Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

2017-10-12 Thread András Piros via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62352/
---

(Updated Oct. 12, 2017, 5:59 p.m.)


Review request for oozie and Robert Kanter.


Repository: oozie-git


Description
---

OOZIE-2406 Completely rewrite GraphGenerator code


Diffs (updated)
-

  client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
74843dc9a3cbb8cef38e97f81e34731f191d9aab 
  core/pom.xml 6f9adb66af9344ac7d2212cdc31aa203ec06c286 
  core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 
059d3cf6dc251b49940af29d82cbdd817043a176 
  core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 
10812c675ebc0cc4aefca9f4a85ef2fc26d143e1 
  core/src/main/java/org/apache/oozie/util/GraphGenerator.java 
6ded2c6dc15c9e8453ff800407ff0324be185f41 
  core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/GraphRenderer.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/OutputFormat.java PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/WorkflowActionNode.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java 
PRE-CREATION 
  core/src/main/resources/oozie-default.xml 
2389b993b7b1769521d6dd0c7386e99e7516210a 
  core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 
ee9ab556c9b6930c406ca5dcd54065cbbebb86c9 
  core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java 
002e925b57cd830ea6d83a87cea4383165116b80 
  core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java 
PRE-CREATION 
  core/src/test/resources/graph-workflow-decision-fork-join.xml PRE-CREATION 
  core/src/test/resources/graph-workflow-simple.xml PRE-CREATION 
  core/src/test/resources/graphWF.xml 6a7b0427a9951835a7533a04b66258ded369d5bf 
  core/src/test/resources/graphWF_26_actions.xml 
a091be0f3559ede195ccc3339adee4478a8da8c0 
  core/src/test/resources/invalidGraphWF.xml  
  docs/src/site/twiki/WebServicesAPI.twiki 
ef3e60242512decd48beb3d8c9ac747b7d128eda 
  pom.xml 0b94484da1c97618e9168cea0ebbfff7f70f723c 
  webapp/src/main/webapp/oozie-console.js 
72c8a198a4ffe60f74a9f700831f65efcb3066c4 


Diff: https://reviews.apache.org/r/62352/diff/11/

Changes: https://reviews.apache.org/r/62352/diff/10-11/


Testing
---

`TestGraphGenerator`, `TestV1JobServlet`


Thanks,

András Piros

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

2017-10-08 Thread András Piros via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62352/
---

(Updated Oct. 8, 2017, 9:39 p.m.)


Review request for oozie and Robert Kanter.


Repository: oozie-git


Description
---

OOZIE-2406 Completely rewrite GraphGenerator code


Diffs (updated)
-

  client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
74843dc9a3cbb8cef38e97f81e34731f191d9aab 
  core/pom.xml 6f9adb66af9344ac7d2212cdc31aa203ec06c286 
  core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 
059d3cf6dc251b49940af29d82cbdd817043a176 
  core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 
10812c675ebc0cc4aefca9f4a85ef2fc26d143e1 
  core/src/main/java/org/apache/oozie/util/GraphGenerator.java 
6ded2c6dc15c9e8453ff800407ff0324be185f41 
  core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/GraphRenderer.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/OutputFormat.java PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/WorkflowActionNode.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java 
PRE-CREATION 
  core/src/main/resources/oozie-default.xml 
2389b993b7b1769521d6dd0c7386e99e7516210a 
  core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 
ee9ab556c9b6930c406ca5dcd54065cbbebb86c9 
  core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java 
002e925b57cd830ea6d83a87cea4383165116b80 
  core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java 
PRE-CREATION 
  core/src/test/resources/graph-workflow-decision-fork-join.xml PRE-CREATION 
  core/src/test/resources/graph-workflow-simple.xml PRE-CREATION 
  core/src/test/resources/graphWF.xml 6a7b0427a9951835a7533a04b66258ded369d5bf 
  core/src/test/resources/graphWF_26_actions.xml 
a091be0f3559ede195ccc3339adee4478a8da8c0 
  docs/src/site/twiki/WebServicesAPI.twiki 
ef3e60242512decd48beb3d8c9ac747b7d128eda 
  pom.xml 0b94484da1c97618e9168cea0ebbfff7f70f723c 
  webapp/src/main/webapp/oozie-console.js 
72c8a198a4ffe60f74a9f700831f65efcb3066c4 


Diff: https://reviews.apache.org/r/62352/diff/10/

Changes: https://reviews.apache.org/r/62352/diff/9-10/


Testing
---

`TestGraphGenerator`, `TestV1JobServlet`


Thanks,

András Piros

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

2017-10-08 Thread András Piros via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62352/
---

(Updated Oct. 8, 2017, 8:08 p.m.)


Review request for oozie and Robert Kanter.


Repository: oozie-git


Description
---

OOZIE-2406 Completely rewrite GraphGenerator code


Diffs (updated)
-

  client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
74843dc9a3cbb8cef38e97f81e34731f191d9aab 
  core/pom.xml 6f9adb66af9344ac7d2212cdc31aa203ec06c286 
  core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 
059d3cf6dc251b49940af29d82cbdd817043a176 
  core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 
10812c675ebc0cc4aefca9f4a85ef2fc26d143e1 
  core/src/main/java/org/apache/oozie/util/GraphGenerator.java 
6ded2c6dc15c9e8453ff800407ff0324be185f41 
  core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/GraphRenderer.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/OutputFormat.java PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/WorkflowActionNode.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java 
PRE-CREATION 
  core/src/main/resources/oozie-default.xml 
2389b993b7b1769521d6dd0c7386e99e7516210a 
  core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 
ee9ab556c9b6930c406ca5dcd54065cbbebb86c9 
  core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java 
002e925b57cd830ea6d83a87cea4383165116b80 
  core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java 
PRE-CREATION 
  core/src/test/resources/graph-workflow-decision-fork-join.xml PRE-CREATION 
  core/src/test/resources/graph-workflow-simple.xml PRE-CREATION 
  core/src/test/resources/graphWF.xml 6a7b0427a9951835a7533a04b66258ded369d5bf 
  core/src/test/resources/graphWF_26_actions.xml 
a091be0f3559ede195ccc3339adee4478a8da8c0 
  core/src/test/resources/invalidGraphWF.xml  
  docs/src/site/twiki/WebServicesAPI.twiki 
ef3e60242512decd48beb3d8c9ac747b7d128eda 
  pom.xml 0b94484da1c97618e9168cea0ebbfff7f70f723c 
  webapp/src/main/webapp/oozie-console.js 
72c8a198a4ffe60f74a9f700831f65efcb3066c4 


Diff: https://reviews.apache.org/r/62352/diff/9/

Changes: https://reviews.apache.org/r/62352/diff/8-9/


Testing
---

`TestGraphGenerator`, `TestV1JobServlet`


Thanks,

András Piros

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

2017-10-08 Thread András Piros 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62352/
---

(Updated Oct. 8, 2017, 10 a.m.)


Review request for oozie and Robert Kanter.


Changes
---

Hopefully last round on review comments.


Repository: oozie-git


Description
---

OOZIE-2406 Completely rewrite GraphGenerator code


Diffs (updated)
-

  client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
74843dc9a3cbb8cef38e97f81e34731f191d9aab 
  core/pom.xml 6f9adb66af9344ac7d2212cdc31aa203ec06c286 
  core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 
059d3cf6dc251b49940af29d82cbdd817043a176 
  core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 
10812c675ebc0cc4aefca9f4a85ef2fc26d143e1 
  core/src/main/java/org/apache/oozie/util/GraphGenerator.java 
6ded2c6dc15c9e8453ff800407ff0324be185f41 
  core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/GraphRenderer.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/OutputFormat.java PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/WorkflowActionNode.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java 
PRE-CREATION 
  core/src/main/resources/oozie-default.xml 
2389b993b7b1769521d6dd0c7386e99e7516210a 
  core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 
ee9ab556c9b6930c406ca5dcd54065cbbebb86c9 
  core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java 
002e925b57cd830ea6d83a87cea4383165116b80 
  core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java 
PRE-CREATION 
  core/src/test/resources/graph-workflow-decision-fork-join.xml PRE-CREATION 
  core/src/test/resources/graph-workflow-simple.xml PRE-CREATION 
  core/src/test/resources/graphWF.xml 6a7b0427a9951835a7533a04b66258ded369d5bf 
  core/src/test/resources/graphWF_26_actions.xml 
a091be0f3559ede195ccc3339adee4478a8da8c0 
  core/src/test/resources/invalidGraphWF.xml  
  docs/src/site/twiki/WebServicesAPI.twiki 
ef3e60242512decd48beb3d8c9ac747b7d128eda 
  pom.xml 0b94484da1c97618e9168cea0ebbfff7f70f723c 
  webapp/src/main/webapp/oozie-console.js 
72c8a198a4ffe60f74a9f700831f65efcb3066c4 


Diff: https://reviews.apache.org/r/62352/diff/8/

Changes: https://reviews.apache.org/r/62352/diff/7-8/


Testing
---

`TestGraphGenerator`, `TestV1JobServlet`


Thanks,

András Piros

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

2017-10-08 Thread András Piros 


> On Oct. 4, 2017, 8:20 a.m., Peter Cseh wrote:
> > examples/src/main/apps/java-main/workflow.xml
> > Lines 17-20 (original), 17-25 (patched)
> > 
> >
> > Is this change intentional?

Reverting.


- András


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62352/#review187064
---


On Oct. 5, 2017, 11:02 a.m., András Piros wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62352/
> ---
> 
> (Updated Oct. 5, 2017, 11:02 a.m.)
> 
> 
> Review request for oozie and Robert Kanter.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> OOZIE-2406 Completely rewrite GraphGenerator code
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
> 74843dc9a3cbb8cef38e97f81e34731f191d9aab 
>   core/pom.xml 6f9adb66af9344ac7d2212cdc31aa203ec06c286 
>   core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 
> 059d3cf6dc251b49940af29d82cbdd817043a176 
>   core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 
> 10812c675ebc0cc4aefca9f4a85ef2fc26d143e1 
>   core/src/main/java/org/apache/oozie/util/GraphGenerator.java 
> 6ded2c6dc15c9e8453ff800407ff0324be185f41 
>   core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/GraphRenderer.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/OutputFormat.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/WorkflowActionNode.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java 
> PRE-CREATION 
>   core/src/main/resources/oozie-default.xml 
> 2389b993b7b1769521d6dd0c7386e99e7516210a 
>   core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 
> ee9ab556c9b6930c406ca5dcd54065cbbebb86c9 
>   core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java 
> 002e925b57cd830ea6d83a87cea4383165116b80 
>   core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java 
> PRE-CREATION 
>   core/src/test/resources/graph-workflow-decision-fork-join.xml PRE-CREATION 
>   core/src/test/resources/graph-workflow-simple.xml PRE-CREATION 
>   core/src/test/resources/graphWF.xml 
> 6a7b0427a9951835a7533a04b66258ded369d5bf 
>   core/src/test/resources/graphWF_26_actions.xml 
> a091be0f3559ede195ccc3339adee4478a8da8c0 
>   core/src/test/resources/invalidGraphWF.xml  
>   docs/src/site/twiki/WebServicesAPI.twiki 
> ef3e60242512decd48beb3d8c9ac747b7d128eda 
>   pom.xml 0b94484da1c97618e9168cea0ebbfff7f70f723c 
>   webapp/src/main/webapp/oozie-console.js 
> 72c8a198a4ffe60f74a9f700831f65efcb3066c4 
> 
> 
> Diff: https://reviews.apache.org/r/62352/diff/7/
> 
> 
> Testing
> ---
> 
> `TestGraphGenerator`, `TestV1JobServlet`
> 
> 
> Thanks,
> 
> András Piros
> 
>

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

2017-10-05 Thread Robert Kanter 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62352/#review187224
---


Fix it, then Ship it!




Looks great!  Just some trivial things.


core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java
Lines 24 (patched)


Let's not use * imports



core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java
Lines 51 (patched)


Extra space before @param



core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java
Lines 67 (patched)


This isn't always a PNG stream, right?



core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java
Lines 39 (patched)


Let's not use * imports



core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java
Lines 53 (patched)


oozie.graphviz.timeout.seconds should be a constant.  No need to 
put a default value here because it's in oozie-default.xml and we want to keep 
only one source of truth on those.
ConfigurationService.getLong(OOZIE_GRAPHVIZ_TIMEOUT_SECONDS);



core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java
Lines 394 (patched)


// format=svg -> OutputFormat.SVG


- Robert Kanter


On Oct. 5, 2017, 11:02 a.m., András Piros wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62352/
> ---
> 
> (Updated Oct. 5, 2017, 11:02 a.m.)
> 
> 
> Review request for oozie and Robert Kanter.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> OOZIE-2406 Completely rewrite GraphGenerator code
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
> 74843dc9a3cbb8cef38e97f81e34731f191d9aab 
>   core/pom.xml 6f9adb66af9344ac7d2212cdc31aa203ec06c286 
>   core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 
> 059d3cf6dc251b49940af29d82cbdd817043a176 
>   core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 
> 10812c675ebc0cc4aefca9f4a85ef2fc26d143e1 
>   core/src/main/java/org/apache/oozie/util/GraphGenerator.java 
> 6ded2c6dc15c9e8453ff800407ff0324be185f41 
>   core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/GraphRenderer.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/OutputFormat.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/WorkflowActionNode.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java 
> PRE-CREATION 
>   core/src/main/resources/oozie-default.xml 
> 2389b993b7b1769521d6dd0c7386e99e7516210a 
>   core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 
> ee9ab556c9b6930c406ca5dcd54065cbbebb86c9 
>   core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java 
> 002e925b57cd830ea6d83a87cea4383165116b80 
>   core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java 
> PRE-CREATION 
>   core/src/test/resources/graph-workflow-decision-fork-join.xml PRE-CREATION 
>   core/src/test/resources/graph-workflow-simple.xml PRE-CREATION 
>   core/src/test/resources/graphWF.xml 
> 6a7b0427a9951835a7533a04b66258ded369d5bf 
>   core/src/test/resources/graphWF_26_actions.xml 
> a091be0f3559ede195ccc3339adee4478a8da8c0 
>   core/src/test/resources/invalidGraphWF.xml  
>   docs/src/site/twiki/WebServicesAPI.twiki 
> ef3e60242512decd48beb3d8c9ac747b7d128eda 
>   pom.xml 0b94484da1c97618e9168cea0ebbfff7f70f723c 
>   webapp/src/main/webapp/oozie-console.js 
> 72c8a198a4ffe60f74a9f700831f65efcb3066c4 
> 
> 
> Diff: https://reviews.apache.org/r/62352/diff/7/
> 
> 
> Testing
> ---
> 
> `TestGraphGenerator`, `TestV1JobServlet`
> 
> 
> Thanks,
> 
> András Piros
> 
>

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

2017-10-05 Thread András Piros 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62352/
---

(Updated Oct. 5, 2017, 11:02 a.m.)


Review request for oozie and Robert Kanter.


Changes
---

JUnit test reorganization, timeout for Graphviz rendering, addressing minor 
comments.


Repository: oozie-git


Description
---

OOZIE-2406 Completely rewrite GraphGenerator code


Diffs (updated)
-

  client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
74843dc9a3cbb8cef38e97f81e34731f191d9aab 
  core/pom.xml 6f9adb66af9344ac7d2212cdc31aa203ec06c286 
  core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 
059d3cf6dc251b49940af29d82cbdd817043a176 
  core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 
10812c675ebc0cc4aefca9f4a85ef2fc26d143e1 
  core/src/main/java/org/apache/oozie/util/GraphGenerator.java 
6ded2c6dc15c9e8453ff800407ff0324be185f41 
  core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/GraphRenderer.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/OutputFormat.java PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/WorkflowActionNode.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java 
PRE-CREATION 
  core/src/main/resources/oozie-default.xml 
2389b993b7b1769521d6dd0c7386e99e7516210a 
  core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 
ee9ab556c9b6930c406ca5dcd54065cbbebb86c9 
  core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java 
002e925b57cd830ea6d83a87cea4383165116b80 
  core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java 
PRE-CREATION 
  core/src/test/resources/graph-workflow-decision-fork-join.xml PRE-CREATION 
  core/src/test/resources/graph-workflow-simple.xml PRE-CREATION 
  core/src/test/resources/graphWF.xml 6a7b0427a9951835a7533a04b66258ded369d5bf 
  core/src/test/resources/graphWF_26_actions.xml 
a091be0f3559ede195ccc3339adee4478a8da8c0 
  core/src/test/resources/invalidGraphWF.xml  
  docs/src/site/twiki/WebServicesAPI.twiki 
ef3e60242512decd48beb3d8c9ac747b7d128eda 
  pom.xml 0b94484da1c97618e9168cea0ebbfff7f70f723c 
  webapp/src/main/webapp/oozie-console.js 
72c8a198a4ffe60f74a9f700831f65efcb3066c4 


Diff: https://reviews.apache.org/r/62352/diff/7/

Changes: https://reviews.apache.org/r/62352/diff/6-7/


Testing
---

`TestGraphGenerator`, `TestV1JobServlet`


Thanks,

András Piros

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

2017-10-05 Thread András Piros 


> On Oct. 2, 2017, 8:11 p.m., Peter Cseh wrote:
> > core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java
> > Lines 148 (patched)
> > 
> >
> > How is this test testing performance?
> 
> András Piros wrote:
> 5 graphs, 50+ nodes each... to render PNG images takes a bit of a time.
> 
> Peter Cseh wrote:
> So we're waiting to generate a bunch of images. We're asserting nothing. 
> Unless we hit the 2-hour timeout, this test would provides no information.

Test case removed.


- András


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62352/#review186874
---


On Oct. 3, 2017, 9:05 p.m., András Piros wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62352/
> ---
> 
> (Updated Oct. 3, 2017, 9:05 p.m.)
> 
> 
> Review request for oozie and Robert Kanter.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> OOZIE-2406 Completely rewrite GraphGenerator code
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
> 74843dc9a3cbb8cef38e97f81e34731f191d9aab 
>   core/pom.xml 6f9adb66af9344ac7d2212cdc31aa203ec06c286 
>   core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 
> 059d3cf6dc251b49940af29d82cbdd817043a176 
>   core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 
> 10812c675ebc0cc4aefca9f4a85ef2fc26d143e1 
>   core/src/main/java/org/apache/oozie/util/GraphGenerator.java 
> 6ded2c6dc15c9e8453ff800407ff0324be185f41 
>   core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/GraphRenderer.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/OutputFormat.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/WorkflowActionNode.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java 
> PRE-CREATION 
>   core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 
> ee9ab556c9b6930c406ca5dcd54065cbbebb86c9 
>   core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java 
> 002e925b57cd830ea6d83a87cea4383165116b80 
>   core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java 
> PRE-CREATION 
>   core/src/test/resources/graphWF.xml 
> 6a7b0427a9951835a7533a04b66258ded369d5bf 
>   core/src/test/resources/graphWF_26_actions.xml 
> a091be0f3559ede195ccc3339adee4478a8da8c0 
>   core/src/test/resources/graphWF_50_actions.xml PRE-CREATION 
>   core/src/test/resources/graphWF_decision_fork_join.xml PRE-CREATION 
>   docs/src/site/twiki/WebServicesAPI.twiki 
> ef3e60242512decd48beb3d8c9ac747b7d128eda 
>   examples/src/main/apps/java-main/workflow.xml 
> 98e01ca92187e1c567686f6c2b4f689bb2a5ef6a 
>   pom.xml 0b94484da1c97618e9168cea0ebbfff7f70f723c 
>   webapp/src/main/webapp/oozie-console.js 
> 72c8a198a4ffe60f74a9f700831f65efcb3066c4 
> 
> 
> Diff: https://reviews.apache.org/r/62352/diff/6/
> 
> 
> Testing
> ---
> 
> `TestGraphGenerator`, `TestV1JobServlet`
> 
> 
> Thanks,
> 
> András Piros
> 
>

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

2017-10-05 Thread András Piros 


> On Oct. 4, 2017, 10:07 a.m., Peter Cseh wrote:
> > core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java
> > Lines 54-56 (patched)
> > 
> >
> > Can this be null?

Test case removed.


> On Oct. 4, 2017, 10:07 a.m., Peter Cseh wrote:
> > core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java
> > Lines 64-65 (patched)
> > 
> >
> > Can this ever be null?

Test case removed.


> On Oct. 4, 2017, 10:07 a.m., Peter Cseh wrote:
> > core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java
> > Lines 108-109 (patched)
> > 
> >
> > Can you add an assert here that validates that it's a dot format and 
> > contains some information?

Yep, the same for SVGs.


> On Oct. 4, 2017, 10:07 a.m., Peter Cseh wrote:
> > core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java
> > Lines 127-140 (patched)
> > 
> >
> > Can you consolidate down the test cases? The testManyNodesX() can have 
> > a basic assertion for PNG, dot and svg.

Reorganized test cases, deleted and renamed a few of them in following classes:
- simple graph: whether graph generation and writing to output formats PNG, DOT 
or SVG is correct
- more sophisticated graph that doesn't have decision, fork, or join nodes: 
test that graph generation is correct
- even more sophisticated graph that has decision, fork, and join nodes: test 
that graph generation is correct


- András


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62352/#review187077
---


On Oct. 3, 2017, 9:05 p.m., András Piros wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62352/
> ---
> 
> (Updated Oct. 3, 2017, 9:05 p.m.)
> 
> 
> Review request for oozie and Robert Kanter.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> OOZIE-2406 Completely rewrite GraphGenerator code
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
> 74843dc9a3cbb8cef38e97f81e34731f191d9aab 
>   core/pom.xml 6f9adb66af9344ac7d2212cdc31aa203ec06c286 
>   core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 
> 059d3cf6dc251b49940af29d82cbdd817043a176 
>   core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 
> 10812c675ebc0cc4aefca9f4a85ef2fc26d143e1 
>   core/src/main/java/org/apache/oozie/util/GraphGenerator.java 
> 6ded2c6dc15c9e8453ff800407ff0324be185f41 
>   core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/GraphRenderer.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/OutputFormat.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/WorkflowActionNode.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java 
> PRE-CREATION 
>   core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 
> ee9ab556c9b6930c406ca5dcd54065cbbebb86c9 
>   core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java 
> 002e925b57cd830ea6d83a87cea4383165116b80 
>   core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java 
> PRE-CREATION 
>   core/src/test/resources/graphWF.xml 
> 6a7b0427a9951835a7533a04b66258ded369d5bf 
>   core/src/test/resources/graphWF_26_actions.xml 
> a091be0f3559ede195ccc3339adee4478a8da8c0 
>   core/src/test/resources/graphWF_50_actions.xml PRE-CREATION 
>   core/src/test/resources/graphWF_decision_fork_join.xml PRE-CREATION 
>   docs/src/site/twiki/WebServicesAPI.twiki 
> ef3e60242512decd48beb3d8c9ac747b7d128eda 
>   examples/src/main/apps/java-main/workflow.xml 
> 98e01ca92187e1c567686f6c2b4f689bb2a5ef6a 
>   pom.xml 0b94484da1c97618e9168cea0ebbfff7f70f723c 
>   webapp/src/main/webapp/oozie-console.js 
> 72c8a198a4ffe60f74a9f700831f65efcb3066c4 
> 
> 
> Diff: https://reviews.apache.org/r/62352/diff/6/
> 
> 
> Testing
> ---
> 
> `TestGraphGenerator`, `TestV1JobServlet`
> 
> 
> Thanks,
> 
> András Piros
> 
>

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

2017-10-04 Thread Peter Cseh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62352/#review187077
---




core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java
Lines 54-56 (patched)


Can this be null?



core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java
Lines 64-65 (patched)


Can this ever be null?



core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java
Lines 108-109 (patched)


Can you add an assert here that validates that it's a dot format and 
contains some information?



core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java
Lines 127-140 (patched)


Can you consolidate down the test cases? The testManyNodesX() can have a 
basic assertion for PNG, dot and svg.


- Peter Cseh


On Oct. 3, 2017, 9:05 p.m., András Piros wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62352/
> ---
> 
> (Updated Oct. 3, 2017, 9:05 p.m.)
> 
> 
> Review request for oozie and Robert Kanter.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> OOZIE-2406 Completely rewrite GraphGenerator code
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
> 74843dc9a3cbb8cef38e97f81e34731f191d9aab 
>   core/pom.xml 6f9adb66af9344ac7d2212cdc31aa203ec06c286 
>   core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 
> 059d3cf6dc251b49940af29d82cbdd817043a176 
>   core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 
> 10812c675ebc0cc4aefca9f4a85ef2fc26d143e1 
>   core/src/main/java/org/apache/oozie/util/GraphGenerator.java 
> 6ded2c6dc15c9e8453ff800407ff0324be185f41 
>   core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/GraphRenderer.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/OutputFormat.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/WorkflowActionNode.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java 
> PRE-CREATION 
>   core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 
> ee9ab556c9b6930c406ca5dcd54065cbbebb86c9 
>   core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java 
> 002e925b57cd830ea6d83a87cea4383165116b80 
>   core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java 
> PRE-CREATION 
>   core/src/test/resources/graphWF.xml 
> 6a7b0427a9951835a7533a04b66258ded369d5bf 
>   core/src/test/resources/graphWF_26_actions.xml 
> a091be0f3559ede195ccc3339adee4478a8da8c0 
>   core/src/test/resources/graphWF_50_actions.xml PRE-CREATION 
>   core/src/test/resources/graphWF_decision_fork_join.xml PRE-CREATION 
>   docs/src/site/twiki/WebServicesAPI.twiki 
> ef3e60242512decd48beb3d8c9ac747b7d128eda 
>   examples/src/main/apps/java-main/workflow.xml 
> 98e01ca92187e1c567686f6c2b4f689bb2a5ef6a 
>   pom.xml 0b94484da1c97618e9168cea0ebbfff7f70f723c 
>   webapp/src/main/webapp/oozie-console.js 
> 72c8a198a4ffe60f74a9f700831f65efcb3066c4 
> 
> 
> Diff: https://reviews.apache.org/r/62352/diff/6/
> 
> 
> Testing
> ---
> 
> `TestGraphGenerator`, `TestV1JobServlet`
> 
> 
> Thanks,
> 
> András Piros
> 
>

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

2017-10-04 Thread Peter Cseh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62352/#review187064
---




examples/src/main/apps/java-main/workflow.xml
Lines 17-20 (original), 17-25 (patched)


Is this change intentional?


- Peter Cseh


On Oct. 3, 2017, 9:05 p.m., András Piros wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62352/
> ---
> 
> (Updated Oct. 3, 2017, 9:05 p.m.)
> 
> 
> Review request for oozie and Robert Kanter.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> OOZIE-2406 Completely rewrite GraphGenerator code
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
> 74843dc9a3cbb8cef38e97f81e34731f191d9aab 
>   core/pom.xml 6f9adb66af9344ac7d2212cdc31aa203ec06c286 
>   core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 
> 059d3cf6dc251b49940af29d82cbdd817043a176 
>   core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 
> 10812c675ebc0cc4aefca9f4a85ef2fc26d143e1 
>   core/src/main/java/org/apache/oozie/util/GraphGenerator.java 
> 6ded2c6dc15c9e8453ff800407ff0324be185f41 
>   core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/GraphRenderer.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/OutputFormat.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/WorkflowActionNode.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java 
> PRE-CREATION 
>   core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 
> ee9ab556c9b6930c406ca5dcd54065cbbebb86c9 
>   core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java 
> 002e925b57cd830ea6d83a87cea4383165116b80 
>   core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java 
> PRE-CREATION 
>   core/src/test/resources/graphWF.xml 
> 6a7b0427a9951835a7533a04b66258ded369d5bf 
>   core/src/test/resources/graphWF_26_actions.xml 
> a091be0f3559ede195ccc3339adee4478a8da8c0 
>   core/src/test/resources/graphWF_50_actions.xml PRE-CREATION 
>   core/src/test/resources/graphWF_decision_fork_join.xml PRE-CREATION 
>   docs/src/site/twiki/WebServicesAPI.twiki 
> ef3e60242512decd48beb3d8c9ac747b7d128eda 
>   examples/src/main/apps/java-main/workflow.xml 
> 98e01ca92187e1c567686f6c2b4f689bb2a5ef6a 
>   pom.xml 0b94484da1c97618e9168cea0ebbfff7f70f723c 
>   webapp/src/main/webapp/oozie-console.js 
> 72c8a198a4ffe60f74a9f700831f65efcb3066c4 
> 
> 
> Diff: https://reviews.apache.org/r/62352/diff/6/
> 
> 
> Testing
> ---
> 
> `TestGraphGenerator`, `TestV1JobServlet`
> 
> 
> Thanks,
> 
> András Piros
> 
>

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

2017-10-04 Thread Peter Cseh 


> On Oct. 2, 2017, 8:11 p.m., Peter Cseh wrote:
> > core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java
> > Lines 148 (patched)
> > 
> >
> > How is this test testing performance?
> 
> András Piros wrote:
> 5 graphs, 50+ nodes each... to render PNG images takes a bit of a time.

So we're waiting to generate a bunch of images. We're asserting nothing. Unless 
we hit the 2-hour timeout, this test would provides no information.


- Peter


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62352/#review186874
---


On Oct. 3, 2017, 9:05 p.m., András Piros wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62352/
> ---
> 
> (Updated Oct. 3, 2017, 9:05 p.m.)
> 
> 
> Review request for oozie and Robert Kanter.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> OOZIE-2406 Completely rewrite GraphGenerator code
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
> 74843dc9a3cbb8cef38e97f81e34731f191d9aab 
>   core/pom.xml 6f9adb66af9344ac7d2212cdc31aa203ec06c286 
>   core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 
> 059d3cf6dc251b49940af29d82cbdd817043a176 
>   core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 
> 10812c675ebc0cc4aefca9f4a85ef2fc26d143e1 
>   core/src/main/java/org/apache/oozie/util/GraphGenerator.java 
> 6ded2c6dc15c9e8453ff800407ff0324be185f41 
>   core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/GraphRenderer.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/OutputFormat.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/WorkflowActionNode.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java 
> PRE-CREATION 
>   core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 
> ee9ab556c9b6930c406ca5dcd54065cbbebb86c9 
>   core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java 
> 002e925b57cd830ea6d83a87cea4383165116b80 
>   core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java 
> PRE-CREATION 
>   core/src/test/resources/graphWF.xml 
> 6a7b0427a9951835a7533a04b66258ded369d5bf 
>   core/src/test/resources/graphWF_26_actions.xml 
> a091be0f3559ede195ccc3339adee4478a8da8c0 
>   core/src/test/resources/graphWF_50_actions.xml PRE-CREATION 
>   core/src/test/resources/graphWF_decision_fork_join.xml PRE-CREATION 
>   docs/src/site/twiki/WebServicesAPI.twiki 
> ef3e60242512decd48beb3d8c9ac747b7d128eda 
>   examples/src/main/apps/java-main/workflow.xml 
> 98e01ca92187e1c567686f6c2b4f689bb2a5ef6a 
>   pom.xml 0b94484da1c97618e9168cea0ebbfff7f70f723c 
>   webapp/src/main/webapp/oozie-console.js 
> 72c8a198a4ffe60f74a9f700831f65efcb3066c4 
> 
> 
> Diff: https://reviews.apache.org/r/62352/diff/6/
> 
> 
> Testing
> ---
> 
> `TestGraphGenerator`, `TestV1JobServlet`
> 
> 
> Thanks,
> 
> András Piros
> 
>

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

2017-10-03 Thread András Piros 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62352/
---

(Updated Oct. 3, 2017, 9:05 p.m.)


Review request for oozie and Robert Kanter.


Changes
---

Addressed another comment round.


Repository: oozie-git


Description
---

OOZIE-2406 Completely rewrite GraphGenerator code


Diffs (updated)
-

  client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
74843dc9a3cbb8cef38e97f81e34731f191d9aab 
  core/pom.xml 6f9adb66af9344ac7d2212cdc31aa203ec06c286 
  core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 
059d3cf6dc251b49940af29d82cbdd817043a176 
  core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 
10812c675ebc0cc4aefca9f4a85ef2fc26d143e1 
  core/src/main/java/org/apache/oozie/util/GraphGenerator.java 
6ded2c6dc15c9e8453ff800407ff0324be185f41 
  core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/GraphRenderer.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/OutputFormat.java PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/WorkflowActionNode.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java 
PRE-CREATION 
  core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 
ee9ab556c9b6930c406ca5dcd54065cbbebb86c9 
  core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java 
002e925b57cd830ea6d83a87cea4383165116b80 
  core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java 
PRE-CREATION 
  core/src/test/resources/graphWF.xml 6a7b0427a9951835a7533a04b66258ded369d5bf 
  core/src/test/resources/graphWF_26_actions.xml 
a091be0f3559ede195ccc3339adee4478a8da8c0 
  core/src/test/resources/graphWF_50_actions.xml PRE-CREATION 
  core/src/test/resources/graphWF_decision_fork_join.xml PRE-CREATION 
  docs/src/site/twiki/WebServicesAPI.twiki 
ef3e60242512decd48beb3d8c9ac747b7d128eda 
  examples/src/main/apps/java-main/workflow.xml 
98e01ca92187e1c567686f6c2b4f689bb2a5ef6a 
  pom.xml 0b94484da1c97618e9168cea0ebbfff7f70f723c 
  webapp/src/main/webapp/oozie-console.js 
72c8a198a4ffe60f74a9f700831f65efcb3066c4 


Diff: https://reviews.apache.org/r/62352/diff/6/

Changes: https://reviews.apache.org/r/62352/diff/5-6/


Testing
---

`TestGraphGenerator`, `TestV1JobServlet`


Thanks,

András Piros

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

2017-10-03 Thread András Piros 


> On Oct. 2, 2017, 8:11 p.m., Peter Cseh wrote:
> > core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java
> > Lines 365 (patched)
> > 
> >
> > UTF-8

This is a `Locale` instance, not an `Encoding`, or a `String`, or a `Charset` 
one.


> On Oct. 2, 2017, 8:11 p.m., Peter Cseh wrote:
> > core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java
> > Lines 366 (patched)
> > 
> >
> > UTF-8

This is a `Locale` instance, not an `Encoding`, or a `String`, or a `Charset` 
one.


> On Oct. 2, 2017, 8:11 p.m., Peter Cseh wrote:
> > core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java
> > Lines 148 (patched)
> > 
> >
> > How is this test testing performance?

5 graphs, 50+ nodes each... to render PNG images takes a bit of a time.


- András


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62352/#review186874
---


On Oct. 2, 2017, 9:04 p.m., András Piros wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62352/
> ---
> 
> (Updated Oct. 2, 2017, 9:04 p.m.)
> 
> 
> Review request for oozie and Robert Kanter.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> OOZIE-2406 Completely rewrite GraphGenerator code
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
> 74843dc9a3cbb8cef38e97f81e34731f191d9aab 
>   core/pom.xml 6f9adb66af9344ac7d2212cdc31aa203ec06c286 
>   core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 
> 059d3cf6dc251b49940af29d82cbdd817043a176 
>   core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 
> 10812c675ebc0cc4aefca9f4a85ef2fc26d143e1 
>   core/src/main/java/org/apache/oozie/util/GraphGenerator.java 
> 6ded2c6dc15c9e8453ff800407ff0324be185f41 
>   core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/GraphRenderer.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/OutputFormat.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/WorkflowActionNode.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java 
> PRE-CREATION 
>   core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 
> ee9ab556c9b6930c406ca5dcd54065cbbebb86c9 
>   core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java 
> 002e925b57cd830ea6d83a87cea4383165116b80 
>   core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java 
> PRE-CREATION 
>   core/src/test/resources/graphWF.xml 
> 6a7b0427a9951835a7533a04b66258ded369d5bf 
>   core/src/test/resources/graphWF_26_actions.xml 
> a091be0f3559ede195ccc3339adee4478a8da8c0 
>   core/src/test/resources/graphWF_50_actions.xml PRE-CREATION 
>   core/src/test/resources/graphWF_decision_fork_join.xml PRE-CREATION 
>   docs/src/site/twiki/WebServicesAPI.twiki 
> ef3e60242512decd48beb3d8c9ac747b7d128eda 
>   examples/src/main/apps/java-main/workflow.xml 
> 98e01ca92187e1c567686f6c2b4f689bb2a5ef6a 
>   pom.xml 0b94484da1c97618e9168cea0ebbfff7f70f723c 
>   webapp/src/main/webapp/oozie-console.js 
> 72c8a198a4ffe60f74a9f700831f65efcb3066c4 
> 
> 
> Diff: https://reviews.apache.org/r/62352/diff/5/
> 
> 
> Testing
> ---
> 
> `TestGraphGenerator`, `TestV1JobServlet`
> 
> 
> Thanks,
> 
> András Piros
> 
>

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

2017-10-03 Thread András Piros 


> On Oct. 3, 2017, 11:12 a.m., Peter Bacsko wrote:
> > core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java
> > Lines 170-173 (patched)
> > 
> >
> > To me this looks weird. We have a single threaded executor and we wait 
> > without any kind of timeout. What does this method accomplish by rendering 
> > the PNG like that?

Added a comment to the field `GraphvizRenderer#EXECUTOR_SERVICE`.


> On Oct. 3, 2017, 11:12 a.m., Peter Bacsko wrote:
> > core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java
> > Lines 161 (patched)
> > 
> >
> > Why do we have to explicitly null this out? Is this class ever reused? 
> > Can't see a setter for "out".
> > 
> > I'm also concerned about closing the output stream here. This should be 
> > the caller's responsibility.

Left from old code. Nevermind, removed, and the code still works.


> On Oct. 3, 2017, 11:12 a.m., Peter Bacsko wrote:
> > core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java
> > Lines 83 (patched)
> > 
> >
> > Please also print the stack trace to improve debuggability

I'm not into having stack trace, making the log message clearer instead.


> On Oct. 3, 2017, 11:12 a.m., Peter Bacsko wrote:
> > core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java
> > Lines 96 (patched)
> > 
> >
> > Please also print the stack trace to improve debuggability

I'm not into having stack trace, making the log message clearer instead.


> On Oct. 3, 2017, 11:12 a.m., Peter Bacsko wrote:
> > core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java
> > Lines 111 (patched)
> > 
> >
> > Please also print the stack trace to improve debuggability

I'm not into having stack trace, making the log message clearer instead.


- András


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62352/#review186944
---


On Oct. 2, 2017, 9:04 p.m., András Piros wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62352/
> ---
> 
> (Updated Oct. 2, 2017, 9:04 p.m.)
> 
> 
> Review request for oozie and Robert Kanter.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> OOZIE-2406 Completely rewrite GraphGenerator code
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
> 74843dc9a3cbb8cef38e97f81e34731f191d9aab 
>   core/pom.xml 6f9adb66af9344ac7d2212cdc31aa203ec06c286 
>   core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 
> 059d3cf6dc251b49940af29d82cbdd817043a176 
>   core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 
> 10812c675ebc0cc4aefca9f4a85ef2fc26d143e1 
>   core/src/main/java/org/apache/oozie/util/GraphGenerator.java 
> 6ded2c6dc15c9e8453ff800407ff0324be185f41 
>   core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/GraphRenderer.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/OutputFormat.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/WorkflowActionNode.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java 
> PRE-CREATION 
>   core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 
> ee9ab556c9b6930c406ca5dcd54065cbbebb86c9 
>   core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java 
> 002e925b57cd830ea6d83a87cea4383165116b80 
>   core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java 
> PRE-CREATION 
>   core/src/test/resources/graphWF.xml 
> 6a7b0427a9951835a7533a04b66258ded369d5bf 
>   core/src/test/resources/graphWF_26_actions.xml 
> a091be0f3559ede195ccc3339adee4478a8da8c0 
>   core/src/test/resources/graphWF_50_actions.xml PRE-CREATION 
>   core/src/test/resources/graphWF_decision_fork_join.xml PRE-CREATION 
>   docs/src/site/twiki/WebServicesAPI.twiki 
> ef3e60242512decd48beb3d8c9ac747b7d128eda 
>   examples/src/main/apps/java-main/workflow.xml 
> 98e01ca92187e1c567686f6c2b4f689bb2a5ef6a 
>   pom.xml 0b94484da1c97618e9168cea0ebbfff7f70f723c 
>   webapp/src/main/webapp/oozie-console.js 
> 72c8a198a4ffe60f74a9f700831f65efcb3066c4 
> 
> 
> Diff: https://reviews.apache.org/r/62352/diff/5/
> 
> 
>

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

2017-10-03 Thread Peter Bacsko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62352/#review186944
---




core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java
Lines 30 (patched)


Import



core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java
Lines 60 (patched)


I would rather call this getShape(). The word "calculate" is telling me 
that we do some math as well.



core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java
Lines 90 (patched)


getColor()



core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java
Lines 125 (patched)


What do we "ensure" here? To me this feels like another get() method with 
some extra logic.



core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java
Lines 170-173 (patched)


To me this looks weird. We have a single threaded executor and we wait 
without any kind of timeout. What does this method accomplish by rendering the 
PNG like that?



core/src/main/java/org/apache/oozie/util/graph/WorkflowActionNode.java
Lines 27 (patched)


We store this class in a hashmap and there is no hashCode() and equals() 
defined for this class. Could you generate them?



core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java
Lines 61 (patched)


Could you just add a short comment like "// nop" if the method body is 
intentionally empty?



core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java
Lines 92-100 (patched)


Can we live without "continue"? If we can, just remove it and put this 
block under an "if (child != null)" branch.



core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java
Lines 161 (patched)


Why do we have to explicitly null this out? Is this class ever reused? 
Can't see a setter for "out".

I'm also concerned about closing the output stream here. This should be the 
caller's responsibility.



core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java
Lines 83 (patched)


Please also print the stack trace to improve debuggability



core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java
Lines 96 (patched)


Please also print the stack trace to improve debuggability



core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java
Lines 111 (patched)


Please also print the stack trace to improve debuggability


- Peter Bacsko


On okt. 2, 2017, 9:04 du, András Piros wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62352/
> ---
> 
> (Updated okt. 2, 2017, 9:04 du)
> 
> 
> Review request for oozie and Robert Kanter.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> OOZIE-2406 Completely rewrite GraphGenerator code
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
> 74843dc9a3cbb8cef38e97f81e34731f191d9aab 
>   core/pom.xml 6f9adb66af9344ac7d2212cdc31aa203ec06c286 
>   core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 
> 059d3cf6dc251b49940af29d82cbdd817043a176 
>   core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 
> 10812c675ebc0cc4aefca9f4a85ef2fc26d143e1 
>   core/src/main/java/org/apache/oozie/util/GraphGenerator.java 
> 6ded2c6dc15c9e8453ff800407ff0324be185f41 
>   core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/GraphRenderer.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/OutputFormat.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/WorkflowActionNode.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java 
> PRE-CREATION 
>   core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 
> ee9ab556c9b6930c406ca5dcd54065cbbebb86c9 
>   core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java 
> 002e925b57cd830ea6d83a87cea4383165116b80 
>

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

2017-10-02 Thread András Piros 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62352/
---

(Updated Oct. 2, 2017, 9:04 p.m.)


Review request for oozie and Robert Kanter.


Changes
---

Addressing Geza's review comments.


Repository: oozie-git


Description
---

OOZIE-2406 Completely rewrite GraphGenerator code


Diffs (updated)
-

  client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
74843dc9a3cbb8cef38e97f81e34731f191d9aab 
  core/pom.xml 6f9adb66af9344ac7d2212cdc31aa203ec06c286 
  core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 
059d3cf6dc251b49940af29d82cbdd817043a176 
  core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 
10812c675ebc0cc4aefca9f4a85ef2fc26d143e1 
  core/src/main/java/org/apache/oozie/util/GraphGenerator.java 
6ded2c6dc15c9e8453ff800407ff0324be185f41 
  core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/GraphRenderer.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/OutputFormat.java PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/WorkflowActionNode.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java 
PRE-CREATION 
  core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 
ee9ab556c9b6930c406ca5dcd54065cbbebb86c9 
  core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java 
002e925b57cd830ea6d83a87cea4383165116b80 
  core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java 
PRE-CREATION 
  core/src/test/resources/graphWF.xml 6a7b0427a9951835a7533a04b66258ded369d5bf 
  core/src/test/resources/graphWF_26_actions.xml 
a091be0f3559ede195ccc3339adee4478a8da8c0 
  core/src/test/resources/graphWF_50_actions.xml PRE-CREATION 
  core/src/test/resources/graphWF_decision_fork_join.xml PRE-CREATION 
  docs/src/site/twiki/WebServicesAPI.twiki 
ef3e60242512decd48beb3d8c9ac747b7d128eda 
  examples/src/main/apps/java-main/workflow.xml 
98e01ca92187e1c567686f6c2b4f689bb2a5ef6a 
  pom.xml 0b94484da1c97618e9168cea0ebbfff7f70f723c 
  webapp/src/main/webapp/oozie-console.js 
72c8a198a4ffe60f74a9f700831f65efcb3066c4 


Diff: https://reviews.apache.org/r/62352/diff/5/

Changes: https://reviews.apache.org/r/62352/diff/4-5/


Testing
---

`TestGraphGenerator`, `TestV1JobServlet`


Thanks,

András Piros

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

2017-10-02 Thread András Piros 


> On Oct. 2, 2017, 6:43 p.m., Peter Cseh wrote:
> > core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java
> > Lines 202 (patched)
> > 
> >
> > UTF-8

This is a `Locale` instance, not an `Encoding`, or a `String`, or a `Charset` 
one.


> On Oct. 2, 2017, 6:43 p.m., Peter Cseh wrote:
> > core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java
> > Lines 211 (patched)
> > 
> >
> > UTF-8

This is a `Locale` instance, not an `Encoding`, or a `String`, or a `Charset` 
one.


> On Oct. 2, 2017, 6:43 p.m., Peter Cseh wrote:
> > core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java
> > Lines 219 (patched)
> > 
> >
> > We should stick to UTF-8 as a locale.

This is a `Locale` instance, not an `Encoding`, or a `String`, or a `Charset` 
one.


> On Oct. 2, 2017, 6:43 p.m., Peter Cseh wrote:
> > core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java
> > Lines 226 (patched)
> > 
> >
> > UTF-8

This is a `Locale` instance, not an `Encoding`, or a `String`, or a `Charset` 
one.


> On Oct. 2, 2017, 6:43 p.m., Peter Cseh wrote:
> > core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java
> > Lines 233 (patched)
> > 
> >
> > UTF-8

This is a `Locale` instance, not an `Encoding`, or a `String`, or a `Charset` 
one.


> On Oct. 2, 2017, 6:43 p.m., Peter Cseh wrote:
> > core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java
> > Lines 242 (patched)
> > 
> >
> > UTF-8

This is a `Locale` instance, not an `Encoding`, or a `String`, or a `Charset` 
one.


- András


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62352/#review186863
---


On Oct. 2, 2017, 4:41 p.m., András Piros wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62352/
> ---
> 
> (Updated Oct. 2, 2017, 4:41 p.m.)
> 
> 
> Review request for oozie and Robert Kanter.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> OOZIE-2406 Completely rewrite GraphGenerator code
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
> 74843dc9a3cbb8cef38e97f81e34731f191d9aab 
>   core/pom.xml 6f9adb66af9344ac7d2212cdc31aa203ec06c286 
>   core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 
> 059d3cf6dc251b49940af29d82cbdd817043a176 
>   core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 
> 10812c675ebc0cc4aefca9f4a85ef2fc26d143e1 
>   core/src/main/java/org/apache/oozie/util/GraphGenerator.java 
> 6ded2c6dc15c9e8453ff800407ff0324be185f41 
>   core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/GraphRenderer.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/OutputFormat.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/WorkflowActionNode.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java 
> PRE-CREATION 
>   core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 
> ee9ab556c9b6930c406ca5dcd54065cbbebb86c9 
>   core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java 
> 002e925b57cd830ea6d83a87cea4383165116b80 
>   core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java 
> PRE-CREATION 
>   core/src/test/resources/graphWF.xml 
> 6a7b0427a9951835a7533a04b66258ded369d5bf 
>   core/src/test/resources/graphWF_26_actions.xml 
> a091be0f3559ede195ccc3339adee4478a8da8c0 
>   core/src/test/resources/graphWF_50_actions.xml PRE-CREATION 
>   docs/src/site/twiki/WebServicesAPI.twiki 
> ef3e60242512decd48beb3d8c9ac747b7d128eda 
>   examples/src/main/apps/java-main/workflow.xml 
> 98e01ca92187e1c567686f6c2b4f689bb2a5ef6a 
>   pom.xml 0b94484da1c97618e9168cea0ebbfff7f70f723c 
>   webapp/src/main/webapp/oozie-console.js 
> 72c8a198a4ffe60f74a9f700831f65efcb3066c4 
> 
> 
> Diff: https://reviews.apache.org/r/62352/diff/4/
> 
> 
> Testing
> ---
> 
> `TestGraphGenerator`, `TestV1JobServlet`
> 
> 
> Thanks,
> 
> András Piros
> 
>

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

2017-10-02 Thread Peter Cseh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62352/#review186874
---




core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java
Lines 335 (patched)


Shouldn't an exception be raised here?



core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java
Lines 365 (patched)


UTF-8



core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java
Lines 366 (patched)


UTF-8



core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java
Lines 86-88 (patched)


Constants



core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java
Lines 202-205 (patched)


extract something like createRenderer



core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java
Lines 148 (patched)


How is this test testing performance?


- Peter Cseh


On Oct. 2, 2017, 4:41 p.m., András Piros wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62352/
> ---
> 
> (Updated Oct. 2, 2017, 4:41 p.m.)
> 
> 
> Review request for oozie and Robert Kanter.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> OOZIE-2406 Completely rewrite GraphGenerator code
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
> 74843dc9a3cbb8cef38e97f81e34731f191d9aab 
>   core/pom.xml 6f9adb66af9344ac7d2212cdc31aa203ec06c286 
>   core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 
> 059d3cf6dc251b49940af29d82cbdd817043a176 
>   core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 
> 10812c675ebc0cc4aefca9f4a85ef2fc26d143e1 
>   core/src/main/java/org/apache/oozie/util/GraphGenerator.java 
> 6ded2c6dc15c9e8453ff800407ff0324be185f41 
>   core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/GraphRenderer.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/OutputFormat.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/WorkflowActionNode.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java 
> PRE-CREATION 
>   core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 
> ee9ab556c9b6930c406ca5dcd54065cbbebb86c9 
>   core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java 
> 002e925b57cd830ea6d83a87cea4383165116b80 
>   core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java 
> PRE-CREATION 
>   core/src/test/resources/graphWF.xml 
> 6a7b0427a9951835a7533a04b66258ded369d5bf 
>   core/src/test/resources/graphWF_26_actions.xml 
> a091be0f3559ede195ccc3339adee4478a8da8c0 
>   core/src/test/resources/graphWF_50_actions.xml PRE-CREATION 
>   docs/src/site/twiki/WebServicesAPI.twiki 
> ef3e60242512decd48beb3d8c9ac747b7d128eda 
>   examples/src/main/apps/java-main/workflow.xml 
> 98e01ca92187e1c567686f6c2b4f689bb2a5ef6a 
>   pom.xml 0b94484da1c97618e9168cea0ebbfff7f70f723c 
>   webapp/src/main/webapp/oozie-console.js 
> 72c8a198a4ffe60f74a9f700831f65efcb3066c4 
> 
> 
> Diff: https://reviews.apache.org/r/62352/diff/4/
> 
> 
> Testing
> ---
> 
> `TestGraphGenerator`, `TestV1JobServlet`
> 
> 
> Thanks,
> 
> András Piros
> 
>

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

2017-10-02 Thread Peter Cseh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62352/#review186863
---




core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java
Lines 311-313 (patched)


Extract function.



core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java
Line 303 (original), 315-337 (patched)


setContentType()



core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java
Lines 121-168 (patched)


These three methods look very similar. Can something be extracted from it?



core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java
Lines 202 (patched)


UTF-8



core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java
Lines 211 (patched)


UTF-8



core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java
Lines 219 (patched)


We should stick to UTF-8 as a locale.



core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java
Lines 226 (patched)


UTF-8



core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java
Lines 233 (patched)


UTF-8



core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java
Lines 242 (patched)


UTF-8



core/src/test/resources/graphWF_26_actions.xml
Lines 1-7 (original), 1-7 (patched)


Can you add workflows with forks and decision nodes in them to the test?


- Peter Cseh


On Oct. 2, 2017, 4:41 p.m., András Piros wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62352/
> ---
> 
> (Updated Oct. 2, 2017, 4:41 p.m.)
> 
> 
> Review request for oozie and Robert Kanter.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> OOZIE-2406 Completely rewrite GraphGenerator code
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
> 74843dc9a3cbb8cef38e97f81e34731f191d9aab 
>   core/pom.xml 6f9adb66af9344ac7d2212cdc31aa203ec06c286 
>   core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 
> 059d3cf6dc251b49940af29d82cbdd817043a176 
>   core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 
> 10812c675ebc0cc4aefca9f4a85ef2fc26d143e1 
>   core/src/main/java/org/apache/oozie/util/GraphGenerator.java 
> 6ded2c6dc15c9e8453ff800407ff0324be185f41 
>   core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/GraphRenderer.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/OutputFormat.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/WorkflowActionNode.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java 
> PRE-CREATION 
>   core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 
> ee9ab556c9b6930c406ca5dcd54065cbbebb86c9 
>   core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java 
> 002e925b57cd830ea6d83a87cea4383165116b80 
>   core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java 
> PRE-CREATION 
>   core/src/test/resources/graphWF.xml 
> 6a7b0427a9951835a7533a04b66258ded369d5bf 
>   core/src/test/resources/graphWF_26_actions.xml 
> a091be0f3559ede195ccc3339adee4478a8da8c0 
>   core/src/test/resources/graphWF_50_actions.xml PRE-CREATION 
>   docs/src/site/twiki/WebServicesAPI.twiki 
> ef3e60242512decd48beb3d8c9ac747b7d128eda 
>   examples/src/main/apps/java-main/workflow.xml 
> 98e01ca92187e1c567686f6c2b4f689bb2a5ef6a 
>   pom.xml 0b94484da1c97618e9168cea0ebbfff7f70f723c 
>   webapp/src/main/webapp/oozie-console.js 
> 72c8a198a4ffe60f74a9f700831f65efcb3066c4 
> 
> 
> Diff: https://reviews.apache.org/r/62352/diff/4/
> 
> 
> Testing
> ---
> 
> `TestGraphGenerator`, `TestV1JobServlet`
> 
> 
> Thanks,
> 
> András Piros
> 
>

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

2017-10-02 Thread András Piros 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62352/
---

(Updated Oct. 2, 2017, 4:41 p.m.)


Review request for oozie and Robert Kanter.


Changes
---

Addressing FindBugs error.


Repository: oozie-git


Description
---

OOZIE-2406 Completely rewrite GraphGenerator code


Diffs (updated)
-

  client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
74843dc9a3cbb8cef38e97f81e34731f191d9aab 
  core/pom.xml 6f9adb66af9344ac7d2212cdc31aa203ec06c286 
  core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 
059d3cf6dc251b49940af29d82cbdd817043a176 
  core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 
10812c675ebc0cc4aefca9f4a85ef2fc26d143e1 
  core/src/main/java/org/apache/oozie/util/GraphGenerator.java 
6ded2c6dc15c9e8453ff800407ff0324be185f41 
  core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/GraphRenderer.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/OutputFormat.java PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/WorkflowActionNode.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java 
PRE-CREATION 
  core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 
ee9ab556c9b6930c406ca5dcd54065cbbebb86c9 
  core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java 
002e925b57cd830ea6d83a87cea4383165116b80 
  core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java 
PRE-CREATION 
  core/src/test/resources/graphWF.xml 6a7b0427a9951835a7533a04b66258ded369d5bf 
  core/src/test/resources/graphWF_26_actions.xml 
a091be0f3559ede195ccc3339adee4478a8da8c0 
  core/src/test/resources/graphWF_50_actions.xml PRE-CREATION 
  docs/src/site/twiki/WebServicesAPI.twiki 
ef3e60242512decd48beb3d8c9ac747b7d128eda 
  examples/src/main/apps/java-main/workflow.xml 
98e01ca92187e1c567686f6c2b4f689bb2a5ef6a 
  pom.xml 0b94484da1c97618e9168cea0ebbfff7f70f723c 
  webapp/src/main/webapp/oozie-console.js 
72c8a198a4ffe60f74a9f700831f65efcb3066c4 


Diff: https://reviews.apache.org/r/62352/diff/4/

Changes: https://reviews.apache.org/r/62352/diff/3-4/


Testing
---

`TestGraphGenerator`, `TestV1JobServlet`


Thanks,

András Piros

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

2017-10-02 Thread András Piros 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62352/
---

(Updated Oct. 2, 2017, 11:59 a.m.)


Review request for oozie and Robert Kanter.


Changes
---

Updating based on review comments.


Repository: oozie-git


Description
---

OOZIE-2406 Completely rewrite GraphGenerator code


Diffs (updated)
-

  client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
74843dc9a3cbb8cef38e97f81e34731f191d9aab 
  core/pom.xml 6f9adb66af9344ac7d2212cdc31aa203ec06c286 
  core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 
059d3cf6dc251b49940af29d82cbdd817043a176 
  core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 
10812c675ebc0cc4aefca9f4a85ef2fc26d143e1 
  core/src/main/java/org/apache/oozie/util/GraphGenerator.java 
6ded2c6dc15c9e8453ff800407ff0324be185f41 
  core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/GraphRenderer.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/OutputFormat.java PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/WorkflowActionNode.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java 
PRE-CREATION 
  core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 
ee9ab556c9b6930c406ca5dcd54065cbbebb86c9 
  core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java 
002e925b57cd830ea6d83a87cea4383165116b80 
  core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java 
PRE-CREATION 
  core/src/test/resources/graphWF.xml 6a7b0427a9951835a7533a04b66258ded369d5bf 
  core/src/test/resources/graphWF_26_actions.xml 
a091be0f3559ede195ccc3339adee4478a8da8c0 
  core/src/test/resources/graphWF_50_actions.xml PRE-CREATION 
  docs/src/site/twiki/WebServicesAPI.twiki 
ef3e60242512decd48beb3d8c9ac747b7d128eda 
  examples/src/main/apps/java-main/workflow.xml 
98e01ca92187e1c567686f6c2b4f689bb2a5ef6a 
  pom.xml 0b94484da1c97618e9168cea0ebbfff7f70f723c 
  webapp/src/main/webapp/oozie-console.js 
72c8a198a4ffe60f74a9f700831f65efcb3066c4 


Diff: https://reviews.apache.org/r/62352/diff/3/

Changes: https://reviews.apache.org/r/62352/diff/2-3/


Testing
---

`TestGraphGenerator`, `TestV1JobServlet`


Thanks,

András Piros

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

2017-10-02 Thread András Piros 


> On Sept. 18, 2017, 11:39 p.m., Robert Kanter wrote:
> > core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java
> > Lines 47 (patched)
> > 
> >
> > Should we make this configurable via oozie-site?

Removed totally.


> On Sept. 18, 2017, 11:39 p.m., Robert Kanter wrote:
> > core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java
> > Lines 150 (patched)
> > 
> >
> > Isn't this going to cause an NPE when using Jung because JungRenderer 
> > returns ``null`` for ``renderDot()``?  We should probably check if ``dot == 
> > null`` and do something nicer.

As `JungRenderer` is removed, this is not an issue anymore. Anyway, introducing 
nullcheck.


- András


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62352/#review185629
---


On Sept. 17, 2017, 5:28 p.m., András Piros wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62352/
> ---
> 
> (Updated Sept. 17, 2017, 5:28 p.m.)
> 
> 
> Review request for oozie and Robert Kanter.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> OOZIE-2406 Completely rewrite GraphGenerator code
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
> 74843dc9a3cbb8cef38e97f81e34731f191d9aab 
>   core/pom.xml b0809546d048c2acbcbea8af5f8947eb0eaece9e 
>   core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 
> 10812c675ebc0cc4aefca9f4a85ef2fc26d143e1 
>   core/src/main/java/org/apache/oozie/util/GraphGenerator.java 
> 6ded2c6dc15c9e8453ff800407ff0324be185f41 
>   core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/GraphRenderer.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/JungRenderer.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/OutputFormat.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/WorkflowActionNode.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java 
> PRE-CREATION 
>   core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 
> ee9ab556c9b6930c406ca5dcd54065cbbebb86c9 
>   core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java 
> 002e925b57cd830ea6d83a87cea4383165116b80 
>   core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java 
> PRE-CREATION 
>   core/src/test/resources/graphWF.xml 
> 6a7b0427a9951835a7533a04b66258ded369d5bf 
>   core/src/test/resources/graphWF_26_actions.xml 
> a091be0f3559ede195ccc3339adee4478a8da8c0 
>   core/src/test/resources/graphWF_50_actions.xml PRE-CREATION 
>   docs/src/site/twiki/WebServicesAPI.twiki 
> ef3e60242512decd48beb3d8c9ac747b7d128eda 
>   pom.xml db18f30814b9b6a73ba872c2cd7946692d0b876b 
> 
> 
> Diff: https://reviews.apache.org/r/62352/diff/2/
> 
> 
> Testing
> ---
> 
> `TestGraphGenerator`, `TestV1JobServlet`
> 
> 
> Thanks,
> 
> András Piros
> 
>

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

2017-09-17 Thread András Piros 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62352/
---

(Updated Sept. 17, 2017, 5:28 p.m.)


Review request for oozie and Robert Kanter.


Changes
---

Addressing review comments, and extending functionality based on JIRA.


Repository: oozie-git


Description
---

OOZIE-2406 Completely rewrite GraphGenerator code


Diffs (updated)
-

  client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
74843dc9a3cbb8cef38e97f81e34731f191d9aab 
  core/pom.xml b0809546d048c2acbcbea8af5f8947eb0eaece9e 
  core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 
10812c675ebc0cc4aefca9f4a85ef2fc26d143e1 
  core/src/main/java/org/apache/oozie/util/GraphGenerator.java 
6ded2c6dc15c9e8453ff800407ff0324be185f41 
  core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/GraphRenderer.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/JungRenderer.java PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/OutputFormat.java PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/WorkflowActionNode.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java 
PRE-CREATION 
  core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 
ee9ab556c9b6930c406ca5dcd54065cbbebb86c9 
  core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java 
002e925b57cd830ea6d83a87cea4383165116b80 
  core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java 
PRE-CREATION 
  core/src/test/resources/graphWF.xml 6a7b0427a9951835a7533a04b66258ded369d5bf 
  core/src/test/resources/graphWF_26_actions.xml 
a091be0f3559ede195ccc3339adee4478a8da8c0 
  core/src/test/resources/graphWF_50_actions.xml PRE-CREATION 
  docs/src/site/twiki/WebServicesAPI.twiki 
ef3e60242512decd48beb3d8c9ac747b7d128eda 
  pom.xml db18f30814b9b6a73ba872c2cd7946692d0b876b 


Diff: https://reviews.apache.org/r/62352/diff/2/

Changes: https://reviews.apache.org/r/62352/diff/1-2/


Testing
---

`TestGraphGenerator`, `TestV1JobServlet`


Thanks,

András Piros

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

2017-09-17 Thread András Piros 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62352/
---

(Updated Sept. 17, 2017, 5:17 p.m.)


Review request for oozie and Robert Kanter.


Repository: oozie-git


Description
---

OOZIE-2406 Completely rewrite GraphGenerator code


Diffs
-

  core/pom.xml b0809546d048c2acbcbea8af5f8947eb0eaece9e 
  core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 
10812c675ebc0cc4aefca9f4a85ef2fc26d143e1 
  core/src/main/java/org/apache/oozie/util/GraphGenerator.java 
6ded2c6dc15c9e8453ff800407ff0324be185f41 
  core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/GraphRenderer.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/JungRenderer.java PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/WorkflowActionNode.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java 
PRE-CREATION 
  core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java 
002e925b57cd830ea6d83a87cea4383165116b80 
  core/src/test/resources/graph-with-many-nodes.png PRE-CREATION 
  core/src/test/resources/graphWF_100_actions.xml PRE-CREATION 
  pom.xml db18f30814b9b6a73ba872c2cd7946692d0b876b 
  sharelib/oozie/pom.xml c74c06df5313b340e27747dfdf9126b3479674af 


Diff: https://reviews.apache.org/r/62352/diff/1/


Testing (updated)
---

`TestGraphGenerator`, `TestV1JobServlet`


Thanks,

András Piros

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

2017-09-15 Thread Robert Kanter 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62352/#review185497
---




core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java
Lines 46 (patched)


?



core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java
Lines 56 (patched)


?



core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java
Lines 57-58 (patched)


Add descriptions like the above constructor



core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java
Lines 75 (patched)


description



core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java
Lines 81 (patched)


Should this go in the ``newXMLReader()`` method?



core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java
Lines 83-84 (patched)


Remove



core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java
Lines 86 (patched)


Do we need to close this?



pom.xml
Lines 1510 (patched)


Looks like the newest version is 0.2.2.  Any reason why we're using 0.1.6?

http://search.maven.org/#search%7Cgav%7C1%7Cg%3A%22guru.nidi%22%20AND%20a%3A%22graphviz-java%22

(That said, 0.1.6 is only from May 2017, so it's not actually that old)


- Robert Kanter


On Sept. 15, 2017, 12:45 p.m., András Piros wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62352/
> ---
> 
> (Updated Sept. 15, 2017, 12:45 p.m.)
> 
> 
> Review request for oozie and Robert Kanter.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> OOZIE-2406 Completely rewrite GraphGenerator code
> 
> 
> Diffs
> -
> 
>   core/pom.xml b0809546d048c2acbcbea8af5f8947eb0eaece9e 
>   core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 
> 10812c675ebc0cc4aefca9f4a85ef2fc26d143e1 
>   core/src/main/java/org/apache/oozie/util/GraphGenerator.java 
> 6ded2c6dc15c9e8453ff800407ff0324be185f41 
>   core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/GraphRenderer.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/JungRenderer.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/WorkflowActionNode.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java 
> PRE-CREATION 
>   core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java 
> 002e925b57cd830ea6d83a87cea4383165116b80 
>   core/src/test/resources/graph-with-many-nodes.png PRE-CREATION 
>   core/src/test/resources/graphWF_100_actions.xml PRE-CREATION 
>   pom.xml db18f30814b9b6a73ba872c2cd7946692d0b876b 
>   sharelib/oozie/pom.xml c74c06df5313b340e27747dfdf9126b3479674af 
> 
> 
> Diff: https://reviews.apache.org/r/62352/diff/1/
> 
> 
> Testing
> ---
> 
> `TestGraphGenerator`
> 
> 
> Thanks,
> 
> András Piros
> 
>

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

2017-09-15 Thread Robert Kanter 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62352/#review185498
---




sharelib/oozie/pom.xml
Line 59 (original), 59 (patched)


Unrelated change.


- Robert Kanter


On Sept. 15, 2017, 12:45 p.m., András Piros wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62352/
> ---
> 
> (Updated Sept. 15, 2017, 12:45 p.m.)
> 
> 
> Review request for oozie and Robert Kanter.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> OOZIE-2406 Completely rewrite GraphGenerator code
> 
> 
> Diffs
> -
> 
>   core/pom.xml b0809546d048c2acbcbea8af5f8947eb0eaece9e 
>   core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 
> 10812c675ebc0cc4aefca9f4a85ef2fc26d143e1 
>   core/src/main/java/org/apache/oozie/util/GraphGenerator.java 
> 6ded2c6dc15c9e8453ff800407ff0324be185f41 
>   core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/GraphRenderer.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/JungRenderer.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/WorkflowActionNode.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java 
> PRE-CREATION 
>   core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java 
> 002e925b57cd830ea6d83a87cea4383165116b80 
>   core/src/test/resources/graph-with-many-nodes.png PRE-CREATION 
>   core/src/test/resources/graphWF_100_actions.xml PRE-CREATION 
>   pom.xml db18f30814b9b6a73ba872c2cd7946692d0b876b 
>   sharelib/oozie/pom.xml c74c06df5313b340e27747dfdf9126b3479674af 
> 
> 
> Diff: https://reviews.apache.org/r/62352/diff/1/
> 
> 
> Testing
> ---
> 
> `TestGraphGenerator`
> 
> 
> Thanks,
> 
> András Piros
> 
>

Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

2017-09-15 Thread András Piros 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62352/
---

Review request for oozie and Robert Kanter.


Repository: oozie-git


Description
---

OOZIE-2406 Completely rewrite GraphGenerator code


Diffs
-

  core/pom.xml b0809546d048c2acbcbea8af5f8947eb0eaece9e 
  core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 
10812c675ebc0cc4aefca9f4a85ef2fc26d143e1 
  core/src/main/java/org/apache/oozie/util/GraphGenerator.java 
6ded2c6dc15c9e8453ff800407ff0324be185f41 
  core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/GraphRenderer.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/JungRenderer.java PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/WorkflowActionNode.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java 
PRE-CREATION 
  core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java 
002e925b57cd830ea6d83a87cea4383165116b80 
  core/src/test/resources/graph-with-many-nodes.png PRE-CREATION 
  core/src/test/resources/graphWF_100_actions.xml PRE-CREATION 
  pom.xml db18f30814b9b6a73ba872c2cd7946692d0b876b 
  sharelib/oozie/pom.xml c74c06df5313b340e27747dfdf9126b3479674af 


Diff: https://reviews.apache.org/r/62352/diff/1/


Testing
---

`TestGraphGenerator`


Thanks,

András Piros