subject:"Backport for OWB 1.7.x"

Re: Backport for OWB 1.7.x

2018-12-17 Thread Jean-Louis MONTEIRO

VOTE is up and binaries ready for review.

Hope it helps

Le lun. 17 déc. 2018 à 17:07, Daniel Cunha  a écrit :

> +1. Thanks Jean-Louis! :D
>
> Em seg, 17 de dez de 2018 às 11:50, Jonathan Gallimore <
> jonathan.gallim...@gmail.com> escreveu:
>
> > +1, thanks Jean-Louis!
> >
> > On Mon, 17 Dec 2018, 14:36 Jean-Louis MONTEIRO  wrote:
> >
> > > Hey,
> > >
> > > Are we ready to roll it out then?
> > > I ca do it whenever it's needed this week.
> > >
> > > Le lun. 3 déc. 2018 à 11:13, Daniel Cunha  a
> > écrit
> > > :
> > >
> > > > Hi Thomas,
> > > >
> > > > Sure, I'll close.
> > > > Thank you too!
> > > >
> > > > Em seg, 3 de dez de 2018 às 07:11, Thomas Andraschko <
> > > > andraschko.tho...@gmail.com> escreveu:
> > > >
> > > > > Merged it. Thank you Daniel for the patch!
> > > > > Also "resolved" the JIRA ticket.
> > > > >
> > > > > @Daniel Could you please close your PR then?
> > > > >
> > > > > Am Sa., 1. Dez. 2018 um 17:14 Uhr schrieb Romain Manni-Bucau <
> > > > > rmannibu...@gmail.com>:
> > > > >
> > > > > > Yes, looks good
> > > > > >
> > > > > > Le sam. 1 déc. 2018 14:28, Thomas Andraschko <
> > > > > andraschko.tho...@gmail.com>
> > > > > > a écrit :
> > > > > >
> > > > > > > Can i merge it romain?
> > > > > > >
> > > > > > >
> > > > > > > Am Do., 22. Nov. 2018, 14:39 hat Daniel Cunha <
> > > daniels...@gmail.com>
> > > > > > > geschrieben:
> > > > > > >
> > > > > > > > Ok. patch updated again. :)
> > > > > > > >
> > > > > > > > Em qui, 22 de nov de 2018 às 10:32, Daniel Cunha <
> > > > > daniels...@gmail.com
> > > > > > >
> > > > > > > > escreveu:
> > > > > > > >
> > > > > > > > > Ah..
> > > > > > > > >
> > > > > > > > > Ok, I get it!
> > > > > > > > > Thanks Thomas and Jon
> > > > > > > > >
> > > > > > > > > Em qui, 22 de nov de 2018 às 10:30, Jonathan Gallimore <
> > > > > > > > > jonathan.gallim...@gmail.com> escreveu:
> > > > > > > > >
> > > > > > > > >> I think you can keep ASM 7, but leave this:
> > > > > > > > >>
> > > > > > > > >>
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/openwebbeans/pull/13/commits/cb600aada79427ab7eff31e7da92038b6af6ed19#diff-f58069aef7df21dd8d4b0bd3546a747aR104
> > > > > > > > >>
> > > > > > > > >> as `return Opcodes.V1_6;`.
> > > > > > > > >>
> > > > > > > > >> Hope that helps.
> > > > > > > > >>
> > > > > > > > >> Jon
> > > > > > > > >>
> > > > > > > > >> On Thu, Nov 22, 2018 at 1:26 PM Romain Manni-Bucau <
> > > > > > > > rmannibu...@gmail.com
> > > > > > > > >> >
> > > > > > > > >> wrote:
> > > > > > > > >>
> > > > > > > > >> > +1 Thomas
> > > > > > > > >> >
> > > > > > > > >> > Romain Manni-Bucau
> > > > > > > > >> > @rmannibucau  |  Blog
> > > > > > > > >> >  | Old Blog
> > > > > > > > >> >  | Github <
> > > > > > > > >> > https://github.com/rmannibucau> |
> > > > > > > > >> > LinkedIn  |
> Book
> > > > > > > > >> > <
> > > > > > > > >> >
> > > > > > > > >>
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > > > > > > >> > >
> > > > > > > > >> >
> > > > > > > > >> >
> > > > > > > > >> > Le jeu. 22 nov. 2018 à 14:17, Thomas Andraschko <
> > > > > > > > >> > andraschko.tho...@gmail.com>
> > > > > > > > >> > a écrit :
> > > > > > > > >> >
> > > > > > > > >> > > Hi Daniel,
> > > > > > > > >> > >
> > > > > > > > >> > > not sure if i didn't understand it correclty but IMO
> we
> > > > should
> > > > > > > > >> upgrade to
> > > > > > > > >> > > ASM7 - BUT - default the bytecode version to Java6 or
> > > Java7
> > > > in
> > > > > > > > >> > > AbstractProxyFactory#determineDefaultJavaVersion.
> > > > > > > > >> > > Could you please clarify Romain?
> > > > > > > > >> > >
> > > > > > > > >> > > Best regards,
> > > > > > > > >> > > Thomas
> > > > > > > > >> > >
> > > > > > > > >> > > Am Do., 22. Nov. 2018 um 13:48 Uhr schrieb Daniel
> Cunha
> > <
> > > > > > > > >> > > daniels...@apache.org>:
> > > > > > > > >> > >
> > > > > > > > >> > > > hi folks,
> > > > > > > > >> > > >
> > > > > > > > >> > > > patch updated again:
> > > > > > > > https://github.com/apache/openwebbeans/pull/13
> > > > > > > > >> :)
> > > > > > > > >> > > >
> > > > > > > > >> > > > Em qui, 22 de nov de 2018 às 08:14, Daniel Cunha <
> > > > > > > > >> > daniels...@apache.org>
> > > > > > > > >> > > > escreveu:
> > > > > > > > >> > > >
> > > > > > > > >> > > > > Ok, in this case I'll back the asm changes. I'll
> > > update
> > > > > the
> > > > > > > > patch.
> > > > > > > > >> > > > >
> > > > > > > > >> > > > > Em qua, 21 de nov de 2018 7:02 AM, Thomas
> > Andraschko <
> > > > > > > > >> > > > > andraschko.tho...@gmail.com escreveu:
> > > > > > > > >> > > > >
> > > > > > > > >> > > > >> +1 to not change the old default
> > > > > > > > >> > > > >>
> > > > > > > > >> > > > >> Am Di., 20. Nov. 2018 um 21:27 Uhr

Re: Backport for OWB 1.7.x

2018-12-17 Thread Daniel Cunha

+1. Thanks Jean-Louis! :D

Em seg, 17 de dez de 2018 às 11:50, Jonathan Gallimore <
jonathan.gallim...@gmail.com> escreveu:

> +1, thanks Jean-Louis!
>
> On Mon, 17 Dec 2018, 14:36 Jean-Louis MONTEIRO 
> > Hey,
> >
> > Are we ready to roll it out then?
> > I ca do it whenever it's needed this week.
> >
> > Le lun. 3 déc. 2018 à 11:13, Daniel Cunha  a
> écrit
> > :
> >
> > > Hi Thomas,
> > >
> > > Sure, I'll close.
> > > Thank you too!
> > >
> > > Em seg, 3 de dez de 2018 às 07:11, Thomas Andraschko <
> > > andraschko.tho...@gmail.com> escreveu:
> > >
> > > > Merged it. Thank you Daniel for the patch!
> > > > Also "resolved" the JIRA ticket.
> > > >
> > > > @Daniel Could you please close your PR then?
> > > >
> > > > Am Sa., 1. Dez. 2018 um 17:14 Uhr schrieb Romain Manni-Bucau <
> > > > rmannibu...@gmail.com>:
> > > >
> > > > > Yes, looks good
> > > > >
> > > > > Le sam. 1 déc. 2018 14:28, Thomas Andraschko <
> > > > andraschko.tho...@gmail.com>
> > > > > a écrit :
> > > > >
> > > > > > Can i merge it romain?
> > > > > >
> > > > > >
> > > > > > Am Do., 22. Nov. 2018, 14:39 hat Daniel Cunha <
> > daniels...@gmail.com>
> > > > > > geschrieben:
> > > > > >
> > > > > > > Ok. patch updated again. :)
> > > > > > >
> > > > > > > Em qui, 22 de nov de 2018 às 10:32, Daniel Cunha <
> > > > daniels...@gmail.com
> > > > > >
> > > > > > > escreveu:
> > > > > > >
> > > > > > > > Ah..
> > > > > > > >
> > > > > > > > Ok, I get it!
> > > > > > > > Thanks Thomas and Jon
> > > > > > > >
> > > > > > > > Em qui, 22 de nov de 2018 às 10:30, Jonathan Gallimore <
> > > > > > > > jonathan.gallim...@gmail.com> escreveu:
> > > > > > > >
> > > > > > > >> I think you can keep ASM 7, but leave this:
> > > > > > > >>
> > > > > > > >>
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/openwebbeans/pull/13/commits/cb600aada79427ab7eff31e7da92038b6af6ed19#diff-f58069aef7df21dd8d4b0bd3546a747aR104
> > > > > > > >>
> > > > > > > >> as `return Opcodes.V1_6;`.
> > > > > > > >>
> > > > > > > >> Hope that helps.
> > > > > > > >>
> > > > > > > >> Jon
> > > > > > > >>
> > > > > > > >> On Thu, Nov 22, 2018 at 1:26 PM Romain Manni-Bucau <
> > > > > > > rmannibu...@gmail.com
> > > > > > > >> >
> > > > > > > >> wrote:
> > > > > > > >>
> > > > > > > >> > +1 Thomas
> > > > > > > >> >
> > > > > > > >> > Romain Manni-Bucau
> > > > > > > >> > @rmannibucau  |  Blog
> > > > > > > >> >  | Old Blog
> > > > > > > >> >  | Github <
> > > > > > > >> > https://github.com/rmannibucau> |
> > > > > > > >> > LinkedIn  | Book
> > > > > > > >> > <
> > > > > > > >> >
> > > > > > > >>
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > > > > > >> > >
> > > > > > > >> >
> > > > > > > >> >
> > > > > > > >> > Le jeu. 22 nov. 2018 à 14:17, Thomas Andraschko <
> > > > > > > >> > andraschko.tho...@gmail.com>
> > > > > > > >> > a écrit :
> > > > > > > >> >
> > > > > > > >> > > Hi Daniel,
> > > > > > > >> > >
> > > > > > > >> > > not sure if i didn't understand it correclty but IMO we
> > > should
> > > > > > > >> upgrade to
> > > > > > > >> > > ASM7 - BUT - default the bytecode version to Java6 or
> > Java7
> > > in
> > > > > > > >> > > AbstractProxyFactory#determineDefaultJavaVersion.
> > > > > > > >> > > Could you please clarify Romain?
> > > > > > > >> > >
> > > > > > > >> > > Best regards,
> > > > > > > >> > > Thomas
> > > > > > > >> > >
> > > > > > > >> > > Am Do., 22. Nov. 2018 um 13:48 Uhr schrieb Daniel Cunha
> <
> > > > > > > >> > > daniels...@apache.org>:
> > > > > > > >> > >
> > > > > > > >> > > > hi folks,
> > > > > > > >> > > >
> > > > > > > >> > > > patch updated again:
> > > > > > > https://github.com/apache/openwebbeans/pull/13
> > > > > > > >> :)
> > > > > > > >> > > >
> > > > > > > >> > > > Em qui, 22 de nov de 2018 às 08:14, Daniel Cunha <
> > > > > > > >> > daniels...@apache.org>
> > > > > > > >> > > > escreveu:
> > > > > > > >> > > >
> > > > > > > >> > > > > Ok, in this case I'll back the asm changes. I'll
> > update
> > > > the
> > > > > > > patch.
> > > > > > > >> > > > >
> > > > > > > >> > > > > Em qua, 21 de nov de 2018 7:02 AM, Thomas
> Andraschko <
> > > > > > > >> > > > > andraschko.tho...@gmail.com escreveu:
> > > > > > > >> > > > >
> > > > > > > >> > > > >> +1 to not change the old default
> > > > > > > >> > > > >>
> > > > > > > >> > > > >> Am Di., 20. Nov. 2018 um 21:27 Uhr schrieb Romain
> > > > > > Manni-Bucau <
> > > > > > > >> > > > >> rmannibu...@gmail.com>:
> > > > > > > >> > > > >>
> > > > > > > >> > > > >> > Except the default to bytecode for java 8 - fear
> we
> > > > have
> > > > > to
> > > > > > > >> stick
> > > > > > > >> > to
> > > > > > > >> > > > j6
> > > > > > > >> > > > >> or
> > > > > > > >> > > > >> > 7 if we want to change here - it looks good.
> > > > > > > >> > > > >> >
>

Re: Backport for OWB 1.7.x

2018-12-17 Thread Jonathan Gallimore

+1, thanks Jean-Louis!

On Mon, 17 Dec 2018, 14:36 Jean-Louis MONTEIRO  Hey,
>
> Are we ready to roll it out then?
> I ca do it whenever it's needed this week.
>
> Le lun. 3 déc. 2018 à 11:13, Daniel Cunha  a écrit
> :
>
> > Hi Thomas,
> >
> > Sure, I'll close.
> > Thank you too!
> >
> > Em seg, 3 de dez de 2018 às 07:11, Thomas Andraschko <
> > andraschko.tho...@gmail.com> escreveu:
> >
> > > Merged it. Thank you Daniel for the patch!
> > > Also "resolved" the JIRA ticket.
> > >
> > > @Daniel Could you please close your PR then?
> > >
> > > Am Sa., 1. Dez. 2018 um 17:14 Uhr schrieb Romain Manni-Bucau <
> > > rmannibu...@gmail.com>:
> > >
> > > > Yes, looks good
> > > >
> > > > Le sam. 1 déc. 2018 14:28, Thomas Andraschko <
> > > andraschko.tho...@gmail.com>
> > > > a écrit :
> > > >
> > > > > Can i merge it romain?
> > > > >
> > > > >
> > > > > Am Do., 22. Nov. 2018, 14:39 hat Daniel Cunha <
> daniels...@gmail.com>
> > > > > geschrieben:
> > > > >
> > > > > > Ok. patch updated again. :)
> > > > > >
> > > > > > Em qui, 22 de nov de 2018 às 10:32, Daniel Cunha <
> > > daniels...@gmail.com
> > > > >
> > > > > > escreveu:
> > > > > >
> > > > > > > Ah..
> > > > > > >
> > > > > > > Ok, I get it!
> > > > > > > Thanks Thomas and Jon
> > > > > > >
> > > > > > > Em qui, 22 de nov de 2018 às 10:30, Jonathan Gallimore <
> > > > > > > jonathan.gallim...@gmail.com> escreveu:
> > > > > > >
> > > > > > >> I think you can keep ASM 7, but leave this:
> > > > > > >>
> > > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/openwebbeans/pull/13/commits/cb600aada79427ab7eff31e7da92038b6af6ed19#diff-f58069aef7df21dd8d4b0bd3546a747aR104
> > > > > > >>
> > > > > > >> as `return Opcodes.V1_6;`.
> > > > > > >>
> > > > > > >> Hope that helps.
> > > > > > >>
> > > > > > >> Jon
> > > > > > >>
> > > > > > >> On Thu, Nov 22, 2018 at 1:26 PM Romain Manni-Bucau <
> > > > > > rmannibu...@gmail.com
> > > > > > >> >
> > > > > > >> wrote:
> > > > > > >>
> > > > > > >> > +1 Thomas
> > > > > > >> >
> > > > > > >> > Romain Manni-Bucau
> > > > > > >> > @rmannibucau  |  Blog
> > > > > > >> >  | Old Blog
> > > > > > >> >  | Github <
> > > > > > >> > https://github.com/rmannibucau> |
> > > > > > >> > LinkedIn  | Book
> > > > > > >> > <
> > > > > > >> >
> > > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > > > > >> > >
> > > > > > >> >
> > > > > > >> >
> > > > > > >> > Le jeu. 22 nov. 2018 à 14:17, Thomas Andraschko <
> > > > > > >> > andraschko.tho...@gmail.com>
> > > > > > >> > a écrit :
> > > > > > >> >
> > > > > > >> > > Hi Daniel,
> > > > > > >> > >
> > > > > > >> > > not sure if i didn't understand it correclty but IMO we
> > should
> > > > > > >> upgrade to
> > > > > > >> > > ASM7 - BUT - default the bytecode version to Java6 or
> Java7
> > in
> > > > > > >> > > AbstractProxyFactory#determineDefaultJavaVersion.
> > > > > > >> > > Could you please clarify Romain?
> > > > > > >> > >
> > > > > > >> > > Best regards,
> > > > > > >> > > Thomas
> > > > > > >> > >
> > > > > > >> > > Am Do., 22. Nov. 2018 um 13:48 Uhr schrieb Daniel Cunha <
> > > > > > >> > > daniels...@apache.org>:
> > > > > > >> > >
> > > > > > >> > > > hi folks,
> > > > > > >> > > >
> > > > > > >> > > > patch updated again:
> > > > > > https://github.com/apache/openwebbeans/pull/13
> > > > > > >> :)
> > > > > > >> > > >
> > > > > > >> > > > Em qui, 22 de nov de 2018 às 08:14, Daniel Cunha <
> > > > > > >> > daniels...@apache.org>
> > > > > > >> > > > escreveu:
> > > > > > >> > > >
> > > > > > >> > > > > Ok, in this case I'll back the asm changes. I'll
> update
> > > the
> > > > > > patch.
> > > > > > >> > > > >
> > > > > > >> > > > > Em qua, 21 de nov de 2018 7:02 AM, Thomas Andraschko <
> > > > > > >> > > > > andraschko.tho...@gmail.com escreveu:
> > > > > > >> > > > >
> > > > > > >> > > > >> +1 to not change the old default
> > > > > > >> > > > >>
> > > > > > >> > > > >> Am Di., 20. Nov. 2018 um 21:27 Uhr schrieb Romain
> > > > > Manni-Bucau <
> > > > > > >> > > > >> rmannibu...@gmail.com>:
> > > > > > >> > > > >>
> > > > > > >> > > > >> > Except the default to bytecode for java 8 - fear we
> > > have
> > > > to
> > > > > > >> stick
> > > > > > >> > to
> > > > > > >> > > > j6
> > > > > > >> > > > >> or
> > > > > > >> > > > >> > 7 if we want to change here - it looks good.
> > > > > > >> > > > >> >
> > > > > > >> > > > >> > Le mar. 20 nov. 2018 20:59, Thomas Andraschko <
> > > > > > >> > > > >> andraschko.tho...@gmail.com
> > > > > > >> > > > >> > >
> > > > > > >> > > > >> > a écrit :
> > > > > > >> > > > >> >
> > > > > > >> > > > >> > > @Romain could you do a short review? I could
> apply
> > it
> > > > > > >> tomorrow
> > > > > > >> > > then.
> > > > > > >> > > > >> > >
> > > > > > >> > > > >> > > Am Di., 20. Nov. 2018 um 20:37

Re: Backport for OWB 1.7.x

2018-12-17 Thread Jean-Louis MONTEIRO

Great.

Thanks guys.
I'll give it a try today

Le lun. 17 déc. 2018 à 15:46, Romain Manni-Bucau  a
écrit :

> +1
>
> Romain Manni-Bucau
> @rmannibucau  |  Blog
>  | Old Blog
>  | Github <
> https://github.com/rmannibucau> |
> LinkedIn  | Book
> <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
>
>
> Le lun. 17 déc. 2018 à 15:44, Thomas Andraschko <
> andraschko.tho...@gmail.com>
> a écrit :
>
> > Yup, i think so.
> >
> > Am Mo., 17. Dez. 2018 um 15:36 Uhr schrieb Jean-Louis MONTEIRO <
> > jeano...@gmail.com>:
> >
> > > Hey,
> > >
> > > Are we ready to roll it out then?
> > > I ca do it whenever it's needed this week.
> > >
> > > Le lun. 3 déc. 2018 à 11:13, Daniel Cunha  a
> > écrit
> > > :
> > >
> > > > Hi Thomas,
> > > >
> > > > Sure, I'll close.
> > > > Thank you too!
> > > >
> > > > Em seg, 3 de dez de 2018 às 07:11, Thomas Andraschko <
> > > > andraschko.tho...@gmail.com> escreveu:
> > > >
> > > > > Merged it. Thank you Daniel for the patch!
> > > > > Also "resolved" the JIRA ticket.
> > > > >
> > > > > @Daniel Could you please close your PR then?
> > > > >
> > > > > Am Sa., 1. Dez. 2018 um 17:14 Uhr schrieb Romain Manni-Bucau <
> > > > > rmannibu...@gmail.com>:
> > > > >
> > > > > > Yes, looks good
> > > > > >
> > > > > > Le sam. 1 déc. 2018 14:28, Thomas Andraschko <
> > > > > andraschko.tho...@gmail.com>
> > > > > > a écrit :
> > > > > >
> > > > > > > Can i merge it romain?
> > > > > > >
> > > > > > >
> > > > > > > Am Do., 22. Nov. 2018, 14:39 hat Daniel Cunha <
> > > daniels...@gmail.com>
> > > > > > > geschrieben:
> > > > > > >
> > > > > > > > Ok. patch updated again. :)
> > > > > > > >
> > > > > > > > Em qui, 22 de nov de 2018 às 10:32, Daniel Cunha <
> > > > > daniels...@gmail.com
> > > > > > >
> > > > > > > > escreveu:
> > > > > > > >
> > > > > > > > > Ah..
> > > > > > > > >
> > > > > > > > > Ok, I get it!
> > > > > > > > > Thanks Thomas and Jon
> > > > > > > > >
> > > > > > > > > Em qui, 22 de nov de 2018 às 10:30, Jonathan Gallimore <
> > > > > > > > > jonathan.gallim...@gmail.com> escreveu:
> > > > > > > > >
> > > > > > > > >> I think you can keep ASM 7, but leave this:
> > > > > > > > >>
> > > > > > > > >>
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/openwebbeans/pull/13/commits/cb600aada79427ab7eff31e7da92038b6af6ed19#diff-f58069aef7df21dd8d4b0bd3546a747aR104
> > > > > > > > >>
> > > > > > > > >> as `return Opcodes.V1_6;`.
> > > > > > > > >>
> > > > > > > > >> Hope that helps.
> > > > > > > > >>
> > > > > > > > >> Jon
> > > > > > > > >>
> > > > > > > > >> On Thu, Nov 22, 2018 at 1:26 PM Romain Manni-Bucau <
> > > > > > > > rmannibu...@gmail.com
> > > > > > > > >> >
> > > > > > > > >> wrote:
> > > > > > > > >>
> > > > > > > > >> > +1 Thomas
> > > > > > > > >> >
> > > > > > > > >> > Romain Manni-Bucau
> > > > > > > > >> > @rmannibucau  |  Blog
> > > > > > > > >> >  | Old Blog
> > > > > > > > >> >  | Github <
> > > > > > > > >> > https://github.com/rmannibucau> |
> > > > > > > > >> > LinkedIn  |
> Book
> > > > > > > > >> > <
> > > > > > > > >> >
> > > > > > > > >>
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > > > > > > >> > >
> > > > > > > > >> >
> > > > > > > > >> >
> > > > > > > > >> > Le jeu. 22 nov. 2018 à 14:17, Thomas Andraschko <
> > > > > > > > >> > andraschko.tho...@gmail.com>
> > > > > > > > >> > a écrit :
> > > > > > > > >> >
> > > > > > > > >> > > Hi Daniel,
> > > > > > > > >> > >
> > > > > > > > >> > > not sure if i didn't understand it correclty but IMO
> we
> > > > should
> > > > > > > > >> upgrade to
> > > > > > > > >> > > ASM7 - BUT - default the bytecode version to Java6 or
> > > Java7
> > > > in
> > > > > > > > >> > > AbstractProxyFactory#determineDefaultJavaVersion.
> > > > > > > > >> > > Could you please clarify Romain?
> > > > > > > > >> > >
> > > > > > > > >> > > Best regards,
> > > > > > > > >> > > Thomas
> > > > > > > > >> > >
> > > > > > > > >> > > Am Do., 22. Nov. 2018 um 13:48 Uhr schrieb Daniel
> Cunha
> > <
> > > > > > > > >> > > daniels...@apache.org>:
> > > > > > > > >> > >
> > > > > > > > >> > > > hi folks,
> > > > > > > > >> > > >
> > > > > > > > >> > > > patch updated again:
> > > > > > > > https://github.com/apache/openwebbeans/pull/13
> > > > > > > > >> :)
> > > > > > > > >> > > >
> > > > > > > > >> > > > Em qui, 22 de nov de 2018 às 08:14, Daniel Cunha <
> > > > > > > > >> > daniels...@apache.org>
> > > > > > > > >> > > > escreveu:
> > > > > > > > >> > > >
> > > > > > > > >> > > > > Ok, in this case I'll back the asm changes. I'll
> > > update
> > > > > the
> > > > > > > > patch.
>

Re: Backport for OWB 1.7.x

2018-12-17 Thread Romain Manni-Bucau

+1

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le lun. 17 déc. 2018 à 15:44, Thomas Andraschko 
a écrit :

> Yup, i think so.
>
> Am Mo., 17. Dez. 2018 um 15:36 Uhr schrieb Jean-Louis MONTEIRO <
> jeano...@gmail.com>:
>
> > Hey,
> >
> > Are we ready to roll it out then?
> > I ca do it whenever it's needed this week.
> >
> > Le lun. 3 déc. 2018 à 11:13, Daniel Cunha  a
> écrit
> > :
> >
> > > Hi Thomas,
> > >
> > > Sure, I'll close.
> > > Thank you too!
> > >
> > > Em seg, 3 de dez de 2018 às 07:11, Thomas Andraschko <
> > > andraschko.tho...@gmail.com> escreveu:
> > >
> > > > Merged it. Thank you Daniel for the patch!
> > > > Also "resolved" the JIRA ticket.
> > > >
> > > > @Daniel Could you please close your PR then?
> > > >
> > > > Am Sa., 1. Dez. 2018 um 17:14 Uhr schrieb Romain Manni-Bucau <
> > > > rmannibu...@gmail.com>:
> > > >
> > > > > Yes, looks good
> > > > >
> > > > > Le sam. 1 déc. 2018 14:28, Thomas Andraschko <
> > > > andraschko.tho...@gmail.com>
> > > > > a écrit :
> > > > >
> > > > > > Can i merge it romain?
> > > > > >
> > > > > >
> > > > > > Am Do., 22. Nov. 2018, 14:39 hat Daniel Cunha <
> > daniels...@gmail.com>
> > > > > > geschrieben:
> > > > > >
> > > > > > > Ok. patch updated again. :)
> > > > > > >
> > > > > > > Em qui, 22 de nov de 2018 às 10:32, Daniel Cunha <
> > > > daniels...@gmail.com
> > > > > >
> > > > > > > escreveu:
> > > > > > >
> > > > > > > > Ah..
> > > > > > > >
> > > > > > > > Ok, I get it!
> > > > > > > > Thanks Thomas and Jon
> > > > > > > >
> > > > > > > > Em qui, 22 de nov de 2018 às 10:30, Jonathan Gallimore <
> > > > > > > > jonathan.gallim...@gmail.com> escreveu:
> > > > > > > >
> > > > > > > >> I think you can keep ASM 7, but leave this:
> > > > > > > >>
> > > > > > > >>
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/openwebbeans/pull/13/commits/cb600aada79427ab7eff31e7da92038b6af6ed19#diff-f58069aef7df21dd8d4b0bd3546a747aR104
> > > > > > > >>
> > > > > > > >> as `return Opcodes.V1_6;`.
> > > > > > > >>
> > > > > > > >> Hope that helps.
> > > > > > > >>
> > > > > > > >> Jon
> > > > > > > >>
> > > > > > > >> On Thu, Nov 22, 2018 at 1:26 PM Romain Manni-Bucau <
> > > > > > > rmannibu...@gmail.com
> > > > > > > >> >
> > > > > > > >> wrote:
> > > > > > > >>
> > > > > > > >> > +1 Thomas
> > > > > > > >> >
> > > > > > > >> > Romain Manni-Bucau
> > > > > > > >> > @rmannibucau  |  Blog
> > > > > > > >> >  | Old Blog
> > > > > > > >> >  | Github <
> > > > > > > >> > https://github.com/rmannibucau> |
> > > > > > > >> > LinkedIn  | Book
> > > > > > > >> > <
> > > > > > > >> >
> > > > > > > >>
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > > > > > >> > >
> > > > > > > >> >
> > > > > > > >> >
> > > > > > > >> > Le jeu. 22 nov. 2018 à 14:17, Thomas Andraschko <
> > > > > > > >> > andraschko.tho...@gmail.com>
> > > > > > > >> > a écrit :
> > > > > > > >> >
> > > > > > > >> > > Hi Daniel,
> > > > > > > >> > >
> > > > > > > >> > > not sure if i didn't understand it correclty but IMO we
> > > should
> > > > > > > >> upgrade to
> > > > > > > >> > > ASM7 - BUT - default the bytecode version to Java6 or
> > Java7
> > > in
> > > > > > > >> > > AbstractProxyFactory#determineDefaultJavaVersion.
> > > > > > > >> > > Could you please clarify Romain?
> > > > > > > >> > >
> > > > > > > >> > > Best regards,
> > > > > > > >> > > Thomas
> > > > > > > >> > >
> > > > > > > >> > > Am Do., 22. Nov. 2018 um 13:48 Uhr schrieb Daniel Cunha
> <
> > > > > > > >> > > daniels...@apache.org>:
> > > > > > > >> > >
> > > > > > > >> > > > hi folks,
> > > > > > > >> > > >
> > > > > > > >> > > > patch updated again:
> > > > > > > https://github.com/apache/openwebbeans/pull/13
> > > > > > > >> :)
> > > > > > > >> > > >
> > > > > > > >> > > > Em qui, 22 de nov de 2018 às 08:14, Daniel Cunha <
> > > > > > > >> > daniels...@apache.org>
> > > > > > > >> > > > escreveu:
> > > > > > > >> > > >
> > > > > > > >> > > > > Ok, in this case I'll back the asm changes. I'll
> > update
> > > > the
> > > > > > > patch.
> > > > > > > >> > > > >
> > > > > > > >> > > > > Em qua, 21 de nov de 2018 7:02 AM, Thomas
> Andraschko <
> > > > > > > >> > > > > andraschko.tho...@gmail.com escreveu:
> > > > > > > >> > > > >
> > > > > > > >> > > > >> +1 to not change the old default
> > > > > > > >> > > > >>
> > > > > > > >> > > > >> Am Di., 20. Nov. 2018 um 21:27 Uhr schrieb Romain
> > > > > > Manni-Bucau <
> > > > > > > >> > > > >> rmannibu...@gmail.com>:
> > > > > > > >> > > >

Re: Backport for OWB 1.7.x

2018-12-17 Thread Thomas Andraschko

Yup, i think so.

Am Mo., 17. Dez. 2018 um 15:36 Uhr schrieb Jean-Louis MONTEIRO <
jeano...@gmail.com>:

> Hey,
>
> Are we ready to roll it out then?
> I ca do it whenever it's needed this week.
>
> Le lun. 3 déc. 2018 à 11:13, Daniel Cunha  a écrit
> :
>
> > Hi Thomas,
> >
> > Sure, I'll close.
> > Thank you too!
> >
> > Em seg, 3 de dez de 2018 às 07:11, Thomas Andraschko <
> > andraschko.tho...@gmail.com> escreveu:
> >
> > > Merged it. Thank you Daniel for the patch!
> > > Also "resolved" the JIRA ticket.
> > >
> > > @Daniel Could you please close your PR then?
> > >
> > > Am Sa., 1. Dez. 2018 um 17:14 Uhr schrieb Romain Manni-Bucau <
> > > rmannibu...@gmail.com>:
> > >
> > > > Yes, looks good
> > > >
> > > > Le sam. 1 déc. 2018 14:28, Thomas Andraschko <
> > > andraschko.tho...@gmail.com>
> > > > a écrit :
> > > >
> > > > > Can i merge it romain?
> > > > >
> > > > >
> > > > > Am Do., 22. Nov. 2018, 14:39 hat Daniel Cunha <
> daniels...@gmail.com>
> > > > > geschrieben:
> > > > >
> > > > > > Ok. patch updated again. :)
> > > > > >
> > > > > > Em qui, 22 de nov de 2018 às 10:32, Daniel Cunha <
> > > daniels...@gmail.com
> > > > >
> > > > > > escreveu:
> > > > > >
> > > > > > > Ah..
> > > > > > >
> > > > > > > Ok, I get it!
> > > > > > > Thanks Thomas and Jon
> > > > > > >
> > > > > > > Em qui, 22 de nov de 2018 às 10:30, Jonathan Gallimore <
> > > > > > > jonathan.gallim...@gmail.com> escreveu:
> > > > > > >
> > > > > > >> I think you can keep ASM 7, but leave this:
> > > > > > >>
> > > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/openwebbeans/pull/13/commits/cb600aada79427ab7eff31e7da92038b6af6ed19#diff-f58069aef7df21dd8d4b0bd3546a747aR104
> > > > > > >>
> > > > > > >> as `return Opcodes.V1_6;`.
> > > > > > >>
> > > > > > >> Hope that helps.
> > > > > > >>
> > > > > > >> Jon
> > > > > > >>
> > > > > > >> On Thu, Nov 22, 2018 at 1:26 PM Romain Manni-Bucau <
> > > > > > rmannibu...@gmail.com
> > > > > > >> >
> > > > > > >> wrote:
> > > > > > >>
> > > > > > >> > +1 Thomas
> > > > > > >> >
> > > > > > >> > Romain Manni-Bucau
> > > > > > >> > @rmannibucau  |  Blog
> > > > > > >> >  | Old Blog
> > > > > > >> >  | Github <
> > > > > > >> > https://github.com/rmannibucau> |
> > > > > > >> > LinkedIn  | Book
> > > > > > >> > <
> > > > > > >> >
> > > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > > > > >> > >
> > > > > > >> >
> > > > > > >> >
> > > > > > >> > Le jeu. 22 nov. 2018 à 14:17, Thomas Andraschko <
> > > > > > >> > andraschko.tho...@gmail.com>
> > > > > > >> > a écrit :
> > > > > > >> >
> > > > > > >> > > Hi Daniel,
> > > > > > >> > >
> > > > > > >> > > not sure if i didn't understand it correclty but IMO we
> > should
> > > > > > >> upgrade to
> > > > > > >> > > ASM7 - BUT - default the bytecode version to Java6 or
> Java7
> > in
> > > > > > >> > > AbstractProxyFactory#determineDefaultJavaVersion.
> > > > > > >> > > Could you please clarify Romain?
> > > > > > >> > >
> > > > > > >> > > Best regards,
> > > > > > >> > > Thomas
> > > > > > >> > >
> > > > > > >> > > Am Do., 22. Nov. 2018 um 13:48 Uhr schrieb Daniel Cunha <
> > > > > > >> > > daniels...@apache.org>:
> > > > > > >> > >
> > > > > > >> > > > hi folks,
> > > > > > >> > > >
> > > > > > >> > > > patch updated again:
> > > > > > https://github.com/apache/openwebbeans/pull/13
> > > > > > >> :)
> > > > > > >> > > >
> > > > > > >> > > > Em qui, 22 de nov de 2018 às 08:14, Daniel Cunha <
> > > > > > >> > daniels...@apache.org>
> > > > > > >> > > > escreveu:
> > > > > > >> > > >
> > > > > > >> > > > > Ok, in this case I'll back the asm changes. I'll
> update
> > > the
> > > > > > patch.
> > > > > > >> > > > >
> > > > > > >> > > > > Em qua, 21 de nov de 2018 7:02 AM, Thomas Andraschko <
> > > > > > >> > > > > andraschko.tho...@gmail.com escreveu:
> > > > > > >> > > > >
> > > > > > >> > > > >> +1 to not change the old default
> > > > > > >> > > > >>
> > > > > > >> > > > >> Am Di., 20. Nov. 2018 um 21:27 Uhr schrieb Romain
> > > > > Manni-Bucau <
> > > > > > >> > > > >> rmannibu...@gmail.com>:
> > > > > > >> > > > >>
> > > > > > >> > > > >> > Except the default to bytecode for java 8 - fear we
> > > have
> > > > to
> > > > > > >> stick
> > > > > > >> > to
> > > > > > >> > > > j6
> > > > > > >> > > > >> or
> > > > > > >> > > > >> > 7 if we want to change here - it looks good.
> > > > > > >> > > > >> >
> > > > > > >> > > > >> > Le mar. 20 nov. 2018 20:59, Thomas Andraschko <
> > > > > > >> > > > >> andraschko.tho...@gmail.com
> > > > > > >> > > > >> > >
> > > > > > >> > > > >> > a écrit :
> > > > > > >> > > > >> >
> > > > > > >> > > > >> > > @Romain could you do a short review? I could
> apply
> > it
> > > > > > >> tomorrow
> > > > > > >> > > then.
> > > > > > >> > > > >> > >
> > > > > > >> > > > >>

Re: Backport for OWB 1.7.x

2018-12-17 Thread Jean-Louis MONTEIRO

Hey,

Are we ready to roll it out then?
I ca do it whenever it's needed this week.

Le lun. 3 déc. 2018 à 11:13, Daniel Cunha  a écrit :

> Hi Thomas,
>
> Sure, I'll close.
> Thank you too!
>
> Em seg, 3 de dez de 2018 às 07:11, Thomas Andraschko <
> andraschko.tho...@gmail.com> escreveu:
>
> > Merged it. Thank you Daniel for the patch!
> > Also "resolved" the JIRA ticket.
> >
> > @Daniel Could you please close your PR then?
> >
> > Am Sa., 1. Dez. 2018 um 17:14 Uhr schrieb Romain Manni-Bucau <
> > rmannibu...@gmail.com>:
> >
> > > Yes, looks good
> > >
> > > Le sam. 1 déc. 2018 14:28, Thomas Andraschko <
> > andraschko.tho...@gmail.com>
> > > a écrit :
> > >
> > > > Can i merge it romain?
> > > >
> > > >
> > > > Am Do., 22. Nov. 2018, 14:39 hat Daniel Cunha 
> > > > geschrieben:
> > > >
> > > > > Ok. patch updated again. :)
> > > > >
> > > > > Em qui, 22 de nov de 2018 às 10:32, Daniel Cunha <
> > daniels...@gmail.com
> > > >
> > > > > escreveu:
> > > > >
> > > > > > Ah..
> > > > > >
> > > > > > Ok, I get it!
> > > > > > Thanks Thomas and Jon
> > > > > >
> > > > > > Em qui, 22 de nov de 2018 às 10:30, Jonathan Gallimore <
> > > > > > jonathan.gallim...@gmail.com> escreveu:
> > > > > >
> > > > > >> I think you can keep ASM 7, but leave this:
> > > > > >>
> > > > > >>
> > > > >
> > > >
> > >
> >
> https://github.com/apache/openwebbeans/pull/13/commits/cb600aada79427ab7eff31e7da92038b6af6ed19#diff-f58069aef7df21dd8d4b0bd3546a747aR104
> > > > > >>
> > > > > >> as `return Opcodes.V1_6;`.
> > > > > >>
> > > > > >> Hope that helps.
> > > > > >>
> > > > > >> Jon
> > > > > >>
> > > > > >> On Thu, Nov 22, 2018 at 1:26 PM Romain Manni-Bucau <
> > > > > rmannibu...@gmail.com
> > > > > >> >
> > > > > >> wrote:
> > > > > >>
> > > > > >> > +1 Thomas
> > > > > >> >
> > > > > >> > Romain Manni-Bucau
> > > > > >> > @rmannibucau  |  Blog
> > > > > >> >  | Old Blog
> > > > > >> >  | Github <
> > > > > >> > https://github.com/rmannibucau> |
> > > > > >> > LinkedIn  | Book
> > > > > >> > <
> > > > > >> >
> > > > > >>
> > > > >
> > > >
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > > > >> > >
> > > > > >> >
> > > > > >> >
> > > > > >> > Le jeu. 22 nov. 2018 à 14:17, Thomas Andraschko <
> > > > > >> > andraschko.tho...@gmail.com>
> > > > > >> > a écrit :
> > > > > >> >
> > > > > >> > > Hi Daniel,
> > > > > >> > >
> > > > > >> > > not sure if i didn't understand it correclty but IMO we
> should
> > > > > >> upgrade to
> > > > > >> > > ASM7 - BUT - default the bytecode version to Java6 or Java7
> in
> > > > > >> > > AbstractProxyFactory#determineDefaultJavaVersion.
> > > > > >> > > Could you please clarify Romain?
> > > > > >> > >
> > > > > >> > > Best regards,
> > > > > >> > > Thomas
> > > > > >> > >
> > > > > >> > > Am Do., 22. Nov. 2018 um 13:48 Uhr schrieb Daniel Cunha <
> > > > > >> > > daniels...@apache.org>:
> > > > > >> > >
> > > > > >> > > > hi folks,
> > > > > >> > > >
> > > > > >> > > > patch updated again:
> > > > > https://github.com/apache/openwebbeans/pull/13
> > > > > >> :)
> > > > > >> > > >
> > > > > >> > > > Em qui, 22 de nov de 2018 às 08:14, Daniel Cunha <
> > > > > >> > daniels...@apache.org>
> > > > > >> > > > escreveu:
> > > > > >> > > >
> > > > > >> > > > > Ok, in this case I'll back the asm changes. I'll update
> > the
> > > > > patch.
> > > > > >> > > > >
> > > > > >> > > > > Em qua, 21 de nov de 2018 7:02 AM, Thomas Andraschko <
> > > > > >> > > > > andraschko.tho...@gmail.com escreveu:
> > > > > >> > > > >
> > > > > >> > > > >> +1 to not change the old default
> > > > > >> > > > >>
> > > > > >> > > > >> Am Di., 20. Nov. 2018 um 21:27 Uhr schrieb Romain
> > > > Manni-Bucau <
> > > > > >> > > > >> rmannibu...@gmail.com>:
> > > > > >> > > > >>
> > > > > >> > > > >> > Except the default to bytecode for java 8 - fear we
> > have
> > > to
> > > > > >> stick
> > > > > >> > to
> > > > > >> > > > j6
> > > > > >> > > > >> or
> > > > > >> > > > >> > 7 if we want to change here - it looks good.
> > > > > >> > > > >> >
> > > > > >> > > > >> > Le mar. 20 nov. 2018 20:59, Thomas Andraschko <
> > > > > >> > > > >> andraschko.tho...@gmail.com
> > > > > >> > > > >> > >
> > > > > >> > > > >> > a écrit :
> > > > > >> > > > >> >
> > > > > >> > > > >> > > @Romain could you do a short review? I could apply
> it
> > > > > >> tomorrow
> > > > > >> > > then.
> > > > > >> > > > >> > >
> > > > > >> > > > >> > > Am Di., 20. Nov. 2018 um 20:37 Uhr schrieb Daniel
> > > Cunha <
> > > > > >> > > > >> > > daniels...@gmail.com>:
> > > > > >> > > > >> > >
> > > > > >> > > > >> > > > Hi Thomas,
> > > > > >> > > > >> > > >
> > > > > >> > > > >> > > > I've updated the patch[1], please review it.
> > > > > >> > > > >> > > > Thank you.
> > > > > >> > > > >> > > >
> > > > > >> > > > >> > > > [1]
> https://github.com/apache/openwebbeans/pull/13
> > > > > >>

Re: Backport for OWB 1.7.x

2018-12-03 Thread Daniel Cunha

Hi Thomas,

Sure, I'll close.
Thank you too!

Em seg, 3 de dez de 2018 às 07:11, Thomas Andraschko <
andraschko.tho...@gmail.com> escreveu:

> Merged it. Thank you Daniel for the patch!
> Also "resolved" the JIRA ticket.
>
> @Daniel Could you please close your PR then?
>
> Am Sa., 1. Dez. 2018 um 17:14 Uhr schrieb Romain Manni-Bucau <
> rmannibu...@gmail.com>:
>
> > Yes, looks good
> >
> > Le sam. 1 déc. 2018 14:28, Thomas Andraschko <
> andraschko.tho...@gmail.com>
> > a écrit :
> >
> > > Can i merge it romain?
> > >
> > >
> > > Am Do., 22. Nov. 2018, 14:39 hat Daniel Cunha 
> > > geschrieben:
> > >
> > > > Ok. patch updated again. :)
> > > >
> > > > Em qui, 22 de nov de 2018 às 10:32, Daniel Cunha <
> daniels...@gmail.com
> > >
> > > > escreveu:
> > > >
> > > > > Ah..
> > > > >
> > > > > Ok, I get it!
> > > > > Thanks Thomas and Jon
> > > > >
> > > > > Em qui, 22 de nov de 2018 às 10:30, Jonathan Gallimore <
> > > > > jonathan.gallim...@gmail.com> escreveu:
> > > > >
> > > > >> I think you can keep ASM 7, but leave this:
> > > > >>
> > > > >>
> > > >
> > >
> >
> https://github.com/apache/openwebbeans/pull/13/commits/cb600aada79427ab7eff31e7da92038b6af6ed19#diff-f58069aef7df21dd8d4b0bd3546a747aR104
> > > > >>
> > > > >> as `return Opcodes.V1_6;`.
> > > > >>
> > > > >> Hope that helps.
> > > > >>
> > > > >> Jon
> > > > >>
> > > > >> On Thu, Nov 22, 2018 at 1:26 PM Romain Manni-Bucau <
> > > > rmannibu...@gmail.com
> > > > >> >
> > > > >> wrote:
> > > > >>
> > > > >> > +1 Thomas
> > > > >> >
> > > > >> > Romain Manni-Bucau
> > > > >> > @rmannibucau  |  Blog
> > > > >> >  | Old Blog
> > > > >> >  | Github <
> > > > >> > https://github.com/rmannibucau> |
> > > > >> > LinkedIn  | Book
> > > > >> > <
> > > > >> >
> > > > >>
> > > >
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > > >> > >
> > > > >> >
> > > > >> >
> > > > >> > Le jeu. 22 nov. 2018 à 14:17, Thomas Andraschko <
> > > > >> > andraschko.tho...@gmail.com>
> > > > >> > a écrit :
> > > > >> >
> > > > >> > > Hi Daniel,
> > > > >> > >
> > > > >> > > not sure if i didn't understand it correclty but IMO we should
> > > > >> upgrade to
> > > > >> > > ASM7 - BUT - default the bytecode version to Java6 or Java7 in
> > > > >> > > AbstractProxyFactory#determineDefaultJavaVersion.
> > > > >> > > Could you please clarify Romain?
> > > > >> > >
> > > > >> > > Best regards,
> > > > >> > > Thomas
> > > > >> > >
> > > > >> > > Am Do., 22. Nov. 2018 um 13:48 Uhr schrieb Daniel Cunha <
> > > > >> > > daniels...@apache.org>:
> > > > >> > >
> > > > >> > > > hi folks,
> > > > >> > > >
> > > > >> > > > patch updated again:
> > > > https://github.com/apache/openwebbeans/pull/13
> > > > >> :)
> > > > >> > > >
> > > > >> > > > Em qui, 22 de nov de 2018 às 08:14, Daniel Cunha <
> > > > >> > daniels...@apache.org>
> > > > >> > > > escreveu:
> > > > >> > > >
> > > > >> > > > > Ok, in this case I'll back the asm changes. I'll update
> the
> > > > patch.
> > > > >> > > > >
> > > > >> > > > > Em qua, 21 de nov de 2018 7:02 AM, Thomas Andraschko <
> > > > >> > > > > andraschko.tho...@gmail.com escreveu:
> > > > >> > > > >
> > > > >> > > > >> +1 to not change the old default
> > > > >> > > > >>
> > > > >> > > > >> Am Di., 20. Nov. 2018 um 21:27 Uhr schrieb Romain
> > > Manni-Bucau <
> > > > >> > > > >> rmannibu...@gmail.com>:
> > > > >> > > > >>
> > > > >> > > > >> > Except the default to bytecode for java 8 - fear we
> have
> > to
> > > > >> stick
> > > > >> > to
> > > > >> > > > j6
> > > > >> > > > >> or
> > > > >> > > > >> > 7 if we want to change here - it looks good.
> > > > >> > > > >> >
> > > > >> > > > >> > Le mar. 20 nov. 2018 20:59, Thomas Andraschko <
> > > > >> > > > >> andraschko.tho...@gmail.com
> > > > >> > > > >> > >
> > > > >> > > > >> > a écrit :
> > > > >> > > > >> >
> > > > >> > > > >> > > @Romain could you do a short review? I could apply it
> > > > >> tomorrow
> > > > >> > > then.
> > > > >> > > > >> > >
> > > > >> > > > >> > > Am Di., 20. Nov. 2018 um 20:37 Uhr schrieb Daniel
> > Cunha <
> > > > >> > > > >> > > daniels...@gmail.com>:
> > > > >> > > > >> > >
> > > > >> > > > >> > > > Hi Thomas,
> > > > >> > > > >> > > >
> > > > >> > > > >> > > > I've updated the patch[1], please review it.
> > > > >> > > > >> > > > Thank you.
> > > > >> > > > >> > > >
> > > > >> > > > >> > > > [1] https://github.com/apache/openwebbeans/pull/13
> > > > >> > > > >> > > >
> > > > >> > > > >> > > > Em ter, 20 de nov de 2018 às 14:06, Daniel Cunha <
> > > > >> > > > >> daniels...@gmail.com
> > > > >> > > > >> > >
> > > > >> > > > >> > > > escreveu:
> > > > >> > > > >> > > >
> > > > >> > > > >> > > > > Hi Thomas,
> > > > >> > > > >> > > > >
> > > > >> > > > >> > > > > sure. I'll working on it. In the same patch.
> > > > >> > > > >> > > > >
> > > > >> > > > >> > > > > Em ter, 20 de nov de 2018 às

Re: Backport for OWB 1.7.x

2018-12-01 Thread Romain Manni-Bucau

Yes, looks good

Le sam. 1 déc. 2018 14:28, Thomas Andraschko 
a écrit :

> Can i merge it romain?
>
>
> Am Do., 22. Nov. 2018, 14:39 hat Daniel Cunha 
> geschrieben:
>
> > Ok. patch updated again. :)
> >
> > Em qui, 22 de nov de 2018 às 10:32, Daniel Cunha 
> > escreveu:
> >
> > > Ah..
> > >
> > > Ok, I get it!
> > > Thanks Thomas and Jon
> > >
> > > Em qui, 22 de nov de 2018 às 10:30, Jonathan Gallimore <
> > > jonathan.gallim...@gmail.com> escreveu:
> > >
> > >> I think you can keep ASM 7, but leave this:
> > >>
> > >>
> >
> https://github.com/apache/openwebbeans/pull/13/commits/cb600aada79427ab7eff31e7da92038b6af6ed19#diff-f58069aef7df21dd8d4b0bd3546a747aR104
> > >>
> > >> as `return Opcodes.V1_6;`.
> > >>
> > >> Hope that helps.
> > >>
> > >> Jon
> > >>
> > >> On Thu, Nov 22, 2018 at 1:26 PM Romain Manni-Bucau <
> > rmannibu...@gmail.com
> > >> >
> > >> wrote:
> > >>
> > >> > +1 Thomas
> > >> >
> > >> > Romain Manni-Bucau
> > >> > @rmannibucau  |  Blog
> > >> >  | Old Blog
> > >> >  | Github <
> > >> > https://github.com/rmannibucau> |
> > >> > LinkedIn  | Book
> > >> > <
> > >> >
> > >>
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > >> > >
> > >> >
> > >> >
> > >> > Le jeu. 22 nov. 2018 à 14:17, Thomas Andraschko <
> > >> > andraschko.tho...@gmail.com>
> > >> > a écrit :
> > >> >
> > >> > > Hi Daniel,
> > >> > >
> > >> > > not sure if i didn't understand it correclty but IMO we should
> > >> upgrade to
> > >> > > ASM7 - BUT - default the bytecode version to Java6 or Java7 in
> > >> > > AbstractProxyFactory#determineDefaultJavaVersion.
> > >> > > Could you please clarify Romain?
> > >> > >
> > >> > > Best regards,
> > >> > > Thomas
> > >> > >
> > >> > > Am Do., 22. Nov. 2018 um 13:48 Uhr schrieb Daniel Cunha <
> > >> > > daniels...@apache.org>:
> > >> > >
> > >> > > > hi folks,
> > >> > > >
> > >> > > > patch updated again:
> > https://github.com/apache/openwebbeans/pull/13
> > >> :)
> > >> > > >
> > >> > > > Em qui, 22 de nov de 2018 às 08:14, Daniel Cunha <
> > >> > daniels...@apache.org>
> > >> > > > escreveu:
> > >> > > >
> > >> > > > > Ok, in this case I'll back the asm changes. I'll update the
> > patch.
> > >> > > > >
> > >> > > > > Em qua, 21 de nov de 2018 7:02 AM, Thomas Andraschko <
> > >> > > > > andraschko.tho...@gmail.com escreveu:
> > >> > > > >
> > >> > > > >> +1 to not change the old default
> > >> > > > >>
> > >> > > > >> Am Di., 20. Nov. 2018 um 21:27 Uhr schrieb Romain
> Manni-Bucau <
> > >> > > > >> rmannibu...@gmail.com>:
> > >> > > > >>
> > >> > > > >> > Except the default to bytecode for java 8 - fear we have to
> > >> stick
> > >> > to
> > >> > > > j6
> > >> > > > >> or
> > >> > > > >> > 7 if we want to change here - it looks good.
> > >> > > > >> >
> > >> > > > >> > Le mar. 20 nov. 2018 20:59, Thomas Andraschko <
> > >> > > > >> andraschko.tho...@gmail.com
> > >> > > > >> > >
> > >> > > > >> > a écrit :
> > >> > > > >> >
> > >> > > > >> > > @Romain could you do a short review? I could apply it
> > >> tomorrow
> > >> > > then.
> > >> > > > >> > >
> > >> > > > >> > > Am Di., 20. Nov. 2018 um 20:37 Uhr schrieb Daniel Cunha <
> > >> > > > >> > > daniels...@gmail.com>:
> > >> > > > >> > >
> > >> > > > >> > > > Hi Thomas,
> > >> > > > >> > > >
> > >> > > > >> > > > I've updated the patch[1], please review it.
> > >> > > > >> > > > Thank you.
> > >> > > > >> > > >
> > >> > > > >> > > > [1] https://github.com/apache/openwebbeans/pull/13
> > >> > > > >> > > >
> > >> > > > >> > > > Em ter, 20 de nov de 2018 às 14:06, Daniel Cunha <
> > >> > > > >> daniels...@gmail.com
> > >> > > > >> > >
> > >> > > > >> > > > escreveu:
> > >> > > > >> > > >
> > >> > > > >> > > > > Hi Thomas,
> > >> > > > >> > > > >
> > >> > > > >> > > > > sure. I'll working on it. In the same patch.
> > >> > > > >> > > > >
> > >> > > > >> > > > > Em ter, 20 de nov de 2018 às 14:03, Thomas
> Andraschko <
> > >> > > > >> > > > > andraschko.tho...@gmail.com> escreveu:
> > >> > > > >> > > > >
> > >> > > > >> > > > >> Yep. Could you please provide a PR (or even a patch
> -
> > i
> > >> > have
> > >> > > to
> > >> > > > >> > merge
> > >> > > > >> > > it
> > >> > > > >> > > > >> manually), so i can commit both?
> > >> > > > >> > > > >>
> > >> > > > >> > > > >> Am Di., 20. Nov. 2018 um 17:41 Uhr schrieb Daniel
> > Cunha
> > >> <
> > >> > > > >> > > > >> daniels...@gmail.com>:
> > >> > > > >> > > > >>
> > >> > > > >> > > > >> > Hi Thomas,
> > >> > > > >> > > > >> >
> > >> > > > >> > > > >> > Good catch! if we want to have support for java 11
> > >> > > > >> (officially) on
> > >> > > > >> > > OWB
> > >> > > > >> > > > >> > 1.7.x, maybe is better to move it to use asm7 as
> > well.
> > >> > > > >> > > > >> >
> > >> > > > >> > > > >> > Em ter, 20 de nov de 2018 às 12:28, Thomas
> > Andraschko
> > >> <
> > >> > > > >> > > > >> >

Re: Backport for OWB 1.7.x

2018-12-01 Thread Thomas Andraschko

Can i merge it romain?


Am Do., 22. Nov. 2018, 14:39 hat Daniel Cunha 
geschrieben:

> Ok. patch updated again. :)
>
> Em qui, 22 de nov de 2018 às 10:32, Daniel Cunha 
> escreveu:
>
> > Ah..
> >
> > Ok, I get it!
> > Thanks Thomas and Jon
> >
> > Em qui, 22 de nov de 2018 às 10:30, Jonathan Gallimore <
> > jonathan.gallim...@gmail.com> escreveu:
> >
> >> I think you can keep ASM 7, but leave this:
> >>
> >>
> https://github.com/apache/openwebbeans/pull/13/commits/cb600aada79427ab7eff31e7da92038b6af6ed19#diff-f58069aef7df21dd8d4b0bd3546a747aR104
> >>
> >> as `return Opcodes.V1_6;`.
> >>
> >> Hope that helps.
> >>
> >> Jon
> >>
> >> On Thu, Nov 22, 2018 at 1:26 PM Romain Manni-Bucau <
> rmannibu...@gmail.com
> >> >
> >> wrote:
> >>
> >> > +1 Thomas
> >> >
> >> > Romain Manni-Bucau
> >> > @rmannibucau  |  Blog
> >> >  | Old Blog
> >> >  | Github <
> >> > https://github.com/rmannibucau> |
> >> > LinkedIn  | Book
> >> > <
> >> >
> >>
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >> > >
> >> >
> >> >
> >> > Le jeu. 22 nov. 2018 à 14:17, Thomas Andraschko <
> >> > andraschko.tho...@gmail.com>
> >> > a écrit :
> >> >
> >> > > Hi Daniel,
> >> > >
> >> > > not sure if i didn't understand it correclty but IMO we should
> >> upgrade to
> >> > > ASM7 - BUT - default the bytecode version to Java6 or Java7 in
> >> > > AbstractProxyFactory#determineDefaultJavaVersion.
> >> > > Could you please clarify Romain?
> >> > >
> >> > > Best regards,
> >> > > Thomas
> >> > >
> >> > > Am Do., 22. Nov. 2018 um 13:48 Uhr schrieb Daniel Cunha <
> >> > > daniels...@apache.org>:
> >> > >
> >> > > > hi folks,
> >> > > >
> >> > > > patch updated again:
> https://github.com/apache/openwebbeans/pull/13
> >> :)
> >> > > >
> >> > > > Em qui, 22 de nov de 2018 às 08:14, Daniel Cunha <
> >> > daniels...@apache.org>
> >> > > > escreveu:
> >> > > >
> >> > > > > Ok, in this case I'll back the asm changes. I'll update the
> patch.
> >> > > > >
> >> > > > > Em qua, 21 de nov de 2018 7:02 AM, Thomas Andraschko <
> >> > > > > andraschko.tho...@gmail.com escreveu:
> >> > > > >
> >> > > > >> +1 to not change the old default
> >> > > > >>
> >> > > > >> Am Di., 20. Nov. 2018 um 21:27 Uhr schrieb Romain Manni-Bucau <
> >> > > > >> rmannibu...@gmail.com>:
> >> > > > >>
> >> > > > >> > Except the default to bytecode for java 8 - fear we have to
> >> stick
> >> > to
> >> > > > j6
> >> > > > >> or
> >> > > > >> > 7 if we want to change here - it looks good.
> >> > > > >> >
> >> > > > >> > Le mar. 20 nov. 2018 20:59, Thomas Andraschko <
> >> > > > >> andraschko.tho...@gmail.com
> >> > > > >> > >
> >> > > > >> > a écrit :
> >> > > > >> >
> >> > > > >> > > @Romain could you do a short review? I could apply it
> >> tomorrow
> >> > > then.
> >> > > > >> > >
> >> > > > >> > > Am Di., 20. Nov. 2018 um 20:37 Uhr schrieb Daniel Cunha <
> >> > > > >> > > daniels...@gmail.com>:
> >> > > > >> > >
> >> > > > >> > > > Hi Thomas,
> >> > > > >> > > >
> >> > > > >> > > > I've updated the patch[1], please review it.
> >> > > > >> > > > Thank you.
> >> > > > >> > > >
> >> > > > >> > > > [1] https://github.com/apache/openwebbeans/pull/13
> >> > > > >> > > >
> >> > > > >> > > > Em ter, 20 de nov de 2018 às 14:06, Daniel Cunha <
> >> > > > >> daniels...@gmail.com
> >> > > > >> > >
> >> > > > >> > > > escreveu:
> >> > > > >> > > >
> >> > > > >> > > > > Hi Thomas,
> >> > > > >> > > > >
> >> > > > >> > > > > sure. I'll working on it. In the same patch.
> >> > > > >> > > > >
> >> > > > >> > > > > Em ter, 20 de nov de 2018 às 14:03, Thomas Andraschko <
> >> > > > >> > > > > andraschko.tho...@gmail.com> escreveu:
> >> > > > >> > > > >
> >> > > > >> > > > >> Yep. Could you please provide a PR (or even a patch -
> i
> >> > have
> >> > > to
> >> > > > >> > merge
> >> > > > >> > > it
> >> > > > >> > > > >> manually), so i can commit both?
> >> > > > >> > > > >>
> >> > > > >> > > > >> Am Di., 20. Nov. 2018 um 17:41 Uhr schrieb Daniel
> Cunha
> >> <
> >> > > > >> > > > >> daniels...@gmail.com>:
> >> > > > >> > > > >>
> >> > > > >> > > > >> > Hi Thomas,
> >> > > > >> > > > >> >
> >> > > > >> > > > >> > Good catch! if we want to have support for java 11
> >> > > > >> (officially) on
> >> > > > >> > > OWB
> >> > > > >> > > > >> > 1.7.x, maybe is better to move it to use asm7 as
> well.
> >> > > > >> > > > >> >
> >> > > > >> > > > >> > Em ter, 20 de nov de 2018 às 12:28, Thomas
> Andraschko
> >> <
> >> > > > >> > > > >> > andraschko.tho...@gmail.com> escreveu:
> >> > > > >> > > > >> >
> >> > > > >> > > > >> > > I could merge it, too but does it really make
> sense
> >> to
> >> > > > apply
> >> > > > >> it
> >> > > > >> > > > >> without
> >> > > > >> > > > >> > > migrating to asm7?
> >> > > > >> > > > >> > >
> >> > > > >> > > > >> > > Am Mo., 19. Nov. 2018 um 16:34 Uhr schrieb Daniel
> >> > Cunha <
> >> > > > >> > > > >> >

Re: Backport for OWB 1.7.x

2018-11-22 Thread Daniel Cunha

Ok. patch updated again. :)

Em qui, 22 de nov de 2018 às 10:32, Daniel Cunha 
escreveu:

> Ah..
>
> Ok, I get it!
> Thanks Thomas and Jon
>
> Em qui, 22 de nov de 2018 às 10:30, Jonathan Gallimore <
> jonathan.gallim...@gmail.com> escreveu:
>
>> I think you can keep ASM 7, but leave this:
>>
>> https://github.com/apache/openwebbeans/pull/13/commits/cb600aada79427ab7eff31e7da92038b6af6ed19#diff-f58069aef7df21dd8d4b0bd3546a747aR104
>>
>> as `return Opcodes.V1_6;`.
>>
>> Hope that helps.
>>
>> Jon
>>
>> On Thu, Nov 22, 2018 at 1:26 PM Romain Manni-Bucau > >
>> wrote:
>>
>> > +1 Thomas
>> >
>> > Romain Manni-Bucau
>> > @rmannibucau  |  Blog
>> >  | Old Blog
>> >  | Github <
>> > https://github.com/rmannibucau> |
>> > LinkedIn  | Book
>> > <
>> >
>> https://www.packtpub.com/application-development/java-ee-8-high-performance
>> > >
>> >
>> >
>> > Le jeu. 22 nov. 2018 à 14:17, Thomas Andraschko <
>> > andraschko.tho...@gmail.com>
>> > a écrit :
>> >
>> > > Hi Daniel,
>> > >
>> > > not sure if i didn't understand it correclty but IMO we should
>> upgrade to
>> > > ASM7 - BUT - default the bytecode version to Java6 or Java7 in
>> > > AbstractProxyFactory#determineDefaultJavaVersion.
>> > > Could you please clarify Romain?
>> > >
>> > > Best regards,
>> > > Thomas
>> > >
>> > > Am Do., 22. Nov. 2018 um 13:48 Uhr schrieb Daniel Cunha <
>> > > daniels...@apache.org>:
>> > >
>> > > > hi folks,
>> > > >
>> > > > patch updated again: https://github.com/apache/openwebbeans/pull/13
>> :)
>> > > >
>> > > > Em qui, 22 de nov de 2018 às 08:14, Daniel Cunha <
>> > daniels...@apache.org>
>> > > > escreveu:
>> > > >
>> > > > > Ok, in this case I'll back the asm changes. I'll update the patch.
>> > > > >
>> > > > > Em qua, 21 de nov de 2018 7:02 AM, Thomas Andraschko <
>> > > > > andraschko.tho...@gmail.com escreveu:
>> > > > >
>> > > > >> +1 to not change the old default
>> > > > >>
>> > > > >> Am Di., 20. Nov. 2018 um 21:27 Uhr schrieb Romain Manni-Bucau <
>> > > > >> rmannibu...@gmail.com>:
>> > > > >>
>> > > > >> > Except the default to bytecode for java 8 - fear we have to
>> stick
>> > to
>> > > > j6
>> > > > >> or
>> > > > >> > 7 if we want to change here - it looks good.
>> > > > >> >
>> > > > >> > Le mar. 20 nov. 2018 20:59, Thomas Andraschko <
>> > > > >> andraschko.tho...@gmail.com
>> > > > >> > >
>> > > > >> > a écrit :
>> > > > >> >
>> > > > >> > > @Romain could you do a short review? I could apply it
>> tomorrow
>> > > then.
>> > > > >> > >
>> > > > >> > > Am Di., 20. Nov. 2018 um 20:37 Uhr schrieb Daniel Cunha <
>> > > > >> > > daniels...@gmail.com>:
>> > > > >> > >
>> > > > >> > > > Hi Thomas,
>> > > > >> > > >
>> > > > >> > > > I've updated the patch[1], please review it.
>> > > > >> > > > Thank you.
>> > > > >> > > >
>> > > > >> > > > [1] https://github.com/apache/openwebbeans/pull/13
>> > > > >> > > >
>> > > > >> > > > Em ter, 20 de nov de 2018 às 14:06, Daniel Cunha <
>> > > > >> daniels...@gmail.com
>> > > > >> > >
>> > > > >> > > > escreveu:
>> > > > >> > > >
>> > > > >> > > > > Hi Thomas,
>> > > > >> > > > >
>> > > > >> > > > > sure. I'll working on it. In the same patch.
>> > > > >> > > > >
>> > > > >> > > > > Em ter, 20 de nov de 2018 às 14:03, Thomas Andraschko <
>> > > > >> > > > > andraschko.tho...@gmail.com> escreveu:
>> > > > >> > > > >
>> > > > >> > > > >> Yep. Could you please provide a PR (or even a patch - i
>> > have
>> > > to
>> > > > >> > merge
>> > > > >> > > it
>> > > > >> > > > >> manually), so i can commit both?
>> > > > >> > > > >>
>> > > > >> > > > >> Am Di., 20. Nov. 2018 um 17:41 Uhr schrieb Daniel Cunha
>> <
>> > > > >> > > > >> daniels...@gmail.com>:
>> > > > >> > > > >>
>> > > > >> > > > >> > Hi Thomas,
>> > > > >> > > > >> >
>> > > > >> > > > >> > Good catch! if we want to have support for java 11
>> > > > >> (officially) on
>> > > > >> > > OWB
>> > > > >> > > > >> > 1.7.x, maybe is better to move it to use asm7 as well.
>> > > > >> > > > >> >
>> > > > >> > > > >> > Em ter, 20 de nov de 2018 às 12:28, Thomas Andraschko
>> <
>> > > > >> > > > >> > andraschko.tho...@gmail.com> escreveu:
>> > > > >> > > > >> >
>> > > > >> > > > >> > > I could merge it, too but does it really make sense
>> to
>> > > > apply
>> > > > >> it
>> > > > >> > > > >> without
>> > > > >> > > > >> > > migrating to asm7?
>> > > > >> > > > >> > >
>> > > > >> > > > >> > > Am Mo., 19. Nov. 2018 um 16:34 Uhr schrieb Daniel
>> > Cunha <
>> > > > >> > > > >> > > daniels...@apache.org>:
>> > > > >> > > > >> > >
>> > > > >> > > > >> > > > Hi Romain,
>> > > > >> > > > >> > > >
>> > > > >> > > > >> > > > Do we have plan to merge it?
>> > > > >> > > > >> > > > Em ter, 6 de nov de 2018 às 13:13, Romain
>> > Manni-Bucau <
>> > > > >> > > > >> > > > rmannibu...@gmail.com>
>> > > > >> > > > >> > > > escreveu:
>> > > > >> > > > >> > > >
>> > > > >> > > > >> > > > > Hello Daniel,
>> > >

Re: Backport for OWB 1.7.x

2018-11-22 Thread Daniel Cunha

Ah..

Ok, I get it!
Thanks Thomas and Jon

Em qui, 22 de nov de 2018 às 10:30, Jonathan Gallimore <
jonathan.gallim...@gmail.com> escreveu:

> I think you can keep ASM 7, but leave this:
>
> https://github.com/apache/openwebbeans/pull/13/commits/cb600aada79427ab7eff31e7da92038b6af6ed19#diff-f58069aef7df21dd8d4b0bd3546a747aR104
>
> as `return Opcodes.V1_6;`.
>
> Hope that helps.
>
> Jon
>
> On Thu, Nov 22, 2018 at 1:26 PM Romain Manni-Bucau 
> wrote:
>
> > +1 Thomas
> >
> > Romain Manni-Bucau
> > @rmannibucau  |  Blog
> >  | Old Blog
> >  | Github <
> > https://github.com/rmannibucau> |
> > LinkedIn  | Book
> > <
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > >
> >
> >
> > Le jeu. 22 nov. 2018 à 14:17, Thomas Andraschko <
> > andraschko.tho...@gmail.com>
> > a écrit :
> >
> > > Hi Daniel,
> > >
> > > not sure if i didn't understand it correclty but IMO we should upgrade
> to
> > > ASM7 - BUT - default the bytecode version to Java6 or Java7 in
> > > AbstractProxyFactory#determineDefaultJavaVersion.
> > > Could you please clarify Romain?
> > >
> > > Best regards,
> > > Thomas
> > >
> > > Am Do., 22. Nov. 2018 um 13:48 Uhr schrieb Daniel Cunha <
> > > daniels...@apache.org>:
> > >
> > > > hi folks,
> > > >
> > > > patch updated again: https://github.com/apache/openwebbeans/pull/13
> :)
> > > >
> > > > Em qui, 22 de nov de 2018 às 08:14, Daniel Cunha <
> > daniels...@apache.org>
> > > > escreveu:
> > > >
> > > > > Ok, in this case I'll back the asm changes. I'll update the patch.
> > > > >
> > > > > Em qua, 21 de nov de 2018 7:02 AM, Thomas Andraschko <
> > > > > andraschko.tho...@gmail.com escreveu:
> > > > >
> > > > >> +1 to not change the old default
> > > > >>
> > > > >> Am Di., 20. Nov. 2018 um 21:27 Uhr schrieb Romain Manni-Bucau <
> > > > >> rmannibu...@gmail.com>:
> > > > >>
> > > > >> > Except the default to bytecode for java 8 - fear we have to
> stick
> > to
> > > > j6
> > > > >> or
> > > > >> > 7 if we want to change here - it looks good.
> > > > >> >
> > > > >> > Le mar. 20 nov. 2018 20:59, Thomas Andraschko <
> > > > >> andraschko.tho...@gmail.com
> > > > >> > >
> > > > >> > a écrit :
> > > > >> >
> > > > >> > > @Romain could you do a short review? I could apply it tomorrow
> > > then.
> > > > >> > >
> > > > >> > > Am Di., 20. Nov. 2018 um 20:37 Uhr schrieb Daniel Cunha <
> > > > >> > > daniels...@gmail.com>:
> > > > >> > >
> > > > >> > > > Hi Thomas,
> > > > >> > > >
> > > > >> > > > I've updated the patch[1], please review it.
> > > > >> > > > Thank you.
> > > > >> > > >
> > > > >> > > > [1] https://github.com/apache/openwebbeans/pull/13
> > > > >> > > >
> > > > >> > > > Em ter, 20 de nov de 2018 às 14:06, Daniel Cunha <
> > > > >> daniels...@gmail.com
> > > > >> > >
> > > > >> > > > escreveu:
> > > > >> > > >
> > > > >> > > > > Hi Thomas,
> > > > >> > > > >
> > > > >> > > > > sure. I'll working on it. In the same patch.
> > > > >> > > > >
> > > > >> > > > > Em ter, 20 de nov de 2018 às 14:03, Thomas Andraschko <
> > > > >> > > > > andraschko.tho...@gmail.com> escreveu:
> > > > >> > > > >
> > > > >> > > > >> Yep. Could you please provide a PR (or even a patch - i
> > have
> > > to
> > > > >> > merge
> > > > >> > > it
> > > > >> > > > >> manually), so i can commit both?
> > > > >> > > > >>
> > > > >> > > > >> Am Di., 20. Nov. 2018 um 17:41 Uhr schrieb Daniel Cunha <
> > > > >> > > > >> daniels...@gmail.com>:
> > > > >> > > > >>
> > > > >> > > > >> > Hi Thomas,
> > > > >> > > > >> >
> > > > >> > > > >> > Good catch! if we want to have support for java 11
> > > > >> (officially) on
> > > > >> > > OWB
> > > > >> > > > >> > 1.7.x, maybe is better to move it to use asm7 as well.
> > > > >> > > > >> >
> > > > >> > > > >> > Em ter, 20 de nov de 2018 às 12:28, Thomas Andraschko <
> > > > >> > > > >> > andraschko.tho...@gmail.com> escreveu:
> > > > >> > > > >> >
> > > > >> > > > >> > > I could merge it, too but does it really make sense
> to
> > > > apply
> > > > >> it
> > > > >> > > > >> without
> > > > >> > > > >> > > migrating to asm7?
> > > > >> > > > >> > >
> > > > >> > > > >> > > Am Mo., 19. Nov. 2018 um 16:34 Uhr schrieb Daniel
> > Cunha <
> > > > >> > > > >> > > daniels...@apache.org>:
> > > > >> > > > >> > >
> > > > >> > > > >> > > > Hi Romain,
> > > > >> > > > >> > > >
> > > > >> > > > >> > > > Do we have plan to merge it?
> > > > >> > > > >> > > > Em ter, 6 de nov de 2018 às 13:13, Romain
> > Manni-Bucau <
> > > > >> > > > >> > > > rmannibu...@gmail.com>
> > > > >> > > > >> > > > escreveu:
> > > > >> > > > >> > > >
> > > > >> > > > >> > > > > Hello Daniel,
> > > > >> > > > >> > > > >
> > > > >> > > > >> > > > > it is ok for me
> > > > >> > > > >> > > > >
> > > > >> > > > >> > > > > Romain Manni-Bucau
> > > > >> > > > >> > > > > @rmannibucau  |
> > > Blog
> > > > >> > > > >> > > > >

Re: Backport for OWB 1.7.x

2018-11-22 Thread Jonathan Gallimore

I think you can keep ASM 7, but leave this:
https://github.com/apache/openwebbeans/pull/13/commits/cb600aada79427ab7eff31e7da92038b6af6ed19#diff-f58069aef7df21dd8d4b0bd3546a747aR104

as `return Opcodes.V1_6;`.

Hope that helps.

Jon

On Thu, Nov 22, 2018 at 1:26 PM Romain Manni-Bucau 
wrote:

> +1 Thomas
>
> Romain Manni-Bucau
> @rmannibucau  |  Blog
>  | Old Blog
>  | Github <
> https://github.com/rmannibucau> |
> LinkedIn  | Book
> <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
>
>
> Le jeu. 22 nov. 2018 à 14:17, Thomas Andraschko <
> andraschko.tho...@gmail.com>
> a écrit :
>
> > Hi Daniel,
> >
> > not sure if i didn't understand it correclty but IMO we should upgrade to
> > ASM7 - BUT - default the bytecode version to Java6 or Java7 in
> > AbstractProxyFactory#determineDefaultJavaVersion.
> > Could you please clarify Romain?
> >
> > Best regards,
> > Thomas
> >
> > Am Do., 22. Nov. 2018 um 13:48 Uhr schrieb Daniel Cunha <
> > daniels...@apache.org>:
> >
> > > hi folks,
> > >
> > > patch updated again: https://github.com/apache/openwebbeans/pull/13 :)
> > >
> > > Em qui, 22 de nov de 2018 às 08:14, Daniel Cunha <
> daniels...@apache.org>
> > > escreveu:
> > >
> > > > Ok, in this case I'll back the asm changes. I'll update the patch.
> > > >
> > > > Em qua, 21 de nov de 2018 7:02 AM, Thomas Andraschko <
> > > > andraschko.tho...@gmail.com escreveu:
> > > >
> > > >> +1 to not change the old default
> > > >>
> > > >> Am Di., 20. Nov. 2018 um 21:27 Uhr schrieb Romain Manni-Bucau <
> > > >> rmannibu...@gmail.com>:
> > > >>
> > > >> > Except the default to bytecode for java 8 - fear we have to stick
> to
> > > j6
> > > >> or
> > > >> > 7 if we want to change here - it looks good.
> > > >> >
> > > >> > Le mar. 20 nov. 2018 20:59, Thomas Andraschko <
> > > >> andraschko.tho...@gmail.com
> > > >> > >
> > > >> > a écrit :
> > > >> >
> > > >> > > @Romain could you do a short review? I could apply it tomorrow
> > then.
> > > >> > >
> > > >> > > Am Di., 20. Nov. 2018 um 20:37 Uhr schrieb Daniel Cunha <
> > > >> > > daniels...@gmail.com>:
> > > >> > >
> > > >> > > > Hi Thomas,
> > > >> > > >
> > > >> > > > I've updated the patch[1], please review it.
> > > >> > > > Thank you.
> > > >> > > >
> > > >> > > > [1] https://github.com/apache/openwebbeans/pull/13
> > > >> > > >
> > > >> > > > Em ter, 20 de nov de 2018 às 14:06, Daniel Cunha <
> > > >> daniels...@gmail.com
> > > >> > >
> > > >> > > > escreveu:
> > > >> > > >
> > > >> > > > > Hi Thomas,
> > > >> > > > >
> > > >> > > > > sure. I'll working on it. In the same patch.
> > > >> > > > >
> > > >> > > > > Em ter, 20 de nov de 2018 às 14:03, Thomas Andraschko <
> > > >> > > > > andraschko.tho...@gmail.com> escreveu:
> > > >> > > > >
> > > >> > > > >> Yep. Could you please provide a PR (or even a patch - i
> have
> > to
> > > >> > merge
> > > >> > > it
> > > >> > > > >> manually), so i can commit both?
> > > >> > > > >>
> > > >> > > > >> Am Di., 20. Nov. 2018 um 17:41 Uhr schrieb Daniel Cunha <
> > > >> > > > >> daniels...@gmail.com>:
> > > >> > > > >>
> > > >> > > > >> > Hi Thomas,
> > > >> > > > >> >
> > > >> > > > >> > Good catch! if we want to have support for java 11
> > > >> (officially) on
> > > >> > > OWB
> > > >> > > > >> > 1.7.x, maybe is better to move it to use asm7 as well.
> > > >> > > > >> >
> > > >> > > > >> > Em ter, 20 de nov de 2018 às 12:28, Thomas Andraschko <
> > > >> > > > >> > andraschko.tho...@gmail.com> escreveu:
> > > >> > > > >> >
> > > >> > > > >> > > I could merge it, too but does it really make sense to
> > > apply
> > > >> it
> > > >> > > > >> without
> > > >> > > > >> > > migrating to asm7?
> > > >> > > > >> > >
> > > >> > > > >> > > Am Mo., 19. Nov. 2018 um 16:34 Uhr schrieb Daniel
> Cunha <
> > > >> > > > >> > > daniels...@apache.org>:
> > > >> > > > >> > >
> > > >> > > > >> > > > Hi Romain,
> > > >> > > > >> > > >
> > > >> > > > >> > > > Do we have plan to merge it?
> > > >> > > > >> > > > Em ter, 6 de nov de 2018 às 13:13, Romain
> Manni-Bucau <
> > > >> > > > >> > > > rmannibu...@gmail.com>
> > > >> > > > >> > > > escreveu:
> > > >> > > > >> > > >
> > > >> > > > >> > > > > Hello Daniel,
> > > >> > > > >> > > > >
> > > >> > > > >> > > > > it is ok for me
> > > >> > > > >> > > > >
> > > >> > > > >> > > > > Romain Manni-Bucau
> > > >> > > > >> > > > > @rmannibucau  |
> > Blog
> > > >> > > > >> > > > >  | Old Blog
> > > >> > > > >> > > > >  | Github <
> > > >> > > > >> > > > > https://github.com/rmannibucau> |
> > > >> > > > >> > > > > LinkedIn 
> |
> > > >> Book
> > > >> > > > >> > > > > <
> > > >> > > > >> > > > >
> > > >> > > > >> > > >
> > > >> > > > >> > >
> > > >> > > > >> >
> > > >> > > > >>
> > > >> > > >
> > >

Re: Backport for OWB 1.7.x

2018-11-22 Thread Romain Manni-Bucau

+1 Thomas

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le jeu. 22 nov. 2018 à 14:17, Thomas Andraschko 
a écrit :

> Hi Daniel,
>
> not sure if i didn't understand it correclty but IMO we should upgrade to
> ASM7 - BUT - default the bytecode version to Java6 or Java7 in
> AbstractProxyFactory#determineDefaultJavaVersion.
> Could you please clarify Romain?
>
> Best regards,
> Thomas
>
> Am Do., 22. Nov. 2018 um 13:48 Uhr schrieb Daniel Cunha <
> daniels...@apache.org>:
>
> > hi folks,
> >
> > patch updated again: https://github.com/apache/openwebbeans/pull/13 :)
> >
> > Em qui, 22 de nov de 2018 às 08:14, Daniel Cunha 
> > escreveu:
> >
> > > Ok, in this case I'll back the asm changes. I'll update the patch.
> > >
> > > Em qua, 21 de nov de 2018 7:02 AM, Thomas Andraschko <
> > > andraschko.tho...@gmail.com escreveu:
> > >
> > >> +1 to not change the old default
> > >>
> > >> Am Di., 20. Nov. 2018 um 21:27 Uhr schrieb Romain Manni-Bucau <
> > >> rmannibu...@gmail.com>:
> > >>
> > >> > Except the default to bytecode for java 8 - fear we have to stick to
> > j6
> > >> or
> > >> > 7 if we want to change here - it looks good.
> > >> >
> > >> > Le mar. 20 nov. 2018 20:59, Thomas Andraschko <
> > >> andraschko.tho...@gmail.com
> > >> > >
> > >> > a écrit :
> > >> >
> > >> > > @Romain could you do a short review? I could apply it tomorrow
> then.
> > >> > >
> > >> > > Am Di., 20. Nov. 2018 um 20:37 Uhr schrieb Daniel Cunha <
> > >> > > daniels...@gmail.com>:
> > >> > >
> > >> > > > Hi Thomas,
> > >> > > >
> > >> > > > I've updated the patch[1], please review it.
> > >> > > > Thank you.
> > >> > > >
> > >> > > > [1] https://github.com/apache/openwebbeans/pull/13
> > >> > > >
> > >> > > > Em ter, 20 de nov de 2018 às 14:06, Daniel Cunha <
> > >> daniels...@gmail.com
> > >> > >
> > >> > > > escreveu:
> > >> > > >
> > >> > > > > Hi Thomas,
> > >> > > > >
> > >> > > > > sure. I'll working on it. In the same patch.
> > >> > > > >
> > >> > > > > Em ter, 20 de nov de 2018 às 14:03, Thomas Andraschko <
> > >> > > > > andraschko.tho...@gmail.com> escreveu:
> > >> > > > >
> > >> > > > >> Yep. Could you please provide a PR (or even a patch - i have
> to
> > >> > merge
> > >> > > it
> > >> > > > >> manually), so i can commit both?
> > >> > > > >>
> > >> > > > >> Am Di., 20. Nov. 2018 um 17:41 Uhr schrieb Daniel Cunha <
> > >> > > > >> daniels...@gmail.com>:
> > >> > > > >>
> > >> > > > >> > Hi Thomas,
> > >> > > > >> >
> > >> > > > >> > Good catch! if we want to have support for java 11
> > >> (officially) on
> > >> > > OWB
> > >> > > > >> > 1.7.x, maybe is better to move it to use asm7 as well.
> > >> > > > >> >
> > >> > > > >> > Em ter, 20 de nov de 2018 às 12:28, Thomas Andraschko <
> > >> > > > >> > andraschko.tho...@gmail.com> escreveu:
> > >> > > > >> >
> > >> > > > >> > > I could merge it, too but does it really make sense to
> > apply
> > >> it
> > >> > > > >> without
> > >> > > > >> > > migrating to asm7?
> > >> > > > >> > >
> > >> > > > >> > > Am Mo., 19. Nov. 2018 um 16:34 Uhr schrieb Daniel Cunha <
> > >> > > > >> > > daniels...@apache.org>:
> > >> > > > >> > >
> > >> > > > >> > > > Hi Romain,
> > >> > > > >> > > >
> > >> > > > >> > > > Do we have plan to merge it?
> > >> > > > >> > > > Em ter, 6 de nov de 2018 às 13:13, Romain Manni-Bucau <
> > >> > > > >> > > > rmannibu...@gmail.com>
> > >> > > > >> > > > escreveu:
> > >> > > > >> > > >
> > >> > > > >> > > > > Hello Daniel,
> > >> > > > >> > > > >
> > >> > > > >> > > > > it is ok for me
> > >> > > > >> > > > >
> > >> > > > >> > > > > Romain Manni-Bucau
> > >> > > > >> > > > > @rmannibucau  |
> Blog
> > >> > > > >> > > > >  | Old Blog
> > >> > > > >> > > > >  | Github <
> > >> > > > >> > > > > https://github.com/rmannibucau> |
> > >> > > > >> > > > > LinkedIn  |
> > >> Book
> > >> > > > >> > > > > <
> > >> > > > >> > > > >
> > >> > > > >> > > >
> > >> > > > >> > >
> > >> > > > >> >
> > >> > > > >>
> > >> > > >
> > >> > >
> > >> >
> > >>
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > >> > > > >> > > > > >
> > >> > > > >> > > > >
> > >> > > > >> > > > >
> > >> > > > >> > > > > Le mar. 6 nov. 2018 à 16:39, Daniel Cunha <
> > >> > > > daniels...@apache.org>
> > >> > > > >> a
> > >> > > > >> > > > écrit
> > >> > > > >> > > > > :
> > >> > > > >> > > > >
> > >> > > > >> > > > > > Hi Romain,
> > >> > > > >> > > > > >
> > >> > > > >> > > > > > So, the change sounds good to go? Or you still see
> > >> > something
> > >> > > > to
> > >> > > > >> be
> > >> > > > >> > > > > changed?
> > >> > > > >> > > > > >

Re: Backport for OWB 1.7.x

2018-11-22 Thread Thomas Andraschko

Hi Daniel,

not sure if i didn't understand it correclty but IMO we should upgrade to
ASM7 - BUT - default the bytecode version to Java6 or Java7 in
AbstractProxyFactory#determineDefaultJavaVersion.
Could you please clarify Romain?

Best regards,
Thomas

Am Do., 22. Nov. 2018 um 13:48 Uhr schrieb Daniel Cunha <
daniels...@apache.org>:

> hi folks,
>
> patch updated again: https://github.com/apache/openwebbeans/pull/13 :)
>
> Em qui, 22 de nov de 2018 às 08:14, Daniel Cunha 
> escreveu:
>
> > Ok, in this case I'll back the asm changes. I'll update the patch.
> >
> > Em qua, 21 de nov de 2018 7:02 AM, Thomas Andraschko <
> > andraschko.tho...@gmail.com escreveu:
> >
> >> +1 to not change the old default
> >>
> >> Am Di., 20. Nov. 2018 um 21:27 Uhr schrieb Romain Manni-Bucau <
> >> rmannibu...@gmail.com>:
> >>
> >> > Except the default to bytecode for java 8 - fear we have to stick to
> j6
> >> or
> >> > 7 if we want to change here - it looks good.
> >> >
> >> > Le mar. 20 nov. 2018 20:59, Thomas Andraschko <
> >> andraschko.tho...@gmail.com
> >> > >
> >> > a écrit :
> >> >
> >> > > @Romain could you do a short review? I could apply it tomorrow then.
> >> > >
> >> > > Am Di., 20. Nov. 2018 um 20:37 Uhr schrieb Daniel Cunha <
> >> > > daniels...@gmail.com>:
> >> > >
> >> > > > Hi Thomas,
> >> > > >
> >> > > > I've updated the patch[1], please review it.
> >> > > > Thank you.
> >> > > >
> >> > > > [1] https://github.com/apache/openwebbeans/pull/13
> >> > > >
> >> > > > Em ter, 20 de nov de 2018 às 14:06, Daniel Cunha <
> >> daniels...@gmail.com
> >> > >
> >> > > > escreveu:
> >> > > >
> >> > > > > Hi Thomas,
> >> > > > >
> >> > > > > sure. I'll working on it. In the same patch.
> >> > > > >
> >> > > > > Em ter, 20 de nov de 2018 às 14:03, Thomas Andraschko <
> >> > > > > andraschko.tho...@gmail.com> escreveu:
> >> > > > >
> >> > > > >> Yep. Could you please provide a PR (or even a patch - i have to
> >> > merge
> >> > > it
> >> > > > >> manually), so i can commit both?
> >> > > > >>
> >> > > > >> Am Di., 20. Nov. 2018 um 17:41 Uhr schrieb Daniel Cunha <
> >> > > > >> daniels...@gmail.com>:
> >> > > > >>
> >> > > > >> > Hi Thomas,
> >> > > > >> >
> >> > > > >> > Good catch! if we want to have support for java 11
> >> (officially) on
> >> > > OWB
> >> > > > >> > 1.7.x, maybe is better to move it to use asm7 as well.
> >> > > > >> >
> >> > > > >> > Em ter, 20 de nov de 2018 às 12:28, Thomas Andraschko <
> >> > > > >> > andraschko.tho...@gmail.com> escreveu:
> >> > > > >> >
> >> > > > >> > > I could merge it, too but does it really make sense to
> apply
> >> it
> >> > > > >> without
> >> > > > >> > > migrating to asm7?
> >> > > > >> > >
> >> > > > >> > > Am Mo., 19. Nov. 2018 um 16:34 Uhr schrieb Daniel Cunha <
> >> > > > >> > > daniels...@apache.org>:
> >> > > > >> > >
> >> > > > >> > > > Hi Romain,
> >> > > > >> > > >
> >> > > > >> > > > Do we have plan to merge it?
> >> > > > >> > > > Em ter, 6 de nov de 2018 às 13:13, Romain Manni-Bucau <
> >> > > > >> > > > rmannibu...@gmail.com>
> >> > > > >> > > > escreveu:
> >> > > > >> > > >
> >> > > > >> > > > > Hello Daniel,
> >> > > > >> > > > >
> >> > > > >> > > > > it is ok for me
> >> > > > >> > > > >
> >> > > > >> > > > > Romain Manni-Bucau
> >> > > > >> > > > > @rmannibucau  |  Blog
> >> > > > >> > > > >  | Old Blog
> >> > > > >> > > > >  | Github <
> >> > > > >> > > > > https://github.com/rmannibucau> |
> >> > > > >> > > > > LinkedIn  |
> >> Book
> >> > > > >> > > > > <
> >> > > > >> > > > >
> >> > > > >> > > >
> >> > > > >> > >
> >> > > > >> >
> >> > > > >>
> >> > > >
> >> > >
> >> >
> >>
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >> > > > >> > > > > >
> >> > > > >> > > > >
> >> > > > >> > > > >
> >> > > > >> > > > > Le mar. 6 nov. 2018 à 16:39, Daniel Cunha <
> >> > > > daniels...@apache.org>
> >> > > > >> a
> >> > > > >> > > > écrit
> >> > > > >> > > > > :
> >> > > > >> > > > >
> >> > > > >> > > > > > Hi Romain,
> >> > > > >> > > > > >
> >> > > > >> > > > > > So, the change sounds good to go? Or you still see
> >> > something
> >> > > > to
> >> > > > >> be
> >> > > > >> > > > > changed?
> >> > > > >> > > > > >
> >> > > > >> > > > > >
> >> > > > >> > > > > > Em seg, 5 de nov de 2018 3:47 PM, Daniel Cunha <
> >> > > > >> > daniels...@gmail.com
> >> > > > >> > > > > > escreveu:
> >> > > > >> > > > > >
> >> > > > >> > > > > > > Hi Romain,
> >> > > > >> > > > > > >
> >> > > > >> > > > > > > You right, the backport include other things which
> >> are
> >> > > > >> important
> >> > > > >> > as
> >> > > > >> > > > > well
> >> > > > >> > > > > > > like:
> >> > > > >> > > > > > > changes on NormalScopeProxyFactory and
> >> > > > >> > > > > InterceptorDecoratorProxyFactory.
> >> > > > >> > > > > > >
> >> > > > >> > > > > > > But yes, the backport includes the commit that you
> >> > refer.
> >>

Re: Backport for OWB 1.7.x

2018-11-22 Thread Daniel Cunha

hi folks,

patch updated again: https://github.com/apache/openwebbeans/pull/13 :)

Em qui, 22 de nov de 2018 às 08:14, Daniel Cunha 
escreveu:

> Ok, in this case I'll back the asm changes. I'll update the patch.
>
> Em qua, 21 de nov de 2018 7:02 AM, Thomas Andraschko <
> andraschko.tho...@gmail.com escreveu:
>
>> +1 to not change the old default
>>
>> Am Di., 20. Nov. 2018 um 21:27 Uhr schrieb Romain Manni-Bucau <
>> rmannibu...@gmail.com>:
>>
>> > Except the default to bytecode for java 8 - fear we have to stick to j6
>> or
>> > 7 if we want to change here - it looks good.
>> >
>> > Le mar. 20 nov. 2018 20:59, Thomas Andraschko <
>> andraschko.tho...@gmail.com
>> > >
>> > a écrit :
>> >
>> > > @Romain could you do a short review? I could apply it tomorrow then.
>> > >
>> > > Am Di., 20. Nov. 2018 um 20:37 Uhr schrieb Daniel Cunha <
>> > > daniels...@gmail.com>:
>> > >
>> > > > Hi Thomas,
>> > > >
>> > > > I've updated the patch[1], please review it.
>> > > > Thank you.
>> > > >
>> > > > [1] https://github.com/apache/openwebbeans/pull/13
>> > > >
>> > > > Em ter, 20 de nov de 2018 às 14:06, Daniel Cunha <
>> daniels...@gmail.com
>> > >
>> > > > escreveu:
>> > > >
>> > > > > Hi Thomas,
>> > > > >
>> > > > > sure. I'll working on it. In the same patch.
>> > > > >
>> > > > > Em ter, 20 de nov de 2018 às 14:03, Thomas Andraschko <
>> > > > > andraschko.tho...@gmail.com> escreveu:
>> > > > >
>> > > > >> Yep. Could you please provide a PR (or even a patch - i have to
>> > merge
>> > > it
>> > > > >> manually), so i can commit both?
>> > > > >>
>> > > > >> Am Di., 20. Nov. 2018 um 17:41 Uhr schrieb Daniel Cunha <
>> > > > >> daniels...@gmail.com>:
>> > > > >>
>> > > > >> > Hi Thomas,
>> > > > >> >
>> > > > >> > Good catch! if we want to have support for java 11
>> (officially) on
>> > > OWB
>> > > > >> > 1.7.x, maybe is better to move it to use asm7 as well.
>> > > > >> >
>> > > > >> > Em ter, 20 de nov de 2018 às 12:28, Thomas Andraschko <
>> > > > >> > andraschko.tho...@gmail.com> escreveu:
>> > > > >> >
>> > > > >> > > I could merge it, too but does it really make sense to apply
>> it
>> > > > >> without
>> > > > >> > > migrating to asm7?
>> > > > >> > >
>> > > > >> > > Am Mo., 19. Nov. 2018 um 16:34 Uhr schrieb Daniel Cunha <
>> > > > >> > > daniels...@apache.org>:
>> > > > >> > >
>> > > > >> > > > Hi Romain,
>> > > > >> > > >
>> > > > >> > > > Do we have plan to merge it?
>> > > > >> > > > Em ter, 6 de nov de 2018 às 13:13, Romain Manni-Bucau <
>> > > > >> > > > rmannibu...@gmail.com>
>> > > > >> > > > escreveu:
>> > > > >> > > >
>> > > > >> > > > > Hello Daniel,
>> > > > >> > > > >
>> > > > >> > > > > it is ok for me
>> > > > >> > > > >
>> > > > >> > > > > Romain Manni-Bucau
>> > > > >> > > > > @rmannibucau  |  Blog
>> > > > >> > > > >  | Old Blog
>> > > > >> > > > >  | Github <
>> > > > >> > > > > https://github.com/rmannibucau> |
>> > > > >> > > > > LinkedIn  |
>> Book
>> > > > >> > > > > <
>> > > > >> > > > >
>> > > > >> > > >
>> > > > >> > >
>> > > > >> >
>> > > > >>
>> > > >
>> > >
>> >
>> https://www.packtpub.com/application-development/java-ee-8-high-performance
>> > > > >> > > > > >
>> > > > >> > > > >
>> > > > >> > > > >
>> > > > >> > > > > Le mar. 6 nov. 2018 à 16:39, Daniel Cunha <
>> > > > daniels...@apache.org>
>> > > > >> a
>> > > > >> > > > écrit
>> > > > >> > > > > :
>> > > > >> > > > >
>> > > > >> > > > > > Hi Romain,
>> > > > >> > > > > >
>> > > > >> > > > > > So, the change sounds good to go? Or you still see
>> > something
>> > > > to
>> > > > >> be
>> > > > >> > > > > changed?
>> > > > >> > > > > >
>> > > > >> > > > > >
>> > > > >> > > > > > Em seg, 5 de nov de 2018 3:47 PM, Daniel Cunha <
>> > > > >> > daniels...@gmail.com
>> > > > >> > > > > > escreveu:
>> > > > >> > > > > >
>> > > > >> > > > > > > Hi Romain,
>> > > > >> > > > > > >
>> > > > >> > > > > > > You right, the backport include other things which
>> are
>> > > > >> important
>> > > > >> > as
>> > > > >> > > > > well
>> > > > >> > > > > > > like:
>> > > > >> > > > > > > changes on NormalScopeProxyFactory and
>> > > > >> > > > > InterceptorDecoratorProxyFactory.
>> > > > >> > > > > > >
>> > > > >> > > > > > > But yes, the backport includes the commit that you
>> > refer.
>> > > :)
>> > > > >> > > > > > >
>> > > > >> > > > > > > Thank you for your review.
>> > > > >> > > > > > >
>> > > > >> > > > > > > Em seg, 5 de nov de 2018 às 15:41, Romain
>> Manni-Bucau <
>> > > > >> > > > > > > rmannibu...@gmail.com> escreveu:
>> > > > >> > > > > > >
>> > > > >> > > > > > >> Ok I get it now, so this is not *this* commit you
>> want
>> > > but
>> > > > >> one
>> > > > >> > > > before
>> > > > >> > > > > -
>> > > > >> > > > > > >> likely
>> > > > >> > > > > > >>
>> > > > >> > > > > > >>
>> > > > >> > > > > >
>> > > > >> > > > >
>> > > > >> > > >
>> > > > >> > >
>> > > > >> >
>> > > > >>
>> > > >

Re: Backport for OWB 1.7.x

2018-11-22 Thread Daniel Cunha

Ok, in this case I'll back the asm changes. I'll update the patch.

Em qua, 21 de nov de 2018 7:02 AM, Thomas Andraschko <
andraschko.tho...@gmail.com escreveu:

> +1 to not change the old default
>
> Am Di., 20. Nov. 2018 um 21:27 Uhr schrieb Romain Manni-Bucau <
> rmannibu...@gmail.com>:
>
> > Except the default to bytecode for java 8 - fear we have to stick to j6
> or
> > 7 if we want to change here - it looks good.
> >
> > Le mar. 20 nov. 2018 20:59, Thomas Andraschko <
> andraschko.tho...@gmail.com
> > >
> > a écrit :
> >
> > > @Romain could you do a short review? I could apply it tomorrow then.
> > >
> > > Am Di., 20. Nov. 2018 um 20:37 Uhr schrieb Daniel Cunha <
> > > daniels...@gmail.com>:
> > >
> > > > Hi Thomas,
> > > >
> > > > I've updated the patch[1], please review it.
> > > > Thank you.
> > > >
> > > > [1] https://github.com/apache/openwebbeans/pull/13
> > > >
> > > > Em ter, 20 de nov de 2018 às 14:06, Daniel Cunha <
> daniels...@gmail.com
> > >
> > > > escreveu:
> > > >
> > > > > Hi Thomas,
> > > > >
> > > > > sure. I'll working on it. In the same patch.
> > > > >
> > > > > Em ter, 20 de nov de 2018 às 14:03, Thomas Andraschko <
> > > > > andraschko.tho...@gmail.com> escreveu:
> > > > >
> > > > >> Yep. Could you please provide a PR (or even a patch - i have to
> > merge
> > > it
> > > > >> manually), so i can commit both?
> > > > >>
> > > > >> Am Di., 20. Nov. 2018 um 17:41 Uhr schrieb Daniel Cunha <
> > > > >> daniels...@gmail.com>:
> > > > >>
> > > > >> > Hi Thomas,
> > > > >> >
> > > > >> > Good catch! if we want to have support for java 11 (officially)
> on
> > > OWB
> > > > >> > 1.7.x, maybe is better to move it to use asm7 as well.
> > > > >> >
> > > > >> > Em ter, 20 de nov de 2018 às 12:28, Thomas Andraschko <
> > > > >> > andraschko.tho...@gmail.com> escreveu:
> > > > >> >
> > > > >> > > I could merge it, too but does it really make sense to apply
> it
> > > > >> without
> > > > >> > > migrating to asm7?
> > > > >> > >
> > > > >> > > Am Mo., 19. Nov. 2018 um 16:34 Uhr schrieb Daniel Cunha <
> > > > >> > > daniels...@apache.org>:
> > > > >> > >
> > > > >> > > > Hi Romain,
> > > > >> > > >
> > > > >> > > > Do we have plan to merge it?
> > > > >> > > > Em ter, 6 de nov de 2018 às 13:13, Romain Manni-Bucau <
> > > > >> > > > rmannibu...@gmail.com>
> > > > >> > > > escreveu:
> > > > >> > > >
> > > > >> > > > > Hello Daniel,
> > > > >> > > > >
> > > > >> > > > > it is ok for me
> > > > >> > > > >
> > > > >> > > > > Romain Manni-Bucau
> > > > >> > > > > @rmannibucau  |  Blog
> > > > >> > > > >  | Old Blog
> > > > >> > > > >  | Github <
> > > > >> > > > > https://github.com/rmannibucau> |
> > > > >> > > > > LinkedIn  | Book
> > > > >> > > > > <
> > > > >> > > > >
> > > > >> > > >
> > > > >> > >
> > > > >> >
> > > > >>
> > > >
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > > >> > > > > >
> > > > >> > > > >
> > > > >> > > > >
> > > > >> > > > > Le mar. 6 nov. 2018 à 16:39, Daniel Cunha <
> > > > daniels...@apache.org>
> > > > >> a
> > > > >> > > > écrit
> > > > >> > > > > :
> > > > >> > > > >
> > > > >> > > > > > Hi Romain,
> > > > >> > > > > >
> > > > >> > > > > > So, the change sounds good to go? Or you still see
> > something
> > > > to
> > > > >> be
> > > > >> > > > > changed?
> > > > >> > > > > >
> > > > >> > > > > >
> > > > >> > > > > > Em seg, 5 de nov de 2018 3:47 PM, Daniel Cunha <
> > > > >> > daniels...@gmail.com
> > > > >> > > > > > escreveu:
> > > > >> > > > > >
> > > > >> > > > > > > Hi Romain,
> > > > >> > > > > > >
> > > > >> > > > > > > You right, the backport include other things which are
> > > > >> important
> > > > >> > as
> > > > >> > > > > well
> > > > >> > > > > > > like:
> > > > >> > > > > > > changes on NormalScopeProxyFactory and
> > > > >> > > > > InterceptorDecoratorProxyFactory.
> > > > >> > > > > > >
> > > > >> > > > > > > But yes, the backport includes the commit that you
> > refer.
> > > :)
> > > > >> > > > > > >
> > > > >> > > > > > > Thank you for your review.
> > > > >> > > > > > >
> > > > >> > > > > > > Em seg, 5 de nov de 2018 às 15:41, Romain Manni-Bucau
> <
> > > > >> > > > > > > rmannibu...@gmail.com> escreveu:
> > > > >> > > > > > >
> > > > >> > > > > > >> Ok I get it now, so this is not *this* commit you
> want
> > > but
> > > > >> one
> > > > >> > > > before
> > > > >> > > > > -
> > > > >> > > > > > >> likely
> > > > >> > > > > > >>
> > > > >> > > > > > >>
> > > > >> > > > > >
> > > > >> > > > >
> > > > >> > > >
> > > > >> > >
> > > > >> >
> > > > >>
> > > >
> > >
> >
> https://github.com/apache/openwebbeans/commit/92f94b68ae125d171ac26e6a3cbf26b6a3f54513
> > > > >> > > > > > >> - but it was included in the commit you backported
> ;).
> > > > >> > > > > > >>
> > > > >> > > > > > >> makes sense to include that in 1.7 branch IMHO
> > > > >> > > > > > >>
> > > >

Re: Backport for OWB 1.7.x

2018-11-21 Thread Thomas Andraschko

+1 to not change the old default

Am Di., 20. Nov. 2018 um 21:27 Uhr schrieb Romain Manni-Bucau <
rmannibu...@gmail.com>:

> Except the default to bytecode for java 8 - fear we have to stick to j6 or
> 7 if we want to change here - it looks good.
>
> Le mar. 20 nov. 2018 20:59, Thomas Andraschko  >
> a écrit :
>
> > @Romain could you do a short review? I could apply it tomorrow then.
> >
> > Am Di., 20. Nov. 2018 um 20:37 Uhr schrieb Daniel Cunha <
> > daniels...@gmail.com>:
> >
> > > Hi Thomas,
> > >
> > > I've updated the patch[1], please review it.
> > > Thank you.
> > >
> > > [1] https://github.com/apache/openwebbeans/pull/13
> > >
> > > Em ter, 20 de nov de 2018 às 14:06, Daniel Cunha  >
> > > escreveu:
> > >
> > > > Hi Thomas,
> > > >
> > > > sure. I'll working on it. In the same patch.
> > > >
> > > > Em ter, 20 de nov de 2018 às 14:03, Thomas Andraschko <
> > > > andraschko.tho...@gmail.com> escreveu:
> > > >
> > > >> Yep. Could you please provide a PR (or even a patch - i have to
> merge
> > it
> > > >> manually), so i can commit both?
> > > >>
> > > >> Am Di., 20. Nov. 2018 um 17:41 Uhr schrieb Daniel Cunha <
> > > >> daniels...@gmail.com>:
> > > >>
> > > >> > Hi Thomas,
> > > >> >
> > > >> > Good catch! if we want to have support for java 11 (officially) on
> > OWB
> > > >> > 1.7.x, maybe is better to move it to use asm7 as well.
> > > >> >
> > > >> > Em ter, 20 de nov de 2018 às 12:28, Thomas Andraschko <
> > > >> > andraschko.tho...@gmail.com> escreveu:
> > > >> >
> > > >> > > I could merge it, too but does it really make sense to apply it
> > > >> without
> > > >> > > migrating to asm7?
> > > >> > >
> > > >> > > Am Mo., 19. Nov. 2018 um 16:34 Uhr schrieb Daniel Cunha <
> > > >> > > daniels...@apache.org>:
> > > >> > >
> > > >> > > > Hi Romain,
> > > >> > > >
> > > >> > > > Do we have plan to merge it?
> > > >> > > > Em ter, 6 de nov de 2018 às 13:13, Romain Manni-Bucau <
> > > >> > > > rmannibu...@gmail.com>
> > > >> > > > escreveu:
> > > >> > > >
> > > >> > > > > Hello Daniel,
> > > >> > > > >
> > > >> > > > > it is ok for me
> > > >> > > > >
> > > >> > > > > Romain Manni-Bucau
> > > >> > > > > @rmannibucau  |  Blog
> > > >> > > > >  | Old Blog
> > > >> > > > >  | Github <
> > > >> > > > > https://github.com/rmannibucau> |
> > > >> > > > > LinkedIn  | Book
> > > >> > > > > <
> > > >> > > > >
> > > >> > > >
> > > >> > >
> > > >> >
> > > >>
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > >> > > > > >
> > > >> > > > >
> > > >> > > > >
> > > >> > > > > Le mar. 6 nov. 2018 à 16:39, Daniel Cunha <
> > > daniels...@apache.org>
> > > >> a
> > > >> > > > écrit
> > > >> > > > > :
> > > >> > > > >
> > > >> > > > > > Hi Romain,
> > > >> > > > > >
> > > >> > > > > > So, the change sounds good to go? Or you still see
> something
> > > to
> > > >> be
> > > >> > > > > changed?
> > > >> > > > > >
> > > >> > > > > >
> > > >> > > > > > Em seg, 5 de nov de 2018 3:47 PM, Daniel Cunha <
> > > >> > daniels...@gmail.com
> > > >> > > > > > escreveu:
> > > >> > > > > >
> > > >> > > > > > > Hi Romain,
> > > >> > > > > > >
> > > >> > > > > > > You right, the backport include other things which are
> > > >> important
> > > >> > as
> > > >> > > > > well
> > > >> > > > > > > like:
> > > >> > > > > > > changes on NormalScopeProxyFactory and
> > > >> > > > > InterceptorDecoratorProxyFactory.
> > > >> > > > > > >
> > > >> > > > > > > But yes, the backport includes the commit that you
> refer.
> > :)
> > > >> > > > > > >
> > > >> > > > > > > Thank you for your review.
> > > >> > > > > > >
> > > >> > > > > > > Em seg, 5 de nov de 2018 às 15:41, Romain Manni-Bucau <
> > > >> > > > > > > rmannibu...@gmail.com> escreveu:
> > > >> > > > > > >
> > > >> > > > > > >> Ok I get it now, so this is not *this* commit you want
> > but
> > > >> one
> > > >> > > > before
> > > >> > > > > -
> > > >> > > > > > >> likely
> > > >> > > > > > >>
> > > >> > > > > > >>
> > > >> > > > > >
> > > >> > > > >
> > > >> > > >
> > > >> > >
> > > >> >
> > > >>
> > >
> >
> https://github.com/apache/openwebbeans/commit/92f94b68ae125d171ac26e6a3cbf26b6a3f54513
> > > >> > > > > > >> - but it was included in the commit you backported ;).
> > > >> > > > > > >>
> > > >> > > > > > >> makes sense to include that in 1.7 branch IMHO
> > > >> > > > > > >>
> > > >> > > > > > >> Romain Manni-Bucau
> > > >> > > > > > >> @rmannibucau  |  Blog
> > > >> > > > > > >>  | Old Blog
> > > >> > > > > > >>  | Github <
> > > >> > > > > > >> https://github.com/rmannibucau> |
> > > >> > > > > > >> LinkedIn  |
> > Book
> > > >> > > > > > >> <
> > > >> > > > > > >>
> > > >> > > > > >
> > > >> > > > >
> > > >> > > >
> > > >> > >
> > > >> >
> > > >>
> > >
> >
>

Re: Backport for OWB 1.7.x

2018-11-20 Thread Romain Manni-Bucau

Except the default to bytecode for java 8 - fear we have to stick to j6 or
7 if we want to change here - it looks good.

Le mar. 20 nov. 2018 20:59, Thomas Andraschko 
a écrit :

> @Romain could you do a short review? I could apply it tomorrow then.
>
> Am Di., 20. Nov. 2018 um 20:37 Uhr schrieb Daniel Cunha <
> daniels...@gmail.com>:
>
> > Hi Thomas,
> >
> > I've updated the patch[1], please review it.
> > Thank you.
> >
> > [1] https://github.com/apache/openwebbeans/pull/13
> >
> > Em ter, 20 de nov de 2018 às 14:06, Daniel Cunha 
> > escreveu:
> >
> > > Hi Thomas,
> > >
> > > sure. I'll working on it. In the same patch.
> > >
> > > Em ter, 20 de nov de 2018 às 14:03, Thomas Andraschko <
> > > andraschko.tho...@gmail.com> escreveu:
> > >
> > >> Yep. Could you please provide a PR (or even a patch - i have to merge
> it
> > >> manually), so i can commit both?
> > >>
> > >> Am Di., 20. Nov. 2018 um 17:41 Uhr schrieb Daniel Cunha <
> > >> daniels...@gmail.com>:
> > >>
> > >> > Hi Thomas,
> > >> >
> > >> > Good catch! if we want to have support for java 11 (officially) on
> OWB
> > >> > 1.7.x, maybe is better to move it to use asm7 as well.
> > >> >
> > >> > Em ter, 20 de nov de 2018 às 12:28, Thomas Andraschko <
> > >> > andraschko.tho...@gmail.com> escreveu:
> > >> >
> > >> > > I could merge it, too but does it really make sense to apply it
> > >> without
> > >> > > migrating to asm7?
> > >> > >
> > >> > > Am Mo., 19. Nov. 2018 um 16:34 Uhr schrieb Daniel Cunha <
> > >> > > daniels...@apache.org>:
> > >> > >
> > >> > > > Hi Romain,
> > >> > > >
> > >> > > > Do we have plan to merge it?
> > >> > > > Em ter, 6 de nov de 2018 às 13:13, Romain Manni-Bucau <
> > >> > > > rmannibu...@gmail.com>
> > >> > > > escreveu:
> > >> > > >
> > >> > > > > Hello Daniel,
> > >> > > > >
> > >> > > > > it is ok for me
> > >> > > > >
> > >> > > > > Romain Manni-Bucau
> > >> > > > > @rmannibucau  |  Blog
> > >> > > > >  | Old Blog
> > >> > > > >  | Github <
> > >> > > > > https://github.com/rmannibucau> |
> > >> > > > > LinkedIn  | Book
> > >> > > > > <
> > >> > > > >
> > >> > > >
> > >> > >
> > >> >
> > >>
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > >> > > > > >
> > >> > > > >
> > >> > > > >
> > >> > > > > Le mar. 6 nov. 2018 à 16:39, Daniel Cunha <
> > daniels...@apache.org>
> > >> a
> > >> > > > écrit
> > >> > > > > :
> > >> > > > >
> > >> > > > > > Hi Romain,
> > >> > > > > >
> > >> > > > > > So, the change sounds good to go? Or you still see something
> > to
> > >> be
> > >> > > > > changed?
> > >> > > > > >
> > >> > > > > >
> > >> > > > > > Em seg, 5 de nov de 2018 3:47 PM, Daniel Cunha <
> > >> > daniels...@gmail.com
> > >> > > > > > escreveu:
> > >> > > > > >
> > >> > > > > > > Hi Romain,
> > >> > > > > > >
> > >> > > > > > > You right, the backport include other things which are
> > >> important
> > >> > as
> > >> > > > > well
> > >> > > > > > > like:
> > >> > > > > > > changes on NormalScopeProxyFactory and
> > >> > > > > InterceptorDecoratorProxyFactory.
> > >> > > > > > >
> > >> > > > > > > But yes, the backport includes the commit that you refer.
> :)
> > >> > > > > > >
> > >> > > > > > > Thank you for your review.
> > >> > > > > > >
> > >> > > > > > > Em seg, 5 de nov de 2018 às 15:41, Romain Manni-Bucau <
> > >> > > > > > > rmannibu...@gmail.com> escreveu:
> > >> > > > > > >
> > >> > > > > > >> Ok I get it now, so this is not *this* commit you want
> but
> > >> one
> > >> > > > before
> > >> > > > > -
> > >> > > > > > >> likely
> > >> > > > > > >>
> > >> > > > > > >>
> > >> > > > > >
> > >> > > > >
> > >> > > >
> > >> > >
> > >> >
> > >>
> >
> https://github.com/apache/openwebbeans/commit/92f94b68ae125d171ac26e6a3cbf26b6a3f54513
> > >> > > > > > >> - but it was included in the commit you backported ;).
> > >> > > > > > >>
> > >> > > > > > >> makes sense to include that in 1.7 branch IMHO
> > >> > > > > > >>
> > >> > > > > > >> Romain Manni-Bucau
> > >> > > > > > >> @rmannibucau  |  Blog
> > >> > > > > > >>  | Old Blog
> > >> > > > > > >>  | Github <
> > >> > > > > > >> https://github.com/rmannibucau> |
> > >> > > > > > >> LinkedIn  |
> Book
> > >> > > > > > >> <
> > >> > > > > > >>
> > >> > > > > >
> > >> > > > >
> > >> > > >
> > >> > >
> > >> >
> > >>
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > >> > > > > > >> >
> > >> > > > > > >>
> > >> > > > > > >>
> > >> > > > > > >> Le lun. 5 nov. 2018 à 19:35, Daniel Cunha <
> > >> > daniels...@apache.org>
> > >> > > a
> > >> > > > > > >> écrit :
> > >> > > > > > >>
> > >> > > > > > >> > Of course, the issue happening when I'm using JDK11 :)
> > >> > > > > > >> >
> > >> > > > > > >> > Em seg, 5 de nov de 2018

Re: Backport for OWB 1.7.x

2018-11-20 Thread Thomas Andraschko

@Romain could you do a short review? I could apply it tomorrow then.

Am Di., 20. Nov. 2018 um 20:37 Uhr schrieb Daniel Cunha <
daniels...@gmail.com>:

> Hi Thomas,
>
> I've updated the patch[1], please review it.
> Thank you.
>
> [1] https://github.com/apache/openwebbeans/pull/13
>
> Em ter, 20 de nov de 2018 às 14:06, Daniel Cunha 
> escreveu:
>
> > Hi Thomas,
> >
> > sure. I'll working on it. In the same patch.
> >
> > Em ter, 20 de nov de 2018 às 14:03, Thomas Andraschko <
> > andraschko.tho...@gmail.com> escreveu:
> >
> >> Yep. Could you please provide a PR (or even a patch - i have to merge it
> >> manually), so i can commit both?
> >>
> >> Am Di., 20. Nov. 2018 um 17:41 Uhr schrieb Daniel Cunha <
> >> daniels...@gmail.com>:
> >>
> >> > Hi Thomas,
> >> >
> >> > Good catch! if we want to have support for java 11 (officially) on OWB
> >> > 1.7.x, maybe is better to move it to use asm7 as well.
> >> >
> >> > Em ter, 20 de nov de 2018 às 12:28, Thomas Andraschko <
> >> > andraschko.tho...@gmail.com> escreveu:
> >> >
> >> > > I could merge it, too but does it really make sense to apply it
> >> without
> >> > > migrating to asm7?
> >> > >
> >> > > Am Mo., 19. Nov. 2018 um 16:34 Uhr schrieb Daniel Cunha <
> >> > > daniels...@apache.org>:
> >> > >
> >> > > > Hi Romain,
> >> > > >
> >> > > > Do we have plan to merge it?
> >> > > > Em ter, 6 de nov de 2018 às 13:13, Romain Manni-Bucau <
> >> > > > rmannibu...@gmail.com>
> >> > > > escreveu:
> >> > > >
> >> > > > > Hello Daniel,
> >> > > > >
> >> > > > > it is ok for me
> >> > > > >
> >> > > > > Romain Manni-Bucau
> >> > > > > @rmannibucau  |  Blog
> >> > > > >  | Old Blog
> >> > > > >  | Github <
> >> > > > > https://github.com/rmannibucau> |
> >> > > > > LinkedIn  | Book
> >> > > > > <
> >> > > > >
> >> > > >
> >> > >
> >> >
> >>
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >> > > > > >
> >> > > > >
> >> > > > >
> >> > > > > Le mar. 6 nov. 2018 à 16:39, Daniel Cunha <
> daniels...@apache.org>
> >> a
> >> > > > écrit
> >> > > > > :
> >> > > > >
> >> > > > > > Hi Romain,
> >> > > > > >
> >> > > > > > So, the change sounds good to go? Or you still see something
> to
> >> be
> >> > > > > changed?
> >> > > > > >
> >> > > > > >
> >> > > > > > Em seg, 5 de nov de 2018 3:47 PM, Daniel Cunha <
> >> > daniels...@gmail.com
> >> > > > > > escreveu:
> >> > > > > >
> >> > > > > > > Hi Romain,
> >> > > > > > >
> >> > > > > > > You right, the backport include other things which are
> >> important
> >> > as
> >> > > > > well
> >> > > > > > > like:
> >> > > > > > > changes on NormalScopeProxyFactory and
> >> > > > > InterceptorDecoratorProxyFactory.
> >> > > > > > >
> >> > > > > > > But yes, the backport includes the commit that you refer. :)
> >> > > > > > >
> >> > > > > > > Thank you for your review.
> >> > > > > > >
> >> > > > > > > Em seg, 5 de nov de 2018 às 15:41, Romain Manni-Bucau <
> >> > > > > > > rmannibu...@gmail.com> escreveu:
> >> > > > > > >
> >> > > > > > >> Ok I get it now, so this is not *this* commit you want but
> >> one
> >> > > > before
> >> > > > > -
> >> > > > > > >> likely
> >> > > > > > >>
> >> > > > > > >>
> >> > > > > >
> >> > > > >
> >> > > >
> >> > >
> >> >
> >>
> https://github.com/apache/openwebbeans/commit/92f94b68ae125d171ac26e6a3cbf26b6a3f54513
> >> > > > > > >> - but it was included in the commit you backported ;).
> >> > > > > > >>
> >> > > > > > >> makes sense to include that in 1.7 branch IMHO
> >> > > > > > >>
> >> > > > > > >> Romain Manni-Bucau
> >> > > > > > >> @rmannibucau  |  Blog
> >> > > > > > >>  | Old Blog
> >> > > > > > >>  | Github <
> >> > > > > > >> https://github.com/rmannibucau> |
> >> > > > > > >> LinkedIn  | Book
> >> > > > > > >> <
> >> > > > > > >>
> >> > > > > >
> >> > > > >
> >> > > >
> >> > >
> >> >
> >>
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >> > > > > > >> >
> >> > > > > > >>
> >> > > > > > >>
> >> > > > > > >> Le lun. 5 nov. 2018 à 19:35, Daniel Cunha <
> >> > daniels...@apache.org>
> >> > > a
> >> > > > > > >> écrit :
> >> > > > > > >>
> >> > > > > > >> > Of course, the issue happening when I'm using JDK11 :)
> >> > > > > > >> >
> >> > > > > > >> > Em seg, 5 de nov de 2018 às 15:33, Daniel Cunha <
> >> > > > > daniels...@gmail.com
> >> > > > > > >
> >> > > > > > >> > escreveu:
> >> > > > > > >> >
> >> > > > > > >> > > Hi Romain,
> >> > > > > > >> > >
> >> > > > > > >> > > Well... that change make me possible to continue create
> >> my
> >> > > > > singleton
> >> > > > > > >> > > startup like it:
> >> > > > > > >> > >
> >> > > > > > >> > > import javax.annotation.PostConstruct;
> >> > > > > > >> > > import javax.annotation.PreDestroy;
> >> > > > > > >> > >

Re: Backport for OWB 1.7.x

2018-11-20 Thread Daniel Cunha

Hi Thomas,

I've updated the patch[1], please review it.
Thank you.

[1] https://github.com/apache/openwebbeans/pull/13

Em ter, 20 de nov de 2018 às 14:06, Daniel Cunha 
escreveu:

> Hi Thomas,
>
> sure. I'll working on it. In the same patch.
>
> Em ter, 20 de nov de 2018 às 14:03, Thomas Andraschko <
> andraschko.tho...@gmail.com> escreveu:
>
>> Yep. Could you please provide a PR (or even a patch - i have to merge it
>> manually), so i can commit both?
>>
>> Am Di., 20. Nov. 2018 um 17:41 Uhr schrieb Daniel Cunha <
>> daniels...@gmail.com>:
>>
>> > Hi Thomas,
>> >
>> > Good catch! if we want to have support for java 11 (officially) on OWB
>> > 1.7.x, maybe is better to move it to use asm7 as well.
>> >
>> > Em ter, 20 de nov de 2018 às 12:28, Thomas Andraschko <
>> > andraschko.tho...@gmail.com> escreveu:
>> >
>> > > I could merge it, too but does it really make sense to apply it
>> without
>> > > migrating to asm7?
>> > >
>> > > Am Mo., 19. Nov. 2018 um 16:34 Uhr schrieb Daniel Cunha <
>> > > daniels...@apache.org>:
>> > >
>> > > > Hi Romain,
>> > > >
>> > > > Do we have plan to merge it?
>> > > > Em ter, 6 de nov de 2018 às 13:13, Romain Manni-Bucau <
>> > > > rmannibu...@gmail.com>
>> > > > escreveu:
>> > > >
>> > > > > Hello Daniel,
>> > > > >
>> > > > > it is ok for me
>> > > > >
>> > > > > Romain Manni-Bucau
>> > > > > @rmannibucau  |  Blog
>> > > > >  | Old Blog
>> > > > >  | Github <
>> > > > > https://github.com/rmannibucau> |
>> > > > > LinkedIn  | Book
>> > > > > <
>> > > > >
>> > > >
>> > >
>> >
>> https://www.packtpub.com/application-development/java-ee-8-high-performance
>> > > > > >
>> > > > >
>> > > > >
>> > > > > Le mar. 6 nov. 2018 à 16:39, Daniel Cunha 
>> a
>> > > > écrit
>> > > > > :
>> > > > >
>> > > > > > Hi Romain,
>> > > > > >
>> > > > > > So, the change sounds good to go? Or you still see something to
>> be
>> > > > > changed?
>> > > > > >
>> > > > > >
>> > > > > > Em seg, 5 de nov de 2018 3:47 PM, Daniel Cunha <
>> > daniels...@gmail.com
>> > > > > > escreveu:
>> > > > > >
>> > > > > > > Hi Romain,
>> > > > > > >
>> > > > > > > You right, the backport include other things which are
>> important
>> > as
>> > > > > well
>> > > > > > > like:
>> > > > > > > changes on NormalScopeProxyFactory and
>> > > > > InterceptorDecoratorProxyFactory.
>> > > > > > >
>> > > > > > > But yes, the backport includes the commit that you refer. :)
>> > > > > > >
>> > > > > > > Thank you for your review.
>> > > > > > >
>> > > > > > > Em seg, 5 de nov de 2018 às 15:41, Romain Manni-Bucau <
>> > > > > > > rmannibu...@gmail.com> escreveu:
>> > > > > > >
>> > > > > > >> Ok I get it now, so this is not *this* commit you want but
>> one
>> > > > before
>> > > > > -
>> > > > > > >> likely
>> > > > > > >>
>> > > > > > >>
>> > > > > >
>> > > > >
>> > > >
>> > >
>> >
>> https://github.com/apache/openwebbeans/commit/92f94b68ae125d171ac26e6a3cbf26b6a3f54513
>> > > > > > >> - but it was included in the commit you backported ;).
>> > > > > > >>
>> > > > > > >> makes sense to include that in 1.7 branch IMHO
>> > > > > > >>
>> > > > > > >> Romain Manni-Bucau
>> > > > > > >> @rmannibucau  |  Blog
>> > > > > > >>  | Old Blog
>> > > > > > >>  | Github <
>> > > > > > >> https://github.com/rmannibucau> |
>> > > > > > >> LinkedIn  | Book
>> > > > > > >> <
>> > > > > > >>
>> > > > > >
>> > > > >
>> > > >
>> > >
>> >
>> https://www.packtpub.com/application-development/java-ee-8-high-performance
>> > > > > > >> >
>> > > > > > >>
>> > > > > > >>
>> > > > > > >> Le lun. 5 nov. 2018 à 19:35, Daniel Cunha <
>> > daniels...@apache.org>
>> > > a
>> > > > > > >> écrit :
>> > > > > > >>
>> > > > > > >> > Of course, the issue happening when I'm using JDK11 :)
>> > > > > > >> >
>> > > > > > >> > Em seg, 5 de nov de 2018 às 15:33, Daniel Cunha <
>> > > > > daniels...@gmail.com
>> > > > > > >
>> > > > > > >> > escreveu:
>> > > > > > >> >
>> > > > > > >> > > Hi Romain,
>> > > > > > >> > >
>> > > > > > >> > > Well... that change make me possible to continue create
>> my
>> > > > > singleton
>> > > > > > >> > > startup like it:
>> > > > > > >> > >
>> > > > > > >> > > import javax.annotation.PostConstruct;
>> > > > > > >> > > import javax.annotation.PreDestroy;
>> > > > > > >> > > import javax.ejb.Singleton;
>> > > > > > >> > > import javax.ejb.Startup;
>> > > > > > >> > >
>> > > > > > >> > > @Singleton
>> > > > > > >> > > @Startup
>> > > > > > >> > > public class KernelShutdownListener {
>> > > > > > >> > >
>> > > > > > >> > > @PostConstruct
>> > > > > > >> > > private void startup() {
>> > > > > > >> > > System.out.println("ALOHA STARTUP");
>> > > > > > >> > > }
>> > > > > > >> > >
>> > > > > > >> > > @PreDestroy
>> > > > > > >> > >

Re: Backport for OWB 1.7.x

2018-11-20 Thread Daniel Cunha

Hi Thomas,

sure. I'll working on it. In the same patch.

Em ter, 20 de nov de 2018 às 14:03, Thomas Andraschko <
andraschko.tho...@gmail.com> escreveu:

> Yep. Could you please provide a PR (or even a patch - i have to merge it
> manually), so i can commit both?
>
> Am Di., 20. Nov. 2018 um 17:41 Uhr schrieb Daniel Cunha <
> daniels...@gmail.com>:
>
> > Hi Thomas,
> >
> > Good catch! if we want to have support for java 11 (officially) on OWB
> > 1.7.x, maybe is better to move it to use asm7 as well.
> >
> > Em ter, 20 de nov de 2018 às 12:28, Thomas Andraschko <
> > andraschko.tho...@gmail.com> escreveu:
> >
> > > I could merge it, too but does it really make sense to apply it without
> > > migrating to asm7?
> > >
> > > Am Mo., 19. Nov. 2018 um 16:34 Uhr schrieb Daniel Cunha <
> > > daniels...@apache.org>:
> > >
> > > > Hi Romain,
> > > >
> > > > Do we have plan to merge it?
> > > > Em ter, 6 de nov de 2018 às 13:13, Romain Manni-Bucau <
> > > > rmannibu...@gmail.com>
> > > > escreveu:
> > > >
> > > > > Hello Daniel,
> > > > >
> > > > > it is ok for me
> > > > >
> > > > > Romain Manni-Bucau
> > > > > @rmannibucau  |  Blog
> > > > >  | Old Blog
> > > > >  | Github <
> > > > > https://github.com/rmannibucau> |
> > > > > LinkedIn  | Book
> > > > > <
> > > > >
> > > >
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > > > >
> > > > >
> > > > >
> > > > > Le mar. 6 nov. 2018 à 16:39, Daniel Cunha 
> a
> > > > écrit
> > > > > :
> > > > >
> > > > > > Hi Romain,
> > > > > >
> > > > > > So, the change sounds good to go? Or you still see something to
> be
> > > > > changed?
> > > > > >
> > > > > >
> > > > > > Em seg, 5 de nov de 2018 3:47 PM, Daniel Cunha <
> > daniels...@gmail.com
> > > > > > escreveu:
> > > > > >
> > > > > > > Hi Romain,
> > > > > > >
> > > > > > > You right, the backport include other things which are
> important
> > as
> > > > > well
> > > > > > > like:
> > > > > > > changes on NormalScopeProxyFactory and
> > > > > InterceptorDecoratorProxyFactory.
> > > > > > >
> > > > > > > But yes, the backport includes the commit that you refer. :)
> > > > > > >
> > > > > > > Thank you for your review.
> > > > > > >
> > > > > > > Em seg, 5 de nov de 2018 às 15:41, Romain Manni-Bucau <
> > > > > > > rmannibu...@gmail.com> escreveu:
> > > > > > >
> > > > > > >> Ok I get it now, so this is not *this* commit you want but one
> > > > before
> > > > > -
> > > > > > >> likely
> > > > > > >>
> > > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/openwebbeans/commit/92f94b68ae125d171ac26e6a3cbf26b6a3f54513
> > > > > > >> - but it was included in the commit you backported ;).
> > > > > > >>
> > > > > > >> makes sense to include that in 1.7 branch IMHO
> > > > > > >>
> > > > > > >> Romain Manni-Bucau
> > > > > > >> @rmannibucau  |  Blog
> > > > > > >>  | Old Blog
> > > > > > >>  | Github <
> > > > > > >> https://github.com/rmannibucau> |
> > > > > > >> LinkedIn  | Book
> > > > > > >> <
> > > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > > > > >> >
> > > > > > >>
> > > > > > >>
> > > > > > >> Le lun. 5 nov. 2018 à 19:35, Daniel Cunha <
> > daniels...@apache.org>
> > > a
> > > > > > >> écrit :
> > > > > > >>
> > > > > > >> > Of course, the issue happening when I'm using JDK11 :)
> > > > > > >> >
> > > > > > >> > Em seg, 5 de nov de 2018 às 15:33, Daniel Cunha <
> > > > > daniels...@gmail.com
> > > > > > >
> > > > > > >> > escreveu:
> > > > > > >> >
> > > > > > >> > > Hi Romain,
> > > > > > >> > >
> > > > > > >> > > Well... that change make me possible to continue create my
> > > > > singleton
> > > > > > >> > > startup like it:
> > > > > > >> > >
> > > > > > >> > > import javax.annotation.PostConstruct;
> > > > > > >> > > import javax.annotation.PreDestroy;
> > > > > > >> > > import javax.ejb.Singleton;
> > > > > > >> > > import javax.ejb.Startup;
> > > > > > >> > >
> > > > > > >> > > @Singleton
> > > > > > >> > > @Startup
> > > > > > >> > > public class KernelShutdownListener {
> > > > > > >> > >
> > > > > > >> > > @PostConstruct
> > > > > > >> > > private void startup() {
> > > > > > >> > > System.out.println("ALOHA STARTUP");
> > > > > > >> > > }
> > > > > > >> > >
> > > > > > >> > > @PreDestroy
> > > > > > >> > > private void shutdown() {
> > > > > > >> > > System.out.println("ALOHA SHUTDOWN");
> > > > > > >> > > }
> > > > > > >> > > }
> > > > > > >> > >
> > > > > > >> > > It was not possible without that change, as you can see
> > here:
> > > > > > >> > > Caused by: java.lang.IllegalStateException: Cannot get
> > > > > > >>

Re: Backport for OWB 1.7.x

2018-11-20 Thread Thomas Andraschko

Yep. Could you please provide a PR (or even a patch - i have to merge it
manually), so i can commit both?

Am Di., 20. Nov. 2018 um 17:41 Uhr schrieb Daniel Cunha <
daniels...@gmail.com>:

> Hi Thomas,
>
> Good catch! if we want to have support for java 11 (officially) on OWB
> 1.7.x, maybe is better to move it to use asm7 as well.
>
> Em ter, 20 de nov de 2018 às 12:28, Thomas Andraschko <
> andraschko.tho...@gmail.com> escreveu:
>
> > I could merge it, too but does it really make sense to apply it without
> > migrating to asm7?
> >
> > Am Mo., 19. Nov. 2018 um 16:34 Uhr schrieb Daniel Cunha <
> > daniels...@apache.org>:
> >
> > > Hi Romain,
> > >
> > > Do we have plan to merge it?
> > > Em ter, 6 de nov de 2018 às 13:13, Romain Manni-Bucau <
> > > rmannibu...@gmail.com>
> > > escreveu:
> > >
> > > > Hello Daniel,
> > > >
> > > > it is ok for me
> > > >
> > > > Romain Manni-Bucau
> > > > @rmannibucau  |  Blog
> > > >  | Old Blog
> > > >  | Github <
> > > > https://github.com/rmannibucau> |
> > > > LinkedIn  | Book
> > > > <
> > > >
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > > >
> > > >
> > > >
> > > > Le mar. 6 nov. 2018 à 16:39, Daniel Cunha  a
> > > écrit
> > > > :
> > > >
> > > > > Hi Romain,
> > > > >
> > > > > So, the change sounds good to go? Or you still see something to be
> > > > changed?
> > > > >
> > > > >
> > > > > Em seg, 5 de nov de 2018 3:47 PM, Daniel Cunha <
> daniels...@gmail.com
> > > > > escreveu:
> > > > >
> > > > > > Hi Romain,
> > > > > >
> > > > > > You right, the backport include other things which are important
> as
> > > > well
> > > > > > like:
> > > > > > changes on NormalScopeProxyFactory and
> > > > InterceptorDecoratorProxyFactory.
> > > > > >
> > > > > > But yes, the backport includes the commit that you refer. :)
> > > > > >
> > > > > > Thank you for your review.
> > > > > >
> > > > > > Em seg, 5 de nov de 2018 às 15:41, Romain Manni-Bucau <
> > > > > > rmannibu...@gmail.com> escreveu:
> > > > > >
> > > > > >> Ok I get it now, so this is not *this* commit you want but one
> > > before
> > > > -
> > > > > >> likely
> > > > > >>
> > > > > >>
> > > > >
> > > >
> > >
> >
> https://github.com/apache/openwebbeans/commit/92f94b68ae125d171ac26e6a3cbf26b6a3f54513
> > > > > >> - but it was included in the commit you backported ;).
> > > > > >>
> > > > > >> makes sense to include that in 1.7 branch IMHO
> > > > > >>
> > > > > >> Romain Manni-Bucau
> > > > > >> @rmannibucau  |  Blog
> > > > > >>  | Old Blog
> > > > > >>  | Github <
> > > > > >> https://github.com/rmannibucau> |
> > > > > >> LinkedIn  | Book
> > > > > >> <
> > > > > >>
> > > > >
> > > >
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > > > >> >
> > > > > >>
> > > > > >>
> > > > > >> Le lun. 5 nov. 2018 à 19:35, Daniel Cunha <
> daniels...@apache.org>
> > a
> > > > > >> écrit :
> > > > > >>
> > > > > >> > Of course, the issue happening when I'm using JDK11 :)
> > > > > >> >
> > > > > >> > Em seg, 5 de nov de 2018 às 15:33, Daniel Cunha <
> > > > daniels...@gmail.com
> > > > > >
> > > > > >> > escreveu:
> > > > > >> >
> > > > > >> > > Hi Romain,
> > > > > >> > >
> > > > > >> > > Well... that change make me possible to continue create my
> > > > singleton
> > > > > >> > > startup like it:
> > > > > >> > >
> > > > > >> > > import javax.annotation.PostConstruct;
> > > > > >> > > import javax.annotation.PreDestroy;
> > > > > >> > > import javax.ejb.Singleton;
> > > > > >> > > import javax.ejb.Startup;
> > > > > >> > >
> > > > > >> > > @Singleton
> > > > > >> > > @Startup
> > > > > >> > > public class KernelShutdownListener {
> > > > > >> > >
> > > > > >> > > @PostConstruct
> > > > > >> > > private void startup() {
> > > > > >> > > System.out.println("ALOHA STARTUP");
> > > > > >> > > }
> > > > > >> > >
> > > > > >> > > @PreDestroy
> > > > > >> > > private void shutdown() {
> > > > > >> > > System.out.println("ALOHA SHUTDOWN");
> > > > > >> > > }
> > > > > >> > > }
> > > > > >> > >
> > > > > >> > > It was not possible without that change, as you can see
> here:
> > > > > >> > > Caused by: java.lang.IllegalStateException: Cannot get
> > > > > >> Unsafe.defineClass
> > > > > >> > > at
> > > > > >> > >
> > > > > >> >
> > > > > >>
> > > > >
> > > >
> > >
> >
> org.apache.webbeans.proxy.AbstractProxyFactory$4.run(AbstractProxyFactory.java:812)
> > > > > >> > > at
> > > > > >> > >
> > > > > >> >
> > > > > >>
> > > > >
> > > >
> > >
> >
> org.apache.webbeans.proxy.AbstractProxyFactory$4.run(AbstractProxyFactory.java:801)
> > > > > >> > > at
> > > >

Re: Backport for OWB 1.7.x

2018-11-20 Thread Daniel Cunha

Hi Thomas,

Good catch! if we want to have support for java 11 (officially) on OWB
1.7.x, maybe is better to move it to use asm7 as well.

Em ter, 20 de nov de 2018 às 12:28, Thomas Andraschko <
andraschko.tho...@gmail.com> escreveu:

> I could merge it, too but does it really make sense to apply it without
> migrating to asm7?
>
> Am Mo., 19. Nov. 2018 um 16:34 Uhr schrieb Daniel Cunha <
> daniels...@apache.org>:
>
> > Hi Romain,
> >
> > Do we have plan to merge it?
> > Em ter, 6 de nov de 2018 às 13:13, Romain Manni-Bucau <
> > rmannibu...@gmail.com>
> > escreveu:
> >
> > > Hello Daniel,
> > >
> > > it is ok for me
> > >
> > > Romain Manni-Bucau
> > > @rmannibucau  |  Blog
> > >  | Old Blog
> > >  | Github <
> > > https://github.com/rmannibucau> |
> > > LinkedIn  | Book
> > > <
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > >
> > >
> > >
> > > Le mar. 6 nov. 2018 à 16:39, Daniel Cunha  a
> > écrit
> > > :
> > >
> > > > Hi Romain,
> > > >
> > > > So, the change sounds good to go? Or you still see something to be
> > > changed?
> > > >
> > > >
> > > > Em seg, 5 de nov de 2018 3:47 PM, Daniel Cunha  > > > escreveu:
> > > >
> > > > > Hi Romain,
> > > > >
> > > > > You right, the backport include other things which are important as
> > > well
> > > > > like:
> > > > > changes on NormalScopeProxyFactory and
> > > InterceptorDecoratorProxyFactory.
> > > > >
> > > > > But yes, the backport includes the commit that you refer. :)
> > > > >
> > > > > Thank you for your review.
> > > > >
> > > > > Em seg, 5 de nov de 2018 às 15:41, Romain Manni-Bucau <
> > > > > rmannibu...@gmail.com> escreveu:
> > > > >
> > > > >> Ok I get it now, so this is not *this* commit you want but one
> > before
> > > -
> > > > >> likely
> > > > >>
> > > > >>
> > > >
> > >
> >
> https://github.com/apache/openwebbeans/commit/92f94b68ae125d171ac26e6a3cbf26b6a3f54513
> > > > >> - but it was included in the commit you backported ;).
> > > > >>
> > > > >> makes sense to include that in 1.7 branch IMHO
> > > > >>
> > > > >> Romain Manni-Bucau
> > > > >> @rmannibucau  |  Blog
> > > > >>  | Old Blog
> > > > >>  | Github <
> > > > >> https://github.com/rmannibucau> |
> > > > >> LinkedIn  | Book
> > > > >> <
> > > > >>
> > > >
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > > >> >
> > > > >>
> > > > >>
> > > > >> Le lun. 5 nov. 2018 à 19:35, Daniel Cunha 
> a
> > > > >> écrit :
> > > > >>
> > > > >> > Of course, the issue happening when I'm using JDK11 :)
> > > > >> >
> > > > >> > Em seg, 5 de nov de 2018 às 15:33, Daniel Cunha <
> > > daniels...@gmail.com
> > > > >
> > > > >> > escreveu:
> > > > >> >
> > > > >> > > Hi Romain,
> > > > >> > >
> > > > >> > > Well... that change make me possible to continue create my
> > > singleton
> > > > >> > > startup like it:
> > > > >> > >
> > > > >> > > import javax.annotation.PostConstruct;
> > > > >> > > import javax.annotation.PreDestroy;
> > > > >> > > import javax.ejb.Singleton;
> > > > >> > > import javax.ejb.Startup;
> > > > >> > >
> > > > >> > > @Singleton
> > > > >> > > @Startup
> > > > >> > > public class KernelShutdownListener {
> > > > >> > >
> > > > >> > > @PostConstruct
> > > > >> > > private void startup() {
> > > > >> > > System.out.println("ALOHA STARTUP");
> > > > >> > > }
> > > > >> > >
> > > > >> > > @PreDestroy
> > > > >> > > private void shutdown() {
> > > > >> > > System.out.println("ALOHA SHUTDOWN");
> > > > >> > > }
> > > > >> > > }
> > > > >> > >
> > > > >> > > It was not possible without that change, as you can see here:
> > > > >> > > Caused by: java.lang.IllegalStateException: Cannot get
> > > > >> Unsafe.defineClass
> > > > >> > > at
> > > > >> > >
> > > > >> >
> > > > >>
> > > >
> > >
> >
> org.apache.webbeans.proxy.AbstractProxyFactory$4.run(AbstractProxyFactory.java:812)
> > > > >> > > at
> > > > >> > >
> > > > >> >
> > > > >>
> > > >
> > >
> >
> org.apache.webbeans.proxy.AbstractProxyFactory$4.run(AbstractProxyFactory.java:801)
> > > > >> > > at
> > > java.base/java.security.AccessController.doPrivileged(Native
> > > > >> > Method)
> > > > >> > > at
> > > > >> > >
> > > > >> >
> > > > >>
> > > >
> > >
> >
> org.apache.webbeans.proxy.AbstractProxyFactory.initializeUnsafe(AbstractProxyFactory.java:800)
> > > > >> > > at
> > > > >> > >
> > > > >> >
> > > > >>
> > > >
> > >
> >
> org.apache.webbeans.proxy.AbstractProxyFactory.(AbstractProxyFactory.java:91)
> > > > >> > > at
> > > > >> > >
> > > > >> >
> > > > >>
> > > >
> > >
> >
> org.apache.webbeans.proxy.InterceptorDecoratorProxyFactory.(InterceptorDecoratorProxyFactory.java:77)
> > > > >> > >

Re: Backport for OWB 1.7.x

2018-11-20 Thread Thomas Andraschko

I could merge it, too but does it really make sense to apply it without
migrating to asm7?

Am Mo., 19. Nov. 2018 um 16:34 Uhr schrieb Daniel Cunha <
daniels...@apache.org>:

> Hi Romain,
>
> Do we have plan to merge it?
> Em ter, 6 de nov de 2018 às 13:13, Romain Manni-Bucau <
> rmannibu...@gmail.com>
> escreveu:
>
> > Hello Daniel,
> >
> > it is ok for me
> >
> > Romain Manni-Bucau
> > @rmannibucau  |  Blog
> >  | Old Blog
> >  | Github <
> > https://github.com/rmannibucau> |
> > LinkedIn  | Book
> > <
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > >
> >
> >
> > Le mar. 6 nov. 2018 à 16:39, Daniel Cunha  a
> écrit
> > :
> >
> > > Hi Romain,
> > >
> > > So, the change sounds good to go? Or you still see something to be
> > changed?
> > >
> > >
> > > Em seg, 5 de nov de 2018 3:47 PM, Daniel Cunha  > > escreveu:
> > >
> > > > Hi Romain,
> > > >
> > > > You right, the backport include other things which are important as
> > well
> > > > like:
> > > > changes on NormalScopeProxyFactory and
> > InterceptorDecoratorProxyFactory.
> > > >
> > > > But yes, the backport includes the commit that you refer. :)
> > > >
> > > > Thank you for your review.
> > > >
> > > > Em seg, 5 de nov de 2018 às 15:41, Romain Manni-Bucau <
> > > > rmannibu...@gmail.com> escreveu:
> > > >
> > > >> Ok I get it now, so this is not *this* commit you want but one
> before
> > -
> > > >> likely
> > > >>
> > > >>
> > >
> >
> https://github.com/apache/openwebbeans/commit/92f94b68ae125d171ac26e6a3cbf26b6a3f54513
> > > >> - but it was included in the commit you backported ;).
> > > >>
> > > >> makes sense to include that in 1.7 branch IMHO
> > > >>
> > > >> Romain Manni-Bucau
> > > >> @rmannibucau  |  Blog
> > > >>  | Old Blog
> > > >>  | Github <
> > > >> https://github.com/rmannibucau> |
> > > >> LinkedIn  | Book
> > > >> <
> > > >>
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > >> >
> > > >>
> > > >>
> > > >> Le lun. 5 nov. 2018 à 19:35, Daniel Cunha  a
> > > >> écrit :
> > > >>
> > > >> > Of course, the issue happening when I'm using JDK11 :)
> > > >> >
> > > >> > Em seg, 5 de nov de 2018 às 15:33, Daniel Cunha <
> > daniels...@gmail.com
> > > >
> > > >> > escreveu:
> > > >> >
> > > >> > > Hi Romain,
> > > >> > >
> > > >> > > Well... that change make me possible to continue create my
> > singleton
> > > >> > > startup like it:
> > > >> > >
> > > >> > > import javax.annotation.PostConstruct;
> > > >> > > import javax.annotation.PreDestroy;
> > > >> > > import javax.ejb.Singleton;
> > > >> > > import javax.ejb.Startup;
> > > >> > >
> > > >> > > @Singleton
> > > >> > > @Startup
> > > >> > > public class KernelShutdownListener {
> > > >> > >
> > > >> > > @PostConstruct
> > > >> > > private void startup() {
> > > >> > > System.out.println("ALOHA STARTUP");
> > > >> > > }
> > > >> > >
> > > >> > > @PreDestroy
> > > >> > > private void shutdown() {
> > > >> > > System.out.println("ALOHA SHUTDOWN");
> > > >> > > }
> > > >> > > }
> > > >> > >
> > > >> > > It was not possible without that change, as you can see here:
> > > >> > > Caused by: java.lang.IllegalStateException: Cannot get
> > > >> Unsafe.defineClass
> > > >> > > at
> > > >> > >
> > > >> >
> > > >>
> > >
> >
> org.apache.webbeans.proxy.AbstractProxyFactory$4.run(AbstractProxyFactory.java:812)
> > > >> > > at
> > > >> > >
> > > >> >
> > > >>
> > >
> >
> org.apache.webbeans.proxy.AbstractProxyFactory$4.run(AbstractProxyFactory.java:801)
> > > >> > > at
> > java.base/java.security.AccessController.doPrivileged(Native
> > > >> > Method)
> > > >> > > at
> > > >> > >
> > > >> >
> > > >>
> > >
> >
> org.apache.webbeans.proxy.AbstractProxyFactory.initializeUnsafe(AbstractProxyFactory.java:800)
> > > >> > > at
> > > >> > >
> > > >> >
> > > >>
> > >
> >
> org.apache.webbeans.proxy.AbstractProxyFactory.(AbstractProxyFactory.java:91)
> > > >> > > at
> > > >> > >
> > > >> >
> > > >>
> > >
> >
> org.apache.webbeans.proxy.InterceptorDecoratorProxyFactory.(InterceptorDecoratorProxyFactory.java:77)
> > > >> > > at
> > > >> > >
> > > >> >
> > > >>
> > >
> >
> org.apache.webbeans.config.WebBeansContext.(WebBeansContext.java:153)
> > > >> > > at
> > > >> > >
> > > >> >
> > > >>
> > >
> >
> org.apache.webbeans.config.WebBeansContext.(WebBeansContext.java:116)
> > > >> > > at
> > > >> > >
> > > >> >
> > > >>
> > >
> >
> org.apache.openejb.cdi.ThreadSingletonServiceImpl.initialize(ThreadSingletonServiceImpl.java:167)
> > > >> > > at
> org.apache.openejb.cdi.CdiBuilder.build(CdiBuilder.java:41)
> > > >> > > at
> > > >> > >
> > > >> >
> > > >>
> > >
> >
>

Re: Backport for OWB 1.7.x

2018-11-19 Thread Daniel Cunha

Hi Romain,

Do we have plan to merge it?
Em ter, 6 de nov de 2018 às 13:13, Romain Manni-Bucau 
escreveu:

> Hello Daniel,
>
> it is ok for me
>
> Romain Manni-Bucau
> @rmannibucau  |  Blog
>  | Old Blog
>  | Github <
> https://github.com/rmannibucau> |
> LinkedIn  | Book
> <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
>
>
> Le mar. 6 nov. 2018 à 16:39, Daniel Cunha  a écrit
> :
>
> > Hi Romain,
> >
> > So, the change sounds good to go? Or you still see something to be
> changed?
> >
> >
> > Em seg, 5 de nov de 2018 3:47 PM, Daniel Cunha  > escreveu:
> >
> > > Hi Romain,
> > >
> > > You right, the backport include other things which are important as
> well
> > > like:
> > > changes on NormalScopeProxyFactory and
> InterceptorDecoratorProxyFactory.
> > >
> > > But yes, the backport includes the commit that you refer. :)
> > >
> > > Thank you for your review.
> > >
> > > Em seg, 5 de nov de 2018 às 15:41, Romain Manni-Bucau <
> > > rmannibu...@gmail.com> escreveu:
> > >
> > >> Ok I get it now, so this is not *this* commit you want but one before
> -
> > >> likely
> > >>
> > >>
> >
> https://github.com/apache/openwebbeans/commit/92f94b68ae125d171ac26e6a3cbf26b6a3f54513
> > >> - but it was included in the commit you backported ;).
> > >>
> > >> makes sense to include that in 1.7 branch IMHO
> > >>
> > >> Romain Manni-Bucau
> > >> @rmannibucau  |  Blog
> > >>  | Old Blog
> > >>  | Github <
> > >> https://github.com/rmannibucau> |
> > >> LinkedIn  | Book
> > >> <
> > >>
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > >> >
> > >>
> > >>
> > >> Le lun. 5 nov. 2018 à 19:35, Daniel Cunha  a
> > >> écrit :
> > >>
> > >> > Of course, the issue happening when I'm using JDK11 :)
> > >> >
> > >> > Em seg, 5 de nov de 2018 às 15:33, Daniel Cunha <
> daniels...@gmail.com
> > >
> > >> > escreveu:
> > >> >
> > >> > > Hi Romain,
> > >> > >
> > >> > > Well... that change make me possible to continue create my
> singleton
> > >> > > startup like it:
> > >> > >
> > >> > > import javax.annotation.PostConstruct;
> > >> > > import javax.annotation.PreDestroy;
> > >> > > import javax.ejb.Singleton;
> > >> > > import javax.ejb.Startup;
> > >> > >
> > >> > > @Singleton
> > >> > > @Startup
> > >> > > public class KernelShutdownListener {
> > >> > >
> > >> > > @PostConstruct
> > >> > > private void startup() {
> > >> > > System.out.println("ALOHA STARTUP");
> > >> > > }
> > >> > >
> > >> > > @PreDestroy
> > >> > > private void shutdown() {
> > >> > > System.out.println("ALOHA SHUTDOWN");
> > >> > > }
> > >> > > }
> > >> > >
> > >> > > It was not possible without that change, as you can see here:
> > >> > > Caused by: java.lang.IllegalStateException: Cannot get
> > >> Unsafe.defineClass
> > >> > > at
> > >> > >
> > >> >
> > >>
> >
> org.apache.webbeans.proxy.AbstractProxyFactory$4.run(AbstractProxyFactory.java:812)
> > >> > > at
> > >> > >
> > >> >
> > >>
> >
> org.apache.webbeans.proxy.AbstractProxyFactory$4.run(AbstractProxyFactory.java:801)
> > >> > > at
> java.base/java.security.AccessController.doPrivileged(Native
> > >> > Method)
> > >> > > at
> > >> > >
> > >> >
> > >>
> >
> org.apache.webbeans.proxy.AbstractProxyFactory.initializeUnsafe(AbstractProxyFactory.java:800)
> > >> > > at
> > >> > >
> > >> >
> > >>
> >
> org.apache.webbeans.proxy.AbstractProxyFactory.(AbstractProxyFactory.java:91)
> > >> > > at
> > >> > >
> > >> >
> > >>
> >
> org.apache.webbeans.proxy.InterceptorDecoratorProxyFactory.(InterceptorDecoratorProxyFactory.java:77)
> > >> > > at
> > >> > >
> > >> >
> > >>
> >
> org.apache.webbeans.config.WebBeansContext.(WebBeansContext.java:153)
> > >> > > at
> > >> > >
> > >> >
> > >>
> >
> org.apache.webbeans.config.WebBeansContext.(WebBeansContext.java:116)
> > >> > > at
> > >> > >
> > >> >
> > >>
> >
> org.apache.openejb.cdi.ThreadSingletonServiceImpl.initialize(ThreadSingletonServiceImpl.java:167)
> > >> > > at org.apache.openejb.cdi.CdiBuilder.build(CdiBuilder.java:41)
> > >> > > at
> > >> > >
> > >> >
> > >>
> >
> org.apache.openejb.assembler.classic.Assembler.createApplication(Assembler.java:963)
> > >> > > ... 17 more
> > >> > > Caused by: java.lang.NoSuchMethodException:
> > >> > > sun.misc.Unsafe.defineClass(java.lang.String, [B, int, int,
> > >> > > java.lang.ClassLoader, java.security.ProtectionDomain)
> > >> > > at
> java.base/java.lang.Class.getDeclaredMethod(Class.java:2476)
> > >> > > at
> > >> > >
> > >> >
> > >>
> >
> org.apache.webbeans.proxy.AbstractProxyFactory$4.run(AbstractProxyFactory.java:807)
> > >> > > ... 27 more
> > >> > >
> > >> > >

Re: Backport for OWB 1.7.x

2018-11-06 Thread Romain Manni-Bucau

Hello Daniel,

it is ok for me

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le mar. 6 nov. 2018 à 16:39, Daniel Cunha  a écrit :

> Hi Romain,
>
> So, the change sounds good to go? Or you still see something to be changed?
>
>
> Em seg, 5 de nov de 2018 3:47 PM, Daniel Cunha  escreveu:
>
> > Hi Romain,
> >
> > You right, the backport include other things which are important as well
> > like:
> > changes on NormalScopeProxyFactory and InterceptorDecoratorProxyFactory.
> >
> > But yes, the backport includes the commit that you refer. :)
> >
> > Thank you for your review.
> >
> > Em seg, 5 de nov de 2018 às 15:41, Romain Manni-Bucau <
> > rmannibu...@gmail.com> escreveu:
> >
> >> Ok I get it now, so this is not *this* commit you want but one before -
> >> likely
> >>
> >>
> https://github.com/apache/openwebbeans/commit/92f94b68ae125d171ac26e6a3cbf26b6a3f54513
> >> - but it was included in the commit you backported ;).
> >>
> >> makes sense to include that in 1.7 branch IMHO
> >>
> >> Romain Manni-Bucau
> >> @rmannibucau  |  Blog
> >>  | Old Blog
> >>  | Github <
> >> https://github.com/rmannibucau> |
> >> LinkedIn  | Book
> >> <
> >>
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >> >
> >>
> >>
> >> Le lun. 5 nov. 2018 à 19:35, Daniel Cunha  a
> >> écrit :
> >>
> >> > Of course, the issue happening when I'm using JDK11 :)
> >> >
> >> > Em seg, 5 de nov de 2018 às 15:33, Daniel Cunha  >
> >> > escreveu:
> >> >
> >> > > Hi Romain,
> >> > >
> >> > > Well... that change make me possible to continue create my singleton
> >> > > startup like it:
> >> > >
> >> > > import javax.annotation.PostConstruct;
> >> > > import javax.annotation.PreDestroy;
> >> > > import javax.ejb.Singleton;
> >> > > import javax.ejb.Startup;
> >> > >
> >> > > @Singleton
> >> > > @Startup
> >> > > public class KernelShutdownListener {
> >> > >
> >> > > @PostConstruct
> >> > > private void startup() {
> >> > > System.out.println("ALOHA STARTUP");
> >> > > }
> >> > >
> >> > > @PreDestroy
> >> > > private void shutdown() {
> >> > > System.out.println("ALOHA SHUTDOWN");
> >> > > }
> >> > > }
> >> > >
> >> > > It was not possible without that change, as you can see here:
> >> > > Caused by: java.lang.IllegalStateException: Cannot get
> >> Unsafe.defineClass
> >> > > at
> >> > >
> >> >
> >>
> org.apache.webbeans.proxy.AbstractProxyFactory$4.run(AbstractProxyFactory.java:812)
> >> > > at
> >> > >
> >> >
> >>
> org.apache.webbeans.proxy.AbstractProxyFactory$4.run(AbstractProxyFactory.java:801)
> >> > > at java.base/java.security.AccessController.doPrivileged(Native
> >> > Method)
> >> > > at
> >> > >
> >> >
> >>
> org.apache.webbeans.proxy.AbstractProxyFactory.initializeUnsafe(AbstractProxyFactory.java:800)
> >> > > at
> >> > >
> >> >
> >>
> org.apache.webbeans.proxy.AbstractProxyFactory.(AbstractProxyFactory.java:91)
> >> > > at
> >> > >
> >> >
> >>
> org.apache.webbeans.proxy.InterceptorDecoratorProxyFactory.(InterceptorDecoratorProxyFactory.java:77)
> >> > > at
> >> > >
> >> >
> >>
> org.apache.webbeans.config.WebBeansContext.(WebBeansContext.java:153)
> >> > > at
> >> > >
> >> >
> >>
> org.apache.webbeans.config.WebBeansContext.(WebBeansContext.java:116)
> >> > > at
> >> > >
> >> >
> >>
> org.apache.openejb.cdi.ThreadSingletonServiceImpl.initialize(ThreadSingletonServiceImpl.java:167)
> >> > > at org.apache.openejb.cdi.CdiBuilder.build(CdiBuilder.java:41)
> >> > > at
> >> > >
> >> >
> >>
> org.apache.openejb.assembler.classic.Assembler.createApplication(Assembler.java:963)
> >> > > ... 17 more
> >> > > Caused by: java.lang.NoSuchMethodException:
> >> > > sun.misc.Unsafe.defineClass(java.lang.String, [B, int, int,
> >> > > java.lang.ClassLoader, java.security.ProtectionDomain)
> >> > > at java.base/java.lang.Class.getDeclaredMethod(Class.java:2476)
> >> > > at
> >> > >
> >> >
> >>
> org.apache.webbeans.proxy.AbstractProxyFactory$4.run(AbstractProxyFactory.java:807)
> >> > > ... 27 more
> >> > >
> >> > > 05-Nov-2018 15:15:33.110 SEVERE [localhost-startStop-2]
> >> > > jdk.internal.reflect.NativeMethodAccessorImpl.invoke Error deploying
> >> web
> >> > > application archive
> >> [/tmp/apache-tomee-plume-7.0.6-TT.2/webapps/ROOT.war]
> >> > >  java.lang.IllegalStateException: ContainerBase.addChild: start:
> >> > > org.apache.catalina.LifecycleException: Failed to start component
> >> > > [StandardEngine[Catalina].StandardHost[localhost].StandardContext[]]
> >> > > at
> >> > >
> >> >
>

Re: Backport for OWB 1.7.x

2018-11-06 Thread Daniel Cunha

Hi Romain,

So, the change sounds good to go? Or you still see something to be changed?


Em seg, 5 de nov de 2018 3:47 PM, Daniel Cunha  Hi Romain,
>
> You right, the backport include other things which are important as well
> like:
> changes on NormalScopeProxyFactory and InterceptorDecoratorProxyFactory.
>
> But yes, the backport includes the commit that you refer. :)
>
> Thank you for your review.
>
> Em seg, 5 de nov de 2018 às 15:41, Romain Manni-Bucau <
> rmannibu...@gmail.com> escreveu:
>
>> Ok I get it now, so this is not *this* commit you want but one before -
>> likely
>>
>> https://github.com/apache/openwebbeans/commit/92f94b68ae125d171ac26e6a3cbf26b6a3f54513
>> - but it was included in the commit you backported ;).
>>
>> makes sense to include that in 1.7 branch IMHO
>>
>> Romain Manni-Bucau
>> @rmannibucau  |  Blog
>>  | Old Blog
>>  | Github <
>> https://github.com/rmannibucau> |
>> LinkedIn  | Book
>> <
>> https://www.packtpub.com/application-development/java-ee-8-high-performance
>> >
>>
>>
>> Le lun. 5 nov. 2018 à 19:35, Daniel Cunha  a
>> écrit :
>>
>> > Of course, the issue happening when I'm using JDK11 :)
>> >
>> > Em seg, 5 de nov de 2018 às 15:33, Daniel Cunha 
>> > escreveu:
>> >
>> > > Hi Romain,
>> > >
>> > > Well... that change make me possible to continue create my singleton
>> > > startup like it:
>> > >
>> > > import javax.annotation.PostConstruct;
>> > > import javax.annotation.PreDestroy;
>> > > import javax.ejb.Singleton;
>> > > import javax.ejb.Startup;
>> > >
>> > > @Singleton
>> > > @Startup
>> > > public class KernelShutdownListener {
>> > >
>> > > @PostConstruct
>> > > private void startup() {
>> > > System.out.println("ALOHA STARTUP");
>> > > }
>> > >
>> > > @PreDestroy
>> > > private void shutdown() {
>> > > System.out.println("ALOHA SHUTDOWN");
>> > > }
>> > > }
>> > >
>> > > It was not possible without that change, as you can see here:
>> > > Caused by: java.lang.IllegalStateException: Cannot get
>> Unsafe.defineClass
>> > > at
>> > >
>> >
>> org.apache.webbeans.proxy.AbstractProxyFactory$4.run(AbstractProxyFactory.java:812)
>> > > at
>> > >
>> >
>> org.apache.webbeans.proxy.AbstractProxyFactory$4.run(AbstractProxyFactory.java:801)
>> > > at java.base/java.security.AccessController.doPrivileged(Native
>> > Method)
>> > > at
>> > >
>> >
>> org.apache.webbeans.proxy.AbstractProxyFactory.initializeUnsafe(AbstractProxyFactory.java:800)
>> > > at
>> > >
>> >
>> org.apache.webbeans.proxy.AbstractProxyFactory.(AbstractProxyFactory.java:91)
>> > > at
>> > >
>> >
>> org.apache.webbeans.proxy.InterceptorDecoratorProxyFactory.(InterceptorDecoratorProxyFactory.java:77)
>> > > at
>> > >
>> >
>> org.apache.webbeans.config.WebBeansContext.(WebBeansContext.java:153)
>> > > at
>> > >
>> >
>> org.apache.webbeans.config.WebBeansContext.(WebBeansContext.java:116)
>> > > at
>> > >
>> >
>> org.apache.openejb.cdi.ThreadSingletonServiceImpl.initialize(ThreadSingletonServiceImpl.java:167)
>> > > at org.apache.openejb.cdi.CdiBuilder.build(CdiBuilder.java:41)
>> > > at
>> > >
>> >
>> org.apache.openejb.assembler.classic.Assembler.createApplication(Assembler.java:963)
>> > > ... 17 more
>> > > Caused by: java.lang.NoSuchMethodException:
>> > > sun.misc.Unsafe.defineClass(java.lang.String, [B, int, int,
>> > > java.lang.ClassLoader, java.security.ProtectionDomain)
>> > > at java.base/java.lang.Class.getDeclaredMethod(Class.java:2476)
>> > > at
>> > >
>> >
>> org.apache.webbeans.proxy.AbstractProxyFactory$4.run(AbstractProxyFactory.java:807)
>> > > ... 27 more
>> > >
>> > > 05-Nov-2018 15:15:33.110 SEVERE [localhost-startStop-2]
>> > > jdk.internal.reflect.NativeMethodAccessorImpl.invoke Error deploying
>> web
>> > > application archive
>> [/tmp/apache-tomee-plume-7.0.6-TT.2/webapps/ROOT.war]
>> > >  java.lang.IllegalStateException: ContainerBase.addChild: start:
>> > > org.apache.catalina.LifecycleException: Failed to start component
>> > > [StandardEngine[Catalina].StandardHost[localhost].StandardContext[]]
>> > > at
>> > >
>> >
>> org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:758)
>> > > at
>> > >
>> org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:730)
>> > > at
>> > > org.apache.catalina.core.StandardHost.addChild(StandardHost.java:734)
>> > > at
>> > > org.apache.catalina.startup.HostConfig.deployWAR(HostConfig.java:985)
>> > > at
>> > >
>> >
>> org.apache.catalina.startup.HostConfig$DeployWar.run(HostConfig.java:1857)
>> > > at
>> > >
>> >
>> java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
>> > > at
>> java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
>> > > at
>> > >
>> >
>>

Re: Backport for OWB 1.7.x

2018-11-05 Thread Romain Manni-Bucau

Ok I get it now, so this is not *this* commit you want but one before -
likely
https://github.com/apache/openwebbeans/commit/92f94b68ae125d171ac26e6a3cbf26b6a3f54513
- but it was included in the commit you backported ;).

makes sense to include that in 1.7 branch IMHO

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le lun. 5 nov. 2018 à 19:35, Daniel Cunha  a écrit :

> Of course, the issue happening when I'm using JDK11 :)
>
> Em seg, 5 de nov de 2018 às 15:33, Daniel Cunha 
> escreveu:
>
> > Hi Romain,
> >
> > Well... that change make me possible to continue create my singleton
> > startup like it:
> >
> > import javax.annotation.PostConstruct;
> > import javax.annotation.PreDestroy;
> > import javax.ejb.Singleton;
> > import javax.ejb.Startup;
> >
> > @Singleton
> > @Startup
> > public class KernelShutdownListener {
> >
> > @PostConstruct
> > private void startup() {
> > System.out.println("ALOHA STARTUP");
> > }
> >
> > @PreDestroy
> > private void shutdown() {
> > System.out.println("ALOHA SHUTDOWN");
> > }
> > }
> >
> > It was not possible without that change, as you can see here:
> > Caused by: java.lang.IllegalStateException: Cannot get Unsafe.defineClass
> > at
> >
> org.apache.webbeans.proxy.AbstractProxyFactory$4.run(AbstractProxyFactory.java:812)
> > at
> >
> org.apache.webbeans.proxy.AbstractProxyFactory$4.run(AbstractProxyFactory.java:801)
> > at java.base/java.security.AccessController.doPrivileged(Native
> Method)
> > at
> >
> org.apache.webbeans.proxy.AbstractProxyFactory.initializeUnsafe(AbstractProxyFactory.java:800)
> > at
> >
> org.apache.webbeans.proxy.AbstractProxyFactory.(AbstractProxyFactory.java:91)
> > at
> >
> org.apache.webbeans.proxy.InterceptorDecoratorProxyFactory.(InterceptorDecoratorProxyFactory.java:77)
> > at
> >
> org.apache.webbeans.config.WebBeansContext.(WebBeansContext.java:153)
> > at
> >
> org.apache.webbeans.config.WebBeansContext.(WebBeansContext.java:116)
> > at
> >
> org.apache.openejb.cdi.ThreadSingletonServiceImpl.initialize(ThreadSingletonServiceImpl.java:167)
> > at org.apache.openejb.cdi.CdiBuilder.build(CdiBuilder.java:41)
> > at
> >
> org.apache.openejb.assembler.classic.Assembler.createApplication(Assembler.java:963)
> > ... 17 more
> > Caused by: java.lang.NoSuchMethodException:
> > sun.misc.Unsafe.defineClass(java.lang.String, [B, int, int,
> > java.lang.ClassLoader, java.security.ProtectionDomain)
> > at java.base/java.lang.Class.getDeclaredMethod(Class.java:2476)
> > at
> >
> org.apache.webbeans.proxy.AbstractProxyFactory$4.run(AbstractProxyFactory.java:807)
> > ... 27 more
> >
> > 05-Nov-2018 15:15:33.110 SEVERE [localhost-startStop-2]
> > jdk.internal.reflect.NativeMethodAccessorImpl.invoke Error deploying web
> > application archive [/tmp/apache-tomee-plume-7.0.6-TT.2/webapps/ROOT.war]
> >  java.lang.IllegalStateException: ContainerBase.addChild: start:
> > org.apache.catalina.LifecycleException: Failed to start component
> > [StandardEngine[Catalina].StandardHost[localhost].StandardContext[]]
> > at
> >
> org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:758)
> > at
> > org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:730)
> > at
> > org.apache.catalina.core.StandardHost.addChild(StandardHost.java:734)
> > at
> > org.apache.catalina.startup.HostConfig.deployWAR(HostConfig.java:985)
> > at
> >
> org.apache.catalina.startup.HostConfig$DeployWar.run(HostConfig.java:1857)
> > at
> >
> java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
> > at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> > at
> >
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> > at
> >
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> > at java.base/java.lang.Thread.run(Thread.java:834)
> >
> >
> > Em seg, 5 de nov de 2018 às 15:24, Romain Manni-Bucau <
> > rmannibu...@gmail.com> escreveu:
> >
> >> Hi Daniel,
> >>
> >> Do you know which part implies the "need", this commit was not suppose
> to
> >> change anything since the code was already supporting java 11, it was
> just
> >> intended to prepare potential change later on.
> >> Did a small change in the behavior was introduced - if so it was not
> >> intended from my part?
> >>
> >> Romain Manni-Bucau
> >> @rmannibucau  |  Blog
> >>  | Old Blog
> >>  | Github <
> >> https://github.com/rmannibucau> |
> >> LinkedIn

Re: Backport for OWB 1.7.x

2018-11-05 Thread Daniel Cunha

Of course, the issue happening when I'm using JDK11 :)

Em seg, 5 de nov de 2018 às 15:33, Daniel Cunha 
escreveu:

> Hi Romain,
>
> Well... that change make me possible to continue create my singleton
> startup like it:
>
> import javax.annotation.PostConstruct;
> import javax.annotation.PreDestroy;
> import javax.ejb.Singleton;
> import javax.ejb.Startup;
>
> @Singleton
> @Startup
> public class KernelShutdownListener {
>
> @PostConstruct
> private void startup() {
> System.out.println("ALOHA STARTUP");
> }
>
> @PreDestroy
> private void shutdown() {
> System.out.println("ALOHA SHUTDOWN");
> }
> }
>
> It was not possible without that change, as you can see here:
> Caused by: java.lang.IllegalStateException: Cannot get Unsafe.defineClass
> at
> org.apache.webbeans.proxy.AbstractProxyFactory$4.run(AbstractProxyFactory.java:812)
> at
> org.apache.webbeans.proxy.AbstractProxyFactory$4.run(AbstractProxyFactory.java:801)
> at java.base/java.security.AccessController.doPrivileged(Native Method)
> at
> org.apache.webbeans.proxy.AbstractProxyFactory.initializeUnsafe(AbstractProxyFactory.java:800)
> at
> org.apache.webbeans.proxy.AbstractProxyFactory.(AbstractProxyFactory.java:91)
> at
> org.apache.webbeans.proxy.InterceptorDecoratorProxyFactory.(InterceptorDecoratorProxyFactory.java:77)
> at
> org.apache.webbeans.config.WebBeansContext.(WebBeansContext.java:153)
> at
> org.apache.webbeans.config.WebBeansContext.(WebBeansContext.java:116)
> at
> org.apache.openejb.cdi.ThreadSingletonServiceImpl.initialize(ThreadSingletonServiceImpl.java:167)
> at org.apache.openejb.cdi.CdiBuilder.build(CdiBuilder.java:41)
> at
> org.apache.openejb.assembler.classic.Assembler.createApplication(Assembler.java:963)
> ... 17 more
> Caused by: java.lang.NoSuchMethodException:
> sun.misc.Unsafe.defineClass(java.lang.String, [B, int, int,
> java.lang.ClassLoader, java.security.ProtectionDomain)
> at java.base/java.lang.Class.getDeclaredMethod(Class.java:2476)
> at
> org.apache.webbeans.proxy.AbstractProxyFactory$4.run(AbstractProxyFactory.java:807)
> ... 27 more
>
> 05-Nov-2018 15:15:33.110 SEVERE [localhost-startStop-2]
> jdk.internal.reflect.NativeMethodAccessorImpl.invoke Error deploying web
> application archive [/tmp/apache-tomee-plume-7.0.6-TT.2/webapps/ROOT.war]
>  java.lang.IllegalStateException: ContainerBase.addChild: start:
> org.apache.catalina.LifecycleException: Failed to start component
> [StandardEngine[Catalina].StandardHost[localhost].StandardContext[]]
> at
> org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:758)
> at
> org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:730)
> at
> org.apache.catalina.core.StandardHost.addChild(StandardHost.java:734)
> at
> org.apache.catalina.startup.HostConfig.deployWAR(HostConfig.java:985)
> at
> org.apache.catalina.startup.HostConfig$DeployWar.run(HostConfig.java:1857)
> at
> java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at java.base/java.lang.Thread.run(Thread.java:834)
>
>
> Em seg, 5 de nov de 2018 às 15:24, Romain Manni-Bucau <
> rmannibu...@gmail.com> escreveu:
>
>> Hi Daniel,
>>
>> Do you know which part implies the "need", this commit was not suppose to
>> change anything since the code was already supporting java 11, it was just
>> intended to prepare potential change later on.
>> Did a small change in the behavior was introduced - if so it was not
>> intended from my part?
>>
>> Romain Manni-Bucau
>> @rmannibucau  |  Blog
>>  | Old Blog
>>  | Github <
>> https://github.com/rmannibucau> |
>> LinkedIn  | Book
>> <
>> https://www.packtpub.com/application-development/java-ee-8-high-performance
>> >
>>
>>
>> Le lun. 5 nov. 2018 à 19:20, Daniel Cunha  a
>> écrit :
>>
>> > Hi Folks,
>> >
>> > we got an issue with Java 11 and TomEE 7.0.x and we need the backport
>> for
>> > it:
>> > https://github.com/apache/openwebbeans/pull/13
>> >
>> > Please take a look at those changes and let me know what do you think.
>> >
>> > Thank you.
>> > --
>> > Daniel "soro" Cunha
>> > https://twitter.com/dvlc_
>> >
>>
>
>
> --
> Daniel "soro" Cunha
> https://twitter.com/dvlc_
>


-- 
Daniel "soro" Cunha
https://twitter.com/dvlc_

Re: Backport for OWB 1.7.x

2018-11-05 Thread Daniel Cunha

Hi Romain,

Well... that change make me possible to continue create my singleton
startup like it:

import javax.annotation.PostConstruct;
import javax.annotation.PreDestroy;
import javax.ejb.Singleton;
import javax.ejb.Startup;

@Singleton
@Startup
public class KernelShutdownListener {

@PostConstruct
private void startup() {
System.out.println("ALOHA STARTUP");
}

@PreDestroy
private void shutdown() {
System.out.println("ALOHA SHUTDOWN");
}
}

It was not possible without that change, as you can see here:
Caused by: java.lang.IllegalStateException: Cannot get Unsafe.defineClass
at
org.apache.webbeans.proxy.AbstractProxyFactory$4.run(AbstractProxyFactory.java:812)
at
org.apache.webbeans.proxy.AbstractProxyFactory$4.run(AbstractProxyFactory.java:801)
at java.base/java.security.AccessController.doPrivileged(Native Method)
at
org.apache.webbeans.proxy.AbstractProxyFactory.initializeUnsafe(AbstractProxyFactory.java:800)
at
org.apache.webbeans.proxy.AbstractProxyFactory.(AbstractProxyFactory.java:91)
at
org.apache.webbeans.proxy.InterceptorDecoratorProxyFactory.(InterceptorDecoratorProxyFactory.java:77)
at
org.apache.webbeans.config.WebBeansContext.(WebBeansContext.java:153)
at
org.apache.webbeans.config.WebBeansContext.(WebBeansContext.java:116)
at
org.apache.openejb.cdi.ThreadSingletonServiceImpl.initialize(ThreadSingletonServiceImpl.java:167)
at org.apache.openejb.cdi.CdiBuilder.build(CdiBuilder.java:41)
at
org.apache.openejb.assembler.classic.Assembler.createApplication(Assembler.java:963)
... 17 more
Caused by: java.lang.NoSuchMethodException:
sun.misc.Unsafe.defineClass(java.lang.String, [B, int, int,
java.lang.ClassLoader, java.security.ProtectionDomain)
at java.base/java.lang.Class.getDeclaredMethod(Class.java:2476)
at
org.apache.webbeans.proxy.AbstractProxyFactory$4.run(AbstractProxyFactory.java:807)
... 27 more

05-Nov-2018 15:15:33.110 SEVERE [localhost-startStop-2]
jdk.internal.reflect.NativeMethodAccessorImpl.invoke Error deploying web
application archive [/tmp/apache-tomee-plume-7.0.6-TT.2/webapps/ROOT.war]
 java.lang.IllegalStateException: ContainerBase.addChild: start:
org.apache.catalina.LifecycleException: Failed to start component
[StandardEngine[Catalina].StandardHost[localhost].StandardContext[]]
at
org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:758)
at
org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:730)
at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:734)
at org.apache.catalina.startup.HostConfig.deployWAR(HostConfig.java:985)
at
org.apache.catalina.startup.HostConfig$DeployWar.run(HostConfig.java:1857)
at
java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:834)


Em seg, 5 de nov de 2018 às 15:24, Romain Manni-Bucau 
escreveu:

> Hi Daniel,
>
> Do you know which part implies the "need", this commit was not suppose to
> change anything since the code was already supporting java 11, it was just
> intended to prepare potential change later on.
> Did a small change in the behavior was introduced - if so it was not
> intended from my part?
>
> Romain Manni-Bucau
> @rmannibucau  |  Blog
>  | Old Blog
>  | Github <
> https://github.com/rmannibucau> |
> LinkedIn  | Book
> <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
>
>
> Le lun. 5 nov. 2018 à 19:20, Daniel Cunha  a écrit
> :
>
> > Hi Folks,
> >
> > we got an issue with Java 11 and TomEE 7.0.x and we need the backport for
> > it:
> > https://github.com/apache/openwebbeans/pull/13
> >
> > Please take a look at those changes and let me know what do you think.
> >
> > Thank you.
> > --
> > Daniel "soro" Cunha
> > https://twitter.com/dvlc_
> >
>


-- 
Daniel "soro" Cunha
https://twitter.com/dvlc_

Re: Backport for OWB 1.7.x

2018-11-05 Thread Romain Manni-Bucau

Hi Daniel,

Do you know which part implies the "need", this commit was not suppose to
change anything since the code was already supporting java 11, it was just
intended to prepare potential change later on.
Did a small change in the behavior was introduced - if so it was not
intended from my part?

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le lun. 5 nov. 2018 à 19:20, Daniel Cunha  a écrit :

> Hi Folks,
>
> we got an issue with Java 11 and TomEE 7.0.x and we need the backport for
> it:
> https://github.com/apache/openwebbeans/pull/13
>
> Please take a look at those changes and let me know what do you think.
>
> Thank you.
> --
> Daniel "soro" Cunha
> https://twitter.com/dvlc_
>

Backport for OWB 1.7.x

2018-11-05 Thread Daniel Cunha

Hi Folks,

we got an issue with Java 11 and TomEE 7.0.x and we need the backport for
it:
https://github.com/apache/openwebbeans/pull/13

Please take a look at those changes and let me know what do you think.

Thank you.
-- 
Daniel "soro" Cunha
https://twitter.com/dvlc_

Re: Backport for OWB 1.7.x

Re: Backport for OWB 1.7.x

Re: Backport for OWB 1.7.x

Re: Backport for OWB 1.7.x

Re: Backport for OWB 1.7.x

Re: Backport for OWB 1.7.x

Re: Backport for OWB 1.7.x

Re: Backport for OWB 1.7.x

Re: Backport for OWB 1.7.x

Re: Backport for OWB 1.7.x

Re: Backport for OWB 1.7.x

Re: Backport for OWB 1.7.x

Re: Backport for OWB 1.7.x

Re: Backport for OWB 1.7.x

Re: Backport for OWB 1.7.x

Re: Backport for OWB 1.7.x

Re: Backport for OWB 1.7.x

Re: Backport for OWB 1.7.x

Re: Backport for OWB 1.7.x

Re: Backport for OWB 1.7.x

Re: Backport for OWB 1.7.x

Re: Backport for OWB 1.7.x

Re: Backport for OWB 1.7.x

Re: Backport for OWB 1.7.x

Re: Backport for OWB 1.7.x

Re: Backport for OWB 1.7.x

Re: Backport for OWB 1.7.x

Re: Backport for OWB 1.7.x

Re: Backport for OWB 1.7.x

Re: Backport for OWB 1.7.x

Re: Backport for OWB 1.7.x

Re: Backport for OWB 1.7.x

Backport for OWB 1.7.x

33 matches

Site Navigation

Mail list logo

Footer information