[jira] [Commented] (SLING-10974) testing clients - replace org.codehaus.jackson with com.fasterxml.jackson.core

[Konrad Windszus (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17456201#comment-17456201
 ] 

Konrad Windszus commented on SLING-10974:
-

FTR: This is not only a change of the Maven coordinates but also of the Java 
package names (which  changes the API of the testing client). Also the 
class/method names are mostly still the same, the change of the package names 
require some refactoring for consumers.

> testing clients - replace org.codehaus.jackson with com.fasterxml.jackson.core
> --
>
> Key: SLING-10974
> URL: https://issues.apache.org/jira/browse/SLING-10974
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 2.0.12
>Reporter: Andrei Dulvac
>Assignee: Andrei Dulvac
>Priority: Major
> Fix For: Apache Sling Testing Clients 3.0.0
>
>
> Replace {{org.codehaus.jackson}} with the latest 
> {{com.fasterxml.jackson.core}} in the sling testing clients.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Re: [VOTE] Release Apache Sling Testing Clients version 3.0.0

[Konrad Windszus]

Sorry for the noise, I was assuming that SLING-10974 is only a change of the 
Maven coordinates, but in fact also the API changed (due to the java package 
name changes).
So everything fine with the major version change.
Konrad

> On 8. Dec 2021, at 19:01, Konrad Windszus  wrote:
> 
> Hi Andrei,
> I am confused by this major version bump. IMHO 
> https://issues.apache.org/jira/browse/SLING-10974 
>  does not affect the 
> users, therefore a minor or even qualifier increase would be sufficient from 
> my PoV.
> Do we really anticipate compatibility issues due to this change?
> Konrad
> 
>> On 8. Dec 2021, at 18:47, Andrei Dulvac  wrote:
>> 
>> Hi,
>> 
>> We solved 1 issue in this release:
>> https://issues.apache.org/jira/projects/SLING/versions/12350884
>> 
>> 
>> Staging repository:
>> https://repository.apache.org/content/repositories/orgapachesling-2561
>> 
>> You can use this UNIX script to download the release and verify the
>> signatures:
>> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>> 
>> Usage:
>> sh check_staged_release.sh 2561 /tmp/sling-staging
>> 
>> Please vote to approve this release:
>> 
>> [ ] +1 Approve the release
>> [ ]  0 Don't care
>> [ ] -1 Don't release, because ...
>> 
>> This majority vote is open for at least 72 hours.
>> 
>> Cheers,
>> - Andrei
> 

[jira] [Updated] (SLING-10977) Exclude JDK packages from version range checks

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-10977:

Description: 
The analysers for package exports/imports currently warn if a bundle is 
importing JDK packages without a version:
[WARNING] [api-regions-exportsimports] foo:1.0-SNAPSHOT: Bundle 
foo:1.0-SNAPSHOT is importing package(s) [java.lang.invoke, java.util, 
java.util.function, java.io, java.lang, java.util.stream] without specifying a 
version range.
As JDK packages usually do not have a version, it doesn't make sense to require 
them for an import package statement

  was:
The analysers for package exports/imports currently warn if a bundle is 
importing JDK packages without a warning:
[WARNING] [api-regions-exportsimports] foo:1.0-SNAPSHOT: Bundle 
foo:1.0-SNAPSHOT is importing package(s) [java.lang.invoke, java.util, 
java.util.function, java.io, java.lang, java.util.stream] without specifying a 
version range.
As JDK packages usually do not have a version, it doesn't make sense to require 
them for an import package statement


> Exclude JDK packages from version range checks
> --
>
> Key: SLING-10977
> URL: https://issues.apache.org/jira/browse/SLING-10977
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model, Feature Model Analyser
>Affects Versions: Feature Model API Regions Extension 1.4.0, Feature Model 
> Analyser 1.5.0
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model Analyser 1.5.2, Feature Model API Regions 
> Extension 1.4.2
>
>
> The analysers for package exports/imports currently warn if a bundle is 
> importing JDK packages without a version:
> [WARNING] [api-regions-exportsimports] foo:1.0-SNAPSHOT: Bundle 
> foo:1.0-SNAPSHOT is importing package(s) [java.lang.invoke, java.util, 
> java.util.function, java.io, java.lang, java.util.stream] without specifying 
> a version range.
> As JDK packages usually do not have a version, it doesn't make sense to 
> require them for an import package statement



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[VOTE] Release Apache Sling Feature Model Analyser 1.5.2 and Feature Extension Api Regions 1.4.2

[Carsten Ziegeler]

Hi,

We solved 2 issues for the Feature Analyser 1.5.2
https://issues.apache.org/jira/projects/SLING/versions/12350853

We solved 1 issue for the Feature Extension Api Region 1.4.2
https://issues.apache.org/jira/projects/SLING/versions/12350923


Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2562

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2562 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards
Carsten
--
Carsten Ziegeler
Adobe
cziege...@apache.org

Re: [VOTE] Release Apache Sling Testing Clients version 3.0.0

[Konrad Windszus]

Hi Andrei,
I am confused by this major version bump. IMHO 
https://issues.apache.org/jira/browse/SLING-10974 
 does not affect the users, 
therefore a minor or even qualifier increase would be sufficient from my PoV.
Do we really anticipate compatibility issues due to this change?
Konrad

> On 8. Dec 2021, at 18:47, Andrei Dulvac  wrote:
> 
> Hi,
> 
> We solved 1 issue in this release:
> https://issues.apache.org/jira/projects/SLING/versions/12350884
> 
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2561
> 
> You can use this UNIX script to download the release and verify the
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> 
> Usage:
> sh check_staged_release.sh 2561 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.
> 
> Cheers,
> - Andrei

[VOTE] Release Apache Sling Testing Clients version 3.0.0

[Andrei Dulvac]

Hi,

We solved 1 issue in this release:
https://issues.apache.org/jira/projects/SLING/versions/12350884


Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2561

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2561 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Cheers,
- Andrei

[jira] [Comment Edited] (SLING-10983) Sling-Initial-Content removes ACLs when using overwrite:=true without path

[Konrad Windszus (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17455886#comment-17455886
 ] 

Konrad Windszus edited comment on SLING-10983 at 12/8/21, 5:31 PM:
---

As removing ACLs cannot easily be prevented (would require some Jackrabbit API) 
without reworking the overwrite semantics of folder nodes in a more complex way 
(i.e. keep the existing node, but adjust its primary and mixin types and remove 
all other (non-protected) properties) I think we have the following options:

# keep current behaviour or
# bail out in case overwrite:=true is used without the path directive or with 
path "/" and throw an according exception

I would be in favour of option 2 actually, because in all cases I have seen 
this was not done deliberately but by mistake and it often goes unnoticed.
In any case the documentation at 
https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html#
 needs to be clarified that
* overwrite never starts at root, but always at the path below
* overwrite might also remove existing permissions bound to the node


was (Author: kwin):
As removing ACLs cannot easily be prevented (would require some Jackrabbit API) 
without reworking the overwrite semantics of folder nodes in a more complex way 
(i.e. keep the existing node, but adjust its primary and mixin types and remove 
all other (non-protected) properties) I think we have the following options:

# keep current behaviour or
# bail out in case overwrite:=true is used without the path directive

I would be in favour of option 2 actually, because in all cases I have seen 
this was not done deliberately but by mistake and it often goes unnoticed.
In any case the documentation at 
https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html#
 needs to be clarified that
* overwrite never starts at root, but always at the path below
* overwrite might also remove existing permissions bound to the node

> Sling-Initial-Content removes ACLs when using overwrite:=true without path
> --
>
> Key: SLING-10983
> URL: https://issues.apache.org/jira/browse/SLING-10983
> Project: Sling
>  Issue Type: Bug
>Affects Versions: JCR ContentLoader 2.4.2
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> In the context of 
> https://github.com/apache/sling-org-apache-sling-models-validation-impl/pull/1
>  it turned out that if you use a Sling-Initial-Content header without an 
> explicit {{path}} directive it will remove ACLs on nodes below the root node 
> (if it is a parent node of the node to be updated by Sling-Initial-Content).



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (SLING-10983) Sling-Initial-Content removes ACLs when using overwrite:=true without path

[Stefan Seifert (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17455888#comment-17455888
 ] 

Stefan Seifert commented on SLING-10983:


i would also recommend option 2

> Sling-Initial-Content removes ACLs when using overwrite:=true without path
> --
>
> Key: SLING-10983
> URL: https://issues.apache.org/jira/browse/SLING-10983
> Project: Sling
>  Issue Type: Bug
>Affects Versions: JCR ContentLoader 2.4.2
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> In the context of 
> https://github.com/apache/sling-org-apache-sling-models-validation-impl/pull/1
>  it turned out that if you use a Sling-Initial-Content header without an 
> explicit {{path}} directive it will remove ACLs on nodes below the root node 
> (if it is a parent node of the node to be updated by Sling-Initial-Content).



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Resolved] (SLING-10974) testing clients - replace org.codehaus.jackson with com.fasterxml.jackson.core

[Andrei Dulvac (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac resolved SLING-10974.
---
Resolution: Fixed

> testing clients - replace org.codehaus.jackson with com.fasterxml.jackson.core
> --
>
> Key: SLING-10974
> URL: https://issues.apache.org/jira/browse/SLING-10974
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 2.0.12
>Reporter: Andrei Dulvac
>Assignee: Andrei Dulvac
>Priority: Major
> Fix For: Apache Sling Testing Clients 2.0.14
>
>
> Replace {{org.codehaus.jackson}} with the latest 
> {{com.fasterxml.jackson.core}} in the sling testing clients.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (SLING-10983) Sling-Initial-Content removes ACLs when using overwrite:=true without path

[Konrad Windszus (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17455886#comment-17455886
 ] 

Konrad Windszus commented on SLING-10983:
-

As removing ACLs cannot easily be prevented (would require some Jackrabbit API) 
without reworking the overwrite semantics of folder nodes in a more complex way 
(i.e. keep the existing node, but adjust its primary and mixin types and remove 
all other (non-protected) properties) I think we have the following options:

# keep current behaviour or
# bail out in case overwrite:=true is used without the path directive

I would be in favour of option 2 actually, because in all cases I have seen 
this was not done deliberately but by mistake and it often goes unnoticed.
In any case the documentation at 
https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html#
 needs to be clarified that
* overwrite never starts at root, but always at the path below
* overwrite might also remove existing permissions bound to the node

> Sling-Initial-Content removes ACLs when using overwrite:=true without path
> --
>
> Key: SLING-10983
> URL: https://issues.apache.org/jira/browse/SLING-10983
> Project: Sling
>  Issue Type: Bug
>Affects Versions: JCR ContentLoader 2.4.2
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> In the context of 
> https://github.com/apache/sling-org-apache-sling-models-validation-impl/pull/1
>  it turned out that if you use a Sling-Initial-Content header without an 
> explicit {{path}} directive it will remove ACLs on nodes below the root node 
> (if it is a parent node of the node to be updated by Sling-Initial-Content).



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Comment Edited] (SLING-10983) Sling-Initial-Content removes ACLs when using overwrite:=true without path

[Konrad Windszus (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17455307#comment-17455307
 ] 

Konrad Windszus edited comment on SLING-10983 at 12/8/21, 5:01 PM:
---

This is probably caused by 
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/blob/bc5153ae9000c4230b92287416785c1ff00fa240/src/main/java/org/apache/sling/jcr/contentloader/internal/BundleContentLoader.java#L558,
 which removes the "/apps" node. 

I would expect though that overwrite with the implicit path "/" would also 
remove all other nodes below "/" but it only clears the folder on the 2nd level 
which is the parent of the contained initial content entry.


was (Author: kwin):
This is probably caused by 
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/blob/bc5153ae9000c4230b92287416785c1ff00fa240/src/main/java/org/apache/sling/jcr/contentloader/internal/BundleContentLoader.java#L558,
 which removes the "/apps" node. Surprisingly the children of "/apps"  which 
are not contained in the initial content in the bundle survive this deletion...

> Sling-Initial-Content removes ACLs when using overwrite:=true without path
> --
>
> Key: SLING-10983
> URL: https://issues.apache.org/jira/browse/SLING-10983
> Project: Sling
>  Issue Type: Bug
>Affects Versions: JCR ContentLoader 2.4.2
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> In the context of 
> https://github.com/apache/sling-org-apache-sling-models-validation-impl/pull/1
>  it turned out that if you use a Sling-Initial-Content header without an 
> explicit {{path}} directive it will remove ACLs on nodes below the root node 
> (if it is a parent node of the node to be updated by Sling-Initial-Content).



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Assigned] (SLING-10983) Sling-Initial-Content removes ACLs when using overwrite:=true without path

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus reassigned SLING-10983:
---

Assignee: Konrad Windszus

> Sling-Initial-Content removes ACLs when using overwrite:=true without path
> --
>
> Key: SLING-10983
> URL: https://issues.apache.org/jira/browse/SLING-10983
> Project: Sling
>  Issue Type: Bug
>Affects Versions: JCR ContentLoader 2.4.2
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> In the context of 
> https://github.com/apache/sling-org-apache-sling-models-validation-impl/pull/1
>  it turned out that if you use a Sling-Initial-Content header without an 
> explicit {{path}} directive it will remove ACLs on nodes below the root node 
> (if it is a parent node of the node to be updated by Sling-Initial-Content).



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [sling-org-apache-sling-starter] sonarcloud[bot] commented on pull request #39: SLING-10984 stop docker container after stopping feature

[GitBox]

sonarcloud[bot] commented on pull request #39:
URL: 
https://github.com/apache/sling-org-apache-sling-starter/pull/39#issuecomment-988906564






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-starter] sonarcloud[bot] removed a comment on pull request #39: SLING-10984 stop docker container after stopping feature

[GitBox]

sonarcloud[bot] removed a comment on pull request #39:
URL: 
https://github.com/apache/sling-org-apache-sling-starter/pull/39#issuecomment-988906564


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=39=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=39=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=39=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=39=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=39=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=39=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=39=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=39=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=39=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=39=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=39=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=39=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter=39)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter=39=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter=39=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SLING-10983) Sling-Initial-Content removes ACLs when using overwrite:=true without path

[Konrad Windszus (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17455307#comment-17455307
 ] 

Konrad Windszus commented on SLING-10983:
-

This is probably caused by 
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/blob/bc5153ae9000c4230b92287416785c1ff00fa240/src/main/java/org/apache/sling/jcr/contentloader/internal/BundleContentLoader.java#L558,
 which removes the "/apps" node. Surprisingly the children of "/apps"  which 
are not contained in the initial content in the bundle survive this deletion...

> Sling-Initial-Content removes ACLs when using overwrite:=true without path
> --
>
> Key: SLING-10983
> URL: https://issues.apache.org/jira/browse/SLING-10983
> Project: Sling
>  Issue Type: Bug
>Affects Versions: JCR ContentLoader 2.4.2
>Reporter: Konrad Windszus
>Priority: Major
>
> In the context of 
> https://github.com/apache/sling-org-apache-sling-models-validation-impl/pull/1
>  it turned out that if you use a Sling-Initial-Content header without an 
> explicit {{path}} directive it will remove ACLs on nodes below the root node 
> (if it is a parent node of the node to be updated by Sling-Initial-Content).



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Updated] (SLING-10983) Sling-Initial-Content removes ACLs when using overwrite:=true without path

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-10983:

Summary: Sling-Initial-Content removes ACLs when using overwrite:=true 
without path  (was: Sling-Initial-Content removes ACLs with overwrite:=true 
without path)

> Sling-Initial-Content removes ACLs when using overwrite:=true without path
> --
>
> Key: SLING-10983
> URL: https://issues.apache.org/jira/browse/SLING-10983
> Project: Sling
>  Issue Type: Bug
>Affects Versions: JCR ContentLoader 2.4.2
>Reporter: Konrad Windszus
>Priority: Major
>
> In the context of 
> https://github.com/apache/sling-org-apache-sling-models-validation-impl/pull/1
>  it turned out that if you use a Sling-Initial-Content header without an 
> explicit {{path}} directive it will remove ACLs on nodes below the root node 
> (if it is a parent node of the node to be updated by Sling-Initial-Content).



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Re: [VOTE] Release Apache Sling Scripting HTL REPL 1.0.8, Apache Sling Starter Content 1.0.10

[Konrad Windszus]

Hi Robert,
due to https://issues.apache.org/jira/browse/SLING-10983 
 we should probably adjust 
https://github.com/apache/sling-org-apache-sling-scripting-sightly-repl/blob/11a40bbeb0ca1ce01ed37441ece94cd29e29e9b0/bnd.bnd#L1
 
.
Using "overwrite" without "path" is really dangerous here.

Konrad

> On 8. Dec 2021, at 16:01, Robert Munteanu  wrote:
> 
> Hi,
> 
> We solved 6 issues in these releases:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12347003
> https://issues.apache.org/jira/browse/SLING/fixforversion/12346241
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2560/
> 
> You can use this UNIX script to download the release and verify the 
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> 
> Usage:
> sh check_staged_release.sh 2560 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.
> 
> Regards,
> Robert Munteanu

[jira] [Updated] (SLING-10984) Starter IT: docker-maven-plugin:stop executed prior to feature-launcher-maven-plugin:stop

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-10984:

Fix Version/s: Starter 12

> Starter IT: docker-maven-plugin:stop executed prior to 
> feature-launcher-maven-plugin:stop
> -
>
> Key: SLING-10984
> URL: https://issues.apache.org/jira/browse/SLING-10984
> Project: Sling
>  Issue Type: Bug
>  Components: Starter
>Affects Versions: Starter 12
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Starter 12
>
>
> The order of the goals of {{docker-maven-plugin}} and 
> {{feature-launcher-maven-plugin}} need to be executed in this order for the 
> integration test
> # docker-maven-plugin:start
> # feature-launcher-maven-plugin:start
> # feature-launcher-maven-plugin:stop
> # docker-maven-plugin:stop
> But currently the docker container is stopped before the Sling feature is 
> stopped.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Assigned] (SLING-10984) Starter IT: docker-maven-plugin:stop executed prior to feature-launcher-maven-plugin:stop

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus reassigned SLING-10984:
---

Assignee: Konrad Windszus

> Starter IT: docker-maven-plugin:stop executed prior to 
> feature-launcher-maven-plugin:stop
> -
>
> Key: SLING-10984
> URL: https://issues.apache.org/jira/browse/SLING-10984
> Project: Sling
>  Issue Type: Bug
>  Components: Starter
>Affects Versions: Starter 12
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> The order of the goals of {{docker-maven-plugin}} and 
> {{feature-launcher-maven-plugin}} need to be executed in this order for the 
> integration test
> # docker-maven-plugin:start
> # feature-launcher-maven-plugin:start
> # feature-launcher-maven-plugin:stop
> # docker-maven-plugin:stop
> But currently the docker container is stopped before the Sling feature is 
> stopped.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [sling-org-apache-sling-starter] rombert commented on pull request #38: Update starter.content and scripting.htl.repl to the latest versions

[GitBox]

rombert commented on pull request #38:
URL: 
https://github.com/apache/sling-org-apache-sling-starter/pull/38#issuecomment-988896332


   This needs to wait for the release vote from 
https://lists.apache.org/thread/4h7f7zm47tc3wprx0fy9qbntftk26fmk .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[VOTE] Release Apache Sling Scripting HTL REPL 1.0.8, Apache Sling Starter Content 1.0.10

[Robert Munteanu]

Hi,

We solved 6 issues in these releases:
https://issues.apache.org/jira/browse/SLING/fixforversion/12347003
https://issues.apache.org/jira/browse/SLING/fixforversion/12346241

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2560/

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2560 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Robert Munteanu

[jira] [Comment Edited] (SLING-10984) Starter IT: docker-maven-plugin:stop executed prior to feature-launcher-maven-plugin:stop

[Konrad Windszus (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17455296#comment-17455296
 ] 

Konrad Windszus edited comment on SLING-10984 at 12/8/21, 3:01 PM:
---

The reason is that 1.&2 and 3.&4. are bound to the same phases, so the order is 
determined by the order of plugins. A similar issue is described at 
https://stackoverflow.com/questions/55855968/maven-plugin-crossed-execution-order


was (Author: kwin):
The reason is that 1.&2 and 3.&4. are bound to the same phases, so the order is 
determined by the order of plugins. 

> Starter IT: docker-maven-plugin:stop executed prior to 
> feature-launcher-maven-plugin:stop
> -
>
> Key: SLING-10984
> URL: https://issues.apache.org/jira/browse/SLING-10984
> Project: Sling
>  Issue Type: Bug
>  Components: Starter
>Affects Versions: Starter 12
>Reporter: Konrad Windszus
>Priority: Major
>
> The order of the goals of {{docker-maven-plugin}} and 
> {{feature-launcher-maven-plugin}} need to be executed in this order for the 
> integration test
> # docker-maven-plugin:start
> # feature-launcher-maven-plugin:start
> # feature-launcher-maven-plugin:stop
> # docker-maven-plugin:stop
> But currently the docker container is stopped before the Sling feature is 
> stopped.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Resolved] (SLING-10982) Update starter.content to parent pom 46

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-10982.
-
Resolution: Fixed

https://github.com/apache/sling-org-apache-sling-starter-content/pull/4

> Update starter.content to parent pom 46
> ---
>
> Key: SLING-10982
> URL: https://issues.apache.org/jira/browse/SLING-10982
> Project: Sling
>  Issue Type: Task
>  Components: Starter
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Starter Content 1.0.10
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Updated] (SLING-10982) Update starter.content to parent pom 46

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-10982:

Fix Version/s: Starter Content 1.0.10
   (was: Starter Content 1.0.12)

> Update starter.content to parent pom 46
> ---
>
> Key: SLING-10982
> URL: https://issues.apache.org/jira/browse/SLING-10982
> Project: Sling
>  Issue Type: Task
>  Components: Starter
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Starter Content 1.0.10
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Updated] (SLING-10982) Update starter.content to parent pom 46

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-10982:

Fix Version/s: Starter Content 1.0.12
   (was: Starter Content 1.0.10)

> Update starter.content to parent pom 46
> ---
>
> Key: SLING-10982
> URL: https://issues.apache.org/jira/browse/SLING-10982
> Project: Sling
>  Issue Type: Task
>  Components: Starter
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Starter Content 1.0.12
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Updated] (SLING-10606) Default login page should not reference content from the starter.content module

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-10606:

Fix Version/s: Starter Content 1.0.12
   (was: Starter Content 1.0.10)

> Default login page should not reference content from the starter.content 
> module
> ---
>
> Key: SLING-10606
> URL: https://issues.apache.org/jira/browse/SLING-10606
> Project: Sling
>  Issue Type: Improvement
>  Components: Authentication, Starter
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Form Based Authentication 1.0.26, Starter Content 1.0.12
>
> Attachments: login-form-without-starter-content.png, 
> resources-not-found-without-starter-content.png
>
>
> The default login form references images and styles from the starter.content. 
> We should avoid that, since the default login form can be deployed in other 
> scenarios as well. Instead, we should:
> - provide a standalone login page for the o.a.s.auth.form bundle
> - move the current login form to o.a.s.starter.content bundle
> The intent is to have a good-looking form for the starter content but also 
> one that does not look broken for auth.form.
> We should also add an HTML comment to the default login form pointing to 
> customisation possibilites.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Created] (SLING-10984) Starter IT: docker-maven-plugin:stop executed prior to feature-launcher-maven-plugin:stop

[Konrad Windszus (Jira)]

Konrad Windszus created SLING-10984:
---

 Summary: Starter IT: docker-maven-plugin:stop executed prior to 
feature-launcher-maven-plugin:stop
 Key: SLING-10984
 URL: https://issues.apache.org/jira/browse/SLING-10984
 Project: Sling
  Issue Type: Bug
  Components: Starter
Affects Versions: Starter 12
Reporter: Konrad Windszus


The order of the goals of {{docker-maven-plugin}} and 
{{feature-launcher-maven-plugin}} need to be executed in this order for the 
integration test

# docker-maven-plugin:start
# feature-launcher-maven-plugin:start
# feature-launcher-maven-plugin:stop
# docker-maven-plugin:stop

But currently the docker container is stopped before the Sling feature is 
stopped.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [sling-org-apache-sling-starter-content] rombert merged pull request #4: SLING-10982 - Update starter.content to parent pom 46

[GitBox]

rombert merged pull request #4:
URL: https://github.com/apache/sling-org-apache-sling-starter-content/pull/4


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (SLING-10983) Sling-Initial-Content removes ACLs with overwrite:=true without path

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-10983:

Summary: Sling-Initial-Content removes ACLs with overwrite:=true without 
path  (was: Sling-Initial-Content removes ACLs)

> Sling-Initial-Content removes ACLs with overwrite:=true without path
> 
>
> Key: SLING-10983
> URL: https://issues.apache.org/jira/browse/SLING-10983
> Project: Sling
>  Issue Type: Bug
>Affects Versions: JCR ContentLoader 2.4.2
>Reporter: Konrad Windszus
>Priority: Major
>
> In the context of 
> https://github.com/apache/sling-org-apache-sling-models-validation-impl/pull/1
>  it turned out that if you use a Sling-Initial-Content header without an 
> explicit {{path}} directive it will remove ACLs on nodes below the root node 
> (if it is a parent node of the node to be updated by Sling-Initial-Content).



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [sling-org-apache-sling-hapi-client] dulvac commented on a change in pull request #1: update dependencies to current ones

[GitBox]

dulvac commented on a change in pull request #1:
URL: 
https://github.com/apache/sling-org-apache-sling-hapi-client/pull/1#discussion_r764932396



##
File path: pom.xml
##
@@ -69,41 +69,47 @@
 
 org.apache.httpcomponents
 httpclient
-4.5.1
+4.5.13
 provided
 
 
 org.apache.httpcomponents
 httpmime
-4.5
+4.5.13
 provided
 
 
-commons-lang
-commons-lang
-2.5
+org.apache.commons
+commons-lang3
+3.12.0
 provided
 
 
 commons-io
 commons-io
-2.5
+2.11.0
 provided
 
 
 org.jsoup
 jsoup
-1.9.2
+1.14.3

Review comment:
   I suspect this one might be the one that triggered your scan?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (SLING-10983) Sling-Initial-Content removes ACLs

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-10983:

Description: In the context of 
https://github.com/apache/sling-org-apache-sling-models-validation-impl/pull/1 
it turned out that if you use a Sling-Initial-Content header without an 
explicit {{path}} directive it will remove ACLs on nodes below the root node 
(if it is a parent node of the node to be updated by Sling-Initial-Content).  
(was: In the context of 
https://github.com/apache/sling-org-apache-sling-models-validation-impl/pull/1 
it turned out that if you use a Sling-Initial-Content header without an 
explicit {{path}} directive it will remove ACLs on root nodes.)

> Sling-Initial-Content removes ACLs
> --
>
> Key: SLING-10983
> URL: https://issues.apache.org/jira/browse/SLING-10983
> Project: Sling
>  Issue Type: Bug
>Affects Versions: JCR ContentLoader 2.4.2
>Reporter: Konrad Windszus
>Priority: Major
>
> In the context of 
> https://github.com/apache/sling-org-apache-sling-models-validation-impl/pull/1
>  it turned out that if you use a Sling-Initial-Content header without an 
> explicit {{path}} directive it will remove ACLs on nodes below the root node 
> (if it is a parent node of the node to be updated by Sling-Initial-Content).



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [sling-org-apache-sling-hapi-client] dulvac commented on pull request #1: update dependencies to current ones

[GitBox]

dulvac commented on pull request #1:
URL: 
https://github.com/apache/sling-org-apache-sling-hapi-client/pull/1#issuecomment-988876195


   Sorry @vhochstein, I somehow missed the notification. And thanks for the 
contribution!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-starter-content] sonarcloud[bot] commented on pull request #4: SLING-10982 - Update starter.content to parent pom 46

[GitBox]

sonarcloud[bot] commented on pull request #4:
URL: 
https://github.com/apache/sling-org-apache-sling-starter-content/pull/4#issuecomment-988874858


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter-content=4=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter-content=4=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter-content=4=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter-content=4=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter-content=4=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter-content=4=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter-content=4=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter-content=4=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter-content=4=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter-content=4=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter-content=4=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter-content=4=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter-content=4)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter-content=4=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter-content=4=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (SLING-10983) Sling-Initial-Content removes ACLs

[Konrad Windszus (Jira)]

Konrad Windszus created SLING-10983:
---

 Summary: Sling-Initial-Content removes ACLs
 Key: SLING-10983
 URL: https://issues.apache.org/jira/browse/SLING-10983
 Project: Sling
  Issue Type: Bug
Affects Versions: JCR ContentLoader 2.4.2
Reporter: Konrad Windszus


In the context of 
https://github.com/apache/sling-org-apache-sling-models-validation-impl/pull/1 
it turned out that if you use a Sling-Initial-Content header without an 
explicit {{path}} directive it will remove ACLs on root nodes.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Created] (SLING-10982) Update starter.content to parent pom 46

[Robert Munteanu (Jira)]

Robert Munteanu created SLING-10982:
---

 Summary: Update starter.content to parent pom 46
 Key: SLING-10982
 URL: https://issues.apache.org/jira/browse/SLING-10982
 Project: Sling
  Issue Type: Task
  Components: Starter
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Starter Content 1.0.10






--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [sling-org-apache-sling-scripting-sightly-repl] rombert merged pull request #4: SLING-10981 - Update HTL REPL to parent pom 46

[GitBox]

rombert merged pull request #4:
URL: 
https://github.com/apache/sling-org-apache-sling-scripting-sightly-repl/pull/4


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Resolved] (SLING-10981) Update HTL REPL to parent pom 46

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-10981.
-
Resolution: Fixed

https://github.com/apache/sling-org-apache-sling-scripting-sightly-repl/pull/3
https://github.com/apache/sling-org-apache-sling-scripting-sightly-repl/pull/4

> Update HTL REPL to parent pom 46
> 
>
> Key: SLING-10981
> URL: https://issues.apache.org/jira/browse/SLING-10981
> Project: Sling
>  Issue Type: Task
>  Components: Scripting
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Scripting HTL REPL 1.0.8
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [sling-org-apache-sling-scripting-sightly-repl] sonarcloud[bot] commented on pull request #4: SLING-10981 - Update HTL REPL to parent pom 46

[GitBox]

sonarcloud[bot] commented on pull request #4:
URL: 
https://github.com/apache/sling-org-apache-sling-scripting-sightly-repl/pull/4#issuecomment-988870098


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=4=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=4=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=4=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=4=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=4=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=4=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly-repl=4=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly-repl=4=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly-repl=4=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=4=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=4=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=4=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-repl=4=coverage=list)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-repl=4=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-repl=4=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-scripting-sightly-repl] sonarcloud[bot] removed a comment on pull request #3: SLING-10978 - HTL REPL should be installed under /content

[GitBox]

sonarcloud[bot] removed a comment on pull request #3:
URL: 
https://github.com/apache/sling-org-apache-sling-scripting-sightly-repl/pull/3#issuecomment-988866673


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=coverage=list)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (SLING-10981) Update HTL REPL to parent pom 46

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-10981:

Summary: Update HTL REPL to parent pom 46  (was: Update HTL REPL to parent 
pom 45)

> Update HTL REPL to parent pom 46
> 
>
> Key: SLING-10981
> URL: https://issues.apache.org/jira/browse/SLING-10981
> Project: Sling
>  Issue Type: Task
>  Components: Scripting
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Scripting HTL REPL 1.0.8
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [sling-org-apache-sling-scripting-sightly-repl] sonarcloud[bot] commented on pull request #3: SLING-10978 - HTL REPL should be installed under /content

[GitBox]

sonarcloud[bot] commented on pull request #3:
URL: 
https://github.com/apache/sling-org-apache-sling-scripting-sightly-repl/pull/3#issuecomment-988867719


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=coverage=list)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-scripting-sightly-repl] rombert commented on a change in pull request #3: SLING-10978 - HTL REPL should be installed under /content

[GitBox]

rombert commented on a change in pull request #3:
URL: 
https://github.com/apache/sling-org-apache-sling-scripting-sightly-repl/pull/3#discussion_r764920708



##
File path: pom.xml
##
@@ -21,7 +21,7 @@
 
 org.apache.sling
 sling-bundle-parent
-35
+45

Review comment:
   Because I did not realise we had 46 :-) I'll create a follow-up PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #789 is FIXED

[Apache Jenkins Server]

Please see 
https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-launchpad-testing/job/master/789/
 for details.

No further emails will be sent until the status of the build is changed.

[GitHub] [sling-org-apache-sling-scripting-sightly-repl] kwin commented on a change in pull request #3: SLING-10978 - HTL REPL should be installed under /content

[GitBox]

kwin commented on a change in pull request #3:
URL: 
https://github.com/apache/sling-org-apache-sling-scripting-sightly-repl/pull/3#discussion_r764919941



##
File path: pom.xml
##
@@ -21,7 +21,7 @@
 
 org.apache.sling
 sling-bundle-parent
-35
+45

Review comment:
   why 45 and not 46?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-scripting-sightly-repl] sonarcloud[bot] commented on pull request #3: SLING-10978 - HTL REPL should be installed under /content

[GitBox]

sonarcloud[bot] commented on pull request #3:
URL: 
https://github.com/apache/sling-org-apache-sling-scripting-sightly-repl/pull/3#issuecomment-988866673


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=coverage=list)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-repl=3=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-scripting-sightly-repl] rombert merged pull request #3: SLING-10978 - HTL REPL should be installed under /content

[GitBox]

rombert merged pull request #3:
URL: 
https://github.com/apache/sling-org-apache-sling-scripting-sightly-repl/pull/3


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (SLING-10981) Update HTL REPL to parent pom 45

[Robert Munteanu (Jira)]

Robert Munteanu created SLING-10981:
---

 Summary: Update HTL REPL to parent pom 45
 Key: SLING-10981
 URL: https://issues.apache.org/jira/browse/SLING-10981
 Project: Sling
  Issue Type: Task
  Components: Scripting
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Scripting HTL REPL 1.0.8






--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [sling-org-apache-sling-hapi-client] rombert commented on a change in pull request #1: update dependencies to current ones

[GitBox]

rombert commented on a change in pull request #1:
URL: 
https://github.com/apache/sling-org-apache-sling-hapi-client/pull/1#discussion_r764905121



##
File path: pom.xml
##
@@ -41,7 +41,7 @@
 
 
 
-6
+8

Review comment:
   Please update the bundle version to 1.1.0-SNAPSHOT, since we are now 
changing the base requirements.

##
File path: pom.xml
##
@@ -23,7 +23,7 @@
 
 org.apache.sling
 sling
-30
+39

Review comment:
   Any reason to not use the latest parent pom?
   
   ```suggestion
   45
   ```

##
File path: pom.xml
##
@@ -69,41 +69,47 @@
 
 org.apache.httpcomponents
 httpclient
-4.5.1
+4.5.13
 provided
 
 
 org.apache.httpcomponents
 httpmime
-4.5
+4.5.13
 provided
 
 
-commons-lang
-commons-lang
-2.5
+org.apache.commons

Review comment:
   It looks like commons-lang is not used at all, can you please remove it?

##
File path: pom.xml
##
@@ -69,41 +69,47 @@
 
 org.apache.httpcomponents
 httpclient
-4.5.1
+4.5.13
 provided
 
 
 org.apache.httpcomponents
 httpmime
-4.5
+4.5.13

Review comment:
   This dependency is used only to calculate the OSGi package import 
ranges, please keep using the oldest one that works.

##
File path: pom.xml
##
@@ -69,41 +69,47 @@
 
 org.apache.httpcomponents
 httpclient
-4.5.1
+4.5.13

Review comment:
   This dependency is used only to calculate the OSGi package import 
ranges, please keep using the oldest one that works.

##
File path: pom.xml
##
@@ -69,41 +69,47 @@
 
 org.apache.httpcomponents
 httpclient
-4.5.1
+4.5.13
 provided
 
 
 org.apache.httpcomponents
 httpmime
-4.5
+4.5.13
 provided
 
 
-commons-lang
-commons-lang
-2.5
+org.apache.commons
+commons-lang3
+3.12.0
 provided
 
 
 commons-io
 commons-io
-2.5
+2.11.0
 provided
 
 
 org.jsoup
 jsoup
-1.9.2
+1.14.3
 
 
 org.slf4j
 slf4j-api
 
+
+   org.osgi
+   org.osgi.service.component.annotations
+   1.5.0
+   provided
+   
 
 
 org.apache.httpcomponents
 httpclient
-4.5.1
+4.5.13

Review comment:
   Technically speaking this one is used only for tests, but since we 
already declare it with scope=provided we need to keep the same version. So 
please don't change this one either. But maybe it's worth extracting a 
`httpclient.version` property since we already use it so many times.

##
File path: pom.xml
##
@@ -69,41 +69,47 @@
 
 org.apache.httpcomponents
 httpclient
-4.5.1
+4.5.13
 provided
 
 
 org.apache.httpcomponents
 httpmime
-4.5
+4.5.13
 provided
 
 
-commons-lang
-commons-lang
-2.5
+org.apache.commons
+commons-lang3
+3.12.0
 provided
 
 
 commons-io
 commons-io
-2.5
+2.11.0

Review comment:
   This dependency is used only to calculate the OSGi package import 
ranges, please keep using the oldest one that works.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Resolved] (SLING-10978) HTL REPL should be installed under /content

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-10978.
-
Resolution: Fixed

https://github.com/apache/sling-org-apache-sling-scripting-sightly-repl/pull/2

> HTL REPL should be installed under /content
> ---
>
> Key: SLING-10978
> URL: https://issues.apache.org/jira/browse/SLING-10978
> Project: Sling
>  Issue Type: New Feature
>  Components: Scripting
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Scripting HTL REPL 1.0.8
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The entry HTL repl resource is installed at {{htl/repl}} ( see 
> https://github.com/apache/sling-org-apache-sling-scripting-sightly-repl/blob/ad3ee50c81fb77302fa2d0b7c505c720b93ec494/src/main/resources/SLING-INF/htl/repl.json
>  ).
> It should instead be installed at /content/htl/repl. This will incidentally 
> make it accesible at the same location anyway.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Resolved] (SLING-10979) Move scripting.sightly.repl bundle into a separate feature

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-10979.
-
Resolution: Fixed

https://github.com/apache/sling-org-apache-sling-starter/pull/37

> Move scripting.sightly.repl bundle into a separate feature
> --
>
> Key: SLING-10979
> URL: https://issues.apache.org/jira/browse/SLING-10979
> Project: Sling
>  Issue Type: New Feature
>  Components: Starter
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Starter 12
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The HTL REPL is a development-time tool and should not be packaged in the 
> scripting feature. Consumers of Sling might mistakenly include it in their 
> deployments. We should move it to its own feature file under 
> {{src/main/features/app}}.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [sling-org-apache-sling-scripting-sightly-repl] rombert merged pull request #2: SLING-10978 - HTL REPL should be installed under /content

[GitBox]

rombert merged pull request #2:
URL: 
https://github.com/apache/sling-org-apache-sling-scripting-sightly-repl/pull/2


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-scripting-sightly-repl] sonarcloud[bot] commented on pull request #2: SLING-10978 - HTL REPL should be installed under /content

[GitBox]

sonarcloud[bot] commented on pull request #2:
URL: 
https://github.com/apache/sling-org-apache-sling-scripting-sightly-repl/pull/2#issuecomment-988848976


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=2=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=2=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=2=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=2=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=2=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=2=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly-repl=2=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly-repl=2=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly-repl=2=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=2=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=2=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-repl=2=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-repl=2=coverage=list)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-repl=2=duplicated_lines_density=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-starter] rombert merged pull request #37: SLING-10979 - Move scripting.sightly.repl bundle into a separate feature

[GitBox]

rombert merged pull request #37:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/37


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Resolved] (SLING-10980) Link to the HTL REPL from the Starter front page

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-10980.
-
Resolution: Fixed

https://github.com/apache/sling-org-apache-sling-starter-content/pull/3

> Link to the HTL REPL from the Starter front page
> 
>
> Key: SLING-10980
> URL: https://issues.apache.org/jira/browse/SLING-10980
> Project: Sling
>  Issue Type: New Feature
>  Components: Starter
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Starter Content 1.0.10
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The HTL REPL is a very nice tool that allows quick prototyping and discovery 
> with HTL. We should link it from the front  page of the Starter.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [sling-org-apache-sling-starter-content] rombert merged pull request #3: SLING-10980 - Link to the HTL REPL from the Starter front page

[GitBox]

rombert merged pull request #3:
URL: https://github.com/apache/sling-org-apache-sling-starter-content/pull/3


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Assigned] (SLING-10978) HTL REPL should be installed under /content

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-10978:
---

Assignee: Robert Munteanu

> HTL REPL should be installed under /content
> ---
>
> Key: SLING-10978
> URL: https://issues.apache.org/jira/browse/SLING-10978
> Project: Sling
>  Issue Type: New Feature
>  Components: Scripting
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Scripting HTL REPL 1.0.8
>
>
> The entry HTL repl resource is installed at {{htl/repl}} ( see 
> https://github.com/apache/sling-org-apache-sling-scripting-sightly-repl/blob/ad3ee50c81fb77302fa2d0b7c505c720b93ec494/src/main/resources/SLING-INF/htl/repl.json
>  ).
> It should instead be installed at /content/htl/repl. This will incidentally 
> make it accesible at the same location anyway.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [sling-org-apache-sling-starter] sonarcloud[bot] commented on pull request #37: SLING-10979 - Move scripting.sightly.repl bundle into a separate feature

[GitBox]

sonarcloud[bot] commented on pull request #37:
URL: 
https://github.com/apache/sling-org-apache-sling-starter/pull/37#issuecomment-988846098


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=37=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=37=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=37=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=37=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=37=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=37=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=37=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=37=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=37=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=37=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=37=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=37=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter=37)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter=37=duplicated_lines_density=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-starter-content] sonarcloud[bot] commented on pull request #3: SLING-10980 - Link to the HTL REPL from the Starter front page

[GitBox]

sonarcloud[bot] commented on pull request #3:
URL: 
https://github.com/apache/sling-org-apache-sling-starter-content/pull/3#issuecomment-988845230


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter-content=3=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter-content=3=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter-content=3=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter-content=3=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter-content=3=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter-content=3=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter-content=3=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter-content=3=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter-content=3=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter-content=3=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter-content=3=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter-content=3=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter-content=3)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter-content=3=duplicated_lines_density=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (SLING-10980) Link to the HTL REPL from the Starter front page

[Robert Munteanu (Jira)]

Robert Munteanu created SLING-10980:
---

 Summary: Link to the HTL REPL from the Starter front page
 Key: SLING-10980
 URL: https://issues.apache.org/jira/browse/SLING-10980
 Project: Sling
  Issue Type: New Feature
  Components: Starter
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Starter Content 1.0.10


The HTL REPL is a very nice tool that allows quick prototyping and discovery 
with HTL. We should link it from the front  page of the Starter.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (SLING-10978) HTL REPL should be installed under /content

[Radu Cotescu (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17455256#comment-17455256
 ] 

Radu Cotescu commented on SLING-10978:
--

Go ahead then. :D

> HTL REPL should be installed under /content
> ---
>
> Key: SLING-10978
> URL: https://issues.apache.org/jira/browse/SLING-10978
> Project: Sling
>  Issue Type: New Feature
>  Components: Scripting
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Scripting HTL REPL 1.0.8
>
>
> The entry HTL repl resource is installed at {{htl/repl}} ( see 
> https://github.com/apache/sling-org-apache-sling-scripting-sightly-repl/blob/ad3ee50c81fb77302fa2d0b7c505c720b93ec494/src/main/resources/SLING-INF/htl/repl.json
>  ).
> It should instead be installed at /content/htl/repl. This will incidentally 
> make it accesible at the same location anyway.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (SLING-10978) HTL REPL should be installed under /content

[Robert Munteanu (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17455255#comment-17455255
 ] 

Robert Munteanu commented on SLING-10978:
-

Because I find it simpler/more discoverable to have everything for the starter 
under /content ( access control included ).

> HTL REPL should be installed under /content
> ---
>
> Key: SLING-10978
> URL: https://issues.apache.org/jira/browse/SLING-10978
> Project: Sling
>  Issue Type: New Feature
>  Components: Scripting
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Scripting HTL REPL 1.0.8
>
>
> The entry HTL repl resource is installed at {{htl/repl}} ( see 
> https://github.com/apache/sling-org-apache-sling-scripting-sightly-repl/blob/ad3ee50c81fb77302fa2d0b7c505c720b93ec494/src/main/resources/SLING-INF/htl/repl.json
>  ).
> It should instead be installed at /content/htl/repl. This will incidentally 
> make it accesible at the same location anyway.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (SLING-10978) HTL REPL should be installed under /content

[Radu Cotescu (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17455253#comment-17455253
 ] 

Radu Cotescu commented on SLING-10978:
--

:shrug: If the app stays available at the same URL (via a mapping, redirect, 
etc.) then it doesn't really matter. Why do you want to move it?

> HTL REPL should be installed under /content
> ---
>
> Key: SLING-10978
> URL: https://issues.apache.org/jira/browse/SLING-10978
> Project: Sling
>  Issue Type: New Feature
>  Components: Scripting
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Scripting HTL REPL 1.0.8
>
>
> The entry HTL repl resource is installed at {{htl/repl}} ( see 
> https://github.com/apache/sling-org-apache-sling-scripting-sightly-repl/blob/ad3ee50c81fb77302fa2d0b7c505c720b93ec494/src/main/resources/SLING-INF/htl/repl.json
>  ).
> It should instead be installed at /content/htl/repl. This will incidentally 
> make it accesible at the same location anyway.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Updated] (SLING-10979) Move scripting.sightly.repl bundle into a separate feature

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-10979:

Summary: Move scripting.sightly.repl bundle into a separate feature  (was: 
Move scripting.sightly.repl bundle into its separate feature)

> Move scripting.sightly.repl bundle into a separate feature
> --
>
> Key: SLING-10979
> URL: https://issues.apache.org/jira/browse/SLING-10979
> Project: Sling
>  Issue Type: New Feature
>  Components: Starter
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Starter 12
>
>
> The HTL REPL is a development-time tool and should not be packaged in the 
> scripting feature. Consumers of Sling might mistakenly include it in their 
> deployments. We should move it to its own feature file under 
> {{src/main/features/app}}.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Created] (SLING-10979) Move scripting.sightly.repl bundle into its separate feature

[Robert Munteanu (Jira)]

Robert Munteanu created SLING-10979:
---

 Summary: Move scripting.sightly.repl bundle into its separate 
feature
 Key: SLING-10979
 URL: https://issues.apache.org/jira/browse/SLING-10979
 Project: Sling
  Issue Type: New Feature
  Components: Starter
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Starter 12


The HTL REPL is a development-time tool and should not be packaged in the 
scripting feature. Consumers of Sling might mistakenly include it in their 
deployments. We should move it to its own feature file under 
{{src/main/features/app}}.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (SLING-10978) HTL REPL should be installed under /content

[Robert Munteanu (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17455248#comment-17455248
 ] 

Robert Munteanu commented on SLING-10978:
-

[~radu] - WDYT?

> HTL REPL should be installed under /content
> ---
>
> Key: SLING-10978
> URL: https://issues.apache.org/jira/browse/SLING-10978
> Project: Sling
>  Issue Type: New Feature
>  Components: Scripting
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Scripting HTL REPL 1.0.8
>
>
> The entry HTL repl resource is installed at {{htl/repl}} ( see 
> https://github.com/apache/sling-org-apache-sling-scripting-sightly-repl/blob/ad3ee50c81fb77302fa2d0b7c505c720b93ec494/src/main/resources/SLING-INF/htl/repl.json
>  ).
> It should instead be installed at /content/htl/repl. This will incidentally 
> make it accesible at the same location anyway.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Created] (SLING-10978) HTL REPL should be installed under /content

[Robert Munteanu (Jira)]

Robert Munteanu created SLING-10978:
---

 Summary: HTL REPL should be installed under /content
 Key: SLING-10978
 URL: https://issues.apache.org/jira/browse/SLING-10978
 Project: Sling
  Issue Type: New Feature
  Components: Scripting
Reporter: Robert Munteanu
 Fix For: Scripting HTL REPL 1.0.8


The entry HTL repl resource is installed at {{htl/repl}} ( see 
https://github.com/apache/sling-org-apache-sling-scripting-sightly-repl/blob/ad3ee50c81fb77302fa2d0b7c505c720b93ec494/src/main/resources/SLING-INF/htl/repl.json
 ).

It should instead be installed at /content/htl/repl. This will incidentally 
make it accesible at the same location anyway.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Re: Proposal: Recommend mechanism for launching the feature-model based Starter

[Robert Munteanu]

On Wed, 2021-12-08 at 08:04 -0500, Daniel Klco wrote:
> I like jbang and agree with Konrad, unless there's a good reason not
> to,
> why not provide examples of a couple different ways of running Sling
> (e.g.
> locally with jbang and via Docker)? Not that we need to provide a dozen
> options, but I found that projects that provide instructions to run the
> application in multiple ways help illustrate how an application can be
> run
> and what options are available.

Using multiple options sounds good. I find the 'code snippets with
multiple tabs' pattern useful for this kind of scenario, see [1] for an
example.

Thanks,
Robert


[1]:
https://docs.microsoft.com/en-us/azure/storage/blobs/storage-quickstart-blobs-java?tabs=powershell#create-the-project

Re: Proposal: Recommend mechanism for launching the feature-model based Starter

[Robert Munteanu]

On Wed, 2021-12-08 at 12:46 +0100, Bertrand Delacretaz wrote:
> Hi Robert,
> 
> On Wed, Dec 8, 2021 at 11:43 AM Robert Munteanu 
> wrote:
> > ...For the Sling Starter, it would be great if you could find the
> > time to
> > add an entry to the wiki page [1] so we can see how it compares
> > with
> > the other entries...
> 
> Done, and IMHO I see JBang as a winner: simple installation, simple
> usage, flexible glue scripts (probably in a new sling-scripts
> repository)

Yup, and all that is missing is the glue, so somebody needs to write it
:-) I don't see jbang as easier to ask of than docker, but, as others
have noted, there is no reason not provide multiple options.

Well, to be pedantic, the only potential reason is that we need to
support them, but that's always been implicit with everything we do in
Sling, so we should be good here.

Thanks,
Robert

Re: Proposal: Recommend mechanism for launching the feature-model based Starter

[Daniel Klco]

I like jbang and agree with Konrad, unless there's a good reason not to,
why not provide examples of a couple different ways of running Sling (e.g.
locally with jbang and via Docker)? Not that we need to provide a dozen
options, but I found that projects that provide instructions to run the
application in multiple ways help illustrate how an application can be run
and what options are available.

On Wed, Dec 8, 2021 at 6:46 AM Bertrand Delacretaz 
wrote:

> Hi Robert,
>
> On Wed, Dec 8, 2021 at 11:43 AM Robert Munteanu 
> wrote:
> > ...For the Sling Starter, it would be great if you could find the time to
> > add an entry to the wiki page [1] so we can see how it compares with
> > the other entries...
>
> Done, and IMHO I see JBang as a winner: simple installation, simple
> usage, flexible glue scripts (probably in a new sling-scripts
> repository)
>
> -Bertrand
>
> > [1]:
> >
> https://cwiki.apache.org/confluence/display/SLING/Recommend+mechanism+for+launching+the+feature-model+based+Starter
>

Re: Proposal: Recommend mechanism for launching the feature-model based Starter

[Bertrand Delacretaz]

Hi Robert,

On Wed, Dec 8, 2021 at 11:43 AM Robert Munteanu  wrote:
> ...For the Sling Starter, it would be great if you could find the time to
> add an entry to the wiki page [1] so we can see how it compares with
> the other entries...

Done, and IMHO I see JBang as a winner: simple installation, simple
usage, flexible glue scripts (probably in a new sling-scripts
repository)

-Bertrand

> [1]:
> https://cwiki.apache.org/confluence/display/SLING/Recommend+mechanism+for+launching+the+feature-model+based+Starter

Re: Proposal: Recommend mechanism for launching the feature-model based Starter

[Robert Munteanu]

On Mon, 2021-12-06 at 10:28 +0100, Robert Munteanu wrote:
> Hi Carsten,
> 
> On Sat, 2021-12-04 at 15:06 +0100, Carsten Ziegeler wrote:
> > Hi,
> > 
> > I'm fine with whatever solution we can agree on, however if we
> > promote a 
> > docker based solution we increase the requirements (installed tools)
> > to 
> > be able to run the starter. Now, I guess everyone will now tell me
> > that 
> > everyone else has docker installed anyway but some users might have
> > challenges with that.
> 
> Right, questioning whether requiring Docker/Podman/etc really is simple
> for our users is a good point.
> 
> I'll try and gather some data around that. There are some developer
> surveys floating around (Stackoverflow, ZeroTurnaround, JetBrains),
> I'll try and check if they have data on Docker usage for development.
> If you have something in particular in mind as a target group, let me
> know.

I added some points to [1]. Briefly, besides the 'we probably don't
support the latest JVM' argument, it looks like Docker is available to
a majority of users. There is no hard data on whether this is more
available more than 'the right JVM version'.

Thanks,
Robert

[1]:
https://cwiki.apache.org/confluence/display/SLING/Recommend+mechanism+for+launching+the+feature-model+based+Starter#RecommendmechanismforlaunchingthefeaturemodelbasedStarter-JavavsContainers

[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #788 is BROKEN

[Apache Jenkins Server]

rvice.bundleid=132, 
service.description=Request Logger Filter, service.id=471, 
service.ranking=32768, service.scope=bundle, service.vendor=The Apache Software 
Foundation}] Ignoring unmatching Filter service
[DEBUG] [ServiceReference 472 from bundle 132 : org.apache.sling.engine:2.8.0 
ref=[javax.servlet.Filter] properties={component.id=227, 
component.name=org.apache.sling.engine.parameters, file.max=-1, 
file.threshold=256000, objectClass=[javax.servlet.Filter], 
osgi.http.whiteboard.context.select=(osgi.http.whiteboard.context.name=org.apache.sling),
 osgi.http.whiteboard.filter.pattern=[/], request.max=-1, service.bundleid=132, 
service.description=Filter for request parameter support, service.id=472, 
service.ranking=2147483647, service.scope=bundle, service.vendor=The Apache 
Software Foundation, sling.default.max.parameters=1, 
sling.default.parameter.checkForAdditionalContainerParameters=false, 
sling.default.parameter.encoding=ISO-8859-1}] Ignoring unmatching Filter service
[DEBUG] [ServiceReference 93 from bundle 38 : 
org.apache.sling.launchpad.test-services:12.0.0.SNAPSHOT 
ref=[javax.servlet.Servlet] properties={component.id=64, 
component.name=org.apache.sling.launchpad.testservices.servlets.R6WhiteboardServlet,
 objectClass=[javax.servlet.Servlet], 
osgi.http.whiteboard.context.select=(osgi.http.whiteboard.context.name=org.apache.sling),
 osgi.http.whiteboard.servlet.pattern=/whiteboard_r6, service.bundleid=38, 
service.id=93, service.scope=bundle}] Ignoring unmatching Servlet service
[INFO] Apachde Felix Http Whiteboard Service stopped
[INFO] Stopped Jetty.
[INFO] 
[INFO] --- tools-maven-plugin:1.4:verify-legal-files (verify-legal-files) @ 
org.apache.sling.launchpad.testing ---
[INFO] Checking legal files in: 
org.apache.sling.launchpad.testing-12-SNAPSHOT.jar
[INFO] Checking legal files in: 
org.apache.sling.launchpad.testing-12-SNAPSHOT-sources.jar
[INFO] 
[INFO] --- apache-rat-plugin:0.13:check (rat-check) @ 
org.apache.sling.launchpad.testing ---
[INFO] Enabled default license matchers.
[INFO] Will parse SCM ignores for exclusions...
[INFO] Parsing exclusions from 
/home/jenkins/jenkins-agent/workspace/e-sling-launchpad-testing_master/.gitignore
[INFO] Finished adding exclusions from SCM ignore files.
[INFO] 75 implicit excludes (use -debug for more details).
[INFO] 13 explicit excludes (use -debug for more details).
[INFO] 4 resources included (use -debug for more details)
[INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated: 
0, approved: 3 licenses.
[INFO] 
[INFO] --- maven-failsafe-plugin:2.21.0:verify (default) @ 
org.apache.sling.launchpad.testing ---
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time:  03:43 min
[INFO] Finished at: 2021-12-08T11:30:58Z
[INFO] 
[INFO] [jenkins-event-spy] Generated 
/home/jenkins/jenkins-agent/workspace/e-sling-launchpad-testing_master@tmp/withMavenc22605a9/maven-spy-20211208-112714-6225666951470255835312.log
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-failsafe-plugin:2.21.0:verify (default) on 
project org.apache.sling.launchpad.testing: There are test failures.
[ERROR] 
[ERROR] Please refer to 
/home/jenkins/jenkins-agent/workspace/e-sling-launchpad-testing_master/target/failsafe-reports
 for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump, 
[date].dumpstream and [date]-jvmRun[N].dumpstream.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[Pipeline] }
[withMaven] junitPublisher - Archive test results for Maven artifact 
org.apache.sling:org.apache.sling.launchpad.testing:jar:12-SNAPSHOT generated 
by maven-surefire-plugin:test (default-test): target/surefire-reports/*.xml
Recording test results
None of the test reports contained any result
[withMaven] junitPublisher - Archive test results for Maven artifact 
org.apache.sling:org.apache.sling.launchpad.testing:jar:12-SNAPSHOT generated 
by maven-failsafe-plugin:integration-test (default): 
target/failsafe-reports/*.xml
Recording test results
[withMaven] Jenkins Task Scanner Plugin not found, don't display results of 
source code scanning for 'TODO' and 'FIXME' in pipeline screen.
[DevOpticsMavenPublisher] dependencies consumed: 93, artifacts produced: 0
[withMaven] Publishers: Generated Artifacts Publisher: 341 ms, Junit Publisher: 
71784 ms, Dependencies Fingerprint Publisher: 678 ms, Open Task Scanner 
Publisher: 1 ms, CloudBees DevOptics Gate Arti

Re: Proposal: Recommend mechanism for launching the feature-model based Starter

[Robert Munteanu]

Hi Bertrand,

On Tue, 2021-12-07 at 10:03 +0100, Bertrand Delacretaz wrote:
> Hi,
> 
> On Fri, Dec 3, 2021 at 4:55 PM Robert Munteanu 
> wrote:
> > ...In the context of the upcoming Sling 12 launch we should settle on
> > a
> > recommended mechanism for launching the Sling Starter...
> 
> I don't remember us discussing jbang but it might be a good
> alternative.

JBang looks nice, just played around with it a bit. I think some things
we are currently running as ad-hoc things ( release checker, groovy
scripts in sling-aggregator ) would benefit nicely from being written
in Java.

For the Sling Starter, it would be great if you could find the time to
add an entry to the wiki page [1] so we can see how it compares with
the other entries.

Thanks!
Robert

[1]:
https://cwiki.apache.org/confluence/display/SLING/Recommend+mechanism+for+launching+the+feature-model+based+Starter