date:20231108



 [ 
https://issues.apache.org/jira/browse/SLING-12012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco closed SLING-12012.


> CMS - Add Recent Drafts List
> 
>
> Key: SLING-12012
> URL: https://issues.apache.org/jira/browse/SLING-12012
> Project: Sling
>  Issue Type: Improvement
>  Components: App CMS
>Affects Versions: App CMS 1.1.6
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Trivial
> Fix For: App CMS 1.1.8
>
>
> It would be helpful to have a list of unpublished or "draft" pages make it 
> quicker and easier to find pages which are not yet published



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-12119) Remove Dependency on Guava from CMS



 [ 
https://issues.apache.org/jira/browse/SLING-12119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco closed SLING-12119.


> Remove Dependency on Guava from CMS
> ---
>
> Key: SLING-12119
> URL: https://issues.apache.org/jira/browse/SLING-12119
> Project: Sling
>  Issue Type: Improvement
>  Components: App CMS
>Affects Versions: App CMS 1.1.6
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Major
> Fix For: App CMS 1.1.8
>
>
> Currently, the CMS app depends on Guava for tests and transitively via 
> thumbnails. This isn't ideal as Guava's major version changes are challenging 
> in OSGi and Oak is removing the dependency on Guava.
> Therefore the app should be refactored to remove the dependency on Guava.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-12120) Align Feature Structure with Starter



 [ 
https://issues.apache.org/jira/browse/SLING-12120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco closed SLING-12120.


> Align Feature Structure with Starter
> 
>
> Key: SLING-12120
> URL: https://issues.apache.org/jira/browse/SLING-12120
> Project: Sling
>  Issue Type: Improvement
>  Components: App CMS
>Affects Versions: App CMS 1.1.6
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Major
> Fix For: App CMS 1.1.8
>
>
> There's a significant delta between the configuration of the CMS app and the 
> Sling Starter. Now that the Sling Starter is receiving regular updates, it'd 
> be beneficial to align the feature structure in the CMS App with the starter 
> to enable easy syncing of updates.  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-12011) CMS - Use LazyBindings



 [ 
https://issues.apache.org/jira/browse/SLING-12011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco closed SLING-12011.


> CMS - Use LazyBindings
> --
>
> Key: SLING-12011
> URL: https://issues.apache.org/jira/browse/SLING-12011
> Project: Sling
>  Issue Type: Improvement
>  Components: App CMS
>Affects Versions: App CMS 1.1.6
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Minor
> Fix For: App CMS 1.1.8
>
> Attachments: image-2023-08-26-09-40-00-139.png, 
> image-2023-08-26-09-42-52-390.png
>
>
> While analyzing the Recent Requests for Sling CMS I noticed that it spends a 
> significant amount of time in the DefaultScriptBindingsValueProvider because 
> it's binding all of properties, even if they are not used. 
>  !image-2023-08-26-09-40-00-139.png|thumbnail! 
> By using the LazyBindings and and the LazyBindings.Supplier we can avoid 
> binding unneeded properties. For a simple page like the attached one, this 
> reduces the request duration nearly in half. 
>  !image-2023-08-26-09-42-52-390.png|thumbnail! 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-11810) CMS - Reference Component Escaping Issues



 [ 
https://issues.apache.org/jira/browse/SLING-11810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco closed SLING-11810.


> CMS - Reference Component Escaping Issues
> -
>
> Key: SLING-11810
> URL: https://issues.apache.org/jira/browse/SLING-11810
> Project: Sling
>  Issue Type: Improvement
>  Components: App CMS Reference
>Affects Versions: App CMS 1.1.6
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Minor
> Fix For: App CMS 1.1.8
>
>
> There's a few issues with the reference components following the XSS fixes:
>  - textfield - label name not set correctly
>  - column control - row classes not set



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-11853) CMS - Editor Submit Buttons Sporadically Un-selectable in Mobile



 [ 
https://issues.apache.org/jira/browse/SLING-11853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco closed SLING-11853.


> CMS - Editor Submit Buttons Sporadically Un-selectable in Mobile
> 
>
> Key: SLING-11853
> URL: https://issues.apache.org/jira/browse/SLING-11853
> Project: Sling
>  Issue Type: Bug
>  Components: App CMS
>Affects Versions: App CMS 1.1.6
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Minor
> Fix For: App CMS 1.1.8
>
>
> When editing components on a mobile breakpoint the buttons to submit the form 
> occasionally are positioned outside of the viewport and due to overflow: 
> hidden CSS rules are not visible and thus cannot be clicked to submit the 
> form.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-12121) Repository Path Substitution Incorrect



 [ 
https://issues.apache.org/jira/browse/SLING-12121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco closed SLING-12121.


> Repository Path Substitution Incorrect
> --
>
> Key: SLING-12121
> URL: https://issues.apache.org/jira/browse/SLING-12121
> Project: Sling
>  Issue Type: Bug
>  Components: App CMS
>Affects Versions: App CMS 1.1.6
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Major
> Fix For: App CMS 1.1.8
>
>
> The features for the Oak repository configuration in the CMS app don't 
> declare the sling.home variable and thus aren't properly substituted at 
> runtime. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-11808) Cannot run SlingCMS 1.1.2+ on Windows



 [ 
https://issues.apache.org/jira/browse/SLING-11808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco closed SLING-11808.


> Cannot run SlingCMS 1.1.2+ on Windows
> -
>
> Key: SLING-11808
> URL: https://issues.apache.org/jira/browse/SLING-11808
> Project: Sling
>  Issue Type: Bug
>  Components: App CMS
>Affects Versions: App CMS 1.1.2
>Reporter: James Raynor
>Priority: Major
> Fix For: App CMS 1.1.8
>
> Attachments: 2023-03-17--15-55-28.jpg
>
>
> Hi, I haven't used SlingCMS for a long time.
> I downloaded the latest version today and tried it out, but I can't run the 
> program.
> It shows:
> Artifact 
> jar:file:/C:/Test/SlingCMS/org.apache.sling.cms.feature-1.1.2.jar!/lib/slingcms.far
>  not found.
> OS Windows 10, Java 8, SlingCMS 1.1.0 works fine, expect subsequent versions 
> to fix this problem.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] SLING-12115 - Repoinit should leave importBehaviour for ACL creation to JCR [sling-org-apache-sling-jcr-repoinit]



sonarcloud[bot] commented on PR #45:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#issuecomment-1803106704

   SonarCloud Quality Gate failed.  [![Quality Gate 
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
 'Quality Gate 
failed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=45)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=45=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=45=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=45=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=45=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=45=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=45=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=45=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=45=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=45=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=45=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=45=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=45=false=CODE_SMELL)
   
   
[![79.2%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png
 
'79.2%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=45=new_coverage=list)
 [79.2% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=45=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=45=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=45=new_duplicated_lines_density=list)
   
   
   
   
![idea](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/light_bulb-16px.png
 'idea') Catch issues before they fail your Quality Gate with our IDE extension 
![sonarlint](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/sonarlint-16px.png
 'sonarlint') 
[SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[RESULT] [VOTE] Release Apache Sling App CMS version 1.1.8

2023-11-08 Thread Daniel Klco

Hi,

The vote has passed with the following result :

+1 (binding): Robert Munteanu, Dan Klco, Julian Sedding
+1 (non binding): N/A

I will copy this release to the Sling dist directory and promote the
artifacts to the central Maven repository.

On Sun, Nov 5, 2023 at 11:22 PM Daniel Klco  wrote:

> Hi,
>
> We solved 9 issues in this release:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353038=Text
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2801/
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh
>
> Usage:
> sh check_staged_release.sh 2801 /tmp/sling-staging
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>

Re: [PR] SLING-12115 - Repoinit should leave importBehaviour for ACL creation to JCR [sling-org-apache-sling-jcr-repoinit]



sonarcloud[bot] commented on PR #45:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#issuecomment-1803076700

   SonarCloud Quality Gate failed.  [![Quality Gate 
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
 'Quality Gate 
failed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=45)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=45=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=45=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=45=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=45=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=45=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=45=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=45=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=45=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=45=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=45=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=45=false=CODE_SMELL)
 [2 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=45=false=CODE_SMELL)
   
   
[![79.2%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png
 
'79.2%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=45=new_coverage=list)
 [79.2% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=45=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=45=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=45=new_duplicated_lines_density=list)
   
   
   
   
![idea](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/light_bulb-16px.png
 'idea') Catch issues before they fail your Quality Gate with our IDE extension 
![sonarlint](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/sonarlint-16px.png
 'sonarlint') 
[SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] SLING-12115 - Repoinit should leave importBehaviour for ACL creation to JCR [sling-org-apache-sling-jcr-repoinit]



jsedding commented on PR #45:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#issuecomment-1803003694

   @anchela thank you for the review! I have tried to address the issues you 
pointed out, and I have tried to simplify the diff of the AclVisitor class, 
without reverting back to the previous version. I'll let you be the judge of 
whether I succeeded in simplifying the diff  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] SLING-12115 - Repoinit should leave importBehaviour for ACL creation to JCR [sling-org-apache-sling-jcr-repoinit]



sonarcloud[bot] commented on PR #45:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#issuecomment-1802976809

   Kudos, SonarCloud Quality Gate passed!  [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-repoinit=45)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=45=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=45=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=45=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=45=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=45=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=45=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=45=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=45=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-repoinit=45=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=45=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=45=false=CODE_SMELL)
 [2 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit=45=false=CODE_SMELL)
   
   
[![82.4%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png
 
'82.4%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=45=new_coverage=list)
 [82.4% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=45=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=45=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-repoinit=45=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SLING-12131) Update sling-parent pom.xml to include JUnit5 dependencies



[ 
https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784238#comment-17784238
 ] 

Julian Sedding commented on SLING-12131:


We have {{org.apache.sling.testing.osgi-mock}} and 
{{org.apache.sling.testing.osgi-mock}} testing libraries, which each provide a 
rule. You can find projects importing them with a [github 
search|https://github.com/search?q=org%3Aapache+org.apache.sling.testing.osgi-mock+language%3A%22Maven+POM%22+-repo%3Aapache%2Fsling-whiteboard=code]
 (adjust for sling-mock). Note, when JUnit5 came along, their respective junit4 
(and thus rule-based) variants were renamed to 
{{org.apache.sling.testing.osgi-mock.junit4}} and 
{{{}org.apache.sling.testing.sling-mock.junit4{}}}.

There's also 
[{{org.apache.sling.junit.teleporter}}|https://github.com/apache/sling-org-apache-sling-junit-teleporter],
 not sure that's widely used, but it would be very difficult to rewrite for 
JUnit5. You could search for usages of that one as well.

> Update sling-parent pom.xml to include JUnit5 dependencies
> --
>
> Key: SLING-12131
> URL: https://issues.apache.org/jira/browse/SLING-12131
> Project: Sling
>  Issue Type: Task
>Reporter: Rob McDougall
>Priority: Major
>
> JUnit4 is in maintenance mode (no updates in the last 2 years and then only 
> security fixes).  I think updating projects to JUnit5 should be encouraged.
> I am thinking this should be a relatively easy change of adding the 
> junit-jupiter and junit-vintage-engine into the Dependency Management section 
> of the sling-parent.
> Once this is done, individual projects could switch to the vintage-engine (at 
> the very least) or move to jupiter by switching the dependency in their 
> project pom.
> Some day down the road, the JUnit 4 dependencies could be removed.  Projects 
> that have not updated to JUnit5 (vintage or jupiter) by that time are likely 
> no longer maintained.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[PR] chore(deps): update dependency org.apache.sling:slingfeature-maven-plugin to v1.7.4 [sling-org-apache-sling-starter]



renovate-bot opened a new pull request, #271:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/271

   [![Mend 
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
   
   This PR contains the following updates:
   
   | Package | Change | Age | Adoption | Passing | Confidence |
   |---|---|---|---|---|---|
   | 
[org.apache.sling:slingfeature-maven-plugin](https://sling.apache.org/components/slingfeature-maven-plugin/)
 ([source](https://togithub.com/apache/sling-slingfeature-maven-plugin)) | 
`1.7.2` -> `1.7.4` | 
[![age](https://developer.mend.io/api/mc/badges/age/maven/org.apache.sling:slingfeature-maven-plugin/1.7.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.apache.sling:slingfeature-maven-plugin/1.7.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.apache.sling:slingfeature-maven-plugin/1.7.2/1.7.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.apache.sling:slingfeature-maven-plugin/1.7.2/1.7.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 |
   
   ---
   
   ### Configuration
   
    **Schedule**: Branch creation - At any time (no schedule defined), 
Automerge - At any time (no schedule defined).
   
    **Automerge**: Disabled by config. Please merge this manually once you are 
satisfied.
   
   ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry 
checkbox.
   
    **Ignore**: Close this PR and you won't be reminded about this update 
again.
   
   ---
   
- [ ] If you want to rebase/retry this PR, check this 
box
   
   ---
   
   This PR has been generated by [Mend 
Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository 
job log 
[here](https://developer.mend.io/github/apache/sling-org-apache-sling-starter).
   

   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SLING-12131) Update sling-parent pom.xml to include JUnit5 dependencies



[ 
https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784231#comment-17784231
 ] 

Rob McDougall commented on SLING-12131:
---

{quote}So I think we're finding common ground :) I'm conceding that migrating 
is desirable, and you seem to be conceding that it's a best-effort exercise and 
some parts of such a migration can be non-trivial.
{quote}
Agreed,  I think we all want to do what's best.  And I absolutely agree that 
the transition to the jupiter-engine is not going to happen overnight.

I hadn't realized that the JUnit Vintage engine includes JUnit4 as a transitive 
dependency.

I guess I'm not really looking to remove JUnit4 (just yet :)).  I'm maybe just 
looking to substitute the explicit JUnit4 dependency for the transitive 
dependency in the JUnit5 Vintage engine.  That (at least) moves the ball a 
little.  It also makes the projects dependent on the newer junit-vintage-engine 
rather than on the older junit dependency, which I think is a step forward.

I've started on the PR and am using the sling-hamcrest-matchers project as my 
test project to ensure JUnit 4 compatibility.

Can you point me to a sling project that uses the custom JUnit4 rules?  I will 
attempt to use that as a second testbed to ensure nothing breaks by using the 
JUnit5 dependencies.

> Update sling-parent pom.xml to include JUnit5 dependencies
> --
>
> Key: SLING-12131
> URL: https://issues.apache.org/jira/browse/SLING-12131
> Project: Sling
>  Issue Type: Task
>Reporter: Rob McDougall
>Priority: Major
>
> JUnit4 is in maintenance mode (no updates in the last 2 years and then only 
> security fixes).  I think updating projects to JUnit5 should be encouraged.
> I am thinking this should be a relatively easy change of adding the 
> junit-jupiter and junit-vintage-engine into the Dependency Management section 
> of the sling-parent.
> Once this is done, individual projects could switch to the vintage-engine (at 
> the very least) or move to jupiter by switching the dependency in their 
> project pom.
> Some day down the road, the JUnit 4 dependencies could be removed.  Projects 
> that have not updated to JUnit5 (vintage or jupiter) by that time are likely 
> no longer maintained.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] SLING-12115 - Repoinit should leave importBehaviour for ACL creation to JCR [sling-org-apache-sling-jcr-repoinit]



jsedding commented on code in PR #45:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#discussion_r1387262981


##
src/main/java/org/apache/sling/jcr/repoinit/impl/DoNothingVisitor.java:
##
@@ -66,7 +66,7 @@ protected DoNothingVisitor(Session s) {
 session = s;
 }
 
-protected void report(Exception e, String message) {
+protected static void report(Exception e, String message) {

Review Comment:
   It is used within the `AclVisitor.Instruction` enum, where it isn't 
accessible as an instance method of `AclVisitor`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] SLING-12115 - Repoinit should leave importBehaviour for ACL creation to JCR [sling-org-apache-sling-jcr-repoinit]



jsedding commented on code in PR #45:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#discussion_r1387263538


##
src/test/java/org/apache/sling/jcr/repoinit/GeneralAclTest.java:
##
@@ -270,9 +270,9 @@ private void verifyRegisterNamespace(String username, 
String prefix, String uri,
 try {
 userSession = U.loginService(username);
 
userSession.getWorkspace().getNamespaceRegistry().registerNamespace(prefix, 
uri);
-assertTrue("Register namespace succeeded " + prefix + uri, 
successExpected);
+assertTrue("Register namespace succeeded " + prefix + " " + uri, 
successExpected);
 } catch (RepositoryException e) {
-assertTrue("Error registering namespace " + prefix + uri + " " + 
e.getMessage(), !successExpected);
+assertFalse("Error registering namespace " + prefix + " " + uri + 
" " + e.getMessage(), successExpected);

Review Comment:
   True, that's cleanup.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] SLING-12115 - Repoinit should leave importBehaviour for ACL creation to JCR [sling-org-apache-sling-jcr-repoinit]



jsedding commented on code in PR #45:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#discussion_r1387262981


##
src/main/java/org/apache/sling/jcr/repoinit/impl/DoNothingVisitor.java:
##
@@ -66,7 +66,7 @@ protected DoNothingVisitor(Session s) {
 session = s;
 }
 
-protected void report(Exception e, String message) {
+protected static void report(Exception e, String message) {

Review Comment:
   +1



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] SLING-12115 - Repoinit should leave importBehaviour for ACL creation to JCR [sling-org-apache-sling-jcr-repoinit]



jsedding commented on code in PR #45:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#discussion_r1387262475


##
src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java:
##
@@ -152,7 +154,9 @@ private static void setAcl(Session session, List 
principals, String jcrP
 
 boolean changed = false;
 for (String name : principals) {
-Principal principal = AccessControlUtils.getPrincipal(session, 
name);
+Principal principal = options.contains("ignoreMissingPrincipal")

Review Comment:
   +1 to both points.
   
   Regarding documentation, it's probably best to add a test-case example in 
the repoinit parser module. AFAIK the test files are included in the 
documentation. I suppose that's the downside of having `ACLOptions` accept all 
strings.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] SLING-12115 - Repoinit should leave importBehaviour for ACL creation to JCR [sling-org-apache-sling-jcr-repoinit]



jsedding commented on code in PR #45:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#discussion_r1387260516


##
src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java:
##
@@ -152,7 +154,9 @@ private static void setAcl(Session session, List 
principals, String jcrP
 
 boolean changed = false;
 for (String name : principals) {
-Principal principal = AccessControlUtils.getPrincipal(session, 
name);
+Principal principal = options.contains("ignoreMissingPrincipal")
+? () -> name

Review Comment:
   Sounds sensible. Thanks for catching this change in logic!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] SLING-12115 - Repoinit should leave importBehaviour for ACL creation to JCR [sling-org-apache-sling-jcr-repoinit]



jsedding commented on code in PR #45:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#discussion_r1387260196


##
src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java:
##
@@ -420,7 +419,7 @@ private static boolean isValidPath(@NotNull Session 
session, @Nullable String jc
 /**
  * 
  * @param acMgr the access control manager
- * @param principal the principal
+ * @param path the path

Review Comment:
   Nope, just javadoc cleanup. I'll revert it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] SLING-12115 - Repoinit should leave importBehaviour for ACL creation to JCR [sling-org-apache-sling-jcr-repoinit]

jsedding commented on code in PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#discussion_r1387259771

##
src/main/java/org/apache/sling/jcr/repoinit/impl/AclVisitor.java:
##

Review Comment:
I did this refactoring so that `SetAclPrincipals` and `SetAclPaths` share
the same code-path and to remove code-duplication. For symmetry, and because
just removing the "set ACL" part from the method `setAcl` seemed strange, I did
the same for `RemoveAcePrincipals` and `RemoveAcePaths`. The final reason, why
I didn't want a `setAcl` method in this class is, that it clashes with
`AclUtil#setAcl`, which I found confusing.

The method `setRepositoryAcl` was a copy & paste of `setAcl`, omitting only
the `paths` argument, which was set to `null` in the removed
`AclUtil#setRepositoryAcl`. Removing this in favour of explicitly injecting the
`:repository` path, seemed much clearer to me.

Finally, the `require` method was actually a no-op, because
`AclLine#getProperty()` [never returns
`null`](https://github.com/apache/sling-org-apache-sling-repoinit-parser/blob/ea340191058fefe84ba9134f8025f71a69295a14/src/main/java/org/apache/sling/repoinit/parser/operations/AclLine.java#L64-L67).

If you insist, I can try to revert these changes in favour of a minimal
change-set approach.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] chore(deps): update dependency org.apache.sling:slingfeature-maven-plugin to v1.7.4 [sling-site]



jsedding merged PR #145:
URL: https://github.com/apache/sling-site/pull/145


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] chore(deps): update dependency org.apache.sling:org.apache.sling.feature.analyser to v2.0.2 [sling-site]



jsedding merged PR #144:
URL: https://github.com/apache/sling-site/pull/144


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Comment Edited] (SLING-12131) Update sling-parent pom.xml to include JUnit5 dependencies



[ 
https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784213#comment-17784213
 ] 

Julian Sedding edited comment on SLING-12131 at 11/8/23 9:49 PM:
-

{quote}Given that, unless anyone objects, I am going to create a PR for this.
{quote}
Go ahead! I think we have a clear consensus on that one.
{quote}I've used this before and it works well, [...]
{quote}
Glad to hear that!
{quote}Well, complete conversion to JUnit5 Jupiter should not be required 
before the JUnit4 can be removed. Conversion to JUnit5 Vintage Engine should 
handle custom @Rules and whatever other JUnit4 constructs are being used. 
That's all I am talking about. Once that is done, the dependency on the 
unmaintained JUnit4 is removed. Conversion from Vintage to Jupiter can take as 
long as it takes.
{quote}
JUnit4 is not removed as long as you have the JUnit5 Vintage Engine. JUnit4 is 
then just a transitive dependency and not explicitly in your pom. As long as 
you are using @Rules, which are a JUnit4 API, you cannot remove the JUnit4 
dependency. There is also {{{}junit-jupiter-migrationsupport{}}}, which can 
emulate some JUnit4 rules. But again, that one does not remove the dependency 
on the @Rule API provided by the JUnit4 dependency.

So I think we're finding common ground :) I'm conceding that migrating is 
desirable, and you seem to be conceding that it's a best-effort exercise and 
some parts of such a migration can be non-trivial.


was (Author: jsedding):
bq. Given that, unless anyone objects, I am going to create a PR for this.

Go ahead! I think we have a clear consencus on that one.

bq. I've used this before and it works well, [...]

Glad to hear that!

bq. Well, complete conversion to JUnit5 Jupiter should not be required before 
the JUnit4 can be removed. Conversion to JUnit5 Vintage Engine should handle 
custom @Rules and whatever other JUnit4 constructs are being used. That's all I 
am talking about. Once that is done, the dependency on the unmaintained JUnit4 
is removed. Conversion from Vintage to Jupiter can take as long as it takes.

JUnit4 is not removed as long as you have the JUnit5 Vintage Engine. JUnit4 is 
then just a transitive dependency and not explicitly in your pom. As long as 
you are using @Rules, which are a JUnit4 API, you cannot remove the JUnit4 
dependency. There is also {{{}junit-jupiter-migrationsupport{}}}, which can 
emulate some JUnit4 rules. But again, that one does not remove the dependency 
on the @Rule API provided by the JUnit4 dependency.

So I think we're finding common ground :) I'm conceding that migrating is 
desirable, and you seem to be conceding that it's a best-effort exercise and 
some parts of such a migration can be non-trivial.

> Update sling-parent pom.xml to include JUnit5 dependencies
> --
>
> Key: SLING-12131
> URL: https://issues.apache.org/jira/browse/SLING-12131
> Project: Sling
>  Issue Type: Task
>Reporter: Rob McDougall
>Priority: Major
>
> JUnit4 is in maintenance mode (no updates in the last 2 years and then only 
> security fixes).  I think updating projects to JUnit5 should be encouraged.
> I am thinking this should be a relatively easy change of adding the 
> junit-jupiter and junit-vintage-engine into the Dependency Management section 
> of the sling-parent.
> Once this is done, individual projects could switch to the vintage-engine (at 
> the very least) or move to jupiter by switching the dependency in their 
> project pom.
> Some day down the road, the JUnit 4 dependencies could be removed.  Projects 
> that have not updated to JUnit5 (vintage or jupiter) by that time are likely 
> no longer maintained.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Comment Edited] (SLING-12131) Update sling-parent pom.xml to include JUnit5 dependencies



[ 
https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784213#comment-17784213
 ] 

Julian Sedding edited comment on SLING-12131 at 11/8/23 9:49 PM:
-

bq. Given that, unless anyone objects, I am going to create a PR for this.

Go ahead! I think we have a clear consencus on that one.

bq. I've used this before and it works well, [...]

Glad to hear that!

bq. Well, complete conversion to JUnit5 Jupiter should not be required before 
the JUnit4 can be removed. Conversion to JUnit5 Vintage Engine should handle 
custom @Rules and whatever other JUnit4 constructs are being used. That's all I 
am talking about. Once that is done, the dependency on the unmaintained JUnit4 
is removed. Conversion from Vintage to Jupiter can take as long as it takes.

JUnit4 is not removed as long as you have the JUnit5 Vintage Engine. JUnit4 is 
then just a transitive dependency and not explicitly in your pom. As long as 
you are using @Rules, which are a JUnit4 API, you cannot remove the JUnit4 
dependency. There is also {{{}junit-jupiter-migrationsupport{}}}, which can 
emulate some JUnit4 rules. But again, that one does not remove the dependency 
on the @Rule API provided by the JUnit4 dependency.

So I think we're finding common ground :) I'm conceding that migrating is 
desirable, and you seem to be conceding that it's a best-effort exercise and 
some parts of such a migration can be non-trivial.


was (Author: jsedding):
bq. I've used this before and it works well, [...]

Glad to hear that!

bq. Well, complete conversion to JUnit5 Jupiter should not be required before 
the JUnit4 can be removed. Conversion to JUnit5 Vintage Engine should handle 
custom @Rules and whatever other JUnit4 constructs are being used. That's all I 
am talking about. Once that is done, the dependency on the unmaintained JUnit4 
is removed. Conversion from Vintage to Jupiter can take as long as it takes.

JUnit4 is not removed as long as you have the JUnit5 Vintage Engine. JUnit4 is 
then just a transitive dependency and not explicitly in your pom. As long as 
you are using @Rules, which are a JUnit4 API, you cannot remove the JUnit4 
dependency. There is also {{junit-jupiter-migrationsupport}}, which can emulate 
some JUnit4 rules. But again, that one does not remove the dependency on the 
@Rule API provided by the JUnit4 dependency.

So I think we're finding common ground :) I'm conceding that migrating is 
desirable, and you seem to be conceding that it's a best-effort exercise and 
some parts of such a migration can be non-trivial.

> Update sling-parent pom.xml to include JUnit5 dependencies
> --
>
> Key: SLING-12131
> URL: https://issues.apache.org/jira/browse/SLING-12131
> Project: Sling
>  Issue Type: Task
>Reporter: Rob McDougall
>Priority: Major
>
> JUnit4 is in maintenance mode (no updates in the last 2 years and then only 
> security fixes).  I think updating projects to JUnit5 should be encouraged.
> I am thinking this should be a relatively easy change of adding the 
> junit-jupiter and junit-vintage-engine into the Dependency Management section 
> of the sling-parent.
> Once this is done, individual projects could switch to the vintage-engine (at 
> the very least) or move to jupiter by switching the dependency in their 
> project pom.
> Some day down the road, the JUnit 4 dependencies could be removed.  Projects 
> that have not updated to JUnit5 (vintage or jupiter) by that time are likely 
> no longer maintained.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-12131) Update sling-parent pom.xml to include JUnit5 dependencies



[ 
https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784213#comment-17784213
 ] 

Julian Sedding commented on SLING-12131:


bq. I've used this before and it works well, [...]

Glad to hear that!

bq. Well, complete conversion to JUnit5 Jupiter should not be required before 
the JUnit4 can be removed. Conversion to JUnit5 Vintage Engine should handle 
custom @Rules and whatever other JUnit4 constructs are being used. That's all I 
am talking about. Once that is done, the dependency on the unmaintained JUnit4 
is removed. Conversion from Vintage to Jupiter can take as long as it takes.

JUnit4 is not removed as long as you have the JUnit5 Vintage Engine. JUnit4 is 
then just a transitive dependency and not explicitly in your pom. As long as 
you are using @Rules, which are a JUnit4 API, you cannot remove the JUnit4 
dependency. There is also {{junit-jupiter-migrationsupport}}, which can emulate 
some JUnit4 rules. But again, that one does not remove the dependency on the 
@Rule API provided by the JUnit4 dependency.

So I think we're finding common ground :) I'm conceding that migrating is 
desirable, and you seem to be conceding that it's a best-effort exercise and 
some parts of such a migration can be non-trivial.

> Update sling-parent pom.xml to include JUnit5 dependencies
> --
>
> Key: SLING-12131
> URL: https://issues.apache.org/jira/browse/SLING-12131
> Project: Sling
>  Issue Type: Task
>Reporter: Rob McDougall
>Priority: Major
>
> JUnit4 is in maintenance mode (no updates in the last 2 years and then only 
> security fixes).  I think updating projects to JUnit5 should be encouraged.
> I am thinking this should be a relatively easy change of adding the 
> junit-jupiter and junit-vintage-engine into the Dependency Management section 
> of the sling-parent.
> Once this is done, individual projects could switch to the vintage-engine (at 
> the very least) or move to jupiter by switching the dependency in their 
> project pom.
> Some day down the road, the JUnit 4 dependencies could be removed.  Projects 
> that have not updated to JUnit5 (vintage or jupiter) by that time are likely 
> no longer maintained.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-12126) Update o.a.s.repoinit.parser to 1.9.0 in feature model analyzer



 [ 
https://issues.apache.org/jira/browse/SLING-12126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Sedding closed SLING-12126.
--

> Update o.a.s.repoinit.parser to 1.9.0 in feature model analyzer
> ---
>
> Key: SLING-12126
> URL: https://issues.apache.org/jira/browse/SLING-12126
> Project: Sling
>  Issue Type: Task
>  Components: Feature Model Analyser
>Affects Versions: Feature Model Analyser 2.0.0
>Reporter: Julian Sedding
>Assignee: Julian Sedding
>Priority: Minor
> Fix For: Feature Model Analyser 2.0.2
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-11935) JarDecompressorTest.testWithEmbeddedJar fails on Jenkins/Windows



 [ 
https://issues.apache.org/jira/browse/SLING-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Sedding closed SLING-11935.
--

> JarDecompressorTest.testWithEmbeddedJar fails on Jenkins/Windows
> 
>
> Key: SLING-11935
> URL: https://issues.apache.org/jira/browse/SLING-11935
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Robert Munteanu
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: OSGi Feature Maven Plugin 1.7.4
>
>
> This is the only CI failure, but I don't understand enough about the 
> JarDecompressor to make an informed fix. I will ignore the test on Windows 
> for now, but it would be great to understand the root cause and fix it.
> {noformat}[ERROR] 
> org.apache.sling.feature.maven.mojos.JarDecompressorTest.testJarWithEmbeddedJar
>   Time elapsed: 0.071 s  <<< FAILURE!
> java.lang.AssertionError: expected:<2108> but was:<1984>
>   at org.junit.Assert.fail(Assert.java:89)
>   at org.junit.Assert.failNotEquals(Assert.java:835)
>   at org.junit.Assert.assertEquals(Assert.java:647)
>   at org.junit.Assert.assertEquals(Assert.java:633)
>   at 
> org.apache.sling.feature.maven.mojos.JarDecompressorTest.testJarWithEmbeddedJar(JarDecompressorTest.java:81)
>   at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.base/java.lang.reflect.Method.invoke(Method.java:566)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
>   at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
>   at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
>   at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:364)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:272)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:237)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:158)
>   at 
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:428)
>   at 
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
>   at 
> org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:562)
>   at 
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:548){noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-11947) Convert Plexus to JSR330 components



 [ 
https://issues.apache.org/jira/browse/SLING-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Sedding closed SLING-11947.
--

> Convert Plexus to JSR330 components
> ---
>
> Key: SLING-11947
> URL: https://issues.apache.org/jira/browse/SLING-11947
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Affects Versions: OSGi Feature Maven Plugin 1.7.2
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: OSGi Feature Maven Plugin 1.7.4
>
>
> As Plexus component descriptors are deprecated 
> (https://codehaus-plexus.github.io/plexus-containers/#deprecated) one should 
> migrate instead to the standard JSR330 annotations which are evaluated at run 
> time (https://github.com/eclipse/sisu.plexus/wiki/Plexus-to-JSR330)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-11948) Get rid of legacy maven-compat dependency



 [ 
https://issues.apache.org/jira/browse/SLING-11948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Sedding closed SLING-11948.
--

> Get rid of legacy maven-compat dependency
> -
>
> Key: SLING-11948
> URL: https://issues.apache.org/jira/browse/SLING-11948
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Affects Versions: OSGi Feature Maven Plugin 1.7.2
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: OSGi Feature Maven Plugin 1.7.4
>
>
> This involves leveraging Maven Resolver API directly. Using legacy 
> maven-compat leads to a WARN with Maven 3.9.x.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-11987) Allow report into a single file



 [ 
https://issues.apache.org/jira/browse/SLING-11987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Sedding closed SLING-11987.
--

> Allow report into a single file
> ---
>
> Key: SLING-11987
> URL: https://issues.apache.org/jira/browse/SLING-11987
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: OSGi Feature Maven Plugin 1.7.4
>
>
> The feature report can either be outputted into the normal log output or into 
> separate report files per feature.
> Sometimes it is useful to get a single report across all features



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-9883) ApisJarMojo: Provide-Capability should be collected from all contained bundles and exposed



 [ 
https://issues.apache.org/jira/browse/SLING-9883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Sedding closed SLING-9883.
-

> ApisJarMojo: Provide-Capability should be collected from all contained 
> bundles and exposed
> --
>
> Key: SLING-9883
> URL: https://issues.apache.org/jira/browse/SLING-9883
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Affects Versions: slingfeature-maven-plugin 1.4.6
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: OSGi Feature Maven Plugin 1.7.4
>
>
> In order to leverage 
> https://github.com/bndtools/bnd/tree/master/maven/bnd-resolver-maven-plugin 
> at build time it would be nice if the API jar would include the 
> {{Provide-Capability}} headers from all contained bundles (similar to 
> {{Export-Package}} and {{Sling-Nodetypes}}).
> See also 
> https://lists.apache.org/thread.html/r7bb5c4493fa241ac5cd8d8ea313ff970866e2f2efc6254ee6a0fd41a%40%3Cdev.sling.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-12009) Report errors and warnings at the end of the scan



 [ 
https://issues.apache.org/jira/browse/SLING-12009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Sedding closed SLING-12009.
--

> Report errors and warnings at the end of the scan
> -
>
> Key: SLING-12009
> URL: https://issues.apache.org/jira/browse/SLING-12009
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: OSGi Feature Maven Plugin 1.7.4
>
>
> Especially when a lot of features get analysed, the errors and warnings are 
> "hidden" in between all the analysis runs. This makes it sometimes hard to 
> find them.
> The report could be deferred to the end of the scan 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-11985) Add report about imported packages



 [ 
https://issues.apache.org/jira/browse/SLING-11985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Sedding closed SLING-11985.
--

> Add report about imported packages
> --
>
> Key: SLING-11985
> URL: https://issues.apache.org/jira/browse/SLING-11985
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: OSGi Feature Maven Plugin 1.7.4
>
>
> We only have a report for exported packages; sometimes it is also useful to 
> get info about all imported packages



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-12127) Update o.a.s.repoinit.parser to 1.9.0 in slingfeature-maven-plugin



 [ 
https://issues.apache.org/jira/browse/SLING-12127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Sedding closed SLING-12127.
--

> Update o.a.s.repoinit.parser to 1.9.0 in slingfeature-maven-plugin
> --
>
> Key: SLING-12127
> URL: https://issues.apache.org/jira/browse/SLING-12127
> Project: Sling
>  Issue Type: Task
>  Components: Feature Model, Maven Plugins and Archetypes
>Affects Versions: OSGi Feature Maven Plugin 1.7.2
>Reporter: Julian Sedding
>Assignee: Julian Sedding
>Priority: Minor
> Fix For: OSGi Feature Maven Plugin 1.7.4
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-12131) Update sling-parent pom.xml to include JUnit5 dependencies



[ 
https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784163#comment-17784163
 ] 

Rob McDougall commented on SLING-12131:
---

{quote}A quick google turned up that the OpenRewrite projct
{quote}
I've used this before and it works well, but I haven't used it for custom 
@Rules (which I would imagine don't migrate well).
{quote}There are custom @Rule implementations that are non-trivial to migrate. 
There are runners, that may not be trivial to migrate, either. The difference 
between assertions and some ootb \{{@Rule}}s can likely be covered with 
automation.
 
{quote}
Well, complete conversion to JUnit5 Jupiter should not be required before the 
JUnit4 can be removed. Conversion to JUnit5 Vintage Engine should handle custom 
@Rules and whatever other JUnit4 constructs are being used. That's all I am 
talking about. Once that is done, the dependency on the unmaintained JUnit4 is 
removed. Conversion from Vintage to Jupiter can take as long as it takes.

> Update sling-parent pom.xml to include JUnit5 dependencies
> --
>
> Key: SLING-12131
> URL: https://issues.apache.org/jira/browse/SLING-12131
> Project: Sling
>  Issue Type: Task
>Reporter: Rob McDougall
>Priority: Major
>
> JUnit4 is in maintenance mode (no updates in the last 2 years and then only 
> security fixes).  I think updating projects to JUnit5 should be encouraged.
> I am thinking this should be a relatively easy change of adding the 
> junit-jupiter and junit-vintage-engine into the Dependency Management section 
> of the sling-parent.
> Once this is done, individual projects could switch to the vintage-engine (at 
> the very least) or move to jupiter by switching the dependency in their 
> project pom.
> Some day down the road, the JUnit 4 dependencies could be removed.  Projects 
> that have not updated to JUnit5 (vintage or jupiter) by that time are likely 
> no longer maintained.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] SLING-12115 - Repoinit should leave importBehaviour for ACL creation to JCR [sling-org-apache-sling-jcr-repoinit]



anchela commented on code in PR #45:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#discussion_r1387009917


##
src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java:
##
@@ -152,7 +154,9 @@ private static void setAcl(Session session, List 
principals, String jcrP
 
 boolean changed = false;
 for (String name : principals) {
-Principal principal = AccessControlUtils.getPrincipal(session, 
name);
+Principal principal = options.contains("ignoreMissingPrincipal")

Review Comment:
   i would recommend to create a constant in the jcr-repoinit space such that 
it is not just hidden somewhere in the code
   
   also, i would love this option to be documented in the repo-init 
documentation. but since that is in a separate git repo, you probably have to 
do it separately. but please don't forget it.



##
src/main/java/org/apache/sling/jcr/repoinit/impl/AclVisitor.java:
##


Review Comment:
   sorry too many changes to review with reasonable effort :(
   can you avoid any renaming of methods that are unrelated to the change 
required here?
   i am all in favor of cleaning up the code base, but please use a separate 
ticket for that.



##
src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java:
##
@@ -152,7 +154,9 @@ private static void setAcl(Session session, List 
principals, String jcrP
 
 boolean changed = false;
 for (String name : principals) {
-Principal principal = AccessControlUtils.getPrincipal(session, 
name);
+Principal principal = options.contains("ignoreMissingPrincipal")
+? () -> name

Review Comment:
   i would slightly alter the logic here, as the fallback below is 
significant. if you just use the specified name now, you might break that 
contract below.
   
   so, i would suggest:
   - always try to retrieve the principal first
   - if it does not exist -> try backwards compatible fallback to original code
   - if it does not exist -> create the anonymous principal in case option is 
set as you do here, otherwise use old behavior.
   
   i believe this way we run the least risk of introducing subtle regressions 
that are super hard to troubleshoot.



##
src/main/java/org/apache/sling/jcr/repoinit/impl/DoNothingVisitor.java:
##
@@ -66,7 +66,7 @@ protected DoNothingVisitor(Session s) {
 session = s;
 }
 
-protected void report(Exception e, String message) {
+protected static void report(Exception e, String message) {

Review Comment:
   unrelated to the task at hand. please move that to a general 
cleanup.improvmeent PR.



##
src/test/java/org/apache/sling/jcr/repoinit/GeneralAclTest.java:
##
@@ -270,9 +270,9 @@ private void verifyRegisterNamespace(String username, 
String prefix, String uri,
 try {
 userSession = U.loginService(username);
 
userSession.getWorkspace().getNamespaceRegistry().registerNamespace(prefix, 
uri);
-assertTrue("Register namespace succeeded " + prefix + uri, 
successExpected);
+assertTrue("Register namespace succeeded " + prefix + " " + uri, 
successExpected);
 } catch (RepositoryException e) {
-assertTrue("Error registering namespace " + prefix + uri + " " + 
e.getMessage(), !successExpected);
+assertFalse("Error registering namespace " + prefix + " " + uri + 
" " + e.getMessage(), successExpected);

Review Comment:
    what does the changes for SLING-12115 lead to a changed assertion in a 
namespace related test? that doesn't look good at all.



##
src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java:
##
@@ -420,7 +419,7 @@ private static boolean isValidPath(@NotNull Session 
session, @Nullable String jc
 /**
  * 
  * @param acMgr the access control manager
- * @param principal the principal
+ * @param path the path

Review Comment:
   is that change related?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SLING-12131) Update sling-parent pom.xml to include JUnit5 dependencies



[ 
https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784161#comment-17784161
 ] 

Rob McDougall commented on SLING-12131:
---

So, at this point, I think no-one is arguing that the JUnit5 BOM dependency 
shouldn't be added.  The only discussion is whether the JUnit4 dependency 
should be removed sometime down the road (and maybe how far down the road that 
is).

Given that, unless anyone objects, I am going to create a PR for this.

> Update sling-parent pom.xml to include JUnit5 dependencies
> --
>
> Key: SLING-12131
> URL: https://issues.apache.org/jira/browse/SLING-12131
> Project: Sling
>  Issue Type: Task
>Reporter: Rob McDougall
>Priority: Major
>
> JUnit4 is in maintenance mode (no updates in the last 2 years and then only 
> security fixes).  I think updating projects to JUnit5 should be encouraged.
> I am thinking this should be a relatively easy change of adding the 
> junit-jupiter and junit-vintage-engine into the Dependency Management section 
> of the sling-parent.
> Once this is done, individual projects could switch to the vintage-engine (at 
> the very least) or move to jupiter by switching the dependency in their 
> project pom.
> Some day down the road, the JUnit 4 dependencies could be removed.  Projects 
> that have not updated to JUnit5 (vintage or jupiter) by that time are likely 
> no longer maintained.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] Updated Hamcrest version to 2.2 [sling-org-apache-sling-testing-hamcrest]



sonarcloud[bot] commented on PR #2:
URL: 
https://github.com/apache/sling-org-apache-sling-testing-hamcrest/pull/2#issuecomment-1802381013

   Kudos, SonarCloud Quality Gate passed!  [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-hamcrest=2)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest=2=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest=2=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest=2=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest=2=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest=2=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest=2=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-hamcrest=2=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-hamcrest=2=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-hamcrest=2=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest=2=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest=2=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest=2=false=CODE_SMELL)
   
   
[![85.7%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png
 
'85.7%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-hamcrest=2=new_coverage=list)
 [85.7% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-hamcrest=2=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-hamcrest=2=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-hamcrest=2=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] chore(deps): update dependency org.apache.sling:slingfeature-maven-plugin to v1.7.4 [sling-site]



renovate-bot opened a new pull request, #145:
URL: https://github.com/apache/sling-site/pull/145

   [![Mend 
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
   
   This PR contains the following updates:
   
   | Package | Change | Age | Adoption | Passing | Confidence |
   |---|---|---|---|---|---|
   | 
[org.apache.sling:slingfeature-maven-plugin](https://sling.apache.org/components/slingfeature-maven-plugin/)
 ([source](https://togithub.com/apache/sling-slingfeature-maven-plugin)) | 
`1.7.2` -> `1.7.4` | 
[![age](https://developer.mend.io/api/mc/badges/age/maven/org.apache.sling:slingfeature-maven-plugin/1.7.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.apache.sling:slingfeature-maven-plugin/1.7.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.apache.sling:slingfeature-maven-plugin/1.7.2/1.7.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.apache.sling:slingfeature-maven-plugin/1.7.2/1.7.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 |
   
   ---
   
   > [!WARNING]
   > Some dependencies could not be looked up. Check the Dependency Dashboard 
for more information.
   
   ---
   
   ### Configuration
   
    **Schedule**: Branch creation - At any time (no schedule defined), 
Automerge - At any time (no schedule defined).
   
    **Automerge**: Disabled by config. Please merge this manually once you are 
satisfied.
   
   ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry 
checkbox.
   
    **Ignore**: Close this PR and you won't be reminded about this update 
again.
   
   ---
   
- [ ] If you want to rebase/retry this PR, check this 
box
   
   ---
   
   This PR has been generated by [Mend 
Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository 
job log [here](https://developer.mend.io/github/apache/sling-site).
   

   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] chore(deps): update dependency org.apache.sling:org.apache.sling.feature.analyser to v2.0.2 [sling-site]



renovate-bot opened a new pull request, #144:
URL: https://github.com/apache/sling-site/pull/144

   [![Mend 
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
   
   This PR contains the following updates:
   
   | Package | Change | Age | Adoption | Passing | Confidence |
   |---|---|---|---|---|---|
   | 
[org.apache.sling:org.apache.sling.feature.analyser](https://sling.apache.org) 
([source](https://togithub.com/apache/sling-org-apache-sling-feature-analyser)) 
| `2.0.0` -> `2.0.2` | 
[![age](https://developer.mend.io/api/mc/badges/age/maven/org.apache.sling:org.apache.sling.feature.analyser/2.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.apache.sling:org.apache.sling.feature.analyser/2.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.apache.sling:org.apache.sling.feature.analyser/2.0.0/2.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.apache.sling:org.apache.sling.feature.analyser/2.0.0/2.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 |
   
   ---
   
   > [!WARNING]
   > Some dependencies could not be looked up. Check the Dependency Dashboard 
for more information.
   
   ---
   
   ### Configuration
   
    **Schedule**: Branch creation - At any time (no schedule defined), 
Automerge - At any time (no schedule defined).
   
    **Automerge**: Disabled by config. Please merge this manually once you are 
satisfied.
   
   ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry 
checkbox.
   
    **Ignore**: Close this PR and you won't be reminded about this update 
again.
   
   ---
   
- [ ] If you want to rebase/retry this PR, check this 
box
   
   ---
   
   This PR has been generated by [Mend 
Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository 
job log [here](https://developer.mend.io/github/apache/sling-site).
   

   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SLING-12131) Update sling-parent pom.xml to include JUnit5 dependencies



[ 
https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784146#comment-17784146
 ] 

Julian Sedding commented on SLING-12131:


If migration is the goal, then it may make sense to facilitate semi-automated 
migration. A quick google turned up that the OpenRewrite projct has several 
[rules for migrating various 
scenarios|https://docs.openrewrite.org/recipes/java/testing/junit5]. There is a 
maven plugin, so we could add a configuration to the parent pom. IIUC it is 
[invoked using {{mvn 
rewrite:run}}|https://docs.openrewrite.org/running-recipes/getting-started#step-4-run-a-simple-refactoring-recipe].
 We could also put the plugin into a profile, if we want to guard against any 
surprises.

I agree that it would be desirable to migrate all actively maintained modules 
to junit5. That said, I don't believe it is realistic in the foreseeable 
future, most certainly not without automation. There are custom {{@Rule}} 
implementations that are non-trivial to migrate. There are runners, that may 
not be trivial to migrate, either. The difference between assertions and some 
ootb {{@Rule}}s can likely be covered with automation. Remains to be seen how 
well the automation works.

> Update sling-parent pom.xml to include JUnit5 dependencies
> --
>
> Key: SLING-12131
> URL: https://issues.apache.org/jira/browse/SLING-12131
> Project: Sling
>  Issue Type: Task
>Reporter: Rob McDougall
>Priority: Major
>
> JUnit4 is in maintenance mode (no updates in the last 2 years and then only 
> security fixes).  I think updating projects to JUnit5 should be encouraged.
> I am thinking this should be a relatively easy change of adding the 
> junit-jupiter and junit-vintage-engine into the Dependency Management section 
> of the sling-parent.
> Once this is done, individual projects could switch to the vintage-engine (at 
> the very least) or move to jupiter by switching the dependency in their 
> project pom.
> Some day down the road, the JUnit 4 dependencies could be removed.  Projects 
> that have not updated to JUnit5 (vintage or jupiter) by that time are likely 
> no longer maintained.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [VOTE] Release Apache Sling App CMS version 1.1.8

+1 - all checks ok

Regards

Julian

On Wed, Nov 8, 2023 at 3:40 PM Daniel Klco  wrote:
>
> My +1
>
> On Wed, Nov 8, 2023 at 8:20 AM Robert Munteanu  wrote:
>
> > On Sun, 2023-11-05 at 23:22 -0500, Daniel Klco wrote:
> > > Please vote to approve this release:
> >
> > +1
> > Robert
> >

[jira] [Comment Edited] (SLING-12131) Update sling-parent pom.xml to include JUnit5 dependencies



[ 
https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784113#comment-17784113
 ] 

Rob McDougall edited comment on SLING-12131 at 11/8/23 4:19 PM:


> Testing dependencies are never transitive and therefore should not affect 
> simple consumers of any Sling bundles!

My point is not really related to testing dependencies.  My point is that 
unmaintained projects will have outdated dependencies that cause work for 
developers.  A reliable indicator that a project is unmaintained is that it 
does not move to JUnit5 (vintage-engine, at least).  This means that removal of 
Junit4 after some finite period causing breakage is an indicator that the 
project is unmaintained.  Do we want to keep an obsolete dependency in the 
parent pom for the sole purpose of allowing unmaintained projects to compile?

If the answer to that question is "yes", then my question would be for how 
long?  If the answer to that is "forever", then that says that you don't intend 
to ever prune unmaintained projects.  That doesn't sound like a reasonable 
stance to me,

If the answer is for some finite period, then that would mean that it would be 
safe to remove an obsolete dependency (in this case JUnit 4) after that finite 
period (whatever it is). 


was (Author: robmcdougall):
> Testing dependencies are never transitive and therefore should not affect 
> simple consumers of any Sling bundles!

My point is not really related to testing dependencies.  My point is that 
unmaintained projects will have outdated dependencies that cause work for 
developers.  A reliable indicator that a project is unmaintained is that it 
does not move to JUnit5.  This means that removal of Junit4 after some finite 
period causing breakage is an indicator that the project is unmaintained.  Do 
we want to keep an obsolete dependency in the parent pom for the sole purpose 
of allowing unmaintained projects to compile?

If the answer to that question is "yes", then my question would be for how 
long?  If the answer to that is "forever", then that says that you don't intend 
to ever prune unmaintained projects.  That doesn't sound like a reasonable 
stance to me,

If the answer is for some finite period, then that would mean that it would be 
safe to remove an obsolete dependency (in this case JUnit 4) after that finite 
period (whatever it is). 

> Update sling-parent pom.xml to include JUnit5 dependencies
> --
>
> Key: SLING-12131
> URL: https://issues.apache.org/jira/browse/SLING-12131
> Project: Sling
>  Issue Type: Task
>Reporter: Rob McDougall
>Priority: Major
>
> JUnit4 is in maintenance mode (no updates in the last 2 years and then only 
> security fixes).  I think updating projects to JUnit5 should be encouraged.
> I am thinking this should be a relatively easy change of adding the 
> junit-jupiter and junit-vintage-engine into the Dependency Management section 
> of the sling-parent.
> Once this is done, individual projects could switch to the vintage-engine (at 
> the very least) or move to jupiter by switching the dependency in their 
> project pom.
> Some day down the road, the JUnit 4 dependencies could be removed.  Projects 
> that have not updated to JUnit5 (vintage or jupiter) by that time are likely 
> no longer maintained.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-12131) Update sling-parent pom.xml to include JUnit5 dependencies



[ 
https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784113#comment-17784113
 ] 

Rob McDougall commented on SLING-12131:
---

> Testing dependencies are never transitive and therefore should not affect 
> simple consumers of any Sling bundles!

My point is not really related to testing dependencies.  My point is that 
unmaintained projects will have outdated dependencies that cause work for 
developers.  A reliable indicator that a project is unmaintained is that it 
does not move to JUnit5.  This means that removal of Junit4 after some finite 
period causing breakage is an indicator that the project is unmaintained.  Do 
we want to keep an obsolete dependency in the parent pom for the sole purpose 
of allowing unmaintained projects to compile?

If the answer to that question is "yes", then my question would be for how 
long?  If the answer to that is "forever", then that says that you don't intend 
to ever prune unmaintained projects.  That doesn't sound like a reasonable 
stance to me,

If the answer is for some finite period, then that would mean that it would be 
safe to remove an obsolete dependency (in this case JUnit 4) after that finite 
period (whatever it is). 

> Update sling-parent pom.xml to include JUnit5 dependencies
> --
>
> Key: SLING-12131
> URL: https://issues.apache.org/jira/browse/SLING-12131
> Project: Sling
>  Issue Type: Task
>Reporter: Rob McDougall
>Priority: Major
>
> JUnit4 is in maintenance mode (no updates in the last 2 years and then only 
> security fixes).  I think updating projects to JUnit5 should be encouraged.
> I am thinking this should be a relatively easy change of adding the 
> junit-jupiter and junit-vintage-engine into the Dependency Management section 
> of the sling-parent.
> Once this is done, individual projects could switch to the vintage-engine (at 
> the very least) or move to jupiter by switching the dependency in their 
> project pom.
> Some day down the road, the JUnit 4 dependencies could be removed.  Projects 
> that have not updated to JUnit5 (vintage or jupiter) by that time are likely 
> no longer maintained.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [VOTE] Release Apache Sling Content Distribution Journal Messages 0.5.6

2023-11-08 Thread Daniel Klco

+1

On Wed, Nov 8, 2023 at 10:31 AM Julian Sedding  wrote:

> +1 - all checks ok
>
> Regards
> Julian
>
> On Wed, Nov 8, 2023 at 2:01 PM Robert Munteanu  wrote:
> >
> > On Tue, 2023-11-07 at 10:24 +0100, Timothee Maret wrote:
> > > Please vote to approve this release:
> >
> > +1
> > Robert
>

[jira] [Comment Edited] (SLING-12131) Update sling-parent pom.xml to include JUnit5 dependencies

2023-11-08 Thread Konrad Windszus (Jira)



[ 
https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784105#comment-17784105
 ] 

Konrad Windszus edited comment on SLING-12131 at 11/8/23 3:53 PM:
--

Testing dependencies are never transitive and therefore should not affect 
simple consumers of any Sling bundles! As long as JUnit4 tests execute fine 
just within the Sling project I agree with [~jsedding] that other things are 
much more important than changing the runner. I already made the experience 
that running both JUnit4 and 5 side by side is not always properly detected by 
maven-surefire-plugin, so this may be some more effort. But this is open 
source, everyone is invited to propose PRs to migrate existing Sling modules.


was (Author: kwin):
Testing dependencies are never transitive and therefore should not affect 
simple consumers of any Sling bundles! As long as JUnit4 tests execute fine 
just within the Sling project I agree with [~jsedding] that other things are 
much more important. I already made some experience that running both JUnit4 
and 5 side by side is not always properly detected by maven-surefire-plugin, so 
this may be some more effort. But this is open source, everyone is invited to 
propose PRs to migrate existing Sling modules.

> Update sling-parent pom.xml to include JUnit5 dependencies
> --
>
> Key: SLING-12131
> URL: https://issues.apache.org/jira/browse/SLING-12131
> Project: Sling
>  Issue Type: Task
>Reporter: Rob McDougall
>Priority: Major
>
> JUnit4 is in maintenance mode (no updates in the last 2 years and then only 
> security fixes).  I think updating projects to JUnit5 should be encouraged.
> I am thinking this should be a relatively easy change of adding the 
> junit-jupiter and junit-vintage-engine into the Dependency Management section 
> of the sling-parent.
> Once this is done, individual projects could switch to the vintage-engine (at 
> the very least) or move to jupiter by switching the dependency in their 
> project pom.
> Some day down the road, the JUnit 4 dependencies could be removed.  Projects 
> that have not updated to JUnit5 (vintage or jupiter) by that time are likely 
> no longer maintained.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-12131) Update sling-parent pom.xml to include JUnit5 dependencies

2023-11-08 Thread Konrad Windszus (Jira)



[ 
https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784105#comment-17784105
 ] 

Konrad Windszus commented on SLING-12131:
-

Testing dependencies are never transitive and therefore should not affect 
simple consumers of any Sling bundles! As long as JUnit4 tests execute fine 
just within the Sling project I agree with [~jsedding] that other things are 
much more important. I already made some experience that running both JUnit4 
and 5 side by side is not always properly detected by maven-surefire-plugin, so 
this may be some more effort. But this is open source, everyone is invited to 
propose PRs to migrate existing Sling modules.

> Update sling-parent pom.xml to include JUnit5 dependencies
> --
>
> Key: SLING-12131
> URL: https://issues.apache.org/jira/browse/SLING-12131
> Project: Sling
>  Issue Type: Task
>Reporter: Rob McDougall
>Priority: Major
>
> JUnit4 is in maintenance mode (no updates in the last 2 years and then only 
> security fixes).  I think updating projects to JUnit5 should be encouraged.
> I am thinking this should be a relatively easy change of adding the 
> junit-jupiter and junit-vintage-engine into the Dependency Management section 
> of the sling-parent.
> Once this is done, individual projects could switch to the vintage-engine (at 
> the very least) or move to jupiter by switching the dependency in their 
> project pom.
> Some day down the road, the JUnit 4 dependencies could be removed.  Projects 
> that have not updated to JUnit5 (vintage or jupiter) by that time are likely 
> no longer maintained.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [VOTE] Release Apache Sling Content Distribution Journal Messages 0.5.6

+1 - all checks ok

Regards
Julian

On Wed, Nov 8, 2023 at 2:01 PM Robert Munteanu  wrote:
>
> On Tue, 2023-11-07 at 10:24 +0100, Timothee Maret wrote:
> > Please vote to approve this release:
>
> +1
> Robert

[RESULT] [VOTE] Release Apache Sling OSGi Feature Maven Plugin 1.7.4, Apache Sling Feature Model Analyser 2.0.2

Hi,

The vote has passed with the following result:

+1 (binding): Carsten Ziegeler, Joerg Hoh, Julian Sedding
+1 (non-binding): none

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

Regards
Julian


On Wed, Nov 8, 2023 at 3:11 PM Julian Sedding  wrote:
>
> +1
>
> Regards
> Julian
>
> On Sun, Nov 5, 2023 at 12:39 PM Jörg Hoh  
> wrote:
> >
> > +1
> >
> > Am Sa., 4. Nov. 2023 um 16:07 Uhr schrieb Julian Sedding  > >:
> >
> > > Hi,
> > >
> > > We solved 9 issues in these releases:
> > >
> > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12352907=Text
> > >
> > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353405=Text
> > >
> > > Staging repository:
> > > https://repository.apache.org/content/repositories/orgapachesling-2800/
> > >
> > > You can use this UNIX script to download the release and verify the
> > > signatures:
> > >
> > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh
> > >
> > > Usage:
> > > sh check_staged_release.sh 2800 /tmp/sling-staging
> > >
> > > Please vote to approve this release:
> > >
> > >   [ ] +1 Approve the release
> > >   [ ]  0 Don't care
> > >   [ ] -1 Don't release, because ...
> > >
> > > This majority vote is open for at least 72 hours.
> > >
> > > Regards
> > > Julian
> > >
> >
> >
> > --
> > Cheers,
> > Jörg Hoh,
> >
> > https://cqdump.joerghoh.de
> > Twitter: @joerghoh

[jira] [Commented] (SLING-12131) Update sling-parent pom.xml to include JUnit5 dependencies



[ 
https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784085#comment-17784085
 ] 

Rob McDougall commented on SLING-12131:
---

> Also, there is virtually no value in doing so, because you can use junit4 and 
> junit5 side-by-side

I disagree.  JUnit4 will be unmaintained at some point (it may already be now, 
not sure).  In theory, the switch to JUnit5 vintage should be pretty painless 
(just a pom.xml change and re-run the tests).  Projects that are being 
maintained will make this change.  If no one cares to make such a trivial 
change to a project over a two year period (or pick some longer period if you 
wish), then who knows what other dependencies are not being updated.  Software 
is more like milk than wine - it does not get better with age.

Old dependencies cause work for developers using those libraries (I myself 
experienced this which is why I raised SLING-12130).  If we have to force 
someone to exclude dependencies from their maven files, I would prefer to make 
people who are running old versions of libraries do the work rather than those 
who are current.

I'm not in favour of unnecessary work, however I would argue that this is 
necessary work.  I don't think you can argue against the idea that at some 
point all active projects will have to move to JUnit5, it's just a matter of 
when.  At what point to you designate a project as "unmaintained" and prune it? 
 Two years? Five years? Ten years?  I would argue that whatever that period is, 
then that's how long you wait before dropping Junit4 from the pom.  I don't 
believe "never" is an acceptable answer.

> Update sling-parent pom.xml to include JUnit5 dependencies
> --
>
> Key: SLING-12131
> URL: https://issues.apache.org/jira/browse/SLING-12131
> Project: Sling
>  Issue Type: Task
>Reporter: Rob McDougall
>Priority: Major
>
> JUnit4 is in maintenance mode (no updates in the last 2 years and then only 
> security fixes).  I think updating projects to JUnit5 should be encouraged.
> I am thinking this should be a relatively easy change of adding the 
> junit-jupiter and junit-vintage-engine into the Dependency Management section 
> of the sling-parent.
> Once this is done, individual projects could switch to the vintage-engine (at 
> the very least) or move to jupiter by switching the dependency in their 
> project pom.
> Some day down the road, the JUnit 4 dependencies could be removed.  Projects 
> that have not updated to JUnit5 (vintage or jupiter) by that time are likely 
> no longer maintained.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [VOTE] Release Apache Sling App CMS version 1.1.8

2023-11-08 Thread Daniel Klco

My +1

On Wed, Nov 8, 2023 at 8:20 AM Robert Munteanu  wrote:

> On Sun, 2023-11-05 at 23:22 -0500, Daniel Klco wrote:
> > Please vote to approve this release:
>
> +1
> Robert
>

Re: [PR] Updated Hamcrest version to 2.2 [sling-org-apache-sling-testing-hamcrest]



rmcdouga commented on PR #2:
URL: 
https://github.com/apache/sling-org-apache-sling-testing-hamcrest/pull/2#issuecomment-1801999485

   OK, will do.  I have some other tasks at work, so it may not happen until 
the weekend.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [VOTE] Release Apache Sling Feature Model Analyser 2.0.2, Apache Sling OSGi Feature Maven Plugin 1.7.4

+1

Regards
Julian

On Sun, Nov 5, 2023 at 12:39 PM Jörg Hoh  wrote:
>
> +1
>
> Am Sa., 4. Nov. 2023 um 16:07 Uhr schrieb Julian Sedding  >:
>
> > Hi,
> >
> > We solved 9 issues in these releases:
> >
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12352907=Text
> >
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353405=Text
> >
> > Staging repository:
> > https://repository.apache.org/content/repositories/orgapachesling-2800/
> >
> > You can use this UNIX script to download the release and verify the
> > signatures:
> >
> > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh
> >
> > Usage:
> > sh check_staged_release.sh 2800 /tmp/sling-staging
> >
> > Please vote to approve this release:
> >
> >   [ ] +1 Approve the release
> >   [ ]  0 Don't care
> >   [ ] -1 Don't release, because ...
> >
> > This majority vote is open for at least 72 hours.
> >
> > Regards
> > Julian
> >
>
>
> --
> Cheers,
> Jörg Hoh,
>
> https://cqdump.joerghoh.de
> Twitter: @joerghoh

Re: [VOTE] Release Apache Sling App CMS version 1.1.8

2023-11-08 Thread Robert Munteanu

On Sun, 2023-11-05 at 23:22 -0500, Daniel Klco wrote:
> Please vote to approve this release:

+1
Robert


signature.asc
Description: This is a digitally signed message part

Re: [VOTE] Release Apache Sling Content Distribution Journal Messages 0.5.6

2023-11-08 Thread Robert Munteanu

On Tue, 2023-11-07 at 10:24 +0100, Timothee Maret wrote:
> Please vote to approve this release:

+1
Robert


signature.asc
Description: This is a digitally signed message part

[jira] [Commented] (SLING-12131) Update sling-parent pom.xml to include JUnit5 dependencies



[ 
https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784022#comment-17784022
 ] 

Julian Sedding commented on SLING-12131:


bq. Let us please just import the JUnit BOM [...]

+1 from me

> Update sling-parent pom.xml to include JUnit5 dependencies
> --
>
> Key: SLING-12131
> URL: https://issues.apache.org/jira/browse/SLING-12131
> Project: Sling
>  Issue Type: Task
>Reporter: Rob McDougall
>Priority: Major
>
> JUnit4 is in maintenance mode (no updates in the last 2 years and then only 
> security fixes).  I think updating projects to JUnit5 should be encouraged.
> I am thinking this should be a relatively easy change of adding the 
> junit-jupiter and junit-vintage-engine into the Dependency Management section 
> of the sling-parent.
> Once this is done, individual projects could switch to the vintage-engine (at 
> the very least) or move to jupiter by switching the dependency in their 
> project pom.
> Some day down the road, the JUnit 4 dependencies could be removed.  Projects 
> that have not updated to JUnit5 (vintage or jupiter) by that time are likely 
> no longer maintained.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Comment Edited] (SLING-12131) Update sling-parent pom.xml to include JUnit5 dependencies



[ 
https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784016#comment-17784016
 ] 

Julian Sedding edited comment on SLING-12131 at 11/8/23 12:35 PM:
--

AFAIK the latest maven-surefire-plugin automatically adds the jupiter and 
vintage engines if the jupiter-api and the junit api, respectively, are in the 
dependencies.

I would also like to transition more to junit5/jupiter, and since you can even 
mix and match individual test methods within the same class, I see no reason 
why we shouldn't move forward with it.

I would add the following two dependencies to sling-parent:
- org.junit.jupiter:junit-jupiter-api
- org.junit.jupiter:junit-jupiter-params


bq. Some day down the road, the JUnit 4 dependencies could be removed.  
Projects that have not updated to JUnit5 (vintage or jupiter) by that time are 
likely no longer maintained.

Yes, we could eventually remove JUnit 4 from the parent. But I disagree with 
the rest of the statement. IMHO, it is _very_ unlikely that we find the time 
and resources to migrate all tests to junit5. Also, there is virtually no value 
in doing so, because you can use junit4 and junit5 side-by-side. Therefore, in 
my eyes, concluding whether or not a module is maintained, will be independent 
of whether it uses junit4 or junit5.




was (Author: jsedding):
AFAIK the latest maven-surefire-plugin automatically adds the jupiter and 
vintage engines if the jupiter-api and the junit api, respectively, are in the 
dependencies.

I would also like to transition more to junit5/jupiter, and since you can even 
mix and match individual test methods within the same class, I see no reason 
why we shouldn't move forward with it.

I would add the following two dependencies to sling-parent:
- org.junit.jupiter:junit-jupiter-api
- org.junit.jupiter:junit-jupiter-params

> Update sling-parent pom.xml to include JUnit5 dependencies
> --
>
> Key: SLING-12131
> URL: https://issues.apache.org/jira/browse/SLING-12131
> Project: Sling
>  Issue Type: Task
>Reporter: Rob McDougall
>Priority: Major
>
> JUnit4 is in maintenance mode (no updates in the last 2 years and then only 
> security fixes).  I think updating projects to JUnit5 should be encouraged.
> I am thinking this should be a relatively easy change of adding the 
> junit-jupiter and junit-vintage-engine into the Dependency Management section 
> of the sling-parent.
> Once this is done, individual projects could switch to the vintage-engine (at 
> the very least) or move to jupiter by switching the dependency in their 
> project pom.
> Some day down the road, the JUnit 4 dependencies could be removed.  Projects 
> that have not updated to JUnit5 (vintage or jupiter) by that time are likely 
> no longer maintained.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-12131) Update sling-parent pom.xml to include JUnit5 dependencies

2023-11-08 Thread Konrad Windszus (Jira)



[ 
https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784018#comment-17784018
 ] 

Konrad Windszus commented on SLING-12131:
-

Let us please just import the JUnit BOM in the depMgmt of sling parent 
(https://junit.org/junit5/docs/current/user-guide/#running-tests-build-maven-bom).
 Otherwise there is a very high chance, that different versions of JUnit5 are 
used which are imcompatible with each other.

> Update sling-parent pom.xml to include JUnit5 dependencies
> --
>
> Key: SLING-12131
> URL: https://issues.apache.org/jira/browse/SLING-12131
> Project: Sling
>  Issue Type: Task
>Reporter: Rob McDougall
>Priority: Major
>
> JUnit4 is in maintenance mode (no updates in the last 2 years and then only 
> security fixes).  I think updating projects to JUnit5 should be encouraged.
> I am thinking this should be a relatively easy change of adding the 
> junit-jupiter and junit-vintage-engine into the Dependency Management section 
> of the sling-parent.
> Once this is done, individual projects could switch to the vintage-engine (at 
> the very least) or move to jupiter by switching the dependency in their 
> project pom.
> Some day down the road, the JUnit 4 dependencies could be removed.  Projects 
> that have not updated to JUnit5 (vintage or jupiter) by that time are likely 
> no longer maintained.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-12131) Update sling-parent pom.xml to include JUnit5 dependencies



[ 
https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784016#comment-17784016
 ] 

Julian Sedding commented on SLING-12131:


AFAIK the latest maven-surefire-plugin automatically adds the jupiter and 
vintage engines if the jupiter-api and the junit api, respectively, are in the 
dependencies.

I would also like to transition more to junit5/jupiter, and since you can even 
mix and match individual test methods within the same class, I see no reason 
why we shouldn't move forward with it.

I would add the following two dependencies to sling-parent:
- org.junit.jupiter:junit-jupiter-api
- org.junit.jupiter:junit-jupiter-params

> Update sling-parent pom.xml to include JUnit5 dependencies
> --
>
> Key: SLING-12131
> URL: https://issues.apache.org/jira/browse/SLING-12131
> Project: Sling
>  Issue Type: Task
>Reporter: Rob McDougall
>Priority: Major
>
> JUnit4 is in maintenance mode (no updates in the last 2 years and then only 
> security fixes).  I think updating projects to JUnit5 should be encouraged.
> I am thinking this should be a relatively easy change of adding the 
> junit-jupiter and junit-vintage-engine into the Dependency Management section 
> of the sling-parent.
> Once this is done, individual projects could switch to the vintage-engine (at 
> the very least) or move to jupiter by switching the dependency in their 
> project pom.
> Some day down the road, the JUnit 4 dependencies could be removed.  Projects 
> that have not updated to JUnit5 (vintage or jupiter) by that time are likely 
> no longer maintained.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-12064) Migrate sling.caconfig.impl to jakarta.json

2023-11-08 Thread Ashok Pelluru (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-12064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashok Pelluru resolved SLING-12064.
---
Resolution: Fixed

> Migrate sling.caconfig.impl to jakarta.json
> ---
>
> Key: SLING-12064
> URL: https://issues.apache.org/jira/browse/SLING-12064
> Project: Sling
>  Issue Type: Sub-task
>Reporter: Ashok Pelluru
>Assignee: Ashok Pelluru
>Priority: Minor
> Fix For: Context-Aware Configuration Impl 1.6.2
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] SLING-12064: migrate to jakarta.json [sling-org-apache-sling-caconfig-impl]



apelluru merged PR #7:
URL: https://github.com/apache/sling-org-apache-sling-caconfig-impl/pull/7


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (SLING-12064) Migrate sling.caconfig.impl to jakarta.json

2023-11-08 Thread Ashok Pelluru (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-12064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashok Pelluru updated SLING-12064:
--
Fix Version/s: Context-Aware Configuration Impl 1.6.2

> Migrate sling.caconfig.impl to jakarta.json
> ---
>
> Key: SLING-12064
> URL: https://issues.apache.org/jira/browse/SLING-12064
> Project: Sling
>  Issue Type: Sub-task
>Reporter: Ashok Pelluru
>Assignee: Ashok Pelluru
>Priority: Minor
> Fix For: Context-Aware Configuration Impl 1.6.2
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] SLING-12124 - Inconsistent handling of empty selectors [sling-org-apache-sling-engine]