[jira] [Commented] (STORM-634) Storm should support rolling upgrade/downgrade of storm cluster.
[ https://issues.apache.org/jira/browse/STORM-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14350011#comment-14350011 ] ASF GitHub Bot commented on STORM-634: -- Github user Parth-Brahmbhatt commented on the pull request: https://github.com/apache/storm/pull/414#issuecomment-77511548 @revans2 @harshach @ptgoetz upmerged again, re-generated all files using thrift- 0.9.2. Appreciate any feedback you guys can provide. > Storm should support rolling upgrade/downgrade of storm cluster. > > > Key: STORM-634 > URL: https://issues.apache.org/jira/browse/STORM-634 > Project: Apache Storm > Issue Type: Improvement >Reporter: Parth Brahmbhatt >Assignee: Parth Brahmbhatt > > Currently when a new version of storm is released in order to upgrade > existing storm clusters users need to backup their existing topologies , kill > all the topologies , perform the upgrade and resubmit all the topologies. > This is painful and results in downtime which may not be acceptable for > "Always alive" production systems. > Storm should support a rolling upgrade/downgrade deployment process to avoid > these downtimes and to make the transition to a different version effortless. > Based on my initial attempt the primary issue seem to be the java > serialization used to serialize java classes like StormBase, Assignment, > WorkerHeartbeat which is then stored in zookeeper. When deserializing if the > serial versions do not match the deserialization fails resulting in processes > just getting killed indefinitely. We need to change the Utils/serialize and > Utils/deserialize so it can support non java serialization mechanism like > json. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] storm pull request: STORM-634: Storm serialization changed to thri...
Github user Parth-Brahmbhatt commented on the pull request: https://github.com/apache/storm/pull/414#issuecomment-77511548 @revans2 @harshach @ptgoetz upmerged again, re-generated all files using thrift- 0.9.2. Appreciate any feedback you guys can provide. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Storm cluster spanning different data centers
Hello, Can Storm be deployed in a topology where the nimbus node and data nodes in a single cluster can span different data centers (for Disaster recovery scenarios)? Or is there another recommended deployment topology for DR scenarios? Regards Rama
Re: [DISCUSS] Release Storm 0.9.4 / 0.10.0
storm-redis (scheduled to be released at 0.10.0) has one bugfix and one essential feature PRs. - bugfix: https://issues.apache.org/jira/browse/STORM-690 -- It fixes connection pool issue. - feature: https://issues.apache.org/jira/browse/STORM-691 -- It provides basic lookup / persist bolts so I believe it's necessary. Furthermore, I'd like to continue to support various data types with storm-redis Trident, after STORM-691 is merged to master. Thanks! Regards Jungtaek Lim (HeartSaVioR) 2015-03-06 2:37 GMT+09:00 P. Taylor Goetz : > I’d like to start a discussion for releasing 0.9.4 (maintenance release) > and 0.10.0 (security release). > > 0.9.4 is basically a branch of 0.9.3 with two important bug fixes: > > STORM-329: fix cascading Storm failure by improving reconnection > strategy and buffering messages > STORM-130: Supervisor getting killed due to > java.io.FileNotFoundException: File '../stormconf.ser' does not exist. > > Both are long-standing bugs that have proven problematic for many users. > I’d be in favor of releasing 0.9.4 with just those two fixes, but I’m > interested in finding out if anyone thinks there are additional patches to > master that should be considered for 0.9.4. > > 0.10.0 is a much larger release in terms of changes. In addition to the > changes above, it includes all the new security features and numerous fixes > and enhancements (see the CHANGELOG in the master branch for a full list). > > Do we feel 0.10.0 is ready for release? If not what outstanding > bugs/patches should we consider before releasing? > > I’m fine holding off on a 0.10.0 release if we feel there is additional > work to be done, but I’d like to at least move forward with 0.9.4 release. > > Thoughts? > > -Taylor > -- Name : 임 정택 Blog : http://www.heartsavior.net / http://dev.heartsavior.net Twitter : http://twitter.com/heartsavior LinkedIn : http://www.linkedin.com/in/heartsavior
Re: [DISCUSS] Release Storm 0.9.4 / 0.10.0
I agree with Richard, in addition I think we should also include https://github.com/apache/storm/pull/437 once Nathan is on board with the changes. Thanks Parth On 3/5/15, 9:56 AM, "Richard Kellogg" wrote: >I believe the pull request attached to STORM-693 >(https://issues.apache.org/jira/browse/STORM-693) warrants inclusion. > >Could someone at least merge this into the trunk? > >-Original Message- >From: P. Taylor Goetz [mailto:ptgo...@gmail.com] >Sent: Thursday, March 05, 2015 12:38 PM >To: dev@storm.apache.org >Subject: [DISCUSS] Release Storm 0.9.4 / 0.10.0 > >I'd like to start a discussion for releasing 0.9.4 (maintenance release) >and >0.10.0 (security release). > >0.9.4 is basically a branch of 0.9.3 with two important bug fixes: > > STORM-329: fix cascading Storm failure by improving reconnection >strategy and buffering messages > STORM-130: Supervisor getting killed due to >java.io.FileNotFoundException: File '../stormconf.ser' does not exist. > >Both are long-standing bugs that have proven problematic for many users. >I'd >be in favor of releasing 0.9.4 with just those two fixes, but I'm >interested >in finding out if anyone thinks there are additional patches to master >that >should be considered for 0.9.4. > >0.10.0 is a much larger release in terms of changes. In addition to the >changes above, it includes all the new security features and numerous >fixes >and enhancements (see the CHANGELOG in the master branch for a full list). > >Do we feel 0.10.0 is ready for release? If not what outstanding >bugs/patches >should we consider before releasing? > >I'm fine holding off on a 0.10.0 release if we feel there is additional >work >to be done, but I'd like to at least move forward with 0.9.4 release. > >Thoughts? > >-Taylor >
[jira] [Commented] (STORM-693) KafkaBolt exception handling improvement
[ https://issues.apache.org/jira/browse/STORM-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349181#comment-14349181 ] ASF GitHub Bot commented on STORM-693: -- Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/453#issuecomment-77415797 +1 > KafkaBolt exception handling improvement > > > Key: STORM-693 > URL: https://issues.apache.org/jira/browse/STORM-693 > Project: Apache Storm > Issue Type: Bug > Components: storm-kafka >Affects Versions: 0.9.3 >Reporter: Rick Kellogg > > Within the KafkaBolt execute method, an error message is logged if any sort > of error occurs communicating with Kafka. Unfortunately the input is still > acknowledged. > Upon review of the HdfsBolt & HiveBolt, I believe the exception handling > block should include the following two lines: > this.collector.reportError(ex); > this.collector.fail(input); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] storm pull request: STORM-693: when bolt fails to write tuple, it ...
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/453#issuecomment-77415797 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
RE: [DISCUSS] Release Storm 0.9.4 / 0.10.0
I believe the pull request attached to STORM-693 (https://issues.apache.org/jira/browse/STORM-693) warrants inclusion. Could someone at least merge this into the trunk? -Original Message- From: P. Taylor Goetz [mailto:ptgo...@gmail.com] Sent: Thursday, March 05, 2015 12:38 PM To: dev@storm.apache.org Subject: [DISCUSS] Release Storm 0.9.4 / 0.10.0 I'd like to start a discussion for releasing 0.9.4 (maintenance release) and 0.10.0 (security release). 0.9.4 is basically a branch of 0.9.3 with two important bug fixes: STORM-329: fix cascading Storm failure by improving reconnection strategy and buffering messages STORM-130: Supervisor getting killed due to java.io.FileNotFoundException: File '../stormconf.ser' does not exist. Both are long-standing bugs that have proven problematic for many users. I'd be in favor of releasing 0.9.4 with just those two fixes, but I'm interested in finding out if anyone thinks there are additional patches to master that should be considered for 0.9.4. 0.10.0 is a much larger release in terms of changes. In addition to the changes above, it includes all the new security features and numerous fixes and enhancements (see the CHANGELOG in the master branch for a full list). Do we feel 0.10.0 is ready for release? If not what outstanding bugs/patches should we consider before releasing? I'm fine holding off on a 0.10.0 release if we feel there is additional work to be done, but I'd like to at least move forward with 0.9.4 release. Thoughts? -Taylor
[DISCUSS] Release Storm 0.9.4 / 0.10.0
I’d like to start a discussion for releasing 0.9.4 (maintenance release) and 0.10.0 (security release). 0.9.4 is basically a branch of 0.9.3 with two important bug fixes: STORM-329: fix cascading Storm failure by improving reconnection strategy and buffering messages STORM-130: Supervisor getting killed due to java.io.FileNotFoundException: File '../stormconf.ser' does not exist. Both are long-standing bugs that have proven problematic for many users. I’d be in favor of releasing 0.9.4 with just those two fixes, but I’m interested in finding out if anyone thinks there are additional patches to master that should be considered for 0.9.4. 0.10.0 is a much larger release in terms of changes. In addition to the changes above, it includes all the new security features and numerous fixes and enhancements (see the CHANGELOG in the master branch for a full list). Do we feel 0.10.0 is ready for release? If not what outstanding bugs/patches should we consider before releasing? I’m fine holding off on a 0.10.0 release if we feel there is additional work to be done, but I’d like to at least move forward with 0.9.4 release. Thoughts? -Taylor signature.asc Description: Message signed with OpenPGP using GPGMail
[jira] [Commented] (STORM-477) Incorrectly set JAVA_HOME is not detected
[ https://issues.apache.org/jira/browse/STORM-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349092#comment-14349092 ] Oleg Ostashchuk commented on STORM-477: --- Does it mean, that there is no need to work on it and it's already fixed? If yes, can you please advice some other issue, that is unresolved yet and good enough to start with Storm. Thank you! > Incorrectly set JAVA_HOME is not detected > - > > Key: STORM-477 > URL: https://issues.apache.org/jira/browse/STORM-477 > Project: Apache Storm > Issue Type: Bug >Affects Versions: 0.9.2-incubating > Environment: Rhel6 >Reporter: Paul Poulosky >Assignee: Oleg Ostashchuk >Priority: Minor > Labels: newbie > > If JAVA_HOME is incorrectly set in a user's environment when launching storm, > > it fails with an error message that is confusing to end users. > Traceback (most recent call last): > File "/home/y/bin/storm", line 485, in > main() > File "/home/y/bin/storm", line 482, in main > (COMMANDS.get(COMMAND, unknown_command))(*ARGS) > File "/home/y/bin/storm", line 225, in listtopos > extrajars=[USER_CONF_DIR, STORM_DIR + "/bin"]) > File "/home/y/bin/storm", line 153, in exec_storm_class > ] + jvmopts + [klass] + list(args) > File "/home/y/bin/storm", line 97, in confvalue > p = sub.Popen(command, stdout=sub.PIPE) > File "/usr/lib64/python2.6/subprocess.py", line 642, in __init__ > errread, errwrite) > File "/usr/lib64/python2.6/subprocess.py", line 1234, in _execute_child > raise child_exception > It would be nice if this were either detected and a proper error message > printed, or if it warned and fell back to the java found in PATH. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-675) Allow users to have storm-env.sh under config dir to set custom JAVA_HOME and other env variables
[
https://issues.apache.org/jira/browse/STORM-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349040#comment-14349040
]
ASF GitHub Bot commented on STORM-675:
--
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/434#issuecomment-77397949
+1. The diffs of `storm` vs. `storm.py` are minimal and related to windows
compatibility.
For easy reference, here they are:
```
$ diff -w storm storm.py
37a38,40
> def is_windows():
> return sys.platform.startswith('win')
>
174c177
< JAVA_CMD, jvmtype, get_config_opts(),
---
> "java", jvmtype, get_config_opts(),
184c187
< else:
---
> elif is_windows():
186a190,191
> else:
> os.execvp(JAVA_CMD, all_args)
```
> Allow users to have storm-env.sh under config dir to set custom JAVA_HOME and
> other env variables
> -
>
> Key: STORM-675
> URL: https://issues.apache.org/jira/browse/STORM-675
> Project: Apache Storm
> Issue Type: Bug
>Reporter: Sriharsha Chintalapani
>Assignee: Sriharsha Chintalapani
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (STORM-675) Allow users to have storm-env.sh under config dir to set custom JAVA_HOME and other env variables
[ https://issues.apache.org/jira/browse/STORM-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349039#comment-14349039 ] ASF GitHub Bot commented on STORM-675: -- Github user harshach commented on the pull request: https://github.com/apache/storm/pull/434#issuecomment-77397764 @ptgoetz Thanks for the review. Removed the year from LICENSE. > Allow users to have storm-env.sh under config dir to set custom JAVA_HOME and > other env variables > - > > Key: STORM-675 > URL: https://issues.apache.org/jira/browse/STORM-675 > Project: Apache Storm > Issue Type: Bug >Reporter: Sriharsha Chintalapani >Assignee: Sriharsha Chintalapani > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] storm pull request: STORM-675. Allow users to have storm-env.sh un...
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/434#issuecomment-77397949
+1. The diffs of `storm` vs. `storm.py` are minimal and related to windows
compatibility.
For easy reference, here they are:
```
$ diff -w storm storm.py
37a38,40
> def is_windows():
> return sys.platform.startswith('win')
>
174c177
< JAVA_CMD, jvmtype, get_config_opts(),
---
> "java", jvmtype, get_config_opts(),
184c187
< else:
---
> elif is_windows():
186a190,191
> else:
> os.execvp(JAVA_CMD, all_args)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-675. Allow users to have storm-env.sh un...
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/434#issuecomment-77397764 @ptgoetz Thanks for the review. Removed the year from LICENSE. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (STORM-675) Allow users to have storm-env.sh under config dir to set custom JAVA_HOME and other env variables
[ https://issues.apache.org/jira/browse/STORM-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349023#comment-14349023 ] ASF GitHub Bot commented on STORM-675: -- Github user ptgoetz commented on a diff in the pull request: https://github.com/apache/storm/pull/434#discussion_r25876751 --- Diff: conf/storm-env.sh --- @@ -0,0 +1,26 @@ +#!/bin/bash +# +# Copyright 2014 The Apache Software Foundation --- End diff -- Same as previous comment. > Allow users to have storm-env.sh under config dir to set custom JAVA_HOME and > other env variables > - > > Key: STORM-675 > URL: https://issues.apache.org/jira/browse/STORM-675 > Project: Apache Storm > Issue Type: Bug >Reporter: Sriharsha Chintalapani >Assignee: Sriharsha Chintalapani > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-675) Allow users to have storm-env.sh under config dir to set custom JAVA_HOME and other env variables
[ https://issues.apache.org/jira/browse/STORM-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349021#comment-14349021 ] ASF GitHub Bot commented on STORM-675: -- Github user ptgoetz commented on a diff in the pull request: https://github.com/apache/storm/pull/434#discussion_r25876670 --- Diff: bin/storm --- @@ -1,5 +1,7 @@ -#!/usr/bin/python - +#!/bin/bash +# +# Copyright 2014 The Apache Software Foundation --- End diff -- We shouldn't need the copyright year in the license header. > Allow users to have storm-env.sh under config dir to set custom JAVA_HOME and > other env variables > - > > Key: STORM-675 > URL: https://issues.apache.org/jira/browse/STORM-675 > Project: Apache Storm > Issue Type: Bug >Reporter: Sriharsha Chintalapani >Assignee: Sriharsha Chintalapani > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] storm pull request: STORM-675. Allow users to have storm-env.sh un...
Github user ptgoetz commented on a diff in the pull request: https://github.com/apache/storm/pull/434#discussion_r25876751 --- Diff: conf/storm-env.sh --- @@ -0,0 +1,26 @@ +#!/bin/bash +# +# Copyright 2014 The Apache Software Foundation --- End diff -- Same as previous comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-675. Allow users to have storm-env.sh un...
Github user ptgoetz commented on a diff in the pull request: https://github.com/apache/storm/pull/434#discussion_r25876670 --- Diff: bin/storm --- @@ -1,5 +1,7 @@ -#!/usr/bin/python - +#!/bin/bash +# +# Copyright 2014 The Apache Software Foundation --- End diff -- We shouldn't need the copyright year in the license header. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-682: supervisor should handle worker sta...
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/437#issuecomment-77394741 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-682: supervisor should handle worker sta...
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/437#issuecomment-77394892 We may want to consider applying this to the 0.9.x branch as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (STORM-682) Supervisor local worker state corrupted and failing to start.
[
https://issues.apache.org/jira/browse/STORM-682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349014#comment-14349014
]
ASF GitHub Bot commented on STORM-682:
--
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/437#issuecomment-77394892
We may want to consider applying this to the 0.9.x branch as well.
> Supervisor local worker state corrupted and failing to start.
> -
>
> Key: STORM-682
> URL: https://issues.apache.org/jira/browse/STORM-682
> Project: Apache Storm
> Issue Type: Bug
>Reporter: Parth Brahmbhatt
>Assignee: Parth Brahmbhatt
>
> If supervisor's cleanup of a worker fails to delete some heartbeat files the
> local state of the supervisors get corrupted.The only way to recover the
> supervisor from this state is to delete the local state folder where
> supervisor stores all worker information.This fix can get very cumbersome if
> it happens on multiple worker nodes.
> The root cause of the issue is the order in which worker heartbeat versioned
> store files are created vs the deletion order of those files. LocalState.put
> first creates a data file X and then marks a success by creating a file
> X.version. During get it first checks for all *.version files , tries to
> find the largest value of X and then issues a read against X. See the below
> pseudo code
> {code:java}
> start_supervisor() {
> workerIds = `ls local-state/workers`
> for each workerId in workerIds
> versions = `ls local-state/workers/workerId/heartbeats/*.version`
> latest_version = max(versions)
> read local-state/workers/workerId/heartbeats/latest_version [Note there
> is no .version extension]
> }
> {code}
> During cleanup it first tries to delete file X and then X.version. If X gets
> deleted but X.version fails to delete the supervisor fails to start with
> FileNotFoundException in the code above.
> We propose to change the deletion order so the .version files get deleted
> before the data file and catch any IOException when reading worker heartbeats
> to avoid supervisor failure.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (STORM-682) Supervisor local worker state corrupted and failing to start.
[
https://issues.apache.org/jira/browse/STORM-682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349012#comment-14349012
]
ASF GitHub Bot commented on STORM-682:
--
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/437#issuecomment-77394741
+1
> Supervisor local worker state corrupted and failing to start.
> -
>
> Key: STORM-682
> URL: https://issues.apache.org/jira/browse/STORM-682
> Project: Apache Storm
> Issue Type: Bug
>Reporter: Parth Brahmbhatt
>Assignee: Parth Brahmbhatt
>
> If supervisor's cleanup of a worker fails to delete some heartbeat files the
> local state of the supervisors get corrupted.The only way to recover the
> supervisor from this state is to delete the local state folder where
> supervisor stores all worker information.This fix can get very cumbersome if
> it happens on multiple worker nodes.
> The root cause of the issue is the order in which worker heartbeat versioned
> store files are created vs the deletion order of those files. LocalState.put
> first creates a data file X and then marks a success by creating a file
> X.version. During get it first checks for all *.version files , tries to
> find the largest value of X and then issues a read against X. See the below
> pseudo code
> {code:java}
> start_supervisor() {
> workerIds = `ls local-state/workers`
> for each workerId in workerIds
> versions = `ls local-state/workers/workerId/heartbeats/*.version`
> latest_version = max(versions)
> read local-state/workers/workerId/heartbeats/latest_version [Note there
> is no .version extension]
> }
> {code}
> During cleanup it first tries to delete file X and then X.version. If X gets
> deleted but X.version fails to delete the supervisor fails to start with
> FileNotFoundException in the code above.
> We propose to change the deletion order so the .version files get deleted
> before the data file and catch any IOException when reading worker heartbeats
> to avoid supervisor failure.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (STORM-496) task.clj missing debug for logging spout and bolt emit values
[ https://issues.apache.org/jira/browse/STORM-496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349006#comment-14349006 ] ASF GitHub Bot commented on STORM-496: -- Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/446#issuecomment-77394266 +1 > task.clj missing debug for logging spout and bolt emit values > - > > Key: STORM-496 > URL: https://issues.apache.org/jira/browse/STORM-496 > Project: Apache Storm > Issue Type: Bug >Reporter: Sriharsha Chintalapani >Assignee: Sriharsha Chintalapani > Labels: newbie, security > > task.clj in security branch missing debug config for logging spout , bolt > emit values. > https://github.com/apache/incubator-storm/blob/security/storm-core/src/clj/backtype/storm/daemon/task.clj > https://github.com/apache/incubator-storm/blob/master/storm-core/src/clj/backtype/storm/daemon/task.clj#L130 > https://github.com/apache/incubator-storm/blob/master/storm-core/src/clj/backtype/storm/daemon/task.clj#L133 > https://github.com/apache/incubator-storm/blob/master/storm-core/src/clj/backtype/storm/daemon/task.clj#L151 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] storm pull request: STORM-496. task.clj missing debug for logging ...
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/446#issuecomment-77394266 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (STORM-554) the "get-task-object" function in task.clj,the type of first param "topology" should be ^StormTopology not ^TopologyContext
[ https://issues.apache.org/jira/browse/STORM-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348967#comment-14348967 ] ASF GitHub Bot commented on STORM-554: -- Github user d2r commented on the pull request: https://github.com/apache/storm/pull/433#issuecomment-77388451 +1 > the "get-task-object" function in task.clj,the type of first param "topology" > should be ^StormTopology not ^TopologyContext > --- > > Key: STORM-554 > URL: https://issues.apache.org/jira/browse/STORM-554 > Project: Apache Storm > Issue Type: Bug >Affects Versions: 0.9.3-rc2 >Reporter: zhangjinlong >Assignee: zhangjinlong > Fix For: 0.9.3-rc2 > > > the "get-task-object" function in task.clj,the type of first param "topology" > should be ^StormTopology not ^TopologyContext -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] storm pull request: Update "get-task-object" function, change the ...
Github user d2r commented on the pull request: https://github.com/apache/storm/pull/433#issuecomment-77388451 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Resolved] (STORM-554) the "get-task-object" function in task.clj,the type of first param "topology" should be ^StormTopology not ^TopologyContext
[ https://issues.apache.org/jira/browse/STORM-554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Derek Dagit resolved STORM-554. --- Resolution: Fixed Fix Version/s: (was: 0.9.3-rc2) 0.10.0 Thanks [~zhangjinlong], I merged this to master. > the "get-task-object" function in task.clj,the type of first param "topology" > should be ^StormTopology not ^TopologyContext > --- > > Key: STORM-554 > URL: https://issues.apache.org/jira/browse/STORM-554 > Project: Apache Storm > Issue Type: Bug >Affects Versions: 0.9.3-rc2 >Reporter: zhangjinlong >Assignee: zhangjinlong > Fix For: 0.10.0 > > > the "get-task-object" function in task.clj,the type of first param "topology" > should be ^StormTopology not ^TopologyContext -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-554) the "get-task-object" function in task.clj,the type of first param "topology" should be ^StormTopology not ^TopologyContext
[ https://issues.apache.org/jira/browse/STORM-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348968#comment-14348968 ] ASF GitHub Bot commented on STORM-554: -- Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/433 > the "get-task-object" function in task.clj,the type of first param "topology" > should be ^StormTopology not ^TopologyContext > --- > > Key: STORM-554 > URL: https://issues.apache.org/jira/browse/STORM-554 > Project: Apache Storm > Issue Type: Bug >Affects Versions: 0.9.3-rc2 >Reporter: zhangjinlong >Assignee: zhangjinlong > Fix For: 0.9.3-rc2 > > > the "get-task-object" function in task.clj,the type of first param "topology" > should be ^StormTopology not ^TopologyContext -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] storm pull request: Update "get-task-object" function, change the ...
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/433 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (STORM-477) Incorrectly set JAVA_HOME is not detected
[ https://issues.apache.org/jira/browse/STORM-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348926#comment-14348926 ] Sriharsha Chintalapani commented on STORM-477: -- [~revans2] There is a patch available https://github.com/apache/storm/pull/434 that does this already. Please take a look . > Incorrectly set JAVA_HOME is not detected > - > > Key: STORM-477 > URL: https://issues.apache.org/jira/browse/STORM-477 > Project: Apache Storm > Issue Type: Bug >Affects Versions: 0.9.2-incubating > Environment: Rhel6 >Reporter: Paul Poulosky >Assignee: Oleg Ostashchuk >Priority: Minor > Labels: newbie > > If JAVA_HOME is incorrectly set in a user's environment when launching storm, > > it fails with an error message that is confusing to end users. > Traceback (most recent call last): > File "/home/y/bin/storm", line 485, in > main() > File "/home/y/bin/storm", line 482, in main > (COMMANDS.get(COMMAND, unknown_command))(*ARGS) > File "/home/y/bin/storm", line 225, in listtopos > extrajars=[USER_CONF_DIR, STORM_DIR + "/bin"]) > File "/home/y/bin/storm", line 153, in exec_storm_class > ] + jvmopts + [klass] + list(args) > File "/home/y/bin/storm", line 97, in confvalue > p = sub.Popen(command, stdout=sub.PIPE) > File "/usr/lib64/python2.6/subprocess.py", line 642, in __init__ > errread, errwrite) > File "/usr/lib64/python2.6/subprocess.py", line 1234, in _execute_child > raise child_exception > It would be nice if this were either detected and a proper error message > printed, or if it warned and fell back to the java found in PATH. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-477) Incorrectly set JAVA_HOME is not detected
[ https://issues.apache.org/jira/browse/STORM-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348853#comment-14348853 ] Paul Poulosky commented on STORM-477: - [~oleg.ost] I had a fix for this I wrote last week that I have been meaning to submit, but hadn't gotten around to it. It only verifies that JAVA_HOME is set correctly, not that java is seen in PATH. > Incorrectly set JAVA_HOME is not detected > - > > Key: STORM-477 > URL: https://issues.apache.org/jira/browse/STORM-477 > Project: Apache Storm > Issue Type: Bug >Affects Versions: 0.9.2-incubating > Environment: Rhel6 >Reporter: Paul Poulosky >Assignee: Oleg Ostashchuk >Priority: Minor > Labels: newbie > > If JAVA_HOME is incorrectly set in a user's environment when launching storm, > > it fails with an error message that is confusing to end users. > Traceback (most recent call last): > File "/home/y/bin/storm", line 485, in > main() > File "/home/y/bin/storm", line 482, in main > (COMMANDS.get(COMMAND, unknown_command))(*ARGS) > File "/home/y/bin/storm", line 225, in listtopos > extrajars=[USER_CONF_DIR, STORM_DIR + "/bin"]) > File "/home/y/bin/storm", line 153, in exec_storm_class > ] + jvmopts + [klass] + list(args) > File "/home/y/bin/storm", line 97, in confvalue > p = sub.Popen(command, stdout=sub.PIPE) > File "/usr/lib64/python2.6/subprocess.py", line 642, in __init__ > errread, errwrite) > File "/usr/lib64/python2.6/subprocess.py", line 1234, in _execute_child > raise child_exception > It would be nice if this were either detected and a proper error message > printed, or if it warned and fell back to the java found in PATH. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] storm pull request: [STORM-477] Add warning for invalid JAVA_HOME
GitHub user ppoulosk opened a pull request: https://github.com/apache/storm/pull/457 [STORM-477] Add warning for invalid JAVA_HOME This adds a check in the python script to ensure that JAVA_HOME points to an installation of storm, and prints an error message if it is not properly set. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ppoulosk/storm STORM-477 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/457.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #457 commit fc3dd60798c158a26380a931b31325249ca7af16 Author: Paul Poulosky Date: 2015-03-05T14:58:38Z Add warning for invalid JAVA_HOME --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (STORM-477) Incorrectly set JAVA_HOME is not detected
[ https://issues.apache.org/jira/browse/STORM-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348837#comment-14348837 ] ASF GitHub Bot commented on STORM-477: -- GitHub user ppoulosk opened a pull request: https://github.com/apache/storm/pull/457 [STORM-477] Add warning for invalid JAVA_HOME This adds a check in the python script to ensure that JAVA_HOME points to an installation of storm, and prints an error message if it is not properly set. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ppoulosk/storm STORM-477 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/457.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #457 commit fc3dd60798c158a26380a931b31325249ca7af16 Author: Paul Poulosky Date: 2015-03-05T14:58:38Z Add warning for invalid JAVA_HOME > Incorrectly set JAVA_HOME is not detected > - > > Key: STORM-477 > URL: https://issues.apache.org/jira/browse/STORM-477 > Project: Apache Storm > Issue Type: Bug >Affects Versions: 0.9.2-incubating > Environment: Rhel6 >Reporter: Paul Poulosky >Assignee: Oleg Ostashchuk >Priority: Minor > Labels: newbie > > If JAVA_HOME is incorrectly set in a user's environment when launching storm, > > it fails with an error message that is confusing to end users. > Traceback (most recent call last): > File "/home/y/bin/storm", line 485, in > main() > File "/home/y/bin/storm", line 482, in main > (COMMANDS.get(COMMAND, unknown_command))(*ARGS) > File "/home/y/bin/storm", line 225, in listtopos > extrajars=[USER_CONF_DIR, STORM_DIR + "/bin"]) > File "/home/y/bin/storm", line 153, in exec_storm_class > ] + jvmopts + [klass] + list(args) > File "/home/y/bin/storm", line 97, in confvalue > p = sub.Popen(command, stdout=sub.PIPE) > File "/usr/lib64/python2.6/subprocess.py", line 642, in __init__ > errread, errwrite) > File "/usr/lib64/python2.6/subprocess.py", line 1234, in _execute_child > raise child_exception > It would be nice if this were either detected and a proper error message > printed, or if it warned and fell back to the java found in PATH. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Issue Comment Deleted] (STORM-477) Incorrectly set JAVA_HOME is not detected
[ https://issues.apache.org/jira/browse/STORM-477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans updated STORM-477: -- Comment: was deleted (was: [~oleg.ost], The file in question is storm in the bin directory https://github.com/apache/storm/blob/master/bin/storm this file really just sets up the environment to call into java and run the storm code there. But if JAVA_HOME is set incorrectly, or if the java executable cannot be found we get a really odd error that is hard to debug. The goal here is to output a user readable error if JAVA_HOME is set incorrectly, and if we can manage it to print out a user readable error if JAVA_HOME is not set and java is not on the path. One of the key parts of this though is that we want it to run on *NIX and Windows. So using *NIX specific commands like which will not work, unless you can short circuit it for windows.) > Incorrectly set JAVA_HOME is not detected > - > > Key: STORM-477 > URL: https://issues.apache.org/jira/browse/STORM-477 > Project: Apache Storm > Issue Type: Bug >Affects Versions: 0.9.2-incubating > Environment: Rhel6 >Reporter: Paul Poulosky >Assignee: Oleg Ostashchuk >Priority: Minor > Labels: newbie > > If JAVA_HOME is incorrectly set in a user's environment when launching storm, > > it fails with an error message that is confusing to end users. > Traceback (most recent call last): > File "/home/y/bin/storm", line 485, in > main() > File "/home/y/bin/storm", line 482, in main > (COMMANDS.get(COMMAND, unknown_command))(*ARGS) > File "/home/y/bin/storm", line 225, in listtopos > extrajars=[USER_CONF_DIR, STORM_DIR + "/bin"]) > File "/home/y/bin/storm", line 153, in exec_storm_class > ] + jvmopts + [klass] + list(args) > File "/home/y/bin/storm", line 97, in confvalue > p = sub.Popen(command, stdout=sub.PIPE) > File "/usr/lib64/python2.6/subprocess.py", line 642, in __init__ > errread, errwrite) > File "/usr/lib64/python2.6/subprocess.py", line 1234, in _execute_child > raise child_exception > It would be nice if this were either detected and a proper error message > printed, or if it warned and fell back to the java found in PATH. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Issue Comment Deleted] (STORM-477) Incorrectly set JAVA_HOME is not detected
[ https://issues.apache.org/jira/browse/STORM-477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans updated STORM-477: -- Comment: was deleted (was: [~oleg.ost], The file in question is storm in the bin directory https://github.com/apache/storm/blob/master/bin/storm this file really just sets up the environment to call into java and run the storm code there. But if JAVA_HOME is set incorrectly, or if the java executable cannot be found we get a really odd error that is hard to debug. The goal here is to output a user readable error if JAVA_HOME is set incorrectly, and if we can manage it to print out a user readable error if JAVA_HOME is not set and java is not on the path. One of the key parts of this though is that we want it to run on *NIX and Windows. So using *NIX specific commands like which will not work, unless you can short circuit it for windows.) > Incorrectly set JAVA_HOME is not detected > - > > Key: STORM-477 > URL: https://issues.apache.org/jira/browse/STORM-477 > Project: Apache Storm > Issue Type: Bug >Affects Versions: 0.9.2-incubating > Environment: Rhel6 >Reporter: Paul Poulosky >Assignee: Oleg Ostashchuk >Priority: Minor > Labels: newbie > > If JAVA_HOME is incorrectly set in a user's environment when launching storm, > > it fails with an error message that is confusing to end users. > Traceback (most recent call last): > File "/home/y/bin/storm", line 485, in > main() > File "/home/y/bin/storm", line 482, in main > (COMMANDS.get(COMMAND, unknown_command))(*ARGS) > File "/home/y/bin/storm", line 225, in listtopos > extrajars=[USER_CONF_DIR, STORM_DIR + "/bin"]) > File "/home/y/bin/storm", line 153, in exec_storm_class > ] + jvmopts + [klass] + list(args) > File "/home/y/bin/storm", line 97, in confvalue > p = sub.Popen(command, stdout=sub.PIPE) > File "/usr/lib64/python2.6/subprocess.py", line 642, in __init__ > errread, errwrite) > File "/usr/lib64/python2.6/subprocess.py", line 1234, in _execute_child > raise child_exception > It would be nice if this were either detected and a proper error message > printed, or if it warned and fell back to the java found in PATH. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Issue Comment Deleted] (STORM-477) Incorrectly set JAVA_HOME is not detected
[ https://issues.apache.org/jira/browse/STORM-477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans updated STORM-477: -- Comment: was deleted (was: [~oleg.ost], The file in question is storm in the bin directory https://github.com/apache/storm/blob/master/bin/storm this file really just sets up the environment to call into java and run the storm code there. But if JAVA_HOME is set incorrectly, or if the java executable cannot be found we get a really odd error that is hard to debug. The goal here is to output a user readable error if JAVA_HOME is set incorrectly, and if we can manage it to print out a user readable error if JAVA_HOME is not set and java is not on the path. One of the key parts of this though is that we want it to run on *NIX and Windows. So using *NIX specific commands like which will not work, unless you can short circuit it for windows.) > Incorrectly set JAVA_HOME is not detected > - > > Key: STORM-477 > URL: https://issues.apache.org/jira/browse/STORM-477 > Project: Apache Storm > Issue Type: Bug >Affects Versions: 0.9.2-incubating > Environment: Rhel6 >Reporter: Paul Poulosky >Assignee: Oleg Ostashchuk >Priority: Minor > Labels: newbie > > If JAVA_HOME is incorrectly set in a user's environment when launching storm, > > it fails with an error message that is confusing to end users. > Traceback (most recent call last): > File "/home/y/bin/storm", line 485, in > main() > File "/home/y/bin/storm", line 482, in main > (COMMANDS.get(COMMAND, unknown_command))(*ARGS) > File "/home/y/bin/storm", line 225, in listtopos > extrajars=[USER_CONF_DIR, STORM_DIR + "/bin"]) > File "/home/y/bin/storm", line 153, in exec_storm_class > ] + jvmopts + [klass] + list(args) > File "/home/y/bin/storm", line 97, in confvalue > p = sub.Popen(command, stdout=sub.PIPE) > File "/usr/lib64/python2.6/subprocess.py", line 642, in __init__ > errread, errwrite) > File "/usr/lib64/python2.6/subprocess.py", line 1234, in _execute_child > raise child_exception > It would be nice if this were either detected and a proper error message > printed, or if it warned and fell back to the java found in PATH. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-477) Incorrectly set JAVA_HOME is not detected
[ https://issues.apache.org/jira/browse/STORM-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348805#comment-14348805 ] Robert Joseph Evans commented on STORM-477: --- [~oleg.ost], The file in question is storm in the bin directory https://github.com/apache/storm/blob/master/bin/storm this file really just sets up the environment to call into java and run the storm code there. But if JAVA_HOME is set incorrectly, or if the java executable cannot be found we get a really odd error that is hard to debug. The goal here is to output a user readable error if JAVA_HOME is set incorrectly, and if we can manage it to print out a user readable error if JAVA_HOME is not set and java is not on the path. One of the key parts of this though is that we want it to run on *NIX and Windows. So using *NIX specific commands like which will not work, unless you can short circuit it for windows. > Incorrectly set JAVA_HOME is not detected > - > > Key: STORM-477 > URL: https://issues.apache.org/jira/browse/STORM-477 > Project: Apache Storm > Issue Type: Bug >Affects Versions: 0.9.2-incubating > Environment: Rhel6 >Reporter: Paul Poulosky >Assignee: Oleg Ostashchuk >Priority: Minor > Labels: newbie > > If JAVA_HOME is incorrectly set in a user's environment when launching storm, > > it fails with an error message that is confusing to end users. > Traceback (most recent call last): > File "/home/y/bin/storm", line 485, in > main() > File "/home/y/bin/storm", line 482, in main > (COMMANDS.get(COMMAND, unknown_command))(*ARGS) > File "/home/y/bin/storm", line 225, in listtopos > extrajars=[USER_CONF_DIR, STORM_DIR + "/bin"]) > File "/home/y/bin/storm", line 153, in exec_storm_class > ] + jvmopts + [klass] + list(args) > File "/home/y/bin/storm", line 97, in confvalue > p = sub.Popen(command, stdout=sub.PIPE) > File "/usr/lib64/python2.6/subprocess.py", line 642, in __init__ > errread, errwrite) > File "/usr/lib64/python2.6/subprocess.py", line 1234, in _execute_child > raise child_exception > It would be nice if this were either detected and a proper error message > printed, or if it warned and fell back to the java found in PATH. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-477) Incorrectly set JAVA_HOME is not detected
[ https://issues.apache.org/jira/browse/STORM-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348803#comment-14348803 ] Robert Joseph Evans commented on STORM-477: --- [~oleg.ost], The file in question is storm in the bin directory https://github.com/apache/storm/blob/master/bin/storm this file really just sets up the environment to call into java and run the storm code there. But if JAVA_HOME is set incorrectly, or if the java executable cannot be found we get a really odd error that is hard to debug. The goal here is to output a user readable error if JAVA_HOME is set incorrectly, and if we can manage it to print out a user readable error if JAVA_HOME is not set and java is not on the path. One of the key parts of this though is that we want it to run on *NIX and Windows. So using *NIX specific commands like which will not work, unless you can short circuit it for windows. > Incorrectly set JAVA_HOME is not detected > - > > Key: STORM-477 > URL: https://issues.apache.org/jira/browse/STORM-477 > Project: Apache Storm > Issue Type: Bug >Affects Versions: 0.9.2-incubating > Environment: Rhel6 >Reporter: Paul Poulosky >Assignee: Oleg Ostashchuk >Priority: Minor > Labels: newbie > > If JAVA_HOME is incorrectly set in a user's environment when launching storm, > > it fails with an error message that is confusing to end users. > Traceback (most recent call last): > File "/home/y/bin/storm", line 485, in > main() > File "/home/y/bin/storm", line 482, in main > (COMMANDS.get(COMMAND, unknown_command))(*ARGS) > File "/home/y/bin/storm", line 225, in listtopos > extrajars=[USER_CONF_DIR, STORM_DIR + "/bin"]) > File "/home/y/bin/storm", line 153, in exec_storm_class > ] + jvmopts + [klass] + list(args) > File "/home/y/bin/storm", line 97, in confvalue > p = sub.Popen(command, stdout=sub.PIPE) > File "/usr/lib64/python2.6/subprocess.py", line 642, in __init__ > errread, errwrite) > File "/usr/lib64/python2.6/subprocess.py", line 1234, in _execute_child > raise child_exception > It would be nice if this were either detected and a proper error message > printed, or if it warned and fell back to the java found in PATH. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-477) Incorrectly set JAVA_HOME is not detected
[ https://issues.apache.org/jira/browse/STORM-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348801#comment-14348801 ] Robert Joseph Evans commented on STORM-477: --- [~oleg.ost], The file in question is storm in the bin directory https://github.com/apache/storm/blob/master/bin/storm this file really just sets up the environment to call into java and run the storm code there. But if JAVA_HOME is set incorrectly, or if the java executable cannot be found we get a really odd error that is hard to debug. The goal here is to output a user readable error if JAVA_HOME is set incorrectly, and if we can manage it to print out a user readable error if JAVA_HOME is not set and java is not on the path. One of the key parts of this though is that we want it to run on *NIX and Windows. So using *NIX specific commands like which will not work, unless you can short circuit it for windows. > Incorrectly set JAVA_HOME is not detected > - > > Key: STORM-477 > URL: https://issues.apache.org/jira/browse/STORM-477 > Project: Apache Storm > Issue Type: Bug >Affects Versions: 0.9.2-incubating > Environment: Rhel6 >Reporter: Paul Poulosky >Assignee: Oleg Ostashchuk >Priority: Minor > Labels: newbie > > If JAVA_HOME is incorrectly set in a user's environment when launching storm, > > it fails with an error message that is confusing to end users. > Traceback (most recent call last): > File "/home/y/bin/storm", line 485, in > main() > File "/home/y/bin/storm", line 482, in main > (COMMANDS.get(COMMAND, unknown_command))(*ARGS) > File "/home/y/bin/storm", line 225, in listtopos > extrajars=[USER_CONF_DIR, STORM_DIR + "/bin"]) > File "/home/y/bin/storm", line 153, in exec_storm_class > ] + jvmopts + [klass] + list(args) > File "/home/y/bin/storm", line 97, in confvalue > p = sub.Popen(command, stdout=sub.PIPE) > File "/usr/lib64/python2.6/subprocess.py", line 642, in __init__ > errread, errwrite) > File "/usr/lib64/python2.6/subprocess.py", line 1234, in _execute_child > raise child_exception > It would be nice if this were either detected and a proper error message > printed, or if it warned and fell back to the java found in PATH. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-477) Incorrectly set JAVA_HOME is not detected
[ https://issues.apache.org/jira/browse/STORM-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348804#comment-14348804 ] Robert Joseph Evans commented on STORM-477: --- [~oleg.ost], The file in question is storm in the bin directory https://github.com/apache/storm/blob/master/bin/storm this file really just sets up the environment to call into java and run the storm code there. But if JAVA_HOME is set incorrectly, or if the java executable cannot be found we get a really odd error that is hard to debug. The goal here is to output a user readable error if JAVA_HOME is set incorrectly, and if we can manage it to print out a user readable error if JAVA_HOME is not set and java is not on the path. One of the key parts of this though is that we want it to run on *NIX and Windows. So using *NIX specific commands like which will not work, unless you can short circuit it for windows. > Incorrectly set JAVA_HOME is not detected > - > > Key: STORM-477 > URL: https://issues.apache.org/jira/browse/STORM-477 > Project: Apache Storm > Issue Type: Bug >Affects Versions: 0.9.2-incubating > Environment: Rhel6 >Reporter: Paul Poulosky >Assignee: Oleg Ostashchuk >Priority: Minor > Labels: newbie > > If JAVA_HOME is incorrectly set in a user's environment when launching storm, > > it fails with an error message that is confusing to end users. > Traceback (most recent call last): > File "/home/y/bin/storm", line 485, in > main() > File "/home/y/bin/storm", line 482, in main > (COMMANDS.get(COMMAND, unknown_command))(*ARGS) > File "/home/y/bin/storm", line 225, in listtopos > extrajars=[USER_CONF_DIR, STORM_DIR + "/bin"]) > File "/home/y/bin/storm", line 153, in exec_storm_class > ] + jvmopts + [klass] + list(args) > File "/home/y/bin/storm", line 97, in confvalue > p = sub.Popen(command, stdout=sub.PIPE) > File "/usr/lib64/python2.6/subprocess.py", line 642, in __init__ > errread, errwrite) > File "/usr/lib64/python2.6/subprocess.py", line 1234, in _execute_child > raise child_exception > It would be nice if this were either detected and a proper error message > printed, or if it warned and fell back to the java found in PATH. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-477) Incorrectly set JAVA_HOME is not detected
[ https://issues.apache.org/jira/browse/STORM-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348794#comment-14348794 ] Oleg Ostashchuk commented on STORM-477: --- Hello! I would really like to work on this issue. It is my first attempt to contribute in Apache Storm project, so it will be fine if someone could guide me through or give some advices. I'll start by following steps here: https://storm.apache.org/documentation/Contributing-to-Storm.html According to this, issues with "newbie" label may be good to start with. Could you please provide me more information about the issue and where I can find files realated to it? Thanks! > Incorrectly set JAVA_HOME is not detected > - > > Key: STORM-477 > URL: https://issues.apache.org/jira/browse/STORM-477 > Project: Apache Storm > Issue Type: Bug >Affects Versions: 0.9.2-incubating > Environment: Rhel6 >Reporter: Paul Poulosky >Assignee: Oleg Ostashchuk >Priority: Minor > Labels: newbie > > If JAVA_HOME is incorrectly set in a user's environment when launching storm, > > it fails with an error message that is confusing to end users. > Traceback (most recent call last): > File "/home/y/bin/storm", line 485, in > main() > File "/home/y/bin/storm", line 482, in main > (COMMANDS.get(COMMAND, unknown_command))(*ARGS) > File "/home/y/bin/storm", line 225, in listtopos > extrajars=[USER_CONF_DIR, STORM_DIR + "/bin"]) > File "/home/y/bin/storm", line 153, in exec_storm_class > ] + jvmopts + [klass] + list(args) > File "/home/y/bin/storm", line 97, in confvalue > p = sub.Popen(command, stdout=sub.PIPE) > File "/usr/lib64/python2.6/subprocess.py", line 642, in __init__ > errread, errwrite) > File "/usr/lib64/python2.6/subprocess.py", line 1234, in _execute_child > raise child_exception > It would be nice if this were either detected and a proper error message > printed, or if it warned and fell back to the java found in PATH. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
