Re: [QUESTION]
> So a user would need these plugins to map actions without XML. Struts > default behavior would require a user to map the action in the XML file and > that would be struts.xml, right? So would it be fair to say that if I parse > the struts.xml file and all included xml files, then I will have a list of > all available actions in the webapp (assuming user is not using the plugins > you mentioned) ? Please note that these plugins are part of the default struts2 distribution. (Convention, REST, ...) You should not rely on parsing the struts.xml. In fact, such plugins have been around since the very first versions of s2 (called codebehind and zeroconfig). Can't remember for how long I am not writing xml mappings for my actions... Piero - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
Re: thoughts on CI
> But, the problem with this was that wget honors > the new robots.txt file which means wget refuses to pull it down. wget should ignore the robots.txt with the option -erobots=off (or add the line robots=off in .wgetrc) Piero - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
Re: Submit button not working (type="input")
> Fixed on trunk. Thanks :) I will test it tomorrow. > Now comes the funny part, after fixing this I realized that > it should had been failing for jsps also, but it obviously wasn't and I > don't know why :) Sounds like a lot of fun :/ Piero - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Submit button not working (type="input")
uh.. no attachements allowed?
here it is:
webapp/tags/ui/example.ftl
UI Tags Example
<@s.form action="exampleSubmit" enctype="multipart/form-data"
javascriptTooltip="true" >
<@s.textfield
label="Name"
name="name"
tooltip="Enter your Name here"/>
<@s.submit />
<@s.reset onclick="alert('Resetting form now... Press OK to continue!');"
/>
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: Submit button not working (type="input")
Hello, thanks for taking a look. The showcase does work for me as well. After testing around it seems to be a freemarker only issue. I did create a simple example.ftl and changed the xml. The submit button disappears. You find my example.ftl attached to this email. The XML description in struts- tags-ui.xml looks like this: --- example.ftl example.ftl --- Hope you can reproduce it. Piero Am Montag 17 November 2008 17:55:35 schrieb Musachy Barroso: > It seems to be ok, I looked at > apps\showcase\src\main\webapp\tags\ui\example.jsp in showcase, and the > submit button is showing up fine on this url: > > http://localhost:8080/tags/ui/example!input.action > > can you check it out? > musachy > > On Sun, Nov 16, 2008 at 9:52 PM, Musachy Barroso <[EMAIL PROTECTED]> wrote: > >> Is this intended? It seems that the submit.ftl template is not used at > >> all if > >> type is not set to "button". > > > > Nope, it is probably a bug, tt is kind of weird that the testcases didn't > > fail, if that is the case. I will take a look at it tomorrow. > > thanks > > musachy > > -- > > "Hey you! Would you help me to carry the stone?" Pink Floyd - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Submit button not working (type="input")
using simple theme, <@s.submit /> fails .. nothing is rendered. If I am using type="button" it seems to work: <@s.submit type ="button">Submit Is this intended? It seems that the submit.ftl template is not used at all if type is not set to "button". There already was a problem some time ago, don't know if this is related (see my comment): -> https://issues.apache.org/struts/browse/WW-1677 Piero - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Struts2 and production apps
Just my oppinion, but I would go with 2.1.2 beta release. My feeling is that it is the best version available. Piero Am Samstag 15 November 2008 00:56:14 schrieb Koen Serry: > Hi all, > > I'm having a bit of an issue here. I have this small app (based on struts2) > that I want to bring in production, however which version. > > * Production, well beter not take 2.1 since we're still beta > * 2.0.13: seems to be in the fridge? > * 2.0.12: yes great GA, ah no it doesn't do static resources, so all client > side validations won't work > * 2.0.11.2: ok second best: hey doesn't this contain security issues, maybe > not a good idea after all. > > So, without pointing fingers here. I like stuts2 but given the current > status of the project (and taken a thourough look at the manifesto as well) > I'm not sure what to tell/give my customer right now. Please advise. > > Thanks - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE] Bring Convention plugin into trunk and deprecate Zero Config
Are there any news on this topic? It reads like there are missing parts that need to be implemented before moving into trunk. How to help out? Is there anything one can do to speed things up? Piero Am Montag 25 August 2008 15:19:45 schrieb Musachy Barroso: > It wasn't technically a vote (it started like one tho), but I think we > got to the agreement of moving it to trunk. First there is something > that needs to be implemented, the multiple unknown handlers feature, > there is a patch for it, but it needs review. It won't happen for 2.1. > > musachy > > On Mon, Aug 25, 2008 at 9:10 AM, alvins <[EMAIL PROTECTED]> wrote: > > So what was the outcome of the vote - is this moving into trunk? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
WW-1677 breaks submit buttons
Please have a look at my comment at -> https://issues.apache.org/struts/browse/WW-1677 Revision 678078 does work for me. Piero - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [s2] Google XML Pages (GXP) to replace Freemarker in tags?
Am Sonntag, 27. Juli 2008 17:47:49 schrieb Musachy Barroso: > I haven't look at it in detail, but there's got to be a way to create > new "elements" (tags), if there isn't we will hack it and send them > the code :) Can't wait to play with it :-) In the meantime I will have a look at org.apache.struts2.view.** Piero - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [s2] Google XML Pages (GXP) to replace Freemarker in tags?
Am Sonntag, 27. Juli 2008 11:18:06 schrieb Ted Husted: > The proposal would use GXP to generate the same content as we do here, > so we can wrap the output as a JSP, Velocity, or Freemarker "tag". Thanks for the explanation! So lets go one step further - would it be possible for the user to write his templates in GXP instead of JSP, FreeMarker or Velocity? Since there already exists a result, it should not be that complicated. But how to access the wrapped s2 tags in this case? If they are written in GXP, they could be imported with gxp itself. But this would bypass the wrapper. As far as I understand it they would not be accessed in the same way as with the other template systems. Piero - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [s2] Google XML Pages (GXP) to replace Freemarker in tags?
Am Samstag, 26. Juli 2008 16:01:08 schrieb Musachy Barroso: > Looks great. +1. If they are using it with Struts and/or XWork they > have a GXP result already (hint hint to googleans: can we have it?). Since there is no support for JSP tags in GXP, how could the struts2 tags be accessed in such an result? Piero - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE] Bring Convention plugin into trunk and deprecate Zero Config
Am Dienstag, 15. Juli 2008 16:43:22 schrieb Piero Sartini:
> > Then the classes that match the actionPackages
> > (named packages like "com.my.package") will be queued for processing,
> > as well as classes whose package matches one of the locators
> > ("action", "actions", etc). If you name your packages using
> > actionPackages, the plugin will find the classes in them.
>
> Thanks for the explanation:)
> It seems it could be implemented in getPackageLocatorTest() very easy. I
> just extend the if-condition (packageName.length() > 0).
I attached my small patch to WW-2576... don't know if it is of any use. Maybe
the class loading issue happens before the PackageLocatorTest.
Did not find a way to close or delete the issue.. can you do this?
Piero
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [PROPOSAL] Deprecate or remove Dojo plugin
> What does anyone think about donating the dojo plugin to codehaus? I think > it's a better idea than letting the code go stale. You could even try > donating to the dojotoolkit project. I am not sure what you mean by donating it to codehaus. If someone wants to support the plugin he may do so under the terms of the APLv2. The actual problem is that there is nobody who thinks that it is worth the work. Wether the code "stales" at codehaus or apache.. what is the difference? Piero - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [jira] Issue Comment Edited: (WW-2709) 2.0.11.2 upgrades breaks xml validators
I guess it is https://svn.opensymphony.com/svn/xwork/branches/2.0 The pom does not reflect this, but the last change was 2008-07-08. Piero Am Freitag, 18. Juli 2008 12:55:04 schrieb holod: > Where can i get XWork 2.0.6-SNAPSHOT? > I can't find it. Please, help > > JIRA [EMAIL PROTECTED] wrote: > > [ > > https://issues.apache.org/struts/browse/WW-2709?page=com.atlassian.jira.p > >lugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44336#action > >_44336 ] > > > > rgielen edited comment on WW-2709 at 7/7/08 4:24 PM: > > - > > > > The linked issues deliver a full discussion of the problem. In summary, > > this is a problem being unique to WebShere 6 / IBM JVM environments. The > > code was introduced with a fix between XWork 2.0.4 and 2.0.5, and the > > breaking part for the said environment was fixed for XW2 trunk (2.1.x), > > but not for 2.0 branch. > > > > The problem should be fixed now in XWork 2.0 branch, see > > http://jira.opensymphony.com/browse/XW-651 > > > > Using a XWork 2.0.6-SNAPSHOT build should work now. We now have to > > discuss the release plans regarding this issue. > > > > was (Author: rgielen): > > The linked issues deliver a full discussion of the problem. In > > summary, this is a problem being unique to WebShere 6.0 / IBM JVM > > environments. The code was introduced with a fix between XWork 2.0.4 and > > 2.0.5, and the breaking part for the said environment was fixed for XW2 > > trunk (2.1.x), but not for 2.0 branch. > > > > The problem should be fixed now in XWork 2.0 branch, see > > http://jira.opensymphony.com/browse/XW-651 > > > > Using a XWork 2.0.6-SNAPSHOT build should work now. We now have to > > discuss the release plans regarding this issue. > > > >> 2.0.11.2 upgrades breaks xml validators > >> --- > >> > >> Key: WW-2709 > >> URL: https://issues.apache.org/struts/browse/WW-2709 > >> Project: Struts 2 > >> Issue Type: Bug > >>Affects Versions: 2.0.11.2 > >> Environment: Websphere V6.1.0.15 > >>Reporter: S. Farshi > >>Assignee: Rene Gielen > >>Priority: Critical > >> Attachments: TicketCreation-validation.xml > >> > >> > >> I have upgraded my struts 2.0.11.1 to struts 2.0.11.2. None of my xml > >> validators run and they all break. I have downgraded to 2.0.11.1 and > >> they all work again. I think there must be a bug with xwork-2.0.5.jar. > >> [7/3/08 14:42:22:753 EDT] 003f WebAppE [Servlet > >> Error]-[Filter [struts2]: filter is unavailable.]: > >> java.lang.ExceptionInInitializerError > >>at java.lang.J9VMInternals.initialize(J9VMInternals.java:216) > >>at > >> com.opensymphony.xwork2.validator.ValidatorFileParser.addValidatorConfig > >>s(ValidatorFileParser.java:192) at > >> com.opensymphony.xwork2.validator.ValidatorFileParser.parseActionValidat > >>orConfigs(ValidatorFileParser.java:72) at > >> com.opensymphony.xwork2.validator.AnnotationActionValidatorManager.loadF > >>ile(AnnotationActionValidatorManager.java:361) at > >> com.opensymphony.xwork2.validator.AnnotationActionValidatorManager.build > >>AliasValidatorConfigs(AnnotationActionValidatorManager.java:244) at > >> com.opensymphony.xwork2.validator.AnnotationActionValidatorManager.build > >>ValidatorConfigs(AnnotationActionValidatorManager.java:343) at > >> com.opensymphony.xwork2.validator.AnnotationActionValidatorManager.getVa > >>lidators(AnnotationActionValidatorManager.java:69) at > >> com.opensymphony.xwork2.validator.AnnotationActionValidatorManager.valid > >>ate(AnnotationActionValidatorManager.java:138) at > >> com.opensymphony.xwork2.validator.AnnotationActionValidatorManager.valid > >>ate(AnnotationActionValidatorManager.java:113) at > >> com.opensymphony.xwork2.validator.AnnotationActionValidatorManager.valid > >>ate(AnnotationActionValidatorManager.java:100) at > >> com.opensymphony.xwork2.validator.ValidationInterceptor.doBeforeInvocati > >>on(ValidationInterceptor.java:142) at > >> com.opensymphony.xwork2.validator.ValidationInterceptor.doIntercept(Vali > >>dationInterceptor.java:148) at > >> org.apache.struts2.interceptor.validation.AnnotationValidationIntercepto > >>r.doIntercept(AnnotationValidationInterceptor.java:48) at > >> com.opensymphony.xwork2.interceptor.MethodFilterInterceptor.intercept(Me > >>thodFilterInterceptor.java:86) at > >> com.opensymphony.xwork2.DefaultActionInvocation$2.doProfiling(DefaultAct > >>ionInvocation.java:224) at > >> com.opensymphony.xwork2.DefaultActionInvocation$2.doProfiling(DefaultAct > >>ionInvocation.java:223) at > >> com.opensymphony.xwork2.util.profiling.UtilTimerStack.profile(UtilTimerS > >>tack.java:455) at > >> com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvo > >>cation.java:221) at > >> com.opensymphony.xwork2.interceptor.ConversionErrorInterceptor.intercept > >>(ConversionErr
Re: [VOTE] Bring Convention plugin into trunk and deprecate Zero Config
> Yes, the wiki needs to be updated, I think the most common use case > will be that people will have their actions in their classes folder, > instead of jar files, so I changed it, but we can talk about it. I don't really care because its just one line of config. Personally I am with Brian and the need for more modular applications. But you may be right that this is not the most common use case. But it should be pointed out, the plugin is used by quite a few people... I will have a look over the wiki tonight. Piero - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE] Bring Convention plugin into trunk and deprecate Zero Config
> Then the classes that match the actionPackages
> (named packages like "com.my.package") will be queued for processing,
> as well as classes whose package matches one of the locators
> ("action", "actions", etc). If you name your packages using
> actionPackages, the plugin will find the classes in them.
Thanks for the explanation:)
It seems it could be implemented in getPackageLocatorTest() very easy. I just
extend the if-condition (packageName.length() > 0).
> You said you
> had to exclude some jars, what kind of problem did you have? it could
> be a bug in the plugin.
I did use Toplink Essentials and in its jar there is a package
called "persistence.antlr.actions". So the locators matched. Don't know why
it comes to an error, but I think it is the same reason Brian excluded
hibernate and some other packages by default.
Because of that I feel way safer including rather than excluding packages to
scan. There may be other libraries like antlr that are problematic.
btw, I realized that disableJarScanning now defaults to true... this is new
behaviour and could lead to some confusion. From the wiki:
"If you compile this class and place it into your application in the
WEB-INF/classes or WEB-INF/lib (inside a JAR file), the Convention plugin
will find the class and map the URL /hello-world to it. "
Piero
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE] Bring Convention plugin into trunk and deprecate Zero Config
> yes, the locators. We could have an option like a "jar locators" which > would limit the jars scanned, it would be really easy to implement > with the URLSets. This could be a solution, but I can't imagine how to find a restriction that is useful We had to enforce a naming scheme on the modules. Wouldn't my first suggestion be easier? Or is that not possible at all? I am pretty lost with these class scanning code... The best thing for me would be if the locators are applied to a given parent package only (like com.project.**). Everything else is ignored. So instead of excluding packages I do not need, I just include what is needed. So I am able to restrict the scanning to areas of the package hierarchy where I have control. And it should give much better performance as well. If you could give me a hint in the right direction how to implement this I am happy and thankful :) Piero - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE] Bring Convention plugin into trunk and deprecate Zero Config
Am Dienstag, 15. Juli 2008 09:44:52 schrieb Piero Sartini: > The modules may be deployed in their own JAR file. If we disable global > scanning they would be ignored, right? JARScanning of course, not global scanning. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE] Bring Convention plugin into trunk and deprecate Zero Config
Am Dienstag, 15. Juli 2008 03:53:26 schrieb Musachy Barroso: > The jars excluded from the scan will never have actions, like > freemarker, velocity, jdk jars, etc. You can completely disable the > scanning of jar files, and the plugin will scan only the specified > packages, wouldn't that cover the use case that you described above? There is a package structure like this: com.myproject.webportal.module1.actions.*, com.myproject.webportal.module2.actions.*, etc The modules may be deployed in their own JAR file. If we disable global scanning they would be ignored, right? If I am understanding it the only option is to disable global scanning and configure every package of each module by hand. I want to avoid that if possible. You wrote "the plugin will scan only the specified packages". Do you mean the locators or did I miss an option? Piero - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE] Bring Convention plugin into trunk and deprecate Zero Config
Am Freitag, 23. Mai 2008 05:51:39 schrieb Musachy Barroso: > Yes I had a similar problem, and is not jdbc specific, it's just > convention scanning too much, I can't really remember what my problem > was, but convention was scanning the whole classpath. Anyway, > that's why I added "struts.convention.action.disableGlobalScanning", > so only the named packages in "struts.convention.action.packages" will > be scanned. You can replace "Action" by "Controller" overwriting > "struts.convention.action.suffix". I opened WW-2576 some time ago. After looking at the source I came to the conclusion that the convention plugin is designed to exclude a whole bunch of packages from classpath scanning. For my feeling that is not the best way to go because you can never be sure what is on your classpath. Worst case the application stops working because the admin adds some jars to the classpath of the appserver, the ear is extended with some lib or whatever. In an enterprise environment this behaviour is IMHO a no-no. Anyway, I do understand that there are usecases where this approach is needed. To solve this, I thought about an option like "scanningRoot" that defaults to "**" (or "^(.*)$") In my case, I would set it to something like "com.project.**" or "^com\.myproject\.(.*)$" What do you think? Keeping the number of configuration options as small as possible is s.th. not too bad... maybe it makes sense to consolidate some of them?! I just feel like there are too much options to do the same kind of stuff. Last but not least: I would start implementing this in PackageBasedActionConfigBuilder.buildUrlSet() - is this the right place to do so? Piero > I will document all these constants > in the plugin page one of these days :) BTW, I added the flatLayout parameter to the table on plugin page. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [s2] A thought - next generation OSGi-based?
> Since I started playing with the OSGi plugin this has been on the back > of my mind, I think it would be a good idea (support for OSGi is > showing up all over the place, There will be another player: JSR 277 is intended to be part of Java 7. Someone commented on a blog that JSR 277 will have support for other module systems like OSGi - so going with OSGi should not be a bad thing :) > I just read somewhere that glassfish > will run on an OSGi platform) AFAIK glassfish will provide the RI for JSR 277. Piero - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: 2.1 build
Am Donnerstag, 3. April 2008 17:58:41 schrieb Brian Pontarelli: > Yeah, I was hoping to have time to get the convention plugin into the > main repository, but I just haven't had anytime at all. It will have to > wait until 2.2 unless someone else wants to move it over. At this point > I can't even recall the outstanding issues and design changes that were > being discussed before. Anyone else remember those? I told you about a minor issue some time ago. Just created WW-2576 :) Piero - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: API Compatibility
Am Freitag, 22. Februar 2008 00:05:53 schrieb Don Brown: > Yes, you are missing my original point #2 - "We need to be able to do > "alpha" releases to get new, experimental features into the community > for testing." I need a way to create an alpha release for 2.1 to hand > off to our community for feedback, but if all releases require a > unique patch version, I'm forced to create 2.1.1, 2.1.2, 2.1.3, etc. > > Public API changes take a while and lots of feedback to really get > right, so going six months without a release is not acceptable, IMO. If these changes need feedback .. why not put them in alpha releases? 2.2 Alpha1, 2.2 Alpha2, etc For me, s.th. like this would be great: A.B.C.D D -> Error fixing, security patches, etc C -> new features, smaller api changes even incompatible ones B -> big changes, large refactorings, new approaches, etc. A -> Struts version Maybe you could drop the A - so we are at Struts2 1.1 instead of 2.1.1 Piero - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [s2] Let's get out Struts 2.1.1
Am Mittwoch, 20. Februar 2008 17:16:51 schrieb Brian Pontarelli: > The API has yet to be solidified and there are a few things that I'd > still like to discuss and possibly change in that regard. My main goal > is to ensure backwards compatibility in the convention plugin API. My thinking is like this: upgrading from [today's convention-plugin] to [final convention-plugin] will be much easier than upgrading from [codebehind] to the [final convention-plugin]. If convention-plugin is not bundled with the next release, people will stick to the codebehind plugin. Last time I checked there was no smarturls for 2.1.x as well - so there is really not much choice. (compiling from the sandbox is no option for most users) > Furthermore, I think we should all start thinking about when the "true" > stable release of XWork and Struts2 will be. Isn't a GA release meant to be a "true stable release"? I think to know what you want to say, but I am still somewhat confused about why releases in s2 are working the way they do. > I think it makes sense to > target the next release and jump up to 2.5 or some number to indicate > stable APIs. This would include a number of API clean-ups, OGNL > replacement and a few other things that will severely break plugins and > applications. After that release, API changes should be compatible so > that plugins and applications can be upgraded without requiring > re-compiling. I am quite sure there will rise another list with new issues that should be resolved before a "true" release in some time... In my oppinion, API stability is nothing that comes with reaching some feature set or project milestone. This would imply stopping innovation at that point. For me, API stability needs to be some kind of project goal or philosophy - which needs to be enforced by defining commonly accepted rules. But my impression is that this is no (important) goal for s2, and I can hardly imagine that it will be one day just because it gets to a point where _today's_ most wanted features are implemented. But maybe this is worth a new thread... > Back to the convention plugin... > > If folks would like to discuss the API and solidify it over the next few > days, I'd be up for that. I'll start a new thread for that and we can > hopefully get things ready for a 2.1.1 final release of the plugin > shortly after the release of core. Is it possible to release a 2.1.1 plugin after the core? In this case I do not feel like it is that important to make it part of the s2.1.1 release :) Until now I thought that the next possible release for the convention plugin would be 2.1.2 (or whatever build makes it). Piero disclaimer: I am just a happy convention-plugin user who tries to learn more about s2 development. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [s2] Let's get out Struts 2.1.1
I think you should release the convention plugin at all costs - but this is just a vote from an user. piero Am Montag, 18. Februar 2008 18:16:52 schrieb Brian Pontarelli: > Don Brown wrote: > > I've cleared all but a couple issues out of Struts 2.1.1, so I think > > we are ready for a release. The only kinda blocking issue is the > > portlet tests failing, but that seems to have something to do with the > > setup, not our portlet code, so we could even punt that one. > > > > Any objections to rolling a release(*) in the next day or so? > > Shall we queue up the convention plugin addition and deprecation of the > smarturls and code-behind plugins for next release than? > > -bp > > > - > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [S2.1] Moving testing classes from core to a new module
> during my license-problem-busting I noticed that in struts-core there > are some classes using TestNG and JUnit, therefore these dependencies > must be at compile-scope. Sorry for the (maybe) stupid question - but does this mean that there are licensing problems with TestNG and S2? It seems that TestNG is using Apache License 2.0... do I miss s.th.? Or did I misread your words and this is s.th. you recognized while checking other parts of the source, unrelated to TestNG and those license problems you mentioned? But now you made me curious about what your license-problem-busting is all about - if there is any source of information about this, could you please give me a pointer? I am under the impression that apache is very strict with licensing and that involved people do care a lot about these kind of things. Now I am curious about what problems can be faced anyway? Piero - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Convention plugin
Am Samstag, 19. Januar 2008 21:01:58 schrieb Brian Pontarelli: > It seems to be a bug. I have a large complex application up and that > uses namespaces and it appears to be working well. Therefore, I'm > assuming it must be an environment or configuration bug inside the > convention plugin that is being revealed within your application. Can > you open a bug for the plugin and attach some code. I created a > component in Jira for the plugin, so you can put the bug in that category. Sorry for the confusion, it works like expected. My fault. com.project.modulename.actions of course can't map to /WEB-INF/content/modulename/ com.project.actions.modulename works. Piero - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Convention plugin
> The results should be the same as smarturls, codebehind, etc. In your > case they should be login-success.jsp or login.jsp and > register-success.jsp or register.jsp. If you turn on some fine or finest > logging in the convention package it should print out the results it is > mapping in the configuration provider and in the unknown handler. After playing around a litte bit more, I realized that the problem is the namespace. My action is located at com.mycomp.proj.actions.auth.User My resuts are in /WEB-INF/content/ I expected they have to be in /WEB-INF/content/auth/ but they do work only if I put them in /WEB-INF/content/ Is this a bug or do I miss something? Piero - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Convention plugin
Another question :)
I really like the @Action annotation to map urls to the methods.
But its not clear to me how the results are choosen.
If there are 2 methods in the class UserAction:
@Action("login")
public String login() {
return SUCCESS;
}
and
@Action("register")
public String register() {
return SUCCESS;
}
is the result user-success.ftl or ist it user-login-success.ftl or
login-success.ftl? After trying around it seems to be neither one. But to
define alle the @Result for every method seems to be a bit noisy.
One other thing I realized is that "location=" of @Result does not use the
namespace path, you have to write the whole path (/auth/login.ftl) instead of
just "login.ftl".
I will have a closer look at the code tomorrow ;)
Ciao,
Piero
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: Convention plugin
Ok, just realized that I did overwrote the default excludes. If I do append the toplink package to your list, everything works: I played with struts.convention.action.packages, but without success. Is there a way to give a root package where the plugin should scan exclusively (IMHO that is nicer than excluding everything else...) com.mycomp.project.* for example ciao, Piero Am Samstag, 12. Januar 2008 18:31:18 schrieb Piero Sartini: > Hello Brian, > > thanks for your great work! > After playing around with the plugin I found an issue in combination with > toplink-essentials. Not sure, but it seems related to the classpath > scanning. > > Trying > struts.convention.exclude.packages=oracle.toplink.essentials.transaction > the error remains, but with different class: > org.apache.struts2.views.velocity.components.SetDirective > > So I think there is some class loading going on in toplink that conflicts > with yours? If I remove the toplink dependency (2.0-36), everything works > fine. If I remove the convention plugin, it works fine as well.. > > Piero > > > Stacktrace: > 12.01.2008 17:21:39 org.apache.catalina.core.StandardContext filterStart > SCHWERWIEGEND: Exception starting filter action2 > java.lang.IllegalArgumentException: Could not load class > [oracle.toplink.essentials.transaction.JTASynchronizationListener] > at > org.apache.struts2.convention.ClassClassLoaderResolver.prepare(ClassClassLo >aderResolver.java:198) at > org.apache.struts2.convention.ClassClassLoaderResolver.prepare(ClassClassLo >aderResolver.java:51) at > org.apache.struts2.convention.AbstractClassLoaderResolver.addIfMatching(Abs >tractClassLoaderResolver.java:447) at > org.apache.struts2.convention.AbstractClassLoaderResolver.loadResourcesInJa >r(AbstractClassLoaderResolver.java:401) at > org.apache.struts2.convention.AbstractClassLoaderResolver.findInDirectory(A >bstractClassLoaderResolver.java:276) at > org.apache.struts2.convention.AbstractClassLoaderResolver.find(AbstractClas >sLoaderResolver.java:154) at > org.apache.struts2.convention.AbstractClassLoaderResolver.findByLocators(Ab >stractClassLoaderResolver.java:243) at > org.apache.struts2.convention.PackageBasedActionConfigBuilder.findActionsUs >ingPackageLocators(PackageBasedActionConfigBuilder.java:185) at > org.apache.struts2.convention.PackageBasedActionConfigBuilder.buildActionCo >nfigs(PackageBasedActionConfigBuilder.java:165) at > org.apache.struts2.convention.ClasspathConfigurationProvider.loadPackages(C >lasspathConfigurationProvider.java:74) at > com.opensymphony.xwork2.config.impl.DefaultConfiguration.reloadContainer(De >faultConfiguration.java:190) at > com.opensymphony.xwork2.config.ConfigurationManager.getConfiguration(Config >urationManager.java:55) at > org.apache.struts2.dispatcher.Dispatcher.init_PreloadConfiguration(Dispatch >er.java:370) at > org.apache.struts2.dispatcher.Dispatcher.init(Dispatcher.java:423) at > org.apache.struts2.dispatcher.FilterDispatcher.init(FilterDispatcher.java:2 >11) at > org.apache.catalina.core.ApplicationFilterConfig.getFilter(ApplicationFilte >rConfig.java:275) at > org.apache.catalina.core.ApplicationFilterConfig.setFilterDef(ApplicationFi >lterConfig.java:397) at > org.apache.catalina.core.ApplicationFilterConfig.(ApplicationFilterCo >nfig.java:108) at > org.apache.catalina.core.StandardContext.filterStart(StandardContext.java:3 >696) at > org.apache.catalina.core.StandardContext.start(StandardContext.java:4343) > at > org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java: >791) at > org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:771) > at > org.apache.catalina.core.StandardHost.addChild(StandardHost.java:525) > at > org.apache.catalina.startup.HostConfig.deployDescriptor(HostConfig.java:626 >) at > org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:511) > at > org.apache.catalina.startup.HostConfig.check(HostConfig.java:1220) at > sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:3 >9) at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImp >l.java:25) at java.lang.reflect.Method.invoke(Method.java:597) > at > org.apache.tomcat.util.modeler.BaseModelMBean.invoke(BaseModelMBean.java:29 >7) at > com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.invoke(DefaultMBeanSe >rverInterceptor.java:836) at > com.sun.jmx.mbeanserver.JmxMBeanServer.invoke(JmxMBeanServer.java:761) > at > org.apache.catalina.manager.ManagerServlet.check(ManagerServlet.java:1458) > at > org.apache.catalina.manager.ManagerServl
Re: Convention plugin
Hello Brian, thanks for your great work! After playing around with the plugin I found an issue in combination with toplink-essentials. Not sure, but it seems related to the classpath scanning. Trying struts.convention.exclude.packages=oracle.toplink.essentials.transaction the error remains, but with different class: org.apache.struts2.views.velocity.components.SetDirective So I think there is some class loading going on in toplink that conflicts with yours? If I remove the toplink dependency (2.0-36), everything works fine. If I remove the convention plugin, it works fine as well.. Piero Stacktrace: 12.01.2008 17:21:39 org.apache.catalina.core.StandardContext filterStart SCHWERWIEGEND: Exception starting filter action2 java.lang.IllegalArgumentException: Could not load class [oracle.toplink.essentials.transaction.JTASynchronizationListener] at org.apache.struts2.convention.ClassClassLoaderResolver.prepare(ClassClassLoaderResolver.java:198) at org.apache.struts2.convention.ClassClassLoaderResolver.prepare(ClassClassLoaderResolver.java:51) at org.apache.struts2.convention.AbstractClassLoaderResolver.addIfMatching(AbstractClassLoaderResolver.java:447) at org.apache.struts2.convention.AbstractClassLoaderResolver.loadResourcesInJar(AbstractClassLoaderResolver.java:401) at org.apache.struts2.convention.AbstractClassLoaderResolver.findInDirectory(AbstractClassLoaderResolver.java:276) at org.apache.struts2.convention.AbstractClassLoaderResolver.find(AbstractClassLoaderResolver.java:154) at org.apache.struts2.convention.AbstractClassLoaderResolver.findByLocators(AbstractClassLoaderResolver.java:243) at org.apache.struts2.convention.PackageBasedActionConfigBuilder.findActionsUsingPackageLocators(PackageBasedActionConfigBuilder.java:185) at org.apache.struts2.convention.PackageBasedActionConfigBuilder.buildActionConfigs(PackageBasedActionConfigBuilder.java:165) at org.apache.struts2.convention.ClasspathConfigurationProvider.loadPackages(ClasspathConfigurationProvider.java:74) at com.opensymphony.xwork2.config.impl.DefaultConfiguration.reloadContainer(DefaultConfiguration.java:190) at com.opensymphony.xwork2.config.ConfigurationManager.getConfiguration(ConfigurationManager.java:55) at org.apache.struts2.dispatcher.Dispatcher.init_PreloadConfiguration(Dispatcher.java:370) at org.apache.struts2.dispatcher.Dispatcher.init(Dispatcher.java:423) at org.apache.struts2.dispatcher.FilterDispatcher.init(FilterDispatcher.java:211) at org.apache.catalina.core.ApplicationFilterConfig.getFilter(ApplicationFilterConfig.java:275) at org.apache.catalina.core.ApplicationFilterConfig.setFilterDef(ApplicationFilterConfig.java:397) at org.apache.catalina.core.ApplicationFilterConfig.(ApplicationFilterConfig.java:108) at org.apache.catalina.core.StandardContext.filterStart(StandardContext.java:3696) at org.apache.catalina.core.StandardContext.start(StandardContext.java:4343) at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:791) at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:771) at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:525) at org.apache.catalina.startup.HostConfig.deployDescriptor(HostConfig.java:626) at org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:511) at org.apache.catalina.startup.HostConfig.check(HostConfig.java:1220) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.tomcat.util.modeler.BaseModelMBean.invoke(BaseModelMBean.java:297) at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.invoke(DefaultMBeanServerInterceptor.java:836) at com.sun.jmx.mbeanserver.JmxMBeanServer.invoke(JmxMBeanServer.java:761) at org.apache.catalina.manager.ManagerServlet.check(ManagerServlet.java:1458) at org.apache.catalina.manager.ManagerServlet.deploy(ManagerServlet.java:820) at org.apache.catalina.manager.ManagerServlet.doGet(ManagerServlet.java:348) at javax.servlet.http.HttpServlet.service(HttpServlet.java:690) at javax.servlet.http.HttpServlet.service(HttpServlet.java:803) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at org.netbeans.modules.web.monitor.server.MonitorFilter.doFilter(MonitorFilter.java:196) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilte
Re: Struts 2 Plugin for Grails?
Am Montag, 19. November 2007 18:55:43 schrieb Brian Pontarelli: > Hopefully that helps clear things up somewhat. If not, feel free to ask > more questions. Thanks for your detailed answer, I do understand the issues with JSP much better now. > Oh, and as for your upcoming development around > "components", I'd go with FreeMarker. Let me know how it goes and if you > need any help. 1 question - but it is somewhat offtopic: I really want to use struts2.1 - but smarturls does work on 2.0 only. I know there was some discussion about merging smarturls into the codebehind plugin. But as far as I can see there was just a merge of ZeroConfig into CodeBehind. What is preferred: will smarturls be available for 2.1 or is CodeBehind the way to go? (If so, will it be possible to drop in my jars and have their actions loaded?) Thanks, Piero - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Struts 2 Plugin for Grails?
Am Freitag, 16. November 2007 23:04:37 schrieb Brian Pontarelli: > Yep. I fall into that category. How else can you build reusable > components in Struts2? Could you please explain why this does not work in s2? I need to build such an application and was under the impression that it will work with JSPs (I used smarturls before and the JSPs were under WEB-INF/content/ ... isn't it possible to load them from a jar? ) Piero - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [s2] Proposal: Rest Plugin
Am Dienstag, 23. Oktober 2007 16:02:01 schrieb Ted Husted: > Does NetBeans bundle a database now? Along with Spring 2, Hibernate 3, > and Struts 1 (not to mention Tapestry), MyEclipse 6 also includes > Tomcat and Derby, so it is, in fact, an end- to-end, full-stack > solution. If you choose to install the Web&JavaEE part there is Tomcat 6 and Glassfish V2 bundled. JavaDB (Apache Derby) is used as a database. You may add Struts1, JSF or Visual Web Toolkit to your project (There are plugins for GWT and others in the plugin manager). Together with Mobility Toolkit, UML, (J)Ruby and Rails and real good Maven2 integration I would consider it an full end-to-end solution as well :-) But I never looked at MyEclipse, so I cannot say much about the differences. For a quick overview of the features of nb6 you may look at: http://download.netbeans.org/netbeans/6.0/beta2/ Piero - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [s2] Proposal: Rest Plugin
Am Dienstag, 23. Oktober 2007 15:18:01 schrieb Ted Husted: > With Java installed, MyEclipse is now a full stack out-of-the box. You > don't actually *need* to download anything else. Period. It's also an > AppFuse-style full-stack, in that you can choose to add and subtract > features like Struts 1, Spring, JPA, Hibernate and so forth. This sounds much like NetBeans ;-) Piero - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [S2] Plugins gone wild!
> * Creating a "struts2-core-plugin" artifact that would include the > plugins that are needed to write a "typical" Struts 2 application. I like this most :-) To have a standard way of doing things makes development a lot faster and easier. > I haven't looked into yet, but we might also consider a "persistence" > plugin with JPA support, if that makes any sense. Using JPA in s2 is really easy. The only functionality I can think of at the moment is a factory for the EntityManager and a PersistenceUnit that is defined in struts.xml. If it helps I will try to build such a plugin. Btw - a JavaEE plugin would be _really_ nice. Is there a way of having some kind of "Servlet-Actions"? This would give us free @EJB and @Persistence functionality in JavaEE 5 environments. Piero - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [PROPOSAL] Merge Able/Code Behind/Zero-Config/SmartURLs into view-behind specification
Am Mittwoch, 17. Oktober 2007 23:49:33 schrieb Jim Cushing: > For different renderings/mimetypes, I think it'd make sense, if > possible, to use a dot-extension (e.g., "foo.pdf" instead of "foo/ > pdf"), since this is a common and well understood convention. Is there a problem with search engines if we have dots in a "directory" name? -> /foo.pdf/id/4 The other way is to append the .pdf to the parameter 4 - but that's not that nice IMHO: /foo/id/4.pdf Piero - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn.apache.org problems?
I am trying to checkout http://svn.apache.org/repos/asf/struts/struts2/tags/STRUTS_2_0_11/ but it is _very_ slow and it cancels from time to time. Are there any known problems? Piero - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [s2] Goal - no experimental code in core for 2.1
Am Montag, 8. Oktober 2007 21:06:10 schrieb Brian Pontarelli: > Oh, forgot one thing. I like the idea of a single codebehind/zero-conf > plugin that is beta. So, I'm voting that we collapse SU and the code > from struts2 core and the current codebehind plugin into a single > location. This would move all the experimental stuff out of core and > still allow users to start using all the current features as we work on > the others that Ted and others have mentioned (including myself). +1 for something that can be used by the users (me) easily. I already used SU for a small project and it is just great. But I do not like the situation with struts 2.1 (mainly because SU doesn't work with xwork 2.1). I would try to fix it, but if you merge everything maybe this is useless work. Everything is confusing - codebehind/zero-conf is the "old" plugin, isn't it? Is it better to use SU or codebehind/zero-conf? Choice is good, plugin-hell is not. If you ask me, I would answer that it is best to let SU replace the codebehind/zero-conf thing in s2 (as an official plugin, maybe tagged beta). Piero - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [s2] Should tags be their own plugin?
S2 without freemarker would be great: +1 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE] Struts 2.0.11 Quality
+1 GA - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Fixing XW-559: No warnings when property or method doesn't exist in Action
> Should I be using the latest version of Struts with the latest version > of XWork to attempt to fix this issue? As far as I know, xwork 2.1 does work with struts 2.1 only. But - and that is the bad news: I was not able to get 2.1 running (maybe trunk is broken?) See the thread "NPE on struts2-showcase" from Wes as well. Piero - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: NPE on struts2-showcase startup
I got the same error some days ago when trying to build a new skeleton for my
projects.
(the m2 starter archetype did not work with 2.1 trunk)
I did not know if trunk is broken because of bigger changes going on and
decided to try it again this week ...
Piero
Am Montag 24 September 2007 20:07:26 schrieb Wes Wannemacher:
> Hello,
>
> I am building xwork2 and struts2 from SVN and I was going to deploy
> struts2-showcase to start poking around. Unfortunately, on context
> startup, an NPE is thrown. The stack trace in the tomcat console is as
> follows -
>
> 2007-09-24 13:13:15,750 ERROR
> (org.apache.catalina.core.ContainerBase.[Catalina].[localhost].[/struts2-sh
>owcase]:3639) - Exception starting filter struts
> java.lang.NullPointerException
> at
> org.apache.struts2.config.StrutsXmlConfigurationProvider.needsReload(Struts
>XmlConfigurationProvider.java:165) at
> com.opensymphony.xwork2.config.ConfigurationManager.conditionalReload(Confi
>gurationManager.java:165) at
> com.opensymphony.xwork2.config.ConfigurationManager.getConfiguration(Config
>urationManager.java:59) at
> org.apache.struts2.dispatcher.Dispatcher.getContainer(Dispatcher.java:827)
> at
> org.apache.struts2.dispatcher.FilterDispatcher.init(FilterDispatcher.java:2
>02) at
> org.apache.catalina.core.ApplicationFilterConfig.getFilter(ApplicationFilte
>rConfig.java:221) at
> org.apache.catalina.core.ApplicationFilterConfig.setFilterDef(ApplicationFi
>lterConfig.java:302) at
> org.apache.catalina.core.ApplicationFilterConfig.(ApplicationFilterCo
>nfig.java:78) at
> org.apache.catalina.core.StandardContext.filterStart(StandardContext.java:3
>635) at
> org.apache.catalina.core.StandardContext.start(StandardContext.java:4222)
> at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1014) at
> org.apache.catalina.core.StandardHost.start(StandardHost.java:736) at
> org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1014) at
> org.apache.catalina.core.StandardEngine.start(StandardEngine.java:443) at
> org.apache.catalina.core.StandardService.start(StandardService.java:448) at
> org.apache.catalina.core.StandardServer.start(StandardServer.java:700) at
> org.apache.catalina.startup.Catalina.start(Catalina.java:552)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:3
>9) at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImp
>l.java:25) at java.lang.reflect.Method.invoke(Method.java:597)
> at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:295)
> at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:433)
>
> It seems this is reproducible. The offending method is fairly simple,
> but the problem appears to be in xwork's
> com.opensymphony.xwork2.ActionContext here -
>
> public static ActionContext getContext() {
> ActionContext context = (ActionContext) actionContext.get();
>
> // Don't do lazy context creation, as it requires container; the
> creation of which may
> // precede the context creation
> //if (context == null) {
> //ValueStack vs =
> ValueStackFactory.getFactory().createValueStack(); //context = new
> ActionContext(vs.getContext());
> //setContext(context);
> //}
>
> return context;
> }
>
> The NPE is thrown by a class that is looking for an ActionContext but
> doesn't get one.
>
> --
> Wesley Wannemacher
> President, Head Engineer/Consultant
> WanTii, Inc.
> http://www.wantii.com
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: Struts 2.0.11 Release Notes created
I think just linking to both TODO and DONE pages does help. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Struts 2.0.11 Release Notes created
Am Donnerstag, 20. September 2007 09:01:06 schrieb Antonio Petrelli: > AFAIK you simply do not need to do anything, except referring to the > release notes of the "real" preceding release (in this case 2.0.9). > 2.0.10 remains a simple test build. This happens frequently at Tomcat: did > not you ever ask why their version numbers has so many holes? :-) Since there is no official 2.0.10 release, how is this handled within JIRA? S2 release notes just link to JIRA for changelog. If they link to 2.0.10, this is confusing - if they link to 2.0.11 its wrong as well. Tomcat changelogs include the testbuilds, but they have only one big changelog page. Piero - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE] Struts 2.0.10 Quality
> Piero: it seems that we agreed on the fact that the change should add > a deprecation: can you open a JIRA issue for this? > Eventually you can provide the patch, so your name will appear in the > SVN log :-) I created a JIRA entry with attached patch: https://issues.apache.org/struts/browse/WW-2188 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE] Struts 2.0.10 Quality
Am Montag 17 September 2007 09:28:15 schrieb Antonio Petrelli: > > Anyway, since 2.0.10 fixes a security issue: Would it be good to have a > > method in Component.java that is compatible with 2.0.9? Maybe tagged > > as @Deprecated? > > Good question: it depends on how the method is used: in the core I see it > used only in URL component. Thanks for changing the release note. In my oppinion an incompatible API change like this should not happen between 2.0.x releases. From the javadoc: "This class is a good extension point when building reuseable UI components." Plugin developers would be forced to come up with 2 versions of their plugins: pre-2.0.10 and post-2.0.10 But I am not a struts developer, so this is just my feeling ;-) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE] Struts 2.0.10 Quality
After looking at the code the problem is within Component.java. The determineActionURL method has 2 new parameters which were not present in 2.0.9 and are passed to UrlHelper.java: boolean forceAddSchemeHostAndPort, boolean escapeAmp It should be safe to call with forceAddSchemeHostAndPort=false, escapeAmp=true (That is what UrlHelper.java does when these params are missing ..) This can be fixed in tabletags quite easy. Anyway, since 2.0.10 fixes a security issue: Would it be good to have a method in Component.java that is compatible with 2.0.9? Maybe tagged as @Deprecated? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE] Struts 2.0.10 Quality
tabletags are broken with 2.0.10. org.apache.struts2.components.UIBean seems to be missing the UIBean.determineActionURL() method. Don't know if this is an issue. Are these components supposed to be stable in 2.0.x? Stacktrace: java.lang.NoSuchMethodError: com.googlecode.tabletags.components.AbstractURLComponent.determineActionURL(Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljavax/servlet/http/HttpServletRequest;Ljavax/servlet/http/HttpServletResponse;Ljava/util/Map;Ljava/lang/String;ZZ)Ljava/lang/String; at com.googlecode.tabletags.components.AbstractURLComponent.evaluateExtraParams(AbstractURLComponent.java:48) at com.googlecode.tabletags.components.Table.evaluateExtraParams(Table.java:60) at org.apache.struts2.components.UIBean.evaluateParams(UIBean.java:780) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: XWork build failing
Am Freitag, 23. März 2007 schrieb Ted Husted: > On 3/23/07, Piero Sartini <[EMAIL PROTECTED]> wrote: > > Am Donnerstag, 22. März 2007 schrieb Claus Ibsen: > > > Isn't it a unit test executed by surefire? that tests what happens if > > > you do a XSLTransformation with an invalid filename, and thus it log it > > > at ERROR level but the test is fine. > > > > But the test fails, and this should not happen I assume? > > It seems to be happening to some of us, but not to others. > > Claus and Ted are on XP. What are Piero and James using? I am sorry - but I captured James' thread. He talked about xwork, my problem is with s2. I misinterpreted the surefire output as well - please see my answer to Claus what tests fail exactly. Tried to build with Linux 2.6.20 and with Solaris (OpenSolaris b55) However, on Solaris there are even more tests that fail. Piero - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: XWork build failing
Ok, I checked it again and you are right. I assumed it is the XSLTResult because it is the last error I see when the tests are finnished. Actually, the errors are: [surefire] Running org.apache.struts2.views.jsp.PortletUrlTagTest [surefire] Tests run: 8, Failures: 1, Errors: 0, Time elapsed: 1,317 sec FAILURE !! and [surefire] Running org.apache.struts2.views.jsp.URLTagTest 2007-03-23 18:01:22,906 WARN [URL.java:190] : Unknown value for includeParams parameter to URL tag: unknown [surefire] Tests run: 21, Failures: 7, Errors: 0, Time elapsed: 1,092 sec FAILURE !! Am Freitag, 23. März 2007 schrieb Claus Ibsen: > Piero > > Are you sure surefire tests really fails. It reports something like <<< > FAILURE in the output if it fails. > > The test can output logging at ERROR level and still not fail the test. > Could you double check it and report back. > - > Posted via Jive Forums > http://forums.opensymphony.com/thread.jspa?threadID=72225&messageID=135233# >135233 > > > - > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Write access to confluence
I often come accross information in the wiki I would like to enhance. In the "how-to-help" pages is described the possibility of posting comments - but could not find this functionality. I did sign a CLA few days ago anyway, is it possible to upgrade my account (psartini) ? Piero - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [S2] [VOTE] Struts 2.0.7 Quality
Am Freitag, 23. März 2007 schrieb Ted Husted: > Actually, that's perfect :) +1 (GA) then :) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: XWork build failing
Am Donnerstag, 22. März 2007 schrieb Claus Ibsen: > Isn't it a unit test executed by surefire? that tests what happens if you > do a XSLTransformation with an invalid filename, and thus it log it at > ERROR level but the test is fine. But the test fails, and this should not happen I assume? [INFO] [ERROR] BUILD ERROR [INFO] [INFO] There are test failures. > Try compiling without executing the tests with -Dskip.test=true or whatever > the syntax is. It works when bypassing -Dmaven.test.skip=true But the issue remains: why does the test fail? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [S2] [VOTE] Struts 2.0.7 Quality
I am using 2.0.7 since it became available to develop my application. Everything works fine and there are no problems. But I am not sure if this is enough to make a vote or if more extensive testing is expected. Piero - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: XWork build failing
Dont know if this is related. But I am unable to build s2 trunk (as well as 2_0_7) because of the following error: 2007-03-22 12:57:16,391 ERROR [XSLTResult.java:365] : Unable to render XSLT Template, 'nofile.xsl' javax.xml.transform.TransformerException: Stylesheet nofile.xsl not found in resources. Maybe I am doing something wrong - first time I tried to build s2 myself. Am Donnerstag, 22. März 2007 schrieb James Mitchell: > Does XW trunk build for anyone else? When I try to build with Maven, > it fails on a few tests, but if I run those same tests within > Eclipse, they pass fine. > > > -- > James Mitchell > The Ruby Roundup > http://www.rubyroundup.com/ > > > > - > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
