[GitHub] thrift pull request #1496: THRIFT-4476: Typecasting problem on list items (+...

[ozymaxx]

Github user ozymaxx closed the pull request at:

https://github.com/apache/thrift/pull/1496


---

[GitHub] thrift pull request #1496: THRIFT-4476: Typecasting problem on list items (+...

[ozymaxx]

Github user ozymaxx commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1496#discussion_r175284941
  
--- Diff: build/appveyor/MSVC-appveyor-build.bat ---
@@ -39,7 +39,7 @@ CD "%BUILDDIR%" || EXIT /B
 -DWITH_PYTHON=%WITH_PYTHON% ^
 -DWITH_%THREADMODEL%THREADS=ON ^
 -DWITH_SHARED_LIB=OFF ^
--DWITH_STATIC_LIB=ON|| EXIT /B
+-DWITH_STATIC_LIB=ON ^|| EXIT /B
--- End diff --

Yes, you're right. I've removed it now. 


---

[GitHub] thrift pull request #1496: THRIFT-4476: Typecasting problem on list items (+...

[ozymaxx]

Github user ozymaxx commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1496#discussion_r175284886
  
--- Diff: compiler/cpp/src/thrift/generate/t_generator.h ---
@@ -268,6 +271,30 @@ class t_generator {
 return out.str();
   }
 
+  const std::string emit_double_as_string(const double value) {
+  std::stringstream double_output_stream;
+  // sets the maximum precision: 
http://en.cppreference.com/w/cpp/io/manip/setprecision
+  // sets the output format to fixed: 
http://en.cppreference.com/w/cpp/io/manip/fixed (not in scientific notation)
+  double_output_stream << 
std::setprecision(std::numeric_limits::digits10 + 1);
+
+  #ifdef _MSC_VER
+  // strtod is broken in MSVC compilers older than 2015, so 
std::fixed fails to format a double literal.
+  // more details: 
https://blogs.msdn.microsoft.com/vcblog/2014/06/18/
+  //   
c-runtime-crt-features-fixes-and-breaking-changes-in-visual-studio-14-ctp1/
+  //   and
+  //   
http://www.exploringbinary.com/visual-c-plus-plus-strtod-still-broken/
+  #if _MSC_VER >= MSC_2015_VER
+  double_output_stream << std::fixed;
+  #endif
+  #else
+  double_output_stream << std::fixed;
--- End diff --

No, in both cases it should use `std::fixed`, that outputs the fixed 
floating point representation of the number. But if the MSVC compiler is older 
than 2015, that function is broken, and should not be called. In short, we want 
the compiler to generate the doubles in the fixed floating point representation 
if possible. On the Erlang side, if the compiler is older than 2015, we want 
the compiler to use `std::scientific` since there can be cases where the 
mantissa is being output as integer, which is illegal. `std::scientific` always 
outputs the floating points numbers with a floating point mantissa. But if it 
is 2015 or later, `std::fixed` works correctly and can be used to get rid of 
the exponent representation. 


---

[GitHub] thrift pull request #1496: THRIFT-4476: Typecasting problem on list items (+...

[jeking3]

Github user jeking3 commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1496#discussion_r175276394
  
--- Diff: build/appveyor/MSVC-appveyor-build.bat ---
@@ -39,7 +39,7 @@ CD "%BUILDDIR%" || EXIT /B
 -DWITH_PYTHON=%WITH_PYTHON% ^
 -DWITH_%THREADMODEL%THREADS=ON ^
 -DWITH_SHARED_LIB=OFF ^
--DWITH_STATIC_LIB=ON|| EXIT /B
+-DWITH_STATIC_LIB=ON ^|| EXIT /B
--- End diff --

The carat addition looks wrong to me; it belongs on the end of a string, so 
in this case I think it does nothing at all?


---

[GitHub] thrift pull request #1496: THRIFT-4476: Typecasting problem on list items (+...

[jeking3]

Github user jeking3 commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1496#discussion_r175276410
  
--- Diff: compiler/cpp/src/thrift/generate/t_generator.h ---
@@ -268,6 +271,30 @@ class t_generator {
 return out.str();
   }
 
+  const std::string emit_double_as_string(const double value) {
+  std::stringstream double_output_stream;
+  // sets the maximum precision: 
http://en.cppreference.com/w/cpp/io/manip/setprecision
+  // sets the output format to fixed: 
http://en.cppreference.com/w/cpp/io/manip/fixed (not in scientific notation)
+  double_output_stream << 
std::setprecision(std::numeric_limits::digits10 + 1);
+
+  #ifdef _MSC_VER
+  // strtod is broken in MSVC compilers older than 2015, so 
std::fixed fails to format a double literal.
+  // more details: 
https://blogs.msdn.microsoft.com/vcblog/2014/06/18/
+  //   
c-runtime-crt-features-fixes-and-breaking-changes-in-visual-studio-14-ctp1/
+  //   and
+  //   
http://www.exploringbinary.com/visual-c-plus-plus-strtod-still-broken/
+  #if _MSC_VER >= MSC_2015_VER
+  double_output_stream << std::fixed;
+  #endif
+  #else
+  double_output_stream << std::fixed;
--- End diff --

Did you mean both cases to be the same?  Both use std::fixed; should one be 
using std::scientific?


---

[GitHub] thrift pull request #1496: THRIFT-4476: Typecasting problem on list items (+...

[ozymaxx]

GitHub user ozymaxx reopened a pull request:

https://github.com/apache/thrift/pull/1496

THRIFT-4476: Typecasting problem on list items (+ low precision double 
rendering, + mis-rendering non-fractional double literals in Python)

- high precision double rendering in JS, Java, Python and C++
- testing double rendering in JS, Java, Python and C++

see the related issue: https://issues.apache.org/jira/browse/THRIFT-4476

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ozymaxx/thrift THRIFT-4476

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1496.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1496


commit f5a6337d4448a30c284a3033307865dfc992ac7d
Author: Ozan Can Altiok 
Date:   2018-02-19T13:55:09Z

- high precision double rendering in JS, Java, Python and C++
- testing double rendering in JS, Java, Python and C++

commit 6dbc35f74fe53a9bacf06867036c21f2761c823e
Author: Ozan Can Altiok 
Date:   2018-02-22T09:47:27Z

- a comment added (about setprecision)
- BOOST_TEST -> BOOST_CHECK

commit 55e3371ed9ea7eadc5826a7f17d3e432e9b99858
Author: Ozan Can Altiok 
Date:   2018-02-23T14:10:15Z

double rendering in erlang, fixed (some additional tests added)

commit 36cc6f9dfe5b508a531ad70958ca3209c3b65e84
Author: Ozan Can Altiok 
Date:   2018-02-23T14:44:31Z

less than operator - correction in erlang test

commit a22d72f024bbf463895022792a31d04054a79445
Author: Ozan Can Altiok 
Date:   2018-02-26T06:17:16Z

style changes, some fixes in erlang test

commit a615812729096a7fa106f8259eb2f41d61ac99ce
Author: Ozan Can Altiok 
Date:   2018-02-26T06:51:24Z

some fixes in erlang test

commit 50b9a3fc69b82a9af2e78602a2e60b9a649874ee
Author: Ozan Can Altiok 
Date:   2018-02-26T07:22:41Z

some fixes in erlang test - no need for including lists library

commit b4e9ce56aecf75beffbf77864f02891808072204
Author: Ozan Can Altiok 
Date:   2018-02-26T09:31:46Z

more style changes - something overlooked

commit 39bb546d0ccbec7177866a1a78d9b5f4de0d9ec1
Author: Ozan Can Altiok 
Date:   2018-02-26T10:24:45Z

expected 2 lines before main - fixed (not seen locally)

commit 98db81883af06d10e9277fb32988edfd3f044d1d
Author: Ozan Can Altiok 
Date:   2018-02-26T11:24:05Z

noticed that test cases should be added manually in Python

commit 64aae330efac4ee23ed01694bc7dceb5a7a9164b
Author: Ozan Can Altiok 
Date:   2018-02-27T06:48:48Z

DoubleConstantTest thrift compilation directive is now given in 
generate.cmake

commit decb436f40990e0a04be9730accd3becab951c39
Author: Ozan Can Altiok 
Date:   2018-02-28T06:13:34Z

render_double_to_string -> emit_double_as_string

commit e9b2e389b1184efa4d8ad1d6424ec52a108b80c9
Author: Ozan Can Altiok 
Date:   2018-03-02T12:45:54Z

added assertion error messages to see the problems inside Java tests in 
more detail

commit 248e8a4c208e518da30f761a2d836ff790cd9b0d
Author: Ozan Can Altiok 
Date:   2018-03-05T06:59:59Z

RDP access to AppVeyor build workers

commit dd9b65113f143f13e6524917add6c216b16f86e5
Author: Ozan Can Altiok 
Date:   2018-03-05T07:01:07Z

Merge branch 'master' of https://github.com/apache/thrift into THRIFT-4476

commit 65a6588d049dcbbef7d3df5d7c3ba9a7b141917a
Author: Ozan Can Altiok 
Date:   2018-03-05T07:03:20Z

duplicate key problem in appveyor settings

commit 6305384d9203bd532983d18a992515db802b29a5
Author: Ozan Can Altiok 
Date:   2018-03-05T09:31:22Z

ignore the test cases with (-+)1.7e+308 in Java tests

commit 74667acf55c435c661c5fc19de729eb5f82758dc
Author: Ozan Can Altiok 
Date:   2018-03-05T10:00:31Z

ignore the test cases with (-+)1.7e+308 in Java tests - 2

commit 85b872bac39078446aa27336ca57001022524fc0
Author: Ozan Can Altiok 
Date:   2018-03-05T12:18:14Z

pyflakes8 style changes

commit af11ef8c7475c5f57f2d6619bedea23856a0fd17
Author: Ozan Can Altiok 
Date:   2018-03-06T08:21:51Z

disabling the test named 'TestRenderedDoubleConstants' on machines with the 
MSVC2010 configuration

commit 8ed1997141dce6c4b4505b09d2d6843344dfa04b
Author: Ozan Can Altiok 
Date:   2018-03-06T08:58:25Z

msvc.profile parameter existence check

commit beb12744f990ed0890648b07d81f19c121303c59
Author: Ozan Can Altiok 
Date:   2018-03-06T12:05:04Z

passing "msvc profile" on build stage

commit 1a0756aa8d48b693ae39dd860bdbeb7de5252cae
Author: Ozan Can Altiok 
Date:   2018-03-06T12:50:10Z

"MSVC_PROFILE" as a cache variable

commit b40fc4e06083f2787db3f805756abe7e6c2c704d
Author: Ozan Can Altiok 
Date:   2018-03-06T13:01:48Z

[GitHub] thrift pull request #1496: THRIFT-4476: Typecasting problem on list items (+...

[ozymaxx]

Github user ozymaxx closed the pull request at:

https://github.com/apache/thrift/pull/1496


---

[GitHub] thrift pull request #1496: THRIFT-4476: Typecasting problem on list items (+...

[jeking3]

Github user jeking3 commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1496#discussion_r174771623
  
--- Diff: test/DoubleConstantsTest.thrift ---
@@ -0,0 +1,17 @@
+namespace java thrift.test
+namespace cpp thrift.test
+
+// more tests on double constants (precision and type checks)
--- End diff --

There's probably another way to resolve this, such as fixing a compiler 
flag being passed to older MSVC2013 compilers.  I'll swing back around to this 
one when I can.  I don't like the notion that we say, "because the compiler was 
built with MSVC2013, let's disable a test".  Shouldn't any thrift compiler, 
regardless of the C++ compiler used to create it, produce working thrift 
generated code that has the same values as any other thrift compiler?


---

[GitHub] thrift pull request #1496: THRIFT-4476: Typecasting problem on list items (+...

[ozymaxx]

Github user ozymaxx commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1496#discussion_r174687128
  
--- Diff: test/py/RunClientServer.py ---
@@ -298,7 +300,11 @@ def main():
 print('')
 for genpydir in generated_dirs:
 for script in SCRIPTS:
-runScriptTest(options.libdir, options.gen_base, genpydir, 
script)
+# The MSVC 2013 C++ compiler stores the double literals 
differently from
+# the MSVC 2015 and G++ compilers, so the 
TestRenderedDoubleConstants test
+# fails on the VMs with the MSVC2013 configuration
+if not (script == 'TestRenderedDoubleConstants.py' and 
options.msvc_profile == 'MSVC2013'):
+runScriptTest(options.libdir, options.gen_base, genpydir, 
script)
--- End diff --

and here @jeking3 


---

[GitHub] thrift pull request #1496: THRIFT-4476: Typecasting problem on list items (+...

[ozymaxx]

Github user ozymaxx commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1496#discussion_r174687088
  
--- Diff: test/py/CMakeLists.txt ---
@@ -27,7 +27,7 @@ add_test(NAME python_test_generate
 )
 
 add_test(NAME python_test
-COMMAND ${PYTHON_EXECUTABLE} 
${CMAKE_CURRENT_SOURCE_DIR}/RunClientServer.py 
--gen-base=${CMAKE_CURRENT_BINARY_DIR}
+COMMAND ${PYTHON_EXECUTABLE} 
${CMAKE_CURRENT_SOURCE_DIR}/RunClientServer.py 
--gen-base=${CMAKE_CURRENT_BINARY_DIR} --msvc-profile=${MSVC_PROFILE}
--- End diff --

@jeking3 By the way, I also disabled my Python tests. Here are the places I 
modified to disable a test suite in Python.


---

[GitHub] thrift pull request #1496: THRIFT-4476: Typecasting problem on list items (+...

[ozymaxx]

Github user ozymaxx commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1496#discussion_r174686538
  
--- Diff: lib/java/gradle/unitTests.gradle ---
@@ -68,6 +68,20 @@ test {
 include '**/Test*.class'
 exclude '**/Test*\$*.class'
 
+println 'Check if msvc.profile exists'
--- End diff --

I did not want to disable the entire `JavaTest` just for a single test 
suite.


---

[GitHub] thrift pull request #1496: THRIFT-4476: Typecasting problem on list items (+...

[ozymaxx]

Github user ozymaxx commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1496#discussion_r174686397
  
--- Diff: test/DoubleConstantsTest.thrift ---
@@ -0,0 +1,17 @@
+namespace java thrift.test
+namespace cpp thrift.test
+
+// more tests on double constants (precision and type checks)
--- End diff --

If I'm not mistaken, only Java and Python tests are running on Windows 
builders. One of the C++ compilers on these builders compiles the Thrift 
compiler source code such that the produced relatively large double constants 
does not match the ones given in the test. That's why I have disabled 
`TestRenderedDoubleConstants` only for Java and Python.


---

[GitHub] thrift pull request #1496: THRIFT-4476: Typecasting problem on list items (+...

[jeking3]

Github user jeking3 commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1496#discussion_r174495089
  
--- Diff: test/DoubleConstantsTest.thrift ---
@@ -0,0 +1,17 @@
+namespace java thrift.test
+namespace cpp thrift.test
+
+// more tests on double constants (precision and type checks)
--- End diff --

Further evidence that disabling the test in Java is a bad idea: why don't 
you need to disable Javascript if the compiler is the cause?


---

[GitHub] thrift pull request #1496: THRIFT-4476: Typecasting problem on list items (+...

[jeking3]

Github user jeking3 commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1496#discussion_r174494320
  
--- Diff: lib/java/gradle/unitTests.gradle ---
@@ -68,6 +68,20 @@ test {
 include '**/Test*.class'
 exclude '**/Test*\$*.class'
 
+println 'Check if msvc.profile exists'
--- End diff --

It seems to me this fix is in the wrong place.  I don't like having the C++ 
compiler type passed down into the java build so it can disable a test.  The 
compiler code be modified somehow.



---

[GitHub] thrift pull request #1496: THRIFT-4476: Typecasting problem on list items (+...

[ozymaxx]

GitHub user ozymaxx reopened a pull request:

https://github.com/apache/thrift/pull/1496

THRIFT-4476: Typecasting problem on list items (+ low precision double 
rendering, + mis-rendering non-fractional double literals in Python)

- high precision double rendering in JS, Java, Python and C++
- testing double rendering in JS, Java, Python and C++

see the related issue: https://issues.apache.org/jira/browse/THRIFT-4476

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ozymaxx/thrift THRIFT-4476

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1496.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1496


commit f5a6337d4448a30c284a3033307865dfc992ac7d
Author: Ozan Can Altiok 
Date:   2018-02-19T13:55:09Z

- high precision double rendering in JS, Java, Python and C++
- testing double rendering in JS, Java, Python and C++

commit 6dbc35f74fe53a9bacf06867036c21f2761c823e
Author: Ozan Can Altiok 
Date:   2018-02-22T09:47:27Z

- a comment added (about setprecision)
- BOOST_TEST -> BOOST_CHECK

commit 55e3371ed9ea7eadc5826a7f17d3e432e9b99858
Author: Ozan Can Altiok 
Date:   2018-02-23T14:10:15Z

double rendering in erlang, fixed (some additional tests added)

commit 36cc6f9dfe5b508a531ad70958ca3209c3b65e84
Author: Ozan Can Altiok 
Date:   2018-02-23T14:44:31Z

less than operator - correction in erlang test

commit a22d72f024bbf463895022792a31d04054a79445
Author: Ozan Can Altiok 
Date:   2018-02-26T06:17:16Z

style changes, some fixes in erlang test

commit a615812729096a7fa106f8259eb2f41d61ac99ce
Author: Ozan Can Altiok 
Date:   2018-02-26T06:51:24Z

some fixes in erlang test

commit 50b9a3fc69b82a9af2e78602a2e60b9a649874ee
Author: Ozan Can Altiok 
Date:   2018-02-26T07:22:41Z

some fixes in erlang test - no need for including lists library

commit b4e9ce56aecf75beffbf77864f02891808072204
Author: Ozan Can Altiok 
Date:   2018-02-26T09:31:46Z

more style changes - something overlooked

commit 39bb546d0ccbec7177866a1a78d9b5f4de0d9ec1
Author: Ozan Can Altiok 
Date:   2018-02-26T10:24:45Z

expected 2 lines before main - fixed (not seen locally)

commit 98db81883af06d10e9277fb32988edfd3f044d1d
Author: Ozan Can Altiok 
Date:   2018-02-26T11:24:05Z

noticed that test cases should be added manually in Python

commit 64aae330efac4ee23ed01694bc7dceb5a7a9164b
Author: Ozan Can Altiok 
Date:   2018-02-27T06:48:48Z

DoubleConstantTest thrift compilation directive is now given in 
generate.cmake

commit decb436f40990e0a04be9730accd3becab951c39
Author: Ozan Can Altiok 
Date:   2018-02-28T06:13:34Z

render_double_to_string -> emit_double_as_string

commit e9b2e389b1184efa4d8ad1d6424ec52a108b80c9
Author: Ozan Can Altiok 
Date:   2018-03-02T12:45:54Z

added assertion error messages to see the problems inside Java tests in 
more detail

commit 248e8a4c208e518da30f761a2d836ff790cd9b0d
Author: Ozan Can Altiok 
Date:   2018-03-05T06:59:59Z

RDP access to AppVeyor build workers

commit dd9b65113f143f13e6524917add6c216b16f86e5
Author: Ozan Can Altiok 
Date:   2018-03-05T07:01:07Z

Merge branch 'master' of https://github.com/apache/thrift into THRIFT-4476

commit 65a6588d049dcbbef7d3df5d7c3ba9a7b141917a
Author: Ozan Can Altiok 
Date:   2018-03-05T07:03:20Z

duplicate key problem in appveyor settings

commit 6305384d9203bd532983d18a992515db802b29a5
Author: Ozan Can Altiok 
Date:   2018-03-05T09:31:22Z

ignore the test cases with (-+)1.7e+308 in Java tests

commit 74667acf55c435c661c5fc19de729eb5f82758dc
Author: Ozan Can Altiok 
Date:   2018-03-05T10:00:31Z

ignore the test cases with (-+)1.7e+308 in Java tests - 2

commit 85b872bac39078446aa27336ca57001022524fc0
Author: Ozan Can Altiok 
Date:   2018-03-05T12:18:14Z

pyflakes8 style changes

commit af11ef8c7475c5f57f2d6619bedea23856a0fd17
Author: Ozan Can Altiok 
Date:   2018-03-06T08:21:51Z

disabling the test named 'TestRenderedDoubleConstants' on machines with the 
MSVC2010 configuration

commit 8ed1997141dce6c4b4505b09d2d6843344dfa04b
Author: Ozan Can Altiok 
Date:   2018-03-06T08:58:25Z

msvc.profile parameter existence check

commit beb12744f990ed0890648b07d81f19c121303c59
Author: Ozan Can Altiok 
Date:   2018-03-06T12:05:04Z

passing "msvc profile" on build stage

commit 1a0756aa8d48b693ae39dd860bdbeb7de5252cae
Author: Ozan Can Altiok 
Date:   2018-03-06T12:50:10Z

"MSVC_PROFILE" as a cache variable

commit b40fc4e06083f2787db3f805756abe7e6c2c704d
Author: Ozan Can Altiok 
Date:   2018-03-06T13:01:48Z

[GitHub] thrift pull request #1496: THRIFT-4476: Typecasting problem on list items (+...

[ozymaxx]

Github user ozymaxx closed the pull request at:

https://github.com/apache/thrift/pull/1496


---

[GitHub] thrift pull request #1496: THRIFT-4476: Typecasting problem on list items (+...

[ozymaxx]

GitHub user ozymaxx reopened a pull request:

https://github.com/apache/thrift/pull/1496

THRIFT-4476: Typecasting problem on list items (+ low precision double 
rendering, + mis-rendering non-fractional double literals in Python)

- high precision double rendering in JS, Java, Python and C++
- testing double rendering in JS, Java, Python and C++

see the related issue: https://issues.apache.org/jira/browse/THRIFT-4476

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ozymaxx/thrift THRIFT-4476

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1496.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1496


commit f5a6337d4448a30c284a3033307865dfc992ac7d
Author: Ozan Can Altiok 
Date:   2018-02-19T13:55:09Z

- high precision double rendering in JS, Java, Python and C++
- testing double rendering in JS, Java, Python and C++

commit 6dbc35f74fe53a9bacf06867036c21f2761c823e
Author: Ozan Can Altiok 
Date:   2018-02-22T09:47:27Z

- a comment added (about setprecision)
- BOOST_TEST -> BOOST_CHECK

commit 55e3371ed9ea7eadc5826a7f17d3e432e9b99858
Author: Ozan Can Altiok 
Date:   2018-02-23T14:10:15Z

double rendering in erlang, fixed (some additional tests added)

commit 36cc6f9dfe5b508a531ad70958ca3209c3b65e84
Author: Ozan Can Altiok 
Date:   2018-02-23T14:44:31Z

less than operator - correction in erlang test

commit a22d72f024bbf463895022792a31d04054a79445
Author: Ozan Can Altiok 
Date:   2018-02-26T06:17:16Z

style changes, some fixes in erlang test

commit a615812729096a7fa106f8259eb2f41d61ac99ce
Author: Ozan Can Altiok 
Date:   2018-02-26T06:51:24Z

some fixes in erlang test

commit 50b9a3fc69b82a9af2e78602a2e60b9a649874ee
Author: Ozan Can Altiok 
Date:   2018-02-26T07:22:41Z

some fixes in erlang test - no need for including lists library

commit b4e9ce56aecf75beffbf77864f02891808072204
Author: Ozan Can Altiok 
Date:   2018-02-26T09:31:46Z

more style changes - something overlooked

commit 39bb546d0ccbec7177866a1a78d9b5f4de0d9ec1
Author: Ozan Can Altiok 
Date:   2018-02-26T10:24:45Z

expected 2 lines before main - fixed (not seen locally)

commit 98db81883af06d10e9277fb32988edfd3f044d1d
Author: Ozan Can Altiok 
Date:   2018-02-26T11:24:05Z

noticed that test cases should be added manually in Python

commit 64aae330efac4ee23ed01694bc7dceb5a7a9164b
Author: Ozan Can Altiok 
Date:   2018-02-27T06:48:48Z

DoubleConstantTest thrift compilation directive is now given in 
generate.cmake

commit decb436f40990e0a04be9730accd3becab951c39
Author: Ozan Can Altiok 
Date:   2018-02-28T06:13:34Z

render_double_to_string -> emit_double_as_string

commit e9b2e389b1184efa4d8ad1d6424ec52a108b80c9
Author: Ozan Can Altiok 
Date:   2018-03-02T12:45:54Z

added assertion error messages to see the problems inside Java tests in 
more detail

commit 248e8a4c208e518da30f761a2d836ff790cd9b0d
Author: Ozan Can Altiok 
Date:   2018-03-05T06:59:59Z

RDP access to AppVeyor build workers

commit dd9b65113f143f13e6524917add6c216b16f86e5
Author: Ozan Can Altiok 
Date:   2018-03-05T07:01:07Z

Merge branch 'master' of https://github.com/apache/thrift into THRIFT-4476

commit 65a6588d049dcbbef7d3df5d7c3ba9a7b141917a
Author: Ozan Can Altiok 
Date:   2018-03-05T07:03:20Z

duplicate key problem in appveyor settings

commit 6305384d9203bd532983d18a992515db802b29a5
Author: Ozan Can Altiok 
Date:   2018-03-05T09:31:22Z

ignore the test cases with (-+)1.7e+308 in Java tests

commit 74667acf55c435c661c5fc19de729eb5f82758dc
Author: Ozan Can Altiok 
Date:   2018-03-05T10:00:31Z

ignore the test cases with (-+)1.7e+308 in Java tests - 2

commit 85b872bac39078446aa27336ca57001022524fc0
Author: Ozan Can Altiok 
Date:   2018-03-05T12:18:14Z

pyflakes8 style changes

commit af11ef8c7475c5f57f2d6619bedea23856a0fd17
Author: Ozan Can Altiok 
Date:   2018-03-06T08:21:51Z

disabling the test named 'TestRenderedDoubleConstants' on machines with the 
MSVC2010 configuration

commit 8ed1997141dce6c4b4505b09d2d6843344dfa04b
Author: Ozan Can Altiok 
Date:   2018-03-06T08:58:25Z

msvc.profile parameter existence check

commit beb12744f990ed0890648b07d81f19c121303c59
Author: Ozan Can Altiok 
Date:   2018-03-06T12:05:04Z

passing "msvc profile" on build stage

commit 1a0756aa8d48b693ae39dd860bdbeb7de5252cae
Author: Ozan Can Altiok 
Date:   2018-03-06T12:50:10Z

"MSVC_PROFILE" as a cache variable

commit b40fc4e06083f2787db3f805756abe7e6c2c704d
Author: Ozan Can Altiok 
Date:   2018-03-06T13:01:48Z

[GitHub] thrift pull request #1496: THRIFT-4476: Typecasting problem on list items (+...

[ozymaxx]

Github user ozymaxx closed the pull request at:

https://github.com/apache/thrift/pull/1496


---

[GitHub] thrift pull request #1496: THRIFT-4476: Typecasting problem on list items (+...

[ozymaxx]

GitHub user ozymaxx opened a pull request:

https://github.com/apache/thrift/pull/1496

THRIFT-4476: Typecasting problem on list items (+ low precision double 
rendering, + mis-rendering non-fractional double literals in Python)

- high precision double rendering in JS, Java, Python and C++
- testing double rendering in JS, Java, Python and C++

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ozymaxx/thrift THRIFT-4476

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1496.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1496


commit f5a6337d4448a30c284a3033307865dfc992ac7d
Author: Ozan Can Altiok 
Date:   2018-02-19T13:55:09Z

- high precision double rendering in JS, Java, Python and C++
- testing double rendering in JS, Java, Python and C++




---