[RESULT][VOTE] TinkerPop 3.2.1 Release

[Stephen Mallette]

This vote is now closed with a total of 6 +1s, no +0s and no -1s. The
results are:

BINDING VOTES:

+1  (Stephen Mallette, Dylan Millikin, Daniel Kuppitz, Hadrian Zbarcea, Ted
Wilmes)
0   (0)
-1  (0)

NON-BINDING VOTES:

+1 (Pieter Martin)
0  (0)
-1 (0)

Thank you very much,

Stephen

On Thu, Jul 21, 2016 at 9:28 PM, Ted Wilmes  wrote:

> Validate distribution looks good along with manual inspection of docs and
> testing.  Thanks for putting this all together Stephen and for running me
> through part of the process this time.
>
> VOTE: +1
>
> --Ted
>
> On Wed, Jul 20, 2016 at 3:42 PM, Stephen Mallette 
> wrote:
>
> > Thanks Hadrian - I read that section you referenced to remind myself of
> how
> > Apache viewed the -1 and I understood it as you described, however I went
> > so far as to say a "-1 means aborting the release" because as the release
> > manager I was taking the the non-binding -1 pretty seriously with the
> > likely action of killing the release if Pieter's concern wasn't cleared.
> > anyway - glad to see that we worked through our first -1 on VOTE day for
> a
> > release ;)
> >
> > On Wed, Jul 20, 2016 at 4:24 PM, Hadrian Zbarcea 
> > wrote:
> >
> > > +1
> > >
> > > Stephen, a -1 on a release is not a veto, see the "votes on package
> > > releases" section on the foundation site [1]. It is up to the release
> > > manager to decide how to proceed. Usually releases are redone not
> because
> > > of the -1, but because there is a valid reason behind the -1.
> Experienced
> > > committers and contributors understand if a -1 is warranted and weird
> -1s
> > > are rare. It is also my preference (and that's what I did in the past)
> to
> > > cancel releases even based on non-binding -1s, because the voice of
> > > contributors matters too.
> > >
> > > Pretty cool that dialogue led to consensus and actions on how to make
> > > progress. Another proof of how awesome the Tinkerpop community is.
> > >
> > > Cheers,
> > > Hadrian
> > >
> > >
> > > On 07/20/2016 12:01 PM, Stephen Mallette wrote:
> > >
> > >> Pieter, Thanks as usual for testing. I would offer than this is not a
> > case
> > >> for a -1. Note that a -1 says we abort the release completely.
> > >>
> > >> imo, a -1 should be reserved for when there is a massive bug that
> brings
> > >> down the house - meaning the system is abend in some way and there are
> > no
> > >> workarounds. a -1 might also be presented if the packaging is bad
> > somehow
> > >> -
> > >> like we didn't include the documentation in the zips. i could also
> see a
> > >> -1
> > >> if somehow a GPL'd dependency snuck into our packaging somehow or we
> > >> otherwise violated Apache licensing. If other's don't agree, I hope
> > >> they'll
> > >> say so.
> > >>
> > >> in this case, you have a single backend for Sqlg that is failing a
> > single
> > >> test that you can temporarily OptOut of for your tests to pass. Users
> > >> don't
> > >> specifically have a workaround for this problem if they use Sqlg and
> > >> HSQLDB, but it's less of a "bug" and more of a feature that they can't
> > use
> > >> (i.e. they can't interrupt a running traversal). To me, I don't think
> we
> > >> need to stop release of TinkerPop over that narrow case.
> > >>
> > >> Would you reconsider your -1 based on that logic?
> > >>
> > >>
> > >>
> > >> On Wed, Jul 20, 2016 at 11:45 AM, pieter-gmail <
> pieter.mar...@gmail.com
> > >
> > >> wrote:
> > >>
> > >> Hi,
> > >>>
> > >>> Ran all Sqlg's tests and the process and structured  test suites.
> > >>> But alas there are failures.
> > >>>
> > >>> TraversalInterruptionTest are failing on HSQLDB as the
> > >>> Thread.interrupt() is intercepted by them and the interrupt flag is
> > >>> reset.
> > >>> The TraversalInterruptionTest tests themselves suffers from this as
> its
> > >>> own Thread.sleep() logic resets the interrupt flag and requires
> special
> > >>> resetting. I'd say the current interrupt strategy needs rethinking.
> > >>>
> > >>> TailTest.g_V_repeatXbothX_timesX3X_tailX7X fails. I added a few more,
> > >>> repeat followed by a tail step, tests in sqlg, all of which also
> fails.
> > >>> Jason has already proposed a fix for this here
> > >>> .
> > >>>
> > >>> vote -1
> > >>>
> > >>> Thanks
> > >>> Pieter
> > >>>
> > >>>
> > >>>
> > >>> On 19/07/2016 15:20, Stephen Mallette wrote:
> > >>>
> >  Hello,
> > 
> >  We are happy to announce that TinkerPop 3.2.1 is ready for release -
> >  note
> >  the lack of "-incubating" everywhere.  :)
> > 
> >  The release artifacts can be found at this location:
> >  https://dist.apache.org/repos/dist/dev/tinkerpop/3.2.1/
> > 
> >  The source distribution is provided by:
> >  apache-tinkerpop-3.2.1-src.zip
> > 
> >  Two binary distributions are provided for user convenience:
> >  apache-gremlin-console-3.2.1-bin.zip
> >  apache-gremlin-server-3.2.1-bin.zip
> > 
> >  The GPG key used to sign

Re: [VOTE] TinkerPop 3.2.1 Release

[Ted Wilmes]

Validate distribution looks good along with manual inspection of docs and
testing.  Thanks for putting this all together Stephen and for running me
through part of the process this time.

VOTE: +1

--Ted

On Wed, Jul 20, 2016 at 3:42 PM, Stephen Mallette 
wrote:

> Thanks Hadrian - I read that section you referenced to remind myself of how
> Apache viewed the -1 and I understood it as you described, however I went
> so far as to say a "-1 means aborting the release" because as the release
> manager I was taking the the non-binding -1 pretty seriously with the
> likely action of killing the release if Pieter's concern wasn't cleared.
> anyway - glad to see that we worked through our first -1 on VOTE day for a
> release ;)
>
> On Wed, Jul 20, 2016 at 4:24 PM, Hadrian Zbarcea 
> wrote:
>
> > +1
> >
> > Stephen, a -1 on a release is not a veto, see the "votes on package
> > releases" section on the foundation site [1]. It is up to the release
> > manager to decide how to proceed. Usually releases are redone not because
> > of the -1, but because there is a valid reason behind the -1. Experienced
> > committers and contributors understand if a -1 is warranted and weird -1s
> > are rare. It is also my preference (and that's what I did in the past) to
> > cancel releases even based on non-binding -1s, because the voice of
> > contributors matters too.
> >
> > Pretty cool that dialogue led to consensus and actions on how to make
> > progress. Another proof of how awesome the Tinkerpop community is.
> >
> > Cheers,
> > Hadrian
> >
> >
> > On 07/20/2016 12:01 PM, Stephen Mallette wrote:
> >
> >> Pieter, Thanks as usual for testing. I would offer than this is not a
> case
> >> for a -1. Note that a -1 says we abort the release completely.
> >>
> >> imo, a -1 should be reserved for when there is a massive bug that brings
> >> down the house - meaning the system is abend in some way and there are
> no
> >> workarounds. a -1 might also be presented if the packaging is bad
> somehow
> >> -
> >> like we didn't include the documentation in the zips. i could also see a
> >> -1
> >> if somehow a GPL'd dependency snuck into our packaging somehow or we
> >> otherwise violated Apache licensing. If other's don't agree, I hope
> >> they'll
> >> say so.
> >>
> >> in this case, you have a single backend for Sqlg that is failing a
> single
> >> test that you can temporarily OptOut of for your tests to pass. Users
> >> don't
> >> specifically have a workaround for this problem if they use Sqlg and
> >> HSQLDB, but it's less of a "bug" and more of a feature that they can't
> use
> >> (i.e. they can't interrupt a running traversal). To me, I don't think we
> >> need to stop release of TinkerPop over that narrow case.
> >>
> >> Would you reconsider your -1 based on that logic?
> >>
> >>
> >>
> >> On Wed, Jul 20, 2016 at 11:45 AM, pieter-gmail  >
> >> wrote:
> >>
> >> Hi,
> >>>
> >>> Ran all Sqlg's tests and the process and structured  test suites.
> >>> But alas there are failures.
> >>>
> >>> TraversalInterruptionTest are failing on HSQLDB as the
> >>> Thread.interrupt() is intercepted by them and the interrupt flag is
> >>> reset.
> >>> The TraversalInterruptionTest tests themselves suffers from this as its
> >>> own Thread.sleep() logic resets the interrupt flag and requires special
> >>> resetting. I'd say the current interrupt strategy needs rethinking.
> >>>
> >>> TailTest.g_V_repeatXbothX_timesX3X_tailX7X fails. I added a few more,
> >>> repeat followed by a tail step, tests in sqlg, all of which also fails.
> >>> Jason has already proposed a fix for this here
> >>> .
> >>>
> >>> vote -1
> >>>
> >>> Thanks
> >>> Pieter
> >>>
> >>>
> >>>
> >>> On 19/07/2016 15:20, Stephen Mallette wrote:
> >>>
>  Hello,
> 
>  We are happy to announce that TinkerPop 3.2.1 is ready for release -
>  note
>  the lack of "-incubating" everywhere.  :)
> 
>  The release artifacts can be found at this location:
>  https://dist.apache.org/repos/dist/dev/tinkerpop/3.2.1/
> 
>  The source distribution is provided by:
>  apache-tinkerpop-3.2.1-src.zip
> 
>  Two binary distributions are provided for user convenience:
>  apache-gremlin-console-3.2.1-bin.zip
>  apache-gremlin-server-3.2.1-bin.zip
> 
>  The GPG key used to sign the release artifacts is available at:
>   https://dist.apache.org/repos/dist/dev/tinkerpop/KEYS
> 
>  The online docs can be found here:
>  http://tinkerpop.apache.org/docs/3.2.1/reference/ (user docs)
>  http://tinkerpop.apache.org/docs/3.2.1/upgrade/ (upgrade docs)
>  http://tinkerpop.apache.org/javadocs/3.2.1/core/ (core javadoc)
>  http://tinkerpop.apache.org/javadocs/3.2.1/full/ (full javadoc)
> 
>  The tag in Apache Git can be found here:
> 
> 
> 
> >>>
> https://git-wip-us.apache.org/repos/asf?p=tinkerpop.git;a=tag;h=c5a9e2815e76f044e6b33b773b6bb0bb048270cc
> >

Re: [VOTE] TinkerPop 3.2.1 Release

[Stephen Mallette]

Thanks Hadrian - I read that section you referenced to remind myself of how
Apache viewed the -1 and I understood it as you described, however I went
so far as to say a "-1 means aborting the release" because as the release
manager I was taking the the non-binding -1 pretty seriously with the
likely action of killing the release if Pieter's concern wasn't cleared.
anyway - glad to see that we worked through our first -1 on VOTE day for a
release ;)

On Wed, Jul 20, 2016 at 4:24 PM, Hadrian Zbarcea  wrote:

> +1
>
> Stephen, a -1 on a release is not a veto, see the "votes on package
> releases" section on the foundation site [1]. It is up to the release
> manager to decide how to proceed. Usually releases are redone not because
> of the -1, but because there is a valid reason behind the -1. Experienced
> committers and contributors understand if a -1 is warranted and weird -1s
> are rare. It is also my preference (and that's what I did in the past) to
> cancel releases even based on non-binding -1s, because the voice of
> contributors matters too.
>
> Pretty cool that dialogue led to consensus and actions on how to make
> progress. Another proof of how awesome the Tinkerpop community is.
>
> Cheers,
> Hadrian
>
>
> On 07/20/2016 12:01 PM, Stephen Mallette wrote:
>
>> Pieter, Thanks as usual for testing. I would offer than this is not a case
>> for a -1. Note that a -1 says we abort the release completely.
>>
>> imo, a -1 should be reserved for when there is a massive bug that brings
>> down the house - meaning the system is abend in some way and there are no
>> workarounds. a -1 might also be presented if the packaging is bad somehow
>> -
>> like we didn't include the documentation in the zips. i could also see a
>> -1
>> if somehow a GPL'd dependency snuck into our packaging somehow or we
>> otherwise violated Apache licensing. If other's don't agree, I hope
>> they'll
>> say so.
>>
>> in this case, you have a single backend for Sqlg that is failing a single
>> test that you can temporarily OptOut of for your tests to pass. Users
>> don't
>> specifically have a workaround for this problem if they use Sqlg and
>> HSQLDB, but it's less of a "bug" and more of a feature that they can't use
>> (i.e. they can't interrupt a running traversal). To me, I don't think we
>> need to stop release of TinkerPop over that narrow case.
>>
>> Would you reconsider your -1 based on that logic?
>>
>>
>>
>> On Wed, Jul 20, 2016 at 11:45 AM, pieter-gmail 
>> wrote:
>>
>> Hi,
>>>
>>> Ran all Sqlg's tests and the process and structured  test suites.
>>> But alas there are failures.
>>>
>>> TraversalInterruptionTest are failing on HSQLDB as the
>>> Thread.interrupt() is intercepted by them and the interrupt flag is
>>> reset.
>>> The TraversalInterruptionTest tests themselves suffers from this as its
>>> own Thread.sleep() logic resets the interrupt flag and requires special
>>> resetting. I'd say the current interrupt strategy needs rethinking.
>>>
>>> TailTest.g_V_repeatXbothX_timesX3X_tailX7X fails. I added a few more,
>>> repeat followed by a tail step, tests in sqlg, all of which also fails.
>>> Jason has already proposed a fix for this here
>>> .
>>>
>>> vote -1
>>>
>>> Thanks
>>> Pieter
>>>
>>>
>>>
>>> On 19/07/2016 15:20, Stephen Mallette wrote:
>>>
 Hello,

 We are happy to announce that TinkerPop 3.2.1 is ready for release -
 note
 the lack of "-incubating" everywhere.  :)

 The release artifacts can be found at this location:
 https://dist.apache.org/repos/dist/dev/tinkerpop/3.2.1/

 The source distribution is provided by:
 apache-tinkerpop-3.2.1-src.zip

 Two binary distributions are provided for user convenience:
 apache-gremlin-console-3.2.1-bin.zip
 apache-gremlin-server-3.2.1-bin.zip

 The GPG key used to sign the release artifacts is available at:
  https://dist.apache.org/repos/dist/dev/tinkerpop/KEYS

 The online docs can be found here:
 http://tinkerpop.apache.org/docs/3.2.1/reference/ (user docs)
 http://tinkerpop.apache.org/docs/3.2.1/upgrade/ (upgrade docs)
 http://tinkerpop.apache.org/javadocs/3.2.1/core/ (core javadoc)
 http://tinkerpop.apache.org/javadocs/3.2.1/full/ (full javadoc)

 The tag in Apache Git can be found here:



>>> https://git-wip-us.apache.org/repos/asf?p=tinkerpop.git;a=tag;h=c5a9e2815e76f044e6b33b773b6bb0bb048270cc
>>>

 The release notes are available here:


>>> https://github.com/apache/tinkerpop/blob/3.2.1/CHANGELOG.asciidoc#release-3-2-1
>>>

 The [VOTE] will be open for the next 72 hours --- closing Friday (July

>>> 22,
>>>
 2016) at 9:30 am EST.

 My vote is +1.

 Thank you very much,
 Stephen


>>>
>>>
>>

Re: [VOTE] TinkerPop 3.2.1 Release

[Hadrian Zbarcea]

+1

Stephen, a -1 on a release is not a veto, see the "votes on package 
releases" section on the foundation site [1]. It is up to the release 
manager to decide how to proceed. Usually releases are redone not 
because of the -1, but because there is a valid reason behind the -1. 
Experienced committers and contributors understand if a -1 is warranted 
and weird -1s are rare. It is also my preference (and that's what I did 
in the past) to cancel releases even based on non-binding -1s, because 
the voice of contributors matters too.


Pretty cool that dialogue led to consensus and actions on how to make 
progress. Another proof of how awesome the Tinkerpop community is.


Cheers,
Hadrian

On 07/20/2016 12:01 PM, Stephen Mallette wrote:

Pieter, Thanks as usual for testing. I would offer than this is not a case
for a -1. Note that a -1 says we abort the release completely.

imo, a -1 should be reserved for when there is a massive bug that brings
down the house - meaning the system is abend in some way and there are no
workarounds. a -1 might also be presented if the packaging is bad somehow -
like we didn't include the documentation in the zips. i could also see a -1
if somehow a GPL'd dependency snuck into our packaging somehow or we
otherwise violated Apache licensing. If other's don't agree, I hope they'll
say so.

in this case, you have a single backend for Sqlg that is failing a single
test that you can temporarily OptOut of for your tests to pass. Users don't
specifically have a workaround for this problem if they use Sqlg and
HSQLDB, but it's less of a "bug" and more of a feature that they can't use
(i.e. they can't interrupt a running traversal). To me, I don't think we
need to stop release of TinkerPop over that narrow case.

Would you reconsider your -1 based on that logic?



On Wed, Jul 20, 2016 at 11:45 AM, pieter-gmail 
wrote:


Hi,

Ran all Sqlg's tests and the process and structured  test suites.
But alas there are failures.

TraversalInterruptionTest are failing on HSQLDB as the
Thread.interrupt() is intercepted by them and the interrupt flag is reset.
The TraversalInterruptionTest tests themselves suffers from this as its
own Thread.sleep() logic resets the interrupt flag and requires special
resetting. I'd say the current interrupt strategy needs rethinking.

TailTest.g_V_repeatXbothX_timesX3X_tailX7X fails. I added a few more,
repeat followed by a tail step, tests in sqlg, all of which also fails.
Jason has already proposed a fix for this here
.

vote -1

Thanks
Pieter



On 19/07/2016 15:20, Stephen Mallette wrote:

Hello,

We are happy to announce that TinkerPop 3.2.1 is ready for release - note
the lack of "-incubating" everywhere.  :)

The release artifacts can be found at this location:
https://dist.apache.org/repos/dist/dev/tinkerpop/3.2.1/

The source distribution is provided by:
apache-tinkerpop-3.2.1-src.zip

Two binary distributions are provided for user convenience:
apache-gremlin-console-3.2.1-bin.zip
apache-gremlin-server-3.2.1-bin.zip

The GPG key used to sign the release artifacts is available at:
 https://dist.apache.org/repos/dist/dev/tinkerpop/KEYS

The online docs can be found here:
http://tinkerpop.apache.org/docs/3.2.1/reference/ (user docs)
http://tinkerpop.apache.org/docs/3.2.1/upgrade/ (upgrade docs)
http://tinkerpop.apache.org/javadocs/3.2.1/core/ (core javadoc)
http://tinkerpop.apache.org/javadocs/3.2.1/full/ (full javadoc)

The tag in Apache Git can be found here:



https://git-wip-us.apache.org/repos/asf?p=tinkerpop.git;a=tag;h=c5a9e2815e76f044e6b33b773b6bb0bb048270cc


The release notes are available here:


https://github.com/apache/tinkerpop/blob/3.2.1/CHANGELOG.asciidoc#release-3-2-1


The [VOTE] will be open for the next 72 hours --- closing Friday (July

22,

2016) at 9:30 am EST.

My vote is +1.

Thank you very much,
Stephen

Re: [VOTE] TinkerPop 3.2.1 Release

[pieter-gmail]

After some discussion in HipChat I have had a change of heart.

VOTE +1

As an aside if the code freeze can include 2 weekends it'll be great.

Thanks
Pieter

On 20/07/2016 18:59, Stephen Mallette wrote:
> w that we dont' have to go through incubator for release. Perhaps we plan
> to get a 3.2.2 out sooner than later with Jason's fix and a couple other
> odds and ends we wanted in 3.2.1 that didn't make it.  Again, another
> discussion for another th

Re: [VOTE] TinkerPop 3.2.1 Release

[Stephen Mallette]

I'll clarify a little bit - I missed a piece of Pieter's email. I focused
on the "thread interruption" but he also mentioned a problem with tail() -
which Jason Plurad has already submitted a PR for:

https://github.com/apache/tinkerpop/pull/363

In this case the bug is on our side in TinkerPop but it only affects
certain implementation in the right combinations of steps that include
bulking (according to Jason). Given Jason's assessment and my earlier
description of what -1 means, I think we should continue with release.
Happy to hear if others think differently

As a separate note, Pieter also brought up on HipChat that this was a
shortened release test period. Apologies for that.  The PR review queue got
too deep toward the end of code freeze. We probably should have delayed the
VOTE for a full seven days. I don't know if we need more than 10 days (7 in
freeze and 3 in VOTE) for testing but if someone would like to bring that
up as a separate thread please do. For me, I think we should just better
stick to our full seven day freeze and not meld it up with PR reviews and
such.

Finally, we can release more often now if we like. We have less overhead
now that we dont' have to go through incubator for release. Perhaps we plan
to get a 3.2.2 out sooner than later with Jason's fix and a couple other
odds and ends we wanted in 3.2.1 that didn't make it.  Again, another
discussion for another thread.




On Wed, Jul 20, 2016 at 12:50 PM, Daniel Kuppitz  wrote:

> >
> > imo, a -1 should be reserved for when there is a massive bug that brings
> down
> > the house
>
>
> I concur. I've also found some nasty bugs in OLAP during my tests and even
> if without a workaround I would probably have voted +1, as this has nothing
> to do with the release.
>
> you have a single backend for Sqlg
>
>
> That's another good point. If all tests pass for our reference
> implementations (TinkerGraph and Neo4j), why should a failing test in
> another 3rd party implementation block our release? AFAIK there are also
> still issues in Titan, but that's a Titan thing, not a TinkerPop issue.
>
> Cheers,
> Daniel
>
>
>
>
> On Wed, Jul 20, 2016 at 6:01 PM, Stephen Mallette 
> wrote:
>
> > Pieter, Thanks as usual for testing. I would offer than this is not a
> case
> > for a -1. Note that a -1 says we abort the release completely.
> >
> > imo, a -1 should be reserved for when there is a massive bug that brings
> > down the house - meaning the system is abend in some way and there are no
> > workarounds. a -1 might also be presented if the packaging is bad
> somehow -
> > like we didn't include the documentation in the zips. i could also see a
> -1
> > if somehow a GPL'd dependency snuck into our packaging somehow or we
> > otherwise violated Apache licensing. If other's don't agree, I hope
> they'll
> > say so.
> >
> > in this case, you have a single backend for Sqlg that is failing a single
> > test that you can temporarily OptOut of for your tests to pass. Users
> don't
> > specifically have a workaround for this problem if they use Sqlg and
> > HSQLDB, but it's less of a "bug" and more of a feature that they can't
> use
> > (i.e. they can't interrupt a running traversal). To me, I don't think we
> > need to stop release of TinkerPop over that narrow case.
> >
> > Would you reconsider your -1 based on that logic?
> >
> >
> >
> > On Wed, Jul 20, 2016 at 11:45 AM, pieter-gmail 
> > wrote:
> >
> > > Hi,
> > >
> > > Ran all Sqlg's tests and the process and structured  test suites.
> > > But alas there are failures.
> > >
> > > TraversalInterruptionTest are failing on HSQLDB as the
> > > Thread.interrupt() is intercepted by them and the interrupt flag is
> > reset.
> > > The TraversalInterruptionTest tests themselves suffers from this as its
> > > own Thread.sleep() logic resets the interrupt flag and requires special
> > > resetting. I'd say the current interrupt strategy needs rethinking.
> > >
> > > TailTest.g_V_repeatXbothX_timesX3X_tailX7X fails. I added a few more,
> > > repeat followed by a tail step, tests in sqlg, all of which also fails.
> > > Jason has already proposed a fix for this here
> > > .
> > >
> > > vote -1
> > >
> > > Thanks
> > > Pieter
> > >
> > >
> > >
> > > On 19/07/2016 15:20, Stephen Mallette wrote:
> > > > Hello,
> > > >
> > > > We are happy to announce that TinkerPop 3.2.1 is ready for release -
> > note
> > > > the lack of "-incubating" everywhere.  :)
> > > >
> > > > The release artifacts can be found at this location:
> > > > https://dist.apache.org/repos/dist/dev/tinkerpop/3.2.1/
> > > >
> > > > The source distribution is provided by:
> > > > apache-tinkerpop-3.2.1-src.zip
> > > >
> > > > Two binary distributions are provided for user convenience:
> > > > apache-gremlin-console-3.2.1-bin.zip
> > > > apache-gremlin-server-3.2.1-bin.zip
> > > >
> > > > The GPG key used to sign the release artifacts is available at:
> > > > https://dist.apache.org/repo

Re: [VOTE] TinkerPop 3.2.1 Release

[Daniel Kuppitz]

>
> imo, a -1 should be reserved for when there is a massive bug that brings down
> the house


I concur. I've also found some nasty bugs in OLAP during my tests and even
if without a workaround I would probably have voted +1, as this has nothing
to do with the release.

you have a single backend for Sqlg


That's another good point. If all tests pass for our reference
implementations (TinkerGraph and Neo4j), why should a failing test in
another 3rd party implementation block our release? AFAIK there are also
still issues in Titan, but that's a Titan thing, not a TinkerPop issue.

Cheers,
Daniel




On Wed, Jul 20, 2016 at 6:01 PM, Stephen Mallette 
wrote:

> Pieter, Thanks as usual for testing. I would offer than this is not a case
> for a -1. Note that a -1 says we abort the release completely.
>
> imo, a -1 should be reserved for when there is a massive bug that brings
> down the house - meaning the system is abend in some way and there are no
> workarounds. a -1 might also be presented if the packaging is bad somehow -
> like we didn't include the documentation in the zips. i could also see a -1
> if somehow a GPL'd dependency snuck into our packaging somehow or we
> otherwise violated Apache licensing. If other's don't agree, I hope they'll
> say so.
>
> in this case, you have a single backend for Sqlg that is failing a single
> test that you can temporarily OptOut of for your tests to pass. Users don't
> specifically have a workaround for this problem if they use Sqlg and
> HSQLDB, but it's less of a "bug" and more of a feature that they can't use
> (i.e. they can't interrupt a running traversal). To me, I don't think we
> need to stop release of TinkerPop over that narrow case.
>
> Would you reconsider your -1 based on that logic?
>
>
>
> On Wed, Jul 20, 2016 at 11:45 AM, pieter-gmail 
> wrote:
>
> > Hi,
> >
> > Ran all Sqlg's tests and the process and structured  test suites.
> > But alas there are failures.
> >
> > TraversalInterruptionTest are failing on HSQLDB as the
> > Thread.interrupt() is intercepted by them and the interrupt flag is
> reset.
> > The TraversalInterruptionTest tests themselves suffers from this as its
> > own Thread.sleep() logic resets the interrupt flag and requires special
> > resetting. I'd say the current interrupt strategy needs rethinking.
> >
> > TailTest.g_V_repeatXbothX_timesX3X_tailX7X fails. I added a few more,
> > repeat followed by a tail step, tests in sqlg, all of which also fails.
> > Jason has already proposed a fix for this here
> > .
> >
> > vote -1
> >
> > Thanks
> > Pieter
> >
> >
> >
> > On 19/07/2016 15:20, Stephen Mallette wrote:
> > > Hello,
> > >
> > > We are happy to announce that TinkerPop 3.2.1 is ready for release -
> note
> > > the lack of "-incubating" everywhere.  :)
> > >
> > > The release artifacts can be found at this location:
> > > https://dist.apache.org/repos/dist/dev/tinkerpop/3.2.1/
> > >
> > > The source distribution is provided by:
> > > apache-tinkerpop-3.2.1-src.zip
> > >
> > > Two binary distributions are provided for user convenience:
> > > apache-gremlin-console-3.2.1-bin.zip
> > > apache-gremlin-server-3.2.1-bin.zip
> > >
> > > The GPG key used to sign the release artifacts is available at:
> > > https://dist.apache.org/repos/dist/dev/tinkerpop/KEYS
> > >
> > > The online docs can be found here:
> > > http://tinkerpop.apache.org/docs/3.2.1/reference/ (user docs)
> > > http://tinkerpop.apache.org/docs/3.2.1/upgrade/ (upgrade docs)
> > > http://tinkerpop.apache.org/javadocs/3.2.1/core/ (core javadoc)
> > > http://tinkerpop.apache.org/javadocs/3.2.1/full/ (full javadoc)
> > >
> > > The tag in Apache Git can be found here:
> > >
> > >
> >
> https://git-wip-us.apache.org/repos/asf?p=tinkerpop.git;a=tag;h=c5a9e2815e76f044e6b33b773b6bb0bb048270cc
> > >
> > > The release notes are available here:
> > >
> >
> https://github.com/apache/tinkerpop/blob/3.2.1/CHANGELOG.asciidoc#release-3-2-1
> > >
> > > The [VOTE] will be open for the next 72 hours --- closing Friday (July
> > 22,
> > > 2016) at 9:30 am EST.
> > >
> > > My vote is +1.
> > >
> > > Thank you very much,
> > > Stephen
> > >
> >
> >
>

Re: [VOTE] TinkerPop 3.2.1 Release

[Stephen Mallette]

Pieter, Thanks as usual for testing. I would offer than this is not a case
for a -1. Note that a -1 says we abort the release completely.

imo, a -1 should be reserved for when there is a massive bug that brings
down the house - meaning the system is abend in some way and there are no
workarounds. a -1 might also be presented if the packaging is bad somehow -
like we didn't include the documentation in the zips. i could also see a -1
if somehow a GPL'd dependency snuck into our packaging somehow or we
otherwise violated Apache licensing. If other's don't agree, I hope they'll
say so.

in this case, you have a single backend for Sqlg that is failing a single
test that you can temporarily OptOut of for your tests to pass. Users don't
specifically have a workaround for this problem if they use Sqlg and
HSQLDB, but it's less of a "bug" and more of a feature that they can't use
(i.e. they can't interrupt a running traversal). To me, I don't think we
need to stop release of TinkerPop over that narrow case.

Would you reconsider your -1 based on that logic?



On Wed, Jul 20, 2016 at 11:45 AM, pieter-gmail 
wrote:

> Hi,
>
> Ran all Sqlg's tests and the process and structured  test suites.
> But alas there are failures.
>
> TraversalInterruptionTest are failing on HSQLDB as the
> Thread.interrupt() is intercepted by them and the interrupt flag is reset.
> The TraversalInterruptionTest tests themselves suffers from this as its
> own Thread.sleep() logic resets the interrupt flag and requires special
> resetting. I'd say the current interrupt strategy needs rethinking.
>
> TailTest.g_V_repeatXbothX_timesX3X_tailX7X fails. I added a few more,
> repeat followed by a tail step, tests in sqlg, all of which also fails.
> Jason has already proposed a fix for this here
> .
>
> vote -1
>
> Thanks
> Pieter
>
>
>
> On 19/07/2016 15:20, Stephen Mallette wrote:
> > Hello,
> >
> > We are happy to announce that TinkerPop 3.2.1 is ready for release - note
> > the lack of "-incubating" everywhere.  :)
> >
> > The release artifacts can be found at this location:
> > https://dist.apache.org/repos/dist/dev/tinkerpop/3.2.1/
> >
> > The source distribution is provided by:
> > apache-tinkerpop-3.2.1-src.zip
> >
> > Two binary distributions are provided for user convenience:
> > apache-gremlin-console-3.2.1-bin.zip
> > apache-gremlin-server-3.2.1-bin.zip
> >
> > The GPG key used to sign the release artifacts is available at:
> > https://dist.apache.org/repos/dist/dev/tinkerpop/KEYS
> >
> > The online docs can be found here:
> > http://tinkerpop.apache.org/docs/3.2.1/reference/ (user docs)
> > http://tinkerpop.apache.org/docs/3.2.1/upgrade/ (upgrade docs)
> > http://tinkerpop.apache.org/javadocs/3.2.1/core/ (core javadoc)
> > http://tinkerpop.apache.org/javadocs/3.2.1/full/ (full javadoc)
> >
> > The tag in Apache Git can be found here:
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=tinkerpop.git;a=tag;h=c5a9e2815e76f044e6b33b773b6bb0bb048270cc
> >
> > The release notes are available here:
> >
> https://github.com/apache/tinkerpop/blob/3.2.1/CHANGELOG.asciidoc#release-3-2-1
> >
> > The [VOTE] will be open for the next 72 hours --- closing Friday (July
> 22,
> > 2016) at 9:30 am EST.
> >
> > My vote is +1.
> >
> > Thank you very much,
> > Stephen
> >
>
>

Re: [VOTE] TinkerPop 3.2.1 Release

[pieter-gmail]

Hi,

Ran all Sqlg's tests and the process and structured  test suites.
But alas there are failures.

TraversalInterruptionTest are failing on HSQLDB as the
Thread.interrupt() is intercepted by them and the interrupt flag is reset.
The TraversalInterruptionTest tests themselves suffers from this as its
own Thread.sleep() logic resets the interrupt flag and requires special
resetting. I'd say the current interrupt strategy needs rethinking.

TailTest.g_V_repeatXbothX_timesX3X_tailX7X fails. I added a few more,
repeat followed by a tail step, tests in sqlg, all of which also fails.
Jason has already proposed a fix for this here
.

vote -1

Thanks
Pieter



On 19/07/2016 15:20, Stephen Mallette wrote:
> Hello,
>
> We are happy to announce that TinkerPop 3.2.1 is ready for release - note
> the lack of "-incubating" everywhere.  :)
>
> The release artifacts can be found at this location:
> https://dist.apache.org/repos/dist/dev/tinkerpop/3.2.1/
>
> The source distribution is provided by:
> apache-tinkerpop-3.2.1-src.zip
>
> Two binary distributions are provided for user convenience:
> apache-gremlin-console-3.2.1-bin.zip
> apache-gremlin-server-3.2.1-bin.zip
>
> The GPG key used to sign the release artifacts is available at:
> https://dist.apache.org/repos/dist/dev/tinkerpop/KEYS
>
> The online docs can be found here:
> http://tinkerpop.apache.org/docs/3.2.1/reference/ (user docs)
> http://tinkerpop.apache.org/docs/3.2.1/upgrade/ (upgrade docs)
> http://tinkerpop.apache.org/javadocs/3.2.1/core/ (core javadoc)
> http://tinkerpop.apache.org/javadocs/3.2.1/full/ (full javadoc)
>
> The tag in Apache Git can be found here:
>
> https://git-wip-us.apache.org/repos/asf?p=tinkerpop.git;a=tag;h=c5a9e2815e76f044e6b33b773b6bb0bb048270cc
>
> The release notes are available here:
> https://github.com/apache/tinkerpop/blob/3.2.1/CHANGELOG.asciidoc#release-3-2-1
>
> The [VOTE] will be open for the next 72 hours --- closing Friday (July 22,
> 2016) at 9:30 am EST.
>
> My vote is +1.
>
> Thank you very much,
> Stephen
>

Re: [VOTE] TinkerPop 3.2.1 Release

[Daniel Kuppitz]

$ bin/validate-distribution.sh 3.2.1

Validating binary distributions

* downloading Apache Gremlin Console
(apache-gremlin-console-3.2.1-bin.zip)... OK
* validating signatures and checksums ...
  * PGP signature ... OK
  * MD5 checksum ... OK
  * SHA1 checksum ... OK
* unzipping Apache Gremlin Console ... OK
* validating Apache Gremlin Console's docs ... OK
* validating Apache Gremlin Console's binaries ... OK
* validating Apache Gremlin Console's legal files ...
  * LICENSE ... OK
  * NOTICE ... OK
* validating Apache Gremlin Console's plugin directory ... OK
* validating Apache Gremlin Console's lib directory ... OK
* testing script evaluation ... OK

* downloading Apache Gremlin Server
(apache-gremlin-server-3.2.1-bin.zip)... OK
* validating signatures and checksums ...
  * PGP signature ... OK
  * MD5 checksum ... OK
  * SHA1 checksum ... OK
* unzipping Apache Gremlin Server ... OK
* validating Apache Gremlin Server's docs ... OK
* validating Apache Gremlin Server's binaries ... OK
* validating Apache Gremlin Server's legal files ...
  * LICENSE ... OK
  * NOTICE ... OK
* validating Apache Gremlin Server's plugin directory ... OK
* validating Apache Gremlin Server's lib directory ... OK

Validating source distribution

* downloading Apache TinkerPop 3.2.1 (apache-tinkerpop-3.2.1-src.zip)... OK
* validating signatures and checksums ...
  * PGP signature ... OK
  * MD5 checksum ... OK
  * SHA1 checksum ... OK
* unzipping Apache TinkerPop 3.2.1 ... OK
OK



Also did a bunch of manual tests (using the console). All good.

VOTE: +1

Cheers,
Daniel


On Tue, Jul 19, 2016 at 9:19 PM, Dylan Millikin 
wrote:

> Ran all the driver tests again neo4j and tinkerpop and everything works as
> expected.
>
> VOTE: +1
>
> On Tue, Jul 19, 2016 at 9:20 AM, Stephen Mallette 
> wrote:
>
> > Hello,
> >
> > We are happy to announce that TinkerPop 3.2.1 is ready for release - note
> > the lack of "-incubating" everywhere.  :)
> >
> > The release artifacts can be found at this location:
> > https://dist.apache.org/repos/dist/dev/tinkerpop/3.2.1/
> >
> > The source distribution is provided by:
> > apache-tinkerpop-3.2.1-src.zip
> >
> > Two binary distributions are provided for user convenience:
> > apache-gremlin-console-3.2.1-bin.zip
> > apache-gremlin-server-3.2.1-bin.zip
> >
> > The GPG key used to sign the release artifacts is available at:
> > https://dist.apache.org/repos/dist/dev/tinkerpop/KEYS
> >
> > The online docs can be found here:
> > http://tinkerpop.apache.org/docs/3.2.1/reference/ (user docs)
> > http://tinkerpop.apache.org/docs/3.2.1/upgrade/ (upgrade docs)
> > http://tinkerpop.apache.org/javadocs/3.2.1/core/ (core javadoc)
> > http://tinkerpop.apache.org/javadocs/3.2.1/full/ (full javadoc)
> >
> > The tag in Apache Git can be found here:
> >
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=tinkerpop.git;a=tag;h=c5a9e2815e76f044e6b33b773b6bb0bb048270cc
> >
> > The release notes are available here:
> >
> >
> https://github.com/apache/tinkerpop/blob/3.2.1/CHANGELOG.asciidoc#release-3-2-1
> >
> > The [VOTE] will be open for the next 72 hours --- closing Friday (July
> 22,
> > 2016) at 9:30 am EST.
> >
> > My vote is +1.
> >
> > Thank you very much,
> > Stephen
> >
>

Re: [VOTE] TinkerPop 3.2.1 Release

[Dylan Millikin]

Ran all the driver tests again neo4j and tinkerpop and everything works as
expected.

VOTE: +1

On Tue, Jul 19, 2016 at 9:20 AM, Stephen Mallette 
wrote:

> Hello,
>
> We are happy to announce that TinkerPop 3.2.1 is ready for release - note
> the lack of "-incubating" everywhere.  :)
>
> The release artifacts can be found at this location:
> https://dist.apache.org/repos/dist/dev/tinkerpop/3.2.1/
>
> The source distribution is provided by:
> apache-tinkerpop-3.2.1-src.zip
>
> Two binary distributions are provided for user convenience:
> apache-gremlin-console-3.2.1-bin.zip
> apache-gremlin-server-3.2.1-bin.zip
>
> The GPG key used to sign the release artifacts is available at:
> https://dist.apache.org/repos/dist/dev/tinkerpop/KEYS
>
> The online docs can be found here:
> http://tinkerpop.apache.org/docs/3.2.1/reference/ (user docs)
> http://tinkerpop.apache.org/docs/3.2.1/upgrade/ (upgrade docs)
> http://tinkerpop.apache.org/javadocs/3.2.1/core/ (core javadoc)
> http://tinkerpop.apache.org/javadocs/3.2.1/full/ (full javadoc)
>
> The tag in Apache Git can be found here:
>
>
> https://git-wip-us.apache.org/repos/asf?p=tinkerpop.git;a=tag;h=c5a9e2815e76f044e6b33b773b6bb0bb048270cc
>
> The release notes are available here:
>
> https://github.com/apache/tinkerpop/blob/3.2.1/CHANGELOG.asciidoc#release-3-2-1
>
> The [VOTE] will be open for the next 72 hours --- closing Friday (July 22,
> 2016) at 9:30 am EST.
>
> My vote is +1.
>
> Thank you very much,
> Stephen
>

[VOTE] TinkerPop 3.2.1 Release

[Stephen Mallette]

Hello,

We are happy to announce that TinkerPop 3.2.1 is ready for release - note
the lack of "-incubating" everywhere.  :)

The release artifacts can be found at this location:
https://dist.apache.org/repos/dist/dev/tinkerpop/3.2.1/

The source distribution is provided by:
apache-tinkerpop-3.2.1-src.zip

Two binary distributions are provided for user convenience:
apache-gremlin-console-3.2.1-bin.zip
apache-gremlin-server-3.2.1-bin.zip

The GPG key used to sign the release artifacts is available at:
https://dist.apache.org/repos/dist/dev/tinkerpop/KEYS

The online docs can be found here:
http://tinkerpop.apache.org/docs/3.2.1/reference/ (user docs)
http://tinkerpop.apache.org/docs/3.2.1/upgrade/ (upgrade docs)
http://tinkerpop.apache.org/javadocs/3.2.1/core/ (core javadoc)
http://tinkerpop.apache.org/javadocs/3.2.1/full/ (full javadoc)

The tag in Apache Git can be found here:

https://git-wip-us.apache.org/repos/asf?p=tinkerpop.git;a=tag;h=c5a9e2815e76f044e6b33b773b6bb0bb048270cc

The release notes are available here:
https://github.com/apache/tinkerpop/blob/3.2.1/CHANGELOG.asciidoc#release-3-2-1

The [VOTE] will be open for the next 72 hours --- closing Friday (July 22,
2016) at 9:30 am EST.

My vote is +1.

Thank you very much,
Stephen