DO NOT REPLY [Bug 36155] - tomcat chooses wrong host if using mod_jk
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36155. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36155 --- Additional Comments From [EMAIL PROTECTED] 2007-03-03 00:40 --- I discovered, that calling byteC.recycle() also resets the Encoding that might have been set. But actually the setEncoding() method is used nowhere. And calling byteC.reset() doesn't work, because the reset()-method leaves the ByteChunk in an illegal state: the array-pointer is set to null, but the internal isSet which controlls the result of isNull() is not reset to false. I'm quite unhappy with the class MessageBytes. For example setInt/setLong also forget to clear the char-buffer. toBytes() ignores the charset. In many cases i discovered strange handeling of non-ASCII characters. So i don't aim to clean it up. There are too many side-effects that might be hurt by any modification. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE] Release build 5.5.23
Filip Hanik - Dev Lists wrote: Candidate binaries are available here: http://people.apache.org/~fhanik/tomcat/tomcat-5.5/v5.5.23/ According to the (slightly) updated release process, the 5.5.23 tag is: [ ] Broken [ ] Alpha [ ] Beta [ X] Stable Cheers Jean-Frederic Filip - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r514117 - in /tomcat/connectors/trunk/jk/xdocs/news: 20041100.xml 20050101.xml 20060101.xml 20070301.xml
Author: jfclere Date: Sat Mar 3 02:18:29 2007 New Revision: 514117 URL: http://svn.apache.org/viewvc?view=revrev=514117 Log: Arrange anchor and add a note on the vulnerability. Modified: tomcat/connectors/trunk/jk/xdocs/news/20041100.xml tomcat/connectors/trunk/jk/xdocs/news/20050101.xml tomcat/connectors/trunk/jk/xdocs/news/20060101.xml tomcat/connectors/trunk/jk/xdocs/news/20070301.xml Modified: tomcat/connectors/trunk/jk/xdocs/news/20041100.xml URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/xdocs/news/20041100.xml?view=diffrev=514117r1=514116r2=514117 == --- tomcat/connectors/trunk/jk/xdocs/news/20041100.xml (original) +++ tomcat/connectors/trunk/jk/xdocs/news/20041100.xml Sat Mar 3 02:18:29 2007 @@ -23,6 +23,7 @@ -- a name=20041224.1 h317 December - JK-1.2.8 released/h3 +/a pThe Apache Jakarta Tomcat team is proud to announce the immediate availability of Jakarta Tomcat Connectors 1.2.8. /p @@ -33,10 +34,10 @@ a href=http://issues.apache.org/bugzilla/enter_bug.cgi?product=Tomcat%205;Bugzilla/a Bug Report. When entering bug select bNative:JK/b Component. /p -/a hr size=1 noshade=noshade / a name=20041218.1 h317 December - JK-1.2.8-rc-1 released/h3 +/a pThe Apache Jakarta Tomcat team is proud to announce the immediate availability of Jakarta Tomcat Connectors 1.2.8-rc-1 (Relase Canditate 1). /p @@ -51,10 +52,10 @@ a href=http://issues.apache.org/bugzilla/enter_bug.cgi?product=Tomcat%205;Bugzilla/a Bug Report. When entering bug select bNative:JK/b Component. /p -/a hr size=1 noshade=noshade / a name=20041213.1 h313 December - JK-1.2.7-beta-3 released/h3 +/a pThe Apache Jakarta Tomcat team is proud to announce the immediate availability of Jakarta Tomcat Connectors 1.2.7-beta-3. The release contains a fix to few configuration problems detected with JK-1.2.7-beta-2 version. @@ -70,10 +71,10 @@ a href=http://issues.apache.org/bugzilla/enter_bug.cgi?product=Tomcat%205;Bugzilla/a Bug Report. When entering bug select bNative:JK/b Component. /p -/a hr size=1 noshade=noshade / a name=20041207.1 h37 December - JK-1.2.7-beta-2 released/h3 +/a pThe Apache Jakarta Tomcat team is proud to announce the immediate availability of Jakarta Tomcat Connectors 1.2.7-beta-2. The release contains a fix to few compilation problems detected with JK-1.2.7-beta version. This release also introduces a new @@ -90,11 +91,11 @@ a href=http://issues.apache.org/bugzilla/enter_bug.cgi?product=Tomcat%205;Bugzilla/a Bug Report. When entering bug select bNative:JK/b Component. /p -/a hr size=1 noshade=noshade / a name=20041130.1 h330 November - JK-1.2.7-beta released/h3 +/a pThe Apache Jakarta Tomcat team is proud to announce the immediate availability of Jakarta Tomcat Connectors 1.2.7-beta. The release contains a significant number of bug fixes and new features. @@ -115,12 +116,12 @@ a href=http://issues.apache.org/bugzilla/enter_bug.cgi?product=Tomcat%205;Bugzilla/a Bug Report. When entering bug select bNative:JK/b Component. /p -/a hr size=1 noshade=noshade / a name=20041115.1 h315 November - JK2 is officially unsupported/h3 +/a pJK2 has been put in maintainer mode and no further development will take place. The reason for shutting down JK2 development was the lack of developers interest. Other reason was lack of users interest in adopting JK2, caused by configuration @@ -137,7 +138,6 @@ pJK will be fully supported for all other web servers. The next JK release is planned for the end of November. Lots of code from JK2 has been ported to JK /p -/a hr size=1 noshade=noshade / /section Modified: tomcat/connectors/trunk/jk/xdocs/news/20050101.xml URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/xdocs/news/20050101.xml?view=diffrev=514117r1=514116r2=514117 == --- tomcat/connectors/trunk/jk/xdocs/news/20050101.xml (original) +++ tomcat/connectors/trunk/jk/xdocs/news/20050101.xml Sat Mar 3 02:18:29 2007 @@ -23,6 +23,7 @@ -- a name=20051108.1 h38 November - JK-1.2.15 released/h3 +/a pThe Apache Tomcat team is proud to announce the immediate availability of Jakarta Tomcat Connectors 1.2.15. This is Stable release and it contains few bug fixes found in 1.2.14 version. @@ -34,11 +35,11 @@ a href=http://issues.apache.org/bugzilla/enter_bug.cgi?product=Tomcat%205;Bugzilla/a Bug Report. When entering bug select bNative:JK/b Component. /p -/a hr size=1 noshade=noshade / a name=20050713.1 h313 July - JK-1.2.14 released/h3 +/a pThe Apache Tomcat team is proud to announce the immediate availability of Jakarta Tomcat Connectors 1.2.14. This is Stable release and it contains few bug fixes found in 1.2.13 version. @@ -50,10 +51,10 @@ a href=http://issues.apache.org/bugzilla/enter_bug.cgi?product=Tomcat%205;Bugzilla/a Bug Report. When
svn commit: r514123 - in /tomcat/site/trunk: docs/download-connectors.html xdocs/download-connectors.xml
Author: jfclere Date: Sat Mar 3 02:45:13 2007 New Revision: 514123 URL: http://svn.apache.org/viewvc?view=revrev=514123 Log: Remove mod_jk2 Modified: tomcat/site/trunk/docs/download-connectors.html tomcat/site/trunk/xdocs/download-connectors.xml Modified: tomcat/site/trunk/docs/download-connectors.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/download-connectors.html?view=diffrev=514123r1=514122r2=514123 == --- tomcat/site/trunk/docs/download-connectors.html (original) +++ tomcat/site/trunk/docs/download-connectors.html Sat Mar 3 02:45:13 2007 @@ -2,17 +2,17 @@ !DOCTYPE html PUBLIC -//W3C//DTD XHTML 1.0 Strict//EN http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd; html head -titleApache Tomcat - Tomcat Connectors (mod_jk, mod_jk2) Downloads/title -link type=text/css href=stylesheets/tomcat.css rel=stylesheet/ +titleApache Tomcat - Tomcat Connectors (mod_jk) Downloads/title +link rel=stylesheet href=stylesheets/tomcat.css type=text/css / /head -body bgcolor=#ff text=#00 link=#525D76 alink=#525D76 vlink=#525D76 -table border=0 width=100% cellspacing=0 +body vlink=#525D76 alink=#525D76 link=#525D76 text=#00 bgcolor=#ff +table cellspacing=0 width=100% border=0 !--PAGE HEADER-- tr td !--PROJECT LOGO-- a href=http://tomcat.apache.org/; -img src=./images/tomcat.gif align=left alt=Tomcat Logo border=0/ +img border=0 alt=Tomcat Logo align=left src=./images/tomcat.gif / /a /td td @@ -23,28 +23,28 @@ td !--APACHE LOGO-- a href=http://www.apache.org/; -img src=http://www.apache.org/images/asf-logo.gif; align=right alt=Apache Logo border=0/ +img border=0 alt=Apache Logo align=right src=http://www.apache.org/images/asf-logo.gif; / /a /td /tr /table div class=searchbox -form action=http://www.google.com/search; method=get -input value=tomcat.apache.org name=sitesearch type=hidden/ -input value=Search the Site size=25 name=q id=query type=text/ -input name=Search value=Search Site type=submit/ +form method=get action=http://www.google.com/search; +input type=hidden name=sitesearch value=tomcat.apache.org / +input type=text id=query name=q size=25 value=Search the Site / +input type=submit value=Search Site name=Search / /form /div -table border=0 width=100% cellspacing=4 +table cellspacing=4 width=100% border=0 !--HEADER SEPARATOR-- tr td colspan=2 -hr noshade= size=1/ +hr size=1 noshade= / /td /tr tr !--LEFT SIDE NAVIGATION-- -td width=20% valign=top nowrap=true +td nowrap=true valign=top width=20% p strongApache Tomcat/strong /p @@ -167,13 +167,13 @@ /ul /td !--RIGHT SIDE MAIN BODY-- -td width=80% valign=top align=left -table border=0 cellspacing=0 cellpadding=2 width=100% +td align=left valign=top width=80% +table width=100% cellpadding=2 cellspacing=0 border=0 tr td bgcolor=#525D76 -font color=#ff face=arial,helvetica,sanserif -a name=Tomcat Connectors (mod_jk, mod_jk2) Downloads -strongTomcat Connectors (mod_jk, mod_jk2) Downloads/strong +font face=arial,helvetica,sanserif color=#ff +a name=Tomcat Connectors (mod_jk) Downloads +strongTomcat Connectors (mod_jk) Downloads/strong /a /font /td @@ -190,8 +190,8 @@ encounter a problem with this mirror, please select another mirror. If all mirrors are failing, there are ibackup/i mirrors (at the end of the mirrors list) that should be -available.br/[if-any logo]a href=[link] -img align=right src=[logo] border=0/ +available.br /[if-any logo]a href=[link] +img align=right src=[logo] border=0 / /a[end]/p p form action=[location] method=get id=SelectMirror @@ -206,13 +206,13 @@ [for backup]option value=[backup][backup] (backup)/option[end] [end] /select -input type=submit value=Change/ +input type=submit value=Change / /form /p p The codeKEYS/code link links to the code signing keys used to sign the product. The codePGP/code link downloads the OpenPGP compatible signature from our main site. /p -pFor more information concerning Tomcat Connectors (mod_jk, mod_jk2), see the a href=http://tomcat.apache.org/connectors-doc/; class=nameTomcat Connectors (mod_jk, mod_jk2)/a site. /p +pFor more information concerning Tomcat Connectors (mod_jk), see the a href=http://tomcat.apache.org/connectors-doc/; class=nameTomcat Connectors (mod_jk)/a site. /p div class=links span class=link a href=http://www.apache.org/dist/tomcat/tomcat-connectors/KEYS;KEYS/a @@ -221,7 +221,7 @@ ul class=downloads li class=group div class=links -span class=labelJK 1.2 (bactively maintained/b) (b +span class=labelJK 1.2 (b a href=security-jk.htmlWARNING: Critical vulnerabilities in previous versions/a /b) /span @@ -255,53 +255,22 @@ /li /ul /li -li class=group -div class=links -span class=labelJK
Re: JK2 confusion
William A. Rowe, Jr. wrote: Since JK2 is now off the map, does it make sense to update http://www.apache.org/dist/tomcat/tomcat-connectors/ and simply remove jk2? The user could still dig these up if they wanted over at http://archive.apache.org/dist/tomcat/tomcat-connectors/ Done I have just left a note that mod_jk2 can be found in the archive area. Cheers Jean-Frederic - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [ANN] Apache Tomcat JK 1.2.21 Web Server Connector released
Hi, The Apache Tomcat team is pleased to announce the immediate availability of version 1.2.21 of the Apache Tomcat Connectors. I've just uploaded NetWare binaries to my directory: http://people.apache.org/~fuankg/mod_jk/1.2.21/ can please someone with commit rights copy them over to the release location - my commit rights got lost with the move to SVN; or can someone kindly tell me how I can receive again the needed rights? This version of mod_jk is principally a bug and security fix release. The following potential security flaw is addressed: It seems to me that with recently introduced check its no longer possible to use mod_jk without worker.properties file - was this intended? From the ChangeLog it sounds more as if the parameter is checked for proper path if exist; but the behaviour is that the worker.properties file is now mandatory. greets, Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: JK2 confusion
William A. Rowe, Jr. wrote: Since JK2 is now off the map, does it make sense to update Not even that. We are talking for more then a year for a next generation binary http(s) protocol. Almost everyone agreed that we need at least few things: 1. Encryption 2. Variable sized messages 3. Client connection close notification. Regards, -- Mladen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE] Release build 5.5.23
+1 Am 03.03.2007 um 00:23 schrieb Filip Hanik - Dev Lists: Candidate binaries are available here: http://people.apache.org/ ~fhanik/tomcat/tomcat-5.5/v5.5.23/ According to the (slightly) updated release process, the 5.5.23 tag is: [ ] Broken [ ] Alpha [ ] Beta [x ] Stable Filip - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36155] - tomcat chooses wrong host if using mod_jk
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36155. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36155 --- Additional Comments From [EMAIL PROTECTED] 2007-03-03 06:25 --- (In reply to comment #15) -1 for the patch. If the problem exists (I really doubt it), a better solution will have to be found. Simply one question: Why? setBytes() invalidates everything - except the value within charC is kept. Anyway: there might be one missing recycle call somewhere. I'm already looking for it. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 41746] - Default web application can not be changed
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=41746. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=41746 --- Additional Comments From [EMAIL PROTECTED] 2007-03-03 06:30 --- 1. define the Context in server.xml This (need to define context in server.xml when trying to deploy application as default one) isn't mentioned in your documentation describing the use of path attribute (http://tomcat.apache.org/tomcat-6.0-doc/config/context.html), so this could be a documentation bug. 2. rename your app to ROOT Consider the case when you want to change the root app - there is a loot of work you need to do. This is more of a kludge then solution. 3. define a TCHOME/conf/Catalina/localhost/ROOT.xml with a docbase pointing to your webapp I like this solution, but I don't know how will this work with my base context.xml located in META-INF folder. If I add a ROOT.xml = Context path= docBase=/lootist/ will this affect settings in context.xml(persistent manager, logging, JNDI resources availability) ? I think you should consider the case when user doesn't have access to server.xml or the directory where context files are kept. Most of the companies we work for have big concerns about security, and they allows us only the minimum access to there servers and tomcat directories. Proposal: When new app is deployed, and if path= element is found, Tomcat could create ROOT.xml pointing to the docBase of previously mentioned app. If ROOT.xml already exists, exception could be thrown. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36155] - tomcat chooses wrong host if using mod_jk
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36155. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36155 --- Additional Comments From [EMAIL PROTECTED] 2007-03-03 06:57 --- So in org.apache.coyote.Request.recylce(), this.localNameMB.recycle() is not called. If i add that call, the problem is gone too (my first patch has been reverted before testing). The problem is: remoteAddrMB.recycle(), remoteHostMB.recycle(), localAddrMB.recycle() is also not called. And i have no clue why not or is it should actually be called. Anyway: At least localNameMB gets reused without being recycled. So the internal charC contains an old value. setBytes() doesn't clear internal the charC-cache. toChars() reuses the old value. Hence the bug. I admit, that the semantics of the MessageBytes class are a ridle to me. I don't know, why setBytes() shouldn't invalidate the charC cache (even though it invalidates all other cached values). Somebody please explain the semantics of this class to me! And decide, whether setBytes() should clear charC, or not. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36155] - tomcat chooses wrong host if using mod_jk
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36155. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36155 --- Additional Comments From [EMAIL PROTECTED] 2007-03-03 07:04 --- Additional information: the value of localNameMB is set in AjpProcessor.prepareRequest() (line 645) by calling requestHandlerMessage.getBytes(request.localName()). This getBytes method calls setBytes() of localNameMB. Above that line, remoteAddrMB and remoteHostMB are also set with the same method. And they also might not have been recycled. I don't know for sure. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE] Release build 5.5.23
Filip Hanik - Dev Lists wrote: [ ] Broken [ ] Alpha [ ] Beta [X] Stable Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r514174 - /tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/http/MimeHeaders.java
Author: markt Date: Sat Mar 3 07:48:33 2007 New Revision: 514174 URL: http://svn.apache.org/viewvc?view=revrev=514174 Log: Tabs - 8 spaces. No functional change. Modified: tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/http/MimeHeaders.java Modified: tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/http/MimeHeaders.java URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/http/MimeHeaders.java?view=diffrev=514174r1=514173r2=514174 == --- tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/http/MimeHeaders.java (original) +++ tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/http/MimeHeaders.java Sat Mar 3 07:48:33 2007 @@ -101,7 +101,7 @@ * The header fields. */ private MimeHeaderField[] headers = new - MimeHeaderField[DEFAULT_HEADER_SIZE]; +MimeHeaderField[DEFAULT_HEADER_SIZE]; /** * The current number of header fields. @@ -126,10 +126,10 @@ * Clears all header fields. */ public void clear() { - for (int i = 0; i count; i++) { - headers[i].recycle(); - } - count = 0; +for (int i = 0; i count; i++) { +headers[i].recycle(); +} +count = 0; } /** @@ -153,7 +153,7 @@ * Returns the current number of header fields. */ public int size() { - return count; +return count; } /** @@ -161,7 +161,7 @@ * This may be used to iterate through all header fields. */ public MessageBytes getName(int n) { - return n = 0 n count ? headers[n].getName() : null; +return n = 0 n count ? headers[n].getName() : null; } /** @@ -169,21 +169,21 @@ * This may be used to iterate through all header fields. */ public MessageBytes getValue(int n) { - return n = 0 n count ? headers[n].getValue() : null; +return n = 0 n count ? headers[n].getValue() : null; } /** Find the index of a header with the given name. */ public int findHeader( String name, int starting ) { - // We can use a hash - but it's not clear how much - // benefit you can get - there is an overhead - // and the number of headers is small (4-5 ?) - // Another problem is that we'll pay the overhead - // of constructing the hashtable +// We can use a hash - but it's not clear how much +// benefit you can get - there is an overhead +// and the number of headers is small (4-5 ?) +// Another problem is that we'll pay the overhead +// of constructing the hashtable - // A custom search tree may be better +// A custom search tree may be better for (int i = starting; i count; i++) { - if (headers[i].getName().equalsIgnoreCase(name)) { +if (headers[i].getName().equalsIgnoreCase(name)) { return i; } } @@ -198,11 +198,11 @@ * that multiple fields with that name exist in this header. */ public Enumeration names() { - return new NamesEnumerator(this); +return new NamesEnumerator(this); } public Enumeration values(String name) { - return new ValuesEnumerator(this, name); +return new ValuesEnumerator(this, name); } // Adding headers @@ -213,54 +213,54 @@ * field has not had its name or value initialized. */ private MimeHeaderField createHeader() { - MimeHeaderField mh; - int len = headers.length; - if (count = len) { - // expand header list array - MimeHeaderField tmp[] = new MimeHeaderField[count * 2]; - System.arraycopy(headers, 0, tmp, 0, len); - headers = tmp; - } - if ((mh = headers[count]) == null) { - headers[count] = mh = new MimeHeaderField(); - } - count++; - return mh; +MimeHeaderField mh; +int len = headers.length; +if (count = len) { +// expand header list array +MimeHeaderField tmp[] = new MimeHeaderField[count * 2]; +System.arraycopy(headers, 0, tmp, 0, len); +headers = tmp; +} +if ((mh = headers[count]) == null) { +headers[count] = mh = new MimeHeaderField(); +} +count++; +return mh; } /** Create a new named header , return the MessageBytes - container for the new value +container for the new value */ public MessageBytes addValue( String name ) { - MimeHeaderField mh = createHeader(); - mh.getName().setString(name); - return mh.getValue(); + MimeHeaderField mh = createHeader(); +mh.getName().setString(name); +return mh.getValue(); } /** Create a new named header using un-translated byte[]. -
svn commit: r514176 - in /tomcat/tc6.0.x/trunk/java/org/apache: coyote/Request.java tomcat/util/http/MimeHeaders.java
Author: markt Date: Sat Mar 3 07:56:14 2007 New Revision: 514176 URL: http://svn.apache.org/viewvc?view=revrev=514176 Log: Port fix from TC5. As per RFC2616, requests with multiple content-length headers are invalid. Modified: tomcat/tc6.0.x/trunk/java/org/apache/coyote/Request.java tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/http/MimeHeaders.java Modified: tomcat/tc6.0.x/trunk/java/org/apache/coyote/Request.java URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/coyote/Request.java?view=diffrev=514176r1=514175r2=514176 == --- tomcat/tc6.0.x/trunk/java/org/apache/coyote/Request.java (original) +++ tomcat/tc6.0.x/trunk/java/org/apache/coyote/Request.java Sat Mar 3 07:56:14 2007 @@ -294,7 +294,7 @@ public long getContentLengthLong() { if( contentLength -1 ) return contentLength; -MessageBytes clB = headers.getValue(content-length); +MessageBytes clB = headers.getUniqueValue(content-length); contentLength = (clB == null || clB.isNull()) ? -1 : clB.getLong(); return contentLength; Modified: tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/http/MimeHeaders.java URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/http/MimeHeaders.java?view=diffrev=514176r1=514175r2=514176 == --- tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/http/MimeHeaders.java (original) +++ tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/http/MimeHeaders.java Sat Mar 3 07:56:14 2007 @@ -293,6 +293,25 @@ return null; } +/** + * Finds and returns a unique header field with the given name. If no such + * field exists, null is returned. If the specified header field is not + * unique then an [EMAIL PROTECTED] IllegalArgumentException} is thrown. + */ +public MessageBytes getUniqueValue(String name) { +MessageBytes result = null; +for (int i = 0; i count; i++) { +if (headers[i].getName().equalsIgnoreCase(name)) { +if (result == null) { +result = headers[i].getValue(); +} else { +throw new IllegalArgumentException(); +} +} +} +return result; +} + // bad shortcut - it'll convert to string ( too early probably, // encoding is guessed very late ) public String getHeader(String name) { - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r514179 - in /tomcat/tc6.0.x/trunk: java/org/apache/catalina/servlets/DefaultServlet.java webapps/docs/changelog.xml
Author: markt Date: Sat Mar 3 08:03:11 2007 New Revision: 514179 URL: http://svn.apache.org/viewvc?view=revrev=514179 Log: Port fix for bug 41666. Correct handling of boundary conditions for If-Unmodified-Since and If-Modified-Since headers. Patch provided by Suzuki Yuichiro. Update changelog. Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/DefaultServlet.java tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/DefaultServlet.java URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/DefaultServlet.java?view=diffrev=514179r1=514178r2=514179 == --- tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/DefaultServlet.java (original) +++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/DefaultServlet.java Sat Mar 3 08:03:11 2007 @@ -1567,7 +1567,7 @@ // If an If-None-Match header has been specified, if modified since // is ignored. if ((request.getHeader(If-None-Match) == null) - (lastModified = headerValue + 1000)) { + (lastModified headerValue + 1000)) { // The entity has not been modified since the date // specified by the client. This is not an error case. response.setStatus(HttpServletResponse.SC_NOT_MODIFIED); @@ -1658,7 +1658,7 @@ long lastModified = resourceAttributes.getLastModified(); long headerValue = request.getDateHeader(If-Unmodified-Since); if (headerValue != -1) { -if ( lastModified (headerValue + 1000)) { +if ( lastModified = (headerValue + 1000)) { // The entity has not been modified since the date // specified by the client. This is not an error case. response.sendError(HttpServletResponse.SC_PRECONDITION_FAILED); Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?view=diffrev=514179r1=514178r2=514179 == --- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original) +++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Sat Mar 3 08:03:11 2007 @@ -18,6 +18,11 @@ subsection name=Catalina changelog fix +bug41666/bug Correct handling of boundary conditions for +If-Unmodified-Since and If-Modified-Since headers. Patch provided by +Suzuki Yuichiro. (markt) + /fix + fix bug41739/bug Correct handling of servlets with a load-on-startup value of zero. These are now the first servlets to be started. (markt) /fix @@ -33,6 +38,9 @@ when the serviet is reading/writing from the input/output streams The flag is code-Dorg.apache.tomcat.util.net.NioSelectorShared=true/code /update + fix +Requests with multiple content-length headers are now rejected. (markt) + /fix /changelog /subsection subsection name=Webapps - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r514180 - in /tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup: LocalStrings_es.properties LocalStrings_fr.properties
Author: markt Date: Sat Mar 3 08:12:41 2007 New Revision: 514180 URL: http://svn.apache.org/viewvc?view=revrev=514180 Log: Port partial fix for bug 41655. Update some of the translations and fix a few obvious typos. Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/LocalStrings_es.properties tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/LocalStrings_fr.properties Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/LocalStrings_es.properties URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/LocalStrings_es.properties?view=diffrev=514180r1=514179r2=514180 == --- tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/LocalStrings_es.properties (original) +++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/LocalStrings_es.properties Sat Mar 3 08:12:41 2007 @@ -1,8 +1,8 @@ contextConfig.applicationClose=Error durante el cierre del archivo web.xml de la aplicación -contextConfig.applicationConfig=Errror de configuración en el archivo web.xml de la aplicación +contextConfig.applicationConfig=Error de configuración en el archivo web.xml de la aplicación contextConfig.applicationListener=Excepción durante la creación de la clase de escucha (listener) {0} -contextConfig.applicationMissing=Falta el archivo web.xml de la aplicaciónb. Utilizando los parámetros por defecto -contextConfig.applicationParse=Error de evaluación (parse) en el archivo web.xml de la aplicación +contextConfig.applicationMissing=Falta el archivo web.xml de la aplicación. Utilizando los parámetros por defecto +contextConfig.applicationParse=Error de evaluación (parse) en el archivo web.xml de la aplicación a {0} contextConfig.applicationPosition=Se ha producido en la línea {0} columna {1} contextConfig.authenticatorConfigured=Configuración de un autentificador (authenticator) para el método {0} contextConfig.authenticatorInstantiate=Imposible de instanciar un autenticador (authenticator) para la clase {0} @@ -22,9 +22,9 @@ contextConfig.role.runas=ATENCIÓN: El nombre de papel de seguridad {0} es usado en un run-as sin haber sido definido en security-role contextConfig.start=ContextConfig: Tratamiento del START contextConfig.stop=ContextConfig: Tratamiento del STOP -contextConfig.tldEntryException=Excepción durante el tratamiento de la TLD {0} en el JAR indicado por la trayectoria de recurso {1} -contextConfig.tldFileException=Excepción durante el tratamiento de la TLD indicada por la trayectoria de recurso {0} -contextConfig.tldJarException=Excepción durante el tratamiento del JAR indicado por la trayectoria de recurso {0} +contextConfig.tldEntryException=Excepción durante el tratamiento de la TLD {0} en el JAR indicado por la trayectoria de recurso {1} en contexto {2} +contextConfig.tldFileException=Excepción durante el tratamiento de la TLD indicada por la trayectoria de recurso {0} en contexto {1} +contextConfig.tldJarException=Excepción durante el tratamiento del JAR indicado por la trayectoria de recurso {0} en contexto {1} contextConfig.tldResourcePath=Trayectoria de recurso TLD {0} inválida contextConfig.unavailable=Esta aplicación está marcada como no disponible debido a los errores precedentes embedded.alreadyStarted=El servicio embebido (embedded service) ya ha sido arrancado Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/LocalStrings_fr.properties URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/LocalStrings_fr.properties?view=diffrev=514180r1=514179r2=514180 == --- tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/LocalStrings_fr.properties (original) +++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/LocalStrings_fr.properties Sat Mar 3 08:12:41 2007 @@ -2,7 +2,7 @@ contextConfig.applicationConfig=Erreur de configuration dans le fichier web.xml de l''application contextConfig.applicationListener=Exception lors de la création de la classe d''écoute (listener) {0} contextConfig.applicationMissing=Le fichier web.xml de l''application est absent, utilisation des paramêtres par défaut -contextConfig.applicationParse=Erreur d''évaluation (parse) dans le fichier web.xml de l''application +contextConfig.applicationParse=Erreur d''évaluation (parse) dans le fichier web.xml de l''application à {0} contextConfig.applicationPosition=S''est produite à la ligne {0} colonne {1} contextConfig.authenticatorConfigured=Configuration d''un authentificateur (authenticator) pour la méthode {0} contextConfig.authenticatorInstantiate=Impossible d''instancier un authentificateur (authenticator) pour la classe {0} @@ -22,9 +22,9 @@ contextConfig.role.runas=ATTENTION: Le nom de rôle de sécurité {0} est utilisé dans un run-as sans avoir été défini dans security-role
svn commit: r514181 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/MemoryRealm.java
Author: markt Date: Sat Mar 3 08:18:50 2007 New Revision: 514181 URL: http://svn.apache.org/viewvc?view=revrev=514181 Log: Code clean-up. No functional change. Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/MemoryRealm.java Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/MemoryRealm.java URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/MemoryRealm.java?view=diffrev=514181r1=514180r2=514181 == --- tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/MemoryRealm.java (original) +++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/MemoryRealm.java Sat Mar 3 08:18:50 2007 @@ -24,7 +24,6 @@ import java.util.ArrayList; import java.util.HashMap; import java.util.Map; -import org.apache.catalina.Container; import org.apache.catalina.LifecycleException; import org.apache.catalina.util.StringManager; import org.apache.juli.logging.Log; @@ -54,12 +53,6 @@ /** - * The Container with which this Realm is associated. - */ -private Container container = null; - - -/** * The Digester we will use to process in-memory database files. */ private static Digester digester = null; @@ -97,12 +90,6 @@ */ private static StringManager sm = StringManager.getManager(Constants.Package); - - -/** - * Has this component been started? - */ -private boolean started = false; // - Properties - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r514182 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/realm/MemoryRealm.java webapps/docs/changelog.xml
Author: markt Date: Sat Mar 3 08:22:48 2007 New Revision: 514182 URL: http://svn.apache.org/viewvc?view=revrev=514182 Log: Fix bug 41752. Correct error message on exception in MemoryRealm. Patch provided by Ales Milan. Modified: tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/realm/MemoryRealm.java tomcat/container/tc5.5.x/webapps/docs/changelog.xml Modified: tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/realm/MemoryRealm.java URL: http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/realm/MemoryRealm.java?view=diffrev=514182r1=514181r2=514182 == --- tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/realm/MemoryRealm.java (original) +++ tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/realm/MemoryRealm.java Sat Mar 3 08:22:48 2007 @@ -301,7 +301,8 @@ digester.parse(file); } } catch (Exception e) { -throw new LifecycleException(memoryRealm.readXml, e); +throw new LifecycleException +(sm.getString(memoryRealm.readXml), e); } finally { digester.reset(); } Modified: tomcat/container/tc5.5.x/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/webapps/docs/changelog.xml?view=diffrev=514182r1=514181r2=514182 == --- tomcat/container/tc5.5.x/webapps/docs/changelog.xml (original) +++ tomcat/container/tc5.5.x/webapps/docs/changelog.xml Sat Mar 3 08:22:48 2007 @@ -34,6 +34,10 @@ bug41739/bug Correct handling of servlets with a load-on-startup value of zero. These are now the first servlets to be started. (markt) /fix + fix +bug41752/bug Correct error message on exception in MemoryRealm. +(markt) + /fix /changelog /subsection subsection name=Coyote - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r514183 - in /tomcat/tc6.0.x/trunk: java/org/apache/catalina/realm/MemoryRealm.java webapps/docs/changelog.xml
Author: markt Date: Sat Mar 3 08:24:08 2007 New Revision: 514183 URL: http://svn.apache.org/viewvc?view=revrev=514183 Log: Port fix for bug 41752. Correct error message on exception in MemoryRealm. Patch provided by Ales Milan. Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/MemoryRealm.java tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/MemoryRealm.java URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/MemoryRealm.java?view=diffrev=514183r1=514182r2=514183 == --- tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/MemoryRealm.java (original) +++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/MemoryRealm.java Sat Mar 3 08:24:08 2007 @@ -301,7 +301,8 @@ digester.parse(file); } } catch (Exception e) { -throw new LifecycleException(memoryRealm.readXml, e); +throw new LifecycleException +(sm.getString(memoryRealm.readXml), e); } finally { digester.reset(); } Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?view=diffrev=514183r1=514182r2=514183 == --- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original) +++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Sat Mar 3 08:24:08 2007 @@ -26,6 +26,10 @@ bug41739/bug Correct handling of servlets with a load-on-startup value of zero. These are now the first servlets to be started. (markt) /fix + fix +bug41752/bug Correct error message on exception in MemoryRealm. +(markt) + /fix /changelog /subsection subsection name=Coyote - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 41752] - Wrong message on exception in MemoryRealm
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=41752. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=41752 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2007-03-03 08:24 --- This is fuxed in svn and will be included in 5.5.23 and 6.0.11 onwards. Thanks for the patch. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r514193 - /tomcat/container/tc5.5.x/webapps/docs/changelog.xml
Author: markt Date: Sat Mar 3 09:14:07 2007 New Revision: 514193 URL: http://svn.apache.org/viewvc?view=revrev=514193 Log: Changes should now be against 5.5.24 Modified: tomcat/container/tc5.5.x/webapps/docs/changelog.xml Modified: tomcat/container/tc5.5.x/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/webapps/docs/changelog.xml?view=diffrev=514193r1=514192r2=514193 == --- tomcat/container/tc5.5.x/webapps/docs/changelog.xml (original) +++ tomcat/container/tc5.5.x/webapps/docs/changelog.xml Sat Mar 3 09:14:07 2007 @@ -14,6 +14,17 @@ /properties body +section name=Tomcat 5.5.24 (fhanik) + subsection name=Catalina +changelog + fix +bug41752/bug Correct error message on exception in MemoryRealm. +(markt) + /fix +/changelog + /subsection +/section + section name=Tomcat 5.5.23 (fhanik) subsection name=Catalina changelog - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36155] - tomcat chooses wrong host if using mod_jk
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36155. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36155 --- Additional Comments From [EMAIL PROTECTED] 2007-03-03 14:45 --- (In reply to comment #17) And decide, whether setBytes() should clear charC, or not. It seems you're eager to contribute and stuff, and I think that's good, but if I said -1 to your patch, this means the answer to this question is no. This will cause problems, and is also inefficient. I think this is a special case with AJP, where recycle should possibly be called on the localName MessageBytes before reading the localName field (it should be fairly explicit that the localName/Addr are otherwise never recycled in the Request object). This is indeed a special case with the IP vhost feature (which IMO is not a very good feature, but it's another story). -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE] Release build 5.5.23
When I try to run 5.5.23 with JDK 1.5.0_08 under windows, I get this error: SEVERE: An incompatible version 0.0.0 of the Apache Tomcat Native library is installed, while Tomcat requires version 1.1.3 Mar 3, 2007 3:43:27 PM org.apache.catalina.core.AprLifecycleListener lifecycleEvent INFO: An older version 0.0.0 of the Apache Tomcat Native library is installed, while Tomcat recommends version greater than 1.1.4 Is this Tomcat Native thing now required? It wasn't in 5.5.22 (the test build anyhow). Is it normal to change the requirements for how the system operates on a point release? Filip Hanik - Dev Lists wrote: Candidate binaries are available here: http://people.apache.org/~fhanik/tomcat/tomcat-5.5/v5.5.23/ According to the (slightly) updated release process, the 5.5.23 tag is: [ ] Broken [ ] Alpha [ ] Beta [ ] Stable Filip - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- George Sexton MH Software, Inc. Voice: +1 303 438 9585 URL: http://www.mhsoftware.com/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36155] - tomcat chooses wrong host if using mod_jk
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36155. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36155 --- Additional Comments From [EMAIL PROTECTED] 2007-03-03 15:51 --- Do you understand, why we need to recycle the localName? (short reason: two ajp-requests with different localName over same AJP connection) So i have the feeling, that you want this fix to be AJP specific. I will try to fix it in that way. I tried to fix AjpProcessor/AjpAprProcessor. But the fix only worked, when i did it in JkCoyoteHandler. I simply changed the code from request.recycle(); to request.recycle(); request.localName().recycle(); I don't feel well leaving the other 3 fields (remoteAddr, remoteHost, localAddr) unrecycled. Somehow i feel, like this issue also applies to the other fields. But i don't have enough knowledge to be sure. So i leave this up to you. Now i will attach a new patch. Maybe you like it :-) -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36155] - tomcat chooses wrong host if using mod_jk
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36155. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36155 [EMAIL PROTECTED] changed: What|Removed |Added Attachment #19659|0 |1 is obsolete|| --- Additional Comments From [EMAIL PROTECTED] 2007-03-03 15:53 --- Created an attachment (id=19660) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=19660action=view) new patch -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 41757] New: - JK Apache HowTo documentation doesn't explain the --enable-prefork option of the configure script
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=41757. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=41757 Summary: JK Apache HowTo documentation doesn't explain the -- enable-prefork option of the configure script Product: Tomcat 5 Version: 5.5.20 Platform: Other OS/Version: other Status: NEW Severity: normal Priority: P2 Component: Native:JK AssignedTo: tomcat-dev@jakarta.apache.org ReportedBy: [EMAIL PROTECTED] Hi, The changelog of JK shows that in version 1.2.11, pero added the --enable- prefork configure option to the JK documentation. Although this option seems to be valid (at least configure shows ...Enabling Prefork mode... when I set it), it's not documented anywhere. I don't even know if the fact of specifying it, does anything at all. I'm using the latest JK 1.2.21. Thank you! -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE] Release build 5.5.23
Is this Tomcat Native thing now required? It wasn't in 5.5.22 (the test build anyhow). Is it normal to change the requirements for how the system operates on a point release? It's not required for 6.0.10 and i wouldn't want it to be required. I don't like too much native stuff. signature.asc Description: OpenPGP digital signature
DO NOT REPLY [Bug 41758] New: - after creating CA tomcat is asking for restart
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=41758. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=41758 Summary: after creating CA tomcat is asking for restart Product: Tomcat 5 Version: Unknown Platform: Other OS/Version: other Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: tomcat-dev@jakarta.apache.org ReportedBy: [EMAIL PROTECTED] After creating client Authentication using Certificate Authentication tomcat is asking for restart but in real Scenario it should not ask for restart -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: JK2 confusion
Mladen Turk wrote: Not even that. We are talking for more then a year for a next generation binary http(s) protocol. Almost everyone agreed that we need at least few things: 1. Encryption 2. Variable sized messages 3. Client connection close notification. Talk about a hijaak :) I'm going to argue; 'no', but let me offer my rational... 1. These features are available through the HTTP connector which is easier to troubleshoot (sniff) and already standardized. 2. The HTTP connector was somewhat neglected; to ensure that it is completely conformant needs more eyes, not fewer. More effort at AJP 1.x is less effort towards HTTP/1.1 conformance. (This is not only a developer issue, but speaks to how well exercised the HTTP connector is with many users choosing AJP and not seeing or reporting specific quirks.) 3. We would honestly win more bandwidth from fully supporting the content encoding deflate from tomcat to the proxy server than from the few bytes saved with AJP. And SSL Encryption + deflate provided by TLS today will already give you this win, so binary protocol is really not that significant (OpenSSL 0.9.8 supports it, don't ask me if JSSE does.) 4. Waka. Why reinvent a wheel in motion? With the new focus at the httpd Amsterdam code to break apart http from apache, we are adding wiggle room for some to come behind and code to Roy's binary http protocol plan. The difference? Waka when done will be an accepted spec, while I don't see that ever happening to AJP. :) That said, those are technical arguments against but I have no vote here - I'll leave it to you all to weight these against your itches and designs. Bill - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r514368 - in /tomcat/connectors/trunk/jk/xdocs: ajp/project.xml generic_howto/project.xml index.xml miscellaneous/project.xml news/project.xml project.xml reference/project.xml webserver_h
Author: rjung Date: Sat Mar 3 23:47:48 2007 New Revision: 514368 URL: http://svn.apache.org/viewvc?view=revrev=514368 Log: Add news page for 2007 to the menue. Modified: tomcat/connectors/trunk/jk/xdocs/ajp/project.xml tomcat/connectors/trunk/jk/xdocs/generic_howto/project.xml tomcat/connectors/trunk/jk/xdocs/index.xml tomcat/connectors/trunk/jk/xdocs/miscellaneous/project.xml tomcat/connectors/trunk/jk/xdocs/news/project.xml tomcat/connectors/trunk/jk/xdocs/project.xml tomcat/connectors/trunk/jk/xdocs/reference/project.xml tomcat/connectors/trunk/jk/xdocs/webserver_howto/project.xml Modified: tomcat/connectors/trunk/jk/xdocs/ajp/project.xml URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/xdocs/ajp/project.xml?view=diffrev=514368r1=514367r2=514368 == --- tomcat/connectors/trunk/jk/xdocs/ajp/project.xml (original) +++ tomcat/connectors/trunk/jk/xdocs/ajp/project.xml Sat Mar 3 23:47:48 2007 @@ -49,6 +49,7 @@ /menu menu name=News +item name=2007 href=../news/20070301.html/ item name=2006 href=../news/20060101.html/ item name=2005 href=../news/20050101.html/ item name=2004 href=../news/20041100.html/ Modified: tomcat/connectors/trunk/jk/xdocs/generic_howto/project.xml URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/xdocs/generic_howto/project.xml?view=diffrev=514368r1=514367r2=514368 == --- tomcat/connectors/trunk/jk/xdocs/generic_howto/project.xml (original) +++ tomcat/connectors/trunk/jk/xdocs/generic_howto/project.xml Sat Mar 3 23:47:48 2007 @@ -49,6 +49,7 @@ /menu menu name=News +item name=2007 href=../news/20070301.html/ item name=2006 href=../news/20060101.html/ item name=2005 href=../news/20050101.html/ item name=2004 href=../news/20041100.html/ Modified: tomcat/connectors/trunk/jk/xdocs/index.xml URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/xdocs/index.xml?view=diffrev=514368r1=514367r2=514368 == --- tomcat/connectors/trunk/jk/xdocs/index.xml (original) +++ tomcat/connectors/trunk/jk/xdocs/index.xml Sat Mar 3 23:47:48 2007 @@ -215,6 +215,8 @@ /p ul +lia href=news/20070301.htmlb2007/b/a +/li lia href=news/20060101.htmlb2006/b/a /li lia href=news/20050101.htmlb2005/b/a Modified: tomcat/connectors/trunk/jk/xdocs/miscellaneous/project.xml URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/xdocs/miscellaneous/project.xml?view=diffrev=514368r1=514367r2=514368 == --- tomcat/connectors/trunk/jk/xdocs/miscellaneous/project.xml (original) +++ tomcat/connectors/trunk/jk/xdocs/miscellaneous/project.xml Sat Mar 3 23:47:48 2007 @@ -49,6 +49,7 @@ /menu menu name=News +item name=2007 href=../news/20070301.html/ item name=2006 href=../news/20060101.html/ item name=2005 href=../news/20050101.html/ item name=2004 href=../news/20041100.html/ Modified: tomcat/connectors/trunk/jk/xdocs/news/project.xml URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/xdocs/news/project.xml?view=diffrev=514368r1=514367r2=514368 == --- tomcat/connectors/trunk/jk/xdocs/news/project.xml (original) +++ tomcat/connectors/trunk/jk/xdocs/news/project.xml Sat Mar 3 23:47:48 2007 @@ -49,6 +49,7 @@ /menu menu name=News +item name=2007 href=../news/20070301.html/ item name=2006 href=../news/20060101.html/ item name=2005 href=../news/20050101.html/ item name=2004 href=../news/20041100.html/ Modified: tomcat/connectors/trunk/jk/xdocs/project.xml URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/xdocs/project.xml?view=diffrev=514368r1=514367r2=514368 == --- tomcat/connectors/trunk/jk/xdocs/project.xml (original) +++ tomcat/connectors/trunk/jk/xdocs/project.xml Sat Mar 3 23:47:48 2007 @@ -49,6 +49,7 @@ /menu menu name=News +item name=2007 href=news/20070301.html/ item name=2006 href=news/20060101.html/ item name=2005 href=news/20050101.html/ item name=2004 href=news/20041100.html/ Modified: