Re: TOMEE-2480: Doubt about the concept of bean

2019-03-04 Thread Gabriel Ferreira
Thank you César ;)

Em seg, 4 de mar de 2019 às 16:53, César Hernández Mendoza <
cesargu...@gmail.com> escreveu:

> Hi Gabriel,
>
> I've heard that bean is a simple class with its encapsulated methods.
>
> You are referring Java Beans
>
> https://www.oracle.com/technetwork/java/javase/documentation/spec-136004.html
> https://docs.oracle.com/javase/tutorial/javabeans/index.html
>
> >
> > In the example "bean" sounds more like a "component", because, what is
> the
> > relationship between Bean-Managed Concurrency, thread, Singleton with
> > "@path", "@get", "@post".
>
> Check for instance Enterprise Java Beans
> https://www.oracle.com/technetwork/java/index-jsp-140203.html
> https://docs.oracle.com/javaee/6/tutorial/doc/gijsz.html
>
> btw is okay ask some questions like that in the list?
>
> I don't see why not, we all are here to learn, share and contribute :)
>
>
>
> El sáb., 2 mar. 2019 a las 9:10, Gabriel Ferreira ()
> escribió:
>
> > So guys, I'm working in the translate of example/simple-rest:
> > I believe that I have not completely understood the concept of "bean",
> I've
> > heard that bean is a simple class with its encapsulated methods.
> > In the example "bean" sounds more like a "component", because, what is
> the
> > relationship between Bean-Managed Concurrency, thread, Singleton with
> > "@path", "@get", "@post".
> > So, if anyone can explain me, I will be grateful.
> > btw is okay ask some questions like that in the list?
> >
> > https://issues.apache.org/jira/browse/TOMEE-2480
> > http://tomee.apache.org/tomee-8.0/examples/simple-rest.html
> > https://github.com/apache/tomee/tree/master/examples/simple-rest
> >
> > thank you guys
> >
>
>
> --
> Atentamente:
> César Hernández Mendoza.
>


Re: JIRA permission request

2019-03-04 Thread Daniel Cunha
He is not appear on the list. Weird!
I've same issue here.

Em seg, 4 de mar de 2019 às 19:28, César Hernández Mendoza <
cesargu...@gmail.com> escreveu:

> @Jonathan or any other JIRA admin,
> Can you check please why I can't assign a ticket to a specific user: Rhuan
> account: rhuanrcoha
> I documented the issue here:
>
> https://issues.apache.org/jira/browse/TOMEE-2486?focusedCommentId=16783829&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16783829
>
>
>
> El jue., 28 feb. 2019 a las 10:29, César Hernández Mendoza (<
> cesargu...@gmail.com>) escribió:
>
> > Thank you all!
> >
> > El jue., 28 feb. 2019 a las 8:02, Jonathan Gallimore (<
> > jonathan.gallim...@gmail.com>) escribió:
> >
> >> Done!
> >>
> >> On Tue, Feb 26, 2019 at 12:59 AM David Blevins  >
> >> wrote:
> >>
> >> > Go for it.  The permissions are restricted to try and get people on
> the
> >> > list working together.  Cesar is doing exactly that.
> >> >
> >> >
> >> > --
> >> > David Blevins
> >> > http://twitter.com/dblevins
> >> > http://www.tomitribe.com
> >> >
> >> > > On Feb 25, 2019, at 4:22 PM, Jonathan Gallimore <
> >> > jonathan.gallim...@gmail.com> wrote:
> >> > >
> >> > > If no-one objects in the next 24 hours, I'll set that up for you.
> >> > >
> >> > > Jon
> >> > >
> >> > > On Mon, Feb 25, 2019 at 11:55 PM Daniel Cunha <
> daniels...@apache.org>
> >> > wrote:
> >> > >
> >> > >> +1
> >> > >>
> >> > >>
> >> > >> Or if you are the ticket creator at least to be possible to assign
> it
> >> > for
> >> > >> someone or to himself
> >> > >>
> >> > >> Em seg, 25 de fev de 2019 8:20 PM, César Hernández Mendoza <
> >> > >> cesargu...@gmail.com> escreveu:
> >> > >>
> >> > >>> I would like to have permission to update tickets assignees.
> >> > >>>
> >> > >>>
> >> > >>> --
> >> > >>> Atentamente:
> >> > >>> César Hernández Mendoza.
> >> > >>>
> >> > >>
> >> >
> >> >
> >>
> >
> >
> > --
> > Atentamente:
> > César Hernández Mendoza.
> >
>
>
> --
> Atentamente:
> César Hernández Mendoza.
>


-- 
Daniel "soro" Cunha
https://twitter.com/dvlc_


Re: JIRA permission request

2019-03-04 Thread César Hernández Mendoza
@Jonathan or any other JIRA admin,
Can you check please why I can't assign a ticket to a specific user: Rhuan
account: rhuanrcoha
I documented the issue here:
https://issues.apache.org/jira/browse/TOMEE-2486?focusedCommentId=16783829&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16783829



El jue., 28 feb. 2019 a las 10:29, César Hernández Mendoza (<
cesargu...@gmail.com>) escribió:

> Thank you all!
>
> El jue., 28 feb. 2019 a las 8:02, Jonathan Gallimore (<
> jonathan.gallim...@gmail.com>) escribió:
>
>> Done!
>>
>> On Tue, Feb 26, 2019 at 12:59 AM David Blevins 
>> wrote:
>>
>> > Go for it.  The permissions are restricted to try and get people on the
>> > list working together.  Cesar is doing exactly that.
>> >
>> >
>> > --
>> > David Blevins
>> > http://twitter.com/dblevins
>> > http://www.tomitribe.com
>> >
>> > > On Feb 25, 2019, at 4:22 PM, Jonathan Gallimore <
>> > jonathan.gallim...@gmail.com> wrote:
>> > >
>> > > If no-one objects in the next 24 hours, I'll set that up for you.
>> > >
>> > > Jon
>> > >
>> > > On Mon, Feb 25, 2019 at 11:55 PM Daniel Cunha 
>> > wrote:
>> > >
>> > >> +1
>> > >>
>> > >>
>> > >> Or if you are the ticket creator at least to be possible to assign it
>> > for
>> > >> someone or to himself
>> > >>
>> > >> Em seg, 25 de fev de 2019 8:20 PM, César Hernández Mendoza <
>> > >> cesargu...@gmail.com> escreveu:
>> > >>
>> > >>> I would like to have permission to update tickets assignees.
>> > >>>
>> > >>>
>> > >>> --
>> > >>> Atentamente:
>> > >>> César Hernández Mendoza.
>> > >>>
>> > >>
>> >
>> >
>>
>
>
> --
> Atentamente:
> César Hernández Mendoza.
>


-- 
Atentamente:
César Hernández Mendoza.


[GitHub] [tomee] cesarhernandezgt commented on issue #431: Add mp-confi-example translate to portuguese

2019-03-04 Thread GitBox
cesarhernandezgt commented on issue #431: Add mp-confi-example translate to 
portuguese
URL: https://github.com/apache/tomee/pull/431#issuecomment-469434513
 
 
   @rhuan080 Can we continue this conversation in the mailing list thread with 
subject "TOMEE-2486 | Translate to Portuguese: examples/mp-config-example" ?
   Remember that "if didn't happen in the mailing list, it didn't happen" ;).
   I can't find your username rhuanrocha in https://issues.apache.org/jira


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [tomee] rhuan080 edited a comment on issue #431: Add mp-confi-example translate to portuguese

2019-03-04 Thread GitBox
rhuan080 edited a comment on issue #431: Add mp-confi-example translate to 
portuguese
URL: https://github.com/apache/tomee/pull/431#issuecomment-469432387
 
 
   Hi @cesarhernandezgt , thank you!
   
   My username is **rhuanrcoha**.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [tomee] rhuan080 commented on issue #431: Add mp-confi-example translate to portuguese

2019-03-04 Thread GitBox
rhuan080 commented on issue #431: Add mp-confi-example translate to portuguese
URL: https://github.com/apache/tomee/pull/431#issuecomment-469432387
 
 
   Hi @cesarhernandezgt , thank you!
   
   My username is **rhuanrocha**.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [tomee] rhuan080 commented on a change in pull request #431: Add mp-confi-example translate to portuguese

2019-03-04 Thread GitBox
rhuan080 commented on a change in pull request #431: Add mp-confi-example 
translate to portuguese
URL: https://github.com/apache/tomee/pull/431#discussion_r262251548
 
 

 ##
 File path: examples/mp-config-example/README_pt.adoc
 ##
 @@ -0,0 +1,71 @@
+= MicroProfile Config
+:index-group: MicroProfile
+:jbake-type: page
+:jbake-status: published
+
+Este é um examplo de como usar o microprofile config no TomEE.
+
+== Rodando a aplicação:
+
+[source,bash]
+
+mvn clean install tomee:run 
+
+
+== API
+
+Na aplicação, tem 3 formas de injetar valores usando config 
 
 Review comment:
   @otaviojava fiz a alteração conforme sugerido!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


TOMEE-2486 | Translate to Portuguese: examples/mp-config-example

2019-03-04 Thread César Hernández Mendoza
Hi Rhuan.

Thanks for the PR [1] :)!

I created for you the JIRA ticket:
https://issues.apache.org/jira/browse/TOMEE-2486, usually we create first
the JIRA, start an email thread on the mailing list to:

1. Request to be assigned to the JIRA, this will allow visibility and
prevent duplication of work.
2. Send status when your PR is ready to be reviewed.

Can you please share your JIRA username so I can assign the ticket
TOMEE-2486 to you?

For further reference about the process we are continuously improving,  you
can check: http://tomee.apache.org/community/contributing/workflow.html

[1] https://github.com/apache/tomee/pull/431
-- 
Atentamente:
César Hernández.


[GitHub] [tomee] cesarhernandezgt commented on issue #431: Add mp-confi-example translate to portuguese

2019-03-04 Thread GitBox
cesarhernandezgt commented on issue #431: Add mp-confi-example translate to 
portuguese
URL: https://github.com/apache/tomee/pull/431#issuecomment-469423417
 
 
   Hi @rhuan080, thanks for the PR :)!
   
   I created the JIRA ticket: https://issues.apache.org/jira/browse/TOMEE-2486, 
usually we create first the JIRA, start a email thread on the mailing list to:
   
   1. Request to be assigned to the JIRA, this will allow visibility and 
prevent duplication of work.
   2. Send status when your PR is ready to be reviewed.
   
   Can you please share your JIRA username so I can assign the ticket 
TOMEE-2486 to you?
   
   For further reference you can check: 
http://tomee.apache.org/community/contributing/workflow.html


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Re: TOMEE-2480: Doubt about the concept of bean

2019-03-04 Thread César Hernández Mendoza
Hi Gabriel,

I've heard that bean is a simple class with its encapsulated methods.

You are referring Java Beans
https://www.oracle.com/technetwork/java/javase/documentation/spec-136004.html
https://docs.oracle.com/javase/tutorial/javabeans/index.html

>
> In the example "bean" sounds more like a "component", because, what is the
> relationship between Bean-Managed Concurrency, thread, Singleton with
> "@path", "@get", "@post".

Check for instance Enterprise Java Beans
https://www.oracle.com/technetwork/java/index-jsp-140203.html
https://docs.oracle.com/javaee/6/tutorial/doc/gijsz.html

btw is okay ask some questions like that in the list?

I don't see why not, we all are here to learn, share and contribute :)



El sáb., 2 mar. 2019 a las 9:10, Gabriel Ferreira ()
escribió:

> So guys, I'm working in the translate of example/simple-rest:
> I believe that I have not completely understood the concept of "bean", I've
> heard that bean is a simple class with its encapsulated methods.
> In the example "bean" sounds more like a "component", because, what is the
> relationship between Bean-Managed Concurrency, thread, Singleton with
> "@path", "@get", "@post".
> So, if anyone can explain me, I will be grateful.
> btw is okay ask some questions like that in the list?
>
> https://issues.apache.org/jira/browse/TOMEE-2480
> http://tomee.apache.org/tomee-8.0/examples/simple-rest.html
> https://github.com/apache/tomee/tree/master/examples/simple-rest
>
> thank you guys
>


-- 
Atentamente:
César Hernández Mendoza.


Re: Buildbot slowness

2019-03-04 Thread j4fm
When running tests in full here are the tests that appear to cause a leak... 
just to see if anything common between them is obvious from your experience? 
Just to be sure, the leak exceptions from these do not appear in the logs at
all with CXF 3.2.7.

org.jboss.cdi.tck.tests.extensions.configurators.observerMethod.ObserverMethodConfiguratorTest
org.jboss.cdi.tck.tests.context.request.event.jms.RequestScopeEventMessageDeliveryTest
org.jboss.cdi.tck.tests.context.request.event.async.RequestScopeEventAsyncTest
org.jboss.cdi.tck.tests.event.observer.conditional.ConditionalObserverTest
org.jboss.cdi.tck.tests.context.passivating.broken.producer.method.enterprise.EnterpriseBeanWithIllegalDependencyTest
org.jboss.cdi.tck.tests.lookup.injection.non.contextual.ws.WebServiceResourceTest
org.jboss.cdi.tck.tests.context.jms.MessageDrivenBeanContextTest
org.jboss.cdi.tck.tests.event.observer.context.async.AsyncObserverMethodInvocationContextTest
org.jboss.cdi.tck.tests.event.observer.context.async.enterprise.EnterpriseSecurityContextPropagationInAsyncObserverTest
org.jboss.cdi.tck.tests.event.observer.async.handlingExceptions.MultipleExceptionsInObserversNotificationTest
org.jboss.cdi.tck.tests.interceptors.definition.enterprise.jms.MessageDrivenBeanInterceptorInvocationTest

org.jboss.cdi.tck.tests.implementation.simple.resource.ws.WebServiceReferenceInjectionTest




--
Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html


[GitHub] [tomee] jgallimore merged pull request #434: Revert "Tomee 7.1.x tt.x updates"

2019-03-04 Thread GitBox
jgallimore merged pull request #434: Revert "Tomee 7.1.x tt.x updates"
URL: https://github.com/apache/tomee/pull/434
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [tomee] jgallimore opened a new pull request #434: Revert "Tomee 7.1.x tt.x updates"

2019-03-04 Thread GitBox
jgallimore opened a new pull request #434: Revert "Tomee 7.1.x tt.x updates"
URL: https://github.com/apache/tomee/pull/434
 
 
   Reverts apache/tomee#433


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [tomee] jgallimore merged pull request #433: Tomee 7.1.x tt.x updates

2019-03-04 Thread GitBox
jgallimore merged pull request #433: Tomee 7.1.x tt.x updates
URL: https://github.com/apache/tomee/pull/433
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [tomee] jgallimore opened a new pull request #433: Tomee 7.1.x tt.x updates

2019-03-04 Thread GitBox
jgallimore opened a new pull request #433: Tomee 7.1.x tt.x updates
URL: https://github.com/apache/tomee/pull/433
 
 
   Pull in latest code from O/S, bump ActiveMQ deps, Jackson deps and Tomcat.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [tomee] otaviojava commented on a change in pull request #431: Add mp-confi-example translate to portuguese

2019-03-04 Thread GitBox
otaviojava commented on a change in pull request #431: Add mp-confi-example 
translate to portuguese
URL: https://github.com/apache/tomee/pull/431#discussion_r262144513
 
 

 ##
 File path: examples/mp-config-example/README_pt.adoc
 ##
 @@ -0,0 +1,71 @@
+= MicroProfile Config
+:index-group: MicroProfile
+:jbake-type: page
+:jbake-status: published
+
+Este é um examplo de como usar o microprofile config no TomEE.
+
+== Rodando a aplicação:
+
+[source,bash]
+
+mvn clean install tomee:run 
+
+
+== API
+
+Na aplicação, tem 3 formas de injetar valores usando config 
 
 Review comment:
   Acredito que a virgula não seja necessário aqui.
   E talvez substituir `tem` por `existem`
Na aplicação existem três formas de injetar valores usando config 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Re: JAX-RS Filter Example (TOMEE-2485)

2019-03-04 Thread Jonathan Gallimore
Not a problem, and thanks again for the submission - its a great example.
Just wanted to provide that feedback in case you wanted to tinker around
with that example a little more and send some more PRs :-).

Cheers!

Jon

On Mon, Mar 4, 2019 at 3:25 PM Sherman Marshall <
sherman.david.marsh...@gmail.com> wrote:

> Thanks Jon,
>
> I should have followed the naming convention, I will remember that for
> future submissions.
>
> I will have to read up on the build instructions a bit more, but I will
> make note to do that as well where applicable!
>
> Regards,
>
> Sherman
>
>
> On Mon, Mar 4, 2019, 2:31 AM Jonathan Gallimore <
> jonathan.gallim...@gmail.com> wrote:
>
> > I've merged this in - thanks for the PR!
> >
> > A couple of suggestions (none of them blocking):
> >
> > 1. I'd be tempted to rename this to something other than Servlet:
> >
> >
> https://github.com/apache/tomee/blob/64c2649966dad626d97725ebfaa66366e70d5ba6/examples/jaxrs-filter/src/main/java/org/superbiz/filterexample/ExampleServlet.java#L21
> > - just so its clear that its a JAX-RS endpoint and not a servlet.
> > 2. Try adding the TomEE Maven Plugin - that enables a "mvn tomee:run" to
> > boot TomEE and run your example. Hopefully that's as easy as adding this
> > plugin:
> >
> >   
> > org.apache.tomee.maven
> > tomee-maven-plugin
> > 8.0.0-SNAPSHOT
> > 
> >   -Xmx512m -XX:PermSize=256m
> > 
> >   
> >
> > 3. An Arquillian test would be great - slightly more involved than (2),
> but
> > we're happy to give some pointers to help.
> >
> > Cheers!
> >
> > Jon
> >
> > On Sun, Mar 3, 2019 at 4:14 PM Sherman Marshall (JIRA) 
> > wrote:
> >
> > >
> > >  [
> > >
> >
> https://issues.apache.org/jira/browse/TOMEE-2485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> > > ]
> > >
> > > Sherman Marshall updated TOMEE-2485:
> > > 
> > > Issue Type: Sub-task  (was: New Feature)
> > > Parent: TOMEE-2482
> > >
> > > > JAX-RS Filter Example
> > > > -
> > > >
> > > > Key: TOMEE-2485
> > > > URL:
> https://issues.apache.org/jira/browse/TOMEE-2485
> > > > Project: TomEE
> > > >  Issue Type: Sub-task
> > > >  Components: Examples and Documentation
> > > >Reporter: Sherman Marshall
> > > >Priority: Minor
> > > >
> > > > Basic example of how to incorporate JAX-RS filters into an
> application.
> > >
> > >
> > >
> > > --
> > > This message was sent by Atlassian JIRA
> > > (v7.6.3#76005)
> > >
> >
>


Re: Buildbot slowness

2019-03-04 Thread Jonathan Gallimore
Thanks for the detail. I'm slammed myself, but hopefully will get some time
to help tomorrow.

I'd encourage others to dig in if they can / wish to. A starting point
could be: try pulling out one of the CDI TCK apps, deploy it manually, and
then undeploy, and see what's not getting freed and what is hanging onto
it. It could be some tweaks are needed in openejb-cxf[rs] around the
integration after the CXF update (just a total guess).

Jon

On Mon, Mar 4, 2019 at 3:29 PM j4fm  wrote:

> Thanks for merging.  Buildbot is succeeding again.
>
> So my testng changes help speed up the tests and improve the heap usage
> (worth adding the changes in at some point) but it didn't solve the root
> cause.  I see these in the logs:
>
> SEVERE [http-nio-37745-exec-211]
>
> org.apache.catalina.loader.WebappClassLoaderBase.checkThreadLocalMapForLeaks
> The web application [24366694ab54ddc83623ef655667ac266c465c4] created a
> ThreadLocal with key of type [java.lang.InheritableThreadLocal] (value
> [java.lang.InheritableThreadLocal@413afe5a]) and a value of type
> [org.testng.internal.TestResult] (value [[TestResult name=testEventsFired
> status=SUCCESS
> method=RequestScopeEventMessageDeliveryTest.testEventsFired()[pri:0,
>
> instance:org.jboss.cdi.tck.tests.context.request.event.jms.RequestScopeEventMessageDeliveryTest@71e20c1
> ]
> output={null}]]) but failed to remove it when the web application was
> stopped. Threads are going to be renewed over time to try and avoid a
> probable memory leak.
>
> WARNING [http-nio-37745-exec-43]
> org.apache.catalina.loader.WebappClassLoaderBase.clearReferencesThreads The
> web application [f171a3d3289dcf8237159d936219ff9c87d85db] appears to have
> started a thread named [pool-29-thread-1] but has failed to stop it. This
> is
> very likely to create a memory leak. Stack trace of thread:
>  sun.misc.Unsafe.park(Native Method)
>  java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
>
>
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039)
>
>  java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442)
>
>
> java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1067)
>
>
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1127)
>
>
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  java.lang.Thread.run(Thread.java:745)
>
> Am trying to get to pin point but things are slow here so it's taking a
> bit.
>
>
>
> --
> Sent from:
> http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
>


Re: Building with Java 11

2019-03-04 Thread Daniel Cunha
Yeah.. I was seeing that exactly now. this option was dropped.

Em seg, 4 de mar de 2019 12:23 PM, Otávio Gonçalves de Santana <
osant...@tomitribe.com> escreveu:

> That does not work, there are changes at ClassLoader since Java 9. That
> became forbidden at Java 11, because of these changes.
>
>
> On Mon, Mar 4, 2019 at 12:03 PM Daniel Cunha 
> wrote:
>
> > Hi Otávio,
> >
> > To fix it using jdk flags, you can use --illegal-access
> > Try it.
> >
> > Em seg, 4 de mar de 2019 às 11:54, Otávio Gonçalves de Santana <
> > osant...@tomitribe.com> escreveu:
> >
> > > Now, I got a new error:
> > >
> > > Illegal reflective access by
> > org.apache.openejb.loader.BasicURLClassPath$4
> > >
> > >
> >
> (file:/tmp/temp14662460932513193953dir/root/lib/openejb-loader-8.0.0-SNAPSHOT.jar)
> > > to field java.net.URLClassLoader.ucp
> > >
> > >
> > > On Mon, Mar 4, 2019 at 10:49 AM Otávio Gonçalves de Santana <
> > > osant...@tomitribe.com> wrote:
> > >
> > > > I got the idea, I'll work on it.
> > > > Thank you.
> > > >
> > > > On Mon, Mar 4, 2019 at 10:47 AM Jonathan Gallimore <
> > > > jonathan.gallim...@gmail.com> wrote:
> > > >
> > > >> It sounded like you could make it work with a compiler config change
> > > (not
> > > >> a
> > > >> code change) in Java 11 - is that correct?
> > > >>
> > > >> If so, can't you just provide that config only when running the
> build
> > on
> > > >> Java 11?
> > > >>
> > > >> Something like:
> > > >>
> > > >> 
> > > >>   
> > > >> java-11
> > > >> 
> > > >>   11
> > > >> 
> > > >> 
> > > >>   
> > > >> 
> > > >>   maven-compiler-plugin
> > > >>   
> > > >> 
> > > >>   --add-modules
> > > >>   jdk.internal.loader
> > > >>
> > > >> 
> > > >>  
> > > >>   
> > > >> 
> > > >>
> > > >> (totally not tested...)
> > > >>
> > > >> Does that make sense? The failover artifacts themselves are simply
> > > >> deployed
> > > >> and run as part of a test suite, so we don't ship them as part of
> > TomEE
> > > >> itself. Its desirable to run the itests on both Java 8 and 11 to see
> > if
> > > >> there are any issues.
> > > >>
> > > >> Jon
> > > >>
> > > >> On Mon, Mar 4, 2019 at 1:27 PM Otávio Gonçalves de Santana <
> > > >> osant...@tomitribe.com> wrote:
> > > >>
> > > >> > Hey JonG.
> > > >> > Could you explain more about it?
> > > >> > Do you mean, create a profile to skip this project such as
> failover.
> > > >> >
> > > >> > I’ve checked some options such as redesign the classpath and
> create
> > > >> wrapper
> > > >> > the BasicURLClass. Both with a huge change of code.
> > > >> >
> > > >> > 
> > > >> >   skip-java-11
> > > >> >   
> > > >> > failover
> > > >> >   
> > > >> > 
> > > >> >
> > > >> >
> > > >> >
> > > >> > On Fri, Mar 1, 2019 at 5:19 PM Jonathan Gallimore <
> > > >> > jonathan.gallim...@gmail.com> wrote:
> > > >> >
> > > >> > > If that's just for itests, I'd be inclined to try creating a
> > profile
> > > >> to
> > > >> > add
> > > >> > > that where the Java version is >8.
> > > >> > >
> > > >> > > What do you think?
> > > >> > >
> > > >> > > Jon
> > > >> > >
> > > >> > > On Fri, Mar 1, 2019 at 6:16 PM Otávio Gonçalves de Santana <
> > > >> > > osant...@tomitribe.com> wrote:
> > > >> > >
> > > >> > > > Hey guys
> > > >> > > >
> > > >> > > > I'm working to make the tests compatible with both Java 8 and
> > Java
> > > >> 11
> > > >> > > > version.
> > > >> > > >
> > > >> > > >
> > > >> > > > Right now, I'm at the failover
> > > >> > > > 
> > > >> project
> > > >> > > that
> > > >> > > > has this issue:
> > > >> > > >
> > > >> > > > java.lang.IllegalAccessException: class
> > > >> > > > org.apache.openejb.loader.BasicURLClassPath cannot access
> class
> > > >> > > > jdk.internal.loader.URLClassPath (in module java.base) because
> > > >> module
> > > >> > > > java.base does not export jdk.internal.loader to unnamed
> module
> > > >> > > > @4c6e276e
> > > >> > > > at
> > > >> > > >
> > > >> > >
> > > >> >
> > > >>
> > >
> >
> java.base/jdk.internal.reflect.Reflection.newIllegalAccessException(Reflection.java:361)
> > > >> > > >
> > > >> > > >
> > > >> > > > There are two ways to solve it;
> > > >> > > >
> > > >> > > >- the first one is using the filemodule-info.java
> > > >> > > >- Using the add-module argument at maven.
> > > >> > > >
> > > >> > > >
> > > >> > > > 
> > > >> > > > maven-compiler-plugin
> > > >> > > > 
> > > >> > > > 
> > > >> > > > --add-modules
> > > >> > > > dk.internal.loader
> > > >> > > > 
> > > >> > > > 
> > > >> > > >
> > > >> > > >
> > > >> > > > However, both make unavailable the situation to run Java 8.
> > > >> > > >
> > > >> > > > I still working to solve it.
> > > >> > > >
> > > >> > > > On Fri, Mar 1, 2019 at 2:11 PM Jonathan Gallimore <
> > > >> > > > jonathan.gallim...@gmail.com> wrote:
> > > >> >

Re: Buildbot slowness

2019-03-04 Thread j4fm
Thanks for merging.  Buildbot is succeeding again.

So my testng changes help speed up the tests and improve the heap usage
(worth adding the changes in at some point) but it didn't solve the root
cause.  I see these in the logs:

SEVERE [http-nio-37745-exec-211]
org.apache.catalina.loader.WebappClassLoaderBase.checkThreadLocalMapForLeaks
The web application [24366694ab54ddc83623ef655667ac266c465c4] created a
ThreadLocal with key of type [java.lang.InheritableThreadLocal] (value
[java.lang.InheritableThreadLocal@413afe5a]) and a value of type
[org.testng.internal.TestResult] (value [[TestResult name=testEventsFired
status=SUCCESS
method=RequestScopeEventMessageDeliveryTest.testEventsFired()[pri:0,
instance:org.jboss.cdi.tck.tests.context.request.event.jms.RequestScopeEventMessageDeliveryTest@71e20c1]
output={null}]]) but failed to remove it when the web application was
stopped. Threads are going to be renewed over time to try and avoid a
probable memory leak.

WARNING [http-nio-37745-exec-43]
org.apache.catalina.loader.WebappClassLoaderBase.clearReferencesThreads The
web application [f171a3d3289dcf8237159d936219ff9c87d85db] appears to have
started a thread named [pool-29-thread-1] but has failed to stop it. This is
very likely to create a memory leak. Stack trace of thread:
 sun.misc.Unsafe.park(Native Method)
 java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)

java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039)
 java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442)

java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1067)

java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1127)

java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
 java.lang.Thread.run(Thread.java:745)
 
Am trying to get to pin point but things are slow here so it's taking a bit.



--
Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html


Re: JAX-RS Filter Example (TOMEE-2485)

2019-03-04 Thread Sherman Marshall
Thanks Jon,

I should have followed the naming convention, I will remember that for
future submissions.

I will have to read up on the build instructions a bit more, but I will
make note to do that as well where applicable!

Regards,

Sherman


On Mon, Mar 4, 2019, 2:31 AM Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:

> I've merged this in - thanks for the PR!
>
> A couple of suggestions (none of them blocking):
>
> 1. I'd be tempted to rename this to something other than Servlet:
>
> https://github.com/apache/tomee/blob/64c2649966dad626d97725ebfaa66366e70d5ba6/examples/jaxrs-filter/src/main/java/org/superbiz/filterexample/ExampleServlet.java#L21
> - just so its clear that its a JAX-RS endpoint and not a servlet.
> 2. Try adding the TomEE Maven Plugin - that enables a "mvn tomee:run" to
> boot TomEE and run your example. Hopefully that's as easy as adding this
> plugin:
>
>   
> org.apache.tomee.maven
> tomee-maven-plugin
> 8.0.0-SNAPSHOT
> 
>   -Xmx512m -XX:PermSize=256m
> 
>   
>
> 3. An Arquillian test would be great - slightly more involved than (2), but
> we're happy to give some pointers to help.
>
> Cheers!
>
> Jon
>
> On Sun, Mar 3, 2019 at 4:14 PM Sherman Marshall (JIRA) 
> wrote:
>
> >
> >  [
> >
> https://issues.apache.org/jira/browse/TOMEE-2485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> > ]
> >
> > Sherman Marshall updated TOMEE-2485:
> > 
> > Issue Type: Sub-task  (was: New Feature)
> > Parent: TOMEE-2482
> >
> > > JAX-RS Filter Example
> > > -
> > >
> > > Key: TOMEE-2485
> > > URL: https://issues.apache.org/jira/browse/TOMEE-2485
> > > Project: TomEE
> > >  Issue Type: Sub-task
> > >  Components: Examples and Documentation
> > >Reporter: Sherman Marshall
> > >Priority: Minor
> > >
> > > Basic example of how to incorporate JAX-RS filters into an application.
> >
> >
> >
> > --
> > This message was sent by Atlassian JIRA
> > (v7.6.3#76005)
> >
>


Re: Building with Java 11

2019-03-04 Thread Otávio Gonçalves de Santana
That does not work, there are changes at ClassLoader since Java 9. That
became forbidden at Java 11, because of these changes.


On Mon, Mar 4, 2019 at 12:03 PM Daniel Cunha  wrote:

> Hi Otávio,
>
> To fix it using jdk flags, you can use --illegal-access
> Try it.
>
> Em seg, 4 de mar de 2019 às 11:54, Otávio Gonçalves de Santana <
> osant...@tomitribe.com> escreveu:
>
> > Now, I got a new error:
> >
> > Illegal reflective access by
> org.apache.openejb.loader.BasicURLClassPath$4
> >
> >
> (file:/tmp/temp14662460932513193953dir/root/lib/openejb-loader-8.0.0-SNAPSHOT.jar)
> > to field java.net.URLClassLoader.ucp
> >
> >
> > On Mon, Mar 4, 2019 at 10:49 AM Otávio Gonçalves de Santana <
> > osant...@tomitribe.com> wrote:
> >
> > > I got the idea, I'll work on it.
> > > Thank you.
> > >
> > > On Mon, Mar 4, 2019 at 10:47 AM Jonathan Gallimore <
> > > jonathan.gallim...@gmail.com> wrote:
> > >
> > >> It sounded like you could make it work with a compiler config change
> > (not
> > >> a
> > >> code change) in Java 11 - is that correct?
> > >>
> > >> If so, can't you just provide that config only when running the build
> on
> > >> Java 11?
> > >>
> > >> Something like:
> > >>
> > >> 
> > >>   
> > >> java-11
> > >> 
> > >>   11
> > >> 
> > >> 
> > >>   
> > >> 
> > >>   maven-compiler-plugin
> > >>   
> > >> 
> > >>   --add-modules
> > >>   jdk.internal.loader
> > >>
> > >> 
> > >>  
> > >>   
> > >> 
> > >>
> > >> (totally not tested...)
> > >>
> > >> Does that make sense? The failover artifacts themselves are simply
> > >> deployed
> > >> and run as part of a test suite, so we don't ship them as part of
> TomEE
> > >> itself. Its desirable to run the itests on both Java 8 and 11 to see
> if
> > >> there are any issues.
> > >>
> > >> Jon
> > >>
> > >> On Mon, Mar 4, 2019 at 1:27 PM Otávio Gonçalves de Santana <
> > >> osant...@tomitribe.com> wrote:
> > >>
> > >> > Hey JonG.
> > >> > Could you explain more about it?
> > >> > Do you mean, create a profile to skip this project such as failover.
> > >> >
> > >> > I’ve checked some options such as redesign the classpath and create
> > >> wrapper
> > >> > the BasicURLClass. Both with a huge change of code.
> > >> >
> > >> > 
> > >> >   skip-java-11
> > >> >   
> > >> > failover
> > >> >   
> > >> > 
> > >> >
> > >> >
> > >> >
> > >> > On Fri, Mar 1, 2019 at 5:19 PM Jonathan Gallimore <
> > >> > jonathan.gallim...@gmail.com> wrote:
> > >> >
> > >> > > If that's just for itests, I'd be inclined to try creating a
> profile
> > >> to
> > >> > add
> > >> > > that where the Java version is >8.
> > >> > >
> > >> > > What do you think?
> > >> > >
> > >> > > Jon
> > >> > >
> > >> > > On Fri, Mar 1, 2019 at 6:16 PM Otávio Gonçalves de Santana <
> > >> > > osant...@tomitribe.com> wrote:
> > >> > >
> > >> > > > Hey guys
> > >> > > >
> > >> > > > I'm working to make the tests compatible with both Java 8 and
> Java
> > >> 11
> > >> > > > version.
> > >> > > >
> > >> > > >
> > >> > > > Right now, I'm at the failover
> > >> > > > 
> > >> project
> > >> > > that
> > >> > > > has this issue:
> > >> > > >
> > >> > > > java.lang.IllegalAccessException: class
> > >> > > > org.apache.openejb.loader.BasicURLClassPath cannot access class
> > >> > > > jdk.internal.loader.URLClassPath (in module java.base) because
> > >> module
> > >> > > > java.base does not export jdk.internal.loader to unnamed module
> > >> > > > @4c6e276e
> > >> > > > at
> > >> > > >
> > >> > >
> > >> >
> > >>
> >
> java.base/jdk.internal.reflect.Reflection.newIllegalAccessException(Reflection.java:361)
> > >> > > >
> > >> > > >
> > >> > > > There are two ways to solve it;
> > >> > > >
> > >> > > >- the first one is using the filemodule-info.java
> > >> > > >- Using the add-module argument at maven.
> > >> > > >
> > >> > > >
> > >> > > > 
> > >> > > > maven-compiler-plugin
> > >> > > > 
> > >> > > > 
> > >> > > > --add-modules
> > >> > > > dk.internal.loader
> > >> > > > 
> > >> > > > 
> > >> > > >
> > >> > > >
> > >> > > > However, both make unavailable the situation to run Java 8.
> > >> > > >
> > >> > > > I still working to solve it.
> > >> > > >
> > >> > > > On Fri, Mar 1, 2019 at 2:11 PM Jonathan Gallimore <
> > >> > > > jonathan.gallim...@gmail.com> wrote:
> > >> > > >
> > >> > > > > Killed of the builds and forced a new one.
> > >> > > > >
> > >> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1048
> > >> > > > >
> > >> > > > > Jon
> > >> > > > >
> > >> > > > > On Fri, Mar 1, 2019 at 4:28 PM j4fm <
> james.m...@my-managed.net>
> > >> > wrote:
> > >> > > > >
> > >> > > > > > Ah yeah that makes sense.
> > >> > > > > >
> > >> > > > > > It won't let me stop the current stuck build.  Would you be
> > able
> > >> > to?
> > >> > > > > >
> > >> > > > > 

Re: Building with Java 11

2019-03-04 Thread Otávio Gonçalves de Santana
That looks illegal access is forbidden at Java 11.
I'm working on it.

On Mon, Mar 4, 2019 at 11:54 AM Otávio Gonçalves de Santana <
osant...@tomitribe.com> wrote:

>
> Now, I got a new error:
>
> Illegal reflective access by org.apache.openejb.loader.BasicURLClassPath$4
> (file:/tmp/temp14662460932513193953dir/root/lib/openejb-loader-8.0.0-SNAPSHOT.jar)
> to field java.net.URLClassLoader.ucp
>
>
> On Mon, Mar 4, 2019 at 10:49 AM Otávio Gonçalves de Santana <
> osant...@tomitribe.com> wrote:
>
>> I got the idea, I'll work on it.
>> Thank you.
>>
>> On Mon, Mar 4, 2019 at 10:47 AM Jonathan Gallimore <
>> jonathan.gallim...@gmail.com> wrote:
>>
>>> It sounded like you could make it work with a compiler config change
>>> (not a
>>> code change) in Java 11 - is that correct?
>>>
>>> If so, can't you just provide that config only when running the build on
>>> Java 11?
>>>
>>> Something like:
>>>
>>> 
>>>   
>>> java-11
>>> 
>>>   11
>>> 
>>> 
>>>   
>>> 
>>>   maven-compiler-plugin
>>>   
>>> 
>>>   --add-modules
>>>   jdk.internal.loader
>>>
>>> 
>>>  
>>>   
>>> 
>>>
>>> (totally not tested...)
>>>
>>> Does that make sense? The failover artifacts themselves are simply
>>> deployed
>>> and run as part of a test suite, so we don't ship them as part of TomEE
>>> itself. Its desirable to run the itests on both Java 8 and 11 to see if
>>> there are any issues.
>>>
>>> Jon
>>>
>>> On Mon, Mar 4, 2019 at 1:27 PM Otávio Gonçalves de Santana <
>>> osant...@tomitribe.com> wrote:
>>>
>>> > Hey JonG.
>>> > Could you explain more about it?
>>> > Do you mean, create a profile to skip this project such as failover.
>>> >
>>> > I’ve checked some options such as redesign the classpath and create
>>> wrapper
>>> > the BasicURLClass. Both with a huge change of code.
>>> >
>>> > 
>>> >   skip-java-11
>>> >   
>>> > failover
>>> >   
>>> > 
>>> >
>>> >
>>> >
>>> > On Fri, Mar 1, 2019 at 5:19 PM Jonathan Gallimore <
>>> > jonathan.gallim...@gmail.com> wrote:
>>> >
>>> > > If that's just for itests, I'd be inclined to try creating a profile
>>> to
>>> > add
>>> > > that where the Java version is >8.
>>> > >
>>> > > What do you think?
>>> > >
>>> > > Jon
>>> > >
>>> > > On Fri, Mar 1, 2019 at 6:16 PM Otávio Gonçalves de Santana <
>>> > > osant...@tomitribe.com> wrote:
>>> > >
>>> > > > Hey guys
>>> > > >
>>> > > > I'm working to make the tests compatible with both Java 8 and Java
>>> 11
>>> > > > version.
>>> > > >
>>> > > >
>>> > > > Right now, I'm at the failover
>>> > > > 
>>> project
>>> > > that
>>> > > > has this issue:
>>> > > >
>>> > > > java.lang.IllegalAccessException: class
>>> > > > org.apache.openejb.loader.BasicURLClassPath cannot access class
>>> > > > jdk.internal.loader.URLClassPath (in module java.base) because
>>> module
>>> > > > java.base does not export jdk.internal.loader to unnamed module
>>> > > > @4c6e276e
>>> > > > at
>>> > > >
>>> > >
>>> >
>>> java.base/jdk.internal.reflect.Reflection.newIllegalAccessException(Reflection.java:361)
>>> > > >
>>> > > >
>>> > > > There are two ways to solve it;
>>> > > >
>>> > > >- the first one is using the filemodule-info.java
>>> > > >- Using the add-module argument at maven.
>>> > > >
>>> > > >
>>> > > > 
>>> > > > maven-compiler-plugin
>>> > > > 
>>> > > > 
>>> > > > --add-modules
>>> > > > dk.internal.loader
>>> > > > 
>>> > > > 
>>> > > >
>>> > > >
>>> > > > However, both make unavailable the situation to run Java 8.
>>> > > >
>>> > > > I still working to solve it.
>>> > > >
>>> > > > On Fri, Mar 1, 2019 at 2:11 PM Jonathan Gallimore <
>>> > > > jonathan.gallim...@gmail.com> wrote:
>>> > > >
>>> > > > > Killed of the builds and forced a new one.
>>> > > > >
>>> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1048
>>> > > > >
>>> > > > > Jon
>>> > > > >
>>> > > > > On Fri, Mar 1, 2019 at 4:28 PM j4fm 
>>> > wrote:
>>> > > > >
>>> > > > > > Ah yeah that makes sense.
>>> > > > > >
>>> > > > > > It won't let me stop the current stuck build.  Would you be
>>> able
>>> > to?
>>> > > > > >
>>> > > > > > From the logs it looks like it succeeds up until the point it's
>>> > > > frozen...
>>> > > > > > I'm not sure what's up with it.  Have you seen it freeze like
>>> this
>>> > > > > before?
>>> > > > > > Maybe it's an issue with the CI agent instead?
>>> > > > > >
>>> > > > > >
>>> > > > > >
>>> > > > > > --
>>> > > > > > Sent from:
>>> > > > > >
>>> http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
>>> > > > > >
>>> > > > >
>>> > > >
>>> > >
>>> >
>>>
>>


Re: Building with Java 11

2019-03-04 Thread Daniel Cunha
Hi Otávio,

To fix it using jdk flags, you can use --illegal-access
Try it.

Em seg, 4 de mar de 2019 às 11:54, Otávio Gonçalves de Santana <
osant...@tomitribe.com> escreveu:

> Now, I got a new error:
>
> Illegal reflective access by org.apache.openejb.loader.BasicURLClassPath$4
>
> (file:/tmp/temp14662460932513193953dir/root/lib/openejb-loader-8.0.0-SNAPSHOT.jar)
> to field java.net.URLClassLoader.ucp
>
>
> On Mon, Mar 4, 2019 at 10:49 AM Otávio Gonçalves de Santana <
> osant...@tomitribe.com> wrote:
>
> > I got the idea, I'll work on it.
> > Thank you.
> >
> > On Mon, Mar 4, 2019 at 10:47 AM Jonathan Gallimore <
> > jonathan.gallim...@gmail.com> wrote:
> >
> >> It sounded like you could make it work with a compiler config change
> (not
> >> a
> >> code change) in Java 11 - is that correct?
> >>
> >> If so, can't you just provide that config only when running the build on
> >> Java 11?
> >>
> >> Something like:
> >>
> >> 
> >>   
> >> java-11
> >> 
> >>   11
> >> 
> >> 
> >>   
> >> 
> >>   maven-compiler-plugin
> >>   
> >> 
> >>   --add-modules
> >>   jdk.internal.loader
> >>
> >> 
> >>  
> >>   
> >> 
> >>
> >> (totally not tested...)
> >>
> >> Does that make sense? The failover artifacts themselves are simply
> >> deployed
> >> and run as part of a test suite, so we don't ship them as part of TomEE
> >> itself. Its desirable to run the itests on both Java 8 and 11 to see if
> >> there are any issues.
> >>
> >> Jon
> >>
> >> On Mon, Mar 4, 2019 at 1:27 PM Otávio Gonçalves de Santana <
> >> osant...@tomitribe.com> wrote:
> >>
> >> > Hey JonG.
> >> > Could you explain more about it?
> >> > Do you mean, create a profile to skip this project such as failover.
> >> >
> >> > I’ve checked some options such as redesign the classpath and create
> >> wrapper
> >> > the BasicURLClass. Both with a huge change of code.
> >> >
> >> > 
> >> >   skip-java-11
> >> >   
> >> > failover
> >> >   
> >> > 
> >> >
> >> >
> >> >
> >> > On Fri, Mar 1, 2019 at 5:19 PM Jonathan Gallimore <
> >> > jonathan.gallim...@gmail.com> wrote:
> >> >
> >> > > If that's just for itests, I'd be inclined to try creating a profile
> >> to
> >> > add
> >> > > that where the Java version is >8.
> >> > >
> >> > > What do you think?
> >> > >
> >> > > Jon
> >> > >
> >> > > On Fri, Mar 1, 2019 at 6:16 PM Otávio Gonçalves de Santana <
> >> > > osant...@tomitribe.com> wrote:
> >> > >
> >> > > > Hey guys
> >> > > >
> >> > > > I'm working to make the tests compatible with both Java 8 and Java
> >> 11
> >> > > > version.
> >> > > >
> >> > > >
> >> > > > Right now, I'm at the failover
> >> > > > 
> >> project
> >> > > that
> >> > > > has this issue:
> >> > > >
> >> > > > java.lang.IllegalAccessException: class
> >> > > > org.apache.openejb.loader.BasicURLClassPath cannot access class
> >> > > > jdk.internal.loader.URLClassPath (in module java.base) because
> >> module
> >> > > > java.base does not export jdk.internal.loader to unnamed module
> >> > > > @4c6e276e
> >> > > > at
> >> > > >
> >> > >
> >> >
> >>
> java.base/jdk.internal.reflect.Reflection.newIllegalAccessException(Reflection.java:361)
> >> > > >
> >> > > >
> >> > > > There are two ways to solve it;
> >> > > >
> >> > > >- the first one is using the filemodule-info.java
> >> > > >- Using the add-module argument at maven.
> >> > > >
> >> > > >
> >> > > > 
> >> > > > maven-compiler-plugin
> >> > > > 
> >> > > > 
> >> > > > --add-modules
> >> > > > dk.internal.loader
> >> > > > 
> >> > > > 
> >> > > >
> >> > > >
> >> > > > However, both make unavailable the situation to run Java 8.
> >> > > >
> >> > > > I still working to solve it.
> >> > > >
> >> > > > On Fri, Mar 1, 2019 at 2:11 PM Jonathan Gallimore <
> >> > > > jonathan.gallim...@gmail.com> wrote:
> >> > > >
> >> > > > > Killed of the builds and forced a new one.
> >> > > > >
> >> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1048
> >> > > > >
> >> > > > > Jon
> >> > > > >
> >> > > > > On Fri, Mar 1, 2019 at 4:28 PM j4fm 
> >> > wrote:
> >> > > > >
> >> > > > > > Ah yeah that makes sense.
> >> > > > > >
> >> > > > > > It won't let me stop the current stuck build.  Would you be
> able
> >> > to?
> >> > > > > >
> >> > > > > > From the logs it looks like it succeeds up until the point
> it's
> >> > > > frozen...
> >> > > > > > I'm not sure what's up with it.  Have you seen it freeze like
> >> this
> >> > > > > before?
> >> > > > > > Maybe it's an issue with the CI agent instead?
> >> > > > > >
> >> > > > > >
> >> > > > > >
> >> > > > > > --
> >> > > > > > Sent from:
> >> > > > > >
> >> http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
> >> > > > > >
> >> > > > >
> >> > > >
> >> > >
> >> >
> >>
> >
>


-- 
Daniel "soro" Cunha
https://twitter.com/dvlc_


Re: Building with Java 11

2019-03-04 Thread Otávio Gonçalves de Santana
Now, I got a new error:

Illegal reflective access by org.apache.openejb.loader.BasicURLClassPath$4
(file:/tmp/temp14662460932513193953dir/root/lib/openejb-loader-8.0.0-SNAPSHOT.jar)
to field java.net.URLClassLoader.ucp


On Mon, Mar 4, 2019 at 10:49 AM Otávio Gonçalves de Santana <
osant...@tomitribe.com> wrote:

> I got the idea, I'll work on it.
> Thank you.
>
> On Mon, Mar 4, 2019 at 10:47 AM Jonathan Gallimore <
> jonathan.gallim...@gmail.com> wrote:
>
>> It sounded like you could make it work with a compiler config change (not
>> a
>> code change) in Java 11 - is that correct?
>>
>> If so, can't you just provide that config only when running the build on
>> Java 11?
>>
>> Something like:
>>
>> 
>>   
>> java-11
>> 
>>   11
>> 
>> 
>>   
>> 
>>   maven-compiler-plugin
>>   
>> 
>>   --add-modules
>>   jdk.internal.loader
>>
>> 
>>  
>>   
>> 
>>
>> (totally not tested...)
>>
>> Does that make sense? The failover artifacts themselves are simply
>> deployed
>> and run as part of a test suite, so we don't ship them as part of TomEE
>> itself. Its desirable to run the itests on both Java 8 and 11 to see if
>> there are any issues.
>>
>> Jon
>>
>> On Mon, Mar 4, 2019 at 1:27 PM Otávio Gonçalves de Santana <
>> osant...@tomitribe.com> wrote:
>>
>> > Hey JonG.
>> > Could you explain more about it?
>> > Do you mean, create a profile to skip this project such as failover.
>> >
>> > I’ve checked some options such as redesign the classpath and create
>> wrapper
>> > the BasicURLClass. Both with a huge change of code.
>> >
>> > 
>> >   skip-java-11
>> >   
>> > failover
>> >   
>> > 
>> >
>> >
>> >
>> > On Fri, Mar 1, 2019 at 5:19 PM Jonathan Gallimore <
>> > jonathan.gallim...@gmail.com> wrote:
>> >
>> > > If that's just for itests, I'd be inclined to try creating a profile
>> to
>> > add
>> > > that where the Java version is >8.
>> > >
>> > > What do you think?
>> > >
>> > > Jon
>> > >
>> > > On Fri, Mar 1, 2019 at 6:16 PM Otávio Gonçalves de Santana <
>> > > osant...@tomitribe.com> wrote:
>> > >
>> > > > Hey guys
>> > > >
>> > > > I'm working to make the tests compatible with both Java 8 and Java
>> 11
>> > > > version.
>> > > >
>> > > >
>> > > > Right now, I'm at the failover
>> > > > 
>> project
>> > > that
>> > > > has this issue:
>> > > >
>> > > > java.lang.IllegalAccessException: class
>> > > > org.apache.openejb.loader.BasicURLClassPath cannot access class
>> > > > jdk.internal.loader.URLClassPath (in module java.base) because
>> module
>> > > > java.base does not export jdk.internal.loader to unnamed module
>> > > > @4c6e276e
>> > > > at
>> > > >
>> > >
>> >
>> java.base/jdk.internal.reflect.Reflection.newIllegalAccessException(Reflection.java:361)
>> > > >
>> > > >
>> > > > There are two ways to solve it;
>> > > >
>> > > >- the first one is using the filemodule-info.java
>> > > >- Using the add-module argument at maven.
>> > > >
>> > > >
>> > > > 
>> > > > maven-compiler-plugin
>> > > > 
>> > > > 
>> > > > --add-modules
>> > > > dk.internal.loader
>> > > > 
>> > > > 
>> > > >
>> > > >
>> > > > However, both make unavailable the situation to run Java 8.
>> > > >
>> > > > I still working to solve it.
>> > > >
>> > > > On Fri, Mar 1, 2019 at 2:11 PM Jonathan Gallimore <
>> > > > jonathan.gallim...@gmail.com> wrote:
>> > > >
>> > > > > Killed of the builds and forced a new one.
>> > > > >
>> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1048
>> > > > >
>> > > > > Jon
>> > > > >
>> > > > > On Fri, Mar 1, 2019 at 4:28 PM j4fm 
>> > wrote:
>> > > > >
>> > > > > > Ah yeah that makes sense.
>> > > > > >
>> > > > > > It won't let me stop the current stuck build.  Would you be able
>> > to?
>> > > > > >
>> > > > > > From the logs it looks like it succeeds up until the point it's
>> > > > frozen...
>> > > > > > I'm not sure what's up with it.  Have you seen it freeze like
>> this
>> > > > > before?
>> > > > > > Maybe it's an issue with the CI agent instead?
>> > > > > >
>> > > > > >
>> > > > > >
>> > > > > > --
>> > > > > > Sent from:
>> > > > > >
>> http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
>> > > > > >
>> > > > >
>> > > >
>> > >
>> >
>>
>


Re: Building with Java 11

2019-03-04 Thread Otávio Gonçalves de Santana
I got the idea, I'll work on it.
Thank you.

On Mon, Mar 4, 2019 at 10:47 AM Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:

> It sounded like you could make it work with a compiler config change (not a
> code change) in Java 11 - is that correct?
>
> If so, can't you just provide that config only when running the build on
> Java 11?
>
> Something like:
>
> 
>   
> java-11
> 
>   11
> 
> 
>   
> 
>   maven-compiler-plugin
>   
> 
>   --add-modules
>   jdk.internal.loader
>
> 
>  
>   
> 
>
> (totally not tested...)
>
> Does that make sense? The failover artifacts themselves are simply deployed
> and run as part of a test suite, so we don't ship them as part of TomEE
> itself. Its desirable to run the itests on both Java 8 and 11 to see if
> there are any issues.
>
> Jon
>
> On Mon, Mar 4, 2019 at 1:27 PM Otávio Gonçalves de Santana <
> osant...@tomitribe.com> wrote:
>
> > Hey JonG.
> > Could you explain more about it?
> > Do you mean, create a profile to skip this project such as failover.
> >
> > I’ve checked some options such as redesign the classpath and create
> wrapper
> > the BasicURLClass. Both with a huge change of code.
> >
> > 
> >   skip-java-11
> >   
> > failover
> >   
> > 
> >
> >
> >
> > On Fri, Mar 1, 2019 at 5:19 PM Jonathan Gallimore <
> > jonathan.gallim...@gmail.com> wrote:
> >
> > > If that's just for itests, I'd be inclined to try creating a profile to
> > add
> > > that where the Java version is >8.
> > >
> > > What do you think?
> > >
> > > Jon
> > >
> > > On Fri, Mar 1, 2019 at 6:16 PM Otávio Gonçalves de Santana <
> > > osant...@tomitribe.com> wrote:
> > >
> > > > Hey guys
> > > >
> > > > I'm working to make the tests compatible with both Java 8 and Java 11
> > > > version.
> > > >
> > > >
> > > > Right now, I'm at the failover
> > > > 
> project
> > > that
> > > > has this issue:
> > > >
> > > > java.lang.IllegalAccessException: class
> > > > org.apache.openejb.loader.BasicURLClassPath cannot access class
> > > > jdk.internal.loader.URLClassPath (in module java.base) because module
> > > > java.base does not export jdk.internal.loader to unnamed module
> > > > @4c6e276e
> > > > at
> > > >
> > >
> >
> java.base/jdk.internal.reflect.Reflection.newIllegalAccessException(Reflection.java:361)
> > > >
> > > >
> > > > There are two ways to solve it;
> > > >
> > > >- the first one is using the filemodule-info.java
> > > >- Using the add-module argument at maven.
> > > >
> > > >
> > > > 
> > > > maven-compiler-plugin
> > > > 
> > > > 
> > > > --add-modules
> > > > dk.internal.loader
> > > > 
> > > > 
> > > >
> > > >
> > > > However, both make unavailable the situation to run Java 8.
> > > >
> > > > I still working to solve it.
> > > >
> > > > On Fri, Mar 1, 2019 at 2:11 PM Jonathan Gallimore <
> > > > jonathan.gallim...@gmail.com> wrote:
> > > >
> > > > > Killed of the builds and forced a new one.
> > > > > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1048
> > > > >
> > > > > Jon
> > > > >
> > > > > On Fri, Mar 1, 2019 at 4:28 PM j4fm 
> > wrote:
> > > > >
> > > > > > Ah yeah that makes sense.
> > > > > >
> > > > > > It won't let me stop the current stuck build.  Would you be able
> > to?
> > > > > >
> > > > > > From the logs it looks like it succeeds up until the point it's
> > > > frozen...
> > > > > > I'm not sure what's up with it.  Have you seen it freeze like
> this
> > > > > before?
> > > > > > Maybe it's an issue with the CI agent instead?
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Sent from:
> > > > > > http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
> > > > > >
> > > > >
> > > >
> > >
> >
>


Re: Building with Java 11

2019-03-04 Thread Jonathan Gallimore
It sounded like you could make it work with a compiler config change (not a
code change) in Java 11 - is that correct?

If so, can't you just provide that config only when running the build on
Java 11?

Something like:


  
java-11

  11


  

  maven-compiler-plugin
  

  --add-modules
  jdk.internal.loader
   

 
  


(totally not tested...)

Does that make sense? The failover artifacts themselves are simply deployed
and run as part of a test suite, so we don't ship them as part of TomEE
itself. Its desirable to run the itests on both Java 8 and 11 to see if
there are any issues.

Jon

On Mon, Mar 4, 2019 at 1:27 PM Otávio Gonçalves de Santana <
osant...@tomitribe.com> wrote:

> Hey JonG.
> Could you explain more about it?
> Do you mean, create a profile to skip this project such as failover.
>
> I’ve checked some options such as redesign the classpath and create wrapper
> the BasicURLClass. Both with a huge change of code.
>
> 
>   skip-java-11
>   
> failover
>   
> 
>
>
>
> On Fri, Mar 1, 2019 at 5:19 PM Jonathan Gallimore <
> jonathan.gallim...@gmail.com> wrote:
>
> > If that's just for itests, I'd be inclined to try creating a profile to
> add
> > that where the Java version is >8.
> >
> > What do you think?
> >
> > Jon
> >
> > On Fri, Mar 1, 2019 at 6:16 PM Otávio Gonçalves de Santana <
> > osant...@tomitribe.com> wrote:
> >
> > > Hey guys
> > >
> > > I'm working to make the tests compatible with both Java 8 and Java 11
> > > version.
> > >
> > >
> > > Right now, I'm at the failover
> > >  project
> > that
> > > has this issue:
> > >
> > > java.lang.IllegalAccessException: class
> > > org.apache.openejb.loader.BasicURLClassPath cannot access class
> > > jdk.internal.loader.URLClassPath (in module java.base) because module
> > > java.base does not export jdk.internal.loader to unnamed module
> > > @4c6e276e
> > > at
> > >
> >
> java.base/jdk.internal.reflect.Reflection.newIllegalAccessException(Reflection.java:361)
> > >
> > >
> > > There are two ways to solve it;
> > >
> > >- the first one is using the filemodule-info.java
> > >- Using the add-module argument at maven.
> > >
> > >
> > > 
> > > maven-compiler-plugin
> > > 
> > > 
> > > --add-modules
> > > dk.internal.loader
> > > 
> > > 
> > >
> > >
> > > However, both make unavailable the situation to run Java 8.
> > >
> > > I still working to solve it.
> > >
> > > On Fri, Mar 1, 2019 at 2:11 PM Jonathan Gallimore <
> > > jonathan.gallim...@gmail.com> wrote:
> > >
> > > > Killed of the builds and forced a new one.
> > > > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1048
> > > >
> > > > Jon
> > > >
> > > > On Fri, Mar 1, 2019 at 4:28 PM j4fm 
> wrote:
> > > >
> > > > > Ah yeah that makes sense.
> > > > >
> > > > > It won't let me stop the current stuck build.  Would you be able
> to?
> > > > >
> > > > > From the logs it looks like it succeeds up until the point it's
> > > frozen...
> > > > > I'm not sure what's up with it.  Have you seen it freeze like this
> > > > before?
> > > > > Maybe it's an issue with the CI agent instead?
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Sent from:
> > > > > http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
> > > > >
> > > >
> > >
> >
>


Re: Building with Java 11

2019-03-04 Thread Otávio Gonçalves de Santana
Hey JonG.
Could you explain more about it?
Do you mean, create a profile to skip this project such as failover.

I’ve checked some options such as redesign the classpath and create wrapper
the BasicURLClass. Both with a huge change of code.


  skip-java-11
  
failover
  




On Fri, Mar 1, 2019 at 5:19 PM Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:

> If that's just for itests, I'd be inclined to try creating a profile to add
> that where the Java version is >8.
>
> What do you think?
>
> Jon
>
> On Fri, Mar 1, 2019 at 6:16 PM Otávio Gonçalves de Santana <
> osant...@tomitribe.com> wrote:
>
> > Hey guys
> >
> > I'm working to make the tests compatible with both Java 8 and Java 11
> > version.
> >
> >
> > Right now, I'm at the failover
> >  project
> that
> > has this issue:
> >
> > java.lang.IllegalAccessException: class
> > org.apache.openejb.loader.BasicURLClassPath cannot access class
> > jdk.internal.loader.URLClassPath (in module java.base) because module
> > java.base does not export jdk.internal.loader to unnamed module
> > @4c6e276e
> > at
> >
> java.base/jdk.internal.reflect.Reflection.newIllegalAccessException(Reflection.java:361)
> >
> >
> > There are two ways to solve it;
> >
> >- the first one is using the filemodule-info.java
> >- Using the add-module argument at maven.
> >
> >
> > 
> > maven-compiler-plugin
> > 
> > 
> > --add-modules
> > dk.internal.loader
> > 
> > 
> >
> >
> > However, both make unavailable the situation to run Java 8.
> >
> > I still working to solve it.
> >
> > On Fri, Mar 1, 2019 at 2:11 PM Jonathan Gallimore <
> > jonathan.gallim...@gmail.com> wrote:
> >
> > > Killed of the builds and forced a new one.
> > > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1048
> > >
> > > Jon
> > >
> > > On Fri, Mar 1, 2019 at 4:28 PM j4fm  wrote:
> > >
> > > > Ah yeah that makes sense.
> > > >
> > > > It won't let me stop the current stuck build.  Would you be able to?
> > > >
> > > > From the logs it looks like it succeeds up until the point it's
> > frozen...
> > > > I'm not sure what's up with it.  Have you seen it freeze like this
> > > before?
> > > > Maybe it's an issue with the CI agent instead?
> > > >
> > > >
> > > >
> > > > --
> > > > Sent from:
> > > > http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
> > > >
> > >
> >
>


Re: Building with Java 11

2019-03-04 Thread Jonathan Gallimore
Merged, thanks :)

On Mon, Mar 4, 2019 at 11:46 AM Daniel Cunha  wrote:

> Hey Jon,
>
> just to keep the branch sync with master.
> https://github.com/jgallimore/tomee/pull/4
>
> Thank you.
>
> Em seg, 4 de mar de 2019 às 00:09, j4fm 
> escreveu:
>
> > So I have a fix for the cdi-tomee tck which means we can add cxf 3.3.0
> back
> > in.  I just want to wait for full tests to complete before explaining in
> > detail but to sum it up the bug was in testng which was keeping hold of
> > threads.
> >
> >
> >
> > --
> > Sent from:
> > http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
> >
>
>
> --
> Daniel "soro" Cunha
> https://twitter.com/dvlc_
>


Re: PropertyEditors deprecated class.

2019-03-04 Thread Daniel Cunha
Hi Jon,

thank you for your review, I'll take a look after we finish the changes for
java and have it merged on master


Em seg, 4 de mar de 2019 às 08:27, Jonathan Gallimore <
jonathan.gallim...@gmail.com> escreveu:

> Added feedback on the PR, but including it here for visibility:
>
> In LocalJMXCommand the PropertyEditorRegistry is held as a field. In other
> places, this is doing PropertyEditorRegistry.registerDefaults() when
> calling getValue(), which has to go an do a bunch of registration each
> time.
>
> What do we think the lifecycle of a PropertyEditorRegistry should be? I did
> a quick search for references, which throws up ManagedMBean,
> ActiveMQ5Factory, JMSProducerImpl, and I would have thought it could be
> tied to the lifecycle of the components using it in each case (i.e. - make
> it a field).
>
> Thoughts?
>
> Jon
>
> On Mon, Mar 4, 2019 at 10:34 AM Jonathan Gallimore <
> jonathan.gallim...@gmail.com> wrote:
>
> > Interesting. Thanks for the PR - looking at it now.
> >
> > Jon
> >
> > On Thu, Feb 28, 2019 at 3:26 PM Daniel Cunha 
> wrote:
> >
> >> Hi Folks,
> >>
> >> I've created the ticket
> https://issues.apache.org/jira/browse/TOMEE-2481
> >>
> >> That because the class PropertyEditors is a deprected class, because of
> >> that we are moving it to use the PropertyEditorRegistry as indicated on
> >> the
> >> PropertyEditors comment: this is all static and leaks, use
> >> PropertyEditorRegistry
> >>
> >> PR is opened: https://github.com/apache/tomee/pull/427
> >>
> >> Pleas review it.
> >>
> >> --
> >> Daniel "soro" Cunha
> >> https://twitter.com/dvlc_
> >>
> >
>


-- 
Daniel "soro" Cunha
https://twitter.com/dvlc_


Re: Building with Java 11

2019-03-04 Thread Daniel Cunha
Hey Jon,

just to keep the branch sync with master.
https://github.com/jgallimore/tomee/pull/4

Thank you.

Em seg, 4 de mar de 2019 às 00:09, j4fm 
escreveu:

> So I have a fix for the cdi-tomee tck which means we can add cxf 3.3.0 back
> in.  I just want to wait for full tests to complete before explaining in
> detail but to sum it up the bug was in testng which was keeping hold of
> threads.
>
>
>
> --
> Sent from:
> http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
>


-- 
Daniel "soro" Cunha
https://twitter.com/dvlc_


Re: PropertyEditors deprecated class.

2019-03-04 Thread Jonathan Gallimore
Added feedback on the PR, but including it here for visibility:

In LocalJMXCommand the PropertyEditorRegistry is held as a field. In other
places, this is doing PropertyEditorRegistry.registerDefaults() when
calling getValue(), which has to go an do a bunch of registration each time.

What do we think the lifecycle of a PropertyEditorRegistry should be? I did
a quick search for references, which throws up ManagedMBean,
ActiveMQ5Factory, JMSProducerImpl, and I would have thought it could be
tied to the lifecycle of the components using it in each case (i.e. - make
it a field).

Thoughts?

Jon

On Mon, Mar 4, 2019 at 10:34 AM Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:

> Interesting. Thanks for the PR - looking at it now.
>
> Jon
>
> On Thu, Feb 28, 2019 at 3:26 PM Daniel Cunha  wrote:
>
>> Hi Folks,
>>
>> I've created the ticket https://issues.apache.org/jira/browse/TOMEE-2481
>>
>> That because the class PropertyEditors is a deprected class, because of
>> that we are moving it to use the PropertyEditorRegistry as indicated on
>> the
>> PropertyEditors comment: this is all static and leaks, use
>> PropertyEditorRegistry
>>
>> PR is opened: https://github.com/apache/tomee/pull/427
>>
>> Pleas review it.
>>
>> --
>> Daniel "soro" Cunha
>> https://twitter.com/dvlc_
>>
>


[GitHub] [tomee] jgallimore commented on issue #427: TOMEE-2481 - Move code using PropertyEditors (deprectaed class) to PropertyEditorRegistry

2019-03-04 Thread GitBox
jgallimore commented on issue #427:  TOMEE-2481 - Move code using 
PropertyEditors (deprectaed class) to PropertyEditorRegistry
URL: https://github.com/apache/tomee/pull/427#issuecomment-469218713
 
 
   In`LocalJMXCommand` the PropertyEditorRegistry is held as a field. In other 
places, this is doing `PropertyEditorRegistry.registerDefaults()` when calling 
`getValue()`, which has to go an do a bunch of registration each time.
   
   What do we think the lifecycle of a `PropertyEditorRegistry` should be? I 
did a quick search for references, which throws up `ManagedMBean`, 
`ActiveMQ5Factory`, `JMSProducerImpl`, and I would have thought it could be 
tied to the lifecycle of the components using it in each case (i.e. - make it a 
field).
   
   Thoughts?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Re: PropertyEditors deprecated class.

2019-03-04 Thread Jonathan Gallimore
Interesting. Thanks for the PR - looking at it now.

Jon

On Thu, Feb 28, 2019 at 3:26 PM Daniel Cunha  wrote:

> Hi Folks,
>
> I've created the ticket https://issues.apache.org/jira/browse/TOMEE-2481
>
> That because the class PropertyEditors is a deprected class, because of
> that we are moving it to use the PropertyEditorRegistry as indicated on the
> PropertyEditors comment: this is all static and leaks, use
> PropertyEditorRegistry
>
> PR is opened: https://github.com/apache/tomee/pull/427
>
> Pleas review it.
>
> --
> Daniel "soro" Cunha
> https://twitter.com/dvlc_
>


JAX-RS Filter Example (TOMEE-2485)

2019-03-04 Thread Jonathan Gallimore
I've merged this in - thanks for the PR!

A couple of suggestions (none of them blocking):

1. I'd be tempted to rename this to something other than Servlet:
https://github.com/apache/tomee/blob/64c2649966dad626d97725ebfaa66366e70d5ba6/examples/jaxrs-filter/src/main/java/org/superbiz/filterexample/ExampleServlet.java#L21
- just so its clear that its a JAX-RS endpoint and not a servlet.
2. Try adding the TomEE Maven Plugin - that enables a "mvn tomee:run" to
boot TomEE and run your example. Hopefully that's as easy as adding this
plugin:

  
org.apache.tomee.maven
tomee-maven-plugin
8.0.0-SNAPSHOT

  -Xmx512m -XX:PermSize=256m

  

3. An Arquillian test would be great - slightly more involved than (2), but
we're happy to give some pointers to help.

Cheers!

Jon

On Sun, Mar 3, 2019 at 4:14 PM Sherman Marshall (JIRA) 
wrote:

>
>  [
> https://issues.apache.org/jira/browse/TOMEE-2485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
>
> Sherman Marshall updated TOMEE-2485:
> 
> Issue Type: Sub-task  (was: New Feature)
> Parent: TOMEE-2482
>
> > JAX-RS Filter Example
> > -
> >
> > Key: TOMEE-2485
> > URL: https://issues.apache.org/jira/browse/TOMEE-2485
> > Project: TomEE
> >  Issue Type: Sub-task
> >  Components: Examples and Documentation
> >Reporter: Sherman Marshall
> >Priority: Minor
> >
> > Basic example of how to incorporate JAX-RS filters into an application.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v7.6.3#76005)
>


[GitHub] [tomee] asfgit merged pull request #432: JAX-RS filter example (JIRA 2482)

2019-03-04 Thread GitBox
asfgit merged pull request #432: JAX-RS filter example (JIRA 2482)
URL: https://github.com/apache/tomee/pull/432
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Re: Buildbot slowness

2019-03-04 Thread Jonathan Gallimore
Shoot over a PR. I would definitely be interested in a little bit of detail
before merging so we all understand what's happening.

Cheers

Jon

On Mon, Mar 4, 2019 at 3:10 AM j4fm  wrote:

> So I have a fix for the cdi-tomee tck which means we can add cxf 3.3.0 back
> in.  I just want to wait for full tests to complete before explaining in
> detail but to sum it up the bug was in testng which was keeping hold of
> threads.
>
>
>
> --
> Sent from:
> http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
>


[GitHub] [tomee] jgallimore merged pull request #430: Revert missed dependency versions

2019-03-04 Thread GitBox
jgallimore merged pull request #430: Revert missed dependency versions
URL: https://github.com/apache/tomee/pull/430
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services