[GitHub] [tomee] rzo1 edited a comment on pull request #829: Regenerated BOMs after dependency upgrades
rzo1 edited a comment on pull request #829: URL: https://github.com/apache/tomee/pull/829#issuecomment-1079613423 I think, that `GenerateBoms` works correctly and removes the things added in https://github.com/apache/tomee/commit/8d94db115f6a9f89b8ed09f9757b7b72d641c217 here because we switched to ``` org.apache.tomee microprofile-opentracing-api-shade 9.0.0-M8-SNAPSHOT * * ``` Looking at the `pom.xml` before the `GenerateBoms` is triggered, I can see this one from https://github.com/apache/tomee/commit/8d94db115f6a9f89b8ed09f9757b7b72d641c217 ``` org.apache.geronimo geronimo-health-common 2.0.1 * * org.apache.geronimo geronimo-health-common 2.0.1 jakarta * * ``` For me it looks like some local (?) hassle as the generated bom file now contains dependencies without jakarta modifier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tomee] rzo1 edited a comment on pull request #829: Regenerated BOMs after dependency upgrades
rzo1 edited a comment on pull request #829: URL: https://github.com/apache/tomee/pull/829#issuecomment-1079613423 I think, that `GenerateBoms` works correctly and removes the things added in https://github.com/apache/tomee/commit/8d94db115f6a9f89b8ed09f9757b7b72d641c217 here because we switched to ``` org.apache.tomee microprofile-opentracing-api-shade 9.0.0-M8-SNAPSHOT * * ``` Looking at the `pom.xml` before the `GenerateBoms` is triggered, I can see this one from https://github.com/apache/tomee/commit/8d94db115f6a9f89b8ed09f9757b7b72d641c217 org.apache.geronimo geronimo-health-common 2.0.1 * * org.apache.geronimo geronimo-health-common 2.0.1 jakarta * * ``` For me it looks like some local (?) hassle as the generated bom file now contains dependencies without jakarta modifier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tomee] rzo1 edited a comment on pull request #829: Regenerated BOMs after dependency upgrades
rzo1 edited a comment on pull request #829: URL: https://github.com/apache/tomee/pull/829#issuecomment-1079613423 I think, that `GenerateBoms` works correctly and removes the things added in https://github.com/apache/tomee/commit/8d94db115f6a9f89b8ed09f9757b7b72d641c217 here because we switched to ``` org.apache.tomee microprofile-opentracing-api-shade 9.0.0-M8-SNAPSHOT * * ``` Looking at the `pom.xml` before the `GenerateBoms` is triggered, I can see this one from https://github.com/apache/tomee/commit/8d94db115f6a9f89b8ed09f9757b7b72d641c217 org.apache.geronimo geronimo-health-common 2.0.1 * * org.apache.geronimo geronimo-health-common 2.0.1 jakarta * * ``` For me it looks like some local (?) hassle as the generated bom file now contains dependencies without jakarta modifier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tomee] rzo1 commented on pull request #829: Regenerated BOMs after dependency upgrades
rzo1 commented on pull request #829: URL: https://github.com/apache/tomee/pull/829#issuecomment-1079613423 I think, that `GenerateBoms` works correctly and removes the things added in https://github.com/apache/tomee/commit/8d94db115f6a9f89b8ed09f9757b7b72d641c217 here because we switched to ``` org.apache.tomee microprofile-opentracing-api-shade 9.0.0-M8-SNAPSHOT * * ``` or org.apache.geronimo geronimo-health-common 2.0.1 * * org.apache.geronimo geronimo-health-common 2.0.1 jakarta * * ``` are contained in the current version of master. I guess, that there is some local (?) hassle on your machine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tomee] rzo1 edited a comment on pull request #829: Regenerated BOMs after dependency upgrades
rzo1 edited a comment on pull request #829: URL: https://github.com/apache/tomee/pull/829#issuecomment-1079612108 @dblevins I get the same results as the GitHub actions job locally. The artifacts are removed in the BOM generation, but I also see ``` rz@ironcat:~/tomee/tomee/apache-tomee/target$ tar tvf apache-tomee-plus-9.0.0-M8-SNAPSHOT.tar.gz | grep trac -rw-r--r-- 0/0 13634 2022-03-26 06:15 apache-tomee-plus-9.0.0-M8-SNAPSHOT/lib/opentracing-api-0.31.0.jar -rw-r--r-- 0/0 14053 2022-03-26 06:15 apache-tomee-plus-9.0.0-M8-SNAPSHOT/lib/microprofile-opentracing-api-shade-9.0.0-M8-SNAPSHOT.jar -rw-r--r-- 0/0 89210 2022-03-26 06:15 apache-tomee-plus-9.0.0-M8-SNAPSHOT/lib/geronimo-opentracing-common-1.0.3-jakarta.jar -rw-r--r-- 0/0 32697 2022-03-26 06:15 apache-tomee-plus-9.0.0-M8-SNAPSHOT/lib/geronimo-opentracing-1.0.3-jakarta.jar ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tomee] rzo1 commented on pull request #829: Regenerated BOMs after dependency upgrades
rzo1 commented on pull request #829: URL: https://github.com/apache/tomee/pull/829#issuecomment-1079612108 @dblevins I get the same results as the GitHub actions job. The artifacts are moved in the BOM generation, but I also see ``` rz@ironcat:~/tomee/tomee/apache-tomee/target$ tar tvf apache-tomee-plus-9.0.0-M8-SNAPSHOT.tar.gz | grep trac -rw-r--r-- 0/0 13634 2022-03-26 06:15 apache-tomee-plus-9.0.0-M8-SNAPSHOT/lib/opentracing-api-0.31.0.jar -rw-r--r-- 0/0 14053 2022-03-26 06:15 apache-tomee-plus-9.0.0-M8-SNAPSHOT/lib/microprofile-opentracing-api-shade-9.0.0-M8-SNAPSHOT.jar -rw-r--r-- 0/0 89210 2022-03-26 06:15 apache-tomee-plus-9.0.0-M8-SNAPSHOT/lib/geronimo-opentracing-common-1.0.3-jakarta.jar -rw-r--r-- 0/0 32697 2022-03-26 06:15 apache-tomee-plus-9.0.0-M8-SNAPSHOT/lib/geronimo-opentracing-1.0.3-jakarta.jar ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tomee] rzo1 edited a comment on pull request #829: Regenerated BOMs after dependency upgrades
rzo1 edited a comment on pull request #829: URL: https://github.com/apache/tomee/pull/829#issuecomment-1079605530 Interesting. Basically we run ` mvn help:system -U --show-version --fail-at-end clean install -DfailIfNoTests=false -DskipTests -Pstyle,rat ` in GH actions. This will invoke GenerateBoms, which will trigger the regeneration (as we do locally). Changed files are then pushed and the PR is created. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tomee] rzo1 commented on pull request #829: Regenerated BOMs after dependency upgrades
rzo1 commented on pull request #829: URL: https://github.com/apache/tomee/pull/829#issuecomment-1079605530 Interesting. Basically we run mvn help:system -U --show-version --fail-at-end clean install -DfailIfNoTests=false -DskipTests -Pstyle,rat in GH actions. This will invoke GenerateBoms, which will trigger the regeneration (as we do locally). Changed files are then pushed and the PR is created. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tomee] dblevins commented on pull request #829: Regenerated BOMs after dependency upgrades
dblevins commented on pull request #829: URL: https://github.com/apache/tomee/pull/829#issuecomment-1079601746 @rzo1 It seems this tool wants to remove opentracing from the distributions. It definitely generates to be included on my machine. The tar.gz has it and so does the generated bom: ``` miles:~/work/apache/tomee/tomee/apache-tomee/target 09:35:35 $ tar tvf apache-tomee-plus-9.0.0-M8-SNAPSHOT.tar.gz | grep trac -rw-r--r-- 0 0 0 10455 Mar 25 21:33 apache-tomee-plus-9.0.0-M8-SNAPSHOT/lib/microprofile-opentracing-api-1.1.2.jar -rw-r--r-- 0 0 0 13634 Mar 25 21:33 apache-tomee-plus-9.0.0-M8-SNAPSHOT/lib/opentracing-api-0.31.0.jar -rw-r--r-- 0 0 0 89210 Mar 25 21:33 apache-tomee-plus-9.0.0-M8-SNAPSHOT/lib/geronimo-opentracing-common-1.0.3-jakarta.jar -rw-r--r-- 0 0 0 14052 Mar 25 21:33 apache-tomee-plus-9.0.0-M8-SNAPSHOT/lib/microprofile-opentracing-api-shade-9.0.0-M8-SNAPSHOT.jar -rw-r--r-- 0 0 0 32697 Mar 25 21:33 apache-tomee-plus-9.0.0-M8-SNAPSHOT/lib/geronimo-opentracing-1.0.3-jakarta.jar ``` Any idea what is happening? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: TomEE 9.x - from javax to jakarta namespace
> On Mar 24, 2022, at 2:28 AM, Jean-Louis Monteiro > wrote: > > We can now divide and conquer. An issue has been created > https://issues.apache.org/jira/browse/TOMEE-3862 > We are going to add as many small tasks as possible so people can pick and > contribute in parallel. Thanks for that JIRA. I saw an easy one I could do and went a head and knocked it out :) - https://github.com/apache/tomee/commit/6e37ec02ca60fe955a3a909d761e09aa5a506978 That yanks 1 minute out of the build on my machine. -David > > On Tue, Mar 22, 2022 at 1:59 PM Jean-Louis Monteiro < > jlmonte...@tomitribe.com> wrote: > >> Hi, >> >> I've been working for quite a long time on TomEE 9.x, and it's been more >> challenging and painful than I was expecting. I thought it would be good to >> give you some sort of status. >> >> I created a PR for the work. As a reminder, since Java EE moved to Eclipse >> to become Jakarta EE, we had a switch from javax.* namespace to jakarta.* >> namespace. This is an impacting change, since all applications and >> applications servers are built on top of it. >> >> In TomEE, we decided to do that change in TomEE. We had previously a >> bytecode change approach like an application could do. It worked and we >> were able to get certified. But it had a lot of limitations, so we had to >> do the migration in the code and fix all compatibility issues. >> >> Here is the PR https://github.com/apache/tomee/pull/814 >> It has 90+ commits and nearly 5000 files touched (added, removed, >> updated). I understand it's a lot and it makes it almost impossible to >> review. But I did not see much approaches in this scenario to create >> smaller PRs. >> >> I created a Jenkins build though available at >> https://ci-builds.apache.org/job/Tomee/job/master-build-quick-9.x/ >> >> It makes it possible to track the progress. There have been steps forward >> and steps backward. >> >> All the code does not sit under TomEE, we use a bunch of third party >> projects and libraries. I have been able to contribute, publish jakarta >> compatible versions and get releases for some of them (Jakarta EE APIs Uber >> jar, Geronimo Connectors and Transaction Manager, Geronimo Config, Health, >> Metrics, OpenTracing, OpenAPI. OpenJPA, BVal, and OpenWebBeans will be >> released soon. >> >> The big parts is CXF, and ActiveMQ. I had to get them done in TomEE and >> update all group/artifact ids. It's under deps, alongside with SXC, DBCP, >> and others. >> >> In terms of removal, I tried to remove old stuff like SAAJ Axis 1 >> integration, JAX RPC, Management J2EE and a couple of other old things. >> >> A lot of other libraries got updated to their latest version when >> available in the new jakarta namespace. >> >> I'm starting to get all the build stable and many modules are passing now, >> including all CXF webservices, OpenEJB Core, and others. I can get a build >> and run TomEE. >> >> Goal is to get a green build asap so we can start working on TCK. >> The "quick" build is now green. Working on the full build. >> >> I'll soon be creating a branch for TomEE 8.x maintenance and merge the PR. >> I'm hoping we can then have small PRs or at least more people working in >> parallel. >> >> -- >> Jean-Louis Monteiro >> http://twitter.com/jlouismonteiro >> http://www.tomitribe.com >> smime.p7s Description: S/MIME cryptographic signature
[GitHub] [tomee] github-actions[bot] opened a new pull request #829: Regenerated BOMs after dependency upgrades
github-actions[bot] opened a new pull request #829: URL: https://github.com/apache/tomee/pull/829 Found some uncommited changes (from BOM regeneration) after running build on TomEE master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tomee] sultan opened a new pull request #828: TOMEE-3871 - TomEE Plume is missing BatchEE / JCS Cache
sultan opened a new pull request #828: URL: https://github.com/apache/tomee/pull/828 batchee and jcs added in Plume to reflect Plus flavor removed xml api from from Plume to reflect Plus flavor remains some jar refs in jar scan exclusions (xerces, xml-apis) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tomee] rzo1 merged pull request #827: TOMEE-3876 - Fixed BOM generation under windows
rzo1 merged pull request #827: URL: https://github.com/apache/tomee/pull/827 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tomee] rzo1 commented on pull request #827: TOMEE-3876 - Fixed BOM generation under windows
rzo1 commented on pull request #827: URL: https://github.com/apache/tomee/pull/827#issuecomment-1078996204 @sultan I changed the base branch, so we are good now. Let's wait for GitHub actions and then I will merge it (and pick it for master as well) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tomee] rzo1 commented on pull request #827: TOMEE-3876 - Fixed BOM generation under windows
rzo1 commented on pull request #827: URL: https://github.com/apache/tomee/pull/827#issuecomment-1078985279 @sultan You need to create this PR against `tomee-8.x` as we switched our master branch to JakartaEE 9.1 just yesterday ;) Nevertheless, thank you for creating it in the first place! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tomee] sultan opened a new pull request #827: TOMEE-3876 - Fixed BOM generation under windows
sultan opened a new pull request #827: URL: https://github.com/apache/tomee/pull/827 not group and artifact ids have dots instead of slashes. now ok under windows like its was already ok on linux and mac -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: TOMEE-3846 flavors comparison page
Thanks for your kind feedback. @Richard, I'll gladly change Tomee Plume pom to include BatchEE, PR : in progress with a blocker i can also resolve. @David, about the flavors page, i think your suggestions are simpler and better, applied them on names consistency and added a table of implementations. what need for this list of implementations ? * For my students => My usual scenario is that i need to remind them of what is provided by Tomee vs other servers. "they dont need HK2 nor Jersey if they have the Plus flavor." * For the general web site visitors => I wonder if people would prefer perf metrics and tck results, rather than comparing what is provided by Tomee vs others. provided a web capture just for fun : https://issues.apache.org/jira/secure/attachment/13041580/image-2022-03-25-11-18-14-708.png i still believe the list of implementations is needed to know what Tomee provides, but David's suggestion is clearer. here is the current version of the web page in the PR : https://issues.apache.org/jira/secure/attachment/13041581/image-2022-03-25-11-19-03-406.png On Fri, 25 Mar 2022 at 06:18, Zowalla, Richard < richard.zowa...@hs-heilbronn.de> wrote: > Hi all, > > Thanks for your mail and your work in making the page more clear, > Swell! Your work is very much appreciated. > > > > Total side note to the wider dev list, we really need to get JBatch > > into Plume! Those distributions are supposed to be the same minus > > the JPA and JSF providers. > > I created TOMEE-3871 [1] for this one. > > @Swell Let me know, if you like to provide a PR for master / tomee-8.x > branch to fix it. We can then assign you the Jira :) > > It basically boils down to adding "batchee-jbatch" (runtime) to the > "tomee-plume-webapp". The references in the "boms" are then > automatically re-generated, if you conduct a quick build: > > mvn -U -Pquick -DskipTests -Dsurefire.useFile=false > -DdisableXmlReport=true -DuniqueVersion=false -ff -Dassemble > -DfailIfNoTests=false clean install > > If you are unsure how to proceed with it, feel free to ask. We are > happy to help. > > Gruß > Richard > > [1] https://issues.apache.org/jira/browse/TOMEE-3871 > > Am Donnerstag, dem 24.03.2022 um 11:48 -0700 schrieb David Blevins: > > > On Mar 19, 2022, at 2:30 AM, Swell > > > wrote: > > > > > > Regarding Tomee website : one web page mislead me to believe that > > > Tomee Plus > > > includes Tomee Plume, and it made it hard for me to understand why > > > my > > > webapp was not loading. > > > > > > I believe it could mislead others and its why I wanted to suggest > > > some > > > changes on its content to better show the delta between flavors. > > > > > > Currently the flavors page does not differentiate between Micro and > > > Web > > > profiles, nor does it tell Plume includes EclipseLink when Plus > > > does not. > > > > > > I took time to write a page I believe could be usefull to Tomee > > > users, a > > > screenshot is linked below, the visitors could benefit from my > > > additional > > > table for synthesis of deltas. > > > > > > > https://issues.apache.org/jira/secure/attachment/13041318/image-2022-03-18-20-36-25-938.png > > > > Hi Swell, > > > > Thank you so much for taking the time to put so much thought into > > this work. We are truly lucky :) > > > > I love that you included the MicroProfile detail, that was definitely > > missing and badly needed. As the table is quite large already, that > > terse summary at the top is a very nice improvement and likely to > > help people see the big picture significantly faster. > > > > In the first table, I like the way you used "Jakarta JSF > > Implementation" and list the implementations by name. For > > consistency, can we use that same approach for the line > > above? Instead of it saying "EclipseLink" and having a checkmark, > > could we also have it say "Jakarta Persistence (JPA) Implementation" > > and then put "OpenJPA, OpenJPA, EcliseLink, OpenJPA" in there? We > > can do that in both the top and bottom tables. > > > > On listing OpenEJB in the bottom table. I think it's fine I'm not > > the best judge of what people think is useful information as I've > > been working on the project too long and everything is "obvious." Do > > you find it helpful to see OpenEJB listed even though it's the same > > for all distributions. Do you think we possibly need a table > > entirely dedicated to implementations? (OpenWebBeans, Geronimo > > Transaction Manager, BVal, etc) > > > > Some minor trademark corrections: > > > > - "GlassFish Mojarra" is "Eclipse Mojarra" > > - "Jakarta JSF" is "Jakarta Faces", but "Jakarta Faces (JSF)" is > > completely fine and encouraged so people are aware of its new and > > former name. > > - "Jakarta EJB" is "Jakarta Enterprise Beans", but "Jakarta > > Enterprise Beans (EJB)" is completely fine and encouraged so people > > are aware of its new and former name. > > - "Jakarta JPA" is "Jakarta Persistence", but "Jakarta Persistence > > (JPA)" is
