[GitHub] zeppelin pull request #2177: [ZEPPELIN-2301] DON'T overwrite editor text whe...
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2177 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2125 It's just my opinion. Thus, it's ok to use d3 if you think it's reasonable ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2212: [gh-pages] set max size for pagination btn & hide arro...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2212 Tested and works as describe. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2125 UI can be improved in the following PRs. So it's ok not to resolve the whole things in this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2199: [ZEPPELIN-2326] - Updating Geode dependencies and impo...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2199 @markito I mean, this PR not the JIRA ticket :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2210: [ZEPPELIN-2088] Evaluate helium bundle one by o...
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2210 [ZEPPELIN-2088] Evaluate helium bundle one by one ### What is this PR for? Evaluate helium bundle one by one. Because - Bundling them in one file is not good idea because the whole bundling fails if only one fails - Some node packages might not installed correctly. For example, `amchart/amcharts3` will be install `helium-bundles/node_modules/my-helium-vis/node_modules` but `amchart-export` will be install `helium-bundles/node_modules` so `my-helium-vis` can't import `amchart-export`. (This is real case) - Additionally, I used yarn to install requires node_modules. Since separated bundling mean installing dependencies for each helium package and `npm` is too slow for that. - Install Zeppelin framework modules using [local path](https://docs.npmjs.com/files/package.json#local-paths). It's more safe and correct way to install local modules. ### What type of PR is it? [Improvement] ### Todos NONE ### What is the Jira issue? [ZEPPELIN-2088](https://issues.apache.org/jira/browse/ZEPPELIN-2088) ### How should this be tested? 1. Install any local helium package 2. Install any online helium package 3. Use them 4. Disable 5. Test `npm run dev:helium` ### Screenshots (if appropriate) NONE ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2088/evaluate-helium-bundle-one-by-one Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2210.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2210 commit 0f8b6363ff30dc7dc8e028450d2af2ec7b96da6e Author: 1ambda <1am...@gmail.com> Date: 2017-03-30T14:30:47Z feat: Build each bundle using yarn commit f2576b78518190a331cb3dcf70ef10351e2e3e68 Author: 1ambda <1am...@gmail.com> Date: 2017-03-30T20:50:41Z feat: Build online packages commit 2ea849298f8ee95bcfa29992857f85e28b3e2b0a Author: 1ambda <1am...@gmail.com> Date: 2017-03-31T04:53:06Z feat: enable, disable commit 9fa2a2c6c775c8158af8ee526d3bf971a04b95a7 Author: 1ambda <1am...@gmail.com> Date: 2017-03-31T09:47:25Z feat: Loading bundles commit 94eaf3e19138fcd6b9e0cd0d7064bf21bc3a7a50 Author: 1ambda <1am...@gmail.com> Date: 2017-03-31T10:31:28Z test: Fix APIs commit f85110311d8620449144509c74b4f3d86e3371b2 Author: 1ambda <1am...@gmail.com> Date: 2017-03-31T10:40:52Z fix: Log single bundle error to browser console commit 80e52a8e487748783e368c9e532152fc4fdb2a02 Author: 1ambda <1am...@gmail.com> Date: 2017-03-31T13:18:12Z fix: HeliumBundleFactoryTest commit 586e2fd7da2daca8afa30e6c259b745104acb6d3 Author: 1ambda <1am...@gmail.com> Date: 2017-03-31T13:50:17Z fix: Add nodeInstallationDir commit bcd5bedf1df47308963532b664c04cc8b79be597 Author: 1ambda <1am...@gmail.com> Date: 2017-03-31T14:00:36Z feat: Apply #2178 commit 84c4b793178d823f6d28d84b070c1e0fc97b0dbf Author: 1ambda <1am...@gmail.com> Date: 2017-03-31T14:06:08Z fix: Add error handling for failed bundle --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2252: [ZEPPELIN-1940] lint rule set is NOT applied at...
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/2252
[ZEPPELIN-1940] lint rule set is NOT applied at all.
### What is this PR for?
eslint ruleset is NOT applied at all due to invalid `.eslintrc`.
This PR includes
- fixes which is automatically done by eslint (`eslint --fix src`)
- modification in `.eslintrc`, `package.json`
- while removing eslint conf in `gruntfile.js`
As a result of this PR, we can have more strict and modernized rulesets
which can help us to prevent bugs.
### What type of PR is it?
[Improvement]
### Todos
* [x] - Setup rules
* [x] - Remove grunt eslint config
* [x] - Ignore useless rules
* [x] - Fix code for applied rules
### What is the Jira issue?
[ZEPPELIN-1940](https://issues.apache.org/jira/browse/ZEPPELIN-1940)
### How should this be tested?
- `cd zeppelin-web`
- `npm run lint:once`
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin
ZEPPELIN-1940/apply-lint-rule-set
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2252.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2252
commit fcf7569c0b3eb2bbccb33ce531cee33e8ffdd950
Author: 1ambda <1am...@gmail.com>
Date: 2017-04-14T00:40:25Z
fix: Use eslint instead of grunt-eslint
commit 1ee0af31976c2d104fedb9c00345ea0201a6eda1
Author: 1ambda <1am...@gmail.com>
Date: 2017-04-14T00:40:51Z
fix: Remove invalid visdev
commit ff30ff0864c6dae7eff21f959b084176a6f6ac21
Author: 1ambda <1am...@gmail.com>
Date: 2017-04-14T15:08:06Z
fix: Set ignored, warn lint rules
commit 2d80425af198beab28754e57cc467a9aed0e2818
Author: 1ambda <1am...@gmail.com>
Date: 2017-04-14T15:19:51Z
fix: ignore all rules
commit 065801aad09160e69f12ea21ed3f449898b2beb5
Author: 1ambda <1am...@gmail.com>
Date: 2017-04-14T15:24:15Z
fix: yoda
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/handsontable/handsonHelper.js
160:49 error Expected literal to be on the right side of === yoda
```
commit 1f1862f74f41a981dbc5ec805dc690b9c993f7b9
Author: 1ambda <1am...@gmail.com>
Date: 2017-04-14T15:25:44Z
fix: no-mixed-spaces-and-tabs
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/builtins/visualization-piechart.js
(3/0)
â 79:2 Mixed spaces and tabs no-mixed-spaces-and-tabs
â 80:2 Mixed spaces and tabs no-mixed-spaces-and-tabs
â 81:2 Mixed spaces and tabs no-mixed-spaces-and-tabs
```
commit 139b28d96883b4056df8fce3a5ddd979900fae4e
Author: 1ambda <1am...@gmail.com>
Date: 2017-04-14T15:27:18Z
fix: semi-spacing
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/search/result-list.controller.js
(1/0)
â 20:26 Unexpected whitespace before semicolon semi-spacing
```
commit deb679cd282db0e40c488a0ae2c31a5dca37f77c
Author: 1ambda <1am...@gmail.com>
Date: 2017-04-14T15:31:05Z
fix: no-extra-boolean-cast
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/app.js
(1/0)
â 40:12 Redundant double negation no-extra-boolean-cast
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/jobmanager/jobs/job.controller.js
(2/0)
â 58:18 Redundant double negation no-extra-boolean-cast
â 90:18 Redundant double negation no-extra-boolean-cast
```
commit 8b540e230802490807f1d938baa30f4a3c75c727
Author: 1ambda <1am...@gmail.com>
Date: 2017-04-14T15:35:15Z
fix: object-property-newline
```
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
(7/0)
â 45:26 Object properties must go on a new line if they aren't all
on the same line object-property-newline
â 46:24 Object properties must go on a new line if they aren't all
on the same line object-property-newline
â 46:40 Object properties must go on a new line if they aren't all
on the same line object-property-newline
â 71:38 Object properties must go on a new line if they aren't all
on the same line object-property-newline
â 76:36 Object properties must go on a new line if they aren't all
on the same line object-property-newline
[GitHub] zeppelin issue #2252: [ZEPPELIN-1940] lint rule set is NOT applied at all.
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2252 @AhyoungRyu Could you help review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2251: [ZEPPELIN-2403] added interpreter property types
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2251 One suggestion. What about calling them as 'widget' or something instead of 'type'? cause we might add actual type like 'number', 'string',... as @leemoonsu mentioned. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2256: [ZEPPELIN-2315] (bug) new note.json is overwritten by ...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2256 Old version zeppelins will not render converted note.json. On the other hand, if we keep 'result', they can render last version of old format. Is it ok? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1761: [ZEPPELIN-1711] Create Docker Images for Released Zepp...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1761 Let me create new PR which including only 1 OS (ubuntu) based on this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2260: [ZEPPELIN-2408] Should use $uibTooltip instead of $too...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2260 @soralee Please help review this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2225: [ZEPPELIN-2357] fix: tooltip doesn't work in btn-group
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2225 Submitted #2261 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2260: [ZEPPELIN-2408] Should use $uibTooltip instead ...
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2260 [ZEPPELIN-2408] Should use $uibTooltip instead of $tooltip (master) ### What is this PR for? Since we are using angular-bootstrap 2.5+, we should use `$uibTooltip` instead of `$tooltip` otherwise we will get an error like the screenshot below. See also https://github.com/angular-ui/bootstrap/issues/4591 ### What type of PR is it? [Bug Fix] ### Todos NONE ### What is the Jira issue? [ZEPPELIN-2048](https://issues.apache.org/jira/browse/ZEPPELIN-2408) ### How should this be tested? 1. open browser console 2. click the scatter chart. 3. shouldn't see an error ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2048/fix-tooltip-provider Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2260.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2260 commit 60faca77550629828d4e4a30afba13c3ca98fbd2 Author: 1ambda <1am...@gmail.com> Date: 2017-04-19T01:25:53Z fix: Use --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2261: [ZEPPELIN-2420] Slow notebook listing in navbar
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/2261
[ZEPPELIN-2420] Slow notebook listing in navbar
### What is this PR for?
Notebook listing is slow as you can see in the screenshot below.
The problem was,
- angular-bootstrap was updated to 2.5
- then, `dropdown-*` directives should be converted into `uib-dropdown-*`
- otherwise, changes in angular controller scope values will not affect on
the directives even though events are fired. (`show.bs.dropdown`,
`hide.bs.dropdown`)
```
function initNotebookListEventListener() {
angular.element(document).ready(function() {
angular.element('.notebook-list-dropdown').on('show.bs.dropdown',
function() {
$scope.isDrawNavbarNoteList = true;
});
angular.element('.notebook-list-dropdown').on('hide.bs.dropdown',
function() {
$scope.isDrawNavbarNoteList = false;
});
});
```
### What type of PR is it?
[Bug Fix]
### Todos
NONE
### What is the Jira issue?
[ZEPPELIN-2420](https://issues.apache.org/jira/browse/ZEPPELIN-2420)
### How should this be tested?
1. Open navbar.
2. Notebook listing should appear immediately.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin
ZEPPELIN-2420/slow-navbar-notebook-listing
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2261.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2261
commit 0fccc50d40af31feb2435f449a218b9a8a03d1cd
Author: 1ambda <1am...@gmail.com>
Date: 2017-04-19T01:36:32Z
style: reformat DOM
commit 4237defae533a325240f268735d55ec3339d0b67
Author: 1ambda <1am...@gmail.com>
Date: 2017-04-19T01:45:43Z
fix: Use uib-dropdown in navbar
commit b20b6c62e03c4817ddb5464605757810ed688b7a
Author: 1ambda <1am...@gmail.com>
Date: 2017-04-19T01:54:37Z
fix: Revert ng-show -> ng-if
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2259: Prevent NPE on delete local module cache
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2259 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2253: [ZEPPELIN-2179] Clear output DOES NOT work in personal...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2253 @jongyoul ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2261: [ZEPPELIN-2420] Slow notebook listing in navbar
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2261 @tinkoff-dwh Please help review this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1689: [ZEPPELIN-1709] Update checkstyle rule file, pl...
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/1689 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2252: [ZEPPELIN-1940] lint rule set is NOT applied at all.
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2252 rebased to resolve conflict with #2133 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2540: [ZEPPELIN-2860] Invalid last job execution time
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2540 It makes sense displaying last execution time instead of creation time of the notebook in the job page. Tested and works well LGTM. Let's merge it to master and branch-0.7 if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2541: [ZEPPELIN-2865] upgrade Beam interpreter to latest ver...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2541 Thanks for the contribution. Could you check the failed job? - https://travis-ci.org/XuMingmin/zeppelin/jobs/264931044 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2536: [ZEPPELIN-2861] Use OpenJDK in docker image.
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2536 Can we apply this patch into branch-0.7 as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2506: [ZEPPELIN-2813] revisions comparator
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2506 I didn't mean both. Just gave an opinion. Personally, I don't believe that reviewer only can reply `LGTM` or `NO`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2539: [ZEPPELIN-2863] change notebook-authorization.json and...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2539 Hi, Thanks for the contribution. @sadhen I think you can manually move `interpreter*.json` inside the docker container. Isn't it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2540: [ZEPPELIN-2860] Invalid last job execution time
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2540 @byung-u I missed the CI status/ Could you make sure CI is green? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2506: [ZEPPELIN-2813] revisions comparator
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2506 For me, it's up to you. - keep current implementation - try and propose few different UIs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2527: [ZEPPELIN-2770] Zeppelin is not working in IE-11
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2527 Thanks for the contribution @byamthev I left a comment. Could you check that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2538: [ZEPPELIN-2862] misalign text and icon in notebook dro...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2538 Thanks for the contribution @wishwisdom. It's unclear in the screenshots because you used the old version of zeppelin for the `before` screenshot. Could you update it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2540: [ZEPPELIN-2860] Invalid last job execution time
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2540 It's weird. https://github.com/apache/zeppelin/pull/2541 passed CI and we modified https://github.com/apache/zeppelin/blob/master/.travis.yml 21 days ago. I guess - the package was not available at that time - or ... Could you trigger CI again? `git commit --amend` and `git push --force` would be enough. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2445: ZEPPELIN-2674 Ignite version upgraded up to 2.0
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2445 Hi, what is your base branch? Could you rebase using current master? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2538: [ZEPPELIN-2862] misalign text and icon in notebook dro...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2538 @soralee Thanks for posting the image. LGTM. Merge if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2540: [ZEPPELIN-2860] Invalid last job execution time
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2540 Some PRs made yesterday passed CI. Could you rebase using current master? I am not sure what base branch you are using.  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2527: [ZEPPELIN-2770] Zeppelin is not working in IE-11
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2527 LGTM. merge if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2538: [ZEPPELIN-2862] misalign text and icon in notebook dro...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2538 LGTM. Merge if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1151: Fonted download chinese garbled fix
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1151 Closed. Thanks for the reporting. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2503: [ZEPPELIN-2808] remember me support
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2503 1. Let's expose the config using REST API we already have. - http://zeppelin.apache.org/docs/0.8.0-SNAPSHOT/usage/rest_api/configuration.html#configuration-rest-api-list 2. Check it in frontend and hide if it's disabled using `ng-if` or something. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2506: [ZEPPELIN-2813] revisions comparator
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2506 @tinkoff-dwh Thanks for the update. In feature and code level, it's good. But personally, I hope we can get improved UI. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2526 I saw that people were asking there is this kind of permission. - https://stackoverflow.com/questions/43971836/how-do-i-set-permissions-to-a-zeppelin-note-to-be-able-to-execute-but-not-change --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2528: ZEPPELIN-2834 Show Interpreter list as expand collapse...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2528 Thanks for the contribution. Really nice and useful feature. I guess you introduced new property `isExpanded` in setting. It would be nice to include newly added the property in existing settings as we did in https://github.com/apache/zeppelin/pull/2268/files. It will be more explicit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2525: [ZEPPELIN-2647] Make admin role to bypass auth logic
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2525 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2503: [ZEPPELIN-2808] remember me support
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2503 Then, I think we need to hide when cookie manager is disabled. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2445: ZEPPELIN-2674 Ignite version upgraded up to 2.0
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2445 Hi @agura I guess you didn't setup travis CI for the forked repository. - https://builds.apache.org/job/zeppelin-pull-request/2647/console  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2445: ZEPPELIN-2674 Ignite version upgraded up to 2.0
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2445 LGTM, merge if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2543: [ZEPPELIN-2860] Invalid last job execution time
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2543 I think now CI works properly. Please restart the failed test since it looks like the flaky test - https://travis-ci.org/byung-u/zeppelin/jobs/265423163 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2543: [ZEPPELIN-2860] Invalid last job execution time
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2543 Checked that CI is green. Merge if no more discussion. https://travis-ci.org/byung-u/zeppelin/builds/265423161 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2541: [ZEPPELIN-2865] upgrade Beam interpreter to latest ver...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2541 LGTM. Merge if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2462: ZEPPELIN-2527 Changed editor cursor to thin
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2462 @malayhm Merged to master. Thanks for the contribution again! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2512: [ZEPPELIN-2823] Notebook saved status is wrong if ther...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2512 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2460: [gh-pages] fix hover event in technologies section on ...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2460 Deployed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2460: [gh-pages] fix hover event in technologies section on ...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2460 and works well in mobile (iphone 6s chrome, sarari) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2472: [ZEPPELIN-2749] Use scalable file structure for zeppel...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2472 @soralee Thanks for the review. We need to keep the zeppelin-web module clean. :) Merge if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2458 @ebuildy Thanks for the contribution. Tested and works well, merge if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2487: [ZEPPELIN-2769] Prevent SQL injection for GetUserList....
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2487 LGTM merge if no more discussion. referred https://www.owasp.org/index.php/SQL_Injection_Prevention_Cheat_Sheet#Defense_Option_1:_Prepared_Statements_.28with_Parameterized_Queries.29 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2473: [fix] Check runtimeInfos is not null
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2473 Hi, Thanks for the contribution. 1. Could you make the failed job be green? - https://travis-ci.org/ebuildy/zeppelin/jobs/251686246 2. Please make a JIRA ticket for this issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2475: [ZEPPELIN-2757] Enhance Authentication decrypting key ...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2475 Thanks for the contribution @yanboliang. I left a comment. Could you check that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2491: [ZEPPELIN-2777] Unit test for configuration mod...
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2491 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2491: [ZEPPELIN-2777] Unit test for configuration mod...
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/2491 [ZEPPELIN-2777] Unit test for configuration module (zeppelin-web) ### What is this PR for? Added few test cases for the configuration module under `zeppelin-web/` Additionally, I modified `configuration.html` to add the missing `tbody`. ### What type of PR is it? [Improvement] ### What is the Jira issue? [ZEPPELIN-2777](https://issues.apache.org/jira/browse/ZEPPELIN-2777) ### How should this be tested? 1. cd `zeppelin-web` 2. `yarn install` (or `npm install`) 3. `yarn run test` (or `npm run test`) The test should pass. ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin add-tests-for-zeppelin-web Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2491.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2491 commit 7acf42e795389fd5b4b8e6e415eae15d47f5567b Author: 1ambda <1am...@gmail.com> Date: 2017-07-13T15:39:32Z fix: Remove unused variables commit d6456266216cfc1ceef8699dde7b67a425d17665 Author: 1ambda <1am...@gmail.com> Date: 2017-07-13T15:39:53Z fix: Add missing tbody commit 4c2d1b5961df06b061a296aa9ae74c349945a205 Author: 1ambda <1am...@gmail.com> Date: 2017-07-13T15:40:05Z fix: Add test for configuration commit bf7a70ff6b47585a7f1125695162a6820ab1b00d Author: 1ambda <1am...@gmail.com> Date: 2017-07-14T11:34:05Z fix: Add more test suite for configuration commit af0ba99d869c2d4280ce301def274c0ba7125d62 Author: 1ambda <1am...@gmail.com> Date: 2017-07-14T12:08:23Z fix: eslint errors --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2472: [ZEPPELIN-2749] Use scalable file structure for...
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2472 [ZEPPELIN-2749] Use scalable file structure for zeppelin web ### What is this PR for? We have improved zeppelin-web, but some parts are still messy. As part of keeping zeppelin-web module healthy ([ZEPPELIN-2725](https://issues.apache.org/jira/browse/ZEPPELIN-2725)), I suggest having these file structure. (Refer the screenshot section) Here are few reasons. - unified directory, file name helps us to recognize, find which part we should modify / fix - [this structure](https://github.com/toddmotto/angularjs-styleguide#file-naming-conventions) is what the angularjs community has verified for few years. so newly joined developers can feel more comfortable. - this is necessary for [Modular archiecture](https://issues.apache.org/jira/browse/ZEPPELIN-2750) and it eventually helps us to make a smooth transition toward next technologies (even whatever we will use) Additionally, - This is not the meaningless refactoring PR and doesn't block developing new features / fixes (Please refer the `Some Details` section) - I will handle conflicts for few days would be brought by other WIPs For your information, - https://github.com/toddmotto/angularjs-styleguide#file-naming-conventions - https://github.com/johnpapa/angular-styleguide/blob/master/a1/README.md#naming How to Review This PR? Please follow the commits. I modified submodules by splitting commits. Thus commit message includes what has been done in that PR. For example,  Some Details - Didn't change the widely used variable names not to make many conflicts. For example, `websocketMsgSrv`, `arrayOrderingSrv` - Since there are helium packages already published, didn't changed the html names like `pivot_setting.html` (it's better to use `pivot-setting.html` if we following the rule) ### What type of PR is it? [Improvement | Refactoring] ### Todos Please refer the commit message. ### What is the Jira issue? [ZEPPELIN-2749](https://issues.apache.org/jira/browse/ZEPPELIN-2749) ### How should this be tested? **All functionalities must work** as like before, CI will test it. ### Screenshots (if appropriate) Before: messy, mixed directory structure  After: only the shared components will be placed under `components/`  ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2749/use-scalable-file-structure-for-zeppelin-web Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2472.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2472 commit c1c210de28579bb0ada8f2b64434f0914e78274a Author: 1ambda <1am...@gmail.com> Date: 2017-07-09T03:12:27Z rename: repository-dialog -> repository-create commit a9a6368a663fce28e8c62a7cebed647fa52075a8 Author: 1ambda <1am...@gmail.com> Date: 2017-07-09T03:14:41Z fix: remove useless dir interpreter-create commit 4e7f6d9c1119a1f82cb34596d089a8c6ef919594 Author: 1ambda <1am...@gmail.com> Date: 2017-07-09T03:16:25Z fix: Move repository-create into interpreter/ commit d7d7434a722ef161289b043f42e5051581fb51bf Author: 1ambda <1am...@gmail.com> Date: 2017-07-09T03:31:06Z move: note specific service saveAsService into notebook/ commit 3f02c5038cd723cc4882c87e8194033ff1ff816b Author: 1ambda <1am...@gmail.com> Date: 2017-07-09T03:33:10Z fix: Remove unused saveAsService from paragraph ctrl commit 701f44320b44675b60f00ab80542944fbc7902fe Author: 1ambda <1am...@gmail.com> Date: 2017-07-09T03:39:52Z move: note specific service into notebook/ commit ad99c04b7c0216dabcf01ba3705e30f7c46fc68c Author: 1ambda <1am...@gmail.com> Date: 2017-07-09T03:50:02Z move: note specific dialog into notebook/ commit c21a1237bc2cee4bc8e1fe5e5aef97c68bc9ac1e Author: 1ambda <1am...@gmail.com> Date: 2017-07-09T03:58:42Z move: paragraph specific ctrl into paragraph/ commit a25275307e373737b465b349d8f9d9f0d25133bc Author: 1ambda <1am...@gmail.com>
[GitHub] zeppelin pull request #2477: [ZEPPELIN-2342] Improving Test Environment for ...
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2477 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2477: [ZEPPELIN-2342] Improving Test Environment for ...
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/2477 [ZEPPELIN-2342] Improving Test Environment for zeppelin-web (e2e, coverage) ### What is this PR for? Improved testing environment for zeppelin-web - added `test:watch` command for continuous testing - displaying coverage report in console - e2e testing in zeppelin-web (can be written easily compare to the zeppelin-server integration tests. For example: [home.spec.js](https://github.com/1ambda/zeppelin/blob/f90deb4bf3db57e36232c9c94ae3b07dfd7c2331/zeppelin-web/e2e/home.spec.js)) This PR adds [a zeppelin-web specific travis profile](https://github.com/1ambda/zeppelin/blob/ad08a3bc0da420f7a7b4771d1aee8bfdd962efa7/.travis.yml#L55) and it usually takes 8-9 mins to execute unit + e2e tests (zeppelin-web) - https://travis-ci.org/1ambda/zeppelin/jobs/252453901 Details - the headless chrome browser works with chromedriver 2.29+ (https://chromium.googlesource.com/chromium/src/+/c75dbfd25cc376b92a494d340259056a01e1432e) - in the case of ubuntu precise (our travis container), should use `/usr/bin/chromium-browser` - `xvfb` is required, please refer https://docs.travis-ci.com/user/gui-and-headless-browsers/#Using-xvfb-to-Run-Tests-That-Require-a-GUI and https://iamakulov.com/notes/install-google-chrome-on-travis/#what-does-the-code-mean - for protractor conf, please check https://github.com/travis-ci/travis-ci/issues/7650#issuecomment-302467188 - can't install stable version of chrome, precise (12.04) support was dropped by chrome - chromium-browser (37.0) is shipped by default in precise and chromedriver version 2.11 is compatible with it. (https://support.saucelabs.com/hc/en-us/articles/225095307-Chromedriver-version-for-each-Chrome-browser-version, https://github.com/travis-ci/travis-ci/issues/5899) ### What type of PR is it? [Improvement] ### Todos * [x] - `test:watch` * [x] - displaying coverage reports in console * [x] - e2e testing in zeppelin-web ### What is the Jira issue? [ZEPPELIN-2342](https://issues.apache.org/jira/browse/ZEPPELIN-2342) ### How should this be tested? CI should be green. If you want to test locally, - stop zeppelin which is running localhost:8080 - `mvn package -DskipTests -DskipRat -Pweb-ci -Pweb-e2e -B` - `mvn verify -DskipRat -pl 'zeppelin-web' -Pweb-ci -Pweb-e2e -B` Screenshots (coverage)  Screenshots (e2e)  ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - YES, updated You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2342/differentiate-unit-and-integration-testing Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2477.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2477 commit e70281bad21ea1d66b21acd6b5e33c84bfcf720f Author: 1ambda <1am...@gmail.com> Date: 2017-07-10T06:38:49Z feat: Use spec repoter and coverage commit 39dc77e4f3b9aab90c101e29a02cecf9a5696c11 Author: 1ambda <1am...@gmail.com> Date: 2017-07-10T07:03:29Z chore: Add test:watch command commit 15473de6b59f8941562f1b6ae10f4c8b13dbaad2 Author: 1ambda <1am...@gmail.com> Date: 2017-07-10T08:29:23Z test: Add a basic e2e test for home commit 76f4f584f4624a63edd5ec4fae09e5d44332bd41 Author: 1ambda <1am...@gmail.com> Date: 2017-07-10T08:33:20Z docs: Update test section in zeppelin-web/README.md commit b5a17a4baf112e89c747d4b18fbff33f6d4a6551 Author: 1ambda <1am...@gmail.com> Date: 2017-07-10T09:26:50Z chore: Bind browser e2e test into CI process commit 742bb961a2691e35084120ceca28639a13671a2f Author: 1ambda <1am...@gmail.com> Date: 2017-07-10T09:40:37Z chore: Exclude e2e specs from RAT commit eb447ef8ef199b72c0a613ecfaef60f55062a48c Author: 1ambda <1am...@gmail.com> Date: 2017-07-10T10:20:44Z WIP: add -X log to selenium profioe commit 2ed397331007e1c4863d983519a30afab958fbc8 Author: 1ambda <1am...@gmail.com> Date: 2017-07-10T11:18:03Z fix: set gecko false for webdriver manager. See https://github.com/angular/webdriver-manager/issues/216 commit 0907d7286dedd83df6afb5bfc11a57b682479c7f Author: 1ambda <1am...@gmail.com> Date: 2017-07-10T11:18:16Z chore: Ingnore protractor conf i
[GitHub] zeppelin pull request #2477: [ZEPPELIN-2342] Improving Test Environment for ...
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2477 [ZEPPELIN-2342] Improving Test Environment for zeppelin-web (e2e, coverage, ..) ### What is this PR for? Improved testing environment for zeppelin-web - added `test:watch` command for continuous testing - displaying coverage report in console - e2e testing in zeppelin-web (can be written easily compare to the zeppelin-server integration tests. For example, check [home.spec.js]()) ### What type of PR is it? [Improvement] ### Todos * [x] - `test:watch` * [x] - displaying coverage reports in console * [x] - e2e testing in zeppelin-web ### What is the Jira issue? [ZEPPELIN-2342](https://issues.apache.org/jira/browse/ZEPPELIN-2342) ### How should this be tested? CI should be green ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - YES, updated You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2342/differentiate-unit-and-integration-testing Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2477.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2477 commit e70281bad21ea1d66b21acd6b5e33c84bfcf720f Author: 1ambda <1am...@gmail.com> Date: 2017-07-10T06:38:49Z feat: Use spec repoter and coverage commit 39dc77e4f3b9aab90c101e29a02cecf9a5696c11 Author: 1ambda <1am...@gmail.com> Date: 2017-07-10T07:03:29Z chore: Add test:watch command commit 15473de6b59f8941562f1b6ae10f4c8b13dbaad2 Author: 1ambda <1am...@gmail.com> Date: 2017-07-10T08:29:23Z test: Add a basic e2e test for home commit 76f4f584f4624a63edd5ec4fae09e5d44332bd41 Author: 1ambda <1am...@gmail.com> Date: 2017-07-10T08:33:20Z docs: Update test section in zeppelin-web/README.md commit b5a17a4baf112e89c747d4b18fbff33f6d4a6551 Author: 1ambda <1am...@gmail.com> Date: 2017-07-10T09:26:50Z chore: Bind browser e2e test into CI process commit 742bb961a2691e35084120ceca28639a13671a2f Author: 1ambda <1am...@gmail.com> Date: 2017-07-10T09:40:37Z chore: Exclude e2e specs from RAT commit eb447ef8ef199b72c0a613ecfaef60f55062a48c Author: 1ambda <1am...@gmail.com> Date: 2017-07-10T10:20:44Z WIP: add -X log to selenium profioe commit 2ed397331007e1c4863d983519a30afab958fbc8 Author: 1ambda <1am...@gmail.com> Date: 2017-07-10T11:18:03Z fix: set gecko false for webdriver manager. See https://github.com/angular/webdriver-manager/issues/216 commit 0907d7286dedd83df6afb5bfc11a57b682479c7f Author: 1ambda <1am...@gmail.com> Date: 2017-07-10T11:18:16Z chore: Ingnore protractor conf in RAT commit 0c09727e95fd1216d6113b53865171466a776852 Author: 1ambda <1am...@gmail.com> Date: 2017-07-10T12:04:17Z fix: Remove -X option from selenium profile commit ca2b17034cddbc398dfac7eff0474ba6d5423f8a Author: 1ambda <1am...@gmail.com> Date: 2017-07-10T13:07:52Z WIP: add -e mvn option to the second profile commit 0c2c1ecbfb4a4c304788177e7e52b95ed8c84757 Author: 1ambda <1am...@gmail.com> Date: 2017-07-10T13:20:07Z chore: Add web-e2e profile to mvn commit 7703615bc41c3be40d1d9f3315c59a9e072f0760 Author: 1ambda <1am...@gmail.com> Date: 2017-07-10T14:01:21Z WIP: Add -X to the second travis profile commit 40ac076ebc78f206cdaf11fe61c5fde220dbc59a Author: 1ambda <1am...@gmail.com> Date: 2017-07-10T16:28:54Z chore: New profile for e2e test only commit f90deb4bf3db57e36232c9c94ae3b07dfd7c2331 Author: 1ambda <1am...@gmail.com> Date: 2017-07-10T16:53:11Z chore: Move web e2e into zeppelin-web --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2472: [ZEPPELIN-2749] Use scalable file structure for...
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2472 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2472: [ZEPPELIN-2749] Use scalable file structure for...
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/2472 [ZEPPELIN-2749] Use scalable file structure for zeppelin web ### What is this PR for? We have improved zeppelin-web, but some parts are still messy. As part of keeping zeppelin-web module healthy ([ZEPPELIN-2725](https://issues.apache.org/jira/browse/ZEPPELIN-2725)), I suggest having these file structure. (Refer the screenshot section) Here are few reasons. - unified directory, file name helps us to recognize, find which part we should modify / fix * Let's say we need to modify the resize feature of paragraph, where the developer can find it? currently, it's under `component/resizable` not under `paragraph/resizeable` and also it's not the shareable component. There is no reason to keep that files in `component/**` - [this structure](https://github.com/toddmotto/angularjs-styleguide#file-naming-conventions) is what the angularjs community has verified for few years. so newly joined developers can feel more comfortable. - this is necessary for [Modular archiecture](https://issues.apache.org/jira/browse/ZEPPELIN-2750) and it eventually helps us to make a smooth transition toward next technologies (even whatever we will use) Additionally, - This is not the meaningless refactoring PR and doesn't block developing new features / fixes (Please refer the `Some Details` section) - I will handle conflicts for few days would be brought by other WIPs For your information, - https://github.com/toddmotto/angularjs-styleguide#file-naming-conventions - https://github.com/johnpapa/angular-styleguide/blob/master/a1/README.md#naming How to Review This PR? Please follow the commits. I modified submodules by splitting commits. Thus commit message includes what has been done in that PR. For example,  Some Details - Didn't change the widely used variable names not to make many conflicts. For example, `websocketMsgSrv`, `arrayOrderingSrv` - Since there are helium packages already published, didn't change the HTML file names like `pivot_setting.html` (it's better to use `pivot-setting.html` if we following the rule) ### What type of PR is it? [Improvement | Refactoring] ### Todos Please refer the commit message. ### What is the Jira issue? [ZEPPELIN-2749](https://issues.apache.org/jira/browse/ZEPPELIN-2749) ### How should this be tested? **All functionalities must work** as like before, CI will test it. ### Screenshots (if appropriate) Before: messy, mixed directory structure  After: only the shared components will be placed under `components/`  ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2749/use-scalable-file-structure-for-zeppelin-web Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2472.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2472 commit c1c210de28579bb0ada8f2b64434f0914e78274a Author: 1ambda <1am...@gmail.com> Date: 2017-07-09T03:12:27Z rename: repository-dialog -> repository-create commit a9a6368a663fce28e8c62a7cebed647fa52075a8 Author: 1ambda <1am...@gmail.com> Date: 2017-07-09T03:14:41Z fix: remove useless dir interpreter-create commit 4e7f6d9c1119a1f82cb34596d089a8c6ef919594 Author: 1ambda <1am...@gmail.com> Date: 2017-07-09T03:16:25Z fix: Move repository-create into interpreter/ commit d7d7434a722ef161289b043f42e5051581fb51bf Author: 1ambda <1am...@gmail.com> Date: 2017-07-09T03:31:06Z move: note specific service saveAsService into notebook/ commit 3f02c5038cd723cc4882c87e8194033ff1ff816b Author: 1ambda <1am...@gmail.com> Date: 2017-07-09T03:33:10Z fix: Remove unused saveAsService from paragraph ctrl commit 701f44320b44675b60f00ab80542944fbc7902fe Author: 1ambda <1am...@gmail.com> Date: 2017-07-09T03:39:52Z move: note specific service into notebook/ commit ad99c04b7c0216dabcf01ba3705e30f7c46fc68c Author: 1ambda <1am...@gmail.com> Date: 2017-07-09T03:50:02Z move
[GitHub] zeppelin issue #2446: [ZEPPELIN-2699] Helium REST API bug-fixes. Also update...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2446 @necosta I just built PR 2446 and remove `/conf/helium.json` and then installed 2 packages and reorder the icons, 1. But it takes longer than before. IMO, we just need to save conf and return new conf. Don't need to fetch new helium json and don't need to build new packages. 2. And It throws an error like  ``` ==> logs/zeppelin-1ambda-1ambda.local.out <== Jul 08, 2017 11:46:14 AM org.glassfish.jersey.server.ServerRuntime$Responder writeResponse SEVERE: An I/O error has occurred while writing a response message entity to the container output stream. org.glassfish.jersey.server.internal.process.MappableException: org.eclipse.jetty.io.EofException at org.glassfish.jersey.server.internal.MappableExceptionWrapperInterceptor.aroundWriteTo(MappableExceptionWrapperInterceptor.java:92) at org.glassfish.jersey.message.internal.WriterInterceptorExecutor.proceed(WriterInterceptorExecutor.java:162) at org.glassfish.jersey.message.internal.MessageBodyFactory.writeTo(MessageBodyFactory.java:1130) at org.glassfish.jersey.server.ServerRuntime$Responder.writeResponse(ServerRuntime.java:711) at org.glassfish.jersey.server.ServerRuntime$Responder.processResponse(ServerRuntime.java:444) at org.glassfish.jersey.server.ServerRuntime$Responder.process(ServerRuntime.java:434) at org.glassfish.jersey.server.ServerRuntime$2.run(ServerRuntime.java:329) at org.glassfish.jersey.internal.Errors$1.call(Errors.java:271) at org.glassfish.jersey.internal.Errors$1.call(Errors.java:267) at org.glassfish.jersey.internal.Errors.process(Errors.java:315) at org.glassfish.jersey.internal.Errors.process(Errors.java:297) at org.glassfish.jersey.internal.Errors.process(Errors.java:267) at org.glassfish.jersey.process.internal.RequestScope.runInScope(RequestScope.java:317) at org.glassfish.jersey.server.ServerRuntime.process(ServerRuntime.java:305) at org.glassfish.jersey.server.ApplicationHandler.handle(ApplicationHandler.java:1154) at org.glassfish.jersey.servlet.WebComponent.serviceImpl(WebComponent.java:473) at org.glassfish.jersey.servlet.WebComponent.service(WebComponent.java:427) at org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:388) at org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:341) at org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:228) at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:812) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1669) at org.apache.zeppelin.server.CorsFilter.doFilter(CorsFilter.java:72) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652) at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:585) at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143) at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:577) at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:223) at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1127) at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:515) at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185) at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1061) at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141) at org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:215) at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:97) at org.eclipse.jetty.server.Server.handle(Server.java:499) at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:311) at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:257) at org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:544) at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:635) at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:555) at java.lang.Thread.run(Thread.java:745) Caused by: org.eclipse.jetty.io.EofExc
[GitHub] zeppelin issue #2472: [ZEPPELIN-2749] Use scalable file structure for zeppel...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2472 Rebased to clean commit messages. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2493: [ZEPPELIN-2778] Unit test for credential module...
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2493 [ZEPPELIN-2778] Unit test for credential module (zeppelin-web) ### What is this PR for? Added few test cases for the credential module under `zeppelin-web/` Additionally, I modified `configuration.html` to add the missing `tbody`. ### What type of PR is it? [Improvement] ### What is the Jira issue? [ZEPPELIN-2778](https://issues.apache.org/jira/browse/ZEPPELIN-2778) ### How should this be tested? 1. cd `zeppelin-web` 2. `yarn install` (or `npm install`) 3. `yarn run test` (or `npm run test`) The test should pass. ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2778/add-unit-test-for-credential-page Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2493.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2493 commit 818d0970d90a5f510075d1791bf6ac04a2494d3d Author: 1ambda <1am...@gmail.com> Date: 2017-07-14T14:08:18Z fix: Remove lodash dependency commit cce91f98236daa89ddfbae51aebed4547997fcdc Author: 1ambda <1am...@gmail.com> Date: 2017-07-14T14:14:52Z fix: Remove unused var commit 904e05131eb9abfbbcbd25829b07d6f491878bfb Author: 1ambda <1am...@gmail.com> Date: 2017-07-14T15:26:21Z refactor: Extract isValidCredential commit 644e49afbbb015ff2b3b60251a0940792247101b Author: 1ambda <1am...@gmail.com> Date: 2017-07-14T15:27:46Z fix: Add guard to update method commit 0c5a22027b2e019a660da4d24a07210ea4185d0d Author: 1ambda <1am...@gmail.com> Date: 2017-07-14T15:38:33Z refactor: Add showToast commit e857047dffb0382fcce98c525e5b07912a0cd75b Author: 1ambda <1am...@gmail.com> Date: 2017-07-14T15:39:55Z style: Re-indent commit b4111f89723312c58cfd0843c1bde70c023dd9c9 Author: 1ambda <1am...@gmail.com> Date: 2017-07-14T15:58:25Z fix: Add missing tbody in credential.html commit 46294be60b54cd3276f4781808bebe150246d58d Author: 1ambda <1am...@gmail.com> Date: 2017-07-14T16:01:26Z test: Add credential.test.js --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2472: [ZEPPELIN-2749] Use scalable file structure for zeppel...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2472 rebased to fix some commit message which can't be handled in the merge script. (`*`) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2493: [ZEPPELIN-2778] Unit test for credential module...
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2493 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2493: [ZEPPELIN-2778] Unit test for credential module...
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/2493 [ZEPPELIN-2778] Unit test for credential module (zeppelin-web) ### What is this PR for? Added few test cases for the credential module under `zeppelin-web/` Additionally, - modified `configuration.html` to add the missing `tbody`. - removed useless lodash dependency ### What type of PR is it? [Improvement] ### What is the Jira issue? [ZEPPELIN-2778](https://issues.apache.org/jira/browse/ZEPPELIN-2778) ### How should this be tested? 1. cd `zeppelin-web` 2. `yarn install` (or `npm install`) 3. `yarn run test` (or `npm run test`) The test should pass. ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2778/add-unit-test-for-credential-page Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2493.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2493 commit 818d0970d90a5f510075d1791bf6ac04a2494d3d Author: 1ambda <1am...@gmail.com> Date: 2017-07-14T14:08:18Z fix: Remove lodash dependency commit cce91f98236daa89ddfbae51aebed4547997fcdc Author: 1ambda <1am...@gmail.com> Date: 2017-07-14T14:14:52Z fix: Remove unused var commit 904e05131eb9abfbbcbd25829b07d6f491878bfb Author: 1ambda <1am...@gmail.com> Date: 2017-07-14T15:26:21Z refactor: Extract isValidCredential commit 644e49afbbb015ff2b3b60251a0940792247101b Author: 1ambda <1am...@gmail.com> Date: 2017-07-14T15:27:46Z fix: Add guard to update method commit 0c5a22027b2e019a660da4d24a07210ea4185d0d Author: 1ambda <1am...@gmail.com> Date: 2017-07-14T15:38:33Z refactor: Add showToast commit e857047dffb0382fcce98c525e5b07912a0cd75b Author: 1ambda <1am...@gmail.com> Date: 2017-07-14T15:39:55Z style: Re-indent commit b4111f89723312c58cfd0843c1bde70c023dd9c9 Author: 1ambda <1am...@gmail.com> Date: 2017-07-14T15:58:25Z fix: Add missing tbody in credential.html commit 46294be60b54cd3276f4781808bebe150246d58d Author: 1ambda <1am...@gmail.com> Date: 2017-07-14T16:01:26Z test: Add credential.test.js commit f8bb092c07ae4fd42ee31e13904cc7283aba3244 Author: 1ambda <1am...@gmail.com> Date: 2017-07-14T16:11:27Z fix: Add verify* to the end of api test commit a0dad5d5da73be5cc389740d5692903f287665d6 Author: 1ambda <1am...@gmail.com> Date: 2017-07-14T16:27:15Z fix: eslint --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2489: [Refactoring] some opportunities to use diamond operat...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2489 @desmorto thanks for the contribution. 1. Could you create a JIRA ticket? 2. files under `/thrift` are auto-generated, so we can't modify. 3. You need to the forked repository for Zeppelin. The name must be `zeppelin`. Please read http://zeppelin.apache.org/contribution/contributions.html#continuous-integration --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2491: [ZEPPELIN-2777] Unit test for configuration mod...
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2491 [ZEPPELIN-2777] Unit test for configuration module (zeppelin-web) ### What is this PR for? Added few test cases for the configuration module under `zeppelin-web/` Additionally, I modified `configuration.html` to add the missing `tbody`. ### What type of PR is it? [Improvement] ### What is the Jira issue? [ZEPPELIN-2777](https://issues.apache.org/jira/browse/ZEPPELIN-2777) ### How should this be tested? 1. cd `zeppelin-web` 2. `yarn install` (or `npm install`) 3. `yarn run test` (or `npm run test`) The test should pass. ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin add-tests-for-zeppelin-web Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2491.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2491 commit 7acf42e795389fd5b4b8e6e415eae15d47f5567b Author: 1ambda <1am...@gmail.com> Date: 2017-07-13T15:39:32Z fix: Remove unused variables commit d6456266216cfc1ceef8699dde7b67a425d17665 Author: 1ambda <1am...@gmail.com> Date: 2017-07-13T15:39:53Z fix: Add missing tbody commit 4c2d1b5961df06b061a296aa9ae74c349945a205 Author: 1ambda <1am...@gmail.com> Date: 2017-07-13T15:40:05Z fix: Add test for configuration commit bf7a70ff6b47585a7f1125695162a6820ab1b00d Author: 1ambda <1am...@gmail.com> Date: 2017-07-14T11:34:05Z fix: Add more test suite for configuration --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2458 @ebuildy I left a comment. Could u check that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2475: [ZEPPELIN-2757] Enhance Authentication decrypting key ...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2475 Left a comment, except for it, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2446: [ZEPPELIN-2699] Helium REST API bug-fixes. Also update...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2446 @necosta Tested locally and it works well. Could you rebase using the current master? since the base branch looks quite old. LGTM except for it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2478: [ZEPPELIN-2761] - Neo4j Interpreter
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2478 Thanks for the great feature! since this is a big change, I guess it takes a time to review and requires multiple reviewers. Let me take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2474: [ZEPPELIN-2753] Basic Implementation of IPython Interp...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2474 Let create a PR to fix the ASCII issue, we can test this PR based on the ASCII PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2462: ZEPPELIN-2527 Changed editor cursor to thin
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2462 Hi, @malayhm Could you take a look the comment I left? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2490: [Zeppelin-2718] Find and replace code in note
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2490 Thanks for implementing such a great feature! 1. Could you rebase against the current master? Since filenames were changes, it would be easier to review after rebasing 2. Regarding UX - It would be nice to provide shortcut to trigger this feature (overriding `CTRL+F`, `CMD+F` or using a different key) - It would be great if cursor move to the next search result if I stroke `enter` key like other editor do. - Can we provide the search result count? (refer the screenshot)  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2458 CI is green, I think jenkins was restarted somehow. - https://travis-ci.org/ebuildy/zeppelin/builds/253975556 LGTM merge if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2489: [Refactoring] some opportunities to use diamond operat...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2489 @desmorto Then could you close and reopen this PR to retrigger jenkins again? https://builds.apache.org/job/zeppelin-pull-request/2363/console --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2500: [ZEPPELIN-2804] Fix shiro_authentication documentation
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2500 @sohaibiftikhar Thanks for the contribution! Travis CI is not set, but this is not relevant with CI. LGTM. merge if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2483 Can we write docs to let the user know they can set these options using maven profile? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2497: [ZEPPELIN-2779] Unit test for job module (zeppe...
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/2497
[ZEPPELIN-2779] Unit test for job module (zeppelin-web)
### What is this PR for?
Added few test cases for the `job` module under `zeppelin-web/`
Additionally,
- removed lodash, q dependency
- converted to `JobModule`
- refactored `jobmanager/*`
### What type of PR is it?
[Improvement]
### What is the Jira issue?
[ZEPPELIN-2779](https://issues.apache.org/jira/browse/ZEPPELIN-2779)
### How should this be tested?
1. cd `zeppelin-web`
2. `yarn install` (or `npm install`)
3. `yarn run test` (or `npm run test`)
The test should pass.
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin
ZEPPELIN-2779/add-unit-test-for-job-page
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2497.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2497
commit eae50011f1d3296f952d4dadb85ada8b2e9baa0b
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-17T12:36:32Z
refactor: Use ng-bind, remove useless ng-if
commit 2b908938fbedf38ff220eeb4b772000900756234
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-17T12:50:41Z
fix: Remove job-control.html
commit 3b21fc83f7631f1824eba30493efdad5c290e7d9
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-17T14:00:09Z
fix: Refactor job-progress-bar
commit 959d91c33b25554dd6171c472ae0fbc4f32a2d78
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-17T14:01:24Z
fix: Remove job-progress-bar.html
commit 99420f860e0d5d149d0e23ce606e748713e1fc8d
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-17T14:02:24Z
fix: Remove job-status
commit 52634bd00ebe5196642b4085f9124d164b77149c
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-17T14:13:59Z
refactor: job.html
commit b34a3762ee793fd9458b0862ee9338a96e46b0b6
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-17T14:27:10Z
refactor: job.controller.js
commit 3ed244607471efebd3d694cd66c284aa58a187b6
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-17T14:44:53Z
fix: Remove lodash dep in job.controller.js
commit dd4598b6f26276dc2a64b7fe6594ed202698e313
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-17T14:47:19Z
fix: Use the word 'Paragraph' instead of 'Job'
commit e0b102d3c740989904b2e3fa54075eeb68cd7dd8
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-17T15:41:09Z
refactor: rename jobs to job
commit 6d8b1a7023f606cf92c68a47e5824efc0645731b
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-18T02:07:18Z
fix: Create job.component.js
commit bb334e087ea75903186ef36ef30aa65209af52fc
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-18T18:23:51Z
test: Add job.component.test.js
commit cc452b982c7db30a3112c7ecd7b95a366de859b8
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-18T18:30:37Z
fix: Use a seperate HTML file for job
commit 22b15a8da53ad7395715658f969f96fb1b843d9c
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-18T18:32:50Z
fix: lint errors in /job
commit a6618b8fe5f31224a0b90651ac648f44995d44dd
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-19T06:44:13Z
fix: Remove lodash dependency in jobmanager
commit 6074c6c6cd063ee6ae7ee0d23d0b930d57b98964
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-19T07:14:23Z
refactor: Rename variables
commit 609c42c5d023c5f3302ed39f14cbb3e9b304882c
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-19T07:17:47Z
refactor: Define job releated filter in jobmanager.js
commit 40b6cf721a2adedfcc2347743206dc104f1c5c79
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-19T07:18:46Z
fix: Remove unused var
commit dce4450913ffb6d120e3c1e77d451b6f874eb3bb
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-19T08:02:56Z
refactor: Remove ng-init
commit c58c6ddb2356ecc26303ed84164955bde0c7fa77
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-19T19:35:07Z
test: job.component.test.js
commit d264a52aaf6cbf20de8dbd7bfbe4478c0d1a7033
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-19T19:38:23Z
fix: Remove q dependency
commit 929b00c641606178dbd5a3847567d818e474fc61
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-20T02:49:56Z
fix: DON'T import job.css in index.html
commit 2c0bd0e651ef0e02a815a9488865f794c937f23c
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-21T08:35:46Z
fix: Add comments
commit 8c2d32fa760c4216fbee5f6e5f6257f71c869035
Author: 1ambda <1am...@gmail
[GitHub] zeppelin pull request #2497: [ZEPPELIN-2779] Unit test for job module (zeppe...
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2497 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2503: [ZEPPELIN-2808] remember me support
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2503 I don't have a preference, but in my experience, many web apps rely on the browser provided remember-me feature. Here is an example of Github sign-in page - https://github.com/login ### Chrome  ### Safari  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2469: [WIP][ZEPPELIN-2726] Move angular related pkgs from bo...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2469 Will be handled later --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2469: [WIP][ZEPPELIN-2726] Move angular related pkgs ...
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2469 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2500: [ZEPPELIN-2804] Fix shiro_authentication documentation
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2500 Deployed - https://zeppelin.apache.org/docs/0.8.0-SNAPSHOT/setup/security/shiro_authentication.html#ldap --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2475: [ZEPPELIN-2757] Enhance Authentication decrypting key ...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2475 @yanboliang Sorry for the late response. Thx for the contribution. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2497: [ZEPPELIN-2779] Unit test for job module (zeppelin-web...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2497 Thanks for the review @sravan-s Merge if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2490: [Zeppelin-2718] Find and replace code in note
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2490 @tinkoff-dwh Thank you for the update. 1. Can we add the shortcut into  2. Can we use more thin border color?  Sorry for the late feedback. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2326 Hi @vipul1409 , Could you check https://github.com/apache/zeppelin/pull/2505? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2490: [Zeppelin-2718] Find and replace code in note
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2490 @tinkoff-dwh It's the default binding in emacs mode. ## in default modes https://github.com/ajaxorg/ace/wiki/Default-Keyboard-Shortcuts  # in emacs mode https://github.com/ajaxorg/ace/blob/master/lib/ace/keyboard/emacs.js#L363 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2503: [ZEPPELIN-2808] remember me support
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2503 Thanks. I updated the previous comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2490: [Zeppelin-2718] Find and replace code in note
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2490 @tinkoff-dwh 1. I realized that `CTRL+F` is bound to `Moving cursor` in paragraphs. Can we use `CTRL + OPT + F` (`ALT` in case of windows OS) or another key what you think better 2. If you change browser size, can't see other buttons like `<`, `replace` and so on. Could you move the find and replace dialog? (I used the half-sized browser)  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2462: ZEPPELIN-2527 Changed editor cursor to thin
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2462 @malayhm cursor is still thick. Should I missing something? or.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2500: [ZEPPELIN-2804] Fix shiro_authentication documentation
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2500 I see. thanks for the answer. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2497: [ZEPPELIN-2779] Unit test for job module (zeppe...
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/2497
[ZEPPELIN-2779] Unit test for job module (zeppelin-web)
### What is this PR for?
Added few test cases for the `job` module under `zeppelin-web/`
Additionally,
- removed lodash, q dependency
- converted to `JobModule`
- refactored `jobmanager/*`
### What type of PR is it?
[Improvement]
### What is the Jira issue?
[ZEPPELIN-2779](https://issues.apache.org/jira/browse/ZEPPELIN-2779)
### How should this be tested?
1. cd `zeppelin-web`
2. `yarn install` (or `npm install`)
3. `yarn run test` (or `npm run test`)
The test should pass.
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin
ZEPPELIN-2779/add-unit-test-for-job-page
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2497.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2497
commit 2349865e7dc2e63ebe13152670c0d9de1e1f7695
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-17T12:36:32Z
refactor: Use ng-bind, remove useless ng-if
commit 0c30422cd9fe5c5742441b8e4b47c97bea011ea7
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-17T12:50:41Z
fix: Remove job-control.html
commit 2439f7ed8eb59b523c4dab25dd06c1ecafd6ab01
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-17T14:00:09Z
fix: Refactor job-progress-bar
commit ca16c997d01c322385ca81cf119eb23a633e356e
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-17T14:01:24Z
fix: Remove job-progress-bar.html
commit dee5e66d0f22266e320dbee2b4b5e282c89695d3
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-17T14:02:24Z
fix: Remove job-status
commit 687970099625288f133a2db773c47a54023cf190
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-17T14:13:59Z
refactor: job.html
commit 504ab1145ef12634ed79f63ff61fbb49cf31c094
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-17T14:27:10Z
refactor: job.controller.js
commit f7c769cbab1a856b00e6f6edc98247ffc536b90b
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-17T14:44:53Z
fix: Remove lodash dep in job.controller.js
commit 379394ad6d9ab3d6fdc2f47d097841d31bed817e
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-17T14:47:19Z
fix: Use the word 'Paragraph' instead of 'Job'
commit 3762abe80229ef5b30465801834c0fa353894e58
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-17T15:41:09Z
refactor: rename jobs to job
commit 5ba277242ca3c3701b37adcd81cbd24635f4d1ac
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-18T02:07:18Z
fix: Create job.component.js
commit 3dcf5da9b27028ede267c4f1d733f88a0ebd08cc
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-18T18:23:51Z
test: Add job.component.test.js
commit bc6e24fa156b9b20cdb4a50c5af5808072d6b429
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-18T18:30:37Z
fix: Use a seperate HTML file for job
commit e88600d944eef8cf73e94d7d6dfbcb54cb51913e
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-18T18:32:50Z
fix: lint errors in /job
commit 2af5c2db52dac1c2c35ef07323fed448dfae191c
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-19T06:44:13Z
fix: Remove lodash dependency in jobmanager
commit 6176e59dd38502dc3349b83ca3d8e0bb5e0aeea2
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-19T07:14:23Z
refactor: Rename variables
commit f1f4c6d35ab6bf814794bf321d7cec25af13f5e4
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-19T07:17:47Z
refactor: Define job releated filter in jobmanager.js
commit 954943dadb535d8d4bf3070f70b47d8c3eeebd07
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-19T07:18:46Z
fix: Remove unused var
commit 7f088c17f0392fe602a83aef4731c3495a8d0c45
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-19T08:02:56Z
refactor: Remove ng-init
commit f3431860127c571a5d2947fe5118f6700404fddc
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-19T19:35:07Z
test: job.component.test.js
commit 41e76c695651e1ba6d52d74415889da53b315099
Author: 1ambda <1am...@gmail.com>
Date: 2017-07-19T19:38:23Z
fix: Remove q dependency
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2489: [Refactoring] some opportunities to use diamond operat...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2489 It says `Looks like travis-ci is not configured for your fork.` If you set already travis CI for your fork, could you provide the link? i can help u. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
