[jira] [Updated] (ZOOKEEPER-1988) new test patch to verify dynamic reconfig backward compatibility
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Shraer updated ZOOKEEPER-1988: Attachment: ZOOKEEPER-1987-ver6.patch good catch! attached file has a fix. Basically just checking for null in PathUtils. > new test patch to verify dynamic reconfig backward compatibility > > > Key: ZOOKEEPER-1988 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1988 > Project: ZooKeeper > Issue Type: Sub-task > Components: tests >Reporter: Raul Gutierrez Segales >Assignee: Alexander Shraer > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1987-ver4.patch, ZOOKEEPER-1987-ver5.patch, > ZOOKEEPER-1987-ver6.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1988) new test patch to verify dynamic reconfig backward compatibility
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074086#comment-14074086
]
Rakesh R commented on ZOOKEEPER-1988:
-
[~shralex] IMHO we need to handle one more case. I'm getting the following
exception, this happens when starting the server without the dynamic config
file.
{code}
2014-07-25 10:37:23,559 [myid:1] - INFO [Thread-1:QuorumPeer@1253] - initLimit
set to 10
2014-07-25 10:37:23,559 [myid:2] - ERROR
[Thread-2:QuorumPeerTestBase$MainThread@162] - unexpected exception in run
java.lang.NullPointerException
at
org.apache.zookeeper.common.PathUtils.normalizeFileSystemPath(PathUtils.java:108)
at
org.apache.zookeeper.server.quorum.QuorumPeer.setDynamicConfigFilename(QuorumPeer.java:322)
at
org.apache.zookeeper.server.quorum.QuorumPeerMain.runFromConfig(QuorumPeerMain.java:157)
at
org.apache.zookeeper.server.quorum.QuorumPeerMain.initializeAndRun(QuorumPeerMain.java:120)
at
org.apache.zookeeper.server.quorum.QuorumPeerTestBase$MainThread.run(QuorumPeerTestBase.java:159)
at java.lang.Thread.run(Thread.java:619)
{code}
> new test patch to verify dynamic reconfig backward compatibility
>
>
> Key: ZOOKEEPER-1988
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1988
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: tests
>Reporter: Raul Gutierrez Segales
>Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1987-ver4.patch, ZOOKEEPER-1987-ver5.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1988) new test patch to verify dynamic reconfig backward compatibility
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074049#comment-14074049 ] Alexander Shraer commented on ZOOKEEPER-1988: - [~rakeshr] does the latest patch still solve the problem on windows ? if so can you please commit it ? Thanks, Alex > new test patch to verify dynamic reconfig backward compatibility > > > Key: ZOOKEEPER-1988 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1988 > Project: ZooKeeper > Issue Type: Sub-task > Components: tests >Reporter: Raul Gutierrez Segales >Assignee: Alexander Shraer > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1987-ver4.patch, ZOOKEEPER-1987-ver5.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1989) backward compatibility of zoo.cfg
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073986#comment-14073986
]
Alexander Shraer commented on ZOOKEEPER-1989:
-
Sure.
zookeeper/server/quorum/QuorumPeerConfig.java is where the config files are
being read.
I think that you should add a new boolean field to this class, something like
"reconfigDisabled"
look for this code:
// backward compatibility - dynamic configuration in the same file as
// static configuration params see writeDynamicConfig() - we change the
// config file to new format if reconfig happens
if (dynamicConfigFileStr == null) {
configBackwardCompatibilityMode = true;
quorumVerifier = parseDynamicConfig(zkProp, electionAlg, true,
configBackwardCompatibilityMode);
checkValidity();
}
in checkValidity or after it, you should do something like this:
for (QuorumServer s: quorumVerifier.getAllMembers().values()) {
if (s.clientAddr == null) {
reconfigDisabled = true;
}
}
Next, in QuorumPeerMain you need to do something like this:
quorumPeer.setReconfigEnabled(config.isReconfigEnabled());
When the leader receives a reconfig command it executes this code:
zookeeper/server/PrepRequestProcessor.java, look for case OpCode.reconfig:
This is where you'd need to throw an exception if lzks.self.isReconfigEnabled()
== false
perhaps an APIERROR exception, not sure.
Next, you'll need to make sure that the config file is not being edited and a
dynamic file is not created.
This can also be done in setQuorumVerifier of QuorumPeer.java. Just check
self.isReconfigEnabled()
where configBackwardCompatibility is checked.
Take a look also on setLastSeenQuorumVerifier. I don't think you should change
it though, because we're not gonna have reconfigs in this mode.
Regarding the test - once ZOOKEEPER-1988 is committed you can add a test to
test/org/apache/zookeeper/server/quorum/DynamicConfigBackwardCompatibilityTest.java
Look on ReconfigRecoveryTest to see how to invoke a reconfig, and just make
sure you get an assertion back if your test starts from an old-style config
file. In order to write static config file only do what the test in
DynamicConfigBackwardCompatibilityTest does - mt[i] = new MainThread(i,
clientPorts[i], currentQuorumCfgSection, false);
the last parameter "false" means "don't write a dynamic config file"
good luck!
Alex
> backward compatibility of zoo.cfg
> -
>
> Key: ZOOKEEPER-1989
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1989
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: tests
>Affects Versions: 3.5.0
>Reporter: Hongchao Deng
>Assignee: Hongchao Deng
>Priority: Blocker
> Fix For: 3.5.0
>
>
> Before 3.5.x, users define zoo.cfg with "clientPort" parameter which is used
> to identify on which port the server is serving clients.
> After upgrading to 3.5.x, the new format:
> {noformat}
> server.$id=$addr:$port1:$port2[:$role];[$cliAddr:]$cliPort
> {noformat}
> force users to define all the client ports on the entire ZK ensemble.
> The goal of this issue is to preserve backward compatibility upgrading 3.4 to
> 3.5.
> 1. when a user defines an old-style config file, it should function the same
> as the old way -- It should use clientPort variable and shouldn't create a
> dynamic file.
> 2. when a user with old-style config file tries to do reconfig relevant jobs,
> it should stop him and give out a warning.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1989) backward compatibility of zoo.cfg
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073934#comment-14073934
]
Hongchao Deng commented on ZOOKEEPER-1989:
--
[~shralex]
Can you share pointers to the code where I should jump away from reconfig
relevant?
> backward compatibility of zoo.cfg
> -
>
> Key: ZOOKEEPER-1989
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1989
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: tests
>Affects Versions: 3.5.0
>Reporter: Hongchao Deng
>Assignee: Hongchao Deng
>Priority: Blocker
> Fix For: 3.5.0
>
>
> Before 3.5.x, users define zoo.cfg with "clientPort" parameter which is used
> to identify on which port the server is serving clients.
> After upgrading to 3.5.x, the new format:
> {noformat}
> server.$id=$addr:$port1:$port2[:$role];[$cliAddr:]$cliPort
> {noformat}
> force users to define all the client ports on the entire ZK ensemble.
> The goal of this issue is to preserve backward compatibility upgrading 3.4 to
> 3.5.
> 1. when a user defines an old-style config file, it should function the same
> as the old way -- It should use clientPort variable and shouldn't create a
> dynamic file.
> 2. when a user with old-style config file tries to do reconfig relevant jobs,
> it should stop him and give out a warning.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1933) Windows release build of zk client cannot connect to zk server
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073877#comment-14073877
]
Hadoop QA commented on ZOOKEEPER-1933:
--
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12657717/ZOOKEEPER-1933.patch
against trunk revision 1613326.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 4 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2231//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2231//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2231//console
This message is automatically generated.
> Windows release build of zk client cannot connect to zk server
> --
>
> Key: ZOOKEEPER-1933
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1933
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
>Affects Versions: 3.4.6
>Reporter: Norris Lee
>Assignee: Orion Hodson
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1933-2.patch, ZOOKEEPER-1933-3.patch,
> ZOOKEEPER-1933.patch, ZOOKEEPER-1933.patch, ZOOKEEPER-1933.patch,
> ZOOKEEPER-1933.patch
>
>
> When building zookeeper in Visual Studio in debug mode, the client can
> connect to the server without error. When building in release mode, I get a
> continuous error message:
> {code}
> 2014-06-02 11:25:20,070:7144(0xc84):ZOO_INFO@zookeeper_init_internal@1008:
> Initiating client connection, host=192.168.39.43:5181 sessionTimeout=3
> watcher=10049C90 sessionId=0 sessionPasswd= context=001FC0F0 flags=0
> 2014-06-02 11:25:20,072:7144(0xc84):ZOO_DEBUG@start_threads@221: starting
> threads...
> 2014-06-02 11:25:20,072:7144(0x1ea0):ZOO_DEBUG@do_completion@460: started
> completion thread
> 2014-06-02 11:25:20,072:7144(0x1e08):ZOO_DEBUG@do_io@403: started IO thread
> 2014-06-02
> 11:25:20,072:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1148: [OLD]
> count=0 capacity=0 next=0 hasnext=0
> 2014-06-02
> 11:25:20,072:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1151: [NEW]
> count=1 capacity=16 next=0 hasnext=1
> 2014-06-02
> 11:25:20,072:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1160: Using
> next from NEW=192.168.39.43:5181
> 2014-06-02 11:25:20,072:7144(0x1e08):ZOO_DEBUG@zookeeper_interest@1992: [zk]
> connect()
> 2014-06-02 11:25:20,158:7144(0x1e08):ZOO_ERROR@handle_socket_error_msg@1847:
> Socket [192.168.39.43:5181] zk retcode=-4, errno=10035(Unknown error): failed
> to send a handshake packet: Unknown error
> 2014-06-02 11:25:20,158:7144(0x1e08):ZOO_DEBUG@handle_error@1595: Previous
> connection=[192.168.39.43:5181] delay=0
> 2014-06-02
> 11:25:20,158:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1148: [OLD]
> count=0 capacity=0 next=0 hasnext=0
> 2014-06-02
> 11:25:20,158:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1151: [NEW]
> count=1 capacity=16 next=0 hasnext=1
> 2014-06-02
> 11:25:20,158:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1160: Using
> next from NEW=192.168.39.43:5181
> 2014-06-02 11:25:20,158:7144(0x1e08):ZOO_DEBUG@zookeeper_interest@1992: [zk]
> connect()
> 2014-06-02 11:25:20,159:7144(0x1e08):ZOO_ERROR@handle_socket_error_msg@1847:
> Socket [192.168.39.43:5181] zk retcode=-4, errno=10035(Unknown error): failed
> to send a handshake packet: Unknown error
> 2014-06-02 11:25:20,159:7144(0x1e08):ZOO_DEBUG@handle_error@1595: Previous
> connection=[192.168.39.43:5181] delay=0
> 2014-06-02
> 11:25:20,159:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1148: [OLD]
> count=0 capacity=0 next=0 hasnext=0
> 2014-06-02
> 11:25:20,159:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1151: [NEW]
> count=1 capacity=16 next=0 hasnext=1
> 2014-06-02
> 11:25:20,159:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1160: Using
> next from NEW=192.168.39.43:5181
> 2014-06-02 11:25:20,159:7144(0x1e08):ZOO_DEBUG@zookeeper_interest@1992: [zk]
> connect()
> 2014-06-02 11:25:20,159:7144(0x1e08):ZOO_ERROR@handle_socket_error_msg@1847:
> Socket [192.168.39.43:5181] zk retcode=-4, errno=10035(Unknown err
Failed: ZOOKEEPER-1933 PreCommit Build #2231
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1933 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2231/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 310333 lines...] [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 4 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2231//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2231//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2231//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 65d05f0d3cdf26356927ce4bd43eab58369dcfd5 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1713: exec returned: 1 Total time: 37 minutes 51 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2179 Archived 7 artifacts Archive block size is 32768 Received 0 blocks and 546308 bytes Compression is 0.0% Took 3.2 sec Recording test results Description set: ZOOKEEPER-1933 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## 1 tests failed. FAILED: org.apache.zookeeper.test.NioNettySuiteHammerTest.testHammer Error Message: Forked Java VM exited abnormally. Please note the time in the report does not reflect the time until the VM exit. Stack Trace: junit.framework.AssertionFailedError: Forked Java VM exited abnormally. Please note the time in the report does not reflect the time until the VM exit.
[jira] [Commented] (ZOOKEEPER-1933) Windows release build of zk client cannot connect to zk server
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073875#comment-14073875
]
Raul Gutierrez Segales commented on ZOOKEEPER-1933:
---
lgtm, +1. some nits though, take them or leave them:
{noformat}
+rc = select(/* unused */0, &rfds, &wfds, NULL, &tv);
+if (rc > 0)
+{
{noformat}
I think
{noformat}
if (rc > 0) {
{noformat}
is more consistent with the rest of the file (i.e.: the prev if block, etc.).
{noformat}
+interest=(FD_ISSET(fd, &rfds))?ZOOKEEPER_READ:0;
+interest|=(FD_ISSET(fd, &wfds))?ZOOKEEPER_WRITE:0;
+
{noformat}
spaces around =, |=, ? and : please.
{noformat}
+if (FD_ISSET(adaptor_threads->self_pipe[0], &rfds)){
{noformat}
space between ) and { please.
{noformat}
+else if (rc < 0)
+{
{noformat}
should be
{noformat}
else if (rc < 0) {
{noformat}
for code style consistency.
And finally:
{noformat}
+
+void testBadDescriptor() {
+int zrc = 0;
+watchctx_t *ctx;
+zhandle_t *zh = zookeeper_init(hostPorts, NULL, 1, 0, ctx, 0);
+sleep(1);
+ zh->io_count = 0;
+ //close socket
+ close(zh->fd);
+ sleep(1);
+ //Check that doIo isn't spinning
+ CPPUNIT_ASSERT(zh->io_count < 2);
+zookeeper_close(zh);
+}
{noformat}
has weird indentation - mixing tabs and spaces perhaps?
> Windows release build of zk client cannot connect to zk server
> --
>
> Key: ZOOKEEPER-1933
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1933
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
>Affects Versions: 3.4.6
>Reporter: Norris Lee
>Assignee: Orion Hodson
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1933-2.patch, ZOOKEEPER-1933-3.patch,
> ZOOKEEPER-1933.patch, ZOOKEEPER-1933.patch, ZOOKEEPER-1933.patch,
> ZOOKEEPER-1933.patch
>
>
> When building zookeeper in Visual Studio in debug mode, the client can
> connect to the server without error. When building in release mode, I get a
> continuous error message:
> {code}
> 2014-06-02 11:25:20,070:7144(0xc84):ZOO_INFO@zookeeper_init_internal@1008:
> Initiating client connection, host=192.168.39.43:5181 sessionTimeout=3
> watcher=10049C90 sessionId=0 sessionPasswd= context=001FC0F0 flags=0
> 2014-06-02 11:25:20,072:7144(0xc84):ZOO_DEBUG@start_threads@221: starting
> threads...
> 2014-06-02 11:25:20,072:7144(0x1ea0):ZOO_DEBUG@do_completion@460: started
> completion thread
> 2014-06-02 11:25:20,072:7144(0x1e08):ZOO_DEBUG@do_io@403: started IO thread
> 2014-06-02
> 11:25:20,072:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1148: [OLD]
> count=0 capacity=0 next=0 hasnext=0
> 2014-06-02
> 11:25:20,072:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1151: [NEW]
> count=1 capacity=16 next=0 hasnext=1
> 2014-06-02
> 11:25:20,072:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1160: Using
> next from NEW=192.168.39.43:5181
> 2014-06-02 11:25:20,072:7144(0x1e08):ZOO_DEBUG@zookeeper_interest@1992: [zk]
> connect()
> 2014-06-02 11:25:20,158:7144(0x1e08):ZOO_ERROR@handle_socket_error_msg@1847:
> Socket [192.168.39.43:5181] zk retcode=-4, errno=10035(Unknown error): failed
> to send a handshake packet: Unknown error
> 2014-06-02 11:25:20,158:7144(0x1e08):ZOO_DEBUG@handle_error@1595: Previous
> connection=[192.168.39.43:5181] delay=0
> 2014-06-02
> 11:25:20,158:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1148: [OLD]
> count=0 capacity=0 next=0 hasnext=0
> 2014-06-02
> 11:25:20,158:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1151: [NEW]
> count=1 capacity=16 next=0 hasnext=1
> 2014-06-02
> 11:25:20,158:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1160: Using
> next from NEW=192.168.39.43:5181
> 2014-06-02 11:25:20,158:7144(0x1e08):ZOO_DEBUG@zookeeper_interest@1992: [zk]
> connect()
> 2014-06-02 11:25:20,159:7144(0x1e08):ZOO_ERROR@handle_socket_error_msg@1847:
> Socket [192.168.39.43:5181] zk retcode=-4, errno=10035(Unknown error): failed
> to send a handshake packet: Unknown error
> 2014-06-02 11:25:20,159:7144(0x1e08):ZOO_DEBUG@handle_error@1595: Previous
> connection=[192.168.39.43:5181] delay=0
> 2014-06-02
> 11:25:20,159:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1148: [OLD]
> count=0 capacity=0 next=0 hasnext=0
> 2014-06-02
> 11:25:20,159:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1151: [NEW]
> count=1 capacity=16 next=0 hasnext=1
> 2014-06-02
> 11:25:20,159:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1160: Using
> next from NEW=192.168.39.43:5181
> 2014-06-02 11:25:20,159:7144(0x1e08):ZOO_DEBUG@zookeeper_interest@1992: [zk]
> connect()
> 2014-06-02 11:25:20,159:7144(0x1e08):ZOO_ERROR@handle_socket_error
Re: ZooKeeper 3.5.0-alpha planning
Can someone take a look at this issue? The windows c client build is failing for a while now, would be great to fix this for 3.5.0... ZOOKEEPER-1974 winvs2008 jenkins job failing with "unresolved external symbol" Patrick On Thu, Jul 24, 2014 at 10:19 AM, Raúl Gutiérrez Segalés wrote: > On 24 July 2014 09:47, Patrick Hunt wrote: > >> We've identified the issues with 1987, it would be good if folks could >> take a look. > > > Great - thanks Patrick. Added some comments to the patch. > > >> Nothing looks unsolvable, but we should tweak things a >> bit before 3.5.0, esp given the current upgrade experience. The new >> docs will help a lot - see >> https://issues.apache.org/jira/browse/ZOOKEEPER-1660 which we need to >> review and commit. >> > > Reading the docs, will follow-up with comments. > > > -rgs
[jira] [Updated] (ZOOKEEPER-1933) Windows release build of zk client cannot connect to zk server
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flavio Junqueira updated ZOOKEEPER-1933:
Attachment: ZOOKEEPER-1933.patch
Attaching new patch.
> Windows release build of zk client cannot connect to zk server
> --
>
> Key: ZOOKEEPER-1933
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1933
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
>Affects Versions: 3.4.6
>Reporter: Norris Lee
>Assignee: Orion Hodson
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1933-2.patch, ZOOKEEPER-1933-3.patch,
> ZOOKEEPER-1933.patch, ZOOKEEPER-1933.patch, ZOOKEEPER-1933.patch,
> ZOOKEEPER-1933.patch
>
>
> When building zookeeper in Visual Studio in debug mode, the client can
> connect to the server without error. When building in release mode, I get a
> continuous error message:
> {code}
> 2014-06-02 11:25:20,070:7144(0xc84):ZOO_INFO@zookeeper_init_internal@1008:
> Initiating client connection, host=192.168.39.43:5181 sessionTimeout=3
> watcher=10049C90 sessionId=0 sessionPasswd= context=001FC0F0 flags=0
> 2014-06-02 11:25:20,072:7144(0xc84):ZOO_DEBUG@start_threads@221: starting
> threads...
> 2014-06-02 11:25:20,072:7144(0x1ea0):ZOO_DEBUG@do_completion@460: started
> completion thread
> 2014-06-02 11:25:20,072:7144(0x1e08):ZOO_DEBUG@do_io@403: started IO thread
> 2014-06-02
> 11:25:20,072:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1148: [OLD]
> count=0 capacity=0 next=0 hasnext=0
> 2014-06-02
> 11:25:20,072:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1151: [NEW]
> count=1 capacity=16 next=0 hasnext=1
> 2014-06-02
> 11:25:20,072:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1160: Using
> next from NEW=192.168.39.43:5181
> 2014-06-02 11:25:20,072:7144(0x1e08):ZOO_DEBUG@zookeeper_interest@1992: [zk]
> connect()
> 2014-06-02 11:25:20,158:7144(0x1e08):ZOO_ERROR@handle_socket_error_msg@1847:
> Socket [192.168.39.43:5181] zk retcode=-4, errno=10035(Unknown error): failed
> to send a handshake packet: Unknown error
> 2014-06-02 11:25:20,158:7144(0x1e08):ZOO_DEBUG@handle_error@1595: Previous
> connection=[192.168.39.43:5181] delay=0
> 2014-06-02
> 11:25:20,158:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1148: [OLD]
> count=0 capacity=0 next=0 hasnext=0
> 2014-06-02
> 11:25:20,158:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1151: [NEW]
> count=1 capacity=16 next=0 hasnext=1
> 2014-06-02
> 11:25:20,158:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1160: Using
> next from NEW=192.168.39.43:5181
> 2014-06-02 11:25:20,158:7144(0x1e08):ZOO_DEBUG@zookeeper_interest@1992: [zk]
> connect()
> 2014-06-02 11:25:20,159:7144(0x1e08):ZOO_ERROR@handle_socket_error_msg@1847:
> Socket [192.168.39.43:5181] zk retcode=-4, errno=10035(Unknown error): failed
> to send a handshake packet: Unknown error
> 2014-06-02 11:25:20,159:7144(0x1e08):ZOO_DEBUG@handle_error@1595: Previous
> connection=[192.168.39.43:5181] delay=0
> 2014-06-02
> 11:25:20,159:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1148: [OLD]
> count=0 capacity=0 next=0 hasnext=0
> 2014-06-02
> 11:25:20,159:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1151: [NEW]
> count=1 capacity=16 next=0 hasnext=1
> 2014-06-02
> 11:25:20,159:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1160: Using
> next from NEW=192.168.39.43:5181
> 2014-06-02 11:25:20,159:7144(0x1e08):ZOO_DEBUG@zookeeper_interest@1992: [zk]
> connect()
> 2014-06-02 11:25:20,159:7144(0x1e08):ZOO_ERROR@handle_socket_error_msg@1847:
> Socket [192.168.39.43:5181] zk retcode=-4, errno=10035(Unknown error): failed
> to send a handshake packet: Unknown error
> 2014-06-02 11:25:20,159:7144(0x1e08):ZOO_DEBUG@handle_error@1595: Previous
> connection=[192.168.39.43:5181] delay=0
> 2014-06-02
> 11:25:20,159:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1148: [OLD]
> count=0 capacity=0 next=0 hasnext=0
> 2014-06-02
> 11:25:20,159:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1151: [NEW]
> count=1 capacity=16 next=0 hasnext=1
> 2014-06-02
> 11:25:20,159:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1160: Using
> next from NEW=192.168.39.43:5181
> 2014-06-02 11:25:20,159:7144(0x1e08):ZOO_DEBUG@zookeeper_interest@1992: [zk]
> connect()
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (ZOOKEEPER-1877) Malformed ACL Id can crash server with skipACL=yes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-1877: Priority: Critical (was: Major) > Malformed ACL Id can crash server with skipACL=yes > -- > > Key: ZOOKEEPER-1877 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1877 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.5.0 >Reporter: Chris Chen >Assignee: Chris Chen >Priority: Critical > Attachments: ZOOKEEPER-1877.patch > > > Because of the way fixupACL is written in PrepRequestProcessor, a request > that feeds in an ACL with null members in the Id will cause a server with > skipACL=yes to crash. > A patch will be provided that re-introduces checks for well-formed ACLs even > if skipACL is enabled. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (ZOOKEEPER-1937) init script needs fixing for ZOOKEEPER-1719
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Hunt updated ZOOKEEPER-1937:
Attachment: ZOOKEEPER-1937.patch
> init script needs fixing for ZOOKEEPER-1719
> ---
>
> Key: ZOOKEEPER-1937
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1937
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.4.6
> Environment: Linux (Ubuntu 12.04)
>Reporter: Nathan Sullivan
>Assignee: Marshall McMullen
> Attachments: ZOOKEEPER-1719.patch, ZOOKEEPER-1937.patch
>
>
> ZOOKEEPER-1719 changed the interpreter to bash for zkCli.sh, zkServer.sh and
> zkEnv.sh, but did not change src/packages/deb/init.d/zookeeper
> This causes the following failure using /bin/sh
> [...] root@hostname:~# service zookeeper stop
> /etc/init.d/zookeeper: 81: /usr/libexec/zkEnv.sh: Syntax error: "("
> unexpected (expecting "fi")
> Simple fix, change the shebang to #!/bin/bash - tested and works fine.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1274) Support child watches to be displayed with 4 letter zookeeper commands (i.e. wchs, wchp and wchc)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073811#comment-14073811 ] Patrick Hunt commented on ZOOKEEPER-1274: - [~rgs] how do you want to handle the new jetty server support being added? Commit this regardless, or would you like to update the patch to include support for exposing in the jetty server as well? > Support child watches to be displayed with 4 letter zookeeper commands (i.e. > wchs, wchp and wchc) > - > > Key: ZOOKEEPER-1274 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1274 > Project: ZooKeeper > Issue Type: Bug > Components: server > Environment: Zookeeper Server >Reporter: amith >Assignee: Raul Gutierrez Segales > Fix For: 3.5.0 > > Attachments: > 0001-ZOOKEEPER-1274.-Display-child-watches-info-in-watch-.patch, > ZOOKEEPER-1274.patch > > > currently only data watchers (created by exists() and getdata() )are getting > displayed with wchs,wchp,wchc 4 letter command command > It would be useful to get the infomation related to childwatchers ( > getChildren() ) also with 4 letter words. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1933) Windows release build of zk client cannot connect to zk server
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073810#comment-14073810
]
Patrick Hunt commented on ZOOKEEPER-1933:
-
This seems like it's pretty serious (per the subject) and we have a bit of
time, any chance we can get this into 3.5.0? [~fpj] , [~michim], [~rgs], et.
al.?
> Windows release build of zk client cannot connect to zk server
> --
>
> Key: ZOOKEEPER-1933
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1933
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
>Affects Versions: 3.4.6
>Reporter: Norris Lee
>Assignee: Orion Hodson
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1933-2.patch, ZOOKEEPER-1933-3.patch,
> ZOOKEEPER-1933.patch, ZOOKEEPER-1933.patch, ZOOKEEPER-1933.patch
>
>
> When building zookeeper in Visual Studio in debug mode, the client can
> connect to the server without error. When building in release mode, I get a
> continuous error message:
> {code}
> 2014-06-02 11:25:20,070:7144(0xc84):ZOO_INFO@zookeeper_init_internal@1008:
> Initiating client connection, host=192.168.39.43:5181 sessionTimeout=3
> watcher=10049C90 sessionId=0 sessionPasswd= context=001FC0F0 flags=0
> 2014-06-02 11:25:20,072:7144(0xc84):ZOO_DEBUG@start_threads@221: starting
> threads...
> 2014-06-02 11:25:20,072:7144(0x1ea0):ZOO_DEBUG@do_completion@460: started
> completion thread
> 2014-06-02 11:25:20,072:7144(0x1e08):ZOO_DEBUG@do_io@403: started IO thread
> 2014-06-02
> 11:25:20,072:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1148: [OLD]
> count=0 capacity=0 next=0 hasnext=0
> 2014-06-02
> 11:25:20,072:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1151: [NEW]
> count=1 capacity=16 next=0 hasnext=1
> 2014-06-02
> 11:25:20,072:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1160: Using
> next from NEW=192.168.39.43:5181
> 2014-06-02 11:25:20,072:7144(0x1e08):ZOO_DEBUG@zookeeper_interest@1992: [zk]
> connect()
> 2014-06-02 11:25:20,158:7144(0x1e08):ZOO_ERROR@handle_socket_error_msg@1847:
> Socket [192.168.39.43:5181] zk retcode=-4, errno=10035(Unknown error): failed
> to send a handshake packet: Unknown error
> 2014-06-02 11:25:20,158:7144(0x1e08):ZOO_DEBUG@handle_error@1595: Previous
> connection=[192.168.39.43:5181] delay=0
> 2014-06-02
> 11:25:20,158:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1148: [OLD]
> count=0 capacity=0 next=0 hasnext=0
> 2014-06-02
> 11:25:20,158:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1151: [NEW]
> count=1 capacity=16 next=0 hasnext=1
> 2014-06-02
> 11:25:20,158:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1160: Using
> next from NEW=192.168.39.43:5181
> 2014-06-02 11:25:20,158:7144(0x1e08):ZOO_DEBUG@zookeeper_interest@1992: [zk]
> connect()
> 2014-06-02 11:25:20,159:7144(0x1e08):ZOO_ERROR@handle_socket_error_msg@1847:
> Socket [192.168.39.43:5181] zk retcode=-4, errno=10035(Unknown error): failed
> to send a handshake packet: Unknown error
> 2014-06-02 11:25:20,159:7144(0x1e08):ZOO_DEBUG@handle_error@1595: Previous
> connection=[192.168.39.43:5181] delay=0
> 2014-06-02
> 11:25:20,159:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1148: [OLD]
> count=0 capacity=0 next=0 hasnext=0
> 2014-06-02
> 11:25:20,159:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1151: [NEW]
> count=1 capacity=16 next=0 hasnext=1
> 2014-06-02
> 11:25:20,159:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1160: Using
> next from NEW=192.168.39.43:5181
> 2014-06-02 11:25:20,159:7144(0x1e08):ZOO_DEBUG@zookeeper_interest@1992: [zk]
> connect()
> 2014-06-02 11:25:20,159:7144(0x1e08):ZOO_ERROR@handle_socket_error_msg@1847:
> Socket [192.168.39.43:5181] zk retcode=-4, errno=10035(Unknown error): failed
> to send a handshake packet: Unknown error
> 2014-06-02 11:25:20,159:7144(0x1e08):ZOO_DEBUG@handle_error@1595: Previous
> connection=[192.168.39.43:5181] delay=0
> 2014-06-02
> 11:25:20,159:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1148: [OLD]
> count=0 capacity=0 next=0 hasnext=0
> 2014-06-02
> 11:25:20,159:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1151: [NEW]
> count=1 capacity=16 next=0 hasnext=1
> 2014-06-02
> 11:25:20,159:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1160: Using
> next from NEW=192.168.39.43:5181
> 2014-06-02 11:25:20,159:7144(0x1e08):ZOO_DEBUG@zookeeper_interest@1992: [zk]
> connect()
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (ZOOKEEPER-1988) new test patch to verify dynamic reconfig backward compatibility
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-1988: Summary: new test patch to verify dynamic reconfig backward compatibility (was: new test patch) > new test patch to verify dynamic reconfig backward compatibility > > > Key: ZOOKEEPER-1988 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1988 > Project: ZooKeeper > Issue Type: Sub-task > Components: tests >Reporter: Raul Gutierrez Segales >Assignee: Alexander Shraer > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1987-ver4.patch, ZOOKEEPER-1987-ver5.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1987) unable to restart 3 node cluster
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073753#comment-14073753 ] Hongchao Deng commented on ZOOKEEPER-1987: -- [~shralex] My first thought is that it's a little ambiguous to put version under the server list. It's best to give reusable config file. A version and other info could be separated. > Storing the version in a separate file creates a problem of keeping this file > in sync with the dynamic config file. It's doable. A server can hold acking back until files are finished. And it takes the final written file as a flag. Anyway, it's a bit of work but doable. > unable to restart 3 node cluster > > > Key: ZOOKEEPER-1987 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1987 > Project: ZooKeeper > Issue Type: Bug > Components: tests >Affects Versions: 3.5.0 >Reporter: Patrick Hunt >Assignee: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1987-ver1.patch, ZOOKEEPER-1987-ver2.patch, > ZOOKEEPER-1987-ver3.patch, ZOOKEEPER-1987.patch, f1.jstack, l3.jstack, > test3.tar.gz > > > I tried a fairly simple test, start a three node cluster, bring it down, then > restart it. On restart the servers elect the leader and send updates, however > the negotiation never completes - the client ports are never bound for > example. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1660) Add documentation for dynamic reconfiguration
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073729#comment-14073729 ] Alexander Shraer commented on ZOOKEEPER-1660: - thanks [~reedwm]! > Add documentation for dynamic reconfiguration > - > > Key: ZOOKEEPER-1660 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1660 > Project: ZooKeeper > Issue Type: Sub-task > Components: documentation >Affects Versions: 3.5.0 >Reporter: Alexander Shraer >Assignee: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > > Update user manual with reconfiguration info. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1660) Add documentation for dynamic reconfiguration
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073718#comment-14073718 ] Reed Wanderman-Milne commented on ZOOKEEPER-1660: - I spoke to [~shralex], and agreed to create the forrest docs, once the Google Doc is updated to its near-final version. > Add documentation for dynamic reconfiguration > - > > Key: ZOOKEEPER-1660 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1660 > Project: ZooKeeper > Issue Type: Sub-task > Components: documentation >Affects Versions: 3.5.0 >Reporter: Alexander Shraer >Assignee: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > > Update user manual with reconfiguration info. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1987) unable to restart 3 node cluster
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073714#comment-14073714 ] Patrick Hunt commented on ZOOKEEPER-1987: - bq. and in this case we get the latest dynamic file? That was my thought. And as a result we get the .bak for free. > unable to restart 3 node cluster > > > Key: ZOOKEEPER-1987 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1987 > Project: ZooKeeper > Issue Type: Bug > Components: tests >Affects Versions: 3.5.0 >Reporter: Patrick Hunt >Assignee: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1987-ver1.patch, ZOOKEEPER-1987-ver2.patch, > ZOOKEEPER-1987-ver3.patch, ZOOKEEPER-1987.patch, f1.jstack, l3.jstack, > test3.tar.gz > > > I tried a fairly simple test, start a three node cluster, bring it down, then > restart it. On restart the servers elect the leader and send updates, however > the negotiation never completes - the client ports are never bound for > example. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1987) unable to restart 3 node cluster
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073708#comment-14073708 ] Flavio Junqueira commented on ZOOKEEPER-1987: - I like the idea of using BAK files to track changes over time, it sounds good for debugging. As for the file updates, it is doable to update files atomically. It is a bit of work, but doable. bq. The static config file could specify just the prefix, and not the full file name and in this case we get the latest dynamic file? > unable to restart 3 node cluster > > > Key: ZOOKEEPER-1987 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1987 > Project: ZooKeeper > Issue Type: Bug > Components: tests >Affects Versions: 3.5.0 >Reporter: Patrick Hunt >Assignee: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1987-ver1.patch, ZOOKEEPER-1987-ver2.patch, > ZOOKEEPER-1987-ver3.patch, ZOOKEEPER-1987.patch, f1.jstack, l3.jstack, > test3.tar.gz > > > I tried a fairly simple test, start a three node cluster, bring it down, then > restart it. On restart the servers elect the leader and send updates, however > the negotiation never completes - the client ports are never bound for > example. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1660) Add documentation for dynamic reconfiguration
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073710#comment-14073710 ] Patrick Hunt commented on ZOOKEEPER-1660: - [~fpj] I agree. W/o docs no one is going to use the feature. And most folks are going to look at the admin guide for that. For better/worse we are still using forrest for that. I believe [~reedwm] is interested. I'll let him comment further. > Add documentation for dynamic reconfiguration > - > > Key: ZOOKEEPER-1660 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1660 > Project: ZooKeeper > Issue Type: Sub-task > Components: documentation >Affects Versions: 3.5.0 >Reporter: Alexander Shraer >Assignee: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > > Update user manual with reconfiguration info. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1660) Add documentation for dynamic reconfiguration
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073697#comment-14073697 ] Flavio Junqueira commented on ZOOKEEPER-1660: - I'm wondering how we are going to be making this doc available. Transforming it into a forrest doc will be a bit of pain. [~phunt], any suggestion here? > Add documentation for dynamic reconfiguration > - > > Key: ZOOKEEPER-1660 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1660 > Project: ZooKeeper > Issue Type: Sub-task > Components: documentation >Affects Versions: 3.5.0 >Reporter: Alexander Shraer >Assignee: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > > Update user manual with reconfiguration info. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1987) unable to restart 3 node cluster
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073695#comment-14073695 ] Patrick Hunt commented on ZOOKEEPER-1987: - bq. I like your idea of making the version part of the filename. This means however that we'd need to update the static config file every time too, as it has a link to the dynamic file. The static config file could specify just the prefix, and not the full file name (iow: exclude the version suffix from the static file) > unable to restart 3 node cluster > > > Key: ZOOKEEPER-1987 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1987 > Project: ZooKeeper > Issue Type: Bug > Components: tests >Affects Versions: 3.5.0 >Reporter: Patrick Hunt >Assignee: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1987-ver1.patch, ZOOKEEPER-1987-ver2.patch, > ZOOKEEPER-1987-ver3.patch, ZOOKEEPER-1987.patch, f1.jstack, l3.jstack, > test3.tar.gz > > > I tried a fairly simple test, start a three node cluster, bring it down, then > restart it. On restart the servers elect the leader and send updates, however > the negotiation never completes - the client ports are never bound for > example. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1987) unable to restart 3 node cluster
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073656#comment-14073656 ] Alexander Shraer commented on ZOOKEEPER-1987: - Configurations are ordered using their version numbers. This is how we can compare two configs and determine which one is older. Initially when you start up a cluster or a new server is joining its file doesn't have to include a version. In fact the user should NEVER specify a version. When a leader comes up, if the config wasn't set yet it sets it to its new zxid, and all config files are updated. If a new config is proposed, its version is the reconfig op zxid. Storing the version in a separate file creates a problem of keeping this file in sync with the dynamic config file. How would one update them atomically? I like your idea of making the version part of the filename. This means however that we'd need to update the static config file every time too, as it has a link to the dynamic file. But the good thing is that we may not need the bak files - we can just leave the old dynamic config files. I'm not sure whether this should be done for 3.5.0 or perhaps later. > unable to restart 3 node cluster > > > Key: ZOOKEEPER-1987 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1987 > Project: ZooKeeper > Issue Type: Bug > Components: tests >Affects Versions: 3.5.0 >Reporter: Patrick Hunt >Assignee: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1987-ver1.patch, ZOOKEEPER-1987-ver2.patch, > ZOOKEEPER-1987-ver3.patch, ZOOKEEPER-1987.patch, f1.jstack, l3.jstack, > test3.tar.gz > > > I tried a fairly simple test, start a three node cluster, bring it down, then > restart it. On restart the servers elect the leader and send updates, however > the negotiation never completes - the client ports are never bound for > example. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1987) unable to restart 3 node cluster
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073630#comment-14073630 ] Hongchao Deng commented on ZOOKEEPER-1987: -- hey [~shralex]. Thanks for sharing. Preserving backward compatibility definitely makes the project harder to maintain. However, it encourages people to try 3.5.x without being stopped at the start. So it's good to support that :) Moreover, I am wondering what the version in dynamic file is? Is it helping to locate the reconfig command more quickly? Or just a notion of version.. I thought about the dynamic file again carefully and had a second thought on this: https://medium.com/@hdeng/zookeeper-dynamic-config-file-b7557a2fb42f Basically, I am suggesting: 1. separate the version (zxid) to another files. 2. Append a sequential number to the filename in backup. 3. backup should be an optional argument (e.g. a directory maybe?). This would be nice to separate production and testing environment. Please take a moment to review the ideas and share your feedback here. > unable to restart 3 node cluster > > > Key: ZOOKEEPER-1987 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1987 > Project: ZooKeeper > Issue Type: Bug > Components: tests >Affects Versions: 3.5.0 >Reporter: Patrick Hunt >Assignee: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1987-ver1.patch, ZOOKEEPER-1987-ver2.patch, > ZOOKEEPER-1987-ver3.patch, ZOOKEEPER-1987.patch, f1.jstack, l3.jstack, > test3.tar.gz > > > I tried a fairly simple test, start a three node cluster, bring it down, then > restart it. On restart the servers elect the leader and send updates, however > the negotiation never completes - the client ports are never bound for > example. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1988) new test patch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073613#comment-14073613 ] Alexander Shraer commented on ZOOKEEPER-1988: - Thanks Raul. I'd rather leave as is - PathUtils refers to znode paths, that's why I named it this way to make clear we mean a file system directory. > new test patch > -- > > Key: ZOOKEEPER-1988 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1988 > Project: ZooKeeper > Issue Type: Sub-task > Components: tests >Reporter: Raul Gutierrez Segales >Assignee: Alexander Shraer > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1987-ver4.patch, ZOOKEEPER-1987-ver5.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1988) new test patch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073561#comment-14073561
]
Raul Gutierrez Segales commented on ZOOKEEPER-1988:
---
+1, I think it looks great. Thanks [~shralex]. One last nit though (feel free
to leave it): since :
{noformat}
PathUtils.normalizeFileSystemPath
{noformat}
is already a static method inside PathUtils, you might as well just call it
normalize (it is implicit it refers to paths):
{noformat}
PathUtils.normalize
{noformat}
Thanks for the quick updates.
> new test patch
> --
>
> Key: ZOOKEEPER-1988
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1988
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: tests
>Reporter: Raul Gutierrez Segales
>Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1987-ver4.patch, ZOOKEEPER-1987-ver5.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
Failed: ZOOKEEPER-1988 PreCommit Build #2230
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1988 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2230/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 299679 lines...] [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 15 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2230//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2230//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2230//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 540ef0ece4ea3c86125aaf75d52254922aa8a2b2 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1713: exec returned: 1 Total time: 38 minutes 28 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2179 Archived 7 artifacts Archive block size is 32768 Received 0 blocks and 546330 bytes Compression is 0.0% Took 3.2 sec Recording test results Description set: ZOOKEEPER-1988 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## 1 tests failed. FAILED: org.apache.zookeeper.test.NioNettySuiteHammerTest.testHammer Error Message: Forked Java VM exited abnormally. Please note the time in the report does not reflect the time until the VM exit. Stack Trace: junit.framework.AssertionFailedError: Forked Java VM exited abnormally. Please note the time in the report does not reflect the time until the VM exit.
[jira] [Commented] (ZOOKEEPER-1988) new test patch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073553#comment-14073553 ] Hadoop QA commented on ZOOKEEPER-1988: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12657650/ZOOKEEPER-1987-ver5.patch against trunk revision 1612906. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 15 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2230//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2230//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2230//console This message is automatically generated. > new test patch > -- > > Key: ZOOKEEPER-1988 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1988 > Project: ZooKeeper > Issue Type: Sub-task > Components: tests >Reporter: Raul Gutierrez Segales >Assignee: Alexander Shraer > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1987-ver4.patch, ZOOKEEPER-1987-ver5.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (ZOOKEEPER-1989) backward compatibility of zoo.cfg
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hongchao Deng updated ZOOKEEPER-1989:
-
Description:
Before 3.5.x, users define zoo.cfg with "clientPort" parameter which is used to
identify on which port the server is serving clients.
After upgrading to 3.5.x, the new format:
{noformat}
server.$id=$addr:$port1:$port2[:$role];[$cliAddr:]$cliPort
{noformat}
force users to define all the client ports on the entire ZK ensemble.
The goal of this issue is to preserve backward compatibility upgrading 3.4 to
3.5.
1. when a user defines an old-style config file, it should function the same as
the old way -- It should use clientPort variable and shouldn't create a dynamic
file.
2. when a user with old-style config file tries to do reconfig relevant jobs,
it should stop him and give out a warning.
was:
Before 3.5.x, users define zoo.cfg with "clientPort" parameter which is used to
identify on which port the server is serving clients.
After upgrading to 3.5.x, the new format:
{noformat}
server.$id=$addr:$port1:$port2[:role];[$cliAddr:]$cliPort
{noformat}
force users to define all the client ports on the entire ZK ensemble.
The goal of this issue is to preserve backward compatibility upgrading 3.4 to
3.5.
1. when a user defines an old-style config file, it should function the same as
the old way -- It should use clientPort variable and shouldn't create a dynamic
file.
2. when a user with old-style config file tries to do reconfig relevant jobs,
it should stop him and give out a warning.
> backward compatibility of zoo.cfg
> -
>
> Key: ZOOKEEPER-1989
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1989
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: tests
>Affects Versions: 3.5.0
>Reporter: Hongchao Deng
>Assignee: Hongchao Deng
>Priority: Blocker
> Fix For: 3.5.0
>
>
> Before 3.5.x, users define zoo.cfg with "clientPort" parameter which is used
> to identify on which port the server is serving clients.
> After upgrading to 3.5.x, the new format:
> {noformat}
> server.$id=$addr:$port1:$port2[:$role];[$cliAddr:]$cliPort
> {noformat}
> force users to define all the client ports on the entire ZK ensemble.
> The goal of this issue is to preserve backward compatibility upgrading 3.4 to
> 3.5.
> 1. when a user defines an old-style config file, it should function the same
> as the old way -- It should use clientPort variable and shouldn't create a
> dynamic file.
> 2. when a user with old-style config file tries to do reconfig relevant jobs,
> it should stop him and give out a warning.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (ZOOKEEPER-1989) backward compatibility of zoo.cfg
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hongchao Deng updated ZOOKEEPER-1989:
-
Description:
Before 3.5.x, users define zoo.cfg with "clientPort" parameter which is used to
identify on which port the server is serving clients.
After upgrading to 3.5.x, the new format:
{noformat}
server.$id=$addr:$port1:$port2[:role];[$cliAddr:]$cliPort
{noformat}
force users to define all the client ports on the entire ZK ensemble.
The goal of this issue is to preserve backward compatibility upgrading 3.4 to
3.5.
1. when a user defines an old-style config file, it should function the same as
the old way -- It should use clientPort variable and shouldn't create a dynamic
file.
2. when a user with old-style config file tries to do reconfig relevant jobs,
it should stop him and give out a warning.
was:
Before 3.5.x, users define zoo.cfg with "clientPort" parameter which is used to
identify on which port the server is serving clients.
After upgrading to 3.5.x, the new format:
{noformat}
server.$id=$addr:$port1:$port2 [:role];[$cliAddr:] $cliPort
{noformat}
force users to define all the client ports on the entire ZK ensemble.
The goal of this issue is to preserve backward compatibility upgrading 3.4 to
3.5.
1. when a user defines an old-style config file, it should function the same as
the old way -- It should use clientPort variable and shouldn't create a dynamic
file.
2. when a user with old-style config file tries to do reconfig relevant jobs,
it should stop him and give out a warning.
> backward compatibility of zoo.cfg
> -
>
> Key: ZOOKEEPER-1989
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1989
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: tests
>Affects Versions: 3.5.0
>Reporter: Hongchao Deng
>Assignee: Hongchao Deng
>Priority: Blocker
> Fix For: 3.5.0
>
>
> Before 3.5.x, users define zoo.cfg with "clientPort" parameter which is used
> to identify on which port the server is serving clients.
> After upgrading to 3.5.x, the new format:
> {noformat}
> server.$id=$addr:$port1:$port2[:role];[$cliAddr:]$cliPort
> {noformat}
> force users to define all the client ports on the entire ZK ensemble.
> The goal of this issue is to preserve backward compatibility upgrading 3.4 to
> 3.5.
> 1. when a user defines an old-style config file, it should function the same
> as the old way -- It should use clientPort variable and shouldn't create a
> dynamic file.
> 2. when a user with old-style config file tries to do reconfig relevant jobs,
> it should stop him and give out a warning.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (ZOOKEEPER-1988) new test patch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Shraer updated ZOOKEEPER-1988: Attachment: ZOOKEEPER-1987-ver5.patch > new test patch > -- > > Key: ZOOKEEPER-1988 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1988 > Project: ZooKeeper > Issue Type: Sub-task > Components: tests >Reporter: Raul Gutierrez Segales >Assignee: Alexander Shraer > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1987-ver4.patch, ZOOKEEPER-1987-ver5.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1988) new test patch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073502#comment-14073502 ] Hadoop QA commented on ZOOKEEPER-1988: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12657642/ZOOKEEPER-1987-ver4.patch against trunk revision 1612906. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2229//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2229//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2229//console This message is automatically generated. > new test patch > -- > > Key: ZOOKEEPER-1988 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1988 > Project: ZooKeeper > Issue Type: Sub-task > Components: tests >Reporter: Raul Gutierrez Segales >Assignee: Alexander Shraer > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1987-ver4.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
Failed: ZOOKEEPER-1988 PreCommit Build #2229
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1988 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2229/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 308614 lines...] [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 9 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2229//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2229//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2229//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] b8ee35968b954a197c7a04724efbef03a595 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1713: exec returned: 1 Total time: 38 minutes 30 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2179 Archived 7 artifacts Archive block size is 32768 Received 0 blocks and 546330 bytes Compression is 0.0% Took 3.3 sec Recording test results Description set: ZOOKEEPER-1988 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## 1 tests failed. FAILED: org.apache.zookeeper.test.NioNettySuiteHammerTest.testHammer Error Message: Forked Java VM exited abnormally. Please note the time in the report does not reflect the time until the VM exit. Stack Trace: junit.framework.AssertionFailedError: Forked Java VM exited abnormally. Please note the time in the report does not reflect the time until the VM exit.
[jira] [Commented] (ZOOKEEPER-1988) new test patch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073456#comment-14073456
]
Raul Gutierrez Segales commented on ZOOKEEPER-1988:
---
This is slightly outside of the scope of this patch (and a nit) but if you have
the cycles moving all the file path conversions to one util function would
clean up things a bit, see:
{noformat}
$ git grep "osname.toLowerCase().contains"
src/java/test/org/apache/zookeeper/server/InvalidSnapCountTest.java:
if (osname.toLowerCase().contains("windows"))
src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java:
if (osname.toLowerCase().contains("windows"
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java:
if (osname.toLowerCase().contains("window
src/java/test/org/apache/zookeeper/server/util/DynamicConfigBCTest.java:
if (osname.toLowerCase().contains("windows
{noformat}
so having a normalizeFilePath() or such would make it easier to maintain.
Less lines of code is always nice :-)
It's also such a small change that another JIRA is probably overkill.
> new test patch
> --
>
> Key: ZOOKEEPER-1988
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1988
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: tests
>Reporter: Raul Gutierrez Segales
>Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1987-ver4.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1987) unable to restart 3 node cluster
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073457#comment-14073457 ] Alexander Shraer commented on ZOOKEEPER-1987: - to sum up some offline discussion with [~phunt]: comments 1 and 2 - its possible to disable reconfig when the user doesn't upgrade the config file or alternatively to avoid changing the config file and return an error message without bringing up the server. I'd prefer the latter because of the additional code that will be needed to patch the dynamic config using to clientPort, disable reconfig, and creating a state where different servers have different configs with the same config version. I'd rather clearly state somewhere that users should add the ports to config file like I did in the doc. Having said that, I understand that users may not be reading the docs, so its up to you. We should warn the user that the reconfig is disabled only on the server where config file wasn't upgraded, so if he upgrades part of the config files but not all of them, things may go wrong. comment 3 - since we can't write bak files atomically with changing the config file, I suggest to number them like bak3, bak4, etc, I think this is what you meant too. Writing it should probably be done in QuorumPeerConfig right before the dynamic config file is updated. comment 4 - please see ZOOKEEPER-1660, which also talks about upgrading from 3.4.6 Thanks, Alex > unable to restart 3 node cluster > > > Key: ZOOKEEPER-1987 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1987 > Project: ZooKeeper > Issue Type: Bug > Components: tests >Affects Versions: 3.5.0 >Reporter: Patrick Hunt >Assignee: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1987-ver1.patch, ZOOKEEPER-1987-ver2.patch, > ZOOKEEPER-1987-ver3.patch, ZOOKEEPER-1987.patch, f1.jstack, l3.jstack, > test3.tar.gz > > > I tried a fairly simple test, start a three node cluster, bring it down, then > restart it. On restart the servers elect the leader and send updates, however > the negotiation never completes - the client ports are never bound for > example. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (ZOOKEEPER-1988) new test patch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Shraer updated ZOOKEEPER-1988: Attachment: ZOOKEEPER-1987-ver4.patch Thanks for the comments, uploading an updated patch. [~rakeshr], I changed your fix slightly, does my fix solve the problem you saw on windows ? the change aims to avoid doing "replace" every time we write the dynamic config file - instead doing it once when the file name is set. > new test patch > -- > > Key: ZOOKEEPER-1988 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1988 > Project: ZooKeeper > Issue Type: Sub-task > Components: tests >Reporter: Raul Gutierrez Segales >Assignee: Alexander Shraer > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1987-ver4.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (ZOOKEEPER-1989) backward compatibility of zoo.cfg
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Hunt updated ZOOKEEPER-1989:
Affects Version/s: 3.5.0
> backward compatibility of zoo.cfg
> -
>
> Key: ZOOKEEPER-1989
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1989
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: tests
>Affects Versions: 3.5.0
>Reporter: Hongchao Deng
>Assignee: Hongchao Deng
>Priority: Blocker
> Fix For: 3.5.0
>
>
> Before 3.5.x, users define zoo.cfg with "clientPort" parameter which is used
> to identify on which port the server is serving clients.
> After upgrading to 3.5.x, the new format:
> {noformat}
> server.$id=$addr:$port1:$port2 [:role];[$cliAddr:] $cliPort
> {noformat}
> force users to define all the client ports on the entire ZK ensemble.
> The goal of this issue is to preserve backward compatibility upgrading 3.4 to
> 3.5.
> 1. when a user defines an old-style config file, it should function the same
> as the old way -- It should use clientPort variable and shouldn't create a
> dynamic file.
> 2. when a user with old-style config file tries to do reconfig relevant jobs,
> it should stop him and give out a warning.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Created] (ZOOKEEPER-1989) backward compatibility of zoo.cfg
Hongchao Deng created ZOOKEEPER-1989:
Summary: backward compatibility of zoo.cfg
Key: ZOOKEEPER-1989
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1989
Project: ZooKeeper
Issue Type: Sub-task
Reporter: Hongchao Deng
Assignee: Hongchao Deng
Priority: Blocker
Before 3.5.x, users define zoo.cfg with "clientPort" parameter which is used to
identify on which port the server is serving clients.
After upgrading to 3.5.x, the new format:
{noformat}
server.$id=$addr:$port1:$port2 [:role];[$cliAddr:] $cliPort
{noformat}
force users to define all the client ports on the entire ZK ensemble.
The goal of this issue is to preserve backward compatibility upgrading 3.4 to
3.5.
1. when a user defines an old-style config file, it should function the same as
the old way -- It should use clientPort variable and shouldn't create a dynamic
file.
2. when a user with old-style config file tries to do reconfig relevant jobs,
it should stop him and give out a warning.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
Re: Xid out of order?
I just tried against trunk (client+servers) and I could reproduce the same exception. java.io.IOException: Xid out of order. Got Xid 11 with err -119 expected Xid 10 for a packet with details: clientPath:/ serverPath:/ finished:false header:: 10,3 replyHeader:: 0,0,-4 request:: '/,T response:: at org.apache.zookeeper.ClientCnxn$SendThread.readResponse(ClientCnxn.java:910) at org.apache.zookeeper.ClientCnxnSocketNIO.doIO(ClientCnxnSocketNIO.java:99) at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:362) at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1192) On Wed, Jul 23, 2014 at 7:48 PM, Dutch Meyer wrote: > There was an xid out of order bug fixed somewhat recently, though from your > description I'm not sure how you'd end up triggering it. > > Reference: https://issues.apache.org/jira/browse/ZOOKEEPER-1863 > > > > On Wed, Jul 23, 2014 at 4:35 PM, Benjamin Jaton > wrote: > > > Hello, > > > > I am looking into this issue: > > https://issues.apache.org/jira/browse/CURATOR-125 > > I have 3 ZK servers, only 1 is started. > > > > I get this log and it might be causing my issue down the road: > > > > java.io.IOException: Xid out of order. Got Xid 14 with err -119 expected > > Xid 13 for a packet with details: clientPath:/ serverPath:/ > finished:false > > header:: 13,3 replyHeader:: 0,0,-4 request:: '/,T response:: > > at > > > org.apache.zookeeper.ClientCnxn$SendThread.readResponse(ClientCnxn.java:795) > > at > > > org.apache.zookeeper.ClientCnxnSocketNIO.doIO(ClientCnxnSocketNIO.java:94) > > at > > > org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:355) > > at > org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1068) > > > > Client and servers are running the official 3.4.5. > > I am attaching the log file. > > > > The code I am running is in the bug: > > https://issues.apache.org/jira/browse/CURATOR-125 ( Test.java ). > > > > I can open a bug if necessary. > > > > Thanks, > > Ben > > > > > > -- > -=-Dutch >
[jira] [Updated] (ZOOKEEPER-1988) new test patch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raul Gutierrez Segales updated ZOOKEEPER-1988: -- Assignee: Alexander Shraer > new test patch > -- > > Key: ZOOKEEPER-1988 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1988 > Project: ZooKeeper > Issue Type: Sub-task > Components: tests >Reporter: Raul Gutierrez Segales >Assignee: Alexander Shraer > Fix For: 3.5.0 > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1988) new test patch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073407#comment-14073407 ] Raul Gutierrez Segales commented on ZOOKEEPER-1988: --- lets follow-up here with the patch review, please see my last comment in the parent task. thanks [~shralex]. > new test patch > -- > > Key: ZOOKEEPER-1988 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1988 > Project: ZooKeeper > Issue Type: Sub-task > Components: tests >Reporter: Raul Gutierrez Segales >Assignee: Alexander Shraer > Fix For: 3.5.0 > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (ZOOKEEPER-1988) new test patch
Raul Gutierrez Segales created ZOOKEEPER-1988: - Summary: new test patch Key: ZOOKEEPER-1988 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1988 Project: ZooKeeper Issue Type: Sub-task Reporter: Raul Gutierrez Segales -- This message was sent by Atlassian JIRA (v6.2#6252)
Re: ZooKeeper 3.5.0-alpha planning
On 24 July 2014 09:47, Patrick Hunt wrote: > We've identified the issues with 1987, it would be good if folks could > take a look. Great - thanks Patrick. Added some comments to the patch. > Nothing looks unsolvable, but we should tweak things a > bit before 3.5.0, esp given the current upgrade experience. The new > docs will help a lot - see > https://issues.apache.org/jira/browse/ZOOKEEPER-1660 which we need to > review and commit. > Reading the docs, will follow-up with comments. -rgs
[jira] [Commented] (ZOOKEEPER-1987) unable to restart 3 node cluster
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073402#comment-14073402 ] Patrick Hunt commented on ZOOKEEPER-1987: - Can we move the "new test patch" to a subtask and use this jira for high level discussion (umbrella)? Thanks. > unable to restart 3 node cluster > > > Key: ZOOKEEPER-1987 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1987 > Project: ZooKeeper > Issue Type: Bug > Components: tests >Affects Versions: 3.5.0 >Reporter: Patrick Hunt >Assignee: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1987-ver1.patch, ZOOKEEPER-1987-ver2.patch, > ZOOKEEPER-1987-ver3.patch, ZOOKEEPER-1987.patch, f1.jstack, l3.jstack, > test3.tar.gz > > > I tried a fairly simple test, start a three node cluster, bring it down, then > restart it. On restart the servers elect the leader and send updates, however > the negotiation never completes - the client ports are never bound for > example. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1987) unable to restart 3 node cluster
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073395#comment-14073395
]
Raul Gutierrez Segales commented on ZOOKEEPER-1987:
---
Small readability (possibly correctness) nit:
{noformat}
+for (int i = 0; i < SERVER_COUNT; i++) {
+mt[i] = new MainThread(i, clientPorts[i], currentQuorumCfgSection,
false);
+// check that a dynamic configuration file wasn't created
+Assert.assertFalse(mt[i].dynamicConfigFile.exists());
+mt[i].start();
+zk[i] = new ZooKeeper("127.0.0.1:" + clientPorts[i],
+ClientBase.CONNECTION_TIMEOUT, this);
+}
+// Check that the servers are up, have the right config and can
process operations
+// Check that the static config was split to static and dynamic files
correctly
+for (int i = 0; i < SERVER_COUNT; i++) {
+Assert.assertTrue("waiting for server 0 being up", ClientBase
+.waitForServerUp("127.0.0.1:" + clientPorts[0],
+CONNECTION_TIMEOUT));
+Assert.assertTrue(mt[i].dynamicConfigFile.exists());
+ReconfigTest.testServerHasConfig(zk[i], allServers, null);
{noformat}
I think it makes more sense to start the ZooKeeper clients in the 2nd loop,
after you've asserted that the server is up?
Also, server 0 is hard-coded in the assert message (should be %d, i).
Another small readability nit:
{noformat}
+Properties cfg = new Properties();
+FileInputStream in = new FileInputStream(mt[0].confFile);
+try {
+cfg.load(in);
+} finally {
+in.close();
+}
{noformat}
is used twice. Mind having a small helper method to get the cfg:
{noformat}
Properties cfg = getProperties(mt[0].confFile);
{noformat}
Same thing with regards starting clients after the servers are up (and same
with hard coded server number in the assert error message):
{noformat}
+for (int i = 0; i < SERVER_COUNT; i++) {
+mt[i].start();
+zk[i] = new ZooKeeper("127.0.0.1:" + clientPorts[i],
+ClientBase.CONNECTION_TIMEOUT, this);
+}
+for (int i = 0; i < SERVER_COUNT; i++) {
+Assert.assertTrue("waiting for server 0 being up", ClientBase
+.waitForServerUp("127.0.0.1:" + clientPorts[0],
+CONNECTION_TIMEOUT));
+ReconfigTest.testServerHasConfig(zk[i], allServers, null);
+}
{noformat}
> unable to restart 3 node cluster
>
>
> Key: ZOOKEEPER-1987
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1987
> Project: ZooKeeper
> Issue Type: Bug
> Components: tests
>Affects Versions: 3.5.0
>Reporter: Patrick Hunt
>Assignee: Alexander Shraer
>Priority: Blocker
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1987-ver1.patch, ZOOKEEPER-1987-ver2.patch,
> ZOOKEEPER-1987-ver3.patch, ZOOKEEPER-1987.patch, f1.jstack, l3.jstack,
> test3.tar.gz
>
>
> I tried a fairly simple test, start a three node cluster, bring it down, then
> restart it. On restart the servers elect the leader and send updates, however
> the negotiation never completes - the client ports are never bound for
> example.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (ZOOKEEPER-1660) Add documentation for dynamic reconfiguration
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-1660: Priority: Blocker (was: Major) > Add documentation for dynamic reconfiguration > - > > Key: ZOOKEEPER-1660 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1660 > Project: ZooKeeper > Issue Type: Sub-task > Components: documentation >Affects Versions: 3.5.0 >Reporter: Alexander Shraer >Assignee: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > > Update user manual with reconfiguration info. -- This message was sent by Atlassian JIRA (v6.2#6252)
Re: ZooKeeper 3.5.0-alpha planning
We've identified the issues with 1987, it would be good if folks could take a look. Nothing looks unsolvable, but we should tweak things a bit before 3.5.0, esp given the current upgrade experience. The new docs will help a lot - see https://issues.apache.org/jira/browse/ZOOKEEPER-1660 which we need to review and commit. Patrick On Wed, Jul 23, 2014 at 5:07 PM, Patrick Hunt wrote: > The units are passing and I'm able to build the release candidate > however even a basic 3 node "start the cluster, stop it, then restart" > is failing. We'll need to look into this before an RC can be built. > > See: https://issues.apache.org/jira/browse/ZOOKEEPER-1987 > > Patrick > > On Wed, Jul 23, 2014 at 3:06 PM, Raúl Gutiérrez Segalés > wrote: >> On 23 July 2014 14:48, Patrick Hunt wrote: >> >>> FYI: Currently running some tests and I'm about to create the >>> branch-3.5 branch. >>> >> >> w00t :-) >> >> >> -rgs
[jira] [Commented] (ZOOKEEPER-1987) unable to restart 3 node cluster
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073367#comment-14073367 ] Patrick Hunt commented on ZOOKEEPER-1987: - Re item 1, perhaps we need to not automatically convert the config, and only support reconfig if the user manually converts the config over. Otw stay with the existing configuration until the user does the upgrade (which is detailed in ZOOKEEPER-1660) > unable to restart 3 node cluster > > > Key: ZOOKEEPER-1987 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1987 > Project: ZooKeeper > Issue Type: Bug > Components: tests >Affects Versions: 3.5.0 >Reporter: Patrick Hunt >Assignee: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1987-ver1.patch, ZOOKEEPER-1987-ver2.patch, > ZOOKEEPER-1987-ver3.patch, ZOOKEEPER-1987.patch, f1.jstack, l3.jstack, > test3.tar.gz > > > I tried a fairly simple test, start a three node cluster, bring it down, then > restart it. On restart the servers elect the leader and send updates, however > the negotiation never completes - the client ports are never bound for > example. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (ZOOKEEPER-1660) Add documentation for dynamic reconfiguration
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-1660: Issue Type: Sub-task (was: Improvement) Parent: ZOOKEEPER-1987 > Add documentation for dynamic reconfiguration > - > > Key: ZOOKEEPER-1660 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1660 > Project: ZooKeeper > Issue Type: Sub-task > Components: documentation >Affects Versions: 3.5.0 >Reporter: Alexander Shraer >Assignee: Alexander Shraer > Fix For: 3.5.0 > > > Update user manual with reconfiguration info. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1987) unable to restart 3 node cluster
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073356#comment-14073356 ] Patrick Hunt commented on ZOOKEEPER-1987: - Alex pointed me at ZOOKEEPER-1660 which contains the doc changes. Let's try to get that into 3.5.0. Reviews welcome! > unable to restart 3 node cluster > > > Key: ZOOKEEPER-1987 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1987 > Project: ZooKeeper > Issue Type: Bug > Components: tests >Affects Versions: 3.5.0 >Reporter: Patrick Hunt >Assignee: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1987-ver1.patch, ZOOKEEPER-1987-ver2.patch, > ZOOKEEPER-1987-ver3.patch, ZOOKEEPER-1987.patch, f1.jstack, l3.jstack, > test3.tar.gz > > > I tried a fairly simple test, start a three node cluster, bring it down, then > restart it. On restart the servers elect the leader and send updates, however > the negotiation never completes - the client ports are never bound for > example. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1987) unable to restart 3 node cluster
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073345#comment-14073345 ] Patrick Hunt commented on ZOOKEEPER-1987: - Hi Alex bq. Client port/adress are now part of the dynamic information that can be changed by reconfig. That's fine. However I see a few issues we'll need to resolve: 1) backward compatibility. We support n to n+1 backward compatibility (upgrading 3.4 to 3.5). This currently breaks that compatibility. What you are saying in your comment is fine, however the conversion from old, non-dynamic, (but valid) config to new, dynamic config is not working properly. There's even an existing jira for this same issue that a user faced - ZOOKEEPER-1950. 2) The server is not properly validating the configuration. bq. with 3.5.0 you have to include the ports when you list the servers if that's the case (missing required parameter) the server needs to log an error and refuse to come up 3) The server needs to output XX.bak# files when modifying the configuration files. Currently they are overwritten, in order to support this in a production environment we need .bak files to be created on each change, so that we have a history to look at if things go wrong, or if we need to revert if something goes wrong. 4) afaict there is no documentation. existing documentation (zk admin guide, examples, etc...) are all based on the "pre-reconfig" requirements. If this were an optional feature it would be less important (people could just ignore it). However reconfig is effecting every single user due to the change in configuration requirements. The config file format has changed, this is a requirement to run the server. It looks to me like 1 and 4 need to be addressed asap, otw folks won't really be able to try out a release. They will run into the same issue I did, the same issue that was reported in ZOOKEEPER-1950. Perhaps we can create some sub-tasks on this jira and work through the issues individually? > unable to restart 3 node cluster > > > Key: ZOOKEEPER-1987 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1987 > Project: ZooKeeper > Issue Type: Bug > Components: tests >Affects Versions: 3.5.0 >Reporter: Patrick Hunt >Assignee: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1987-ver1.patch, ZOOKEEPER-1987-ver2.patch, > ZOOKEEPER-1987-ver3.patch, ZOOKEEPER-1987.patch, f1.jstack, l3.jstack, > test3.tar.gz > > > I tried a fairly simple test, start a three node cluster, bring it down, then > restart it. On restart the servers elect the leader and send updates, however > the negotiation never completes - the client ports are never bound for > example. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1987) unable to restart 3 node cluster
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073313#comment-14073313 ] Hadoop QA commented on ZOOKEEPER-1987: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12657613/ZOOKEEPER-1987-ver3.patch against trunk revision 1612906. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2228//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2228//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2228//console This message is automatically generated. > unable to restart 3 node cluster > > > Key: ZOOKEEPER-1987 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1987 > Project: ZooKeeper > Issue Type: Bug > Components: tests >Affects Versions: 3.5.0 >Reporter: Patrick Hunt >Assignee: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1987-ver1.patch, ZOOKEEPER-1987-ver2.patch, > ZOOKEEPER-1987-ver3.patch, ZOOKEEPER-1987.patch, f1.jstack, l3.jstack, > test3.tar.gz > > > I tried a fairly simple test, start a three node cluster, bring it down, then > restart it. On restart the servers elect the leader and send updates, however > the negotiation never completes - the client ports are never bound for > example. -- This message was sent by Atlassian JIRA (v6.2#6252)
Failed: ZOOKEEPER-1987 PreCommit Build #2228
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1987 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2228/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 316036 lines...] [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 9 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2228//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2228//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2228//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] f0effd1982ff7b15d230e859b4d1ce6cec9530de logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1713: exec returned: 1 Total time: 38 minutes 59 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2179 Archived 7 artifacts Archive block size is 32768 Received 0 blocks and 546329 bytes Compression is 0.0% Took 2.7 sec Recording test results Description set: ZOOKEEPER-1987 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## 1 tests failed. FAILED: org.apache.zookeeper.test.NioNettySuiteHammerTest.testHammer Error Message: Forked Java VM exited abnormally. Please note the time in the report does not reflect the time until the VM exit. Stack Trace: junit.framework.AssertionFailedError: Forked Java VM exited abnormally. Please note the time in the report does not reflect the time until the VM exit.
[jira] [Resolved] (ZOOKEEPER-1950) configBackwardCompatibilityMode breaks compatibility
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongchao Deng resolved ZOOKEEPER-1950. -- Resolution: Duplicate This is the same as ZOOKEEPER-1987 > configBackwardCompatibilityMode breaks compatibility > > > Key: ZOOKEEPER-1950 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1950 > Project: ZooKeeper > Issue Type: Bug >Affects Versions: 3.5.0 >Reporter: Hongchao Deng > Fix For: 3.5.0 > > > The current implementation divide information of servers of legacy config > into two separate dynamic config files. There is a problem. > When we set "clientPort" variable in config file, it gets automatically > erased and later on there is no information about "clientPort" in either the > old or new (.dynamic) config file. > It becomes a serious problem when users of *3.4* jump to *3.5* directly > without changing their config: when a server crashes and restarts, there is > no client port serving. > For example, > a legacy config might look like: > ```zoo.cfg > dataDir=/root/zookeeper/groupconfig/conf1/data > syncLimit=5 > initLimit=10 > tickTime=2000 > clientPort=2181 > server.1=127.0.0.1::2223 > server.2=127.0.0.1::3334 > server.3=127.0.0.1::4445 > ``` > After dynamic reconfig, it might look like > ```zoo.cfg > dataDir=/root/zookeeper/groupconfig/conf1/data > syncLimit=5 > tickTime=2000 > initLimit=10 > dynamicConfigFile=./zoo.cfg.dynamic > ``` > and > ```zoo.cfg.dynamic > server.1=127.0.0.1::2223:participant > server.2=127.0.0.1::3334:participant > server.3=127.0.0.1::4445:participant > version=e > ``` > This could be successfully started at first time. But when server restarts > from crash, it never serve client port again. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1987) unable to restart 3 node cluster
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073283#comment-14073283 ] Alexander Shraer commented on ZOOKEEPER-1987: - Thanks, Rakesh. It looks good to me. [~bfreuden], can you please take a look as well ? (mainly the change to QuorumPeerConfig). > unable to restart 3 node cluster > > > Key: ZOOKEEPER-1987 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1987 > Project: ZooKeeper > Issue Type: Bug > Components: tests >Affects Versions: 3.5.0 >Reporter: Patrick Hunt >Assignee: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1987-ver1.patch, ZOOKEEPER-1987-ver2.patch, > ZOOKEEPER-1987-ver3.patch, ZOOKEEPER-1987.patch, f1.jstack, l3.jstack, > test3.tar.gz > > > I tried a fairly simple test, start a three node cluster, bring it down, then > restart it. On restart the servers elect the leader and send updates, however > the negotiation never completes - the client ports are never bound for > example. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1987) unable to restart 3 node cluster
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073277#comment-14073277 ] Rakesh R commented on ZOOKEEPER-1987: - [~shralex] I've done the changes and updated a new patch. Please have a look. > unable to restart 3 node cluster > > > Key: ZOOKEEPER-1987 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1987 > Project: ZooKeeper > Issue Type: Bug > Components: tests >Affects Versions: 3.5.0 >Reporter: Patrick Hunt >Assignee: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1987-ver1.patch, ZOOKEEPER-1987-ver2.patch, > ZOOKEEPER-1987-ver3.patch, ZOOKEEPER-1987.patch, f1.jstack, l3.jstack, > test3.tar.gz > > > I tried a fairly simple test, start a three node cluster, bring it down, then > restart it. On restart the servers elect the leader and send updates, however > the negotiation never completes - the client ports are never bound for > example. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (ZOOKEEPER-1987) unable to restart 3 node cluster
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-1987: Attachment: ZOOKEEPER-1987-ver3.patch > unable to restart 3 node cluster > > > Key: ZOOKEEPER-1987 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1987 > Project: ZooKeeper > Issue Type: Bug > Components: tests >Affects Versions: 3.5.0 >Reporter: Patrick Hunt >Assignee: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1987-ver1.patch, ZOOKEEPER-1987-ver2.patch, > ZOOKEEPER-1987-ver3.patch, ZOOKEEPER-1987.patch, f1.jstack, l3.jstack, > test3.tar.gz > > > I tried a fairly simple test, start a three node cluster, bring it down, then > restart it. On restart the servers elect the leader and send updates, however > the negotiation never completes - the client ports are never bound for > example. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1987) unable to restart 3 node cluster
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073252#comment-14073252
]
Alexander Shraer commented on ZOOKEEPER-1987:
-
Hi Rakesh,
I see. So you're adding something like this to QPC#writeDynamicConfig()?
if (osname.toLowerCase().contains("windows")) {
actualDynamicConfigFilename =
actualDynamicConfigFilename.replace('\\', '/');
}
I don't have a windows machine available to test this, but please feel free to
just update the patch.
Thanks,
Alex
> unable to restart 3 node cluster
>
>
> Key: ZOOKEEPER-1987
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1987
> Project: ZooKeeper
> Issue Type: Bug
> Components: tests
>Affects Versions: 3.5.0
>Reporter: Patrick Hunt
>Assignee: Alexander Shraer
>Priority: Blocker
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1987-ver1.patch, ZOOKEEPER-1987-ver2.patch,
> ZOOKEEPER-1987.patch, f1.jstack, l3.jstack, test3.tar.gz
>
>
> I tried a fairly simple test, start a three node cluster, bring it down, then
> restart it. On restart the servers elect the leader and send updates, however
> the negotiation never completes - the client ports are never bound for
> example.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1987) unable to restart 3 node cluster
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073200#comment-14073200
]
Rakesh R commented on ZOOKEEPER-1987:
-
[~shralex] Thanks for the patch. It looks good to me. Just one suggestion,
When I'm executing the tests in _Windows environment_. I have seen the
following code path is updating the "zoo.cfg" with 'dynamicConfigFile file
path'. Here its not converting the windows path to UNIX to avoid problems with
"\" and due to this test case is failing. I've done conversion and after that
its passing consistently. I'm thinking to add this conversion logic too, what
do you say?
{code}
QPC#writeDynamicConfig()
out.write("dynamicConfigFile=".concat(actualDynamicConfigFilename).concat("\n"));
{code}
-Rakesh
> unable to restart 3 node cluster
>
>
> Key: ZOOKEEPER-1987
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1987
> Project: ZooKeeper
> Issue Type: Bug
> Components: tests
>Affects Versions: 3.5.0
>Reporter: Patrick Hunt
>Assignee: Alexander Shraer
>Priority: Blocker
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1987-ver1.patch, ZOOKEEPER-1987-ver2.patch,
> ZOOKEEPER-1987.patch, f1.jstack, l3.jstack, test3.tar.gz
>
>
> I tried a fairly simple test, start a three node cluster, bring it down, then
> restart it. On restart the servers elect the leader and send updates, however
> the negotiation never completes - the client ports are never bound for
> example.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
ZooKeeper-trunk-WinVS2008 - Build # 1453 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008/1453/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 164 lines...] .\src\zookeeper.c(2505): warning C4267: '=' : conversion from 'size_t' to 'int', possible loss of data [f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln] .\src\zookeeper.c(3205): warning C4267: '=' : conversion from 'size_t' to 'int', possible loss of data [f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln] .\src\zookeeper.c(3831): warning C4267: 'initializing' : conversion from 'size_t' to 'int', possible loss of data [f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln] Cli: C:\Program Files (x86)\Microsoft Visual Studio 9.0\Common7\IDE\..\..\vc\vcpackages\vcbuild.exe f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\Cli.vcproj "Release|Win32" cli.obj : error LNK2001: unresolved external symbol __imp__ZOO_READONLY_STATE [f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln] f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\Release\Cli.exe : fatal error LNK1120: 1 unresolved externals [f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln] Done Building Project "f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln" (default targets) -- FAILED. Build FAILED. "f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln" (default target) (1) -> (zookeeper target) -> cl : Command line warning D9035: option 'Wp64' has been deprecated and will be removed in a future release [f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln] .\src\zookeeper.c(252): warning C4267: 'function' : conversion from 'size_t' to 'int', possible loss of data [f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln] .\src\zookeeper.c(533): warning C4996: 'strdup': The POSIX name for this item is deprecated. Instead, use the ISO C++ conformant name: _strdup. See online help for details. [f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln] .\src\zookeeper.c(781): warning C4996: 'strdup': The POSIX name for this item is deprecated. Instead, use the ISO C++ conformant name: _strdup. See online help for details. [f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln] .\src\zookeeper.c(1045): warning C4996: 'strdup': The POSIX name for this item is deprecated. Instead, use the ISO C++ conformant name: _strdup. See online help for details. [f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln] .\src\zookeeper.c(1056): warning C4996: 'strncpy': This function or variable may be unsafe. Consider using strncpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln] .\src\zookeeper.c(1062): warning C4996: 'strdup': The POSIX name for this item is deprecated. Instead, use the ISO C++ conformant name: _strdup. See online help for details. [f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln] .\src\zookeeper.c(1137): warning C4996: 'strdup': The POSIX name for this item is deprecated. Instead, use the ISO C++ conformant name: _strdup. See online help for details. [f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln] .\src\zookeeper.c(1266): warning C4996: 'strdup': The POSIX name for this item is deprecated. Instead, use the ISO C++ conformant name: _strdup. See online help for details. [f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln] .\src\zookeeper.c(1269): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln] .\src\zookeeper.c(1270): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln] .\src\zookeeper.c(1289): warning C4996: 'strdup': The POSIX name for this item is deprecated. Instead, use the ISO C++ conformant name: _strdup. See online help for details. [f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln] .\src\zookeeper.c(1292): warning C4996: 'strdup': The POSIX name for this item is deprecated. Instead, use t
[jira] [Commented] (ZOOKEEPER-1984) testLeaderTimesoutOnNewQuorum is a flakey test
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073090#comment-14073090
]
Hudson commented on ZOOKEEPER-1984:
---
SUCCESS: Integrated in ZooKeeper-trunk #2384 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2384/])
ZOOKEEPER-1984. testLeaderTimesoutOnNewQuorum is a flakey test (Alex Shraer via
phunt) (phunt:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1612867)
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ReconfigTest.java
> testLeaderTimesoutOnNewQuorum is a flakey test
> ---
>
> Key: ZOOKEEPER-1984
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1984
> Project: ZooKeeper
> Issue Type: Bug
> Components: tests
>Affects Versions: 3.5.0
>Reporter: Patrick Hunt
>Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: small_fix.patch
>
>
> I'm seeing intermittent failures in testLeaderTimesoutOnNewQuorum
> It's failing both on jdk6 and jdk7. (this is my personal
> jenkins, I haven't see any other failures than this during the past
> few days).
> {noformat}
> junit.framework.AssertionFailedError
> at
> org.apache.zookeeper.test.ReconfigTest.testServerHasConfig(ReconfigTest.java:127)
> at
> org.apache.zookeeper.test.ReconfigTest.testLeaderTimesoutOnNewQuorum(ReconfigTest.java:450)
> at
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1789) 3.4.x observer causes NPE on 3.5.0 (trunk) participants
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073088#comment-14073088
]
Hudson commented on ZOOKEEPER-1789:
---
SUCCESS: Integrated in ZooKeeper-trunk #2384 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2384/])
ZOOKEEPER-1789. 3.4.x observer causes NPE on 3.5.0 (trunk) participants (Alex
Shraer via phunt) (phunt:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1612885)
* /zookeeper/trunk/CHANGES.txt
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/CnxManagerTest.java
> 3.4.x observer causes NPE on 3.5.0 (trunk) participants
> ---
>
> Key: ZOOKEEPER-1789
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1789
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Raul Gutierrez Segales
>Assignee: Alexander Shraer
>Priority: Critical
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1789.patch, ZOOKEEPER-1789.patch
>
>
> (assigning to Alex because this was introduced by ZOOKEEPER-107, but will
> upload a patch as well.)
> I have a 5 participants cluster running what will be 3.5.0 (i.e.: trunk as of
> today) and an observer running 3.4 (trunk from 3.4 branch). When the observer
> tries to establish a connection to the participants I get:
> {noformat}
> Thread Thread[10.40.78.121:3888,5,main] died java.lang.NullPointerException
> at
> org.apache.zookeeper.server.quorum.QuorumCnxManager.receiveConnection(QuorumCnxManager.java:240)
> at
> org.apache.zookeeper.server.quorum.QuorumCnxManager$Listener.run(QuorumCnxManager.java:552)
> {noformat}
> Looking at QuorumCnxManager.java:240:
> {noformat}
> if (protocolVersion >= 0) { // this is a server id and not a
> protocol version
>sid = protocolVersion;
> electionAddr = self.getVotingView().get(sid).electionAddr;
> } else {
> {noformat}
> and self.getVotingView().get(sid) will be null for Observers. So this block
> should cover that case.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1982) Refactor (touch|add)Session in SessionTrackerImpl.java
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073089#comment-14073089 ] Hudson commented on ZOOKEEPER-1982: --- SUCCESS: Integrated in ZooKeeper-trunk #2384 (See [https://builds.apache.org/job/ZooKeeper-trunk/2384/]) ZOOKEEPER-1982. Refactor (touch|add)Session in SessionTrackerImpl.java (Hongchao Deng via phunt) (phunt: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1612906) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java > Refactor (touch|add)Session in SessionTrackerImpl.java > -- > > Key: ZOOKEEPER-1982 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1982 > Project: ZooKeeper > Issue Type: Improvement >Reporter: Hongchao Deng >Assignee: Hongchao Deng >Priority: Minor > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1982.patch, ZOOKEEPER-1982.patch, > ZOOKEEPER-1982.patch > > > This JIRA extends the idea of ZOOKEEPER-1978. > Besides refactoring get-put operations of concurrentMap in addSession method, > addSession also calls touchSession which repeatedly checks if session > existed. So it would be nice for refactor. Refactoring the second issue is > relevant to ZOOKEEPER-1978. So I create a this JIRA to fix both. -- This message was sent by Atlassian JIRA (v6.2#6252)
ZooKeeper-trunk-WinVS2008_java - Build # 784 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008_java/784/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 301602 lines...] [junit] 2014-07-24 11:54:38,113 [myid:] - INFO [main:ZooKeeperServer@781] - minSessionTimeout set to 6000 [junit] 2014-07-24 11:54:38,113 [myid:] - INFO [main:ZooKeeperServer@790] - maxSessionTimeout set to 6 [junit] 2014-07-24 11:54:38,114 [myid:] - INFO [main:ZooKeeperServer@152] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008_java\trunk\build\test\tmp\test1826834553568571213.junit.dir\version-2 snapdir f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008_java\trunk\build\test\tmp\test1826834553568571213.junit.dir\version-2 [junit] 2014-07-24 11:54:38,114 [myid:] - INFO [main:FileSnap@83] - Reading snapshot f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008_java\trunk\build\test\tmp\test1826834553568571213.junit.dir\version-2\snapshot.b [junit] 2014-07-24 11:54:38,116 [myid:] - INFO [main:FileTxnSnapLog@298] - Snapshotting: 0xb to f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008_java\trunk\build\test\tmp\test1826834553568571213.junit.dir\version-2\snapshot.b [junit] 2014-07-24 11:54:38,118 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2014-07-24 11:54:38,119 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@296] - Accepted socket connection from /127.0.0.1:58487 [junit] 2014-07-24 11:54:38,121 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@835] - Processing stat command from /127.0.0.1:58487 [junit] 2014-07-24 11:54:38,121 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn$StatCommand@684] - Stat command output [junit] 2014-07-24 11:54:38,121 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@1006] - Closed socket connection for client /127.0.0.1:58487 (no session established for client) [junit] 2014-07-24 11:54:38,121 [myid:] - INFO [main:JMXEnv@224] - ensureParent:[InMemoryDataTree, StandaloneServer_port] [junit] 2014-07-24 11:54:38,123 [myid:] - INFO [main:JMXEnv@241] - expect:InMemoryDataTree [junit] 2014-07-24 11:54:38,123 [myid:] - INFO [main:JMXEnv@245] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] 2014-07-24 11:54:38,123 [myid:] - INFO [main:JMXEnv@241] - expect:StandaloneServer_port [junit] 2014-07-24 11:54:38,123 [myid:] - INFO [main:JMXEnv@245] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2014-07-24 11:54:38,124 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@55] - Memory used 11852 [junit] 2014-07-24 11:54:38,124 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@60] - Number of threads 23 [junit] 2014-07-24 11:54:38,124 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@65] - FINISHED TEST METHOD testQuota [junit] 2014-07-24 11:54:38,124 [myid:] - INFO [main:ClientBase@520] - tearDown starting [junit] 2014-07-24 11:54:38,169 [myid:] - INFO [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@963] - Socket connection established to 127.0.0.1/127.0.0.1:11221, initiating session [junit] 2014-07-24 11:54:38,169 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@296] - Accepted socket connection from /127.0.0.1:58482 [junit] 2014-07-24 11:54:38,170 [myid:] - INFO [NIOWorkerThread-2:ZooKeeperServer@877] - Client attempting to renew session 0x14768021e3e at /127.0.0.1:58482 [junit] 2014-07-24 11:54:38,171 [myid:] - INFO [NIOWorkerThread-2:ZooKeeperServer@619] - Established session 0x14768021e3e with negotiated timeout 3 for client /127.0.0.1:58482 [junit] 2014-07-24 11:54:38,211 [myid:] - INFO [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1346] - Session establishment complete on server 127.0.0.1/127.0.0.1:11221, sessionid = 0x14768021e3e, negotiated timeout = 3 [junit] 2014-07-24 11:54:38,212 [myid:] - INFO [ProcessThread(sid:0 cport:-1)::PrepRequestProcessor@685] - Processed session termination for sessionid: 0x14768021e3e [junit] 2014-07-24 11:54:38,212 [myid:] - INFO [SyncThread:0:FileTxnLog@200] - Creating new log file: log.c [junit] 2014-07-24 11:54:38,327 [myid:] - INFO [NIOWorkerThread-1:MBeanRegistry@119] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=Connections,name2=127.0.0.1,name3=0x14768021e3e] [junit] 2014-07-24 11:54:38,328 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@1006] - Closed socket connection for client /127.0.0.1:58482 which had sessi
ZooKeeper-trunk-jdk7 - Build # 924 - Failure
See https://builds.apache.org/job/ZooKeeper-trunk-jdk7/924/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 39 lines...] [junit] 2014-07-24 10:14:37,784 [myid:] - INFO [main:ClientBase@443] - STARTING server [junit] 2014-07-24 10:14:37,785 [myid:] - INFO [main:ClientBase@364] - CREATING server instance 127.0.0.1:11221 [junit] 2014-07-24 10:14:37,785 [myid:] - INFO [main:NIOServerCnxnFactory@670] - Configuring NIO connection handler with 10s sessionless connection timeout, 2 selector thread(s), 32 worker threads, and 64 kB direct buffers. [junit] 2014-07-24 10:14:37,785 [myid:] - INFO [main:NIOServerCnxnFactory@683] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2014-07-24 10:14:37,786 [myid:] - INFO [main:ClientBase@339] - STARTING server instance 127.0.0.1:11221 [junit] 2014-07-24 10:14:37,786 [myid:] - INFO [main:ZooKeeperServer@781] - minSessionTimeout set to 6000 [junit] 2014-07-24 10:14:37,786 [myid:] - INFO [main:ZooKeeperServer@790] - maxSessionTimeout set to 6 [junit] 2014-07-24 10:14:37,787 [myid:] - INFO [main:ZooKeeperServer@152] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-jdk7/trunk/build/test/tmp/test8661209711012206099.junit.dir/version-2 snapdir /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-jdk7/trunk/build/test/tmp/test8661209711012206099.junit.dir/version-2 [junit] 2014-07-24 10:14:37,787 [myid:] - INFO [main:FileSnap@83] - Reading snapshot /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-jdk7/trunk/build/test/tmp/test8661209711012206099.junit.dir/version-2/snapshot.b [junit] 2014-07-24 10:14:37,790 [myid:] - INFO [main:FileTxnSnapLog@298] - Snapshotting: 0xb to /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-jdk7/trunk/build/test/tmp/test8661209711012206099.junit.dir/version-2/snapshot.b [junit] 2014-07-24 10:14:37,792 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2014-07-24 10:14:37,792 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@296] - Accepted socket connection from /127.0.0.1:48930 [junit] 2014-07-24 10:14:37,793 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@835] - Processing stat command from /127.0.0.1:48930 [junit] 2014-07-24 10:14:37,793 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn$StatCommand@684] - Stat command output [junit] 2014-07-24 10:14:37,793 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@1006] - Closed socket connection for client /127.0.0.1:48930 (no session established for client) [junit] 2014-07-24 10:14:37,793 [myid:] - INFO [main:JMXEnv@224] - ensureParent:[InMemoryDataTree, StandaloneServer_port] [junit] 2014-07-24 10:14:37,795 [myid:] - INFO [main:JMXEnv@241] - expect:InMemoryDataTree [junit] 2014-07-24 10:14:37,795 [myid:] - INFO [main:JMXEnv@245] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] 2014-07-24 10:14:37,795 [myid:] - INFO [main:JMXEnv@241] - expect:StandaloneServer_port [junit] 2014-07-24 10:14:37,795 [myid:] - INFO [main:JMXEnv@245] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2014-07-24 10:14:37,796 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@55] - Memory used 18081 [junit] 2014-07-24 10:14:37,796 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@60] - Number of threads 24 [junit] 2014-07-24 10:14:37,796 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@65] - FINISHED TEST METHOD testQuota [junit] 2014-07-24 10:14:37,796 [myid:] - INFO [main:ClientBase@520] - tearDown starting [junit] 2014-07-24 10:14:37,857 [myid:] - INFO [main:ZooKeeper@968] - Session: 0x14767dd890a closed [junit] 2014-07-24 10:14:37,857 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@529] - EventThread shut down [junit] 2014-07-24 10:14:37,857 [myid:] - INFO [main:ClientBase@490] - STOPPING server [junit] 2014-07-24 10:14:37,858 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@219] - accept thread exitted run method [junit] 2014-07-24 10:14:37,858 [myid:] - INFO [ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - ConnnectionExpirerThread interrupted [junit] 2014-07-24 10:14:37,858 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] - selector thread exitted run method [junit] 2014-07-24 10:14:37,858 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] - selector thread exitted run method [junit] 2014
ZooKeeper-trunk-ibm6 - Build # 562 - Failure
See https://builds.apache.org/job/ZooKeeper-trunk-ibm6/562/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 333271 lines...] [junit] 2014-07-24 09:35:47,707 [myid:] - INFO [main:JMXEnv@142] - ensureOnly:[] [junit] 2014-07-24 09:35:47,709 [myid:] - INFO [main:ClientBase@443] - STARTING server [junit] 2014-07-24 09:35:47,709 [myid:] - INFO [main:ClientBase@364] - CREATING server instance 127.0.0.1:11221 [junit] 2014-07-24 09:35:47,710 [myid:] - INFO [main:NIOServerCnxnFactory@670] - Configuring NIO connection handler with 10s sessionless connection timeout, 2 selector thread(s), 32 worker threads, and 64 kB direct buffers. [junit] 2014-07-24 09:35:47,714 [myid:] - INFO [main:NIOServerCnxnFactory@683] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2014-07-24 09:35:47,717 [myid:] - INFO [main:ClientBase@339] - STARTING server instance 127.0.0.1:11221 [junit] 2014-07-24 09:35:47,717 [myid:] - INFO [main:ZooKeeperServer@781] - minSessionTimeout set to 6000 [junit] 2014-07-24 09:35:47,717 [myid:] - INFO [main:ZooKeeperServer@790] - maxSessionTimeout set to 6 [junit] 2014-07-24 09:35:47,718 [myid:] - INFO [main:ZooKeeperServer@152] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-ibm6/trunk/build/test/tmp/test2141075198280891602.junit.dir/version-2 snapdir /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-ibm6/trunk/build/test/tmp/test2141075198280891602.junit.dir/version-2 [junit] 2014-07-24 09:35:47,719 [myid:] - INFO [main:FileSnap@83] - Reading snapshot /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-ibm6/trunk/build/test/tmp/test2141075198280891602.junit.dir/version-2/snapshot.b [junit] 2014-07-24 09:35:47,722 [myid:] - INFO [main:FileTxnSnapLog@298] - Snapshotting: 0xb to /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-ibm6/trunk/build/test/tmp/test2141075198280891602.junit.dir/version-2/snapshot.b [junit] 2014-07-24 09:35:47,725 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2014-07-24 09:35:47,725 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@296] - Accepted socket connection from /127.0.0.1:34881 [junit] 2014-07-24 09:35:47,728 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@835] - Processing stat command from /127.0.0.1:34881 [junit] 2014-07-24 09:35:47,728 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn$StatCommand@684] - Stat command output [junit] 2014-07-24 09:35:47,729 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@1006] - Closed socket connection for client /127.0.0.1:34881 (no session established for client) [junit] 2014-07-24 09:35:47,729 [myid:] - INFO [main:JMXEnv@224] - ensureParent:[InMemoryDataTree, StandaloneServer_port] [junit] 2014-07-24 09:35:47,733 [myid:] - INFO [main:JMXEnv@241] - expect:InMemoryDataTree [junit] 2014-07-24 09:35:47,734 [myid:] - INFO [main:JMXEnv@245] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] 2014-07-24 09:35:47,734 [myid:] - INFO [main:JMXEnv@241] - expect:StandaloneServer_port [junit] 2014-07-24 09:35:47,734 [myid:] - INFO [main:JMXEnv@245] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2014-07-24 09:35:47,735 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@55] - Memory used 5517 [junit] 2014-07-24 09:35:47,735 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@60] - Number of threads 40 [junit] 2014-07-24 09:35:47,736 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@65] - FINISHED TEST METHOD testQuota [junit] 2014-07-24 09:35:47,736 [myid:] - INFO [main:ClientBase@520] - tearDown starting [junit] 2014-07-24 09:35:47,753 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@529] - EventThread shut down [junit] 2014-07-24 09:35:47,755 [myid:] - INFO [main:ZooKeeper@968] - Session: 0x14767b9faa5 closed [junit] 2014-07-24 09:35:47,755 [myid:] - INFO [main:ClientBase@490] - STOPPING server [junit] 2014-07-24 09:35:47,755 [myid:] - INFO [ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - ConnnectionExpirerThread interrupted [junit] 2014-07-24 09:35:47,757 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] - selector thread exitted run method [junit] 2014-07-24 09:35:47,757 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] - selector thread exitted run method [junit] 2014-07-24 09:35:47,757 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOSe
[jira] [Commented] (ZOOKEEPER-1987) unable to restart 3 node cluster
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073034#comment-14073034 ] Hadoop QA commented on ZOOKEEPER-1987: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12657578/ZOOKEEPER-1987-ver2.patch against trunk revision 1612906. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2226//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2226//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2226//console This message is automatically generated. > unable to restart 3 node cluster > > > Key: ZOOKEEPER-1987 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1987 > Project: ZooKeeper > Issue Type: Bug > Components: tests >Affects Versions: 3.5.0 >Reporter: Patrick Hunt >Assignee: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1987-ver1.patch, ZOOKEEPER-1987-ver2.patch, > ZOOKEEPER-1987.patch, f1.jstack, l3.jstack, test3.tar.gz > > > I tried a fairly simple test, start a three node cluster, bring it down, then > restart it. On restart the servers elect the leader and send updates, however > the negotiation never completes - the client ports are never bound for > example. -- This message was sent by Atlassian JIRA (v6.2#6252)
Failed: ZOOKEEPER-1987 PreCommit Build #2226
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1987 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2226/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 312648 lines...] [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 9 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2226//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2226//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2226//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 1aca32009af67ea0dea411205146bbc710630eba logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1713: exec returned: 1 Total time: 38 minutes 22 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2179 Archived 7 artifacts Archive block size is 32768 Received 0 blocks and 546329 bytes Compression is 0.0% Took 0.74 sec Recording test results Description set: ZOOKEEPER-1987 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## 1 tests failed. FAILED: org.apache.zookeeper.test.NioNettySuiteHammerTest.testHammer Error Message: Forked Java VM exited abnormally. Please note the time in the report does not reflect the time until the VM exit. Stack Trace: junit.framework.AssertionFailedError: Forked Java VM exited abnormally. Please note the time in the report does not reflect the time until the VM exit.
Failed: ZOOKEEPER-1985 PreCommit Build #2227
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1985 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2227/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 1768 lines...] [exec] Skipping patch. [exec] 15 out of 15 hunks ignored [exec] PATCH APPLICATION FAILED [exec] [exec] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12657580/ZOOKEEPER-1985.patch [exec] against trunk revision 1612906. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] -1 patch. The patch command could not apply the patch. [exec] [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2227//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] fcd5b3ce0746e7cb1db655bcbc6945f5a8d8cbc4 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1713: exec returned: 1 Total time: 58 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2179 Archived 1 artifacts Archive block size is 32768 Received 0 blocks and 58386 bytes Compression is 0.0% Took 1.9 sec Recording test results Description set: ZOOKEEPER-1985 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## No tests ran.
[jira] [Commented] (ZOOKEEPER-1985) Memory leak in C client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073033#comment-14073033 ] Hadoop QA commented on ZOOKEEPER-1985: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12657580/ZOOKEEPER-1985.patch against trunk revision 1612906. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2227//console This message is automatically generated. > Memory leak in C client > --- > > Key: ZOOKEEPER-1985 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1985 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.4.6 >Reporter: desmondhe >Assignee: desmondhe >Priority: Minor > Attachments: ZOOKEEPER-1985.patch > > > in the file zookeeper.c, most function call of "close_buffer_oarchive(&oa, > 0)" shoud been instead by > close_buffer_oarchive(&oa, rc < 0 ? 1 : 0); -- This message was sent by Atlassian JIRA (v6.2#6252)
ZooKeeper-trunk-WinVS2008 - Build # 1452 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008/1452/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 166 lines...] .\src\zookeeper.c(2505): warning C4267: '=' : conversion from 'size_t' to 'int', possible loss of data [f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln] .\src\zookeeper.c(3205): warning C4267: '=' : conversion from 'size_t' to 'int', possible loss of data [f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln] .\src\zookeeper.c(3831): warning C4267: 'initializing' : conversion from 'size_t' to 'int', possible loss of data [f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln] Cli: C:\Program Files (x86)\Microsoft Visual Studio 9.0\Common7\IDE\..\..\vc\vcpackages\vcbuild.exe f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\Cli.vcproj "Release|Win32" cli.obj : error LNK2001: unresolved external symbol __imp__ZOO_READONLY_STATE [f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln] f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\Release\Cli.exe : fatal error LNK1120: 1 unresolved externals [f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln] Done Building Project "f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln" (default targets) -- FAILED. Build FAILED. "f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln" (default target) (1) -> (zookeeper target) -> cl : Command line warning D9035: option 'Wp64' has been deprecated and will be removed in a future release [f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln] .\src\zookeeper.c(252): warning C4267: 'function' : conversion from 'size_t' to 'int', possible loss of data [f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln] .\src\zookeeper.c(533): warning C4996: 'strdup': The POSIX name for this item is deprecated. Instead, use the ISO C++ conformant name: _strdup. See online help for details. [f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln] .\src\zookeeper.c(781): warning C4996: 'strdup': The POSIX name for this item is deprecated. Instead, use the ISO C++ conformant name: _strdup. See online help for details. [f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln] .\src\zookeeper.c(1045): warning C4996: 'strdup': The POSIX name for this item is deprecated. Instead, use the ISO C++ conformant name: _strdup. See online help for details. [f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln] .\src\zookeeper.c(1056): warning C4996: 'strncpy': This function or variable may be unsafe. Consider using strncpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln] .\src\zookeeper.c(1062): warning C4996: 'strdup': The POSIX name for this item is deprecated. Instead, use the ISO C++ conformant name: _strdup. See online help for details. [f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln] .\src\zookeeper.c(1137): warning C4996: 'strdup': The POSIX name for this item is deprecated. Instead, use the ISO C++ conformant name: _strdup. See online help for details. [f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln] .\src\zookeeper.c(1266): warning C4996: 'strdup': The POSIX name for this item is deprecated. Instead, use the ISO C++ conformant name: _strdup. See online help for details. [f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln] .\src\zookeeper.c(1269): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln] .\src\zookeeper.c(1270): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln] .\src\zookeeper.c(1289): warning C4996: 'strdup': The POSIX name for this item is deprecated. Instead, use the ISO C++ conformant name: _strdup. See online help for details. [f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln] .\src\zookeeper.c(1292): warning C4996: 'strdup': The POSIX name for this item is deprecated. Instead, use t
ZooKeeper-3.4-WinVS2008_java - Build # 539 - Still Failing
See https://builds.apache.org/job/ZooKeeper-3.4-WinVS2008_java/539/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 171692 lines...] [junit] 2014-07-24 10:10:38,570 [myid:] - INFO [main:JMXEnv@146] - ensureOnly:[] [junit] 2014-07-24 10:10:38,571 [myid:] - INFO [main:ClientBase@443] - STARTING server [junit] 2014-07-24 10:10:38,571 [myid:] - INFO [main:ClientBase@364] - CREATING server instance 127.0.0.1:11221 [junit] 2014-07-24 10:10:38,572 [myid:] - INFO [main:NIOServerCnxnFactory@94] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2014-07-24 10:10:38,573 [myid:] - INFO [main:ClientBase@339] - STARTING server instance 127.0.0.1:11221 [junit] 2014-07-24 10:10:38,573 [myid:] - INFO [main:ZooKeeperServer@162] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir f:\hudson\hudson-slave\workspace\ZooKeeper-3.4-WinVS2008_java\branch-3.4\build\test\tmp\test3231518254009286283.junit.dir\version-2 snapdir f:\hudson\hudson-slave\workspace\ZooKeeper-3.4-WinVS2008_java\branch-3.4\build\test\tmp\test3231518254009286283.junit.dir\version-2 [junit] 2014-07-24 10:10:38,576 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2014-07-24 10:10:38,577 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@197] - Accepted socket connection from /127.0.0.1:61448 [junit] 2014-07-24 10:10:38,577 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@827] - Processing stat command from /127.0.0.1:61448 [junit] 2014-07-24 10:10:38,578 [myid:] - INFO [Thread-4:NIOServerCnxn$StatCommand@663] - Stat command output [junit] 2014-07-24 10:10:38,578 [myid:] - INFO [Thread-4:NIOServerCnxn@1007] - Closed socket connection for client /127.0.0.1:61448 (no session established for client) [junit] 2014-07-24 10:10:38,578 [myid:] - INFO [main:JMXEnv@229] - ensureParent:[InMemoryDataTree, StandaloneServer_port] [junit] 2014-07-24 10:10:38,579 [myid:] - INFO [main:JMXEnv@246] - expect:InMemoryDataTree [junit] 2014-07-24 10:10:38,579 [myid:] - INFO [main:JMXEnv@250] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] 2014-07-24 10:10:38,579 [myid:] - INFO [main:JMXEnv@246] - expect:StandaloneServer_port [junit] 2014-07-24 10:10:38,579 [myid:] - INFO [main:JMXEnv@250] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2014-07-24 10:10:38,580 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@55] - Memory used 10819 [junit] 2014-07-24 10:10:38,580 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@60] - Number of threads 20 [junit] 2014-07-24 10:10:38,580 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@65] - FINISHED TEST METHOD testQuota [junit] 2014-07-24 10:10:38,580 [myid:] - INFO [main:ClientBase@520] - tearDown starting [junit] 2014-07-24 10:10:39,001 [myid:] - INFO [SessionTracker:SessionTrackerImpl@162] - SessionTrackerImpl exited loop! [junit] 2014-07-24 10:10:39,003 [myid:] - INFO [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@852] - Socket connection established to 127.0.0.1/127.0.0.1:11221, initiating session [junit] 2014-07-24 10:10:39,003 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@197] - Accepted socket connection from /127.0.0.1:61445 [junit] 2014-07-24 10:10:39,003 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:ZooKeeperServer@861] - Client attempting to renew session 0x14767a2ebdd at /127.0.0.1:61445 [junit] 2014-07-24 10:10:39,004 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:ZooKeeperServer@617] - Established session 0x14767a2ebdd with negotiated timeout 3 for client /127.0.0.1:61445 [junit] 2014-07-24 10:10:39,004 [myid:] - INFO [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1235] - Session establishment complete on server 127.0.0.1/127.0.0.1:11221, sessionid = 0x14767a2ebdd, negotiated timeout = 3 [junit] 2014-07-24 10:10:39,005 [myid:] - INFO [ProcessThread(sid:0 cport:-1)::PrepRequestProcessor@494] - Processed session termination for sessionid: 0x14767a2ebdd [junit] 2014-07-24 10:10:39,005 [myid:] - INFO [SyncThread:0:FileTxnLog@199] - Creating new log file: log.c [junit] 2014-07-24 10:10:39,011 [myid:] - INFO [main:ZooKeeper@684] - Session: 0x14767a2ebdd closed [junit] 2014-07-24 10:10:39,011 [myid:] - INFO [main:ClientBase@490] - STOPPING server [junit] 2014-07-24 10:10:39,011 [myid:] - WARN [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@357] - caught end of stream exception [junit] EndOfStreamException: Unable to read additional
[jira] [Updated] (ZOOKEEPER-1985) Memory leak in C client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] desmondhe updated ZOOKEEPER-1985: - Attachment: ZOOKEEPER-1985.patch patch for zookeeper-3.4.6/src/c/src/zookeeper.c > Memory leak in C client > --- > > Key: ZOOKEEPER-1985 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1985 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.4.6 >Reporter: desmondhe >Assignee: desmondhe >Priority: Minor > Attachments: ZOOKEEPER-1985.patch > > > in the file zookeeper.c, most function call of "close_buffer_oarchive(&oa, > 0)" shoud been instead by > close_buffer_oarchive(&oa, rc < 0 ? 1 : 0); -- This message was sent by Atlassian JIRA (v6.2#6252)
Failed: ZOOKEEPER-1987 PreCommit Build #2225
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1987 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2225/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 305252 lines...] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 9 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. [exec] [exec] -1 release audit. The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings). [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2225//testReport/ [exec] Release audit warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2225//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2225//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2225//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 927c716c83e21bef31af804fc6dab756fc3041d4 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1713: exec returned: 2 Total time: 37 minutes 35 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2179 Archived 8 artifacts Archive block size is 32768 Received 0 blocks and 549925 bytes Compression is 0.0% Took 0.7 sec Recording test results Description set: ZOOKEEPER-1987 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## 6 tests failed. FAILED: org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testNextConfigCompletion Error Message: null Stack Trace: junit.framework.AssertionFailedError at org.apache.zookeeper.test.ReconfigTest.testServerHasConfig(ReconfigTest.java:122) at org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testNextConfigCompletion(ReconfigRecoveryTest.java:106) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52) FAILED: org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentServersAreObserversInNextConfig Error Message: waiting for server 0 being up Stack Trace: junit.framework.AssertionFailedError: waiting for server 0 being up at org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentServersAreObserversInNextConfig(ReconfigRecoveryTest.java:222) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52) FAILED: org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testNextConfigUnreachable Error Message: server 0 is up but shouldn't be Stack Trace: junit.framework.AssertionFailedError: server 0 is up but shouldn't be at org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testNextConfigUnreachable(ReconfigRecoveryTest.java:290) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52) FAILED: org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testNextConfigAlreadyActive Error Message: null Stack Trace: junit.framework.Assertio
[jira] [Updated] (ZOOKEEPER-1987) unable to restart 3 node cluster
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Shraer updated ZOOKEEPER-1987: Attachment: ZOOKEEPER-1987-ver2.patch > unable to restart 3 node cluster > > > Key: ZOOKEEPER-1987 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1987 > Project: ZooKeeper > Issue Type: Bug > Components: tests >Affects Versions: 3.5.0 >Reporter: Patrick Hunt >Assignee: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1987-ver1.patch, ZOOKEEPER-1987-ver2.patch, > ZOOKEEPER-1987.patch, f1.jstack, l3.jstack, test3.tar.gz > > > I tried a fairly simple test, start a three node cluster, bring it down, then > restart it. On restart the servers elect the leader and send updates, however > the negotiation never completes - the client ports are never bound for > example. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1987) unable to restart 3 node cluster
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073005#comment-14073005 ] Hadoop QA commented on ZOOKEEPER-1987: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12657571/ZOOKEEPER-1987-ver1.patch against trunk revision 1612906. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. -1 release audit. The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings). -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2225//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2225//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2225//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2225//console This message is automatically generated. > unable to restart 3 node cluster > > > Key: ZOOKEEPER-1987 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1987 > Project: ZooKeeper > Issue Type: Bug > Components: tests >Affects Versions: 3.5.0 >Reporter: Patrick Hunt >Assignee: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1987-ver1.patch, ZOOKEEPER-1987-ver2.patch, > ZOOKEEPER-1987.patch, f1.jstack, l3.jstack, test3.tar.gz > > > I tried a fairly simple test, start a three node cluster, bring it down, then > restart it. On restart the servers elect the leader and send updates, however > the negotiation never completes - the client ports are never bound for > example. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1987) unable to restart 3 node cluster
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073000#comment-14073000 ] Rakesh R commented on ZOOKEEPER-1987: - [~shralex] Please include Apache License for the DynamicConfigBackwardCompatibilityTest.java. > unable to restart 3 node cluster > > > Key: ZOOKEEPER-1987 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1987 > Project: ZooKeeper > Issue Type: Bug > Components: tests >Affects Versions: 3.5.0 >Reporter: Patrick Hunt >Assignee: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1987-ver1.patch, ZOOKEEPER-1987.patch, > f1.jstack, l3.jstack, test3.tar.gz > > > I tried a fairly simple test, start a three node cluster, bring it down, then > restart it. On restart the servers elect the leader and send updates, however > the negotiation never completes - the client ports are never bound for > example. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1987) unable to restart 3 node cluster
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14072989#comment-14072989 ] Hadoop QA commented on ZOOKEEPER-1987: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12657568/ZOOKEEPER-1987.patch against trunk revision 1612906. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2224//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2224//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2224//console This message is automatically generated. > unable to restart 3 node cluster > > > Key: ZOOKEEPER-1987 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1987 > Project: ZooKeeper > Issue Type: Bug > Components: tests >Affects Versions: 3.5.0 >Reporter: Patrick Hunt >Assignee: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1987-ver1.patch, ZOOKEEPER-1987.patch, > f1.jstack, l3.jstack, test3.tar.gz > > > I tried a fairly simple test, start a three node cluster, bring it down, then > restart it. On restart the servers elect the leader and send updates, however > the negotiation never completes - the client ports are never bound for > example. -- This message was sent by Atlassian JIRA (v6.2#6252)
Failed: ZOOKEEPER-1987 PreCommit Build #2224
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1987 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2224/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 304822 lines...] [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2224//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2224//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2224//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] b00c2c1d8d008751199147f79deeb278be5e9cb4 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1713: exec returned: 1 Total time: 37 minutes 29 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2179 Archived 7 artifacts Archive block size is 32768 Received 0 blocks and 546307 bytes Compression is 0.0% Took 2.8 sec Recording test results Description set: ZOOKEEPER-1987 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## 7 tests failed. REGRESSION: org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testInconsistentPeerType Error Message: Should warn about inconsistent peer type Stack Trace: junit.framework.AssertionFailedError: Should warn about inconsistent peer type at org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testInconsistentPeerType(QuorumPeerMainTest.java:532) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52) REGRESSION: org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testNextConfigCompletion Error Message: null Stack Trace: junit.framework.AssertionFailedError at org.apache.zookeeper.test.ReconfigTest.testServerHasConfig(ReconfigTest.java:122) at org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testNextConfigCompletion(ReconfigRecoveryTest.java:212) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52) REGRESSION: org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentServersAreObserversInNextConfig Error Message: waiting for server 0 being up Stack Trace: junit.framework.AssertionFailedError: waiting for server 0 being up at org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentServersAreObserversInNextConfig(ReconfigRecoveryTest.java:328) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52) REGRESSION: org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testNextConfigUnreachable Error Message: server 0 is up but shouldn't be Stack Trace: junit.framework.AssertionFailedError: server 0 is up but shouldn't be at org.apache.zookeeper.server.quorum.ReconfigRecoveryT
[jira] [Updated] (ZOOKEEPER-1987) unable to restart 3 node cluster
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Shraer updated ZOOKEEPER-1987: Attachment: ZOOKEEPER-1987-ver1.patch I removed the old test checking config file backward compatibility - the new one has better coverage. > unable to restart 3 node cluster > > > Key: ZOOKEEPER-1987 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1987 > Project: ZooKeeper > Issue Type: Bug > Components: tests >Affects Versions: 3.5.0 >Reporter: Patrick Hunt >Assignee: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1987-ver1.patch, ZOOKEEPER-1987.patch, > f1.jstack, l3.jstack, test3.tar.gz > > > I tried a fairly simple test, start a three node cluster, bring it down, then > restart it. On restart the servers elect the leader and send updates, however > the negotiation never completes - the client ports are never bound for > example. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1907) Improve Thread handling
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14072959#comment-14072959
]
Rakesh R commented on ZOOKEEPER-1907:
-
[~hdeng] Attached latest patch where I've corrected the test case. Could you
have a look at this. Thanks!
> Improve Thread handling
> ---
>
> Key: ZOOKEEPER-1907
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1907
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
>Affects Versions: 3.5.0
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1907.patch, ZOOKEEPER-1907.patch,
> ZOOKEEPER-1907.patch, ZOOKEEPER-1907.patch, ZOOKEEPER-1907.patch,
> ZOOKEEPER-1907.patch, ZOOKEEPER-1907.patch
>
>
> Server has many critical threads running and co-ordinating each other like
> RequestProcessor chains et. When going through each threads, most of them
> having the similar structure like:
> {code}
> public void run() {
> try {
> while(running)
>// processing logic
> }
> } catch (InterruptedException e) {
> LOG.error("Unexpected interruption", e);
> } catch (Exception e) {
> LOG.error("Unexpected exception", e);
> }
> LOG.info("...exited loop!");
> }
> {code}
> From the design I could see, there could be a chance of silently leaving the
> thread by swallowing the exception. If this happens in the production, the
> server would get hanged forever and would not be able to deliver its role.
> Now its hard for the management tool to detect this.
> The idea of this JIRA is to discuss and imprv.
> Reference: [Community discussion
> thread|http://mail-archives.apache.org/mod_mbox/zookeeper-user/201403.mbox/%3cc2496325850aa74c92aaf83aa9662d26458a1...@szxeml561-mbx.china.huawei.com%3E]
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (ZOOKEEPER-1987) unable to restart 3 node cluster
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Shraer updated ZOOKEEPER-1987: Attachment: ZOOKEEPER-1987.patch Attaching a patch that includes a new test for this scenario. > unable to restart 3 node cluster > > > Key: ZOOKEEPER-1987 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1987 > Project: ZooKeeper > Issue Type: Bug > Components: tests >Affects Versions: 3.5.0 >Reporter: Patrick Hunt >Assignee: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1987.patch, f1.jstack, l3.jstack, test3.tar.gz > > > I tried a fairly simple test, start a three node cluster, bring it down, then > restart it. On restart the servers elect the leader and send updates, however > the negotiation never completes - the client ports are never bound for > example. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (ZOOKEEPER-1987) unable to restart 3 node cluster
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Shraer updated ZOOKEEPER-1987: Component/s: (was: server) tests > unable to restart 3 node cluster > > > Key: ZOOKEEPER-1987 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1987 > Project: ZooKeeper > Issue Type: Bug > Components: tests >Affects Versions: 3.5.0 >Reporter: Patrick Hunt >Assignee: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1987.patch, f1.jstack, l3.jstack, test3.tar.gz > > > I tried a fairly simple test, start a three node cluster, bring it down, then > restart it. On restart the servers elect the leader and send updates, however > the negotiation never completes - the client ports are never bound for > example. -- This message was sent by Atlassian JIRA (v6.2#6252)
Failed: ZOOKEEPER-1907 PreCommit Build #2223
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1907 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2223/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 340600 lines...] [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 15 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2223//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2223//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2223//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 790c243b706d7491aa157e270d10bb2c383d88af logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1713: exec returned: 1 Total time: 52 minutes 19 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2179 Archived 7 artifacts Archive block size is 32768 Received 0 blocks and 546622 bytes Compression is 0.0% Took 3 sec Recording test results Description set: ZOOKEEPER-1907 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## 2 tests failed. REGRESSION: org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentObserverIsParticipantInNewConfig Error Message: null Stack Trace: junit.framework.AssertionFailedError at org.apache.zookeeper.test.ReconfigTest.testServerHasConfig(ReconfigTest.java:122) at org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentObserverIsParticipantInNewConfig(ReconfigRecoveryTest.java:544) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52) FAILED: org.apache.zookeeper.test.NioNettySuiteHammerTest.testHammer Error Message: Timeout occurred. Please note the time in the report does not reflect the time until the timeout. Stack Trace: junit.framework.AssertionFailedError: Timeout occurred. Please note the time in the report does not reflect the time until the timeout.
[jira] [Commented] (ZOOKEEPER-1907) Improve Thread handling
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14072922#comment-14072922
]
Hadoop QA commented on ZOOKEEPER-1907:
--
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12657546/ZOOKEEPER-1907.patch
against trunk revision 1612906.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 15 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2223//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2223//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2223//console
This message is automatically generated.
> Improve Thread handling
> ---
>
> Key: ZOOKEEPER-1907
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1907
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
>Affects Versions: 3.5.0
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1907.patch, ZOOKEEPER-1907.patch,
> ZOOKEEPER-1907.patch, ZOOKEEPER-1907.patch, ZOOKEEPER-1907.patch,
> ZOOKEEPER-1907.patch, ZOOKEEPER-1907.patch
>
>
> Server has many critical threads running and co-ordinating each other like
> RequestProcessor chains et. When going through each threads, most of them
> having the similar structure like:
> {code}
> public void run() {
> try {
> while(running)
>// processing logic
> }
> } catch (InterruptedException e) {
> LOG.error("Unexpected interruption", e);
> } catch (Exception e) {
> LOG.error("Unexpected exception", e);
> }
> LOG.info("...exited loop!");
> }
> {code}
> From the design I could see, there could be a chance of silently leaving the
> thread by swallowing the exception. If this happens in the production, the
> server would get hanged forever and would not be able to deliver its role.
> Now its hard for the management tool to detect this.
> The idea of this JIRA is to discuss and imprv.
> Reference: [Community discussion
> thread|http://mail-archives.apache.org/mod_mbox/zookeeper-user/201403.mbox/%3cc2496325850aa74c92aaf83aa9662d26458a1...@szxeml561-mbx.china.huawei.com%3E]
--
This message was sent by Atlassian JIRA
(v6.2#6252)
