[GitHub] zookeeper issue #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast protoc...

[ivmaykov]

Github user ivmaykov commented on the issue:

https://github.com/apache/zookeeper/pull/184
  
@anmolnar thanks for the hard work! Our plan is to run this on a real 
cluster for about a month, if everything is working well, that will be a pretty 
good argument for "this code is ready to be merged to master".

There are 2 pieces of functionality that I would like to add:
- support for PEM-encoded certs and private keys. I have this working 
already, just need to figure out how to stack my PR on top of your PR.
- re-initialize the SSLContext when the cert file changes, without 
restarting the server. Our certs are not very long-lived and are refreshed by a 
mechanism outside of ZK, so ZK process may outlive a cert and will need to 
refresh it. This is not yet done, but I'm starting to work on it, will send 
that PR out once it's ready as well.


---

ZooKeeper-trunk - Build # 78 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk/78/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 142.23 KB...]
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.743 sec, Thread: 5, Class: org.apache.zookeeper.test.SaslSuperUserTest
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest in thread 
8
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.708 sec, Thread: 8, Class: org.apache.zookeeper.test.SessionInvalidationTest
[junit] Running org.apache.zookeeper.test.SessionTest in thread 5
[junit] Running org.apache.zookeeper.test.SessionTimeoutTest in thread 8
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.467 sec, Thread: 8, Class: org.apache.zookeeper.test.SessionTimeoutTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.499 sec, Thread: 6, Class: org.apache.zookeeper.test.ServerCnxnTest
[junit] Running org.apache.zookeeper.test.SessionTrackerCheckTest in thread 
8
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.085 sec, Thread: 8, Class: org.apache.zookeeper.test.SessionTrackerCheckTest
[junit] Running org.apache.zookeeper.test.SessionUpgradeTest in thread 6
[junit] Running org.apache.zookeeper.test.StandaloneTest in thread 8
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.659 sec, Thread: 8, Class: org.apache.zookeeper.test.StandaloneTest
[junit] Running org.apache.zookeeper.test.StatTest in thread 8
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.128 sec, Thread: 8, Class: org.apache.zookeeper.test.StatTest
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 8
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.792 sec, Thread: 8, Class: org.apache.zookeeper.test.StaticHostProviderTest
[junit] Running org.apache.zookeeper.test.StringUtilTest in thread 8
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.067 sec, Thread: 8, Class: org.apache.zookeeper.test.StringUtilTest
[junit] Running org.apache.zookeeper.test.SyncCallTest in thread 8
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
12.154 sec, Thread: 5, Class: org.apache.zookeeper.test.SessionTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.749 sec, Thread: 8, Class: org.apache.zookeeper.test.SyncCallTest
[junit] Running org.apache.zookeeper.test.TruncateTest in thread 5
[junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in 
thread 8
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
70.958 sec, Thread: 1, Class: org.apache.zookeeper.test.QuorumZxidSyncTest
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
4.954 sec, Thread: 5, Class: org.apache.zookeeper.test.TruncateTest
[junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 5
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.084 sec, Thread: 5, Class: org.apache.zookeeper.test.WatchedEventTest
[junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 1
[junit] Running org.apache.zookeeper.test.WatcherTest in thread 5
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.178 sec, Thread: 1, Class: org.apache.zookeeper.test.WatcherFuncTest
[junit] Running org.apache.zookeeper.test.X509AuthTest in thread 1
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.095 sec, Thread: 1, Class: org.apache.zookeeper.test.X509AuthTest
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in 
thread 1
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
20.778 sec, Thread: 6, Class: org.apache.zookeeper.test.SessionUpgradeTest
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 6
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.795 sec, Thread: 6, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 14, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 
90.049 sec, Thread: 7, Class: org.apache.zookeeper.test.QuorumTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
22.677 sec, Thread: 8, Class: 
org.apache.zookeeper.test.WatchEventWhenAutoResetTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
15.413 sec, Thread: 1, Class: org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
29.225 sec, Thread: 5, Class: org.apache.zookeeper.test.WatcherTest
[junit] Tests run: 105, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
345.657 

Re: [VOTE] Apache ZooKeeper release 3.4.13 candidate 0

[Michael Han]

Hi Pat,

Yes please hold off reviewing. A quick look indicates that this RC is
problematic in terms of the C client build files - I don't know what
happened as I was following standard release protocol.
I'll investigate a little bit more, and cut a new RC before next Monday.

On Wed, Jun 27, 2018 at 12:30 PM, Patrick Hunt  wrote:

> Given this has a -1 should I hold off reviewing? Michael what are you
> planning to do? Cut another RC?
>
> Patrick
>
> On Wed, Jun 27, 2018 at 7:17 AM Norbert Kalmar
>  wrote:
>
>> +1 (non-binding)
>>
>> Built from source (release-3.4.13-rc0 tag), run in standalone, cluster of
>> 3, runed basic commands (create, get,set, delete etc.).
>> MacOS 10.13.4
>>
>> Thanks,
>> Norbert
>>
>> On Wed, Jun 27, 2018 at 3:45 PM Andor Molnar 
>> wrote:
>>
>> > + tested with different cluster sizes: 1,3,5,7
>> > + verified a few 4lw commands
>> > + verified JMX interface
>> >
>> > Regards,
>> > Andor
>> >
>> >
>> > On Wed, Jun 27, 2018 at 2:51 PM, Andor Molnar 
>> wrote:
>> >
>> > > Hi Michael,
>> > >
>> > > Thanks for putting together this new release.
>> > >
>> > > My vote: -1
>> > >
>> > > I've run the following tests so far:
>> > > + signatures verified
>> > > + java unit tests successful
>> > > - unable to build C client / C++ unit tests, because ./configure
>> script
>> > is
>> > > not executable
>> > >
>> > > BUILD FAILED
>> > > /home/andor/work/zookeeper-3.4.13/build.xml:1511: The following error
>> > > occurred while executing this line:
>> > > /home/andor/work/zookeeper-3.4.13/build.xml:1470: The following error
>> > > occurred while executing this line:
>> > > /home/andor/work/zookeeper-3.4.13/build.xml:1461: Execute failed:
>> > > java.io.IOException: Cannot run program
>> > "/home/andor/work/zookeeper-3.4.13/src/c/configure"
>> > > (in directory
>> > "/home/andor/work/zookeeper-3.4.13/build/test/test-cppunit"):
>> > > error=13, Permission denied
>> > >
>> > > Looking at the contents of the C client, it's slightly different from
>> > what
>> > > we released in 3.4.12:
>> > >
>> > > [andor@andor-centos work]$ ls -l zookeeper-3.4.12/src/c
>> > > total 1748
>> > > -rw-rw-r--. 1 andor andor  11533 Mar 27 06:32 acinclude.m4
>> > > -rw-rw-r--. 1 andor andor 376234 Mar 27 06:32 aclocal.m4
>> > > -rw-rw-r--. 1 andor andor   4733 Mar 27 06:32 aminclude.am
>> > > drwxr-xr-x. 2 andor andor 86 Mar 27 06:32 autom4te.cache
>> > > -rw-rw-r--. 1 andor andor  50794 Mar 27 06:32 c-doc.Doxyfile
>> > > -rw-rw-r--. 1 andor andor   4343 Mar 27 06:32 ChangeLog
>> > > -rw-rw-r--. 1 andor andor   4763 Mar 27 06:32 cmake_config.h.in
>> > > -rw-rw-r--. 1 andor andor   6456 Mar 27 06:32 CMakeLists.txt
>> > > -rwxr-xr-x. 1 andor andor   7333 Mar 27 06:32 compile
>> > > -rwxr-xr-x. 1 andor andor  43499 Mar 27 06:32 config.guess
>> > > -rw-rw-r--. 1 andor andor   3989 Mar 27 06:32 config.h.in
>> > > -rwxr-xr-x. 1 andor andor  36144 Mar 27 06:32 config.sub
>> > > -rwxr-xr-x. 1 andor andor 649183 Mar 27 06:32 configure
>> > > -rw-rw-r--. 1 andor andor   4110 Mar 27 06:32 configure.ac
>> > > -rwxr-xr-x. 1 andor andor  23566 Mar 27 06:32 depcomp
>> > > drwxr-xr-x. 2 andor andor 54 Mar 27 06:32 generated
>> > > drwxr-xr-x. 2 andor andor127 Mar 27 06:32 include
>> > > -rw-rw-r--. 1 andor andor   9416 Mar 27 06:32 INSTALL
>> > > -rwxr-xr-x. 1 andor andor  15155 Mar 27 06:32 install-sh
>> > > -rw-rw-r--. 1 andor andor  11358 Mar 27 06:32 LICENSE
>> > > -rwxr-xr-x. 1 andor andor 324404 Mar 27 06:32 ltmain.sh
>> > > -rw-rw-r--. 1 andor andor   4367 Mar 27 06:32 Makefile.am
>> > > -rw-rw-r--. 1 andor andor 134372 Mar 27 06:32 Makefile.in
>> > > -rwxr-xr-x. 1 andor andor   6872 Mar 27 06:32 missing
>> > > -rw-rw-r--. 1 andor andor   1961 Mar 27 06:32 NOTICE.txt
>> > > -rw-rw-r--. 1 andor andor   7400 Mar 27 06:32 README
>> > > drwxr-xr-x. 3 andor andor245 Mar 27 06:32 src
>> > > drwxr-xr-x. 2 andor andor   4096 Mar 27 06:32 tests
>> > > [andor@andor-centos work]$ ls -l zookeeper-3.4.13/src/c
>> > > total 1468
>> > > -rw-r--r--. 1 andor andor  11533 Jun 22 20:03 acinclude.m4
>> > > -rw-r--r--. 1 andor andor 372149 Jun 22 20:03 aclocal.m4
>> > > -rw-r--r--. 1 andor andor   4733 Jun 22 20:03 aminclude.am
>> > > drwxr-xr-x. 2 andor andor 86 Jun 27 13:12 autom4te.cache
>> > > -rw-r--r--. 1 andor andor  50794 Jun 22 20:03 c-doc.Doxyfile
>> > > -rw-r--r--. 1 andor andor   4343 Jun 22 20:03 ChangeLog
>> > > -rw-r--r--. 1 andor andor   4763 Jun 22 20:03 cmake_config.h.in
>> > > -rw-r--r--. 1 andor andor   6456 Jun 22 20:03 CMakeLists.txt
>> > > -rw-r--r--. 1 andor andor 644086 Jun 22 20:03 configure
>> > > -rw-r--r--. 1 andor andor   4423 Jun 22 20:03 configure.ac
>> > > drwxrwxr-x. 2 andor andor 54 Jun 27 13:13 generated
>> > > drwxr-xr-x. 2 andor andor127 Jun 27 13:12 include
>> > > -rw-r--r--. 1 andor andor   9416 Jun 22 20:03 INSTALL
>> > > -rw-r--r--. 1 andor andor  11358 Jun 22 20:03 LICENSE
>> > > -rw-r--r--. 1 andor andor 324089 Jun 22 20:03 ltmain.sh
>> > > -rw-r--r--. 1 andor andor   4509 Jun 

Re: [VOTE] Apache ZooKeeper release 3.4.13 candidate 0

[Patrick Hunt]

Given this has a -1 should I hold off reviewing? Michael what are you
planning to do? Cut another RC?

Patrick

On Wed, Jun 27, 2018 at 7:17 AM Norbert Kalmar 
wrote:

> +1 (non-binding)
>
> Built from source (release-3.4.13-rc0 tag), run in standalone, cluster of
> 3, runed basic commands (create, get,set, delete etc.).
> MacOS 10.13.4
>
> Thanks,
> Norbert
>
> On Wed, Jun 27, 2018 at 3:45 PM Andor Molnar 
> wrote:
>
> > + tested with different cluster sizes: 1,3,5,7
> > + verified a few 4lw commands
> > + verified JMX interface
> >
> > Regards,
> > Andor
> >
> >
> > On Wed, Jun 27, 2018 at 2:51 PM, Andor Molnar 
> wrote:
> >
> > > Hi Michael,
> > >
> > > Thanks for putting together this new release.
> > >
> > > My vote: -1
> > >
> > > I've run the following tests so far:
> > > + signatures verified
> > > + java unit tests successful
> > > - unable to build C client / C++ unit tests, because ./configure script
> > is
> > > not executable
> > >
> > > BUILD FAILED
> > > /home/andor/work/zookeeper-3.4.13/build.xml:1511: The following error
> > > occurred while executing this line:
> > > /home/andor/work/zookeeper-3.4.13/build.xml:1470: The following error
> > > occurred while executing this line:
> > > /home/andor/work/zookeeper-3.4.13/build.xml:1461: Execute failed:
> > > java.io.IOException: Cannot run program
> > "/home/andor/work/zookeeper-3.4.13/src/c/configure"
> > > (in directory
> > "/home/andor/work/zookeeper-3.4.13/build/test/test-cppunit"):
> > > error=13, Permission denied
> > >
> > > Looking at the contents of the C client, it's slightly different from
> > what
> > > we released in 3.4.12:
> > >
> > > [andor@andor-centos work]$ ls -l zookeeper-3.4.12/src/c
> > > total 1748
> > > -rw-rw-r--. 1 andor andor  11533 Mar 27 06:32 acinclude.m4
> > > -rw-rw-r--. 1 andor andor 376234 Mar 27 06:32 aclocal.m4
> > > -rw-rw-r--. 1 andor andor   4733 Mar 27 06:32 aminclude.am
> > > drwxr-xr-x. 2 andor andor 86 Mar 27 06:32 autom4te.cache
> > > -rw-rw-r--. 1 andor andor  50794 Mar 27 06:32 c-doc.Doxyfile
> > > -rw-rw-r--. 1 andor andor   4343 Mar 27 06:32 ChangeLog
> > > -rw-rw-r--. 1 andor andor   4763 Mar 27 06:32 cmake_config.h.in
> > > -rw-rw-r--. 1 andor andor   6456 Mar 27 06:32 CMakeLists.txt
> > > -rwxr-xr-x. 1 andor andor   7333 Mar 27 06:32 compile
> > > -rwxr-xr-x. 1 andor andor  43499 Mar 27 06:32 config.guess
> > > -rw-rw-r--. 1 andor andor   3989 Mar 27 06:32 config.h.in
> > > -rwxr-xr-x. 1 andor andor  36144 Mar 27 06:32 config.sub
> > > -rwxr-xr-x. 1 andor andor 649183 Mar 27 06:32 configure
> > > -rw-rw-r--. 1 andor andor   4110 Mar 27 06:32 configure.ac
> > > -rwxr-xr-x. 1 andor andor  23566 Mar 27 06:32 depcomp
> > > drwxr-xr-x. 2 andor andor 54 Mar 27 06:32 generated
> > > drwxr-xr-x. 2 andor andor127 Mar 27 06:32 include
> > > -rw-rw-r--. 1 andor andor   9416 Mar 27 06:32 INSTALL
> > > -rwxr-xr-x. 1 andor andor  15155 Mar 27 06:32 install-sh
> > > -rw-rw-r--. 1 andor andor  11358 Mar 27 06:32 LICENSE
> > > -rwxr-xr-x. 1 andor andor 324404 Mar 27 06:32 ltmain.sh
> > > -rw-rw-r--. 1 andor andor   4367 Mar 27 06:32 Makefile.am
> > > -rw-rw-r--. 1 andor andor 134372 Mar 27 06:32 Makefile.in
> > > -rwxr-xr-x. 1 andor andor   6872 Mar 27 06:32 missing
> > > -rw-rw-r--. 1 andor andor   1961 Mar 27 06:32 NOTICE.txt
> > > -rw-rw-r--. 1 andor andor   7400 Mar 27 06:32 README
> > > drwxr-xr-x. 3 andor andor245 Mar 27 06:32 src
> > > drwxr-xr-x. 2 andor andor   4096 Mar 27 06:32 tests
> > > [andor@andor-centos work]$ ls -l zookeeper-3.4.13/src/c
> > > total 1468
> > > -rw-r--r--. 1 andor andor  11533 Jun 22 20:03 acinclude.m4
> > > -rw-r--r--. 1 andor andor 372149 Jun 22 20:03 aclocal.m4
> > > -rw-r--r--. 1 andor andor   4733 Jun 22 20:03 aminclude.am
> > > drwxr-xr-x. 2 andor andor 86 Jun 27 13:12 autom4te.cache
> > > -rw-r--r--. 1 andor andor  50794 Jun 22 20:03 c-doc.Doxyfile
> > > -rw-r--r--. 1 andor andor   4343 Jun 22 20:03 ChangeLog
> > > -rw-r--r--. 1 andor andor   4763 Jun 22 20:03 cmake_config.h.in
> > > -rw-r--r--. 1 andor andor   6456 Jun 22 20:03 CMakeLists.txt
> > > -rw-r--r--. 1 andor andor 644086 Jun 22 20:03 configure
> > > -rw-r--r--. 1 andor andor   4423 Jun 22 20:03 configure.ac
> > > drwxrwxr-x. 2 andor andor 54 Jun 27 13:13 generated
> > > drwxr-xr-x. 2 andor andor127 Jun 27 13:12 include
> > > -rw-r--r--. 1 andor andor   9416 Jun 22 20:03 INSTALL
> > > -rw-r--r--. 1 andor andor  11358 Jun 22 20:03 LICENSE
> > > -rw-r--r--. 1 andor andor 324089 Jun 22 20:03 ltmain.sh
> > > -rw-r--r--. 1 andor andor   4509 Jun 22 20:03 Makefile.am
> > > -rw-r--r--. 1 andor andor   1961 Jun 22 20:03 NOTICE.txt
> > > -rw-r--r--. 1 andor andor   7400 Jun 22 20:03 README
> > > drwxr-xr-x. 3 andor andor245 Jun 22 20:03 src
> > > drwxr-xr-x. 2 andor andor   4096 Jun 27 13:12 tests
> > >
> > > Some of the files are missing, others don't have executable bit.
> > > Do you have an idea what could go wrong?
> > >
> > > I continue testing with cluster setups.
> > >
> > > 

[GitHub] zookeeper issue #466: ZOOKEEPER-2940. Deal with maxbuffer as it relates to l...

[phunt]

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/466
  
Currently listed as having a conflict, @anmolnar can you update the patch?


---

[GitHub] zookeeper pull request #549: ZOOKEEPER-2873 abort startup on invalid ports

[enixon]

Github user enixon commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/549#discussion_r198607891
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerConfigTest.java ---
@@ -103,6 +103,23 @@ public void testCustomSSLAuth()
 }
 }
 
+/**
+ * Test case for https://issues.apache.org/jira/browse/ZOOKEEPER-2873
+ */
+@Test
+public void testSamePortConfiguredForClientAndElection() throws 
IOException, ConfigException {
+QuorumPeerConfig quorumPeerConfig = new QuorumPeerConfig();
+try {
+Properties zkProp = getDefaultZKProperties();
+zkProp.setProperty("server.1", "localhost:2888:2888");
+quorumPeerConfig.parseProperties(zkProp);
+fail("ConfigException is expected");
+} catch (ConfigException ce) {
--- End diff --

I agree that your test as written is more exact, my proposal is more about 
future proofing the test so it doesn't get hung up on the exact language of the 
exception thrown.

I will happily defer the point to someone with more ZooKeeper experience 
about which is more in the project's style.


---

[GitHub] zookeeper pull request #549: ZOOKEEPER-2873 abort startup on invalid ports

[enixon]

Github user enixon commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/549#discussion_r198607295
  
--- Diff: src/java/test/org/apache/zookeeper/test/ReconfigTest.java ---
@@ -801,10 +801,12 @@ private void testPortChangeToBlockedPort(boolean 
testLeader) throws Exception {
 
 @Test
 public void testUnspecifiedClientAddress() throws Exception {
-   int[] ports = new int[3];
-   for (int port : ports) {
-   port = PortAssignment.unique();
-   }
+   int[] ports = {
+PortAssignment.unique(),
+PortAssignment.unique(),
+PortAssignment.unique()
+   };
+
--- End diff --

agreed, good catch


---

[GitHub] zookeeper pull request #549: ZOOKEEPER-2873 abort startup on invalid ports

[enixon]

Github user enixon commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/549#discussion_r198609106
  
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 
---
@@ -259,6 +259,11 @@ public QuorumServer(long sid, String addressStr) 
throws ConfigException {
 throw new ConfigException("Address unresolved: " + 
serverParts[0] + ":" + serverParts[2]);
 }
 
+if(addr.getPort() == electionAddr.getPort()) {
+throw new ConfigException(
+"Client and election port must be different! 
Please update the configuration file on server." + sid);
+}
+
--- End diff --

Double checked and you're right, all the other constructors for this class 
are only invoked in tests. Agreed that my proposal is a "nice to have" at best.


---

Re: ZK-3034 Unable to compile C++ test files with cppunit-1.14.0

[Patrick Hunt]

On Mon, Jun 25, 2018 at 10:34 PM Michael Han  wrote:

> Since pkg-config has been available for a long time, what's the drawback in
> terms of compatibilities if we choose only support pkg-config moving
> forward?
>
>
It could break existing downstream build infra. Also the issue is not super
obvious when it does manifest - see my comments on the original PR, I ran
into this myself on existing infra where it has previously compiled just
fine (everything before this most recent OS release).

That said, if we doc and explicitly release note it it might be fine, this
is a bit of a rock/hardplace issue.

Patrick


> For cmake, if we choose only to support cmake, then that's another
> dependency users that consumes release tarball have to install on their OS
> distribution (comparing to autotools / config script approach where users
> just grab the release tarball and build)... so probably not very user
> friendly?
>
> On Mon, Jun 25, 2018 at 5:52 AM, Andor Molnar 
> wrote:
>
> > Does anybody else has strong or not that strong opinion?
> >
> > Andor
> >
> >
> >
> > On Wed, Jun 20, 2018 at 8:30 PM, Andor Molnar 
> wrote:
> >
> > > What do you think @andschwa?
> > > You did some contribution on CMake recently.
> > >
> > > Andor
> > >
> > >
> > >
> > > On Wed, Jun 20, 2018 at 8:09 PM, Patrick Hunt 
> wrote:
> > >
> > >> Hm. Not directly on point but related - should we move off auto* tools
> > at
> > >> some point and just use cmake? (which is already in the codebase) Or
> > some
> > >> other option?
> > >>
> > >> Patrick
> > >>
> > >> On Wed, Jun 20, 2018 at 11:05 AM Andor Molnar
> >  > >> >
> > >> wrote:
> > >>
> > >> > "When is pkg-config needed?"
> > >> >
> > >> > Both. You need the macro to generate ./configure and you need
> > pkg-config
> > >> > and cppunit.pc (part of cppunit package) to compile the tests.
> > >> >
> > >> > "Do we already do something special like generate the configure
> script
> > >> and
> > >> > ship that as part of the release?"
> > >> >
> > >> > That's correct. We ship the generated ./configure script and
> > >> Makefile.in in
> > >> > the release artifact.
> > >> >
> > >> > Andor
> > >> >
> > >> >
> > >> >
> > >> >
> > >> > On Wed, Jun 20, 2018 at 7:38 PM, Patrick Hunt 
> > wrote:
> > >> >
> > >> > > When is pkg-config needed? If you want to compile from source or
> if
> > >> you
> > >> > > want to compile from the release artifact? Do we already do
> > something
> > >> > > special like generate the configure script and ship that as part
> of
> > >> the
> > >> > > release?
> > >> > >
> > >> > > Patrick
> > >> > >
> > >> > > On Fri, Jun 8, 2018 at 6:44 AM Andor Molnar 
> > >> wrote:
> > >> > >
> > >> > > > This PR is also related:
> > >> > > >
> > >> > > > https://github.com/apache/zookeeper/pull/362
> > >> > > >
> > >> > > > Andor
> > >> > > >
> > >> > > >
> > >> > > >
> > >> > > > On Fri, Jun 8, 2018 at 3:18 PM, Andor Molnar <
> an...@cloudera.com>
> > >> > wrote:
> > >> > > >
> > >> > > > > Hi devs,
> > >> > > > >
> > >> > > > > I'm having problems resolving the issue mentioned in this Jira
> > and
> > >> > need
> > >> > > > > some feedback from you:
> > >> > > > >
> > >> > > > > https://issues.apache.org/jira/browse/ZOOKEEPER-3034
> > >> > > > >
> > >> > > > > In a nutshell the situation with *cppunit* is as follows:
> > >> > > > > LibreOffice team confirmed that from version *1.14.0* they
> will
> > no
> > >> > > longer
> > >> > > > > ship m4 macro definitions in cppunit releases. They encourage
> > >> > everybody
> > >> > > > to
> > >> > > > > use *pkg-config* instead in order to generate configure script
> > and
> > >> > > > > Makefile. By the way, this is not a new thing, it was
> supported
> > >> even
> > >> > > > before
> > >> > > > > 1.14.0.  So basically, they no longer support both tools, only
> > >> > > > pkg-config.
> > >> > > > >
> > >> > > > > So, in order to support building and running C++ tests on
> recent
> > >> > > > > distributions with cppunit-1.14.0 like Ubuntu 18.04, Fedora,
> > >> etc., we
> > >> > > > have
> > >> > > > > to switch to *pkg-config*.
> > >> > > > >
> > >> > > > > *Backward compatibility*
> > >> > > > > pkg-config is going to be a new dependency of the C client
> which
> > >> we
> > >> > > need
> > >> > > > > to add to the documentation near to autoconf 2.59 requirement.
> > On
> > >> the
> > >> > > > > flipside we can remove the requirement of cppunit.m4.
> > >> > > > >
> > >> > > > > Another thing we can do is to maintain two different
> > configure.ac
> > >> > > > scripts
> > >> > > > > from now on: one for cppunit.m4 and another one for pkg-config
> > >> which
> > >> > is
> > >> > > > > going to be the default. We also have to describe in the
> > >> > documentation
> > >> > > > why
> > >> > > > > we made that change and how to revert to the m4 version if
> > needed.
> > >> > > > >
> > >> > > > > The way it's currently implemented in the following pull
> request
> > >> has
> > >> > > been
> > >> > > > > tested and works on Ubuntu 14.04, 

[jira] [Commented] (ZOOKEEPER-3061) add more details to 'Unhandled scenario for peer' log.warn message

[Christine Poerschke (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525329#comment-16525329
 ] 

Christine Poerschke commented on ZOOKEEPER-3061:


Thanks [~maoling] for the question on my initial patch!
{quote}... and we can use sid to associate them ...
{quote}
Yes, once one knows that the {{"Synchronizing with Follower sid: ..."}} INFO 
logging mostly contains the meaning behind the {{"Unhandled scenario"}} WARN 
phrase then a repeat of the details is not strictly necessary.

Including the extra details in the warning is aimed at users who have not yet 
associated the two log lines, plus I'm suggesting for the warning to also log 
the {{txnLogSyncEnabled}} variable which is used in the handling logic but not 
logged by the adjacent INFO log line.

> add more details to 'Unhandled scenario for peer' log.warn message
> --
>
> Key: ZOOKEEPER-3061
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3061
> Project: ZooKeeper
>  Issue Type: Task
>Reporter: Christine Poerschke
>Priority: Minor
> Attachments: ZOOKEEPER-3061.patch
>
>
> A few lines earlier the {{LOG.info("Synchronizing with Follower sid: ...}} 
> logging already contains most relevant details but it would be convenient to 
> more directly have full details in the {{LOG.warn("Unhandled scenario for 
> peer sid: ...}} itself.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

ZooKeeper_branch34_openjdk7 - Build # 1973 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1973/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 40.77 KB...]
[junit] Running org.apache.zookeeper.test.SaslAuthDesignatedServerTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.542 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailDesignatedClientTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.097 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailNotifyTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.517 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.634 sec
[junit] Running org.apache.zookeeper.test.SaslAuthMissingClientConfigTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.515 sec
[junit] Running org.apache.zookeeper.test.SaslClientTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.091 sec
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.535 sec
[junit] Running org.apache.zookeeper.test.SessionTest
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
10.887 sec
[junit] Running org.apache.zookeeper.test.SessionTimeoutTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.744 sec
[junit] Running org.apache.zookeeper.test.StandaloneTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.876 sec
[junit] Running org.apache.zookeeper.test.StatTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.779 sec
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.821 sec
[junit] Running org.apache.zookeeper.test.SyncCallTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.657 sec
[junit] Running org.apache.zookeeper.test.TruncateTest
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
8.019 sec
[junit] Running org.apache.zookeeper.test.UpgradeTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.569 sec
[junit] Running org.apache.zookeeper.test.WatchedEventTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.098 sec
[junit] Running org.apache.zookeeper.test.WatcherFuncTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.825 sec
[junit] Running org.apache.zookeeper.test.WatcherTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
28.778 sec
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
5.52 sec
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.602 sec

fail.build.on.test.failure:

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7/build.xml:1393:
 The following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7/build.xml:1396:
 Tests failed!

Total time: 34 minutes 6 seconds
Build step 'Invoke Ant' marked build as failure
Archiving artifacts
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/
Recording test results
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  
org.apache.zookeeper.server.quorum.Zab1_0Test.testNormalFollowerRunWithDiff

Error Message:
expected:<4294967298> but was:<0>

Stack Trace:
junit.framework.AssertionFailedError: expected:<4294967298> but was:<0>
at 
org.apache.zookeeper.server.quorum.Zab1_0Test$5.converseWithFollower(Zab1_0Test.java:796)
at 
org.apache.zookeeper.server.quorum.Zab1_0Test.testFollowerConversation(Zab1_0Test.java:442)
at 
org.apache.zookeeper.server.quorum.Zab1_0Test.testNormalFollowerRunWithDiff(Zab1_0Test.java:712)

[GitHub] zookeeper pull request #549: ZOOKEEPER-2873 abort startup on invalid ports

[tamaashu]

Github user tamaashu commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/549#discussion_r198532231
  
--- Diff: src/java/test/org/apache/zookeeper/test/ReconfigTest.java ---
@@ -801,10 +801,12 @@ private void testPortChangeToBlockedPort(boolean 
testLeader) throws Exception {
 
 @Test
 public void testUnspecifiedClientAddress() throws Exception {
-   int[] ports = new int[3];
-   for (int port : ports) {
-   port = PortAssignment.unique();
-   }
+   int[] ports = {
+PortAssignment.unique(),
+PortAssignment.unique(),
+PortAssignment.unique()
+   };
+
--- End diff --

@nkalmar good catch


---

Re: [VOTE] Apache ZooKeeper release 3.4.13 candidate 0

[Norbert Kalmar]

+1 (non-binding)

Built from source (release-3.4.13-rc0 tag), run in standalone, cluster of
3, runed basic commands (create, get,set, delete etc.).
MacOS 10.13.4

Thanks,
Norbert

On Wed, Jun 27, 2018 at 3:45 PM Andor Molnar 
wrote:

> + tested with different cluster sizes: 1,3,5,7
> + verified a few 4lw commands
> + verified JMX interface
>
> Regards,
> Andor
>
>
> On Wed, Jun 27, 2018 at 2:51 PM, Andor Molnar  wrote:
>
> > Hi Michael,
> >
> > Thanks for putting together this new release.
> >
> > My vote: -1
> >
> > I've run the following tests so far:
> > + signatures verified
> > + java unit tests successful
> > - unable to build C client / C++ unit tests, because ./configure script
> is
> > not executable
> >
> > BUILD FAILED
> > /home/andor/work/zookeeper-3.4.13/build.xml:1511: The following error
> > occurred while executing this line:
> > /home/andor/work/zookeeper-3.4.13/build.xml:1470: The following error
> > occurred while executing this line:
> > /home/andor/work/zookeeper-3.4.13/build.xml:1461: Execute failed:
> > java.io.IOException: Cannot run program
> "/home/andor/work/zookeeper-3.4.13/src/c/configure"
> > (in directory
> "/home/andor/work/zookeeper-3.4.13/build/test/test-cppunit"):
> > error=13, Permission denied
> >
> > Looking at the contents of the C client, it's slightly different from
> what
> > we released in 3.4.12:
> >
> > [andor@andor-centos work]$ ls -l zookeeper-3.4.12/src/c
> > total 1748
> > -rw-rw-r--. 1 andor andor  11533 Mar 27 06:32 acinclude.m4
> > -rw-rw-r--. 1 andor andor 376234 Mar 27 06:32 aclocal.m4
> > -rw-rw-r--. 1 andor andor   4733 Mar 27 06:32 aminclude.am
> > drwxr-xr-x. 2 andor andor 86 Mar 27 06:32 autom4te.cache
> > -rw-rw-r--. 1 andor andor  50794 Mar 27 06:32 c-doc.Doxyfile
> > -rw-rw-r--. 1 andor andor   4343 Mar 27 06:32 ChangeLog
> > -rw-rw-r--. 1 andor andor   4763 Mar 27 06:32 cmake_config.h.in
> > -rw-rw-r--. 1 andor andor   6456 Mar 27 06:32 CMakeLists.txt
> > -rwxr-xr-x. 1 andor andor   7333 Mar 27 06:32 compile
> > -rwxr-xr-x. 1 andor andor  43499 Mar 27 06:32 config.guess
> > -rw-rw-r--. 1 andor andor   3989 Mar 27 06:32 config.h.in
> > -rwxr-xr-x. 1 andor andor  36144 Mar 27 06:32 config.sub
> > -rwxr-xr-x. 1 andor andor 649183 Mar 27 06:32 configure
> > -rw-rw-r--. 1 andor andor   4110 Mar 27 06:32 configure.ac
> > -rwxr-xr-x. 1 andor andor  23566 Mar 27 06:32 depcomp
> > drwxr-xr-x. 2 andor andor 54 Mar 27 06:32 generated
> > drwxr-xr-x. 2 andor andor127 Mar 27 06:32 include
> > -rw-rw-r--. 1 andor andor   9416 Mar 27 06:32 INSTALL
> > -rwxr-xr-x. 1 andor andor  15155 Mar 27 06:32 install-sh
> > -rw-rw-r--. 1 andor andor  11358 Mar 27 06:32 LICENSE
> > -rwxr-xr-x. 1 andor andor 324404 Mar 27 06:32 ltmain.sh
> > -rw-rw-r--. 1 andor andor   4367 Mar 27 06:32 Makefile.am
> > -rw-rw-r--. 1 andor andor 134372 Mar 27 06:32 Makefile.in
> > -rwxr-xr-x. 1 andor andor   6872 Mar 27 06:32 missing
> > -rw-rw-r--. 1 andor andor   1961 Mar 27 06:32 NOTICE.txt
> > -rw-rw-r--. 1 andor andor   7400 Mar 27 06:32 README
> > drwxr-xr-x. 3 andor andor245 Mar 27 06:32 src
> > drwxr-xr-x. 2 andor andor   4096 Mar 27 06:32 tests
> > [andor@andor-centos work]$ ls -l zookeeper-3.4.13/src/c
> > total 1468
> > -rw-r--r--. 1 andor andor  11533 Jun 22 20:03 acinclude.m4
> > -rw-r--r--. 1 andor andor 372149 Jun 22 20:03 aclocal.m4
> > -rw-r--r--. 1 andor andor   4733 Jun 22 20:03 aminclude.am
> > drwxr-xr-x. 2 andor andor 86 Jun 27 13:12 autom4te.cache
> > -rw-r--r--. 1 andor andor  50794 Jun 22 20:03 c-doc.Doxyfile
> > -rw-r--r--. 1 andor andor   4343 Jun 22 20:03 ChangeLog
> > -rw-r--r--. 1 andor andor   4763 Jun 22 20:03 cmake_config.h.in
> > -rw-r--r--. 1 andor andor   6456 Jun 22 20:03 CMakeLists.txt
> > -rw-r--r--. 1 andor andor 644086 Jun 22 20:03 configure
> > -rw-r--r--. 1 andor andor   4423 Jun 22 20:03 configure.ac
> > drwxrwxr-x. 2 andor andor 54 Jun 27 13:13 generated
> > drwxr-xr-x. 2 andor andor127 Jun 27 13:12 include
> > -rw-r--r--. 1 andor andor   9416 Jun 22 20:03 INSTALL
> > -rw-r--r--. 1 andor andor  11358 Jun 22 20:03 LICENSE
> > -rw-r--r--. 1 andor andor 324089 Jun 22 20:03 ltmain.sh
> > -rw-r--r--. 1 andor andor   4509 Jun 22 20:03 Makefile.am
> > -rw-r--r--. 1 andor andor   1961 Jun 22 20:03 NOTICE.txt
> > -rw-r--r--. 1 andor andor   7400 Jun 22 20:03 README
> > drwxr-xr-x. 3 andor andor245 Jun 22 20:03 src
> > drwxr-xr-x. 2 andor andor   4096 Jun 27 13:12 tests
> >
> > Some of the files are missing, others don't have executable bit.
> > Do you have an idea what could go wrong?
> >
> > I continue testing with cluster setups.
> >
> > Regards,
> > Andor
> >
> >
> >
> >
> >
> >
> > On Sat, Jun 23, 2018 at 12:31 AM, Michael Han  wrote:
> >
> >> This is a bugfix release candidate for 3.4.13. It fixes 17 issues,
> >> including issues such as ZOOKEEPER-2959
> >>  that could cause
> >> data loss when observer is used, and ZOOKEEPER-2184
> >> 

Re: [VOTE] Apache ZooKeeper release 3.4.13 candidate 0

[Andor Molnar]

+ tested with different cluster sizes: 1,3,5,7
+ verified a few 4lw commands
+ verified JMX interface

Regards,
Andor


On Wed, Jun 27, 2018 at 2:51 PM, Andor Molnar  wrote:

> Hi Michael,
>
> Thanks for putting together this new release.
>
> My vote: -1
>
> I've run the following tests so far:
> + signatures verified
> + java unit tests successful
> - unable to build C client / C++ unit tests, because ./configure script is
> not executable
>
> BUILD FAILED
> /home/andor/work/zookeeper-3.4.13/build.xml:1511: The following error
> occurred while executing this line:
> /home/andor/work/zookeeper-3.4.13/build.xml:1470: The following error
> occurred while executing this line:
> /home/andor/work/zookeeper-3.4.13/build.xml:1461: Execute failed:
> java.io.IOException: Cannot run program 
> "/home/andor/work/zookeeper-3.4.13/src/c/configure"
> (in directory "/home/andor/work/zookeeper-3.4.13/build/test/test-cppunit"):
> error=13, Permission denied
>
> Looking at the contents of the C client, it's slightly different from what
> we released in 3.4.12:
>
> [andor@andor-centos work]$ ls -l zookeeper-3.4.12/src/c
> total 1748
> -rw-rw-r--. 1 andor andor  11533 Mar 27 06:32 acinclude.m4
> -rw-rw-r--. 1 andor andor 376234 Mar 27 06:32 aclocal.m4
> -rw-rw-r--. 1 andor andor   4733 Mar 27 06:32 aminclude.am
> drwxr-xr-x. 2 andor andor 86 Mar 27 06:32 autom4te.cache
> -rw-rw-r--. 1 andor andor  50794 Mar 27 06:32 c-doc.Doxyfile
> -rw-rw-r--. 1 andor andor   4343 Mar 27 06:32 ChangeLog
> -rw-rw-r--. 1 andor andor   4763 Mar 27 06:32 cmake_config.h.in
> -rw-rw-r--. 1 andor andor   6456 Mar 27 06:32 CMakeLists.txt
> -rwxr-xr-x. 1 andor andor   7333 Mar 27 06:32 compile
> -rwxr-xr-x. 1 andor andor  43499 Mar 27 06:32 config.guess
> -rw-rw-r--. 1 andor andor   3989 Mar 27 06:32 config.h.in
> -rwxr-xr-x. 1 andor andor  36144 Mar 27 06:32 config.sub
> -rwxr-xr-x. 1 andor andor 649183 Mar 27 06:32 configure
> -rw-rw-r--. 1 andor andor   4110 Mar 27 06:32 configure.ac
> -rwxr-xr-x. 1 andor andor  23566 Mar 27 06:32 depcomp
> drwxr-xr-x. 2 andor andor 54 Mar 27 06:32 generated
> drwxr-xr-x. 2 andor andor127 Mar 27 06:32 include
> -rw-rw-r--. 1 andor andor   9416 Mar 27 06:32 INSTALL
> -rwxr-xr-x. 1 andor andor  15155 Mar 27 06:32 install-sh
> -rw-rw-r--. 1 andor andor  11358 Mar 27 06:32 LICENSE
> -rwxr-xr-x. 1 andor andor 324404 Mar 27 06:32 ltmain.sh
> -rw-rw-r--. 1 andor andor   4367 Mar 27 06:32 Makefile.am
> -rw-rw-r--. 1 andor andor 134372 Mar 27 06:32 Makefile.in
> -rwxr-xr-x. 1 andor andor   6872 Mar 27 06:32 missing
> -rw-rw-r--. 1 andor andor   1961 Mar 27 06:32 NOTICE.txt
> -rw-rw-r--. 1 andor andor   7400 Mar 27 06:32 README
> drwxr-xr-x. 3 andor andor245 Mar 27 06:32 src
> drwxr-xr-x. 2 andor andor   4096 Mar 27 06:32 tests
> [andor@andor-centos work]$ ls -l zookeeper-3.4.13/src/c
> total 1468
> -rw-r--r--. 1 andor andor  11533 Jun 22 20:03 acinclude.m4
> -rw-r--r--. 1 andor andor 372149 Jun 22 20:03 aclocal.m4
> -rw-r--r--. 1 andor andor   4733 Jun 22 20:03 aminclude.am
> drwxr-xr-x. 2 andor andor 86 Jun 27 13:12 autom4te.cache
> -rw-r--r--. 1 andor andor  50794 Jun 22 20:03 c-doc.Doxyfile
> -rw-r--r--. 1 andor andor   4343 Jun 22 20:03 ChangeLog
> -rw-r--r--. 1 andor andor   4763 Jun 22 20:03 cmake_config.h.in
> -rw-r--r--. 1 andor andor   6456 Jun 22 20:03 CMakeLists.txt
> -rw-r--r--. 1 andor andor 644086 Jun 22 20:03 configure
> -rw-r--r--. 1 andor andor   4423 Jun 22 20:03 configure.ac
> drwxrwxr-x. 2 andor andor 54 Jun 27 13:13 generated
> drwxr-xr-x. 2 andor andor127 Jun 27 13:12 include
> -rw-r--r--. 1 andor andor   9416 Jun 22 20:03 INSTALL
> -rw-r--r--. 1 andor andor  11358 Jun 22 20:03 LICENSE
> -rw-r--r--. 1 andor andor 324089 Jun 22 20:03 ltmain.sh
> -rw-r--r--. 1 andor andor   4509 Jun 22 20:03 Makefile.am
> -rw-r--r--. 1 andor andor   1961 Jun 22 20:03 NOTICE.txt
> -rw-r--r--. 1 andor andor   7400 Jun 22 20:03 README
> drwxr-xr-x. 3 andor andor245 Jun 22 20:03 src
> drwxr-xr-x. 2 andor andor   4096 Jun 27 13:12 tests
>
> Some of the files are missing, others don't have executable bit.
> Do you have an idea what could go wrong?
>
> I continue testing with cluster setups.
>
> Regards,
> Andor
>
>
>
>
>
>
> On Sat, Jun 23, 2018 at 12:31 AM, Michael Han  wrote:
>
>> This is a bugfix release candidate for 3.4.13. It fixes 17 issues,
>> including issues such as ZOOKEEPER-2959
>>  that could cause
>> data loss when observer is used, and ZOOKEEPER-2184
>>  that prevents
>> ZooKeeper Java clients working in dynamic IP (container / cloud)
>> environment.
>>
>> The full release notes is available at:
>>
>> *https://issues.apache.org/jira/secure/ReleaseNote.jspa?proj
>> ectId=12310801=12342973
>> > ectId=12310801=12342973>*
>>
>> *** Please download, test and vote by June 27th 2018, 23:59 UTC+0. ***
>>
>> Source 

[GitHub] zookeeper issue #553: continue can be replaced with break

[nkalmar]

Github user nkalmar commented on the issue:

https://github.com/apache/zookeeper/pull/553
  
Thanks @a470577391 , possibly OK, but please create a jira for this PR on 
https://issues.apache.org/jira/projects/ZOOKEEPER/
And make sure the jira number is in the commit message.



---

[GitHub] zookeeper issue #353: [ZOOKEEPER-2886] Permanent session moved error in mult...

[anmolnar]

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/353
  
@phunt Would you like to take a quick look?
You worked on the patch for ZOOKEEPER-710.


---

Re: [VOTE] Apache ZooKeeper release 3.4.13 candidate 0

[Andor Molnar]

Hi Michael,

Thanks for putting together this new release.

My vote: -1

I've run the following tests so far:
+ signatures verified
+ java unit tests successful
- unable to build C client / C++ unit tests, because ./configure script is
not executable

BUILD FAILED
/home/andor/work/zookeeper-3.4.13/build.xml:1511: The following error
occurred while executing this line:
/home/andor/work/zookeeper-3.4.13/build.xml:1470: The following error
occurred while executing this line:
/home/andor/work/zookeeper-3.4.13/build.xml:1461: Execute failed:
java.io.IOException: Cannot run program
"/home/andor/work/zookeeper-3.4.13/src/c/configure" (in directory
"/home/andor/work/zookeeper-3.4.13/build/test/test-cppunit"): error=13,
Permission denied

Looking at the contents of the C client, it's slightly different from what
we released in 3.4.12:

[andor@andor-centos work]$ ls -l zookeeper-3.4.12/src/c
total 1748
-rw-rw-r--. 1 andor andor  11533 Mar 27 06:32 acinclude.m4
-rw-rw-r--. 1 andor andor 376234 Mar 27 06:32 aclocal.m4
-rw-rw-r--. 1 andor andor   4733 Mar 27 06:32 aminclude.am
drwxr-xr-x. 2 andor andor 86 Mar 27 06:32 autom4te.cache
-rw-rw-r--. 1 andor andor  50794 Mar 27 06:32 c-doc.Doxyfile
-rw-rw-r--. 1 andor andor   4343 Mar 27 06:32 ChangeLog
-rw-rw-r--. 1 andor andor   4763 Mar 27 06:32 cmake_config.h.in
-rw-rw-r--. 1 andor andor   6456 Mar 27 06:32 CMakeLists.txt
-rwxr-xr-x. 1 andor andor   7333 Mar 27 06:32 compile
-rwxr-xr-x. 1 andor andor  43499 Mar 27 06:32 config.guess
-rw-rw-r--. 1 andor andor   3989 Mar 27 06:32 config.h.in
-rwxr-xr-x. 1 andor andor  36144 Mar 27 06:32 config.sub
-rwxr-xr-x. 1 andor andor 649183 Mar 27 06:32 configure
-rw-rw-r--. 1 andor andor   4110 Mar 27 06:32 configure.ac
-rwxr-xr-x. 1 andor andor  23566 Mar 27 06:32 depcomp
drwxr-xr-x. 2 andor andor 54 Mar 27 06:32 generated
drwxr-xr-x. 2 andor andor127 Mar 27 06:32 include
-rw-rw-r--. 1 andor andor   9416 Mar 27 06:32 INSTALL
-rwxr-xr-x. 1 andor andor  15155 Mar 27 06:32 install-sh
-rw-rw-r--. 1 andor andor  11358 Mar 27 06:32 LICENSE
-rwxr-xr-x. 1 andor andor 324404 Mar 27 06:32 ltmain.sh
-rw-rw-r--. 1 andor andor   4367 Mar 27 06:32 Makefile.am
-rw-rw-r--. 1 andor andor 134372 Mar 27 06:32 Makefile.in
-rwxr-xr-x. 1 andor andor   6872 Mar 27 06:32 missing
-rw-rw-r--. 1 andor andor   1961 Mar 27 06:32 NOTICE.txt
-rw-rw-r--. 1 andor andor   7400 Mar 27 06:32 README
drwxr-xr-x. 3 andor andor245 Mar 27 06:32 src
drwxr-xr-x. 2 andor andor   4096 Mar 27 06:32 tests
[andor@andor-centos work]$ ls -l zookeeper-3.4.13/src/c
total 1468
-rw-r--r--. 1 andor andor  11533 Jun 22 20:03 acinclude.m4
-rw-r--r--. 1 andor andor 372149 Jun 22 20:03 aclocal.m4
-rw-r--r--. 1 andor andor   4733 Jun 22 20:03 aminclude.am
drwxr-xr-x. 2 andor andor 86 Jun 27 13:12 autom4te.cache
-rw-r--r--. 1 andor andor  50794 Jun 22 20:03 c-doc.Doxyfile
-rw-r--r--. 1 andor andor   4343 Jun 22 20:03 ChangeLog
-rw-r--r--. 1 andor andor   4763 Jun 22 20:03 cmake_config.h.in
-rw-r--r--. 1 andor andor   6456 Jun 22 20:03 CMakeLists.txt
-rw-r--r--. 1 andor andor 644086 Jun 22 20:03 configure
-rw-r--r--. 1 andor andor   4423 Jun 22 20:03 configure.ac
drwxrwxr-x. 2 andor andor 54 Jun 27 13:13 generated
drwxr-xr-x. 2 andor andor127 Jun 27 13:12 include
-rw-r--r--. 1 andor andor   9416 Jun 22 20:03 INSTALL
-rw-r--r--. 1 andor andor  11358 Jun 22 20:03 LICENSE
-rw-r--r--. 1 andor andor 324089 Jun 22 20:03 ltmain.sh
-rw-r--r--. 1 andor andor   4509 Jun 22 20:03 Makefile.am
-rw-r--r--. 1 andor andor   1961 Jun 22 20:03 NOTICE.txt
-rw-r--r--. 1 andor andor   7400 Jun 22 20:03 README
drwxr-xr-x. 3 andor andor245 Jun 22 20:03 src
drwxr-xr-x. 2 andor andor   4096 Jun 27 13:12 tests

Some of the files are missing, others don't have executable bit.
Do you have an idea what could go wrong?

I continue testing with cluster setups.

Regards,
Andor






On Sat, Jun 23, 2018 at 12:31 AM, Michael Han  wrote:

> This is a bugfix release candidate for 3.4.13. It fixes 17 issues,
> including issues such as ZOOKEEPER-2959
>  that could cause
> data loss when observer is used, and ZOOKEEPER-2184
>  that prevents
> ZooKeeper Java clients working in dynamic IP (container / cloud)
> environment.
>
> The full release notes is available at:
>
> *https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12310801=12342973
>  projectId=12310801=12342973>*
>
> *** Please download, test and vote by June 27th 2018, 23:59 UTC+0. ***
>
> Source files:
> http://people.apache.org/~hanm/zookeeper/zookeeper-3.4.13-rc0/
>
> Maven staging repo:
> https://repository.apache.org/content/groups/staging/org/
> apache/zookeeper/zookeeper/3.4.13/
>
> The release candidate tag in git to be voted upon: release-3.4.13-rc0
>
> ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> 

Success: ZOOKEEPER- PreCommit Build #1883

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1883/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 86.33 MB...]
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +0 tests included.  The patch appears to be a documentation 
patch that doesn't require tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1883//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1883//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1883//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] Session logged out. Session was 
JSESSIONID=9AE75578706780CEC46125C9BEB43EF4.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD SUCCESSFUL
Total time: 23 minutes 4 seconds
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Could not determine description.
Putting comment on the pull request
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
All tests passed

[GitHub] zookeeper pull request #553: continue can be replaced with break

[a470577391]

GitHub user a470577391 opened a pull request:

https://github.com/apache/zookeeper/pull/553

continue can be replaced with break

FileTxnLog.getLogFiles()
continue can be replaced with break

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/a470577391/zookeeper master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/553.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #553


commit ba91c4d13a6b2b908c1ab854839877d370c15bfc
Author: zhangbo 
Date:   2018-06-27T12:11:35Z

continue can be replaced with break




---

ZooKeeper_branch35_jdk8 - Build # 1020 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1020/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 61.96 KB...]
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.075 sec, Thread: 6, Class: org.apache.zookeeper.test.SaslClientTest
[junit] Running org.apache.zookeeper.test.SaslSuperUserTest in thread 3
[junit] Running org.apache.zookeeper.test.ServerCnxnTest in thread 6
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest in thread 
7
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.822 sec, Thread: 3, Class: org.apache.zookeeper.test.SaslSuperUserTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.889 sec, Thread: 7, Class: org.apache.zookeeper.test.SessionInvalidationTest
[junit] Running org.apache.zookeeper.test.SessionTest in thread 3
[junit] Running org.apache.zookeeper.test.SessionTimeoutTest in thread 7
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.436 sec, Thread: 6, Class: org.apache.zookeeper.test.ServerCnxnTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.833 sec, Thread: 7, Class: org.apache.zookeeper.test.SessionTimeoutTest
[junit] Running org.apache.zookeeper.test.SessionTrackerCheckTest in thread 
6
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.109 sec, Thread: 6, Class: org.apache.zookeeper.test.SessionTrackerCheckTest
[junit] Running org.apache.zookeeper.test.SessionUpgradeTest in thread 7
[junit] Running org.apache.zookeeper.test.StandaloneTest in thread 6
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.936 sec, Thread: 6, Class: org.apache.zookeeper.test.StandaloneTest
[junit] Running org.apache.zookeeper.test.StatTest in thread 6
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.788 sec, Thread: 6, Class: org.apache.zookeeper.test.StatTest
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 6
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
68.477 sec, Thread: 1, Class: org.apache.zookeeper.test.QuorumZxidSyncTest
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
13.493 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionTest
[junit] Running org.apache.zookeeper.test.StringUtilTest in thread 3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.066 sec, Thread: 3, Class: org.apache.zookeeper.test.StringUtilTest
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.918 sec, Thread: 6, Class: org.apache.zookeeper.test.StaticHostProviderTest
[junit] Running org.apache.zookeeper.test.SyncCallTest in thread 3
[junit] Running org.apache.zookeeper.test.TruncateTest in thread 6
[junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in 
thread 1
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.067 sec, Thread: 3, Class: org.apache.zookeeper.test.SyncCallTest
[junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 3
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.082 sec, Thread: 3, Class: org.apache.zookeeper.test.WatchedEventTest
[junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 3
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.093 sec, Thread: 3, Class: org.apache.zookeeper.test.WatcherFuncTest
[junit] Running org.apache.zookeeper.test.WatcherTest in thread 3
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
7.706 sec, Thread: 6, Class: org.apache.zookeeper.test.TruncateTest
[junit] Running org.apache.zookeeper.test.X509AuthTest in thread 6
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.097 sec, Thread: 6, Class: org.apache.zookeeper.test.X509AuthTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
20.134 sec, Thread: 7, Class: org.apache.zookeeper.test.SessionUpgradeTest
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in 
thread 6
[junit] Tests run: 14, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 
85.048 sec, Thread: 4, Class: org.apache.zookeeper.test.QuorumTest
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 7
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.913 sec, Thread: 7, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
7.844 sec, Thread: 6, Class: org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
21.935 sec, 

Success: ZOOKEEPER- PreCommit Build #1882

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1882/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 39.69 MB...]
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +0 tests included.  The patch appears to be a documentation 
patch that doesn't require tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1882//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1882//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1882//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16524919 added to ZOOKEEPER-3022.
 [exec] Session logged out. Session was 
JSESSIONID=D09ED18FA273A4E49D8DF2E07E716AED.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD SUCCESSFUL
Total time: 35 minutes 6 seconds
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3022
Putting comment on the pull request
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-3022) Step 1 - Separate project structure

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524919#comment-16524919
 ] 

Hadoop QA commented on ZOOKEEPER-3022:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1882//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1882//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1882//console

This message is automatically generated.

> Step 1 - Separate project structure
> ---
>
> Key: ZOOKEEPER-3022
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3022
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: build, scripts
>Affects Versions: 3.6.0
>Reporter: Norbert Kalmar
>Assignee: Norbert Kalmar
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Create a project structure that separates the different parts of ZooKeeper 
> into a more meaningful packages for the future maven build.
> This should be done in iterations to limit the impact.
> * First iteration - safe changes including moving src/docs to zk-docs, 
> creating zk-it empty directory. Build and conf directory remains unchanged. 
> These changes also have minimum impact on PR’s.
> * Second iteration - move src/recipes to zk-recipes.
> * Third iteration - move src/contrib to zk-contrib.
> * Fourth iteration - move src/c to zk-client (java will be moved in Phase 2)
> * Fifth iteration - move src/java/main to zk-server, which will be further 
> separated in Step 2.
> {noformat}
> zookeeper
> | -bin
> | -conf
> | -zookeeper-client
> || -zookeeper-client-c
> | -zookeeper-contrib
> || -zookeeper-contrib-fatjar
> || -zookeeper-contrib-huebrowser
> || -zookeeper-contrib-loggraph
> || -zookeeper-contrib-monitoring
> || -zookeeper-contrib-rest
> || -zookeeper-contrib-zkfuse
> || -zookeeper-contrib-zkperl
> || -zookeeper-contrib-zkpython
> || -zookeeper-contrib-zktreeutil
> |\ -zookeeper-contrib-zooinspector
> | -zookeeper-docs
> | -zookeeper-it (integration tests)
> | -zookeeper-server
> | -zookeeper-recipes
> || -zookeeper-recipes-election
> || -zookeeper-recipes-lock
> \\ -zookeeper-recipes-queue
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Success: ZOOKEEPER- PreCommit Build #1881

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1881/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 39.86 MB...]
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +0 tests included.  The patch appears to be a documentation 
patch that doesn't require tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1881//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1881//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1881//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16524882 added to ZOOKEEPER-3022.
 [exec] Session logged out. Session was 
JSESSIONID=361773A343ED39683AFB3AA266B933F2.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD SUCCESSFUL
Total time: 46 minutes 29 seconds
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3022
Putting comment on the pull request
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-3022) Step 1 - Separate project structure

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524882#comment-16524882
 ] 

Hadoop QA commented on ZOOKEEPER-3022:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1881//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1881//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1881//console

This message is automatically generated.

> Step 1 - Separate project structure
> ---
>
> Key: ZOOKEEPER-3022
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3022
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: build, scripts
>Affects Versions: 3.6.0
>Reporter: Norbert Kalmar
>Assignee: Norbert Kalmar
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Create a project structure that separates the different parts of ZooKeeper 
> into a more meaningful packages for the future maven build.
> This should be done in iterations to limit the impact.
> * First iteration - safe changes including moving src/docs to zk-docs, 
> creating zk-it empty directory. Build and conf directory remains unchanged. 
> These changes also have minimum impact on PR’s.
> * Second iteration - move src/recipes to zk-recipes.
> * Third iteration - move src/contrib to zk-contrib.
> * Fourth iteration - move src/c to zk-client (java will be moved in Phase 2)
> * Fifth iteration - move src/java/main to zk-server, which will be further 
> separated in Step 2.
> {noformat}
> zookeeper
> | -bin
> | -conf
> | -zookeeper-client
> || -zookeeper-client-c
> | -zookeeper-contrib
> || -zookeeper-contrib-fatjar
> || -zookeeper-contrib-huebrowser
> || -zookeeper-contrib-loggraph
> || -zookeeper-contrib-monitoring
> || -zookeeper-contrib-rest
> || -zookeeper-contrib-zkfuse
> || -zookeeper-contrib-zkperl
> || -zookeeper-contrib-zkpython
> || -zookeeper-contrib-zktreeutil
> |\ -zookeeper-contrib-zooinspector
> | -zookeeper-docs
> | -zookeeper-it (integration tests)
> | -zookeeper-server
> | -zookeeper-recipes
> || -zookeeper-recipes-election
> || -zookeeper-recipes-lock
> \\ -zookeeper-recipes-queue
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper pull request #552: ZOOKEEPER-3022 MAVEN MIGRATION 3.4 - Iteration ...

[nkalmar]

GitHub user nkalmar opened a pull request:

https://github.com/apache/zookeeper/pull/552

ZOOKEEPER-3022 MAVEN MIGRATION 3.4 - Iteration 1 - docs, it

Maven migration - first iteration (zookeeper-docs and zookeeper-it), branch 
3.4

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nkalmar/zookeeper ZOOKEEPER-3022-1_b3.4

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/552.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #552


commit d2acad4256d9fff0345dc97861a0235c1831ab87
Author: Norbert Kalmar 
Date:   2018-06-27T10:30:38Z

ZOOKEEPER-3022 MAVEN MIGRATION 3.4 - Iteration 1 - docs, it




---

[GitHub] zookeeper pull request #551: ZOOKEEPER-3022 MAVEN MIGRATION 3.4 - Iteration ...

[nkalmar]

Github user nkalmar closed the pull request at:

https://github.com/apache/zookeeper/pull/551


---

[GitHub] zookeeper pull request #551: ZOOKEEPER-3022 MAVEN MIGRATION 3.4 - Iteration ...

[nkalmar]

GitHub user nkalmar opened a pull request:

https://github.com/apache/zookeeper/pull/551

ZOOKEEPER-3022 MAVEN MIGRATION 3.4 - Iteration 1 - docs, it

This is the backport to 3.4 on the maven migration, first iteration 
(zookeeper-docs and zookeeper-it folder for future sub-modules)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nkalmar/zookeeper ZOOKEEPER-3022-1_3.4

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/551.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #551


commit 336a83b04cb47d2361d58b1b3c7b2e33fa72f3a1
Author: Norbert Kalmar 
Date:   2018-04-30T08:15:30Z

ZOOKEEPER-3019 add metric for slow fsyncs count

commit deb254397b07af828fd57e21e3a738f1ac52ec60
Author: Norbert Kalmar 
Date:   2018-05-11T08:38:25Z

Merge branch 'branch-3.4' of github.com:apache/zookeeper into branch-3.4

commit 63d3cb9c79ae443237c88f448ea2c505e21e01bf
Author: Norbert Kalmar 
Date:   2018-05-28T13:24:32Z

Merge branch 'branch-3.4' of github.com:apache/zookeeper into branch-3.4

commit 0ec9213a4e7ebbce3c98aebad4fd754650a2711a
Author: Norbert Kalmar 
Date:   2018-06-04T09:16:51Z

ZOOKEEPER-3019 remove redundant log

commit a4078e60c953f619e97f3584bccdcbce95a5e3d6
Author: Norbert Kalmar 
Date:   2018-06-27T09:30:30Z

Merge branch 'branch-3.4' of github.com:apache/zookeeper into branch-3.4

commit cc0f2284ff8a004bfcb1b3fc5851a75c9ca0060f
Author: Norbert Kalmar 
Date:   2018-06-27T09:38:37Z

ZOOKEEPER-3022 MAVEN MIGRATION 3.4 - Iteration 1 - docs, it




---

Success: ZOOKEEPER- PreCommit Build #1880

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1880/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 86.05 MB...]
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 6 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1880//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1880//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1880//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16524808 added to ZOOKEEPER-2873.
 [exec] Session logged out. Session was 
JSESSIONID=7F84306D29A603F72E10AD26BDDF082E.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD SUCCESSFUL
Total time: 23 minutes 15 seconds
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-2873
Putting comment on the pull request
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-2873) print error and/or abort on invalid server definition

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524808#comment-16524808
 ] 

Hadoop QA commented on ZOOKEEPER-2873:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 6 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1880//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1880//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1880//console

This message is automatically generated.

> print error and/or abort on invalid server definition
> -
>
> Key: ZOOKEEPER-2873
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2873
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.4.10
>Reporter: Christopher Smith
>Assignee: Norbert Kalmar
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> While bringing up a new cluster, I managed to fat-finger a sed script and put 
> some lines like this into my config file:
> {code}
> server.1=zookeeper1:2888:2888
> {code}
> This led to a predictable spew of error messages when the client and election 
> components fought over the single port. Since a configuration of this case is 
> *always* an error, I suggest that it would be sensible to abort the server 
> startup if an entry is found with the same port for both client and election. 
> (Logging the error explicitly without shutting down is less helpful because 
> of how fast the logs pile up.)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #550: ZOOKEEPER-3022 - Iteration 1 - docs, it

[nkalmar]

Github user nkalmar commented on the issue:

https://github.com/apache/zookeeper/pull/550
  
You're right @anmolnar , I also realised after seeing the PR that I should 
have added some text indicating this is part of the migration. I will add it in 
the future, thanks.


---

[GitHub] zookeeper issue #549: ZOOKEEPER-2873 abort startup on invalid ports

[eolivelli]

Github user eolivelli commented on the issue:

https://github.com/apache/zookeeper/pull/549
  
Doesn't the merge script do a squash?


---

[GitHub] zookeeper pull request #549: ZOOKEEPER-2873 abort startup on invalid ports

[nkalmar]

Github user nkalmar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/549#discussion_r198408262
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerConfigTest.java ---
@@ -103,6 +103,23 @@ public void testCustomSSLAuth()
 }
 }
 
+/**
+ * Test case for https://issues.apache.org/jira/browse/ZOOKEEPER-2873
+ */
+@Test
+public void testSamePortConfiguredForClientAndElection() throws 
IOException, ConfigException {
--- End diff --

Thanks, I will fix this with an amend commit (I don't want a whole commit 
in history just for this change)


---

[GitHub] zookeeper pull request #549: ZOOKEEPER-2873 abort startup on invalid ports

[nkalmar]

Github user nkalmar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/549#discussion_r198407883
  
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 
---
@@ -259,6 +259,11 @@ public QuorumServer(long sid, String addressStr) 
throws ConfigException {
 throw new ConfigException("Address unresolved: " + 
serverParts[0] + ":" + serverParts[2]);
 }
 
+if(addr.getPort() == electionAddr.getPort()) {
+throw new ConfigException(
+"Client and election port must be different! 
Please update the configuration file on server." + sid);
+}
+
--- End diff --

Good question. Well, as what I can see it is only used for test, and it is 
called programmatically, so not from reading a config. The intention here was 
to make sure that ZK is not misconfigured. 

So I'm open to adding it there also, just my initial thinking was it is not 
necessary. 


---

[GitHub] zookeeper pull request #549: ZOOKEEPER-2873 abort startup on invalid ports

[nkalmar]

Github user nkalmar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/549#discussion_r198405834
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerConfigTest.java ---
@@ -103,6 +103,23 @@ public void testCustomSSLAuth()
 }
 }
 
+/**
+ * Test case for https://issues.apache.org/jira/browse/ZOOKEEPER-2873
+ */
+@Test
+public void testSamePortConfiguredForClientAndElection() throws 
IOException, ConfigException {
+QuorumPeerConfig quorumPeerConfig = new QuorumPeerConfig();
+try {
+Properties zkProp = getDefaultZKProperties();
+zkProp.setProperty("server.1", "localhost:2888:2888");
+quorumPeerConfig.parseProperties(zkProp);
+fail("ConfigException is expected");
+} catch (ConfigException ce) {
--- End diff --

That will only verify the exception was thrown. I am also checking what is 
the error message. We can use expected, but I think this is more "To the point"


---

[GitHub] zookeeper pull request #549: ZOOKEEPER-2873 abort startup on invalid ports

[nkalmar]

Github user nkalmar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/549#discussion_r198404697
  
--- Diff: src/java/test/org/apache/zookeeper/test/ReconfigTest.java ---
@@ -801,10 +801,12 @@ private void testPortChangeToBlockedPort(boolean 
testLeader) throws Exception {
 
 @Test
 public void testUnspecifiedClientAddress() throws Exception {
-   int[] ports = new int[3];
-   for (int port : ports) {
-   port = PortAssignment.unique();
-   }
+   int[] ports = {
+PortAssignment.unique(),
+PortAssignment.unique(),
+PortAssignment.unique()
+   };
+
--- End diff --

Yes, they will fail otherwise with the introduced changes - all the ports 
were null. Also, this is just bad java code, the for does nothing, while the 
intention was clearly to set the ports for a unique number.


---

Re: Maven migration doc - thoughts and suggestions

[Andor Molnar]

Hi,

Heads-up for everybody:

The migration project has been started with the first PR according to the
design docs.
Please try to make some effort taking a quick look and give feedback.

Thanks,
Andor


On Thu, Jun 14, 2018 at 2:17 PM, Norbert Kalmar <
nkal...@cloudera.com.invalid> wrote:

> Thanks Brian, your input is much appreciated!
>
> I will finalize the document soon, there are still some ToDo's on the list
> which I will investigate first.
>
> Regards,
> Norbert
>
> On Thu, Jun 14, 2018 at 2:26 AM Brian Nixon 
> wrote:
>
> > Andor hit the points that I was going to highlight. Norbert, nice work
> > pulling this together.
> >
> > No major red flags for me. +1
> >
> > On Mon, Jun 11, 2018 at 3:29 AM, Andor Molnar 
> wrote:
> >
> > > ​Hi team,
> > >
> > > Just a quick heads-up that we need your feedback in this doc even if
> it's
> > > only +1 would be appreciated.
> > > Please share your thoughts.
> > >
> > > Thanks,
> > > Andor
> > >
> > > ​
> > >
> > > On Tue, May 29, 2018 at 4:16 PM, Norbert Kalmar 
> > > wrote:
> > >
> > > > Sorry, one important clarification: These are not decided yet, in the
> > > > contrary, the main goal would be to have a discussion about these
> (and
> > > > more) points and arrive to a mutual agreement on how we should do the
> > > > migration, and to make sure this will not die and forgotten in a pull
> > > > request somewhere.
> > > >
> > > > Norbert
> > > >
> > > > On Tue, May 29, 2018 at 4:12 PM Norbert Kalmar  >
> > > > wrote:
> > > >
> > > > > Thanks Andor!
> > > > >
> > > > > A quick update on where were at with the maven migration plan:
> > > > > - All 3 active branches will get the full maven build.
> > > > > - End artifacts will change, 3 separate jar for server, client and
> > > > common,
> > > > > possible package change as well (backward compatibility will break)
> > > > > - The changes will be committed to master / 3.5 / 3.4 in smaller
> > > > > iterations, starting with moving the docs to it's new folder
> > > > >
> > > > > Check out the docs for more info, and some explanation why we
> arrived
> > > to
> > > > > the above conclusions in the above statements.
> > > > > The link again:
> > > > > https://docs.google.com/document/d/1WXqhaPlCwchcWc8RCEzbCmVa4WbBD
> > > > lfR3GQngikGjqc/edit?usp=sharing
> > > > >
> > > > > Regards,
> > > > > Norbert
> > > > >
> > > > > On Mon, May 28, 2018 at 1:09 PM Andor Molnar 
> > > wrote:
> > > > >
> > > > >> Excellent job Norbert, this doc will be very useful to discuss all
> > > kinds
> > > > >> of
> > > > >> aspects of the migration.
> > > > >> I've left some comments already.
> > > > >>
> > > > >> Thanks,
> > > > >> Andor
> > > > >>
> > > > >>
> > > > >>
> > > > >> On Fri, May 25, 2018 at 3:14 PM, Norbert Kalmar <
> > nkal...@cloudera.com
> > > >
> > > > >> wrote:
> > > > >>
> > > > >> > Hi,
> > > > >> >
> > > > >> > After doing some proof of work and had some discussion, I have
> > > > created a
> > > > >> > google docs about the maven migration.
> > > > >> >
> > > > >> > Please read through, and comment your thoughts and suggestions.
> > > > >> >
> > > > >> > https://docs.google.com/document/d/
> 1WXqhaPlCwchcWc8RCEzbCmVa4WbBD
> > > > >> > lfR3GQngikGjqc/edit?usp=sharing
> > > > >> >
> > > > >> >
> > > > >> > Thanks!
> > > > >> > Norbert
> > > > >> >
> > > > >>
> > > > >
> > > >
> > >
> >
>

[GitHub] zookeeper issue #550: ZOOKEEPER-3022 - Iteration 1 - docs, it

[anmolnar]

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/550
  
Thanks @nkalmar, looks good to me.
One nitpick only: add "MAVEN MIGRATION" to the title of all these PRs in 
capitals, just to make it obvious for everybody that you're making progress.


---

[jira] [Commented] (ZOOKEEPER-451) ZK should enforce quota

[Andor Molnar (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524612#comment-16524612
 ] 

Andor Molnar commented on ZOOKEEPER-451:


Thanks [~plsnotracking] for testing.

Are you willing to create a pull request on GitHub?

Your contribution would be more than welcome.

> ZK should enforce quota
> ---
>
> Key: ZOOKEEPER-451
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-451
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.2.0
>Reporter: Raghu S
>Assignee: Botond Hejj
>Priority: Major
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-451.patch, ZOOKEEPER-451.patch, 
> ZOOKEEPER-451.patch
>
>
> Email exchange with Mahadev:
> Mahadev Konar wrote:
> > Hi Raghu,
> >  We do have plans to enforce quota in future. Enforcing requires some more
> > work then just reporting. Reporting is a good enough tool for operations to
> > manage a zookeeper cluster but we would certainly like to enforce it in the
> > near future.
> > 
> > Thanks
> > mahadev
> > 
> > 
> > On 6/18/09 7:01 PM, "rag...@yahoo.com"  wrote:
> > 
> >> Is there a reason why node count/byte quota is not actually enforced but
> >> rather ZK just warns? Are there any plans to enforce the quota in a future
> >> release?
> >>
> >> Thanks
> >> Raghu
> >>
> >>
> >>
> > 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)