[jira] [Commented] (ZOOKEEPER-1423) 4lw and jmx should expose the size of the datadir/datalogdir
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622141#comment-14622141 ] Hudson commented on ZOOKEEPER-1423: --- SUCCESS: Integrated in ZooKeeper-trunk #2749 (See [https://builds.apache.org/job/ZooKeeper-trunk/2749/]) ZOOKEEPER-1423: 4lw and jmx should expose the size of the datadir/datalogdir (Edward Ribeiro via rgs) (rgs: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1690207) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ServerStats.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServerBean.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServerMXBean.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/admin/Commands.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/command/CommandExecutor.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/command/DirsCommand.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/command/FourLetterCommands.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FourLetterWordsQuorumTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FourLetterWordsTest.java > 4lw and jmx should expose the size of the datadir/datalogdir > > > Key: ZOOKEEPER-1423 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1423 > Project: ZooKeeper > Issue Type: Improvement > Components: jmx >Affects Versions: 3.5.0 >Reporter: Patrick Hunt >Assignee: Edward Ribeiro > Labels: newbie > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-1423.2.patch, ZOOKEEPER-1423.3.patch, > ZOOKEEPER-1423.4.patch, ZOOKEEPER-1423.5.patch, ZOOKEEPER-1423.6.patch, > ZOOKEEPER-1423.7.patch, ZOOKEEPER-1423.8.patch, ZOOKEEPER-1423.patch > > > There are no metrics currently available on the size of the > datadir/datalogdir. These grow w/o bound unless the cleanup script is run. It > would be good to expose these metrics through jmx/4lw such that monitoring > can be done on the size. Would key ppl in on whether cleanup was actually > running. In particular this could be monitored/alerted on by third party > systems (nagios, ganglia and the like). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1423) 4lw and jmx should expose the size of the datadir/datalogdir
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14621813#comment-14621813 ] Raul Gutierrez Segales commented on ZOOKEEPER-1423: --- Merged: http://svn.apache.org/viewvc?view=revision&revision=1690207 (github mirror lagging, apparently). Thanks [~eribeiro]! [~michim]: shall I merge this for 3.5 too? > 4lw and jmx should expose the size of the datadir/datalogdir > > > Key: ZOOKEEPER-1423 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1423 > Project: ZooKeeper > Issue Type: Improvement > Components: jmx >Affects Versions: 3.5.0 >Reporter: Patrick Hunt >Assignee: Edward Ribeiro > Labels: newbie > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-1423.2.patch, ZOOKEEPER-1423.3.patch, > ZOOKEEPER-1423.4.patch, ZOOKEEPER-1423.5.patch, ZOOKEEPER-1423.6.patch, > ZOOKEEPER-1423.7.patch, ZOOKEEPER-1423.8.patch, ZOOKEEPER-1423.patch > > > There are no metrics currently available on the size of the > datadir/datalogdir. These grow w/o bound unless the cleanup script is run. It > would be good to expose these metrics through jmx/4lw such that monitoring > can be done on the size. Would key ppl in on whether cleanup was actually > running. In particular this could be monitored/alerted on by third party > systems (nagios, ganglia and the like). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1423) 4lw and jmx should expose the size of the datadir/datalogdir
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619862#comment-14619862 ] Hadoop QA commented on ZOOKEEPER-1423: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12744356/ZOOKEEPER-1423.8.patch against trunk revision 1689571. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2810//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2810//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2810//console This message is automatically generated. > 4lw and jmx should expose the size of the datadir/datalogdir > > > Key: ZOOKEEPER-1423 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1423 > Project: ZooKeeper > Issue Type: Improvement > Components: jmx >Affects Versions: 3.5.0 >Reporter: Patrick Hunt >Assignee: Edward Ribeiro > Labels: newbie > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-1423.2.patch, ZOOKEEPER-1423.3.patch, > ZOOKEEPER-1423.4.patch, ZOOKEEPER-1423.5.patch, ZOOKEEPER-1423.6.patch, > ZOOKEEPER-1423.7.patch, ZOOKEEPER-1423.8.patch, ZOOKEEPER-1423.patch > > > There are no metrics currently available on the size of the > datadir/datalogdir. These grow w/o bound unless the cleanup script is run. It > would be good to expose these metrics through jmx/4lw such that monitoring > can be done on the size. Would key ppl in on whether cleanup was actually > running. In particular this could be monitored/alerted on by third party > systems (nagios, ganglia and the like). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1423) 4lw and jmx should expose the size of the datadir/datalogdir
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619516#comment-14619516 ] Raul Gutierrez Segales commented on ZOOKEEPER-1423: --- Thanks [~eribeiro]! One last nit (though, a bit more than a nit since it's a legal thing ;-): the license header is missing in src/java/main/org/apache/zookeeper/server/command/DirsCommand.java. After that I am happy to merge it, +1. Thanks! > 4lw and jmx should expose the size of the datadir/datalogdir > > > Key: ZOOKEEPER-1423 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1423 > Project: ZooKeeper > Issue Type: Improvement > Components: jmx >Affects Versions: 3.5.0 >Reporter: Patrick Hunt >Assignee: Edward Ribeiro > Labels: newbie > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-1423.2.patch, ZOOKEEPER-1423.3.patch, > ZOOKEEPER-1423.4.patch, ZOOKEEPER-1423.5.patch, ZOOKEEPER-1423.6.patch, > ZOOKEEPER-1423.7.patch, ZOOKEEPER-1423.patch > > > There are no metrics currently available on the size of the > datadir/datalogdir. These grow w/o bound unless the cleanup script is run. It > would be good to expose these metrics through jmx/4lw such that monitoring > can be done on the size. Would key ppl in on whether cleanup was actually > running. In particular this could be monitored/alerted on by third party > systems (nagios, ganglia and the like). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1423) 4lw and jmx should expose the size of the datadir/datalogdir
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619492#comment-14619492
]
Edward Ribeiro commented on ZOOKEEPER-1423:
---
Just a minor addendum: I had included the dir.length() just because then its
calculated numbers would not differ by the 4K bytes, per Linux directory, from
*du* command, for example (see below). But, I completely agree that its
inclusion would be very risky on multi-platform settings.
{code}
$ echo dirs | nc localhost 2181
datadir_size: 67109658
logdir_size: 67109658
{code}
{code}
$ du -b /var/zookeeper/data
67113754/var/zookeeper/data/version-2
67117854/var/zookeeper/data
{code}
> 4lw and jmx should expose the size of the datadir/datalogdir
>
>
> Key: ZOOKEEPER-1423
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1423
> Project: ZooKeeper
> Issue Type: Improvement
> Components: jmx
>Affects Versions: 3.5.0
>Reporter: Patrick Hunt
>Assignee: Edward Ribeiro
> Labels: newbie
> Fix For: 3.5.1
>
> Attachments: ZOOKEEPER-1423.2.patch, ZOOKEEPER-1423.3.patch,
> ZOOKEEPER-1423.4.patch, ZOOKEEPER-1423.5.patch, ZOOKEEPER-1423.6.patch,
> ZOOKEEPER-1423.7.patch, ZOOKEEPER-1423.patch
>
>
> There are no metrics currently available on the size of the
> datadir/datalogdir. These grow w/o bound unless the cleanup script is run. It
> would be good to expose these metrics through jmx/4lw such that monitoring
> can be done on the size. Would key ppl in on whether cleanup was actually
> running. In particular this could be monitored/alerted on by third party
> systems (nagios, ganglia and the like).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1423) 4lw and jmx should expose the size of the datadir/datalogdir
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619429#comment-14619429
]
Raul Gutierrez Segales commented on ZOOKEEPER-1423:
---
In:
{code}
+private long getDirSize(File dir) {
+long size = dir.length();
+if (dir.isDirectory()) {
+for (File f: dir.listFiles()) {
+size += getDirSize(f);
+}
+}
+return size;
+}
{code}
Is calling length() on a directory reliable? According to
http://docs.oracle.com/javase/7/docs/api/java/io/File.html#length(), it's not
defined:
"Returns the length of the file denoted by this abstract pathname. The return
value is unspecified if this pathname denotes a directory."
Though running a test prog on Linux (i.e.:
https://gist.github.com/rgs1/31e57c9bf2ddcb2c8018) it does show the right
thing. I wonder if it breaks on other platforms... If so, we probably shouldn't
add up the size of the directory.
One last nit, in:
{code}
+package org.apache.zookeeper.server.command;
+
+
+import org.apache.zookeeper.server.ServerCnxn;
+
+import java.io.IOException;
+import java.io.PrintWriter;
+
{code}
The stdlib imports usually go first, so it would be:
{code}
+import java.io.IOException;
+import java.io.PrintWriter;
+
+import org.apache.zookeeper.server.ServerCnxn;
{code}
> 4lw and jmx should expose the size of the datadir/datalogdir
>
>
> Key: ZOOKEEPER-1423
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1423
> Project: ZooKeeper
> Issue Type: Improvement
> Components: jmx
>Affects Versions: 3.5.0
>Reporter: Patrick Hunt
>Assignee: Edward Ribeiro
> Labels: newbie
> Fix For: 3.5.1
>
> Attachments: ZOOKEEPER-1423.2.patch, ZOOKEEPER-1423.3.patch,
> ZOOKEEPER-1423.4.patch, ZOOKEEPER-1423.5.patch, ZOOKEEPER-1423.6.patch,
> ZOOKEEPER-1423.patch
>
>
> There are no metrics currently available on the size of the
> datadir/datalogdir. These grow w/o bound unless the cleanup script is run. It
> would be good to expose these metrics through jmx/4lw such that monitoring
> can be done on the size. Would key ppl in on whether cleanup was actually
> running. In particular this could be monitored/alerted on by third party
> systems (nagios, ganglia and the like).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1423) 4lw and jmx should expose the size of the datadir/datalogdir
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619025#comment-14619025 ] Hadoop QA commented on ZOOKEEPER-1423: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12744274/ZOOKEEPER-1423.5.patch against trunk revision 1689571. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to cause Findbugs (version 2.0.3) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2809//testReport/ Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2809//console This message is automatically generated. > 4lw and jmx should expose the size of the datadir/datalogdir > > > Key: ZOOKEEPER-1423 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1423 > Project: ZooKeeper > Issue Type: Improvement > Components: jmx >Affects Versions: 3.5.0 >Reporter: Patrick Hunt >Assignee: Edward Ribeiro > Labels: newbie > Fix For: 3.5.1 > > Attachments: ZOOKEEPER-1423.2.patch, ZOOKEEPER-1423.3.patch, > ZOOKEEPER-1423.4.patch, ZOOKEEPER-1423.5.patch, ZOOKEEPER-1423.patch > > > There are no metrics currently available on the size of the > datadir/datalogdir. These grow w/o bound unless the cleanup script is run. It > would be good to expose these metrics through jmx/4lw such that monitoring > can be done on the size. Would key ppl in on whether cleanup was actually > running. In particular this could be monitored/alerted on by third party > systems (nagios, ganglia and the like). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1423) 4lw and jmx should expose the size of the datadir/datalogdir
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617558#comment-14617558
]
Raul Gutierrez Segales commented on ZOOKEEPER-1423:
---
Thanks for the patch [~eribeiro]! A few nits:
In:
{code}
+@Override
+public long getDataDirSize() {
+if (zkDb == null) return 0L;
+File path = zkDb.snapLog.getDataDir();
+return getDirSize(path);
+}
+
+@Override
+public long getLogDirSize() {
{code}
please use {} for if statements, even the body only has 1 statement. I.e.:
{code}
+public long getDataDirSize() {
+if (zkDb == null) {
+ return 0L;
+}
+File path = zkDb.snapLog.getDataDir();
+return getDirSize(path);
+}
{code}
Ditto for getLogDirSize(). Other than, lgtm. Will do one more pass after the
nits are addressed - thanks!
> 4lw and jmx should expose the size of the datadir/datalogdir
>
>
> Key: ZOOKEEPER-1423
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1423
> Project: ZooKeeper
> Issue Type: Improvement
> Components: jmx
>Affects Versions: 3.5.0
>Reporter: Patrick Hunt
>Assignee: Edward Ribeiro
> Labels: newbie
> Attachments: ZOOKEEPER-1423.2.patch, ZOOKEEPER-1423.3.patch,
> ZOOKEEPER-1423.4.patch, ZOOKEEPER-1423.patch
>
>
> There are no metrics currently available on the size of the
> datadir/datalogdir. These grow w/o bound unless the cleanup script is run. It
> would be good to expose these metrics through jmx/4lw such that monitoring
> can be done on the size. Would key ppl in on whether cleanup was actually
> running. In particular this could be monitored/alerted on by third party
> systems (nagios, ganglia and the like).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1423) 4lw and jmx should expose the size of the datadir/datalogdir
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1395#comment-1395
]
Rakesh R commented on ZOOKEEPER-1423:
-
Thanks Edward for the patch, lgtm mostly. I've few comments, please see:
# Format issues, please correct
{code}
+ public long getDataDirSize();
+public long getLogDirSize();
{code}
{code}
+
+public long getDataDirSize() {
+ return provider.getDataDirSize();
+}
+
+public long getLogDirSize() {
+ return provider.getLogDirSize();
+}
{code}
# Can we print the o/p in a single line like:
{code}
"datadir: " + dir + "size: " + dataSize
"logdir: " + dir + "size: " + logSize
{code}
# Small correction,
{code}
the total size of data and log (snapshot) directories' content in bytes.
{code}
Actually it should be snapshot and log, can we rephrase like:
{code}
the total size of snapshot and log files in bytes
{code}
# I feel, its good to expose the dirs path in MBean too.
# please provide javadocs for #getDataDirSize() and #getLogDirSize()
> 4lw and jmx should expose the size of the datadir/datalogdir
>
>
> Key: ZOOKEEPER-1423
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1423
> Project: ZooKeeper
> Issue Type: Improvement
> Components: jmx
>Affects Versions: 3.5.0
>Reporter: Patrick Hunt
>Assignee: Edward Ribeiro
> Labels: newbie
> Attachments: ZOOKEEPER-1423.2.patch, ZOOKEEPER-1423.3.patch,
> ZOOKEEPER-1423.patch
>
>
> There are no metrics currently available on the size of the
> datadir/datalogdir. These grow w/o bound unless the cleanup script is run. It
> would be good to expose these metrics through jmx/4lw such that monitoring
> can be done on the size. Would key ppl in on whether cleanup was actually
> running. In particular this could be monitored/alerted on by third party
> systems (nagios, ganglia and the like).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1423) 4lw and jmx should expose the size of the datadir/datalogdir
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951114#comment-13951114 ] Hadoop QA commented on ZOOKEEPER-1423: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12566406/ZOOKEEPER-1423.3.patch against trunk revision 1582572. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1992//console This message is automatically generated. > 4lw and jmx should expose the size of the datadir/datalogdir > > > Key: ZOOKEEPER-1423 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1423 > Project: ZooKeeper > Issue Type: Improvement > Components: jmx >Affects Versions: 3.5.0 >Reporter: Patrick Hunt >Assignee: Edward Ribeiro > Labels: newbie > Attachments: ZOOKEEPER-1423.2.patch, ZOOKEEPER-1423.3.patch, > ZOOKEEPER-1423.patch > > > There are no metrics currently available on the size of the > datadir/datalogdir. These grow w/o bound unless the cleanup script is run. It > would be good to expose these metrics through jmx/4lw such that monitoring > can be done on the size. Would key ppl in on whether cleanup was actually > running. In particular this could be monitored/alerted on by third party > systems (nagios, ganglia and the like). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1423) 4lw and jmx should expose the size of the datadir/datalogdir
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562185#comment-13562185 ] Hadoop QA commented on ZOOKEEPER-1423: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12566406/ZOOKEEPER-1423.3.patch against trunk revision 1437257. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1362//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1362//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1362//console This message is automatically generated. > 4lw and jmx should expose the size of the datadir/datalogdir > > > Key: ZOOKEEPER-1423 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1423 > Project: ZooKeeper > Issue Type: Improvement > Components: jmx >Reporter: Patrick Hunt >Assignee: Edward Ribeiro > Labels: newbie > Attachments: ZOOKEEPER-1423.2.patch, ZOOKEEPER-1423.3.patch, > ZOOKEEPER-1423.patch > > > There are no metrics currently available on the size of the > datadir/datalogdir. These grow w/o bound unless the cleanup script is run. It > would be good to expose these metrics through jmx/4lw such that monitoring > can be done on the size. Would key ppl in on whether cleanup was actually > running. In particular this could be monitored/alerted on by third party > systems (nagios, ganglia and the like). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1423) 4lw and jmx should expose the size of the datadir/datalogdir
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562133#comment-13562133 ] Hadoop QA commented on ZOOKEEPER-1423: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12566395/ZOOKEEPER-1423.2.patch against trunk revision 1437257. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1361//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1361//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1361//console This message is automatically generated. > 4lw and jmx should expose the size of the datadir/datalogdir > > > Key: ZOOKEEPER-1423 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1423 > Project: ZooKeeper > Issue Type: Improvement > Components: jmx >Reporter: Patrick Hunt >Assignee: Edward Ribeiro > Labels: newbie > Attachments: ZOOKEEPER-1423.2.patch, ZOOKEEPER-1423.patch > > > There are no metrics currently available on the size of the > datadir/datalogdir. These grow w/o bound unless the cleanup script is run. It > would be good to expose these metrics through jmx/4lw such that monitoring > can be done on the size. Would key ppl in on whether cleanup was actually > running. In particular this could be monitored/alerted on by third party > systems (nagios, ganglia and the like). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
