[jira] [Commented] (ZOOKEEPER-1817) Fix don't care for b3.4
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13830155#comment-13830155 ] Raul Gutierrez Segales commented on ZOOKEEPER-1817: --- Even though I didn't actually test this it looks correct to me (and nit-less ;-) ) - so +1. Will do proper testing for https://issues.apache.org/jira/browse/ZOOKEEPER-1818 once https://issues.apache.org/jira/browse/ZOOKEEPER-1810 lands. > Fix don't care for b3.4 > --- > > Key: ZOOKEEPER-1817 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira >Priority: Blocker > Fix For: 3.4.6 > > Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > logs.tar.gz, logs2.tar.gz > > > See umbrella jira. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1817) Fix don't care for b3.4
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13830100#comment-13830100 ] Germán Blanco commented on ZOOKEEPER-1817: -- +1, you are hearing right :-) > Fix don't care for b3.4 > --- > > Key: ZOOKEEPER-1817 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira >Priority: Blocker > Fix For: 3.4.6 > > Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > logs.tar.gz, logs2.tar.gz > > > See umbrella jira. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1817) Fix don't care for b3.4
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13830087#comment-13830087 ] Hadoop QA commented on ZOOKEEPER-1817: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12615351/ZOOKEEPER-1817.patch against trunk revision 1543281. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1801//console This message is automatically generated. > Fix don't care for b3.4 > --- > > Key: ZOOKEEPER-1817 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira >Priority: Blocker > Fix For: 3.4.6 > > Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > logs.tar.gz, logs2.tar.gz > > > See umbrella jira. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1817) Fix don't care for b3.4
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13830044#comment-13830044 ] Germán Blanco commented on ZOOKEEPER-1817: -- Responding to your proposal of removing backwards compatibility code, I agree. In my opinion, as long as there is an upgrade path from previous releases to new releases, introducing some mandatory steps (i.e. through 3.4.6 to reach 3.5.X) shouldn't be a big problem. > Fix don't care for b3.4 > --- > > Key: ZOOKEEPER-1817 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira >Priority: Blocker > Fix For: 3.4.6 > > Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, logs.tar.gz, logs2.tar.gz > > > See umbrella jira. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1817) Fix don't care for b3.4
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829981#comment-13829981 ] Hadoop QA commented on ZOOKEEPER-1817: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12615327/ZOOKEEPER-1817.patch against trunk revision 1543281. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1800//console This message is automatically generated. > Fix don't care for b3.4 > --- > > Key: ZOOKEEPER-1817 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira >Priority: Blocker > Fix For: 3.4.6 > > Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, logs.tar.gz, logs2.tar.gz > > > See umbrella jira. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1817) Fix don't care for b3.4
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829923#comment-13829923 ] Flavio Junqueira commented on ZOOKEEPER-1817: - Thanks for bringing this up, you're right. The current predicate works for versions 0x0 and 0x1, but it doesn't seem to do it right moving forward. There is a caveat to it, however. I was thinking of removing the backward compatibility code we have introduce here for 3.5.0 or even 3.4.7 if we have it. The transition path for upgrading from say 3.4.5 to 3.5.0 would have to be through 3.4.6. I can make the change you suggest, and it is probably a better idea to make it more general just in case, but my thinking is that this code for backward compatibility should be gone soon. My sense is that we have quite a number of bugs because we have to keep introducing complicated logic to satisfy backward compatibility, so I'd like to try to remove it for future releases. Does it make sense to you? > Fix don't care for b3.4 > --- > > Key: ZOOKEEPER-1817 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira >Priority: Blocker > Fix For: 3.4.6 > > Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, logs.tar.gz, logs2.tar.gz > > > See umbrella jira. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1817) Fix don't care for b3.4
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829741#comment-13829741
]
Germán Blanco commented on ZOOKEEPER-1817:
--
This works very well and it looks excellent overall.
However, I am starting to have doubts about this comparison in Vote.java:
{noformat}
+if (version == other.version) {
+return (id == other.id
+&& peerEpoch == other.peerEpoch);
+} else {
+return id == other.id;
+}
{noformat}
We know 3.4.5 peerEpoch has a different value than in the rest. But the
difference is there only for 3.4.5. I think this comparison should be a bit
different, and more in line with the use of backwards compatibility vote in
FastLeaderElection.java ...
{noformat}
ToSend notmsg;
if(n.version > 0x0) {
notmsg = new ToSend(
{noformat}
that would be "if one of the versions is 0x0 and the other is not, then don't
use peerEpoch. Otherwise use it" ...
{noformat}
+if ((version > 0x0) ^ (other.version > 0x0)) {
+return id == other.id;
+} else {
+return (id == other.id
+&& peerEpoch == other.peerEpoch);
+}
{noformat}
> Fix don't care for b3.4
> ---
>
> Key: ZOOKEEPER-1817
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817
> Project: ZooKeeper
> Issue Type: Sub-task
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
>Priority: Blocker
> Fix For: 3.4.6
>
> Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch,
> ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch,
> ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch,
> ZOOKEEPER-1817.patch, logs.tar.gz, logs2.tar.gz
>
>
> See umbrella jira.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1817) Fix don't care for b3.4
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13828903#comment-13828903 ] Hadoop QA commented on ZOOKEEPER-1817: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12615112/ZOOKEEPER-1817.patch against trunk revision 1543281. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1794//console This message is automatically generated. > Fix don't care for b3.4 > --- > > Key: ZOOKEEPER-1817 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira >Priority: Blocker > Fix For: 3.4.6 > > Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, logs.tar.gz, logs2.tar.gz > > > See umbrella jira. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1817) Fix don't care for b3.4
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13827763#comment-13827763 ] Flavio Junqueira commented on ZOOKEEPER-1817: - .bq It should be QuorumMaj.class instead of QuorumVerifier.class I actually meant to remove it because there is no logging going on there, I added it for my own debugging. bq. this has a "+1" from me I'd like to work a bit more on the test case, but I don't expect the overall behavior to change. Once I have it, I'll ask you to give it a last look if you don't mind. bq. Thank you for the great work Thank you for all the help with reviewing and testing, it has been great. > Fix don't care for b3.4 > --- > > Key: ZOOKEEPER-1817 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira >Priority: Blocker > Fix For: 3.4.6 > > Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > logs.tar.gz, logs2.tar.gz > > > See umbrella jira. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1817) Fix don't care for b3.4
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13827721#comment-13827721
]
Germán Blanco commented on ZOOKEEPER-1817:
--
Just one additional comment ...
I think that in this line:
{noformat}
public class QuorumMaj implements QuorumVerifier {
+private static final Logger LOG =
LoggerFactory.getLogger(QuorumVerifier.class);
+
{noformat}
It should be QuorumMaj.class instead of QuorumVerifier.class
In terms of behavior, this has a "+1" from me. I will still repeat the tests
again in the last version of the patch, just in case.
Thank you for the great work on this [~fpj]!
> Fix don't care for b3.4
> ---
>
> Key: ZOOKEEPER-1817
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817
> Project: ZooKeeper
> Issue Type: Sub-task
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
>Priority: Blocker
> Fix For: 3.4.6
>
> Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch,
> ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch,
> ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch,
> logs.tar.gz, logs2.tar.gz
>
>
> See umbrella jira.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1817) Fix don't care for b3.4
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13827146#comment-13827146
]
Raul Gutierrez Segales commented on ZOOKEEPER-1817:
---
(as said before, i have only been testing the upstream version of this ticket)
Some nits:
{noformat}
+if ((state == ServerState.LOOKING) ||
+(other.state == ServerState.LOOKING)) {
+return (id == other.id
&& zxid == other.zxid
&& electionEpoch == other.electionEpoch
&& peerEpoch == other.peerEpoch);
+} else {
+if (version == other.version) {
+return (id == other.id
+&& peerEpoch == other.peerEpoch);
+} else {
+return id == other.id;
+}
+}
+}
{noformat}
could be simplified to:
{noformat}
+if ((state == ServerState.LOOKING) ||
+(other.state == ServerState.LOOKING)) {
+return (id == other.id
&& zxid == other.zxid
&& electionEpoch == other.electionEpoch
&& peerEpoch == other.peerEpoch);
+} else if (version == other.version) {
+return id == other.id && peerEpoch == other.peerEpoch;
+}
+
+return id == other.id;
+}
{noformat}
In src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumMaj.java:
{noformat}
+//import org.apache.zookeeper.server.quorum.QuorumCnxManager;
{noformat}
just delete that line?
In src/java/test/org/apache/zookeeper/server/quorum/FLEDontCareTest.java I
guess testOutofElection is still work in progress because of the commented code?
> Fix don't care for b3.4
> ---
>
> Key: ZOOKEEPER-1817
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817
> Project: ZooKeeper
> Issue Type: Sub-task
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
>Priority: Blocker
> Fix For: 3.4.6
>
> Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch,
> ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch,
> ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch,
> logs.tar.gz, logs2.tar.gz
>
>
> See umbrella jira.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1817) Fix don't care for b3.4
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826920#comment-13826920 ] Hadoop QA commented on ZOOKEEPER-1817: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12614685/ZOOKEEPER-1817.patch against trunk revision 1543281. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1792//console This message is automatically generated. > Fix don't care for b3.4 > --- > > Key: ZOOKEEPER-1817 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira >Priority: Blocker > Fix For: 3.4.6 > > Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > logs.tar.gz, logs2.tar.gz > > > See umbrella jira. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1817) Fix don't care for b3.4
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826775#comment-13826775 ] Raul Gutierrez Segales commented on ZOOKEEPER-1817: --- Sorry guys I couldn't test this - don't have a 3.4 setup handy. Will do proper testing with trunk though (and of course, the nits in both cases ;-). And thanks for testing [~abranzyck]. > Fix don't care for b3.4 > --- > > Key: ZOOKEEPER-1817 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira >Priority: Blocker > Fix For: 3.4.6 > > Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, logs.tar.gz, logs2.tar.gz > > > See umbrella jira. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1817) Fix don't care for b3.4
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826615#comment-13826615
]
Germán Blanco commented on ZOOKEEPER-1817:
--
As far as I can test, this works.
There seems to be a continuous output every two seconds in the log of the
leader:
{noformat}
WARN [QuorumPeer[myid=3]/0:0:0:0:0:0:0:0:2183:QuorumMaj@60] - Set size and
half: 3, 1
{noformat}
> Fix don't care for b3.4
> ---
>
> Key: ZOOKEEPER-1817
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817
> Project: ZooKeeper
> Issue Type: Sub-task
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
>Priority: Blocker
> Fix For: 3.4.6
>
> Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch,
> ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch,
> ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, logs.tar.gz, logs2.tar.gz
>
>
> See umbrella jira.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1817) Fix don't care for b3.4
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826564#comment-13826564 ] Hadoop QA commented on ZOOKEEPER-1817: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12614628/ZOOKEEPER-1817.patch against trunk revision 1543281. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1791//console This message is automatically generated. > Fix don't care for b3.4 > --- > > Key: ZOOKEEPER-1817 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira >Priority: Blocker > Fix For: 3.4.6 > > Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, logs.tar.gz, logs2.tar.gz > > > See umbrella jira. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1817) Fix don't care for b3.4
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826250#comment-13826250 ] Hadoop QA commented on ZOOKEEPER-1817: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12614552/logs2.tar.gz against trunk revision 1543281. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1790//console This message is automatically generated. > Fix don't care for b3.4 > --- > > Key: ZOOKEEPER-1817 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira >Priority: Blocker > Fix For: 3.4.6 > > Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, logs.tar.gz, logs2.tar.gz > > > See umbrella jira. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1817) Fix don't care for b3.4
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825743#comment-13825743 ] Hadoop QA commented on ZOOKEEPER-1817: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12614476/ZOOKEEPER-1817.patch against trunk revision 1542355. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1789//console This message is automatically generated. > Fix don't care for b3.4 > --- > > Key: ZOOKEEPER-1817 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira >Priority: Blocker > Fix For: 3.4.6 > > Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, logs.tar.gz > > > See umbrella jira. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1817) Fix don't care for b3.4
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825501#comment-13825501 ] Flavio Junqueira commented on ZOOKEEPER-1817: - ah, I can see where I got it wrong, thanks for checking. > Fix don't care for b3.4 > --- > > Key: ZOOKEEPER-1817 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira >Priority: Blocker > Fix For: 3.4.6 > > Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, logs.tar.gz > > > See umbrella jira. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1817) Fix don't care for b3.4
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825478#comment-13825478 ] Hadoop QA commented on ZOOKEEPER-1817: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12614421/logs.tar.gz against trunk revision 1542355. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1784//console This message is automatically generated. > Fix don't care for b3.4 > --- > > Key: ZOOKEEPER-1817 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira >Priority: Blocker > Fix For: 3.4.6 > > Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, logs.tar.gz > > > See umbrella jira. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1817) Fix don't care for b3.4
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825367#comment-13825367 ] Hadoop QA commented on ZOOKEEPER-1817: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12614396/ZOOKEEPER-1817.patch against trunk revision 1542355. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1783//console This message is automatically generated. > Fix don't care for b3.4 > --- > > Key: ZOOKEEPER-1817 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira >Priority: Blocker > Fix For: 3.4.6 > > Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch > > > See umbrella jira. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1817) Fix don't care for b3.4
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825290#comment-13825290 ] Flavio Junqueira commented on ZOOKEEPER-1817: - Ok, that's bad news, although I think I know how to fix this one. I'll work on a new patch. > Fix don't care for b3.4 > --- > > Key: ZOOKEEPER-1817 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira >Priority: Blocker > Fix For: 3.4.6 > > Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch > > > See umbrella jira. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1817) Fix don't care for b3.4
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825270#comment-13825270
]
Germán Blanco commented on ZOOKEEPER-1817:
--
This works in almost all cases.
3.4 is a server running the updated branch 3.4, patch included.
3.3 is a server running the latest code in branch 3.3.
Rolling upgrade from 3.3 to 3.4 works.
Rolling upgrade from 3.4.5 to 3.4 works, unless there is a leader election in
the wrong moment.
That is because a 3.4.5 server is not always able to join an ensemble of a
3.4.5 and a 3.4. However some of the elections do finish. I found two potential
causes:
1 - election epoch reported by 3.4 follower after election is -1, instead of
the round of the last election. This seems to be because of the change here:
{noformat}
} else {
/*
* If this server is not looking, but the one
that sent the ack
* is looking, then send back what it believes
to be the leader.
*/
Vote current = self.getCurrentVote();
if(ackstate == QuorumPeer.ServerState.LOOKING){
if(LOG.isDebugEnabled()){
LOG.debug("Sending new notification. My
id = " +
self.getId() + " recipient=" +
response.sid + " zxid=0x" +
Long.toHexString(current.getZxid()) +
" leader=" + current.getId());
}
ToSend notmsg = new ToSend(
ToSend.mType.notification,
current.getId(),
current.getZxid(),
+ current.getElectionEpoch(),
- logicalclock,
self.getPeerState(),
response.sid,
current.getPeerEpoch());
sendqueue.offer(notmsg);
}
}
}
{noformat}
I am afraid this change was introduced by me in ZOOKEEPER-1732. The only
purpose of the change was to be able to update the election epoch from FLETest.
My assumption was that current.getElectionEpoch() was always the same as
logicalclock when this function was called. I see now that this is not the
case, and it causes problems. I suggest to put this back to what it was
(logicalclock) and fix the test case if required.
2 - The value of n.round is different (because of the "newEpoch-1" issue). This
could be fixed by removing the call to updateElectionVote in Leader.java, and
changing the parameter from newEpoch to newEpoch-1 in Learner.java.
I have tried these two changes and they seem to enable finishing the election
for the 3.4.5 server joining the 3.4+3.4.5 ensemble every time.
I can upload logs, but given the amount of combinations, sending everything
would be a mess. If you are interested in the logs of any of the nodes in any
of the rolling upgrade test cases, please let me know and I will send them.
> Fix don't care for b3.4
> ---
>
> Key: ZOOKEEPER-1817
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817
> Project: ZooKeeper
> Issue Type: Sub-task
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
>Priority: Blocker
> Fix For: 3.4.6
>
> Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch,
> ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch
>
>
> See umbrella jira.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1817) Fix don't care for b3.4
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825185#comment-13825185 ] Hadoop QA commented on ZOOKEEPER-1817: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12614356/ZOOKEEPER-1817.patch against trunk revision 1542355. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1780//console This message is automatically generated. > Fix don't care for b3.4 > --- > > Key: ZOOKEEPER-1817 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira >Priority: Blocker > Fix For: 3.4.6 > > Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch > > > See umbrella jira. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1817) Fix don't care for b3.4
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824972#comment-13824972 ] Raul Gutierrez Segales commented on ZOOKEEPER-1817: --- (of course, with the proper line wrap for > 80 chars). > Fix don't care for b3.4 > --- > > Key: ZOOKEEPER-1817 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira >Priority: Blocker > Fix For: 3.4.6 > > Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch > > > See umbrella jira. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1817) Fix don't care for b3.4
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824970#comment-13824970
]
Raul Gutierrez Segales commented on ZOOKEEPER-1817:
---
One more nit (sorry [~fpj]) in:
{noformat}
-return "(" + id + ", " + Long.toHexString(zxid) + ", " +
Long.toHexString(peerEpoch) + ")";
+return "(" + id + ", "
+ + Long.toHexString(zxid)
+ + ", " + Long.toHexString(peerEpoch)
+ + ")";
{noformat}
should we encourage String.format instead of concatenation (as we do in LOG
statements with {})? I think this is more readable:
{noformat}
-return "(" + id + ", " + Long.toHexString(zxid) + ", " +
Long.toHexString(peerEpoch) + ")";
+return String.format("(%d, %s, %s)", id, Long.toHexString(zxid),
Long.toHexString(peerEpoch));
{noformat}
What do you think?
> Fix don't care for b3.4
> ---
>
> Key: ZOOKEEPER-1817
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817
> Project: ZooKeeper
> Issue Type: Sub-task
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
>Priority: Blocker
> Fix For: 3.4.6
>
> Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch,
> ZOOKEEPER-1817.patch
>
>
> See umbrella jira.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1817) Fix don't care for b3.4
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824784#comment-13824784 ] Hadoop QA commented on ZOOKEEPER-1817: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12614277/ZOOKEEPER-1817.patch against trunk revision 1542355. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1776//console This message is automatically generated. > Fix don't care for b3.4 > --- > > Key: ZOOKEEPER-1817 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira >Priority: Blocker > Fix For: 3.4.6 > > Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch > > > See umbrella jira. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1817) Fix don't care for b3.4
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824625#comment-13824625 ] Raul Gutierrez Segales commented on ZOOKEEPER-1817: --- Ah - the rb is https://reviews.apache.org/r/15625/. Though it's having issues - maybe try reloading? I guess reviewboard applies against the git mirrors and there was a lag in Apache's git-svn sync yesterday (i think). > Fix don't care for b3.4 > --- > > Key: ZOOKEEPER-1817 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira >Priority: Blocker > Fix For: 3.4.6 > > Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch > > > See umbrella jira. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1817) Fix don't care for b3.4
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824622#comment-13824622 ] Raul Gutierrez Segales commented on ZOOKEEPER-1817: --- With the mix of inline and reviewboard reviews I am not sure where we should review this one :) Is there a reviewboard for this one as well or just inline? If there is mind adding the link here for posterity - thanks [~fpj]. > Fix don't care for b3.4 > --- > > Key: ZOOKEEPER-1817 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira >Priority: Blocker > Fix For: 3.4.6 > > Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch > > > See umbrella jira. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1817) Fix don't care for b3.4
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824481#comment-13824481 ] Hadoop QA commented on ZOOKEEPER-1817: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12614222/ZOOKEEPER-1817.patch against trunk revision 1542355. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1775//console This message is automatically generated. > Fix don't care for b3.4 > --- > > Key: ZOOKEEPER-1817 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira >Priority: Blocker > Fix For: 3.4.6 > > Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch > > > See umbrella jira. -- This message was sent by Atlassian JIRA (v6.1#6144)
