[jira] [Commented] (ZOOKEEPER-2182) Several test suites are not running during pre-commit, because their names do not end with "Test".
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14539286#comment-14539286
]
Hongchao Deng commented on ZOOKEEPER-2182:
--
Thank you! My mistake to forget close it.
> Several test suites are not running during pre-commit, because their names do
> not end with "Test".
> --
>
> Key: ZOOKEEPER-2182
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2182
> Project: ZooKeeper
> Issue Type: Bug
> Components: tests
>Affects Versions: 3.5.0
>Reporter: Chris Nauroth
>Assignee: Chris Nauroth
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2182.001.patch
>
>
> In build.xml, the {{}} task definition uses an include pattern of
> {{\*\*/\*$\{test.category\}Test.java}}. This is important so that we don't
> accidentally try to run utility classes like {{PortAssignment}} or
> {{TestableZooKeeper}} as if they were JUnit suites. However, several test
> suites are misnamed so that they don't satisfy this pattern, and therefore
> pre-commit hasn't been running them.
> {{ClientRetry}}
> {{ReconfigFailureCases}}
> {{WatchEventWhenAutoReset}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2182) Several test suites are not running during pre-commit, because their names do not end with "Test".
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14539278#comment-14539278
]
Rakesh R commented on ZOOKEEPER-2182:
-
Thanks all for taking care this. [~hdeng] am closing this jira as I think the
changes has been applied/committed. Please feel to re-open if anything to be
done.
> Several test suites are not running during pre-commit, because their names do
> not end with "Test".
> --
>
> Key: ZOOKEEPER-2182
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2182
> Project: ZooKeeper
> Issue Type: Bug
> Components: tests
>Affects Versions: 3.5.0
>Reporter: Chris Nauroth
>Assignee: Chris Nauroth
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2182.001.patch
>
>
> In build.xml, the {{}} task definition uses an include pattern of
> {{\*\*/\*$\{test.category\}Test.java}}. This is important so that we don't
> accidentally try to run utility classes like {{PortAssignment}} or
> {{TestableZooKeeper}} as if they were JUnit suites. However, several test
> suites are misnamed so that they don't satisfy this pattern, and therefore
> pre-commit hasn't been running them.
> {{ClientRetry}}
> {{ReconfigFailureCases}}
> {{WatchEventWhenAutoReset}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2182) Several test suites are not running during pre-commit, because their names do not end with "Test".
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538257#comment-14538257
]
Chris Nauroth commented on ZOOKEEPER-2182:
--
Thank you for the reviews and commit, Hongchao and Alex.
> Several test suites are not running during pre-commit, because their names do
> not end with "Test".
> --
>
> Key: ZOOKEEPER-2182
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2182
> Project: ZooKeeper
> Issue Type: Bug
> Components: tests
>Affects Versions: 3.5.0
>Reporter: Chris Nauroth
>Assignee: Chris Nauroth
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2182.001.patch
>
>
> In build.xml, the {{}} task definition uses an include pattern of
> {{\*\*/\*$\{test.category\}Test.java}}. This is important so that we don't
> accidentally try to run utility classes like {{PortAssignment}} or
> {{TestableZooKeeper}} as if they were JUnit suites. However, several test
> suites are misnamed so that they don't satisfy this pattern, and therefore
> pre-commit hasn't been running them.
> {{ClientRetry}}
> {{ReconfigFailureCases}}
> {{WatchEventWhenAutoReset}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2182) Several test suites are not running during pre-commit, because their names do not end with "Test".
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537827#comment-14537827
]
Hudson commented on ZOOKEEPER-2182:
---
SUCCESS: Integrated in ZooKeeper-trunk #2688 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2688/])
ZOOKEEPER-2182 Several test suites are not running during pre-commit, because
their names do not end with "Test". (Chris Nauroth via hdeng) (hdeng:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1678645)
* /zookeeper/trunk/CHANGES.txt
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/ReconfigFailureCases.java
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/ReconfigFailureCasesTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ClientRetry.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ClientRetryTest.java
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/WatchEventWhenAutoReset.java
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/WatchEventWhenAutoResetTest.java
> Several test suites are not running during pre-commit, because their names do
> not end with "Test".
> --
>
> Key: ZOOKEEPER-2182
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2182
> Project: ZooKeeper
> Issue Type: Bug
> Components: tests
>Affects Versions: 3.5.0
>Reporter: Chris Nauroth
>Assignee: Chris Nauroth
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2182.001.patch
>
>
> In build.xml, the {{}} task definition uses an include pattern of
> {{\*\*/\*$\{test.category\}Test.java}}. This is important so that we don't
> accidentally try to run utility classes like {{PortAssignment}} or
> {{TestableZooKeeper}} as if they were JUnit suites. However, several test
> suites are misnamed so that they don't satisfy this pattern, and therefore
> pre-commit hasn't been running them.
> {{ClientRetry}}
> {{ReconfigFailureCases}}
> {{WatchEventWhenAutoReset}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2182) Several test suites are not running during pre-commit, because their names do not end with "Test".
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537384#comment-14537384
]
Hongchao Deng commented on ZOOKEEPER-2182:
--
Thanks for Alex's review and [~cnauroth]'s patch
> Several test suites are not running during pre-commit, because their names do
> not end with "Test".
> --
>
> Key: ZOOKEEPER-2182
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2182
> Project: ZooKeeper
> Issue Type: Bug
> Components: tests
>Affects Versions: 3.5.0
>Reporter: Chris Nauroth
>Assignee: Chris Nauroth
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2182.001.patch
>
>
> In build.xml, the {{}} task definition uses an include pattern of
> {{\*\*/\*$\{test.category\}Test.java}}. This is important so that we don't
> accidentally try to run utility classes like {{PortAssignment}} or
> {{TestableZooKeeper}} as if they were JUnit suites. However, several test
> suites are misnamed so that they don't satisfy this pattern, and therefore
> pre-commit hasn't been running them.
> {{ClientRetry}}
> {{ReconfigFailureCases}}
> {{WatchEventWhenAutoReset}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2182) Several test suites are not running during pre-commit, because their names do not end with "Test".
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537383#comment-14537383
]
Hongchao Deng commented on ZOOKEEPER-2182:
--
Committed:
trunk:
https://github.com/apache/zookeeper/commit/029d6299e006ca697c3d6f9953b3194a7c33bf19
branch-3.5:
https://github.com/apache/zookeeper/commit/5b06e01de19135b6fe38a947dd1238877a647e49
> Several test suites are not running during pre-commit, because their names do
> not end with "Test".
> --
>
> Key: ZOOKEEPER-2182
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2182
> Project: ZooKeeper
> Issue Type: Bug
> Components: tests
>Affects Versions: 3.5.0
>Reporter: Chris Nauroth
>Assignee: Chris Nauroth
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2182.001.patch
>
>
> In build.xml, the {{}} task definition uses an include pattern of
> {{\*\*/\*$\{test.category\}Test.java}}. This is important so that we don't
> accidentally try to run utility classes like {{PortAssignment}} or
> {{TestableZooKeeper}} as if they were JUnit suites. However, several test
> suites are misnamed so that they don't satisfy this pattern, and therefore
> pre-commit hasn't been running them.
> {{ClientRetry}}
> {{ReconfigFailureCases}}
> {{WatchEventWhenAutoReset}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2182) Several test suites are not running during pre-commit, because their names do not end with "Test".
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537331#comment-14537331
]
Alexander Shraer commented on ZOOKEEPER-2182:
-
+1 thanks a lot Chris
> Several test suites are not running during pre-commit, because their names do
> not end with "Test".
> --
>
> Key: ZOOKEEPER-2182
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2182
> Project: ZooKeeper
> Issue Type: Bug
> Components: tests
>Reporter: Chris Nauroth
>Assignee: Chris Nauroth
> Attachments: ZOOKEEPER-2182.001.patch
>
>
> In build.xml, the {{}} task definition uses an include pattern of
> {{\*\*/\*$\{test.category\}Test.java}}. This is important so that we don't
> accidentally try to run utility classes like {{PortAssignment}} or
> {{TestableZooKeeper}} as if they were JUnit suites. However, several test
> suites are misnamed so that they don't satisfy this pattern, and therefore
> pre-commit hasn't been running them.
> {{ClientRetry}}
> {{ReconfigFailureCases}}
> {{WatchEventWhenAutoReset}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2182) Several test suites are not running during pre-commit, because their names do not end with "Test".
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1451#comment-1451
]
Hongchao Deng commented on ZOOKEEPER-2182:
--
+1 for the patch.
> Several test suites are not running during pre-commit, because their names do
> not end with "Test".
> --
>
> Key: ZOOKEEPER-2182
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2182
> Project: ZooKeeper
> Issue Type: Bug
> Components: tests
>Reporter: Chris Nauroth
>Assignee: Chris Nauroth
> Attachments: ZOOKEEPER-2182.001.patch
>
>
> In build.xml, the {{}} task definition uses an include pattern of
> {{\*\*/\*$\{test.category\}Test.java}}. This is important so that we don't
> accidentally try to run utility classes like {{PortAssignment}} or
> {{TestableZooKeeper}} as if they were JUnit suites. However, several test
> suites are misnamed so that they don't satisfy this pattern, and therefore
> pre-commit hasn't been running them.
> {{ClientRetry}}
> {{ReconfigFailureCases}}
> {{WatchEventWhenAutoReset}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2182) Several test suites are not running during pre-commit, because their names do not end with "Test".
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14533248#comment-14533248
]
Hadoop QA commented on ZOOKEEPER-2182:
--
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12731238/ZOOKEEPER-2182.001.patch
against trunk revision 1678032.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 20 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2680//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2680//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2680//console
This message is automatically generated.
> Several test suites are not running during pre-commit, because their names do
> not end with "Test".
> --
>
> Key: ZOOKEEPER-2182
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2182
> Project: ZooKeeper
> Issue Type: Bug
> Components: tests
>Reporter: Chris Nauroth
>Assignee: Chris Nauroth
> Attachments: ZOOKEEPER-2182.001.patch
>
>
> In build.xml, the {{}} task definition uses an include pattern of
> {{\*\*/\*$\{test.category\}Test.java}}. This is important so that we don't
> accidentally try to run utility classes like {{PortAssignment}} or
> {{TestableZooKeeper}} as if they were JUnit suites. However, several test
> suites are misnamed so that they don't satisfy this pattern, and therefore
> pre-commit hasn't been running them.
> {{ClientRetry}}
> {{ReconfigFailureCases}}
> {{WatchEventWhenAutoReset}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
