Fellow Report: Oct 27-31, 2014
Hi all,
Here is a list of what I've worked on in the last week. You can see
more detailed version of this report (including my rough TODO list) at
https://code.djangoproject.com/wiki/DjangoFellows/BerkerPeksag.
Authored
* https://github.com/django/django/pull/3432 -- Used more specific
asserts in the Django test suite.
* https://github.com/django/django/pull/3421 -- Limited lines to 119
characters in django/{contrib,db}.
* https://github.com/django/django/pull/3439 -- Fixed #18731 -- Added
an example about customizing "makemessages" command.
* https://github.com/django/django/pull/3442 -- Converted seealso
directives to use 4 space indendation.
* https://github.com/django/django/pull/3444 -- Fixed #23575 -- Added
a code example for custom AdminSite.
Revised pull requests (fixing merge conflicts, addressing remaining
issues, adding more tests etc.)
* https://github.com/django/django/pull/3433 -- Fixed #20495 -- Added
login failure events to security logger.
* https://github.com/django/django/pull/3454 -- Escape path returned
by `HttpRequest.get_full_path()`.
Code reviews
Django
* https://github.com/django/django/pull/3369/ -- Fixed #9893 --
Filename could exceed max_length on a collision
* https://github.com/django/django/pull/3447/ -- Fixed #23468 --
settings.FIXTURE_DIRS checks in loaddata command
* https://github.com/django/django/pull/3455/ -- Fixed #23730 --
Moved support for SimpleCookie HIGHEST_PROTOCOL pickling to
http.cookie
Python
* http://bugs.python.org/review/22775/ -- SimpleCookie not picklable
with HIGHEST_PROTOCOL
Triaged tickets
* http://bugs.python.org/issue22758 -- Regression in Python 3.2 cookie parsing
* http://bugs.python.org/issue22775 -- SimpleCookie not picklable with
HIGHEST_PROTOCOL
--Berker
--
You received this message because you are subscribed to the Google Groups
"Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-developers/CAF4280LmuiZcAp0PrgWhayRJVxA-0dQovoo2LwNNFBMYiJb20g%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Fellow Report: Week 2
Hi all, Here is this week's report. I plan to finish #3461 (Gunicorn integration) and #3467 (logging support for management commands) in the next week: Pull requests - Authored * [Committed] https://github.com/django/django/pull/3460 -- Fixed versionchanged indentation in docs/ Commit: https://github.com/django/django/commit/5c517ec21839358249c6f17611abbf84661fb200 * [Work in progress] https://github.com/django/django/pull/3461 -- Fixed #21978 -- Added optional gunicorn support to runserver. * [Committed] https://github.com/django/django/pull/3466 -- Fixed #23531 -- Added CommonMiddleware.response_redirect_class. Commit: https://github.com/django/django/commit/df0523debcc2d0984f1bc11d323f04227d4b388b * [Work in progress] https://github.com/django/django/pull/3467 -- Fixed #21429 -- Added builtin logging support to BaseCommand. * [Ready for review] https://github.com/django/django/pull/3477 -- Fixed #18119 -- Added a DomainNameValidator validator. * [In review] https://github.com/django/django/pull/3479 -- Fixed #11919 -- Added a DPASTE_URL setting to customize the dpaste feature. * [Ready for review] https://github.com/django/django/pull/3486 -- Fixed #14664 -- Logged a warning if MiddlewareNotUsed is raised in DEBUG mode. Revised (from last week) * [Committed] https://github.com/django/django/pull/3454 - https://github.com/django/django/commit/c548c8d0d1112d2c4bace2eebf73ede35300d842 * [Committed] https://github.com/django/django/pull/3432 - https://github.com/django/django/commit/f7969b0920c403118656f6bfec58d6454d79ef1a Code reviews -- * https://github.com/django/django/pull/3469 Triaged tickets --- * https://code.djangoproject.com/ticket/18716 -- Add a new docs management command that loads up the docs in a webbrowser * https://code.djangoproject.com/ticket/19159 -- loaddata reports DeserializationError instead of MemoryError * https://code.djangoproject.com/ticket/15917 -- Logging dictionary config works wrong at least with SMTPHandler --Berker -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAF4280Ki1KmzDTg4RTR3rM5d2v_xC4AXdnSzi4yCusnTnKHRYQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
Fellow Report: Week 3
Hi all, Here is this week's report. You can see a more readable version of this report at https://code.djangoproject.com/wiki/DjangoFellows/BerkerPeksag#Weekof2014-11-10 Pull requests - Authored ^ * [Committed] https://github.com/django/django/pull/3495 -- Fixed #22407 -- Added BaseEmailHandler to allow customizing mail senders. Commit: https://github.com/django/django/commit/d552da1f8d42b7c6db992fee42bc4781f5fdde43 * [Committed] https://github.com/django/django/pull/3510 -- Fixed #23665 -- Added a note about precedence of the USE_L10N setting in the MONTH_DAY_FORMAT and YEAR_MONTH_FORMAT documentations. Commit: https://github.com/django/django/commit/4f90c99635149fae2f488c03f0b52303fe97e0aa * [Committed] https://github.com/django/django/pull/3512 -- Fixed #21363 -- Added datetime.timedelta support to TimestampSigner.unsign(). Commit: https://github.com/django/django/commit/d2d6c0c097072e2a8ece755fdc2d50c04e7d * https://github.com/django/django/pull/3518 -- Fixed #21753 -- Raised exception when both form_class and fields are specified. WIP pull requests ^ * Thanks to feedback from Collin Anderson, I've fixed a couple of bugs in the Gunicorn branch: https://github.com/django/django/pull/3461 * I've simplified the initial implementation, and will start to port some management commands to use `self.logger` in the next week: https://github.com/django/django/pull/3467 * I've addressed review comments, fixed tests on Python 3: https://github.com/django/django/pull/3486 Code reviews -- * Second round for https://github.com/django/django/pull/3369 -- Ready for checkin * https://github.com/django/django/pull/3508/ * https://github.com/django/django/pull/3506/ * https://github.com/django/django/pull/3511/ * https://github.com/django/django/pull/3517/ * https://github.com/django/django/pull/3513/ * https://github.com/django/django/pull/3524/ -- Ready for checkin: https://code.djangoproject.com/ticket/23690#comment:4 * https://github.com/django/django/pull/3526/ -- Ready for checkin: https://code.djangoproject.com/ticket/23585#comment:2 * https://github.com/django/django/pull/3553/ --Berker -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAF4280%2BEsZaM7HYA6zc_Y%3DsFsAodg6JANcEhhD-aB-f5vsV%2Bzg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
Fellow Report: Nov 23, 2014
Hi all, Here is this week's report. You can see a more readable version of this report at https://code.djangoproject.com/wiki/DjangoFellows/BerkerPeksag#Weekof2014-11-17 Pull requests - Authored ^ * [Committed] https://github.com/django/django/pull/3582 -- Fixed #12098 -- Simplified HttpRequest.__repr__(). Commit: https://github.com/django/django/commit/788fa9fffa0105d391b8fe35f2894bc5b4e29066 * https://github.com/django/django/pull/3597 -- Fixed #21587 -- Added a deprecation warning for RedirectView.permanent. * [Committed] https://github.com/django/django/pull/3604 -- Silenced a flake8 warning. Commit: https://github.com/django/django/commit/da2a35cf9ed3ced1425aea361bca49ef759c8706 * https://github.com/django/django/pull/3606 -- Fixed #13694 -- Made SafeMIMEText's constructor compatible with MIMEText. * https://github.com/django/django/pull/3609 -- Fixed #12982 -- Added a ``get_or_set`` method to the BaseCache backend. >From last week ^^ * https://github.com/django/django/commit/343162410f9270012e4fdd8396d542b39cc63269 -- Raised exception when both `form_class` and `fields` are specified. Code reviews -- * https://github.com/django/django/pull/3560 -- Fixed #23859 -- Documented the locmem.Loader class. -- Ready for checkin: https://code.djangoproject.com/ticket/23849#comment:3 * https://github.com/django/django/pull/3553 -- Second round - Ready for checkin: https://code.djangoproject.com/ticket/18714#comment:15 * [Post merge review] https://github.com/django/django/commit/bb4a92d7845878b2ce0c4a5ca154cb4db22f7bad * https://github.com/django/django/pull/3566 * https://github.com/django/django/pull/3594 * https://github.com/django/django/pull/3575 * https://github.com/django/django/pull/3557 --Berker -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAF4280KvJRG5V5E6e%2BLOk7nL%3DHjKOFWYD8-bbfBCZ769o4GsHA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
Fellow Report: Nov 30, 2014
Hi all, Here is this week's report. You can see a more readable version of this report at https://code.djangoproject.com/wiki/DjangoFellows/BerkerPeksag#Weekof2014-11-24 Pull requests -- Authored ^ * https://github.com/django/django/pull/3628 -- Removed redundant numbered parameters from str.format(). * [Committed] https://github.com/django/django/pull/3629 -- Fixed #23847 -- Improved the email_check example. Commit: https://github.com/django/django/commit/87bd13617c57a806deb550e3af1c06ce00517a9c * [Committed] https://github.com/django/django/pull/3632 -- Refs #21587 -- Corrected deprecation warnings for RedirectView. Commit: https://github.com/django/django/commit/47789410dbf351fd17a7854492b7b5b99a66bb1c * [Committed] https://github.com/django/django/pull/3644 -- Fixed #17890 -- Added a extra_context parameter to AdminSite.password_change(). Commit: https://github.com/django/django/commit/c8dcded930a1d0ee5688ae2c2eeb8c33d942009f * https://github.com/django/django/pull/3645 -- Fixed #23922 -- Corrected parsing of URLs containing a # char in RequestFactory. >From the last week's pull requests * Fixed #13694 -- Made SafeMIMEText's constructor compatible with MIMEText: https://github.com/django/django/commit/a5bd7f2cb2ce6d9cf309748be0fe033b836c4507 * Fixed #21587 -- Added a warning for changing default of RedirectView.permanent: https://github.com/django/django/commit/9a30acad8a1996c914351bad981d937de4db29a4 * Fixed #14664 -- Logged a warning if MiddlewareNotUsed is raised in DEBUG mode: https://github.com/django/django/commit/093e6c68b9b5afdf1f059a2321affc999763e919 Code reviews -- * https://code.djangoproject.com/ticket/23900#comment:3 * https://github.com/django/django/pull/3613 * https://github.com/django/django/pull/3528 * https://github.com/django/django/commit/056a3c6c374f15e23746ea8568cd5b11bfe7d442 * https://github.com/django/django/pull/3624 * https://github.com/django/django/pull/3630 * https://github.com/django/django/pull/3626 * https://github.com/django/django/pull/3649 Issues - * #23922: Quoting problem in RequestFactory -- https://code.djangoproject.com/ticket/23922 * #23930: Add context managers for capturing output (testing utils)https://code.djangoproject.com/ticket/23930 --Berker -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAF4280LTPwOnF4wTb8%2B%3D12By4pTckS2WzP2pDVxnOQqWbXqmQQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
Fellow Report: Dec 7, 2014
Hi all,
Here is this week's report. You can see a more readable version of
this report at
https://code.djangoproject.com/wiki/DjangoFellows/BerkerPeksag#Weekof2014-12-01
Pull requests
= Authored =
* [Committed] https://github.com/django/django/pull/3671 -- Fixed "no
such test method" error in template_tests.
Commit:
https://github.com/django/django/commit/adacbd64a062662f54d6e91dc4e460eff96b5dd5
* https://github.com/django/django/pull/3706 -- Added a "htmlview" target.
= From last week =
*
https://github.com/django/django/commit/560b4207b1490a7d0cbf70cfbeba7daf2082e5be
-- Removed redundant numbered parameters from str.format().
Code reviews
* https://github.com/django/django/pull/3663 -- Fixed incorrect use of
rst section heirarchy in form fields docs.
* https://github.com/django/django/pull/3660 -- Fixed #23913 --
Deprecation of `=` comparison in `if` template tag.
* https://github.com/django/django/pull/3664 -- Fixed #23946 -
Runserver command socket error decoded to utf-8.
* https://github.com/django/django/pull/3673 -- Added a test to verify
headers set by default middleware; refs #23939
* https://github.com/django/django/pull/3638 -- Refactored
order_with_respect_to tests Refs #18586
* https://github.com/django/django/pull/3688 -- Fixed #23955 - remove
{{ form.id }} and add {{ form.pubdate }} field
* https://github.com/django/django/pull/3700 -- Fixed #23405 - Fixed
asking for default value for `CharField` and `TextField` in
migrations.
* https://github.com/django/django/pull/3701 -- Fixed #23968 --
Replace list comprehension with generator comprehension when possible
Tracker activity
* https://code.djangoproject.com/ticket/23768#comment:11
* https://code.djangoproject.com/ticket/23768#comment:12
* https://code.djangoproject.com/ticket/23944#comment:4
* https://code.djangoproject.com/ticket/23768
* https://code.djangoproject.com/ticket/23751
Please see
https://code.djangoproject.com/timeline?from=12%2F08%2F14&daysback=7&authors=berkerpeksag&changeset=on&ticket=on&ticket_details=on&sfp_email=&sfph_mail=&update=Update
for full report.
--Berker
--
You received this message because you are subscribed to the Google Groups
"Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-developers/CAF4280L-sEFFH_-YvNRYboXBBn6rS4RamTwHku1dFd1yEnczxA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Fellow Report: Dec 14, 2014
Hi all, Here is this week's report. You can see a more readable version of this report at https://code.djangoproject.com/wiki/DjangoFellows/BerkerPeksag#Weekof2014-12-07 Pull requests = Authored = * https://github.com/django/django/pull/3710 -- Fixed #23884 -- Moved FlatPageSitemap into django.contrib.flatpages. = Revised = * https://github.com/django/django/pull/3227 -- Fixed #23497 -- Made admin system checks run for custom AdminSites. New pull request: https://github.com/django/django/pull/3728 * https://github.com/django/django/pull/1979 -- Fixed #16501 -- Added a unicode parameter to models.SlugField and forms.SlugField. New pull request: https://github.com/django/django/pull/3729 = Review in progress = * https://github.com/django/django/pull/3609 -- Fixed #12982 -- Added a ``get_or_set`` method to the BaseCache backend. * https://github.com/django/django/pull/3710 -- Fixed #23884 -- Moved FlatPageSitemap into django.contrib.flatpages. = From last week = * https://github.com/django/django/commit/b327a614eb7d885441c6a2575e10b70ac1352aae -- Added an "htmlview" target to open docs after building them. Code reviews * https://github.com/django/django/pull/3713 -- Fixed #23977 -- Added setdefault method to HttpResponse * https://github.com/django/django/pull/3721 -- Fixed #23986 -- clear_dir no longer fails if dir doesn't exist * https://github.com/django/django/pull/2290 -- Fixed #21183 -- Filter block on the right covers information in admin Tracker activity Please see https://code.djangoproject.com/timeline?from=12%2F15%2F14&daysback=7&authors=berkerpeksag&changeset=on&ticket=on&ticket_details=on&sfp_email=&sfph_mail=&update=Update for full report. --Berker -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAF4280KvQz9505ebXX1s2%3DMeJf41H1Em02uXDgnV_e4Lfkr2jg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
Vendoring XRegexp
While I'm working on #3729 [1], I had to update current regexes to match unicode codepoints. Unfortunately, JavaScript has no proper support for unicode character classes, so writing unicode aware regex is a bit difficult: http://stackoverflow.com/a/280762 I would like to add XRegexp to django.contrib.admin. It's a popular, well tested and small library. It will only be imported if you pass ``unicode=True`` to SlugField and define ``prepopulated_fields`` in a ModelAdmin. [1] https://github.com/django/django/pull/3729 --Berker -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAF4280KA9FvC082bySLnDCcUQOyJ0nJ5nXJhnO3U6Hy%2BMVVbxQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
Fellow Report: Dec 21, 2014
Hi all, Here is this week's report. You can see a more readable version of this report at https://code.djangoproject.com/wiki/DjangoFellows/BerkerPeksag#Weekof2014-12-14 Pull requests = Authored = * https://github.com/django/django/pull/3759 = In progress = * https://github.com/django/django/pull/3729 -- Fixed #16501 -- Added a unicode parameter to models.SlugField and forms.SlugField. * I also created a thread for #3729 on django-developers: https://groups.google.com/forum/#!topic/django-developers/1G_axjxHnQc = From last week = * https://github.com/django/django/commit/9aeb917dad2c3d4c2830f38d3bfc63699e0ba837 -- Fixed #23884 -- Moved FlatPageSitemap into django.contrib.flatpages. * [Revised] https://github.com/django/django/commit/b7219c7ba5fdfbf9349948b5a91af50e32822ee6 -- Fixed #23497 -- Made admin system checks run for custom AdminSites. Code reviews * https://github.com/django/django/pull/3731 * https://github.com/django/django/pull/3737 * https://github.com/django/django/pull/3652 -- Fixed #5986 -- Override default field order * https://github.com/django/django/pull/3762 -- Fixed #22295 -- Replaced permission check for displaying user-tools * https://github.com/django/django/pull/2667 -- Fixed #22634 -- Changed Session and SessionStore to be easily extendable Tracker Activity * https://code.djangoproject.com/ticket/23986#comment:7 -- Collectstatic --clear fails if the static dir doesn't exist yet * https://code.djangoproject.com/ticket/23993#comment:1 -- Default admin login.html form doesn't respect custom AuthenticationForm Media assets. Please see https://code.djangoproject.com/timeline?from=12%2F21%2F14&daysback=7&authors=berkerpeksag&changeset=on&ticket=on&ticket_details=on&sfp_email=&sfph_mail=&update=Update for full report. --Berker -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAF4280J3_vFL6umJsX8c%3Df%2BE_uVpS5nTcRSHKa3hjaYmDMjq6g%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
Fellow Report: Dec 28, 2014
Hi all, Here is this week's report. You can see a more readable version of this report at https://code.djangoproject.com/wiki/DjangoFellows/BerkerPeksag#Weekof2014-12-21 Pull requests = Authored = * https://github.com/django/django/pull/3804 -- Converted middleware tests to use RequestFactory. = In progress = * https://github.com/django/django/pull/3467 -- Fixed #21429 -- Added builtin logging support to BaseCommand. = Closed = * https://github.com/django/django/pull/3645 Code reviews * https://github.com/django/django/pull/3772 -- Fixed #23959 -- Added topic about system checks in deployment * https://github.com/django/django/pull/3771 -- Fixed #24036 -- Added ignore_warnings decorator * https://github.com/django/django/pull/3789 -- Fixed #23866 -- Harmonized refs to Django documentation from code * https://github.com/django/django/pull/3781 -- Fixed #24008 -- ValidationError crashes with list of dicts * https://github.com/django/django/pull/3797 -- Fixed #24055 -- Keep reference to view class for resolve() * https://github.com/django/django/pull/3801 -- Fixed #20488 -- Added copy and move methods to the storage API `django-users` replies * https://groups.google.com/forum/#!topic/django-users/FWwqPNJbAMA Tracker Activity Please see https://code.djangoproject.com/timeline?from=12%2F31%2F14&daysback=7&authors=berkerpeksag&changeset=on&ticket=on&ticket_details=on&sfp_email=&sfph_mail=&update=Update for full report. --Berker -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAF4280JRsE8nfqSHy%3DAiLZXpEHFjN0hikHgv9H52j%2Bi84TbtPQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
Fellow Report: Jan 4, 2015
Hi all, Here is this week's report. You can see a more readable version of this report at https://code.djangoproject.com/wiki/DjangoFellows/BerkerPeksag#Weekof2014-12-30 Pull requests = Authored = * https://github.com/django/django/pull/3819 -- Ignored warnings correctly in test_get_formsets_with_inlines_returns_tuples. Commit: https://github.com/django/django/commit/32ca159c96339b4856837d7abec376a575ec44ab * https://github.com/django/django/pull/3833 -- Removed formtools entries from MANIFEST.in. Commit: https://github.com/django/django/commit/83dd70b927f962976737f9ba7d616fbcf359 = In progress = * https://github.com/django/django/pull/3467 -- Fixed #21429 -- Added builtin logging support to BaseCommand. Updates: - "assertLogs" backported from Python 3.4 - Most of the builtin commands ported to use the new logging API Code reviews * https://github.com/django/django/pull/3823 -- Removed double newline from output of migrate --list * https://github.com/django/django/pull/3815 -- Fixed #24063 -- Locale code validation too strict * https://github.com/django/django/pull/3829 -- Updated six to 1.9.0. * https://github.com/django/django/pull/3832 -- Fixed #23861 -- Added an API to deprecate model fields. * https://github.com/django/django/pull/3828 -- Fixed #8280 -- Allowed management command discovery for eggs * https://github.com/django/django/pull/3831 -- Fixed #23940 -- Added checks for 'exact' fieldnames --Berker -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAF4280Ld3Q4adbzcx5cXaaCt4mfhbWj018DTvV3vr5%2BJYY%3D_iQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
Fellow Report: Jan 11, 2015
Hi all, Here is this week's report. You can see a more readable version of this report at https://code.djangoproject.com/wiki/DjangoFellows/BerkerPeksag#Weekof2015-01-05 Pull requests = In progress = * https://github.com/django/django/pull/3467 -- Fixed #21429 -- Added builtin logging support to BaseCommand. * https://github.com/django/django/pull/3815 -- Fixed #24063 -- Locale code validation too strict * https://github.com/django/django/pull/3729 -- Fixed #16501 -- Added a unicode parameter to models.SlugField and forms.SlugField. Code reviews * https://github.com/django/django/pull/3846 -- Fixed #24022 -- Deprecated the ssi tag. * https://github.com/django/django/pull/3850 -- Fixed null handling in Value expression * https://github.com/django/django/pull/3369 -- Fixed #9893 -- Filename could exceed max_length on a collision * https://github.com/django/django/pull/3876 * [Inline patch] https://code.djangoproject.com/ticket/24105#comment:2 * https://github.com/mathspace/django/commit/0d09e379aa983c95b357ce4e54dd298f6725f3ef -- Fixed #24097 -- Python3 AttributeError with redirect_to_login and lazy LOGIN_URL [Full patch at https://github.com/mathspace/django/compare/error-lazylogin-master] * https://github.com/django/django/pull/3887 -- Fixed #23913 -- Deprecated the `=` comparison in `if` template tag. * https://github.com/django/django/pull/3847 -- Fixed #23712 -- Fixed KeyError with BaseForm._html_output() * https://github.com/django/django/pull/3885 -- Fixed #24118 -- Added --debug-sql option for tests. Tracker Activity * https://code.djangoproject.com/ticket/24121#comment:2 Please see https://code.djangoproject.com/timeline?from=01%2F12%2F2015&daysback=8&authors=berkerpeksag&changeset=on&ticket=on&ticket_details=on&sfp_email=&sfph_mail=&update=Update for full report. --Berker -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAF4280KSZMWbN_yfXJL-wG5azyVbKHqobEuecUWnnu4R4RQegw%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
Fellow Report: Jan 18, 2015
Hi all, Here is this week's report. You can see a more readable version of this report at https://code.djangoproject.com/wiki/DjangoFellows/BerkerPeksag#Weekof2015-01-12 Code reviews * https://github.com/django/django/pull/3908 -- Fixed #24145 -- Changed POST redirect error to be raised on PUT and PATCH too * https://github.com/django/django/pull/3852 -- Possible fix for django bug #21231. * https://github.com/django/django/pull/3902 -- Fixed #24137 -- Use default reason phrases from HTTP standard. * https://github.com/django/django/pull/2714 -- Fixed #20081 -- Minimized risk of SECRET_KEY leak. * https://github.com/django/django/pull/3145 -- Ticket #22990 sensitive post * https://github.com/django/django/pull/2648 -- Fixed #22617 -- Improved makemessages error reporting * https://github.com/django/django/pull/2562 -- Fixed #21987 -- Add support for custom MEDIA_TYPES to Media objects. * https://github.com/django/django/pull/3907 -- Fixed #24143 - Changed Http404 usages in docs to use instantiated versions * https://github.com/django/django/pull/3566 -- Fixed #23860 -- Document imports order convention. * https://github.com/django/django/pull/3793 -- Fixed #22728 - Prohibited lookups usage for get_or_create * https://github.com/django/django/pull/3935 -- Cleaned up migration writer tests * https://github.com/django/django/pull/3934 -- Removed some compatibility bits for Python 3.2. * https://github.com/django/django/pull/3937 -- Fixed #24165 -- Added request.messages * https://github.com/django/django/pull/3942 -- Fixed #18773 -- Add logging for template variable resolving Tracker Activity * Cookie HttpOnly attribute does not use suggested case-style of HTTP standard -- https://code.djangoproject.com/ticket/24153#comment:2 Please see https://code.djangoproject.com/timeline?from=01%2F18%2F2015&daysback=7&authors=berkerpeksag&changeset=on&ticket=on&ticket_details=on&sfp_email=&sfph_mail=&update=Update for full report. --Berker -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAF4280%2BQz%3DQFw4VURAUm1RxRqh_v5MTAYwh1EapUmBhLppnK2Q%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
Re: SSL support for Django-admin runserver
On Mon, May 11, 2015 at 4:34 PM, Tim Graham wrote: > Hi Steven, > > I'm in favor of trying to switch runserver to use gunicorn instead of > expanding the functionality of our own homegrown webserver > (https://code.djangoproject.com/ticket/21978). Windows support still remains > an unsolved issue (https://github.com/benoitc/gunicorn/issues/524), but I > don't think the lack of Windows support should stall that effort or justify > adding SSL support to the homegrown runserver. https://github.com/benoitc/gunicorn/issues/935 is another smail blocker for Gunicorn integration, but there is already a solution in the issue. --Berker -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAF4280JDtRsMMbXzaEcQV%2B0cQ%2BfWiUdZFvkxaf4rc%2BcsR0gnwQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
Re: how to deal with inspect.getargspec() deprecation?
On Wed, Jun 10, 2015 at 9:49 PM, Tim Graham wrote: > inspect.getargspec() was deprecated in Python 3.0 and will be removed in 3.6 > (ETA late 2016). It started throwing a deprecation warning in Python 3.5 > which causes some test failures when we check the number of deprecation > warnings so I'd like to deal with it now and avoid introducing more usages. > > Its replacement is inspect.signature() which is in all the versions of > Python 3 we support, but not 2.7. Options I see: > 1. Add a dependency for the funcsigs backport [1] (only needed on Python 2) > 2. Vendor funcsigs in django.utils (about 1k LOC) (this has been the > historical approach) > 3. Write different code for Python 2 & 3 funcsigs doesn't look like an up-to-date backport and we've fixed many bugs in inspect.signature() in recent releases. It might be safer to go with 3 (instead of adding an unmaintained dependency). --Berker -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAF4280%2BzmENf-_Zdaeno5676Srr3%2B7V7mPRWXPA2KVaLqzy4Gw%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
Re: naming of a new test client method for logging in
On Tue, Jun 30, 2015 at 4:38 PM, Tim Graham wrote: > There's a proposal [1] to add a new method to the test client that works > like login(), but skips the authentication (no credentials need to be > provided) and verification (is_active=False can login) steps. The signature > is (user, backend=None). What would you name this method? > > Proposals so far: > * force_login() (since this method bypasses authentication and other checks > login() has) +1 for force_login() --Berker -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAF4280KNLaH6fdBrOQ3U6kRidhMeo%2B1iEpZeHKNJ9_r%2B4f46KA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
Re: should we close in-memory file-like objects (StringIO, BytesIO, etc.)?
On Fri, Jul 3, 2015 at 4:59 PM, Tim Graham wrote: > Andriy proposed a patch to close objects like StringIO and BytesIO in our > test suite [1]. I am not sure how much benefit this gives (frees "a few > bytes of RAM" according to [2]) and it seems to add a lot of verbosity. > Looking at Python's own test suite, it doesn't appear these objects are > closed there (I spot checked BytesIO and StringIO). Any thoughts on this? I agree with you on the StringIO and BytesIO cases, but I agree with Andriy on the other usages (e.g. ZipFile, GzipFile). Many contributors follow the existing practices to write new tests, so it would be nice to use best practices if they don't produce too much noise. --Berker -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAF4280KRmDBLm%2BKMywDHsvajOMNq0th%2BhHrt77LV%2BQStNRx4zQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
Re: UTF-8 name of a staticfiles test is breaking Django installation
On Tue, Aug 2, 2016 at 6:14 PM, Tim Graham wrote: > A similar report was https://code.djangoproject.com/ticket/24761. I'm not > sure if this is a bug in those install tools or if it's something we should > try to fix in Django. You can use `git blame > tests/staticfiles_tests/apps/test/static/test/⊗.txt` to find the commit > where the file was introduced to learn the reason for it. It looks like this is a bug in setuptools: https://github.com/pypa/setuptools/issues/709 --Berker -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAF4280%2BXA9%3DKDAE7CKrgCjY4ttq%2BkxG5VdXZk2p6KdUn5k8VWQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
Re: Struggling newbie
On Wed, Aug 24, 2016 at 11:12 PM, wrote: > I am running python3.4 with Django in virtualenv. When I execute python > manage.py runserver I continue to get "sqlite3.NotSupportedError: URIs not > supported", I have looked all around for posts that will point me to the > solution but have not located any to date. Can anyone provide me with clues > as to what I have messed up in the environment? You need to install SQLite 3.7.7 or newer to be able to pass uri=True to sqlite3.connect(). However, this list is for discussing the development of Django itself, please ask usage questions on django-users. --Berker -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAF4280Lk1xVxjZoCjRXrF1gf3GpkknwfA4JWg0RjphnDf9uExw%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
Looking for feedback on implementation of UserManager.with_perm()
https://github.com/django/django/pull/7153/ implements UserManager.with_perm() [1] as: def with_perm(self, perm): for backend in auth.get_backends(): if hasattr(backend, 'with_perm'): return backend.with_perm(perm) return self.get_queryset().none() [1] "Shortcut to get users by permission": https://code.djangoproject.com/ticket/18763 With this implementation, users of UserManager.with_perm() won't get users with permissions for all backends. Also, result of UserManager.with_perm() will depend on the order of settings.AUTHENTICATION_BACKENDS. See also https://code.djangoproject.com/ticket/18763#comment:9 for more information about the current strategy. I suggested an alternative approach at https://github.com/django/django/pull/7153/files#r78226234 with the following implementation: def with_perm(self, perm, backend=None): if backend is None: backends = _get_backends(return_tuples=True) if len(backends) != 1: raise ValueError( 'You have multiple authentication backends configured and ' 'therefore must provide the `backend` argument.' ) _, backend = backends[0] if hasattr(backend, 'with_perm'): return backend.with_perm(perm) else: backend = load_backend(backend) if hasattr(backend, 'with_perm'): return backend.with_perm(perm) return self.get_queryset().none() This also simulates what django.contrib.auth.login() does when multiple authentication backends are defined: https://github.com/django/django/blob/18c72d59e0807dae75ac2c34890d08c1e0972d0a/django/contrib/auth/__init__.py#L100 Tim suggested to get some feedback about possible use cases: "I'm not sure about the use cases. For example, someone might want to get users with permissions for all backends. It would be nice if we had some feedback about what users are implementing on their own to confirm we're targeting the largest use case." Is there any other possible use cases? Which one of the suggested approaches cover the largest use case? Thanks! --Berker -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAF4280%2BmaOn6m%2BcoHDDdhQaUGNfOvw_KSf%2BsnMEtc_EF-pRn6Q%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
Re: [feature request] including HttpResponse(status=204) as an HttpResponse subclasses
On Fri, Apr 7, 2017 at 9:54 AM, Adam Johnson wrote: > Personally I'd be in favour of adding such classes. It seems against the > batteries-included philosophy that Django does not provide all of the > standard codes as classes. I can never remember which codes correspond to > which response types, if I saw status=204 in code it would be a 'magic > number' for me and I'd have to look it up. HttpResponseRedirect and > HttpResponsePermanentRedirect have been my friends in the past, I can > imagine the same for HttpResponseNoContent. Alternatively, they can use the HTTPStatus enum from the stdlib if they are on Python 3.5+: from http import HTTPStatus HttpResponse(status=HTTPStatus.NO_CONTENT) --Berker -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAF4280K-fT8bRnc6fvpZj0RjuhK8b2-eSozMKEJMsPT0EinevQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
Re: Proposal to format Django using black
On Sat, Apr 13, 2019 at 9:19 PM Tobias McNulty wrote: > Overall, the main downside I see is the large, fairly useless changeset this > would create and the impact it would have, such as reduced utility of `git > blame` for some portion of the code for the foreseeable future and > interruption to all in-progress PRs. Problems that can be worked around, > sure, but it would be an interruption to ongoing work nonetheless. I came here to say exactly this. Django's codebase is already pretty consistent with its own style and I think having a usable "git blame" is much more important than starting to use a new code formatter. IMO, with a codebase as big as Django, trying to adapt a different style guide would only cause unnecessary code churn. The following style is much more readable (and it also makes future diffs less noisy since we can add new formats without having reformat code and comments) than black-formatted code: TIME_INPUT_FORMATS = [ '%H:%M:%S', # '14:30:59' '%H:%M:%S.%f', # '14:30:59.000200' '%H:%M', # '14:30' ] Reformatted by black: TIME_INPUT_FORMATS = ['%H:%M:%S', '%H:%M:%S.%f', '%H:%M'] # '14:30:59' # '14:30:59.000200' # '14:30' (Taken from https://github.com/hermansc/django/pull/2/files#diff-ba8335f5987fcd81d41c28cd1879a9bfL370) (Also, thank you for creating PRs with different black configurations, Herman.) --Berker -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAF4280%2BB9k0Nymm4Oq%3DxnGe0gnZCzx2cDs3-esEBxDp2W9P-bg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
Re: Proposal to format Django using black
On Sun, Apr 14, 2019 at 1:34 AM Carlton Gibson wrote: > > We spend a lot of time spotting small formatting errors and then asking for > those to be fixed and then waiting for an update. This wastes reviewer time > and slows down the feedback cycle. Many pull requests drag out because of it. But you can now do final edits (cosmetic changes, tweak reST markup and documentation) via GitHub UI, right? I always do it to not bother contributors with these changes, especially if they are new to the project. --Berker -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAF4280J%2B6J1BJAto1MHd8mo5X%2Bm4AohSqS2HQr3yNXh1WOUcRQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
Re: Proposal to format Django using black
On Sun, Apr 14, 2019 at 1:06 PM Florian Apolloner wrote: > This is imo not something that scales well. Also it is not something I want > to pay our fellows for, I rather have them use their time on something else. > It is true that it is probably easier and faster to just fix code instead of > back & forth with the contributor, but the main argument for me here is that > this is work that shouldn't be needed in the first place. True, having an automated code formatter would definitely help to save reviewer a bit time. However, Django has already flake8 checker on GitHub, which would already help a contributor to fix biggest inconsistencies in their PR. Note that my point in my earlier email was that there are more minor details than just cosmetic fixes and unfortunately you can't automatically fix all of them :) So, a final round of edits still needed. I've used git-hyper-blame before. Most of the time you need to manually collect all "mass cleanup" commits in a file (and you need to maintain that file separately) It's also not easy to integrate it with your workflow especially if you're using "git blame" from your IDE of choice. --Berker -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAF4280LX-m8PiKC1bEQz%3DX9nS32BZ9Wb0NR1-UUpRY6CLgxqng%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
