Re: [E-devel] {Spam?} [offtopic]
On Thu, 24 Jan 2008, Mike Frysinger wrote:
> can you please fix your e-mail/isp/whatever sucks ... this {Spam?} in the
> subject is ridiculous
Yes, it's ridiculous and no i can't. It's the server of my university
that add it. I can tell them that it's ridiculous, if you want.
Vincent
-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] {Spam?} [offtopic]
On Thursday 24 January 2008, Vincent Torri wrote:
> On Thu, 24 Jan 2008, Mike Frysinger wrote:
> > can you please fix your e-mail/isp/whatever sucks ... this {Spam?} in the
> > subject is ridiculous
>
> Yes, it's ridiculous and no i can't. It's the server of my university
> that add it.
there are plenty of free e-mail services out there without retarded setups.
gmail does pop/imap and transparent forwarding.
> I can tell them that it's ridiculous, if you want.
you should
-mike
signature.asc
Description: This is a digitally signed message part.
-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E17 under OpenBSD and other goodies.
Hi,
First off, i am not trying to push these patches, i was asked on IRC
to post them with some comments.
I did so.
On Jan 23, 2008 7:45 AM, Mike Frysinger <[EMAIL PROTECTED]> wrote:
> On Wednesday 23 January 2008, laurent FANIS wrote:
> > --- src/lib/eet_lib.c.orig Mon Nov 12 11:14:04 2007
> > +++ src/lib/eet_lib.c Mon Nov 12 11:15:11 2007
> > @@ -497,6 +497,10 @@ eet_open(const char *file, Eet_File_Mode mode)
> > else
> > return NULL;
> > }
> > + else if (file_stat.st_size == 0)
> > + {
> > + return NULL;
> > + }
> >
> > /* We found one */
> > if (ef && (file_stat.st_mtime != ef->mtime))
>
> should be an issue on all systems ... could you elaborate on what this fixes ?
> if you look up a few lines, there's already a stat size check.
>
> > Warnings:
> > Four warnings:about "HAVE_STDLIB_H" being redefined.
>
> *when* and *where* ... please post real build errors instead of describing
> them in snippets which lack context
>
Will do as soon as i have some free time.
> > Two warning about unsafe function : strcpy and sprintf instead of
> > strlcpy and snprintf
>
> all of these strl* warnings are bsd-specific obviously as they are
> bsd-specific functions
>
For future reference i did not checked all the functions, and i did
not patch them. And yeah usually the OpenBSD gcc-local bitches about
unsafe functions.
> > --- configure.in.orig Wed Dec 5 22:13:29 2007
> > +++ configure.inWed Dec 5 22:13:42 2007
> > @@ -31,7 +31,7 @@ AC_SUBST(version_info)
> >
> > AC_FUNC_ALLOCA
> >
> > -MODULE_ARCH="$host_os-$host_cpu"
> > +MODULE_ARCH=""
> > AC_SUBST(MODULE_ARCH)
> > AC_DEFINE_UNQUOTED(MODULE_ARCH, "$MODULE_ARCH", "Module architecture")
> >
>
> ugh, this cant possibly be correct. can you explain what you're trying to
> fix. same goes for all the configure scripts you modified like this.
>
This is to be able to update cleanly the packages from one release to
another, this is OpenBSD specific.
> > --- src/lib/include/evas_common.h.orig Fri Dec 7 10:34:46 2007
> > +++ src/lib/include/evas_common.h Fri Dec 7 10:34:59 2007
> > @@ -46,6 +46,7 @@
> > #include
> > #include
> > #include
> > +#include
> > #include
> > #include
> > #include
>
> stdint.h should be everywhere ;)
>
It wasn't here and the compiler choked.
> > and:a couple of warnings about "HAVE_STDLIB_H" being redefined in the
> > jpg folder.
>
> that is a bug with libjpeg, not e17
>
Yep.
> > In ecore:
> > It seems ecore does not respect :--disable-ecore-evas-sdl
> > --disable-ecore-sdl and still links to SDL if it exist, can someone
> > please test this under linux.
>
> there is no --disable-ecore-sdl option ... maybe that is why it doesnt work
> for you ;)
>
It didn't work on my test machine and i wanted some feedback from
other users as i do not have a linux machine to test it.
> > In edje:
> > edje_data.c: In function `_edje_edd_setup':
> > edje_data.c:70: warning: assignment from incompatible pointer type
> > edje_data.c:72: warning: assignment from incompatible pointer type
> > edje_data.c:73: warning: assignment from incompatible pointer type
> > edje_data.c:74: warning: assignment from incompatible pointer type
> > edje_data.c:75: warning: assignment from incompatible pointer type
> > edje_data.c:76: warning: assignment from incompatible pointer type
> > edje_data.c:77: warning: assignment from incompatible pointer type
> > edje_data.c:78: warning: assignment from incompatible pointer type
>
> looks like simple prototype desyncs ... should be fixed, but shouldnt be a
> serious problem
>
It is not.
> > In E:
> > --- src/bin/Makefile.am.origFri Nov 9 16:20:53 2007
> > +++ src/bin/Makefile.am Fri Nov 9 16:21:15 2007
> > @@ -345,7 +345,7 @@ e_xinerama.c
> >
> > enlightenment_init_LDFLAGS = @e_libs@
> >
> > -setuid_root_mode = a=rx,u+xs
> > +setuid_root_mode = a=rx,u+x
> > install-exec-hook:
> > @chmod $(setuid_root_mode)
> > $(DESTDIR)$(bindir)/enlightenment_sys$(EXEEXT) || true
>
> clearly this is not correct.
>
In the port system we do not install anything with setuid root. If the
user wants it then the user has to manually update it.
> > --- src/bin/e_fm.c.orig Wed Nov 7 11:45:43 2007
> > +++ src/bin/e_fm.c Fri Dec 7 15:44:09 2007
> > @@ -104,7 +104,7 @@ struct _E_Fm2_Smart_Data
> > E_Drop_Handler *drop_handler;
> > E_Fm2_Icon *drop_icon;
> > E_Fm2_Mount*mount;
> > - chardrop_after;
> > + signed char drop_after;
> > unsigned char drop_show : 1;
> > unsigned char drop_in_show : 1;
> > unsigned char drop_all : 1;
>
> either everything should be "char" or not ... inserting "signed" here without
> an explanation as to why doesnt seem like a good idea.
>
This fixes macppc.
> > @@ -3214,7 +3214,7 @@ _e_fm2_uri_parse(const char *val)
> > p = val + 7;
> > if (*p != '/')
> > {
> > - for (i = 0; *p != '/' && *p != '\0' && i <
> >
[E-devel] Nightly build log for E17 on 2008-01-24 01:30:27 -0800
Build log for Enlightenment DR 0.17 on 2008-01-24 01:30:27 -0800 Build logs are available at http://download.enlightenment.org/tests/logs Packages that failed to build: alarm http://download.enlightenment.org/tests/logs/alarm.log bling http://download.enlightenment.org/tests/logs/bling.log calendar http://download.enlightenment.org/tests/logs/calendar.log cpu http://download.enlightenment.org/tests/logs/cpu.log deskshow http://download.enlightenment.org/tests/logs/deskshow.log echo http://download.enlightenment.org/tests/logs/echo.log eclair http://download.enlightenment.org/tests/logs/eclair.log edje_editor http://download.enlightenment.org/tests/logs/edje_editor.log edje http://download.enlightenment.org/tests/logs/edje.log edje_viewer http://download.enlightenment.org/tests/logs/edje_viewer.log edvi http://download.enlightenment.org/tests/logs/edvi.log eflpp http://download.enlightenment.org/tests/logs/eflpp.log efm_nav http://download.enlightenment.org/tests/logs/efm_nav.log efm_path http://download.enlightenment.org/tests/logs/efm_path.log elapse http://download.enlightenment.org/tests/logs/elapse.log elation http://download.enlightenment.org/tests/logs/elation.log elicit http://download.enlightenment.org/tests/logs/elicit.log elitaire http://download.enlightenment.org/tests/logs/elitaire.log e http://download.enlightenment.org/tests/logs/e.log embrace http://download.enlightenment.org/tests/logs/embrace.log emotion http://download.enlightenment.org/tests/logs/emotion.log emphasis http://download.enlightenment.org/tests/logs/emphasis.log empower http://download.enlightenment.org/tests/logs/empower.log emprint http://download.enlightenment.org/tests/logs/emprint.log emu http://download.enlightenment.org/tests/logs/emu.log engage http://download.enlightenment.org/tests/logs/engage.log enhance http://download.enlightenment.org/tests/logs/enhance.log enity http://download.enlightenment.org/tests/logs/enity.log enna http://download.enlightenment.org/tests/logs/enna.log entrance_edit_gui http://download.enlightenment.org/tests/logs/entrance_edit_gui.log entrance http://download.enlightenment.org/tests/logs/entrance.log entropy http://download.enlightenment.org/tests/logs/entropy.log envision http://download.enlightenment.org/tests/logs/envision.log epdf http://download.enlightenment.org/tests/logs/epdf.log ephoto http://download.enlightenment.org/tests/logs/ephoto.log epsilon http://download.enlightenment.org/tests/logs/epsilon.log equate http://download.enlightenment.org/tests/logs/equate.log esmart http://download.enlightenment.org/tests/logs/esmart.log estickies http://download.enlightenment.org/tests/logs/estickies.log etk_extra http://download.enlightenment.org/tests/logs/etk_extra.log etk http://download.enlightenment.org/tests/logs/etk.log etk-perl http://download.enlightenment.org/tests/logs/etk-perl.log evfs http://download.enlightenment.org/tests/logs/evfs.log evolve http://download.enlightenment.org/tests/logs/evolve.log ewl http://download.enlightenment.org/tests/logs/ewl.log examine http://download.enlightenment.org/tests/logs/examine.log execwatch http://download.enlightenment.org/tests/logs/execwatch.log exhibit http://download.enlightenment.org/tests/logs/exhibit.log express http://download.enlightenment.org/tests/logs/express.log exquisite http://download.enlightenment.org/tests/logs/exquisite.log extrackt http://download.enlightenment.org/tests/logs/extrackt.log flame http://download.enlightenment.org/tests/logs/flame.log forecasts http://download.enlightenment.org/tests/logs/forecasts.log gevas2 http://download.enlightenment.org/tests/logs/gevas2.log iconbar http://download.enlightenment.org/tests/logs/iconbar.log language http://download.enlightenment.org/tests/logs/language.log mail http://download.enlightenment.org/tests/logs/mail.log mem http://download.enlightenment.org/tests/logs/mem.log mixer http://download.enlightenment.org/tests/logs/mixer.log moon http://download.enlightenment.org/tests/logs/moon.log mpdule http://download.enlightenment.org/tests/logs/mpdule.log net http://download.enlightenment.org/tests/logs/net.log news http://download.enlightenment.org/tests/logs/news.log notification http://download.enlightenment.org/tests/logs/notification.log photo http://download.enlightenment.org/tests/logs/photo.log rage http://download.enlightenment.org/tests/logs/rage.log rain http://download.enlightenment.org/tests/logs/rain.log screenshot http://download.enlightenment.org/tests/logs/screenshot.log slideshow http://download.enlightenment.org/tests/logs/slideshow.log snow http://download.enlightenment.org/tests/logs/snow.log taskbar http://download.enlightenment.org/tests/logs/taskbar.log tclock http://download.enlightenment.org/tests/logs/tclock.log uptime http://download.enlightenment.org/tests/logs/uptime.log weather http://download.enlightenment.org/tests/logs/weather.log winselector http://download.enl
[E-devel] Nightly build log for E17 on 2008-01-24 01:30:32 -0800
Build log for Enlightenment DR 0.17 on 2008-01-24 01:30:32 -0800 Build logs are available at http://download.enlightenment.org/tests/logs Packages that failed to build: alarm http://download.enlightenment.org/tests/logs/alarm.log bling http://download.enlightenment.org/tests/logs/bling.log calendar http://download.enlightenment.org/tests/logs/calendar.log cpu http://download.enlightenment.org/tests/logs/cpu.log deskshow http://download.enlightenment.org/tests/logs/deskshow.log echo http://download.enlightenment.org/tests/logs/echo.log eclair http://download.enlightenment.org/tests/logs/eclair.log edje_editor http://download.enlightenment.org/tests/logs/edje_editor.log edje http://download.enlightenment.org/tests/logs/edje.log edje_viewer http://download.enlightenment.org/tests/logs/edje_viewer.log edvi http://download.enlightenment.org/tests/logs/edvi.log eflpp http://download.enlightenment.org/tests/logs/eflpp.log efm_nav http://download.enlightenment.org/tests/logs/efm_nav.log efm_path http://download.enlightenment.org/tests/logs/efm_path.log elapse http://download.enlightenment.org/tests/logs/elapse.log elation http://download.enlightenment.org/tests/logs/elation.log elicit http://download.enlightenment.org/tests/logs/elicit.log elitaire http://download.enlightenment.org/tests/logs/elitaire.log e http://download.enlightenment.org/tests/logs/e.log embrace http://download.enlightenment.org/tests/logs/embrace.log emotion http://download.enlightenment.org/tests/logs/emotion.log emphasis http://download.enlightenment.org/tests/logs/emphasis.log empower http://download.enlightenment.org/tests/logs/empower.log emprint http://download.enlightenment.org/tests/logs/emprint.log emu http://download.enlightenment.org/tests/logs/emu.log engage http://download.enlightenment.org/tests/logs/engage.log enhance http://download.enlightenment.org/tests/logs/enhance.log enity http://download.enlightenment.org/tests/logs/enity.log enna http://download.enlightenment.org/tests/logs/enna.log entrance_edit_gui http://download.enlightenment.org/tests/logs/entrance_edit_gui.log entrance http://download.enlightenment.org/tests/logs/entrance.log entropy http://download.enlightenment.org/tests/logs/entropy.log envision http://download.enlightenment.org/tests/logs/envision.log epdf http://download.enlightenment.org/tests/logs/epdf.log ephoto http://download.enlightenment.org/tests/logs/ephoto.log epsilon http://download.enlightenment.org/tests/logs/epsilon.log equate http://download.enlightenment.org/tests/logs/equate.log esmart http://download.enlightenment.org/tests/logs/esmart.log estickies http://download.enlightenment.org/tests/logs/estickies.log etk_extra http://download.enlightenment.org/tests/logs/etk_extra.log etk http://download.enlightenment.org/tests/logs/etk.log etk-perl http://download.enlightenment.org/tests/logs/etk-perl.log evfs http://download.enlightenment.org/tests/logs/evfs.log evolve http://download.enlightenment.org/tests/logs/evolve.log ewl http://download.enlightenment.org/tests/logs/ewl.log examine http://download.enlightenment.org/tests/logs/examine.log execwatch http://download.enlightenment.org/tests/logs/execwatch.log exhibit http://download.enlightenment.org/tests/logs/exhibit.log express http://download.enlightenment.org/tests/logs/express.log exquisite http://download.enlightenment.org/tests/logs/exquisite.log extrackt http://download.enlightenment.org/tests/logs/extrackt.log flame http://download.enlightenment.org/tests/logs/flame.log forecasts http://download.enlightenment.org/tests/logs/forecasts.log gevas2 http://download.enlightenment.org/tests/logs/gevas2.log iconbar http://download.enlightenment.org/tests/logs/iconbar.log language http://download.enlightenment.org/tests/logs/language.log mail http://download.enlightenment.org/tests/logs/mail.log mem http://download.enlightenment.org/tests/logs/mem.log mixer http://download.enlightenment.org/tests/logs/mixer.log moon http://download.enlightenment.org/tests/logs/moon.log mpdule http://download.enlightenment.org/tests/logs/mpdule.log net http://download.enlightenment.org/tests/logs/net.log news http://download.enlightenment.org/tests/logs/news.log notification http://download.enlightenment.org/tests/logs/notification.log photo http://download.enlightenment.org/tests/logs/photo.log rage http://download.enlightenment.org/tests/logs/rage.log rain http://download.enlightenment.org/tests/logs/rain.log screenshot http://download.enlightenment.org/tests/logs/screenshot.log slideshow http://download.enlightenment.org/tests/logs/slideshow.log snow http://download.enlightenment.org/tests/logs/snow.log taskbar http://download.enlightenment.org/tests/logs/taskbar.log tclock http://download.enlightenment.org/tests/logs/tclock.log uptime http://download.enlightenment.org/tests/logs/uptime.log weather http://download.enlightenment.org/tests/logs/weather.log winselector http://download.enl
[E-devel] Nightly build log for E17 on 2008-01-24 01:31:01 -0800
Build log for Enlightenment DR 0.17 on 2008-01-24 01:31:01 -0800 Build logs are available at http://download.enlightenment.org/tests/logs Packages that failed to build: alarm http://download.enlightenment.org/tests/logs/alarm.log bling http://download.enlightenment.org/tests/logs/bling.log calendar http://download.enlightenment.org/tests/logs/calendar.log cpu http://download.enlightenment.org/tests/logs/cpu.log deskshow http://download.enlightenment.org/tests/logs/deskshow.log echo http://download.enlightenment.org/tests/logs/echo.log eclair http://download.enlightenment.org/tests/logs/eclair.log edje_editor http://download.enlightenment.org/tests/logs/edje_editor.log edje http://download.enlightenment.org/tests/logs/edje.log edje_viewer http://download.enlightenment.org/tests/logs/edje_viewer.log edvi http://download.enlightenment.org/tests/logs/edvi.log eflpp http://download.enlightenment.org/tests/logs/eflpp.log efm_nav http://download.enlightenment.org/tests/logs/efm_nav.log efm_path http://download.enlightenment.org/tests/logs/efm_path.log elapse http://download.enlightenment.org/tests/logs/elapse.log elation http://download.enlightenment.org/tests/logs/elation.log elicit http://download.enlightenment.org/tests/logs/elicit.log elitaire http://download.enlightenment.org/tests/logs/elitaire.log e http://download.enlightenment.org/tests/logs/e.log embrace http://download.enlightenment.org/tests/logs/embrace.log emotion http://download.enlightenment.org/tests/logs/emotion.log emphasis http://download.enlightenment.org/tests/logs/emphasis.log empower http://download.enlightenment.org/tests/logs/empower.log emprint http://download.enlightenment.org/tests/logs/emprint.log emu http://download.enlightenment.org/tests/logs/emu.log engage http://download.enlightenment.org/tests/logs/engage.log enhance http://download.enlightenment.org/tests/logs/enhance.log enity http://download.enlightenment.org/tests/logs/enity.log enna http://download.enlightenment.org/tests/logs/enna.log entrance_edit_gui http://download.enlightenment.org/tests/logs/entrance_edit_gui.log entrance http://download.enlightenment.org/tests/logs/entrance.log entropy http://download.enlightenment.org/tests/logs/entropy.log envision http://download.enlightenment.org/tests/logs/envision.log epdf http://download.enlightenment.org/tests/logs/epdf.log ephoto http://download.enlightenment.org/tests/logs/ephoto.log epsilon http://download.enlightenment.org/tests/logs/epsilon.log equate http://download.enlightenment.org/tests/logs/equate.log esmart http://download.enlightenment.org/tests/logs/esmart.log estickies http://download.enlightenment.org/tests/logs/estickies.log etk_extra http://download.enlightenment.org/tests/logs/etk_extra.log etk http://download.enlightenment.org/tests/logs/etk.log etk-perl http://download.enlightenment.org/tests/logs/etk-perl.log evfs http://download.enlightenment.org/tests/logs/evfs.log evolve http://download.enlightenment.org/tests/logs/evolve.log ewl http://download.enlightenment.org/tests/logs/ewl.log examine http://download.enlightenment.org/tests/logs/examine.log execwatch http://download.enlightenment.org/tests/logs/execwatch.log exhibit http://download.enlightenment.org/tests/logs/exhibit.log express http://download.enlightenment.org/tests/logs/express.log exquisite http://download.enlightenment.org/tests/logs/exquisite.log extrackt http://download.enlightenment.org/tests/logs/extrackt.log flame http://download.enlightenment.org/tests/logs/flame.log forecasts http://download.enlightenment.org/tests/logs/forecasts.log gevas2 http://download.enlightenment.org/tests/logs/gevas2.log iconbar http://download.enlightenment.org/tests/logs/iconbar.log language http://download.enlightenment.org/tests/logs/language.log mail http://download.enlightenment.org/tests/logs/mail.log mem http://download.enlightenment.org/tests/logs/mem.log mixer http://download.enlightenment.org/tests/logs/mixer.log moon http://download.enlightenment.org/tests/logs/moon.log mpdule http://download.enlightenment.org/tests/logs/mpdule.log net http://download.enlightenment.org/tests/logs/net.log news http://download.enlightenment.org/tests/logs/news.log notification http://download.enlightenment.org/tests/logs/notification.log photo http://download.enlightenment.org/tests/logs/photo.log rage http://download.enlightenment.org/tests/logs/rage.log rain http://download.enlightenment.org/tests/logs/rain.log screenshot http://download.enlightenment.org/tests/logs/screenshot.log slideshow http://download.enlightenment.org/tests/logs/slideshow.log snow http://download.enlightenment.org/tests/logs/snow.log taskbar http://download.enlightenment.org/tests/logs/taskbar.log tclock http://download.enlightenment.org/tests/logs/tclock.log uptime http://download.enlightenment.org/tests/logs/uptime.log weather http://download.enlightenment.org/tests/logs/weather.log winselector http://download.enl
[E-devel] Nightly build log for E17 on 2008-01-24 01:31:01 -0800
Build log for Enlightenment DR 0.17 on 2008-01-24 01:31:01 -0800 Build logs are available at http://download.enlightenment.org/tests/logs Packages that failed to build: alarm http://download.enlightenment.org/tests/logs/alarm.log bling http://download.enlightenment.org/tests/logs/bling.log calendar http://download.enlightenment.org/tests/logs/calendar.log cpu http://download.enlightenment.org/tests/logs/cpu.log deskshow http://download.enlightenment.org/tests/logs/deskshow.log echo http://download.enlightenment.org/tests/logs/echo.log eclair http://download.enlightenment.org/tests/logs/eclair.log edje_editor http://download.enlightenment.org/tests/logs/edje_editor.log edje http://download.enlightenment.org/tests/logs/edje.log edje_viewer http://download.enlightenment.org/tests/logs/edje_viewer.log edvi http://download.enlightenment.org/tests/logs/edvi.log eflpp http://download.enlightenment.org/tests/logs/eflpp.log efm_nav http://download.enlightenment.org/tests/logs/efm_nav.log efm_path http://download.enlightenment.org/tests/logs/efm_path.log elapse http://download.enlightenment.org/tests/logs/elapse.log elation http://download.enlightenment.org/tests/logs/elation.log elicit http://download.enlightenment.org/tests/logs/elicit.log elitaire http://download.enlightenment.org/tests/logs/elitaire.log e http://download.enlightenment.org/tests/logs/e.log embrace http://download.enlightenment.org/tests/logs/embrace.log emotion http://download.enlightenment.org/tests/logs/emotion.log emphasis http://download.enlightenment.org/tests/logs/emphasis.log empower http://download.enlightenment.org/tests/logs/empower.log emprint http://download.enlightenment.org/tests/logs/emprint.log emu http://download.enlightenment.org/tests/logs/emu.log engage http://download.enlightenment.org/tests/logs/engage.log enhance http://download.enlightenment.org/tests/logs/enhance.log enity http://download.enlightenment.org/tests/logs/enity.log enna http://download.enlightenment.org/tests/logs/enna.log entrance_edit_gui http://download.enlightenment.org/tests/logs/entrance_edit_gui.log entrance http://download.enlightenment.org/tests/logs/entrance.log entropy http://download.enlightenment.org/tests/logs/entropy.log envision http://download.enlightenment.org/tests/logs/envision.log epdf http://download.enlightenment.org/tests/logs/epdf.log ephoto http://download.enlightenment.org/tests/logs/ephoto.log epsilon http://download.enlightenment.org/tests/logs/epsilon.log equate http://download.enlightenment.org/tests/logs/equate.log esmart http://download.enlightenment.org/tests/logs/esmart.log estickies http://download.enlightenment.org/tests/logs/estickies.log etk_extra http://download.enlightenment.org/tests/logs/etk_extra.log etk http://download.enlightenment.org/tests/logs/etk.log etk-perl http://download.enlightenment.org/tests/logs/etk-perl.log evfs http://download.enlightenment.org/tests/logs/evfs.log evolve http://download.enlightenment.org/tests/logs/evolve.log ewl http://download.enlightenment.org/tests/logs/ewl.log examine http://download.enlightenment.org/tests/logs/examine.log execwatch http://download.enlightenment.org/tests/logs/execwatch.log exhibit http://download.enlightenment.org/tests/logs/exhibit.log express http://download.enlightenment.org/tests/logs/express.log exquisite http://download.enlightenment.org/tests/logs/exquisite.log extrackt http://download.enlightenment.org/tests/logs/extrackt.log flame http://download.enlightenment.org/tests/logs/flame.log forecasts http://download.enlightenment.org/tests/logs/forecasts.log gevas2 http://download.enlightenment.org/tests/logs/gevas2.log iconbar http://download.enlightenment.org/tests/logs/iconbar.log language http://download.enlightenment.org/tests/logs/language.log mail http://download.enlightenment.org/tests/logs/mail.log mem http://download.enlightenment.org/tests/logs/mem.log mixer http://download.enlightenment.org/tests/logs/mixer.log moon http://download.enlightenment.org/tests/logs/moon.log mpdule http://download.enlightenment.org/tests/logs/mpdule.log net http://download.enlightenment.org/tests/logs/net.log news http://download.enlightenment.org/tests/logs/news.log notification http://download.enlightenment.org/tests/logs/notification.log photo http://download.enlightenment.org/tests/logs/photo.log rage http://download.enlightenment.org/tests/logs/rage.log rain http://download.enlightenment.org/tests/logs/rain.log screenshot http://download.enlightenment.org/tests/logs/screenshot.log slideshow http://download.enlightenment.org/tests/logs/slideshow.log snow http://download.enlightenment.org/tests/logs/snow.log taskbar http://download.enlightenment.org/tests/logs/taskbar.log tclock http://download.enlightenment.org/tests/logs/tclock.log uptime http://download.enlightenment.org/tests/logs/uptime.log weather http://download.enlightenment.org/tests/logs/weather.log winselector http://download.enl
[E-devel] Nightly build log for E17 on 2008-01-24 01:32:00 -0800
Build log for Enlightenment DR 0.17 on 2008-01-24 01:32:00 -0800 Build logs are available at http://download.enlightenment.org/tests/logs Packages that failed to build: alarm http://download.enlightenment.org/tests/logs/alarm.log bling http://download.enlightenment.org/tests/logs/bling.log calendar http://download.enlightenment.org/tests/logs/calendar.log cpu http://download.enlightenment.org/tests/logs/cpu.log deskshow http://download.enlightenment.org/tests/logs/deskshow.log echo http://download.enlightenment.org/tests/logs/echo.log eclair http://download.enlightenment.org/tests/logs/eclair.log edje_editor http://download.enlightenment.org/tests/logs/edje_editor.log edje http://download.enlightenment.org/tests/logs/edje.log edje_viewer http://download.enlightenment.org/tests/logs/edje_viewer.log edvi http://download.enlightenment.org/tests/logs/edvi.log eflpp http://download.enlightenment.org/tests/logs/eflpp.log efm_nav http://download.enlightenment.org/tests/logs/efm_nav.log efm_path http://download.enlightenment.org/tests/logs/efm_path.log elapse http://download.enlightenment.org/tests/logs/elapse.log elation http://download.enlightenment.org/tests/logs/elation.log elicit http://download.enlightenment.org/tests/logs/elicit.log elitaire http://download.enlightenment.org/tests/logs/elitaire.log e http://download.enlightenment.org/tests/logs/e.log embrace http://download.enlightenment.org/tests/logs/embrace.log emotion http://download.enlightenment.org/tests/logs/emotion.log emphasis http://download.enlightenment.org/tests/logs/emphasis.log empower http://download.enlightenment.org/tests/logs/empower.log emprint http://download.enlightenment.org/tests/logs/emprint.log emu http://download.enlightenment.org/tests/logs/emu.log engage http://download.enlightenment.org/tests/logs/engage.log enhance http://download.enlightenment.org/tests/logs/enhance.log enity http://download.enlightenment.org/tests/logs/enity.log enna http://download.enlightenment.org/tests/logs/enna.log entrance_edit_gui http://download.enlightenment.org/tests/logs/entrance_edit_gui.log entrance http://download.enlightenment.org/tests/logs/entrance.log entropy http://download.enlightenment.org/tests/logs/entropy.log envision http://download.enlightenment.org/tests/logs/envision.log epdf http://download.enlightenment.org/tests/logs/epdf.log ephoto http://download.enlightenment.org/tests/logs/ephoto.log epsilon http://download.enlightenment.org/tests/logs/epsilon.log equate http://download.enlightenment.org/tests/logs/equate.log esmart http://download.enlightenment.org/tests/logs/esmart.log estickies http://download.enlightenment.org/tests/logs/estickies.log etk_extra http://download.enlightenment.org/tests/logs/etk_extra.log etk http://download.enlightenment.org/tests/logs/etk.log etk-perl http://download.enlightenment.org/tests/logs/etk-perl.log evfs http://download.enlightenment.org/tests/logs/evfs.log evolve http://download.enlightenment.org/tests/logs/evolve.log ewl http://download.enlightenment.org/tests/logs/ewl.log examine http://download.enlightenment.org/tests/logs/examine.log execwatch http://download.enlightenment.org/tests/logs/execwatch.log exhibit http://download.enlightenment.org/tests/logs/exhibit.log express http://download.enlightenment.org/tests/logs/express.log exquisite http://download.enlightenment.org/tests/logs/exquisite.log extrackt http://download.enlightenment.org/tests/logs/extrackt.log flame http://download.enlightenment.org/tests/logs/flame.log forecasts http://download.enlightenment.org/tests/logs/forecasts.log gevas2 http://download.enlightenment.org/tests/logs/gevas2.log iconbar http://download.enlightenment.org/tests/logs/iconbar.log language http://download.enlightenment.org/tests/logs/language.log mail http://download.enlightenment.org/tests/logs/mail.log mem http://download.enlightenment.org/tests/logs/mem.log mixer http://download.enlightenment.org/tests/logs/mixer.log moon http://download.enlightenment.org/tests/logs/moon.log mpdule http://download.enlightenment.org/tests/logs/mpdule.log net http://download.enlightenment.org/tests/logs/net.log news http://download.enlightenment.org/tests/logs/news.log notification http://download.enlightenment.org/tests/logs/notification.log photo http://download.enlightenment.org/tests/logs/photo.log rage http://download.enlightenment.org/tests/logs/rage.log rain http://download.enlightenment.org/tests/logs/rain.log screenshot http://download.enlightenment.org/tests/logs/screenshot.log slideshow http://download.enlightenment.org/tests/logs/slideshow.log snow http://download.enlightenment.org/tests/logs/snow.log taskbar http://download.enlightenment.org/tests/logs/taskbar.log tclock http://download.enlightenment.org/tests/logs/tclock.log uptime http://download.enlightenment.org/tests/logs/uptime.log weather http://download.enlightenment.org/tests/logs/weather.log winselector http://download.enl
[E-devel] Nightly build log for E17 on 2008-01-24 01:33:40 -0800
Build log for Enlightenment DR 0.17 on 2008-01-24 01:33:40 -0800 Build logs are available at http://download.enlightenment.org/tests/logs Packages that failed to build: alarm http://download.enlightenment.org/tests/logs/alarm.log bling http://download.enlightenment.org/tests/logs/bling.log calendar http://download.enlightenment.org/tests/logs/calendar.log cpu http://download.enlightenment.org/tests/logs/cpu.log deskshow http://download.enlightenment.org/tests/logs/deskshow.log echo http://download.enlightenment.org/tests/logs/echo.log eclair http://download.enlightenment.org/tests/logs/eclair.log edje_editor http://download.enlightenment.org/tests/logs/edje_editor.log edje http://download.enlightenment.org/tests/logs/edje.log edje_viewer http://download.enlightenment.org/tests/logs/edje_viewer.log edvi http://download.enlightenment.org/tests/logs/edvi.log eflpp http://download.enlightenment.org/tests/logs/eflpp.log efm_nav http://download.enlightenment.org/tests/logs/efm_nav.log efm_path http://download.enlightenment.org/tests/logs/efm_path.log elapse http://download.enlightenment.org/tests/logs/elapse.log elation http://download.enlightenment.org/tests/logs/elation.log elicit http://download.enlightenment.org/tests/logs/elicit.log elitaire http://download.enlightenment.org/tests/logs/elitaire.log e http://download.enlightenment.org/tests/logs/e.log embrace http://download.enlightenment.org/tests/logs/embrace.log emotion http://download.enlightenment.org/tests/logs/emotion.log emphasis http://download.enlightenment.org/tests/logs/emphasis.log empower http://download.enlightenment.org/tests/logs/empower.log emprint http://download.enlightenment.org/tests/logs/emprint.log emu http://download.enlightenment.org/tests/logs/emu.log engage http://download.enlightenment.org/tests/logs/engage.log enhance http://download.enlightenment.org/tests/logs/enhance.log enity http://download.enlightenment.org/tests/logs/enity.log enna http://download.enlightenment.org/tests/logs/enna.log entrance_edit_gui http://download.enlightenment.org/tests/logs/entrance_edit_gui.log entrance http://download.enlightenment.org/tests/logs/entrance.log entropy http://download.enlightenment.org/tests/logs/entropy.log envision http://download.enlightenment.org/tests/logs/envision.log epdf http://download.enlightenment.org/tests/logs/epdf.log ephoto http://download.enlightenment.org/tests/logs/ephoto.log epsilon http://download.enlightenment.org/tests/logs/epsilon.log equate http://download.enlightenment.org/tests/logs/equate.log esmart http://download.enlightenment.org/tests/logs/esmart.log estickies http://download.enlightenment.org/tests/logs/estickies.log etk_extra http://download.enlightenment.org/tests/logs/etk_extra.log etk http://download.enlightenment.org/tests/logs/etk.log etk-perl http://download.enlightenment.org/tests/logs/etk-perl.log evfs http://download.enlightenment.org/tests/logs/evfs.log evolve http://download.enlightenment.org/tests/logs/evolve.log ewl http://download.enlightenment.org/tests/logs/ewl.log examine http://download.enlightenment.org/tests/logs/examine.log execwatch http://download.enlightenment.org/tests/logs/execwatch.log exhibit http://download.enlightenment.org/tests/logs/exhibit.log express http://download.enlightenment.org/tests/logs/express.log exquisite http://download.enlightenment.org/tests/logs/exquisite.log extrackt http://download.enlightenment.org/tests/logs/extrackt.log flame http://download.enlightenment.org/tests/logs/flame.log forecasts http://download.enlightenment.org/tests/logs/forecasts.log gevas2 http://download.enlightenment.org/tests/logs/gevas2.log iconbar http://download.enlightenment.org/tests/logs/iconbar.log language http://download.enlightenment.org/tests/logs/language.log mail http://download.enlightenment.org/tests/logs/mail.log mem http://download.enlightenment.org/tests/logs/mem.log mixer http://download.enlightenment.org/tests/logs/mixer.log moon http://download.enlightenment.org/tests/logs/moon.log mpdule http://download.enlightenment.org/tests/logs/mpdule.log net http://download.enlightenment.org/tests/logs/net.log news http://download.enlightenment.org/tests/logs/news.log notification http://download.enlightenment.org/tests/logs/notification.log photo http://download.enlightenment.org/tests/logs/photo.log rage http://download.enlightenment.org/tests/logs/rage.log rain http://download.enlightenment.org/tests/logs/rain.log screenshot http://download.enlightenment.org/tests/logs/screenshot.log slideshow http://download.enlightenment.org/tests/logs/slideshow.log snow http://download.enlightenment.org/tests/logs/snow.log taskbar http://download.enlightenment.org/tests/logs/taskbar.log tclock http://download.enlightenment.org/tests/logs/tclock.log uptime http://download.enlightenment.org/tests/logs/uptime.log weather http://download.enlightenment.org/tests/logs/weather.log winselector http://download.enl
[E-devel] Nightly build log for E17 on 2008-01-24 01:33:59 -0800
Build log for Enlightenment DR 0.17 on 2008-01-24 01:33:59 -0800 Build logs are available at http://download.enlightenment.org/tests/logs Packages that failed to build: alarm http://download.enlightenment.org/tests/logs/alarm.log bling http://download.enlightenment.org/tests/logs/bling.log calendar http://download.enlightenment.org/tests/logs/calendar.log cpu http://download.enlightenment.org/tests/logs/cpu.log deskshow http://download.enlightenment.org/tests/logs/deskshow.log echo http://download.enlightenment.org/tests/logs/echo.log eclair http://download.enlightenment.org/tests/logs/eclair.log edje_editor http://download.enlightenment.org/tests/logs/edje_editor.log edje http://download.enlightenment.org/tests/logs/edje.log edje_viewer http://download.enlightenment.org/tests/logs/edje_viewer.log edvi http://download.enlightenment.org/tests/logs/edvi.log eflpp http://download.enlightenment.org/tests/logs/eflpp.log efm_nav http://download.enlightenment.org/tests/logs/efm_nav.log efm_path http://download.enlightenment.org/tests/logs/efm_path.log elapse http://download.enlightenment.org/tests/logs/elapse.log elation http://download.enlightenment.org/tests/logs/elation.log elicit http://download.enlightenment.org/tests/logs/elicit.log elitaire http://download.enlightenment.org/tests/logs/elitaire.log e http://download.enlightenment.org/tests/logs/e.log embrace http://download.enlightenment.org/tests/logs/embrace.log emotion http://download.enlightenment.org/tests/logs/emotion.log emphasis http://download.enlightenment.org/tests/logs/emphasis.log empower http://download.enlightenment.org/tests/logs/empower.log emprint http://download.enlightenment.org/tests/logs/emprint.log emu http://download.enlightenment.org/tests/logs/emu.log engage http://download.enlightenment.org/tests/logs/engage.log enhance http://download.enlightenment.org/tests/logs/enhance.log enity http://download.enlightenment.org/tests/logs/enity.log enna http://download.enlightenment.org/tests/logs/enna.log entrance_edit_gui http://download.enlightenment.org/tests/logs/entrance_edit_gui.log entrance http://download.enlightenment.org/tests/logs/entrance.log entropy http://download.enlightenment.org/tests/logs/entropy.log envision http://download.enlightenment.org/tests/logs/envision.log epdf http://download.enlightenment.org/tests/logs/epdf.log ephoto http://download.enlightenment.org/tests/logs/ephoto.log epsilon http://download.enlightenment.org/tests/logs/epsilon.log equate http://download.enlightenment.org/tests/logs/equate.log esmart http://download.enlightenment.org/tests/logs/esmart.log estickies http://download.enlightenment.org/tests/logs/estickies.log etk_extra http://download.enlightenment.org/tests/logs/etk_extra.log etk http://download.enlightenment.org/tests/logs/etk.log etk-perl http://download.enlightenment.org/tests/logs/etk-perl.log evfs http://download.enlightenment.org/tests/logs/evfs.log evolve http://download.enlightenment.org/tests/logs/evolve.log ewl http://download.enlightenment.org/tests/logs/ewl.log examine http://download.enlightenment.org/tests/logs/examine.log execwatch http://download.enlightenment.org/tests/logs/execwatch.log exhibit http://download.enlightenment.org/tests/logs/exhibit.log express http://download.enlightenment.org/tests/logs/express.log exquisite http://download.enlightenment.org/tests/logs/exquisite.log extrackt http://download.enlightenment.org/tests/logs/extrackt.log flame http://download.enlightenment.org/tests/logs/flame.log forecasts http://download.enlightenment.org/tests/logs/forecasts.log gevas2 http://download.enlightenment.org/tests/logs/gevas2.log iconbar http://download.enlightenment.org/tests/logs/iconbar.log language http://download.enlightenment.org/tests/logs/language.log mail http://download.enlightenment.org/tests/logs/mail.log mem http://download.enlightenment.org/tests/logs/mem.log mixer http://download.enlightenment.org/tests/logs/mixer.log moon http://download.enlightenment.org/tests/logs/moon.log mpdule http://download.enlightenment.org/tests/logs/mpdule.log net http://download.enlightenment.org/tests/logs/net.log news http://download.enlightenment.org/tests/logs/news.log notification http://download.enlightenment.org/tests/logs/notification.log photo http://download.enlightenment.org/tests/logs/photo.log rage http://download.enlightenment.org/tests/logs/rage.log rain http://download.enlightenment.org/tests/logs/rain.log screenshot http://download.enlightenment.org/tests/logs/screenshot.log slideshow http://download.enlightenment.org/tests/logs/slideshow.log snow http://download.enlightenment.org/tests/logs/snow.log taskbar http://download.enlightenment.org/tests/logs/taskbar.log tclock http://download.enlightenment.org/tests/logs/tclock.log uptime http://download.enlightenment.org/tests/logs/uptime.log weather http://download.enlightenment.org/tests/logs/weather.log winselector http://download.enl
[E-devel] Nightly build log for E17 on 2008-01-24 01:31:34 -0800
Build log for Enlightenment DR 0.17 on 2008-01-24 01:31:34 -0800 Build logs are available at http://download.enlightenment.org/tests/logs Packages that failed to build: alarm http://download.enlightenment.org/tests/logs/alarm.log bling http://download.enlightenment.org/tests/logs/bling.log calendar http://download.enlightenment.org/tests/logs/calendar.log cpu http://download.enlightenment.org/tests/logs/cpu.log deskshow http://download.enlightenment.org/tests/logs/deskshow.log echo http://download.enlightenment.org/tests/logs/echo.log eclair http://download.enlightenment.org/tests/logs/eclair.log edje_editor http://download.enlightenment.org/tests/logs/edje_editor.log edje http://download.enlightenment.org/tests/logs/edje.log edje_viewer http://download.enlightenment.org/tests/logs/edje_viewer.log edvi http://download.enlightenment.org/tests/logs/edvi.log eflpp http://download.enlightenment.org/tests/logs/eflpp.log efm_nav http://download.enlightenment.org/tests/logs/efm_nav.log efm_path http://download.enlightenment.org/tests/logs/efm_path.log elapse http://download.enlightenment.org/tests/logs/elapse.log elation http://download.enlightenment.org/tests/logs/elation.log elicit http://download.enlightenment.org/tests/logs/elicit.log elitaire http://download.enlightenment.org/tests/logs/elitaire.log e http://download.enlightenment.org/tests/logs/e.log embrace http://download.enlightenment.org/tests/logs/embrace.log emotion http://download.enlightenment.org/tests/logs/emotion.log emphasis http://download.enlightenment.org/tests/logs/emphasis.log empower http://download.enlightenment.org/tests/logs/empower.log emprint http://download.enlightenment.org/tests/logs/emprint.log emu http://download.enlightenment.org/tests/logs/emu.log engage http://download.enlightenment.org/tests/logs/engage.log enhance http://download.enlightenment.org/tests/logs/enhance.log enity http://download.enlightenment.org/tests/logs/enity.log enna http://download.enlightenment.org/tests/logs/enna.log entrance_edit_gui http://download.enlightenment.org/tests/logs/entrance_edit_gui.log entrance http://download.enlightenment.org/tests/logs/entrance.log entropy http://download.enlightenment.org/tests/logs/entropy.log envision http://download.enlightenment.org/tests/logs/envision.log epdf http://download.enlightenment.org/tests/logs/epdf.log ephoto http://download.enlightenment.org/tests/logs/ephoto.log epsilon http://download.enlightenment.org/tests/logs/epsilon.log equate http://download.enlightenment.org/tests/logs/equate.log esmart http://download.enlightenment.org/tests/logs/esmart.log estickies http://download.enlightenment.org/tests/logs/estickies.log etk_extra http://download.enlightenment.org/tests/logs/etk_extra.log etk http://download.enlightenment.org/tests/logs/etk.log etk-perl http://download.enlightenment.org/tests/logs/etk-perl.log evfs http://download.enlightenment.org/tests/logs/evfs.log evolve http://download.enlightenment.org/tests/logs/evolve.log ewl http://download.enlightenment.org/tests/logs/ewl.log examine http://download.enlightenment.org/tests/logs/examine.log execwatch http://download.enlightenment.org/tests/logs/execwatch.log exhibit http://download.enlightenment.org/tests/logs/exhibit.log express http://download.enlightenment.org/tests/logs/express.log exquisite http://download.enlightenment.org/tests/logs/exquisite.log extrackt http://download.enlightenment.org/tests/logs/extrackt.log flame http://download.enlightenment.org/tests/logs/flame.log forecasts http://download.enlightenment.org/tests/logs/forecasts.log gevas2 http://download.enlightenment.org/tests/logs/gevas2.log iconbar http://download.enlightenment.org/tests/logs/iconbar.log language http://download.enlightenment.org/tests/logs/language.log mail http://download.enlightenment.org/tests/logs/mail.log mem http://download.enlightenment.org/tests/logs/mem.log mixer http://download.enlightenment.org/tests/logs/mixer.log moon http://download.enlightenment.org/tests/logs/moon.log mpdule http://download.enlightenment.org/tests/logs/mpdule.log net http://download.enlightenment.org/tests/logs/net.log news http://download.enlightenment.org/tests/logs/news.log notification http://download.enlightenment.org/tests/logs/notification.log photo http://download.enlightenment.org/tests/logs/photo.log rage http://download.enlightenment.org/tests/logs/rage.log rain http://download.enlightenment.org/tests/logs/rain.log screenshot http://download.enlightenment.org/tests/logs/screenshot.log slideshow http://download.enlightenment.org/tests/logs/slideshow.log snow http://download.enlightenment.org/tests/logs/snow.log taskbar http://download.enlightenment.org/tests/logs/taskbar.log tclock http://download.enlightenment.org/tests/logs/tclock.log uptime http://download.enlightenment.org/tests/logs/uptime.log weather http://download.enlightenment.org/tests/logs/weather.log winselector http://download.enl
Re: [E-devel] E17 under OpenBSD and other goodies.
Hi
Again as mentioned in my last mail these are openbsd specific issues.
On Jan 23, 2008 4:49 PM, The Rasterman Carsten Haitzler
<[EMAIL PROTECTED]> wrote:
> On Wed, 23 Jan 2008 05:11:33 -0800 "laurent FANIS" <[EMAIL PROTECTED]>
> babbled:
>
> > Hi,
> >
> > A long over due mail with the OpenBSD specific patches inlined.
> > The files can be checked directly from
> > http://www.openbsd.org/cgi-bin/cvsweb/ports/x11/e17/
> > This in the -current system (http://www.openbsd.org/faq/faq5.html#Flavors).
> > This is based on a snapshot from 20071211.
>
> do you do the ports patching? if so you've done a great job at breaking e in
> openbsd ports.
>
Not at all it works pretty well and i use it as my main desktop.
> > In eet:
> >
> > --- src/lib/eet_lib.c.orig Mon Nov 12 11:14:04 2007
> > +++ src/lib/eet_lib.c Mon Nov 12 11:15:11 2007
> > @@ -497,6 +497,10 @@ eet_open(const char *file, Eet_File_Mode mode)
> > else
> > return NULL;
> > }
> > + else if (file_stat.st_size == 0)
> > + {
> > + return NULL;
> > + }
> >
> > /* We found one */
> > if (ef && (file_stat.st_mtime != ef->mtime))
>
> old - eet is even pickier. it requires the file be > 3 ints of size (which in
> 99.% of cases int is 32bit - yes. technically it might not be - but if you
> are on a system where it is not - 99.% of your software just broke
> anyway :) ). not needed.
>
When i take a newer snapshot i will keep this in mind.
> >
> > Warnings:
> > Four warnings:about "HAVE_STDLIB_H" being redefined.
>
> i don't know where this comes from, but config.h is included onle once in
> Eet_private.h and that is included only once in each .c file. where are the
> previous definitions?
>
> > Two warning about unsafe function : strcpy and sprintf instead of
> > strlcpy and snprintf
>
> where? you might find that these are safe anyway as the pre-conditions make
> them safe. if we missed them - telling us will be useful :).
>
> i can go through all of them:
>
> eet_lib.c:
> check the code above the strcpy. the buffer is alloced to be bigger than the
> string being strcpy'ed in. it's safe.
> eet_data.c:
> 1st instance: safe. malloced buffer of correct size exists to strcpy into.
> 2nd instance: same as above
> 3rd instance: same as above
> 4th instance: commented out
> 5th instance: commented out
> 6th instance: commented out
>
> sprintf: buffers used are 64 bytes. this is more than large enough to hold any
> possible output from _eet_double_to_string_convert() and the null terminator.
> format is (up to a max):
>
> 0xX. (4 bytes - X is 1 hex value)
> (16 bytes - hex)
> pX (2 bytes)
> (exponent in decimal max value with a max sized double will be 1023 - so
> 4
> bytes)
>
> so a total buffer size requirement is 4 + 16 + 2 + 4 = 26 bytes, plus nul byte
> terminator, so 27. we have 64. we're safe as houses. :)
>
I have no doubt about it but, it seems in some cases "safe" function
are used in others "unsafe" function are used. I was merely mentioning
the compilers warning.
If all where safe function they wouldn't require passing over them
later in development, again this is an opinion and i do not feel like
fighting over it.
We usually do not patch these in ports unless they are going to be
fixed upstream, this is why i am only mentioning them.
> > In Evas:
> >
> > $OpenBSD: patch-configure_in,v 1.1 2007/12/06 19:47:08 bernd Exp $
> > --- configure.in.orig Wed Dec 5 22:13:29 2007
> > +++ configure.inWed Dec 5 22:13:42 2007
> > @@ -31,7 +31,7 @@ AC_SUBST(version_info)
> >
> > AC_FUNC_ALLOCA
> >
> > -MODULE_ARCH="$host_os-$host_cpu"
> > +MODULE_ARCH=""
> > AC_SUBST(MODULE_ARCH)
> > AC_DEFINE_UNQUOTED(MODULE_ARCH, "$MODULE_ARCH", "Module architecture")
>
> you just broke multi-arch support if you install modules to ~/.evas/modules
> (imagine your homedir is rsync'ed or nfs shared between a sparc solaris box,
> an
> x86 solairs box, a openbsd x86 box, an x86-64 linux box. each module will have
> its binaries in a different arch dir - and will work - as long as you built it
> for that arch+os. this patch summarily breaks that.
>
It is irrelevant in OpenBSD's case as EFL and E are installed via the
packaging system, and that install the correct package in the correct
place.
Again i am not trying to push these patches.
> > $OpenBSD: patch-src_lib_include_evas_common_h,v 1.1 2007/12/07
> > 09:49:58 mbalmer Exp $
> > --- src/lib/include/evas_common.h.orig Fri Dec 7 10:34:46 2007
> > +++ src/lib/include/evas_common.h Fri Dec 7 10:34:59 2007
> > @@ -46,6 +46,7 @@
> > #include
> > #include
> > #include
> > +#include
> > #include
> > #include
> > #include
>
> what problems did you fix by doing this? we rarely use uint32/64 etc. etc.
> (and
> friends). i'll put this in as it should be harmless unless your os is in a
> retirement home awaiting its final days.
>
> > Warnings:
> > evas_convert_rgb_8.c: In function
> > `evas_common_convert_rgba_to_8bpp_rgb_2
Re: [E-devel] E17 under OpenBSD and other goodies.
On Thursday 24 January 2008, laurent FANIS wrote:
> First off, i am not trying to push these patches, i was asked on IRC
> to post them with some comments.
> I did so.
ok ... just need to make sure the stupid BSD mentality doesnt infect you like
so many other BSD devs. keeping local changes in BSD cvs just screws
everyone long term.
> On Jan 23, 2008 7:45 AM, Mike Frysinger <[EMAIL PROTECTED]> wrote:
> > On Wednesday 23 January 2008, laurent FANIS wrote:
> > > --- configure.in.orig Wed Dec 5 22:13:29 2007
> > > +++ configure.inWed Dec 5 22:13:42 2007
> > > @@ -31,7 +31,7 @@ AC_SUBST(version_info)
> > >
> > > AC_FUNC_ALLOCA
> > >
> > > -MODULE_ARCH="$host_os-$host_cpu"
> > > +MODULE_ARCH=""
> > > AC_SUBST(MODULE_ARCH)
> > > AC_DEFINE_UNQUOTED(MODULE_ARCH, "$MODULE_ARCH", "Module architecture")
> >
> > ugh, this cant possibly be correct. can you explain what you're trying
> > to fix. same goes for all the configure scripts you modified like this.
>
> This is to be able to update cleanly the packages from one release to
> another, this is OpenBSD specific.
right, because the bsd folks insist on inserting the version into the host_os
field of their tuple. i'd be inclined to say that having multiple dirs
across bsd versions is actually correct ...
> > > --- src/lib/include/evas_common.h.orig Fri Dec 7 10:34:46 2007
> > > +++ src/lib/include/evas_common.h Fri Dec 7 10:34:59 2007
> > > @@ -46,6 +46,7 @@
> > > #include
> > > #include
> > > #include
> > > +#include
> > > #include
> > > #include
> > > #include
> >
> > stdint.h should be everywhere ;)
>
> It wasn't here and the compiler choked.
*how* did it choke
> > > In E:
> > > --- src/bin/Makefile.am.origFri Nov 9 16:20:53 2007
> > > +++ src/bin/Makefile.am Fri Nov 9 16:21:15 2007
> > > @@ -345,7 +345,7 @@ e_xinerama.c
> > >
> > > enlightenment_init_LDFLAGS = @e_libs@
> > >
> > > -setuid_root_mode = a=rx,u+xs
> > > +setuid_root_mode = a=rx,u+x
> > > install-exec-hook:
> > > @chmod $(setuid_root_mode)
> > > $(DESTDIR)$(bindir)/enlightenment_sys$(EXEEXT) || true
> >
> > clearly this is not correct.
>
> In the port system we do not install anything with setuid root. If the
> user wants it then the user has to manually update it.
then leave the hack in the port build system. it's trivial to run:
make setuid_root_mode=whatever-you-want
> > > --- src/bin/e_fm.c.orig Wed Nov 7 11:45:43 2007
> > > +++ src/bin/e_fm.c Fri Dec 7 15:44:09 2007
> > > @@ -104,7 +104,7 @@ struct _E_Fm2_Smart_Data
> > > E_Drop_Handler *drop_handler;
> > > E_Fm2_Icon *drop_icon;
> > > E_Fm2_Mount*mount;
> > > - chardrop_after;
> > > + signed char drop_after;
> > > unsigned char drop_show : 1;
> > > unsigned char drop_in_show : 1;
> > > unsigned char drop_all : 1;
> >
> > either everything should be "char" or not ... inserting "signed" here
> > without an explanation as to why doesnt seem like a good idea.
>
> This fixes macppc.
please elaborate
> > > @@ -3214,7 +3214,7 @@ _e_fm2_uri_parse(const char *val)
> > > p = val + 7;
> > > if (*p != '/')
> > > {
> > > - for (i = 0; *p != '/' && *p != '\0' && i <
> > > _POSIX_HOST_NAME_MAX; p++, i++)
> > > + for (i = 0; *p != '/' && *p != '\0' && i < MAXHOSTNAMELEN; p++,
> > > i++) hostname[i] = *p;
> > > }
> > > hostname[i] = '\0';
> > > @@ -3247,9 +3247,9 @@ _e_fm2_uri_path_list_get(Evas_List *uri_list)
> > > {
> > > E_Fm2_Uri *uri;
> > > Evas_List *l, *path_list = NULL;
> > > - char current_hostname[_POSIX_HOST_NAME_MAX];
> > > + char current_hostname[MAXHOSTNAMELEN];
> >
> > move this to autotools as a build time test as this ugly churn of defines
> > will simply break some systems while "fixing" others.
> >
> > > - if (gethostname(current_hostname, _POSIX_HOST_NAME_MAX) == -1)
> > > + if (gethostname(current_hostname, MAXHOSTNAMELEN) == -1)
> >
> > sizeof(current_hostname) should be used instead
>
> Again i am not pushing these patches. This is OpenBSD specific.
OpenBSD is probably broken then. POSIX requires _POSIX_HOST_NAME_MAX to be
defined in limits.h.
-mike
signature.asc
Description: This is a digitally signed message part.
-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Nightly build log for E17 on 2008-01-24 01:33:59 -0800
Looks like edje failed due to some strange problem I don't understand, so most other stuff failed as well. Also sent the email 8 times for some peculiar reason. It was stuck before with a CVS conflict, which is why we have not seen one for a while. I've been off the net a lot since Christmas, so I have not had much chance to investigate. I've added -C to the cvs options to take care of cvs conflicts in future. I'm going to assume it was some sort of glitch related to me running things manually and wait for the usual cron run. Hope things get fixed by then. signature.asc Description: PGP signature - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [PATCH][RFC] signal/select race problem in ecore_main
Hi
While working on suspend/resume on my embedded system I ran into to the
race problem between select and signals. See this link for a description
of the problem:
http://www.xs4all.nl/~evbergen/unix-signals.html
The problem is that the following code in ecore_main_select is not an
atomic operation and could end up in select waiting forever even though
there is a signal to be served and put in the event queue:
if (_ecore_signal_count_get()) return -1;
ret = select(max_fd + 1, &rfds, &wfds, &exfds, t);
My proposed solution (see attached patch) is something similar to that
described in above link, namely to create a pipe to flag a signal
arrival to select. NOTE: the attached patch currently only handles
sigusr1 and sigusr2 and has almost no error checking.
As far as I can tell, the attached patch still have a race around
sig_count and sigXXX_count. I thought about adding the signal number to
the signal pipe to avoid this race, but that solution could result in
pipe buffer overflow and then signals would get lost.
Before I continue working on this patch, I really like your comments and
suggestions.
Thanks
-- Lars Munch
Index: src/lib/ecore/ecore_signal.c
===
RCS file: /var/cvs/e/e17/libs/ecore/src/lib/ecore/ecore_signal.c,v
retrieving revision 1.35
diff -u -r1.35 ecore_signal.c
--- src/lib/ecore/ecore_signal.c 26 Aug 2007 11:17:21 - 1.35
+++ src/lib/ecore/ecore_signal.c 23 Jan 2008 15:53:28 -
@@ -60,6 +60,9 @@
static volatile siginfo_t *sigrt_info = NULL;
#endif
+static int pipe_fd[2];
+static Ecore_Fd_Handler *pipe_handler;
+
void
_ecore_signal_shutdown(void)
{
@@ -110,13 +113,52 @@
#endif
}
+static void
+_ecore_signal_pipe_fd_flag()
+{
+ int count;
+ char f = 1;
+
+ /* Empty signal pipe completely */
+ for(count = 0; read(pipe_fd[0], &f, sizeof(f)) > 0; count++) ;
+
+ /* Put one flag into signal pipe */
+ write(pipe_fd[1], &f, sizeof(f));
+}
+
+static int
+_ecore_signal_pipe_fb_callback(void *data, Ecore_Fd_Handler *fdh)
+{
+ int count;
+ char f;
+
+ /* Empty signal pipe completely */
+ for(count = 0; read(fdh->fd, &f, sizeof(f)) > 0; count++) ;
+
+ if(count)
+ _ecore_signal_call();
+
+ return 1;
+}
+
void
_ecore_signal_init(void)
{
+ int ret;
#ifdef SIGRTMIN
int i, num = SIGRTMAX - SIGRTMIN;
#endif
+ ret = pipe(pipe_fd);
+ assert(!ret);
+
+ fcntl(pipe_fd[0], F_SETFL, O_NONBLOCK);
+ fcntl(pipe_fd[1], F_SETFL, O_NONBLOCK);
+
+ pipe_handler = ecore_main_fd_handler_add(pipe_fd[0], ECORE_FD_READ,
+ _ecore_signal_pipe_fb_callback,
+ NULL, NULL, NULL);
+
_ecore_signal_callback_set(SIGPIPE, _ecore_signal_callback_ignore);
_ecore_signal_callback_set(SIGALRM, _ecore_signal_callback_ignore);
_ecore_signal_callback_set(SIGCHLD, _ecore_signal_callback_sigchld);
@@ -401,6 +443,8 @@
else
sigusr1_info.si_signo = 0;
+ _ecore_signal_pipe_fd_flag();
+
sigusr1_count++;
sig_count++;
}
@@ -413,6 +457,8 @@
else
sigusr2_info.si_signo = 0;
+ _ecore_signal_pipe_fd_flag();
+
sigusr2_count++;
sig_count++;
}
-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E17 under OpenBSD and other goodies.
On Thu, 24 Jan 2008 01:37:12 -0800 "laurent FANIS" <[EMAIL PROTECTED]>
babbled:
> > > In Evas:
> > >
> > > $OpenBSD: patch-configure_in,v 1.1 2007/12/06 19:47:08 bernd Exp $
> > > --- configure.in.orig Wed Dec 5 22:13:29 2007
> > > +++ configure.inWed Dec 5 22:13:42 2007
> > > @@ -31,7 +31,7 @@ AC_SUBST(version_info)
> > >
> > > AC_FUNC_ALLOCA
> > >
> > > -MODULE_ARCH="$host_os-$host_cpu"
> > > +MODULE_ARCH=""
> > > AC_SUBST(MODULE_ARCH)
> > > AC_DEFINE_UNQUOTED(MODULE_ARCH, "$MODULE_ARCH", "Module architecture")
> >
> > you just broke multi-arch support if you install modules to ~/.evas/modules
> > (imagine your homedir is rsync'ed or nfs shared between a sparc solaris
> > box, an x86 solairs box, a openbsd x86 box, an x86-64 linux box. each
> > module will have its binaries in a different arch dir - and will work - as
> > long as you built it for that arch+os. this patch summarily breaks that.
> >
>
> It is irrelevant in OpenBSD's case as EFL and E are installed via the
> packaging system, and that install the correct package in the correct
> place.
> Again i am not trying to push these patches.
the problem is that if there are 3rd party modules for e or engines/modules for
evas- they will install, if compiled by a user who doesn't have root access, to
be in ~/ - and ~/ can very easily be mounted across os's, architectures etc.
and the CODE that LOOKS for modules will LOOK in the os/arch dir for the
os/arch it was built for - in this case it wont look in any dir - and so it
will never find the module you compiled and never work. :( so this only works
as long as every possible makefile for everything you ever install is patched.
if ports patches them all - sure, but you take something outside of ports and
it will be broken unless it is also similarly patched - thus causing confusion
and problems for users :( if the os/arch dir changes because openbsd changed
versions and its in the os string - it COULD be that ABI was broken and thus a
new dir is needed.
> > > AM_GNU_GETTEXT([external])
> > > AM_GNU_GETTEXT_VERSION([0.12.1])
> > > +LIBICONV="$LTLIBICONV"
> > > +LIBINTL="$LTLIBINTL"
> > > +INTLLIBS="$LTLIBINTL"
> > > if test "x$LIBINTL" = "x"; then
> > >LIBINTL="$INTLLIBS"
> > > fi
> >
> > i am dubious about this - why?
>
> This is only for the ports, IIRC this is to prevent linking to
> libintl.a and libiconv.a instead of the .so.
bizarre! why doesn't it link the .so in as it should be available...?
> > > --- src/bin/Makefile.am.origFri Nov 9 16:20:53 2007
> > > +++ src/bin/Makefile.am Fri Nov 9 16:21:15 2007
> > > @@ -345,7 +345,7 @@ e_xinerama.c
> > >
> > > enlightenment_init_LDFLAGS = @e_libs@
> > >
> > > -setuid_root_mode = a=rx,u+xs
> > > +setuid_root_mode = a=rx,u+x
> > > install-exec-hook:
> > > @chmod $(setuid_root_mode)
> > > $(DESTDIR)$(bindir)/enlightenment_sys$(EXEEXT) || true
> >
> > you just broke sysactions. e can't shut down, reboot, suspend or hubernate
> > now. it has to be setuid root to be able to run shutdown, reboot etc. as
> > root. there is a sysactions.cfg file- text, that e installs that allows
> > packagers to define access policies and what users, groups etc. can do what
> > and what commands are mapped to which sysaction. you probably should solve
> > this with packaging and install an appropriate sysactions.cfg into openbsd
> > that still allows your average desktop used to do these things as it is a
> > necessary function of using your pc (in almost all if not all cases - if
> > you have access to the power button - you should have access to these). the
> > default sysactions.cfg is set up to "just work" as best as possible and
> > works "as-is" on ubuntu - i guarantee. distributions may/should customise
> > it if needed.
> >
>
> As mentioned above the port system does not allow you to install suid
> stuff, If the user wants it he has to set it by hand.
> sysactions.cfg is being installed correctly via the port system.
is it also configured correctly for openbsd (ie security policies, commands to
run on halt, reboot, suspend, hibernate etc.?)? why blanket "ban" setuid?
> > > CFG_MODULE("exebuf", 1, 1);
> > > CFG_MODULE("winlist", 1, 1);
> >
> > not useful. these are needed for linux - and eventually the wizard will
> > enable or disable modules based on initial system probes the first time you
> > run E. i.e
> > - check if you have any battery (look for apm, acpi etc.) and if not - dont
> > load battery module. check for temp sensors - if you don't have any e knows
> > about - don't load temp module etc.
>
> We will wait for the Wizard ;) till then i disabled them.
no problems. just letting you know why we can't accept such a patch :)
> Or u can use the "safe function" :P .
> All i did is report the nagging from the compiler, i haven't check in
> details all, but they seemed safe.
personally i find just moving everything to "Safe" functions is a false sense
of security - unless you study all the preconditio
Re: [E-devel] E17 under OpenBSD and other goodies.
On Thu, 24 Jan 2008 01:08:40 -0800 "laurent FANIS" <[EMAIL PROTECTED]> babbled: > Hi, > > First off, i am not trying to push these patches, i was asked on IRC > to post them with some comments. > I did so. ok - but this is not good for anyone using the openbsd ports. things literally are broken due to these patches you put in. > > > -MODULE_ARCH="$host_os-$host_cpu" > > > +MODULE_ARCH="" > > > AC_SUBST(MODULE_ARCH) > > > AC_DEFINE_UNQUOTED(MODULE_ARCH, "$MODULE_ARCH", "Module architecture") > > > > > > > ugh, this cant possibly be correct. can you explain what you're trying to > > fix. same goes for all the configure scripts you modified like this. > > > This is to be able to update cleanly the packages from one release to > another, this is OpenBSD specific. i don't see how this can be right - the host_os and host_cpu should be the SAME between builds and updates - thus the same dir and files created or overwritten. if it varies - then you have a problem in your build setup. > > > In ecore: > > > It seems ecore does not respect :--disable-ecore-evas-sdl > > > --disable-ecore-sdl and still links to SDL if it exist, can someone > > > please test this under linux. > > > > there is no --disable-ecore-sdl option ... maybe that is why it doesnt work > > for you ;) > > > > It didn't work on my test machine and i wanted some feedback from > other users as i do not have a linux machine to test it. it was a problem of linking if sdl is found at all. fixed in cvs. > > > In E: > > > --- src/bin/Makefile.am.origFri Nov 9 16:20:53 2007 > > > +++ src/bin/Makefile.am Fri Nov 9 16:21:15 2007 > > > @@ -345,7 +345,7 @@ e_xinerama.c > > > > > > enlightenment_init_LDFLAGS = @e_libs@ > > > > > > -setuid_root_mode = a=rx,u+xs > > > +setuid_root_mode = a=rx,u+x > > > install-exec-hook: > > > @chmod $(setuid_root_mode) > > > $(DESTDIR)$(bindir)/enlightenment_sys$(EXEEXT) || true > > > > clearly this is not correct. > > > > In the port system we do not install anything with setuid root. If the > user wants it then the user has to manually update it. that that's wrong. the policy is wrong. it literally breaks functionality for a user. this is where security policies just go into the land of stupidity and make life hard for users. as i said in my other email - there is a nice detailed config file to determine access here. this basically means any documentation on features will be incorrect as you removed functionality that despite how they configure it, will never work. maybe before blindly removing setuid bits - you should check what has it and why and what it does, and how. :) i understand the need for security - but just blindly removing setuid bits "because that is policy" is a policy that is wrong - as it does not examine the facts of the case nor the repercussions of removing it. please consider supplying a correctly configured sysactions.cfg for e instead of removing the setuid bit. :) -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)[EMAIL PROTECTED] - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Current status of e_nm
On Wed, Jan 23, 2008 at 11:27:03PM +0100, Stefan Schmidt wrote: > > I'm not much of a GUI developer, but I'll try to dig up the sample > > client I was working on tonight. > > Thanks. Hi Stefan, I've posted the most recent code for my sample NM app at http://kallisti.us/~ross/enetmgr.tar.gz It's not currently in a state where it builds, but the tarball includes the git history and there was an 0.1 (also on the same site, but enetmgr-0.1.tar.gz) that did build. -- Ross Vandegrift [EMAIL PROTECTED] "The good Christian should beware of mathematicians, and all those who make empty prophecies. The danger already exists that the mathematicians have made a covenant with the devil to darken the spirit and to confine man in the bonds of Hell." --St. Augustine, De Genesi ad Litteram, Book II, xviii, 37 - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Current status of e_nm
Hello. On Thu, 2008-01-24 at 07:50, Ross Vandegrift wrote: > On Wed, Jan 23, 2008 at 11:27:03PM +0100, Stefan Schmidt wrote: > > I've posted the most recent code for my sample NM app at > http://kallisti.us/~ross/enetmgr.tar.gz > > It's not currently in a state where it builds, but the tarball > includes the git history and there was an 0.1 (also on the same site, > but enetmgr-0.1.tar.gz) that did build. Great. Thanks a lot. I'll take a look later this day. regards Stefan Schmidt signature.asc Description: Digital signature - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Solution for Desktop Drives and Devices
I sincerly doubt this will get any attention, but the linking of the favorites to the Desktop is just double handling. The devices are just fine in the Favorites box on EFM startup. But personally, I dont like having those linked .desktop files on my desktop. Im sure some of you might agree. I know its the only way to get them to work as devices on the desktop but a on/off switch for it needs to be made. I know ill be applying this diff when I next compile from CVS. Toma- --- src/bin/e_fm_hal.c 2008-01-24 22:17:06.0 +0900 +++ e_fm_hal.c 2008-01-24 22:00:25.0 +0900 @@ -268,10 +268,10 @@ v->udi); fclose(f); - snprintf(buf2, sizeof(buf2), "%s/Desktop/|%s_%d.desktop", +/* snprintf(buf2, sizeof(buf2), "%s/Desktop/|%s_%d.desktop", e_user_homedir_get(), id, v->partition_number); ecore_file_symlink(buf, buf2); - +*/ /* FIXME: manipulate icon directly */ _e_fm2_file_force_update(buf); _e_fm2_file_force_update(buf2); @@ -291,9 +291,9 @@ if (!v->storage) return; id = ecore_file_file_get(v->storage->udi); - snprintf(buf, sizeof(buf) - 1, "%s/Desktop/|%s_%d.desktop", +/* snprintf(buf, sizeof(buf) - 1, "%s/Desktop/|%s_%d.desktop", e_user_homedir_get(), id, v->partition_number); - +*/ ecore_file_unlink(buf); _e_fm2_file_force_update(buf); snprintf(buf, sizeof(buf) - 1, "%s/.e/e/fileman/favorites/|%s_%d.desktop", - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH][RFC] signal/select race problem in ecore_main
I think the proper fix is to use sigprocmask() disable signals, then rather than using select(), call pselect() which takes a signal mask and will atomically use that mask during the select. This should fix the race condition and force signals to be processed simultaneously to file descriptors. On Jan 24, 2008 5:03 AM, Lars Munch <[EMAIL PROTECTED]> wrote: > Hi > > While working on suspend/resume on my embedded system I ran into to the > race problem between select and signals. See this link for a description > of the problem: > > http://www.xs4all.nl/~evbergen/unix-signals.html > > The problem is that the following code in ecore_main_select is not an > atomic operation and could end up in select waiting forever even though > there is a signal to be served and put in the event queue: > >if (_ecore_signal_count_get()) return -1; >ret = select(max_fd + 1, &rfds, &wfds, &exfds, t); > > My proposed solution (see attached patch) is something similar to that > described in above link, namely to create a pipe to flag a signal > arrival to select. NOTE: the attached patch currently only handles > sigusr1 and sigusr2 and has almost no error checking. > > As far as I can tell, the attached patch still have a race around > sig_count and sigXXX_count. I thought about adding the signal number to > the signal pipe to avoid this race, but that solution could result in > pipe buffer overflow and then signals would get lost. > > Before I continue working on this patch, I really like your comments and > suggestions. > > Thanks > > -- Lars Munch > > > - > This SF.net email is sponsored by: Microsoft > Defy all challenges. Microsoft(R) Visual Studio 2008. > http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] E17 or X crash?
Hello,
I commited a trivial patch to tclock to disable the tooltip entry if
the check is disabled. While hacking around I did a mistake before that
could reproducible freeze E17 or X. I'm not sure how to find out.
See here the wrong patch:
Index: e_mod_config.c
===
RCS file: /cvs/e/e_modules/tclock/e_mod_config.c,v
retrieving revision 1.36
diff -u -u -r1.36 e_mod_config.c
--- e_mod_config.c 26 Dec 2007 01:18:56 - 1.36
+++ e_mod_config.c 24 Jan 2008 17:54:38 -
@@ -20,6 +20,7 @@
E_Config_Dialog_Data * cfdata);
static void _cb_time_check (void *data, Evas_Object * obj);
static void _cb_date_check (void *data, Evas_Object * obj);
+static void _cb_tooltip_check (void *data, Evas_Object * obj);
void
_config_tclock_module (Config_Item * ci)
@@ -84,7 +85,9 @@
_basic_create_widgets (E_Config_Dialog * cfd, Evas * evas,
E_Config_Dialog_Data * cfdata)
{
Evas_Object *o, *of, *ob;
- Evas_Object *time_entry, *time_check, *date_entry, *date_check;
+ Evas_Object *time_entry, *time_check;
+ Evas_Object *date_entry, *date_check;
+ Evas_Object *tooltip_entry, *tooltip_check;
o = e_widget_list_add (evas, 0, 0);
@@ -117,10 +120,13 @@
e_widget_list_object_append (o, of, 1, 1, 0.5);
of = e_widget_frametable_add (evas, D_ ("Tool Tip"), 1);
- ob = e_widget_check_add (evas, D_ ("Show Tooltip"), &(cfdata->show_tip));
- e_widget_frametable_object_append (of, ob, 0, 0, 1, 1, 1, 0, 1, 0);
- ob = e_widget_entry_add (evas, &cfdata->tip_format, NULL, NULL, NULL);
- e_widget_min_size_set (ob, 150, 1);
+ tooltip_check =
+e_widget_check_add (evas, D_ ("Show Tooltip"), &(cfdata->show_tip));
+ e_widget_frametable_object_append (of, tooltip_check, 0, 0, 1, 1, 1, 0, 1,
0);
+ tooltip_entry = e_widget_entry_add (evas, &cfdata->tip_format, NULL, NULL,
NULL);
+ e_widget_on_change_hook_set (tooltip_check, _cb_date_check, tooltip_entry);
+ // disabled
+ e_widget_min_size_set (tooltip_entry, 150, 1);
e_widget_frametable_object_append (of, ob, 0, 1, 1, 1, 1, 0, 1, 0);
^
-
This line above was a mistake by me. It should be:
e_widget_frametable_object_append (of, tooltip_entry, 0, 1, 1, 1, 1, 0, 1, 0);
-
ob =
e_widget_label_add (evas, D_ ("Consult strftime(3) for format syntax"));
@@ -166,6 +172,15 @@
static void
_cb_date_check (void *data, Evas_Object *obj)
+{
+ int checked;
+
+ checked = e_widget_check_checked_get (obj);
+ e_widget_disabled_set (data, !checked);
+}
+
+static void
+_cb_tooltip_check (void *data, Evas_Object *obj)
{
int checked;
The result was that the line "see strftime(3)..." was printed two times below
the
check instead of the entry. Ok, I noticed the mistake and corrected it later
before
commiting. But the really strange thing was that after pressing on the "close"
button
E17 or X was frozen. The button did come up from the pressed position. If I
remember
correct even the mouse cursor was frozen. But not sure here. I should reproduce
it if
needed.
Any ideas what's the problem here? Is this a expected behaviour by such a
programming
mistake?
regards
Andreas
-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] e_module-notification from 2008-01-24 can't find .pot
Hey all,
I just updated e_module-notification around 10:30 PST on 2008-01-24
and ran into this error:
test ! -f notification.po || { \
if test -f ./notification.pot; then \
sed -f remove-potcdate.sed < ./notification.pot >
notification.1po &
& \
sed -f remove-potcdate.sed < notification.po >
notification.2po && \
if cmp notification.1po notification.2po >/dev/null 2>&1; then \
rm -f notification.1po notification.2po notification.po; \
else \
rm -f notification.1po notification.2po ./notification.pot && \
mv notification.po ./notification.pot; \
fi; \
else \
mv notification.po ./notification.pot; \
fi; \
}
make[4]: Leaving directory `/usr/src/e_module-notification-cvs/po'
/usr/bin/msgmerge --update fi.po notification.pot
/usr/bin/msgmerge: error while opening "notification.pot" for reading:
No such file or directory
make[3]: *** [fi.po] Error 1
make[3]: Leaving directory `/usr/src/e_module-notification-cvs/po'
Thanks,
-sandalle
--
Eric Sandall | Source Mage GNU/Linux Developer
[EMAIL PROTECTED] PGP: 0xA8EFDD61 | http://www.sourcemage.org/
http://eric.sandall.us/ | http://counter.li.org/ #196285
-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] e_module-notification from 2008-01-24 can't find .pot
Eric Sandall wrote: > Hey all, > > I just updated e_module-notification around 10:30 PST on 2008-01-24 > and ran into this error: Fixed in cvs. Sebastian - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] e_module-notification from 2008-01-24 can't find .pot
Quoting Sebastian Dransfeld <[EMAIL PROTECTED]>: > Eric Sandall wrote: >> Hey all, >> >> I just updated e_module-notification around 10:30 PST on 2008-01-24 >> and ran into this error: > > Fixed in cvs. Verified. Thanks Sebastian! :) -sandalle -- Eric Sandall | Source Mage GNU/Linux Developer [EMAIL PROTECTED] PGP: 0xA8EFDD61 | http://www.sourcemage.org/ http://eric.sandall.us/ | http://counter.li.org/ #196285 - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] e_module-notification installation location
Hey all, After updating lately (2008-01-24 at 10:30 PST, though the last update was a week ago or so), I noticed that notification no longer loads (E17 complains it cannot find the module). I looked at the installation path and it is now installing to /usr/notification/ instead of /usr/lib/enlightenment/modules/notification/ where all of the other modules install given the same ./configure --prefix=/usr. I recall a recent (last few days) CVS update to notification to change installation paths, but I've already deleted it. :( Thanks, -sandalle -- Eric Sandall | Source Mage GNU/Linux Developer [EMAIL PROTECTED] PGP: 0xA8EFDD61 | http://www.sourcemage.org/ http://eric.sandall.us/ | http://counter.li.org/ #196285 - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] e_module-notification installation location
This seems to be a bug with the autofoo stuff, some recent commit to all modules autofoo break the --prefix rule, it isn't respected anymore and so modules are installed in a default path. Someone should fix that... Greets, Brian 'morlenxus' Miculcy On Thu, Jan 24, 2008 at 12:50:21PM -0800, Eric Sandall wrote: > Hey all, > > After updating lately (2008-01-24 at 10:30 PST, though the last update > was a week ago or so), I noticed that notification no longer loads > (E17 complains it cannot find the module). I looked at the > installation path and it is now installing to /usr/notification/ > instead of /usr/lib/enlightenment/modules/notification/ where all of > the other modules install given the same ./configure --prefix=/usr. I > recall a recent (last few days) CVS update to notification to change > installation paths, but I've already deleted it. :( > > Thanks, > > -sandalle > > -- > Eric Sandall | Source Mage GNU/Linux Developer > [EMAIL PROTECTED] PGP: 0xA8EFDD61 | http://www.sourcemage.org/ > http://eric.sandall.us/ | http://counter.li.org/ #196285 > > > - > This SF.net email is sponsored by: Microsoft > Defy all challenges. Microsoft(R) Visual Studio 2008. > http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Little optical patch for the fileselector
Hi there, as I did the current german translation, there are some parts where the translated text needs more space than the original. In the "select icon"-dialog the "add to favorites"-button was getting bigger, but the favorites_frame-table below had a fixed size to the old table and so the favorites-button was wider than the -frame. This isn't only ugly, it's a waste of free space. The patch attached fixes it. Index: e_widget_fsel.c === RCS file: /var/cvs/e/e17/apps/e/src/bin/e_widget_fsel.c,v retrieving revision 1.55 diff -u -r1.55 e_widget_fsel.c --- e_widget_fsel.c 7 Oct 2007 21:22:40 - 1.55 +++ e_widget_fsel.c 24 Jan 2008 20:56:52 - @@ -425,7 +425,7 @@ wd->o_favorites_frame = o; e_widget_sub_object_add(obj, o); e_widget_min_size_set(o, 128, 128); - e_widget_table_object_append(wd->o_table2, o, 0, 1, 1, 1, 0, 1, 0, 1); + e_widget_table_object_append(wd->o_table2, o, 0, 1, 1, 1, 1, 1, 0, 1); o = e_fm2_add(evas); wd->o_files_fm = o; - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] e_module-notification installation location
For most modules prefix is ignored, they will by default install in the enlightenment dir ($e_prefix/lib/enlightenment/modules) unless homedir is specified. With notification prefix was enabled again with the commit a while ago, but you can't give /usr as prefix, you must give the whole path which is /usr/lib/enlightenment/modules/ in your case. Giving prefix has little meaning with modules as e only looks in specific dirs for modules anyway. Sebastian Brian 'morlenxus' Miculcy wrote: > This seems to be a bug with the autofoo stuff, > some recent commit to all modules autofoo break the --prefix rule, it > isn't respected anymore and so modules are installed in a default path. > Someone should fix that... > > Greets, > Brian 'morlenxus' Miculcy > > On Thu, Jan 24, 2008 at 12:50:21PM -0800, Eric Sandall wrote: >> Hey all, >> >> After updating lately (2008-01-24 at 10:30 PST, though the last update >> was a week ago or so), I noticed that notification no longer loads >> (E17 complains it cannot find the module). I looked at the >> installation path and it is now installing to /usr/notification/ >> instead of /usr/lib/enlightenment/modules/notification/ where all of >> the other modules install given the same ./configure --prefix=/usr. I >> recall a recent (last few days) CVS update to notification to change >> installation paths, but I've already deleted it. :( >> >> Thanks, >> >> -sandalle >> >> -- >> Eric Sandall | Source Mage GNU/Linux Developer >> [EMAIL PROTECTED] PGP: 0xA8EFDD61 | http://www.sourcemage.org/ >> http://eric.sandall.us/ | http://counter.li.org/ #196285 >> >> >> - >> This SF.net email is sponsored by: Microsoft >> Defy all challenges. Microsoft(R) Visual Studio 2008. >> http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ >> ___ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > - > This SF.net email is sponsored by: Microsoft > Defy all challenges. Microsoft(R) Visual Studio 2008. > http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] e_module-notification installation location
It's not a bug the configure.in are set up this way in most (all?) modules. They will be installed in `enlightenment-config --module-dir`. Unless you use the --enable-homedir-install option. Morlenxus pointed me than the --prefix was ignored, and I thought that it might be a handful option for package maintainers (or people with various reasons). I added it, with a little resume when the configure ends, so that people notice where the module will be installed. If you run the configure with no prefix option the behaviour is still the same, and the module will be installed in your E's dir. I didn't updated all the modules because I don't know what the other devs are thinking about this. And I don't want to impose such a thing to them without even asking. Personnaly I don't care to keep or not this option (it's maybe better if every modules act in the same manner ?). So what do you think about this ? Brian 'morlenxus' Miculcy wrote: > This seems to be a bug with the autofoo stuff, > some recent commit to all modules autofoo break the --prefix rule, it > isn't respected anymore and so modules are installed in a default path. > Someone should fix that... > > Greets, > Brian 'morlenxus' Miculcy > > On Thu, Jan 24, 2008 at 12:50:21PM -0800, Eric Sandall wrote: > >> Hey all, >> >> After updating lately (2008-01-24 at 10:30 PST, though the last update >> was a week ago or so), I noticed that notification no longer loads >> (E17 complains it cannot find the module). I looked at the >> installation path and it is now installing to /usr/notification/ >> instead of /usr/lib/enlightenment/modules/notification/ where all of >> the other modules install given the same ./configure --prefix=/usr. I >> recall a recent (last few days) CVS update to notification to change >> installation paths, but I've already deleted it. :( >> >> Thanks, >> >> -sandalle >> >> -- >> Eric Sandall | Source Mage GNU/Linux Developer >> [EMAIL PROTECTED] PGP: 0xA8EFDD61 | http://www.sourcemage.org/ >> http://eric.sandall.us/ | http://counter.li.org/ #196285 >> >> >> - >> This SF.net email is sponsored by: Microsoft >> Defy all challenges. Microsoft(R) Visual Studio 2008. >> http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ >> ___ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > > - > This SF.net email is sponsored by: Microsoft > Defy all challenges. Microsoft(R) Visual Studio 2008. > http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E17 under OpenBSD and other goodies.
On Jan 24, 2008 2:59 AM, Mike Frysinger <[EMAIL PROTECTED]> wrote: > On Wednesday 23 January 2008, Carsten Haitzler wrote: > > On Wed, 23 Jan 2008 05:11:33 -0800 "laurent FANIS" > > > --- src/bin/e_fm.c.orig Wed Nov 7 11:45:43 2007 > > > +++ src/bin/e_fm.c Fri Dec 7 15:44:09 2007 > > > @@ -104,7 +104,7 @@ struct _E_Fm2_Smart_Data > > > E_Drop_Handler *drop_handler; > > > E_Fm2_Icon *drop_icon; > > > E_Fm2_Mount*mount; > > > - chardrop_after; > > > + signed char drop_after; > > > unsigned char drop_show : 1; > > > unsigned char drop_in_show : 1; > > > unsigned char drop_all : 1; > > > > why? char is normally signed. are you using a strange architecture? i can > > see how this would break if char is not signed on a particular arch. > > you cannot rely on the signedness when using "char". if there is code that > requires it one way or the other, then the type must be explicit. one > example of a strange architecture is powerpc ;). "char" defaults > to "unsigned char" on ppc systems. ARM is also unsigned. -- Gustavo Sverzut Barbieri -- Jabber: [EMAIL PROTECTED] MSN: [EMAIL PROTECTED] ICQ#: 17249123 Skype: gsbarbieri Mobile: +55 (81) 9927 0010 - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Solution for Desktop Drives and Devices
On Thu, 24 Jan 2008 22:37:19 +0900 Toma <[EMAIL PROTECTED]> babbled: eventually this will be an option - disable desktop device icons and/or determine a specific location to put them (right now its fixed to be put in favorites and then symlinked form the desktop). but as i said - for now its "the code does this with no option for you" ... currently. > I sincerly doubt this will get any attention, but the linking of the > favorites to the Desktop is just double handling. The devices are just > fine in the Favorites box on EFM startup. But personally, I dont like > having those linked .desktop files on my desktop. Im sure some of you > might agree. > I know its the only way to get them to work as devices on the desktop > but a on/off switch for it needs to be made. I know ill be applying > this diff when I next compile from CVS. > Toma- > > > --- src/bin/e_fm_hal.c2008-01-24 22:17:06.0 +0900 > +++ e_fm_hal.c2008-01-24 22:00:25.0 +0900 > @@ -268,10 +268,10 @@ > v->udi); > fclose(f); > > - snprintf(buf2, sizeof(buf2), "%s/Desktop/|%s_%d.desktop", > +/* snprintf(buf2, sizeof(buf2), "%s/Desktop/|%s_%d.desktop", >e_user_homedir_get(), id, v->partition_number); > ecore_file_symlink(buf, buf2); > - > +*/ > /* FIXME: manipulate icon directly */ > _e_fm2_file_force_update(buf); > _e_fm2_file_force_update(buf2); > @@ -291,9 +291,9 @@ > > if (!v->storage) return; > id = ecore_file_file_get(v->storage->udi); > - snprintf(buf, sizeof(buf) - 1, "%s/Desktop/|%s_%d.desktop", > +/* snprintf(buf, sizeof(buf) - 1, "%s/Desktop/|%s_%d.desktop", > e_user_homedir_get(), id, v->partition_number); > - > +*/ > ecore_file_unlink(buf); > _e_fm2_file_force_update(buf); > snprintf(buf, sizeof(buf) - 1, "%s/.e/e/fileman/favorites/|%s_%d.desktop", > > - > This SF.net email is sponsored by: Microsoft > Defy all challenges. Microsoft(R) Visual Studio 2008. > http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)[EMAIL PROTECTED] - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Little optical patch for the fileselector
On Thu, 24 Jan 2008 22:20:41 +0100 "Thomas Gstädtner" <[EMAIL PROTECTED]> babbled: in cvs. danke! :) > Hi there, > > as I did the current german translation, there are some parts where the > translated text needs more space than the original. > In the "select icon"-dialog the "add to favorites"-button was getting > bigger, but the favorites_frame-table below had a fixed size to the old > table and so the favorites-button was wider than the -frame. > This isn't only ugly, it's a waste of free space. > The patch attached fixes it. > -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)[EMAIL PROTECTED] - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH][RFC] signal/select race problem in ecore_main
On Thu, 24 Jan 2008 12:03:26 +0100 [EMAIL PROTECTED] (Lars Munch) babbled: > Hi > > While working on suspend/resume on my embedded system I ran into to the > race problem between select and signals. See this link for a description > of the problem: > > http://www.xs4all.nl/~evbergen/unix-signals.html > > The problem is that the following code in ecore_main_select is not an > atomic operation and could end up in select waiting forever even though > there is a signal to be served and put in the event queue: > >if (_ecore_signal_count_get()) return -1; >ret = select(max_fd + 1, &rfds, &wfds, &exfds, t); > > My proposed solution (see attached patch) is something similar to that > described in above link, namely to create a pipe to flag a signal > arrival to select. NOTE: the attached patch currently only handles > sigusr1 and sigusr2 and has almost no error checking. > > As far as I can tell, the attached patch still have a race around > sig_count and sigXXX_count. I thought about adding the signal number to > the signal pipe to avoid this race, but that solution could result in > pipe buffer overflow and then signals would get lost. > > Before I continue working on this patch, I really like your comments and > suggestions. oh yeah. very good point. and yes - a race condition - a very small one, but there nevertheless. now nathan's solution - sigmask and pselect. that could work. problem is - pselect. how will that affect us. not sure. never touched it. the pipe/fd solution should work. we dont use it for delivery of signals ONLY to wake select up. just a dumb fd we write a single byte to in the sig handler. that means select should go in and then instantly come out if there was a signal. we can have another global flags of "sig_pipe_write". i.e sig_pipe_write++; if (_ecore_signal_count_get()) return -1; et = select(max_fd + 1, &rfds, &wfds, &exfds, t); sig_pipe_write--; and in signal handler add: ... unsigned char dummy_buf = 1; if (sig_pipe_write > 0) write(signal_pipe, &dummy_buf, 1); ... this means that whenever in select we also get a write on any signals that will cause select to wake up when it is next called. we will get extra select() wakeups tho (and wakeups for just the reason that the pipe buffer has data). of course i am assuming non-blocking writes to this signal pipe fd, so if they fail - thats ok. the fact the buffer has data is enough to wake select up and avoid the "long term sleep" bug. next time select returns the signal stuff will be fixed up and handled- it just means we get a possible delay (until something else wakes select up). using the pipe we force it to wake up. now i think this is a bit more generic a solution - but it adds overhead. so what about the pselect() method? anyone got input on that? -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)[EMAIL PROTECTED] - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH][RFC] signal/select race problem in ecore_main
On Jan 24, 2008 7:18 PM, The Rasterman Carsten Haitzler <[EMAIL PROTECTED]> wrote: > > now i think this is a bit more generic a solution - but it adds overhead. so > what about the pselect() method? anyone got input on that? Basically, pselect() is designed for exactly this situation. You block all of the signals you're going to handle during init or some other very early point, then you pass a mask of the signals you're going to unblock to pselect(). At this point, pselect() will atomically unblock the specified signals and call select() with the specified fd's, it also re-instates the original signal blocks after select() returns. Since this sequence is atomic, it prevents the race condition we currently have. Now the problem, this is a good solution on BSD and Solaris, but unfortunately Linux only fakes support for pselect() (unless this was fixed recently). On Linux pselect() is actually a wrapper exactly around the sequence sigprocmask(), select() sigprocmask(). So we still end up with a race condition between the first sigprocmask() call and the select() call. - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH][RFC] signal/select race problem in ecore_main
On Jan 24, 2008 11:42 PM, Nathan Ingersoll <[EMAIL PROTECTED]> wrote: > On Jan 24, 2008 7:18 PM, The Rasterman Carsten Haitzler > <[EMAIL PROTECTED]> wrote: > > > > now i think this is a bit more generic a solution - but it adds overhead. so > > what about the pselect() method? anyone got input on that? > > Basically, pselect() is designed for exactly this situation. You block > all of the signals you're going to handle during init or some other > very early point, then you pass a mask of the signals you're going to > unblock to pselect(). At this point, pselect() will atomically unblock > the specified signals and call select() with the specified fd's, it > also re-instates the original signal blocks after select() returns. > Since this sequence is atomic, it prevents the race condition we > currently have. > > Now the problem, this is a good solution on BSD and Solaris, but > unfortunately Linux only fakes support for pselect() (unless this was > fixed recently). On Linux pselect() is actually a wrapper exactly > around the sequence sigprocmask(), select() sigprocmask(). So we still > end up with a race condition between the first sigprocmask() call and > the select() call. man page says: BUGS: Since version 2.1, glibc has provided an emulation of pselect() that is implemented using sigprocmask(2) and select(). This implementation remains vulnerable to the very race condition that pselect() was designed to prevent. On systems that lack pselect() reliable (and more portable) signal trapping can be achieved using the self-pipe trick (where a signal handler writes a byte to a pipe whose other end is monitored by select() in the main program.) however a bit earlier it says Linux has pselect(), and at least 2.6.23 implements it... so maybe this wrapper is just used as a fallback? -- Gustavo Sverzut Barbieri -- Jabber: [EMAIL PROTECTED] MSN: [EMAIL PROTECTED] ICQ#: 17249123 Skype: gsbarbieri Mobile: +55 (81) 9927 0010 - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: libs/ewl jethomas
I think this should be moved to the theme rather than hardcoding it directly into the lib. On Jan 24, 2008 9:08 PM, Enlightenment CVS <[EMAIL PROTECTED]> wrote: > Enlightenment CVS committal > > Author : jethomas > Project : e17 > Module : libs/ewl > > Dir : e17/libs/ewl/src/lib > > > Modified Files: > ewl_filepicker.c > > > Log Message: > Add some padding to the combo. > > === > RCS file: /cvs/e/e17/libs/ewl/src/lib/ewl_filepicker.c,v > retrieving revision 1.45 > retrieving revision 1.46 > diff -u -3 -r1.45 -r1.46 > --- ewl_filepicker.c16 Jan 2008 22:03:17 - 1.45 > +++ ewl_filepicker.c25 Jan 2008 03:08:19 - 1.46 > @@ -160,6 +160,7 @@ > ewl_filepicker_cb_path_change, fp); > ewl_object_fill_policy_set(EWL_OBJECT(fp->mvc_path.combo), > EWL_FLAG_FILL_HFILL | EWL_FLAG_FILL_VSHRINK); > + ewl_object_padding_set(EWL_OBJECT(fp->mvc_path.combo), 1, 1, 1, 1); > ewl_widget_show(fp->mvc_path.combo); > > o = ewl_hbox_new(); > > > > - > This SF.net email is sponsored by: Microsoft > Defy all challenges. Microsoft(R) Visual Studio 2008. > http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ > ___ > enlightenment-cvs mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs > - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] e_module-notification installation location
lok wrote: > It's not a bug the configure.in are set up this way in most (all?) modules. > They will be installed in `enlightenment-config --module-dir`. > Unless you use the --enable-homedir-install option. > Morlenxus pointed me than the --prefix was ignored, and I thought that it > might be a handful option for package maintainers (or people with > various reasons). I think package maintainers would like modules to install in a location where e finds it, so I don't really think we should use --prefix. At least since modules don't use --prefix like normal apps do. For most users it isn't logical that ./configure --prefix=/usr in 'e_modules' wont work with ./configure --prefix=/usr in 'e'. Maybe a --set-module-installation-dir option? Sebastian - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH][RFC] signal/select race problem in ecore_main
On Fri, 25 Jan 2008 00:11:41 -0300 "Gustavo Sverzut Barbieri" <[EMAIL PROTECTED]> babbled: > On Jan 24, 2008 11:42 PM, Nathan Ingersoll <[EMAIL PROTECTED]> wrote: > > On Jan 24, 2008 7:18 PM, The Rasterman Carsten Haitzler > > <[EMAIL PROTECTED]> wrote: > > > > > > now i think this is a bit more generic a solution - but it adds overhead. > > > so what about the pselect() method? anyone got input on that? > > > > Basically, pselect() is designed for exactly this situation. You block > > all of the signals you're going to handle during init or some other > > very early point, then you pass a mask of the signals you're going to > > unblock to pselect(). At this point, pselect() will atomically unblock > > the specified signals and call select() with the specified fd's, it > > also re-instates the original signal blocks after select() returns. > > Since this sequence is atomic, it prevents the race condition we > > currently have. > > > > Now the problem, this is a good solution on BSD and Solaris, but > > unfortunately Linux only fakes support for pselect() (unless this was > > fixed recently). On Linux pselect() is actually a wrapper exactly > > around the sequence sigprocmask(), select() sigprocmask(). So we still > > end up with a race condition between the first sigprocmask() call and > > the select() call. > > man page says: > > BUGS: > Since version 2.1, glibc has provided an emulation of pselect() > that is implemented using sigprocmask(2) and select(). >This implementation remains vulnerable to the very race > condition that pselect() was designed to prevent. On systems >that lack pselect() reliable (and more portable) signal > trapping can be achieved using the self-pipe trick (where a >signal handler writes a byte to a pipe whose other end is > monitored by select() in the main program.) > > > however a bit earlier it says Linux has pselect(), and at least 2.6.23 > implements it... so maybe this wrapper is just used as a fallback? that is the question - is it implemented kernel-wise widely enough to use it? or do we just stick to the old-fashioned self-pipe trick? -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)[EMAIL PROTECTED] - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] e_module-notification installation location
Sebastian Dransfeld wrote: > lok wrote: >> It's not a bug the configure.in are set up this way in most (all?) modules. >> They will be installed in `enlightenment-config --module-dir`. >> Unless you use the --enable-homedir-install option. >> Morlenxus pointed me than the --prefix was ignored, and I thought that it >> might be a handful option for package maintainers (or people with >> various reasons). > > I think package maintainers would like modules to install in a location > where e finds it, so I don't really think we should use --prefix. At > least since modules don't use --prefix like normal apps do. For most > users it isn't logical that ./configure --prefix=/usr in 'e_modules' > wont work with ./configure --prefix=/usr in 'e'. > > Maybe a --set-module-installation-dir option? > > > Sebastian Well, before the great autofoo changes, this used to work. If you passed in a prefix (eg: same prefix as E) it would install to the module directory under E. If you did not pass a prefix, then it installed to the user's home directory (under ~/.e/e/modules) which is a place that E also checks. dh - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: enna captainigloo
Le mercredi 23 janvier 2008 à 10:37 +0100, Peter Wehrfritz a écrit : > Nicolas Aguirre schrieb: > > Le mardi 22 janvier 2008 à 19:48 +0100, Peter Wehrfritz a écrit : > > > >> Wouldn't it be better, if ecore_str_has_suffix() were case-insensitive, > >> because it is most time used to check for extensions? Or maybe to have > >> another function that does the same job, but that use strcasecmp instead > >> strcmp? > >> > >> Peter > >> > > > > Agree with you, but maybe have another function would be better. > > > > > You'll find a patch attached, that adds ecore_str_has_extentsion() which > uses strcasecmp() instead of strcmp(). If there are no objections, I'm > going to commit it in some days > > Peter It's ok for me and, could be very usefull :) Nico - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: libs/evas vapier
> --- Makefile.am 7 Nov 2007 22:56:05 - 1.48 > +++ Makefile.am 25 Jan 2008 04:40:28 - 1.49 > @@ -1,4 +1,4 @@ > -# ACLOCAL_AMFLAGS = -I m4 > +ACLOCAL_AMFLAGS = -I m4 I've added it one day, but raster removed it because he said that it broke make distcheck. Is it still true ? Vincent - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
