[E-devel] EFL 1.24 first abi checker results (beta2)
Hello. I hoped the alpha and beta release are getting picked up by the abi-tracker website directly. That was not the case. Not sure why this is not the case, but I took this as a nudge to setup abi-tracker/upstream-tracker just for efl on my machine. I uploaded the first results now and I would hoep everybody could have a look and see if we have problems here for 1.24 http://www.enlightenment.org/~stefan/abi-tracker/timeline/efl/ regards Stefan Schmidt ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] EFL 1.24 first abi checker results (beta2)
Hi, I checked, and there don't seem to be any issues with the removed symbols. Mike On Wed, Apr 15, 2020 at 9:49 AM Stefan Schmidt wrote: > Hello. > > I hoped the alpha and beta release are getting picked up by the > abi-tracker website directly. That was not the case. Not sure why this > is not the case, but I took this as a nudge to setup > abi-tracker/upstream-tracker just for efl on my machine. > > I uploaded the first results now and I would hoep everybody could have a > look and see if we have problems here for 1.24 > > http://www.enlightenment.org/~stefan/abi-tracker/timeline/efl/ > > regards > Stefan Schmidt > > > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] EFL 1.24 first abi checker results (beta2)
Hello. On 15.04.20 16:15, Mike Blumenkrantz wrote: Hi, I checked, and there don't seem to be any issues with the removed symbols. I agree. We only have three symbol removals and all are ok to me as well. Removed Symbols: Edje_Common.h, libedje.so.1.23.3 edje_3d_object_add ( Evas_Object* obj, Eo** root_node, Eo* scene ) -> The complete Evas3D support was removed and it was only beta eina_types.h, libeina.so.1.23.3 eina_prime_table [data] -> Since table was not accurate and really useless. elm_widget.h, libelementary.so.1.23.3 elm_selection_selection_has_owner ( Evas_Object* obj ) -> Part of elm_widget.h which is not considered stable. If we want this symbol back anyway, Marcel has a patch for this. Not sure if this is worth it. Thoughts? Added Symbols: -- We have 59 new symbols this release. I looked over them and the naming seems sane to me. I would encourage more people to have a look at them as well! I stumbled over ecore_evas_callback_drop_drop_set() but the first drop is the namespace and the function set the drop. Just looked odd. :-) eina_content_* is a complete new API, symbol wise it looks ok to me. I was wondering a bit about the four new eina_matrix4_* functions. With Evas3D gone I thought we would not need them anymore. I was wrong, they are used in our vector graphics code. All good. :-) regards Stefan Schmidt ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] EFL 1.24 first abi checker results (beta2)
Stefan Schmidt wrote on Wed 15/04/20 15:48: > Hello. > > I hoped the alpha and beta release are getting picked up by the abi-tracker > website directly. That was not the case. Not sure why this is not the case, > but I took this as a nudge to setup abi-tracker/upstream-tracker just for > efl on my machine. > > I uploaded the first results now and I would hoep everybody could have a > look and see if we have problems here for 1.24 > > http://www.enlightenment.org/~stefan/abi-tracker/timeline/efl/ Hi, are the warnings like efl_canvas_text_eo.legacy.h, libevas.so.1.23.3 - evas_object_textblock_visible_range_get ( Efl_Canvas_Text* obj, Efl_Text_Cursor_Cursor* start, Efl_Text_Cursor_Cursor* end ) + evas_object_textblock_visible_range_get ( Efl_Canvas_Textblock* obj, Efl_Text_Cursor_Handle* start, Efl_Text_Cursor_Handle* end ) really not a problem? If my code has this: Efl_Canvas_Text *bla; it compiles well with 1.23.3 but 1.24 gives unknown type name 'Efl_Canvas_Text' Regards, Jean Rene ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] EFL 1.24 first abi checker results (beta2)
That is indeed a good question. And i am not sure if this just slipped our fingers here. We even discussed exactly that https://phab.enlightenment.org/D10808#203133. Should we simply revert the changes from that revision in the legacy file ? Implementation wise this is not making any difference at all... Greetings, bu5hm4n On 4/22/20 8:27 AM, Jean Rene Dawin wrote: Stefan Schmidt wrote on Wed 15/04/20 15:48: Hello. I hoped the alpha and beta release are getting picked up by the abi-tracker website directly. That was not the case. Not sure why this is not the case, but I took this as a nudge to setup abi-tracker/upstream-tracker just for efl on my machine. I uploaded the first results now and I would hoep everybody could have a look and see if we have problems here for 1.24 http://www.enlightenment.org/~stefan/abi-tracker/timeline/efl/ Hi, are the warnings like efl_canvas_text_eo.legacy.h, libevas.so.1.23.3 - evas_object_textblock_visible_range_get ( Efl_Canvas_Text* obj, Efl_Text_Cursor_Cursor* start, Efl_Text_Cursor_Cursor* end ) + evas_object_textblock_visible_range_get ( Efl_Canvas_Textblock* obj, Efl_Text_Cursor_Handle* start, Efl_Text_Cursor_Handle* end ) really not a problem? If my code has this: Efl_Canvas_Text *bla; it compiles well with 1.23.3 but 1.24 gives unknown type name 'Efl_Canvas_Text' Regards, Jean Rene ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] EFL 1.24 first abi checker results (beta2)
Hello Jean Rene. On 22.04.20 08:27, Jean Rene Dawin wrote: Stefan Schmidt wrote on Wed 15/04/20 15:48: Hello. I hoped the alpha and beta release are getting picked up by the abi-tracker website directly. That was not the case. Not sure why this is not the case, but I took this as a nudge to setup abi-tracker/upstream-tracker just for efl on my machine. I uploaded the first results now and I would hoep everybody could have a look and see if we have problems here for 1.24 http://www.enlightenment.org/~stefan/abi-tracker/timeline/efl/ Hi, are the warnings like efl_canvas_text_eo.legacy.h, libevas.so.1.23.3 - evas_object_textblock_visible_range_get ( Efl_Canvas_Text* obj, Efl_Text_Cursor_Cursor* start, Efl_Text_Cursor_Cursor* end ) + evas_object_textblock_visible_range_get ( Efl_Canvas_Textblock* obj, Efl_Text_Cursor_Handle* start, Efl_Text_Cursor_Handle* end ) really not a problem? If my code has this: Efl_Canvas_Text *bla; it compiles well with 1.23.3 but 1.24 gives unknown type name 'Efl_Canvas_Text' Thanks a lot for bringing this to our attention. Sorry for missing it in the first place. After some discussion with Marcel Ali came up with a patch that should fix the problem for you. This should fix your problem: https://phab.enlightenment.org/D11744 I am going to push this now. Please let us know if it is working correctly afterwards for you. regards Stefan Schmidt ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] EFL 1.24 first abi checker results (beta2)
Stefan Schmidt wrote on Wed 22/04/20 14:05: > Hello Jean Rene. > > On 22.04.20 08:27, Jean Rene Dawin wrote: > > Stefan Schmidt wrote on Wed 15/04/20 15:48: > > > Hello. > > > > > If my code has this: > > > > Efl_Canvas_Text *bla; > > > > it compiles well with 1.23.3 but 1.24 gives > > > > unknown type name 'Efl_Canvas_Text' > > > > Thanks a lot for bringing this to our attention. Sorry for missing it in the > first place. After some discussion with Marcel Ali came up with a patch that > should fix the problem for you. > > This should fix your problem: > https://phab.enlightenment.org/D11744 > > I am going to push this now. Please let us know if it is working correctly > afterwards for you. > > regards > Stefan Schmidt Thanks. Honestly I don't have code that is affected right now. I just was curious if the warnings of the ABI checker were all harmless and did a test with the code above. Regards, Jean Rene ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] EFL 1.24 first abi checker results (beta2)
Jean Rene Dawin wrote on Wed 22/04/20 19:19: > Stefan Schmidt wrote on Wed 22/04/20 14:05: > > Hello Jean Rene. > > > > On 22.04.20 08:27, Jean Rene Dawin wrote: > > > Stefan Schmidt wrote on Wed 15/04/20 15:48: > > > > Hello. > > > > > > > If my code has this: > > > > > > Efl_Canvas_Text *bla; > > > > > > it compiles well with 1.23.3 but 1.24 gives > > > > > > unknown type name 'Efl_Canvas_Text' > > > > > > > Thanks a lot for bringing this to our attention. Sorry for missing it in the > > first place. After some discussion with Marcel Ali came up with a patch that > > should fix the problem for you. > > > > This should fix your problem: > > https://phab.enlightenment.org/D11744 > > > > I am going to push this now. Please let us know if it is working correctly > > afterwards for you. > > > > regards > > Stefan Schmidt > > Thanks. Honestly I don't have code that is affected right now. > I just was curious if the warnings of the ABI checker were all harmless and > did a test > with the code above. > > Regards, > Jean Rene Ok, with f619a2fbad2dcc81085f14cedaea4fc0df8f2837 Efl_Canvas_Text is fixed. I'm still not sure if a program is supposed to use these types directly in the first place. Similar issues occur with these types: Efl_Canvas_Vg_Container Efl_Canvas_Vg_Node Efl_Text_Cursor_Cursor Regards, Jean Rene ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] EFL 1.24 first abi checker results (beta2)
Hello, For Efl_Canvas_Text and Efl_Text_Cursor_Cursor, I do not think they are supposed to be used anyway especially in a Legacy application (also they were beta anyway), but the defines leaked out from headers. Thanks Ali Alzyod On Thu, Apr 23, 2020 at 12:16 PM Jean Rene Dawin < jda...@math.uni-bielefeld.de> wrote: > Jean Rene Dawin wrote on Wed 22/04/20 19:19: > > Stefan Schmidt wrote on Wed 22/04/20 14:05: > > > Hello Jean Rene. > > > > > > On 22.04.20 08:27, Jean Rene Dawin wrote: > > > > Stefan Schmidt wrote on Wed 15/04/20 15:48: > > > > > Hello. > > > > > > > > > If my code has this: > > > > > > > > Efl_Canvas_Text *bla; > > > > > > > > it compiles well with 1.23.3 but 1.24 gives > > > > > > > > unknown type name 'Efl_Canvas_Text' > > > > > > > > > > Thanks a lot for bringing this to our attention. Sorry for missing it > in the > > > first place. After some discussion with Marcel Ali came up with a > patch that > > > should fix the problem for you. > > > > > > This should fix your problem: > > > https://phab.enlightenment.org/D11744 > > > > > > I am going to push this now. Please let us know if it is working > correctly > > > afterwards for you. > > > > > > regards > > > Stefan Schmidt > > > > Thanks. Honestly I don't have code that is affected right now. > > I just was curious if the warnings of the ABI checker were all harmless > and did a test > > with the code above. > > > > Regards, > > Jean Rene > > Ok, with f619a2fbad2dcc81085f14cedaea4fc0df8f2837 Efl_Canvas_Text is > fixed. > > I'm still not sure if a program is supposed to use these types directly > in the first place. > > Similar issues occur with these types: >Efl_Canvas_Vg_Container >Efl_Canvas_Vg_Node >Efl_Text_Cursor_Cursor > > Regards, > Jean Rene > > > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] EFL 1.24 first abi checker results (beta2)
I can confirm that these are not legacy types and further have never been shipped in a stable release (as of pre-1.24). On Thu, Apr 23, 2020 at 6:34 AM Ali Al-Zyoud wrote: > Hello, > > For Efl_Canvas_Text and Efl_Text_Cursor_Cursor, I do not think they are > supposed to be used anyway especially in a Legacy application (also they > were beta anyway), but the defines leaked out from headers. > > Thanks > Ali Alzyod > > On Thu, Apr 23, 2020 at 12:16 PM Jean Rene Dawin < > jda...@math.uni-bielefeld.de> wrote: > > > Jean Rene Dawin wrote on Wed 22/04/20 19:19: > > > Stefan Schmidt wrote on Wed 22/04/20 14:05: > > > > Hello Jean Rene. > > > > > > > > On 22.04.20 08:27, Jean Rene Dawin wrote: > > > > > Stefan Schmidt wrote on Wed 15/04/20 15:48: > > > > > > Hello. > > > > > > > > > > > If my code has this: > > > > > > > > > > Efl_Canvas_Text *bla; > > > > > > > > > > it compiles well with 1.23.3 but 1.24 gives > > > > > > > > > > unknown type name 'Efl_Canvas_Text' > > > > > > > > > > > > > Thanks a lot for bringing this to our attention. Sorry for missing it > > in the > > > > first place. After some discussion with Marcel Ali came up with a > > patch that > > > > should fix the problem for you. > > > > > > > > This should fix your problem: > > > > https://phab.enlightenment.org/D11744 > > > > > > > > I am going to push this now. Please let us know if it is working > > correctly > > > > afterwards for you. > > > > > > > > regards > > > > Stefan Schmidt > > > > > > Thanks. Honestly I don't have code that is affected right now. > > > I just was curious if the warnings of the ABI checker were all harmless > > and did a test > > > with the code above. > > > > > > Regards, > > > Jean Rene > > > > Ok, with f619a2fbad2dcc81085f14cedaea4fc0df8f2837 Efl_Canvas_Text is > > fixed. > > > > I'm still not sure if a program is supposed to use these types directly > > in the first place. > > > > Similar issues occur with these types: > >Efl_Canvas_Vg_Container > >Efl_Canvas_Vg_Node > >Efl_Text_Cursor_Cursor > > > > Regards, > > Jean Rene > > > > > > ___ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] EFL 1.24 first abi checker results (beta2)
Hello. I just uploaded another run for current git master. http://www.enlightenment.org/~stefan/abi-tracker/objects_report/efl/1.24.0-beta3/current/report.html This looks good for the changes from beta3 to current. If anyone wants to do another review this would be the last chance to do so as I am planning to do the final release on Wednesday. regards Stefan Schmidt ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] EFL 1.24 first abi checker results (beta2)
What about cleaning the build warnings for the release? I'm getting this ones on latest git: [1806/2261] Compiling C object 'src/lib/elementary/f70ca57@@elementary@sha > /efl_ui_widget.c.o'. > In file included from ../src/lib/elementary/efl_ui_widget.c:5701: > src/lib/elementary/efl_ui_widget_part.eo.c: In function > ‘__eolian_efl_ui_widget_part_efl_gfx_entity_scale_set’: > src/lib/elementary/efl_ui_widget_part.eo.c:49:125: warning: unused > parameter ‘scale’ [-Wunused-parameter] >49 | static void > __eolian_efl_ui_widget_part_efl_gfx_entity_scale_set(Eo *obj EINA_UNUSED, > Elm_Part_Data *pd EINA_UNUSED, double scale) > | >~~~^ > [1829/2261] Compiling C object 'src/lib/elementary/f70ca57@@elementary@sha > /efl_ui_view_model.c.o'. > In file included from ../src/lib/elementary/efl_ui_view_model.c:859: > src/lib/elementary/efl_ui_view_model.eo.c: In function > ‘_efl_ui_view_model_property_logic_add_ownership_fallback’: > src/lib/elementary/efl_ui_view_model.eo.c:13:86: warning: unused parameter > ‘get_data’ [-Wunused-parameter] >13 | _efl_ui_view_model_property_logic_add_ownership_fallback(const > char *property, void *get_data, EflUiViewModelPropertyGet get, Eina_Free_Cb > get_free_cb, void *set_data, EflUiViewModelPropertySet set, Eina_Free_Cb > set_free_cb, Eina_Iterator *bound) > | > ~~^~~~ > src/lib/elementary/efl_ui_view_model.eo.c:13:140: warning: unused > parameter ‘get_free_cb’ [-Wunused-parameter] >13 | _efl_ui_view_model_property_logic_add_ownership_fallback(const > char *property, void *get_data, EflUiViewModelPropertyGet get, Eina_Free_Cb > get_free_cb, void *set_data, EflUiViewModelPropertySet set, Eina_Free_Cb > set_free_cb, Eina_Iterator *bound) > | > > ~^~~ > src/lib/elementary/efl_ui_view_model.eo.c:13:159: warning: unused > parameter ‘set_data’ [-Wunused-parameter] >13 | _efl_ui_view_model_property_logic_add_ownership_fallback(const > char *property, void *get_data, EflUiViewModelPropertyGet get, Eina_Free_Cb > get_free_cb, void *set_data, EflUiViewModelPropertySet set, Eina_Free_Cb > set_free_cb, Eina_Iterator *bound) > | > > ~~^~~~ > src/lib/elementary/efl_ui_view_model.eo.c:13:213: warning: unused > parameter ‘set_free_cb’ [-Wunused-parameter] >13 | _efl_ui_view_model_property_logic_add_ownership_fallback(const > char *property, void *get_data, EflUiViewModelPropertyGet get, Eina_Free_Cb > get_free_cb, void *set_data, EflUiViewModelPropertySet set, Eina_Free_Cb > set_free_cb, Eina_Iterator *bound) > | > > > ~^~~ > They seems easy to fix and they give a bad impression on a stable release just my 2 cents Dave Il giorno lun 27 apr 2020 alle ore 16:15 Stefan Schmidt < ste...@datenfreihafen.org> ha scritto: > Hello. > > I just uploaded another run for current git master. > > > http://www.enlightenment.org/~stefan/abi-tracker/objects_report/efl/1.24.0-beta3/current/report.html > > This looks good for the changes from beta3 to current. > > If anyone wants to do another review this would be the last chance to do > so as I am planning to do the final release on Wednesday. > > regards > Stefan Schmidt > > > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] EFL 1.24 first abi checker results (beta2)
Totally agreed. That's generated code, though. Xavi On Mon, 27 Apr 2020 at 19:15, Davide Andreoli wrote: > What about cleaning the build warnings for the release? > I'm getting this ones on latest git: > > [1806/2261] Compiling C object 'src/lib/elementary/f70ca57@@elementary@sha > > /efl_ui_widget.c.o'. > > In file included from ../src/lib/elementary/efl_ui_widget.c:5701: > > src/lib/elementary/efl_ui_widget_part.eo.c: In function > > ‘__eolian_efl_ui_widget_part_efl_gfx_entity_scale_set’: > > src/lib/elementary/efl_ui_widget_part.eo.c:49:125: warning: unused > > parameter ‘scale’ [-Wunused-parameter] > >49 | static void > > __eolian_efl_ui_widget_part_efl_gfx_entity_scale_set(Eo *obj EINA_UNUSED, > > Elm_Part_Data *pd EINA_UNUSED, double scale) > > | > >~~~^ > > [1829/2261] Compiling C object 'src/lib/elementary/f70ca57@ > @elementary@sha > > /efl_ui_view_model.c.o'. > > In file included from ../src/lib/elementary/efl_ui_view_model.c:859: > > src/lib/elementary/efl_ui_view_model.eo.c: In function > > ‘_efl_ui_view_model_property_logic_add_ownership_fallback’: > > src/lib/elementary/efl_ui_view_model.eo.c:13:86: warning: unused > parameter > > ‘get_data’ [-Wunused-parameter] > >13 | _efl_ui_view_model_property_logic_add_ownership_fallback(const > > char *property, void *get_data, EflUiViewModelPropertyGet get, > Eina_Free_Cb > > get_free_cb, void *set_data, EflUiViewModelPropertySet set, Eina_Free_Cb > > set_free_cb, Eina_Iterator *bound) > > | > > ~~^~~~ > > src/lib/elementary/efl_ui_view_model.eo.c:13:140: warning: unused > > parameter ‘get_free_cb’ [-Wunused-parameter] > >13 | _efl_ui_view_model_property_logic_add_ownership_fallback(const > > char *property, void *get_data, EflUiViewModelPropertyGet get, > Eina_Free_Cb > > get_free_cb, void *set_data, EflUiViewModelPropertySet set, Eina_Free_Cb > > set_free_cb, Eina_Iterator *bound) > > | > > > > ~^~~ > > src/lib/elementary/efl_ui_view_model.eo.c:13:159: warning: unused > > parameter ‘set_data’ [-Wunused-parameter] > >13 | _efl_ui_view_model_property_logic_add_ownership_fallback(const > > char *property, void *get_data, EflUiViewModelPropertyGet get, > Eina_Free_Cb > > get_free_cb, void *set_data, EflUiViewModelPropertySet set, Eina_Free_Cb > > set_free_cb, Eina_Iterator *bound) > > | > > > > ~~^~~~ > > src/lib/elementary/efl_ui_view_model.eo.c:13:213: warning: unused > > parameter ‘set_free_cb’ [-Wunused-parameter] > >13 | _efl_ui_view_model_property_logic_add_ownership_fallback(const > > char *property, void *get_data, EflUiViewModelPropertyGet get, > Eina_Free_Cb > > get_free_cb, void *set_data, EflUiViewModelPropertySet set, Eina_Free_Cb > > set_free_cb, Eina_Iterator *bound) > > | > > > > > > ~^~~ > > > > They seems easy to fix and they give a bad impression on a stable release > just my 2 cents > Dave > > > Il giorno lun 27 apr 2020 alle ore 16:15 Stefan Schmidt < > ste...@datenfreihafen.org> ha scritto: > > > Hello. > > > > I just uploaded another run for current git master. > > > > > > > http://www.enlightenment.org/~stefan/abi-tracker/objects_report/efl/1.24.0-beta3/current/report.html > > > > This looks good for the changes from beta3 to current. > > > > If anyone wants to do another review this would be the last chance to do > > so as I am planning to do the final release on Wednesday. > > > > regards > > Stefan Schmidt > > > > > > ___ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] EFL 1.24 first abi checker results (beta2)
Hello Dave. On 27.04.20 19:13, Davide Andreoli wrote: What about cleaning the build warnings for the release? I'm getting this ones on latest git: [1806/2261] Compiling C object 'src/lib/elementary/f70ca57@@elementary@sha /efl_ui_widget.c.o'. In file included from ../src/lib/elementary/efl_ui_widget.c:5701: src/lib/elementary/efl_ui_widget_part.eo.c: In function ‘__eolian_efl_ui_widget_part_efl_gfx_entity_scale_set’: src/lib/elementary/efl_ui_widget_part.eo.c:49:125: warning: unused parameter ‘scale’ [-Wunused-parameter] 49 | static void __eolian_efl_ui_widget_part_efl_gfx_entity_scale_set(Eo *obj EINA_UNUSED, Elm_Part_Data *pd EINA_UNUSED, double scale) | ~~~^ [1829/2261] Compiling C object 'src/lib/elementary/f70ca57@@elementary@sha /efl_ui_view_model.c.o'. In file included from ../src/lib/elementary/efl_ui_view_model.c:859: src/lib/elementary/efl_ui_view_model.eo.c: In function ‘_efl_ui_view_model_property_logic_add_ownership_fallback’: src/lib/elementary/efl_ui_view_model.eo.c:13:86: warning: unused parameter ‘get_data’ [-Wunused-parameter] 13 | _efl_ui_view_model_property_logic_add_ownership_fallback(const char *property, void *get_data, EflUiViewModelPropertyGet get, Eina_Free_Cb get_free_cb, void *set_data, EflUiViewModelPropertySet set, Eina_Free_Cb set_free_cb, Eina_Iterator *bound) | ~~^~~~ src/lib/elementary/efl_ui_view_model.eo.c:13:140: warning: unused parameter ‘get_free_cb’ [-Wunused-parameter] 13 | _efl_ui_view_model_property_logic_add_ownership_fallback(const char *property, void *get_data, EflUiViewModelPropertyGet get, Eina_Free_Cb get_free_cb, void *set_data, EflUiViewModelPropertySet set, Eina_Free_Cb set_free_cb, Eina_Iterator *bound) | ~^~~ src/lib/elementary/efl_ui_view_model.eo.c:13:159: warning: unused parameter ‘set_data’ [-Wunused-parameter] 13 | _efl_ui_view_model_property_logic_add_ownership_fallback(const char *property, void *get_data, EflUiViewModelPropertyGet get, Eina_Free_Cb get_free_cb, void *set_data, EflUiViewModelPropertySet set, Eina_Free_Cb set_free_cb, Eina_Iterator *bound) | ~~^~~~ src/lib/elementary/efl_ui_view_model.eo.c:13:213: warning: unused parameter ‘set_free_cb’ [-Wunused-parameter] 13 | _efl_ui_view_model_property_logic_add_ownership_fallback(const char *property, void *get_data, EflUiViewModelPropertyGet get, Eina_Free_Cb get_free_cb, void *set_data, EflUiViewModelPropertySet set, Eina_Free_Cb set_free_cb, Eina_Iterator *bound) | ~^~~ They seems easy to fix and they give a bad impression on a stable release Its a fair point. As Xavi mentioned already this comes from generated code. I will talk to Daniel to see if we can get this fixed in time for the release. regards Stefan Schmidt ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] EFL 1.24 first abi checker results (beta2)
On Tue, Apr 28, 2020, at 12:12, Stefan Schmidt wrote: > Hello Dave. > > On 27.04.20 19:13, Davide Andreoli wrote: > > What about cleaning the build warnings for the release? > > I'm getting this ones on latest git: > > > > [1806/2261] Compiling C object 'src/lib/elementary/f70ca57@@elementary@sha > >> /efl_ui_widget.c.o'. > >> In file included from ../src/lib/elementary/efl_ui_widget.c:5701: > >> src/lib/elementary/efl_ui_widget_part.eo.c: In function > >> ‘__eolian_efl_ui_widget_part_efl_gfx_entity_scale_set’: > >> src/lib/elementary/efl_ui_widget_part.eo.c:49:125: warning: unused > >> parameter ‘scale’ [-Wunused-parameter] > >> 49 | static void > >> __eolian_efl_ui_widget_part_efl_gfx_entity_scale_set(Eo *obj EINA_UNUSED, > >> Elm_Part_Data *pd EINA_UNUSED, double scale) > >>| > >> ~~~^ > >> [1829/2261] Compiling C object 'src/lib/elementary/f70ca57@@elementary@sha > >> /efl_ui_view_model.c.o'. > >> In file included from ../src/lib/elementary/efl_ui_view_model.c:859: > >> src/lib/elementary/efl_ui_view_model.eo.c: In function > >> ‘_efl_ui_view_model_property_logic_add_ownership_fallback’: > >> src/lib/elementary/efl_ui_view_model.eo.c:13:86: warning: unused parameter > >> ‘get_data’ [-Wunused-parameter] > >> 13 | _efl_ui_view_model_property_logic_add_ownership_fallback(const > >> char *property, void *get_data, EflUiViewModelPropertyGet get, Eina_Free_Cb > >> get_free_cb, void *set_data, EflUiViewModelPropertySet set, Eina_Free_Cb > >> set_free_cb, Eina_Iterator *bound) > >>| > >> ~~^~~~ > >> src/lib/elementary/efl_ui_view_model.eo.c:13:140: warning: unused > >> parameter ‘get_free_cb’ [-Wunused-parameter] > >> 13 | _efl_ui_view_model_property_logic_add_ownership_fallback(const > >> char *property, void *get_data, EflUiViewModelPropertyGet get, Eina_Free_Cb > >> get_free_cb, void *set_data, EflUiViewModelPropertySet set, Eina_Free_Cb > >> set_free_cb, Eina_Iterator *bound) > >>| > >> > >> ~^~~ > >> src/lib/elementary/efl_ui_view_model.eo.c:13:159: warning: unused > >> parameter ‘set_data’ [-Wunused-parameter] > >> 13 | _efl_ui_view_model_property_logic_add_ownership_fallback(const > >> char *property, void *get_data, EflUiViewModelPropertyGet get, Eina_Free_Cb > >> get_free_cb, void *set_data, EflUiViewModelPropertySet set, Eina_Free_Cb > >> set_free_cb, Eina_Iterator *bound) > >>| > >> > >>~~^~~~ > >> src/lib/elementary/efl_ui_view_model.eo.c:13:213: warning: unused > >> parameter ‘set_free_cb’ [-Wunused-parameter] > >> 13 | _efl_ui_view_model_property_logic_add_ownership_fallback(const > >> char *property, void *get_data, EflUiViewModelPropertyGet get, Eina_Free_Cb > >> get_free_cb, void *set_data, EflUiViewModelPropertySet set, Eina_Free_Cb > >> set_free_cb, Eina_Iterator *bound) > >>| > >> > >> > >> ~^~~ > >> > > > > They seems easy to fix and they give a bad impression on a stable release > > Its a fair point. As Xavi mentioned already this comes from generated > code. I will talk to Daniel to see if we can get this fixed in time for > the release. I fixed these specific cases. To do it better bigger refactoring/rewriting will be needed but that's not something to do a day before release > > regards > Stefan Schmidt > > > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
