Re: [Flightgear-devel] Yet another Clouds Patch (again)
Hi,
osg::ref_ptrGeode SGNewCloud::genCloud() {
...
+GeodeList* g = (*iter).second;
+
+if (iter == cloudMap.end() || g-size() num_flavours)
...
dereferencing iterator::end is a no-no (it's not standard c++).
suggest:
GeodeList* g;// = (*iter).second;
if (iter == cloudMap.end() || (g=(*iter).second)-size()
num_flavours)
Also, cull is thru the roof and it looks much nicer :)
greetings,
yon
--
SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
The future of the web can't happen without you. Join us at MIX09 to help
pave the way to the Next Web now. Learn more and register at
http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] Yet another Clouds Patch (again)
Hi Stuart, a little patch for the update callback, this time in a readable and #ifdef'ed format. The update time goes down from 10ms to 1ms on this machine. Fog is still applied. Bonus: trivial patch for annoying unsigned warnings. greetings, yon clouds.patch Description: Binary data -- SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada. The future of the web can't happen without you. Join us at MIX09 to help pave the way to the Next Web now. Learn more and register at http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] Yet another Clouds Patch (again)
On 5 Dec 2008, at 14:23, Yon Uriarte wrote: a little patch for the update callback, this time in a readable and #ifdef'ed format. The update time goes down from 10ms to 1ms on this machine. Fog is still applied. I'd just like to say, this kind of work is appreciated, and much needed in some areas of FG. Cumulatively, it should keep FG usable on more machines, for more people, even with the graphical improvements, which is a great thing. Premature optimisation is a bad thing, but focused, targeted optimisation backed up by real numbers is a (very) good thing. Regards, James -- SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada. The future of the web can't happen without you. Join us at MIX09 to help pave the way to the Next Web now. Learn more and register at http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/ ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] Yet another Clouds Patch (again)
Curt wrote: I did think of that after scratching my head a while ... the metar reported several cloud layers and I did try to switch to a new location as well as switching to fair weather and thunderstorm ... I did get snow and rain, but with a perfectly clear sky. I think there's a bug. I've repro'd it here. I _think_ it may be related to the weather interpolation code I added in the last release. BTW - I've found the source of a long-standing bug were changing the weather scenario when real-weather-fetch was enabled didn't work. -- SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada. The future of the web can't happen without you. Join us at MIX09 to help pave the way to the Next Web now. Learn more and register at http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/ ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] Yet another Clouds Patch (again)
On 5 Dec 2008, at 14:48, Stuart Buchanan wrote: BTW - I've found the source of a long-standing bug were changing the weather scenario when real-weather-fetch was enabled didn't work. Wooo! Fantastic! James -- SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada. The future of the web can't happen without you. Join us at MIX09 to help pave the way to the Next Web now. Learn more and register at http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/ ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] Yet another Clouds Patch (again)
On Thu, Dec 4, 2008 at 2:12 PM, Stuart Buchanan wrote: Hi All, Attached is yet another patch for 3D clouds. Could someone please apply it to CVS? This provides the following enhancements bug fixes - Fix the chequer-board bug. - Add proper cloud coverage function - so scattered clouds are now truly scattered. - Add real-time control for visibility range. - Use a limited set of clouds rather than generating a completely new Geode for each cloud. This saves sorting and display time. - Add controls to Rendering dialog to allow fine-tuning of the number of sprites, cloud visibility and the number of different types of cloud. - Add some variance to the sort back-off to avoid all clouds being sorted at the same time. - Pack attributes into vectors for performance - Re-order the cloud type determination code so that if a cloud layer could either be stratus or cumulus, cumulus is used. - Lowered the cloud level in the standard cloud configuration slightly so a cumulus layer is generated rather than stratus. These last two mean that you should see some 3D cumuli if disabling real weather fetch. My thanks to Yon Uriarte for his help with performance work. On my system, this has saved around 10fps - I'm now getting around 38fps instead of 28fps. As always, feedback is appreciated. I could easily be doing something wrong, or have inherited some configuration setting from a previous version, but before today's patch I had 3d clouds, and now I do not. This is with OSG 2.7.5. Is there anything I can quickly double check? Thanks, Curt. -- Curtis Olson: http://baron.flightgear.org/~curt/ -- SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada. The future of the web can't happen without you. Join us at MIX09 to help pave the way to the Next Web now. Learn more and register at http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] Yet another Clouds Patch (again)
Curtis Olson wrote: I could easily be doing something wrong, or have inherited some configuration setting from a previous version, but before today's patch I had 3d clouds, and now I do not. This is with OSG 2.7.5. Is there anything I can quickly double check? The current weather !? ;-) I just experienced a similar effect and after switching the startup position from KSFO to EHAM I got the clouds back Martin. -- Unix _IS_ user friendly - it's just selective about who its friends are ! -- -- SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada. The future of the web can't happen without you. Join us at MIX09 to help pave the way to the Next Web now. Learn more and register at http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/ ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] Yet another Clouds Patch (again)
On Thu, Dec 4, 2008 at 4:49 PM, Martin Spott wrote: Curtis Olson wrote: I could easily be doing something wrong, or have inherited some configuration setting from a previous version, but before today's patch I had 3d clouds, and now I do not. This is with OSG 2.7.5. Is there anything I can quickly double check? The current weather !? ;-) I just experienced a similar effect and after switching the startup position from KSFO to EHAM I got the clouds back I did think of that after scratching my head a while ... the metar reported several cloud layers and I did try to switch to a new location as well as switching to fair weather and thunderstorm ... I did get snow and rain, but with a perfectly clear sky. I can try to re-cvs update and re-compile things again if other people are working with todays patches ... Curt. -- Curtis Olson: http://baron.flightgear.org/~curt/ -- SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada. The future of the web can't happen without you. Join us at MIX09 to help pave the way to the Next Web now. Learn more and register at http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] Yet another Clouds Patch (again)
Hi, I did think of that after scratching my head a while ... the metar reported several cloud layers and I did try to switch to a new location as well as switching to fair weather and thunderstorm ... I did get snow and rain, but with a perfectly clear sky. I can try to re-cvs update and re-compile things again if other people are working with todays patches ... Curt. -- Curtis Olson: http://baron.flightgear.org/~curt/ Seems to be a bug sicne a while- in the forum someoene else noticed it. -- SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada. The future of the web can't happen without you. Join us at MIX09 to help pave the way to the Next Web now. Learn more and register at http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/ ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] Yet another Clouds Patch (again)
On vendredi 05 décembre 2008, Heiko Schulz wrote: Hi, I did think of that after scratching my head a while ... the metar reported several cloud layers and I did try to switch to a new location as well as switching to fair weather and thunderstorm ... I did get snow and rain, but with a perfectly clear sky. I can try to re-cvs update and re-compile things again if other people are working with todays patches ... Curt. -- Curtis Olson: http://baron.flightgear.org/~curt/ Seems to be a bug sicne a while- in the forum someoene else noticed it. Which is an old bug, before the coming of that new 3D clouds (with the old 3d clouds) I noticed it some years ago , on that mal-list , i had rain without any cloud. and... i remember i got flame (or thunder with lighting) , probably because i said it without flowers :):) -- Gérard http://pagesperso-orange.fr/GRTux/ J'ai décidé d'être heureux parce que c'est bon pour la santé. Voltaire -- SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada. The future of the web can't happen without you. Join us at MIX09 to help pave the way to the Next Web now. Learn more and register at http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/ ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
