Re: pax(1) looping infinitely

2024-06-21 Thread Warner Losh
The last core team announced one.

But you can add Approved by: imp

Warner


On Sat, Jun 22, 2024, 12:16 AM Ganael Laplanche <
ganael.laplan...@martymac.org> wrote:

>
>
> On 6/21/24 23:41, Yuri Pankov wrote:
>
> > .mailmap
>
> Thanks Yuri!
>
> I cannot see any blanket approval for a ports committer modifying that
> file within the src repo.
>
> Can a src committer approve (or commit) the following change please ? :
>
> diff --git a/.mailmap b/.mailmap
> index 0d0231a3da68..3d33acc8d59a 100644
> --- a/.mailmap
> +++ b/.mailmap
> @@ -16,3 +16,4 @@ Jose Luis Duran 
> 
>   Val Packett  
>   Piotr Paweł Stefaniak  
>   Sumit Saxena  
> +Ganael LAPLANCHE  
>
> Thanks in advance,
> Best regards,
>
> --
> Ganael LAPLANCHE 
> http://www.martymac.org | http://contribs.martymac.org
> FreeBSD: martymac , http://www.FreeBSD.org
>
>


Re: pax(1) looping infinitely

2024-06-21 Thread Ganael Laplanche




On 6/21/24 23:41, Yuri Pankov wrote:


.mailmap


Thanks Yuri!

I cannot see any blanket approval for a ports committer modifying that 
file within the src repo.


Can a src committer approve (or commit) the following change please ? :

diff --git a/.mailmap b/.mailmap
index 0d0231a3da68..3d33acc8d59a 100644
--- a/.mailmap
+++ b/.mailmap
@@ -16,3 +16,4 @@ Jose Luis Duran  


 Val Packett  
 Piotr Paweł Stefaniak  
 Sumit Saxena  
+Ganael LAPLANCHE  

Thanks in advance,
Best regards,

--
Ganael LAPLANCHE 
http://www.martymac.org | http://contribs.martymac.org
FreeBSD: martymac , http://www.FreeBSD.org



Re: pax(1) looping infinitely

2024-06-21 Thread Yuri Pankov
Ganael Laplanche wrote:
> 
> 
> Le 21/06/2024 à 18:58, Warner Losh a écrit :
> 
>> My apologies...  I didn't check, but. it's in your sig so I should
>> have. 
> 
> Hey, no pb :)
> 
>> There's a mapping file that can be updated for cases like this.
> 
> Hmmm, I could add my address there. Can you point me to that file, I
> can't find it in the source tree ?

mailmap




Re: pax(1) looping infinitely

2024-06-21 Thread Ganael Laplanche




Le 21/06/2024 à 18:58, Warner Losh a écrit :

My apologies...  I didn't check, but. it's in your sig so I should have. 



Hey, no pb :)


There's a mapping file that can be updated for cases like this.


Hmmm, I could add my address there. Can you point me to that file, I 
can't find it in the source tree ?


Cheers,

--
Ganael LAPLANCHE 
http://www.martymac.org | http://contribs.martymac.org
FreeBSD: martymac , http://www.FreeBSD.org



Re: pax(1) looping infinitely

2024-06-21 Thread Warner Losh
On Fri, Jun 21, 2024 at 10:55 AM Ganael Laplanche <
ganael.laplan...@martymac.org> wrote:

> On 6/21/24 18:44, Warner Losh wrote:
>
> Hi Warner,
>
> > Fixed.
>  >
> > commit 681fd2bed8eaba88693867ba928a1c03a5b152cc (HEAD -> main)
> > Author: Ganael Laplanche 
> Thanks!
>
> > Wrote the commit message and had to guess at the right email to use. But
> > it looked like bz and the mail here were the same.
>
> You could just have used my FreeBSD.org (martymac@) address here.
> Anyway, my personal address is OK too :)
>

My apologies...  I didn't check, but. it's in your sig so I should have.


There's a mapping file that can be updated for cases like this.


> > In the future, simple patches like this might work better as a github
> > pull request, though, since that would resolve all that ambiguity.
>
> Yep, thanks again!
>

You Bet. IT was an easy one to work with since the patch applied cleanly,
it clearly fixed the problem, (which I was able to reproduce and verify
things
were fixed), etc.

Warner


> Cheers,


> --

Ganael LAPLANCHE 

http://www.martymac.org | http://contribs.martymac.org

FreeBSD: martymac , http://www.FreeBSD.org


Re: pax(1) looping infinitely

2024-06-21 Thread Ganael Laplanche

On 6/21/24 18:44, Warner Losh wrote:

Hi Warner,


Fixed.

>

commit 681fd2bed8eaba88693867ba928a1c03a5b152cc (HEAD -> main)
Author: Ganael Laplanche 

Thanks!

Wrote the commit message and had to guess at the right email to use. But 
it looked like bz and the mail here were the same.


You could just have used my FreeBSD.org (martymac@) address here. 
Anyway, my personal address is OK too :)


In the future, simple patches like this might work better as a github 
pull request, though, since that would resolve all that ambiguity.


Yep, thanks again!

Cheers,

--
Ganael LAPLANCHE 
http://www.martymac.org | http://contribs.martymac.org
FreeBSD: martymac , http://www.FreeBSD.org



Re: pax(1) looping infinitely

2024-06-21 Thread Warner Losh
Fixed.

commit 681fd2bed8eaba88693867ba928a1c03a5b152cc (HEAD -> main)
Author: Ganael Laplanche 
Date:   Fri Jun 21 10:39:09 2024 -0600

pax: Terminate loop for empty directory names
..

Wrote the commit message and had to guess at the right email to use. But it
looked like bz and the mail here were the same.

In the future, simple patches like this might work better as a github pull
request, though, since that would resolve all that ambiguity.

Warner


On Fri, Jun 21, 2024 at 4:51 AM Ganael Laplanche <
ganael.laplan...@martymac.org> wrote:

> Hello,
>
> Our pax(1) implementation has a small bug triggered when it is fed with
> a directory containing a trailing slash.
>
> Could a src committer have a look at:
>
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277060
>
> ?
>
> I've submitted a small patch that fixes the problem.
>
> Thanks!
>
> Cheers,
>
> --
> Ganael LAPLANCHE 
> http://www.martymac.org | http://contribs.martymac.org
> FreeBSD: martymac , http://www.FreeBSD.org
>
>


Re: ncurses message spam

2024-06-21 Thread Baptiste Daroussin
On Fri 21 Jun 15:23, Shawn Webb wrote:
> Hey all,
> 
> With the recent changes to ncurses in base, I'm getting a bunch of
> messages (snippet below) on every single new PTY. Every time I open a
> new window in tmux or login via ssh, I'm getting spammed with a flood
> of messages like below.
> 
>  BEGIN LOG 
> Name collision 'tvi950-b' between
> tvi950-b|bare tvi950 no is
> and tvi950-b|bare tvi950 no is
> ...now  bare tvi950 no is 
> Cannot remove alias 'bare tvi950 no is'
> Name collision 'tvi950-ns' between
> tvi950-ns|tvi950 w/no standout
> and tvi950-ns|tvi950 w/no standout   
> ...now  tvi950 w/no standout  
> Cannot remove alias 'tvi950 w/no standout'
> Name collision 'tvi925' between
> tvi925|925|televideo model 925
> and tvi925|925|televideo model 925
> ...now  925|televideo model 925
> ...now  televideo model 925   
> Cannot remove alias 'televideo model 925'
> Name collision 'tvi925vb' between
> tvi925vb|925vb|televideo model 925 visual bells
> and tvi925vb|925vb|televideo model 925 visual bells
> ...now  925vb|televideo model 925 visual bells
> ...now  televideo model 925 visual bells   
> Cannot remove alias 'televideo model 925 visual bells'
> Name collision 'tvi925n' between  
>  
> tvi925n|925n|televideo model 925 no standout or underline
> and tvi925n|925n|televideo model 925 no standout or underline
> ...now  925n|televideo model 925 no standout or underline
> ...now  televideo model 925 no standout or underline
> Cannot remove alias 'televideo model 925 no standout or underline'
> Name collision 'tvi925vbn' between
> tvi925vbn|925vbn|televideo model 925 visual bells no so or ul
> and tvi925vbn|925vbn|televideo model 925 visual bells no so or ul
> ...now  925vbn|televideo model 925 visual bells no so or ul
> ...now  televideo model 925 visual bells no so or ul
> Cannot remove alias 'televideo model 925 visual bells no so or ul'
> Name collision '925a' between
> 925a|tvi925a|TeleVideo Model 925
> and 925a|tvi925a|TeleVideo Model 925
> ...now  tvi925a|TeleVideo Model 925
> ...now  TeleVideo Model 925 
> Cannot remove alias 'TeleVideo Model 925'
> Name collision 'tvi950' between   
>   
>   
> tvi950|950|televideo950
> and tvi950|950|televideo950   
>   
>   
> ...now  950|televideo950  
>   
>   
> ...now  televideo950  
>   
>   
> Cannot remove alias 'televideo950'
>  END LOG 
> 
> Thanks,
> 
> -- 
> Shawn Webb
> Cofounder / Security Engineer
> HardenedBSD
> 
> Tor-ified Signal: +1 303-901-1600 / shawn_webb_opsec.50
> https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc



Do your sync again, this has been fixed a few hours after the ncurses 6.5
upgrade

Bapt



ncurses message spam

2024-06-21 Thread Shawn Webb
Hey all,

With the recent changes to ncurses in base, I'm getting a bunch of
messages (snippet below) on every single new PTY. Every time I open a
new window in tmux or login via ssh, I'm getting spammed with a flood
of messages like below.

 BEGIN LOG 
Name collision 'tvi950-b' between
tvi950-b|bare tvi950 no is
and tvi950-b|bare tvi950 no is
...now  bare tvi950 no is 
Cannot remove alias 'bare tvi950 no is'
Name collision 'tvi950-ns' between
tvi950-ns|tvi950 w/no standout
and tvi950-ns|tvi950 w/no standout   
...now  tvi950 w/no standout  
Cannot remove alias 'tvi950 w/no standout'
Name collision 'tvi925' between
tvi925|925|televideo model 925
and tvi925|925|televideo model 925
...now  925|televideo model 925
...now  televideo model 925   
Cannot remove alias 'televideo model 925'
Name collision 'tvi925vb' between
tvi925vb|925vb|televideo model 925 visual bells
and tvi925vb|925vb|televideo model 925 visual bells
...now  925vb|televideo model 925 visual bells
...now  televideo model 925 visual bells   
Cannot remove alias 'televideo model 925 visual bells'
Name collision 'tvi925n' between
   
tvi925n|925n|televideo model 925 no standout or underline
and tvi925n|925n|televideo model 925 no standout or underline
...now  925n|televideo model 925 no standout or underline
...now  televideo model 925 no standout or underline
Cannot remove alias 'televideo model 925 no standout or underline'
Name collision 'tvi925vbn' between
tvi925vbn|925vbn|televideo model 925 visual bells no so or ul
and tvi925vbn|925vbn|televideo model 925 visual bells no so or ul
...now  925vbn|televideo model 925 visual bells no so or ul
...now  televideo model 925 visual bells no so or ul
Cannot remove alias 'televideo model 925 visual bells no so or ul'
Name collision '925a' between
925a|tvi925a|TeleVideo Model 925
and 925a|tvi925a|TeleVideo Model 925
...now  tvi925a|TeleVideo Model 925
...now  TeleVideo Model 925 
Cannot remove alias 'TeleVideo Model 925'
Name collision 'tvi950' between 

  
tvi950|950|televideo950
and tvi950|950|televideo950 

  
...now  950|televideo950

  
...now  televideo950

  
Cannot remove alias 'televideo950'
 END LOG 

Thanks,

-- 
Shawn Webb
Cofounder / Security Engineer
HardenedBSD

Tor-ified Signal: +1 303-901-1600 / shawn_webb_opsec.50
https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc


signature.asc
Description: PGP signature


pax(1) looping infinitely

2024-06-21 Thread Ganael Laplanche

Hello,

Our pax(1) implementation has a small bug triggered when it is fed with 
a directory containing a trailing slash.


Could a src committer have a look at:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277060

?

I've submitted a small patch that fixes the problem.

Thanks!

Cheers,

--
Ganael LAPLANCHE 
http://www.martymac.org | http://contribs.martymac.org
FreeBSD: martymac , http://www.FreeBSD.org