[Freeciv-Dev] [bug #24394] Help Browser unit/building lists show same icon for all units/buildings

2016-02-08 Thread Marko Lindqvist 
URL:
  

 Summary: Help Browser unit/building lists show same icon for
all units/buildings
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 08 Feb 2016 12:16:30 PM EET
Category: client-sdl2
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.6.0, 3.0.0

___

Details:

This leads also to crash when the there's an attempt to free the same icon
over and over.

Fix attached.



___

File Attachments:


---
Date: Mon 08 Feb 2016 12:16:30 PM EET  Name:
Sdl2HelpBrowserBackgroundTmpl.patch  Size: 987B   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6930] Use AM_PROG_AR instead of AC_CHECK_TOOL(ar)

2016-02-08 Thread Marko Lindqvist 
URL:
  

 Summary: Use AM_PROG_AR instead of AC_CHECK_TOOL(ar)
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 08 Feb 2016 02:10:00 PM EET
Category: bootstrap
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

Replace AC_CHECK_TOOL(ar) with AM_PROG_AR that resolves some portability
problems.

TRUNK patch bumps automake requirement to version 1.11.2 and uses AM_PROG_AR
unconditionally.
S2_6 patch uses AM_PROG_AR if available, fallbacks to AC_CHECK_TOOL(ar)
otherwise.



___

File Attachments:


---
Date: Mon 08 Feb 2016 02:10:00 PM EET  Name: AmProgAr.patch  Size: 3kB   By:
cazfi


---
Date: Mon 08 Feb 2016 02:10:00 PM EET  Name: AmProgAr-S2_6.patch  Size: 872B  
By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24375] Barracks are not getting obsolete by Barracks III

2016-02-08 Thread Marko Lindqvist 
Update of bug #24375 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6912] Public FREECIV_HAVE_LIBREADLINE

2016-02-08 Thread Marko Lindqvist 
Follow-up Comment #1, patch #6912 (project freeciv):

While testing this, I've noticed that there's something our rebuilding rules
do not catch. Once this is applied, fc_config.h does not get automatically
regenerated, leading to compilation failures. If one encounters such problems,
'./config.status --recheck' should be enough to force regeneration of
configure produced files.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6931] Configure check for pathless SDL includes

2016-02-08 Thread Marko Lindqvist 
URL:
  

 Summary: Configure check for pathless SDL includes
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 08 Feb 2016 07:27:46 PM EET
Category: bootstrap
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

We prefer to include "SDL/SDL.h" or "SDL2/SDL.h" instead of just "SDL.h" so
that we always get the right one.
Unfortunately this is not what SDL installation expects us to do. Instead both
sdl-config and pkg-config set include path all the way inside the SDL version
specific directory so one needs to include just "SDL.h". We still can have the
include with path in most cases as the top-level directory is in include path
for some other reason (in most typical case being system default include
directory).

While the problem is on any SDL installation in custom location (so that
top-level directory is not part of include path), I'm currently trying to
solve this for msys2 environment.

I considered making includes "../SDL2/SDL.h" so that it's both relative to
version specific directory (either one of them!) and has the version specific
component, but attached patch takes a bit different approach. If configure
finds to find some SDL headers with "SDL2/SDL.h" -style, it tries plain
"SDL.h" and if that then success, defines SDL_PLAIN_INCLUDES macro. Source
files are then expected to include just "SDL.h" when SDL_PLAIN_INCLUDES is
defined.

Initial version is just for SDL_Mixer support for clients other than SDL/2.



___

File Attachments:


---
Date: Mon 08 Feb 2016 07:27:46 PM EET  Name: SdlPlainInclude.patch  Size: 2kB 
 By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6912] Public FREECIV_HAVE_LIBREADLINE

2016-02-08 Thread Marko Lindqvist 
Update of patch #6912 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24318] unit movement animation time too high

2016-02-08 Thread mir3x 
Follow-up Comment #5, bug #24318 (project freeciv):

I have new idea why cairo is slow

Its because it uses hardware acceleration probably ...  :D
All cairo surfaces are stored in some X server process or video ram. So cairo
uses those surfaces by sending requests to X server. And there is a lot of
those requests for each sprite 
and tile.

Maybe there are also hidden conversions from video ram to freeciv process
somehow.

Or maybe there is some problem with some vertical synchronization ( when
moving map with animation enabled 
gtk3 reports it has much more frames than gtk2 or qt - but it cheats somehow
for sure - because its choppy like hell)

My guess is to force software rendering only and see how it works.


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6932] Public FREECIV_RELEASE_MONTH

2016-02-08 Thread Marko Lindqvist 
URL:
  

 Summary: Public FREECIV_RELEASE_MONTH
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 08 Feb 2016 09:59:49 PM EET
Category: bootstrap
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

Make RELEASE_MONTH public in freeciv_config.h as FREECIV_RELEASE_MONTH

Do not give an error when version.h is included without includeing fc_config.h
first - it's enough to include freeciv_config.h



___

File Attachments:


---
Date: Mon 08 Feb 2016 09:59:50 PM EET  Name: PublicReleaseMonth.patch  Size:
3kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24334] [Metaticket] Public interface incompleteness

2016-02-08 Thread Marko Lindqvist 
Update of bug #24334 (project freeciv):

  Depends on: => patch #6932


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24318] unit movement animation time too high

2016-02-08 Thread Christian Knoke 
Follow-up Comment #6, bug #24318 (project freeciv):

I do not care about video acceleration too much ..., but for my part, I can
tell, this machine shares ist ram with the video chip, and what is relevant
for the graphic in the 3.2 kernel module list, is probably limited to

i915  321689  2 
video  17459  1 i915
drm_kms_helper 22738  1 i915
drm   146387  3 drm_kms_helper,i915


___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6912] Public FREECIV_HAVE_LIBREADLINE

2016-02-08 Thread Jacob Nevins 
Follow-up Comment #4, patch #6912 (project freeciv):

On my system, trunk compilation is failing in a way that "./config.status
--recheck" doesn't help with:


  CC   console.lo
../../server/console.c: In function 'con_update_prompt':
../../server/console.c:98:5: error: implicit declaration of function
'rl_forced_update_display' [-Werror=implicit-function-declaration]
 rl_forced_update_display();
 ^
../../server/console.c:98:5: error: nested extern declaration of
'rl_forced_update_display' [-Werror=nested-externs]
../../server/console.c: At top level:
cc1: error: unrecognized command line option "-Wno-tautological-compare"
[-Werror]
cc1: all warnings being treated as errors
make[2]: *** [console.lo] Error 1
make[2]: Leaving directory `/home/jtn/src/freeciv/git/btrunk/server'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/jtn/src/freeciv/git/btrunk/server'
make: *** [all-recursive] Error 1


Moving the "#include " later in the file makes it build --
after the next line #including "fcbacktrace.h" is sufficient.

I assume that console.c is not ensuring freeciv_config.h is included in the
correct way; but I don't know what the correct way is.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6912] Public FREECIV_HAVE_LIBREADLINE

2016-02-08 Thread Marko Lindqvist 
Follow-up Comment #5, patch #6912 (project freeciv):

> ensuring freeciv_config.h is included in the correct way;

There should be no need to include freeciv_config.h when fc_config.h is
included.

$ grep -r "FREECIV_HAVE_LIBREADLINE" gen_headers/
gen_headers/freeciv_config.h:#define FREECIV_HAVE_LIBREADLINE 1
gen_headers/fc_config.h:#define FREECIV_HAVE_LIBREADLINE 1

Try running './autogen.sh --no-configure-run' first (to make sure autoheader
has run and regenerated fc_config.h.in template) and './config.status
--recheck' only then.

$ grep -r "FREECIV_HAVE_LIBREADLINE" ../src/gen_headers/fc_config.h.in
#undef FREECIV_HAVE_LIBREADLINE

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6912] Public FREECIV_HAVE_LIBREADLINE

2016-02-08 Thread Jacob Nevins 
Follow-up Comment #6, patch #6912 (project freeciv):

> Try running './autogen.sh --no-configure-run' first (to make 
> sure autoheader has run and regenerated fc_config.h.in template) 
> and './config.status --recheck' only then. 
Yes, that worked. (Should have thought of that.)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24018] The AI players are extremely slow during europe_1901's turn change

2016-02-08 Thread Marko Lindqvist 
Follow-up Comment #11, bug #24018 (project freeciv):

Some S2_6 autogame analysis (not with Europe 1901 scenario) indicates that AI
looking for new city spots takes significant portion of the CPU usage. One we
get the scenario updated to S2_6 format, we can presumably set
scenario.prevent_new_cities for it. This in turn should stop AI from even
trying to look for new city spots.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6933] Replace road_type_iterate() with extra_type_by_cause_iterate(EC_ROAD) everywhere

2016-02-08 Thread Marko Lindqvist 
URL:
  

 Summary: Replace road_type_iterate() with
extra_type_by_cause_iterate(EC_ROAD) everywhere
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 09 Feb 2016 03:03:51 AM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

Replace all remaining uses of road_type_iterate() with
extra_type_by_cause_iterate(EC_ROAD) construct. Almost all places where this
was done, lost some back-and-forth conversions extra->road->extra
('extra->road' part hidden inside the road_type_iterate() macro, 'road->extra'
part sometimes hidden in then called functions of the road_ -family)



___

File Attachments:


---
Date: Tue 09 Feb 2016 03:03:52 AM EET  Name: RoadTypeIterateRm-S2_6.patch.bz2 
Size: 7kB   By: cazfi


---
Date: Tue 09 Feb 2016 03:03:51 AM EET  Name: RoadTypeIterateRm.patch.bz2 
Size: 8kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19561] No indication of connection loss

2016-02-08 Thread Marko Lindqvist 
Update of bug #19561 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #6:

- Added client option to control the behavior
- Changed packet number within correct range
- Renamed dummypong as heartbeat

(file #26657, file #26658)
___

Additional Item Attachment:

File name: Heartbeat.patchSize:5 KB
File name: Heartbeat-S2_6.patch   Size:5 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6910] Arch specific msys2 based Installer build and temporary install directories

2016-02-08 Thread Marko Lindqvist 
Update of patch #6910 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6934] Inline map_move_cost() & map_move_cost_unit()

2016-02-08 Thread Marko Lindqvist 
URL:
  

 Summary: Inline map_move_cost() & map_move_cost_unit()
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 09 Feb 2016 08:14:01 AM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.4, 2.6.0, 3.0.0

___

Details:

Avoid extra function call overhead from map_move_cost() and
map_move_cost_unit() functions that are just wrappers to tile_move_cost_ptrs()



___

File Attachments:


---
Date: Tue 09 Feb 2016 08:14:02 AM EET  Name: MapMoveCostInline.patch  Size:
4kB   By: cazfi


---
Date: Tue 09 Feb 2016 08:14:02 AM EET  Name: MapMoveCostInline-S2_5.patch 
Size: 5kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6909] Load Goods names before they are needed

2016-02-08 Thread Marko Lindqvist 
Update of patch #6909 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #1:

Patch

(file #26661)
___

Additional Item Attachment:

File name: GoodsNamesLoad.patch   Size:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24395] Move cost for RMM_RELAXED diagonal move between integrating roads

2016-02-08 Thread Marko Lindqvist 
URL:
  

 Summary: Move cost for RMM_RELAXED diagonal move between
integrating roads
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 09 Feb 2016 08:45:54 AM EET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.6.0, 3.0.0

___

Details:

The check for between-tile road in move cost calculation for RMM_RELAXED
diagonal move between integrating roads expects destination road. It does not
allow (even) situation where the between tile has same road type as the source
tile.

More complex cases about between-tile having road type distinct from both
source and destination are already noted in bug #24242. This one is less
acceptable as only the source and destination road types are involved, and the
direction matters (moving around the same corner has different cost depending
which way one moves)

Fix attached.




___

File Attachments:


---
Date: Tue 09 Feb 2016 08:45:54 AM EET  Name: AllowIextraInBetween.patch  Size:
2kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24242] is_native_move() and "Relaxed" move_mode not considering possibility of three road types

2016-02-08 Thread Marko Lindqvist 
Follow-up Comment #1, bug #24242 (project freeciv):

More generally: Problem exist when between-tile has integrating road type
distinct from both source and destination. This can be third road type, but
there's also the case where source and destination are the same and
between-tile is the only one with different road type.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6329] pf_normal_map_iterate() optimization

2016-02-08 Thread Marko Lindqvist 
Follow-up Comment #1, patch #6329 (project freeciv):

> Server side autogames (S2_6) regularly show over 38% of the time being spent
in pf_normal_map_iterate().

That's something that has clearly changed between S2_5 and S2_6. While
pf_normal_map_iterate() is on the top of the list in S2_5 too, there its share
is about 12%.

I did an experiment where I created exact copy of the function, named
pf_normal_reversed_map_iterate() and changed callers so that the new copy was
used when ever reverse maps are being iterated.
It's possible that compiler optimization made the two copies of the function
partly merge - so take these results with grain of salt - but on that run
pf_normal_reverser_map_iterate() took about 34% of CPU time while
pf_normal_map_iterate() took less than 1%.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6900] Add support for "emergency" release version number part

2016-02-08 Thread Marko Lindqvist 
Update of patch #6900 (project freeciv):

  Status: In Progress => Ready For Test 
 Planned Release: 2.5.4, 2.6.0, 3.0.0 => 2.6.0, 3.0.0   

___

Follow-up Comment #4:

Patches for S2_6 & TRUNK. Dropped S2_5 target.

(file #26663, file #26664)
___

Additional Item Attachment:

File name: EmergencyVersion.patch Size:2 KB
File name: EmergencyVersion-S2_6.patchSize:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6935] Make version numbers in savegame3 100 times bigger

2016-02-08 Thread Marko Lindqvist 
URL:
  

 Summary: Make version numbers in savegame3 100 times bigger
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 09 Feb 2016 09:51:19 AM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0

___

Details:

Make freeciv version number indicator saved to savegames 100 times bigger in
case of savegame3.c. We may end up using new lowest digits for "emergency"
version part ( patch #6900 ) or maybe not, but reserving the space now that we
have the opportunity (as part of introducing completely new savegame3 module)
makes sense.
I'm not for introducing similar thing to savegame2.c for the benefit of S2_6.
There it wouldn't be unconditionally (already released versions of freeciv
have not saved version that way) and adding the complexity is not worth the
little potential (realize only if we ever end up making S2_6 emergency
release, and decide to do it using four-part-version-number mechanism)
benefit.



___

File Attachments:


---
Date: Tue 09 Feb 2016 09:51:19 AM EET  Name: Savegame3Verx100.patch  Size: 2kB
  By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev