[Freevo-devel] Re: [PATCH] Detached player
On Wednesday 15 September 2004 21:18, Dirk Meyer wrote: Define 'after a while'. I works ok here. Maybe it depends on the text you draw? For me it happens after 15-20 minutes. Try setting high fps on the animation, and it will happen even quicker. Good. I changed some stuff in the eventhandler so that you don't need to show() the menuw. By calling p.hide(), the eventhandler know sees that no application has the focus and set the focus to the last application below p. Good! Nice, very nice. Maybe not use the osd for displaying the text but draw it just below the control box? And handling it as popup box is exactly the way to go. The OSD_MESSAGE was a last minute thing as I thought the buttons needed some more explanation than just the image. I'll see if I can find a better way to display it. [RE: mail 2] And something irritating: When you show the control, I _see_ a stop button, but can't press it becuase you don't understand that event (it's not mapped). Maybe define an extra keymap for each buttonbar, too? Or each button? Hmm, what do you mean? Pressing the stop button works just fine here. Or are you saying we sould listen to other events such as the STOP button mapped on the remote/keyboard? [RE: mail 3] BTW, can you send a patch to respect the coding guidelines? Before you ask: they are only in my haed for now :-). You respected most of my guidelines, only small things: o please do not use more than 80 chars in a line o every function needs a doc string o the header of a file needs a doc what this file does o more internal docs (# comments) what you are doing here Check the image viewer for a good example. I know, writing docs suck, but we need better development docs. I'll try to document better in the future. I have an exam monday, I doubt I have the time to fix anything before that. Viggo -- I'm not prejudiced, I hate everyone equally. --- This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170 Project Admins to receive an Apple iPod Mini FREE for your judgement on who ports your project to Linux PPC the best. Sponsored by IBM. Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php ___ Freevo-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/freevo-devel
[Freevo-devel] Re: [PATCH] Detached player
Viggo Fredriksen wrote: On Wednesday 15 September 2004 21:18, Dirk Meyer wrote: Define 'after a while'. I works ok here. Maybe it depends on the text you draw? For me it happens after 15-20 minutes. Try setting high fps on the animation, and it will happen even quicker. I will try. The OSD_MESSAGE was a last minute thing as I thought the buttons needed some more explanation than just the image. I'll see if I can find a better way to display it. Maybe add two text fields above to buttons. The first showing the name of the control (Audioplayer), the second the current button. Aubin: since you are our designer, any suggestions how this should look like? And something irritating: When you show the control, I _see_ a stop button, but can't press it becuase you don't understand that event (it's not mapped). Maybe define an extra keymap for each buttonbar, too? Or each button? Hmm, what do you mean? Pressing the stop button works just fine here. Or are you saying we sould listen to other events such as the STOP button mapped on the remote/keyboard? Yes, I mean the stop button on my remote. Or 's' in keyboard mode. BTW, can you send a patch to respect the coding guidelines? Before you ask: they are only in my haed for now :-). You respected most of my guidelines, only small things: o please do not use more than 80 chars in a line o every function needs a doc string o the header of a file needs a doc what this file does o more internal docs (# comments) what you are doing here Check the image viewer for a good example. I know, writing docs suck, but we need better development docs. I'll try to document better in the future. I have an exam monday, I doubt I have the time to fix anything before that. Good luck. Dischi -- Bills travel through the mail at twice the speed of checks. pgptoG9ixVAVB.pgp Description: PGP signature
[Freevo-devel] Re: [PATCH] Detached player
Viggo Fredriksen wrote: Hi! Hi Attached is a patch for a new detached player. This looks so cool. But we need to define a default key button (not only keyboard) for the control box. It's mostly finished but it has a serious bug which I can't seem to find the reason for. I get Fatal python error: Deallocating None in my DetachbarAnimation after it's been running for a while. This might be a mevas error for all I know, so I don't want to spend any more time pulling my hair over this. Define 'after a while'. I works ok here. Maybe it depends on the text you draw? self.itemcanvas.set_image(gui.Text(elapsed, (0,0), size, self.elapsed_font)) I may understand it here because you replace the image. self.canvas.image.clear() self.canvas.draw_image(obj, src_pos=srcpos) But here? Very strange. I hope Tack will be back again soon to have a look why this happens. It looks like a bug in pyimlib2. Am I doing something horribly wrong here? No, looks good. About the changes: - Removed detachbar.py - Merged new detachbar with detach.py (detachbar is shown based on a plugin activation argument). It no longer shows up in the menu, instead it utilizes the new controlmanager. Good. I changed some stuff in the eventhandler so that you don't need to show() the menuw. By calling p.hide(), the eventhandler know sees that no application has the focus and set the focus to the last application below p. - Added a new class ControlManager for managing different controls. The class basicly listens to TOGGLE_CONTROL events and shows/hides the registered controls. (better naming for this class?) Nice, very nice. Maybe not use the osd for displaying the text but draw it just below the control box? And handling it as popup box is exactly the way to go. - Added ButtonPanel as an example for use with the ControlManager, this is also the one I use to create the audio detached control. It's not pretty, but I didn't have any good ideas for how it should look. Some problem here. In CVS in 5 minutes, thanks again. Dischi -- I think there's a world market for about five computers. -- attr. Thomas J. Watson (Chairman of the Board, IBM), 1943 pgpIoDJXaFsm4.pgp Description: PGP signature
[Freevo-devel] Re: [PATCH] Detached player
Dirk Meyer wrote: Viggo Fredriksen wrote: Hi! Hi Attached is a patch for a new detached player. This looks so cool. But we need to define a default key button (not only keyboard) for the control box. It's mostly finished but it has a serious bug which I can't seem to find the reason for. I get Fatal python error: Deallocating None in my DetachbarAnimation after it's been running for a while. This might be a mevas error for all I know, so I don't want to spend any more time pulling my hair over this. One bug: after the playlist is done, you don't remove the idlebar plugin. And something irritating: When you show the control, I _see_ a stop button, but can't press it becuase you don't understand that event (it's not mapped). Maybe define an extra keymap for each buttonbar, too? Or each button? Dischi -- printk(What? oldfid != cii-c_fid. Call 911.\n); 2.4.3 linux/fs/coda/cnode.c pgpT14mSA7aL0.pgp Description: PGP signature
[Freevo-devel] Re: [PATCH] Detached player
Dirk Meyer wrote: Dirk Meyer wrote: Viggo Fredriksen wrote: Hi! Hi Attached is a patch for a new detached player. This looks so cool. But we need to define a default key button (not only keyboard) for the control box. It's mostly finished but it has a serious bug which I can't seem to find the reason for. I get Fatal python error: Deallocating None in my DetachbarAnimation after it's been running for a while. This might be a mevas error for all I know, so I don't want to spend any more time pulling my hair over this. One bug: after the playlist is done, you don't remove the idlebar plugin. OK, fixed. You registered to the PLAY_STOP event but that doesn't add the item as argument. I fixed it by checking the player in the animation. BTW, registering to PLAY_STOP had a bad side-effect. Your plugin got all PLAY_STOP and nothing else worked. Now, a registered eventhandler must return True if he used it, if not, it goes the normal eventhandler chain. BTW, can you send a patch to respect the coding guidelines? Before you ask: they are only in my haed for now :-). You respected most of my guidelines, only small things: o please do not use more than 80 chars in a line o every function needs a doc string o the header of a file needs a doc what this file does o more internal docs (# comments) what you are doing here Check the image viewer for a good example. I know, writing docs suck, but we need better development docs. Dischi -- Monday is an awful way to spend 1/7th of your life. pgpjYqAi3faTK.pgp Description: PGP signature
