[Freevo-devel] Re: view thoughts in the new skin
Dirk Meyer wrote: Gustavo Sverzut Barbieri wrote: What about using the way Zope does: ifdef filename Filename: getvar filename endif It's ok IMO, and even it's XML compilant... so no need to know python code. Nice, I like that. I don't know how to do that in Python (mixture of cdata and tags), but I will try to figure that out. Great idea. I will support ifdef, ifndef, else and endif as conditions, and getvar as command. Oops, sorry, it's no xml. It will be ifdef var=filename Filename: get var=filename/ ifdef You can also use ifndef, else is not supported. For the cols, tab instead of \t? Or hflush? justify? [2 min later] Or if condition=filename .. /if and we could also support condition=filename title or condition=filename || title. And you can put if inside if. Dischi -- A lecture is a process where information is passed from the notebook of the lecturer to the notebook of the student without necessarily passing through the minds of either. --- This SF.net email is sponsored by: Tablet PC. Does your code think in ink? You could win a Tablet PC. Get a free Tablet PC hat just for playing. What are you waiting for? http://ads.sourceforge.net/cgi-bin/redirect.pl?micr5043en ___ Freevo-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/freevo-devel
[Freevo-devel] Re: view thoughts in the new skin
Gustavo Sverzut Barbieri wrote: --- Dirk Meyer [EMAIL PROTECTED] escreveu: Gustavo Sverzut Barbieri wrote: --- Dirk Meyer [EMAIL PROTECTED] escreveu: Also it would be great if UP/DOWN/LEFT/RIGHT wouldn't rebuild the table all the time, only change self.selected if the table is still the same. BTW, Huum... I really don't remember the code, need to review it if you want. That would be great Ok, it's almost done. The one thing I miss is where to disable clearing the whole screen before calling update_content(). Ie: When I move the selected item, I only see the last selected (that was reblited) and the new selected one (that was hilighted). Also, the headers go away... Oh, there was a missunderstanding. | Also it would be great if UP/DOWN/LEFT/RIGHT wouldn't rebuild the | table all the time, only change self.selected if the table is still | the same. BTW, In menutable.py rebuild build the table to display. I only thought about: if the table is identical (== same channels, same start time), don't rebuild it, only set self.selected to the new item. The problem is right now: you _must_ draw everything. It's no drawing, it's pretend-to-draw. If you don't draw a text, the skin thinks this as a difference to the prev. view and redraws the screen without than information. This one was said in a previous email (maybe pass another argument 'dummy=TRUE'... you didn't comment on that). dummy=TRUE are maybe easier color=None (0 == black, but None is not taken). And what hack you did on the drawstringframedsoft() ? drawstringframedsoft returns the coordinates where the drawing took place as second return value. drawstringframedhard only returns (0,0,0,0) Dischi -- - Hi! I'm a .signature virus! Copy me into your ~/.signature to help me spread! - --- This SF.net email is sponsored by: Does your code think in ink? You could win a Tablet PC. Get a free Tablet PC hat just for playing. What are you waiting for? http://ads.sourceforge.net/cgi-bin/redirect.pl?micr5043en ___ Freevo-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/freevo-devel
Re: [Freevo-devel] Re: view thoughts in the new skin
--- Dirk Meyer [EMAIL PROTECTED] escreveu: Gustavo Sverzut Barbieri wrote: --- Dirk Meyer [EMAIL PROTECTED] escreveu: Gustavo Sverzut Barbieri wrote: --- Dirk Meyer [EMAIL PROTECTED] escreveu: Gustavo Sverzut 6. No grey skin These one could be the latest item to cover... Agreed. OK, I lied. There is now a grey skin. But only the menu is like grey1, tv and audio are like blue1. The reason for this skin: it's now possible to use name instead of numbers for colors and then use color to define the color. The grey1 skin is an example how to change colors, images and fonts of an existing skin to create a new one. I saw :) Looks good anyway. I meant the menu look as before... selected item has darker bg. but's only skin xml I used it because blue1 used a darker selection color. But it's very easy, change color label=selected to a new color and all selection bars are new. BTW, I also like your light-blue better than darkening the selection. Ok. 12. Finish integration of Robs new gui stuff That's good. What is the current progress? Right now you won't see any popups with my skin because the drawpopup function is disabled. But in videoitem.py are two popups that work with the gui code (when you scan the dvd for titles). But it's very easy to integrate the gui code in other files, too. Ok... I want to play with that... any idea on menus/popups to the movies? At first we should change most of the files like videoitem.py (just grep for config.NEW_SKIN is the file) 1. Don't import skin or osd, use gui for all drawing stuff 2. Create the gui objects (again grep for config.NEW_SKIN in videoitem.py) Ok, I'll see. Ok, but we can make the OSD show the line ONLY if we have at least one (or maybe we need all) of the variables (if we have one) of that line, so we wont get empty-meaning lines, like: Title: ??? I'm not happy with the current way to define what to display. All this \t and @var@ doesn't look good. Yeah, but there is another cleaner solution? and just a notice, try to enable the Filename: [EMAIL PROTECTED]@ on the XML, you'll see that if we are viewing a movie.fxd, you don't have the filename... why? it's a bug, IMO I'll look into that. I'm not familiar with that new xml code. But if the fxd file contains more than one movie file, a videoitem has subitems and the first one has no filename to play (and that has to be this way). Maybe we could make a special treatment in getattr for this. Yeah... but we have to see this filename issue. I used the filename since we should always have it :) Maybe this one could be grouped with the \t @var@ issue and we could create some conditionals... maybe using some kind of PHP in our XML :) Like: ?python if not title: print Filename: %s % filename It's dirty IMO, but it's cool :) Agreed. I will thing about it, maybe a box around the info area like you had. I'm also thinking about Aubins idle bar. We need a way to configure the look of it (what items to display). Maybe the item bar can ask the skin am I visible? What are my colors? Where can I draw myself?. Than we could make a 6th area: bararea or panelarea. maybe we can, first, do it at a user-level, just have the user to not specify coordinates that overlap the bar_area. Later we can make something like bliting the bar_area later, after the whole screen becomes ready. I was talking about making the bar_area a new area, like View, Info, Listing. But handled by the OSD and not any other thing (menu, music player, image viewer, etc) So we always have it displayed. We should assing a RC key to toggle it on/off and make it default off when viewing images or movies, but be able to toggle it on when that key was pressed. (we could use the mplayer's bmovl to do that in movies) Gustavo ___ Busca Yahoo! O serviço de busca mais completo da Internet. O que você pensar o Yahoo! encontra. http://br.busca.yahoo.com/ --- This SF.net email is sponsored by: Does your code think in ink? You could win a Tablet PC. Get a free Tablet PC hat just for playing. What are you waiting for? http://ads.sourceforge.net/cgi-bin/redirect.pl?micr5043en ___ Freevo-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/freevo-devel
[Freevo-devel] Re: view thoughts in the new skin
Gustavo Sverzut Barbieri wrote: --- Dirk Meyer [EMAIL PROTECTED] escreveu: Gustavo Sverzut Barbieri Please take a look at blue1_big.xml and blue2_big.xml, I would like to hear some comments from you what you thing about the xml structure. Wow! It's gorgeous... Thanks. I'll myself write a skin when we got that finnish or when I have time (the one that arives first) :-) 1. no view area for the tv menu We really need it now? I don't use the TV Guide myself, but IMO it's not usefull. I made that as a reference. It may be useful if someday we can use a channel preview of what's playing right now on that channel. Good idea. If we skip it, we have more space for the info area. 2. no indicators for tv items and UP/DOWN for more items than you see Is that that difficult? No, some points on my list are very simple. 3. DISPLAY can only toggle between two styles Again, how difficult is to implement unlimited styles? Very easy. But I didn't tocuhed the toggle code yesterday. The good thing about my TODO list I posted is, that I can do lots of it in a very short time. I like that about a TODO list ;-) 6. No grey skin These one could be the latest item to cover... Agreed. We still need to port the round as it was before. What do you mean? It's the same as before (except the image listing and that's no Python, it's xml work). Maybe we use as 'default' the new Aubin's skin. Agreed. The current default skin is a skin I only made as example for round boxes, it wasn't designed to be a default skin. I think it will not offense anyone, since Aubin was the author of the other skins too :) Aubin has a better look about what's looking good and what not. Aubin, if you have some time, maybe you could add image listings to your skin. 12. Finish integration of Robs new gui stuff That's good. What is the current progress? Right now you won't see any popups with my skin because the drawpopup function is disabled. But in videoitem.py are two popups that work with the gui code (when you scan the dvd for titles). But it's very easy to integrate the gui code in other files, too. One thing is missing from blue2: when I select a file that has no XML, I got no info! we must provide at least the filename. The name is in the title area and I don't thing we need the real filename. But I'm only doing the Python stuff, if a skin designer what to display that information, it's all part of the xml file. And I like the 3 views placed as before... I like the placing as it is now, but the good thing with my skin is, it's very easy to replace the areas to the way it looked before. or at least we need more contrast in blue2... Agreed. I will thing about it, maybe a box around the info area like you had. I'm also thinking about Aubins idle bar. We need a way to configure the look of it (what items to display). Maybe the item bar can ask the skin am I visible? What are my colors? Where can I draw myself?. Than we could make a 6th area: bararea or panelarea. but it's just decoration stuff that can be done later by someone more experienced, Aubin? :) Help us! PS: Why we define iconset and don't use it? See blue1_big.xml main Right now we don't need it in blue1, but blue2 uses it to find the default images for the image listing. But I also want to use it in the mainmenu definition. But there are more things to change. We should get away with all relative images paths... neither the ../images IMHO we should make really use a icon set. When you change it, you change everything. OK, what about you give an image name and the image will be searched in ., skin/images, skin/main1 (skin/dischi1 until it's not the main1 skin). Dischi -- Unnamed Law: If it happens, it must be possible. --- This SF.net email is sponsored by:Crypto Challenge is now open! Get cracking and register here for some mind boggling fun and the chance of winning an Apple iPod: http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0031en ___ Freevo-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/freevo-devel
[Freevo-devel] Re: view thoughts in the new skin
Gustavo Sverzut Barbieri wrote: --- Dirk Meyer [EMAIL PROTECTED] escreveu: Also it would be great if UP/DOWN/LEFT/RIGHT wouldn't rebuild the table all the time, only change self.selected if the table is still the same. BTW, Huum... I really don't remember the code, need to review it if you want. That would be great I don't use your ExtendedMenu anymore, your code is now in tv/tvmenu.py. Ok, great... I hope it now fits in our new XML skin. Yes, most of it was copy-paste from your code. The main difference is that I don't have different draw functions for the different areas and some internal names are like they are in the normal menu. The second thing is drawstringframed. Do know the area this function will draw I want the coordinates back. I hacked it into the soft-function some time ago, the hard-function is still not ready. Since it's your code, maybe you could add that. I also would like to have a pretend-to-draw function. I only want the coordinates, don't draw. Right now I use a dummy layer for that, but that's not the correct way of doing it. Maybe color==None will be the pretend-mode. Do you want the draw area? The area it may draw you pass as parameter. but it's easy to do. It now returns the not-draw string. But as you know the x0,y0 and the x,y (last draw) you can make: return_y = y # last draw X return_x = (y y0) ? x0+width : x # return x if we only have one line or the x+width if we have more than 1 lines No, I don't want to draw. I only want the coordinates where the text would be if I would really draw. Dischi -- This file will self-destruct in five minutes. --- This SF.net email is sponsored by:Crypto Challenge is now open! Get cracking and register here for some mind boggling fun and the chance of winning an Apple iPod: http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0031en ___ Freevo-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/freevo-devel
Re: [Freevo-devel] Re: view thoughts in the new skin
On Thu, Mar 13, 2003 at 05:16:55PM +0100, Dirk Meyer wrote: The second thing is drawstringframed. Do know the area this function will draw I want the coordinates back. I hacked it into the soft-function some time ago, the hard-function is still not ready. Since it's your code, maybe you could add that. I also would like to have a pretend-to-draw function. I only want the coordinates, don't draw. Right now I use a dummy layer for that, but that's not the correct way of doing it. Maybe color==None will be the pretend-mode. I hacked the main1_tv.py skin to return an array of co-ordinates by the timeslot which is the channel_id and the start time in UTC; then, to redraw an item, I just do redraw old surface surface = getsurface(array[channel_id and time] drawhighlighted area (array[channel_id and time]) return Then, each time it's called, it draws the old surface back, and draws the new one, so the surface variable always contains the previous surface. Aubin --- This SF.net email is sponsored by:Crypto Challenge is now open! Get cracking and register here for some mind boggling fun and the chance of winning an Apple iPod: http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0031en ___ Freevo-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/freevo-devel
[Freevo-devel] Re: view thoughts in the new skin
Gustavo Sverzut Barbieri wrote: --- Dirk Meyer [EMAIL PROTECTED] escreveu: Gustavo Sverzut Barbieri Maybe it's better to help with ideas than with the code itself. There are some undocumented things right now which aren't easy to unterstand. Sure... :) There are some points you can help (since it's your code). First of all, I don't like the behavior of UP/DOWN in the tv menu. Select an item, than move up and down some times and go back to the channel from the beginning. There is a different item selected now. Maye you shouldn't take the start time of the current item as start time and remember a start time when you moved LEFT/RIGHT the last time. Also it would be great if UP/DOWN/LEFT/RIGHT wouldn't rebuild the table all the time, only change self.selected if the table is still the same. BTW, I don't use your ExtendedMenu anymore, your code is now in tv/tvmenu.py. The second thing is drawstringframed. Do know the area this function will draw I want the coordinates back. I hacked it into the soft-function some time ago, the hard-function is still not ready. Since it's your code, maybe you could add that. I also would like to have a pretend-to-draw function. I only want the coordinates, don't draw. Right now I use a dummy layer for that, but that's not the correct way of doing it. Maybe color==None will be the pretend-mode. IMHO we should get the extended off the name. Since all menus are these type now. Agreed, but I haven't found a better name yet -- maybe we don't need one, we'll see. Just menu. OK Proposal: menu type=audio !-- definition of audio menus -- use image=my image text=my text menu with info/ use image= text=my text menu/ /menu I don't like the name use, but I already use layout. What about style or variant. Sounds both ok for me. If we want to name it layout, maybe we could rename the current layout tag. But style is also ok. This menu set defines that DISPLAY should toggle between these two use types (I _really_ don't like use). The first one (default) has an image version and a text version. Normally my image will be taken, if all covers look the same, my text menu with info is displayed. If you press DISPLAY you toggle. There is no image version, so it's text mode only and my text menu will be used. Idea: maybe variant is better than use After that, we need to define my image and all the other menus. This looks like the normal menus in my skin now, only the name is now menu_layout: menu_layout name=my image screen .../ listing .../ info .../ view .../ title .../ /menu_layout The skin designer can define as much different menus to toggle as he likes. Comments? Yes, perfect :) Thanks, I will do that next weekend (or maybe this evening) Dischi -- Three things are certain: Death, taxes, and lost data. Guess which has occurred... --- This SF.net email is sponsored by:Crypto Challenge is now open! Get cracking and register here for some mind boggling fun and the chance of winning an Apple iPod: http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0031en ___ Freevo-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/freevo-devel
Re: [Freevo-devel] Re: view thoughts in the new skin
--- Dirk Meyer [EMAIL PROTECTED] escreveu: Gustavo Sverzut Barbieri wrote: --- Dirk Meyer [EMAIL PROTECTED] escreveu: Gustavo Sverzut Barbieri Maybe it's better to help with ideas than with the code itself. There are some undocumented things right now which aren't easy to unterstand. Sure... :) There are some points you can help (since it's your code). First of all, I don't like the behavior of UP/DOWN in the tv menu. Select an item, than move up and down some times and go back to the channel from the beginning. There is a different item selected now. Maye you shouldn't take the start time of the current item as start time and remember a start time when you moved LEFT/RIGHT the last time. Yes... that's the behaviour of my DirecTV and it's ok imo. But feel free to change if it annoys you. I don't use the TV Guide myself. I just did it 'cause the older one was ugly enough to make me change it even don't using it :) Also it would be great if UP/DOWN/LEFT/RIGHT wouldn't rebuild the table all the time, only change self.selected if the table is still the same. BTW, Huum... I really don't remember the code, need to review it if you want. But really I see no reason that couldn't be done easily... I think I was not so dumb that time :) I don't use your ExtendedMenu anymore, your code is now in tv/tvmenu.py. Ok, great... I hope it now fits in our new XML skin. The second thing is drawstringframed. Do know the area this function will draw I want the coordinates back. I hacked it into the soft-function some time ago, the hard-function is still not ready. Since it's your code, maybe you could add that. I also would like to have a pretend-to-draw function. I only want the coordinates, don't draw. Right now I use a dummy layer for that, but that's not the correct way of doing it. Maybe color==None will be the pretend-mode. Do you want the draw area? The area it may draw you pass as parameter. but it's easy to do. It now returns the not-draw string. But as you know the x0,y0 and the x,y (last draw) you can make: return_y = y # last draw X return_x = (y y0) ? x0+width : x # return x if we only have one line or the x+width if we have more than 1 lines Proposal: menu type=audio !-- definition of audio menus -- use image=my image text=my text menu with info/ use image= text=my text menu/ /menu I don't like the name use, but I already use layout. What about style or variant. Sounds both ok for me. If we want to name it layout, maybe we could rename the current layout tag. But style is also ok. ok. This menu set defines that DISPLAY should toggle between these two use types (I _really_ don't like use). The first one (default) has an image version and a text version. Normally my image will be taken, if all covers look the same, my text menu with info is displayed. If you press DISPLAY you toggle. There is no image version, so it's text mode only and my text menu will be used. Idea: maybe variant is better than use After that, we need to define my image and all the other menus. This looks like the normal menus in my skin now, only the name is now menu_layout: menu_layout name=my image screen .../ listing .../ info .../ view .../ title .../ /menu_layout The skin designer can define as much different menus to toggle as he likes. Comments? Yes, perfect :) Thanks, I will do that next weekend (or maybe this evening) Ok, Gustavo ___ Busca Yahoo! O serviço de busca mais completo da Internet. O que você pensar o Yahoo! encontra. http://br.busca.yahoo.com/ --- This SF.net email is sponsored by:Crypto Challenge is now open! Get cracking and register here for some mind boggling fun and the chance of winning an Apple iPod: http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0031en ___ Freevo-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/freevo-devel
[Freevo-devel] Re: view thoughts in the new skin
Gustavo Sverzut Barbieri wrote: It can look like blue1_big, blue1_small, blue_round1 and aubin_round1 (called blue_round2 in the new skin). Everything is located in skins/dischi1. Also working: mp3 player and the beginning of the extended view (press DISPLAY inside the audio menu to take a look, only in blue1_big). Great, I'll start looking at your code and try to help you with the extended menus... Maybe it's better to help with ideas than with the code itself. There are some undocumented things right now which aren't easy to unterstand. IMHO we should get the extended off the name. Since all menus are these type now. Agreed, but I haven't found a better name yet -- maybe we don't need one, we'll see. I think we might change betweens various options of menu layouts, using DISPLAY to toggle between: VIEW=ON/OFF INFO=ON/OFF (also resize if VIEW is ON/OFF) LISTING=ON/OFF (also resize if VIEW,INFO are OFF) DISPLAY should toggle between all these combinations? I think it's too much. Really, DISPLAY should be a method array, calling each one: display[0]=View.toggle_visibility() display[1]=Info.toggle_visibility() (more?) How much? Do we need the combination Info without View? Do we need a menu without listing area? It's no problem with the current skin, but do we really need this? and then call resize, based on other screen items... (how to do that in a clean way?) That's the problem: how to do that in a clean way? Right now you toggle between different types of menus. Look at blue1_big in skins/dischi1. There are two menus for the audio menu and we toggle between them. Second we have an info area. The tv menu toggles between a large listing and a smaller one with an info area. We can also have an info area for the movie/audio/image/games menu. Should DISPLAY toggle between with and without info area? No, we should toggle between various layouts. as explained above. OK, we have various layouts. Let's call them menu_layout, because in my skin a layout is something different. The skin designer could define different layouts, e.g. text without info, image with info, ... DISPLAY would toggle between them. So if we want to have a text with info fallback if they all have the same cover, we need to define this, too. But should it be visible with the toggle, too. The problem will be how to tell the screen objects on how they should resize themselves... before (2 state menu) it was easy, but we should think about many layouts mode. No resizing please, it's a mess and it wouldn't look like the skin designer wants it. Proposal: menu type=audio !-- definition of audio menus -- use image=my image text=my text menu with info/ use image= text=my text menu/ /menu I don't like the name use, but I already use layout. This menu set defines that DISPLAY should toggle between these two use types (I _really_ don't like use). The first one (default) has an image version and a text version. Normally my image will be taken, if all covers look the same, my text menu with info is displayed. If you press DISPLAY you toggle. There is no image version, so it's text mode only and my text menu will be used. Idea: maybe variant is better than use After that, we need to define my image and all the other menus. This looks like the normal menus in my skin now, only the name is now menu_layout: menu_layout name=my image screen .../ listing .../ info .../ view .../ title .../ /menu_layout The skin designer can define as much different menus to toggle as he likes. Comments? Dischi -- Today Is A Good Day For Someone Else To Die! -- (Terry Pratchett, Feet of Clay) --- This SF.net email is sponsored by:Crypto Challenge is now open! Get cracking and register here for some mind boggling fun and the chance of winning an Apple iPod: http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0031en ___ Freevo-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/freevo-devel
