Re: [VOTE] Release Apache StreamPark(Incubating) 2.1.4-rc1

2024-04-29 Thread shaokang lv
Thanks for your review, this vote is closed.

Best,
Shaokang Lv

Huajie Wang  于2024年4月29日周一 18:17写道:

> Thanks for your review work with profound respect. we have always
> attached great importance to License compliance issues. We will close
> the current vote later and initiate a new round of voting.
>
>
> Best,
> Huajie Wang
>
>
>
> Justin Mclean  于2024年4月29日周一 17:52写道:
>
> > Hi,
> >
> > > Thanks for your clarification. We have submitted a PR[1] to address
> this
> > > issue. I believe this issue will be resolved quickly.
> > >
> > > [1] https://github.com/apache/incubator-streampark/pull/3689
> >
> > That looks good to me, thanks.
> >
> > Kind Regards,
> > Justin
> >
> > -
> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > For additional commands, e-mail: general-h...@incubator.apache.org
> >
> >
>


Re: [VOTE] Release Apache StreamPark(Incubating) 2.1.4-rc1

2024-04-29 Thread Huajie Wang
Thanks for your review work with profound respect. we have always
attached great importance to License compliance issues. We will close
the current vote later and initiate a new round of voting.


Best,
Huajie Wang



Justin Mclean  于2024年4月29日周一 17:52写道:

> Hi,
>
> > Thanks for your clarification. We have submitted a PR[1] to address this
> > issue. I believe this issue will be resolved quickly.
> >
> > [1] https://github.com/apache/incubator-streampark/pull/3689
>
> That looks good to me, thanks.
>
> Kind Regards,
> Justin
>
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>


Re: [VOTE] Release Apache StreamPark(Incubating) 2.1.4-rc1

2024-04-29 Thread Justin Mclean
Hi,

> Thanks for your clarification. We have submitted a PR[1] to address this
> issue. I believe this issue will be resolved quickly.
> 
> [1] https://github.com/apache/incubator-streampark/pull/3689

That looks good to me, thanks.

Kind Regards,
Justin

-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org



Re: [VOTE] Release Apache StreamPark(Incubating) 2.1.4-rc1

2024-04-29 Thread Huajie Wang
Thanks for your clarification. We have submitted a PR[1] to address this
issue. I believe this issue will be resolved quickly.

[1] https://github.com/apache/incubator-streampark/pull/3689



Best,
Huajie Wang



tison  于2024年4月29日周一 16:02写道:

> > So a condition of including MIT licensed code is to include the relevant
> MIT license text.
>
> Confirmed this is the case.
>
> I found the mention to vue-vben-admin is licensed under MIT at [1] but I
> don't find the LICENSE of vue-vben-admin bundled also.
>
> I agree that the LICENSE file at [2] seems to be misleading and since those
> MIT licensed files doesn't have a license header, it would be better to
> update the LICENSE content at the root path of streampark-console-webapp.
>
> [1]
>
> https://github.com/apache/incubator-streampark/blob/fe536ef7e24db2adeaaa298e1e8933899b61f834/LICENSE#L223-L251
> [2] streampark-console/streampark-console-webapp/LICENSE
>
> The license issue of vue-vben-admin was pointed out at previous releases
> [3]. It seems StreamPark still has some issues to resolve.
>
> [3] https://lists.apache.org/thread/p1f9k83q3tvz2pykfmjvpcsnxl8x4wl3
>
> For using SCANOSS, Shawn Yang shares a video that you may leverage from
> [4].
>
> [4] https://lists.apache.org/thread/13s0cgfd6b5m7qtkcffz1rk1jbywy3wv
>
> Best,
> tison.
>
>
> Justin Mclean  于2024年4月29日周一 15:32写道:
>
> > Hi,
> >
> > -1 (binding) from me
> >
> > I checked:
> > - incubating in name
> > - signatures and hashes correct
> > - disclaimer exists
> > - LICENSE is missing some info on the MIT license
> > - NOTICE looks fine
> > - I didn't compile from source
> >
> > So a condition of including MIT licensed code is to include the relevant
> > MIT license text. That seems to be missing for for vue-vben-admin , as I
> > can’t find it anywhere in the release. Oddly, the license file here [1]
> is
> > an Apache one, not an MIT one, and it also fails to mention the MIT code
> > under it.
> >
> > It looks like additional third-party code might also be in the release,
> > but it is difficult to tell. I think you should run SCANOSS (
> > https://www.softwaretransparency.org/download) on your release and look
> > into its results.
> >
> > Kind Regards,
> > Justin
> >
> >
> > 1. streampark-console/streampark-console-webapp/LICENSE
> > -
> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > For additional commands, e-mail: general-h...@incubator.apache.org
> >
> >
>


Re: [VOTE] Release Apache StreamPark(Incubating) 2.1.4-rc1

2024-04-29 Thread Huajie Wang
> But I found a potential issue that it's possible StreamPark copied some
code from flink-sql-gateway to streampark-flink-sql-gateway.

Thanks for your review work, the "streampark-flink-sql-gateway" module is
in the dev branch and is currently in the development phase, As you said,
some of the code is copied from Flink. We will address these issues in
future releases. In the current release version 2.1.4, there is no
"flink-sql-gateway" code included.



Best,
Huajie Wang



tison  于2024年4月29日周一 17:07写道:

> But I found a potential issue that it's possible StreamPark copied some
> code from flink-sql-gateway to streampark-flink-sql-gateway.
>
> If that's the case, we should convey this info in the LICENSE file. But
> since Flink is also an ASF project, we don't need to convey another copy of
> ALv2 and no need to remove the license header, while add a comment to the
> origin file can be helpful.
>
> Best,
> tison.
>
>
> tison  于2024年4月29日周一 16:59写道:
>
> > > It looks like additional third-party code might also be in the release,
> > but it is difficult to tell.
> >
> > Yeah. The result gives a lot of noise. I run SCANOSS locally, and don't
> > find any other third-party code included:
> >
> > * Many of the reference to streamx is the original project before
> > StreamPark donated to the ASF.
> > * Some false positive on testing assertions utils. Match rate < 50%, file
> > is small, and those utilities are trivial. Even when I go to the
> "origins",
> > they are lost or changed a lot. Clearly not the same origin.
> > * streampark-console is reported to be the same as a few frontend
> > projects, where we know that it's because we copy the sources
> > from vue-vben-admin and we convey the license info now.
> >
> > To sum up, AFAICS there is no more potential violation.
> >
> > Best,
> > tison.
> >
> >
> > tison  于2024年4月29日周一 16:26写道:
> >
> >> > vue-vben-admin is under MIT[1] license, In the LICENST[2] file of
> >> > StreamPark, we listed which files are copied from vue-vben-admin
> >>
> >> The issue here is that, as MIT license writes:
> >>
> >> > The above copyright notice and this permission notice shall be
> included
> >> in all copies or substantial portions of the Software.
> >>
> >> But the "copyright notice and this permission notice" of vue-vben-admin,
> >> i.e., LICENSE-vue-vben-admin.txt added at [10] doesn't included in the
> >> source releases of streampark and that is the issue. I suppose you also
> >> check if you distribute streampark-console at your binary release, and
> if
> >> so, ensure that the binary release contains a copy of this license file
> >> also.
> >>
> >> [10] https://github.com/apache/incubator-streampark/pull/3689
> >>
> >> Best,
> >> tison.
> >>
> >>
> >> Huajie Wang  于2024年4月29日周一 16:16写道:
> >>
> >>> > So a condition of including MIT licensed code is to include the
> >>> relevant
> >>> MIT license text. That seems to be missing for for vue-vben-admin , as
> I
> >>> can’t find it anywhere in the release
> >>>
> >>> vue-vben-admin is under MIT[1] license, In the LICENST[2] file of
> >>> StreamPark, we listed which files are copied from vue-vben-admin
> >>>
> >>> [1] https://github.com/vbenjs/vue-vben-admin/blob/main/LICENSE [2]
> >>>
> >>>
> https://github.com/apache/incubator-streampark/blob/release-2.1.4-rc1/LICENSE#L228
> >>>
> >>> Best,
> >>> Huajie Wang
> >>>
> >>>
> >>>
> >>> Best,
> >>> Huajie Wang
> >>>
> >>>
> >>>
> >>> Justin Mclean  于2024年4月29日周一 15:32写道:
> >>>
> >>> > Hi,
> >>> >
> >>> > -1 (binding) from me
> >>> >
> >>> > I checked:
> >>> > - incubating in name
> >>> > - signatures and hashes correct
> >>> > - disclaimer exists
> >>> > - LICENSE is missing some info on the MIT license
> >>> > - NOTICE looks fine
> >>> > - I didn't compile from source
> >>> >
> >>> > So a condition of including MIT licensed code is to include the
> >>> relevant
> >>> > MIT license text. That seems to be missing for for vue-vben-admin ,
> as
> >>> I
> >>> > can’t find it anywhere in the release. Oddly, the license file here
> >>> [1] is
> >>> > an Apache one, not an MIT one, and it also fails to mention the MIT
> >>> code
> >>> > under it.
> >>> >
> >>> > It looks like additional third-party code might also be in the
> release,
> >>> > but it is difficult to tell. I think you should run SCANOSS (
> >>> > https://www.softwaretransparency.org/download) on your release and
> >>> look
> >>> > into its results.
> >>> >
> >>> > Kind Regards,
> >>> > Justin
> >>> >
> >>> >
> >>> > 1. streampark-console/streampark-console-webapp/LICENSE
> >>> > -
> >>> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> >>> > For additional commands, e-mail: general-h...@incubator.apache.org
> >>> >
> >>> >
> >>>
> >>
>


Re: [VOTE] Release Apache StreamPark(Incubating) 2.1.4-rc1

2024-04-29 Thread tison
> Even if they have changed a lot, that could still be an issue. Copying an
earlier version of a file is still an issue that needs to be dealt with.
Even copying 5% of something needs to be treated correctly. The files seem
to have permissive licenses, so there is no category X licensing issue, at
least.

Agree.

My expression bad. I originally wanted to say, that the reported similar
file's content is different, and there is no history to show they're ever
the same.

Best,
tison.


Justin Mclean  于2024年4月29日周一 17:19写道:

> Hi,
>
> > * Some false positive on testing assertions utils. Match rate < 50%, file
> > is small, and those utilities are trivial. Even when I go to the
> "origins",
> > they are lost or changed a lot. Clearly not the same origin.
>
> Even if they have changed a lot, that could still be an issue. Copying an
> earlier version of a file is still an issue that needs to be dealt with.
> Even copying 5% of something needs to be treated correctly. The files seem
> to have permissive licenses, so there is no category X licensing issue, at
> least.
>
> Kind Regards,
> Justin
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>


Re: [VOTE] Release Apache StreamPark(Incubating) 2.1.4-rc1

2024-04-29 Thread Justin Mclean
Hi,

> * Some false positive on testing assertions utils. Match rate < 50%, file
> is small, and those utilities are trivial. Even when I go to the "origins",
> they are lost or changed a lot. Clearly not the same origin.

Even if they have changed a lot, that could still be an issue. Copying an 
earlier version of a file is still an issue that needs to be dealt with. Even 
copying 5% of something needs to be treated correctly. The files seem to have 
permissive licenses, so there is no category X licensing issue, at least.

Kind Regards,
Justin
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org



Re: [VOTE] Release Apache StreamPark(Incubating) 2.1.4-rc1

2024-04-29 Thread tison
But I found a potential issue that it's possible StreamPark copied some
code from flink-sql-gateway to streampark-flink-sql-gateway.

If that's the case, we should convey this info in the LICENSE file. But
since Flink is also an ASF project, we don't need to convey another copy of
ALv2 and no need to remove the license header, while add a comment to the
origin file can be helpful.

Best,
tison.


tison  于2024年4月29日周一 16:59写道:

> > It looks like additional third-party code might also be in the release,
> but it is difficult to tell.
>
> Yeah. The result gives a lot of noise. I run SCANOSS locally, and don't
> find any other third-party code included:
>
> * Many of the reference to streamx is the original project before
> StreamPark donated to the ASF.
> * Some false positive on testing assertions utils. Match rate < 50%, file
> is small, and those utilities are trivial. Even when I go to the "origins",
> they are lost or changed a lot. Clearly not the same origin.
> * streampark-console is reported to be the same as a few frontend
> projects, where we know that it's because we copy the sources
> from vue-vben-admin and we convey the license info now.
>
> To sum up, AFAICS there is no more potential violation.
>
> Best,
> tison.
>
>
> tison  于2024年4月29日周一 16:26写道:
>
>> > vue-vben-admin is under MIT[1] license, In the LICENST[2] file of
>> > StreamPark, we listed which files are copied from vue-vben-admin
>>
>> The issue here is that, as MIT license writes:
>>
>> > The above copyright notice and this permission notice shall be included
>> in all copies or substantial portions of the Software.
>>
>> But the "copyright notice and this permission notice" of vue-vben-admin,
>> i.e., LICENSE-vue-vben-admin.txt added at [10] doesn't included in the
>> source releases of streampark and that is the issue. I suppose you also
>> check if you distribute streampark-console at your binary release, and if
>> so, ensure that the binary release contains a copy of this license file
>> also.
>>
>> [10] https://github.com/apache/incubator-streampark/pull/3689
>>
>> Best,
>> tison.
>>
>>
>> Huajie Wang  于2024年4月29日周一 16:16写道:
>>
>>> > So a condition of including MIT licensed code is to include the
>>> relevant
>>> MIT license text. That seems to be missing for for vue-vben-admin , as I
>>> can’t find it anywhere in the release
>>>
>>> vue-vben-admin is under MIT[1] license, In the LICENST[2] file of
>>> StreamPark, we listed which files are copied from vue-vben-admin
>>>
>>> [1] https://github.com/vbenjs/vue-vben-admin/blob/main/LICENSE [2]
>>>
>>> https://github.com/apache/incubator-streampark/blob/release-2.1.4-rc1/LICENSE#L228
>>>
>>> Best,
>>> Huajie Wang
>>>
>>>
>>>
>>> Best,
>>> Huajie Wang
>>>
>>>
>>>
>>> Justin Mclean  于2024年4月29日周一 15:32写道:
>>>
>>> > Hi,
>>> >
>>> > -1 (binding) from me
>>> >
>>> > I checked:
>>> > - incubating in name
>>> > - signatures and hashes correct
>>> > - disclaimer exists
>>> > - LICENSE is missing some info on the MIT license
>>> > - NOTICE looks fine
>>> > - I didn't compile from source
>>> >
>>> > So a condition of including MIT licensed code is to include the
>>> relevant
>>> > MIT license text. That seems to be missing for for vue-vben-admin , as
>>> I
>>> > can’t find it anywhere in the release. Oddly, the license file here
>>> [1] is
>>> > an Apache one, not an MIT one, and it also fails to mention the MIT
>>> code
>>> > under it.
>>> >
>>> > It looks like additional third-party code might also be in the release,
>>> > but it is difficult to tell. I think you should run SCANOSS (
>>> > https://www.softwaretransparency.org/download) on your release and
>>> look
>>> > into its results.
>>> >
>>> > Kind Regards,
>>> > Justin
>>> >
>>> >
>>> > 1. streampark-console/streampark-console-webapp/LICENSE
>>> > -
>>> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
>>> > For additional commands, e-mail: general-h...@incubator.apache.org
>>> >
>>> >
>>>
>>


Re: [VOTE] Release Apache StreamPark(Incubating) 2.1.4-rc1

2024-04-29 Thread tison
> It looks like additional third-party code might also be in the release,
but it is difficult to tell.

Yeah. The result gives a lot of noise. I run SCANOSS locally, and don't
find any other third-party code included:

* Many of the reference to streamx is the original project before
StreamPark donated to the ASF.
* Some false positive on testing assertions utils. Match rate < 50%, file
is small, and those utilities are trivial. Even when I go to the "origins",
they are lost or changed a lot. Clearly not the same origin.
* streampark-console is reported to be the same as a few frontend projects,
where we know that it's because we copy the sources from vue-vben-admin and
we convey the license info now.

To sum up, AFAICS there is no more potential violation.

Best,
tison.


tison  于2024年4月29日周一 16:26写道:

> > vue-vben-admin is under MIT[1] license, In the LICENST[2] file of
> > StreamPark, we listed which files are copied from vue-vben-admin
>
> The issue here is that, as MIT license writes:
>
> > The above copyright notice and this permission notice shall be included
> in all copies or substantial portions of the Software.
>
> But the "copyright notice and this permission notice" of vue-vben-admin,
> i.e., LICENSE-vue-vben-admin.txt added at [10] doesn't included in the
> source releases of streampark and that is the issue. I suppose you also
> check if you distribute streampark-console at your binary release, and if
> so, ensure that the binary release contains a copy of this license file
> also.
>
> [10] https://github.com/apache/incubator-streampark/pull/3689
>
> Best,
> tison.
>
>
> Huajie Wang  于2024年4月29日周一 16:16写道:
>
>> > So a condition of including MIT licensed code is to include the relevant
>> MIT license text. That seems to be missing for for vue-vben-admin , as I
>> can’t find it anywhere in the release
>>
>> vue-vben-admin is under MIT[1] license, In the LICENST[2] file of
>> StreamPark, we listed which files are copied from vue-vben-admin
>>
>> [1] https://github.com/vbenjs/vue-vben-admin/blob/main/LICENSE [2]
>>
>> https://github.com/apache/incubator-streampark/blob/release-2.1.4-rc1/LICENSE#L228
>>
>> Best,
>> Huajie Wang
>>
>>
>>
>> Best,
>> Huajie Wang
>>
>>
>>
>> Justin Mclean  于2024年4月29日周一 15:32写道:
>>
>> > Hi,
>> >
>> > -1 (binding) from me
>> >
>> > I checked:
>> > - incubating in name
>> > - signatures and hashes correct
>> > - disclaimer exists
>> > - LICENSE is missing some info on the MIT license
>> > - NOTICE looks fine
>> > - I didn't compile from source
>> >
>> > So a condition of including MIT licensed code is to include the relevant
>> > MIT license text. That seems to be missing for for vue-vben-admin , as I
>> > can’t find it anywhere in the release. Oddly, the license file here [1]
>> is
>> > an Apache one, not an MIT one, and it also fails to mention the MIT code
>> > under it.
>> >
>> > It looks like additional third-party code might also be in the release,
>> > but it is difficult to tell. I think you should run SCANOSS (
>> > https://www.softwaretransparency.org/download) on your release and look
>> > into its results.
>> >
>> > Kind Regards,
>> > Justin
>> >
>> >
>> > 1. streampark-console/streampark-console-webapp/LICENSE
>> > -
>> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
>> > For additional commands, e-mail: general-h...@incubator.apache.org
>> >
>> >
>>
>


Re: [VOTE] Release Apache StreamPark(Incubating) 2.1.4-rc1

2024-04-29 Thread tison
> vue-vben-admin is under MIT[1] license, In the LICENST[2] file of
> StreamPark, we listed which files are copied from vue-vben-admin

The issue here is that, as MIT license writes:

> The above copyright notice and this permission notice shall be included
in all copies or substantial portions of the Software.

But the "copyright notice and this permission notice" of vue-vben-admin,
i.e., LICENSE-vue-vben-admin.txt added at [10] doesn't included in the
source releases of streampark and that is the issue. I suppose you also
check if you distribute streampark-console at your binary release, and if
so, ensure that the binary release contains a copy of this license file
also.

[10] https://github.com/apache/incubator-streampark/pull/3689

Best,
tison.


Huajie Wang  于2024年4月29日周一 16:16写道:

> > So a condition of including MIT licensed code is to include the relevant
> MIT license text. That seems to be missing for for vue-vben-admin , as I
> can’t find it anywhere in the release
>
> vue-vben-admin is under MIT[1] license, In the LICENST[2] file of
> StreamPark, we listed which files are copied from vue-vben-admin
>
> [1] https://github.com/vbenjs/vue-vben-admin/blob/main/LICENSE [2]
>
> https://github.com/apache/incubator-streampark/blob/release-2.1.4-rc1/LICENSE#L228
>
> Best,
> Huajie Wang
>
>
>
> Best,
> Huajie Wang
>
>
>
> Justin Mclean  于2024年4月29日周一 15:32写道:
>
> > Hi,
> >
> > -1 (binding) from me
> >
> > I checked:
> > - incubating in name
> > - signatures and hashes correct
> > - disclaimer exists
> > - LICENSE is missing some info on the MIT license
> > - NOTICE looks fine
> > - I didn't compile from source
> >
> > So a condition of including MIT licensed code is to include the relevant
> > MIT license text. That seems to be missing for for vue-vben-admin , as I
> > can’t find it anywhere in the release. Oddly, the license file here [1]
> is
> > an Apache one, not an MIT one, and it also fails to mention the MIT code
> > under it.
> >
> > It looks like additional third-party code might also be in the release,
> > but it is difficult to tell. I think you should run SCANOSS (
> > https://www.softwaretransparency.org/download) on your release and look
> > into its results.
> >
> > Kind Regards,
> > Justin
> >
> >
> > 1. streampark-console/streampark-console-webapp/LICENSE
> > -
> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > For additional commands, e-mail: general-h...@incubator.apache.org
> >
> >
>


Re: [VOTE] Release Apache StreamPark(Incubating) 2.1.4-rc1

2024-04-29 Thread Huajie Wang
> So a condition of including MIT licensed code is to include the relevant
MIT license text. That seems to be missing for for vue-vben-admin , as I
can’t find it anywhere in the release

vue-vben-admin is under MIT[1] license, In the LICENST[2] file of
StreamPark, we listed which files are copied from vue-vben-admin

[1] https://github.com/vbenjs/vue-vben-admin/blob/main/LICENSE [2]
https://github.com/apache/incubator-streampark/blob/release-2.1.4-rc1/LICENSE#L228

Best,
Huajie Wang



Best,
Huajie Wang



Justin Mclean  于2024年4月29日周一 15:32写道:

> Hi,
>
> -1 (binding) from me
>
> I checked:
> - incubating in name
> - signatures and hashes correct
> - disclaimer exists
> - LICENSE is missing some info on the MIT license
> - NOTICE looks fine
> - I didn't compile from source
>
> So a condition of including MIT licensed code is to include the relevant
> MIT license text. That seems to be missing for for vue-vben-admin , as I
> can’t find it anywhere in the release. Oddly, the license file here [1] is
> an Apache one, not an MIT one, and it also fails to mention the MIT code
> under it.
>
> It looks like additional third-party code might also be in the release,
> but it is difficult to tell. I think you should run SCANOSS (
> https://www.softwaretransparency.org/download) on your release and look
> into its results.
>
> Kind Regards,
> Justin
>
>
> 1. streampark-console/streampark-console-webapp/LICENSE
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>


Re: [VOTE] Release Apache StreamPark(Incubating) 2.1.4-rc1

2024-04-29 Thread tison
Here is a draft that participants in this thread can review: [1]

[1] https://github.com/apache/incubator-streampark/pull/3689

Best,
tison.


tison  于2024年4月29日周一 16:01写道:

> > So a condition of including MIT licensed code is to include the
> relevant MIT license text.
>
> Confirmed this is the case.
>
> I found the mention to vue-vben-admin is licensed under MIT at [1] but I
> don't find the LICENSE of vue-vben-admin bundled also.
>
> I agree that the LICENSE file at [2] seems to be misleading and since
> those MIT licensed files doesn't have a license header, it would be better
> to update the LICENSE content at the root path of streampark-console-webapp.
>
> [1]
> https://github.com/apache/incubator-streampark/blob/fe536ef7e24db2adeaaa298e1e8933899b61f834/LICENSE#L223-L251
> [2] streampark-console/streampark-console-webapp/LICENSE
>
> The license issue of vue-vben-admin was pointed out at previous releases
> [3]. It seems StreamPark still has some issues to resolve.
>
> [3] https://lists.apache.org/thread/p1f9k83q3tvz2pykfmjvpcsnxl8x4wl3
>
> For using SCANOSS, Shawn Yang shares a video that you may leverage from
> [4].
>
> [4] https://lists.apache.org/thread/13s0cgfd6b5m7qtkcffz1rk1jbywy3wv
>
> Best,
> tison.
>
>
> Justin Mclean  于2024年4月29日周一 15:32写道:
>
>> Hi,
>>
>> -1 (binding) from me
>>
>> I checked:
>> - incubating in name
>> - signatures and hashes correct
>> - disclaimer exists
>> - LICENSE is missing some info on the MIT license
>> - NOTICE looks fine
>> - I didn't compile from source
>>
>> So a condition of including MIT licensed code is to include the relevant
>> MIT license text. That seems to be missing for for vue-vben-admin , as I
>> can’t find it anywhere in the release. Oddly, the license file here [1] is
>> an Apache one, not an MIT one, and it also fails to mention the MIT code
>> under it.
>>
>> It looks like additional third-party code might also be in the release,
>> but it is difficult to tell. I think you should run SCANOSS (
>> https://www.softwaretransparency.org/download) on your release and look
>> into its results.
>>
>> Kind Regards,
>> Justin
>>
>>
>> 1. streampark-console/streampark-console-webapp/LICENSE
>> -
>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
>> For additional commands, e-mail: general-h...@incubator.apache.org
>>
>>


Re: [VOTE] Release Apache StreamPark(Incubating) 2.1.4-rc1

2024-04-29 Thread tison
> So a condition of including MIT licensed code is to include the relevant
MIT license text.

Confirmed this is the case.

I found the mention to vue-vben-admin is licensed under MIT at [1] but I
don't find the LICENSE of vue-vben-admin bundled also.

I agree that the LICENSE file at [2] seems to be misleading and since those
MIT licensed files doesn't have a license header, it would be better to
update the LICENSE content at the root path of streampark-console-webapp.

[1]
https://github.com/apache/incubator-streampark/blob/fe536ef7e24db2adeaaa298e1e8933899b61f834/LICENSE#L223-L251
[2] streampark-console/streampark-console-webapp/LICENSE

The license issue of vue-vben-admin was pointed out at previous releases
[3]. It seems StreamPark still has some issues to resolve.

[3] https://lists.apache.org/thread/p1f9k83q3tvz2pykfmjvpcsnxl8x4wl3

For using SCANOSS, Shawn Yang shares a video that you may leverage from [4].

[4] https://lists.apache.org/thread/13s0cgfd6b5m7qtkcffz1rk1jbywy3wv

Best,
tison.


Justin Mclean  于2024年4月29日周一 15:32写道:

> Hi,
>
> -1 (binding) from me
>
> I checked:
> - incubating in name
> - signatures and hashes correct
> - disclaimer exists
> - LICENSE is missing some info on the MIT license
> - NOTICE looks fine
> - I didn't compile from source
>
> So a condition of including MIT licensed code is to include the relevant
> MIT license text. That seems to be missing for for vue-vben-admin , as I
> can’t find it anywhere in the release. Oddly, the license file here [1] is
> an Apache one, not an MIT one, and it also fails to mention the MIT code
> under it.
>
> It looks like additional third-party code might also be in the release,
> but it is difficult to tell. I think you should run SCANOSS (
> https://www.softwaretransparency.org/download) on your release and look
> into its results.
>
> Kind Regards,
> Justin
>
>
> 1. streampark-console/streampark-console-webapp/LICENSE
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>


Re: [VOTE] Release Apache StreamPark(Incubating) 2.1.4-rc1

2024-04-29 Thread Justin Mclean
Hi,

-1 (binding) from me

I checked:
- incubating in name
- signatures and hashes correct
- disclaimer exists
- LICENSE is missing some info on the MIT license
- NOTICE looks fine
- I didn't compile from source

So a condition of including MIT licensed code is to include the relevant MIT 
license text. That seems to be missing for for vue-vben-admin , as I can’t find 
it anywhere in the release. Oddly, the license file here [1] is an Apache one, 
not an MIT one, and it also fails to mention the MIT code under it.

It looks like additional third-party code might also be in the release, but it 
is difficult to tell. I think you should run SCANOSS 
(https://www.softwaretransparency.org/download) on your release and look into 
its results. 

Kind Regards,
Justin


1. streampark-console/streampark-console-webapp/LICENSE
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org



Re: [VOTE] Release Apache StreamPark(Incubating) 2.1.4-rc1

2024-04-28 Thread Huajie Wang
> To verify the release here is supposed to verify the release candidate
stored at the Apache distribution, right?
Is it wrong to verify the code repo downloaded by git clone?

When we are releasing a new version, we will create a git tag for the
release.  Here, "-b v2.1.4-rc1[1]" is to verify whether the current version
can be build from the matching source code.
Of course, you can specified any tag or branch, If you have any questions
about this, please feel free to communicate。

[1] https://github.com/apache/incubator-streampark/releases/tag/v2.1.4-rc1



Best,
Huajie Wang



Suyan  于2024年4月28日周日 21:20写道:

> +1 binding
> Apache ID: suyanhanx
>
> I checked:
>
> [x] Download links are valid.
> [x] Checksums and signatures.
> gpg: Signature made Mon Apr 22 00:02:13 2024 CST
> gpg:using RSA key B0AD51795657CF5C303FE79B5CEB5ECFD38791FF
> gpg: checking the trustdb
> gpg: marginals needed: 3  completes needed: 1  trust model: pgp
> gpg: depth: 0  valid:  24  signed:   0  trust: 0-, 0q, 0n, 0m, 0f, 24u
> gpg: next trustdb check due at 2024-05-25
> gpg: Good signature from "lvshaokang (for apache StreamPark release
> create at 20240421) " [ultimate]
>
> [x] LICENSE/NOTICE files exist
> [x] No unexpected binary files
> [x] All source files have ASF headers
> [x] Can compile from source on macOS(arm64)
> [INFO]
> 
> [INFO] BUILD SUCCESS
> [INFO]
> 
> [INFO] Total time:  14:28 min
> [INFO] Finished at: 2024-04-28T19:31:40+08:00
> [INFO]
> 
>
> [StreamPark] StreamPark project build successful!
> info: package mode @ mixed, scala-2.12
>
>
> A small problem:
>
> This is the build tip in your vote email template:
>
> > How to Build:
> >
> > 1) clone source code:
> > > git clone -b v2.1.4-rc1 g...@github.com:apache/incubator-streampark.git
> >
> > 2) build project:
> > > cd incubator-streampark && sh ./build.sh
>
> To verify the release here is supposed to verify the release candidate
> stored at the Apache distribution, right?
> Is it wrong to verify the code repo downloaded by git clone?
>
>
> Sincerely,
> Suyan
>
> Shaokang Lv  于2024年4月25日周四 16:02写道:
> >
> > Hello Incubator Community:
> >
> > This is a call for a vote to release Apache StreamPark(Incubating)
> version
> > 2.1.4-RC1.
> > The Apache StreamPark community has voted on and approved a proposal to
> > release Apache StreamPark(Incubating) version 2.1.4-RC1.
> > We now kindly request the Incubator PMC members review and vote on this
> > incubator release.
> > Apache StreamPark, Make stream processing easier! Easy-to-use streaming
> > application development framework and operation platform.
> >
> > StreamPark community vote thread:
> > https://lists.apache.org/thread/v4yx0f0xgmr53g795cgn4ppblytqhvqh
> >
> > Vote result thread:
> > https://lists.apache.org/thread/f85yn1j6y6k9fcmc8qvl7ltob706twcs
> >
> > The release candidate:
> > https://dist.apache.org/repos/dist/dev/incubator/streampark/2.1.4-RC1/
> >
> > Git tag for the release:
> > https://github.com/apache/incubator-streampark/releases/tag/v2.1.4-rc1
> >
> > The artifacts signed with PGP key [D38791FF], corresponding to [
> > lvshaok...@apache.org], that can be found in keys file:
> > https://downloads.apache.org/incubator/streampark/KEYS
> >
> > The vote will be open for at least 72 hours or until the necessary number
> > of votes are reached.
> >
> > Please vote accordingly:
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > More detailed checklist please refer:
> > •
> >
> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
> >
> > Steps to validate the release, Please refer to:
> > • https://www.apache.org/info/verification.html
> > • https://streampark.apache.org/community/release/how_to_verify_release
> >
> >
> > How to Build:
> >
> > 1) clone source code:
> > > git clone -b v2.1.4-rc1 g...@github.com:apache/incubator-streampark.git
> >
> > 2) build project:
> > > cd incubator-streampark && sh ./build.sh
> >
> >
> > Thanks,
> >
> > On behalf of Apache StreamPark(Incubating) community
> >
> >
> > Best,
> > Shaokang Lv
>
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>


Re: [VOTE] Release Apache StreamPark(Incubating) 2.1.4-rc1

2024-04-28 Thread shaokang lv
hi Suyan,

Thank you for your careful review. The version by git clone is the same as
the apache release candidate. To avoid ambiguity, we'll add a comment to
the vote template later.


Best,
Shaokang Lv


Suyan  于2024年4月28日周日 21:20写道:

> +1 binding
> Apache ID: suyanhanx
>
> I checked:
>
> [x] Download links are valid.
> [x] Checksums and signatures.
> gpg: Signature made Mon Apr 22 00:02:13 2024 CST
> gpg:using RSA key B0AD51795657CF5C303FE79B5CEB5ECFD38791FF
> gpg: checking the trustdb
> gpg: marginals needed: 3  completes needed: 1  trust model: pgp
> gpg: depth: 0  valid:  24  signed:   0  trust: 0-, 0q, 0n, 0m, 0f, 24u
> gpg: next trustdb check due at 2024-05-25
> gpg: Good signature from "lvshaokang (for apache StreamPark release
> create at 20240421) " [ultimate]
>
> [x] LICENSE/NOTICE files exist
> [x] No unexpected binary files
> [x] All source files have ASF headers
> [x] Can compile from source on macOS(arm64)
> [INFO]
> 
> [INFO] BUILD SUCCESS
> [INFO]
> 
> [INFO] Total time:  14:28 min
> [INFO] Finished at: 2024-04-28T19:31:40+08:00
> [INFO]
> 
>
> [StreamPark] StreamPark project build successful!
> info: package mode @ mixed, scala-2.12
>
>
> A small problem:
>
> This is the build tip in your vote email template:
>
> > How to Build:
> >
> > 1) clone source code:
> > > git clone -b v2.1.4-rc1 g...@github.com:apache/incubator-streampark.git
> >
> > 2) build project:
> > > cd incubator-streampark && sh ./build.sh
>
> To verify the release here is supposed to verify the release candidate
> stored at the Apache distribution, right?
> Is it wrong to verify the code repo downloaded by git clone?
>
>
> Sincerely,
> Suyan
>
> Shaokang Lv  于2024年4月25日周四 16:02写道:
> >
> > Hello Incubator Community:
> >
> > This is a call for a vote to release Apache StreamPark(Incubating)
> version
> > 2.1.4-RC1.
> > The Apache StreamPark community has voted on and approved a proposal to
> > release Apache StreamPark(Incubating) version 2.1.4-RC1.
> > We now kindly request the Incubator PMC members review and vote on this
> > incubator release.
> > Apache StreamPark, Make stream processing easier! Easy-to-use streaming
> > application development framework and operation platform.
> >
> > StreamPark community vote thread:
> > https://lists.apache.org/thread/v4yx0f0xgmr53g795cgn4ppblytqhvqh
> >
> > Vote result thread:
> > https://lists.apache.org/thread/f85yn1j6y6k9fcmc8qvl7ltob706twcs
> >
> > The release candidate:
> > https://dist.apache.org/repos/dist/dev/incubator/streampark/2.1.4-RC1/
> >
> > Git tag for the release:
> > https://github.com/apache/incubator-streampark/releases/tag/v2.1.4-rc1
> >
> > The artifacts signed with PGP key [D38791FF], corresponding to [
> > lvshaok...@apache.org], that can be found in keys file:
> > https://downloads.apache.org/incubator/streampark/KEYS
> >
> > The vote will be open for at least 72 hours or until the necessary number
> > of votes are reached.
> >
> > Please vote accordingly:
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > More detailed checklist please refer:
> > •
> >
> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
> >
> > Steps to validate the release, Please refer to:
> > • https://www.apache.org/info/verification.html
> > • https://streampark.apache.org/community/release/how_to_verify_release
> >
> >
> > How to Build:
> >
> > 1) clone source code:
> > > git clone -b v2.1.4-rc1 g...@github.com:apache/incubator-streampark.git
> >
> > 2) build project:
> > > cd incubator-streampark && sh ./build.sh
> >
> >
> > Thanks,
> >
> > On behalf of Apache StreamPark(Incubating) community
> >
> >
> > Best,
> > Shaokang Lv
>
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>


Re: [VOTE] Release Apache StreamPark(Incubating) 2.1.4-rc1

2024-04-28 Thread Suyan
+1 binding
Apache ID: suyanhanx

I checked:

[x] Download links are valid.
[x] Checksums and signatures.
gpg: Signature made Mon Apr 22 00:02:13 2024 CST
gpg:using RSA key B0AD51795657CF5C303FE79B5CEB5ECFD38791FF
gpg: checking the trustdb
gpg: marginals needed: 3  completes needed: 1  trust model: pgp
gpg: depth: 0  valid:  24  signed:   0  trust: 0-, 0q, 0n, 0m, 0f, 24u
gpg: next trustdb check due at 2024-05-25
gpg: Good signature from "lvshaokang (for apache StreamPark release
create at 20240421) " [ultimate]

[x] LICENSE/NOTICE files exist
[x] No unexpected binary files
[x] All source files have ASF headers
[x] Can compile from source on macOS(arm64)
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time:  14:28 min
[INFO] Finished at: 2024-04-28T19:31:40+08:00
[INFO] 

[StreamPark] StreamPark project build successful!
info: package mode @ mixed, scala-2.12


A small problem:

This is the build tip in your vote email template:

> How to Build:
>
> 1) clone source code:
> > git clone -b v2.1.4-rc1 g...@github.com:apache/incubator-streampark.git
>
> 2) build project:
> > cd incubator-streampark && sh ./build.sh

To verify the release here is supposed to verify the release candidate
stored at the Apache distribution, right?
Is it wrong to verify the code repo downloaded by git clone?


Sincerely,
Suyan

Shaokang Lv  于2024年4月25日周四 16:02写道:
>
> Hello Incubator Community:
>
> This is a call for a vote to release Apache StreamPark(Incubating) version
> 2.1.4-RC1.
> The Apache StreamPark community has voted on and approved a proposal to
> release Apache StreamPark(Incubating) version 2.1.4-RC1.
> We now kindly request the Incubator PMC members review and vote on this
> incubator release.
> Apache StreamPark, Make stream processing easier! Easy-to-use streaming
> application development framework and operation platform.
>
> StreamPark community vote thread:
> https://lists.apache.org/thread/v4yx0f0xgmr53g795cgn4ppblytqhvqh
>
> Vote result thread:
> https://lists.apache.org/thread/f85yn1j6y6k9fcmc8qvl7ltob706twcs
>
> The release candidate:
> https://dist.apache.org/repos/dist/dev/incubator/streampark/2.1.4-RC1/
>
> Git tag for the release:
> https://github.com/apache/incubator-streampark/releases/tag/v2.1.4-rc1
>
> The artifacts signed with PGP key [D38791FF], corresponding to [
> lvshaok...@apache.org], that can be found in keys file:
> https://downloads.apache.org/incubator/streampark/KEYS
>
> The vote will be open for at least 72 hours or until the necessary number
> of votes are reached.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> More detailed checklist please refer:
> •
> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
>
> Steps to validate the release, Please refer to:
> • https://www.apache.org/info/verification.html
> • https://streampark.apache.org/community/release/how_to_verify_release
>
>
> How to Build:
>
> 1) clone source code:
> > git clone -b v2.1.4-rc1 g...@github.com:apache/incubator-streampark.git
>
> 2) build project:
> > cd incubator-streampark && sh ./build.sh
>
>
> Thanks,
>
> On behalf of Apache StreamPark(Incubating) community
>
>
> Best,
> Shaokang Lv

-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org



Re: [VOTE] Release Apache StreamPark(Incubating) 2.1.4-rc1

2024-04-27 Thread Duo Zhang
+1 binding

Checked sigs and sums: Matched
NOTICE and LICENSE: Looks fine
DISCLAIMER: In place
Built from src: Passed with jdk11 by calling build.sh

Thanks.

Huajie Wang  于2024年4月27日周六 10:06写道:
>
> Carrying my non-binding +1 vote from the StreamPark community.
>
>
> Best,
> Huajie Wang
>
>
>
> Huajie Wang  于2024年4月26日周五 00:27写道:
>
> > hi tison:
> >
> > Thanks very much for your thorough checking work. You even found such a
> > minor issue as the version number mismatch in the README.md file, We have
> > created an issues[1] to tracking  DISCLAIMER and README.md issue
> >
> > [1] https://github.com/apache/incubator-streampark/issues/3680
> >
> >
> > > This is not yet a clear and strong conclusion, so as an IPMC member,
> > I encourage you to give your own feedback on such suggestions.
> > >
> > https://streampark.apache.org/community/release/how_to_release#4-complete-the-final-publishing-steps
> >
> > I will send an email to the community for discussing and resolving this
> > issue.
> >
> >
> > Best,
> > Huajie Wang
> >
> >
> >
> > tison  于2024年4月25日周四 20:04写道:
> >
> >> +1 binding with a few suggestions.
> >>
> >> I checked:
> >>
> >> * Download links valid.
> >> * Signature and checksum match.
> >> * LICENSE, NOTICE and DISCLAIMER are included in both source and binary
> >> releases. The content looks good to me.
> >> * No binary files in the source release
> >>
> >> Below are two suggestions:
> >>
> >> 1. You may evaluate to add a DISCLAIM in the announcement template, which
> >> is the same content as DISCLAIMER file in your sources.
> >>
> >> This is proposed at [1] and may related to your email template in 4.5 at
> >> [2]. This is not yet a clear and strong conclusion, so as an IPMC member,
> >> I
> >> encourage you to give your own feedback on such suggestions.
> >>
> >> [1] https://lists.apache.org/thread/3fosfz2jv0yhcrzt6mtwbwtxg4vtwxpy
> >> [2]
> >>
> >> https://streampark.apache.org/community/release/how_to_release#4-complete-the-final-publishing-steps
> >>
> >> 2. You may write a dedicated README.md file for your binary release. It
> >> now
> >> contains the same content as the main repo's, which is mismatched from the
> >> binary release's content.
> >>
> >> For example, it has:
> >>
> >> ## 🚀 QuickStart
> >> - [Start with Docker](docker/README.md)
> >> - [Start with Kubernetes](helm/README.md)
> >>
> >> which are missing in the binary release. I suppose you should talk about
> >> how to use and configure the release artifacts instead.
> >>
> >> Best,
> >> tison.
> >>
> >>
> >> Shaokang Lv  于2024年4月25日周四 16:01写道:
> >>
> >> > Hello Incubator Community:
> >> >
> >> > This is a call for a vote to release Apache StreamPark(Incubating)
> >> version
> >> > 2.1.4-RC1.
> >> > The Apache StreamPark community has voted on and approved a proposal to
> >> > release Apache StreamPark(Incubating) version 2.1.4-RC1.
> >> > We now kindly request the Incubator PMC members review and vote on this
> >> > incubator release.
> >> > Apache StreamPark, Make stream processing easier! Easy-to-use streaming
> >> > application development framework and operation platform.
> >> >
> >> > StreamPark community vote thread:
> >> > https://lists.apache.org/thread/v4yx0f0xgmr53g795cgn4ppblytqhvqh
> >> >
> >> > Vote result thread:
> >> > https://lists.apache.org/thread/f85yn1j6y6k9fcmc8qvl7ltob706twcs
> >> >
> >> > The release candidate:
> >> > https://dist.apache.org/repos/dist/dev/incubator/streampark/2.1.4-RC1/
> >> >
> >> > Git tag for the release:
> >> > https://github.com/apache/incubator-streampark/releases/tag/v2.1.4-rc1
> >> >
> >> > The artifacts signed with PGP key [D38791FF], corresponding to [
> >> > lvshaok...@apache.org], that can be found in keys file:
> >> > https://downloads.apache.org/incubator/streampark/KEYS
> >> >
> >> > The vote will be open for at least 72 hours or until the necessary
> >> number
> >> > of votes are reached.
> >> >
> >> > Please vote accordingly:
> >> > [ ] +1 approve
> >> > [ ] +0 no opinion
> >> > [ ] -1 disapprove with the reason
> >> >
> >> > More detailed checklist please refer:
> >> > •
> >> >
> >> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
> >> >
> >> > Steps to validate the release, Please refer to:
> >> > • https://www.apache.org/info/verification.html
> >> > • https://streampark.apache.org/community/release/how_to_verify_release
> >> >
> >> >
> >> > How to Build:
> >> >
> >> > 1) clone source code:
> >> > > git clone -b v2.1.4-rc1 g...@github.com:
> >> apache/incubator-streampark.git
> >> >
> >> > 2) build project:
> >> > > cd incubator-streampark && sh ./build.sh
> >> >
> >> >
> >> > Thanks,
> >> >
> >> > On behalf of Apache StreamPark(Incubating) community
> >> >
> >> >
> >> > Best,
> >> > Shaokang Lv
> >> >
> >>
> >

-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org



Re: [VOTE] Release Apache StreamPark(Incubating) 2.1.4-rc1

2024-04-26 Thread Huajie Wang
Carrying my non-binding +1 vote from the StreamPark community.


Best,
Huajie Wang



Huajie Wang  于2024年4月26日周五 00:27写道:

> hi tison:
>
> Thanks very much for your thorough checking work. You even found such a
> minor issue as the version number mismatch in the README.md file, We have
> created an issues[1] to tracking  DISCLAIMER and README.md issue
>
> [1] https://github.com/apache/incubator-streampark/issues/3680
>
>
> > This is not yet a clear and strong conclusion, so as an IPMC member,
> I encourage you to give your own feedback on such suggestions.
> >
> https://streampark.apache.org/community/release/how_to_release#4-complete-the-final-publishing-steps
>
> I will send an email to the community for discussing and resolving this
> issue.
>
>
> Best,
> Huajie Wang
>
>
>
> tison  于2024年4月25日周四 20:04写道:
>
>> +1 binding with a few suggestions.
>>
>> I checked:
>>
>> * Download links valid.
>> * Signature and checksum match.
>> * LICENSE, NOTICE and DISCLAIMER are included in both source and binary
>> releases. The content looks good to me.
>> * No binary files in the source release
>>
>> Below are two suggestions:
>>
>> 1. You may evaluate to add a DISCLAIM in the announcement template, which
>> is the same content as DISCLAIMER file in your sources.
>>
>> This is proposed at [1] and may related to your email template in 4.5 at
>> [2]. This is not yet a clear and strong conclusion, so as an IPMC member,
>> I
>> encourage you to give your own feedback on such suggestions.
>>
>> [1] https://lists.apache.org/thread/3fosfz2jv0yhcrzt6mtwbwtxg4vtwxpy
>> [2]
>>
>> https://streampark.apache.org/community/release/how_to_release#4-complete-the-final-publishing-steps
>>
>> 2. You may write a dedicated README.md file for your binary release. It
>> now
>> contains the same content as the main repo's, which is mismatched from the
>> binary release's content.
>>
>> For example, it has:
>>
>> ## 🚀 QuickStart
>> - [Start with Docker](docker/README.md)
>> - [Start with Kubernetes](helm/README.md)
>>
>> which are missing in the binary release. I suppose you should talk about
>> how to use and configure the release artifacts instead.
>>
>> Best,
>> tison.
>>
>>
>> Shaokang Lv  于2024年4月25日周四 16:01写道:
>>
>> > Hello Incubator Community:
>> >
>> > This is a call for a vote to release Apache StreamPark(Incubating)
>> version
>> > 2.1.4-RC1.
>> > The Apache StreamPark community has voted on and approved a proposal to
>> > release Apache StreamPark(Incubating) version 2.1.4-RC1.
>> > We now kindly request the Incubator PMC members review and vote on this
>> > incubator release.
>> > Apache StreamPark, Make stream processing easier! Easy-to-use streaming
>> > application development framework and operation platform.
>> >
>> > StreamPark community vote thread:
>> > https://lists.apache.org/thread/v4yx0f0xgmr53g795cgn4ppblytqhvqh
>> >
>> > Vote result thread:
>> > https://lists.apache.org/thread/f85yn1j6y6k9fcmc8qvl7ltob706twcs
>> >
>> > The release candidate:
>> > https://dist.apache.org/repos/dist/dev/incubator/streampark/2.1.4-RC1/
>> >
>> > Git tag for the release:
>> > https://github.com/apache/incubator-streampark/releases/tag/v2.1.4-rc1
>> >
>> > The artifacts signed with PGP key [D38791FF], corresponding to [
>> > lvshaok...@apache.org], that can be found in keys file:
>> > https://downloads.apache.org/incubator/streampark/KEYS
>> >
>> > The vote will be open for at least 72 hours or until the necessary
>> number
>> > of votes are reached.
>> >
>> > Please vote accordingly:
>> > [ ] +1 approve
>> > [ ] +0 no opinion
>> > [ ] -1 disapprove with the reason
>> >
>> > More detailed checklist please refer:
>> > •
>> >
>> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
>> >
>> > Steps to validate the release, Please refer to:
>> > • https://www.apache.org/info/verification.html
>> > • https://streampark.apache.org/community/release/how_to_verify_release
>> >
>> >
>> > How to Build:
>> >
>> > 1) clone source code:
>> > > git clone -b v2.1.4-rc1 g...@github.com:
>> apache/incubator-streampark.git
>> >
>> > 2) build project:
>> > > cd incubator-streampark && sh ./build.sh
>> >
>> >
>> > Thanks,
>> >
>> > On behalf of Apache StreamPark(Incubating) community
>> >
>> >
>> > Best,
>> > Shaokang Lv
>> >
>>
>


Re: [VOTE] Release Apache StreamPark(Incubating) 2.1.4-rc1

2024-04-25 Thread Huajie Wang
hi tison:

Thanks very much for your thorough checking work. You even found such a
minor issue as the version number mismatch in the README.md file, We have
created an issues[1] to tracking  DISCLAIMER and README.md issue

[1] https://github.com/apache/incubator-streampark/issues/3680


> This is not yet a clear and strong conclusion, so as an IPMC member,
I encourage you to give your own feedback on such suggestions.
>
https://streampark.apache.org/community/release/how_to_release#4-complete-the-final-publishing-steps

I will send an email to the community for discussing and resolving this
issue.


Best,
Huajie Wang



tison  于2024年4月25日周四 20:04写道:

> +1 binding with a few suggestions.
>
> I checked:
>
> * Download links valid.
> * Signature and checksum match.
> * LICENSE, NOTICE and DISCLAIMER are included in both source and binary
> releases. The content looks good to me.
> * No binary files in the source release
>
> Below are two suggestions:
>
> 1. You may evaluate to add a DISCLAIM in the announcement template, which
> is the same content as DISCLAIMER file in your sources.
>
> This is proposed at [1] and may related to your email template in 4.5 at
> [2]. This is not yet a clear and strong conclusion, so as an IPMC member, I
> encourage you to give your own feedback on such suggestions.
>
> [1] https://lists.apache.org/thread/3fosfz2jv0yhcrzt6mtwbwtxg4vtwxpy
> [2]
>
> https://streampark.apache.org/community/release/how_to_release#4-complete-the-final-publishing-steps
>
> 2. You may write a dedicated README.md file for your binary release. It now
> contains the same content as the main repo's, which is mismatched from the
> binary release's content.
>
> For example, it has:
>
> ## 🚀 QuickStart
> - [Start with Docker](docker/README.md)
> - [Start with Kubernetes](helm/README.md)
>
> which are missing in the binary release. I suppose you should talk about
> how to use and configure the release artifacts instead.
>
> Best,
> tison.
>
>
> Shaokang Lv  于2024年4月25日周四 16:01写道:
>
> > Hello Incubator Community:
> >
> > This is a call for a vote to release Apache StreamPark(Incubating)
> version
> > 2.1.4-RC1.
> > The Apache StreamPark community has voted on and approved a proposal to
> > release Apache StreamPark(Incubating) version 2.1.4-RC1.
> > We now kindly request the Incubator PMC members review and vote on this
> > incubator release.
> > Apache StreamPark, Make stream processing easier! Easy-to-use streaming
> > application development framework and operation platform.
> >
> > StreamPark community vote thread:
> > https://lists.apache.org/thread/v4yx0f0xgmr53g795cgn4ppblytqhvqh
> >
> > Vote result thread:
> > https://lists.apache.org/thread/f85yn1j6y6k9fcmc8qvl7ltob706twcs
> >
> > The release candidate:
> > https://dist.apache.org/repos/dist/dev/incubator/streampark/2.1.4-RC1/
> >
> > Git tag for the release:
> > https://github.com/apache/incubator-streampark/releases/tag/v2.1.4-rc1
> >
> > The artifacts signed with PGP key [D38791FF], corresponding to [
> > lvshaok...@apache.org], that can be found in keys file:
> > https://downloads.apache.org/incubator/streampark/KEYS
> >
> > The vote will be open for at least 72 hours or until the necessary number
> > of votes are reached.
> >
> > Please vote accordingly:
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > More detailed checklist please refer:
> > •
> >
> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
> >
> > Steps to validate the release, Please refer to:
> > • https://www.apache.org/info/verification.html
> > • https://streampark.apache.org/community/release/how_to_verify_release
> >
> >
> > How to Build:
> >
> > 1) clone source code:
> > > git clone -b v2.1.4-rc1 g...@github.com:apache/incubator-streampark.git
> >
> > 2) build project:
> > > cd incubator-streampark && sh ./build.sh
> >
> >
> > Thanks,
> >
> > On behalf of Apache StreamPark(Incubating) community
> >
> >
> > Best,
> > Shaokang Lv
> >
>


Re: [VOTE] Release Apache StreamPark(Incubating) 2.1.4-rc1

2024-04-25 Thread tison
+1 binding with a few suggestions.

I checked:

* Download links valid.
* Signature and checksum match.
* LICENSE, NOTICE and DISCLAIMER are included in both source and binary
releases. The content looks good to me.
* No binary files in the source release

Below are two suggestions:

1. You may evaluate to add a DISCLAIM in the announcement template, which
is the same content as DISCLAIMER file in your sources.

This is proposed at [1] and may related to your email template in 4.5 at
[2]. This is not yet a clear and strong conclusion, so as an IPMC member, I
encourage you to give your own feedback on such suggestions.

[1] https://lists.apache.org/thread/3fosfz2jv0yhcrzt6mtwbwtxg4vtwxpy
[2]
https://streampark.apache.org/community/release/how_to_release#4-complete-the-final-publishing-steps

2. You may write a dedicated README.md file for your binary release. It now
contains the same content as the main repo's, which is mismatched from the
binary release's content.

For example, it has:

## 🚀 QuickStart
- [Start with Docker](docker/README.md)
- [Start with Kubernetes](helm/README.md)

which are missing in the binary release. I suppose you should talk about
how to use and configure the release artifacts instead.

Best,
tison.


Shaokang Lv  于2024年4月25日周四 16:01写道:

> Hello Incubator Community:
>
> This is a call for a vote to release Apache StreamPark(Incubating) version
> 2.1.4-RC1.
> The Apache StreamPark community has voted on and approved a proposal to
> release Apache StreamPark(Incubating) version 2.1.4-RC1.
> We now kindly request the Incubator PMC members review and vote on this
> incubator release.
> Apache StreamPark, Make stream processing easier! Easy-to-use streaming
> application development framework and operation platform.
>
> StreamPark community vote thread:
> https://lists.apache.org/thread/v4yx0f0xgmr53g795cgn4ppblytqhvqh
>
> Vote result thread:
> https://lists.apache.org/thread/f85yn1j6y6k9fcmc8qvl7ltob706twcs
>
> The release candidate:
> https://dist.apache.org/repos/dist/dev/incubator/streampark/2.1.4-RC1/
>
> Git tag for the release:
> https://github.com/apache/incubator-streampark/releases/tag/v2.1.4-rc1
>
> The artifacts signed with PGP key [D38791FF], corresponding to [
> lvshaok...@apache.org], that can be found in keys file:
> https://downloads.apache.org/incubator/streampark/KEYS
>
> The vote will be open for at least 72 hours or until the necessary number
> of votes are reached.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> More detailed checklist please refer:
> •
> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
>
> Steps to validate the release, Please refer to:
> • https://www.apache.org/info/verification.html
> • https://streampark.apache.org/community/release/how_to_verify_release
>
>
> How to Build:
>
> 1) clone source code:
> > git clone -b v2.1.4-rc1 g...@github.com:apache/incubator-streampark.git
>
> 2) build project:
> > cd incubator-streampark && sh ./build.sh
>
>
> Thanks,
>
> On behalf of Apache StreamPark(Incubating) community
>
>
> Best,
> Shaokang Lv
>


[VOTE] Release Apache StreamPark(Incubating) 2.1.4-rc1

2024-04-25 Thread Shaokang Lv
Hello Incubator Community:

This is a call for a vote to release Apache StreamPark(Incubating) version
2.1.4-RC1.
The Apache StreamPark community has voted on and approved a proposal to
release Apache StreamPark(Incubating) version 2.1.4-RC1.
We now kindly request the Incubator PMC members review and vote on this
incubator release.
Apache StreamPark, Make stream processing easier! Easy-to-use streaming
application development framework and operation platform.

StreamPark community vote thread:
https://lists.apache.org/thread/v4yx0f0xgmr53g795cgn4ppblytqhvqh

Vote result thread:
https://lists.apache.org/thread/f85yn1j6y6k9fcmc8qvl7ltob706twcs

The release candidate:
https://dist.apache.org/repos/dist/dev/incubator/streampark/2.1.4-RC1/

Git tag for the release:
https://github.com/apache/incubator-streampark/releases/tag/v2.1.4-rc1

The artifacts signed with PGP key [D38791FF], corresponding to [
lvshaok...@apache.org], that can be found in keys file:
https://downloads.apache.org/incubator/streampark/KEYS

The vote will be open for at least 72 hours or until the necessary number
of votes are reached.

Please vote accordingly:
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove with the reason

More detailed checklist please refer:
•
https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist

Steps to validate the release, Please refer to:
• https://www.apache.org/info/verification.html
• https://streampark.apache.org/community/release/how_to_verify_release


How to Build:

1) clone source code:
> git clone -b v2.1.4-rc1 g...@github.com:apache/incubator-streampark.git

2) build project:
> cd incubator-streampark && sh ./build.sh


Thanks,

On behalf of Apache StreamPark(Incubating) community


Best,
Shaokang Lv