[VOTE] Release Apache Zipkin (incubating) version 2.14.0
Hello IPMC The Apache Zipkin community has voted on and approved a proposal to release Apache Zipkin (incubating) version 2.14.0. The voting thread can be found here: https://lists.apache.org/thread.html/03b215cc4a6e10a7092fe39b6ce87d3a964f35b6e181e12da4d45432@%3Cdev.zipkin.apache.org%3E This vote is running concurrent with the above, carrying over 3 binding +1 votes from mentors Willem Ning Jiang, Sheng Wu and Andriy Redko. We now kindly request the Incubator PMC members review and vote on this incubator release. Apache Zipkin (incubating) is a distributed tracing system. It helps gather timing data needed to troubleshoot latency problems in microservice architectures. It manages both the collection and lookup of this data. Zipkin’s design is based on the Google Dapper paper. This source includes a dependency-free library and a spring-boot server. Storage options include in-memory, JDBC (mysql), Cassandra, and Elasticsearch. The release candidates: https://dist.apache.org/repos/dist/dev/incubator/zipkin/zipkin/2.14.0/ Git tag for the release: https://github.com/apache/incubator-zipkin/tree/v2.14.0 Hash for the release tag: 9c2fa2697cdbbd6a3eeb9f87ae6a6ccba2f3c881 Release Notes: https://github.com/apache/incubator-zipkin/releases/tag/v2.14.0 The artifacts have been signed with Key: BB67A050, which can be found in the keys file: https://www.apache.org/dist/incubator/zipkin/KEYS Verification Hints: For your convenience, the below includes a detailed how-to on verifying a source release. Please note that this document is a work-in-progress https://cwiki.apache.org/confluence/display/ZIPKIN/Verifying+a+Source+ Release The vote will be open for at least 72 hours or until the necessary number of votes are reached. Please vote accordingly: [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove with the reason Note: 1. Zipkin-UI contains vendored libraries which will be removed during the incubation 2. A more complete list of issues requiring attention before graduation is here https://github.com/apache/incubator-zipkin/issues/2544 Thanks, The Apache Zipkin (Incubating) Team - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache Zipkin (incubating) version 2.14.0
Hi, +1 (binding) but there some improvements that can be made. I checked: - incubating in name - signatures and hashes good - LICENSE needs a little more work and is missing LICENSE for [2]. - NOTICE is incorrect as it missing information from this NOTICE [4] - no unexpected binary files - source file have ASF header. In fact a couple too many [1] has an ASF header and two others and this file as well [2] - can compile from source To ensure you are abiding by 3rd party license terms the full license text generally needs be included (e.g. MIT, BSD). Usually this is done by pointing a pointer to a file in the distribution in the LICENSE file (not a URL). Some projects put all of these licenses into a license directory. You might want to consider doing that. Thanks, Justin 1. ./zipkin-2.13.0/zipkin-ui/libs/dagre-d3/js/dagre-d3.js 2. ./zipkin-2.14.0/zipkin-server/src/main/java/zipkin2/server/internal/AbstractUnsafeUnaryGrpcService.java 3. ./zipkin-ui/libs/chosen/chosen.css 4. https://github.com/line/armeria/blob/master/NOTICE.txt - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache Zipkin (incubating) version 2.14.0
Thanks justin. Opened an issue to polish this eventhough these files won't survive graduation. https://github.com/apache/incubator-zipkin/issues/2602 On Fri, May 17, 2019 at 10:04 AM Justin Mclean wrote: > > Hi, > > +1 (binding) but there some improvements that can be made. > > I checked: > - incubating in name > - signatures and hashes good > - LICENSE needs a little more work and is missing LICENSE for [2]. > - NOTICE is incorrect as it missing information from this NOTICE [4] > - no unexpected binary files > - source file have ASF header. In fact a couple too many [1] has an ASF > header and two others and this file as well [2] > - can compile from source > > To ensure you are abiding by 3rd party license terms the full license text > generally needs be included (e.g. MIT, BSD). Usually this is done by pointing > a pointer to a file in the distribution in the LICENSE file (not a URL). Some > projects put all of these licenses into a license directory. You might want > to consider doing that. > > Thanks, > Justin > > 1. ./zipkin-2.13.0/zipkin-ui/libs/dagre-d3/js/dagre-d3.js > 2. > ./zipkin-2.14.0/zipkin-server/src/main/java/zipkin2/server/internal/AbstractUnsafeUnaryGrpcService.java > 3. ./zipkin-ui/libs/chosen/chosen.css > 4. https://github.com/line/armeria/blob/master/NOTICE.txt > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache Zipkin (incubating) version 2.14.0
Hi, > This vote is running concurrent with the above, carrying over 3 > binding +1 votes from mentors Willem Ning Jiang, Sheng Wu and Andriy > Redko. Given that people can change their vote I would suggest you not do this in future but wait until the podling vote is over. If an issue was found and the vote cancelled then IPMC may not be so inclined to vote of future votes, it also means you’re asking the IPMC to vote without full information on the outcome of the podling vote. there are no carry over votes here because the voting on the podling list has not been finished. Thanks, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache Zipkin (incubating) version 2.14.0
> Please vote accordingly: > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove with the reason +1 - built source - checked sha - checked copyright and licence (noting Justin's points) - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache Zipkin (incubating) version 2.14.0
As mentor is member of PPMC and IPMC, it could speed up the voting process by getting the mentor involved at the earlier stage. Normally we just wait for the PPMC to do the technical check then we go through the License check in the IPMC vote. But for Zipkin, there are lots of community releases which are built on top of auto tools, so I think it's much safer for us to start a parallel vote both PPMC and IPMC. Any thoughts? Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Fri, May 17, 2019 at 4:54 PM Justin Mclean wrote: > > Hi, > > > This vote is running concurrent with the above, carrying over 3 > > binding +1 votes from mentors Willem Ning Jiang, Sheng Wu and Andriy > > Redko. > > Given that people can change their vote I would suggest you not do this in > future but wait until the podling vote is over. If an issue was found and the > vote cancelled then IPMC may not be so inclined to vote of future votes, it > also means you’re asking the IPMC to vote without full information on the > outcome of the podling vote. there are no carry over votes here because the > voting on the podling list has not been finished. > > Thanks, > Justin > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache Zipkin (incubating) version 2.14.0
Hi, > But for Zipkin, there are lots of community releases which are built > on top of auto tools, so I think it's much safer for us to start a > parallel vote both PPMC and IPMC. Given all release I’ve looked at had license (or other) issues why do you think that the “auto tools” are doing what is required and that there is a requirement for doing this? Or why do you feel you need to get releases out before they comply with ASF policy? You'll allow note that issues pointed out with previous releases still occur in later releases and that’s probably an issue you need to look into. Thanks, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache Zipkin (incubating) version 2.14.0
maybe you can open source the tools you use justin. you seem uncanny ability to find glitches, yet also have an ability to ignore note in the vote request mentioning known issues. start helping instead of finding faults. you are the reason incubator is not something anyone wants to go through On Sat, May 18, 2019, 3:20 PM Justin Mclean wrote: > Hi, > > > But for Zipkin, there are lots of community releases which are built > > on top of auto tools, so I think it's much safer for us to start a > > parallel vote both PPMC and IPMC. > > Given all release I’ve looked at had license (or other) issues why do you > think that the “auto tools” are doing what is required and that there is a > requirement for doing this? Or why do you feel you need to get releases out > before they comply with ASF policy? You'll allow note that issues pointed > out with previous releases still occur in later releases and that’s > probably an issue you need to look into. > > Thanks, > Justin > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re: [VOTE] Release Apache Zipkin (incubating) version 2.14.0
In defence of Justin :-) I'm very sure NetBeans would not be as solid and well placed in Apache right now, outside the Incubator, without Justin's uncanny ability to find glitches. :-) Gj On Sat, May 18, 2019 at 4:59 PM Adrian Cole wrote: > maybe you can open source the tools you use justin. > > you seem uncanny ability to find glitches, yet also have an ability to > ignore note in the vote request mentioning known issues. > > start helping instead of finding faults. you are the reason incubator is > not something anyone wants to go through > > On Sat, May 18, 2019, 3:20 PM Justin Mclean > wrote: > > > Hi, > > > > > But for Zipkin, there are lots of community releases which are built > > > on top of auto tools, so I think it's much safer for us to start a > > > parallel vote both PPMC and IPMC. > > > > Given all release I’ve looked at had license (or other) issues why do you > > think that the “auto tools” are doing what is required and that there is > a > > requirement for doing this? Or why do you feel you need to get releases > out > > before they comply with ASF policy? You'll allow note that issues pointed > > out with previous releases still occur in later releases and that’s > > probably an issue you need to look into. > > > > Thanks, > > Justin > > - > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > >
Re: [VOTE] Release Apache Zipkin (incubating) version 2.14.0
the fact people allow tools like apache RAT to rot, yet somehow can find glitches in dozens of repos tells me priorities are whacked. For example, the last release justin found a second header on a file that said it was temporary (now deleted) did he manually look at hundreds of files to see that? If not, why are the tools we are supposed to use hamstrung? A correct optimization is empowering projects to succeed on their own. RAT is a part of that. Why are there better tools not available? Why is a second license a "ISSUE" that needs to be discussed in consideration of whether a vote is 3+1 days or 3+3 days. The bias is towards making things problems, not putting them in perspective or addressing long held issues that make this whole thing eggshell (ex RAT) On Sat, May 18, 2019 at 5:33 PM Geertjan Wielenga wrote: > > In defence of Justin :-) I'm very sure NetBeans would not be as solid and > well placed in Apache right now, outside the Incubator, without Justin's > uncanny ability to find glitches. :-) > > Gj > > On Sat, May 18, 2019 at 4:59 PM Adrian Cole wrote: > > > maybe you can open source the tools you use justin. > > > > you seem uncanny ability to find glitches, yet also have an ability to > > ignore note in the vote request mentioning known issues. > > > > start helping instead of finding faults. you are the reason incubator is > > not something anyone wants to go through > > > > On Sat, May 18, 2019, 3:20 PM Justin Mclean > > wrote: > > > > > Hi, > > > > > > > But for Zipkin, there are lots of community releases which are built > > > > on top of auto tools, so I think it's much safer for us to start a > > > > parallel vote both PPMC and IPMC. > > > > > > Given all release I’ve looked at had license (or other) issues why do you > > > think that the “auto tools” are doing what is required and that there is > > a > > > requirement for doing this? Or why do you feel you need to get releases > > out > > > before they comply with ASF policy? You'll allow note that issues pointed > > > out with previous releases still occur in later releases and that’s > > > probably an issue you need to look into. > > > > > > Thanks, > > > Justin > > > - > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > > - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache Zipkin (incubating) version 2.14.0
Probably more than anyone in the world, I feel your pain. Tip: document everything Justin identifies as a problem, focus on those items in addition to everything you’re focusing on already, and each release will be less painful than the one before. Gj On Sat, 18 May 2019 at 17:46, Adrian Cole wrote: > the fact people allow tools like apache RAT to rot, yet somehow can > find glitches in dozens of repos tells me priorities are whacked. > > For example, the last release justin found a second header on a file > that said it was temporary (now deleted) > > did he manually look at hundreds of files to see that? If not, why are > the tools we are supposed to use hamstrung? A correct optimization is > empowering projects to succeed on their own. RAT is a part of that. > Why are there better tools not available? Why is a second license a > "ISSUE" that needs to be discussed in consideration of whether a vote > is 3+1 days or 3+3 days. The bias is towards making things problems, > not putting them in perspective or addressing long held issues that > make this whole thing eggshell (ex RAT) > > On Sat, May 18, 2019 at 5:33 PM Geertjan Wielenga > wrote: > > > > In defence of Justin :-) I'm very sure NetBeans would not be as solid and > > well placed in Apache right now, outside the Incubator, without Justin's > > uncanny ability to find glitches. :-) > > > > Gj > > > > On Sat, May 18, 2019 at 4:59 PM Adrian Cole > wrote: > > > > > maybe you can open source the tools you use justin. > > > > > > you seem uncanny ability to find glitches, yet also have an ability to > > > ignore note in the vote request mentioning known issues. > > > > > > start helping instead of finding faults. you are the reason incubator > is > > > not something anyone wants to go through > > > > > > On Sat, May 18, 2019, 3:20 PM Justin Mclean > > > wrote: > > > > > > > Hi, > > > > > > > > > But for Zipkin, there are lots of community releases which are > built > > > > > on top of auto tools, so I think it's much safer for us to start a > > > > > parallel vote both PPMC and IPMC. > > > > > > > > Given all release I’ve looked at had license (or other) issues why > do you > > > > think that the “auto tools” are doing what is required and that > there is > > > a > > > > requirement for doing this? Or why do you feel you need to get > releases > > > out > > > > before they comply with ASF policy? You'll allow note that issues > pointed > > > > out with previous releases still occur in later releases and that’s > > > > probably an issue you need to look into. > > > > > > > > Thanks, > > > > Justin > > > > - > > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > > > > > > > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re: [VOTE] Release Apache Zipkin (incubating) version 2.14.0
HI,
> maybe you can open source the tools you use justin.
I spoken about it at many ApacheCons and provided "them" here on this list.
Calling them tools is probably an exaggeration, It’s nothing complex.
Here’s the tool I used:
search copyright | sort -u
(Where search is "find . -type f -exec grep -i "$1" {} \;“)
I then look at the files it finds to see if they match with what is listed in
LICENSE.
Sometime I might do a few more searches like "search BSD" or "search MIT” or
“search general public license”. I didn’t in this case.
Do note that this will not catch the case where a header had moved or altered
or code been minified. Tools are there to just help and will not find
everything. If you want something more comprehensive I suggest you setup
Fossology [1].
> you seem uncanny ability to find glitches, yet also have an ability to
> ignore note in the vote request mentioning known issues.
None of the issue I mentioned where mentioned in the vote as from what I can
see?
> start helping instead of finding faults. you are the reason incubator is
> not something anyone wants to go through
I am helping, you’ll note a) I voted +1 b) provided feedback that will improve
your next release.
The incubator is here to help, if you want things checked in a release before
you vote on it then just ask here. If you want to try out a new process or
change how you vote on something then you can discuss it here.
Thanks,
Justin
1. https://www.fossology.org
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache Zipkin (incubating) version 2.14.0
Hi, > the fact people allow tools like apache RAT to rot, yet somehow can > find glitches in dozens of repos tells me priorities are whacked. If you’ve found an issue with Rat please raise an issue with that project. Rat isn’t expected to be perfect, as it says: Rat is really little more than a grep ATM Rat is also rather memory hungry ATM Rat is very basic ATM Rat highlights possible issues Rat reports require intepretation Rat often requires some tuning before it runs well against a project Rat relies on heuristics: it may miss issues Thanks, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache Zipkin (incubating) version 2.14.0
I'd second Geertjan's comments about how helpful (even though it probably
seemed painful at the time) Justin's comments were for Apache Groovy during
our incubation.
Perhaps it is worth re-reading some of the reasons why The ASF values
highly the provenance behind all of the software in its builds (probably
3rd para is the most relevant):
http://www.apache.org/legal/release-policy.html#why
I have also found Justin's ApacheCon talks very interesting. I couldn't
find the most relevant one but one with additional tools for looking at
large code bases can be found here:
https://static.sched.com/hosted_files/apachecon2016/75/CodeAnalysis_ApacheCon2016.pdf
Cheers, Paul.
On Sun, May 19, 2019 at 8:57 AM Justin Mclean
wrote:
> HI,
>
> > maybe you can open source the tools you use justin.
>
> I spoken about it at many ApacheCons and provided "them" here on this
> list. Calling them tools is probably an exaggeration, It’s nothing complex.
>
> Here’s the tool I used:
>
> search copyright | sort -u
>
> (Where search is "find . -type f -exec grep -i "$1" {} \;“)
>
> I then look at the files it finds to see if they match with what is listed
> in LICENSE.
>
> Sometime I might do a few more searches like "search BSD" or "search MIT”
> or “search general public license”. I didn’t in this case.
>
> Do note that this will not catch the case where a header had moved or
> altered or code been minified. Tools are there to just help and will not
> find everything. If you want something more comprehensive I suggest you
> setup Fossology [1].
>
> > you seem uncanny ability to find glitches, yet also have an ability to
> > ignore note in the vote request mentioning known issues.
>
> None of the issue I mentioned where mentioned in the vote as from what I
> can see?
>
> > start helping instead of finding faults. you are the reason incubator is
> > not something anyone wants to go through
>
> I am helping, you’ll note a) I voted +1 b) provided feedback that will
> improve your next release.
>
> The incubator is here to help, if you want things checked in a release
> before you vote on it then just ask here. If you want to try out a new
> process or change how you vote on something then you can discuss it here.
>
> Thanks,
> Justin
>
> 1. https://www.fossology.org
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>
Re: [VOTE] Release Apache Zipkin (incubating) version 2.14.0
Hi, Here’s some other links that may help. A worked example on how to assemble LICENSE and NOTICE: https://github.com/justinmclean/ApacheWombat https://vimeo.com/171210141 A previous incubator talk (from 2017): https://www.youtube.com/watch?v=I0-lp1t9ee0 A talk I gave last year it currently being donated to Apache Training that might also help. [1] Thanks, Justin 1. https://github.com/apache/incubator-training/tree/master/content/ApacheWay/NavigatingASFIncubation - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
[RESULT][VOTE] Release Apache Zipkin (incubating) version 2.14.0
Thanks to everyone that participated. The vote to release Release Apache Zipkin (incubating) version 2.14.0 is now closed. It PASSED with 5 (+1 binding) votes and no 0 or -1 votes: +1 Willem Ning Jiang (binding) +1 Sheng Wu (binding) +1 Andriy Redko (binding) +1 Michael Semb Wever (binding) +1 Justin Mclean (binding) Vote thread: https://lists.apache.org/thread.html/0b52a3437370937c98724f5478002fe65b68717f30387595be4cd18e@%3Cgeneral.incubator.apache.org%3E We will work to complete the release process. Thanks, The Apache Zipkin (Incubating) Team - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
