[Geoserver-devel] asking before doing something strange
After troubleshooting we have a PR for GEOS-10871 <https://osgeo-org.atlassian.net/browse/GEOS-10871> which changes the maven configuration of antrun to use a consistent version. Due to version inconsistencies the version of geoserver released to source forge and deployed to maven were slightly different. With this in mind I would like to do something strange: 1. Create a 2.22.2.x branch 2. Cherry pick this build change 3. Re-deploy 2.22.2 artifacts to maven 4. Update the 2.22.x tag to the new revision There are no java source code changes here; but moving tags and so on is a strange and unusual response to a strange and unusual problem. -- Jody Garnett ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
[Geoserver-devel] [JIRA] (GEOS-10871) about geoserver page reporting @project.version@ for WAR deploy
Jody Garnett ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae422bb7f-4808-47e3-837f-13db0e6681e3 ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiMzNlMmE2ZWNjMmFjNGNjNzljMjE4MWQzYWU2MTY2NzYiLCJwIjoiaiJ9 ) / Bug ( https://osgeo-org.atlassian.net/browse/GEOS-10871?atlOrigin=eyJpIjoiMzNlMmE2ZWNjMmFjNGNjNzljMjE4MWQzYWU2MTY2NzYiLCJwIjoiaiJ9 ) GEOS-10871 ( https://osgeo-org.atlassian.net/browse/GEOS-10871?atlOrigin=eyJpIjoiMzNlMmE2ZWNjMmFjNGNjNzljMjE4MWQzYWU2MTY2NzYiLCJwIjoiaiJ9 ) about geoserver page reporting @project.version@ for WAR deploy ( https://osgeo-org.atlassian.net/browse/GEOS-10871?atlOrigin=eyJpIjoiMzNlMmE2ZWNjMmFjNGNjNzljMjE4MWQzYWU2MTY2NzYiLCJwIjoiaiJ9 ) Issue Type: Bug Affects Versions: 2.21.1, 2.22.2 Assignee: Unassigned Components: web-app Created: 23/Feb/23 6:59 PM Priority: Medium Reporter: Jody Garnett ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae422bb7f-4808-47e3-837f-13db0e6681e3 ) We have reports from email and gitter that the *About GeoServer* page is showing incorrect information: > > > > Hi, our team started upgrading to 2.22.2. We noticed that Geoserver > version number is showing as @project.version@. > > ( https://osgeo-org.atlassian.net/browse/GEOS-10871#add-comment?atlOrigin=eyJpIjoiMzNlMmE2ZWNjMmFjNGNjNzljMjE4MWQzYWU2MTY2NzYiLCJwIjoiaiJ9 ) Add Comment ( https://osgeo-org.atlassian.net/browse/GEOS-10871#add-comment?atlOrigin=eyJpIjoiMzNlMmE2ZWNjMmFjNGNjNzljMjE4MWQzYWU2MTY2NzYiLCJwIjoiaiJ9 ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100217- sha1:7bcbf31 )___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] GeoServer.org web site seems to have gone missing
It seems that Andrea has fixed it, it was a custom domain setting in github pages (was blank for some reason). Thanks for troubleshooting Andrea -- Jody Garnett On Mon, Feb 20, 2023 at 6:25 AM Ian Turton wrote: > Is this related to today's releases? Is some one looking at it or should I > have a go? > > Ian > > -- > Ian Turton > ___ > Geoserver-devel mailing list > Geoserver-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geoserver-devel > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] Scheduling GeoServer 2.21.4 release for next week
Announcement for 2.22.2 and 2.21.4 is available https://github.com/geoserver/geoserver.github.io/pull/140 Also: - a security vulnerability statement, including the CVE numbers etc... - filled in the jira placeholders with a title, and a description linking to the security vulnerabilities - the vulnerabilities remain in draft so the jira links are broken until they are published If any additional releases are being made they can be added to the vulnerability statement above. I can see Andrea backporting the geotools fix to several branches here: https://osgeo-org.atlassian.net/browse/GEOT-7302 -- Jody Garnett On Sat, Feb 18, 2023 at 8:21 AM Jody Garnett wrote: > Thanks SO much for the extensive testing. I will work on the release > announcement for Monday. > > I should be able to fill in a more specific build date in the read me - > ant is doing the work and has extensive date formatting. > > If anyone is feeling adventurous the styles can support more language code > - just need more options added to the recode statement. > > Jody > > On Fri, Feb 17, 2023 at 9:42 PM Brad Hards wrote: > >> On Saturday, 18 February 2023 2:18:25 PM AEDT Jody Garnett wrote: >> > The next release is available for preflight testing >> > >> https://build.geoserver.org/view/release/job/geoserver-release/lastSuccessfu >> > lBuild/artifact/distribution/2.22.2/ -- >> >> Thanks for the release work. >> >> Downloaded javadoc package. Unzipped OK. Opened in Firefox, version >> number >> correct. Poked around a bit, links appeared OK, no problems noted. >> >> Downloaded html package. Unzipped OK. Opened in Firefox, version number >> correct. Poked around a bit in user manual. Links appeared OK (including >> x-ref >> to JIRA and github for edit). No problems noted. >> Same for developer manual (although the release testing checklist was >> noted as >> being a bit out-of-date, that isn't a new issue). >> REST API is documented as Version 1.0.0, but no problems noted. >> Top level README, license and version OK (although it would be nice if >> the >> build date was more specific). >> >> Downloaded the war package. Unzipped OK. Booted it on a Tomcat 9 install >> on >> ubuntu (9.0.58-1ubuntu0.1) with openjdk (11.0.17) - distro packages. >> Log in OK, poked around with layer preview. Checked a couple of >> capabilities. >> No problems noted. The new data and styling is nice improvement. >> >> Overall: LGTM. >> >> Brad >> >> >> >> -- > -- > Jody Garnett > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] Scheduling GeoServer 2.21.4 release for next week
Thanks SO much for the extensive testing. I will work on the release announcement for Monday. I should be able to fill in a more specific build date in the read me - ant is doing the work and has extensive date formatting. If anyone is feeling adventurous the styles can support more language code - just need more options added to the recode statement. Jody On Fri, Feb 17, 2023 at 9:42 PM Brad Hards wrote: > On Saturday, 18 February 2023 2:18:25 PM AEDT Jody Garnett wrote: > > The next release is available for preflight testing > > > https://build.geoserver.org/view/release/job/geoserver-release/lastSuccessfu > > lBuild/artifact/distribution/2.22.2/ -- > > Thanks for the release work. > > Downloaded javadoc package. Unzipped OK. Opened in Firefox, version number > correct. Poked around a bit, links appeared OK, no problems noted. > > Downloaded html package. Unzipped OK. Opened in Firefox, version number > correct. Poked around a bit in user manual. Links appeared OK (including > x-ref > to JIRA and github for edit). No problems noted. > Same for developer manual (although the release testing checklist was > noted as > being a bit out-of-date, that isn't a new issue). > REST API is documented as Version 1.0.0, but no problems noted. > Top level README, license and version OK (although it would be nice if the > build date was more specific). > > Downloaded the war package. Unzipped OK. Booted it on a Tomcat 9 install > on > ubuntu (9.0.58-1ubuntu0.1) with openjdk (11.0.17) - distro packages. > Log in OK, poked around with layer preview. Checked a couple of > capabilities. > No problems noted. The new data and styling is nice improvement. > > Overall: LGTM. > > Brad > > > > -- -- Jody Garnett ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] Scheduling GeoServer 2.21.4 release for next week
The next release is available for preflight testing https://build.geoserver.org/view/release/job/geoserver-release/lastSuccessfulBuild/artifact/distribution/2.22.2/ -- Jody Garnett On Fri, Feb 17, 2023 at 7:42 AM Jody Garnett wrote: > Okay, got an update via chat - too many moving parts depend on Monday > announcement. > > I will go get back at it ... > -- > Jody Garnett > > > On Fri, Feb 17, 2023 at 7:34 AM Jody Garnett > wrote: > >> Andrea given the sheer number of releases being scheduled; and it is a >> public holiday on monday for me - I propose publishing the updates on >> Tuesday. >> >> The first update is now on SF - >> https://sourceforge.net/projects/geoserver/files/GeoServer/2.21.4/ >> >> The 2.22.x updating being build later today >> -- >> Jody Garnett >> >> >> On Thu, Feb 16, 2023 at 2:37 PM Jody Garnett >> wrote: >> >>> Preflight artifacts are available for testing: >>> https://build.geoserver.org/view/geoserver/job/geoserver-release/lastSuccessfulBuild/artifact/distribution/2.21.4/ >>> >>> Also pleased to report that the windows job kicked off successfully. >>> -- >>> Jody Garnett >>> >>> >>> On Fri, Feb 10, 2023 at 1:10 AM Jody Garnett >>> wrote: >>> >>>> GeoServer team: >>>> >>>> I am scheduled >>>> <https://github.com/geoserver/geoserver/wiki/Release-Schedule> to >>>> release GeoServer 2.21.4 maintenance release next week, if you have any >>>> outstanding changes for this update please speak up now. >>>> >>>> I would also like to schedule an additional GeoServer 2.28.2 release >>>> next week. >>>> -- >>>> Jody Garnett >>>> >>> ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] Scheduling GeoServer 2.21.4 release for next week
Okay, got an update via chat - too many moving parts depend on Monday announcement. I will go get back at it ... -- Jody Garnett On Fri, Feb 17, 2023 at 7:34 AM Jody Garnett wrote: > Andrea given the sheer number of releases being scheduled; and it is a > public holiday on monday for me - I propose publishing the updates on > Tuesday. > > The first update is now on SF - > https://sourceforge.net/projects/geoserver/files/GeoServer/2.21.4/ > > The 2.22.x updating being build later today > -- > Jody Garnett > > > On Thu, Feb 16, 2023 at 2:37 PM Jody Garnett > wrote: > >> Preflight artifacts are available for testing: >> https://build.geoserver.org/view/geoserver/job/geoserver-release/lastSuccessfulBuild/artifact/distribution/2.21.4/ >> >> Also pleased to report that the windows job kicked off successfully. >> -- >> Jody Garnett >> >> >> On Fri, Feb 10, 2023 at 1:10 AM Jody Garnett >> wrote: >> >>> GeoServer team: >>> >>> I am scheduled >>> <https://github.com/geoserver/geoserver/wiki/Release-Schedule> to >>> release GeoServer 2.21.4 maintenance release next week, if you have any >>> outstanding changes for this update please speak up now. >>> >>> I would also like to schedule an additional GeoServer 2.28.2 release >>> next week. >>> -- >>> Jody Garnett >>> >> ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] Scheduling GeoServer 2.21.4 release for next week
Andrea given the sheer number of releases being scheduled; and it is a public holiday on monday for me - I propose publishing the updates on Tuesday. The first update is now on SF - https://sourceforge.net/projects/geoserver/files/GeoServer/2.21.4/ The 2.22.x updating being build later today -- Jody Garnett On Thu, Feb 16, 2023 at 2:37 PM Jody Garnett wrote: > Preflight artifacts are available for testing: > https://build.geoserver.org/view/geoserver/job/geoserver-release/lastSuccessfulBuild/artifact/distribution/2.21.4/ > > Also pleased to report that the windows job kicked off successfully. > -- > Jody Garnett > > > On Fri, Feb 10, 2023 at 1:10 AM Jody Garnett > wrote: > >> GeoServer team: >> >> I am scheduled >> <https://github.com/geoserver/geoserver/wiki/Release-Schedule> to >> release GeoServer 2.21.4 maintenance release next week, if you have any >> outstanding changes for this update please speak up now. >> >> I would also like to schedule an additional GeoServer 2.28.2 release next >> week. >> -- >> Jody Garnett >> > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] Scheduling GeoServer 2.21.4 release for next week
Preflight artifacts are available for testing: https://build.geoserver.org/view/geoserver/job/geoserver-release/lastSuccessfulBuild/artifact/distribution/2.21.4/ Also pleased to report that the windows job kicked off successfully. -- Jody Garnett On Fri, Feb 10, 2023 at 1:10 AM Jody Garnett wrote: > GeoServer team: > > I am scheduled > <https://github.com/geoserver/geoserver/wiki/Release-Schedule> to release > GeoServer 2.21.4 maintenance release next week, if you have any outstanding > changes for this update please speak up now. > > I would also like to schedule an additional GeoServer 2.28.2 release next > week. > -- > Jody Garnett > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
[Geoserver-devel] [JIRA] (GEOS-10862) JAIExt registerOp and CoverageProcessor messages on startup
Jody Garnett ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae422bb7f-4808-47e3-837f-13db0e6681e3 ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiMmE3NmJhM2Q5NmYyNGY2OGFmY2ZjOTc5NDRjNzVlOGQiLCJwIjoiaiJ9 ) / Task ( https://osgeo-org.atlassian.net/browse/GEOS-10862?atlOrigin=eyJpIjoiMmE3NmJhM2Q5NmYyNGY2OGFmY2ZjOTc5NDRjNzVlOGQiLCJwIjoiaiJ9 ) GEOS-10862 ( https://osgeo-org.atlassian.net/browse/GEOS-10862?atlOrigin=eyJpIjoiMmE3NmJhM2Q5NmYyNGY2OGFmY2ZjOTc5NDRjNzVlOGQiLCJwIjoiaiJ9 ) JAIExt registerOp and CoverageProcessor messages on startup ( https://osgeo-org.atlassian.net/browse/GEOS-10862?atlOrigin=eyJpIjoiMmE3NmJhM2Q5NmYyNGY2OGFmY2ZjOTc5NDRjNzVlOGQiLCJwIjoiaiJ9 ) Issue Type: Task Affects Versions: 2.21.4 Assignee: Unassigned Components: Main Created: 16/Feb/23 1:15 AM Priority: Medium Reporter: Jody Garnett ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae422bb7f-4808-47e3-837f-13db0e6681e3 ) On startup GeoServer 2.21.x is producing warnings due to normal operation of JAI: 15 Feb. 16:08:38 WARN [coverage.processing] - Operation: BandCombine not found in CoverageProcessor 15 Feb. 16:08:38 WARN [coverage.processing] - Operation: BandSelect not found in CoverageProcessor 15 Feb. 16:08:38 WARN [coverage.processing] - Operation: Binarize not found in CoverageProcessor ... 15 Feb. 16:08:38 WARN [coverage.processing] - Operation: AndConst not found in CoverageProcessor 15 Feb. 16:08:38 WARN [coverage.processing] - Operation: OrConst not found in CoverageProcessor 15 Feb. 16:08:38 WARN [coverage.processing] - Operation: XorConst not found in CoverageProcessor JAIExt registerOp produces a series of INFO messages which may or may not be necessary? Reducing these to CONFIG allow for a clean startup. These messages also include a linefeed (not sure why). Feb. 15, 2023 4:08:38 P.M. it.geosolutions.jaiext.JAIExt registerOp INFO: Registered operation: Affine Feb. 15, 2023 4:08:38 P.M. it.geosolutions.jaiext.JAIExt registerOp INFO: Registered operation: BandCombine ... Feb. 15, 2023 4:08:38 P.M. it.geosolutions.jaiext.JAIExt registerOp INFO: Unable to register the descriptor related to the following operation: Null ... Feb. 15, 2023 4:08:38 P.M. it.geosolutions.jaiext.JAIExt registerOp INFO: Registered operation: operationConst One of the operations has a null descriptor, failing to register which should be a WARNING? ( https://osgeo-org.atlassian.net/browse/GEOS-10862#add-comment?atlOrigin=eyJpIjoiMmE3NmJhM2Q5NmYyNGY2OGFmY2ZjOTc5NDRjNzVlOGQiLCJwIjoiaiJ9 ) Add Comment ( https://osgeo-org.atlassian.net/browse/GEOS-10862#add-comment?atlOrigin=eyJpIjoiMmE3NmJhM2Q5NmYyNGY2OGFmY2ZjOTc5NDRjNzVlOGQiLCJwIjoiaiJ9 ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100216- sha1:a1e7611 )___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] (GEOS-10705) Loading missing resources creates unsolicited empty files
Hey Dieter:
Checking-in on this email thread - you are welcome to make a GSIP page now
as it could help capture your understanding and improvements you have made
thus far (and are considering). Indeed I recommend you do this as you are
asking more and more interesting questions :)
Do you wish me to review #6570 - or are you still thinking through
options
--
Jody Garnett
On Fri, Feb 3, 2023 at 9:24 AM Dieter Stüken - con terra GmbH <
d.stue...@conterra.de> wrote:
> Hi Jody,
>
>
>
> after the pull requests for [GEOS-10723] [GEOS-10724] and [GEOS-10743]
> accepted, we may also close the issues, doo.
>
> I went back to [10705] again and started another PR #6570
> <https://github.com/geoserver/geoserver/pull/6570>.
>
>
>
> The more I dive into the Resource API the more questions arise.
>
> After reading the GSIPs about it, I think I should probably have made a
> separate GSIP from it.
>
>
>
> Solving the Resource.in() problem, I noticed, that calling Resorce.file()
> raises similar problems.
>
> Probably we need a hint whether the intention is to read the file or to
> create the file.
>
> But this really breaks the current API.
>
>
>
> I also just detected the jdbcstore community module. I’m currently about
> to understand it….
>
>
>
> Then I think about the IllegalStateException thrown.
>
> This should possibly be an UncheckedIOException (since 1.8) which
> definitely covers the underlying FileNotFound Exception.
>
> Don’t see if this concerns any error handling.
>
>
>
> And then the idea of using Optional or Consumer to hide the
> sensitive parts of dealing with the Inputstream.
>
> This may also improve many of the deeply nested error handlers.
>
>
>
> Regards, Dieter.
>
>
>
> *Von:* Jody Garnett
> *Gesendet:* Freitag, 21. Oktober 2022 21:58
> *An:* Dieter Stüken - con terra GmbH
> *Cc:* GeoServer
> *Betreff:* Re: [Geoserver-devel] (GEOS-10705) Loading missing resources
> creates unsolicited empty files
>
>
>
> It is worth proposing a refactoring here.
>
>
>
> The guideline during the api developement was to optimize for the most
> common patterns of File usage we found in the codebase; and utillity
> methods such as in() for common usage patterns. Where possible we provided
> method name compatibility so it would be easier to migrate code from File
> to Resource.
>
>
>
> I was expecting far more input on this API when it was first introduced;
> your input is welcome now.
>
>
>
> For the specific example you show:
>
> - in() should not accidentally create a file for UNDEFINED
>
> - returning an empty input stream would be okay - less for client code to
> handle. I understand that failed parsing expression is not so fun
>
> - throwing UncheckedIOException is okay - concerned it would lead to a
> bunch of boiler plate code try / catch being introduced
>
>
>
> Since we have the whole codebase available it should be easy to access
> what this change would require and answer the concerns above.
>
>
>
> Whatever change is made I ask that the javadocs be clearly updated.
>
> --
>
> Jody
>
>
>
> On Fri, Oct 21, 2022 at 12:03 PM Dieter Stüken - con terra GmbH via
> Geoserver-devel wrote:
>
> Hi dev list,
>
> I frequently noticed, that Resource.in() just creates non existing files
> and then returns an empty input stream. This almost ever causes further
> problems like https://github.com/geoserver/geoserver/pull/6216
> <https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgeoserver%2Fgeoserver%2Fpull%2F6216&data=05%7C01%7C%7C2e008cb088634d28236808dab39e8a6a%7C6e0bfede3fcb4518a16565dc14fe5620%7C0%7C0%7C638019790762577204%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000%7C%7C%7C&sdata=WS6HiPOGG7gg6E4SsnCg07apkqnWcU%2Bs04%2BSpwky9qQ%3D&reserved=0>
> .
>
> I think the root cause is the implementation of Resource.in() for
> UNDEFINED resources.
> Looking at Files.ResourceAdaptor.in
> <https://eur04.safelinks.protection.outlook.com/?url=http%3A%2F%2Ffiles.resourceadaptor.in%2F&data=05%7C01%7C%7C2e008cb088634d28236808dab39e8a6a%7C6e0bfede3fcb4518a16565dc14fe5620%7C0%7C0%7C638019790762577204%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000%7C%7C%7C&sdata=dIAvutYZgvYtC9nsJSkaEHLDqIJb2sVEOO8aj1Tl4wg%3D&reserved=0>()
> I find:
>
> final File actualFile = file();
> if (!actualFile.exists()) {
> throw new IllegalStateException("Cannot access " + actualFile);
> }
>
> Seems, the initial intention was to throw an exception, but since file
Re: [Geoserver-devel] Scheduling GeoServer 2.21.4 release for next week
Going to reply to this thread with a request to review https://github.com/geoserver/geoserver/pull/6604 A small fix so that the welcome blurb respects the session Locale. This PR is for 2.22.x so there is a bit of time to review still. -- Jody Garnett On Fri, Feb 10, 2023 at 1:10 AM Jody Garnett wrote: > GeoServer team: > > I am scheduled > <https://github.com/geoserver/geoserver/wiki/Release-Schedule> to release > GeoServer 2.21.4 maintenance release next week, if you have any outstanding > changes for this update please speak up now. > > I would also like to schedule an additional GeoServer 2.28.2 release next > week. > -- > Jody Garnett > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] Cleaning up extensions and community modules in preparation for 2.23-RC
Andrea: Your suggestions seem good. I waned to ask if https://docs.geoserver.org/latest/en/user/community/dds/index.html is in use? GeoStyler docs need to be removed https://docs.geoserver.org/latest/en/user/community/geostyler/index.html as the project dropped out of community. Any other docs that can be cleaned up? Has COG received enough real world use to be considered an extension. I have had customers using it for 6 months now; but I understand we try for a year in production. -- Jody Garnett On Tue, Feb 14, 2023 at 8:27 AM Andrea Aime < andrea.a...@geosolutionsgroup.com> wrote: > Hi all, > in preparation for the 2.23-RC release, I was looking at > community and extension modules that could be dropped. > > I'd suggest moving these modules down, from extension to community: > >- XLST. I have built that 10 years ago, has been sitting there >quietly, mostly gathering dust, haven't touched it since. I'd say it did >not find interest in the community. >- imagemap, originally maintained by Mauro Bartolomeoli. Mauro has not >been active for a while (knock if you read this mail Mauro!) and image maps >have been out of favor in front end development for a long while now. > > Speaking of community modules instead, I'd suggest removing from the > source tree the following: > >- WMS-EO (lack of use/interest) >- SAML (anyone using it?) >- OWS-Simulate (contributed by Justin some year ago, does it still >have any use?) >- NSG-WMTS profile (no traction) >- WMTS-styles (part of a testbed, did not have follow up) >- ogcapi/image (an experiment, did not have follow up) >- ext-teradata (with the removal of the corresponding geotools code >- importer-fgdb (not even in the community build) > > Anything more? Or anything you're still interested in keeping around with > a minimum of care and feeding for the module? > > Cheers > Andrea > > == > GeoServer Professional Services from the experts! > > Visit http://bit.ly/gs-services-us for more information. > == > > Ing. Andrea Aime > @geowolf > Technical Lead > > GeoSolutions Group > phone: +39 0584 962313 > > fax: +39 0584 1660272 > > mob: +39 339 8844549 > > https://www.geosolutionsgroup.com/ > > http://twitter.com/geosolutions_it > > --- > > Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE > 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si > precisa che ogni circostanza inerente alla presente email (il suo > contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è > riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il > messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra > operazione è illecita. Le sarei comunque grato se potesse darmene notizia. > > This email is intended only for the person or entity to which it is > addressed and may contain information that is privileged, confidential or > otherwise protected from disclosure. We remind that - as provided by > European Regulation 2016/679 “GDPR” - copying, dissemination or use of this > e-mail or the information herein by anyone other than the intended > recipient is prohibited. If you have received this email by mistake, please > notify us immediately by telephone or e-mail > ___ > Geoserver-devel mailing list > Geoserver-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geoserver-devel > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] Scheduling GeoServer 2.21.4 release for next week
You are indeed korrekt! I intended to release Geoserver 2.22.2 (thanks for all the fixes on welcome page performance). -- Jody Garnett On Fri, Feb 10, 2023 at 10:47 AM Andrea Aime < andrea.a...@geosolutionsgroup.com> wrote: > On Fri, Feb 10, 2023 at 10:12 AM Jody Garnett > wrote: > >> GeoServer team: >> >> I am scheduled >> <https://github.com/geoserver/geoserver/wiki/Release-Schedule> to >> release GeoServer 2.21.4 maintenance release next week, if you have any >> outstanding changes for this update please speak up now. >> >> I would also like to schedule an additional GeoServer 2.28.2 release next >> week. >> > > I'm torn between a time machine and a typo... I guess it's 2.22.2... > although the time machine would have been more fun 😂 > > Cheers > Andrea > > == > > GeoServer Professional Services from the experts! > > Visit http://bit.ly/gs-services-us for more information. > == > > Ing. Andrea Aime > @geowolf > Technical Lead > > GeoSolutions Group > phone: +39 0584 962313 > > fax: +39 0584 1660272 > > mob: +39 339 8844549 > > https://www.geosolutionsgroup.com/ > > http://twitter.com/geosolutions_it > > --- > > Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE > 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si > precisa che ogni circostanza inerente alla presente email (il suo > contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è > riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il > messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra > operazione è illecita. Le sarei comunque grato se potesse darmene notizia. > > This email is intended only for the person or entity to which it is > addressed and may contain information that is privileged, confidential or > otherwise protected from disclosure. We remind that - as provided by > European Regulation 2016/679 “GDPR” - copying, dissemination or use of this > e-mail or the information herein by anyone other than the intended > recipient is prohibited. If you have received this email by mistake, please > notify us immediately by telephone or e-mail > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
[Geoserver-devel] Scheduling GeoServer 2.21.4 release for next week
GeoServer team: I am scheduled <https://github.com/geoserver/geoserver/wiki/Release-Schedule> to release GeoServer 2.21.4 maintenance release next week, if you have any outstanding changes for this update please speak up now. I would also like to schedule an additional GeoServer 2.28.2 release next week. -- Jody Garnett ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] [JIRA] (GEOS-10840) 2.22.1 Maven and release artifacts pushed with SNAPSHOT dependencies
Added the release notes to https://github.com/geoserver/geoserver/releases/tag/2.22.1 (as it is not reliable for public to access jira release notes) -- Jody Garnett On Mon, Jan 30, 2023 at 4:04 PM Ian Turton wrote: > No, there were no changes to GWC since 1.21.3 so we decided not to make a > new build of GWC > > Ian > > On Mon, 30 Jan 2023 at 14:55, Jody Garnett wrote: > >> Checking https://github.com/geoserver/geoserver/blob/2.22.1/src/pom.xml >> >> It has 1.21.3 >> >> Should this be 1.22.0 >> <https://github.com/GeoWebCache/geowebcache/blob/1.22.0/geowebcache/pom.xml> >> ? >> -- >> Jody Garnett >> >> >> On Fri, Jan 27, 2023 at 1:14 PM Ian Turton wrote: >> >>> My fault, I knew I shouldn't mess with the settings with out reading the >>> source code :-( >>> >>> I'll run it again. >>> >>> Ian >>> >>> On Fri, 27 Jan 2023 at 12:11, Jody Garnett >>> wrote: >>> >>>> I am glad we have an answer. >>>> Personally I understood those parameters only did a build when a >>>> revision was supplied; if an actual release tag is used no building is >>>> required? >>>> >>>> I understand that these were used to issue an emergency hotfix in the >>>> past. Now we tend to just make another geotools release if a critical fix >>>> is required. >>>> >>>> Perhaps these options could be removed? >>>> -- >>>> Jody Garnett >>>> >>>> >>>> On Fri, Jan 27, 2023 at 12:32 PM Andrea Aime < >>>> andrea.a...@geosolutionsgroup.com> wrote: >>>> >>>>> Hi, I've spent some time investigating what happened, I believe it's >>>>> user error caused by confusing parameters and a bug in the release >>>>> script... >>>>> The build has these two parameters, that I normally don't touch, set >>>>> to "skip": >>>>> >>>>> [image: image.png] >>>>> I normally don't touch them due to lack of understanding, but the >>>>> description seems to suggest "skip GT build", which is indeed >>>>> something we don't need during a release, the upstream builds are done >>>>> already. >>>>> But looking at how they work in build_release.sh >>>>> <https://github.com/geoserver/geoserver/blob/main/build/build_release.sh#L156>, >>>>> they skip the build but also skip setting gt_tag and gwc_tag, >>>>> which then are used to update the version numbers in the pom files >>>>> <https://github.com/geoserver/geoserver/blob/main/build/build_release.sh#L199> >>>>> . >>>>> >>>>> Seems like a bug in the logic of the release script IMHO, but for now, >>>>> better not set those to "skip" and let them do the extra, >>>>> unnecessary builds. >>>>> >>>>> Cheers >>>>> Andrea >>>>> >>>>> ___ >>>>> Geoserver-devel mailing list >>>>> Geoserver-devel@lists.sourceforge.net >>>>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >>>>> >>>> ___ >>>> Geoserver-devel mailing list >>>> Geoserver-devel@lists.sourceforge.net >>>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >>>> >>> >>> >>> -- >>> Ian Turton >>> >> > > -- > Ian Turton > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] [GEOS-10850] Suggested WFS-T OGC exception text improvement
Martin: I personally welcome such a change; but must advise you that every time we include real information from the database in an OGC exception text we get a security vulnerability report. Folks are especially careful with database error codes appearing anywhere in output (even exception output). As long as your improvement respects the "include stack trace" setting you should be fine. I recognize the duplication but do not know which approach is best for consistency. -- Jody Garnett On Fri, Feb 3, 2023 at 6:17 PM Kalén, Martin via Geoserver-devel < geoserver-devel@lists.sourceforge.net> wrote: > Hi, > > > > We have a use case with GeoServer + MS SQL Server where the WFS module is > connected to JDBCStore and WFS-T used for transactional operations. > > The DB model consists of two layers; lower layer with a complex data model > plus a high level “flat” view layer connected to GeoServer. Triggers in the > DB view layer perform data validation, lookups and similar. User-facing > application is an OpenLayers based web map and when the user is creating, > editing or deleting features we use WFS-T between OpenLayers and GeoServer. > > > An issue with the current GeoServer WFS module is that the root cause on > any storage exception is lost in the OGC exception report returned by WFS-T > service. E.g. if SQL error is raised with a message regarding failed > validation, missing lookup or similar. > > > > I created a JIRA issue for a suggested improvement and have started work > on a PR in a Git fork. > > See https://osgeo-org.atlassian.net/browse/GEOS-10850 and > https://github.com/sweco-semara/geoserver/commit/6c5139fe66091a1822bce643673f9018245c8c62 > > This seems to work fine, but before creating a PR I need developer’s > feedback on: > >1. Is this change welcome in GeoServer? We see an improvement for our >use-case and there are no existing tests that fail. >2. If it’s a welcome change, could a GS developer give a hint as to >where to move current code duplication for message creation (StringBuilder >handling – see “TODO” in the commit above). I have seen both static >utils/static helper classes and embedded logic in e.g. exception classes in >GeoServer codebase, so I am unsure what the current coding convention would >be? > > > > Thanks for your time. > > > > Best regards, > > Martin > > > ___ > Geoserver-devel mailing list > Geoserver-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geoserver-devel > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] (GEOS-10705) Loading missing resources creates unsolicited empty files
Dieter: First up you are absolutely not "annoying" with all your visions. Indeed I am quite happy to have such a conversation and feel it it *excellent* to have such discussion with a) the initial migration completed so we can see how the API is used b) someone (you) passionate / interested / caring. You may wish to try and attend one of the bi-weekly meetings for a more interactive discussion. I will try and respond to some of your ideas "inline" as part of this reply. > My IDE finds 163 usages. Most of them are clearly read attempts. > > What is missing is some hint about the intention (read or write). > Indeed if these are clearly read attempts then it would be good if they used *in()* or checked if the resource is a FILE before attempting a read. We have the *file*() method for when we work with systems like freemarker templates which only understand a java File reference. Any GeoServer code should be possible to refactor to use *in()*. > Currently we have no change, since the API promises to create the file. > > But I think this is misleading. I begin to understand the background of > Resource related to JDBCResource. > > In this case a file is created on demand from a database resource. > > But the relevant part is creating any missing directory structure, I think. > There are several relevant parts, creating the missing directory structure and creating the file avoid lots of code having to make such work. > > > Is there any description about what JDBCResource exactly does? > It should be an implementation of the Resource API backed by JDBC Blobs rather than files. In the case where a file is needed (for example freemarker template) the file contents are "unpacked" from the database blob into a file on disk for use. Indeed in a cluster each geoserver blob would unpack such a file for use. > If a Resource on the database was found, creating the associated file > seems OK. > > If not, does it make sense to create an empty file in advance? > If the file is being created to write to then indeed it should be created. > If the file Is written using out(), is it finally written back to the > database on close()? > Yes. > > > A possible refactoring process might be to introduce a method like > file(boolean create). > I am not sure this is needed. We do have some utility methods for common cases that could be used. I wish to have the minimal number of methods for resource store api implementations to manage. > At first we must define file() -> file(true), to retain the API. > > But we may change all those obvious read attempts to use file(false) in a > first step. > > Later on we can analyze the remaining calls. > > Could we make a summary of how many can be refactored to use *out()*, and make the rest use: - Resources.find(resource) - Resources.find(resource, boolean) Which behave in the manner you are proposing. > > > I observed, that FileSystemResource and ResourceAdaptor have a lot of > duplicate code in common. > > Is this intended? > ResourceAdaptor is intended to be quite independent, used for test cases and so forth. > ResourceAdaptor got some improvements which are not propagated to > FileSystemResource. > > I may have some suggestions to refactor the duplicate code… > Adding some package visible methods to Files class would be an appropriate location. > > > I also try to understand the lock() system. > I am curious what you will find. Another thing: If you are brave, the first thing you will notice is a terrible simulation of the Java file watching system. We were using an older version of Java that did not yet have WatchService when the API was implemented. What is there now was designed to be thrown away and replaced with WatchService when we upgraded to Java 7 :) The style of events is similar. > I read something about previous problems and I get the feeling there is > still a race condition. > > But I have to analyze this a bit deeper…. > > > > And some suggestion: I like to replace the IllegalStateException by > UncheckedIOException (since 1.8). > I think that will be fine; it will not be so confusing for JDBC implementation. -- Jody ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] (GEOS-10705) Loading missing resources creates unsolicited empty files
Dieter:
For Resource.file() we are stuck, the API allows this use in order to
create a file (and any directories required for that file location) in
order to have a file to write out to.
--
Jody Garnett
On Fri, Feb 3, 2023 at 6:24 PM Dieter Stüken - con terra GmbH <
d.stue...@conterra.de> wrote:
> Hi Jody,
>
>
>
> after the pull requests for [GEOS-10723] [GEOS-10724] and [GEOS-10743]
> accepted, we may also close the issues, doo.
>
> I went back to [10705] again and started another PR #6570
> <https://github.com/geoserver/geoserver/pull/6570>.
>
>
>
> The more I dive into the Resource API the more questions arise.
>
> After reading the GSIPs about it, I think I should probably have made a
> separate GSIP from it.
>
>
>
> Solving the Resource.in() problem, I noticed, that calling Resorce.file()
> raises similar problems.
>
> Probably we need a hint whether the intention is to read the file or to
> create the file.
>
> But this really breaks the current API.
>
>
>
> I also just detected the jdbcstore community module. I’m currently about
> to understand it….
>
>
>
> Then I think about the IllegalStateException thrown.
>
> This should possibly be an UncheckedIOException (since 1.8) which
> definitely covers the underlying FileNotFound Exception.
>
> Don’t see if this concerns any error handling.
>
>
>
> And then the idea of using Optional or Consumer to hide the
> sensitive parts of dealing with the Inputstream.
>
> This may also improve many of the deeply nested error handlers.
>
>
>
> Regards, Dieter.
>
>
>
> *Von:* Jody Garnett
> *Gesendet:* Freitag, 21. Oktober 2022 21:58
> *An:* Dieter Stüken - con terra GmbH
> *Cc:* GeoServer
> *Betreff:* Re: [Geoserver-devel] (GEOS-10705) Loading missing resources
> creates unsolicited empty files
>
>
>
> It is worth proposing a refactoring here.
>
>
>
> The guideline during the api developement was to optimize for the most
> common patterns of File usage we found in the codebase; and utillity
> methods such as in() for common usage patterns. Where possible we provided
> method name compatibility so it would be easier to migrate code from File
> to Resource.
>
>
>
> I was expecting far more input on this API when it was first introduced;
> your input is welcome now.
>
>
>
> For the specific example you show:
>
> - in() should not accidentally create a file for UNDEFINED
>
> - returning an empty input stream would be okay - less for client code to
> handle. I understand that failed parsing expression is not so fun
>
> - throwing UncheckedIOException is okay - concerned it would lead to a
> bunch of boiler plate code try / catch being introduced
>
>
>
> Since we have the whole codebase available it should be easy to access
> what this change would require and answer the concerns above.
>
>
>
> Whatever change is made I ask that the javadocs be clearly updated.
>
> --
>
> Jody
>
>
>
> On Fri, Oct 21, 2022 at 12:03 PM Dieter Stüken - con terra GmbH via
> Geoserver-devel wrote:
>
> Hi dev list,
>
> I frequently noticed, that Resource.in() just creates non existing files
> and then returns an empty input stream. This almost ever causes further
> problems like https://github.com/geoserver/geoserver/pull/6216
> <https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgeoserver%2Fgeoserver%2Fpull%2F6216&data=05%7C01%7C%7C2e008cb088634d28236808dab39e8a6a%7C6e0bfede3fcb4518a16565dc14fe5620%7C0%7C0%7C638019790762577204%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000%7C%7C%7C&sdata=WS6HiPOGG7gg6E4SsnCg07apkqnWcU%2Bs04%2BSpwky9qQ%3D&reserved=0>
> .
>
> I think the root cause is the implementation of Resource.in() for
> UNDEFINED resources.
> Looking at Files.ResourceAdaptor.in
> <https://eur04.safelinks.protection.outlook.com/?url=http%3A%2F%2Ffiles.resourceadaptor.in%2F&data=05%7C01%7C%7C2e008cb088634d28236808dab39e8a6a%7C6e0bfede3fcb4518a16565dc14fe5620%7C0%7C0%7C638019790762577204%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000%7C%7C%7C&sdata=dIAvutYZgvYtC9nsJSkaEHLDqIJb2sVEOO8aj1Tl4wg%3D&reserved=0>()
> I find:
>
> final File actualFile = file();
> if (!actualFile.exists()) {
> throw new IllegalStateException("Cannot access " + actualFile);
> }
>
> Seems, the initial intention was to throw an exception, but since file()
> creates the missing file, it does not work as intended. I analyzed the
> former GSIP 106, but I did not find any hints about the expected behavior
> here.
>
>
Re: [Geoserver-devel] (GEOS-10705) Loading missing resources creates unsolicited empty files
Thanks!
Dieter you have prepared a number of fixes now; may I add you to the
correct jira group so I can credit you as the person doing the fix?
This also let's you indicate when you are working on an issue (ie in
progress).
--
Jody Garnett
On Fri, Feb 3, 2023 at 6:24 PM Dieter Stüken - con terra GmbH <
d.stue...@conterra.de> wrote:
> Hi Jody,
>
>
>
> after the pull requests for [GEOS-10723] [GEOS-10724] and [GEOS-10743]
> accepted, we may also close the issues, doo.
>
> I went back to [10705] again and started another PR #6570
> <https://github.com/geoserver/geoserver/pull/6570>.
>
>
>
> The more I dive into the Resource API the more questions arise.
>
> After reading the GSIPs about it, I think I should probably have made a
> separate GSIP from it.
>
>
>
> Solving the Resource.in() problem, I noticed, that calling Resorce.file()
> raises similar problems.
>
> Probably we need a hint whether the intention is to read the file or to
> create the file.
>
> But this really breaks the current API.
>
>
>
> I also just detected the jdbcstore community module. I’m currently about
> to understand it….
>
>
>
> Then I think about the IllegalStateException thrown.
>
> This should possibly be an UncheckedIOException (since 1.8) which
> definitely covers the underlying FileNotFound Exception.
>
> Don’t see if this concerns any error handling.
>
>
>
> And then the idea of using Optional or Consumer to hide the
> sensitive parts of dealing with the Inputstream.
>
> This may also improve many of the deeply nested error handlers.
>
>
>
> Regards, Dieter.
>
>
>
> *Von:* Jody Garnett
> *Gesendet:* Freitag, 21. Oktober 2022 21:58
> *An:* Dieter Stüken - con terra GmbH
> *Cc:* GeoServer
> *Betreff:* Re: [Geoserver-devel] (GEOS-10705) Loading missing resources
> creates unsolicited empty files
>
>
>
> It is worth proposing a refactoring here.
>
>
>
> The guideline during the api developement was to optimize for the most
> common patterns of File usage we found in the codebase; and utillity
> methods such as in() for common usage patterns. Where possible we provided
> method name compatibility so it would be easier to migrate code from File
> to Resource.
>
>
>
> I was expecting far more input on this API when it was first introduced;
> your input is welcome now.
>
>
>
> For the specific example you show:
>
> - in() should not accidentally create a file for UNDEFINED
>
> - returning an empty input stream would be okay - less for client code to
> handle. I understand that failed parsing expression is not so fun
>
> - throwing UncheckedIOException is okay - concerned it would lead to a
> bunch of boiler plate code try / catch being introduced
>
>
>
> Since we have the whole codebase available it should be easy to access
> what this change would require and answer the concerns above.
>
>
>
> Whatever change is made I ask that the javadocs be clearly updated.
>
> --
>
> Jody
>
>
>
> On Fri, Oct 21, 2022 at 12:03 PM Dieter Stüken - con terra GmbH via
> Geoserver-devel wrote:
>
> Hi dev list,
>
> I frequently noticed, that Resource.in() just creates non existing files
> and then returns an empty input stream. This almost ever causes further
> problems like https://github.com/geoserver/geoserver/pull/6216
> <https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgeoserver%2Fgeoserver%2Fpull%2F6216&data=05%7C01%7C%7C2e008cb088634d28236808dab39e8a6a%7C6e0bfede3fcb4518a16565dc14fe5620%7C0%7C0%7C638019790762577204%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000%7C%7C%7C&sdata=WS6HiPOGG7gg6E4SsnCg07apkqnWcU%2Bs04%2BSpwky9qQ%3D&reserved=0>
> .
>
> I think the root cause is the implementation of Resource.in() for
> UNDEFINED resources.
> Looking at Files.ResourceAdaptor.in
> <https://eur04.safelinks.protection.outlook.com/?url=http%3A%2F%2Ffiles.resourceadaptor.in%2F&data=05%7C01%7C%7C2e008cb088634d28236808dab39e8a6a%7C6e0bfede3fcb4518a16565dc14fe5620%7C0%7C0%7C638019790762577204%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000%7C%7C%7C&sdata=dIAvutYZgvYtC9nsJSkaEHLDqIJb2sVEOO8aj1Tl4wg%3D&reserved=0>()
> I find:
>
> final File actualFile = file();
> if (!actualFile.exists()) {
> throw new IllegalStateException("Cannot access " + actualFile);
> }
>
> Seems, the initial intention was to throw an exception, but since file()
> creates the missing file, it does not work as intended. I analyzed the
> former GSIP 106, but I did not find any hints about t
Re: [Geoserver-devel] Docker image publishing
I think the shell script could be in the https://github.com/geoserver/docker repository. perhaps build/release.sh if we wish to be consistent. Then I would configure build.geoserver.org to checkout the docker file and run the script with the version being published (example 2.22.1). I could set up the job but would like to make sure you have permissions to run it for troubleshooting. Jody -- Jody Garnett On Tue, Jan 31, 2023 at 10:11 AM Johannes Weskamm wrote: > Ok, then i need hints what to do. Do you need a shell script which sets up > the image? Anything else? > > PR against https://github.com/geoserver/geoserver/tree/main/build ? > > > Greetings, > > Johannes > > > Am 28.01.23 um 08:46 schrieb Jody Garnett: > > I would prefer to manage the secrets in one location (build.geoserver.org) > rather than spread across services. > > In the last year I had to check our history as travis had been compromised > (which we had not used for a long time, and never for deploy). > -- > Jody Garnett > > > On Fri, Jan 27, 2023 at 1:28 PM Johannes Weskamm > wrote: > >> Personally i dont really care if a github action or a shell script is >> used to get the image build and published. >> >> But i like the idea to have the docker things all in one place / repo >> instead of spreading it over several repos. >> >> One could also use a trigger / notify in the mentioned scripts to start >> the build in github actions so that the timing should be no issue then. >> >> Are there other opinions ? >> >> >> Greetings, >> >> Johannes >> >> >> Am 26.01.23 um 14:12 schrieb Andrea Aime: >> >> Why not have it as part of the release scripts instead... a periodic >> check could have the docker >> be available either before announcement (sometimes we have a few days in >> between artifacts and announcement) >> or after the release is available to the general public. >> >> Scripts are here (*_release.sh): >> https://github.com/geoserver/geoserver/tree/main/build >> >> Cheers >> Andrea >> >> On Thu, Jan 26, 2023 at 10:24 AM Johannes Weskamm >> wrote: >> >>> Hi again, >>> I intend to setup an github action, which periodically checks for new >>> geoserver releases. >>> If a new one is available, the action should build, test and finally >>> push the image to the osgeo repo. >>> >>> Therefore i need to configure my credentials in the settings of the >>> github repo, but i am missing permissions for that. >>> >>> Not sure if Jody can help here? >>> >>> This is what has to be done: >>> >>> >>> https://docs.github.com/en/actions/security-guides/encrypted-secrets#creating-encrypted-secrets-for-a-repository >>> >>> >>> Greetings, >>> >>> Johannes >>> >>> >>> Am 26.01.23 um 09:59 schrieb Jakob Miksch: >>> >>> Alright, thanks for the quick response. An automatic publication of the >>> images would indeed be very useful. >>> >>> Am 26.01.23 um 09:53 schrieb Jody Garnett: >>> >>> Indeed we need a volunteer to do the publish; or indeed to add a job to >>> our build server. >>> -- >>> Jody Garnett >>> >>> >>> On Thu, Jan 26, 2023 at 9:33 AM Jakob Miksch wrote: >>> >>>> Hi everybody, >>>> >>>> in the repo for the GeoServer Docker image the version is already set >>>> to >>>> '2.22.0' (https://github.com/geoserver/docker), but the image is not >>>> published to the registry yet >>>> ( >>>> https://docker.osgeo.org/#browse/browse:geoserver-docker:v2%2Fgeoserver%2Ftags >>>> ). >>>> >>>> Who is typically doing the publishing? >>>> >>>> Best regards, >>>> Jakob >>> >>> >>> ___ >>> Geoserver-devel mailing list >>> Geoserver-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >>> >> >> >> -- >> >> Regards, >> >> Andrea Aime >> >> == GeoServer Professional Services from the experts! >> >> Visit http://bit.ly/gs-services-us for more information. == Ing. Andrea >> Aime @geowolf Technical Lead >> >> GeoSolutions Group phone: +39 0584 962313 >> >> fax: +39 0584 1660272 >> >> mob: +39 339 8844549 >> >> https
Re: [Geoserver-devel] [JIRA] (GEOS-10840) 2.22.1 Maven and release artifacts pushed with SNAPSHOT dependencies
Checking https://github.com/geoserver/geoserver/blob/2.22.1/src/pom.xml It has 1.21.3 Should this be 1.22.0 <https://github.com/GeoWebCache/geowebcache/blob/1.22.0/geowebcache/pom.xml> ? -- Jody Garnett On Fri, Jan 27, 2023 at 1:14 PM Ian Turton wrote: > My fault, I knew I shouldn't mess with the settings with out reading the > source code :-( > > I'll run it again. > > Ian > > On Fri, 27 Jan 2023 at 12:11, Jody Garnett wrote: > >> I am glad we have an answer. >> Personally I understood those parameters only did a build when a revision >> was supplied; if an actual release tag is used no building is required? >> >> I understand that these were used to issue an emergency hotfix in the >> past. Now we tend to just make another geotools release if a critical fix >> is required. >> >> Perhaps these options could be removed? >> -- >> Jody Garnett >> >> >> On Fri, Jan 27, 2023 at 12:32 PM Andrea Aime < >> andrea.a...@geosolutionsgroup.com> wrote: >> >>> Hi, I've spent some time investigating what happened, I believe it's >>> user error caused by confusing parameters and a bug in the release script... >>> The build has these two parameters, that I normally don't touch, set to >>> "skip": >>> >>> [image: image.png] >>> I normally don't touch them due to lack of understanding, but the >>> description seems to suggest "skip GT build", which is indeed >>> something we don't need during a release, the upstream builds are done >>> already. >>> But looking at how they work in build_release.sh >>> <https://github.com/geoserver/geoserver/blob/main/build/build_release.sh#L156>, >>> they skip the build but also skip setting gt_tag and gwc_tag, >>> which then are used to update the version numbers in the pom files >>> <https://github.com/geoserver/geoserver/blob/main/build/build_release.sh#L199> >>> . >>> >>> Seems like a bug in the logic of the release script IMHO, but for now, >>> better not set those to "skip" and let them do the extra, >>> unnecessary builds. >>> >>> Cheers >>> Andrea >>> >>> ___ >>> Geoserver-devel mailing list >>> Geoserver-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >>> >> ___ >> Geoserver-devel mailing list >> Geoserver-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >> > > > -- > Ian Turton > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] Docker image publishing
I would prefer to manage the secrets in one location (build.geoserver.org) rather than spread across services. In the last year I had to check our history as travis had been compromised (which we had not used for a long time, and never for deploy). -- Jody Garnett On Fri, Jan 27, 2023 at 1:28 PM Johannes Weskamm wrote: > Personally i dont really care if a github action or a shell script is used > to get the image build and published. > > But i like the idea to have the docker things all in one place / repo > instead of spreading it over several repos. > > One could also use a trigger / notify in the mentioned scripts to start > the build in github actions so that the timing should be no issue then. > > Are there other opinions ? > > > Greetings, > > Johannes > > > Am 26.01.23 um 14:12 schrieb Andrea Aime: > > Why not have it as part of the release scripts instead... a periodic check > could have the docker > be available either before announcement (sometimes we have a few days in > between artifacts and announcement) > or after the release is available to the general public. > > Scripts are here (*_release.sh): > https://github.com/geoserver/geoserver/tree/main/build > > Cheers > Andrea > > On Thu, Jan 26, 2023 at 10:24 AM Johannes Weskamm > wrote: > >> Hi again, >> I intend to setup an github action, which periodically checks for new >> geoserver releases. >> If a new one is available, the action should build, test and finally push >> the image to the osgeo repo. >> >> Therefore i need to configure my credentials in the settings of the >> github repo, but i am missing permissions for that. >> >> Not sure if Jody can help here? >> >> This is what has to be done: >> >> >> https://docs.github.com/en/actions/security-guides/encrypted-secrets#creating-encrypted-secrets-for-a-repository >> >> >> Greetings, >> >> Johannes >> >> >> Am 26.01.23 um 09:59 schrieb Jakob Miksch: >> >> Alright, thanks for the quick response. An automatic publication of the >> images would indeed be very useful. >> >> Am 26.01.23 um 09:53 schrieb Jody Garnett: >> >> Indeed we need a volunteer to do the publish; or indeed to add a job to >> our build server. >> -- >> Jody Garnett >> >> >> On Thu, Jan 26, 2023 at 9:33 AM Jakob Miksch wrote: >> >>> Hi everybody, >>> >>> in the repo for the GeoServer Docker image the version is already set to >>> '2.22.0' (https://github.com/geoserver/docker), but the image is not >>> published to the registry yet >>> ( >>> https://docker.osgeo.org/#browse/browse:geoserver-docker:v2%2Fgeoserver%2Ftags >>> ). >>> >>> Who is typically doing the publishing? >>> >>> Best regards, >>> Jakob >> >> >> ___ >> Geoserver-devel mailing list >> Geoserver-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >> > > > -- > > Regards, > > Andrea Aime > > == GeoServer Professional Services from the experts! > > Visit http://bit.ly/gs-services-us for more information. == Ing. Andrea > Aime @geowolf Technical Lead > > GeoSolutions Group phone: +39 0584 962313 > > fax: +39 0584 1660272 > > mob: +39 339 8844549 > > https://www.geosolutionsgroup.com/ > > http://twitter.com/geosolutions_it > > --- > > Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE > 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si > precisa che ogni circostanza inerente alla presente email (il suo > contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è > riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il > messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra > operazione è illecita. Le sarei comunque grato se potesse darmene notizia. > This > email is intended only for the person or entity to which it is addressed > and may contain information that is privileged, confidential or otherwise > protected from disclosure. We remind that - as provided by European > Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail > or the information herein by anyone other than the intended recipient is > prohibited. If you have received this email by mistake, please notify us > immediately by telephone or e-mail > > -- > Dipl.-Geogr. Johannes Weskamm > — Anwendungsentwickler — > > te
Re: [Geoserver-devel] [JIRA] (GEOS-10840) 2.22.1 Maven and release artifacts pushed with SNAPSHOT dependencies
I am glad we have an answer. Personally I understood those parameters only did a build when a revision was supplied; if an actual release tag is used no building is required? I understand that these were used to issue an emergency hotfix in the past. Now we tend to just make another geotools release if a critical fix is required. Perhaps these options could be removed? -- Jody Garnett On Fri, Jan 27, 2023 at 12:32 PM Andrea Aime < andrea.a...@geosolutionsgroup.com> wrote: > Hi, I've spent some time investigating what happened, I believe it's user > error caused by confusing parameters and a bug in the release script... > The build has these two parameters, that I normally don't touch, set to > "skip": > > [image: image.png] > I normally don't touch them due to lack of understanding, but the > description seems to suggest "skip GT build", which is indeed > something we don't need during a release, the upstream builds are done > already. > But looking at how they work in build_release.sh > <https://github.com/geoserver/geoserver/blob/main/build/build_release.sh#L156>, > they skip the build but also skip setting gt_tag and gwc_tag, > which then are used to update the version numbers in the pom files > <https://github.com/geoserver/geoserver/blob/main/build/build_release.sh#L199> > . > > Seems like a bug in the logic of the release script IMHO, but for now, > better not set those to "skip" and let them do the extra, > unnecessary builds. > > Cheers > Andrea > > ___ > Geoserver-devel mailing list > Geoserver-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geoserver-devel > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] Docker image publishing
Indeed we need a volunteer to do the publish; or indeed to add a job to our build server. -- Jody Garnett On Thu, Jan 26, 2023 at 9:33 AM Jakob Miksch wrote: > Hi everybody, > > in the repo for the GeoServer Docker image the version is already set to > '2.22.0' (https://github.com/geoserver/docker), but the image is not > published to the registry yet > ( > https://docker.osgeo.org/#browse/browse:geoserver-docker:v2%2Fgeoserver%2Ftags > ). > > Who is typically doing the publishing? > > Best regards, > Jakob > > -- > Jakob Miksch > Geoinformatiker > > meggsimum - Büro für Geoinformatik > Christian Mayer > Schillerstr. 2a| 67112 Mutterstadt > i...@meggsimum.de | www.meggsimum.de > T 06231 - 6298988 | > > > > ___ > Geoserver-devel mailing list > Geoserver-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geoserver-devel > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] seeking permission to increase release data directory size
This is indeed a fair point - however I believe the situation is the other way around, I hope this alleviates criticism we already receive. On Tue, Jan 24, 2023 at 3:57 PM Simone Giannecchini < simone.giannecch...@geosolutionsgroup.com> wrote: > Hi Jody, > on the technical side I am neutral but on the more "marketing" side do we > really want to ship disputed areas? > I am concerned that we expose ourselves to criticism, unnecessarily. > > Regards, > Simone Giannecchini > == > Online training classes for GeoNode, GeoServer and MapStore from the > experts! > Visit https://bookwhen.com/geosolutions-professional-training for more > information. > == > Ing. Simone Giannecchini > @simogeo > Founder/Director GeoSolutions Italy > President GeoSolutions USA > > phone: +39 0584 962313 > fax: +39 0584 1660272 > mob: +39 333 8128928 > US: +1 (845) 547-7905 > > http://www.geosolutionsgroup.com > http://twitter.com/geosolutions_it > > --- > This email is intended only for the person or entity to which it is > addressed and may contain information that is privileged, confidential or > otherwise protected from disclosure. We remind that - as provided by > European Regulation 2016/679 “GDPR” - copying, dissemination or use of this > e-mail or the information herein by anyone other than the intended > recipient is prohibited. If you have received this email by mistake, please > notify us immediately by telephone or e-mail. > > > On Tue, Jan 24, 2023 at 7:54 AM Jody Garnett > wrote: > >> While twitter was still a thing I received some feedback online with >> respect to data directory for GeoServer 2.22.x series. >> >> I have a PR here https://github.com/geoserver/geoserver/pull/6527 adding >> disputed regions to our map, and having some ability to demo LANGAGUE= >> parameter for GetMap. >> >> While I would like to continue, and set up a few alternative styles for >> ne:world layergroup - I do not wish to put in any more effort unless we are >> comfortable growing the data directory by 3.5 MB in order to jump to 1:50m >> scale where disputed regions is available. >> >> So what do you think? Checkout >> https://github.com/geoserver/geoserver/pull/6527 which has some screen >> shots. >> -- >> Jody Garnett >> ___ >> Geoserver-devel mailing list >> Geoserver-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >> > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
[Geoserver-devel] [JIRA] (GEOS-10837) Relax geopackage export file locking
Jody Garnett ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae422bb7f-4808-47e3-837f-13db0e6681e3 ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiYjQxNjdkNmUxMDY2NDkzNjg0NzBlMDk2NGU5Y2IxOTIiLCJwIjoiaiJ9 ) / Bug ( https://osgeo-org.atlassian.net/browse/GEOS-10837?atlOrigin=eyJpIjoiYjQxNjdkNmUxMDY2NDkzNjg0NzBlMDk2NGU5Y2IxOTIiLCJwIjoiaiJ9 ) GEOS-10837 ( https://osgeo-org.atlassian.net/browse/GEOS-10837?atlOrigin=eyJpIjoiYjQxNjdkNmUxMDY2NDkzNjg0NzBlMDk2NGU5Y2IxOTIiLCJwIjoiaiJ9 ) Relax geopackage export file locking ( https://osgeo-org.atlassian.net/browse/GEOS-10837?atlOrigin=eyJpIjoiYjQxNjdkNmUxMDY2NDkzNjg0NzBlMDk2NGU5Y2IxOTIiLCJwIjoiaiJ9 ) Issue Type: Bug Affects Versions: 2.21.2 Assignee: Jody Garnett ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae422bb7f-4808-47e3-837f-13db0e6681e3 ) Components: geopackage Created: 24/Jan/23 1:38 PM Priority: Medium Reporter: Jody Garnett ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae422bb7f-4808-47e3-837f-13db0e6681e3 ) The geopackage output formats presently open in exclusive mode (and thus never give up file lock - causing some issue for java temp directory). We should experiment with normal mode, and perhaps some of the other options since we know we are only writing a temporary file. ( https://osgeo-org.atlassian.net/browse/GEOS-10837#add-comment?atlOrigin=eyJpIjoiYjQxNjdkNmUxMDY2NDkzNjg0NzBlMDk2NGU5Y2IxOTIiLCJwIjoiaiJ9 ) Add Comment ( https://osgeo-org.atlassian.net/browse/GEOS-10837#add-comment?atlOrigin=eyJpIjoiYjQxNjdkNmUxMDY2NDkzNjg0NzBlMDk2NGU5Y2IxOTIiLCJwIjoiaiJ9 ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100214- sha1:01e0849 )___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
[Geoserver-devel] seeking permission to increase release data directory size
While twitter was still a thing I received some feedback online with respect to data directory for GeoServer 2.22.x series. I have a PR here https://github.com/geoserver/geoserver/pull/6527 adding disputed regions to our map, and having some ability to demo LANGAGUE= parameter for GetMap. While I would like to continue, and set up a few alternative styles for ne:world layergroup - I do not wish to put in any more effort unless we are comfortable growing the data directory by 3.5 MB in order to jump to 1:50m scale where disputed regions is available. So what do you think? Checkout https://github.com/geoserver/geoserver/pull/6527 which has some screen shots. -- Jody Garnett ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
[Geoserver-devel] [JIRA] (GEOS-10835) printing extension missing commons httpclient
Jody Garnett ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae422bb7f-4808-47e3-837f-13db0e6681e3 ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiYTNhOTE3NWU1YWRiNGMwYTg4NThiMzI3YThlMDk3NzgiLCJwIjoiaiJ9 ) / Bug ( https://osgeo-org.atlassian.net/browse/GEOS-10835?atlOrigin=eyJpIjoiYTNhOTE3NWU1YWRiNGMwYTg4NThiMzI3YThlMDk3NzgiLCJwIjoiaiJ9 ) GEOS-10835 ( https://osgeo-org.atlassian.net/browse/GEOS-10835?atlOrigin=eyJpIjoiYTNhOTE3NWU1YWRiNGMwYTg4NThiMzI3YThlMDk3NzgiLCJwIjoiaiJ9 ) printing extension missing commons httpclient ( https://osgeo-org.atlassian.net/browse/GEOS-10835?atlOrigin=eyJpIjoiYTNhOTE3NWU1YWRiNGMwYTg4NThiMzI3YThlMDk3NzgiLCJwIjoiaiJ9 ) Issue Type: Bug Assignee: Unassigned Components: Mapfish print Created: 24/Jan/23 7:43 AM Priority: Medium Reporter: Jody Garnett ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae422bb7f-4808-47e3-837f-13db0e6681e3 ) As Tiago Vieira reported via email: > > > > The fork was required as mapfish version 2.x made use of a library that > was no longer open source. My expectation is that the jar required by > mapfish print 2.22.0 is not included in GeoServer and it is unable to > work. > > > > > > That library could be "commons-httpclient-3.1.jar" from below dependency? > If not, it may be added to the zip printing libs on geoserver extensions > downloads section, and update the pom file to bring that dependency also. > > > > commons-httpclient > commons-httpclient > > > > I just added that Jar to geoserver lib and everything seems to work. I'll > run more tests. > > ( https://osgeo-org.atlassian.net/browse/GEOS-10835#add-comment?atlOrigin=eyJpIjoiYTNhOTE3NWU1YWRiNGMwYTg4NThiMzI3YThlMDk3NzgiLCJwIjoiaiJ9 ) Add Comment ( https://osgeo-org.atlassian.net/browse/GEOS-10835#add-comment?atlOrigin=eyJpIjoiYTNhOTE3NWU1YWRiNGMwYTg4NThiMzI3YThlMDk3NzgiLCJwIjoiaiJ9 ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100214- sha1:01e0849 )___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] [Geotools-devel] Release artefacts available for testing
Thanks, we can update the readme instructions. -- Jody Garnett On Mon, Jan 23, 2023 at 7:39 PM Mark Prins wrote: > Working fine for me > > Op do 19 jan. 2023 11:15 schreef Ian Turton : > >> Please try out the new 28.1 release - >> https://build.geoserver.org/view/release/job/geotools-release/73/artifact/build/release/distribution/28.1/geotools-28.1-bin.zip >> >> Ian >> >> -- >> Ian Turton >> ___ >> GeoTools-Devel mailing list >> geotools-de...@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/geotools-devel >> > ___ > Geoserver-devel mailing list > Geoserver-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geoserver-devel > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] [Geowebcache-devel] osgeo budget request
Here is the GeoServer budget request: - https://wiki.osgeo.org/wiki/GeoServer_Budget_2023 I made up some assorted sponsorship opportunities (as I am trying to encourage the board to be clear with sponsorship opportunities during Q1 while annual budgets are established). -- Jody Garnett On Sat, Jan 7, 2023 at 10:34 AM Andrea Aime wrote: > On Wed, Jan 4, 2023 at 9:06 PM Jody Garnett > wrote: > >> I have provided a technical debt wiki page on refactoring org.opengis >> packages (reversing the work we did to provide the interfaces to start the >> project) in order to get an idea on the work required and costs involved: >> https://github.com/geotools/geotools/wiki/Remove-OpenGIS >> > > +1, the current situation is causing problems already in downstream > projects and Java 11 modules are just going > to make things worse. Let's get rid of the org.opengis packages > altogether (also supporting the merge of the API rather than > the simple package rename, the split between the two packages would look > artificial once done). > > >> Also after last year I am going to separately suggest an OSGeo budget for >> "security issues" (as a cross project initiative similar to code sprints). >> Because 2022 sucked. >> > > Yes please, +1 > > Cheers > Andrea > > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
[Geoserver-devel] PSC Meeting - 2031-01-17
GeoTools / GeoServer PMC meeting - 2023-01-17Attending - Torben Barsballe - Andrea Aime - Kevin Smith - Jody Garnett Actions from prior meetings: - N/A Agenda 1. GeoServer release schedule 2. Spring upgrade 3. OSGeo Budget request 4. Java 11 deployments 5. WCS version negotiation 6. OGC API Features updates 7. Large catalogs and home page selectors Actions - Ask for release volunteers on email list, as applicable (may be worthwhile asking for RC volunteers early) - jody: osgeo budget request GeoServer release schedule - Jody and Andrea got the last one out (thanks) - Ian and Andrea will do the January release 2.22.1 - https://github.com/geoserver/geoserver/wiki/Release-Schedule - Feb 18 maintenance release needs volunteer - March 3rd release candidate should have several volunteers due to build server and blog post of new features - March 18th release is Java 11 (Java 17 not confirmed without QA commitment) Send to email list for discussion, jody volunteers to do Feb release or March RC as needed Spring upgrade Joseph miller been working on this: - https://github.com/GeoWebCache/geowebcache/pull/ - https://github.com/geoserver/geoserver/pull/6515 ContentNegotiationConfigurer.favorPathExtension is deprecated (and no longer the default configuration) because Spring wants to discourage extensions in paths. 1. Rest API dispatch depends on this - how to preserve for roadmap? - Discussion recommends we make our own resolver. - There’s an (old and primitive) implementation of something like this here, that may provide a starting point: https://github.com/planetlabs/stratus/blob/master/src/stratus-application/src/main/java/stratus/config/CommunityRestMvcConfigurer.java#L107-L140 - OGCAPI does not use extensions (yet …) 1. Servlet inputstream / outputstream have new methods, so work to update mocks etc.. 2. Spring started added charset to mime types text/html;charset=utf8 (correct but annoying). Tests updated to only check first part 3. Spring deprecating spring-remoting (spring 5 deprecated, spring 6 removed). This is a challenge for geofence. 4. ogcapi modules updated fine (that was unexpected) 5. Spring Security OAuth modules (cleaned up, but makes use of deprecated api) 1. manual testing is going ahead to confirm this still works 2. at somepoint (when these go supported) migration to spring-security ouath (which will be hard due to final classes) as the spring oauth extension is end of life and deprecated We want to merge as soon as possible; so that this is inplace for March RC. Soft goal will be to test the community modules mentioned above before March release (not a requirement). This PR is Spring 5.2 -> 5.3.23, the latest is 5.3.25 (which was released during this activity) Spring 6 will be more extensive update (Spring 5 EOL is end of 2024) OSGeo Budget request Deadline is Jan 20th for funding requests, see technical debt page for funding request across projects. Jan 30th board meeting <https://wiki.osgeo.org/wiki/Board_Meeting_2023-01-30> - need a volunteer to attend, discuss org.opengis topic - removing the org.opengis <https://git.osgeo.org/gitea/osgeo/todo/issues/142> (see here for budget estimate) Jan 20th Board Funding deadline (this friday) - We need to write a wiki page, and email osgeo board - We did benefit from OSGeo funding last year; would be good to apply again - Jody volunteered, need a review (multiply numbers by 2) - Example: https://github.com/geotools/geotools/wiki/GeoTools-Budget-Request-2022 Some email discussion: 1. replace org.opengis packages (if OSGeo / Apache provides funding to so) 1. mixed response from email list 2. https://github.com/geotools/geotools/wiki/Remove-OpenGIS 1. We can discuss another time, there is an interesting trade off if you read the API Change (with two ideas) 1. Idea: Ask OSGeo to set up a security emergency funding that projects could apply for similar to code-sprint Need a volunteer to attend OSGeo Meeting. Java 11 deployments to OSGeo repo Jenkins 11 builds were isolated, and do not deploy to osgeo nexus (may wish to keep for Java 17 isolated testing) For main we may wish to copy the old builds, and change the JDK for 11? Or just copy the deploy step … 1. Copy Java11 main builds to Java 17 main builds (and disable) 2. Edit Java 11 builds to remove local workspace m2 repo (remove -Dmaven.repo.local flag) 1. Also remove the actual workspace folder in General Settings (need to click “Advanced”): 2. This may also re
Re: [Geoserver-devel] GeoServer 2.22.1 release volunteer needed
Andrea: I do not have any availability this month, if I did it would go towards resolving "[GEOS-10759] Welcome page autocomplete mode". -- Jody Garnett On Mon, Jan 16, 2023 at 8:04 AM Andrea Aime < andrea.a...@geosolutionsgroup.com> wrote: > Hi all, > in theory we should be releasing 2.22.1 the 18th (in two days). But > looking at the release page > <https://github.com/geoserver/geoserver/wiki/Release-Schedule#volunteer-coordination>, > we don't have a volunteer. Any takers? > > Cheers > Andrea > > == > GeoServer Professional Services from the experts! > > Visit http://bit.ly/gs-services-us for more information. > == > > Ing. Andrea Aime > @geowolf > Technical Lead > > GeoSolutions Group > phone: +39 0584 962313 > > fax: +39 0584 1660272 > > mob: +39 339 8844549 > > https://www.geosolutionsgroup.com/ > > http://twitter.com/geosolutions_it > > --- > > Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE > 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si > precisa che ogni circostanza inerente alla presente email (il suo > contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è > riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il > messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra > operazione è illecita. Le sarei comunque grato se potesse darmene notizia. > > This email is intended only for the person or entity to which it is > addressed and may contain information that is privileged, confidential or > otherwise protected from disclosure. We remind that - as provided by > European Regulation 2016/679 “GDPR” - copying, dissemination or use of this > e-mail or the information herein by anyone other than the intended > recipient is prohibited. If you have received this email by mistake, please > notify us immediately by telephone or e-mail > ___ > Geoserver-devel mailing list > Geoserver-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geoserver-devel > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] Dropping Java 8 from main branch
Congrats Andrea and thanks for dedication on this one. -- Jody Garnett On Thu, Jan 5, 2023 at 10:56 AM Andrea Aime < andrea.a...@geosolutionsgroup.com> wrote: > Aaand... all merged! > We are now running on Java 11 as the minimum. Sending separate mail as a > reminder. > > Cheers > Andrea > > On Thu, Jan 5, 2023 at 7:54 PM Andrea Aime < > andrea.a...@geosolutionsgroup.com> wrote: > >> Too late, wiped them out. Java 17 builds can be created by copying over >> the Java 11 ones though. >> Not sure we need them until Java 17 is officially supported though (right >> now it's experimental with a large bunch >> of "add-opens" to have tests run). >> >> Cheers >> Andrea >> >> On Thu, Jan 5, 2023 at 5:32 PM Jody Garnett >> wrote: >> >>> Disable java 8 builds, we should be able to repurpose as java 17 builds? >>> >>> On Thu, Jan 5, 2023 at 8:18 AM Andrea Aime < >>> andrea.a...@geosolutionsgroup.com> wrote: >>> >>>> No complaint, starting to merge, from GeoServer and then backwards. >>>> We'll also have to remove the Java 8 builds from the build server (not sure >>>> if I'll manage today). >>>> >>>> Cheers >>>> Andrea >>>> >>>> On Wed, Jan 4, 2023 at 5:40 PM Andrea Aime < >>>> andrea.a...@geosolutionsgroup.com> wrote: >>>> >>>>> All green now. Shall we? >>>>> >>>>> Cheers >>>>> Andrea >>>>> >>>>> On Tue, Jan 3, 2023 at 7:21 PM Andrea Aime < >>>>> andrea.a...@geosolutionsgroup.com> wrote: >>>>> >>>>>> A status update: >>>>>> >>>>>>- GeoServer PR green: https://github.com/geoserver/geoserver/pulls >>>>>>- GeoWebCache PR green: >>>>>>https://github.com/GeoWebCache/geowebcache/pull/1109 >>>>>>- GeoTools PR is stuck on some ES online test issue I haven't >>>>>>figured out: https://github.com/geotools/geotools/pull/4097 >>>>>> >>>>>> About the GT bit... If I run the online tests from IntelliJ, I see no >>>>>> problem. So I'm guessing the issue might be in the Github action >>>>>> script >>>>>> <https://github.com/geotools/geotools/blob/50047e9843330dc270404d3b333cec2f0d8cc453/.github/workflows/elasticsearch_online.yml>, >>>>>> but I don't see anything strange there either. >>>>>> >>>>>> Cheers >>>>>> Andrea >>>>>> >>>>>> >>>>>> On Tue, Dec 27, 2022 at 9:58 PM Jody Garnett >>>>>> wrote: >>>>>> >>>>>>> My understanding is we are waiting for the new year before merging >>>>>>> this PR (want to be on hand for those upgrading their dev env to java >>>>>>> 11). >>>>>>> -- >>>>>>> Jody Garnett >>>>>>> >>>>>>> >>>>>>> On Mon, Dec 19, 2022 at 8:26 AM Jody Garnett >>>>>>> wrote: >>>>>>> >>>>>>>> After a bit of guesswork and troubleshooting on windows / Java 11 >>>>>>>> combo the PR is ready: >>>>>>>> https://github.com/geoserver/geoserver/pull/6370 >>>>>>>> >>>>>>>> Thanks Andrea for doing the heavy lifting on this one; the >>>>>>>> documentation is already updated to be Java 11 minimum. >>>>>>>> >>>>>>>> Please be advised that when this PR is merged you will *require* a >>>>>>>> Java 11 environment for working on the main branch. >>>>>>>> -- >>>>>>>> Jody Garnett >>>>>>>> >>>>>>> ___ >>>>>>> Geoserver-devel mailing list >>>>>>> Geoserver-devel@lists.sourceforge.net >>>>>>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> >>>>>> Regards, >>>>>> >>>>>> Andrea Aime >>>>>> >>>>>> == >>>>>>
Re: [Geoserver-devel] Dropping Java 8 from main branch
Disable java 8 builds, we should be able to repurpose as java 17 builds? On Thu, Jan 5, 2023 at 8:18 AM Andrea Aime < andrea.a...@geosolutionsgroup.com> wrote: > No complaint, starting to merge, from GeoServer and then backwards. We'll > also have to remove the Java 8 builds from the build server (not sure if > I'll manage today). > > Cheers > Andrea > > On Wed, Jan 4, 2023 at 5:40 PM Andrea Aime < > andrea.a...@geosolutionsgroup.com> wrote: > >> All green now. Shall we? >> >> Cheers >> Andrea >> >> On Tue, Jan 3, 2023 at 7:21 PM Andrea Aime < >> andrea.a...@geosolutionsgroup.com> wrote: >> >>> A status update: >>> >>>- GeoServer PR green: https://github.com/geoserver/geoserver/pulls >>>- GeoWebCache PR green: >>>https://github.com/GeoWebCache/geowebcache/pull/1109 >>>- GeoTools PR is stuck on some ES online test issue I haven't >>>figured out: https://github.com/geotools/geotools/pull/4097 >>> >>> About the GT bit... If I run the online tests from IntelliJ, I see no >>> problem. So I'm guessing the issue might be in the Github action script >>> <https://github.com/geotools/geotools/blob/50047e9843330dc270404d3b333cec2f0d8cc453/.github/workflows/elasticsearch_online.yml>, >>> but I don't see anything strange there either. >>> >>> Cheers >>> Andrea >>> >>> >>> On Tue, Dec 27, 2022 at 9:58 PM Jody Garnett >>> wrote: >>> >>>> My understanding is we are waiting for the new year before merging this >>>> PR (want to be on hand for those upgrading their dev env to java 11). >>>> -- >>>> Jody Garnett >>>> >>>> >>>> On Mon, Dec 19, 2022 at 8:26 AM Jody Garnett >>>> wrote: >>>> >>>>> After a bit of guesswork and troubleshooting on windows / Java 11 >>>>> combo the PR is ready: >>>>> https://github.com/geoserver/geoserver/pull/6370 >>>>> >>>>> Thanks Andrea for doing the heavy lifting on this one; the >>>>> documentation is already updated to be Java 11 minimum. >>>>> >>>>> Please be advised that when this PR is merged you will *require* a >>>>> Java 11 environment for working on the main branch. >>>>> -- >>>>> Jody Garnett >>>>> >>>> ___ >>>> Geoserver-devel mailing list >>>> Geoserver-devel@lists.sourceforge.net >>>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >>>> >>> >>> >>> -- >>> >>> Regards, >>> >>> Andrea Aime >>> >>> == >>> GeoServer Professional Services from the experts! >>> >>> Visit http://bit.ly/gs-services-us for more information. >>> == >>> >>> Ing. Andrea Aime >>> @geowolf >>> Technical Lead >>> >>> GeoSolutions Group >>> phone: +39 0584 962313 >>> >>> fax: +39 0584 1660272 >>> >>> mob: +39 339 8844549 >>> >>> https://www.geosolutionsgroup.com/ >>> >>> http://twitter.com/geosolutions_it >>> >>> --- >>> >>> Con riferimento alla normativa sul trattamento dei dati personali (Reg. >>> UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si >>> precisa che ogni circostanza inerente alla presente email (il suo >>> contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è >>> riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il >>> messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra >>> operazione è illecita. Le sarei comunque grato se potesse darmene notizia. >>> >>> This email is intended only for the person or entity to which it is >>> addressed and may contain information that is privileged, confidential or >>> otherwise protected from disclosure. We remind that - as provided by >>> European Regulation 2016/679 “GDPR” - copying, dissemination or use of this >>> e-mail or the information herein by anyone other than the intended >>> recipient is prohibited. If you have received this email by mistake, please >>> notify us immediately by telephone or e-mail >>> >> >> >> -- >> >> Regards, >> >> Andr
[Geoserver-devel] osgeo budget request
Good morning folks, OSGeo board put out their call for budget request; separately they have "todo" ticket for removing the org.opengis <https://git.osgeo.org/gitea/osgeo/todo/issues/142> package from the GeoTools codebase. And it is on the agenda for the next board meeting <https://wiki.osgeo.org/wiki/Board_Meeting_2023-01-30>. I have provided a technical debt wiki page on refactoring org.opengis packages (reversing the work we did to provide the interfaces to start the project) in order to get an idea on the work required and costs involved: https://github.com/geotools/geotools/wiki/Remove-OpenGIS Since this change provides no value to the geotools codebase I have no real interest in fundraising for the activity. I would expect a similar effort to the Java 11 split-package refactoring where the work can be done, and a script created and tested against downstream GeoWebCache and GeoServer codebases. For that activity sponsorship raised around $5k for a cross-project sprint. The in-kind contributions were 10-25k (staff time / travel / venue / fundraising). I am going to recommend putting in a budget request of 10k for geotools, and 5k for geowebcache, and 5k for geoserver to cover a similar undertaking. If successful we will still need to ask for in-kind participation for individuals and organizations (even if just to cover their risk). I do not think we have a meeting before their budget deadline; so if I can get a few +1 replies to this email I will make the request on our behalf. Also after last year I am going to separately suggest an OSGeo budget for "security issues" (as a cross project initiative similar to code sprints). Because 2022 sucked. -- Jody Garnett ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] [Geowebcache-devel] Starting the GT 27.3, GWC 1.21.3, GS 2.21.3 release train
Backported, re-ran the release, and the download bundles are now correct :) In checking the commit history of 2.21.x I found a number of issues missing from our release notes; which have now been updated. I will update the release announcement and publish. -- Jody Garnett On Wed, Dec 28, 2022 at 9:02 AM Jody Garnett wrote: > Checking: > - The bin download looks good, and the html files (readme, running, > licenses) are accounted for. > - war download (did not run) the readme and running instructions are > missing, but licenses are included. > - javadoc > - html docs - license.md, readme.txt but at least there is something > - data - readme.txt only, should probably have a license > > Looking into it - seems https://github.com/geoserver/geoserver/pull/6367 > was not backported (too bad) > > -- > Jody Garnett > > > On Wed, Dec 28, 2022 at 2:49 AM Andrea Aime < > andrea.a...@geosolutionsgroup.com> wrote: > >> On Wed, Dec 28, 2022 at 8:09 AM Jody Garnett >> wrote: >> >>> Good news, >>> >>> The release is available for pre-flight testing: >>> https://build.geoserver.org/view/release/job/geoserver-release/lastSuccessfulBuild/artifact/distribution/2.21.3/ >>> >> >> Thank you! >> >> >> >>> And the windows installer built automatically and uploaded the above >>> folder without incident :) >>> >> >> Ooh... Santa came a little late but the gift is nice! >> >> Cheers >> Andrea >> >> == >> >> GeoServer Professional Services from the experts! >> >> Visit http://bit.ly/gs-services-us for more information. >> == >> >> Ing. Andrea Aime >> @geowolf >> Technical Lead >> >> GeoSolutions Group >> phone: +39 0584 962313 >> >> fax: +39 0584 1660272 >> >> mob: +39 339 8844549 >> >> https://www.geosolutionsgroup.com/ >> >> http://twitter.com/geosolutions_it >> >> --- >> >> Con riferimento alla normativa sul trattamento dei dati personali (Reg. >> UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si >> precisa che ogni circostanza inerente alla presente email (il suo >> contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è >> riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il >> messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra >> operazione è illecita. Le sarei comunque grato se potesse darmene notizia. >> >> This email is intended only for the person or entity to which it is >> addressed and may contain information that is privileged, confidential or >> otherwise protected from disclosure. We remind that - as provided by >> European Regulation 2016/679 “GDPR” - copying, dissemination or use of this >> e-mail or the information herein by anyone other than the intended >> recipient is prohibited. If you have received this email by mistake, please >> notify us immediately by telephone or e-mail >> > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] [Geowebcache-devel] Starting the GT 27.3, GWC 1.21.3, GS 2.21.3 release train
Checking: - The bin download looks good, and the html files (readme, running, licenses) are accounted for. - war download (did not run) the readme and running instructions are missing, but licenses are included. - javadoc - html docs - license.md, readme.txt but at least there is something - data - readme.txt only, should probably have a license Looking into it - seems https://github.com/geoserver/geoserver/pull/6367 was not backported (too bad) -- Jody Garnett On Wed, Dec 28, 2022 at 2:49 AM Andrea Aime < andrea.a...@geosolutionsgroup.com> wrote: > On Wed, Dec 28, 2022 at 8:09 AM Jody Garnett > wrote: > >> Good news, >> >> The release is available for pre-flight testing: >> https://build.geoserver.org/view/release/job/geoserver-release/lastSuccessfulBuild/artifact/distribution/2.21.3/ >> > > Thank you! > > > >> And the windows installer built automatically and uploaded the above >> folder without incident :) >> > > Ooh... Santa came a little late but the gift is nice! > > Cheers > Andrea > > == > > GeoServer Professional Services from the experts! > > Visit http://bit.ly/gs-services-us for more information. > == > > Ing. Andrea Aime > @geowolf > Technical Lead > > GeoSolutions Group > phone: +39 0584 962313 > > fax: +39 0584 1660272 > > mob: +39 339 8844549 > > https://www.geosolutionsgroup.com/ > > http://twitter.com/geosolutions_it > > --- > > Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE > 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si > precisa che ogni circostanza inerente alla presente email (il suo > contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è > riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il > messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra > operazione è illecita. Le sarei comunque grato se potesse darmene notizia. > > This email is intended only for the person or entity to which it is > addressed and may contain information that is privileged, confidential or > otherwise protected from disclosure. We remind that - as provided by > European Regulation 2016/679 “GDPR” - copying, dissemination or use of this > e-mail or the information herein by anyone other than the intended > recipient is prohibited. If you have received this email by mistake, please > notify us immediately by telephone or e-mail > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] [Geowebcache-devel] Starting the GT 27.3, GWC 1.21.3, GS 2.21.3 release train
Good news, The release is available for pre-flight testing: https://build.geoserver.org/view/release/job/geoserver-release/lastSuccessfulBuild/artifact/distribution/2.21.3/ And the windows installer built automatically and uploaded the above folder without incident :) -- Jody Garnett On Tue, Dec 27, 2022 at 10:20 AM Andrea Aime < andrea.a...@geosolutionsgroup.com> wrote: > I have run the GeoTools jobs and released GWC as well. Will resume > tomorrow. Still to do: > - GS release > - Jira releases > - Announcements > > Cheers > Andrea > > On Tue, Dec 27, 2022 at 3:58 PM Jody Garnett > wrote: > >> Thanks Andrea, I can help also. >> >> On Tue, Dec 27, 2022 at 2:58 AM Andrea Aime < >> andrea.a...@geosolutionsgroup.com> wrote: >> >>> Hi all, >>> some weeks ago we looked for a volunteer but no one showed up ... so we >>> either skip the release or well... volunteer someone 😂 >>> I'm going for the second, starting the GT release right now (everything >>> seems quiet, no important pending PRs on the 27.x branch) and will follow >>> up with GWC and GS in the following days. >>> >>> Cheers >>> Andrea >>> >>> -- >>> >>> Regards, >>> >>> Andrea Aime >>> >>> == >>> GeoServer Professional Services from the experts! >>> >>> Visit http://bit.ly/gs-services-us for more information. >>> == >>> >>> Ing. Andrea Aime >>> @geowolf >>> Technical Lead >>> >>> GeoSolutions Group >>> phone: +39 0584 962313 >>> >>> fax: +39 0584 1660272 >>> >>> mob: +39 339 8844549 >>> >>> https://www.geosolutionsgroup.com/ >>> >>> http://twitter.com/geosolutions_it >>> >>> --- >>> >>> Con riferimento alla normativa sul trattamento dei dati personali (Reg. >>> UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si >>> precisa che ogni circostanza inerente alla presente email (il suo >>> contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è >>> riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il >>> messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra >>> operazione è illecita. Le sarei comunque grato se potesse darmene notizia. >>> >>> This email is intended only for the person or entity to which it is >>> addressed and may contain information that is privileged, confidential or >>> otherwise protected from disclosure. We remind that - as provided by >>> European Regulation 2016/679 “GDPR” - copying, dissemination or use of this >>> e-mail or the information herein by anyone other than the intended >>> recipient is prohibited. If you have received this email by mistake, please >>> notify us immediately by telephone or e-mail >>> ___ >>> Geowebcache-devel mailing list >>> geowebcache-de...@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/geowebcache-devel >>> >> -- >> -- >> Jody Garnett >> > > > -- > > Regards, > > Andrea Aime > > == > GeoServer Professional Services from the experts! > > Visit http://bit.ly/gs-services-us for more information. > == > > Ing. Andrea Aime > @geowolf > Technical Lead > > GeoSolutions Group > phone: +39 0584 962313 > > fax: +39 0584 1660272 > > mob: +39 339 8844549 > > https://www.geosolutionsgroup.com/ > > http://twitter.com/geosolutions_it > > --- > > Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE > 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si > precisa che ogni circostanza inerente alla presente email (il suo > contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è > riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il > messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra > operazione è illecita. Le sarei comunque grato se potesse darmene notizia. > > This email is intended only for the person or entity to which it is > addressed and may contain information that is privileged, confidential or > otherwise protected from disclosure. We remind that - as provided by > European Regulation 2016/679 “GDPR” - copying, dissemination or use of this > e-mail or the information herein by anyone other than the intended > recipient is prohibited. If you have received this email by mistake, please > notify us immediately by telephone or e-mail > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] Dropping Java 8 from main branch
My understanding is we are waiting for the new year before merging this PR (want to be on hand for those upgrading their dev env to java 11). -- Jody Garnett On Mon, Dec 19, 2022 at 8:26 AM Jody Garnett wrote: > After a bit of guesswork and troubleshooting on windows / Java 11 combo > the PR is ready: https://github.com/geoserver/geoserver/pull/6370 > > Thanks Andrea for doing the heavy lifting on this one; the documentation > is already updated to be Java 11 minimum. > > Please be advised that when this PR is merged you will *require* a Java > 11 environment for working on the main branch. > -- > Jody Garnett > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] [Geowebcache-devel] Starting the GT 27.3, GWC 1.21.3, GS 2.21.3 release train
Thanks Andrea, I can help also. On Tue, Dec 27, 2022 at 2:58 AM Andrea Aime < andrea.a...@geosolutionsgroup.com> wrote: > Hi all, > some weeks ago we looked for a volunteer but no one showed up ... so we > either skip the release or well... volunteer someone 😂 > I'm going for the second, starting the GT release right now (everything > seems quiet, no important pending PRs on the 27.x branch) and will follow > up with GWC and GS in the following days. > > Cheers > Andrea > > -- > > Regards, > > Andrea Aime > > == > GeoServer Professional Services from the experts! > > Visit http://bit.ly/gs-services-us for more information. > == > > Ing. Andrea Aime > @geowolf > Technical Lead > > GeoSolutions Group > phone: +39 0584 962313 > > fax: +39 0584 1660272 > > mob: +39 339 8844549 > > https://www.geosolutionsgroup.com/ > > http://twitter.com/geosolutions_it > > --- > > Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE > 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si > precisa che ogni circostanza inerente alla presente email (il suo > contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è > riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il > messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra > operazione è illecita. Le sarei comunque grato se potesse darmene notizia. > > This email is intended only for the person or entity to which it is > addressed and may contain information that is privileged, confidential or > otherwise protected from disclosure. We remind that - as provided by > European Regulation 2016/679 “GDPR” - copying, dissemination or use of this > e-mail or the information herein by anyone other than the intended > recipient is prohibited. If you have received this email by mistake, please > notify us immediately by telephone or e-mail > _______ > Geowebcache-devel mailing list > geowebcache-de...@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geowebcache-devel > -- -- Jody Garnett ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
[Geoserver-devel] [JIRA] (GEOS-10808) WCS 2.0 tests failing on macOS M1 environment
Jody Garnett ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae422bb7f-4808-47e3-837f-13db0e6681e3 ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiNmM2NzZjYzBhNTU1NDYyNmEyNzcwNjhlNmVkNzE5N2EiLCJwIjoiaiJ9 ) / Task ( https://osgeo-org.atlassian.net/browse/GEOS-10808?atlOrigin=eyJpIjoiNmM2NzZjYzBhNTU1NDYyNmEyNzcwNjhlNmVkNzE5N2EiLCJwIjoiaiJ9 ) GEOS-10808 ( https://osgeo-org.atlassian.net/browse/GEOS-10808?atlOrigin=eyJpIjoiNmM2NzZjYzBhNTU1NDYyNmEyNzcwNjhlNmVkNzE5N2EiLCJwIjoiaiJ9 ) WCS 2.0 tests failing on macOS M1 environment ( https://osgeo-org.atlassian.net/browse/GEOS-10808?atlOrigin=eyJpIjoiNmM2NzZjYzBhNTU1NDYyNmEyNzcwNjhlNmVkNzE5N2EiLCJwIjoiaiJ9 ) Issue Type: Task Assignee: Unassigned Created: 24/Dec/22 9:28 AM Environment: openjdk version "11.0.17" 2022-10-18 OpenJDK Runtime Environment Temurin-11.0.17+8 (build 11.0.17+8) OpenJDK 64-Bit Server VM Temurin-11.0.17+8 (build 11.0.17+8, mixed mode) Priority: Medium Reporter: Jody Garnett ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae422bb7f-4808-47e3-837f-13db0e6681e3 ) The following failures are observed: [ERROR] Failures: [ERROR] DescribeCoverageTest.testReprojectFromNative:982 expected:<...3E7 6199732.71372963[5]> but was:<...3E7 6199732.71372963[4]> [ERROR] GetCapabilitiesTest.testBasicKVP:48->WCSTestSupport.checkFullCapabilitiesDocument:394 expected:<...3E7 6199732.71372963[5]> but was:<...3E7 6199732.71372963[4]> [ERROR] GetCapabilitiesTest.testBasicPost:37->WCSTestSupport.checkFullCapabilitiesDocument:394 expected:<...3E7 6199732.71372963[5]> but was:<...3E7 6199732.71372963[4]> We have encountered these kind of difficulties before as Java does not completely hide the host platform implementation of IEEE math. ( https://osgeo-org.atlassian.net/browse/GEOS-10808#add-comment?atlOrigin=eyJpIjoiNmM2NzZjYzBhNTU1NDYyNmEyNzcwNjhlNmVkNzE5N2EiLCJwIjoiaiJ9 ) Add Comment ( https://osgeo-org.atlassian.net/browse/GEOS-10808#add-comment?atlOrigin=eyJpIjoiNmM2NzZjYzBhNTU1NDYyNmEyNzcwNjhlNmVkNzE5N2EiLCJwIjoiaiJ9 ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100213- sha1:d1b903b )___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
[Geoserver-devel] [JIRA] (GEOS-10804) Resource paths do not reliably recognize absolute paths on windows
Jody Garnett ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae422bb7f-4808-47e3-837f-13db0e6681e3 ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiOTRkM2EyZDM5ZTljNDAyZGE4ZjY2MWMzYjNlMjIwOTciLCJwIjoiaiJ9 ) / Bug ( https://osgeo-org.atlassian.net/browse/GEOS-10804?atlOrigin=eyJpIjoiOTRkM2EyZDM5ZTljNDAyZGE4ZjY2MWMzYjNlMjIwOTciLCJwIjoiaiJ9 ) GEOS-10804 ( https://osgeo-org.atlassian.net/browse/GEOS-10804?atlOrigin=eyJpIjoiOTRkM2EyZDM5ZTljNDAyZGE4ZjY2MWMzYjNlMjIwOTciLCJwIjoiaiJ9 ) Resource paths do not reliably recognize absolute paths on windows ( https://osgeo-org.atlassian.net/browse/GEOS-10804?atlOrigin=eyJpIjoiOTRkM2EyZDM5ZTljNDAyZGE4ZjY2MWMzYjNlMjIwOTciLCJwIjoiaiJ9 ) Issue Type: Bug Assignee: Unassigned Created: 20/Dec/22 8:21 AM Priority: Medium Reporter: Jody Garnett ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae422bb7f-4808-47e3-837f-13db0e6681e3 ) This was noticed due to Java 11 bug highlighting difference between *C:folder* relative path and *C:\folder* absolute path. ( https://osgeo-org.atlassian.net/browse/GEOS-10804#add-comment?atlOrigin=eyJpIjoiOTRkM2EyZDM5ZTljNDAyZGE4ZjY2MWMzYjNlMjIwOTciLCJwIjoiaiJ9 ) Add Comment ( https://osgeo-org.atlassian.net/browse/GEOS-10804#add-comment?atlOrigin=eyJpIjoiOTRkM2EyZDM5ZTljNDAyZGE4ZjY2MWMzYjNlMjIwOTciLCJwIjoiaiJ9 ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100213- sha1:1464b31 )___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
[Geoserver-devel] Dropping Java 8 from main branch
After a bit of guesswork and troubleshooting on windows / Java 11 combo the PR is ready: https://github.com/geoserver/geoserver/pull/6370 Thanks Andrea for doing the heavy lifting on this one; the documentation is already updated to be Java 11 minimum. Please be advised that when this PR is merged you will *require* a Java 11 environment for working on the main branch. -- Jody Garnett ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
[Geoserver-devel] [JIRA] (GEOS-10761) Failed login with encrypt URL parameters setting results in 404
Jody Garnett (
https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae422bb7f-4808-47e3-837f-13db0e6681e3
) *created* an issue
GeoServer (
https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiNWMxMTkwNzJkMWU5NDk4YmEyMTEzN2I4MWVhNzE4NWUiLCJwIjoiaiJ9
) / Bug (
https://osgeo-org.atlassian.net/browse/GEOS-10761?atlOrigin=eyJpIjoiNWMxMTkwNzJkMWU5NDk4YmEyMTEzN2I4MWVhNzE4NWUiLCJwIjoiaiJ9
) GEOS-10761 (
https://osgeo-org.atlassian.net/browse/GEOS-10761?atlOrigin=eyJpIjoiNWMxMTkwNzJkMWU5NDk4YmEyMTEzN2I4MWVhNzE4NWUiLCJwIjoiaiJ9
) Failed login with encrypt URL parameters setting results in 404 (
https://osgeo-org.atlassian.net/browse/GEOS-10761?atlOrigin=eyJpIjoiNWMxMTkwNzJkMWU5NDk4YmEyMTEzN2I4MWVhNzE4NWUiLCJwIjoiaiJ9
)
Issue Type: Bug Affects Versions: 2.21.2, 2.22.0 Assignee: Unassigned
Components: Wicket UI Created: 29/Nov/22 4:48 PM Environment:
Java 11, Tomcat 8.5
Priority: Medium Reporter: Jody Garnett (
https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae422bb7f-4808-47e3-837f-13db0e6681e3
)
Failed login page inaccessible when encrypt URL parameters enabled:
* Login as admin
* Change Security Settings *Encrypt web admin URL parameters* (as described
here (
https://docs.geoserver.org/latest/en/user/security/webadmin/settings.html#encryption
) )
* Logout, the home page has a random {{wicket-crypt= }}parameter to keep the
sequence from being guessable
* Fail to login, and be redirected to 404 page:
http://localhost:8080/geoserver/web/wicket/bookmarkable/org.geoserver.web.GeoServerLoginPage?error=true
(
http://localhost:8080/geoserver/web/wicket/bookmarkable/org.geoserver.web.GeoServerLoginPage?error=true
)
See attached screen snap for comparison.
(
https://osgeo-org.atlassian.net/browse/GEOS-10761#add-comment?atlOrigin=eyJpIjoiNWMxMTkwNzJkMWU5NDk4YmEyMTEzN2I4MWVhNzE4NWUiLCJwIjoiaiJ9
) Add Comment (
https://osgeo-org.atlassian.net/browse/GEOS-10761#add-comment?atlOrigin=eyJpIjoiNWMxMTkwNzJkMWU5NDk4YmEyMTEzN2I4MWVhNzE4NWUiLCJwIjoiaiJ9
)
Get Jira notifications on your phone! Download the Jira Cloud app for Android (
https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail
) or iOS (
https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8
) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210-
sha1:4037f92 )___
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] Proposing Joseph Miller for commit rights
+1 And thanks for the work :) -- Jody Garnett On Mon, Nov 28, 2022 at 9:23 AM Andrea Aime < andrea.a...@geosolutionsgroup.com> wrote: > Hi all, > Joseph has been working on a number of PRs lately, on a variety of > different topics (request logging, database column descriptions, STAC, > GetFeature output format control, and more, see also the proposal I'm > making on the gt-devel side). > He has patiently been applying all review feedback received. > > I'd like to propose Joseph for commit rights on the GeoServer project. > > What do you think? > > Cheers > Andrea > > > == > GeoServer Professional Services from the experts! > > Visit http://bit.ly/gs-services-us for more information. > == > > Ing. Andrea Aime > @geowolf > Technical Lead > > GeoSolutions Group > phone: +39 0584 962313 > > fax: +39 0584 1660272 > > mob: +39 339 8844549 > > https://www.geosolutionsgroup.com/ > > http://twitter.com/geosolutions_it > > --- > > Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE > 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si > precisa che ogni circostanza inerente alla presente email (il suo > contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è > riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il > messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra > operazione è illecita. Le sarei comunque grato se potesse darmene notizia. > > This email is intended only for the person or entity to which it is > addressed and may contain information that is privileged, confidential or > otherwise protected from disclosure. We remind that - as provided by > European Regulation 2016/679 “GDPR” - copying, dissemination or use of this > e-mail or the information herein by anyone other than the intended > recipient is prohibited. If you have received this email by mistake, please > notify us immediately by telephone or e-mail > ___ > Geoserver-devel mailing list > Geoserver-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geoserver-devel > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
[Geoserver-devel] [JIRA] (GEOS-10759) Welcome page unreachable with large / slow catalogue configuration
Jody Garnett ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae422bb7f-4808-47e3-837f-13db0e6681e3 ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiNTYwMDM3ZDgwNjJmNDIxMzg1ODY3MTIzODEzZDk2MTIiLCJwIjoiaiJ9 ) / Bug ( https://osgeo-org.atlassian.net/browse/GEOS-10759?atlOrigin=eyJpIjoiNTYwMDM3ZDgwNjJmNDIxMzg1ODY3MTIzODEzZDk2MTIiLCJwIjoiaiJ9 ) GEOS-10759 ( https://osgeo-org.atlassian.net/browse/GEOS-10759?atlOrigin=eyJpIjoiNTYwMDM3ZDgwNjJmNDIxMzg1ODY3MTIzODEzZDk2MTIiLCJwIjoiaiJ9 ) Welcome page unreachable with large / slow catalogue configuration ( https://osgeo-org.atlassian.net/browse/GEOS-10759?atlOrigin=eyJpIjoiNTYwMDM3ZDgwNjJmNDIxMzg1ODY3MTIzODEzZDk2MTIiLCJwIjoiaiJ9 ) Issue Type: Bug Assignee: Unassigned Created: 27/Nov/22 8:33 PM Environment: GeoServer configuration with Oracle Data store and 20k+ layers. Priority: Medium Reporter: Jody Garnett ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae422bb7f-4808-47e3-837f-13db0e6681e3 ) From email Andrea Aime ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae9469ffc-5e16-4c2b-b7b0-b9c46e912f9e ) writes: > > > > I've just got a report from a customer that they tried to upgrade to > 2.22.0, but had to quickly revert back to 2.21.x, as the GeoServer home > page was unreachable. > > > > What is interesting about that deployment is the number of layer, well > above 20k. Not the largest I've seen, but large. Also, all the layers are > sourced from an Oracle database. > > > > In their case, the home page takes several minutes to load. > > ( https://osgeo-org.atlassian.net/browse/GEOS-10759#add-comment?atlOrigin=eyJpIjoiNTYwMDM3ZDgwNjJmNDIxMzg1ODY3MTIzODEzZDk2MTIiLCJwIjoiaiJ9 ) Add Comment ( https://osgeo-org.atlassian.net/browse/GEOS-10759#add-comment?atlOrigin=eyJpIjoiNTYwMDM3ZDgwNjJmNDIxMzg1ODY3MTIzODEzZDk2MTIiLCJwIjoiaiJ9 ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:eab5823 )___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] Workpace/layer home page selection problematic with large data directories
Andrea: One more idea - does your customer have global services on or off when working with such a large catalogue I could see changing the workflow to select workspace --> select layers when global services are off. -- Jody Garnett On Thu, Nov 24, 2022 at 10:20 PM Jody Garnett wrote: > Andrea; > > I sure wish this was tested with a large number of layers during the RC; > but good we are getting the feedback now. > > Ideas: > > 1. Over 1k layers? Switch to a mode where workspace is selected 1st; then > enable layer the layer selector with a smaller list of layers? > 2. Over 1k layers? Make the controls into simple text fields; no look > ahead (guess this is similar to your suggestion) > > But yeah I was just hitting the catalog api; could we check what data type > verification is being hit? Most likely an enabled / available check? > > -- > Jody Garnett > > > On Thu, Nov 24, 2022 at 2:18 AM Andrea Aime < > andrea.a...@geosolutionsgroup.com> wrote: > >> Hi all, >> I've just got a report from a customer that they tried to upgrade to >> 2.22.0, but had to quickly revert back to 2.21.x, as the GeoServer home >> page was unreachable. >> >> What is interesting about that deployment is the number of layer, well >> above 20k. Not the largest I've seen, but large. Also, all the layers are >> sourced from an Oracle database. >> In their case, the home page takes several minutes to load. >> >> Locally I have an oddball test data directory with 40k layers, but with >> an easing factor, it's a "many times copy" of the GeoServer demo layers, >> meaning it's all shapefiles. >> The landing page for me displays quick enough (few seconds), but then >> the browser is on its knees, completely unresponsive, for 10+ seconds. >> After that, trying to use the workspace/layer dropdown also incurs in >> severe slowdown, with the browser blocked for several seconds. >> Chrome reports that one tab with the home page is using 776MB of memory, >> too. >> >> Considering I've seen installations with up to 1 million layers (a case >> where they actually had 3 millions, and split them across 3 different data >> directories), this is a serious problem... >> >> I have also seen Gabriel experiment with large geoserver-cloud >> deployments with a lot of workspaces (tens of thousands? more?) but I >> cannot find the relevant branch anymore (believe it was about better >> parallelizing data directory loading, cannot find the commit anymore). >> >> How to address it though? Throwing in a couple of ideas: >> >>- Make the functionality opt-in or opt-out via a flag or UI >>configuration. The flag might be hard to discover, but the UI setting >> could >>be hard to reach if one cannot get to the home page to start with... >>- Automatically disable the dropdowns after a certain threshold of >>workspaces layers is reached, with the threshold being configurable? Say >>1000 for example? However it might still cause issues for data sources >> that >>are slow to be connected (I'm guessing part of the slowness is due to some >>data type verification that requires actual connection to the data source, >>based on the fact the Oracle seems a lot slower to just generate the page >> >> Any other idea? >> >> Cheers >> Andrea >> >> == >> >> GeoServer Professional Services from the experts! >> >> Visit http://bit.ly/gs-services-us for more information. >> == >> >> Ing. Andrea Aime >> @geowolf >> Technical Lead >> >> GeoSolutions Group >> phone: +39 0584 962313 >> >> fax: +39 0584 1660272 >> >> mob: +39 339 8844549 >> >> https://www.geosolutionsgroup.com/ >> >> http://twitter.com/geosolutions_it >> >> --- >> >> Con riferimento alla normativa sul trattamento dei dati personali (Reg. >> UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si >> precisa che ogni circostanza inerente alla presente email (il suo >> contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è >> riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il >> messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra >> operazione è illecita. Le sarei comunque grato se potesse darmene notizia. >> >> This email is intended only for the person or entity to which it is >> addressed and may contain information that is privileged, confidential or >&
Re: [Geoserver-devel] Workpace/layer home page selection problematic with large data directories
Andrea; I sure wish this was tested with a large number of layers during the RC; but good we are getting the feedback now. Ideas: 1. Over 1k layers? Switch to a mode where workspace is selected 1st; then enable layer the layer selector with a smaller list of layers? 2. Over 1k layers? Make the controls into simple text fields; no look ahead (guess this is similar to your suggestion) But yeah I was just hitting the catalog api; could we check what data type verification is being hit? Most likely an enabled / available check? -- Jody Garnett On Thu, Nov 24, 2022 at 2:18 AM Andrea Aime < andrea.a...@geosolutionsgroup.com> wrote: > Hi all, > I've just got a report from a customer that they tried to upgrade to > 2.22.0, but had to quickly revert back to 2.21.x, as the GeoServer home > page was unreachable. > > What is interesting about that deployment is the number of layer, well > above 20k. Not the largest I've seen, but large. Also, all the layers are > sourced from an Oracle database. > In their case, the home page takes several minutes to load. > > Locally I have an oddball test data directory with 40k layers, but with an > easing factor, it's a "many times copy" of the GeoServer demo layers, > meaning it's all shapefiles. > The landing page for me displays quick enough (few seconds), but then > the browser is on its knees, completely unresponsive, for 10+ seconds. > After that, trying to use the workspace/layer dropdown also incurs in > severe slowdown, with the browser blocked for several seconds. > Chrome reports that one tab with the home page is using 776MB of memory, > too. > > Considering I've seen installations with up to 1 million layers (a case > where they actually had 3 millions, and split them across 3 different data > directories), this is a serious problem... > > I have also seen Gabriel experiment with large geoserver-cloud deployments > with a lot of workspaces (tens of thousands? more?) but I cannot find the > relevant branch anymore (believe it was about better parallelizing data > directory loading, cannot find the commit anymore). > > How to address it though? Throwing in a couple of ideas: > >- Make the functionality opt-in or opt-out via a flag or UI >configuration. The flag might be hard to discover, but the UI setting could >be hard to reach if one cannot get to the home page to start with... >- Automatically disable the dropdowns after a certain threshold of >workspaces layers is reached, with the threshold being configurable? Say >1000 for example? However it might still cause issues for data sources that >are slow to be connected (I'm guessing part of the slowness is due to some >data type verification that requires actual connection to the data source, >based on the fact the Oracle seems a lot slower to just generate the page > > Any other idea? > > Cheers > Andrea > > == > > GeoServer Professional Services from the experts! > > Visit http://bit.ly/gs-services-us for more information. > == > > Ing. Andrea Aime > @geowolf > Technical Lead > > GeoSolutions Group > phone: +39 0584 962313 > > fax: +39 0584 1660272 > > mob: +39 339 8844549 > > https://www.geosolutionsgroup.com/ > > http://twitter.com/geosolutions_it > > --- > > Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE > 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si > precisa che ogni circostanza inerente alla presente email (il suo > contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è > riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il > messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra > operazione è illecita. Le sarei comunque grato se potesse darmene notizia. > > This email is intended only for the person or entity to which it is > addressed and may contain information that is privileged, confidential or > otherwise protected from disclosure. We remind that - as provided by > European Regulation 2016/679 “GDPR” - copying, dissemination or use of this > e-mail or the information herein by anyone other than the intended > recipient is prohibited. If you have received this email by mistake, please > notify us immediately by telephone or e-mail > ___ > Geoserver-devel mailing list > Geoserver-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geoserver-devel > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] GeoServer 2.22RC does not write log into the logfile
Jukka: I think I added some examples to the user manual on how to do this. I do wish we could figure out your RHEL challenge - perhaps with wider release another user will encounter the problem and we can learn more. Here is the example https://docs.geoserver.org/latest/en/user/configuration/logging.html#forcing-geoserver-to-relinquish-log4j-control -DRELINQUISH_LOG4J_CONTROL=true -Dlog4j2.configurationFile=logging_configuration.xml When used in this fashion it will use the location defined in the logging_configuration - or even no log file at all just console out. An example of which is further down the page. Jody On Tue, Nov 22, 2022 at 2:31 AM Rahkonen Jukka < jukka.rahko...@maanmittauslaitos.fi> wrote: > Hi, > > > > We have not been able to make our GeoServer 2.22 to write log into a file > https://osgeo-org.atlassian.net/browse/GEOS-10744. Our developer wants to > get help with a workaround and write: > > > > “We haven’t been able to figure out the logging problem with 2.22-RC on > our RHEL servers. Different tomcat and java version combinations have been > tested among other configurations. > > We are now searching for a way to work around the problem. Is it possible > to disable normal geoserver logging and get the same output to catalina.log > or a separate named log file in /tomcat/logs using RELINQUISH_LOG4J_CONTROL > or other options. Can you describe what are the required configurations of > a setup like this.” > > > > -Jukka Rahkonen- > ___ > Geoserver-devel mailing list > Geoserver-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geoserver-devel > -- -- Jody Garnett ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] [Geotools-devel] GeoServer/GeoTools PMC Meeting at 18:30 CET / 9:30 PST tomorrow
Thanks Torben, I am unable to attend tomorrow. On Mon, Nov 21, 2022 at 11:52 AM Torben Barsballe wrote: > Reminder that the next PMC meeting is scheduled for tomorrow, Nov 22, at > 18:30 > <https://www.timeanddate.com/worldclock/fixedtime.html?year=2022&month=11&day=22&hour=18&min=30&sec=0&msg=GeoTools%20/%20GeoServer%20Meeting&ah=1&sort=1&p1=215> > CET. > > > Cheers, > > Torben > ___ > GeoTools-Devel mailing list > geotools-de...@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geotools-devel > -- -- Jody Garnett ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] GeoServer 2.22.0 release artifacts ready for testing
Andrea Reopened the existing ticket: https://osgeo-org.atlassian.net/browse/GEOS-10606 Also checked the docs bundles. And PR: https://github.com/geoserver/geoserver/pull/6367 -- Jody Garnett On Nov 18, 2022 at 9:34:12 AM, Andrea Aime < andrea.a...@geosolutionsgroup.com> wrote: > On Fri, Nov 18, 2022 at 6:18 PM Jody Garnett > wrote: > >> Andrea >> >> Doing some quick tests with war bundle: java temurin- 11.0.16.1+1) / >> apachine-tomcat-9.0.68 >> > > Thanks! > > >> >> >>1. Bundle: >> 1. *Bundle does not readme and running instructions.* >> >> > war files are not for the faint hearted, one should know what to do with > them... but having the instructions > would be good. Also don't think it's new, I don't see a README in the > 2.21.x bundles either. > > Ticket and fix by 2.22.1? > > Cheers > Andrea > > == > > GeoServer Professional Services from the experts! > > Visit http://bit.ly/gs-services-us for more information. > == > > Ing. Andrea Aime > @geowolf > Technical Lead > > GeoSolutions Group > phone: +39 0584 962313 > > fax: +39 0584 1660272 > > mob: +39 339 8844549 > > https://www.geosolutionsgroup.com/ > > http://twitter.com/geosolutions_it > > --- > > Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE > 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si > precisa che ogni circostanza inerente alla presente email (il suo > contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è > riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il > messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra > operazione è illecita. Le sarei comunque grato se potesse darmene notizia. > > This email is intended only for the person or entity to which it is > addressed and may contain information that is privileged, confidential or > otherwise protected from disclosure. We remind that - as provided by > European Regulation 2016/679 “GDPR” - copying, dissemination or use of this > e-mail or the information herein by anyone other than the intended > recipient is prohibited. If you have received this email by mistake, please > notify us immediately by telephone or e-mail > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] Some troubles with the GeoServer release
You are correct; I think it is working now (used find to remove the file if it exists before changing ownership). -- Jody Garnett On Nov 18, 2022 at 8:47:31 AM, Carsten Klein wrote: > I expect that as a normal user jenkins cannot change ownership of a file > (w access for the group is not sufficient for chown?) > > In Linux, only root can change ownership. Maybe you could sudo? > > Carsten > Am 18.11.2022 um 17:32 schrieb Jody Garnett: > > Updated the Personal Access Token, > > I note the chmod is failing as Jenkins does not have permission to modify > exe uploaded by prior run. Deleting the file allowed to verify that the > access token works (and installer was uploaded). > > > Trying to change the file group to jenkins so this should not happen in > the future: > > -rw-rw-r-- 1 azurebuild jenkins 110M Nov 18 16:19 > GeoServer-2.22.0-winsetup.exe > > But this did not resolve the issue; and chmod failed on the next attempt. > > chmod: changing permissions of > '/var/lib/jenkins/jobs/geoserver-release/builds/92/archive/distribution/2.22.0/GeoServer-2.22.0-winsetup.exe': > Operation not permitted > > I expect that as a normal user jenkins cannot change ownership of a file > (w access for the group is not sufficient for chown?) > -- > Jody Garnett > > > On Nov 18, 2022 at 4:39:37 AM, Juan Luis Rodriguez Ponce < > juanlui...@geocat.net> wrote: > >> On Fri, 18 Nov 2022 12:47:06 +0100 *Andrea Aime >> >* >> wrote --- >> >> Hi Juan, >> thanks for doing that! >> >> Looks like the release job was not used, it's still red, so I assume you >> run the creation on your own. >> What needs to be done, in order to get that job fixed and running >> automatically when we need to? >> >> >> I guess I or Jody need to generate a Personal Access Token in Azure Dev, >> update the current secret (AZURE_WINDOWS_CREDENTIALS) used by the job in >> Jenkins. The project changed to a new organization and the old PAT stopped >> working. Probably Jody has enough permissions to update the secret. >> >> Best regards, >> Juan Luis. >> >> > > ___ > Geoserver-devel mailing > listGeoserver-devel@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/geoserver-devel > > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] GeoServer 2.22.0 release artifacts ready for testing
Andrea Doing some quick tests with war bundle: java temurin- 11.0.16.1+1) / apachine-tomcat-9.0.68 1. Bundle: 1. *Bundle does not readme and running instructions.* 2. Quick test: bin/catalina.sh run 3. Language chooser 1. shows German and Dutch translation of welcome page description 4. Natural Earth GeoPackage and workspace 1. ne:world looks good 5. Logging profile date formatting updates 1. Logs have: "18 Nov. 08:17:23 INFO" with today's date rather than milliseconds 6. Startup logging messages - much improved 7. Welcome Page Updates 1. Welcome page is behaving correctly 2. Contact information changes are good 8. Style format displayed 9. GWC security testing worked; turned off global services, made ne.* require authenticated Docs: - https://docs.geoserver.org/latest/en/user/webadmin/welcome.html - Description is fine, some screen snaps can be updated - https://docs.geoserver.org/latest/en/user/configuration/contact.html - Updated - https://docs.geoserver.org/latest/en/user/installation/upgrade.html#log4j-upgrade-geoserver-2-21-and-newer - Useful to link to in release anouncement -- Jody Garnett On Nov 17, 2022 at 10:29:23 AM, Andrea Aime < andrea.a...@geosolutionsgroup.com> wrote: > Hi all, > the release artifacts are available here, if you have time for a quick > test: > > > https://build.geoserver.org/view/release/job/geoserver-release/lastSuccessfulBuild/artifact/distribution/2.22.0/ > > Cheers > Andrea > > > == > GeoServer Professional Services from the experts! > > Visit http://bit.ly/gs-services-us for more information. > == > > Ing. Andrea Aime > @geowolf > Technical Lead > > GeoSolutions Group > phone: +39 0584 962313 > > fax: +39 0584 1660272 > > mob: +39 339 8844549 > > https://www.geosolutionsgroup.com/ > > http://twitter.com/geosolutions_it > > --- > > Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE > 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si > precisa che ogni circostanza inerente alla presente email (il suo > contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è > riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il > messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra > operazione è illecita. Le sarei comunque grato se potesse darmene notizia. > > This email is intended only for the person or entity to which it is > addressed and may contain information that is privileged, confidential or > otherwise protected from disclosure. We remind that - as provided by > European Regulation 2016/679 “GDPR” - copying, dissemination or use of this > e-mail or the information herein by anyone other than the intended > recipient is prohibited. If you have received this email by mistake, please > notify us immediately by telephone or e-mail > ___ > Geoserver-devel mailing list > Geoserver-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geoserver-devel > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] Some troubles with the GeoServer release
Updated the Personal Access Token, I note the chmod is failing as Jenkins does not have permission to modify exe uploaded by prior run. Deleting the file allowed to verify that the access token works (and installer was uploaded). Trying to change the file group to jenkins so this should not happen in the future: -rw-rw-r-- 1 azurebuild jenkins 110M Nov 18 16:19 GeoServer-2.22.0-winsetup.exe But this did not resolve the issue; and chmod failed on the next attempt. chmod: changing permissions of '/var/lib/jenkins/jobs/geoserver-release/builds/92/archive/distribution/2.22.0/GeoServer-2.22.0-winsetup.exe': Operation not permitted I expect that as a normal user jenkins cannot change ownership of a file (w access for the group is not sufficient for chown?) -- Jody Garnett On Nov 18, 2022 at 4:39:37 AM, Juan Luis Rodriguez Ponce < juanlui...@geocat.net> wrote: > On Fri, 18 Nov 2022 12:47:06 +0100 *Andrea Aime > >* > wrote --- > > Hi Juan, > thanks for doing that! > > Looks like the release job was not used, it's still red, so I assume you > run the creation on your own. > What needs to be done, in order to get that job fixed and running > automatically when we need to? > > > I guess I or Jody need to generate a Personal Access Token in Azure Dev, > update the current secret (AZURE_WINDOWS_CREDENTIALS) used by the job in > Jenkins. The project changed to a new organization and the old PAT stopped > working. Probably Jody has enough permissions to update the secret. > > Best regards, > Juan Luis. > > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] Some troubles with the GeoServer release
Andrea: You are correct the permission changes allow the windows build to write the installer (when it is available) back to that location so it is available for the publish step to upload. Juan may be able to troubleshot. For this release I should be able to login and get the windows installer from azure (not sure). Not sure if it is in the release instructions yet but the Docker image instructions are here: https://github.com/geoserver/docker/blob/master/README.md update the docker file version numbers docker build -t geoserver-docker.osgeo.org/geoserver:2.22.0 . docker login geoserver-docker.osgeo.org docker push geoserver-docker.osgeo.org/geoserver:2.22.0 -- Jody Garnett On Thu, 17 Nov 2022 at 10:32, Andrea Aime wrote: > Removing that step allowed the release job to succeed... and the windows > build failed (again). > Seems due to permission issues, so those commands should probably be > placed in the windows build? > > Cheers > Andrea > > On Thu, Nov 17, 2022 at 7:22 PM Andrea Aime < > andrea.a...@geosolutionsgroup.com> wrote: > >> Hi, >> me and Martha have been going through the release process and reached the >> geoserver-release build. >> >> It kept on failing, looking into it, I've found the disk was full. I've >> removed some very old builds and their workspaces, freeing some space, and >> started looking into cleaning up snapshots, as they are accumulating in the >> local maven repos of the builds (geoserver-main is 8GB...), as well as >> doing a pass of "clean" to remove the target folders, they are not needed >> after a build in any case. >> >> Yet, even with space, the release job kept on failing... on this step: >> >> [image: image.png] >> echo "Allowing azure to write in the distribution folder" >> chmod g+w distribution >> chmod -R g+w >> /var/lib/jenkins/jobs/geoserver-release/builds/$BUILD_NUMBER/archive/distribution >> >> This step does not make sense, because the archiving of the output is not >> yet done, it's part of the "post-build" actions, which do happen later. And >> yet, post build actions do not allow to run a shell so there is really >> no place to run it. >> >> I'm removing it in order to get the release done, the above should work >> as a backup... that said, I'm not sure that can work, but maybe it can be >> moved in a downstream build (talks about azure, I guess it's related to the >> windows installer build). >> >> Cheers >> Andrea >> >> == >> GeoServer Professional Services from the experts! >> >> Visit http://bit.ly/gs-services-us for more information. >> == >> >> Ing. Andrea Aime >> @geowolf >> Technical Lead >> >> GeoSolutions Group >> phone: +39 0584 962313 >> >> fax: +39 0584 1660272 >> >> mob: +39 339 8844549 >> >> https://www.geosolutionsgroup.com/ >> >> http://twitter.com/geosolutions_it >> >> --- >> >> Con riferimento alla normativa sul trattamento dei dati personali (Reg. >> UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si >> precisa che ogni circostanza inerente alla presente email (il suo >> contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è >> riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il >> messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra >> operazione è illecita. Le sarei comunque grato se potesse darmene notizia. >> >> This email is intended only for the person or entity to which it is >> addressed and may contain information that is privileged, confidential or >> otherwise protected from disclosure. We remind that - as provided by >> European Regulation 2016/679 “GDPR” - copying, dissemination or use of this >> e-mail or the information herein by anyone other than the intended >> recipient is prohibited. If you have received this email by mistake, please >> notify us immediately by telephone or e-mail >> > > > -- > > Regards, > > Andrea Aime > > == > GeoServer Professional Services from the experts! > > Visit http://bit.ly/gs-services-us for more information. > == > > Ing. Andrea Aime > @geowolf > Technical Lead > > GeoSolutions Group > phone: +39 0584 962313 > > fax: +39 0584 1660272 > > mob: +39 339 8844549 > > https://www.geosolutionsgroup.com/ > > http://twitter.com/geosolutions_it > > --- > > Con riferimento al
Re: [Geoserver-devel] Completing and Updating German translation
Thanks, applied and backported. -- Jody Garnett On Wed, 16 Nov 2022 at 22:13, Carsten Klein wrote: > Final PR #6359 *German Translation Overhaul Part 1* is now available and > all green. > > https://github.com/geoserver/geoserver/pull/6359 > > Please backport someone to 2.22.x, as I can't add any labels without repo > write access (thinking about requesting write access, as it could actually > make some things a bit easier). > > Cheers > Carsten > Am 16.11.2022 um 21:08 schrieb Carsten Klein: > > PR against main will be available tomorrow, 7:30 CET. I can't add labels, > so please, someone should kick off backports (2.22.x should be sufficient) > > Carsten > > > > Von meinem/meiner Galaxy gesendet > > > Ursprüngliche Nachricht > Von: Jody Garnett > Datum: 16.11.22 20:38 (GMT+01:00) > An: Carsten Klein > Cc: Marc Jansen , > geoserver-devel@lists.sourceforge.net > Betreff: Re: [Geoserver-devel] Completing and Updating German translation > > Andrea is starting the release process tomorrow with geotools; so please > make your PR and backport as soon as possible! > -- > Jody Garnett > > > On Wed, 16 Nov 2022 at 08:35, Carsten Klein wrote: > >> Hi there, >> >> now, theres a (local) PR in my repo to show, primarily to German >> translators, how I'm updating German translation. >> >> https://github.com/cklein05/geoserver/pull/2 >> >> I will soon add in a PR comment that describes, what's already finished >> and what not. Have a look at the changed files to get an idea of what my >> work is like. Feel free to comment... >> >> @Jody: I decided to call it "Preview-Layer" (Vorschau-Layer in German) in >> the context of an Earth Observation tree Layer Group and leave it >> "Main-Layer" (Hauptlayer in German) in the context of the GetCapabilities >> response. >> >> Google's translation seems like a wrongly written version of "top-most >> layer" :) >> >> @Jody: If my changes are acceptable, I will issue the same PR (more or >> less, maybe including some last small changes) against the official GS main >> branch tomorrow, so you are able to include it in the 2.22.0 release on >> Friday. Although it's not yet complete (maybe it will never be complete), >> its much better/more complete than before and, most important, the new >> messages on the welcome page have been translated successfully. >> >> Cheers >> Carsten >> Am 16.11.2022 um 16:50 schrieb Jody Garnett: >> >> >> > 2. Root Layer >>> > >>> > Inconsistently translated: >>> > >>> > "Hauptlayer" (in WMS global settings) >>> > "Wurzellayer" (in Layer Group Editor, type 'Earth Observetion Tree') >>> > >>> > I tend to use "Wurzellayer" (like in "Wurzelvereichnis"). Due to the >>> > double "ll", for better readability writing it with a hyphen >>> > "Wurzel-Layer" may be an option. Any suggestions? >>> > >>> >>> I do not like "Wurzellayer" or "Wurzel-Layer" (the longer I look at the >>> words the more odd the look). How about "Hauptlayer" (not a 100 % match) >>> or "Basislayer"? >>> >>> Hard to translate, TBH. >>> >> >> The root indicates it is the root of the tree data structure; however >> that is more a computer science idea/concept. >> >> If I explain the idea in english I indicate it is the top layer or the >> parent layer and all the other layers are children that inherit the values >> (such as the coordinate reference system list) from the top layer. >> >> Google translate gives me "Oberstelayer" for upper or uppermost - may be >> a good fit? >> >> >> ___ >> Geoserver-devel mailing >> listGeoserver-devel@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/geoserver-devel >> >> > > ___ > Geoserver-devel mailing > listGeoserver-devel@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/geoserver-devel > > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] Backport of [GEOS-10696] Allow configuration of Output Format types allowed in GetFeature
+1 And thanks for the new feature Joe -- Jody Garnett On Wed, 16 Nov 2022 at 08:52, Joseph Miller wrote: > I would like to do a backport of [GEOS-10696] Allow configuration of > Output Format types allowed in GetFeature ( > https://github.com/geoserver/geoserver/pull/6230 ) to 2.21. Note that I > plan on waiting until 2.22.0 has got from RC to final release beforehand. > > All of the settings for this feature default to off (in this case > GetFeature Output Type checking) and will result in no impact to previous > installations. > > Thanks, > Joe Miller > > ___ > Geoserver-devel mailing list > Geoserver-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geoserver-devel > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] Completing and Updating German translation
Andrea is starting the release process tomorrow with geotools; so please make your PR and backport as soon as possible! -- Jody Garnett On Wed, 16 Nov 2022 at 08:35, Carsten Klein wrote: > Hi there, > > now, theres a (local) PR in my repo to show, primarily to German > translators, how I'm updating German translation. > > https://github.com/cklein05/geoserver/pull/2 > > I will soon add in a PR comment that describes, what's already finished > and what not. Have a look at the changed files to get an idea of what my > work is like. Feel free to comment... > > @Jody: I decided to call it "Preview-Layer" (Vorschau-Layer in German) in > the context of an Earth Observation tree Layer Group and leave it > "Main-Layer" (Hauptlayer in German) in the context of the GetCapabilities > response. > > Google's translation seems like a wrongly written version of "top-most > layer" :) > > @Jody: If my changes are acceptable, I will issue the same PR (more or > less, maybe including some last small changes) against the official GS main > branch tomorrow, so you are able to include it in the 2.22.0 release on > Friday. Although it's not yet complete (maybe it will never be complete), > its much better/more complete than before and, most important, the new > messages on the welcome page have been translated successfully. > > Cheers > Carsten > Am 16.11.2022 um 16:50 schrieb Jody Garnett: > > > > 2. Root Layer >> > >> > Inconsistently translated: >> > >> > "Hauptlayer" (in WMS global settings) >> > "Wurzellayer" (in Layer Group Editor, type 'Earth Observetion Tree') >> > >> > I tend to use "Wurzellayer" (like in "Wurzelvereichnis"). Due to the >> > double "ll", for better readability writing it with a hyphen >> > "Wurzel-Layer" may be an option. Any suggestions? >> > >> >> I do not like "Wurzellayer" or "Wurzel-Layer" (the longer I look at the >> words the more odd the look). How about "Hauptlayer" (not a 100 % match) >> or "Basislayer"? >> >> Hard to translate, TBH. >> > > The root indicates it is the root of the tree data structure; however that > is more a computer science idea/concept. > > If I explain the idea in english I indicate it is the top layer or the > parent layer and all the other layers are children that inherit the values > (such as the coordinate reference system list) from the top layer. > > Google translate gives me "Oberstelayer" for upper or uppermost - may be a > good fit? > > > ___ > Geoserver-devel mailing > listGeoserver-devel@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/geoserver-devel > > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] Completing and Updating German translation
> > 2. Root Layer > > > > Inconsistently translated: > > > > "Hauptlayer" (in WMS global settings) > > "Wurzellayer" (in Layer Group Editor, type 'Earth Observetion Tree') > > > > I tend to use "Wurzellayer" (like in "Wurzelvereichnis"). Due to the > > double "ll", for better readability writing it with a hyphen > > "Wurzel-Layer" may be an option. Any suggestions? > > > > I do not like "Wurzellayer" or "Wurzel-Layer" (the longer I look at the > words the more odd the look). How about "Hauptlayer" (not a 100 % match) > or "Basislayer"? > > Hard to translate, TBH. > The root indicates it is the root of the tree data structure; however that is more a computer science idea/concept. If I explain the idea in english I indicate it is the top layer or the parent layer and all the other layers are children that inherit the values (such as the coordinate reference system list) from the top layer. Google translate gives me "Oberstelayer" for upper or uppermost - may be a good fit? ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] Release volunteer needed for Nov 18th timeframe
Andrea: Here is a fix https://github.com/geoserver/geoserver/pull/6333 for the bug encountered during testing. Same deal as with the recent "minimal" data directory issue - if the services are not named "WFS", "WMS", "WMTS" sections of the codebase fail to work. In this case it was DisabledServiceResourceFilter which was making the assumption about service naming. The fix is to add ServiceInfo.getType() so the codebase stops making assumptions about ServiceInfo.getName(). I plan to do one documentation update (screen snaps) prior to release; but I think we should be good to go. -- Jody Garnett On Wed, 9 Nov 2022 at 08:34, Jody Garnett wrote: > Thanks Andrea that is much appreciated. > > I am turning up some bugs today in testing, and we still do not have a > good answer on the linux logging issue; I expect we should make a jira > ticket and have it as a "known" issue for the release in the hopes of > learning more. > > Jody > > On Wed, Nov 9, 2022 at 8:25 AM Andrea Aime < > andrea.a...@geosolutionsgroup.com> wrote: > >> Hi Jody, >> me and Martha can work on it, if she's given enough credentials. See the >> other thread "Introducing Martha Nagginda" >> >> Cheers >> Andrea >> >> On Fri, Oct 28, 2022 at 4:47 PM Jody Garnett >> wrote: >> >>> The release schedule has been updated: >>> https://github.com/geoserver/geoserver/wiki/Release-Schedule >>> >>> We are seeking a release volunteer for November 18th release. This >>> 2.22.0 update should be a normal stable release, all the jobs are working >>> with the possible exception of windows-installer (which needs updated >>> credentials). The blog post is mostly cut and paste from the 2.22-RC (with >>> the addition of thanking volunteers for testing). >>> >>> The only special work should be adjusting 2.22.x to stable, and 2.21.x >>> branch to maintenance. >>> -- >>> -- >>> Jody Garnett >>> >> ___ >>> Geoserver-devel mailing list >>> Geoserver-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >>> >> >> >> -- >> >> Regards, >> >> Andrea Aime >> >> == >> GeoServer Professional Services from the experts! >> >> Visit http://bit.ly/gs-services-us for more information. >> == >> >> Ing. Andrea Aime >> @geowolf >> Technical Lead >> >> GeoSolutions Group >> phone: +39 0584 962313 >> >> fax: +39 0584 1660272 >> >> mob: +39 339 8844549 >> >> https://www.geosolutionsgroup.com/ >> >> http://twitter.com/geosolutions_it >> >> --- >> >> Con riferimento alla normativa sul trattamento dei dati personali (Reg. >> UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si >> precisa che ogni circostanza inerente alla presente email (il suo >> contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è >> riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il >> messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra >> operazione è illecita. Le sarei comunque grato se potesse darmene notizia. >> >> This email is intended only for the person or entity to which it is >> addressed and may contain information that is privileged, confidential or >> otherwise protected from disclosure. We remind that - as provided by >> European Regulation 2016/679 “GDPR” - copying, dissemination or use of this >> e-mail or the information herein by anyone other than the intended >> recipient is prohibited. If you have received this email by mistake, please >> notify us immediately by telephone or e-mail >> > -- > -- > Jody Garnett > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] so what transfix do we use?
Thank you very much :) I am watching the back port PR build now. Jody On Thu, Nov 10, 2022 at 12:22 AM Alexandre Gacon wrote: > I solved the encoding issues reported by the QA tests : I will communicate > to try to have more translations of the welcome page. > > Alexandre > > Le mer. 9 nov. 2022 à 20:57, Alexandre Gacon > a écrit : > >> Hi, >> >> I have tested again Transifex to check if the problems I observed last >> time have been solved: apparently it is the case. As a consequence I have >> updated the source on Transifex and push back a first batch of >> translations, including the ones for French for the new welcome page. >> >> If the PR succeeds, I will post a message on the Transifex group and on >> the user mailing list to ask for translation updates. >> >> For the moment I didn't add the resources for the new extensions of this >> release : I will try to add them this weekend. >> >> I still would like to move to weblate, at least to longer rely on a local >> computer to do the sync, but I have to find enough time to work on it. >> >> Regards >> Alexandre >> >> Le mer. 9 nov. 2022 à 16:03, Jody Garnett a >> écrit : >> >>> Release is scheduled for next week (nov 18). >>> >>> On Wed, Nov 9, 2022 at 4:14 AM Carsten Klein >>> wrote: >>> >>>> Jody, >>>> >>>> I will split this into two parts. First part is translating missing/not >>>> yet translated messages, including those for the welcome page you need for >>>> the 2.22.0 release. When is that release planned (aka, when do you need the >>>> messages ultimately?). Likely I'm not getting done with part #1 completely >>>> when you release 2.22.0 so, part #1 may be split into several PRs. >>>> >>>> Only after part #1 is done, I will start with revising already >>>> translated messages, which is part #2. Part #2 is about consistency, style >>>> and common IT wording. At least for my mind, some of the texts actually use >>>> quite uncommon IT wording... However, I will make a draft/proposal PR for >>>> part #2 and then, explicitly ask other German translators, what they think >>>> about it. >>>> >>>> Cheers >>>> >>>> >>>> Carsten >>>> Am 08.11.2022 um 17:12 schrieb Jody Garnett: >>>> >>>> Thanks Klein: >>>> >>>> I am waiting to hear back from Alexandre; although if you have any >>>> experience with weblate or transifx we welcome your input. >>>> >>>> Anything you can do to make the translations consistent and clear is >>>> appreciated. As the application changes over time you maybe able to spot >>>> places that can be improved that were not obvious to the original author. >>>> My guidance would be to look at the resulting user interface page and focus >>>> on making that clear; if you need to update some prior translations it is >>>> to be expected. >>>> >>>> You are also welcome to start an email thread on a specific translation >>>> challenge (making layer group consistent for example; or shortening label >>>> to fit UI). Even if folks do not respond today; they can find the topic >>>> later. >>>> -- >>>> Jody Garnett >>>> >>>> >>>> On Tue, 8 Nov 2022 at 06:16, Carsten Klein wrote: >>>> >>>>> Hello there, >>>>> >>>>> I've translated the new welcome page messages (e. g. >>>>> GeoServerHomePage.description[...]) into German. Like these as a separate >>>>> commit/PR? Or... >>>>> >>>>> I could also translate some more of the commented out messages in the >>>>> German locale files. >>>>> >>>>> Furthermore, I think about editing some of the existing German >>>>> messages... However, I don't want to tread on some other >>>>> dev's/translator's >>>>> toes by blaming his/her work... Any best practices known concerning such a >>>>> situation? >>>>> >>>>> Cheers >>>>> Carsten >>>>> Am 08.11.2022 um 07:46 schrieb Jody Garnett: >>>>> >>>>> Want to bump this message now that we are testing 2.22-RC release; it >>>>> would be good to have translations for the welcome page messages prior to >>>>> re
Re: [Geoserver-devel] [Geotools-devel] Introducing Martha Nagginda
Welcome Martha: Thanks for helping get releases out, we really appreciate the assistance. Andrea we are generally good at setting up release volunteers with credentials (relying on the honour system to avoid using their commit status). Indeed it is a great way to assist the community. Jody On Wed, Nov 9, 2022 at 5:55 AM Andrea Aime < andrea.a...@geosolutionsgroup.com> wrote: > Hi all, > I would like to introduce my colleague Martha. > Martha has been working on testing, automation and documentation in > projects using GeoServer. > > In the following months I'd like to have her help us perform the release > trains, including the Nov. 18th one (for the first time, I'll be > there assisting her, and perform the GWC release). > > As you know, to do that, she would need access to the build server, admin > access to Jira, and probably commit access to the repositories. Would that > be ok? > > Cheers > Andrea > > == > > GeoServer Professional Services from the experts! > > Visit http://bit.ly/gs-services-us for more information. > == > > Ing. Andrea Aime > @geowolf > Technical Lead > > GeoSolutions Group > phone: +39 0584 962313 > > fax: +39 0584 1660272 > > mob: +39 339 8844549 > > https://www.geosolutionsgroup.com/ > > http://twitter.com/geosolutions_it > > --- > > Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE > 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si > precisa che ogni circostanza inerente alla presente email (il suo > contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è > riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il > messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra > operazione è illecita. Le sarei comunque grato se potesse darmene notizia. > > This email is intended only for the person or entity to which it is > addressed and may contain information that is privileged, confidential or > otherwise protected from disclosure. We remind that - as provided by > European Regulation 2016/679 “GDPR” - copying, dissemination or use of this > e-mail or the information herein by anyone other than the intended > recipient is prohibited. If you have received this email by mistake, please > notify us immediately by telephone or e-mail > _______ > GeoTools-Devel mailing list > geotools-de...@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geotools-devel > -- -- Jody Garnett ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] Release volunteer needed for Nov 18th timeframe
Thanks Andrea that is much appreciated. I am turning up some bugs today in testing, and we still do not have a good answer on the linux logging issue; I expect we should make a jira ticket and have it as a "known" issue for the release in the hopes of learning more. Jody On Wed, Nov 9, 2022 at 8:25 AM Andrea Aime < andrea.a...@geosolutionsgroup.com> wrote: > Hi Jody, > me and Martha can work on it, if she's given enough credentials. See the > other thread "Introducing Martha Nagginda" > > Cheers > Andrea > > On Fri, Oct 28, 2022 at 4:47 PM Jody Garnett > wrote: > >> The release schedule has been updated: >> https://github.com/geoserver/geoserver/wiki/Release-Schedule >> >> We are seeking a release volunteer for November 18th release. This 2.22.0 >> update should be a normal stable release, all the jobs are working with the >> possible exception of windows-installer (which needs updated credentials). >> The blog post is mostly cut and paste from the 2.22-RC (with the addition >> of thanking volunteers for testing). >> >> The only special work should be adjusting 2.22.x to stable, and 2.21.x >> branch to maintenance. >> -- >> -- >> Jody Garnett >> > ___ >> Geoserver-devel mailing list >> Geoserver-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >> > > > -- > > Regards, > > Andrea Aime > > == > GeoServer Professional Services from the experts! > > Visit http://bit.ly/gs-services-us for more information. > == > > Ing. Andrea Aime > @geowolf > Technical Lead > > GeoSolutions Group > phone: +39 0584 962313 > > fax: +39 0584 1660272 > > mob: +39 339 8844549 > > https://www.geosolutionsgroup.com/ > > http://twitter.com/geosolutions_it > > --- > > Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE > 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si > precisa che ogni circostanza inerente alla presente email (il suo > contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è > riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il > messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra > operazione è illecita. Le sarei comunque grato se potesse darmene notizia. > > This email is intended only for the person or entity to which it is > addressed and may contain information that is privileged, confidential or > otherwise protected from disclosure. We remind that - as provided by > European Regulation 2016/679 “GDPR” - copying, dissemination or use of this > e-mail or the information herein by anyone other than the intended > recipient is prohibited. If you have received this email by mistake, please > notify us immediately by telephone or e-mail > -- -- Jody Garnett ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] so what transfix do we use?
Release is scheduled for next week (nov 18). On Wed, Nov 9, 2022 at 4:14 AM Carsten Klein wrote: > Jody, > > I will split this into two parts. First part is translating missing/not > yet translated messages, including those for the welcome page you need for > the 2.22.0 release. When is that release planned (aka, when do you need the > messages ultimately?). Likely I'm not getting done with part #1 completely > when you release 2.22.0 so, part #1 may be split into several PRs. > > Only after part #1 is done, I will start with revising already translated > messages, which is part #2. Part #2 is about consistency, style and common > IT wording. At least for my mind, some of the texts actually use quite > uncommon IT wording... However, I will make a draft/proposal PR for part #2 > and then, explicitly ask other German translators, what they think about it. > > Cheers > > > Carsten > Am 08.11.2022 um 17:12 schrieb Jody Garnett: > > Thanks Klein: > > I am waiting to hear back from Alexandre; although if you have any > experience with weblate or transifx we welcome your input. > > Anything you can do to make the translations consistent and clear is > appreciated. As the application changes over time you maybe able to spot > places that can be improved that were not obvious to the original author. > My guidance would be to look at the resulting user interface page and focus > on making that clear; if you need to update some prior translations it is > to be expected. > > You are also welcome to start an email thread on a specific translation > challenge (making layer group consistent for example; or shortening label > to fit UI). Even if folks do not respond today; they can find the topic > later. > -- > Jody Garnett > > > On Tue, 8 Nov 2022 at 06:16, Carsten Klein wrote: > >> Hello there, >> >> I've translated the new welcome page messages (e. g. >> GeoServerHomePage.description[...]) into German. Like these as a separate >> commit/PR? Or... >> >> I could also translate some more of the commented out messages in the >> German locale files. >> >> Furthermore, I think about editing some of the existing German >> messages... However, I don't want to tread on some other dev's/translator's >> toes by blaming his/her work... Any best practices known concerning such a >> situation? >> >> Cheers >> Carsten >> Am 08.11.2022 um 07:46 schrieb Jody Garnett: >> >> Want to bump this message now that we are testing 2.22-RC release; it >> would be good to have translations for the welcome page messages prior to >> release. >> -- >> Jody Garnett >> >> >> On Fri, 29 Jul 2022 at 12:46, Jody Garnett >> wrote: >> >>> My co-workers have given me some welcome page translations to fix for >>> "nl": >>> >>>- welcome => Welkom >>>- username => gebruikersnaam >>>- password => wachtwoord >>>- Remember me => Onthoud mij >>> >>> Checking https://explore.transifex.com/GeoServer/ shows three projects >>> all updated in the last month: >>> >>>- GeoServer - Updated 3 days ago >>>- GeoServer GitHub Integration • Updated 18 days ago >>>- GeoServer Stable • Updated 10 days ago >>> >>> Which is the correct one to use? Checking developers guide ... >>> >>> - https://docs.geoserver.org/latest/en/developer/translation.html says >>> https://www.transifex.com/GeoServer/geoserver-github-integration/dashboard/ >>> . >>> >>> However the geoserver-github-integration project was updated 18 days ago >>> (ie the oldest). Should we turn the others off if they are no longer in use? >>> -- >>> Jody Garnett >>> >> >> >> ___ >> Geoserver-devel mailing >> listGeoserver-devel@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/geoserver-devel >> >> -- -- Jody Garnett ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
[Geoserver-devel] [JIRA] (GEOS-10740) Service enabled does not respect minimal/custom service names
Jody Garnett ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae422bb7f-4808-47e3-837f-13db0e6681e3 ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiNzRhYzM3NmI2ODE1NDk0OGI2MGQxY2Y0ZmQ1OTRjYzciLCJwIjoiaiJ9 ) / Improvement ( https://osgeo-org.atlassian.net/browse/GEOS-10740?atlOrigin=eyJpIjoiNzRhYzM3NmI2ODE1NDk0OGI2MGQxY2Y0ZmQ1OTRjYzciLCJwIjoiaiJ9 ) GEOS-10740 ( https://osgeo-org.atlassian.net/browse/GEOS-10740?atlOrigin=eyJpIjoiNzRhYzM3NmI2ODE1NDk0OGI2MGQxY2Y0ZmQ1OTRjYzciLCJwIjoiaiJ9 ) Service enabled does not respect minimal/custom service names ( https://osgeo-org.atlassian.net/browse/GEOS-10740?atlOrigin=eyJpIjoiNzRhYzM3NmI2ODE1NDk0OGI2MGQxY2Y0ZmQ1OTRjYzciLCJwIjoiaiJ9 ) Issue Type: Improvement Affects Versions: 2.22-RC Assignee: Unassigned Components: Main, Security Created: 09/Nov/22 6:32 AM Priority: Medium Reporter: Jody Garnett ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae422bb7f-4808-47e3-837f-13db0e6681e3 ) Follow on to https://osgeo-org.atlassian.net/browse/GEOS-10702 ( https://osgeo-org.atlassian.net/browse/GEOS-10702 ) ; the same problem is found in other code that assumes service.getName() is a useful value. The root cause is the file contents being structured like: wms true GeoServer WMS GeoServer Web Map Service And code trying to check using *info.getName()* rather than *info.getId()* , as we learned apparently *info.getId()* is not especially safe either. *ServiceDescriptionProvider.isAvailable()* is checking *ServiceResourceProvider.getServicesForResource(layer)* and needs constant it can trust to check against. a) On review *getServicesForResource(layer)* checks if the ResourceInfo is compatible with the service and does not check if the service is enabled for the layer. b) Checking *ResourceInfo.getDisabledServices()* list; and it is called by *DisabledServiceResourceFilter* (which also provides an system property *org.geoserver.service.disabled* used disable services externally) ( https://osgeo-org.atlassian.net/browse/GEOS-10740#add-comment?atlOrigin=eyJpIjoiNzRhYzM3NmI2ODE1NDk0OGI2MGQxY2Y0ZmQ1OTRjYzciLCJwIjoiaiJ9 ) Add Comment ( https://osgeo-org.atlassian.net/browse/GEOS-10740#add-comment?atlOrigin=eyJpIjoiNzRhYzM3NmI2ODE1NDk0OGI2MGQxY2Y0ZmQ1OTRjYzciLCJwIjoiaiJ9 ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:ffe1a02 )___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
[Geoserver-devel] [JIRA] (GEOS-10739) Contact information user interface feedback for welcome message
Jody Garnett ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae422bb7f-4808-47e3-837f-13db0e6681e3 ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiMjdkYzIxMDExNzg5NDMwZjkzMTczOWM4YmZmMDQxMzMiLCJwIjoiaiJ9 ) / Improvement ( https://osgeo-org.atlassian.net/browse/GEOS-10739?atlOrigin=eyJpIjoiMjdkYzIxMDExNzg5NDMwZjkzMTczOWM4YmZmMDQxMzMiLCJwIjoiaiJ9 ) GEOS-10739 ( https://osgeo-org.atlassian.net/browse/GEOS-10739?atlOrigin=eyJpIjoiMjdkYzIxMDExNzg5NDMwZjkzMTczOWM4YmZmMDQxMzMiLCJwIjoiaiJ9 ) Contact information user interface feedback for welcome message ( https://osgeo-org.atlassian.net/browse/GEOS-10739?atlOrigin=eyJpIjoiMjdkYzIxMDExNzg5NDMwZjkzMTczOWM4YmZmMDQxMzMiLCJwIjoiaiJ9 ) Issue Type: Improvement Assignee: Unassigned Components: web, Wicket UI Created: 09/Nov/22 2:09 AM Priority: Medium Reporter: Jody Garnett ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae422bb7f-4808-47e3-837f-13db0e6681e3 ) As discussed in meeting and email list: * contact information welcome message should be a text area * workspace layout should be single column (to give workspace specific contact information more room) ( https://osgeo-org.atlassian.net/browse/GEOS-10739#add-comment?atlOrigin=eyJpIjoiMjdkYzIxMDExNzg5NDMwZjkzMTczOWM4YmZmMDQxMzMiLCJwIjoiaiJ9 ) Add Comment ( https://osgeo-org.atlassian.net/browse/GEOS-10739#add-comment?atlOrigin=eyJpIjoiMjdkYzIxMDExNzg5NDMwZjkzMTczOWM4YmZmMDQxMzMiLCJwIjoiaiJ9 ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:ffe1a02 )___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] so what transfix do we use?
Thanks Klein: I am waiting to hear back from Alexandre; although if you have any experience with weblate or transifx we welcome your input. Anything you can do to make the translations consistent and clear is appreciated. As the application changes over time you maybe able to spot places that can be improved that were not obvious to the original author. My guidance would be to look at the resulting user interface page and focus on making that clear; if you need to update some prior translations it is to be expected. You are also welcome to start an email thread on a specific translation challenge (making layer group consistent for example; or shortening label to fit UI). Even if folks do not respond today; they can find the topic later. -- Jody Garnett On Tue, 8 Nov 2022 at 06:16, Carsten Klein wrote: > Hello there, > > I've translated the new welcome page messages (e. g. > GeoServerHomePage.description[...]) into German. Like these as a separate > commit/PR? Or... > > I could also translate some more of the commented out messages in the > German locale files. > > Furthermore, I think about editing some of the existing German messages... > However, I don't want to tread on some other dev's/translator's toes by > blaming his/her work... Any best practices known concerning such a > situation? > > Cheers > Carsten > Am 08.11.2022 um 07:46 schrieb Jody Garnett: > > Want to bump this message now that we are testing 2.22-RC release; it > would be good to have translations for the welcome page messages prior to > release. > -- > Jody Garnett > > > On Fri, 29 Jul 2022 at 12:46, Jody Garnett wrote: > >> My co-workers have given me some welcome page translations to fix for >> "nl": >> >>- welcome => Welkom >>- username => gebruikersnaam >>- password => wachtwoord >>- Remember me => Onthoud mij >> >> Checking https://explore.transifex.com/GeoServer/ shows three projects >> all updated in the last month: >> >>- GeoServer - Updated 3 days ago >>- GeoServer GitHub Integration • Updated 18 days ago >>- GeoServer Stable • Updated 10 days ago >> >> Which is the correct one to use? Checking developers guide ... >> >> - https://docs.geoserver.org/latest/en/developer/translation.html says >> https://www.transifex.com/GeoServer/geoserver-github-integration/dashboard/ >> . >> >> However the geoserver-github-integration project was updated 18 days ago >> (ie the oldest). Should we turn the others off if they are no longer in use? >> -- >> Jody Garnett >> > > > ___ > Geoserver-devel mailing > listGeoserver-devel@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/geoserver-devel > > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] so what transfix do we use?
Alexandre:
We have our video meeting in 20 mins perhaps discuss there? I think weblate
would be a good way to go; but I am really not invested in the outcome
(only wish to assist folks in translating our software).
For the short term we have a release coming out with some strings that
really need translating - where can we change this?
GeoServerHomePage.belongsTo = For more information visit ${organization}.
GeoServerHomePage.footer= This GeoServer instance is
running version ${version}.
GeoServerHomePage.footerContact = Contact administrator.
GeoServerHomePage.serviceCapabilities = Service Capabilities
GeoServerHomePage.title = Welcome
GeoServerHomePage.descriptionGlobal = GeoServer Web Service, ${user}
access to ${workspaceCount} workspaces, with ${layerCount} layers.
GeoServerHomePage.descriptionGlobalOff = GeoServer, ${user} access. Select
a workspace or layer, above, to change to a virtual web service.
GeoServerHomePage.descriptionWorkspace = GeoServer Virtual Web Service,
${user} access to ${workspaceName} workspace, with
${layerCount} layers.
GeoServerHomePage.descriptionLayer = GeoServer Virtual Web Service,
${user} access to ${layerName} layer.
GeoServerHomePage.descriptionLayerGroup = GeoServer Virtual Web Service,
${user} access to ${layerName} layer group.
--
Jody Garnett
On Mon, 7 Nov 2022 at 23:05, Alexandre Gacon
wrote:
> Another Pros for weblate : there is a direct sync with GitHub so it is no
> longer required to use a local build to do the sync.
>
> Alexandre
>
> Le mar. 8 nov. 2022 à 07:58, Alexandre Gacon
> a écrit :
>
>> Hello Jody,
>>
>> On the translation side, I hesitate between two options:
>>
>>- Reopen the translation on Transifex after updating it
>> - Pros : all is in place, all translators have an account and know
>> how to use Transifex
>> - Cons : during the last sync, I got a lot of stuff introduced by
>> the automatic mechanisms of Transifex which I had to remove manually,
>> so I
>> fear the work to do to sync from Transifex to GitHub
>>- Use the OSGeo weblate instance for this translation
>> - Pros : no more relying on Transifex, use a OSGeo managed tool,
>> no automatic mechanisms you can't disable
>> - Cons : have to remove the duplicate languages (chinese in two
>> encoding styles), all translators must request an account to OSGeo, new
>> tool to discover, configuration to complete (I have done the
>> configuration
>> with my fork for all the core modules but not for the extensions)
>>
>> Any advice is welcomed
>>
>> Alexandre
>>
>>
>> Le mar. 8 nov. 2022 à 07:48, Jody Garnett a
>> écrit :
>>
>>> Want to bump this message now that we are testing 2.22-RC release; it
>>> would be good to have translations for the welcome page messages prior to
>>> release.
>>> --
>>> Jody Garnett
>>>
>>>
>>> On Fri, 29 Jul 2022 at 12:46, Jody Garnett
>>> wrote:
>>>
>>>> My co-workers have given me some welcome page translations to fix for
>>>> "nl":
>>>>
>>>>- welcome => Welkom
>>>>- username => gebruikersnaam
>>>>- password => wachtwoord
>>>>- Remember me => Onthoud mij
>>>>
>>>> Checking https://explore.transifex.com/GeoServer/ shows three projects
>>>> all updated in the last month:
>>>>
>>>>- GeoServer - Updated 3 days ago
>>>>- GeoServer GitHub Integration • Updated 18 days ago
>>>>- GeoServer Stable • Updated 10 days ago
>>>>
>>>> Which is the correct one to use? Checking developers guide ...
>>>>
>>>> - https://docs.geoserver.org/latest/en/developer/translation.html says
>>>> https://www.transifex.com/GeoServer/geoserver-github-integration/dashboard/
>>>> .
>>>>
>>>> However the geoserver-github-integration project was updated 18 days
>>>> ago (ie the oldest). Should we turn the others off if they are no longer in
>>>> use?
>>>> --
>>>> Jody Garnett
>>>>
>>> ___
>>> Geoserver-devel mailing list
>>> Geoserver-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>>>
>>
>>
>> --
>> Alexandre Gacon
>>
>
>
> --
> Alexandre Gacon
>
___
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] so what transfix do we use?
Want to bump this message now that we are testing 2.22-RC release; it would be good to have translations for the welcome page messages prior to release. -- Jody Garnett On Fri, 29 Jul 2022 at 12:46, Jody Garnett wrote: > My co-workers have given me some welcome page translations to fix for "nl": > >- welcome => Welkom >- username => gebruikersnaam >- password => wachtwoord >- Remember me => Onthoud mij > > Checking https://explore.transifex.com/GeoServer/ shows three projects > all updated in the last month: > >- GeoServer - Updated 3 days ago >- GeoServer GitHub Integration • Updated 18 days ago >- GeoServer Stable • Updated 10 days ago > > Which is the correct one to use? Checking developers guide ... > > - https://docs.geoserver.org/latest/en/developer/translation.html says > https://www.transifex.com/GeoServer/geoserver-github-integration/dashboard/ > . > > However the geoserver-github-integration project was updated 18 days ago > (ie the oldest). Should we turn the others off if they are no longer in use? > -- > Jody Garnett > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format
Comments inline: On Thu, 3 Nov 2022 at 00:16, Carsten Klein wrote: > Hello there, > > now the 2nd optimization of the new SpatialJSON format (Shared String > Table) is merged into main. Many thanks for that :-) > Must be this one https://github.com/geoserver/geoserver/pull/6320 > I have prepared two more single-commit PRs for porting back everything > to 2.22.x and 2.21.x. Before pushing these into my forked repo and > issuing the PRs, I'd like to ask how to do this correctly concerning > Jira tickets and, what Andrea mentioned recently, GeoServer's "Jira > ticket first" approach. > Since Jira tickets are required for adding stuff to the change log, I > guess having two tickets for these PRs is a good idea. After creating > the Jira ticket, I know its ticket number (e. g. GEOS-12345). How do I > link the the ticket with the PR? Is it just naming the PR [GEOS-12345] > ... whatever? Is it crucial to name the commit behind the PR > accordingly? What's technically required and what is best practice? > As recommended by Andrea I've issued a Jira ticket (GEOS-10708) for the > first PR of the new community module. However, it's still unassigned and > open. Will this ever be used for the change log? Get tickets "linked" to > a PR closed automatically? > Cleaning up: 1. Changed your PR title to: [GEOS-10708] SpatialJSON Shared String Table Feature 2. If the title has the pattern [GEOS-] when created a bot provides a link to the jira ticket, I added this by hand editing PR description 3. Added a link to the PR in the Jira ticket; using add web link 4. I added the backport labels for the backport bot to see, ... and it failed to backport as the community modules is not backported yet. > > Sorry for asking all that but, it's a quite complex system and new to me > (I'm doing this for the first time). I want to do it the right way now > and as well for future contributions, but still feel kind of lost... :-p > Thanks for asking for help; it got a little complicated to clean up ., > > Cheers > Carsten > > > -- > > Carsten Klein > Lead Software Engineer > > DataGis GmbH > > Johann-Strauß-Str. 26 > 70794 Filderstadt > GERMANY > > Phone: +49 7158 9490 106 > Fax: +49 7158 9490 111 > > E-Mail: c.kl...@datagis.com > Internet: www.datagis.com > > Commercial Register: Stuttgart, HRB 225945 > Management: Dr. Gunter Hahn, Markus Ruess, Carsten Klein > > > > ___ > Geoserver-devel mailing list > Geoserver-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geoserver-devel > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
[Geoserver-devel] [JIRA] (GEOS-10732) SpatialJSON Shared String Table
Jody Garnett ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae422bb7f-4808-47e3-837f-13db0e6681e3 ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiYTQ0MjJlYjUyNTY3NDkxZTllNjkzNDYwYzJjZTkxOTMiLCJwIjoiaiJ9 ) / New Feature ( https://osgeo-org.atlassian.net/browse/GEOS-10732?atlOrigin=eyJpIjoiYTQ0MjJlYjUyNTY3NDkxZTllNjkzNDYwYzJjZTkxOTMiLCJwIjoiaiJ9 ) GEOS-10732 ( https://osgeo-org.atlassian.net/browse/GEOS-10732?atlOrigin=eyJpIjoiYTQ0MjJlYjUyNTY3NDkxZTllNjkzNDYwYzJjZTkxOTMiLCJwIjoiaiJ9 ) SpatialJSON Shared String Table ( https://osgeo-org.atlassian.net/browse/GEOS-10732?atlOrigin=eyJpIjoiYTQ0MjJlYjUyNTY3NDkxZTllNjkzNDYwYzJjZTkxOTMiLCJwIjoiaiJ9 ) Issue Type: New Feature Affects Versions: 2.22-RC Assignee: Unassigned Components: Community modules Created: 03/Nov/22 3:56 PM Priority: Medium Reporter: Jody Garnett ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae422bb7f-4808-47e3-837f-13db0e6681e3 ) A SpatialJSON response *may* contain a Shared String Table , which *may* contain strings that are referenced by some features' properties. Only properties expressed as JSON strings can be stored in a shared string table (at current, temporal values, like Dates and Timestamps, which are expressed as strings as well, are not stored in a shared string table). ( https://osgeo-org.atlassian.net/browse/GEOS-10732#add-comment?atlOrigin=eyJpIjoiYTQ0MjJlYjUyNTY3NDkxZTllNjkzNDYwYzJjZTkxOTMiLCJwIjoiaiJ9 ) Add Comment ( https://osgeo-org.atlassian.net/browse/GEOS-10732#add-comment?atlOrigin=eyJpIjoiYTQ0MjJlYjUyNTY3NDkxZTllNjkzNDYwYzJjZTkxOTMiLCJwIjoiaiJ9 ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:a51bb46 )___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format
Klien: You should be able to add the label: backport-2.22.x, and backport-2.21.x to your PR and a bot will prep two new pull requests for you. When those are merged the original Jira ticket has the "fixed for" information update to indicate additional releases where the problem is fixed (2.22.0 and 2.21.4 or something). The procedure; such as it is; is to ask on your original pull request for the fix to be backported. If it is a fix it can be backported immediately; if it is a new feature we try and wait a month (for stability), or ask on the email list for an "early backport". -- Jody Garnett On Thu, 3 Nov 2022 at 00:16, Carsten Klein wrote: > Hello there, > > now the 2nd optimization of the new SpatialJSON format (Shared String > Table) is merged into main. Many thanks for that :-) > > I have prepared two more single-commit PRs for porting back everything > to 2.22.x and 2.21.x. Before pushing these into my forked repo and > issuing the PRs, I'd like to ask how to do this correctly concerning > Jira tickets and, what Andrea mentioned recently, GeoServer's "Jira > ticket first" approach. > > Since Jira tickets are required for adding stuff to the change log, I > guess having two tickets for these PRs is a good idea. After creating > the Jira ticket, I know its ticket number (e. g. GEOS-12345). How do I > link the the ticket with the PR? Is it just naming the PR [GEOS-12345] > ... whatever? Is it crucial to name the commit behind the PR > accordingly? What's technically required and what is best practice? > > As recommended by Andrea I've issued a Jira ticket (GEOS-10708) for the > first PR of the new community module. However, it's still unassigned and > open. Will this ever be used for the change log? Get tickets "linked" to > a PR closed automatically? > > Sorry for asking all that but, it's a quite complex system and new to me > (I'm doing this for the first time). I want to do it the right way now > and as well for future contributions, but still feel kind of lost... :-p > > Cheers > Carsten > > > -- > > Carsten Klein > Lead Software Engineer > > DataGis GmbH > > Johann-Strauß-Str. 26 > 70794 Filderstadt > GERMANY > > Phone: +49 7158 9490 106 > Fax: +49 7158 9490 111 > > E-Mail: c.kl...@datagis.com > Internet: www.datagis.com > > Commercial Register: Stuttgart, HRB 225945 > Management: Dr. Gunter Hahn, Markus Ruess, Carsten Klein > > > > ___ > Geoserver-devel mailing list > Geoserver-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geoserver-devel > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] Backport of [GEOS-10716] Build simple feature types schema using column descriptions if available
+1 Thanks for waiting for 2.22.0 release -- Jody Garnett On Mon, 31 Oct 2022 at 07:08, Joseph Miller wrote: > I would like to do a backport of [GEOS-10716] Build simple feature types > schema using column descriptions if available ( > https://github.com/geoserver/geoserver/pull/6315 ) to 2.21. Note that I > plan on waiting until 2.22.0 has gone from RC to final released beforehand. > > All of the settings for this feature default to off (in this case only > turning on the comment feature in Oracle) and will result in no impact to > previous installations. > > Thanks, > Joe Miller > ___ > Geoserver-devel mailing list > Geoserver-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geoserver-devel > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
[Geoserver-devel] Release volunteer needed for Nov 18th timeframe
The release schedule has been updated: https://github.com/geoserver/geoserver/wiki/Release-Schedule We are seeking a release volunteer for November 18th release. This 2.22.0 update should be a normal stable release, all the jobs are working with the possible exception of windows-installer (which needs updated credentials). The blog post is mostly cut and paste from the 2.22-RC (with the addition of thanking volunteers for testing). The only special work should be adjusting 2.22.x to stable, and 2.21.x branch to maintenance. -- -- Jody Garnett ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] (GEOS-10705) Loading missing resources creates unsolicited empty files
Yes it looks like an empty file should be created; the comments added to the top of the file probably form some instructions for use / customization. On Thu, Oct 27, 2022 at 5:21 AM Dieter Stüken - con terra GmbH via Geoserver-devel wrote: > Throwing an Exception seems to be the better solution, I think. > > So you can differ between an empty file and a not existing file. > > I discovered some possible bug at: > > > > > https://github.com/geoserver/geoserver/blob/main/src/main/src/main/java/org/geoserver/config/GeoServerPropertyConfigurer.java#L104 > > > > Here an IOException is expected if the file is missing. > > Currently an empty file is silently created and I think this was not > intended. > > > > If an IllegalStateException is thrown, it does not work well, too. > > This is the reason for [GEOS-10724]. > > > > I just try to find a unit test for > GeoServerPropertyConfigurer.loadProperties with missing files. > > > > The existence can also be checked before without depending on an > IOException. > > Should empty config files also be replaced here? > > > > Dieter. > > > > *Von:* Jody Garnett > *Gesendet:* Donnerstag, 27. Oktober 2022 01:22 > *An:* Dieter Stüken - con terra GmbH > *Cc:* geoserver-devel@lists.sourceforge.net > *Betreff:* Re: [Geoserver-devel] (GEOS-10705) Loading missing resources > creates unsolicited empty files > > > > Good discussion, feedback inline: > > > On Wed, 26 Oct 2022 at 03:13, Dieter Stüken - con terra GmbH via > Geoserver-devel wrote: > > The primary change (throwing an Exception for missing files) is quite > easy, but I found lots of unit tests failing thereafter. > > Some are quite easy to fix, others require some refactorings. > > > > So this is going to be a judgement call: > > - Is it more clear to have an exception (forcing client code to handle) or > runtime exception? > > - Is returning an empty inputstream going to be kinder / easier for code > to manage? > > > > I’m a bit in struggle with EchoParametersDao and RulesDao. Those commonly > use already opened InputStreams to read. > > Unfortunately it unclear who has to close them again and if try/resource > block can be used. > > > > > > > > In the context of GEOS-9882 the InputStream was turned into a > Supplier > > > https://github.com/geoserver/geoserver/commit/9a8e4c30#diff-4b4acded1754ed2027dfc585dcfe55d05348911be59e55624c70b65fb6a815bbR53 > <https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgeoserver%2Fgeoserver%2Fcommit%2F9a8e4c30%23diff-4b4acded1754ed2027dfc585dcfe55d05348911be59e55624c70b65fb6a815bbR53&data=05%7C01%7C%7Ca17399575fcf4142a46308dab7a8f61f%7C6e0bfede3fcb4518a16565dc14fe5620%7C0%7C0%7C638024233574733485%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=UZ7LiAmt5BGl1wO7XlmEEY%2BzFlST8nr7xyrm%2F%2B6fyiI%3D&reserved=0> > > > > May be this was related to: https://github.com/pmd/pmd/issues/3235 > <https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpmd%2Fpmd%2Fissues%2F3235&data=05%7C01%7C%7Ca17399575fcf4142a46308dab7a8f61f%7C6e0bfede3fcb4518a16565dc14fe5620%7C0%7C0%7C638024233574733485%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=1Ap2RhZ9jwGdxcBz2wtOEdmIDESKzaPTJGYGPQC5CDk%3D&reserved=0> > > > > I think the Resource must be forwarded down to the read function itself to > keep the try/catch block as small as possible. > > (Similar argument for OutputStream here) > > > > This is an example where returning an empty inputstream would smoothly > allow the existing code to function. The resulting stream.available() would > always return 0 producing the desired functionality. > > > > However I like your approach of using Resource in the method api: RulesDao > getRules() / RulesDao.saveOrUpdate() / deleteRules() ... > > > > I found, that the InputStream becomes necessary by TestSupport. doWork > only, which works on File instead of Resource. > > And here we find another try-resource block again. This shows, how fragile > it is to pass an open stream. > > > > That is a good one to fix; I was less concerned with the test cases using > Files/ > > > > Does it make sense to wrap the file using Files.asResource into a Resource > here? > > > > Yes, it is why the adaptor was created, to help test API in isolation. > > > > Anyway: is the URL returned by Class.getResource always a File if it comes > from a JAR instead? > > > > I think it is when working w
Re: [Geoserver-devel] (GEOS-10705) Loading missing resources creates unsolicited empty files
Good discussion, feedback inline: On Wed, 26 Oct 2022 at 03:13, Dieter Stüken - con terra GmbH via Geoserver-devel wrote: > The primary change (throwing an Exception for missing files) is quite > easy, but I found lots of unit tests failing thereafter. > > Some are quite easy to fix, others require some refactorings. > So this is going to be a judgement call: - Is it more clear to have an exception (forcing client code to handle) or runtime exception? - Is returning an empty inputstream going to be kinder / easier for code to manage? > I’m a bit in struggle with EchoParametersDao and RulesDao. Those commonly > use already opened InputStreams to read. > > Unfortunately it unclear who has to close them again and if try/resource > block can be used. > > > > In the context of GEOS-9882 the InputStream was turned into a > Supplier > > > https://github.com/geoserver/geoserver/commit/9a8e4c30#diff-4b4acded1754ed2027dfc585dcfe55d05348911be59e55624c70b65fb6a815bbR53 > > > > May be this was related to: https://github.com/pmd/pmd/issues/3235 > > > > I think the Resource must be forwarded down to the read function itself to > keep the try/catch block as small as possible. > > (Similar argument for OutputStream here) > This is an example where returning an empty inputstream would smoothly allow the existing code to function. The resulting stream.available() would always return 0 producing the desired functionality. However I like your approach of using Resource in the method api: RulesDao getRules() / RulesDao.saveOrUpdate() / deleteRules() ... I found, that the InputStream becomes necessary by TestSupport. doWork > only, which works on File instead of Resource. > > And here we find another try-resource block again. This shows, how fragile > it is to pass an open stream. > That is a good one to fix; I was less concerned with the test cases using Files/ Does it make sense to wrap the file using Files.asResource into a Resource > here? > Yes, it is why the adaptor was created, to help test API in isolation. > Anyway: is the URL returned by Class.getResource always a File if it comes > from a JAR instead? > I think it is when working with resources from your own module; but when working with resources from a jar it is best to use the GeoTools TestSupport class (which can unpack jar resources into a tmp file if needed). > I think It’s worth to open a separate subtask to refactor this at first. > > Agreed, thanks for digging into this Dieter it is a good maintenance activity that will benefit the codebase. Jody > > > Dieter. > > *Von:* Jody Garnett > *Gesendet:* Freitag, 21. Oktober 2022 21:58 > *An:* Dieter Stüken - con terra GmbH > *Cc:* GeoServer > *Betreff:* Re: [Geoserver-devel] (GEOS-10705) Loading missing resources > creates unsolicited empty files > > > > It is worth proposing a refactoring here. > > > > The guideline during the api developement was to optimize for the most > common patterns of File usage we found in the codebase; and utillity > methods such as in() for common usage patterns. Where possible we provided > method name compatibility so it would be easier to migrate code from File > to Resource. > > > > I was expecting far more input on this API when it was first introduced; > your input is welcome now. > > > > For the specific example you show: > > - in() should not accidentally create a file for UNDEFINED > > - returning an empty input stream would be okay - less for client code to > handle. I understand that failed parsing expression is not so fun > > - throwing UncheckedIOException is okay - concerned it would lead to a > bunch of boiler plate code try / catch being introduced > > > > Since we have the whole codebase available it should be easy to access > what this change would require and answer the concerns above. > > > > Whatever change is made I ask that the javadocs be clearly updated. > > -- > > Jody > > > > On Fri, Oct 21, 2022 at 12:03 PM Dieter Stüken - con terra GmbH via > Geoserver-devel wrote: > > Hi dev list, > > I frequently noticed, that Resource.in() just creates non existing files > and then returns an empty input stream. This almost ever causes further > problems like https://github.com/geoserver/geoserver/pull/6216 > <https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgeoserver%2Fgeoserver%2Fpull%2F6216&data=05%7C01%7C%7C2e008cb088634d28236808dab39e8a6a%7C6e0bfede3fcb4518a16565dc14fe5620%7C0%7C0%7C638019790762577204%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000%7C%7C%7C&sdata=WS6HiPOGG7gg6E4SsnCg07apkqnWcU%2Bs04%2BSpwky9qQ%3D&
Re: [Geoserver-devel] GSIP-215 Drop Java 8
Thanks torben; and that suddenly makes sense - that the PR was coming from a `main` branch and causing concern -- Jody Garnett On Tue, 25 Oct 2022 at 09:33, Torben Barsballe wrote: > Hi Jody, > > I think I see what's going on here. > > On Fri, Oct 21, 2022 at 7:22 PM Jody Garnett > wrote: > >> >> - >> https://github.com/geoserver/geoserver/commit/261f221d455f71055faa1209411415a47cfd5b6a >> merge main into main? Showing no files changed locally; but many files >> changed in the github UI ... >> >> I am not sure what to make of it; and do not wish to revert; or force >> push; without a better understanding of what is going on. >> > > That looks to be a merge of geoserver:main into euanmitchell:main > <https://github.com/euanmitchell/geoserver> (the source of the PR). I > assume that remote was rather behind geoserver:main at the time of the > merge, which would explain the large number of changes for that commit, and > the relatively few number of actual changes relative to geoserver:main > > So, things are probably fine? > > Cheers, > Torben > > >> -- >> Jody >> -- >> Jody Garnett >> >> >> On Mon, 19 Sept 2022 at 14:29, Jody Garnett >> wrote: >> >>> Thanks Jukka, updated the page. >>> -- >>> Jody Garnett >>> >>> >>> On Mon, 19 Sept 2022 at 10:21, Rahkonen Jukka < >>> jukka.rahko...@maanmittauslaitos.fi> wrote: >>> >>>> Hi, >>>> >>>> >>>> >>>> I sent also my +1 that was meant to mean for 2.23 only on August 31. >>>> >>>> >>>> >>>> -Jukka- >>>> >>>> >>>> >>>> *Lähettäjä:* Jody Garnett >>>> *Lähetetty:* maanantai 19. syyskuuta 2022 19.06 >>>> *Vastaanottaja:* GeoServer >>>> *Aihe:* Re: [Geoserver-devel] GSIP-215 Drop Java 8 >>>> >>>> >>>> >>>> I think this proposal is now ready to be accepted? (Note it was updated >>>> to indicate 2.23.0 timeframe) >>>> >>>> >>>> >>>> Project Steering Committee: >>>> >>>> * Alessio Fabiani: >>>> * Andrea Aime: +1 (2.23.0 only) >>>> * Ian Turton: +1 (2.22.0 or 2.23.0) >>>> * Jody Garnett: +1 (2.22.0 or 2.23.0) >>>> * Jukka Rahkonen: >>>> * Kevin Smith: +1 >>>> * Simone Giannecchini: >>>> * Torben Barsballe: +1 >>>> * Nuno Oliveira: +1 >>>> >>>> Community support: >>>> >>>> * Fernando Mino: +1 >>>> >>>> >>>> -- >>>> >>>> Jody Garnett >>>> >>>> >>>> >>>> >>>> >>>> On Tue, 30 Aug 2022 at 11:14, Jody Garnett >>>> wrote: >>>> >>>> Please see https://github.com/geoserver/geoserver/wiki/GSIP-215 >>>> <https://eur06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgeoserver%2Fgeoserver%2Fwiki%2FGSIP-215&data=05%7C01%7Cjukka.rahkonen%40maanmittauslaitos.fi%7C7510e1b877cf48e6919a08da9a590afe%7Cc4f8a63255804a1c92371d5a571b71fa%7C0%7C0%7C637992004474975321%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=QbEZTem54CnNZm59GpvWPLz7G6nKWeR8FJ19Rlg0BNY%3D&reserved=0> >>>> for details, general idea is to drop Java 8 support so we can update >>>> dependencies and plan Jakarta migration. >>>> >>>> >>>> >>>> Thanks to foss4g code sprint and Euan Mitchell for initial pull request >>>> for docs: >>>> >>>> - https://github.com/geoserver/geoserver/pull/6137 >>>> <https://eur06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgeoserver%2Fgeoserver%2Fpull%2F6137&data=05%7C01%7Cjukka.rahkonen%40maanmittauslaitos.fi%7C7510e1b877cf48e6919a08da9a590afe%7Cc4f8a63255804a1c92371d5a571b71fa%7C0%7C0%7C637992004474975321%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=ZLh7BsgCQcwHjgdDujzxp%2BSl3ZHAZNqDjwo%2BAAROXWI%3D&reserved=0> >>>> >>>> >>>> >>>> >>>> If this proposal is ready for the 2.22.0 release it would simplify the >>>> process of setting up build jobs for the new release cycle. Vote early, >>>> vote often... >>>> >>>> -- >>>> >>>> Jody Garnett >>>> >>>> ___ >> Geoserver-devel mailing list >> Geoserver-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >> > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
[Geoserver-devel] [JIRA] (GEOS-10722) WFS geopackage output extension failing to encode MDSYS.SDO_GEOMETRY
Jody Garnett ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae422bb7f-4808-47e3-837f-13db0e6681e3 ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiYWEyZDY1MzM5ZDVhNDcwMDk0MzZlM2VhMTczOTFkOWIiLCJwIjoiaiJ9 ) / Task ( https://osgeo-org.atlassian.net/browse/GEOS-10722?atlOrigin=eyJpIjoiYWEyZDY1MzM5ZDVhNDcwMDk0MzZlM2VhMTczOTFkOWIiLCJwIjoiaiJ9 ) GEOS-10722 ( https://osgeo-org.atlassian.net/browse/GEOS-10722?atlOrigin=eyJpIjoiYWEyZDY1MzM5ZDVhNDcwMDk0MzZlM2VhMTczOTFkOWIiLCJwIjoiaiJ9 ) WFS geopackage output extension failing to encode MDSYS.SDO_GEOMETRY ( https://osgeo-org.atlassian.net/browse/GEOS-10722?atlOrigin=eyJpIjoiYWEyZDY1MzM5ZDVhNDcwMDk0MzZlM2VhMTczOTFkOWIiLCJwIjoiaiJ9 ) Issue Type: Task Assignee: Unassigned Created: 25/Oct/22 6:27 PM Priority: Medium Reporter: Jody Garnett ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae422bb7f-4808-47e3-837f-13db0e6681e3 ) ( https://osgeo-org.atlassian.net/browse/GEOS-10722#add-comment?atlOrigin=eyJpIjoiYWEyZDY1MzM5ZDVhNDcwMDk0MzZlM2VhMTczOTFkOWIiLCJwIjoiaiJ9 ) Add Comment ( https://osgeo-org.atlassian.net/browse/GEOS-10722#add-comment?atlOrigin=eyJpIjoiYWEyZDY1MzM5ZDVhNDcwMDk0MzZlM2VhMTczOTFkOWIiLCJwIjoiaiJ9 ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100209- sha1:9aa9d1d )___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] geoserver 2.21.2 available for preflight testing
Release is up: https://geoserver.org/announcements/vulnerability/2022/10/24/geoserver-2-21-2-released.html - Docker uploading now ... - Windows installer ... in process? -- Jody Garnett On Sun, 23 Oct 2022 at 08:00, Jody Garnett wrote: > The bin download checks out okay; the readme / running / license files are > present as expected. > -- > Jody Garnett > > > On Sat, 22 Oct 2022 at 22:27, Jody Garnett wrote: > >> Build server artifacts here: >> - >> https://build.geoserver.org/view/release/job/geoserver-release/lastSuccessfulBuild/artifact/distribution/2.21.2/ >> >> The associated blog post is here >> https://github.com/geoserver/geoserver.github.io/pull/135 (thanks to >> Brad for initial review). >> >> This is a stable release which is thus far un-eventful. I am still having >> trouble with geowebcache updating or restoring version numbers and end up >> checking the result by hand and introducing additional commits if needed. >> -- >> Jody Garnett >> > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] geoserver 2.21.2 available for preflight testing
The bin download checks out okay; the readme / running / license files are present as expected. -- Jody Garnett On Sat, 22 Oct 2022 at 22:27, Jody Garnett wrote: > Build server artifacts here: > - > https://build.geoserver.org/view/release/job/geoserver-release/lastSuccessfulBuild/artifact/distribution/2.21.2/ > > The associated blog post is here > https://github.com/geoserver/geoserver.github.io/pull/135 (thanks to Brad > for initial review). > > This is a stable release which is thus far un-eventful. I am still having > trouble with geowebcache updating or restoring version numbers and end up > checking the result by hand and introducing additional commits if needed. > -- > Jody Garnett > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
[Geoserver-devel] geoserver 2.21.2 available for preflight testing
Build server artifacts here: - https://build.geoserver.org/view/release/job/geoserver-release/lastSuccessfulBuild/artifact/distribution/2.21.2/ The associated blog post is here https://github.com/geoserver/geoserver.github.io/pull/135 (thanks to Brad for initial review). This is a stable release which is thus far un-eventful. I am still having trouble with geowebcache updating or restoring version numbers and end up checking the result by hand and introducing additional commits if needed. -- Jody Garnett ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] Release train starting for 2.21.x
Release artifacts are available for pre-flight testing: - https://build.geoserver.org/view/release/job/geotools-release/70/artifact/build/release/distribution/27.2/ -- Jody Garnett On Thu, 20 Oct 2022 at 07:17, Jody Garnett wrote: > With the RC out of the way; I still have some customers waiting on a > stable release for security improvements. > > Is it okay if I make a 2.21.x release? That way we still get a stable > release for October here. > > Jody > -- > -- > Jody Garnett > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] Release train starting for 2.21.x
Sounds good Ian, please make the change as a suggestion to the PR and it should go in :) -- Jody Garnett On Sat, 22 Oct 2022 at 10:28, Ian Turton wrote: > > > On Sat, 22 Oct 2022, 17:23 Jody Garnett, wrote: > >> We do not have a ticket for it (since we were not affected). >> > > Well we do have a ticket, it just doesn't mention the cve. I've answered > one question on the security list and one on gis.se so people seem > worried about it. > > > >> I think I am against reporting CVEs from dependencies where our software >> is not affected. It just adds "noise". I would prefer when we have a >> security vulnerability section that everyone take it seriously and >> upgrade >> >> What do you think? >> > > Since we do use the effected jar it is probably worth mentioning in the > release notes. > > Ian > >> >> Jody >> >> On Sat, Oct 22, 2022 at 3:01 AM Ian Turton wrote: >> >>> Do we want to mention the CVE-2022-42889 >>> <https://nvd.nist.gov/vuln/detail/CVE-2022-42889> vulnerability, that >>> doesn't actually affect us and is now patched anyway? >>> >>> Ian >>> >>> On Sat, 22 Oct 2022 at 04:52, Jody Garnett >>> wrote: >>> >>>> Here is draft blog post while we wait for build process: >>>> https://github.com/geoserver/geoserver.github.io/pull/135 >>>> >>>> Okay, gather the bits for release: >>>> >>>>- Security hiding layer groups: >>>>https://github.com/geoserver/geoserver/pull/6290 (done) >>>>- Windows installer needs assembly changes backport >>>>https://github.com/geoserver/geoserver/pull/6291 (done) >>>> - aside: Noticed many of the assembles try and gather >>>> src/release/RELEASE_NOTES.txt >>>> >>>> <https://github.com/geoserver/geoserver/blob/2.13.x/src/release/RELEASE_NOTES.txt> >>>> ... which has not been present since 2.13.x >>>>- Did a round up of other backports, we should be good ... >>>> >>>> -- >>>> Jody Garnett >>>> >>>> >>>> On Thu, 20 Oct 2022 at 07:17, Jody Garnett >>>> wrote: >>>> >>>>> With the RC out of the way; I still have some customers waiting on a >>>>> stable release for security improvements. >>>>> >>>>> Is it okay if I make a 2.21.x release? That way we still get a stable >>>>> release for October here. >>>>> >>>>> Jody >>>>> -- >>>>> -- >>>>> Jody Garnett >>>>> >>>> ___ >>> >>> >>>> Geoserver-devel mailing list >>>> Geoserver-devel@lists.sourceforge.net >>>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >>>> >>> >>> >>> -- >>> Ian Turton >>> >> -- >> -- >> Jody Garnett >> > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] Release train starting for 2.21.x
We do not have a ticket for it (since we were not affected). I think I am against reporting CVEs from dependencies where our software is not affected. It just adds "noise". I would prefer when we have a security vulnerability section that everyone take it seriously and upgrade What do you think? Jody On Sat, Oct 22, 2022 at 3:01 AM Ian Turton wrote: > Do we want to mention the CVE-2022-42889 > <https://nvd.nist.gov/vuln/detail/CVE-2022-42889> vulnerability, that > doesn't actually affect us and is now patched anyway? > > Ian > > On Sat, 22 Oct 2022 at 04:52, Jody Garnett wrote: > >> Here is draft blog post while we wait for build process: >> https://github.com/geoserver/geoserver.github.io/pull/135 >> >> Okay, gather the bits for release: >> >>- Security hiding layer groups: >>https://github.com/geoserver/geoserver/pull/6290 (done) >>- Windows installer needs assembly changes backport >>https://github.com/geoserver/geoserver/pull/6291 (done) >> - aside: Noticed many of the assembles try and gather >> src/release/RELEASE_NOTES.txt >> >> <https://github.com/geoserver/geoserver/blob/2.13.x/src/release/RELEASE_NOTES.txt> >> ... which has not been present since 2.13.x >>- Did a round up of other backports, we should be good ... >> >> -- >> Jody Garnett >> >> >> On Thu, 20 Oct 2022 at 07:17, Jody Garnett >> wrote: >> >>> With the RC out of the way; I still have some customers waiting on a >>> stable release for security improvements. >>> >>> Is it okay if I make a 2.21.x release? That way we still get a stable >>> release for October here. >>> >>> Jody >>> -- >>> -- >>> Jody Garnett >>> >> ___ > > >> Geoserver-devel mailing list >> Geoserver-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >> > > > -- > Ian Turton > -- -- Jody Garnett ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] Release train starting for 2.21.x
Here is draft blog post while we wait for build process: https://github.com/geoserver/geoserver.github.io/pull/135 Okay, gather the bits for release: - Security hiding layer groups: https://github.com/geoserver/geoserver/pull/6290 (done) - Windows installer needs assembly changes backport https://github.com/geoserver/geoserver/pull/6291 (done) - aside: Noticed many of the assembles try and gather src/release/RELEASE_NOTES.txt <https://github.com/geoserver/geoserver/blob/2.13.x/src/release/RELEASE_NOTES.txt> ... which has not been present since 2.13.x - Did a round up of other backports, we should be good ... -- Jody Garnett On Thu, 20 Oct 2022 at 07:17, Jody Garnett wrote: > With the RC out of the way; I still have some customers waiting on a > stable release for security improvements. > > Is it okay if I make a 2.21.x release? That way we still get a stable > release for October here. > > Jody > -- > -- > Jody Garnett > ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] GSIP-215 Drop Java 8
The build server only sees a small number of files changed: https://build.geoserver.org/view/geoserver/job/geoserver-main/1358/changes Summary 1. [GEOS-10638] drop Java 8 support from docs (details) 2. Remove java 8 reference from developers guide (details) *Commit 6fdd602bcb3cffc66f80f22ef3c93b2a84a3c606 by Jody Garnett* [GEOS-10638] drop Java 8 support from docs The file was modified doc/en/user/source/configuration/status.rst (diff) The file was modified doc/en/user/source/production/java.rst (diff) The file was modified doc/en/user/source/security/passwd.rst (diff) The file was modified doc/en/user/source/installation/index.rst (diff) The file was modified doc/en/user/source/installation/war.rst (diff) The file was modified doc/en/user/source/installation/win_binary.rst (diff) The file was modified doc/en/user/source/installation/win_installer.rst (diff) The file was modified doc/en/user/source/installation/linux.rst (diff) The file was modified doc/en/user/source/production/container.rst (diff) *Commit 21fa400de4fb43fd8c26dda8dd4f18f45b98d4fc by Jody Garnett* Remove java 8 reference from developers guide The file was modified doc/en/developer/source/tools.rst (diff) The file was modified doc/en/developer/source/qa-guide/index.rst (diff) So I hope everything is okay -- Jody Garnett On Fri, 21 Oct 2022 at 19:20, Jody Garnett wrote: > I merged the initial PR now that the proposal is approved and the RC is > out. > > - https://github.com/geoserver/geoserver/pull/6137 > > And tried the github resolves the conflict thing ... and now have regrests: > > 1. There was one conflict on one documentation page due to a new section > on paramertized security > 2. Resolving the conflict indicated it would be a commitment to main ... > which I took to mean the PR would be merged... > 3. The commit history locally shows two merge commits and everything seems > okay... > 4. However ... the commit history in github shows: > - > https://github.com/geoserver/geoserver/commit/2565aaaca34e652770e4d6077d20881f34762db8 > clean merge commit updating the docs as expected > - > https://github.com/geoserver/geoserver/commit/261f221d455f71055faa1209411415a47cfd5b6a > merge main into main? Showing no files changed locally; but many files > changed in the github UI ... > > I am not sure what to make of it; and do not wish to revert; or force > push; without a better understanding of what is going on. > -- > Jody > -- > Jody Garnett > > > On Mon, 19 Sept 2022 at 14:29, Jody Garnett > wrote: > >> Thanks Jukka, updated the page. >> -- >> Jody Garnett >> >> >> On Mon, 19 Sept 2022 at 10:21, Rahkonen Jukka < >> jukka.rahko...@maanmittauslaitos.fi> wrote: >> >>> Hi, >>> >>> >>> >>> I sent also my +1 that was meant to mean for 2.23 only on August 31. >>> >>> >>> >>> -Jukka- >>> >>> >>> >>> *Lähettäjä:* Jody Garnett >>> *Lähetetty:* maanantai 19. syyskuuta 2022 19.06 >>> *Vastaanottaja:* GeoServer >>> *Aihe:* Re: [Geoserver-devel] GSIP-215 Drop Java 8 >>> >>> >>> >>> I think this proposal is now ready to be accepted? (Note it was updated >>> to indicate 2.23.0 timeframe) >>> >>> >>> >>> Project Steering Committee: >>> >>> * Alessio Fabiani: >>> * Andrea Aime: +1 (2.23.0 only) >>> * Ian Turton: +1 (2.22.0 or 2.23.0) >>> * Jody Garnett: +1 (2.22.0 or 2.23.0) >>> * Jukka Rahkonen: >>> * Kevin Smith: +1 >>> * Simone Giannecchini: >>> * Torben Barsballe: +1 >>> * Nuno Oliveira: +1 >>> >>> Community support: >>> >>> * Fernando Mino: +1 >>> >>> >>> -- >>> >>> Jody Garnett >>> >>> >>> >>> >>> >>> On Tue, 30 Aug 2022 at 11:14, Jody Garnett >>> wrote: >>> >>> Please see https://github.com/geoserver/geoserver/wiki/GSIP-215 >>> <https://eur06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgeoserver%2Fgeoserver%2Fwiki%2FGSIP-215&data=05%7C01%7Cjukka.rahkonen%40maanmittauslaitos.fi%7C7510e1b877cf48e6919a08da9a590afe%7Cc4f8a63255804a1c92371d5a571b71fa%7C0%7C0%7C637992004474975321%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=QbEZTem54CnNZm59GpvWPLz7G6nKWeR8FJ19Rlg0BNY%3D&reserved=0> >>> for details, general idea is to drop Java 8 support so we can update >>> dependencies and plan Jakarta migration. >>> >>> >>> >>> Thanks to foss4g code sprint and Euan Mit
Re: [Geoserver-devel] GSIP-215 Drop Java 8
I merged the initial PR now that the proposal is approved and the RC is out. - https://github.com/geoserver/geoserver/pull/6137 And tried the github resolves the conflict thing ... and now have regrests: 1. There was one conflict on one documentation page due to a new section on paramertized security 2. Resolving the conflict indicated it would be a commitment to main ... which I took to mean the PR would be merged... 3. The commit history locally shows two merge commits and everything seems okay... 4. However ... the commit history in github shows: - https://github.com/geoserver/geoserver/commit/2565aaaca34e652770e4d6077d20881f34762db8 clean merge commit updating the docs as expected - https://github.com/geoserver/geoserver/commit/261f221d455f71055faa1209411415a47cfd5b6a merge main into main? Showing no files changed locally; but many files changed in the github UI ... I am not sure what to make of it; and do not wish to revert; or force push; without a better understanding of what is going on. -- Jody -- Jody Garnett On Mon, 19 Sept 2022 at 14:29, Jody Garnett wrote: > Thanks Jukka, updated the page. > -- > Jody Garnett > > > On Mon, 19 Sept 2022 at 10:21, Rahkonen Jukka < > jukka.rahko...@maanmittauslaitos.fi> wrote: > >> Hi, >> >> >> >> I sent also my +1 that was meant to mean for 2.23 only on August 31. >> >> >> >> -Jukka- >> >> >> >> *Lähettäjä:* Jody Garnett >> *Lähetetty:* maanantai 19. syyskuuta 2022 19.06 >> *Vastaanottaja:* GeoServer >> *Aihe:* Re: [Geoserver-devel] GSIP-215 Drop Java 8 >> >> >> >> I think this proposal is now ready to be accepted? (Note it was updated >> to indicate 2.23.0 timeframe) >> >> >> >> Project Steering Committee: >> >> * Alessio Fabiani: >> * Andrea Aime: +1 (2.23.0 only) >> * Ian Turton: +1 (2.22.0 or 2.23.0) >> * Jody Garnett: +1 (2.22.0 or 2.23.0) >> * Jukka Rahkonen: >> * Kevin Smith: +1 >> * Simone Giannecchini: >> * Torben Barsballe: +1 >> * Nuno Oliveira: +1 >> >> Community support: >> >> * Fernando Mino: +1 >> >> >> -- >> >> Jody Garnett >> >> >> >> >> >> On Tue, 30 Aug 2022 at 11:14, Jody Garnett >> wrote: >> >> Please see https://github.com/geoserver/geoserver/wiki/GSIP-215 >> <https://eur06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgeoserver%2Fgeoserver%2Fwiki%2FGSIP-215&data=05%7C01%7Cjukka.rahkonen%40maanmittauslaitos.fi%7C7510e1b877cf48e6919a08da9a590afe%7Cc4f8a63255804a1c92371d5a571b71fa%7C0%7C0%7C637992004474975321%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=QbEZTem54CnNZm59GpvWPLz7G6nKWeR8FJ19Rlg0BNY%3D&reserved=0> >> for details, general idea is to drop Java 8 support so we can update >> dependencies and plan Jakarta migration. >> >> >> >> Thanks to foss4g code sprint and Euan Mitchell for initial pull request >> for docs: >> >> - https://github.com/geoserver/geoserver/pull/6137 >> <https://eur06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgeoserver%2Fgeoserver%2Fpull%2F6137&data=05%7C01%7Cjukka.rahkonen%40maanmittauslaitos.fi%7C7510e1b877cf48e6919a08da9a590afe%7Cc4f8a63255804a1c92371d5a571b71fa%7C0%7C0%7C637992004474975321%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=ZLh7BsgCQcwHjgdDujzxp%2BSl3ZHAZNqDjwo%2BAAROXWI%3D&reserved=0> >> >> >> >> >> If this proposal is ready for the 2.22.0 release it would simplify the >> process of setting up build jobs for the new release cycle. Vote early, >> vote often... >> >> -- >> >> Jody Garnett >> >> ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] (GEOS-10705) Loading missing resources creates unsolicited empty files
It is worth proposing a refactoring here.
The guideline during the api developement was to optimize for the most
common patterns of File usage we found in the codebase; and utillity
methods such as in() for common usage patterns. Where possible we provided
method name compatibility so it would be easier to migrate code from File
to Resource.
I was expecting far more input on this API when it was first introduced;
your input is welcome now.
For the specific example you show:
- in() should not accidentally create a file for UNDEFINED
- returning an empty input stream would be okay - less for client code to
handle. I understand that failed parsing expression is not so fun
- throwing UncheckedIOException is okay - concerned it would lead to a
bunch of boiler plate code try / catch being introduced
Since we have the whole codebase available it should be easy to access what
this change would require and answer the concerns above.
Whatever change is made I ask that the javadocs be clearly updated.
--
Jody
On Fri, Oct 21, 2022 at 12:03 PM Dieter Stüken - con terra GmbH via
Geoserver-devel wrote:
> Hi dev list,
>
> I frequently noticed, that Resource.in() just creates non existing files
> and then returns an empty input stream. This almost ever causes further
> problems like https://github.com/geoserver/geoserver/pull/6216.
>
> I think the root cause is the implementation of Resource.in() for
> UNDEFINED resources.
> Looking at Files.ResourceAdaptor.in() I find:
>
> final File actualFile = file();
> if (!actualFile.exists()) {
> throw new IllegalStateException("Cannot access " + actualFile);
> }
>
> Seems, the initial intention was to throw an exception, but since file()
> creates the missing file, it does not work as intended. I analyzed the
> former GSIP 106, but I did not find any hints about the expected behavior
> here.
>
> This can be fixed easily and in think an Exception about a missing file is
> much more expressive than a message from a failed content parser.
>
> Most use cases check for Type.RESOURCE in advance or have some elaborated
> exception handlers and are thus unaffected. Some usages however try to
> handle this condition later on by using inputStream.available() like
> EchoParametersDao.getEchoParameters(in) does and will fail then.
>
> I'm working on a pull request to change the behavior this way, but this
> causes adaptions to other related areas. Even SpringResourceAdaptor is
> affected, since it relays on IOExcetion which have been wrapped into
> IllegalStateException (and for which I think an UncheckedIOException is the
> better choice).
>
> Other solutions are:
>
> return null (can be checked afterwards but not so nice)
>
> return an empty InputStream (Java 11 even has some:
> InputStream.nullInputStream())
>
> Do you think it is worth to propose a refactoring here or should I better
> keep hands off?
>
> Dieter.
>
> --
>
> *Dieter Stüken*
>
> Software Engineer
>
> Nature Environment and Resources
>
>
>
> T +49 251 59689 403
>
> <https://www.google.com/maps/search/Martin-Luther-King-Weg+20+%0D%0A+48155+M%C3%BCnster?entry=gmail&source=g>
>
> d.stue...@conterra.de
>
>
>
> con terra GmbH
>
> Martin-Luther-King-Weg 20
> <https://www.google.com/maps/search/Martin-Luther-King-Weg+20+%0D%0A+48155+M%C3%BCnster?entry=gmail&source=g>
>
> 48155 Münster
> <https://www.google.com/maps/search/Martin-Luther-King-Weg+20+%0D%0A+48155+M%C3%BCnster?entry=gmail&source=g>
>
> conterra.de <https://www.conterra.com/>
>
>
>
> Geschäftsführung: Karl Wiesmann, Uwe König
>
> HRB 4149, Amtsgericht Münster
>
> Privacy statements <https://www.con-terra.com/privacy-statements>
>
>
>
> YouTube <https://www.youtube.com/conterrachannel> | Twitter
> <https://twitter.com/conterra> | LinkedIn
> <https://www.linkedin.com/company/con-terra-gmbh>
>
>
> ___
> Geoserver-devel mailing list
> Geoserver-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>
--
--
Jody Garnett
___
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] GeoServer 2.22-RC preflight testing
Checking this morning; the installer did not go (some more NSI updates were needed) but Sander and Juan have something working. The release is anounced; may have to upload the installer seperate to source forge. -- Jody On Fri, Oct 21, 2022 at 6:33 AM Jody Garnett wrote: > I have taken another go at the release process to address the windows > installer script tripping up including license files. Release candidate is > the right (well only) chance to address such things. > > > https://build.geoserver.org/view/release/job/geoserver-release/86/artifact/distribution/2.22-RC/ > > > Waiting to see if the windows installer will run successfully... > > A number of bugs have been reported: > > 1) [GEOS-10647] Welcome page links to GetCapabilities do not follow the > OGC standard > - done: Quick fix for URL typo > https://github.com/geoserver/geoserver/pull/6282 (thanks David) > > 2) [GEOS-10715] - Workspace Filter for PublishedInfo does not include > LayerGroups > - https://github.com/geoserver/geoserver/pull/6280 for review > - Layer Preview and Welcome Page do a general query for PublishedInfo .. > which for a user with workspace only permissions just returns layers. It > was checking LayerInfo *resource.store.workspace.name > <http://resource.store.workspace.name>, *and not including LayerGroup > *workspace.name > <http://workspace.name>.* > > -- > Jody Garnett > > > On Thu, 20 Oct 2022 at 06:51, Jody Garnett wrote: > >> Local testing is fine thus far. >> >> The move of license / notice not being included in the bin download has >> broken the windows installer script. I will update and re-run the release >> candidate (see https://osgeo-org.atlassian.net/browse/GEOS-10713 ). >> >> Since this is only a release candidate I do not see any reason to delay >> announcing today; please review the blog post anouncement. >> >> Jody >> >> On Wed, Oct 19, 2022 at 11:29 PM Jody Garnett >> wrote: >> >>> GeoServer 2.22-RC is available for preflight testing: >>> - >>> https://build.geoserver.org/view/release/job/geoserver-release/lastSuccessfulBuild/artifact/distribution/2.22-RC/ >>> >>> Blog post being constructed here: >>> - https://github.com/geoserver/geoserver.github.io/tree/release_2.22-RC >>> - https://github.com/geoserver/geoserver.github.io/pull/134 >>> >>> Known issues (with some casual testing): >>> - ne:countries description is incorrect >>> - general license / notice appears to be missing from bin download >>> >>> -- >>> Jody Garnett >>> >> -- >> -- >> Jody Garnett >> > -- > -- > Jody Garnett > -- -- Jody Garnett ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] GeoServer 2.22-RC preflight testing
I have taken another go at the release process to address the windows installer script tripping up including license files. Release candidate is the right (well only) chance to address such things. https://build.geoserver.org/view/release/job/geoserver-release/86/artifact/distribution/2.22-RC/ Waiting to see if the windows installer will run successfully... A number of bugs have been reported: 1) [GEOS-10647] Welcome page links to GetCapabilities do not follow the OGC standard - done: Quick fix for URL typo https://github.com/geoserver/geoserver/pull/6282 (thanks David) 2) [GEOS-10715] - Workspace Filter for PublishedInfo does not include LayerGroups - https://github.com/geoserver/geoserver/pull/6280 for review - Layer Preview and Welcome Page do a general query for PublishedInfo .. which for a user with workspace only permissions just returns layers. It was checking LayerInfo *resource.store.workspace.name <http://resource.store.workspace.name>, *and not including LayerGroup *workspace.name <http://workspace.name>.* -- Jody Garnett On Thu, 20 Oct 2022 at 06:51, Jody Garnett wrote: > Local testing is fine thus far. > > The move of license / notice not being included in the bin download has > broken the windows installer script. I will update and re-run the release > candidate (see https://osgeo-org.atlassian.net/browse/GEOS-10713 ). > > Since this is only a release candidate I do not see any reason to delay > announcing today; please review the blog post anouncement. > > Jody > > On Wed, Oct 19, 2022 at 11:29 PM Jody Garnett > wrote: > >> GeoServer 2.22-RC is available for preflight testing: >> - >> https://build.geoserver.org/view/release/job/geoserver-release/lastSuccessfulBuild/artifact/distribution/2.22-RC/ >> >> Blog post being constructed here: >> - https://github.com/geoserver/geoserver.github.io/tree/release_2.22-RC >> - https://github.com/geoserver/geoserver.github.io/pull/134 >> >> Known issues (with some casual testing): >> - ne:countries description is incorrect >> - general license / notice appears to be missing from bin download >> >> -- >> Jody Garnett >> > -- > -- > Jody Garnett > -- -- Jody Garnett ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
[Geoserver-devel] Release train starting for 2.21.x
With the RC out of the way; I still have some customers waiting on a stable release for security improvements. Is it okay if I make a 2.21.x release? That way we still get a stable release for October here. Jody -- -- Jody Garnett ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] GeoServer 2.22-RC preflight testing
Local testing is fine thus far. The move of license / notice not being included in the bin download has broken the windows installer script. I will update and re-run the release candidate (see https://osgeo-org.atlassian.net/browse/GEOS-10713 ). Since this is only a release candidate I do not see any reason to delay announcing today; please review the blog post anouncement. Jody On Wed, Oct 19, 2022 at 11:29 PM Jody Garnett wrote: > GeoServer 2.22-RC is available for preflight testing: > - > https://build.geoserver.org/view/release/job/geoserver-release/lastSuccessfulBuild/artifact/distribution/2.22-RC/ > > Blog post being constructed here: > - https://github.com/geoserver/geoserver.github.io/tree/release_2.22-RC > - https://github.com/geoserver/geoserver.github.io/pull/134 > > Known issues (with some casual testing): > - ne:countries description is incorrect > - general license / notice appears to be missing from bin download > > -- > Jody Garnett > -- -- Jody Garnett ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
[Geoserver-devel] GeoServer 2.22-RC preflight testing
GeoServer 2.22-RC is available for preflight testing: - https://build.geoserver.org/view/release/job/geoserver-release/lastSuccessfulBuild/artifact/distribution/2.22-RC/ Blog post being constructed here: - https://github.com/geoserver/geoserver.github.io/tree/release_2.22-RC - https://github.com/geoserver/geoserver.github.io/pull/134 Known issues (with some casual testing): - ne:countries description is incorrect - general license / notice appears to be missing from bin download -- Jody Garnett ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format
noscenza è > riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il > messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra > operazione è illecita. Le sarei comunque grato se potesse darmene notizia. > This > email is intended only for the person or entity to which it is addressed > and may contain information that is privileged, confidential or otherwise > protected from disclosure. We remind that - as provided by European > Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail > or the information herein by anyone other than the intended recipient is > prohibited. If you have received this email by mistake, please notify us > immediately by telephone or e-mail > > ___ > Geoserver-devel mailing list > Geoserver-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geoserver-devel > -- -- Jody Garnett ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] discussion of GEOS-10561 CatalogImpl.save(StoreInfo) business rule to handle ResourceInfo.namespace
Thanks for untangling Andrea, Near as I can tell the fix is good but you identified a cleaner approach that will result in less duplication. Jody On Wed, Oct 12, 2022 at 12:50 AM Andrea Aime < andrea.a...@geosolutionsgroup.com> wrote: > Hi Jody, > you're talking about one PR in the title and first part of the mail, but > then link to another... I think you were referring to this one instead: > >- https://github.com/geoserver/geoserver/pull/5993 >- https://osgeo-org.atlassian.net/browse/GEOS-10561 > > The discussion on the PR already provides some pros/cons and alternatives. > > Cheers > Andrea > > On Mon, Oct 10, 2022 at 11:09 PM Jody Garnett > wrote: > >> Checking outstanding PRs one I am really keen to see progress on is >> GEOS-1056; presently the PR is held up pending some discussion on the >> development list as their is a javadoc api change for >> Catalog.save(StoreInfo store); so any implementation would need to be >> updated. >> >> While the functionality is good; there is a wish to discuss how it should >> be implemented: >> - https://osgeo-org.atlassian.net/browse/GEOS-10685 >> - https://github.com/geoserver/geoserver/pull/6216 >> >> -- >> Jody Garnett >> > ___ >> Geoserver-devel mailing list >> Geoserver-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >> > > > -- > > Regards, > > Andrea Aime > > == > GeoServer Professional Services from the experts! > > Visit http://bit.ly/gs-services-us for more information. > == > > Ing. Andrea Aime > @geowolf > Technical Lead > > GeoSolutions Group > phone: +39 0584 962313 > > fax: +39 0584 1660272 > > mob: +39 339 8844549 > > https://www.geosolutionsgroup.com/ > > http://twitter.com/geosolutions_it > > --- > > Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE > 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si > precisa che ogni circostanza inerente alla presente email (il suo > contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è > riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il > messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra > operazione è illecita. Le sarei comunque grato se potesse darmene notizia. > > This email is intended only for the person or entity to which it is > addressed and may contain information that is privileged, confidential or > otherwise protected from disclosure. We remind that - as provided by > European Regulation 2016/679 “GDPR” - copying, dissemination or use of this > e-mail or the information herein by anyone other than the intended > recipient is prohibited. If you have received this email by mistake, please > notify us immediately by telephone or e-mail > -- -- Jody Garnett ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
[Geoserver-devel] some kind of build failure ...
Doing a full build with -PcommunityRelease fails: [ERROR] Failed to execute goal on project gs-taskmanager-metadata: Could not resolve dependencies for project org.geoserver.community:gs-taskmanager-metadata:jar:2.23-SNAPSHOT: Could not find artifact org.geoserver.community:gs-metadata:jar:2.23-SNAPSHOT in osgeo-snapshots (https://repo.osgeo.org/repository/snapshot/) -> [Help 1] This is causing the https://build.geoserver.org/view/geoserver/job/geoserver-main/ jobs to fail. I guess the prior branches were building because the repo held a snapshot from prior runs... -- Jody Garnett ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
[Geoserver-devel] New 2.22.x branch created, main moves to 2.23-SNAPSHOT development
A new 2.22.x branch for stable development is available. Main transitions to 2.23-SNAPSHOT development. Reminder a release volunteer is needed for 2.22-RC; if anyone has capacity this week please speak up :) -- Jody Garnett ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Re: [Geoserver-devel] Default logging profiles are not longer customizable
I am sorry if my initial response to the issue appeared dismissive; I was just trying to indicate that this change was on purpose. Please keep in mind that this is new code for log4j and there is no commit to easily "revert" as mentioned in this thread ... I created a draft PR which I think highlights where the change is needed https://github.com/geoserver/geoserver/pull/6234 -- Jody Garnett On Sun, 9 Oct 2022 at 01:36, Jody Garnett wrote: > Jody here with some notes for the discussion: > > 1. The documentation refers to these as built-in logging configurations. I > think it is good that the built-in logging configurations are available for > use as an example (rather than just hidden in a jar). > > https://docs.geoserver.org/main/en/user/configuration/logging.html > > 2. The documentation on customization (above) has an example that starts > with copying a built-in configuration and making changes. > > 3. The blog post has some more details on updating from properties --> > xml; but also updating about the built-in xml definitions updating each > release. Reading the blog post it just has an example using properties and > not an xml file. > > If you made any customizations to the built-in profiles, you can recover > your changes from backup bak file. You can use this backup as a reference > when creating a new xml logging profile, or restore this under a > different name which does not conflict with the built-in logging profiles. > > 4. I do expect these logging configuration to change over time, see bug > https://osgeo-org.atlassian.net/browse/GEOS-10701 for an example. As such > it is nice to treat these as built-in and managed as part of the software. > > aside: Initially I tried writing some code that checked if the built-in > files had been customized; and only update ones that had not had their > checksum change. PR review guidance was to simplify the code. Perhaps > reviewers were thinking it was only applying with updating from properties > --> xml and not an ongoing policy. > -- > Jody > > On Sat, Oct 8, 2022 at 7:33 AM Andrea Aime < > andrea.a...@geosolutionsgroup.com> wrote: > >> Sel correction: GeoServer will bulldoze the file the moment one changes >> the logging profile, so the edit will really never take. >> Hopefully one is working with an editor still open, and smart enough to >> tell them "hey, the file just got modified". >> >> Cheers >> Andrea >> >> >> On Sat, Oct 8, 2022 at 11:27 AM Andrea Aime < >> andrea.a...@geosolutionsgroup.com> wrote: >> >>> You have a good point about predictability. At the same time, it's >>> shocking to be able to edit a file, have it working fine for >>> a while, and then find out it reverted back to a previous state >>> days/weeks/months later, when a restart happens. >>> >>> The other surprising bit is the change of behavior, after so many years >>> being able to just edit these files without surprises. >>> >>> Cheers >>> Andrea >>> >>> On Fri, Oct 7, 2022 at 9:20 PM Alexandre Gacon < >>> alexandre.ga...@gmail.com> wrote: >>> >>>> I think I understand the point of Jody. If the definition of the level >>>> of logging stays the same, you know you can have a given information by >>>> asking a customer or a user to set the logging to level YYY. >>>> >>>> If the definition has been changed, you won't have the information to >>>> help him or her. >>>> >>>> To me it should be possible to define several custom logging levels. >>>> For the default one, the only thing that should be allowed to be changed >>>> should be the location of the file or a rolling policy but not the content >>>> of the log. >>>> >>>> Alexandre >>>> >>>> Le ven. 7 oct. 2022 à 19:58, Ian Turton a écrit : >>>> >>>>> Overwriting an existing file seems wrong to me. I for one would be >>>>> surprised if it happened to me. >>>>> >>>>> Ian >>>>> >>>>> On Fri, 7 Oct 2022, 18:20 Andrea Aime, < >>>>> andrea.a...@geosolutionsgroup.com> wrote: >>>>> >>>>>> Hi all, >>>>>> I'm bringing a discussion started in >>>>>> https://osgeo-org.atlassian.net/browse/GEOS-10700 here on list, >>>>>> because I believe it needs a wider audience. >>>>>> >>>>>> In summary, it's no longer possible to customize the logging profiles >
[Geoserver-devel] discussion of GEOS-10561 CatalogImpl.save(StoreInfo) business rule to handle ResourceInfo.namespace
Checking outstanding PRs one I am really keen to see progress on is GEOS-1056; presently the PR is held up pending some discussion on the development list as their is a javadoc api change for Catalog.save(StoreInfo store); so any implementation would need to be updated. While the functionality is good; there is a wish to discuss how it should be implemented: - https://osgeo-org.atlassian.net/browse/GEOS-10685 - https://github.com/geoserver/geoserver/pull/6216 -- Jody Garnett ___ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
