Change in osmo-bsc[master]: cosmetic: lchan: introduce sub-struct lchan->release.*

[Neels Hofmeyr]

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/11668


Change subject: cosmetic: lchan: introduce sub-struct lchan->release.*
..

cosmetic: lchan: introduce sub-struct lchan->release.*

Put all lchan release related flags and settings in a sub-struct named
'release' to better indicate what those fields are for. There is no functional
change.

Change-Id: Icfddc6010e5d7c309f1a7ed3526b5b635ffeaf11
---
M include/osmocom/bsc/gsm_data.h
M src/osmo-bsc/bsc_subscr_conn_fsm.c
M src/osmo-bsc/lchan_fsm.c
M src/osmo-bsc/lchan_rtp_fsm.c
4 files changed, 53 insertions(+), 50 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/68/11668/1

diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index b257b67..fb1db80 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -492,6 +492,8 @@
uint8_t nr;
char *name;

+   char *last_error;
+
struct osmo_fsm_inst *fi;
struct osmo_fsm_inst *fi_rtp;
struct mgwep_ci *mgw_endpoint_ci_bts;
@@ -510,21 +512,21 @@
struct gsm_lchan *re_use_mgw_endpoint_from_lchan;
} activate;

-   /* If an event to release the lchan comes in while still waiting for 
responses, just mark this
-* flag, so that the lchan will gracefully release at the next sensible 
junction. */
-   bool release_requested;
-   bool do_rr_release;
+   struct {
+   /* If an event to release the lchan comes in while still 
waiting for responses, just mark this
+* flag, so that the lchan will gracefully release at the next 
sensible junction. */
+   bool release_requested;
+   bool do_rr_release;

-   char *last_error;
+   /* There is an RSL error cause of value 0, so we need a 
separate flag. */
+   bool release_in_error;
+   /* RSL error code, RSL_ERR_* */
+   uint8_t rsl_error_cause;

-   /* There is an RSL error cause of value 0, so we need a separate flag. 
*/
-   bool release_in_error;
-   /* RSL error code, RSL_ERR_* */
-   uint8_t rsl_error_cause;
-
-   /* If a release event is being handled, ignore other ricocheting 
release events until that
-* release handling has concluded. */
-   bool in_release_handler;
+   /* If a release event is being handled, ignore other 
ricocheting release events until that
+* release handling has concluded. */
+   bool in_release_handler;
+   } release;

/* The logical channel type */
enum gsm_chan_t type;
diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c 
b/src/osmo-bsc/bsc_subscr_conn_fsm.c
index 86f8354..c0febaa 100644
--- a/src/osmo-bsc/bsc_subscr_conn_fsm.c
+++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c
@@ -715,8 +715,8 @@
break;
case GSCON_EV_RSL_CONN_FAIL:
if (conn->lchan) {
-   conn->lchan->release_in_error = true;
-   conn->lchan->rsl_error_cause = data ? *(uint8_t*)data : 
RSL_ERR_IE_ERROR;
+   conn->lchan->release.release_in_error = true;
+   conn->lchan->release.rsl_error_cause = data ? 
*(uint8_t*)data : RSL_ERR_IE_ERROR;
}
gscon_bssmap_clear(conn, GSM0808_CAUSE_RADIO_INTERFACE_FAILURE);
break;
diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c
index 9964fcf..012239c 100644
--- a/src/osmo-bsc/lchan_fsm.c
+++ b/src/osmo-bsc/lchan_fsm.c
@@ -485,7 +485,7 @@
OSMO_ASSERT(!lchan->conn);
OSMO_ASSERT(!lchan->mgw_endpoint_ci_bts);
lchan_set_last_error(lchan, NULL);
-   lchan->release_requested = false;
+   lchan->release.release_requested = false;

lchan->conn = info->for_conn;
lchan->activate.activ_for = info->activ_for;
@@ -557,7 +557,7 @@
struct gsm_lchan *lchan = lchan_fi_lchan(fi);
struct mgwep_ci *use_mgwep_ci = lchan_use_mgw_endpoint_ci_bts(lchan);

-   if (lchan->release_requested) {
+   if (lchan->release.release_requested) {
lchan_fail("Release requested while activating");
return;
}
@@ -593,7 +593,7 @@

case LCHAN_EV_RTP_RELEASED:
case LCHAN_EV_RTP_ERROR:
-   if (lchan->in_release_handler) {
+   if (lchan->release.in_release_handler) {
/* Already in release, the RTP is not the initial cause 
of failure.
 * Just ignore. */
return;
@@ -616,7 +616,7 @@
uint8_t ho_ref = 0;
struct gsm_lchan *lchan = lchan_fi_lchan(fi);

-   if (lchan->release_requested) {
+   if (lchan->release.release_requested) {
lchan_fail_to(LCHAN_ST_UNUSED, "Releas

Change in osmo-bsc[master]: lchan: release in error: fix missing messages / events

[Neels Hofmeyr]

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/11666


Change subject: lchan: release in error: fix missing messages / events
..

lchan: release in error: fix missing messages / events

In the case where there is a release in error and we skip immediately to the RF
Release state, send all of Deact SACCH, RR Release messages and also signal the
lchan_rtp_fsm as appropriate.

Move that code to static lchan_do_release() and call from both
lchan_fsm_wait_rll_rtp_released_onenter() in the normal case, as well as
lchan_release() when skipping that.

When releasing in error, but we're already in LCHAN_ST_WAIT_RLL_RTP_RELEASED,
those messages have already been sent and we can skip them.

Change-Id: I648a9826ce56b611359f81462ca03e4ab4c736aa
---
M src/osmo-bsc/lchan_fsm.c
1 file changed, 18 insertions(+), 12 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/66/11666/1

diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c
index e15adbe..2cb7c3e 100644
--- a/src/osmo-bsc/lchan_fsm.c
+++ b/src/osmo-bsc/lchan_fsm.c
@@ -927,6 +927,18 @@
}
 }

+static void lchan_do_release(struct gsm_lchan *lchan)
+{
+   if (lchan->do_rr_release && lchan->sapis[0] != LCHAN_SAPI_UNUSED)
+   gsm48_send_rr_release(lchan);
+
+   if (lchan->fi_rtp)
+   osmo_fsm_inst_dispatch(lchan->fi_rtp, LCHAN_RTP_EV_RELEASE, 0);
+
+   if (lchan->deact_sacch && should_sacch_deact(lchan))
+   rsl_deact_sacch(lchan);
+}
+
 static void lchan_fsm_wait_rll_rtp_released_onenter(struct osmo_fsm_inst *fi, 
uint32_t prev_state)
 {
int sapis;
@@ -937,14 +949,7 @@
if (lchan->sapis[sapi])
LOG_LCHAN(lchan, LOGL_DEBUG, "SAPI[%d] = %d\n", sapi, 
lchan->sapis[sapi]);

-   if (lchan->do_rr_release && lchan->sapis[0] != LCHAN_SAPI_UNUSED)
-   gsm48_send_rr_release(lchan);
-
-   if (lchan->fi_rtp)
-   osmo_fsm_inst_dispatch(lchan->fi_rtp, LCHAN_RTP_EV_RELEASE, 0);
-
-   if (lchan->deact_sacch && should_sacch_deact(lchan))
-   rsl_deact_sacch(lchan);
+   lchan_do_release(lchan);

sapis = 0;
for_each_active_sapi(sapi, 1, lchan) {
@@ -1317,10 +1322,11 @@
if (lchan->release_in_error) {
switch (lchan->fi->state) {
default:
-   /* Normally we deact SACCH in 
lchan_fsm_wait_rll_rtp_released_onenter(). When
-* skipping that, but asked to SACCH deact, do it now. 
*/
-   if (lchan->deact_sacch)
-   rsl_deact_sacch(lchan);
+   /* Normally we signal release in 
lchan_fsm_wait_rll_rtp_released_onenter(). When
+* skipping that, do it now. */
+   lchan_do_release(lchan);
+   /* fall thru */
+   case LCHAN_ST_WAIT_RLL_RTP_RELEASED:
lchan_fsm_state_chg(LCHAN_ST_WAIT_RF_RELEASE_ACK);
goto exit_release_handler;
case LCHAN_ST_WAIT_TS_READY:

--
To view, visit https://gerrit.osmocom.org/11666
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I648a9826ce56b611359f81462ca03e4ab4c736aa
Gerrit-Change-Number: 11666
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 

Change in osmo-bsc[master]: lchan: set cause for 4 instances of release_in_error = true

[Neels Hofmeyr]

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/11670


Change subject: lchan: set cause for 4 instances of release_in_error = true
..

lchan: set cause for 4 instances of release_in_error = true

Make sure some RSL cause is set.

Change-Id: I372ade9fc58919fbf858ce14caab8a0a22dbb083
---
M src/osmo-bsc/lchan_fsm.c
M src/osmo-bsc/lchan_rtp_fsm.c
2 files changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/70/11670/1

diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c
index 012239c..bfcf55d 100644
--- a/src/osmo-bsc/lchan_fsm.c
+++ b/src/osmo-bsc/lchan_fsm.c
@@ -1054,6 +1054,7 @@
case LCHAN_EV_RSL_CHAN_ACTIV_ACK:
/* A late Chan Activ ACK? Release. */
lchan->release.release_in_error = true;
+   lchan->release.rsl_error_cause = RSL_ERR_INTERWORKING;
lchan_fsm_state_chg(LCHAN_ST_WAIT_RF_RELEASE_ACK);
return;

@@ -1065,6 +1066,7 @@
case LCHAN_EV_RSL_RF_CHAN_REL_ACK:
/* A late Release ACK? */
lchan->release.release_in_error = true;
+   lchan->release.rsl_error_cause = RSL_ERR_INTERWORKING;
lchan_fsm_state_chg(LCHAN_ST_WAIT_AFTER_ERROR);
/* TODO: we used to do this only for sysmobts:
int do_free = is_sysmobts_v2(ts->trx->bts);
@@ -1289,6 +1291,7 @@

default:
lchan->release.release_in_error = true;
+   lchan->release.rsl_error_cause = RSL_ERR_INTERWORKING;
lchan_fail("Timeout");
return 0;
}
diff --git a/src/osmo-bsc/lchan_rtp_fsm.c b/src/osmo-bsc/lchan_rtp_fsm.c
index dd42fc4..b6aa39c 100644
--- a/src/osmo-bsc/lchan_rtp_fsm.c
+++ b/src/osmo-bsc/lchan_rtp_fsm.c
@@ -725,6 +725,7 @@
 {
struct gsm_lchan *lchan = lchan_rtp_fi_lchan(fi);
lchan->release.release_in_error = true;
+   lchan->release.rsl_error_cause = RSL_ERR_EQUIPMENT_FAIL;
lchan_rtp_fail("Timeout");
return 0;
 }

--
To view, visit https://gerrit.osmocom.org/11670
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I372ade9fc58919fbf858ce14caab8a0a22dbb083
Gerrit-Change-Number: 11670
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 

Change in osmo-bsc[master]: cosmetic: abis_rsl.c: drop uneccesary braces

[Neels Hofmeyr]

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/11669


Change subject: cosmetic: abis_rsl.c: drop uneccesary braces
..

cosmetic: abis_rsl.c: drop uneccesary braces

Change-Id: I20a7b160321cf86179cdcece71c8158e76ba4a1b
---
M src/osmo-bsc/abis_rsl.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/69/11669/1

diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c
index c16f044..6e8d078 100644
--- a/src/osmo-bsc/abis_rsl.c
+++ b/src/osmo-bsc/abis_rsl.c
@@ -895,9 +895,9 @@
/* If the lchan is associated with a conn, we shall notify the MSC of 
the RSL Conn Failure, and
 * the connection will presumably be torn down and lead to an lchan 
release. During initial
 * Channel Request from the MS, an lchan has no conn yet, so in that 
case release now. */
-   if (!lchan->conn) {
+   if (!lchan->conn)
lchan_release(lchan, false, true, *cause_p);
-   } else
+   else
osmo_fsm_inst_dispatch(lchan->conn->fi, GSCON_EV_RSL_CONN_FAIL, 
(void*)cause_p);

return 0;

--
To view, visit https://gerrit.osmocom.org/11669
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I20a7b160321cf86179cdcece71c8158e76ba4a1b
Gerrit-Change-Number: 11669
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 

Change in osmo-bsc[master]: abis_rsl.c: drop unused enum sacch_deact

[Neels Hofmeyr]

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/11665


Change subject: abis_rsl.c: drop unused enum sacch_deact
..

abis_rsl.c: drop unused enum sacch_deact

Change-Id: I8a1542e92373d2773699744e7b64a08667a4b0f5
---
M src/osmo-bsc/abis_rsl.c
1 file changed, 0 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/65/11665/1

diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c
index ea537fe..0ec8fbc 100644
--- a/src/osmo-bsc/abis_rsl.c
+++ b/src/osmo-bsc/abis_rsl.c
@@ -56,11 +56,6 @@
 #define RSL_ALLOC_SIZE 1024
 #define RSL_ALLOC_HEADROOM 128

-enum sacch_deact {
-   SACCH_NONE,
-   SACCH_DEACTIVATE,
-};
-
 static void send_lchan_signal(int sig_no, struct gsm_lchan *lchan,
  struct gsm_meas_rep *resp)
 {

--
To view, visit https://gerrit.osmocom.org/11665
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a1542e92373d2773699744e7b64a08667a4b0f5
Gerrit-Change-Number: 11665
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 

Change in osmo-bsc[master]: lchan release: always Deact SACCH

[Neels Hofmeyr]

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/11667


Change subject: lchan release: always Deact SACCH
..

lchan release: always Deact SACCH

If an lchan is being released and had a SACCH active, there is no reason to
omit the Deact SACCH message ever. All of the callers that passed
do_deact_sachh = false did so for no good reason.

Drop the do_deact_sachh flag everywhere and, when the lchan type matches and
SAPI[0] is still active, simply always send a Deact SACCH message.

The do_deact_sachh flag was carried over from legacy code, by me, mainly
because I never really understood why it was there. I do hope I'm correct now,
asserting that having this flag makes no sense.

Change-Id: Id3301df059582da2377ef82feae554e94fa42035
---
M include/osmocom/bsc/bsc_subscr_conn_fsm.h
M include/osmocom/bsc/gsm_data.h
M include/osmocom/bsc/lchan_fsm.h
M src/osmo-bsc/abis_rsl.c
M src/osmo-bsc/assignment_fsm.c
M src/osmo-bsc/bsc_subscr_conn_fsm.c
M src/osmo-bsc/bsc_vty.c
M src/osmo-bsc/gsm_04_08_rr.c
M src/osmo-bsc/gsm_08_08.c
M src/osmo-bsc/handover_fsm.c
M src/osmo-bsc/lchan_fsm.c
M tests/gsm0408/gsm0408_test.c
M tests/handover/handover_test.c
13 files changed, 32 insertions(+), 32 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/67/11667/1

diff --git a/include/osmocom/bsc/bsc_subscr_conn_fsm.h 
b/include/osmocom/bsc/bsc_subscr_conn_fsm.h
index fcdba50..f5ed7bd 100644
--- a/include/osmocom/bsc/bsc_subscr_conn_fsm.h
+++ b/include/osmocom/bsc/bsc_subscr_conn_fsm.h
@@ -71,7 +71,7 @@
struct assignment_request *req);

 void gscon_change_primary_lchan(struct gsm_subscriber_connection *conn, struct 
gsm_lchan *new_lchan);
-void gscon_release_lchans(struct gsm_subscriber_connection *conn, bool 
do_sacch_deact, bool do_rr_release);
+void gscon_release_lchans(struct gsm_subscriber_connection *conn, bool 
do_rr_release);

 void gscon_lchan_releasing(struct gsm_subscriber_connection *conn, struct 
gsm_lchan *lchan);
 void gscon_forget_lchan(struct gsm_subscriber_connection *conn, struct 
gsm_lchan *lchan);
diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index 6ad6fce..b257b67 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -513,7 +513,6 @@
/* If an event to release the lchan comes in while still waiting for 
responses, just mark this
 * flag, so that the lchan will gracefully release at the next sensible 
junction. */
bool release_requested;
-   bool deact_sacch;
bool do_rr_release;

char *last_error;
diff --git a/include/osmocom/bsc/lchan_fsm.h b/include/osmocom/bsc/lchan_fsm.h
index d3315a6..48cd383 100644
--- a/include/osmocom/bsc/lchan_fsm.h
+++ b/include/osmocom/bsc/lchan_fsm.h
@@ -49,7 +49,7 @@
 void lchan_fsm_init();

 void lchan_fsm_alloc(struct gsm_lchan *lchan);
-void lchan_release(struct gsm_lchan *lchan, bool do_deact_sacch, bool 
do_rr_release,
+void lchan_release(struct gsm_lchan *lchan, bool do_rr_release,
   bool err, enum gsm48_rr_cause cause_rr);

 struct lchan_activate_info {
diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c
index 0ec8fbc..c16f044 100644
--- a/src/osmo-bsc/abis_rsl.c
+++ b/src/osmo-bsc/abis_rsl.c
@@ -896,7 +896,7 @@
 * the connection will presumably be torn down and lead to an lchan 
release. During initial
 * Channel Request from the MS, an lchan has no conn yet, so in that 
case release now. */
if (!lchan->conn) {
-   lchan_release(lchan, false, false, true, *cause_p);
+   lchan_release(lchan, false, true, *cause_p);
} else
osmo_fsm_inst_dispatch(lchan->conn->fi, GSCON_EV_RSL_CONN_FAIL, 
(void*)cause_p);

diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c
index 653681e..93362f8 100644
--- a/src/osmo-bsc/assignment_fsm.c
+++ b/src/osmo-bsc/assignment_fsm.c
@@ -98,7 +98,7 @@
if (conn->assignment.new_lchan) {
struct gsm_lchan *lchan = conn->assignment.new_lchan;
conn->assignment.new_lchan = NULL;
-   lchan_release(lchan, false, false, true, 
RSL_ERR_EQUIPMENT_FAIL);
+   lchan_release(lchan, false, true, RSL_ERR_EQUIPMENT_FAIL);
}

if (conn->assignment.created_ci_for_msc) {
@@ -213,7 +213,7 @@
if (!conn->assignment.fi) {
/* The lchan was ready, and we failed to tell the MSC about it. 
By releasing this lchan,
 * the conn will notice that its primary lchan is gone and 
should clean itself up. */
-   lchan_release(conn->lchan, false, true, true, 
RSL_ERR_EQUIPMENT_FAIL);
+   lchan_release(conn->lchan, true, true, RSL_ERR_EQUIPMENT_FAIL);
return;
}

diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c 
b/src/osmo-bsc/bsc_subscr_conn_fsm.c
index 8c11521

Change in osmo-bsc[master]: fix: send RR Release (e.g. after BSSMAP Clear Cmd)

[Neels Hofmeyr]

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/11664


Change subject: fix: send RR Release (e.g. after BSSMAP Clear Cmd)
..

fix: send RR Release (e.g. after BSSMAP Clear Cmd)

After commit [1], the code makes sure to disassociate lchan and conn before
invoking the lchan release. However, we only send RR Release if a conn is
present, which clearly is nonsense after [1].

[1] commit 8b818a01b00ea3daad4ad58c162ac52b4f08a5cb
"subscr conn: properly forget lchan before release"
Change-Id: I4fd582b41ba4599af704d670af83651d2450b1db

Manage sending of RR Release via a flag, set during invoking lchan release.

Add do_rr_release arg to lchan_release(), gscon_release_lchans(). In
lchan_fsm.c, send RR Release only if do_rr_release was passed true; do not care
whether a conn is still associated (because it won't ever be since [1]).

That way we can intelligently decide what release process makes sense (whether
the lchan terminates the subscriber connection or whether the connection goes
on at another lchan), and still disassociate lchan and conn early.

BTW, this problem wasn't caught by the stock OsmoBSC TTCN3 tests, because the
f_expect_chan_rel() don't care whether an RR Release happens or not. This is
being fixed by Ibc64058f1e214bea585f4e8dcb66f3df8ead3845.

So far this patch should fix BSC_Tests_LCLS.TC_lcls_connect_clear.

Related: OS#3413
Change-Id: I666b3b4f45706d898d664d380bd0fd2b018be358
---
M include/osmocom/bsc/bsc_subscr_conn_fsm.h
M include/osmocom/bsc/gsm_data.h
M include/osmocom/bsc/lchan_fsm.h
M src/osmo-bsc/abis_rsl.c
M src/osmo-bsc/assignment_fsm.c
M src/osmo-bsc/bsc_subscr_conn_fsm.c
M src/osmo-bsc/bsc_vty.c
M src/osmo-bsc/gsm_04_08_rr.c
M src/osmo-bsc/gsm_08_08.c
M src/osmo-bsc/handover_fsm.c
M src/osmo-bsc/lchan_fsm.c
M tests/gsm0408/gsm0408_test.c
12 files changed, 32 insertions(+), 30 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/64/11664/1

diff --git a/include/osmocom/bsc/bsc_subscr_conn_fsm.h 
b/include/osmocom/bsc/bsc_subscr_conn_fsm.h
index d4de1c9..fcdba50 100644
--- a/include/osmocom/bsc/bsc_subscr_conn_fsm.h
+++ b/include/osmocom/bsc/bsc_subscr_conn_fsm.h
@@ -71,7 +71,7 @@
struct assignment_request *req);

 void gscon_change_primary_lchan(struct gsm_subscriber_connection *conn, struct 
gsm_lchan *new_lchan);
-void gscon_release_lchans(struct gsm_subscriber_connection *conn, bool 
do_sacch_deact);
+void gscon_release_lchans(struct gsm_subscriber_connection *conn, bool 
do_sacch_deact, bool do_rr_release);

 void gscon_lchan_releasing(struct gsm_subscriber_connection *conn, struct 
gsm_lchan *lchan);
 void gscon_forget_lchan(struct gsm_subscriber_connection *conn, struct 
gsm_lchan *lchan);
diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index 7897fea..6ad6fce 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -514,6 +514,7 @@
 * flag, so that the lchan will gracefully release at the next sensible 
junction. */
bool release_requested;
bool deact_sacch;
+   bool do_rr_release;

char *last_error;

diff --git a/include/osmocom/bsc/lchan_fsm.h b/include/osmocom/bsc/lchan_fsm.h
index d2e8724..d3315a6 100644
--- a/include/osmocom/bsc/lchan_fsm.h
+++ b/include/osmocom/bsc/lchan_fsm.h
@@ -49,7 +49,7 @@
 void lchan_fsm_init();

 void lchan_fsm_alloc(struct gsm_lchan *lchan);
-void lchan_release(struct gsm_lchan *lchan, bool sacch_deact,
+void lchan_release(struct gsm_lchan *lchan, bool do_deact_sacch, bool 
do_rr_release,
   bool err, enum gsm48_rr_cause cause_rr);

 struct lchan_activate_info {
diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c
index bd104ed..ea537fe 100644
--- a/src/osmo-bsc/abis_rsl.c
+++ b/src/osmo-bsc/abis_rsl.c
@@ -901,7 +901,7 @@
 * the connection will presumably be torn down and lead to an lchan 
release. During initial
 * Channel Request from the MS, an lchan has no conn yet, so in that 
case release now. */
if (!lchan->conn) {
-   lchan_release(lchan, false, true, *cause_p);
+   lchan_release(lchan, false, false, true, *cause_p);
} else
osmo_fsm_inst_dispatch(lchan->conn->fi, GSCON_EV_RSL_CONN_FAIL, 
(void*)cause_p);

diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c
index 3f553ff..653681e 100644
--- a/src/osmo-bsc/assignment_fsm.c
+++ b/src/osmo-bsc/assignment_fsm.c
@@ -98,7 +98,7 @@
if (conn->assignment.new_lchan) {
struct gsm_lchan *lchan = conn->assignment.new_lchan;
conn->assignment.new_lchan = NULL;
-   lchan_release(lchan, false, true, RSL_ERR_EQUIPMENT_FAIL);
+   lchan_release(lchan, false, false, true, 
RSL_ERR_EQUIPMENT_FAIL);
}

if (conn->assignment.created_ci_for_msc) {
@@ -213,7 +213,7 @@
  

Change in osmo-ttcn3-hacks[master]: disable tcpdump

[Neels Hofmeyr]

Neels Hofmeyr has abandoned this change. ( https://gerrit.osmocom.org/11663 )

Change subject: disable tcpdump
..


Abandoned
--
To view, visit https://gerrit.osmocom.org/11663
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I46116df68b2f8c9ca253a9285d0a571904521727
Gerrit-Change-Number: 11663
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-CC: Jenkins Builder (102)

Change in osmo-ttcn3-hacks[master]: disable tcpdump

[Neels Hofmeyr]

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/11663


Change subject: disable tcpdump
..

disable tcpdump

Change-Id: I46116df68b2f8c9ca253a9285d0a571904521727
---
M ttcn3-tcpdump-start.sh
M ttcn3-tcpdump-stop.sh
2 files changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/63/11663/1

diff --git a/ttcn3-tcpdump-start.sh b/ttcn3-tcpdump-start.sh
index 395941d..0659df1 100755
--- a/ttcn3-tcpdump-start.sh
+++ b/ttcn3-tcpdump-start.sh
@@ -4,6 +4,8 @@
 TCPDUMP=/usr/sbin/tcpdump
 TESTCASE=$1

+exit 0
+
 if [ "z$TTCN3_PCAP_PATH" = "z" ]; then
TTCN3_PCAP_PATH=/tmp
 fi
diff --git a/ttcn3-tcpdump-stop.sh b/ttcn3-tcpdump-stop.sh
index 9404841..15c34cb 100755
--- a/ttcn3-tcpdump-stop.sh
+++ b/ttcn3-tcpdump-stop.sh
@@ -11,6 +11,8 @@
 fi
 echo

+exit 0
+
 if [ "z$TTCN3_PCAP_PATH" = "z" ]; then
TTCN3_PCAP_PATH=/tmp
 fi

--
To view, visit https://gerrit.osmocom.org/11663
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I46116df68b2f8c9ca253a9285d0a571904521727
Gerrit-Change-Number: 11663
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 

Change in osmo-ttcn3-hacks[master]: bsc: check channel release message presence

[Neels Hofmeyr]

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/11662


Change subject: bsc: check channel release message presence
..

bsc: check channel release message presence

Instead of vaguely allowing any release messages to be present or not, exactly
pinpoint for each test case the exact release messages expected during lchan
release.

Related: an osmo-bsc change broke sending of RR Release messages, which was
utterly ignored and hence not caught by ttcn tests. That must not happen again.

I am not actually sure that these expectations are 100% correct; if errors
become apparent, we shall change the expectations in ttcn3 and then fix
osmo-bsc according to that.

Adjust f_expect_chan_rel() and callers,
and the Assignment procedures (as_assignment and f_establish_fully).

The current state of the bsc tests should all pass with osmo-bsc
Id3301df059582da2377ef82feae554e94fa42035

Related: OS#3413
Change-Id: Ibc64058f1e214bea585f4e8dcb66f3df8ead3845
---
M bsc/BSC_Tests.ttcn
M bsc/MSC_ConnectionHandler.ttcn
2 files changed, 53 insertions(+), 17 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/62/11662/1

diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index b1f3a31..e06f496 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -429,7 +429,7 @@

/* expect BSC to disable the channel again if there's no response from 
MSC */
/* MS waits 20s (T3210) at LU; 10s (T3230) at CM SERV REQ and 5s 
(T3220) AT detach */
-   f_expect_chan_rel(0, chan_nr);
+   f_expect_chan_rel(0, chan_nr, expect_rll_rel_req := false);
setverdict(pass);
 }

@@ -450,7 +450,7 @@
BSSAP.send(ts_BSSAP_DISC_req(rx_c_ind.connectionId, 0));

/* expect BSC to disable the channel */
-   f_expect_chan_rel(0, chan_nr);
+   f_expect_chan_rel(0, chan_nr, expect_rll_rel_req := false);
setverdict(pass);
 }

@@ -817,32 +817,38 @@
 }

 function f_expect_chan_rel(integer bts_nr, RslChannelNr rsl_chan_nr,
-  boolean handle_rll_rel := true) runs on test_CT {
+  boolean expect_deact_sacch := true,
+  boolean expect_rr_chan_rel := true,
+  boolean expect_rll_rel_req := true,
+  boolean handle_rll_rel := true
+  ) runs on test_CT {

var RslLinkId main_dcch := valueof(ts_RslLinkID_DCCH(0));
var octetstring l3_rr_chan_rel := '060D00'O;
+   var boolean got_deact_sacch := false;
+   var boolean got_rr_chan_rel := false;
+   var boolean got_rll_rel_req := false;
+   log("f_expect_chan_rel() expecting: expect_deact_sacch=", 
expect_deact_sacch, " expect_rr_chan_rel=", expect_rr_chan_rel,
+   " expect_rll_rel_req=", expect_rll_rel_req);
alt {
-   /* ignore DEACTIVATE SACCH (if any) */
[] IPA_RSL[bts_nr].receive(tr_ASP_RSL_UD(IPAC_PROTO_RSL_TRX0,
tr_RSL_DEACT_SACCH(rsl_chan_nr))) {
+   got_deact_sacch := true;
repeat;
}
[] IPA_RSL[bts_nr].receive(tr_ASP_RSL_UD(IPAC_PROTO_RSL_TRX0, 
tr_RSL_DATA_REQ(rsl_chan_nr, ?, l3_rr_chan_rel))) {
+   got_rr_chan_rel := true;
repeat;
}
-   /* acknowledge RLL release (if any)*/
-   [handle_rll_rel] 
IPA_RSL[bts_nr].receive(tr_ASP_RSL_UD(IPAC_PROTO_RSL_TRX0,
+   [] IPA_RSL[bts_nr].receive(tr_ASP_RSL_UD(IPAC_PROTO_RSL_TRX0,
tr_RSL_REL_REQ(rsl_chan_nr, ?))) {
+   got_rll_rel_req := true;
/* FIXME: Why are we getting this for LinkID SACCH? */
-   f_ipa_tx(0, ts_RSL_REL_CONF(rsl_chan_nr, main_dcch));
+   if (handle_rll_rel) {
+   f_ipa_tx(0, ts_RSL_REL_CONF(rsl_chan_nr, main_dcch));
+   }
repeat;
}
-   [not handle_rll_rel] 
IPA_RSL[bts_nr].receive(tr_ASP_RSL_UD(IPAC_PROTO_RSL_TRX0,
-   tr_RSL_REL_REQ(rsl_chan_nr, ?))) {
-   /* Do not reply, just continue */
-   repeat;
-   }
-   /* Expect RF channel release from BSC on Abis */
[] IPA_RSL[bts_nr].receive(tr_ASP_RSL_UD(IPAC_PROTO_RSL_TRX0,

tr_RSL_MsgTypeD(RSL_MT_RF_CHAN_REL))) {
/* respond with CHAN REL ACK */
@@ -853,6 +859,19 @@
repeat;
}
}
+
+   log("f_expect_chan_rel() summary: got_deact_sacch=", got_deact_sacch, " 
got_rr_chan_rel=", got_rr_chan_rel,
+   " got_rll_rel_req=", got_rll_rel_req);
+
+   if (expect_deact_sacch != got_deact_sacch) {
+   setverdict(fail, "f_expect_chan_rel(): expect_deact_sacch=", 
expect_deact_sacch, " got_deact_sacch=", got_deact_sacch);
+   }
+   if (expect_rr_chan_re

Change in osmo-ttcn3-hacks[master]: bsc: remove flush from f_expect_chan_rel

[Neels Hofmeyr]

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/11658


Change subject: bsc: remove flush from f_expect_chan_rel
..

bsc: remove flush from f_expect_chan_rel

When we're expecting release, it can be non-deterministic / timing dependent to
flush the RSL queue. Particularly the RR Release message is typically already
in the queue when f_expect_chan_rel() is called and would be lost.

It turns out that none of the current callers need the flush feature.

If a test needs it, we can add a separate f_rsl_flush() function and call that,
no need to clutter up the f_expect_chan_rel() argument list. I had such
function but found that no caller needs it, so dropped it.

Related: OS#3413
Change-Id: Ie1be30c3f109dda8c58c523df508211f8e20aad3
---
M bsc/BSC_Tests.ttcn
1 file changed, 3 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/58/11658/1

diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index e3ac707..551ffe0 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -824,14 +824,10 @@
setverdict(pass);
 }

-function f_expect_chan_rel(integer bts_nr, RslChannelNr rsl_chan_nr, boolean 
flush := true,
+function f_expect_chan_rel(integer bts_nr, RslChannelNr rsl_chan_nr,
   boolean handle_rll_rel := true) runs on test_CT {

var RslLinkId main_dcch := valueof(ts_RslLinkID_DCCH(0));
-   if (flush) {
-   /* Clear the queue, it might still contain stuff like IMMEDIATE 
ASSIGN */
-   IPA_RSL[bts_nr].clear;
-   }
alt {
/* ignore DEACTIVATE SACCH (if any) */
[] IPA_RSL[bts_nr].receive(tr_ASP_RSL_UD(IPAC_PROTO_RSL_TRX0,
@@ -912,7 +908,7 @@
/* release the SCCP connection */
BSSAP.send(ts_BSSAP_DISC_req(dt.sccp_conn_id, 0));

-   f_expect_chan_rel(0, dt.rsl_chan_nr, true, false);
+   f_expect_chan_rel(0, dt.rsl_chan_nr, handle_rll_rel := false);
setverdict(pass);
 }

@@ -934,7 +930,7 @@
[] BSSAP.receive(tr_BSSAP_DISC_ind(dt.sccp_conn_id, ?, ?)) { }
}

-   f_expect_chan_rel(0, dt.rsl_chan_nr, false);
+   f_expect_chan_rel(0, dt.rsl_chan_nr);
setverdict(pass);
 }


--
To view, visit https://gerrit.osmocom.org/11658
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie1be30c3f109dda8c58c523df508211f8e20aad3
Gerrit-Change-Number: 11658
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 

Change in osmo-ttcn3-hacks[master]: bsc: handle RR Release messages

[Neels Hofmeyr]

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/11660


Change subject: bsc: handle RR Release messages
..

bsc: handle RR Release messages

Receive RR Release messages if they happen during lchan release. Add RR Release
to the alt{}s in both f_expect_chan_rel() to cover a whole bunch of test cases,
and in f_tc_ho_out_fail_no_ho_detect() which has its own release expectations.

Before this, RR Release messages would typically be lost in the RSL.clear
recently removed by Ie1be30c3f109dda8c58c523df508211f8e20aad3.

However, I still expect tests to pass after this, since the current osmo-bsc
master has a bug that omits RR Release messages (since [1]).

By applying this patch, both the buggy osmo-bsc (omitting RR Release) and the
fix of that [2] should pass the BSC tests. So far by accepting whatever comes
along, and not complaining if it doesn't come along.

A subsequent patch will more precisely ensure that exactly the expected
messages will be sent by osmo-bsc (Ibc64058f1e214bea585f4e8dcb66f3df8ead3845).

[1] osmo-bsc I4fd582b41ba4599af704d670af83651d2450b1db
commit 8b818a01b00ea3daad4ad58c162ac52b4f08a5cb
"subscr conn: properly forget lchan before release"

[2] osmo-bsc I666b3b4f45706d898d664d380bd0fd2b018be358
"fix: send RR Release (e.g. after BSSMAP Clear Cmd"

Related: OS#3413
Change-Id: I4e6d266d091b140f56b28312cb3c5d67ffcc3a59
---
M bsc/BSC_Tests.ttcn
1 file changed, 8 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/60/11660/1

diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index a2a3378..fcccad0 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -820,12 +820,16 @@
   boolean handle_rll_rel := true) runs on test_CT {

var RslLinkId main_dcch := valueof(ts_RslLinkID_DCCH(0));
+   var octetstring l3_rr_chan_rel := '060D00'O;
alt {
/* ignore DEACTIVATE SACCH (if any) */
[] IPA_RSL[bts_nr].receive(tr_ASP_RSL_UD(IPAC_PROTO_RSL_TRX0,
tr_RSL_DEACT_SACCH(rsl_chan_nr))) {
repeat;
}
+   [] IPA_RSL[bts_nr].receive(tr_ASP_RSL_UD(IPAC_PROTO_RSL_TRX0, 
tr_RSL_DATA_REQ(rsl_chan_nr, ?, l3_rr_chan_rel))) {
+   repeat;
+   }
/* acknowledge RLL release (if any)*/
[handle_rll_rel] 
IPA_RSL[bts_nr].receive(tr_ASP_RSL_UD(IPAC_PROTO_RSL_TRX0,
tr_RSL_REL_REQ(rsl_chan_nr, ?))) {
@@ -2441,7 +2445,11 @@
 * RR should be released and Clear Request should go to the MSC. */

var MgcpCommand mgcp;
+   var octetstring l3_rr_chan_rel := '060D00'O;
interleave {
+   [] RSL.receive(tr_RSL_DATA_REQ(g_chan_nr, ?, l3_rr_chan_rel)) {
+   log("Got RR Release");
+   }
[] RSL.receive(tr_RSL_MsgTypeD(RSL_MT_RF_CHAN_REL)) {
log("Got RF Chan Rel");
RSL.send(ts_RSL_RF_CHAN_REL_ACK(g_chan_nr));

--
To view, visit https://gerrit.osmocom.org/11660
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4e6d266d091b140f56b28312cb3c5d67ffcc3a59
Gerrit-Change-Number: 11660
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 

Change in osmo-ttcn3-hacks[master]: bsc: handle Deact SACCH messages

[Neels Hofmeyr]

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/11661


Change subject: bsc: handle Deact SACCH messages
..

bsc: handle Deact SACCH messages

Allow osmo-bsc sending a Deact SACCH messages in most cases. Prepare the
ttcn3-bsc-tests to not break just because of those messages that will soon be
sent.

When releasing an lchan, it makes sense to Deactivate SACCH on it, if it was
ever active. So far osmo-bsc was fairly reluctant to send Deactivate SACCH, but
osmo-bsc Id3301df059582da2377ef82feae554e94fa42035 is about to change that.

In most test cases, Deact SACCH are still optional, but in one case, the
current missing Deact SACCH will introduce a test failure: in the 'interleave'
of BSC_Tests.TC_ho_out_fail_no_ho_detect.

As soon as abovementioned osmo-bsc patch is merged, the test will pass again.

Also, as soon as Ibc64058f1e214bea585f4e8dcb66f3df8ead3845 is merged here, the
bsc tests will properly ensure whether Deact SACCH is sent or not in all tests.

Change-Id: I27da24dbe3184fa7a076a35f6fa6af457c1db8d2
---
M bsc/BSC_Tests.ttcn
M bsc/MSC_ConnectionHandler.ttcn
2 files changed, 10 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/61/11661/1

diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index fcccad0..b1f3a31 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -2182,6 +2182,7 @@
/* Check the amount of MGCP transactions is still consistant with the
 * test expectation */
f_check_mgcp_expectations()
+   f_sleep(0.5);
 }

 testcase TC_ho_int() runs on test_CT {
@@ -2447,6 +2448,9 @@
var MgcpCommand mgcp;
var octetstring l3_rr_chan_rel := '060D00'O;
interleave {
+   [] RSL.receive(tr_RSL_DEACT_SACCH(g_chan_nr)) {
+   log("Got Deact SACCH");
+   }
[] RSL.receive(tr_RSL_DATA_REQ(g_chan_nr, ?, l3_rr_chan_rel)) {
log("Got RR Release");
}
diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn
index 003813a..07eafc7 100644
--- a/bsc/MSC_ConnectionHandler.ttcn
+++ b/bsc/MSC_ConnectionHandler.ttcn
@@ -682,6 +682,9 @@
Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, 
log2str("Unexpected L3 received", l3));
}
}
+   [st.rr_ass_cmpl_seen] RSL.receive(tr_RSL_DEACT_SACCH(st.old_chan_nr)) {
+   repeat;
+   }
[st.rr_ass_cmpl_seen] RSL.receive(tr_RSL_REL_REQ(st.old_chan_nr, 
tr_RslLinkID_DCCH(0))) {
RSL.send(ts_RSL_REL_CONF(st.old_chan_nr, 
valueof(ts_RslLinkID_DCCH(0;
repeat;
@@ -1043,6 +1046,9 @@
}
[st.rr_ho_cmpl_seen] as_Media_ipacc();
[st.rr_ho_cmpl_seen] as_Media_mgw(true);
+   [st.rr_ho_cmpl_seen] RSL.receive(tr_RSL_DEACT_SACCH(st.old_chan_nr)) {
+   repeat;
+   }
[st.rr_ho_cmpl_seen] RSL.receive(tr_RSL_REL_REQ(st.old_chan_nr, 
tr_RslLinkID_DCCH(0))) {
RSL.send(ts_RSL_REL_CONF(st.old_chan_nr, 
valueof(ts_RslLinkID_DCCH(0;
repeat;

--
To view, visit https://gerrit.osmocom.org/11661
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I27da24dbe3184fa7a076a35f6fa6af457c1db8d2
Gerrit-Change-Number: 11661
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 

Change in osmo-ttcn3-hacks[master]: bsc: TC_chan_act_ack_est_ind_noreply: use f_expect_chan_rel

[Neels Hofmeyr]

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/11659


Change subject: bsc: TC_chan_act_ack_est_ind_noreply: use f_expect_chan_rel
..

bsc: TC_chan_act_ack_est_ind_noreply: use f_expect_chan_rel

Instead of placing an own set of channel release expectations, just use the
common f_expect_chan_rel() that exists for exactly this purpose.

This will also be in line with upcoming changes to tighten checking of the
lchan release messages.

Related: OS#3413
Change-Id: Ib7dd886472337e2deb968e6f9de6cecdb7855319
---
M bsc/BSC_Tests.ttcn
1 file changed, 1 insertion(+), 9 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/59/11659/1

diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index 551ffe0..a2a3378 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -429,15 +429,7 @@

/* expect BSC to disable the channel again if there's no response from 
MSC */
/* MS waits 20s (T3210) at LU; 10s (T3230) at CM SERV REQ and 5s 
(T3220) AT detach */
-   IPA_RSL[0].clear;
-   alt {
-   [] IPA_RSL[0].receive(tr_ASP_RSL_UD(sid, 
tr_RSL_MsgTypeD(RSL_MT_RF_CHAN_REL))) -> value rx_rsl_ud { }
-   [] IPA_RSL[0].receive(tr_ASP_RSL_UD(sid, tr_RSL_REL_REQ(chan_nr, ?))) 
-> value rx_rsl_ud {
-   f_ipa_tx(0, ts_RSL_REL_CONF(chan_nr, main_dcch));
-   repeat;
-   }
-   }
-
+   f_expect_chan_rel(0, chan_nr);
setverdict(pass);
 }


--
To view, visit https://gerrit.osmocom.org/11659
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib7dd886472337e2deb968e6f9de6cecdb7855319
Gerrit-Change-Number: 11659
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 

Change in osmo-bsc[master]: prevent a NULL pointer dereference in debug_candidate()

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11630 )

Change subject: prevent a NULL pointer dereference in debug_candidate()
..


Patch Set 1:

Neels,

> Related: CID#10


--
To view, visit https://gerrit.osmocom.org/11630
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3d672d835bbc136809e593a819a6dda7c84a88e
Gerrit-Change-Number: 11630
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Thu, 08 Nov 2018 00:05:17 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: library/GSUP_Types.ttcn: introduce new InvokeID IE

[Vadim Yanitskiy]

Vadim Yanitskiy has abandoned this change. ( https://gerrit.osmocom.org/11640 )

Change subject: library/GSUP_Types.ttcn: introduce new InvokeID IE
..


Abandoned
--
To view, visit https://gerrit.osmocom.org/11640
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ib7ed702cb05328dc4d1f459efc93df4fa947d7ae
Gerrit-Change-Number: 11640
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 

Change in libosmocore[master]: GSUP: introduce new InvokeID Information Element

[Vadim Yanitskiy]

Vadim Yanitskiy has abandoned this change. ( https://gerrit.osmocom.org/11633 )

Change subject: GSUP: introduce new InvokeID Information Element
..


Abandoned
--
To view, visit https://gerrit.osmocom.org/11633
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: If14006b035ff465b73b39ea4cd59e5fd16a4d7ff
Gerrit-Change-Number: 11633
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-bsc[master]: prevent a NULL pointer dereference in debug_candidate()

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11630 )

Change subject: prevent a NULL pointer dereference in debug_candidate()
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/11630/1/src/osmo-bsc/handover_decision_2.c
File src/osmo-bsc/handover_decision_2.c:

https://gerrit.osmocom.org/#/c/11630/1/src/osmo-bsc/handover_decision_2.c@844
PS1, Line 844:  }
AFAICT the logic was already sound.

lchan->ts->trx->bts by definition is never NULL, hence we never hit a NULL 
dereference situation? Where is this coming from, reading code, a coverity 
warning or actual failure?

(If this remains valid, then rather exit-early like if (!candidate->bts) 
return;)



--
To view, visit https://gerrit.osmocom.org/11630
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3d672d835bbc136809e593a819a6dda7c84a88e
Gerrit-Change-Number: 11630
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Wed, 07 Nov 2018 19:15:55 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in docker-playground[master]: Add ttcn3-bscnat-test docker image

[daniel]

daniel has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/11657 )

Change subject: Add ttcn3-bscnat-test docker image
..

Add ttcn3-bscnat-test docker image

Run the bscnat ttcn3 tests in docker. This uses the osmo-nitb-master
image since osmo-bsc_nat is built there as well.

Change-Id: Ibeebb0325d3d1976225666eb28db0741df2e66f0
---
A ttcn3-bscnat-test/BSCNAT_Tests.cfg
A ttcn3-bscnat-test/Dockerfile
A ttcn3-bscnat-test/Makefile
A ttcn3-bscnat-test/bscs.config
A ttcn3-bscnat-test/jenkins.sh
A ttcn3-bscnat-test/osmo-bsc-nat.cfg
6 files changed, 190 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/docker-playground 
refs/changes/57/11657/2
--
To view, visit https://gerrit.osmocom.org/11657
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibeebb0325d3d1976225666eb28db0741df2e66f0
Gerrit-Change-Number: 11657
Gerrit-PatchSet: 2
Gerrit-Owner: daniel 

Change in docker-playground[master]: Add ttcn3-bscnat-test docker image

[daniel]

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/11657


Change subject: Add ttcn3-bscnat-test docker image
..

Add ttcn3-bscnat-test docker image

Run the bscnat ttcn3 tests in docker. This uses the osmo-nitb-master
image since osmo-bsc_nat is built there as well.

Change-Id: Ibeebb0325d3d1976225666eb28db0741df2e66f0
---
A ttcn3-bscnat-test/BSCNAT_Tests.cfg
A ttcn3-bscnat-test/Dockerfile
A ttcn3-bscnat-test/Makefile
A ttcn3-bscnat-test/bscs.config
A ttcn3-bscnat-test/jenkins.sh
A ttcn3-bscnat-test/osmo-bsc-nat.cfg
6 files changed, 183 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/docker-playground 
refs/changes/57/11657/1

diff --git a/ttcn3-bscnat-test/BSCNAT_Tests.cfg 
b/ttcn3-bscnat-test/BSCNAT_Tests.cfg
new file mode 100644
index 000..e45061d
--- /dev/null
+++ b/ttcn3-bscnat-test/BSCNAT_Tests.cfg
@@ -0,0 +1,30 @@
+[ORDERED_INCLUDE]
+"/osmo-ttcn3-hacks/Common.cfg"
+"/osmo-ttcn3-hacks/bsc-nat/BSCNAT_Tests.default"
+
+[LOGGING]
+*.JUnitLogger.testsuite_name := "BSCNAT_Tests"
+
+[TESTPORT_PARAMETERS]
+
+[MODULE_PARAMETERS]
+mp_bsc_port := 4;
+mp_bsc_ip   := "172.18.11.203";
+mp_msc_port := 5100;
+mp_msc_ip   := "172.18.11.203";
+mp_nat_port := 5000;
+mp_nat_ip   := "172.18.11.20";
+
+#mp_ipa_mgcp_uses_osmo_ext := true;
+
+mp_mgcp_uses_udp := true;
+mp_callagent_ip := "172.18.11.203";
+mp_callagent_udp_port := 2727;
+mp_mgw_ip := "172.18.11.20";
+mp_mgw_udp_port := 2427;
+
+[MAIN_CONTROLLER]
+
+[EXECUTE]
+BSCNAT_Tests.control
+#BSCNAT_Tests.TC_recv_dump
diff --git a/ttcn3-bscnat-test/Dockerfile b/ttcn3-bscnat-test/Dockerfile
new file mode 100644
index 000..10acf98
--- /dev/null
+++ b/ttcn3-bscnat-test/Dockerfile
@@ -0,0 +1,32 @@
+FROM   laforge/debian-stretch-titan
+
+RUNmkdir /root/projects && (cd /root/projects && ln -sf / git)
+RUNgit clone git://git.osmocom.org/osmo-ttcn3-hacks.git
+
+RUNcd osmo-ttcn3-hacks && \
+   git checkout -f -B master origin/master && \
+   make deps
+
+RUNgit config --global user.email doc...@dock.er && \
+   git config --global user.name "Dock Er"
+
+ARGOSMO_TTCN3_BRANCH="master"
+
+ADDhttp://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH 
/tmp/commit
+RUNcd osmo-ttcn3-hacks && \
+   git fetch && \
+   git checkout -f -B $OSMO_TTCN3_BRANCH origin/$OSMO_TTCN3_BRANCH && \
+   make bsc-nat
+
+VOLUME /data
+
+RUNln -s /osmo-ttcn3-hacks/ttcn3-tcpdump-start.sh / && \
+   ln -s /osmo-ttcn3-hacks/ttcn3-tcpdump-stop.sh /
+
+COPY   BSCNAT_Tests.cfg /data/BSCNAT_Tests.cfg
+
+CMDcd /data && \
+   /osmo-ttcn3-hacks/start-testsuite.sh 
/osmo-ttcn3-hacks/bsc-nat/BSCNAT_Tests; \
+   exit_code=$?; \
+   /osmo-ttcn3-hacks/log_merge.sh BSCNAT_Tests --rm; \
+   exit $exit_code
diff --git a/ttcn3-bscnat-test/Makefile b/ttcn3-bscnat-test/Makefile
new file mode 100644
index 000..0895788
--- /dev/null
+++ b/ttcn3-bscnat-test/Makefile
@@ -0,0 +1,2 @@
+
+include ../make/Makefile
diff --git a/ttcn3-bscnat-test/bscs.config b/ttcn3-bscnat-test/bscs.config
new file mode 100644
index 000..6afa09b
--- /dev/null
+++ b/ttcn3-bscnat-test/bscs.config
@@ -0,0 +1,19 @@
+nat
+ bsc 0
+  token BSC0
+  location_area_code 1
+  description bsc
+  max-endpoints 32
+  paging forbidden 0
+ bsc 1
+  token BSC1
+  location_area_code 2
+  description bsc
+  max-endpoints 32
+  paging forbidden 0
+ bsc 2
+  token BSC2
+  location_area_code 3
+  description bsc
+  max-endpoints 32
+  paging forbidden 0
diff --git a/ttcn3-bscnat-test/jenkins.sh b/ttcn3-bscnat-test/jenkins.sh
new file mode 100755
index 000..d54a31a
--- /dev/null
+++ b/ttcn3-bscnat-test/jenkins.sh
@@ -0,0 +1,33 @@
+#!/bin/sh
+
+. ../jenkins-common.sh
+
+mkdir $VOL_BASE_DIR/bscnat-tester
+cp BSCNAT_Tests.cfg $VOL_BASE_DIR/bscnat-tester/
+
+mkdir $VOL_BASE_DIR/bscnat
+cp osmo-bsc-nat.cfg $VOL_BASE_DIR/bscnat/
+cp bscs.config $VOL_BASE_DIR/bscnat/
+
+network_create 172.18.11.0/24
+
+echo Starting container with BSCNAT
+docker run --rm \
+   --network $NET_NAME --ip 172.18.11.20 \
+   -v $VOL_BASE_DIR/bscnat:/data \
+   --name ${BUILD_TAG}-bscnat -d \
+   $REPO_USER/osmo-nitb-master /usr/local/bin/osmo-bsc_nat -c 
/data/osmo-bsc-nat.cfg
+
+echo Starting container with BSCNAT testsuite
+docker run --rm \
+   --network $NET_NAME --ip 172.18.11.203 \
+   -e "TTCN3_PCAP_PATH=/data" \
+   -v $VOL_BASE_DIR/bscnat-tester:/data \
+   --name ${BUILD_TAG}-ttcn3-bscnat-test \
+   $REPO_USER/ttcn3-bscnat-test
+
+echo Stopping containers
+docker container kill ${BUILD_TAG}-bscnat
+
+network_remove
+collect_logs
diff --git a/ttcn3-bscnat-test/osmo-bsc-nat.cfg 
b/ttcn3-bscnat-test/osmo-bsc-nat.cfg
new file mode 100644
index 000..4f02366
--- /dev/null
+++ b/ttcn3-bscnat-test/osmo-bsc-nat.cfg
@@ -0,0 +1,67 @@
+!
+! OsmoBSCNAT (0.12.0

Change in osmo-ttcn3-hacks[master]: bsc: Introduce test TC_paging_resp_unsol

[Pau Espin Pedrol]

Hello Vadim Yanitskiy, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11604

to look at the new patch set (#2).

Change subject: bsc: Introduce test TC_paging_resp_unsol
..

bsc: Introduce test TC_paging_resp_unsol

With this test we want to verify that channels are released if BSC fails
to complete an L3 request, for instance because no pending Paging
CMD is found for a received Paging Response.

Related: OS#3680
Change-Id: Iabe8a51aa13d2fcfec4500cf7aab47d60cc138ce
---
M bsc/BSC_Tests.ttcn
M bsc/expected-results.xml
2 files changed, 26 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/04/11604/2
--
To view, visit https://gerrit.osmocom.org/11604
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iabe8a51aa13d2fcfec4500cf7aab47d60cc138ce
Gerrit-Change-Number: 11604
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 

Change in osmo-dev[master]: replace src/* git scripts with a single src/gits

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11560 )

Change subject: replace src/* git scripts with a single src/gits
..


Patch Set 7:

Are we through with this now?


--
To view, visit https://gerrit.osmocom.org/11560
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I579e7af26d76d5c5d83b2349695456bc7b54f5a2
Gerrit-Change-Number: 11560
Gerrit-PatchSet: 7
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 07 Nov 2018 16:26:25 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-dev[master]: replace src/* git scripts with a single src/gits

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11560 )

Change subject: replace src/* git scripts with a single src/gits
..


Patch Set 7:

(3 comments)

https://gerrit.osmocom.org/#/c/11560/4/src/gits
File src/gits:

https://gerrit.osmocom.org/#/c/11560/4/src/gits@68
PS4, Line 68: l:
> This seems to work - do you get the same output with your version? […]
my --porcelain --long seems to be identical to just status:

  ▶ git status --porcelain --long
  On branch neels/wip
  Your branch and 'origin/neels/wip' have diverged,
  and have 9 and 6 different commits each, respectively.
(use "git pull" to merge the remote branch into yours)

  Untracked files:
(use "git add ..." to include in what will be committed)

../d.bsc/
../m2/
../make/
../net/config_mine
../net/config_sip
../net/my_network/
../net/nitb/
../net/simcards.csv
../net/sip/
../net/tmpl_dyn/
../openbsc/
../quick_vty_tests.opts

  nothing added to commit but untracked files present (use "git add" to track)


https://gerrit.osmocom.org/#/c/11560/4/src/gits@359
PS4, Line 359: def cmd_fetch():
> you don't need a shim for every git command, you can just put them in a list 
> and iterate over them: […]
Re: shim: the best for consistent help doc is to just add a shim.

Re argparse:
I see .. seems to me an awful lot of trouble for just sys.argv[1:].

BTW, one thing I don't like about argparse is that it removes line feeds, i.e. 
paragraphs, from the doc string. In osmo_interact I did

  parser = argparse.ArgumentParser(description=doc, 
formatter_class=argparse.RawDescriptionHelpFormatter)

but then you also need to take care of line feeds for option arg docs. All in 
all it often is more meh than yay to me.

That said, if you want to change it to argparse so that it works and looks 
good, do go ahead in a follow-up patch. ok?


https://gerrit.osmocom.org/#/c/11560/5/src/gits
File src/gits:

https://gerrit.osmocom.org/#/c/11560/5/src/gits@6
PS5, Line 6: # This program is free software: you can redistribute it and/or 
modify
> Out of curiosity: why not use the shorter SPDX form? […]
because I just copy-paste these things from elsewhere :P



--
To view, visit https://gerrit.osmocom.org/11560
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I579e7af26d76d5c5d83b2349695456bc7b54f5a2
Gerrit-Change-Number: 11560
Gerrit-PatchSet: 7
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 07 Nov 2018 16:25:53 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-dev[master]: replace src/* git scripts with a single src/gits

[Neels Hofmeyr]

Hello osmith,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11560

to look at the new patch set (#8).

Change subject: replace src/* git scripts with a single src/gits
..

replace src/* git scripts with a single src/gits

I keep re-using this functionality in completely unrelated realms, and decided
to unify the oddly named scripts in a single 'gits' meta-repos tool, so I can
just symlink this script into my ~/bin and use it everywhere.

Change-Id: I579e7af26d76d5c5d83b2349695456bc7b54f5a2
---
M src/README
D src/e
D src/g
D src/git_branch_summary.py
A src/gits
D src/s
D src/st
7 files changed, 432 insertions(+), 298 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/60/11560/8
--
To view, visit https://gerrit.osmocom.org/11560
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I579e7af26d76d5c5d83b2349695456bc7b54f5a2
Gerrit-Change-Number: 11560
Gerrit-PatchSet: 8
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 

Change in osmo-dev[master]: replace src/* git scripts with a single src/gits

[Neels Hofmeyr]

Hello osmith,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11560

to look at the new patch set (#7).

Change subject: replace src/* git scripts with a single src/gits
..

replace src/* git scripts with a single src/gits

I keep re-using this functionality in completely unrelated realms, and decided
to unify the oddly named scripts in a single 'gits' meta-repos tool, so I can
just symlink this script into my ~/bin and use it everywhere.

Change-Id: I579e7af26d76d5c5d83b2349695456bc7b54f5a2
---
M src/README
D src/e
D src/g
D src/git_branch_summary.py
A src/gits
D src/s
D src/st
7 files changed, 432 insertions(+), 298 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/60/11560/7
--
To view, visit https://gerrit.osmocom.org/11560
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I579e7af26d76d5c5d83b2349695456bc7b54f5a2
Gerrit-Change-Number: 11560
Gerrit-PatchSet: 7
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 

Change in osmo-dev[master]: 2G.deps: add osmo-sip-connector

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11635 )

Change subject: 2G.deps: add osmo-sip-connector
..

2G.deps: add osmo-sip-connector

Change-Id: I30e27e2eb0060889f167417a21894e8e411ad1e3
---
M 2G.deps
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved; Verified



diff --git a/2G.deps b/2G.deps
index c49589d..9ccb1ee 100644
--- a/2G.deps
+++ b/2G.deps
@@ -10,6 +10,7 @@
 osmo-msc   libosmo-sccp osmo-mgw libsmpp34
 osmo-bsc   libosmo-sccp osmo-mgw
 osmo-sgsn  libosmo-sccp osmo-ggsn osmo-hlr
+osmo-sip-connector libosmocore
 # osmo-trx can build with --enable-sanitize, but then won't work reliably.
 # When omitting --enable-sanitize from osmo-trx only, its 'make check' will 
fail.
 # So if you want osmo-trx, uncomment and use no sanitize.opts, or use 
LD_PRELOAD for osmo-trx binaries.

--
To view, visit https://gerrit.osmocom.org/11635
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I30e27e2eb0060889f167417a21894e8e411ad1e3
Gerrit-Change-Number: 11635
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 

Change in osmo-dev[master]: sanitize.opts: add osmo-sip-connector --enable-sanitize

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11593 )

Change subject: sanitize.opts: add osmo-sip-connector --enable-sanitize
..

sanitize.opts: add osmo-sip-connector --enable-sanitize

Otherwise it is not able to link asan-enabled libosmocore in the binaries.

Change-Id: I5e04ef38982ee6c89110776fc941ee0e2c193196
---
M sanitize.opts
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved; Verified
  osmith: Looks good to me, but someone else must approve



diff --git a/sanitize.opts b/sanitize.opts
index 40675be..7d545d2 100644
--- a/sanitize.opts
+++ b/sanitize.opts
@@ -12,3 +12,4 @@
 osmo-msc --enable-sanitize
 osmo-sgsn --enable-sanitize
 openbsc --enable-sanitize
+osmo-sip-connector --enable-sanitize

--
To view, visit https://gerrit.osmocom.org/11593
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5e04ef38982ee6c89110776fc941ee0e2c193196
Gerrit-Change-Number: 11593
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-CC: Pau Espin Pedrol 

Change in osmo-dev[master]: sanitize.opts: add osmo-sip-connector --enable-sanitize

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11593 )

Change subject: sanitize.opts: add osmo-sip-connector --enable-sanitize
..


Patch Set 3: Verified+1 Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11593
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e04ef38982ee6c89110776fc941ee0e2c193196
Gerrit-Change-Number: 11593
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 07 Nov 2018 15:55:51 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-dev[master]: deps: comment out osmo-trx

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11634 )

Change subject: deps: comment out osmo-trx
..

deps: comment out osmo-trx

osmo-trx shouldn't run with address sanitizer. But omitting --enable-sanitize
from osmo-trx breaks 'make check', so then the whole top-level makefile will
end in error with sanitize.opts.

A user wanting to build osmo-trx can just uncomment that line.

Change-Id: I589f49652f8fa4e5becc7d7e63e6e4bc1a8b33bb
---
M 2G.deps
M 3G+2G.deps
2 files changed, 8 insertions(+), 2 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved; Verified



diff --git a/2G.deps b/2G.deps
index cf2723a..c49589d 100644
--- a/2G.deps
+++ b/2G.deps
@@ -10,4 +10,7 @@
 osmo-msc   libosmo-sccp osmo-mgw libsmpp34
 osmo-bsc   libosmo-sccp osmo-mgw
 osmo-sgsn  libosmo-sccp osmo-ggsn osmo-hlr
-osmo-trx   libosmocore
+# osmo-trx can build with --enable-sanitize, but then won't work reliably.
+# When omitting --enable-sanitize from osmo-trx only, its 'make check' will 
fail.
+# So if you want osmo-trx, uncomment and use no sanitize.opts, or use 
LD_PRELOAD for osmo-trx binaries.
+#osmo-trx  libosmocore
diff --git a/3G+2G.deps b/3G+2G.deps
index b82e7c9..e5d53fa 100644
--- a/3G+2G.deps
+++ b/3G+2G.deps
@@ -13,4 +13,7 @@
 osmo-bsc   libosmo-sccp osmo-mgw
 osmo-sgsn  osmo-iuh osmo-ggsn osmo-hlr
 osmo-sip-connector libosmocore
-osmo-trx   libosmocore
+# osmo-trx can build with --enable-sanitize, but then won't work reliably.
+# When omitting --enable-sanitize from osmo-trx only, its 'make check' will 
fail.
+# So if you want osmo-trx, uncomment and use no sanitize.opts, or use 
LD_PRELOAD for osmo-trx binaries.
+#osmo-trx  libosmocore

--
To view, visit https://gerrit.osmocom.org/11634
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I589f49652f8fa4e5becc7d7e63e6e4bc1a8b33bb
Gerrit-Change-Number: 11634
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 

Change in osmo-dev[master]: 2G.deps: add osmo-sip-connector

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11635 )

Change subject: 2G.deps: add osmo-sip-connector
..


Patch Set 2: Verified+1 Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11635
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30e27e2eb0060889f167417a21894e8e411ad1e3
Gerrit-Change-Number: 11635
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 07 Nov 2018 15:55:35 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-dev[master]: deps: comment out osmo-trx

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11634 )

Change subject: deps: comment out osmo-trx
..


Patch Set 2: Verified+1 Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11634
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I589f49652f8fa4e5becc7d7e63e6e4bc1a8b33bb
Gerrit-Change-Number: 11634
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 07 Nov 2018 15:55:01 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-dev[master]: 2G.deps: add osmo-sip-connector

[Neels Hofmeyr]

Hello osmith,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11635

to look at the new patch set (#2).

Change subject: 2G.deps: add osmo-sip-connector
..

2G.deps: add osmo-sip-connector

Change-Id: I30e27e2eb0060889f167417a21894e8e411ad1e3
---
M 2G.deps
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/35/11635/2
--
To view, visit https://gerrit.osmocom.org/11635
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I30e27e2eb0060889f167417a21894e8e411ad1e3
Gerrit-Change-Number: 11635
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: osmith 

Change in osmo-dev[master]: deps: comment out osmo-trx

[Neels Hofmeyr]

Hello osmith,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11634

to look at the new patch set (#2).

Change subject: deps: comment out osmo-trx
..

deps: comment out osmo-trx

osmo-trx shouldn't run with address sanitizer. But omitting --enable-sanitize
from osmo-trx breaks 'make check', so then the whole top-level makefile will
end in error with sanitize.opts.

A user wanting to build osmo-trx can just uncomment that line.

Change-Id: I589f49652f8fa4e5becc7d7e63e6e4bc1a8b33bb
---
M 2G.deps
M 3G+2G.deps
2 files changed, 8 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/34/11634/2
--
To view, visit https://gerrit.osmocom.org/11634
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I589f49652f8fa4e5becc7d7e63e6e4bc1a8b33bb
Gerrit-Change-Number: 11634
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: osmith 

Change in osmo-sgsn[master]: use enums consistently instead of falling back to int

[Stefan Sperling]

Stefan Sperling has uploaded this change for review. ( 
https://gerrit.osmocom.org/11656


Change subject: use enums consistently instead of falling back to int
..

use enums consistently instead of falling back to int

The two existing enums defined in gprs_sndcp_xid.h, for protocol
and data compression algorithm numbers respectively, were assigned
to 'int' variables when their values were copied to other structures.

This prevented the compiler from checking the enum value coverage
during switch statements and also tripped up Coverity scans looking
for enum value mismatch problems.

So instead of copying enums to ints, make use of the enums throughout.
Structures which can contain values from both enums now use a union
of both, forcing us to be very explicit about which set of values
we are dealing with.

Change-Id: I3771a5c59f4e6fee24083b3c914965baf192cbd7
Related: CID#149102
---
M include/osmocom/sgsn/gprs_sndcp_comp.h
M include/osmocom/sgsn/gprs_sndcp_xid.h
M src/gprs/gprs_sndcp.c
M src/gprs/gprs_sndcp_comp.c
M src/gprs/gprs_sndcp_dcomp.c
M src/gprs/gprs_sndcp_pcomp.c
M src/gprs/gprs_sndcp_xid.c
M tests/sndcp_xid/sndcp_xid_test.c
8 files changed, 177 insertions(+), 81 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/56/11656/1

diff --git a/include/osmocom/sgsn/gprs_sndcp_comp.h 
b/include/osmocom/sgsn/gprs_sndcp_comp.h
index c04f7d4..1573132 100644
--- a/include/osmocom/sgsn/gprs_sndcp_comp.h
+++ b/include/osmocom/sgsn/gprs_sndcp_comp.h
@@ -41,9 +41,12 @@
uint8_t comp[MAX_COMP]; /* see also: 6.5.1.1.5 and 6.6.1.1.5 */

/* Algorithm parameters */
-   int algo;   /* Algorithm type (see gprs_sndcp_xid.h) */
-   int compclass;  /* See gprs_sndcp_xid.h/c */
-   void *state;/* Algorithm status and parameters */
+   union {
+   enum gprs_sndcp_hdr_comp_algo pcomp;
+   enum gprs_sndcp_data_comp_algo dcomp;
+   } algo; /* Algorithm type (see 
gprs_sndcp_xid.h) */
+   enum gprs_sndcp_xid_param_types compclass;  /* See 
gprs_sndcp_xid.h/c */
+   void *state;/* Algorithm status and 
parameters */
 };

 #define MAX_COMP 16/* Maximum number of possible pcomp/dcomp values */
diff --git a/include/osmocom/sgsn/gprs_sndcp_xid.h 
b/include/osmocom/sgsn/gprs_sndcp_xid.h
index e64bc52..2b63f50 100644
--- a/include/osmocom/sgsn/gprs_sndcp_xid.h
+++ b/include/osmocom/sgsn/gprs_sndcp_xid.h
@@ -32,6 +32,19 @@
 #define MAX_NSAPI 11   /* Maximum number usable NSAPIs */
 #define MAX_ROHC 16/* Maximum number of ROHC compression profiles */

+/* According to: 3GPP TS 44.065, 6.5.1.1.4 Algorithm identifier */
+enum gprs_sndcp_hdr_comp_algo {
+   RFC_1144,   /* TCP/IP header compression, see also 6.5.2 */
+   RFC_2507,   /* TCP/UDP/IP header compression, see also: 
6.5.3 */
+   ROHC/* Robust Header Compression, see also 6.5.4 */
+};
+
+/* According to: 3GPP TS 44.065, 6.5.1.1.4 Algorithm identifier */
+enum gprs_sndcp_data_comp_algo {
+   V42BIS, /* V.42bis data compression, see also 6.6.2 */
+   V44 /* V44 data compression, see also: 6.6.3 */
+};
+
 /* According to: 3GPP TS 44.065, 6.5.1.1 Format of the protocol control
  * information compression field (Figure 7) and 3GPP TS 44.065,
  * 6.6.1.1 Format of the data compression field (Figure 9) */
@@ -45,7 +58,10 @@
unsigned int entity;

/* Algorithm identifier, see also: 6.5.1.1.4 and 6.6.1.1.4 */
-   int algo;
+   union {
+   enum gprs_sndcp_hdr_comp_algo pcomp;
+   enum gprs_sndcp_data_comp_algo dcomp;
+   } algo;

/* Number of contained PCOMP / DCOMP values */
uint8_t comp_len;
@@ -62,24 +78,12 @@
struct gprs_sndcp_dcomp_v44_params *v44_params;
 };

-/* According to: 3GPP TS 44.065, 6.5.1.1.4 Algorithm identifier */
-enum gprs_sndcp_hdr_comp_algo {
-   RFC_1144,   /* TCP/IP header compression, see also 6.5.2 */
-   RFC_2507,   /* TCP/UDP/IP header compression, see also: 
6.5.3 */
-   ROHC/* Robust Header Compression, see also 6.5.4 */
-};
-
-/* According to: 3GPP TS 44.065, 6.5.1.1.4 Algorithm identifier */
-enum gprs_sndcp_data_comp_algo {
-   V42BIS, /* V.42bis data compression, see also 6.6.2 */
-   V44 /* V44 data compression, see also: 6.6.3 */
-};
-
 /* According to: 3GPP TS 44.065, 8 SNDCP XID parameters */
 enum gprs_sndcp_xid_param_types {
SNDCP_XID_VERSION_NUMBER,
SNDCP_XID_DATA_COMPRESSION, /* See also: subclause 6.6.1 */
SNDCP_XID_PROTOCOL_COMPRESSION, /* See also: subclause 6.5.1 */
+   SNDCP_XID_INVALID_COMPRESSION   /* Not part of the spec; this means we 
found an invalid value *

Change in osmo-dev[master]: deps: comment out osmo-trx

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/11634 )

Change subject: deps: comment out osmo-trx
..


Patch Set 1: Code-Review-1

Actually... how about adding a comment on top that describes why this was 
commented out?

  # does not work with address sanitizer


--
To view, visit https://gerrit.osmocom.org/11634
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I589f49652f8fa4e5becc7d7e63e6e4bc1a8b33bb
Gerrit-Change-Number: 11634
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 07 Nov 2018 15:15:49 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Build failed in Jenkins: master-asn1c » a1=default,a2=default,a3=default,osmocom-master-debian9 #300

[jenkins]

See 


--
[...truncated 3.67 KB...]

+ ./configure
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for style of include used by make... GNU
checking for gcc... gcc
checking for C compiler default output file name... a.out
checking whether the C compiler works... yes
checking whether we are cross compiling... no
checking for suffix of executables... 
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for /usr/bin/ld option to reload object files... -r
checking for BSD-compatible nm... /usr/bin/nm -B
checking whether ln -s works... yes
checking how to recognise dependent libraries... pass_all
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking dlfcn.h usability... yes
checking dlfcn.h presence... yes
checking for dlfcn.h... yes
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking how to run the C++ preprocessor... g++ -E
checking for g77... no
checking for f77... no
checking for xlf... no
checking for frt... no
checking for pgf77... no
checking for cf77... no
checking for fort77... no
checking for fl32... no
checking for af77... no
checking for f90... no
checking for xlf90... no
checking for pgf90... no
checking for pghpf... no
checking for epcf90... no
checking for gfortran... no
checking for g95... no
checking for f95... no
checking for fort... no
checking for xlf95... no
checking for ifort... no
checking for ifc... no
checking for efc... no
checking for pgf95... no
checking for lf95... no
checking for ftn... no
checking whether we are using the GNU Fortran 77 compiler... no
checking whether  accepts -g... no
checking the maximum length of command line arguments... 32768
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for objdir... .libs
checking for ar... ar
checking for ranlib... ranlib
checking for strip... strip
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC
checking if gcc PIC flag -fPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
configure: creating libtool
appending configuration tag "CXX" to libtool
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking for g++ option to produce PIC... -fPIC
checking if g++ PIC flag -fPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
appending configuration tag "F77" to libtool
checking for autoconf... /usr/bin/autoconf
checking for autoheader... /usr/bin/autoheader
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking dep

Change in libosmocore[master]: Add helper wrapper for BSSAP TLV parsing

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/11655 )

Change subject: Add helper wrapper for BSSAP TLV parsing
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/11655
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib228368901ce90a02a5664f2510593371c7d29cd
Gerrit-Change-Number: 11655
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Wed, 07 Nov 2018 14:41:07 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: start implementing the TC_paging() PCU test

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/9374 )

Change subject: start implementing the TC_paging() PCU test
..


Patch Set 5:

(1 comment)

Would be nice to update comment in PCU_Tests.cfg

https://gerrit.osmocom.org/#/c/9374/5/pcu/expected-results.xml
File pcu/expected-results.xml:

https://gerrit.osmocom.org/#/c/9374/5/pcu/expected-results.xml@2
PS5, Line 2: 
Not 100% sure but I think we got to update number of tests as well.



--
To view, visit https://gerrit.osmocom.org/9374
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0384e0742ab91983615e4f1c883bb044c1c8b18
Gerrit-Change-Number: 9374
Gerrit-PatchSet: 5
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Wed, 07 Nov 2018 14:40:08 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: start implementing the TC_paging() PCU test

[Stefan Sperling]

Stefan Sperling has posted comments on this change. ( 
https://gerrit.osmocom.org/9374 )

Change subject: start implementing the TC_paging() PCU test
..


Patch Set 5:

> Patch Set 4:
>
> Please rebase to latest master, add the test to control() and 
> expected_results.xml

Done. See patch set 5.


--
To view, visit https://gerrit.osmocom.org/9374
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0384e0742ab91983615e4f1c883bb044c1c8b18
Gerrit-Change-Number: 9374
Gerrit-PatchSet: 5
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Wed, 07 Nov 2018 14:29:16 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: start implementing the TC_paging() PCU test

[Stefan Sperling]

Hello Max, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/9374

to look at the new patch set (#5).

Change subject: start implementing the TC_paging() PCU test
..

start implementing the TC_paging() PCU test

Implement a basic paging test for the PCU, which is passing for paging
via TMSI (but only if osmo-pcu is started after the test is started).

Previously, this test code amounted to a debugging loop which
never terminated.

Change-Id: Id0384e0742ab91983615e4f1c883bb044c1c8b18
Related: OS#2404
---
M library/L3_Templates.ttcn
M pcu/PCU_Tests.ttcn
M pcu/expected-results.xml
3 files changed, 66 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/74/9374/5
--
To view, visit https://gerrit.osmocom.org/9374
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id0384e0742ab91983615e4f1c883bb044c1c8b18
Gerrit-Change-Number: 9374
Gerrit-PatchSet: 5
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Stefan Sperling 

Change in libosmocore[master]: Add helper wrapper for BSSAP TLV parsing

[Max]

Max has uploaded this change for review. ( https://gerrit.osmocom.org/11655


Change subject: Add helper wrapper for BSSAP TLV parsing
..

Add helper wrapper for BSSAP TLV parsing

Change-Id: Ib228368901ce90a02a5664f2510593371c7d29cd
---
M include/osmocom/gsm/gsm0808.h
1 file changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/55/11655/1

diff --git a/include/osmocom/gsm/gsm0808.h b/include/osmocom/gsm/gsm0808.h
index cdbb273..652aae9 100644
--- a/include/osmocom/gsm/gsm0808.h
+++ b/include/osmocom/gsm/gsm0808.h
@@ -173,6 +173,9 @@

 const struct tlv_definition *gsm0808_att_tlvdef(void);

+/*! Parse BSSAP TLV structure using \ref tlv_parse */
+#define osmo_bssap_tlv_parse(dec, buf, len) tlv_parse(dec, 
gsm0808_att_tlvdef(), buf, len, 0, 0)
+
 const char *gsm0808_bssmap_name(uint8_t msg_type);
 const char *gsm0808_bssap_name(uint8_t msg_type);
 const char *gsm0808_cause_name(uint8_t cause);

--
To view, visit https://gerrit.osmocom.org/11655
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib228368901ce90a02a5664f2510593371c7d29cd
Gerrit-Change-Number: 11655
Gerrit-PatchSet: 1
Gerrit-Owner: Max 

Change in osmo-bsc[master]: paging: Make default T3113 timeout dynamic

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/11654


Change subject: paging: Make default T3113 timeout dynamic
..

paging: Make default T3113 timeout dynamic

Change-Id: I4fb2969b690151415038631fb6ad059aa6835c7f
---
M src/osmo-bsc/net_init.c
M src/osmo-bsc/paging.c
2 files changed, 31 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/54/11654/1

diff --git a/src/osmo-bsc/net_init.c b/src/osmo-bsc/net_init.c
index 1199bdc..5ea564d 100644
--- a/src/osmo-bsc/net_init.c
+++ b/src/osmo-bsc/net_init.c
@@ -37,7 +37,7 @@
{ .T=3109, .default_val=5, .desc="RSL SACCH deactivation" },
{ .T=3111, .default_val=2, .desc="Wait time before RSL RF Channel 
Release" },
{ .T=993111, .default_val=4, .desc="Wait time after lchan was released 
in error (should be T3111 + 2s)" },
-   { .T=3113, .default_val=10, .desc="Paging"},
+   { .T=3113, .default_val=7, .desc="Paging"},
{ .T=3115, .default_val=10, .desc="(unused)" },
{ .T=3117, .default_val=10, .desc="(unused)" },
{ .T=3119, .default_val=10, .desc="(unused)" },
diff --git a/src/osmo-bsc/paging.c b/src/osmo-bsc/paging.c
index afe3245..a5fed32 100644
--- a/src/osmo-bsc/paging.c
+++ b/src/osmo-bsc/paging.c
@@ -287,6 +287,34 @@
paging_remove_request(&req->bts->paging, req);
 }

+
+#define GSM_FRAME_DURATION_us  4615
+#define GSM51_MFRAME_DURATION_us (51 * GSM_FRAME_DURATION_us) /* 235365 us */
+static unsigned int calculate_timer_3113(struct gsm_bts *bts)
+{
+   unsigned int to_us, to;
+   struct T_def *d = T_def_get_entry(bts->network->T_defs, 3113);
+
+   /* VTY value overrides default dynamic value */
+   if (d->val != d->default_val)
+   return d->val;
+
+   /* TODO: take into account load of paging group for req->bsub */
+
+   /* MFRMS defines repeat interval of paging messages for MSs that belong
+* to same paging group accross multiple 51 frame multiframes.
+* MAXTRANS defines maximum number of RACH retransmissions.
+*/
+   to_us = GSM51_MFRAME_DURATION_us * 
(bts->si_common.chan_desc.bs_pa_mfrms + 2) *
+   bts->si_common.rach_control.max_trans;
+
+   /* ceiling in seconds + extra time */
+   to = (to_us + 99) / 100 + d->default_val;
+   LOGP(DPAG, LOGL_DEBUG, "(bts=%d) Paging request calculated T3113 
expires in %u seconds\n",
+bts->nr, to);
+   return to;
+}
+
 /*! Start paging + paging timer for given subscriber on given BTS
  * \param bts BTS on which to page
  * \param[in] bsub subscriber we want to page
@@ -317,7 +345,8 @@
req->chan_type = type;
req->msc = msc;
osmo_timer_setup(&req->T3113, paging_T3113_expired, req);
-   osmo_timer_schedule(&req->T3113, T_def_get(bts->network->T_defs, 3113, 
T_S, -1), 0);
+   int t3113_timeout_s = calculate_timer_3113(bts);
+   osmo_timer_schedule(&req->T3113, t3113_timeout_s, 0);
llist_add_tail(&req->entry, &bts_entry->pending_requests);
paging_schedule_if_needed(bts_entry);


--
To view, visit https://gerrit.osmocom.org/11654
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4fb2969b690151415038631fb6ad059aa6835c7f
Gerrit-Change-Number: 11654
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmo-pcu[master]: deb: add missing copyright file

[Max]

Max has uploaded this change for review. ( https://gerrit.osmocom.org/11653


Change subject: deb: add missing copyright file
..

deb: add missing copyright file

File is imported as-is from current .deb package

Change-Id: Ib05480c0eea91bfb55bfc7ab446ea60932096d3d
---
A debian/copyright
1 file changed, 132 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/53/11653/1

diff --git a/debian/copyright b/debian/copyright
new file mode 100644
index 000..853cd6e
--- /dev/null
+++ b/debian/copyright
@@ -0,0 +1,132 @@
+Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
+Upstream-Name: osmo-pcu
+Source: git://git.osmocom.org/osmo-pcu
+Files-Excluded: debian
+
+Files: *
+Copyright: 2009-2015 Holger Hans Peter Freyther 
+   2013 Jacob Erlbeck 
+   2016-2017 sysmocom s.m.f.c. GmbH 
+   2015 by Yves Godin 
+License:   AGPL-3.0+
+
+Files: src/gprs_ms_storage.h
+   src/gprs_ms_storage.cpp
+   src/gprs_ms.h
+   src/gprs_coding_scheme.cpp
+   src/gprs_coding_scheme.h
+   src/cxx_linuxlist.h
+   src/pcu_vty_functions.cpp
+   src/pcu_vty_functions.h
+   src/pcu_utils.h
+   src/gprs_codel.c
+   src/gprs_codel.h
+Copyright: 2016-2017 sysmocom s.m.f.c. GmbH 
+License:   GPL-2.0+
+
+Files: osmoappdesc.py
+Copyright: 2013 by Katerina Barone-Adesi 
+License:   GPL-3.0+
+
+Files: src/gprs_debug.cpp
+   src/gprs_debug.h
+   src/pcu_main.cpp
+   src/pcu_l1_if.h
+   src/gsm_timer.cpp
+   src/gsm_timer.h
+Copyright: 2012 Ivan Klyuchnikov
+License:   GPL-2.0+
+
+Files: src/tbf.cpp
+   src/tbf_ul.cpp
+   src/tbf_dl.cpp
+   src/sba.cpp
+   src/sba.h
+   src/llc.cpp
+   src/encoding.cpp
+   src/encoding.h
+   src/gprs_rlcmac.cpp
+   src/gprs_rlcmac_ts_alloc.cpp
+Copyright: 2012 Ivan Klyuchnikov
+   2012 Andreas Eversberg 
+   2013 by Holger Hans Peter Freyther
+License:   GPL-2.0+
+
+Files: src/gprs_rlcmac.h
+   src/gprs_bssgp_pcu.cpp
+   src/gprs_bssgp_pcu.h
+   src/bts.h
+Copyright: 2012 Ivan Klyuchnikov
+   2013 by Holger Hans Peter Freyther
+License:   GPL-2.0+
+
+Files: src/rlc.h
+   src/decoding.cpp
+   src/decoding.h
+Copyright: 2012 Ivan Klyuchnikov
+   2012 Andreas Eversberg 
+License:   GPL-2.0+
+
+Files: src/rlc.cpp
+   src/llc.h
+   src/tbf.h
+Copyright: 2013 by Holger Hans Peter Freyther
+License:   GPL-2.0+
+
+Files: src/pcu_l1_if.cpp
+   src/gprs_rlcmac_meas.cpp
+   src/gprs_rlcmac_sched.cpp
+   src/osmobts_sock.cpp
+Copyright: 2012 Andreas Eversberg 
+License:   GPL-2.0+
+
+Files: src/csn1.h
+   src/csn1.cpp
+   src/gsm_rlcmac.cpp
+   src/gsm_rlcmac.h
+Copyright: 2011 Vincent Helfre
+   2011 ST-Ericsson (Jari Sassi)
+License:   GPL-2.0+
+
+License:   AGPL-3.0+
+ All rights not specifically granted under this license are reserved.
+ .
+ This program is free software; you can redistribute it and/or modify it
+ under the terms of the GNU Affero General Public License as published by the
+ Free Software Foundation; either version 3 of the License, or (at your
+ option) any later version.
+
+License:   GPL-3.0+
+ This program is free software: you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation, either version 3 of the License, or
+ (at your option) any later version.
+ .
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ GNU General Public License for more details.
+ .
+ You should have received a copy of the GNU General Public License
+ along with this program.  If not, see .
+ .
+ On Debian systems, the complete text of the GNU General Public License
+ Version 3 can be found in `/usr/share/common-licenses/GPL-3'.
+
+License:   GPL-2.0+
+ This program is free software: you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation, either version 2 of the License, or
+ (at your option) any later version.
+ .
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ GNU General Public License for more details.
+ .
+ You should have received a copy of the GNU General Public License
+ along with this program.  If not, see .
+ .
+ On Debian systems, the complete text of the GNU General Public Licens

Change in osmo-bsc[master]: Make IP address helper accessible via header file

[Max]

Max has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11650 )

Change subject: Make IP address helper accessible via header file
..

Make IP address helper accessible via header file

Change-Id: I4bc157bf296e28678de6d9c9823f91810132a58c
---
M include/osmocom/bsc/abis_rsl.h
M src/osmo-bsc/abis_rsl.c
2 files changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, approved



diff --git a/include/osmocom/bsc/abis_rsl.h b/include/osmocom/bsc/abis_rsl.h
index 886e7d6..ba44669 100644
--- a/include/osmocom/bsc/abis_rsl.h
+++ b/include/osmocom/bsc/abis_rsl.h
@@ -35,6 +35,8 @@

 #define GSM48_LEN2PLEN(a)  (((a) << 2) | 1)

+const char *ip_to_a(uint32_t ip);
+
 int rsl_bcch_info(const struct gsm_bts_trx *trx, enum osmo_sysinfo_type 
si_type, const uint8_t *data, int len);
 int rsl_sacch_filling(struct gsm_bts_trx *trx, uint8_t type,
  const uint8_t *data, int len);
diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c
index b86780d..2eda884 100644
--- a/src/osmo-bsc/abis_rsl.c
+++ b/src/osmo-bsc/abis_rsl.c
@@ -1770,7 +1770,7 @@
return -EINVAL;
 }

-static const char *ip_to_a(uint32_t ip)
+const char *ip_to_a(uint32_t ip)
 {
struct in_addr ia;
ia.s_addr = htonl(ip);

--
To view, visit https://gerrit.osmocom.org/11650
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4bc157bf296e28678de6d9c9823f91810132a58c
Gerrit-Change-Number: 11650
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-bsc[master]: constify rsl_tx_ipacc_*cx() parameters

[Max]

Max has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11651 )

Change subject: constify rsl_tx_ipacc_*cx() parameters
..

constify rsl_tx_ipacc_*cx() parameters

Change-Id: Ib34c8e3fb51d067581aefa1c80f8be1f6db9512e
---
M include/osmocom/bsc/abis_rsl.h
M src/osmo-bsc/abis_rsl.c
M tests/gsm0408/gsm0408_test.c
3 files changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, approved



diff --git a/include/osmocom/bsc/abis_rsl.h b/include/osmocom/bsc/abis_rsl.h
index ba44669..5ada3fc 100644
--- a/include/osmocom/bsc/abis_rsl.h
+++ b/include/osmocom/bsc/abis_rsl.h
@@ -61,8 +61,8 @@
 int rsl_siemens_mrpci(struct gsm_lchan *lchan, struct rsl_mrpci *mrpci);

 /* ip.access specfic RSL extensions */
-int rsl_tx_ipacc_crcx(struct gsm_lchan *lchan);
-int rsl_tx_ipacc_mdcx(struct gsm_lchan *lchan);
+int rsl_tx_ipacc_crcx(const struct gsm_lchan *lchan);
+int rsl_tx_ipacc_mdcx(const struct gsm_lchan *lchan);
 int rsl_ipacc_mdcx_to_rtpsock(struct gsm_lchan *lchan);
 int rsl_ipacc_pdch_activate(struct gsm_bts_trx_ts *ts, int act);

diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c
index 2eda884..bd104ed 100644
--- a/src/osmo-bsc/abis_rsl.c
+++ b/src/osmo-bsc/abis_rsl.c
@@ -1830,7 +1830,7 @@
 /*! Send Issue IPA RSL CRCX to configure the RTP port of the BTS.
  * \param[in] lchan Logical Channel for which we issue CRCX
  */
-int rsl_tx_ipacc_crcx(struct gsm_lchan *lchan)
+int rsl_tx_ipacc_crcx(const struct gsm_lchan *lchan)
 {
struct msgb *msg = rsl_msgb_alloc();
struct abis_rsl_dchan_hdr *dh;
@@ -1856,7 +1856,7 @@
  * \param[in] lchan Logical Channel for which we issue MDCX
  * Remote (MGW) IP address, port and payload types for RTP are determined from 
lchan->abis_ip.
  */
-int rsl_tx_ipacc_mdcx(struct gsm_lchan *lchan)
+int rsl_tx_ipacc_mdcx(const struct gsm_lchan *lchan)
 {
struct msgb *msg = rsl_msgb_alloc();
struct abis_rsl_dchan_hdr *dh;
diff --git a/tests/gsm0408/gsm0408_test.c b/tests/gsm0408/gsm0408_test.c
index faeca39..f2b85e4 100644
--- a/tests/gsm0408/gsm0408_test.c
+++ b/tests/gsm0408/gsm0408_test.c
@@ -968,7 +968,7 @@

 int rsl_chan_mode_modify_req(struct gsm_lchan *ts) { return 0; }

-int rsl_tx_ipacc_crcx(struct gsm_lchan *lchan) { return 0; }
+int rsl_tx_ipacc_crcx(const struct gsm_lchan *lchan) { return 0; }

 void gscon_submit_rsl_dtap(struct gsm_subscriber_connection *conn,
   struct msgb *msg, int link_id, int allow_sacch) {}

--
To view, visit https://gerrit.osmocom.org/11651
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib34c8e3fb51d067581aefa1c80f8be1f6db9512e
Gerrit-Change-Number: 11651
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in libosmocore[master]: gsm0808: add BSSMAP Cell Identifier matching API

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11504 )

Change subject: gsm0808: add BSSMAP Cell Identifier matching API
..


Patch Set 4:

(1 comment)

> (1 comment)
 >
 > I think you should also update TODO-RELEASE file as well. Provided
 > it's still used during the release preparation. Pau?

Not really mandatory, I end up looking at git log anyway, since people usually 
forget to add stuff there (or they dn't realize that they are changing API/ABI 
at all).

https://gerrit.osmocom.org/#/c/11504/4/src/gsm/gsm0808_utils.c
File src/gsm/gsm0808_utils.c:

https://gerrit.osmocom.org/#/c/11504/4/src/gsm/gsm0808_utils.c@1401
PS4, Line 1401: match_nr --;
> That looks odd - why space before decrement?
Agree



--
To view, visit https://gerrit.osmocom.org/11504
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5535f0d149c2173294538df75764dd181b023312
Gerrit-Change-Number: 11504
Gerrit-PatchSet: 4
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 07 Nov 2018 12:41:16 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-bsc[master]: LCLS: expand logging to print the name of the mode in use

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11652 )

Change subject: LCLS: expand logging to print the name of the mode in use
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11652
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I56b57936ae82984e84896228da5a83115a78bbd7
Gerrit-Change-Number: 11652
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 07 Nov 2018 12:38:52 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: constify rsl_tx_ipacc_*cx() parameters

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11651 )

Change subject: constify rsl_tx_ipacc_*cx() parameters
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11651
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib34c8e3fb51d067581aefa1c80f8be1f6db9512e
Gerrit-Change-Number: 11651
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 07 Nov 2018 12:37:37 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: Make IP address helper accessible via header file

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11650 )

Change subject: Make IP address helper accessible via header file
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11650
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4bc157bf296e28678de6d9c9823f91810132a58c
Gerrit-Change-Number: 11650
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 07 Nov 2018 12:37:17 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: BSC: log MGCP connection number on failure

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11645 )

Change subject: BSC: log MGCP connection number on failure
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11645
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b743aaf9d68f2f332660d819d38ad8212484e00
Gerrit-Change-Number: 11645
Gerrit-PatchSet: 3
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 07 Nov 2018 12:36:36 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: gsm0808: add BSSMAP Cell Identifier matching API

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/11504 )

Change subject: gsm0808: add BSSMAP Cell Identifier matching API
..


Patch Set 4: Code-Review-1

(1 comment)

I think you should also update TODO-RELEASE file as well. Provided it's still 
used during the release preparation. Pau?

https://gerrit.osmocom.org/#/c/11504/4/src/gsm/gsm0808_utils.c
File src/gsm/gsm0808_utils.c:

https://gerrit.osmocom.org/#/c/11504/4/src/gsm/gsm0808_utils.c@1401
PS4, Line 1401: match_nr --;
That looks odd - why space before decrement?



--
To view, visit https://gerrit.osmocom.org/11504
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5535f0d149c2173294538df75764dd181b023312
Gerrit-Change-Number: 11504
Gerrit-PatchSet: 4
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 07 Nov 2018 12:32:42 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in libosmocore[master]: Update 3GPP TS 08.08 Cause handling

[Max]

Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11577

to look at the new patch set (#5).

Change subject: Update 3GPP TS 08.08 Cause handling
..

Update 3GPP TS 08.08 Cause handling

* add Class definitions
* add helper to check for extended bit
* add helper to get Cause's Class
* use enum in gsm0808_cause_name() and gsm0808_create_cipher_reject() to
  avoid confusion between class and cause
* update gsm0808_create_cipher_reject() comments

Change-Id: I31b31dfc22eb4b6b07089e1255246ac458125340
Related: OS#3187
---
M TODO-RELEASE
M include/osmocom/gsm/gsm0808.h
M include/osmocom/gsm/gsm0808_utils.h
M include/osmocom/gsm/protocol/gsm_08_08.h
M src/gsm/gsm0808.c
M src/gsm/libosmogsm.map
6 files changed, 59 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/77/11577/5
--
To view, visit https://gerrit.osmocom.org/11577
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I31b31dfc22eb4b6b07089e1255246ac458125340
Gerrit-Change-Number: 11577
Gerrit-PatchSet: 5
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 

Change in libosmocore[master]: Support cipher mode reject with extended cause

[Max]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11601

to look at the new patch set (#3).

Change subject: Support cipher mode reject with extended cause
..

Support cipher mode reject with extended cause

* add function to generate cipher mode reject with extended (2-byte)
  Cause IE
* add function to get (extended) Cause value
* add helper wrapper for BSSAP TLV parsing
* add corresponding (extended cause) test
* update existing (non-extended cause) test
* use enum as a parameter for existing non-extended version to make
  interface more unified

Change-Id: Id5509b94a18180a44f45300caaa02b843c166fa3
Related: OS#3187
---
M TODO-RELEASE
M include/osmocom/gsm/gsm0808.h
M include/osmocom/gsm/gsm0808_utils.h
M src/gsm/gsm0808.c
M src/gsm/gsm0808_utils.c
M src/gsm/libosmogsm.map
M tests/gsm0808/gsm0808_test.c
M tests/gsm0808/gsm0808_test.ok
8 files changed, 94 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/01/11601/3
--
To view, visit https://gerrit.osmocom.org/11601
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id5509b94a18180a44f45300caaa02b843c166fa3
Gerrit-Change-Number: 11601
Gerrit-PatchSet: 3
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-CC: Vadim Yanitskiy 

Change in osmo-ttcn3-hacks[master]: BSC: log MGCP connection on failure

[Max]

Hello Pau Espin Pedrol, Neels Hofmeyr, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11645

to look at the new patch set (#2).

Change subject: BSC: log MGCP connection on failure
..

BSC: log MGCP connection on failure

Change-Id: I3b743aaf9d68f2f332660d819d38ad8212484e00
---
M bsc/MSC_ConnectionHandler.ttcn
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/45/11645/2
--
To view, visit https://gerrit.osmocom.org/11645
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3b743aaf9d68f2f332660d819d38ad8212484e00
Gerrit-Change-Number: 11645
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-ttcn3-hacks[master]: BSC: log MGCP connection number on failure

[Max]

Hello Pau Espin Pedrol, Neels Hofmeyr, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11645

to look at the new patch set (#3).

Change subject: BSC: log MGCP connection number on failure
..

BSC: log MGCP connection number on failure

Change-Id: I3b743aaf9d68f2f332660d819d38ad8212484e00
---
M bsc/MSC_ConnectionHandler.ttcn
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/45/11645/3
--
To view, visit https://gerrit.osmocom.org/11645
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3b743aaf9d68f2f332660d819d38ad8212484e00
Gerrit-Change-Number: 11645
Gerrit-PatchSet: 3
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-bsc[master]: RSL: restructure MDCX functions

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/11550 )

Change subject: RSL: restructure MDCX functions
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/11550
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iffe2f4f10e841fc36965cce02b4e5f017a5ae6c8
Gerrit-Change-Number: 11550
Gerrit-PatchSet: 5
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 07 Nov 2018 12:10:14 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-bsc[master]: LCLS: explicitly check for mode before closing the loop

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/11565 )

Change subject: LCLS: explicitly check for mode before closing the loop
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/11565
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie91cc70de20ade2bfa3a1a108c731341f5e739bb
Gerrit-Change-Number: 11565
Gerrit-PatchSet: 3
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 07 Nov 2018 12:10:34 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-bsc[master]: LCLS: move mode check into separate function

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/11551 )

Change subject: LCLS: move mode check into separate function
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/11551
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I32ba232ad802625d97a0ad9d0511edc6ac7f251c
Gerrit-Change-Number: 11551
Gerrit-PatchSet: 5
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 07 Nov 2018 12:10:39 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-bsc[master]: Make IP address helper accessible via header file

[Max]

Max has uploaded this change for review. ( https://gerrit.osmocom.org/11650


Change subject: Make IP address helper accessible via header file
..

Make IP address helper accessible via header file

Change-Id: I4bc157bf296e28678de6d9c9823f91810132a58c
---
M include/osmocom/bsc/abis_rsl.h
M src/osmo-bsc/abis_rsl.c
2 files changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/50/11650/1

diff --git a/include/osmocom/bsc/abis_rsl.h b/include/osmocom/bsc/abis_rsl.h
index 886e7d6..ba44669 100644
--- a/include/osmocom/bsc/abis_rsl.h
+++ b/include/osmocom/bsc/abis_rsl.h
@@ -35,6 +35,8 @@

 #define GSM48_LEN2PLEN(a)  (((a) << 2) | 1)

+const char *ip_to_a(uint32_t ip);
+
 int rsl_bcch_info(const struct gsm_bts_trx *trx, enum osmo_sysinfo_type 
si_type, const uint8_t *data, int len);
 int rsl_sacch_filling(struct gsm_bts_trx *trx, uint8_t type,
  const uint8_t *data, int len);
diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c
index b86780d..2eda884 100644
--- a/src/osmo-bsc/abis_rsl.c
+++ b/src/osmo-bsc/abis_rsl.c
@@ -1770,7 +1770,7 @@
return -EINVAL;
 }

-static const char *ip_to_a(uint32_t ip)
+const char *ip_to_a(uint32_t ip)
 {
struct in_addr ia;
ia.s_addr = htonl(ip);

--
To view, visit https://gerrit.osmocom.org/11650
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4bc157bf296e28678de6d9c9823f91810132a58c
Gerrit-Change-Number: 11650
Gerrit-PatchSet: 1
Gerrit-Owner: Max 

Change in osmo-bsc[master]: constify rsl_tx_ipacc_*cx() parameters

[Max]

Max has uploaded this change for review. ( https://gerrit.osmocom.org/11651


Change subject: constify rsl_tx_ipacc_*cx() parameters
..

constify rsl_tx_ipacc_*cx() parameters

Change-Id: Ib34c8e3fb51d067581aefa1c80f8be1f6db9512e
---
M include/osmocom/bsc/abis_rsl.h
M src/osmo-bsc/abis_rsl.c
M tests/gsm0408/gsm0408_test.c
3 files changed, 5 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/51/11651/1

diff --git a/include/osmocom/bsc/abis_rsl.h b/include/osmocom/bsc/abis_rsl.h
index ba44669..5ada3fc 100644
--- a/include/osmocom/bsc/abis_rsl.h
+++ b/include/osmocom/bsc/abis_rsl.h
@@ -61,8 +61,8 @@
 int rsl_siemens_mrpci(struct gsm_lchan *lchan, struct rsl_mrpci *mrpci);

 /* ip.access specfic RSL extensions */
-int rsl_tx_ipacc_crcx(struct gsm_lchan *lchan);
-int rsl_tx_ipacc_mdcx(struct gsm_lchan *lchan);
+int rsl_tx_ipacc_crcx(const struct gsm_lchan *lchan);
+int rsl_tx_ipacc_mdcx(const struct gsm_lchan *lchan);
 int rsl_ipacc_mdcx_to_rtpsock(struct gsm_lchan *lchan);
 int rsl_ipacc_pdch_activate(struct gsm_bts_trx_ts *ts, int act);

diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c
index 2eda884..bd104ed 100644
--- a/src/osmo-bsc/abis_rsl.c
+++ b/src/osmo-bsc/abis_rsl.c
@@ -1830,7 +1830,7 @@
 /*! Send Issue IPA RSL CRCX to configure the RTP port of the BTS.
  * \param[in] lchan Logical Channel for which we issue CRCX
  */
-int rsl_tx_ipacc_crcx(struct gsm_lchan *lchan)
+int rsl_tx_ipacc_crcx(const struct gsm_lchan *lchan)
 {
struct msgb *msg = rsl_msgb_alloc();
struct abis_rsl_dchan_hdr *dh;
@@ -1856,7 +1856,7 @@
  * \param[in] lchan Logical Channel for which we issue MDCX
  * Remote (MGW) IP address, port and payload types for RTP are determined from 
lchan->abis_ip.
  */
-int rsl_tx_ipacc_mdcx(struct gsm_lchan *lchan)
+int rsl_tx_ipacc_mdcx(const struct gsm_lchan *lchan)
 {
struct msgb *msg = rsl_msgb_alloc();
struct abis_rsl_dchan_hdr *dh;
diff --git a/tests/gsm0408/gsm0408_test.c b/tests/gsm0408/gsm0408_test.c
index faeca39..f2b85e4 100644
--- a/tests/gsm0408/gsm0408_test.c
+++ b/tests/gsm0408/gsm0408_test.c
@@ -968,7 +968,7 @@

 int rsl_chan_mode_modify_req(struct gsm_lchan *ts) { return 0; }

-int rsl_tx_ipacc_crcx(struct gsm_lchan *lchan) { return 0; }
+int rsl_tx_ipacc_crcx(const struct gsm_lchan *lchan) { return 0; }

 void gscon_submit_rsl_dtap(struct gsm_subscriber_connection *conn,
   struct msgb *msg, int link_id, int allow_sacch) {}

--
To view, visit https://gerrit.osmocom.org/11651
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib34c8e3fb51d067581aefa1c80f8be1f6db9512e
Gerrit-Change-Number: 11651
Gerrit-PatchSet: 1
Gerrit-Owner: Max 

Change in osmo-bsc[master]: LCLS: expand logging to print the name of the mode in use

[Max]

Max has uploaded this change for review. ( https://gerrit.osmocom.org/11652


Change subject: LCLS: expand logging to print the name of the mode in use
..

LCLS: expand logging to print the name of the mode in use

Change-Id: I56b57936ae82984e84896228da5a83115a78bbd7
Related: OS#3659
---
M include/osmocom/bsc/bsc_msc_data.h
M src/osmo-bsc/gsm_data.c
M src/osmo-bsc/osmo_bsc_lcls.c
M src/osmo-bsc/osmo_bsc_vty.c
4 files changed, 18 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/52/11652/1

diff --git a/include/osmocom/bsc/bsc_msc_data.h 
b/include/osmocom/bsc/bsc_msc_data.h
index 6ca0330..32b161e 100644
--- a/include/osmocom/bsc/bsc_msc_data.h
+++ b/include/osmocom/bsc/bsc_msc_data.h
@@ -59,6 +59,13 @@
/* we may later introduce BTS_LOOP here: direct RTP between BTSs */
 };

+extern const struct value_string bsc_lcls_mode_names[];
+
+static inline const char *bsc_lcls_mode_name(enum bsc_lcls_mode m)
+{
+   return get_value_string(bsc_lcls_mode_names, m);
+}
+
 /*! /brief Information on a remote MSC for libbsc.
  */
 struct bsc_msc_data {
diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c
index 08d5bcb..56eb24e 100644
--- a/src/osmo-bsc/gsm_data.c
+++ b/src/osmo-bsc/gsm_data.c
@@ -47,6 +47,12 @@

 void *tall_bsc_ctx = NULL;

+const struct value_string bsc_lcls_mode_names[] = {
+   { BSC_LCLS_MODE_DISABLED,   "disabled" },
+   { BSC_LCLS_MODE_MGW_LOOP,   "mgw-loop" },
+   { 0, NULL }
+};
+
 static LLIST_HEAD(bts_models);

 void set_ts_e1link(struct gsm_bts_trx_ts *ts, uint8_t e1_nr,
diff --git a/src/osmo-bsc/osmo_bsc_lcls.c b/src/osmo-bsc/osmo_bsc_lcls.c
index e642976..a406643 100644
--- a/src/osmo-bsc/osmo_bsc_lcls.c
+++ b/src/osmo-bsc/osmo_bsc_lcls.c
@@ -240,7 +240,9 @@
 {
struct mgcp_conn_peer mdcx_info;

-   LOGPFSM(conn->lcls.fi, "=== HERE IS WHERE WE DISABLE LCLS\n");
+   LOGPFSM(conn->lcls.fi, "=== HERE IS WHERE WE DISABLE LCLS(%s)\n",
+   bsc_lcls_mode_name(conn->sccp.msc->lcls_mode));
+
if (!conn->user_plane.mgw_endpoint_ci_msc) {
/* the MGCP FSM has died, e.g. due to some MGCP/SDP parsing 
error */
LOGPFSML(conn->lcls.fi, LOGL_NOTICE, "Cannot disable LCLS 
without MSC-side MGCP FSM\n");
@@ -581,7 +583,8 @@

OSMO_ASSERT(conn_other);

-   LOGPFSM(fi, "=== HERE IS WHERE WE ENABLE LCLS\n");
+   LOGPFSM(fi, "=== HERE IS WHERE WE ENABLE LCLS(%s)\n",
+   bsc_lcls_mode_name(conn->sccp.msc->lcls_mode));
if (!conn->user_plane.mgw_endpoint_ci_msc) {
LOGPFSML(fi, LOGL_ERROR, "Cannot enable LCLS without MSC-side 
MGCP FSM. FIXME\n");
return;
diff --git a/src/osmo-bsc/osmo_bsc_vty.c b/src/osmo-bsc/osmo_bsc_vty.c
index f90ad6f..14fd274 100644
--- a/src/osmo-bsc/osmo_bsc_vty.c
+++ b/src/osmo-bsc/osmo_bsc_vty.c
@@ -38,12 +38,6 @@

 #define IPA_STR "IP.ACCESS specific\n"

-static const struct value_string bsc_lcls_mode_names[] = {
-   { BSC_LCLS_MODE_DISABLED,   "disabled" },
-   { BSC_LCLS_MODE_MGW_LOOP,   "mgw-loop" },
-   { 0, NULL }
-};
-
 static struct osmo_bsc_data *osmo_bsc_data(struct vty *vty)
 {
return bsc_gsmnet->bsc_data;

--
To view, visit https://gerrit.osmocom.org/11652
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I56b57936ae82984e84896228da5a83115a78bbd7
Gerrit-Change-Number: 11652
Gerrit-PatchSet: 1
Gerrit-Owner: Max 

Change in osmo-ttcn3-hacks[master]: BSSMAP_Templates: Add missing tr_BSSMAP_HandoverPerformed template

[dexter]

dexter has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11607 )

Change subject: BSSMAP_Templates: Add missing tr_BSSMAP_HandoverPerformed 
template
..

BSSMAP_Templates: Add missing tr_BSSMAP_HandoverPerformed template

The receive template for the BSSMAP HANDOVER PERFORMED MESSAGE is
missing, lets add one.

Related OS#3645

Change-Id: I527913203b2d5bfa26c181c4bb79481a9cd283ae
---
M library/BSSMAP_Templates.ttcn
1 file changed, 20 insertions(+), 0 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/library/BSSMAP_Templates.ttcn b/library/BSSMAP_Templates.ttcn
index 118168e..d00a5ab 100644
--- a/library/BSSMAP_Templates.ttcn
+++ b/library/BSSMAP_Templates.ttcn
@@ -823,6 +823,26 @@
}
 }

+template PDU_BSSAP tr_BSSMAP_HandoverPerformed
+modifies tr_BSSAP_BSSMAP := {
+   pdu := {
+   bssmap := {
+   handoverPerformed := {
+   messageType := '17'O,
+   cause := ?,
+   cellIdentifier := ?,
+   chosenChannel := omit,
+   chosenEncryptionAlgorithm := omit,
+   lSAIdentifier := omit,
+   talkerPriority := omit,
+   codecList := omit,
+   speechCodec := omit,
+   lCLS_BSS_Status := omit
+   }
+   }
+   }
+}
+
 template BSSMAP_IE_IMSI ts_BSSMAP_Imsi(hexstring imsi_digits) := {
elementIdentifier := '08'O,
lengthIndicator := 0, /* overwritten */

--
To view, visit https://gerrit.osmocom.org/11607
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I527913203b2d5bfa26c181c4bb79481a9cd283ae
Gerrit-Change-Number: 11607
Gerrit-PatchSet: 3
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: dexter 

Change in libosmocore[master]: gsm_29_118: add missing include to header file

[dexter]

dexter has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11638 )

Change subject: gsm_29_118: add missing include to header file
..

gsm_29_118: add missing include to header file

The header file gsm_29_118.h is defining variables of type struct
value_string, which is declared in core/utils.h. We should add an
include to utils.h to prevent confusion when the header is used.

Change-Id: I9f9bb62d29cd068820ad5aa677717bd448de3f4a
Related: OS#3615
---
M include/osmocom/gsm/protocol/gsm_29_118.h
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/gsm/protocol/gsm_29_118.h 
b/include/osmocom/gsm/protocol/gsm_29_118.h
index 24e9de2..c344f04 100644
--- a/include/osmocom/gsm/protocol/gsm_29_118.h
+++ b/include/osmocom/gsm/protocol/gsm_29_118.h
@@ -1,5 +1,6 @@
 #pragma once

+#include 

 /* TS 29.118 Section 9.2 */
 enum sgsap_msg_type {

--
To view, visit https://gerrit.osmocom.org/11638
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9f9bb62d29cd068820ad5aa677717bd448de3f4a
Gerrit-Change-Number: 11638
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: dexter 

Change in osmo-mgw[master]: mgcp_protocol: increase buffer space for codec name in LCO

[dexter]

dexter has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11466 )

Change subject: mgcp_protocol: increase buffer space for codec name in LCO
..

mgcp_protocol: increase buffer space for codec name in LCO

The function that parses the LCO uses an internal buffer to store the
codec name that has been issued via LCO. This buffer is only 9 byte
long, this means an 8 character string can be stored. If a codec name
exceeds this limit it gets chopped. For example "GSM-HR-08" becomes
"GSM-HR-0", which may mess up the codec negotiation.

- Increase the buffer from 9 to 17 byte.

Change-Id: I17ce7acde1f23ab1394227d74214fe2a55cd2264
Related: OS#3673
---
M src/libosmo-mgcp/mgcp_protocol.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c
index 90c282c..3313164 100644
--- a/src/libosmo-mgcp/mgcp_protocol.c
+++ b/src/libosmo-mgcp/mgcp_protocol.c
@@ -579,7 +579,7 @@
 const char *options)
 {
char *p_opt, *a_opt;
-   char codec[9];
+   char codec[17];

if (!options)
return 0;
@@ -605,7 +605,7 @@
 * (e.g. a:PCMU;G726-32) But this implementation only supports a single
 * codec only. */
a_opt = strstr(lco->string, "a:");
-   if (a_opt && sscanf(a_opt, "a:%8[^,]", codec) == 1) {
+   if (a_opt && sscanf(a_opt, "a:%16[^,]", codec) == 1) {
talloc_free(lco->codec);
lco->codec = talloc_strdup(ctx, codec);
}

--
To view, visit https://gerrit.osmocom.org/11466
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I17ce7acde1f23ab1394227d74214fe2a55cd2264
Gerrit-Change-Number: 11466
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: dexter 

Change in osmo-dev[master]: deps: comment out osmo-trx

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/11634 )

Change subject: deps: comment out osmo-trx
..


Patch Set 1: Code-Review+1

looks good. the best way would probably be adding "--enable-sanitize-tests" to 
osmo-trx, like pespin commented in IRC.


--
To view, visit https://gerrit.osmocom.org/11634
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I589f49652f8fa4e5becc7d7e63e6e4bc1a8b33bb
Gerrit-Change-Number: 11634
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 07 Nov 2018 10:52:52 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-dev[master]: 2G.deps: add osmo-sip-connector

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/11635 )

Change subject: 2G.deps: add osmo-sip-connector
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/11635
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30e27e2eb0060889f167417a21894e8e411ad1e3
Gerrit-Change-Number: 11635
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 07 Nov 2018 10:50:16 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-dev[master]: sanitize.opts: add osmo-sip-connector --enable-sanitize

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/11593 )

Change subject: sanitize.opts: add osmo-sip-connector --enable-sanitize
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/11593
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e04ef38982ee6c89110776fc941ee0e2c193196
Gerrit-Change-Number: 11593
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 07 Nov 2018 10:49:39 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-dev[master]: replace src/* git scripts with a single src/gits

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/11560 )

Change subject: replace src/* git scripts with a single src/gits
..


Patch Set 5: Code-Review-1

(6 comments)

gits was not executable in the last patchset (chmod +x gits)

https://gerrit.osmocom.org/#/c/11560/4/src/gits
File src/gits:

https://gerrit.osmocom.org/#/c/11560/4/src/gits@2
PS4, Line 2:
> the reason why argparse will not work so well is passing arguments to git. 
> consider: […]
this works well with argparse, see the example below


https://gerrit.osmocom.org/#/c/11560/4/src/gits@68
PS4, Line 68: args):
> yeah, that's the main ultra drawback of this script so far. I really really 
> shouldn't use porcelain. […]
This seems to work - do you get the same output with your version?

  $ git status --porcelain --long
  On branch master
  Your branch is up-to-date with 'origin/master'.
  nothing to commit, working tree clean


https://gerrit.osmocom.org/#/c/11560/4/src/gits@194
PS4, Line 194: lines = []
> I like more visible markers in this case
What I meant: keep the  marker that is there, and add this line below:

print('+ %s' % ' '.join(cmd))


https://gerrit.osmocom.org/#/c/11560/4/src/gits@359
PS4, Line 359: for git_dir in git_dirs():
> but I want to write 'gits fetch' :) […]
you don't need a shim for every git command, you can just put them in a list 
and iterate over them:

  import argparse

  def parse_args():
  parser = argparse.ArgumentParser()
  sub = parser.add_subparsers(title="action", dest="action")
  sub.required = True
  sub.add_parser("status", aliases=["s", "st"],
  help="show a branch summary...")

  do = sub.add_parser("do", help="run arbitrary git command...")
  do.add_argument("args_passed", nargs=argparse.REMAINDER)

  # direct pass-through to git
  for action in ["fetch"]:
  action_parser = sub.add_parser(action)
  action_parser.add_argument("args_passed", nargs=argparse.REMAINDER)
  return parser.parse_args()


  if __name__ == '__main__':
  args = parse_args()
  if args.action == "status":
  cmd_status()
  # ... (other commands here)
  elif args.action == "do":
  cmd_do(args.args_passed)
  else: # pass directly through to git
  cmd_do([args.action] + args.args_passed)


https://gerrit.osmocom.org/#/c/11560/4/src/gits@362
PS4, Line 362: sys.stdout.flush()
> wow, you're just as obsessed with details like I am!
yeah :)


https://gerrit.osmocom.org/#/c/11560/5/src/gits
File src/gits:

https://gerrit.osmocom.org/#/c/11560/5/src/gits@6
PS5, Line 6: # This program is free software: you can redistribute it and/or 
modify
Out of curiosity: why not use the shorter SPDX form?

  # SPDX-License-Identifier: GPL-3.0-or-later



--
To view, visit https://gerrit.osmocom.org/11560
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I579e7af26d76d5c5d83b2349695456bc7b54f5a2
Gerrit-Change-Number: 11560
Gerrit-PatchSet: 5
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 07 Nov 2018 10:47:47 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-gsm-tester[master]: misc: Use RPATH to avoid having tests to set LD_LIBRARY_PATH

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11580 )

Change subject: misc: Use RPATH to avoid having tests to set LD_LIBRARY_PATH
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11580
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If771767dd82662e13b6b10ee7a8b8d0c84dcbdb1
Gerrit-Change-Number: 11580
Gerrit-PatchSet: 3
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 07 Nov 2018 10:45:59 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ci[master]: ansible: Wrap distro version number as string for ansible

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11648 )

Change subject: ansible: Wrap distro version number as string for ansible
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/11648
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58591ee37c6ec1479778c3f90ed8004a7e2adf1e
Gerrit-Change-Number: 11648
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Comment-Date: Wed, 07 Nov 2018 10:45:13 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-tester[master]: suits: Add an initial test for the ms_driver

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10687 )

Change subject: suits: Add an initial test for the ms_driver
..


Patch Set 9:

(1 comment)

https://gerrit.osmocom.org/#/c/10687/9//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/10687/9//COMMIT_MSG@7
PS9, Line 7: suits: Add an initial test for the ms_driver
typo. I personally think I fixed this twice already, but I guess it keeps being 
rewritten when you rebase+push.



--
To view, visit https://gerrit.osmocom.org/10687
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5be2a6b4d3d21bf48625624b9e2cccb33765fe39
Gerrit-Change-Number: 10687
Gerrit-PatchSet: 9
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 07 Nov 2018 10:44:39 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-gsm-tester[master]: ms_driver: Consult the suite to get the binaries

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11599 )

Change subject: ms_driver: Consult the suite to get the binaries
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11599
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fbb04cf67fe21378aacefcf1a15533d20d10d49
Gerrit-Change-Number: 11599
Gerrit-PatchSet: 2
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 07 Nov 2018 10:42:55 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-tester[master]: ms_driver: use the util.Dir and create one dir per instance

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11598 )

Change subject: ms_driver: use the util.Dir and create one dir per instance
..


Patch Set 2: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/11598/2/src/osmo_gsm_tester/ms_driver.py
File src/osmo_gsm_tester/ms_driver.py:

https://gerrit.osmocom.org/#/c/11598/2/src/osmo_gsm_tester/ms_driver.py@74
PS2, Line 74: self.event_server_sk_tmp_dir = tempfile.mkdtemp('', 
'ogteventserversk')
if suite_run != None, you should use it to create the tmp dir inside the run 
dir, like we do with all other resources/objects. This way everything ends up 
per-test in a dir tree which can be archived by jenkins.
You can do that on a followup patch.



--
To view, visit https://gerrit.osmocom.org/11598
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0f2fe99f6a6640606eb4e69fb1a2d22eae9b2c8
Gerrit-Change-Number: 11598
Gerrit-PatchSet: 2
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 07 Nov 2018 10:41:45 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-gsm-tester[master]: ms_driver: Switch to process.Process from subprocess

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11597 )

Change subject: ms_driver: Switch to process.Process from subprocess
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11597
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf4d4e161ac4283a63ed4e0745b375e7e6a25004
Gerrit-Change-Number: 11597
Gerrit-PatchSet: 2
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 07 Nov 2018 10:37:56 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-tester[master]: ms_driver: Allow to specify env and binary name/path

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11596 )

Change subject: ms_driver: Allow to specify env and binary name/path
..


Patch Set 3: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/11596/3//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11596/3//COMMIT_MSG@11
PS3, Line 11: direcyly (e.g. need a LD_LIBRARY_PATH to be applied).
still contains the typo.



--
To view, visit https://gerrit.osmocom.org/11596
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I79a57e53bc20613ac061453c24fd29a6d05e1721
Gerrit-Change-Number: 11596
Gerrit-PatchSet: 3
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 07 Nov 2018 10:35:25 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-gsm-tester[master]: ms_driver: Fix subject in the header

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11649 )

Change subject: ms_driver: Fix subject in the header
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11649
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47e688b9fe3aef6679e3c82c641393ab041cbec3
Gerrit-Change-Number: 11649
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 07 Nov 2018 10:32:03 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: start implementing the TC_paging() PCU test

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/9374 )

Change subject: start implementing the TC_paging() PCU test
..


Patch Set 4:

Please rebase to latest master, add the test to control() and 
expected_results.xml


--
To view, visit https://gerrit.osmocom.org/9374
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0384e0742ab91983615e4f1c883bb044c1c8b18
Gerrit-Change-Number: 9374
Gerrit-PatchSet: 4
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Wed, 07 Nov 2018 10:24:15 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ci[master]: ansible: gsm-tester: Add IP addr for umtrx

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11619 )

Change subject: ansible: gsm-tester: Add IP addr for umtrx
..

ansible: gsm-tester: Add IP addr for umtrx

Change-Id: I7fb65e3c337fc82c787e925fbbdf9eaf7569defd
---
M ansible/roles/gsm-tester-network/templates/interface.j2
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Pau Espin Pedrol: Verified



diff --git a/ansible/roles/gsm-tester-network/templates/interface.j2 
b/ansible/roles/gsm-tester-network/templates/interface.j2
index f694261..30af679 100644
--- a/ansible/roles/gsm-tester-network/templates/interface.j2
+++ b/ansible/roles/gsm-tester-network/templates/interface.j2
@@ -68,3 +68,8 @@
 iface {{ bts_interface }}:12 inet static
 address 10.42.42.53
 netmask 255.255.255.0
+
+auto {{ bts_interface }}:13
+iface {{ bts_interface }}:13 inet static
+address 10.42.42.54
+netmask 255.255.255.0

--
To view, visit https://gerrit.osmocom.org/11619
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7fb65e3c337fc82c787e925fbbdf9eaf7569defd
Gerrit-Change-Number: 11619
Gerrit-PatchSet: 3
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-ci[master]: ansible: gsm-tester: prod has now 8 modems attached

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11627 )

Change subject: ansible: gsm-tester: prod has now 8 modems attached
..

ansible: gsm-tester: prod has now 8 modems attached

4 EC20 modems were attached,  and the issue with only 3 out of the 4
showing up was fixed a while ago.

Change-Id: I0e0876fd5581e9eb56c498078ae8cd8c68ede5b5
---
M ansible/host_vars/osmo-gsm-tester-prod.yml
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Neels Hofmeyr: Looks good to me, but someone else must approve
  Pau Espin Pedrol: Verified



diff --git a/ansible/host_vars/osmo-gsm-tester-prod.yml 
b/ansible/host_vars/osmo-gsm-tester-prod.yml
index 9d195de..92d8169 100644
--- a/ansible/host_vars/osmo-gsm-tester-prod.yml
+++ b/ansible/host_vars/osmo-gsm-tester-prod.yml
@@ -8,4 +8,4 @@
 ip: 10.42.42.122

 # how many modems are connected via a quadmodem?
-gsm_modems: 3
+gsm_modems: 8

--
To view, visit https://gerrit.osmocom.org/11627
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0e0876fd5581e9eb56c498078ae8cd8c68ede5b5
Gerrit-Change-Number: 11627
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-ci[master]: ansible: gsm-tester: Support power cycling multiple quad modems

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11628 )

Change subject: ansible: gsm-tester: Support power cycling multiple quad modems
..

ansible: gsm-tester: Support power cycling multiple quad modems

uhubctl doesn't support acting on several hubs from same vendor at once.

Change-Id: I01e698c96240130ed6f632f82383f6020d2a3b81
---
M ansible/roles/gsm-tester/templates/quad_modem_power_cycle.sh
1 file changed, 8 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Neels Hofmeyr: Looks good to me, approved
  Pau Espin Pedrol: Verified



diff --git a/ansible/roles/gsm-tester/templates/quad_modem_power_cycle.sh 
b/ansible/roles/gsm-tester/templates/quad_modem_power_cycle.sh
index 626a04e..f461d81 100755
--- a/ansible/roles/gsm-tester/templates/quad_modem_power_cycle.sh
+++ b/ansible/roles/gsm-tester/templates/quad_modem_power_cycle.sh
@@ -1,9 +1,15 @@
 #!/bin/sh
 set -ex
-uhubctl -p 123456 -a 0 -n 1d50:4002
+
+locations="$(uhubctl -n 1d50:4002 | grep "Current status for hub" | awk 
'{print $5}')"
+for l in $locations; do
+   uhubctl -p 123456 -a 0 -n 1d50:4002 -l $l
+done
 # give a lot of time to discharge capacitors on the board
 sleep 20
-uhubctl -p 123456 -a 1 -n 1d50:4002
+for l in $locations; do
+   uhubctl -p 123456 -a 1 -n 1d50:4002 -l $l
+done
 attempts=30
 while [ "x$(uhubctl | grep -e 05c6 -e 1199 -c)" != "x{{ gsm_modems }}" ]; do
attempts=$(($attempts - 1))

--
To view, visit https://gerrit.osmocom.org/11628
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I01e698c96240130ed6f632f82383f6020d2a3b81
Gerrit-Change-Number: 11628
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-ci[master]: ansible: gsm-tester: prod has now 8 modems attached

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11627 )

Change subject: ansible: gsm-tester: prod has now 8 modems attached
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/11627
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e0876fd5581e9eb56c498078ae8cd8c68ede5b5
Gerrit-Change-Number: 11627
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 07 Nov 2018 10:23:39 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ci[master]: ansible: gsm-tester: Support power cycling multiple quad modems

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11628 )

Change subject: ansible: gsm-tester: Support power cycling multiple quad modems
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/11628
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I01e698c96240130ed6f632f82383f6020d2a3b81
Gerrit-Change-Number: 11628
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 07 Nov 2018 10:23:23 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ci[master]: ansible: gsm-tester: Add IP addr for umtrx

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11619 )

Change subject: ansible: gsm-tester: Add IP addr for umtrx
..


Patch Set 2: Verified+1


--
To view, visit https://gerrit.osmocom.org/11619
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fb65e3c337fc82c787e925fbbdf9eaf7569defd
Gerrit-Change-Number: 11619
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 07 Nov 2018 10:21:47 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: gsm0808: add BSSMAP Cell Identifier matching API

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11504 )

Change subject: gsm0808: add BSSMAP Cell Identifier matching API
..


Patch Set 4:

> jenkins tests with gcc 6.3.0-18+deb9u1, my gcc is gcc (Debian
 > 8.2.0-9) 8.2.0.
 >
 > So a) this code will work as soon as we upgrade gcc.
 > But b) do we really want to depend on newer gcc :/
 >
 > Appears I need to think of some cumbersome magic to initialize the
 > structs.

afaiu, moving them inside a function (main()?) may be enough, since then they 
are not static (of course removing the static keyword).


--
To view, visit https://gerrit.osmocom.org/11504
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5535f0d149c2173294538df75764dd181b023312
Gerrit-Change-Number: 11504
Gerrit-PatchSet: 4
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 07 Nov 2018 10:20:42 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: BSC: log number of expected/seen *CX messages on failure

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11645 )

Change subject: BSC: log number of expected/seen *CX messages on failure
..


Patch Set 1: Code-Review-1

The commit description doesn't match with what the patch does.


--
To view, visit https://gerrit.osmocom.org/11645
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b743aaf9d68f2f332660d819d38ad8212484e00
Gerrit-Change-Number: 11645
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 07 Nov 2018 10:17:43 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-tester[master]: misc: Use RPATH to avoid having tests to set LD_LIBRARY_PATH

[Holger Freyther]

Holger Freyther has posted comments on this change. ( 
https://gerrit.osmocom.org/11580 )

Change subject: misc: Use RPATH to avoid having tests to set LD_LIBRARY_PATH
..


Patch Set 3: -Verified -Code-Review


--
To view, visit https://gerrit.osmocom.org/11580
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If771767dd82662e13b6b10ee7a8b8d0c84dcbdb1
Gerrit-Change-Number: 11580
Gerrit-PatchSet: 3
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 07 Nov 2018 09:31:50 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-tester[master]: misc: Use RPATH to avoid having tests to set LD_LIBRARY_PATH

[Holger Freyther]

Holger Freyther has posted comments on this change. ( 
https://gerrit.osmocom.org/11580 )

Change subject: misc: Use RPATH to avoid having tests to set LD_LIBRARY_PATH
..


Patch Set 3: Verified+1 Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11580
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If771767dd82662e13b6b10ee7a8b8d0c84dcbdb1
Gerrit-Change-Number: 11580
Gerrit-PatchSet: 3
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 07 Nov 2018 09:31:35 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes