Build failure of network:osmocom:nightly/openbsc in Raspbian_9.0/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Raspbian_9.0/armv7l Package network:osmocom:nightly/openbsc failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 203s] ../../src/libcommon/libcommon.a(talloc_ctx.o): In function `talloc_ctx_init': [ 203s] ./openbsc/src/libcommon/talloc_ctx.c:55: undefined reference to `tall_sigh_ctx' [ 203s] collect2: error: ld returned 1 exit status [ 203s] Makefile:483: recipe for target 'osmo-nitb' failed [ 203s] make[4]: *** [osmo-nitb] Error 1 [ 203s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/osmo-nitb' [ 203s] Makefile:450: recipe for target 'all-recursive' failed [ 203s] make[3]: *** [all-recursive] Error 1 [ 203s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src' [ 203s] Makefile:470: recipe for target 'all-recursive' failed [ 203s] make[2]: *** [all-recursive] Error 1 [ 203s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 203s] Makefile:402: recipe for target 'all' failed [ 203s] make[1]: *** [all] Error 2 [ 203s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 203s] dh_auto_build: make -j1 returned exit code 2 [ 203s] debian/rules:13: recipe for target 'build' failed [ 203s] make: *** [build] Error 2 [ 203s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 203s] [ 203s] obs-arm-5 failed "build openbsc_1.2.0.20190322.dsc" at Fri Mar 22 03:00:07 UTC 2019. [ 203s] [ 203s] ### VM INTERACTION START ### [ 206s] [ 182.420350] sysrq: SysRq : Power Off [ 206s] [ 182.427646] reboot: Power down [ 207s] ### VM INTERACTION END ### [ 207s] [ 207s] obs-arm-5 failed "build openbsc_1.2.0.20190322.dsc" at Fri Mar 22 03:00:11 UTC 2019. [ 207s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/openbsc in Debian_9.0/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/armv7l Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 298s] ../../src/libcommon/libcommon.a(talloc_ctx.o): In function `talloc_ctx_init': [ 298s] ./openbsc/src/libcommon/talloc_ctx.c:55: undefined reference to `tall_sigh_ctx' [ 298s] collect2: error: ld returned 1 exit status [ 298s] Makefile:483: recipe for target 'osmo-nitb' failed [ 298s] make[4]: *** [osmo-nitb] Error 1 [ 298s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/osmo-nitb' [ 298s] Makefile:450: recipe for target 'all-recursive' failed [ 298s] make[3]: *** [all-recursive] Error 1 [ 298s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src' [ 298s] Makefile:470: recipe for target 'all-recursive' failed [ 298s] make[2]: *** [all-recursive] Error 1 [ 298s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 298s] Makefile:402: recipe for target 'all' failed [ 298s] make[1]: *** [all] Error 2 [ 298s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 298s] dh_auto_build: make -j1 returned exit code 2 [ 298s] debian/rules:13: recipe for target 'build' failed [ 298s] make: *** [build] Error 2 [ 298s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 298s] [ 298s] armbuild19 failed "build openbsc_1.2.0.20190322.dsc" at Fri Mar 22 02:57:37 UTC 2019. [ 298s] [ 298s] ### VM INTERACTION START ### [ 302s] [ 262.651029] sysrq: SysRq : Power Off [ 302s] [ 262.653319] reboot: Power down [ 302s] ### VM INTERACTION END ### [ 302s] [ 302s] armbuild19 failed "build openbsc_1.2.0.20190322.dsc" at Fri Mar 22 02:57:41 UTC 2019. [ 302s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/openbsc in xUbuntu_18.10/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_18.10/x86_64 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_18.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 137s] /usr/include/osmocom/core/application.h:20:5: note: declared here [ 137s] int osmo_init_logging(const struct log_info *) [ 137s] ^ [ 137s] /bin/bash ../../libtool --tag=CC --mode=link gcc -Wall -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Werror=null-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-z,now -o osmo-nitb bsc_hack.o ../../src/libbsc/libbsc.a ../../src/libcommon-cs/libcommon-cs.a ../../src/libmsc/libmsc.a ../../src/libtrau/libtrau.a ../../src/libcommon/libcommon.a -ltalloc -losmogsm -losmocore -ltalloc -losmovty -losmocore -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -losmoabis -lsmpp34 -ldbi [ 138s] libtool: link: gcc -Wall -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Werror=null-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -Wl,-Bsymbolic-functions -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-nitb bsc_hack.o ../../src/libbsc/libbsc.a ../../src/libcommon-cs/libcommon-cs.a ../../src/libmsc/libmsc.a ../../src/libtrau/libtrau.a ../../src/libcommon/libcommon.a /usr/lib/x86_64-linux-gnu/libosmovty.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so /usr/lib/x86_64-linux-gnu/libosmocore.so /usr/lib/x86_64-linux-gnu/libosmoabis.so /usr/lib/x86_64-linux-gnu/libsmpp34.so -ldbi [ 138s] /usr/bin/ld: ../../src/libcommon/libcommon.a(talloc_ctx.o): in function `talloc_ctx_init': [ 138s] ./openbsc/src/libcommon/talloc_ctx.c:50: undefined reference to `tall_sigh_ctx' [ 138s] collect2: error: ld returned 1 exit status [ 138s] make[4]: *** [Makefile:485: osmo-nitb] Error 1 [ 138s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/osmo-nitb' [ 138s] make[3]: *** [Makefile:450: all-recursive] Error 1 [ 138s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src' [ 138s] make[2]: *** [Makefile:470: all-recursive] Error 1 [ 138s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 138s] make[1]: *** [Makefile:402: all] Error 2 [ 138s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 138s] dh_auto_build: cd openbsc && make -j1 returned exit code 2 [ 138s] make: *** [debian/rules:13: build] Error 2 [ 138s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 138s] [ 138s] lamb58 failed "build openbsc_1.2.0.20190322.dsc" at Fri Mar 22 02:48:16 UTC 2019. [ 138s] [ 138s] ### VM INTERACTION START ### [ 141s] [ 128.684256] sysrq: SysRq : Power Off [ 141s] [ 128.691242] reboot: Power down [ 141s] ### VM INTERACTION END ### [ 141s] [ 141s] lamb58 failed "build openbsc_1.2.0.20190322.dsc" at Fri Mar 22 02:48:19 UTC 2019. [ 141s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/openbsc in Debian_8.0/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_8.0/x86_64 Package network:osmocom:nightly/openbsc failed to build in Debian_8.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 108s] ../../src/libcommon/libcommon.a(talloc_ctx.o): In function `talloc_ctx_init': [ 108s] /usr/src/packages/BUILD/openbsc/src/libcommon/talloc_ctx.c:50: undefined reference to `tall_sigh_ctx' [ 108s] collect2: error: ld returned 1 exit status [ 108s] Makefile:472: recipe for target 'osmo-nitb' failed [ 108s] make[4]: *** [osmo-nitb] Error 1 [ 108s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/osmo-nitb' [ 108s] Makefile:438: recipe for target 'all-recursive' failed [ 108s] make[3]: *** [all-recursive] Error 1 [ 108s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src' [ 108s] Makefile:458: recipe for target 'all-recursive' failed [ 108s] make[2]: *** [all-recursive] Error 1 [ 108s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 108s] Makefile:389: recipe for target 'all' failed [ 108s] make[1]: *** [all] Error 2 [ 108s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 108s] dh_auto_build: make -j1 returned exit code 2 [ 108s] debian/rules:13: recipe for target 'build' failed [ 108s] make: *** [build] Error 2 [ 108s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 108s] [ 108s] lamb03 failed "build openbsc_1.2.0.20190322.dsc" at Fri Mar 22 02:47:52 UTC 2019. [ 108s] [ 108s] ### VM INTERACTION START ### [ 109s] Powering off. [ 109s] [ 96.705248] reboot: Power down [ 109s] ### VM INTERACTION END ### [ 109s] [ 109s] lamb03 failed "build openbsc_1.2.0.20190322.dsc" at Fri Mar 22 02:47:53 UTC 2019. [ 109s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/openbsc in xUbuntu_18.04/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_18.04/i586 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_18.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 111s] ../../src/libcommon/libcommon.a(talloc_ctx.o): In function `talloc_ctx_init': [ 111s] ./openbsc/src/libcommon/talloc_ctx.c:50: undefined reference to `tall_sigh_ctx' [ 111s] collect2: error: ld returned 1 exit status [ 111s] Makefile:483: recipe for target 'osmo-nitb' failed [ 111s] make[4]: *** [osmo-nitb] Error 1 [ 111s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/osmo-nitb' [ 111s] Makefile:450: recipe for target 'all-recursive' failed [ 111s] make[3]: *** [all-recursive] Error 1 [ 111s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src' [ 111s] Makefile:470: recipe for target 'all-recursive' failed [ 111s] make[2]: *** [all-recursive] Error 1 [ 111s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 111s] Makefile:402: recipe for target 'all' failed [ 111s] make[1]: *** [all] Error 2 [ 111s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 111s] dh_auto_build: cd openbsc && make -j1 returned exit code 2 [ 111s] debian/rules:13: recipe for target 'build' failed [ 111s] make: *** [build] Error 2 [ 111s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 111s] [ 111s] sheep84 failed "build openbsc_1.2.0.20190322.dsc" at Fri Mar 22 02:47:11 UTC 2019. [ 111s] [ 111s] ### VM INTERACTION START ### [ 115s] [ 106.222364] sysrq: SysRq : Power Off [ 115s] [ 106.229135] reboot: Power down [ 115s] ### VM INTERACTION END ### [ 115s] [ 115s] sheep84 failed "build openbsc_1.2.0.20190322.dsc" at Fri Mar 22 02:47:16 UTC 2019. [ 115s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/openbsc in xUbuntu_17.10/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_17.10/x86_64 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_17.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 112s] ../../src/libcommon/libcommon.a(talloc_ctx.o): In function `talloc_ctx_init': [ 112s] ./openbsc/src/libcommon/talloc_ctx.c:50: undefined reference to `tall_sigh_ctx' [ 112s] collect2: error: ld returned 1 exit status [ 112s] Makefile:483: recipe for target 'osmo-nitb' failed [ 112s] make[4]: *** [osmo-nitb] Error 1 [ 112s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/osmo-nitb' [ 112s] Makefile:450: recipe for target 'all-recursive' failed [ 112s] make[3]: *** [all-recursive] Error 1 [ 112s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src' [ 112s] Makefile:470: recipe for target 'all-recursive' failed [ 112s] make[2]: *** [all-recursive] Error 1 [ 112s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 112s] Makefile:402: recipe for target 'all' failed [ 112s] make[1]: *** [all] Error 2 [ 112s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 112s] dh_auto_build: make -j1 returned exit code 2 [ 112s] debian/rules:13: recipe for target 'build' failed [ 112s] make: *** [build] Error 2 [ 112s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 113s] [ 113s] lamb07 failed "build openbsc_1.2.0.20190322.dsc" at Fri Mar 22 02:46:41 UTC 2019. [ 113s] [ 113s] ### VM INTERACTION START ### [ 116s] [ 105.621835] sysrq: SysRq : Power Off [ 116s] [ 105.629590] reboot: Power down [ 116s] ### VM INTERACTION END ### [ 116s] [ 116s] lamb07 failed "build openbsc_1.2.0.20190322.dsc" at Fri Mar 22 02:46:44 UTC 2019. [ 116s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/openbsc in Debian_9.0/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/i586 Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 157s] ../../src/libcommon/libcommon.a(talloc_ctx.o): In function `talloc_ctx_init': [ 157s] ./openbsc/src/libcommon/talloc_ctx.c:50: undefined reference to `tall_sigh_ctx' [ 157s] collect2: error: ld returned 1 exit status [ 157s] Makefile:483: recipe for target 'osmo-nitb' failed [ 157s] make[4]: *** [osmo-nitb] Error 1 [ 157s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/osmo-nitb' [ 157s] Makefile:450: recipe for target 'all-recursive' failed [ 157s] make[3]: *** [all-recursive] Error 1 [ 157s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src' [ 157s] Makefile:470: recipe for target 'all-recursive' failed [ 157s] make[2]: *** [all-recursive] Error 1 [ 157s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 157s] Makefile:402: recipe for target 'all' failed [ 157s] make[1]: *** [all] Error 2 [ 157s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 157s] dh_auto_build: make -j1 returned exit code 2 [ 157s] debian/rules:13: recipe for target 'build' failed [ 157s] make: *** [build] Error 2 [ 157s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 157s] [ 157s] cloud126 failed "build openbsc_1.2.0.20190322.dsc" at Fri Mar 22 02:46:40 UTC 2019. [ 157s] [ 157s] ### VM INTERACTION START ### [ 160s] [ 136.144224] sysrq: SysRq : Power Off [ 160s] [ 136.148852] reboot: Power down [ 161s] ### VM INTERACTION END ### [ 161s] [ 161s] cloud126 failed "build openbsc_1.2.0.20190322.dsc" at Fri Mar 22 02:46:45 UTC 2019. [ 161s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/openbsc in xUbuntu_17.10/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_17.10/i586 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_17.10/i586 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 117s] ../../src/libcommon/libcommon.a(talloc_ctx.o): In function `talloc_ctx_init': [ 117s] ./openbsc/src/libcommon/talloc_ctx.c:50: undefined reference to `tall_sigh_ctx' [ 117s] collect2: error: ld returned 1 exit status [ 117s] Makefile:483: recipe for target 'osmo-nitb' failed [ 117s] make[4]: *** [osmo-nitb] Error 1 [ 117s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/osmo-nitb' [ 117s] Makefile:450: recipe for target 'all-recursive' failed [ 117s] make[3]: *** [all-recursive] Error 1 [ 117s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src' [ 117s] Makefile:470: recipe for target 'all-recursive' failed [ 117s] make[2]: *** [all-recursive] Error 1 [ 117s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 117s] Makefile:402: recipe for target 'all' failed [ 117s] make[1]: *** [all] Error 2 [ 117s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 117s] dh_auto_build: make -j1 returned exit code 2 [ 117s] debian/rules:13: recipe for target 'build' failed [ 117s] make: *** [build] Error 2 [ 117s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 117s] [ 117s] wildcard2 failed "build openbsc_1.2.0.20190322.dsc" at Fri Mar 22 02:46:56 UTC 2019. [ 117s] [ 117s] ### VM INTERACTION START ### [ 120s] [ 105.016785] sysrq: SysRq : Power Off [ 120s] [ 105.020052] reboot: Power down [ 121s] ### VM INTERACTION END ### [ 121s] [ 121s] wildcard2 failed "build openbsc_1.2.0.20190322.dsc" at Fri Mar 22 02:47:01 UTC 2019. [ 121s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/openbsc in Debian_9.0/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/x86_64 Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 147s] int osmo_init_logging(const struct log_info *) [ 147s] ^ [ 147s] /bin/bash ../../libtool --tag=CC --mode=link gcc -Wall -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Werror=null-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -Wl,-z,relro -Wl,-z,now -o osmo-nitb bsc_hack.o ../../src/libbsc/libbsc.a ../../src/libcommon-cs/libcommon-cs.a ../../src/libmsc/libmsc.a ../../src/libtrau/libtrau.a ../../src/libcommon/libcommon.a -ltalloc -losmogsm -losmocore -ltalloc -losmovty -losmocore -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -losmoabis -lsmpp34 -ldbi [ 147s] libtool: link: gcc -Wall -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Werror=null-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-nitb bsc_hack.o ../../src/libbsc/libbsc.a ../../src/libcommon-cs/libcommon-cs.a ../../src/libmsc/libmsc.a ../../src/libtrau/libtrau.a ../../src/libcommon/libcommon.a /usr/lib/x86_64-linux-gnu/libosmovty.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so /usr/lib/x86_64-linux-gnu/libosmocore.so /usr/lib/x86_64-linux-gnu/libosmoabis.so /usr/lib/x86_64-linux-gnu/libsmpp34.so -ldbi [ 148s] ../../src/libcommon/libcommon.a(talloc_ctx.o): In function `talloc_ctx_init': [ 148s] ./openbsc/src/libcommon/talloc_ctx.c:50: undefined reference to `tall_sigh_ctx' [ 148s] collect2: error: ld returned 1 exit status [ 148s] Makefile:483: recipe for target 'osmo-nitb' failed [ 148s] make[4]: *** [osmo-nitb] Error 1 [ 148s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/osmo-nitb' [ 148s] Makefile:450: recipe for target 'all-recursive' failed [ 148s] make[3]: *** [all-recursive] Error 1 [ 148s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src' [ 148s] Makefile:470: recipe for target 'all-recursive' failed [ 148s] make[2]: *** [all-recursive] Error 1 [ 148s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 148s] Makefile:402: recipe for target 'all' failed [ 148s] make[1]: *** [all] Error 2 [ 148s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 148s] dh_auto_build: make -j1 returned exit code 2 [ 148s] debian/rules:13: recipe for target 'build' failed [ 148s] make: *** [build] Error 2 [ 148s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 148s] [ 148s] cloud106 failed "build openbsc_1.2.0.20190322.dsc" at Fri Mar 22 02:46:10 UTC 2019. [ 148s] [ 148s] ### VM INTERACTION START ### [ 151s] [ 122.717474] sysrq: SysRq : Power Off [ 151s] [ 122.730492] reboot: Power down -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/openbsc in xUbuntu_18.04/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_18.04/x86_64 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 147s] ../../src/libcommon/libcommon.a(talloc_ctx.o): In function `talloc_ctx_init': [ 147s] ./openbsc/src/libcommon/talloc_ctx.c:50: undefined reference to `tall_sigh_ctx' [ 147s] collect2: error: ld returned 1 exit status [ 147s] Makefile:483: recipe for target 'osmo-nitb' failed [ 147s] make[4]: *** [osmo-nitb] Error 1 [ 147s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/osmo-nitb' [ 147s] Makefile:450: recipe for target 'all-recursive' failed [ 147s] make[3]: *** [all-recursive] Error 1 [ 147s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src' [ 147s] Makefile:470: recipe for target 'all-recursive' failed [ 147s] make[2]: *** [all-recursive] Error 1 [ 147s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 147s] Makefile:402: recipe for target 'all' failed [ 147s] make[1]: *** [all] Error 2 [ 147s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 147s] dh_auto_build: cd openbsc && make -j1 returned exit code 2 [ 147s] debian/rules:13: recipe for target 'build' failed [ 147s] make: *** [build] Error 2 [ 148s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 148s] [ 148s] morla3 failed "build openbsc_1.2.0.20190322.dsc" at Fri Mar 22 02:45:55 UTC 2019. [ 148s] [ 148s] ### VM INTERACTION START ### [ 151s] [ 136.273818] sysrq: SysRq : Power Off [ 151s] [ 136.293697] reboot: Power down [ 151s] ### VM INTERACTION END ### [ 151s] [ 151s] morla3 failed "build openbsc_1.2.0.20190322.dsc" at Fri Mar 22 02:45:59 UTC 2019. [ 151s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/openbsc in xUbuntu_16.04/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_16.04/x86_64 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_16.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 133s] ../../src/libcommon/libcommon.a(talloc_ctx.o): In function `talloc_ctx_init': [ 133s] /usr/src/packages/BUILD/openbsc/src/libcommon/talloc_ctx.c:50: undefined reference to `tall_sigh_ctx' [ 133s] collect2: error: ld returned 1 exit status [ 133s] Makefile:483: recipe for target 'osmo-nitb' failed [ 133s] make[4]: *** [osmo-nitb] Error 1 [ 133s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/osmo-nitb' [ 133s] Makefile:450: recipe for target 'all-recursive' failed [ 133s] make[3]: *** [all-recursive] Error 1 [ 133s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src' [ 133s] Makefile:470: recipe for target 'all-recursive' failed [ 133s] make[2]: *** [all-recursive] Error 1 [ 133s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 133s] Makefile:402: recipe for target 'all' failed [ 133s] make[1]: *** [all] Error 2 [ 133s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 133s] dh_auto_build: make -j1 returned exit code 2 [ 133s] debian/rules:13: recipe for target 'build' failed [ 133s] make: *** [build] Error 2 [ 133s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 133s] [ 133s] morla3 failed "build openbsc_1.2.0.20190322.dsc" at Fri Mar 22 02:43:31 UTC 2019. [ 133s] [ 133s] ### VM INTERACTION START ### [ 136s] [ 122.937241] sysrq: SysRq : Power Off [ 136s] [ 122.946607] reboot: Power down [ 136s] ### VM INTERACTION END ### [ 136s] [ 136s] morla3 failed "build openbsc_1.2.0.20190322.dsc" at Fri Mar 22 02:43:35 UTC 2019. [ 136s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Change in osmo-ttcn3-hacks[master]: NS_Emulation: Add minimal support for SGSN-side SNS handling
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13046 ) Change subject: NS_Emulation: Add minimal support for SGSN-side SNS handling .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/13046 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1edf739d6fd39478f662a28a7d9334ca51c270a3 Gerrit-Change-Number: 13046 Gerrit-PatchSet: 2 Gerrit-Owner: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Comment-Date: Thu, 21 Mar 2019 21:47:46 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-ttcn3-hacks[master]: NS_Emulation: Disable sending NS-RESET from SGSN to BSS
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13047 ) Change subject: NS_Emulation: Disable sending NS-RESET from SGSN to BSS .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/13047 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a5775fcaf63ac008adecaf2c602c82e9e4ccb5a Gerrit-Change-Number: 13047 Gerrit-PatchSet: 2 Gerrit-Owner: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Comment-Date: Thu, 21 Mar 2019 21:47:44 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-pcu[master]: Forward GPRS SUSPEND REQ from BTS to SGSN using BSSGP
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/3384 ) Change subject: Forward GPRS SUSPEND REQ from BTS to SGSN using BSSGP .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/3384 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7b4beb413a6f974373a404b5a11c44d86ba695d3 Gerrit-Change-Number: 3384 Gerrit-PatchSet: 13 Gerrit-Owner: Harald Welte Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 21 Mar 2019 21:37:29 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-pcu[master]: gprs_debug: Use named initializers and explicit array indicies
Harald Welte has uploaded this change for review. (
https://gerrit.osmocom.org/13384
Change subject: gprs_debug: Use named initializers and explicit array indicies
..
gprs_debug: Use named initializers and explicit array indicies
This is a much safe way, it allows for modifications of the debug
subsystem enum member values without breakage. Also, the syntax
introduced here is what we do in all other Osmocom CNI projects.
Change-Id: I2be88586ca44b0b8361f96cf3c034c8459244c2c
---
M src/gprs_debug.cpp
1 file changed, 99 insertions(+), 14 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/84/13384/1
diff --git a/src/gprs_debug.cpp b/src/gprs_debug.cpp
index f1ae6ad..91933a2 100644
--- a/src/gprs_debug.cpp
+++ b/src/gprs_debug.cpp
@@ -1,6 +1,7 @@
/* gprs_debug.cpp
*
* Copyright (C) 2012 Ivan Klyuchnikov
+ * Copyright (C) 2019 Harald Welte
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
@@ -24,20 +25,104 @@
/* default categories */
static const struct log_info_cat default_categories[] = {
- {"DCSN1", "\033[1;31m", "Concrete Syntax Notation One (CSN1)",
LOGL_INFO, 0},
- {"DL1IF", "\033[1;32m", "GPRS PCU L1 interface (L1IF)", LOGL_INFO, 1},
- {"DRLCMAC", "\033[0;33m", "GPRS RLC/MAC layer (RLCMAC)", LOGL_NOTICE,
1},
- {"DRLCMACDATA", "\033[0;33m", "GPRS RLC/MAC layer Data (RLCMAC)",
LOGL_NOTICE, 1},
- {"DRLCMACDL", "\033[1;33m", "GPRS RLC/MAC layer Downlink (RLCMAC)",
LOGL_NOTICE, 1},
- {"DRLCMACUL", "\033[1;36m", "GPRS RLC/MAC layer Uplink (RLCMAC)",
LOGL_NOTICE, 1},
- {"DRLCMACSCHED", "\033[0;36m", "GPRS RLC/MAC layer Scheduling
(RLCMAC)", LOGL_NOTICE, 1},
- {"DRLCMACMEAS", "\033[1;31m", "GPRS RLC/MAC layer Measurements
(RLCMAC)", LOGL_INFO, 1},
- {"DTBF","\033[1;34m", "Temporary Block Flow (TBF)", LOGL_INFO , 1},
- {"DTBFDL","\033[1;34m", "Temporary Block Flow (TBF) Downlink",
LOGL_INFO , 1},
- {"DTBFUL","\033[1;34m", "Temporary Block Flow (TBF) Uplink", LOGL_INFO
, 1},
- {"DNS","\033[1;34m", "GPRS Network Service Protocol (NS)", LOGL_INFO ,
1},
- {"DBSSGP","\033[1;34m", "GPRS BSS Gateway Protocol (BSSGP)", LOGL_INFO
, 1},
- {"DPCU", "\033[1;35m", "GPRS Packet Control Unit (PCU)", LOGL_NOTICE,
1},
+ [DCSN1] = {
+ .name = "DCSN1",
+ .color = "\033[1;31m",
+ .description = "Concrete Syntax Notation One (CSN1)",
+ .loglevel = LOGL_INFO,
+ .enabled = 0,
+ },
+ [DL1IF] = {
+ .name = "DL1IF",
+ .color = "\033[1;32m",
+ .description = "GPRS PCU L1 interface (L1IF)",
+ .loglevel = LOGL_INFO,
+ .enabled = 1,
+ },
+ [DRLCMAC] = {
+ .name = "DRLCMAC",
+ .color = "\033[0;33m",
+ .description = "GPRS RLC/MAC layer (RLCMAC)",
+ .loglevel = LOGL_NOTICE,
+ .enabled = 1,
+ },
+ [DRLCMACDATA] = {
+ .name = "DRLCMACDATA",
+ .color = "\033[0;33m",
+ .description = "GPRS RLC/MAC layer Data (RLCMAC)",
+ .loglevel = LOGL_NOTICE,
+ .enabled = 1,
+ },
+ [DRLCMACDL] = {
+ .name = "DRLCMACDL",
+ .color = "\033[1;33m",
+ .description = "GPRS RLC/MAC layer Downlink (RLCMAC)",
+ .loglevel = LOGL_NOTICE,
+ .enabled = 1,
+ },
+ [DRLCMACUL] = {
+ .name = "DRLCMACUL",
+ .color = "\033[1;36m",
+ .description = "GPRS RLC/MAC layer Uplink (RLCMAC)",
+ .loglevel = LOGL_NOTICE,
+ .enabled = 1,
+ },
+ [DRLCMACSCHED] = {
+ .name = "DRLCMACSCHED",
+ .color = "\033[0;36m",
+ .description = "GPRS RLC/MAC layer Scheduling (RLCMAC)",
+ .loglevel = LOGL_NOTICE,
+ .enabled = 1,
+ },
+ [DRLCMACMEAS] = {
+ .name = "DRLCMACMEAS",
+ .color = "\033[1;31m",
+ .description = "GPRS RLC/MAC layer Measurements (RLCMAC)",
+ .loglevel = LOGL_INFO,
+ .enabled = 1,
+ },
+ [DTBF] = {
+ .name = "DTBF",
+ .color = "\033[1;34m",
+ .description = "Temporary Block Flow (TBF)",
+ .loglevel = LOGL_INFO,
+ .enabled = 1,
+ },
+ [DTBFDL] = {
+ .name = "DTBFDL",
+ .color = "\033[1;34m",
+ .description = "Temporary Block Flow (TBF) Downlink",
+ .loglevel = LOGL_INFO,
+ .enabled = 1,
+ },
+ [DTBFUL] = {
+ .name = "DTBFUL",
+ .color = "\033[1;34m",
+
Build failure of network:osmocom:nightly/osmo-sysmon in Raspbian_9.0/armv7l
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sysmon/Raspbian_9.0/armv7l
Package network:osmocom:nightly/osmo-sysmon failed to build in
Raspbian_9.0/armv7l
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-sysmon
Last lines of build log:
[ 127s] #define VERSION "0.1.0"
[ 127s] #define STDC_HEADERS 1
[ 127s] #define HAVE_SYS_TYPES_H 1
[ 127s] #define HAVE_SYS_STAT_H 1
[ 127s] #define HAVE_STDLIB_H 1
[ 127s] #define HAVE_STRING_H 1
[ 127s] #define HAVE_MEMORY_H 1
[ 127s] #define HAVE_STRINGS_H 1
[ 127s] #define HAVE_INTTYPES_H 1
[ 127s] #define HAVE_STDINT_H 1
[ 127s] #define HAVE_UNISTD_H 1
[ 127s] #define HAVE_DLFCN_H 1
[ 127s] #define LT_OBJDIR ".libs/"
[ 127s]
[ 127s] configure: exit 1
[ 127s] dh_auto_configure: ./configure --build=arm-linux-gnueabihf
--prefix=/usr --includedir=${prefix}/include --mandir=${prefix}/share/man
--infodir=${prefix}/share/info --sysconfdir=/etc --localstatedir=/var
--disable-silent-rules --libdir=${prefix}/lib/arm-linux-gnueabihf
--libexecdir=${prefix}/lib/arm-linux-gnueabihf --disable-maintainer-mode
--disable-dependency-tracking returned exit code 1
[ 127s] debian/rules:45: recipe for target 'build' failed
[ 127s] make: *** [build] Error 2
[ 127s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[ 127s]
[ 127s] armbuild24 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 21:33:14
UTC 2019.
[ 127s]
[ 127s] ### VM INTERACTION START ###
[ 130s] [ 109.283901] SysRq : Power Off
[ 130s] [ 109.334113] reboot: Power down
[ 130s] ### VM INTERACTION END ###
[ 130s]
[ 130s] armbuild24 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 21:33:17
UTC 2019.
[ 130s]
--
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-sysmon in Debian_9.0/armv7l
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sysmon/Debian_9.0/armv7l
Package network:osmocom:nightly/osmo-sysmon failed to build in Debian_9.0/armv7l
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-sysmon
Last lines of build log:
[ 123s] #define VERSION "0.1.0"
[ 123s] #define STDC_HEADERS 1
[ 123s] #define HAVE_SYS_TYPES_H 1
[ 123s] #define HAVE_SYS_STAT_H 1
[ 123s] #define HAVE_STDLIB_H 1
[ 123s] #define HAVE_STRING_H 1
[ 123s] #define HAVE_MEMORY_H 1
[ 123s] #define HAVE_STRINGS_H 1
[ 123s] #define HAVE_INTTYPES_H 1
[ 123s] #define HAVE_STDINT_H 1
[ 123s] #define HAVE_UNISTD_H 1
[ 123s] #define HAVE_DLFCN_H 1
[ 123s] #define LT_OBJDIR ".libs/"
[ 124s]
[ 124s] configure: exit 1
[ 124s] dh_auto_configure: ./configure --build=arm-linux-gnueabihf
--prefix=/usr --includedir=${prefix}/include --mandir=${prefix}/share/man
--infodir=${prefix}/share/info --sysconfdir=/etc --localstatedir=/var
--disable-silent-rules --libdir=${prefix}/lib/arm-linux-gnueabihf
--libexecdir=${prefix}/lib/arm-linux-gnueabihf --disable-maintainer-mode
--disable-dependency-tracking returned exit code 1
[ 124s] debian/rules:45: recipe for target 'build' failed
[ 124s] make: *** [build] Error 2
[ 124s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[ 124s]
[ 124s] armbuild24 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 21:32:09
UTC 2019.
[ 124s]
[ 124s] ### VM INTERACTION START ###
[ 126s] [ 107.212231] SysRq : Power Off
[ 126s] [ 107.232347] reboot: Power down
[ 127s] ### VM INTERACTION END ###
[ 127s]
[ 127s] armbuild24 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 21:32:13
UTC 2019.
[ 127s]
--
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)
Change in osmo-ttcn3-hacks[master]: PCU: make f_bssgp_establish() run on BSSGP_Client_CT
Harald Welte has uploaded this change for review. (
https://gerrit.osmocom.org/13382
Change subject: PCU: make f_bssgp_establish() run on BSSGP_Client_CT
..
PCU: make f_bssgp_establish() run on BSSGP_Client_CT
This means it can be used in different/other scenarios, e.g.
with tests that use PCUIF directly.
Change-Id: I1aa5dc090aac78a85a85ac190343befb0199a093
---
M pcu/PCU_Tests.ttcn
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/82/13382/1
diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn
index b18b999..80a1bd1 100644
--- a/pcu/PCU_Tests.ttcn
+++ b/pcu/PCU_Tests.ttcn
@@ -195,10 +195,9 @@
}
/* Establish BSSGP connection to PCU */
-function f_bssgp_establish() runs on dummy_CT {
+function f_bssgp_establish() runs on BSSGP_Client_CT {
timer T:= 10.0;
- f_init();
T.start
alt {
[] BSSGP[0].receive(t_BssgpStsInd(?, ?, BVC_S_UNBLOCKED)) { }
@@ -386,6 +385,7 @@
testcase TC_nsem() runs on dummy_CT {
+ f_init();
f_bssgp_establish();
while (true) {
--
To view, visit https://gerrit.osmocom.org/13382
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1aa5dc090aac78a85a85ac190343befb0199a093
Gerrit-Change-Number: 13382
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte
Change in osmo-ttcn3-hacks[master]: PCUIF: Add templates for PCU_IF_MSG_SUSP_REQ
Harald Welte has uploaded this change for review. (
https://gerrit.osmocom.org/13381
Change subject: PCUIF: Add templates for PCU_IF_MSG_SUSP_REQ
..
PCUIF: Add templates for PCU_IF_MSG_SUSP_REQ
Change-Id: Ib7661790b9531be829ee550ce889151ebe1885ac
---
M library/PCUIF_Types.ttcn
1 file changed, 32 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/81/13381/1
diff --git a/library/PCUIF_Types.ttcn b/library/PCUIF_Types.ttcn
index 0c3f000..17adbd1 100644
--- a/library/PCUIF_Types.ttcn
+++ b/library/PCUIF_Types.ttcn
@@ -772,4 +772,36 @@
}
}
+template (value) PCUIF_Message ts_PCUIF_SUSP_REQ(template (value) uint8_t
bts_nr,
+template (value) OCT4 tlli,
+template (value) OCT6 ra_id,
+template (value) uint8_t
cause) := {
+ msg_type := PCU_IF_MSG_SUSP_REQ,
+ bts_nr := bts_nr,
+ spare := ''O,
+ u := {
+ susp_req := {
+ tlli := tlli,
+ ra_id := ra_id,
+ cause := cause
+ }
+ }
+}
+template PCUIF_Message tr_PCUIF_SUSP_REQ(template uint8_t bts_nr,
+template OCT4 tlli,
+template OCT6 ra_id,
+template uint8_t cause) := {
+ msg_type := PCU_IF_MSG_SUSP_REQ,
+ bts_nr := bts_nr,
+ spare := ''O,
+ u := {
+ susp_req := {
+ tlli := tlli,
+ ra_id := ra_id,
+ cause := cause
+ }
+ }
+}
+
+
} with { encode "RAW" variant "BYTEORDER(first)" };
--
To view, visit https://gerrit.osmocom.org/13381
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib7661790b9531be829ee550ce889151ebe1885ac
Gerrit-Change-Number: 13381
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte
Change in osmo-ttcn3-hacks[master]: Osmocom_Gb_Types: Add more templates for BSSGP SUSPEND/RESUME
Harald Welte has uploaded this change for review. (
https://gerrit.osmocom.org/13379
Change subject: Osmocom_Gb_Types: Add more templates for BSSGP SUSPEND/RESUME
..
Osmocom_Gb_Types: Add more templates for BSSGP SUSPEND/RESUME
Change-Id: Ife25401043d565e52a73206c562bbb68bcfdbafa
---
M library/Osmocom_Gb_Types.ttcn
1 file changed, 176 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/79/13379/1
diff --git a/library/Osmocom_Gb_Types.ttcn b/library/Osmocom_Gb_Types.ttcn
index 780c768..623be33 100644
--- a/library/Osmocom_Gb_Types.ttcn
+++ b/library/Osmocom_Gb_Types.ttcn
@@ -732,6 +732,40 @@
unstructured_value := f_oct_or_wc(bvci, 2)
}
+ template (value) TLLI_BSSGP ts_BSSGP_TLLI(template (value) GprsTlli
tlli) := {
+ iEI := '1F'O,
+ ext := '1'B,
+ lengthIndicator := {
+ length1 := 4
+ },
+ tLLI_Value := tlli
+ }
+ template TLLI_BSSGP tr_BSSGP_TLLI(template GprsTlli tlli) := {
+ iEI := '1F'O,
+ ext := '1'B,
+ lengthIndicator := {
+ length1 := 4
+ },
+ tLLI_Value := tlli
+ }
+
+ template (value) Suspend_Reference_Number ts_BSSGP_SUSP_REF(template
(value) OCT1 susp_ref) := {
+ iEI := '1D'O,
+ ext := '1'B,
+ lengthIndicator := {
+ length1 := 1
+ },
+ suspend_Reference_Number_value := susp_ref
+ }
+ template Suspend_Reference_Number tr_BSSGP_SUSP_REF(template OCT1
susp_ref) := {
+ iEI := '1D'O,
+ ext := '1'B,
+ lengthIndicator := {
+ length1 := 1
+ },
+ suspend_Reference_Number_value := susp_ref
+ }
+
template IMSI_BSSGP tr_BSSGP_IMSI(template hexstring imsi) := {
iEI := '0D'O,
ext := '1'B,
@@ -781,6 +815,18 @@
lLC_PDU := pdu
}
+ function ts_BSSGP_CAUSE(template (omit) BssgpCause cause) return
template (omit) Cause_BSSGP {
+ var template (omit) Cause_BSSGP ret;
+ if (istemplatekind(cause, "omit")) {
+ ret := omit;
+ } else {
+ ret.iEI := '07'O;
+ ret.ext := '1'B;
+ ret.lengthIndicator := { length1 := 1 };
+ ret.cause_Value := int2oct(enum2int(valueof(cause)), 1);
+ }
+ return ret;
+ }
function t_BSSGP_CAUSE(template BssgpCause cause) return template
Cause_BSSGP {
var template Cause_BSSGP ret;
ret.iEI := '07'O;
@@ -843,7 +889,7 @@
pDU_BSSGP_BVC_RESET := {
bssgpPduType := '22'O,
bVCI := t_BSSGP_BVCI(bvci),
- cause := t_BSSGP_CAUSE(cause),
+ cause := ts_BSSGP_CAUSE(cause),
cell_Identifier := t_BSSGP_IE_CellId(cell_id),
feature_bitmap := omit,
extended_Feature_Bitmap := omit
@@ -1222,5 +1268,134 @@
}
}
+ template (value) Routeing_Area ts_BSSGP_RA_ID(RoutingAreaIdentification
input) := {
+ iEI := '1B'O,
+ ext := '1'B,
+ lengthIndicator := {
+ length1 := 6
+ },
+ mccDigit1 := input.lai.mcc_mnc[0],
+ mccDigit2 := input.lai.mcc_mnc[1],
+ mccDigit3 := input.lai.mcc_mnc[2],
+ mncDigit3 := input.lai.mcc_mnc[3],
+ mncDigit1 := input.lai.mcc_mnc[4],
+ mncDigit2 := input.lai.mcc_mnc[5],
+ lac := int2oct(input.lai.lac, 2),
+ rac := int2oct(input.rac, 1)
+ }
+
+ template (value) PDU_BSSGP ts_BSSGP_SUSPEND(GprsTlli tlli,
RoutingAreaIdentification ra_id) := {
+ pDU_BSSGP_SUSPEND := {
+ bssgpPduType := '0B'O,
+ tLLI := ts_BSSGP_TLLI(tlli),
+ routeing_Area := ts_BSSGP_RA_ID(ra_id)
+ }
+ }
+ template PDU_BSSGP tr_BSSGP_SUSPEND(template GprsTlli tlli,
RoutingAreaIdentification ra_id) := {
+ pDU_BSSGP_SUSPEND := {
+ bssgpPduType := '0B'O,
+ tLLI := tr_BSSGP_TLLI(tlli),
+ routeing_Area := ts_BSSGP_RA_ID(ra_id)
+ }
+ }
+
+ template (value) PDU_BSSGP ts_BSSGP_SUSPEND_ACK(GprsTlli tlli,
RoutingAreaIdentification ra_id,
+ template (value) OCT1
susp_ref) := {
+ pDU_BSSGP_SUSPEND_ACK := {
+
Change in osmo-ttcn3-hacks[master]: pcu: Ensure we're always using the same defaults for the CGI
Harald Welte has uploaded this change for review. (
https://gerrit.osmocom.org/13375
Change subject: pcu: Ensure we're always using the same defaults for the CGI
..
pcu: Ensure we're always using the same defaults for the CGI
Not all parts of the code explicitly specify each and every parameter
of the Cell Gobal Identifier (particularly we don't do that for the PCU
INFO IND), and hence multiple parts only interoperate if the same
defaults are used in all locations.
Change-Id: Iac9be9a8d4ccb4d01cc343d763d2e35873e3844f
---
M library/PCUIF_Types.ttcn
M pcu/PCU_Tests.default
2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/75/13375/1
diff --git a/library/PCUIF_Types.ttcn b/library/PCUIF_Types.ttcn
index 5644431..0c3f000 100644
--- a/library/PCUIF_Types.ttcn
+++ b/library/PCUIF_Types.ttcn
@@ -657,9 +657,9 @@
template (value) PCUIF_Flags
flags := c_PCUIF_Flags_default,
template (value) uint16_t mcc
:= 262,
template (value) uint16_t mnc
:= 42,
-template (value) uint16_t lac
:= 2342,
+template (value) uint16_t lac
:= 13135,
template (value) uint8_t rac
:= 0,
-template (value) uint16_t
cell_id := 1,
+template (value) uint16_t
cell_id := 20960,
template (value) uint8_t bsic
:= 7,
template (value)
PCUIF_InfoTrxs trx := ts_PCUIF_InfoTrxs_def,
template (value) uint32_t
version := PCU_IF_VERSION) := {
diff --git a/pcu/PCU_Tests.default b/pcu/PCU_Tests.default
index a877045..67c05f8 100644
--- a/pcu/PCU_Tests.default
+++ b/pcu/PCU_Tests.default
@@ -13,11 +13,11 @@
cell_id := {
ra_id := {
lai := {
- mcc_mnc := '00101F'H, lac := 1
+ mcc_mnc := '26242F'H, lac := 13135
},
rac := 0
},
- cell_id := 0
+ cell_id := 20960
},
sgsn_role := true
}
--
To view, visit https://gerrit.osmocom.org/13375
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iac9be9a8d4ccb4d01cc343d763d2e35873e3844f
Gerrit-Change-Number: 13375
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte
Change in osmo-ttcn3-hacks[master]: PCU_Tests.ttcn: Use "normal" Osmocom TTCN-3 coding style
Harald Welte has uploaded this change for review. (
https://gerrit.osmocom.org/13374
Change subject: PCU_Tests.ttcn: Use "normal" Osmocom TTCN-3 coding style
..
PCU_Tests.ttcn: Use "normal" Osmocom TTCN-3 coding style
Change-Id: I6eaca0ec7fb9c2dc5d59e385bc3a3a8bb85fe23a
---
M pcu/PCU_Tests.ttcn
1 file changed, 534 insertions(+), 534 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/74/13374/1
diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn
index f63c4ad..09885bd 100644
--- a/pcu/PCU_Tests.ttcn
+++ b/pcu/PCU_Tests.ttcn
@@ -1,318 +1,318 @@
module PCU_Tests {
- import from General_Types all;
- import from Osmocom_Types all;
- import from GSM_Types all;
- import from GSM_RR_Types all;
- import from Osmocom_Gb_Types all;
- import from BSSGP_Types all;
- import from BSSGP_Emulation all;
- import from NS_Types all;
- import from NS_Emulation all;
- import from LLC_Types all;
- import from LLC_Templates all;
- import from RLCMAC_Types all;
- import from RLCMAC_CSN1_Types all;
- import from LAPDm_RAW_PT all;
- import from GPRS_Context all;
- import from GPRS_TBF all;
- import from L1CTL_PortType all;
- import from MobileL3_Types all;
- import from MobileL3_CommonIE_Types all;
- import from L3_Templates all;
+import from General_Types all;
+import from Osmocom_Types all;
+import from GSM_Types all;
+import from GSM_RR_Types all;
+import from Osmocom_Gb_Types all;
+import from BSSGP_Types all;
+import from BSSGP_Emulation all;
+import from NS_Types all;
+import from NS_Emulation all;
+import from LLC_Types all;
+import from LLC_Templates all;
+import from RLCMAC_Types all;
+import from RLCMAC_CSN1_Types all;
+import from LAPDm_RAW_PT all;
+import from GPRS_Context all;
+import from GPRS_TBF all;
+import from L1CTL_PortType all;
+import from MobileL3_Types all;
+import from MobileL3_CommonIE_Types all;
+import from L3_Templates all;
- modulepar {
- BssgpConfig mp_gb_cfg := {
- nsei := 1234,
- bvci := 1234,
- cell_id := {
- ra_id := {
- lai := {
- mcc_mnc := '26242F'H, lac :=
13135
- },
- rac := 0
+modulepar {
+ BssgpConfig mp_gb_cfg := {
+ nsei := 1234,
+ bvci := 1234,
+ cell_id := {
+ ra_id := {
+ lai := {
+ mcc_mnc := '26242F'H, lac := 13135
},
- cell_id := 20960
+ rac := 0
},
- sgsn_role := true
- };
+ cell_id := 20960
+ },
+ sgsn_role := true
+ };
- NSConfiguration mp_nsconfig := {
- local_udp_port := 23000,
- local_ip := "127.0.0.1",
- remote_udp_port := 21000,
- remote_ip := "127.0.0.1",
- nsvci := 0,
- nsei := 2342,
- role_sgsn := true,
- handle_sns := true
- };
+ NSConfiguration mp_nsconfig := {
+ local_udp_port := 23000,
+ local_ip := "127.0.0.1",
+ remote_udp_port := 21000,
+ remote_ip := "127.0.0.1",
+ nsvci := 0,
+ nsei := 2342,
+ role_sgsn := true,
+ handle_sns := true
+ };
+}
+
+type component dummy_CT extends BSSGP_Client_CT {
+ var lapdm_CT lapdm_component;
+ port LAPDm_PT L1;
+
+ var NS_CT ns_component;
+ var BSSGP_CT bssgp_component;
+
+ var MmContext g_mmctx := {
+ tlli := ''O,
+ n_u := 0
+ };
+
+ var boolean g_initialized := false;
+}
+
+function f_init() runs on dummy_CT {
+ if (g_initialized == true) {
+ return;
}
+ g_initialized := true;
+ /* create a new NS component */
+ ns_component := NS_CT.create;
+ bssgp_component := BSSGP_CT.create;
+ /* connect our BSSGP port to the BSSGP Emulation */
+ connect(self:BSSGP[0], bssgp_component:BSSGP_SP);
+ connect(self:BSSGP_SIG[0], bssgp_component:BSSGP_SP_SIG);
+ connect(self:BSSGP_PROC[0], bssgp_component:BSSGP_PROC);
+ /* connect lower-end of BSSGP with BSSGP_CODEC_PORT (maps to NS_PT*/
+ connect(bssgp_component:BSCP, ns_component:NS_SP);
+ /* connect lower-end of NS emulation to NS_CODEC_PORT (on top of IPl4)
*/
Change in osmo-ttcn3-hacks[master]: GSM_RR_Types: Add enc_RoutingAreaIdentification()
Harald Welte has uploaded this change for review. (
https://gerrit.osmocom.org/13378
Change subject: GSM_RR_Types: Add enc_RoutingAreaIdentification()
..
GSM_RR_Types: Add enc_RoutingAreaIdentification()
This allows us to encode a stand-alone RAID as needed in some places.
Change-Id: I28222304b2bac893b216c47e6dc002886fab6406
---
M library/GSM_RR_Types.ttcn
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/78/13378/1
diff --git a/library/GSM_RR_Types.ttcn b/library/GSM_RR_Types.ttcn
index 26783f9..5958569 100644
--- a/library/GSM_RR_Types.ttcn
+++ b/library/GSM_RR_Types.ttcn
@@ -421,6 +421,9 @@
uint8_t rac
} with { variant "" };
+ external function
enc_RoutingAreaIdentification(RoutingAreaIdentification rai) return octetstring
+ with { extension "prototype(convert)" extension "encode(RAW)" }
+
/* 44.018 10.5.2.16 */
type record IaRestOctHL {
uint6_t freq_par_len,
--
To view, visit https://gerrit.osmocom.org/13378
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I28222304b2bac893b216c47e6dc002886fab6406
Gerrit-Change-Number: 13378
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte
Change in osmo-ttcn3-hacks[master]: pcu: Fix MCC/MNC handling: use 'F' between MCC and MNC in 2-digit case
Harald Welte has uploaded this change for review. (
https://gerrit.osmocom.org/13380
Change subject: pcu: Fix MCC/MNC handling: use 'F' between MCC and MNC in
2-digit case
..
pcu: Fix MCC/MNC handling: use 'F' between MCC and MNC in 2-digit case
Change-Id: Ifdb64c501095839e86894716769adb53e3c17382
---
M library/Osmocom_Gb_Types.ttcn
M pcu/PCU_Tests.default
M pcu/PCU_Tests.ttcn
3 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/80/13380/1
diff --git a/library/Osmocom_Gb_Types.ttcn b/library/Osmocom_Gb_Types.ttcn
index 623be33..95d3028 100644
--- a/library/Osmocom_Gb_Types.ttcn
+++ b/library/Osmocom_Gb_Types.ttcn
@@ -867,9 +867,9 @@
ret.mccDigit1 := cid.ra_id.lai.mcc_mnc[0];
ret.mccDigit2 := cid.ra_id.lai.mcc_mnc[1];
ret.mccDigit3 := cid.ra_id.lai.mcc_mnc[2];
- ret.mncDigit3 := cid.ra_id.lai.mcc_mnc[5];
- ret.mncDigit2 := cid.ra_id.lai.mcc_mnc[4];
- ret.mncDigit1 := cid.ra_id.lai.mcc_mnc[3];
+ ret.mncDigit3 := cid.ra_id.lai.mcc_mnc[3];
+ ret.mncDigit2 := cid.ra_id.lai.mcc_mnc[5];
+ ret.mncDigit1 := cid.ra_id.lai.mcc_mnc[4];
}
if (isvalue(cid.ra_id.lai.lac)) {
ret.lac := f_oct_or_wc(cid.ra_id.lai.lac, 2);
diff --git a/pcu/PCU_Tests.default b/pcu/PCU_Tests.default
index 67c05f8..2a87345 100644
--- a/pcu/PCU_Tests.default
+++ b/pcu/PCU_Tests.default
@@ -13,7 +13,7 @@
cell_id := {
ra_id := {
lai := {
- mcc_mnc := '26242F'H, lac := 13135
+ mcc_mnc := '262F42'H, lac := 13135
},
rac := 0
},
diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn
index 09885bd..b18b999 100644
--- a/pcu/PCU_Tests.ttcn
+++ b/pcu/PCU_Tests.ttcn
@@ -28,7 +28,7 @@
cell_id := {
ra_id := {
lai := {
- mcc_mnc := '26242F'H, lac := 13135
+ mcc_mnc := '262F42'H, lac := 13135
},
rac := 0
},
--
To view, visit https://gerrit.osmocom.org/13380
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifdb64c501095839e86894716769adb53e3c17382
Gerrit-Change-Number: 13380
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte
Change in osmo-ttcn3-hacks[master]: BSSGP_Emulation: Handle incoming BVCI=0 messages
Harald Welte has uploaded this change for review. (
https://gerrit.osmocom.org/13377
Change subject: BSSGP_Emulation: Handle incoming BVCI=0 messages
..
BSSGP_Emulation: Handle incoming BVCI=0 messages
Like BVCI=PTP, the BVCI=0 messages must be dispatched by their
TLLI, but using the BSSGP_SP_SIG port instead of BSSGP_SP.
Change-Id: Ic456d43ec07600162991698ec3d75d36785b2fb8
---
M library/BSSGP_Emulation.ttcn
1 file changed, 21 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/77/13377/1
diff --git a/library/BSSGP_Emulation.ttcn b/library/BSSGP_Emulation.ttcn
index fa33f51..8988926 100644
--- a/library/BSSGP_Emulation.ttcn
+++ b/library/BSSGP_Emulation.ttcn
@@ -532,7 +532,7 @@
BSSGP_SP.send(f_dec_bssgp(udi.bssgp)) to vc_conn;
}
- /* Any other BSSGP message: If it has TLLi, route to component;
otherwise broadcast */
+ /* Any other PTP BSSGP message: If it has TLLi, route to component;
otherwise broadcast */
[] BSCP.receive(f_BnsUdInd(?, g_cfg.bvci)) -> value udi {
var BssgpDecoded dec := f_dec_bssgp(udi.bssgp);
var template OCT4 tlli := f_bssgp_get_tlli(udi.bssgp);
@@ -551,6 +551,26 @@
}
}
+ /* Any other SIG BSSGP message: If it has TLLi, route to component;
otherwise broadcast */
+ [] BSCP.receive(f_BnsUdInd(?, 0)) -> value udi {
+ var BssgpDecoded dec := f_dec_bssgp(udi.bssgp);
+ var template OCT4 tlli := f_bssgp_get_tlli(udi.bssgp);
+ if (isvalue(tlli)) {
+ vc_conn := f_tbl_comp_by_tlli(valueof(tlli));
+ BSSGP_SP_SIG.send(dec) to vc_conn;
+ } else {
+ log("No TLLI: Broadcasting ", dec);
+ /* broadcast this message to all components */
+ // TITAN DOESN'T DO THIS, *SIGH*: "BSSGP_SP.send(dec)
to all component;"
+ for (var integer i := 0; i < sizeof(ClientTable); i :=
i+1) {
+ if (isbound(ClientTable[i].comp_ref)) {
+ BSSGP_SP_SIG.send(dec) to
ClientTable[i].comp_ref;
+ }
+ }
+ }
+ }
+
+
[] BSSGP_SP_SIG.receive(PDU_BSSGP:?)-> value bs_pdu sender vc_conn {
BSCP.send(f_BnsUdReq(bs_pdu, 0));
}
--
To view, visit https://gerrit.osmocom.org/13377
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic456d43ec07600162991698ec3d75d36785b2fb8
Gerrit-Change-Number: 13377
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte
Change in osmo-ttcn3-hacks[master]: pcu: move f_pcuif_tx() to PCU_Tests_RAW as it runs on RAW_PCU_CT
Harald Welte has uploaded this change for review. (
https://gerrit.osmocom.org/13376
Change subject: pcu: move f_pcuif_tx() to PCU_Tests_RAW as it runs on RAW_PCU_CT
..
pcu: move f_pcuif_tx() to PCU_Tests_RAW as it runs on RAW_PCU_CT
Change-Id: Ic60a7fc657df17ff2d3a889501f0576b98f1f4ad
---
M pcu/PCU_Tests_RAW.ttcn
M pcu/PCU_Tests_RAW_SNS.ttcn
2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/76/13376/1
diff --git a/pcu/PCU_Tests_RAW.ttcn b/pcu/PCU_Tests_RAW.ttcn
index 6022d36..3e38fa8 100644
--- a/pcu/PCU_Tests_RAW.ttcn
+++ b/pcu/PCU_Tests_RAW.ttcn
@@ -73,6 +73,10 @@
PCU.send(t_SD_PCUIF(g_pcu_conn_id, info_ind));
}
+function f_pcuif_tx(template (value) PCUIF_Message msg) runs on RAW_PCU_CT {
+ PCU.send(t_SD_PCUIF(g_pcu_conn_id, msg));
+}
+
function f_init_ns_codec(integer idx := 0, float guard_secs := 60.0) runs on
RAW_NS_CT {
var Result res;
diff --git a/pcu/PCU_Tests_RAW_SNS.ttcn b/pcu/PCU_Tests_RAW_SNS.ttcn
index 7513196..9bedff9 100644
--- a/pcu/PCU_Tests_RAW_SNS.ttcn
+++ b/pcu/PCU_Tests_RAW_SNS.ttcn
@@ -354,10 +354,6 @@
import from PCUIF_Types all;
import from PCUIF_CodecPort all;
-private function f_pcuif_tx(template (value) PCUIF_Message msg) runs on
RAW_PCU_CT {
- PCU.send(t_SD_PCUIF(g_pcu_conn_id, msg));
-}
-
altstep as_pcu_activate() runs on RAW_PCU_CT {
var PCUIF_send_data sd;
[] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_ACT_REQ(?, ?, ?)))
-> value sd { repeat; }
--
To view, visit https://gerrit.osmocom.org/13376
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic60a7fc657df17ff2d3a889501f0576b98f1f4ad
Gerrit-Change-Number: 13376
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte
Change in osmo-ttcn3-hacks[master]: pcu: Add TC_pcuif_suspend() to test PCU->BSSGP SUSPEND processing
Harald Welte has uploaded this change for review. (
https://gerrit.osmocom.org/13383
Change subject: pcu: Add TC_pcuif_suspend() to test PCU->BSSGP SUSPEND
processing
..
pcu: Add TC_pcuif_suspend() to test PCU->BSSGP SUSPEND processing
The PCU is supposed to forward any RR SUSPEND received by the BTS
on dedicated channels and pass it to the SGSN via BSSGP. This provides
knowledge to the SGSN that the MS is not reachable via PS/TBF anymore
until it completes its CC dedicated mode transaction and RESUMEs.
Change-Id: Iaf35e0c1087413db1dc7d169fa716df14c78f5db
---
M pcu/PCU_Tests.ttcn
M pcu/PCU_Tests_RAW.ttcn
2 files changed, 66 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/83/13383/1
diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn
index 80a1bd1..4dce7dd 100644
--- a/pcu/PCU_Tests.ttcn
+++ b/pcu/PCU_Tests.ttcn
@@ -663,6 +663,46 @@
f_sleep(10.0);
}
+/* FIXME: merge this into BSSGP_Client_CT ? */
+type component bssgp_CT extends BSSGP_Client_CT {
+ var NS_CT ns_component;
+ var BSSGP_CT bssgp_component;
+ var boolean g_initialized := false;
+}
+
+/* FIXME: merge this into BSSGP_Client_CT ? */
+function f_init_bssgp() runs on bssgp_CT {
+ var MmContext mmctx := {
+ imsi := '2624201'H,
+ tlli := ''O,
+ n_u := 0
+ };
+
+
+ if (g_initialized == true) {
+ return;
+ }
+ g_initialized := true;
+
+ /* create a new NS component */
+ ns_component := NS_CT.create;
+ bssgp_component := BSSGP_CT.create;
+ /* connect our BSSGP port to the BSSGP Emulation */
+ connect(self:BSSGP[0], bssgp_component:BSSGP_SP);
+ connect(self:BSSGP_SIG[0], bssgp_component:BSSGP_SP_SIG);
+ connect(self:BSSGP_PROC[0], bssgp_component:BSSGP_PROC);
+ /* connect lower-end of BSSGP with BSSGP_CODEC_PORT (maps to NS_PT*/
+ connect(bssgp_component:BSCP, ns_component:NS_SP);
+ /* connect lower-end of NS emulation to NS_CODEC_PORT (on top of IPl4)
*/
+ map(ns_component:NSCP, system:NS_CODEC_PORT);
+ ns_component.start(NSStart(mp_nsconfig));
+ bssgp_component.start(BssgpStart(mp_gb_cfg));
+
+ f_bssgp_client_register(mmctx.imsi, mmctx.tlli, mp_gb_cfg.cell_id);
+ f_bssgp_establish();
+}
+
+
control {
execute(TC_selftest_ns());
diff --git a/pcu/PCU_Tests_RAW.ttcn b/pcu/PCU_Tests_RAW.ttcn
index 3e38fa8..96a3f86 100644
--- a/pcu/PCU_Tests_RAW.ttcn
+++ b/pcu/PCU_Tests_RAW.ttcn
@@ -8,6 +8,9 @@
import from General_Types all;
import from Osmocom_Types all;
+import from GSM_Types all;
+import from GSM_RR_Types all;
+
import from NS_Types all;
import from BSSGP_Types all;
import from Osmocom_Gb_Types all;
@@ -405,6 +408,27 @@
setverdict(pass);
}
+/* Test component with PCUIF + BSSGP/NS Emulation (no L1CTL) */
+type component bssgp_pcuif_CT extends bssgp_CT, RAW_PCU_CT {
+}
+
+testcase TC_pcuif_suspend() runs on bssgp_pcuif_CT {
+ var OCT6 ra_id :=
enc_RoutingAreaIdentification(mp_gb_cfg.cell_id.ra_id);
+ var GprsTlli tlli := ''O;
+
+ /* Initialize PCU interface side */
+ f_init_pcuif();
+
+ /* Initialize NS/BSSGP side */
+ f_init_bssgp();
+
+ f_sleep(1.0);
+ f_pcuif_tx(ts_PCUIF_SUSP_REQ(0, tlli, ra_id, 0));
+ BSSGP_SIG[0].receive(tr_BD_BSSGP(tr_BSSGP_SUSPEND(tlli,
mp_gb_cfg.cell_id.ra_id)));
+
+ setverdict(pass);
+}
+
control {
execute( TC_ns_reset() );
@@ -415,6 +439,8 @@
execute( TC_ns_unblock_retrans() );
execute( TC_ns_full_bringup() );
execute( TC_ns_so_block() );
+
+ execute( TC_pcuif_suspend() );
}
--
To view, visit https://gerrit.osmocom.org/13383
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaf35e0c1087413db1dc7d169fa716df14c78f5db
Gerrit-Change-Number: 13383
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte
Build failure of network:osmocom:nightly/openbsc in Debian_9.0/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/armv7l Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 306s] ../../src/libcommon/libcommon.a(talloc_ctx.o): In function `talloc_ctx_init': [ 306s] ./openbsc/src/libcommon/talloc_ctx.c:55: undefined reference to `tall_sigh_ctx' [ 306s] collect2: error: ld returned 1 exit status [ 306s] Makefile:483: recipe for target 'osmo-nitb' failed [ 306s] make[4]: *** [osmo-nitb] Error 1 [ 306s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/osmo-nitb' [ 306s] Makefile:450: recipe for target 'all-recursive' failed [ 306s] make[3]: *** [all-recursive] Error 1 [ 306s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src' [ 306s] Makefile:470: recipe for target 'all-recursive' failed [ 306s] make[2]: *** [all-recursive] Error 1 [ 306s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 306s] Makefile:402: recipe for target 'all' failed [ 306s] make[1]: *** [all] Error 2 [ 306s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 306s] dh_auto_build: make -j1 returned exit code 2 [ 306s] debian/rules:13: recipe for target 'build' failed [ 306s] make: *** [build] Error 2 [ 306s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 306s] [ 306s] obs-arm-5 failed "build openbsc_1.2.0.20190321.dsc" at Thu Mar 21 21:21:52 UTC 2019. [ 306s] [ 306s] ### VM INTERACTION START ### [ 309s] [ 280.625330] sysrq: SysRq : Power Off [ 309s] [ 280.641877] reboot: Power down [ 310s] ### VM INTERACTION END ### [ 310s] [ 310s] obs-arm-5 failed "build openbsc_1.2.0.20190321.dsc" at Thu Mar 21 21:21:56 UTC 2019. [ 310s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/openbsc in Raspbian_9.0/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Raspbian_9.0/armv7l Package network:osmocom:nightly/openbsc failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 184s] ../../src/libcommon/libcommon.a(talloc_ctx.o): In function `talloc_ctx_init': [ 184s] ./openbsc/src/libcommon/talloc_ctx.c:55: undefined reference to `tall_sigh_ctx' [ 184s] collect2: error: ld returned 1 exit status [ 184s] Makefile:483: recipe for target 'osmo-nitb' failed [ 184s] make[4]: *** [osmo-nitb] Error 1 [ 184s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/osmo-nitb' [ 184s] Makefile:450: recipe for target 'all-recursive' failed [ 184s] make[3]: *** [all-recursive] Error 1 [ 184s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src' [ 184s] Makefile:470: recipe for target 'all-recursive' failed [ 184s] make[2]: *** [all-recursive] Error 1 [ 184s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 184s] Makefile:402: recipe for target 'all' failed [ 184s] make[1]: *** [all] Error 2 [ 184s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 184s] dh_auto_build: make -j1 returned exit code 2 [ 184s] debian/rules:13: recipe for target 'build' failed [ 184s] make: *** [build] Error 2 [ 184s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 184s] [ 184s] armbuild21 failed "build openbsc_1.2.0.20190321.dsc" at Thu Mar 21 21:19:30 UTC 2019. [ 184s] [ 184s] ### VM INTERACTION START ### [ 187s] [ 170.503640] SysRq : Power Off [ 187s] [ 170.505902] reboot: Power down [ 188s] ### VM INTERACTION END ### [ 188s] [ 188s] armbuild21 failed "build openbsc_1.2.0.20190321.dsc" at Thu Mar 21 21:19:34 UTC 2019. [ 188s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Change in osmo-pcu[master]: Include pdch.h in bts.h even if we're not compiling C++
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13361 ) Change subject: Include pdch.h in bts.h even if we're not compiling C++ .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13361 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib39e4424f73c677b34f921917440f211e400e14f Gerrit-Change-Number: 13361 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Willmann Gerrit-Reviewer: Daniel Willmann Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-CC: Pau Espin Pedrol Gerrit-Comment-Date: Thu, 21 Mar 2019 21:17:31 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-msc[master]: libmsc/sgs_vty.c: don't print SGs socket error twice
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13372 ) Change subject: libmsc/sgs_vty.c: don't print SGs socket error twice .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13372 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifea308645c7829691dbcf53e4f59841090119006 Gerrit-Change-Number: 13372 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Comment-Date: Thu, 21 Mar 2019 21:15:52 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-msc[master]: libmsc/sgs_iface.c: register sgs_vlr_reset_fsm on DSO load
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13371 ) Change subject: libmsc/sgs_iface.c: register sgs_vlr_reset_fsm on DSO load .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13371 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80cd2e5645d6e391080376250c0853a3f3f821ef Gerrit-Change-Number: 13371 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Comment-Date: Thu, 21 Mar 2019 21:15:37 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-msc[master]: libmsc/sgs_iface.c: fix copy-paste error
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13370 ) Change subject: libmsc/sgs_iface.c: fix copy-paste error .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13370 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57b773659302ad4c92b6e670c6156e90a50189ba Gerrit-Change-Number: 13370 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Comment-Date: Thu, 21 Mar 2019 21:15:30 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Build failure of network:osmocom:nightly/openbsc in xUbuntu_18.04/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_18.04/x86_64 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 161s] ../../src/libcommon/libcommon.a(talloc_ctx.o): In function `talloc_ctx_init': [ 161s] ./openbsc/src/libcommon/talloc_ctx.c:50: undefined reference to `tall_sigh_ctx' [ 161s] collect2: error: ld returned 1 exit status [ 161s] Makefile:483: recipe for target 'osmo-nitb' failed [ 161s] make[4]: *** [osmo-nitb] Error 1 [ 161s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/osmo-nitb' [ 161s] Makefile:450: recipe for target 'all-recursive' failed [ 161s] make[3]: *** [all-recursive] Error 1 [ 161s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src' [ 161s] Makefile:470: recipe for target 'all-recursive' failed [ 161s] make[2]: *** [all-recursive] Error 1 [ 161s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 161s] Makefile:402: recipe for target 'all' failed [ 161s] make[1]: *** [all] Error 2 [ 161s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 161s] dh_auto_build: cd openbsc && make -j1 returned exit code 2 [ 161s] debian/rules:13: recipe for target 'build' failed [ 161s] make: *** [build] Error 2 [ 161s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 161s] [ 161s] lamb14 failed "build openbsc_1.2.0.20190321.dsc" at Thu Mar 21 20:42:44 UTC 2019. [ 161s] [ 161s] ### VM INTERACTION START ### [ 164s] [ 150.457374] sysrq: SysRq : Power Off [ 164s] [ 150.461954] reboot: Power down [ 164s] ### VM INTERACTION END ### [ 164s] [ 164s] lamb14 failed "build openbsc_1.2.0.20190321.dsc" at Thu Mar 21 20:42:47 UTC 2019. [ 164s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/openbsc in xUbuntu_18.10/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_18.10/x86_64 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_18.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 161s] /usr/include/osmocom/core/application.h:20:5: note: declared here [ 161s] int osmo_init_logging(const struct log_info *) [ 161s] ^ [ 161s] /bin/bash ../../libtool --tag=CC --mode=link gcc -Wall -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Werror=null-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-z,now -o osmo-nitb bsc_hack.o ../../src/libbsc/libbsc.a ../../src/libcommon-cs/libcommon-cs.a ../../src/libmsc/libmsc.a ../../src/libtrau/libtrau.a ../../src/libcommon/libcommon.a -ltalloc -losmogsm -losmocore -ltalloc -losmovty -losmocore -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -losmoabis -lsmpp34 -ldbi [ 161s] libtool: link: gcc -Wall -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Werror=null-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -Wl,-Bsymbolic-functions -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-nitb bsc_hack.o ../../src/libbsc/libbsc.a ../../src/libcommon-cs/libcommon-cs.a ../../src/libmsc/libmsc.a ../../src/libtrau/libtrau.a ../../src/libcommon/libcommon.a /usr/lib/x86_64-linux-gnu/libosmovty.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so /usr/lib/x86_64-linux-gnu/libosmocore.so /usr/lib/x86_64-linux-gnu/libosmoabis.so /usr/lib/x86_64-linux-gnu/libsmpp34.so -ldbi [ 162s] /usr/bin/ld: ../../src/libcommon/libcommon.a(talloc_ctx.o): in function `talloc_ctx_init': [ 162s] ./openbsc/src/libcommon/talloc_ctx.c:50: undefined reference to `tall_sigh_ctx' [ 162s] collect2: error: ld returned 1 exit status [ 162s] make[4]: *** [Makefile:485: osmo-nitb] Error 1 [ 162s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/osmo-nitb' [ 162s] make[3]: *** [Makefile:450: all-recursive] Error 1 [ 162s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src' [ 162s] make[2]: *** [Makefile:470: all-recursive] Error 1 [ 162s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 162s] make[1]: *** [Makefile:402: all] Error 2 [ 162s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 162s] dh_auto_build: cd openbsc && make -j1 returned exit code 2 [ 162s] make: *** [debian/rules:13: build] Error 2 [ 162s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 162s] [ 162s] lamb07 failed "build openbsc_1.2.0.20190321.dsc" at Thu Mar 21 20:42:03 UTC 2019. [ 162s] [ 162s] ### VM INTERACTION START ### [ 165s] [ 153.374030] sysrq: SysRq : Power Off [ 165s] [ 153.401555] reboot: Power down [ 165s] ### VM INTERACTION END ### [ 165s] [ 165s] lamb07 failed "build openbsc_1.2.0.20190321.dsc" at Thu Mar 21 20:42:07 UTC 2019. [ 165s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-sysmon in xUbuntu_18.04/x86_64
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sysmon/xUbuntu_18.04/x86_64
Package network:osmocom:nightly/osmo-sysmon failed to build in
xUbuntu_18.04/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-sysmon
Last lines of build log:
[ 123s] #define VERSION "0.1.0"
[ 123s] #define STDC_HEADERS 1
[ 123s] #define HAVE_SYS_TYPES_H 1
[ 123s] #define HAVE_SYS_STAT_H 1
[ 123s] #define HAVE_STDLIB_H 1
[ 123s] #define HAVE_STRING_H 1
[ 123s] #define HAVE_MEMORY_H 1
[ 123s] #define HAVE_STRINGS_H 1
[ 123s] #define HAVE_INTTYPES_H 1
[ 123s] #define HAVE_STDINT_H 1
[ 123s] #define HAVE_UNISTD_H 1
[ 123s] #define HAVE_DLFCN_H 1
[ 123s] #define LT_OBJDIR ".libs/"
[ 123s]
[ 123s] configure: exit 1
[ 123s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr
--includedir=\${prefix}/include --mandir=\${prefix}/share/man
--infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var
--disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu
--libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode
--disable-dependency-tracking returned exit code 1
[ 123s] debian/rules:45: recipe for target 'build' failed
[ 123s] make: *** [build] Error 2
[ 123s] dpkg-buildpackage: error: debian/rules build subprocess returned exit
status 2
[ 123s]
[ 123s] lamb59 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 20:38:00 UTC
2019.
[ 123s]
[ 123s] ### VM INTERACTION START ###
[ 125s] [ 112.513975] sysrq: SysRq : Power Off
[ 125s] [ 112.519234] reboot: Power down
[ 125s] ### VM INTERACTION END ###
[ 125s]
[ 125s] lamb59 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 20:38:04 UTC
2019.
[ 125s]
--
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-sysmon in xUbuntu_18.10/x86_64
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sysmon/xUbuntu_18.10/x86_64
Package network:osmocom:nightly/osmo-sysmon failed to build in
xUbuntu_18.10/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-sysmon
Last lines of build log:
[ 120s] #define PACKAGE "osmo-sysmon"
[ 120s] #define VERSION "0.1.0"
[ 120s] #define STDC_HEADERS 1
[ 120s] #define HAVE_SYS_TYPES_H 1
[ 120s] #define HAVE_SYS_STAT_H 1
[ 120s] #define HAVE_STDLIB_H 1
[ 120s] #define HAVE_STRING_H 1
[ 120s] #define HAVE_MEMORY_H 1
[ 120s] #define HAVE_STRINGS_H 1
[ 120s] #define HAVE_INTTYPES_H 1
[ 120s] #define HAVE_STDINT_H 1
[ 120s] #define HAVE_UNISTD_H 1
[ 120s] #define HAVE_DLFCN_H 1
[ 120s] #define LT_OBJDIR ".libs/"
[ 120s]
[ 120s] configure: exit 1
[ 120s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr
--includedir=\${prefix}/include --mandir=\${prefix}/share/man
--infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var
--disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu
--libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode
--disable-dependency-tracking returned exit code 1
[ 120s] make: *** [debian/rules:45: build] Error 2
[ 120s] dpkg-buildpackage: error: debian/rules build subprocess returned exit
status 2
[ 120s]
[ 120s] lamb12 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 20:28:08 UTC
2019.
[ 120s]
[ 120s] ### VM INTERACTION START ###
[ 124s] [ 112.176912] sysrq: SysRq : Power Off
[ 124s] [ 112.183024] reboot: Power down
[ 124s] ### VM INTERACTION END ###
[ 124s]
[ 124s] lamb12 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 20:28:12 UTC
2019.
[ 124s]
--
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-sysmon in Debian_9.0/x86_64
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sysmon/Debian_9.0/x86_64
Package network:osmocom:nightly/osmo-sysmon failed to build in Debian_9.0/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-sysmon
Last lines of build log:
[ 78s] #define VERSION "0.1.0"
[ 78s] #define STDC_HEADERS 1
[ 78s] #define HAVE_SYS_TYPES_H 1
[ 78s] #define HAVE_SYS_STAT_H 1
[ 78s] #define HAVE_STDLIB_H 1
[ 78s] #define HAVE_STRING_H 1
[ 78s] #define HAVE_MEMORY_H 1
[ 78s] #define HAVE_STRINGS_H 1
[ 78s] #define HAVE_INTTYPES_H 1
[ 78s] #define HAVE_STDINT_H 1
[ 78s] #define HAVE_UNISTD_H 1
[ 78s] #define HAVE_DLFCN_H 1
[ 78s] #define LT_OBJDIR ".libs/"
[ 78s]
[ 78s] configure: exit 1
[ 78s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr
--includedir=${prefix}/include --mandir=${prefix}/share/man
--infodir=${prefix}/share/info --sysconfdir=/etc --localstatedir=/var
--disable-silent-rules --libdir=${prefix}/lib/x86_64-linux-gnu
--libexecdir=${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode
--disable-dependency-tracking returned exit code 1
[ 78s] debian/rules:45: recipe for target 'build' failed
[ 78s] make: *** [build] Error 2
[ 78s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[ 78s]
[ 78s] lamb20 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 20:21:48 UTC
2019.
[ 78s]
[ 78s] ### VM INTERACTION START ###
[ 82s] [ 68.111263] sysrq: SysRq : Power Off
[ 82s] [ 68.127481] reboot: Power down
[ 82s] ### VM INTERACTION END ###
[ 82s]
[ 82s] lamb20 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 20:21:52 UTC
2019.
[ 82s]
--
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-sysmon in xUbuntu_17.10/x86_64
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sysmon/xUbuntu_17.10/x86_64
Package network:osmocom:nightly/osmo-sysmon failed to build in
xUbuntu_17.10/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-sysmon
Last lines of build log:
[ 84s] #define VERSION "0.1.0"
[ 84s] #define STDC_HEADERS 1
[ 84s] #define HAVE_SYS_TYPES_H 1
[ 84s] #define HAVE_SYS_STAT_H 1
[ 84s] #define HAVE_STDLIB_H 1
[ 84s] #define HAVE_STRING_H 1
[ 84s] #define HAVE_MEMORY_H 1
[ 84s] #define HAVE_STRINGS_H 1
[ 84s] #define HAVE_INTTYPES_H 1
[ 84s] #define HAVE_STDINT_H 1
[ 84s] #define HAVE_UNISTD_H 1
[ 84s] #define HAVE_DLFCN_H 1
[ 84s] #define LT_OBJDIR ".libs/"
[ 84s]
[ 84s] configure: exit 1
[ 84s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr
--includedir=\${prefix}/include --mandir=\${prefix}/share/man
--infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var
--disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu
--libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode
--disable-dependency-tracking returned exit code 1
[ 84s] debian/rules:45: recipe for target 'build' failed
[ 84s] make: *** [build] Error 2
[ 84s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[ 84s]
[ 84s] lamb17 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 20:22:03 UTC
2019.
[ 84s]
[ 84s] ### VM INTERACTION START ###
[ 88s] [ 75.866240] sysrq: SysRq : Power Off
[ 88s] [ 75.884149] reboot: Power down
[ 88s] ### VM INTERACTION END ###
[ 88s]
[ 88s] lamb17 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 20:22:08 UTC
2019.
[ 88s]
--
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/openbsc in Debian_8.0/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_8.0/x86_64 Package network:osmocom:nightly/openbsc failed to build in Debian_8.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 386s] ../../src/libcommon/libcommon.a(talloc_ctx.o): In function `talloc_ctx_init': [ 386s] /usr/src/packages/BUILD/openbsc/src/libcommon/talloc_ctx.c:50: undefined reference to `tall_sigh_ctx' [ 386s] collect2: error: ld returned 1 exit status [ 386s] Makefile:472: recipe for target 'osmo-nitb' failed [ 386s] make[4]: *** [osmo-nitb] Error 1 [ 386s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/osmo-nitb' [ 386s] Makefile:438: recipe for target 'all-recursive' failed [ 386s] make[3]: *** [all-recursive] Error 1 [ 386s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src' [ 386s] Makefile:458: recipe for target 'all-recursive' failed [ 386s] make[2]: *** [all-recursive] Error 1 [ 386s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 386s] Makefile:389: recipe for target 'all' failed [ 386s] make[1]: *** [all] Error 2 [ 386s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 386s] dh_auto_build: make -j1 returned exit code 2 [ 386s] debian/rules:13: recipe for target 'build' failed [ 386s] make: *** [build] Error 2 [ 386s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 386s] [ 386s] cloud108 failed "build openbsc_1.2.0.20190321.dsc" at Thu Mar 21 20:21:29 UTC 2019. [ 386s] [ 386s] ### VM INTERACTION START ### [ 389s] Powering off. [ 389s] [ 355.921601] reboot: Power down [ 391s] ### VM INTERACTION END ### [ 391s] [ 391s] cloud108 failed "build openbsc_1.2.0.20190321.dsc" at Thu Mar 21 20:21:35 UTC 2019. [ 391s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-sysmon in xUbuntu_18.04/i586
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sysmon/xUbuntu_18.04/i586
Package network:osmocom:nightly/osmo-sysmon failed to build in
xUbuntu_18.04/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-sysmon
Last lines of build log:
[ 386s] #define VERSION "0.1.0"
[ 386s] #define STDC_HEADERS 1
[ 386s] #define HAVE_SYS_TYPES_H 1
[ 386s] #define HAVE_SYS_STAT_H 1
[ 386s] #define HAVE_STDLIB_H 1
[ 386s] #define HAVE_STRING_H 1
[ 386s] #define HAVE_MEMORY_H 1
[ 386s] #define HAVE_STRINGS_H 1
[ 386s] #define HAVE_INTTYPES_H 1
[ 386s] #define HAVE_STDINT_H 1
[ 386s] #define HAVE_UNISTD_H 1
[ 386s] #define HAVE_DLFCN_H 1
[ 386s] #define LT_OBJDIR ".libs/"
[ 386s]
[ 386s] configure: exit 1
[ 386s] dh_auto_configure: ./configure --build=i686-linux-gnu --prefix=/usr
--includedir=\${prefix}/include --mandir=\${prefix}/share/man
--infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var
--disable-silent-rules --libdir=\${prefix}/lib/i386-linux-gnu
--libexecdir=\${prefix}/lib/i386-linux-gnu --disable-maintainer-mode
--disable-dependency-tracking returned exit code 1
[ 386s] debian/rules:45: recipe for target 'build' failed
[ 386s] make: *** [build] Error 2
[ 386s] dpkg-buildpackage: error: debian/rules build subprocess returned exit
status 2
[ 386s]
[ 386s] lamb27 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 20:21:10 UTC
2019.
[ 386s]
[ 386s] ### VM INTERACTION START ###
[ 389s] [ 375.419904] sysrq: SysRq : Power Off
[ 389s] [ 375.457374] reboot: Power down
[ 389s] ### VM INTERACTION END ###
[ 389s]
[ 389s] lamb27 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 20:21:14 UTC
2019.
[ 389s]
--
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/openbsc in xUbuntu_18.04/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_18.04/i586 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_18.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 283s] ../../src/libcommon/libcommon.a(talloc_ctx.o): In function `talloc_ctx_init': [ 283s] ./openbsc/src/libcommon/talloc_ctx.c:50: undefined reference to `tall_sigh_ctx' [ 283s] collect2: error: ld returned 1 exit status [ 283s] Makefile:483: recipe for target 'osmo-nitb' failed [ 283s] make[4]: *** [osmo-nitb] Error 1 [ 283s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/osmo-nitb' [ 283s] Makefile:450: recipe for target 'all-recursive' failed [ 283s] make[3]: *** [all-recursive] Error 1 [ 283s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src' [ 283s] Makefile:470: recipe for target 'all-recursive' failed [ 283s] make[2]: *** [all-recursive] Error 1 [ 283s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 283s] Makefile:402: recipe for target 'all' failed [ 283s] make[1]: *** [all] Error 2 [ 283s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 283s] dh_auto_build: cd openbsc && make -j1 returned exit code 2 [ 283s] debian/rules:13: recipe for target 'build' failed [ 283s] make: *** [build] Error 2 [ 283s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 283s] [ 283s] morla3 failed "build openbsc_1.2.0.20190321.dsc" at Thu Mar 21 20:20:11 UTC 2019. [ 283s] [ 283s] ### VM INTERACTION START ### [ 286s] [ 270.599505] sysrq: SysRq : Power Off [ 286s] [ 270.699177] reboot: Power down [ 286s] ### VM INTERACTION END ### [ 286s] [ 286s] morla3 failed "build openbsc_1.2.0.20190321.dsc" at Thu Mar 21 20:20:14 UTC 2019. [ 286s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-sysmon in Debian_9.0/i586
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sysmon/Debian_9.0/i586
Package network:osmocom:nightly/osmo-sysmon failed to build in Debian_9.0/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-sysmon
Last lines of build log:
[ 132s] #define VERSION "0.1.0"
[ 132s] #define STDC_HEADERS 1
[ 132s] #define HAVE_SYS_TYPES_H 1
[ 132s] #define HAVE_SYS_STAT_H 1
[ 132s] #define HAVE_STDLIB_H 1
[ 132s] #define HAVE_STRING_H 1
[ 132s] #define HAVE_MEMORY_H 1
[ 132s] #define HAVE_STRINGS_H 1
[ 132s] #define HAVE_INTTYPES_H 1
[ 132s] #define HAVE_STDINT_H 1
[ 132s] #define HAVE_UNISTD_H 1
[ 132s] #define HAVE_DLFCN_H 1
[ 132s] #define LT_OBJDIR ".libs/"
[ 132s]
[ 132s] configure: exit 1
[ 132s] dh_auto_configure: ./configure --build=i686-linux-gnu --prefix=/usr
--includedir=${prefix}/include --mandir=${prefix}/share/man
--infodir=${prefix}/share/info --sysconfdir=/etc --localstatedir=/var
--disable-silent-rules --libdir=${prefix}/lib/i386-linux-gnu
--libexecdir=${prefix}/lib/i386-linux-gnu --disable-maintainer-mode
--disable-dependency-tracking returned exit code 1
[ 132s] debian/rules:45: recipe for target 'build' failed
[ 132s] make: *** [build] Error 2
[ 132s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[ 132s]
[ 132s] lamb60 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 20:16:57 UTC
2019.
[ 132s]
[ 132s] ### VM INTERACTION START ###
[ 135s] [ 118.198441] sysrq: SysRq : Power Off
[ 135s] [ 118.218851] reboot: Power down
[ 135s] ### VM INTERACTION END ###
[ 135s]
[ 135s] lamb60 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 20:17:00 UTC
2019.
[ 135s]
--
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/openbsc in xUbuntu_16.04/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_16.04/x86_64 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_16.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 165s] ../../src/libcommon/libcommon.a(talloc_ctx.o): In function `talloc_ctx_init': [ 165s] /usr/src/packages/BUILD/openbsc/src/libcommon/talloc_ctx.c:50: undefined reference to `tall_sigh_ctx' [ 165s] collect2: error: ld returned 1 exit status [ 165s] Makefile:483: recipe for target 'osmo-nitb' failed [ 165s] make[4]: *** [osmo-nitb] Error 1 [ 165s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/osmo-nitb' [ 165s] Makefile:450: recipe for target 'all-recursive' failed [ 165s] make[3]: *** [all-recursive] Error 1 [ 165s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src' [ 165s] Makefile:470: recipe for target 'all-recursive' failed [ 165s] make[2]: *** [all-recursive] Error 1 [ 165s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 165s] Makefile:402: recipe for target 'all' failed [ 165s] make[1]: *** [all] Error 2 [ 165s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 165s] dh_auto_build: make -j1 returned exit code 2 [ 165s] debian/rules:13: recipe for target 'build' failed [ 165s] make: *** [build] Error 2 [ 165s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 165s] [ 165s] cloud112 failed "build openbsc_1.2.0.20190321.dsc" at Thu Mar 21 20:16:24 UTC 2019. [ 165s] [ 165s] ### VM INTERACTION START ### [ 168s] [ 143.759670] sysrq: SysRq : Power Off [ 168s] [ 143.766912] reboot: Power down [ 169s] ### VM INTERACTION END ### [ 169s] [ 169s] cloud112 failed "build openbsc_1.2.0.20190321.dsc" at Thu Mar 21 20:16:28 UTC 2019. [ 169s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/openbsc in xUbuntu_17.10/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_17.10/i586 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_17.10/i586 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 184s] ../../src/libcommon/libcommon.a(talloc_ctx.o): In function `talloc_ctx_init': [ 184s] ./openbsc/src/libcommon/talloc_ctx.c:50: undefined reference to `tall_sigh_ctx' [ 184s] collect2: error: ld returned 1 exit status [ 184s] Makefile:483: recipe for target 'osmo-nitb' failed [ 184s] make[4]: *** [osmo-nitb] Error 1 [ 184s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/osmo-nitb' [ 184s] Makefile:450: recipe for target 'all-recursive' failed [ 184s] make[3]: *** [all-recursive] Error 1 [ 184s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src' [ 185s] Makefile:470: recipe for target 'all-recursive' failed [ 185s] make[2]: *** [all-recursive] Error 1 [ 185s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 185s] Makefile:402: recipe for target 'all' failed [ 185s] make[1]: *** [all] Error 2 [ 185s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 185s] dh_auto_build: make -j1 returned exit code 2 [ 185s] debian/rules:13: recipe for target 'build' failed [ 185s] make: *** [build] Error 2 [ 185s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 185s] [ 185s] lamb06 failed "build openbsc_1.2.0.20190321.dsc" at Thu Mar 21 20:15:37 UTC 2019. [ 185s] [ 185s] ### VM INTERACTION START ### [ 188s] [ 168.567970] sysrq: SysRq : Power Off [ 188s] [ 168.589383] reboot: Power down [ 188s] ### VM INTERACTION END ### [ 188s] [ 188s] lamb06 failed "build openbsc_1.2.0.20190321.dsc" at Thu Mar 21 20:15:41 UTC 2019. [ 188s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/openbsc in Debian_9.0/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/x86_64 Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 115s] ../../src/libcommon/libcommon.a(talloc_ctx.o): In function `talloc_ctx_init': [ 115s] ./openbsc/src/libcommon/talloc_ctx.c:50: undefined reference to `tall_sigh_ctx' [ 115s] collect2: error: ld returned 1 exit status [ 115s] Makefile:483: recipe for target 'osmo-nitb' failed [ 115s] make[4]: *** [osmo-nitb] Error 1 [ 115s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/osmo-nitb' [ 115s] Makefile:450: recipe for target 'all-recursive' failed [ 115s] make[3]: *** [all-recursive] Error 1 [ 115s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src' [ 115s] Makefile:470: recipe for target 'all-recursive' failed [ 115s] make[2]: *** [all-recursive] Error 1 [ 115s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 115s] Makefile:402: recipe for target 'all' failed [ 115s] make[1]: *** [all] Error 2 [ 115s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 115s] dh_auto_build: make -j1 returned exit code 2 [ 115s] debian/rules:13: recipe for target 'build' failed [ 115s] make: *** [build] Error 2 [ 115s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 115s] [ 115s] lamb58 failed "build openbsc_1.2.0.20190321.dsc" at Thu Mar 21 20:15:17 UTC 2019. [ 115s] [ 115s] ### VM INTERACTION START ### [ 118s] [ 104.415199] sysrq: SysRq : Power Off [ 118s] [ 104.424420] reboot: Power down [ 118s] ### VM INTERACTION END ### [ 118s] [ 118s] lamb58 failed "build openbsc_1.2.0.20190321.dsc" at Thu Mar 21 20:15:21 UTC 2019. [ 118s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/openbsc in Debian_9.0/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/i586 Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 173s] ../../src/libcommon/libcommon.a(talloc_ctx.o): In function `talloc_ctx_init': [ 173s] ./openbsc/src/libcommon/talloc_ctx.c:50: undefined reference to `tall_sigh_ctx' [ 173s] collect2: error: ld returned 1 exit status [ 173s] Makefile:483: recipe for target 'osmo-nitb' failed [ 173s] make[4]: *** [osmo-nitb] Error 1 [ 173s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/osmo-nitb' [ 173s] Makefile:450: recipe for target 'all-recursive' failed [ 173s] make[3]: *** [all-recursive] Error 1 [ 173s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src' [ 173s] Makefile:470: recipe for target 'all-recursive' failed [ 173s] make[2]: *** [all-recursive] Error 1 [ 173s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 173s] Makefile:402: recipe for target 'all' failed [ 173s] make[1]: *** [all] Error 2 [ 173s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 173s] dh_auto_build: make -j1 returned exit code 2 [ 173s] debian/rules:13: recipe for target 'build' failed [ 173s] make: *** [build] Error 2 [ 173s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 173s] [ 173s] lamb01 failed "build openbsc_1.2.0.20190321.dsc" at Thu Mar 21 20:13:39 UTC 2019. [ 173s] [ 173s] ### VM INTERACTION START ### [ 176s] [ 151.501398] sysrq: SysRq : Power Off [ 176s] [ 151.520286] reboot: Power down [ 176s] ### VM INTERACTION END ### [ 176s] [ 176s] lamb01 failed "build openbsc_1.2.0.20190321.dsc" at Thu Mar 21 20:13:42 UTC 2019. [ 176s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/openbsc in xUbuntu_17.10/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_17.10/x86_64 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_17.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 92s] ../../src/libcommon/libcommon.a(talloc_ctx.o): In function `talloc_ctx_init': [ 92s] ./openbsc/src/libcommon/talloc_ctx.c:50: undefined reference to `tall_sigh_ctx' [ 92s] collect2: error: ld returned 1 exit status [ 92s] Makefile:483: recipe for target 'osmo-nitb' failed [ 92s] make[4]: *** [osmo-nitb] Error 1 [ 92s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/osmo-nitb' [ 92s] Makefile:450: recipe for target 'all-recursive' failed [ 92s] make[3]: *** [all-recursive] Error 1 [ 92s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src' [ 92s] Makefile:470: recipe for target 'all-recursive' failed [ 92s] make[2]: *** [all-recursive] Error 1 [ 92s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 92s] Makefile:402: recipe for target 'all' failed [ 92s] make[1]: *** [all] Error 2 [ 92s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 92s] dh_auto_build: make -j1 returned exit code 2 [ 92s] debian/rules:13: recipe for target 'build' failed [ 92s] make: *** [build] Error 2 [ 92s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 92s] [ 92s] sheep82 failed "build openbsc_1.2.0.20190321.dsc" at Thu Mar 21 20:13:19 UTC 2019. [ 92s] [ 92s] ### VM INTERACTION START ### [ 95s] [ 87.102779] sysrq: SysRq : Power Off [ 95s] [ 87.109095] reboot: Power down [ 95s] ### VM INTERACTION END ### [ 95s] [ 95s] sheep82 failed "build openbsc_1.2.0.20190321.dsc" at Thu Mar 21 20:13:22 UTC 2019. [ 95s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-sysmon in xUbuntu_17.10/i586
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sysmon/xUbuntu_17.10/i586
Package network:osmocom:nightly/osmo-sysmon failed to build in
xUbuntu_17.10/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-sysmon
Last lines of build log:
[ 76s] #define VERSION "0.1.0"
[ 76s] #define STDC_HEADERS 1
[ 76s] #define HAVE_SYS_TYPES_H 1
[ 76s] #define HAVE_SYS_STAT_H 1
[ 76s] #define HAVE_STDLIB_H 1
[ 76s] #define HAVE_STRING_H 1
[ 76s] #define HAVE_MEMORY_H 1
[ 76s] #define HAVE_STRINGS_H 1
[ 76s] #define HAVE_INTTYPES_H 1
[ 76s] #define HAVE_STDINT_H 1
[ 76s] #define HAVE_UNISTD_H 1
[ 76s] #define HAVE_DLFCN_H 1
[ 76s] #define LT_OBJDIR ".libs/"
[ 76s]
[ 76s] configure: exit 1
[ 76s] dh_auto_configure: ./configure --build=i686-linux-gnu --prefix=/usr
--includedir=\${prefix}/include --mandir=\${prefix}/share/man
--infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var
--disable-silent-rules --libdir=\${prefix}/lib/i386-linux-gnu
--libexecdir=\${prefix}/lib/i386-linux-gnu --disable-maintainer-mode
--disable-dependency-tracking returned exit code 1
[ 76s] debian/rules:45: recipe for target 'build' failed
[ 76s] make: *** [build] Error 2
[ 76s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[ 76s]
[ 76s] lamb13 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 20:11:55 UTC
2019.
[ 76s]
[ 76s] ### VM INTERACTION START ###
[ 79s] [ 68.247446] sysrq: SysRq : Power Off
[ 79s] [ 68.253136] reboot: Power down
[ 79s] ### VM INTERACTION END ###
[ 79s]
[ 79s] lamb13 failed "build osmo-sysmon_0.1.0.dsc" at Thu Mar 21 20:11:59 UTC
2019.
[ 79s]
--
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)
Change in osmo-msc[master]: libmsc: fix: properly initialize the SGs server
Vadim Yanitskiy has uploaded this change for review. (
https://gerrit.osmocom.org/13373
Change subject: libmsc: fix: properly initialize the SGs server
..
libmsc: fix: properly initialize the SGs server
Change-Id: Ie0c31205ac48be7e50d0380a89833771b2708da4
---
M src/libmsc/sgs_iface.c
M src/libmsc/sgs_vty.c
M src/osmo-msc/msc_main.c
3 files changed, 16 insertions(+), 8 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/73/13373/1
diff --git a/src/libmsc/sgs_iface.c b/src/libmsc/sgs_iface.c
index 95b68f8..450d552 100644
--- a/src/libmsc/sgs_iface.c
+++ b/src/libmsc/sgs_iface.c
@@ -1258,8 +1258,6 @@
return NULL;
g_sgs = sgs;
- sgs_server_open(sgs);
-
return sgs;
}
diff --git a/src/libmsc/sgs_vty.c b/src/libmsc/sgs_vty.c
index 8ba5a79..dbf2607 100644
--- a/src/libmsc/sgs_vty.c
+++ b/src/libmsc/sgs_vty.c
@@ -56,9 +56,11 @@
osmo_strlcpy(sgs->cfg.local_addr, argv[0], sizeof(sgs->cfg.local_addr));
osmo_stream_srv_link_set_addr(sgs->srv_link, sgs->cfg.local_addr);
- rc = sgs_server_open(sgs);
- if (rc < 0)
- return CMD_WARNING;
+ if (vty->type != VTY_FILE) {
+ rc = sgs_server_open(sgs);
+ if (rc < 0)
+ return CMD_WARNING;
+ }
return CMD_SUCCESS;
}
@@ -74,9 +76,11 @@
sgs->cfg.local_port = atoi(argv[0]);
osmo_stream_srv_link_set_port(sgs->srv_link, sgs->cfg.local_port);
- rc = sgs_server_open(sgs);
- if (rc < 0)
- return CMD_WARNING;
+ if (vty->type != VTY_FILE) {
+ rc = sgs_server_open(sgs);
+ if (rc < 0)
+ return CMD_WARNING;
+ }
return CMD_SUCCESS;
}
diff --git a/src/osmo-msc/msc_main.c b/src/osmo-msc/msc_main.c
index f29b2a8..b55d38f 100644
--- a/src/osmo-msc/msc_main.c
+++ b/src/osmo-msc/msc_main.c
@@ -62,6 +62,7 @@
#include
#include
#include
+#include
#ifdef BUILD_IU
#include
@@ -692,6 +693,11 @@
return 8;
}
+ if (sgs_server_open(g_sgs)) {
+ printf("Starting SGs server failed\n");
+ return 9;
+ }
+
#ifdef BUILD_IU
/* Set up IuCS */
ranap_iu_init(tall_msc_ctx, DRANAP, "OsmoMSC-IuCS",
msc_network->iu.sccp, rcvmsg_iu_cs, rx_iu_event);
--
To view, visit https://gerrit.osmocom.org/13373
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie0c31205ac48be7e50d0380a89833771b2708da4
Gerrit-Change-Number: 13373
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy
Change in osmo-msc[master]: libmsc/sgs_iface.c: register sgs_vlr_reset_fsm on DSO load
Vadim Yanitskiy has uploaded this change for review. (
https://gerrit.osmocom.org/13371
Change subject: libmsc/sgs_iface.c: register sgs_vlr_reset_fsm on DSO load
..
libmsc/sgs_iface.c: register sgs_vlr_reset_fsm on DSO load
Change-Id: I80cd2e5645d6e391080376250c0853a3f3f821ef
---
M src/libmsc/sgs_iface.c
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/71/13371/1
diff --git a/src/libmsc/sgs_iface.c b/src/libmsc/sgs_iface.c
index f2e74cb..95b68f8 100644
--- a/src/libmsc/sgs_iface.c
+++ b/src/libmsc/sgs_iface.c
@@ -1258,8 +1258,12 @@
return NULL;
g_sgs = sgs;
- osmo_fsm_register(&sgs_vlr_reset_fsm);
sgs_server_open(sgs);
return sgs;
}
+
+static __attribute__((constructor)) void on_dso_load(void)
+{
+ OSMO_ASSERT(osmo_fsm_register(&sgs_vlr_reset_fsm) == 0);
+}
--
To view, visit https://gerrit.osmocom.org/13371
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I80cd2e5645d6e391080376250c0853a3f3f821ef
Gerrit-Change-Number: 13371
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy
Change in osmo-msc[master]: libmsc/sgs_vty.c: don't print SGs socket error twice
Vadim Yanitskiy has uploaded this change for review. (
https://gerrit.osmocom.org/13372
Change subject: libmsc/sgs_vty.c: don't print SGs socket error twice
..
libmsc/sgs_vty.c: don't print SGs socket error twice
Because sgs_server_open() already does this.
Change-Id: Ifea308645c7829691dbcf53e4f59841090119006
---
M src/libmsc/sgs_vty.c
1 file changed, 2 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/72/13372/1
diff --git a/src/libmsc/sgs_vty.c b/src/libmsc/sgs_vty.c
index 8c94301..8ba5a79 100644
--- a/src/libmsc/sgs_vty.c
+++ b/src/libmsc/sgs_vty.c
@@ -57,10 +57,8 @@
osmo_stream_srv_link_set_addr(sgs->srv_link, sgs->cfg.local_addr);
rc = sgs_server_open(sgs);
- if (rc < 0) {
- vty_out(vty, "%% SGs socket cannot be opened: %s%s",
strerror(errno), VTY_NEWLINE);
+ if (rc < 0)
return CMD_WARNING;
- }
return CMD_SUCCESS;
}
@@ -77,10 +75,8 @@
osmo_stream_srv_link_set_port(sgs->srv_link, sgs->cfg.local_port);
rc = sgs_server_open(sgs);
- if (rc < 0) {
- vty_out(vty, "%% SGs socket cannot be opened: %s%s",
strerror(errno), VTY_NEWLINE);
+ if (rc < 0)
return CMD_WARNING;
- }
return CMD_SUCCESS;
}
--
To view, visit https://gerrit.osmocom.org/13372
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifea308645c7829691dbcf53e4f59841090119006
Gerrit-Change-Number: 13372
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy
Change in osmo-msc[master]: libmsc/sgs_iface.c: fix copy-paste error
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13370 Change subject: libmsc/sgs_iface.c: fix copy-paste error .. libmsc/sgs_iface.c: fix copy-paste error Change-Id: I57b773659302ad4c92b6e670c6156e90a50189ba --- M src/libmsc/sgs_iface.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/70/13370/1 diff --git a/src/libmsc/sgs_iface.c b/src/libmsc/sgs_iface.c index 4f262a5..f2e74cb 100644 --- a/src/libmsc/sgs_iface.c +++ b/src/libmsc/sgs_iface.c @@ -51,7 +51,7 @@ /* A pointer to the GSM network we work with. By the current paradigm, * there can only be one gsm_network per MSC. The pointer is set once - * when calling a_init() */ + * when calling sgs_iface_init() */ static struct gsm_network *gsm_network = NULL; static struct osmo_fsm sgs_vlr_reset_fsm; -- To view, visit https://gerrit.osmocom.org/13370 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I57b773659302ad4c92b6e670c6156e90a50189ba Gerrit-Change-Number: 13370 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy
Change in osmo-pcu[master]: pcu_l1_if: Fix erroneous endian-swapping of the CellID
Harald Welte has uploaded this change for review. (
https://gerrit.osmocom.org/13369
Change subject: pcu_l1_if: Fix erroneous endian-swapping of the CellID
..
pcu_l1_if: Fix erroneous endian-swapping of the CellID
In Change-Id I787fed84a7b613158a5618dd5cffafe4e4927234 in February 2018
we accidentially introduced a change that would erroneously swap
the endianness of the CellID on the way between PCUIF socket and
BSGSP. This meant that all OsmoPCU based BTSs would report the
wrong CellId to the SGSN.
Closes: OS#3854
Change-Id: I2f6cc930c5dbf8dac386b24b0756df2efe8199e4
---
M src/pcu_l1_if.cpp
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/69/13369/1
diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp
index 27e86dd..b59f198 100644
--- a/src/pcu_l1_if.cpp
+++ b/src/pcu_l1_if.cpp
@@ -414,7 +414,6 @@
int rc = 0;
unsigned int trx, ts;
int i;
- uint16_t cell_id = ntohs(info_ind->cell_id);
if (info_ind->version != PCU_IF_VERSION) {
fprintf(stderr, "PCU interface version number of BTS (%d) is "
@@ -445,7 +444,7 @@
LOGP(DL1IF, LOGL_DEBUG, " mnc=%0*u\n", info_ind->mnc_3_digits,
info_ind->mnc);
LOGP(DL1IF, LOGL_DEBUG, " lac=%d\n", info_ind->lac);
LOGP(DL1IF, LOGL_DEBUG, " rac=%d\n", info_ind->rac);
- LOGP(DL1IF, LOGL_DEBUG, " cell_id=%d\n", cell_id);
+ LOGP(DL1IF, LOGL_DEBUG, " cell_id=%d\n", info_ind->cell_id);
LOGP(DL1IF, LOGL_DEBUG, " bsic=%d\n", info_ind->bsic);
LOGP(DL1IF, LOGL_DEBUG, " nsei=%d\n", info_ind->nsei);
LOGP(DL1IF, LOGL_DEBUG, " nse_timer=%d %d %d %d %d %d %d\n",
@@ -496,7 +495,7 @@
info_ind->remote_ip[0], info_ind->remote_port[0],
info_ind->nsei, info_ind->nsvci[0], info_ind->bvci,
info_ind->mcc, info_ind->mnc, info_ind->mnc_3_digits,
info_ind->lac, info_ind->rac,
- cell_id);
+ info_ind->cell_id);
if (!pcu) {
LOGP(DL1IF, LOGL_NOTICE, "SGSN not available\n");
goto bssgp_failed;
--
To view, visit https://gerrit.osmocom.org/13369
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2f6cc930c5dbf8dac386b24b0756df2efe8199e4
Gerrit-Change-Number: 13369
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte
Change in osmocom-bb[master]: trxcon: update trx_udp_open()
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13367 ) Change subject: trxcon: update trx_udp_open() .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13367/1/src/host/trxcon/trx_if.c File src/host/trxcon/trx_if.c: https://gerrit.osmocom.org/#/c/13367/1/src/host/trxcon/trx_if.c@612 PS1, Line 612: bool is_ctrl, > This change makes the function useless for anything else than TRXC and TRXD. > […] Alternatively, we can introduce an enumerated list of interfaces, and just pass an interface type here. So, we would also avoid passing both *ofd and *cb, and moreover just accept the base port instead of port_local / port remote, and do the final calculations here. I prefer this solution. -- To view, visit https://gerrit.osmocom.org/13367 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33b01879f6ea468941e5dab5b46492be8fe5730d Gerrit-Change-Number: 13367 Gerrit-PatchSet: 1 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 21 Mar 2019 18:03:57 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in osmocom-bb[master]: trxcon: update trx_udp_open()
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13367 ) Change subject: trxcon: update trx_udp_open() .. Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/13367/1/src/host/trxcon/trx_if.c File src/host/trxcon/trx_if.c: https://gerrit.osmocom.org/#/c/13367/1/src/host/trxcon/trx_if.c@612 PS1, Line 612: bool is_ctrl, This change makes the function useless for anything else than TRXC and TRXD. I was thinking about (re)introducing the clock interface, so let's avoid this please. As a possible solution, you can keep passing of the call-back function and just pass the interface name as a separate parameter, e.g. const char *name. https://gerrit.osmocom.org/#/c/13367/1/src/host/trxcon/trx_if.c@630 PS1, Line 630: LOGL_NOTICE Looks more like LOGL_INFO for me. I know, the existing code is not perfect, and LOGL_NOTICE is used most of the time. But let's consider LOGL_NOTICE as something more important than host / port information, and closer to error. -- To view, visit https://gerrit.osmocom.org/13367 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33b01879f6ea468941e5dab5b46492be8fe5730d Gerrit-Change-Number: 13367 Gerrit-PatchSet: 1 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 21 Mar 2019 17:58:07 + Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
Change in osmocom-bb[master]: trxcon: use static helper to prepare FBSB
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13355 ) Change subject: trxcon: use static helper to prepare FBSB .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13355 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43832d6a912a32ea5795ed0110981e0b714a7a61 Gerrit-Change-Number: 13355 Gerrit-PatchSet: 3 Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: dexter Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 21 Mar 2019 17:40:56 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmocom-bb[master]: trxcon: log FBSB timer events
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13364 ) Change subject: trxcon: log FBSB timer events .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13364 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0168d43951494f4010df891f391ddad4b57493d7 Gerrit-Change-Number: 13364 Gerrit-PatchSet: 2 Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 21 Mar 2019 17:36:16 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmocom-bb[master]: trxcon: use helper to add l1ctl_info_dl
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13354 ) Change subject: trxcon: use helper to add l1ctl_info_dl .. Patch Set 2: > What would be advantage of using pointer instead of type? 1. It's safe against possible symbol renaming, 2. It's shorter ;) -- To view, visit https://gerrit.osmocom.org/13354 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0b5b81f1fcd2984136e553a93735ea5456d2b3df Gerrit-Change-Number: 13354 Gerrit-PatchSet: 2 Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: dexter Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 21 Mar 2019 17:35:17 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in pysim[master]: commands: correct case of a TLV tag (A5 => a5)
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13339 ) Change subject: commands: correct case of a TLV tag (A5 => a5) .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13339 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41a9933707783f6b1b68ebd91a365405ac0892d0 Gerrit-Change-Number: 13339 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Daniel Willmann Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Kévin Redon Gerrit-CC: Max Gerrit-Comment-Date: Thu, 21 Mar 2019 17:23:15 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in pysim[master]: cards: sysmo-usim-sjs1: add programming of EF.PLMNsel, EF.PLMNwAcT an...
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13340 ) Change subject: cards: sysmo-usim-sjs1: add programming of EF.PLMNsel, EF.PLMNwAcT and EF.OPLMNwAcT .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13340 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0cac3041f1902383d98d6dc211cf31ae6e3a610b Gerrit-Change-Number: 13340 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Daniel Willmann Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Kévin Redon Gerrit-CC: Max Gerrit-Comment-Date: Thu, 21 Mar 2019 17:23:01 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-ci[master]: Also build oc2g support for osmo-pcu
André Boddenberg has posted comments on this change. ( https://gerrit.osmocom.org/13368 ) Change subject: Also build oc2g support for osmo-pcu .. Patch Set 1: +1 -- To view, visit https://gerrit.osmocom.org/13368 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebddf8d41538fe1e69435cda7f77bd49c4c14477 Gerrit-Change-Number: 13368 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Willmann Gerrit-CC: André Boddenberg Gerrit-Comment-Date: Thu, 21 Mar 2019 17:19:39 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in pysim[master]: cards: sysmo-usim-sjs1: add programming of EF.PLMNsel, EF.PLMNwAcT an...
Hello Kévin Redon, Daniel Willmann, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13340 to look at the new patch set (#3). Change subject: cards: sysmo-usim-sjs1: add programming of EF.PLMNsel, EF.PLMNwAcT and EF.OPLMNwAcT .. cards: sysmo-usim-sjs1: add programming of EF.PLMNsel, EF.PLMNwAcT and EF.OPLMNwAcT The files EF.PLMNsel, EF.PLMNwAcT and EF.OPLMNwAcT are currently not programmed for sysmo-usim-sjs1, lets add them. Change-Id: I0cac3041f1902383d98d6dc211cf31ae6e3a610b Related: OS#3850 --- M pySim/cards.py 1 file changed, 20 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/40/13340/3 -- To view, visit https://gerrit.osmocom.org/13340 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0cac3041f1902383d98d6dc211cf31ae6e3a610b Gerrit-Change-Number: 13340 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Daniel Willmann Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Kévin Redon Gerrit-CC: Max
Change in pysim[master]: cards: sysmo-usim-sjs1: add programming of EF.PLMNsel, EF.PLMNwAcT an...
Daniel Willmann has posted comments on this change. ( https://gerrit.osmocom.org/13340 ) Change subject: cards: sysmo-usim-sjs1: add programming of EF.PLMNsel, EF.PLMNwAcT and EF.OPLMNwAcT .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/13340/2/pySim/cards.py File pySim/cards.py: https://gerrit.osmocom.org/#/c/13340/2/pySim/cards.py@540 PS2, Line 540: self._scc.sel_ctrl = "0004" #request an FCP You're overwriting the other sel_ctrl here, is that intended? Does this break other stuff? Or remove the line above? -- To view, visit https://gerrit.osmocom.org/13340 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0cac3041f1902383d98d6dc211cf31ae6e3a610b Gerrit-Change-Number: 13340 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Daniel Willmann Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Kévin Redon Gerrit-CC: Max Gerrit-Comment-Date: Thu, 21 Mar 2019 17:02:17 + Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
Change in pysim[master]: commands: correct case of a TLV tag (A5 => a5)
Daniel Willmann has posted comments on this change. ( https://gerrit.osmocom.org/13339 ) Change subject: commands: correct case of a TLV tag (A5 => a5) .. Patch Set 2: Code-Review+1 Looks good, but does it make sense to avoid this in general by using to_lower in the TLV class or is this too much work? -- To view, visit https://gerrit.osmocom.org/13339 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41a9933707783f6b1b68ebd91a365405ac0892d0 Gerrit-Change-Number: 13339 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Daniel Willmann Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Kévin Redon Gerrit-CC: Harald Welte Gerrit-CC: Max Gerrit-Comment-Date: Thu, 21 Mar 2019 16:59:45 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-ci[master]: Also build oc2g support for osmo-pcu
Daniel Willmann has uploaded this change for review. ( https://gerrit.osmocom.org/13368 Change subject: Also build oc2g support for osmo-pcu .. Also build oc2g support for osmo-pcu Needs gerrit change I7cd89a549c9463e81893ca7dd925299f728e4453 in osmo-pcu Fixes: SYS#4524 Change-Id: Iebddf8d41538fe1e69435cda7f77bd49c4c14477 --- M jobs/gerrit-verifications.yml 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/68/13368/1 diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index a2f68f5..1d5c56c 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -192,11 +192,11 @@ - osmo-pcu: a1_name: FIRMWARE_VERSION - a1: !!python/tuple [master, v2017.01, origin/nrw/litecell15] + a1: !!python/tuple [master, v2017.01, origin/nrw/litecell15, origin/nrw/oc2g] a2_name: with_vty a2: !!python/tuple [True, False] a3_name: with_dsp - a3: !!python/tuple [sysmo, lc15, none] + a3: !!python/tuple [sysmo, lc15, oc2g, none] a4_name: WITH_MANUALS a4: !!python/tuple ["1", "0"] sequential: true @@ -205,6 +205,7 @@ (with_vty == "True" && with_dsp == "lc15" && FIRMWARE_VERSION=="master" && WITH_MANUALS == "0") || (with_vty == "True" && with_dsp == "lc15" && FIRMWARE_VERSION=="v2017.01" && WITH_MANUALS == "0") || (with_vty == "True" && with_dsp == "lc15" && FIRMWARE_VERSION=="origin/nrw/litecell15" && WITH_MANUALS == "0") || +(with_vty == "True" && with_dsp == "oc2g" && FIRMWARE_VERSION=="origin/nrw/oc2g" && WITH_MANUALS == "0") || (with_vty == "False" && with_dsp == "none" && FIRMWARE_VERSION=="master" && WITH_MANUALS == "1") - osmo-python-tests: -- To view, visit https://gerrit.osmocom.org/13368 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iebddf8d41538fe1e69435cda7f77bd49c4c14477 Gerrit-Change-Number: 13368 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Willmann
Change in osmo-pcu[master]: Include pdch.h in bts.h even if we're not compiling C++
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13361 to look at the new patch set (#2). Change subject: Include pdch.h in bts.h even if we're not compiling C++ .. Include pdch.h in bts.h even if we're not compiling C++ bts.h needs pdch.h whether we're compiling C or C++ code so move it out of the #ifdef. make[1]: Entering directory '/home/daniel/scm/osmo/oc2g/osmo-pcu-oc2g/src' CC osmo-bts-oc2g/oc2g_l1_if.o In file included from osmo-bts-oc2g/oc2g_l1_if.c:39: ./bts.h:74:26: error: array type has incomplete element type ‘struct gprs_rlcmac_pdch’ struct gprs_rlcmac_pdch pdch[8]; ^~~~ Change-Id: Ib39e4424f73c677b34f921917440f211e400e14f --- M src/bts.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/61/13361/2 -- To view, visit https://gerrit.osmocom.org/13361 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib39e4424f73c677b34f921917440f211e400e14f Gerrit-Change-Number: 13361 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Willmann Gerrit-Reviewer: Daniel Willmann Gerrit-Reviewer: Jenkins Builder (102) Gerrit-CC: Pau Espin Pedrol
Change in osmo-pcu[master]: Add missing include
Daniel Willmann has posted comments on this change. ( https://gerrit.osmocom.org/13361 ) Change subject: Add missing include .. Patch Set 1: See https://projects.sysmocom.de/issues/4524 - basically we are not building the oc2g support at all in the verification jobs. I'll update the commit message with the compile error. -- To view, visit https://gerrit.osmocom.org/13361 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib39e4424f73c677b34f921917440f211e400e14f Gerrit-Change-Number: 13361 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Willmann Gerrit-Reviewer: Daniel Willmann Gerrit-Reviewer: Jenkins Builder (102) Gerrit-CC: Pau Espin Pedrol Gerrit-Comment-Date: Thu, 21 Mar 2019 16:32:55 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-pcu[master]: MCS: move Mode enum outside of class definition
Max has posted comments on this change. ( https://gerrit.osmocom.org/13163 ) Change subject: MCS: move Mode enum outside of class definition .. Patch Set 6: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/13163 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3baaac7f1ca3f5b88917a23c1679d63847455f47 Gerrit-Change-Number: 13163 Gerrit-PatchSet: 6 Gerrit-Owner: Max Gerrit-Reviewer: Daniel Willmann Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 21 Mar 2019 16:28:43 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in pysim[master]: sysmo-usim-sjs1: update EF.AD with correct MNC length
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13366 to look at the new patch set (#2). Change subject: sysmo-usim-sjs1: update EF.AD with correct MNC length .. sysmo-usim-sjs1: update EF.AD with correct MNC length At the moment EF.AD, which contains the length of the MNC is not updated. For two digit MNC (the usual case) this is fine since the length is set to 2 by default. However, when one wants to set an MNC with 3 digit length the file must be updated, otherwise the third digit of the MNC is recognized as part of the MSIN. Change-Id: I827092b2c7f7952f54b2d9f8dbda419a0dbfaf65 Related: OS#3850 --- M pySim-read.py M pySim/cards.py 2 files changed, 19 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/66/13366/2 -- To view, visit https://gerrit.osmocom.org/13366 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I827092b2c7f7952f54b2d9f8dbda419a0dbfaf65 Gerrit-Change-Number: 13366 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102)
Change in pysim[master]: cards: sysmo-usim-sjs1: add programming of EF.PLMNsel, EF.PLMNwAcT an...
Hello Kévin Redon, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13340 to look at the new patch set (#2). Change subject: cards: sysmo-usim-sjs1: add programming of EF.PLMNsel, EF.PLMNwAcT and EF.OPLMNwAcT .. cards: sysmo-usim-sjs1: add programming of EF.PLMNsel, EF.PLMNwAcT and EF.OPLMNwAcT The files EF.PLMNsel, EF.PLMNwAcT and EF.OPLMNwAcT are currently not programmed for sysmo-usim-sjs1, lets add them. Change-Id: I0cac3041f1902383d98d6dc211cf31ae6e3a610b Related: OS#3850 --- M pySim/cards.py 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/40/13340/2 -- To view, visit https://gerrit.osmocom.org/13340 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0cac3041f1902383d98d6dc211cf31ae6e3a610b Gerrit-Change-Number: 13340 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Kévin Redon Gerrit-CC: Max
Change in osmo-pcu[master]: Add missing include
Daniel Willmann has posted comments on this change. ( https://gerrit.osmocom.org/13361 ) Change subject: Add missing include .. Patch Set 1: -Code-Review -- To view, visit https://gerrit.osmocom.org/13361 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib39e4424f73c677b34f921917440f211e400e14f Gerrit-Change-Number: 13361 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Willmann Gerrit-Reviewer: Daniel Willmann Gerrit-Reviewer: Jenkins Builder (102) Gerrit-CC: Pau Espin Pedrol Gerrit-Comment-Date: Thu, 21 Mar 2019 16:27:17 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in pysim[master]: commands: correct case of a TLV tag (A5 => a5)
Hello Kévin Redon, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13339 to look at the new patch set (#2). Change subject: commands: correct case of a TLV tag (A5 => a5) .. commands: correct case of a TLV tag (A5 => a5) The hexadecimal tag defintions of pytlv are case sensitive strings. So 'A5' is something different than 'a5'. Pytlv uses lower case letters for the upper hexadecimal digits. Lets correct this. Change-Id: I41a9933707783f6b1b68ebd91a365405ac0892d0 Related: OS#3850 --- M pySim/commands.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/39/13339/2 -- To view, visit https://gerrit.osmocom.org/13339 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I41a9933707783f6b1b68ebd91a365405ac0892d0 Gerrit-Change-Number: 13339 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Kévin Redon Gerrit-CC: Harald Welte Gerrit-CC: Max
Change in osmo-pcu[master]: Add missing include
Daniel Willmann has posted comments on this change. ( https://gerrit.osmocom.org/13361 ) Change subject: Add missing include .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13361 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib39e4424f73c677b34f921917440f211e400e14f Gerrit-Change-Number: 13361 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Willmann Gerrit-Reviewer: Daniel Willmann Gerrit-Reviewer: Jenkins Builder (102) Gerrit-CC: Pau Espin Pedrol Gerrit-Comment-Date: Thu, 21 Mar 2019 16:27:12 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-pcu[master]: Add missing include
Daniel Willmann has posted comments on this change. ( https://gerrit.osmocom.org/13361 ) Change subject: Add missing include .. Patch Set 1: > Again, how it comes this header is added here and jenkins passed > before? explain so in description That's indeed interesting and I was actually expecting fall-out. It certainly didn't compile on my machine when I added it. Let me recheck -- To view, visit https://gerrit.osmocom.org/13361 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib39e4424f73c677b34f921917440f211e400e14f Gerrit-Change-Number: 13361 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Willmann Gerrit-Reviewer: Daniel Willmann Gerrit-Reviewer: Jenkins Builder (102) Gerrit-CC: Pau Espin Pedrol Gerrit-Comment-Date: Thu, 21 Mar 2019 16:20:32 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-pcu[master]: oc2g: Change log type (Litecell15->Oc2g)
Daniel Willmann has posted comments on this change. ( https://gerrit.osmocom.org/13362 ) Change subject: oc2g: Change log type (Litecell15->Oc2g) .. Patch Set 1: > Why not squashing it with initial commit? It looks like a trivial > typo. I want to keep the commit from others unchanged as much as a can - even if this is really trivial. -- To view, visit https://gerrit.osmocom.org/13362 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95ced5da1c89dae5a16963b10b005747277f320b Gerrit-Change-Number: 13362 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Willmann Gerrit-Reviewer: Daniel Willmann Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-CC: Max Gerrit-Comment-Date: Thu, 21 Mar 2019 16:19:03 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-gsm-tester[master]: contrib: jenkins-build-osmo-pcu-oc2g: Enable oc2gbts-phy
Daniel Willmann has posted comments on this change. ( https://gerrit.osmocom.org/13363 ) Change subject: contrib: jenkins-build-osmo-pcu-oc2g: Enable oc2gbts-phy .. Patch Set 1: It depends on the patchset starting with I7cd89a549c9463e81893ca7dd925299f728e4453 but better to wait until everything upto I95ced5da1c89dae5a16963b10b005747277f320b is merged -- To view, visit https://gerrit.osmocom.org/13363 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1384f4adeca7583e48dd94fcb09a1b58d108f1de Gerrit-Change-Number: 13363 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol Gerrit-Assignee: Daniel Willmann Gerrit-Reviewer: Daniel Willmann Gerrit-Reviewer: Harald Welte Gerrit-Comment-Date: Thu, 21 Mar 2019 16:15:01 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in openbsc[master]: Drop openggsn from build dependencies
Max has posted comments on this change. ( https://gerrit.osmocom.org/13345 ) Change subject: Drop openggsn from build dependencies .. Patch Set 1: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/13345 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6725d39449a3d498adcd83fb8c3fe892367df0e8 Gerrit-Change-Number: 13345 Gerrit-PatchSet: 1 Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 21 Mar 2019 16:11:20 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-gsm-tester[master]: contrib: jenkins-build-osmo-pcu-oc2g: Enable oc2gbts-phy
Daniel Willmann has posted comments on this change. ( https://gerrit.osmocom.org/13363 ) Change subject: contrib: jenkins-build-osmo-pcu-oc2g: Enable oc2gbts-phy .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/13363/1/contrib/jenkins-build-osmo-pcu-oc2g.sh File contrib/jenkins-build-osmo-pcu-oc2g.sh: https://gerrit.osmocom.org/#/c/13363/1/contrib/jenkins-build-osmo-pcu-oc2g.sh@22 PS1, Line 22: build_repo osmo-pcu --disable-sysmocom-dsp -enable-oc2gbts-phy You will also need to either add the include files for the firmware to a path that is already in include or set it with "--with-oc2g=/path/to/inc" In any case you need the oc2g firmware files that can be obtained from https://gitlab.com/nrw_oc2g/oc2g-fw Not sure if you are doing that already (since it's also needed for the oc2g bts support). also *-*-enable-oc2gbts-phy -- To view, visit https://gerrit.osmocom.org/13363 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1384f4adeca7583e48dd94fcb09a1b58d108f1de Gerrit-Change-Number: 13363 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol Gerrit-Assignee: Daniel Willmann Gerrit-Reviewer: Daniel Willmann Gerrit-Reviewer: Harald Welte Gerrit-Comment-Date: Thu, 21 Mar 2019 16:06:57 + Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
Change in docker-playground[master]: BTS tests: update NSVC config in osmo-bsc.cfg
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/13341 ) Change subject: BTS tests: update NSVC config in osmo-bsc.cfg .. BTS tests: update NSVC config in osmo-bsc.cfg * remove extra NSVC config * use 0.0.0.0 for nsvc 0 The additional nsvc and this particular address are not used for BTS' PCU-related tests in any way and only add confusion. It's likely a result of copy-paste from another test. Change-Id: Ie424107672496df70fc83c8fd6cef99a312fcee7 --- M ttcn3-bts-test/osmo-bsc.cfg 1 file changed, 1 insertion(+), 5 deletions(-) Approvals: Harald Welte: Looks good to me, approved Max: Verified diff --git a/ttcn3-bts-test/osmo-bsc.cfg b/ttcn3-bts-test/osmo-bsc.cfg index b06cf06..54264e8 100644 --- a/ttcn3-bts-test/osmo-bsc.cfg +++ b/ttcn3-bts-test/osmo-bsc.cfg @@ -131,11 +131,7 @@ gprs nsvc 0 nsvci 1234 gprs nsvc 0 local udp port 23000 gprs nsvc 0 remote udp port 23000 - gprs nsvc 0 remote ip 192.168.100.239 - gprs nsvc 1 nsvci 0 - gprs nsvc 1 local udp port 0 - gprs nsvc 1 remote udp port 0 - gprs nsvc 1 remote ip 0.0.0.0 + gprs nsvc 0 remote ip 0.0.0.0 no force-combined-si trx 0 rf_locked 0 -- To view, visit https://gerrit.osmocom.org/13341 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie424107672496df70fc83c8fd6cef99a312fcee7 Gerrit-Change-Number: 13341 Gerrit-PatchSet: 2 Gerrit-Owner: Max Gerrit-Reviewer: Daniel Willmann Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: osmith
Change in libosmocore[master]: signal.c: Make non-exported tall_sigh_ctx static
Harald Welte has submitted this change and it was merged. (
https://gerrit.osmocom.org/13337 )
Change subject: signal.c: Make non-exported tall_sigh_ctx static
..
signal.c: Make non-exported tall_sigh_ctx static
As indicated in the commitlog of
Id58ca18eb826b8f4183a7cf0dbb2b38cba702a09,
the symbol was never exported in a header file, so it should be safe
to mark it as static.
Change-Id: I7132ffe9a7efcab226cc639d1b2357f7115bcadf
---
M src/signal.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Max: Looks good to me, but someone else must approve
Vadim Yanitskiy: Looks good to me, but someone else must approve
Pau Espin Pedrol: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/signal.c b/src/signal.c
index be3b777..f988419 100644
--- a/src/signal.c
+++ b/src/signal.c
@@ -36,7 +36,7 @@
* \file signal.c */
-void *tall_sigh_ctx;
+static void *tall_sigh_ctx;
static LLIST_HEAD(signal_handler_list);
struct signal_handler {
--
To view, visit https://gerrit.osmocom.org/13337
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7132ffe9a7efcab226cc639d1b2357f7115bcadf
Gerrit-Change-Number: 13337
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte
Gerrit-Assignee: Pau Espin Pedrol
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-Reviewer: Pau Espin Pedrol
Gerrit-Reviewer: Vadim Yanitskiy
Change in osmocom-bb[master]: trxcon: use helper to add l1ctl_info_dl
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/13354 )
Change subject: trxcon: use helper to add l1ctl_info_dl
..
trxcon: use helper to add l1ctl_info_dl
Use static helpers to add l1ctl_info_dl to msgb - this simplifies
l1ctl_* routines and reduce code duplication.
Change-Id: I0b5b81f1fcd2984136e553a93735ea5456d2b3df
---
M src/host/trxcon/l1ctl.c
1 file changed, 18 insertions(+), 24 deletions(-)
Approvals:
Jenkins Builder: Verified
Harald Welte: Looks good to me, approved
diff --git a/src/host/trxcon/l1ctl.c b/src/host/trxcon/l1ctl.c
index eb14832..b37082e 100644
--- a/src/host/trxcon/l1ctl.c
+++ b/src/host/trxcon/l1ctl.c
@@ -138,13 +138,24 @@
return l1ctl_link_send(l1l, msg);
}
+static struct l1ctl_info_dl *put_dl_info_hdr(struct msgb *msg, struct
l1ctl_info_dl *dl_info)
+{
+ size_t len = sizeof(struct l1ctl_info_dl);
+ struct l1ctl_info_dl *dl = (struct l1ctl_info_dl *) msgb_put(msg, len);
+
+ if (dl_info) /* Copy DL info provided by handler */
+ memcpy(dl, dl_info, len);
+ else /* Init DL info header */
+ memset(dl, 0x00, len);
+
+ return dl;
+}
+
int l1ctl_tx_fbsb_conf(struct l1ctl_link *l1l, uint8_t result,
struct l1ctl_info_dl *dl_info, uint8_t bsic)
{
struct l1ctl_fbsb_conf *conf;
- struct l1ctl_info_dl *dl;
struct msgb *msg;
- size_t len;
msg = l1ctl_alloc_msg(L1CTL_FBSB_CONF);
if (msg == NULL)
@@ -153,10 +164,7 @@
LOGP(DL1C, LOGL_DEBUG, "Send FBSB Conf (result=%u, bsic=%u)\n",
result, bsic);
- /* Copy DL info provided by handler */
- len = sizeof(struct l1ctl_info_dl);
- dl = (struct l1ctl_info_dl *) msgb_put(msg, len);
- memcpy(dl, dl_info, len);
+ put_dl_info_hdr(msg, dl_info);
talloc_free(dl_info);
/* Fill in FBSB payload: BSIC and sync result */
@@ -198,7 +206,6 @@
int l1ctl_tx_dt_ind(struct l1ctl_link *l1l, struct l1ctl_info_dl *data,
uint8_t *l2, size_t l2_len, bool traffic)
{
- struct l1ctl_info_dl *dl;
struct msgb *msg;
uint8_t *msg_l2;
@@ -207,9 +214,7 @@
if (msg == NULL)
return -ENOMEM;
- /* Copy DL header */
- dl = (struct l1ctl_info_dl *) msgb_put(msg, sizeof(*dl));
- memcpy(dl, data, sizeof(*dl));
+ put_dl_info_hdr(msg, data);
/* Copy the L2 payload if preset */
if (l2 && l2_len > 0) {
@@ -225,16 +230,13 @@
{
struct l1ctl_info_dl *dl;
struct msgb *msg;
- size_t len;
msg = l1ctl_alloc_msg(L1CTL_RACH_CONF);
if (msg == NULL)
return -ENOMEM;
- len = sizeof(struct l1ctl_info_dl);
- dl = (struct l1ctl_info_dl *) msgb_put(msg, len);
+ dl = put_dl_info_hdr(msg, NULL);
- memset(dl, 0x00, len);
dl->band_arfcn = htons(l1l->trx->band_arfcn);
dl->frame_nr = htonl(fn);
@@ -248,9 +250,7 @@
int l1ctl_tx_dt_conf(struct l1ctl_link *l1l,
struct l1ctl_info_dl *data, bool traffic)
{
- struct l1ctl_info_dl *dl;
struct msgb *msg;
- size_t len;
msg = l1ctl_alloc_msg(traffic ?
L1CTL_TRAFFIC_CONF : L1CTL_DATA_CONF);
@@ -258,9 +258,7 @@
return -ENOMEM;
/* Copy DL frame header from source message */
- len = sizeof(struct l1ctl_info_dl);
- dl = (struct l1ctl_info_dl *) msgb_put(msg, len);
- memcpy(dl, data, len);
+ put_dl_info_hdr(msg, data);
return l1ctl_link_send(l1l, msg);
}
@@ -292,7 +290,6 @@
struct l1ctl_fbsb_conf *conf;
struct l1ctl_info_dl *dl;
struct msgb *msg;
- size_t len;
msg = l1ctl_alloc_msg(L1CTL_FBSB_CONF);
if (msg == NULL)
@@ -300,10 +297,7 @@
LOGP(DL1C, LOGL_DEBUG, "Send FBSB Conf (result=255, bsic=0)\n");
- /* Compose DL info header */
- len = sizeof(struct l1ctl_info_dl);
- dl = (struct l1ctl_info_dl *) msgb_put(msg, len);
- memset(dl, 0x00, len);
+ dl = put_dl_info_hdr(msg, NULL);
/* Fill in current ARFCN */
dl->band_arfcn = htons(l1l->trx->band_arfcn);
--
To view, visit https://gerrit.osmocom.org/13354
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b5b81f1fcd2984136e553a93735ea5456d2b3df
Gerrit-Change-Number: 13354
Gerrit-PatchSet: 2
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-Reviewer: Vadim Yanitskiy
Gerrit-Reviewer: dexter
Gerrit-Reviewer: osmith
Change in libosmocore[master]: signal.c: Fix osmo_signal_talloc_ctx_init()
Harald Welte has submitted this change and it was merged. (
https://gerrit.osmocom.org/13336 )
Change subject: signal.c: Fix osmo_signal_talloc_ctx_init()
..
signal.c: Fix osmo_signal_talloc_ctx_init()
This function is broken ever since it was added back in 2018 in commit
Id58ca18eb826b8f4183a7cf0dbb2b38cba702a09
Rather than allocating from the user-supplied 'root_ctx', it is
allocating from the context that it's trying to create (which is
NULL at that time, rendering the entire operation more or less
a no-op. For sure you will not see osmo_signal structures never in
any talloc report.
Change-Id: I922d26815a3baa5be74bd3ee89d498555882d62f
---
M src/signal.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Max: Looks good to me, but someone else must approve
Vadim Yanitskiy: Looks good to me, approved
Pau Espin Pedrol: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/signal.c b/src/signal.c
index 7e53e83..be3b777 100644
--- a/src/signal.c
+++ b/src/signal.c
@@ -52,7 +52,7 @@
* \returns the new osmo_signal talloc context, e.g. for reporting
*/
void *osmo_signal_talloc_ctx_init(void *root_ctx) {
- tall_sigh_ctx = talloc_named_const(tall_sigh_ctx, 0, "osmo_signal");
+ tall_sigh_ctx = talloc_named_const(root_ctx, 0, "osmo_signal");
return tall_sigh_ctx;
}
--
To view, visit https://gerrit.osmocom.org/13336
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I922d26815a3baa5be74bd3ee89d498555882d62f
Gerrit-Change-Number: 13336
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte
Gerrit-Assignee: Pau Espin Pedrol
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-Reviewer: Pau Espin Pedrol
Gerrit-Reviewer: Vadim Yanitskiy
Change in libosmocore[master]: select: Rename BSC_FD_* constants to OSMO_FD_*
Harald Welte has submitted this change and it was merged. (
https://gerrit.osmocom.org/13335 )
Change subject: select: Rename BSC_FD_* constants to OSMO_FD_*
..
select: Rename BSC_FD_* constants to OSMO_FD_*
The naming of these constants dates back to when the code was private
within OpenBSC. Everything else was renamed (bsc_fd -> osmo_fd) at
the time, but somehow the BSC_FD_* defines have been missed at the
time.
Keep compatibility #defines around, but allow us to migrate the
applications to a less confusing naming meanwhile.
Change-Id: Ifae33ed61a7cf0ae54ad487399e7dd2489986436
---
M include/osmocom/core/select.h
M src/ctrl/control_if.c
M src/gb/gprs_ns.c
M src/gb/gprs_ns_frgre.c
M src/gsmtap_util.c
M src/select.c
M src/socket.c
M src/vty/telnet_interface.c
M src/write_queue.c
9 files changed, 42 insertions(+), 37 deletions(-)
Approvals:
Max: Looks good to me, but someone else must approve
Vadim Yanitskiy: Looks good to me, but someone else must approve
Pau Espin Pedrol: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/include/osmocom/core/select.h b/include/osmocom/core/select.h
index 1ba6b83..e4787b0 100644
--- a/include/osmocom/core/select.h
+++ b/include/osmocom/core/select.h
@@ -13,11 +13,16 @@
* \file select.h */
/*! Indicate interest in reading from the file descriptor */
-#define BSC_FD_READ0x0001
+#define OSMO_FD_READ 0x0001
/*! Indicate interest in writing to the file descriptor */
-#define BSC_FD_WRITE 0x0002
+#define OSMO_FD_WRITE 0x0002
/*! Indicate interest in exceptions from the file descriptor */
-#define BSC_FD_EXCEPT 0x0004
+#define OSMO_FD_EXCEPT 0x0004
+
+/* legacy naming dating back to early OpenBSC / bsc_hack of 2008 */
+#define BSC_FD_READOSMO_FD_READ
+#define BSC_FD_WRITE OSMO_FD_WRITE
+#define BSC_FD_EXCEPT OSMO_FD_EXCEPT
/*! Structure representing a file dsecriptor */
struct osmo_fd {
@@ -25,8 +30,8 @@
struct llist_head list;
/*! actual operating-system level file decriptor */
int fd;
- /*! bit-mask or of \ref BSC_FD_READ, \ref BSC_FD_WRITE and/or
-* \ref BSC_FD_EXCEPT */
+ /*! bit-mask or of \ref OSMO_FD_READ, \ref OSMO_FD_WRITE and/or
+* \ref OSMO_FD_EXCEPT */
unsigned int when;
/*! call-back function to be called once file descriptor becomes
* available */
diff --git a/src/ctrl/control_if.c b/src/ctrl/control_if.c
index 0209f3b..ce2e367 100644
--- a/src/ctrl/control_if.c
+++ b/src/ctrl/control_if.c
@@ -524,7 +524,7 @@
char *name;
- if (!(what & BSC_FD_READ))
+ if (!(what & OSMO_FD_READ))
return 0;
fd = accept(listen_bfd->fd, NULL, NULL);
@@ -554,7 +554,7 @@
LOGP(DLCTRL, LOGL_INFO, "accept()ed new CTRL connection from %s\n",
name);
ccon->write_queue.bfd.fd = fd;
- ccon->write_queue.bfd.when = BSC_FD_READ;
+ ccon->write_queue.bfd.when = OSMO_FD_READ;
ret = osmo_fd_register(&ccon->write_queue.bfd);
if (ret < 0) {
diff --git a/src/gb/gprs_ns.c b/src/gb/gprs_ns.c
index 8c3b0fa..c7ff78e 100644
--- a/src/gb/gprs_ns.c
+++ b/src/gb/gprs_ns.c
@@ -2006,9 +2006,9 @@
{
int rc = 0;
- if (what & BSC_FD_READ)
+ if (what & OSMO_FD_READ)
rc = handle_nsip_read(bfd);
- if (what & BSC_FD_WRITE)
+ if (what & OSMO_FD_WRITE)
rc = handle_nsip_write(bfd);
return rc;
diff --git a/src/gb/gprs_ns_frgre.c b/src/gb/gprs_ns_frgre.c
index 483fdb6..dbbd8d2 100644
--- a/src/gb/gprs_ns_frgre.c
+++ b/src/gb/gprs_ns_frgre.c
@@ -315,9 +315,9 @@
{
int rc = 0;
- if (what & BSC_FD_READ)
+ if (what & OSMO_FD_READ)
rc = handle_nsfrgre_read(bfd);
- if (what & BSC_FD_WRITE)
+ if (what & OSMO_FD_WRITE)
rc = handle_nsfrgre_write(bfd);
return rc;
diff --git a/src/gsmtap_util.c b/src/gsmtap_util.c
index 385b467..996830f 100644
--- a/src/gsmtap_util.c
+++ b/src/gsmtap_util.c
@@ -355,7 +355,7 @@
int rc;
uint8_t buf[4096];
- if (!(flags & BSC_FD_READ))
+ if (!(flags & OSMO_FD_READ))
return 0;
rc = read(fd->fd, buf, sizeof(buf));
@@ -395,7 +395,7 @@
sink_ofd = >i->sink_ofd;
sink_ofd->fd = fd;
- sink_ofd->when = BSC_FD_READ;
+ sink_ofd->when = OSMO_FD_READ;
sink_ofd->cb = gsmtap_sink_fd_cb;
rc = osmo_fd_register(sink_ofd);
diff --git a/src/select.c b/src/select.c
index 4e7be35..7ce135f 100644
--- a/src/select.c
+++ b/src/select.c
@@ -55,7 +55,7 @@
/*! Set up an osmo-fd. Will not register it.
* \param[inout] ofd Osmo FD to be set-up
* \param[in] fd OS-level file descriptor number
- * \param[in] when bit-mask of BSC_FD_{READ,WRITE,EXECEPT}
+ * \param[in] when bit-mask of OSMO_FD_{READ,WRITE,EXECEPT}
* \param[in] cb Call-back functio
Change in libosmocore[master]: src/signal.c: cosmetic: use talloc_zero()
Harald Welte has submitted this change and it was merged. (
https://gerrit.osmocom.org/13342 )
Change subject: src/signal.c: cosmetic: use talloc_zero()
..
src/signal.c: cosmetic: use talloc_zero()
Change-Id: I55c6249b0c4c82d5a181001e945ff2eca6e9ca36
---
M src/signal.c
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Jenkins Builder: Verified
Pau Espin Pedrol: Looks good to me, but someone else must approve
Harald Welte: Looks good to me, approved
diff --git a/src/signal.c b/src/signal.c
index 188876b..7e53e83 100644
--- a/src/signal.c
+++ b/src/signal.c
@@ -67,12 +67,10 @@
{
struct signal_handler *sig_data;
- sig_data = talloc(tall_sigh_ctx, struct signal_handler);
+ sig_data = talloc_zero(tall_sigh_ctx, struct signal_handler);
if (!sig_data)
return -ENOMEM;
- memset(sig_data, 0, sizeof(*sig_data));
-
sig_data->subsys = subsys;
sig_data->data = data;
sig_data->cbfn = cbfn;
--
To view, visit https://gerrit.osmocom.org/13342
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I55c6249b0c4c82d5a181001e945ff2eca6e9ca36
Gerrit-Change-Number: 13342
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol
Change in osmo-pcu[master]: Fix TA index encoder
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/13238 )
Change subject: Fix TA index encoder
..
Fix TA index encoder
The TAI is described as { 0 | 1 < TIMING_ADVANCE_INDEX : bit (4) > } in
3GPP TS 44.018 §10.5.2.16.1 so it should be encoded with if-else.
Change-Id: I54482790e1cf3cb13a635a99a481250576deabaf
---
M src/encoding.cpp
1 file changed, 6 insertions(+), 6 deletions(-)
Approvals:
Jenkins Builder: Verified
Pau Espin Pedrol: Looks good to me, but someone else must approve
Harald Welte: Looks good to me, approved
diff --git a/src/encoding.cpp b/src/encoding.cpp
index ad53b0b..e21a7fc 100644
--- a/src/encoding.cpp
+++ b/src/encoding.cpp
@@ -117,13 +117,13 @@
{
int rc;
- if (tai < 0) /* No TIMING_ADVANCE_INDEX: */
+ if (tai < 0) { /* No TIMING_ADVANCE_INDEX: */
SET_0(dest);
-
- /* TIMING_ADVANCE_INDEX: */
- SET_1(dest);
- rc = bitvec_set_u64(dest, tai, 4, false);
- CHECK(rc);
+ } else { /* TIMING_ADVANCE_INDEX: */
+ SET_1(dest);
+ rc = bitvec_set_u64(dest, tai, 4, false);
+ CHECK(rc);
+ }
return 0;
}
--
To view, visit https://gerrit.osmocom.org/13238
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I54482790e1cf3cb13a635a99a481250576deabaf
Gerrit-Change-Number: 13238
Gerrit-PatchSet: 4
Gerrit-Owner: Max
Gerrit-Reviewer: Daniel Willmann
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-Reviewer: Pau Espin Pedrol
Change in libosmocore[master]: src/signal.c: cosmetic: use talloc_zero()
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13342 ) Change subject: src/signal.c: cosmetic: use talloc_zero() .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13342 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I55c6249b0c4c82d5a181001e945ff2eca6e9ca36 Gerrit-Change-Number: 13342 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Thu, 21 Mar 2019 16:01:37 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-pcu[master]: MCS: use value_string for conversion
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/13069 )
Change subject: MCS: use value_string for conversion
..
MCS: use value_string for conversion
Change-Id: I212ebb892ab162821633974d5a6c7e315d308370
---
M src/coding_scheme.c
M src/coding_scheme.h
M src/decoding.cpp
M src/encoding.cpp
M src/gprs_bssgp_pcu.cpp
M src/gprs_coding_scheme.cpp
M src/gprs_coding_scheme.h
M src/gprs_ms.cpp
M src/pcu_vty_functions.cpp
M src/pdch.cpp
M src/tbf_dl.cpp
M src/tbf_ul.cpp
M tests/edge/EdgeTest.cpp
13 files changed, 84 insertions(+), 54 deletions(-)
Approvals:
Jenkins Builder: Verified
Harald Welte: Looks good to me, approved
diff --git a/src/coding_scheme.c b/src/coding_scheme.c
index a6f2905..93278e7 100644
--- a/src/coding_scheme.c
+++ b/src/coding_scheme.c
@@ -24,6 +24,28 @@
#include "coding_scheme.h"
+const struct value_string mcs_names[] = {
+ { UNKNOWN, "UNKNOWN" },
+ { CS1, "CS-1" },
+ { CS2, "CS-2" },
+ { CS3, "CS-3" },
+ { CS4, "CS-4" },
+ { MCS1, "MCS-1" },
+ { MCS2, "MCS-2" },
+ { MCS3, "MCS-3" },
+ { MCS4, "MCS-4" },
+ { MCS5, "MCS-5" },
+ { MCS6, "MCS-6" },
+ { MCS7, "MCS-7" },
+ { MCS8, "MCS-8" },
+ { MCS9, "MCS-9" },
+ { 0, NULL }
+};
+
+const char *mcs_name(enum CodingScheme val) {
+ return get_value_string(mcs_names, val);
+}
+
static struct {
struct {
uint8_t data_header_bits;
diff --git a/src/coding_scheme.h b/src/coding_scheme.h
index b0b85e3..1e8ca78 100644
--- a/src/coding_scheme.h
+++ b/src/coding_scheme.h
@@ -19,6 +19,8 @@
#pragma once
+#include
+
enum CodingScheme {
UNKNOWN,
/* GPRS Coding Schemes: */
@@ -28,6 +30,9 @@
NUM_SCHEMES
};
+extern const struct value_string mcs_names[];
+const char *mcs_name(enum CodingScheme val);
+
enum HeaderType {
HEADER_INVALID,
HEADER_GPRS_CONTROL,
diff --git a/src/decoding.cpp b/src/decoding.cpp
index 3410291..1473ff7 100644
--- a/src/decoding.cpp
+++ b/src/decoding.cpp
@@ -370,7 +370,7 @@
default:
LOGP(DRLCMACDL, LOGL_ERROR,
"Decoding of uplink %s data blocks not yet
supported.\n",
- cs.name());
+ mcs_name(cs));
return -ENOTSUP;
};
diff --git a/src/encoding.cpp b/src/encoding.cpp
index 58df95f..ad53b0b 100644
--- a/src/encoding.cpp
+++ b/src/encoding.cpp
@@ -1227,7 +1227,7 @@
default:
LOGP(DRLCMACDL, LOGL_ERROR,
"Encoding of uplink %s data blocks not yet
supported.\n",
- cs.name());
+ mcs_name(cs));
return -ENOTSUP;
};
@@ -1616,7 +1616,7 @@
count_payload);
LOGP(DRLCMACDL, LOGL_ERROR, "%s data block encoding not implemented\n",
- cs.name());
+ mcs_name(cs));
return AR_NEED_MORE_BLOCKS;
}
diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp
index 7ac5ab1..9d02df6 100644
--- a/src/gprs_bssgp_pcu.cpp
+++ b/src/gprs_bssgp_pcu.cpp
@@ -26,7 +26,11 @@
#include
#include
#include
-#include "coding_scheme.h"
+
+extern "C" {
+ #include
+ #include "coding_scheme.h"
+}
#define BSSGP_TIMER_T1 30 /* Guards the (un)blocking procedures */
#define BSSGP_TIMER_T2 30 /* Guards the reset procedure */
@@ -775,7 +779,7 @@
LOGP(DBSSGP, LOGL_DEBUG,
"Computed BVC leak rate = %d, num_pdch = %d, cs = %s\n",
- leak_rate, num_pdch, max_cs_dl.name());
+ leak_rate, num_pdch, mcs_name(max_cs_dl));
};
if (ms_leak_rate == 0) {
@@ -799,7 +803,7 @@
LOGP(DBSSGP, LOGL_DEBUG,
"Computed MS default leak rate = %d, ms_num_pdch = %d, "
"cs = %s\n",
- ms_leak_rate, ms_num_pdch, max_cs_dl.name());
+ ms_leak_rate, ms_num_pdch, mcs_name(max_cs_dl));
};
/* TODO: Force leak_rate to 0 on buffer bloat */
diff --git a/src/gprs_coding_scheme.cpp b/src/gprs_coding_scheme.cpp
index 0616a49..53b3b07 100644
--- a/src/gprs_coding_scheme.cpp
+++ b/src/gprs_coding_scheme.cpp
@@ -81,39 +81,38 @@
} uplink, downlink;
uint8_t data_bytes;
uint8_t optional_padding_bits;
- const char *name;
enum HeaderType data_hdr;
enum Family family;
} mcs_info[NUM_SCHEMES] = {
- {{0, 0}, {0, 0},0, 0, "UNKNOWN",
+ {{0, 0}, {0, 0},0, 0,
HEADER_INVALID, FAMILY_INVALID},
- {{23, 0}, {23, 0}, 20, 0, "CS-1",
+ {{23, 0}, {23, 0}, 20, 0,
HEADER_GPRS_DATA, FAMILY_INVALID},
- {{33, 7}, {33, 7}, 30, 0, "CS-2",
+ {{33, 7}, {33, 7}, 30, 0,
HEADER_GPRS_DATA, FAM
Change in osmo-bsc[master]: osmo_bsc_bssap: check bssmap length field
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13306 ) Change subject: osmo_bsc_bssap: check bssmap length field .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13306 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idef2e783d2377a2ad1f697ea4d26491a32b3e549 Gerrit-Change-Number: 13306 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: dexter Gerrit-Comment-Date: Thu, 21 Mar 2019 16:01:18 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-pcu[master]: MCS: move HeaderType enum outside of class definition
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/13067 )
Change subject: MCS: move HeaderType enum outside of class definition
..
MCS: move HeaderType enum outside of class definition
Move functions which compute number of blocks or bits depending on
header type and corresponding enum outside of GprsCodingScheme
class. This will allows us to use standard libosmocore value_sting
functions in upcoming patches for IA Rest Octet encoding/decoding.
Change-Id: Id0873f85e1f16a72e17e7fbc4ad76b194917067f
---
M debian/copyright
M src/Makefile.am
A src/coding_scheme.c
M src/coding_scheme.h
M src/decoding.cpp
M src/encoding.cpp
M src/gprs_bssgp_pcu.cpp
M src/gprs_coding_scheme.cpp
M src/gprs_coding_scheme.h
M src/rlc.cpp
M src/tbf_dl.cpp
M tests/edge/EdgeTest.cpp
12 files changed, 126 insertions(+), 92 deletions(-)
Approvals:
Jenkins Builder: Verified
Harald Welte: Looks good to me, approved
diff --git a/debian/copyright b/debian/copyright
index 2e800a7..0069d0c 100644
--- a/debian/copyright
+++ b/debian/copyright
@@ -15,6 +15,7 @@
src/gprs_ms.h
src/gprs_coding_scheme.cpp
src/gprs_coding_scheme.h
+ src/coding_scheme.c
src/coding_scheme.h
src/cxx_linuxlist.h
src/pcu_vty_functions.cpp
diff --git a/src/Makefile.am b/src/Makefile.am
index eb4a2bb..51b047e 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -63,6 +63,7 @@
rlc.cpp \
osmobts_sock.cpp \
gprs_codel.c \
+ coding_scheme.c \
gprs_coding_scheme.cpp \
egprs_rlc_compression.cpp
diff --git a/src/coding_scheme.c b/src/coding_scheme.c
new file mode 100644
index 000..a6f2905
--- /dev/null
+++ b/src/coding_scheme.c
@@ -0,0 +1,65 @@
+/* coding_scheme.c
+ *
+ * Copyright (C) 2019 by sysmocom s.f.m.c. GmbH
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
+ */
+
+#include
+#include
+
+#include
+
+#include "coding_scheme.h"
+
+static struct {
+ struct {
+ uint8_t data_header_bits;
+ } uplink, downlink;
+ uint8_t data_block_header_bits;
+ uint8_t num_blocks;
+ const char *name;
+} hdr_type_info[NUM_HEADER_TYPES] = {
+ { { 0 }, { 0 }, 0, 0, "INVALID" },
+ { { 1 * 8 + 0 }, { 1 * 8 + 0 }, 0, 0, "CONTROL" },
+ { { 3 * 8 + 0 }, { 3 * 8 + 0 }, 0, 1, "GPRS_DATA" },
+ { { 5 * 8 + 6 }, { 5 * 8 + 0 }, 2, 2, "EGPRS_DATA_TYPE1" },
+ { { 4 * 8 + 5 }, { 3 * 8 + 4 }, 2, 1, "EGPRS_DATA_TYPE2" },
+ { { 3 * 8 + 7 }, { 3 * 8 + 7 }, 2, 1, "EGPRS_DATA_TYPE3" },
+};
+
+uint8_t num_data_blocks(enum HeaderType ht)
+{
+ OSMO_ASSERT(ht < NUM_HEADER_TYPES);
+ return hdr_type_info[ht].num_blocks;
+}
+
+uint8_t num_data_header_bits_UL(enum HeaderType ht)
+{
+ OSMO_ASSERT(ht < NUM_HEADER_TYPES);
+ return hdr_type_info[ht].uplink.data_header_bits;
+}
+
+uint8_t num_data_header_bits_DL(enum HeaderType ht)
+{
+ OSMO_ASSERT(ht < NUM_HEADER_TYPES);
+ return hdr_type_info[ht].downlink.data_header_bits;
+}
+
+uint8_t num_data_block_header_bits(enum HeaderType ht)
+{
+ OSMO_ASSERT(ht < NUM_HEADER_TYPES);
+ return hdr_type_info[ht].data_block_header_bits;
+}
diff --git a/src/coding_scheme.h b/src/coding_scheme.h
index 3705ea4..b0b85e3 100644
--- a/src/coding_scheme.h
+++ b/src/coding_scheme.h
@@ -27,3 +27,20 @@
MCS1, MCS2, MCS3, MCS4, MCS5, MCS6, MCS7, MCS8, MCS9,
NUM_SCHEMES
};
+
+enum HeaderType {
+ HEADER_INVALID,
+ HEADER_GPRS_CONTROL,
+ HEADER_GPRS_DATA,
+ HEADER_EGPRS_DATA_TYPE_1,
+ HEADER_EGPRS_DATA_TYPE_2,
+ HEADER_EGPRS_DATA_TYPE_3,
+ NUM_HEADER_TYPES
+};
+
+enum HeaderType headerTypeData(enum CodingScheme mcs);
+
+uint8_t num_data_blocks(enum HeaderType ht);
+uint8_t num_data_header_bits_UL(enum HeaderType ht);
+uint8_t num_data_header_bits_DL(enum HeaderType ht);
+uint8_t num_data_block_header_bits(enum HeaderType ht);
diff --git a/src/decoding.cpp b/src/decoding.cpp
index 0dbb10a..3410291 100644
--- a/src/decoding.cpp
+++ b/src/decoding.cpp
@@ -355,16 +355,16 @@
{
unsigned int cur_bit = 0;
switch(cs.headerTypeData()) {
- case GprsCodingScheme::HEADER_GPRS_DATA :
+
Change in osmo-pcu[master]: TBF-DL: log MCS as string
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/13149 ) Change subject: TBF-DL: log MCS as string .. TBF-DL: log MCS as string Log MCS name instead of numeric value. Change-Id: I3e1925a010a6def5fd14da63b73e0b75feddfafc --- M src/tbf_dl.cpp M tests/tbf/TbfTest.err 2 files changed, 28 insertions(+), 28 deletions(-) Approvals: Jenkins Builder: Verified Harald Welte: Looks good to me, approved diff --git a/src/tbf_dl.cpp b/src/tbf_dl.cpp index 38dab37..c276b3a 100644 --- a/src/tbf_dl.cpp +++ b/src/tbf_dl.cpp @@ -385,11 +385,11 @@ bts->bts_data()->dl_arq_type); LOGPTBFDL(this, LOGL_DEBUG, - "initial_cs_dl(%d) last_mcs(%d) demanded_mcs(%d) cs_trans(%d) arq_type(%d) bsn(%d)\n", - m_rlc.block(bsn)->cs_init.to_num(), - m_rlc.block(bsn)->cs_last.to_num(), - ms()->current_cs_dl().to_num(), - m_rlc.block(bsn)->cs_current_trans.to_num(), + "initial_cs_dl(%s) last_mcs(%s) demanded_mcs(%s) cs_trans(%s) arq_type(%d) bsn(%d)\n", + mcs_name(m_rlc.block(bsn)->cs_init), + mcs_name(m_rlc.block(bsn)->cs_last), + mcs_name(ms()->current_cs_dl()), + mcs_name(m_rlc.block(bsn)->cs_current_trans), bts->bts_data()->dl_arq_type, bsn); /* TODO: Need to remove this check when MCS-8 -> MCS-6 diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err index 355ec69..b58b61d 100644 --- a/tests/tbf/TbfTest.err +++ b/tests/tbf/TbfTest.err @@ -4754,7 +4754,7 @@ Received RTS for PDCH: TRX=0 TS=4 FN=8 block_nr=2 scheduling free USF for polling at FN=13 of TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) Scheduling data message at RTS for DL TFI=0 (TRX=0, TS=4) prio=3 TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) downlink (V(A)==0 .. V(S)==1) -TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) initial_cs_dl(7) last_mcs(5) demanded_mcs(7) cs_trans(7) arq_type(1) bsn(0) +TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) initial_cs_dl(MCS-7) last_mcs(MCS-5) demanded_mcs(MCS-7) cs_trans(MCS-7) arq_type(1) bsn(0) TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) Resending BSN 0 TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) Sending new block at BSN 1, CS=MCS-7 TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) Dequeue next LLC (len=512) @@ -4898,7 +4898,7 @@ Received RTS for PDCH: TRX=0 TS=4 FN=8 block_nr=2 scheduling free USF for polling at FN=13 of TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) Scheduling data message at RTS for DL TFI=0 (TRX=0, TS=4) prio=3 TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) downlink (V(A)==0 .. V(S)==1) -TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) initial_cs_dl(8) last_mcs(8) demanded_mcs(8) cs_trans(8) arq_type(1) bsn(0) +TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) initial_cs_dl(MCS-8) last_mcs(MCS-8) demanded_mcs(MCS-8) cs_trans(MCS-8) arq_type(1) bsn(0) TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) Resending BSN 0 TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) Sending new block at BSN 1, CS=MCS-8 TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) Dequeue next LLC (len=512) @@ -5029,7 +5029,7 @@ Received RTS for PDCH: TRX=0 TS=4 FN=8 block_nr=2 scheduling free USF for polling at FN=13 of TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) Scheduling data message at RTS for DL TFI=0 (TRX=0, TS=4) prio=3 TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) downlink (V(A)==0 .. V(S)==1) -TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) initial_cs_dl(9) last_mcs(6) demanded_mcs(9) cs_trans(9) arq_type(1) bsn(0) +TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) initial_cs_dl(MCS-9) last_mcs(MCS-6) demanded_mcs(MCS-9) cs_trans(MCS-9) arq_type(1) bsn(0) TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) Resending BSN 0 TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) Sending new block at BSN 1, CS=MCS-9 TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) Dequeue next LLC (len=512) @@ -5145,7 +5145,7 @@ TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) Copying data unit 0 (BSN 0) TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) msg block (BSN 0, MCS-6): 07 00 00 10 40 80 c0 00 41 81 c1 01 42 82 c2 02 43 83 c3 03 44 84 c4 04 45 85 c5 05 46 86 c6 06 47 87 c7 07 48 88 c8 08 49 89 c9 09 4a 8a ca 0a 4b 8b cb 0b 4c 8c cc 0c 4d 8d cd 0d 4e 8e ce 0e 4f 8f cf 0f 50 90 d0 10 51 91 d1 11 52 12 TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) downlink (V(A)==0 .. V(S)==1) -TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=FLOW EGPRS) initial_cs_dl(6) last_mcs(6) demanded_mcs(6) cs_trans(6) arq_type(1) bsn(0) +TB
Change in osmo-sysmon[master]: Depend on liboping 1.7.0 instead of 1.9.0
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13344 ) Change subject: Depend on liboping 1.7.0 instead of 1.9.0 .. Depend on liboping 1.7.0 instead of 1.9.0 Debian8 provides 1.7.0. Let's depend on it so we can build packages for debian8. Change-Id: Idba4494102d48d125bcd215dd0d3fdf42bbd409e --- M configure.ac M debian/control 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified Harald Welte: Looks good to me, approved diff --git a/configure.ac b/configure.ac index 44a040c..5242b6a 100644 --- a/configure.ac +++ b/configure.ac @@ -45,7 +45,8 @@ PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 0.4.0) PKG_CHECK_MODULES(LIBMNL, libmnl) dnl FIXME: bump to 1.10.0 once it's available on build slaves and remove workaround from osysmon_ping.c -PKG_CHECK_MODULES(LIBOPING, liboping >= 1.9.0) +dnl FIXME: debian8 provides 1.7.0, debian9 provides 1.9.0 +PKG_CHECK_MODULES(LIBOPING, liboping >= 1.7.0) dnl checks for header files AC_HEADER_STDC diff --git a/debian/control b/debian/control index 9439c3b..fc8aed7 100644 --- a/debian/control +++ b/debian/control @@ -11,7 +11,7 @@ pkg-config, libtalloc-dev, libmnl-dev, - liboping-dev (>= 1.9.0), + liboping-dev (>= 1.7.0), libosmocore-dev (>= 1.0.1), libosmo-netif-dev (>= 0.4.0), Standards-Version: 3.9.8 -- To view, visit https://gerrit.osmocom.org/13344 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Idba4494102d48d125bcd215dd0d3fdf42bbd409e Gerrit-Change-Number: 13344 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102)
Change in osmo-sysmon[master]: Depend on liboping 1.7.0 instead of 1.9.0
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13344 ) Change subject: Depend on liboping 1.7.0 instead of 1.9.0 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13344 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idba4494102d48d125bcd215dd0d3fdf42bbd409e Gerrit-Change-Number: 13344 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Comment-Date: Thu, 21 Mar 2019 16:00:32 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-ttcn3-hacks[master]: BTS: use PCU-related test cases as version string
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/13305 )
Change subject: BTS: use PCU-related test cases as version string
..
BTS: use PCU-related test cases as version string
When running PCU-related tests against BTS use name of the test as a PCU
version string sent from TTCN-3 code. This makes it easier to separate
OsmoBTS log output related to different test cases.
Change-Id: I9ef9e46061ef116529bdea196050f914804615b3
---
M bts/BTS_Tests.ttcn
1 file changed, 35 insertions(+), 18 deletions(-)
Approvals:
Harald Welte: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 86d43fe..e617323 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -2723,33 +2723,43 @@
}
}
+private function f_init_pcu_test() runs on test_CT {
+ f_init();
+ PCU.send(t_SD_PCUIF(g_pcu_conn_id, ts_PCUIF_TXT_IND(0, PCU_VERSION,
testcasename(;
+}
+
/* PDCH activation via PCU socket; check for presence of RTS.req */
testcase TC_pcu_act_req() runs on test_CT {
- f_init();
+ f_init_pcu_test();
+
f_TC_pcu_act_req(0, 0, 7, true);
}
/* PDCH activation via PCU socket on non-PDCU timeslot */
testcase TC_pcu_act_req_wrong_ts() runs on test_CT {
- f_init();
+ f_init_pcu_test();
+
f_TC_pcu_act_req(0, 0, 1, false);
}
/* PDCH activation via PCU socket on wrong BTS */
testcase TC_pcu_act_req_wrong_bts() runs on test_CT {
- f_init();
+ f_init_pcu_test();
+
f_TC_pcu_act_req(23, 0, 7, false);
}
/* PDCH activation via PCU socket on wrong TRX */
testcase TC_pcu_act_req_wrong_trx() runs on test_CT {
- f_init();
+ f_init_pcu_test();
+
f_TC_pcu_act_req(0, 23, 7, false);
}
/* PDCH deactivation via PCU socket; check for absence of RTS.req */
testcase TC_pcu_deact_req() runs on test_CT {
- f_init();
+ f_init_pcu_test();
+
/* Activate PDCH */
f_TC_pcu_act_req(0, 0, 7, true);
f_sleep(1.0);
@@ -2759,7 +2769,8 @@
/* Attempt to deactivate a PDCH on a non-PDCH timeslot */
testcase TC_pcu_deact_req_wrong_ts() runs on test_CT {
- f_init();
+ f_init_pcu_test();
+
f_TC_pcu_deact_req(0, 0, 1);
}
@@ -2768,11 +2779,11 @@
const octetstring si13 := '00010203040506070909'O;
var PCUIF_send_data sd;
timer T:= 3.0;
- f_init();
+ f_init_pcu_test();
/* Set SI13 via RSL */
f_rsl_bcch_fill_raw(RSL_SYSTEM_INFO_13, si13);
- PCU.send(t_SD_PCUIF(g_pcu_conn_id, ts_PCUIF_TXT_IND(0, PCU_VERSION,
"BTS_Test v23")));
+
T.start;
alt {
[] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_DATA_IND(0, 0, 0, ?,
PCU_IF_SAPI_BCCH))) -> value sd {
@@ -2824,7 +2835,8 @@
/* Send DATA.req on invalid BTS */
testcase TC_pcu_data_req_wrong_bts() runs on test_CT {
- f_init();
+ f_init_pcu_test();
+
f_TC_pcu_act_req(0, 0, 7, true);
f_pcu_data_req(23, 0, 7, 0, 0, PCU_IF_SAPI_PDTCH, c_PCU_DATA);
/* FIXME: how to check this wasn't actually sent and didn't crash BTS?
*/
@@ -2833,7 +2845,8 @@
/* Send DATA.req on invalid TRX */
testcase TC_pcu_data_req_wrong_trx() runs on test_CT {
- f_init();
+ f_init_pcu_test();
+
f_TC_pcu_act_req(0, 0, 7, true);
f_pcu_data_req(0, 100, 7, 0, 0, PCU_IF_SAPI_PDTCH, c_PCU_DATA);
/* FIXME: how to check this wasn't actually sent and didn't crash BTS?
*/
@@ -2842,7 +2855,8 @@
/* Send DATA.req on invalid timeslot */
testcase TC_pcu_data_req_wrong_ts() runs on test_CT {
- f_init();
+ f_init_pcu_test();
+
f_TC_pcu_act_req(0, 0, 7, true);
f_pcu_data_req(0, 0, 70, 0, 0, PCU_IF_SAPI_PDTCH, c_PCU_DATA);
/* FIXME: how to check this wasn't actually sent and didn't crash BTS?
*/
@@ -2851,14 +2865,16 @@
/* Send DATA.req on timeslot that hasn't been activated */
testcase TC_pcu_data_req_ts_inactive() runs on test_CT {
- f_init();
+ f_init_pcu_test();
+
f_pcu_data_req(0, 0, 7, 0, 0, PCU_IF_SAPI_PDTCH, c_PCU_DATA);
/* FIXME: how to check this wasn't actually sent and didn't crash BTS?
*/
f_sleep(2.0);
}
testcase TC_pcu_data_req_pdtch() runs on test_CT {
- f_init();
+ f_init_pcu_test();
+
f_TC_pcu_act_req(0, 0, 7, true);
f_pcu_wait_rts_and_data_req(0, 0, 7, PCU_IF_SAPI_PDTCH, c_PCU_DATA);
/* FIXME: how to check this was actually sent */
@@ -2866,7 +2882,8 @@
}
testcase TC_pcu_data_req_ptcch() runs on test_CT {
- f_init();
+ f_init_pcu_test();
+
f_TC_pcu_act_req(0, 0, 7, true);
f_pcu_wait_rts_and_data_req(0, 0, 7, PCU_IF_SAPI_PTCCH, c_PCU_DATA);
/* FIXME: how to check this was actually sent */
@@ -2876,7 +2893,7 @@
/* Send AGCH from PCU; check it appears on Um side */
testcase TC_pcu_data_req_agch() runs on test_CT {
timer
Change in osmo-msc[master]: a_iface_bssap: check bssmap length field
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13307 ) Change subject: a_iface_bssap: check bssmap length field .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13307 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b89dd5a66ec83b03860b58b6b8eb58007f433a4 Gerrit-Change-Number: 13307 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Thu, 21 Mar 2019 16:00:10 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-sysmon[master]: debian: Add missing libmnl-dev dependency
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13343 ) Change subject: debian: Add missing libmnl-dev dependency .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13343 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1157b1f0edabac16d664c2d4ad2250d3802dcc60 Gerrit-Change-Number: 13343 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Comment-Date: Thu, 21 Mar 2019 16:00:19 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-sysmon[master]: debian: Add missing libmnl-dev dependency
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13343 ) Change subject: debian: Add missing libmnl-dev dependency .. debian: Add missing libmnl-dev dependency Change-Id: I1157b1f0edabac16d664c2d4ad2250d3802dcc60 --- M debian/control 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified Harald Welte: Looks good to me, approved diff --git a/debian/control b/debian/control index 651ecce..9439c3b 100644 --- a/debian/control +++ b/debian/control @@ -10,6 +10,7 @@ libtool, pkg-config, libtalloc-dev, + libmnl-dev, liboping-dev (>= 1.9.0), libosmocore-dev (>= 1.0.1), libosmo-netif-dev (>= 0.4.0), -- To view, visit https://gerrit.osmocom.org/13343 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1157b1f0edabac16d664c2d4ad2250d3802dcc60 Gerrit-Change-Number: 13343 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102)
Change in osmo-msc[master]: a_iface_bssap: add context information to log output
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13319 ) Change subject: a_iface_bssap: add context information to log output .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/13319/2/src/libmsc/a_iface_bssap.c File src/libmsc/a_iface_bssap.c: https://gerrit.osmocom.org/#/c/13319/2/src/libmsc/a_iface_bssap.c@167 PS2, Line 167: /* Confirm that we managed to get the reset ack message > That seems redundant: it'll be printed as part of the prefix anyway. the point here was that the %s / osmo_sccp_addr_name() is redundant. Not the enitre log line. So please keep the log line, but remove the %s + osmo_sccp_addr_name from it. -- To view, visit https://gerrit.osmocom.org/13319 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I704954edc8677688fc7cccd2b23d2aff958ebf32 Gerrit-Change-Number: 13319 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder (102) Gerrit-CC: Harald Welte Gerrit-CC: Max Gerrit-Comment-Date: Thu, 21 Mar 2019 15:59:35 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in osmocom-bb[master]: trxcon: update trx_udp_open()
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13367
Change subject: trxcon: update trx_udp_open()
..
trxcon: update trx_udp_open()
* explicitly log created socket type (ctrl vs data)
* log local/remote ip/port
* log detailed per-socket error in case of failure
* internalize callback and osmo_fd selection based on socket type
Change-Id: I33b01879f6ea468941e5dab5b46492be8fe5730d
---
M src/host/trxcon/trx_if.c
1 file changed, 25 insertions(+), 22 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/67/13367/1
diff --git a/src/host/trxcon/trx_if.c b/src/host/trxcon/trx_if.c
index 4c10da6..9b7a5d6 100644
--- a/src/host/trxcon/trx_if.c
+++ b/src/host/trxcon/trx_if.c
@@ -83,23 +83,6 @@
.event_names = trx_evt_names,
};
-static int trx_udp_open(void *priv, struct osmo_fd *ofd, const char
*host_local,
- uint16_t port_local, const char *host_remote, uint16_t port_remote,
- int (*cb)(struct osmo_fd *fd, unsigned int what))
-{
- int rc;
-
- ofd->data = priv;
- ofd->fd = -1;
- ofd->cb = cb;
-
- /* Init UDP Connection */
- rc = osmo_sock_init2_ofd(ofd, AF_UNSPEC, SOCK_DGRAM, 0, host_local,
port_local,
-host_remote, port_remote,
-OSMO_SOCK_F_BIND | OSMO_SOCK_F_CONNECT);
- return rc;
-}
-
static void trx_udp_close(struct osmo_fd *ofd)
{
if (ofd->fd > 0) {
@@ -626,6 +609,29 @@
return 0;
}
+static int trx_udp_open(struct trx_instance *trx, bool is_ctrl, const char
*host_local,
+ uint16_t port_local, const char *host_remote, uint16_t
port_remote)
+{
+ int rc;
+ struct osmo_fd *ofd = is_ctrl ? &trx->trx_ofd_ctrl : &trx->trx_ofd_data;
+
+ ofd->data = trx;
+ ofd->fd = -1;
+ ofd->cb = is_ctrl ? trx_ctrl_read_cb : trx_data_rx_cb;
+
+ /* Init UDP Connection */
+ rc = osmo_sock_init2_ofd(ofd, AF_UNSPEC, SOCK_DGRAM, 0, host_local,
port_local,
+host_remote, port_remote,
+OSMO_SOCK_F_BIND | OSMO_SOCK_F_CONNECT);
+ if (rc < 0)
+ LOGP(DTRX, LOGL_ERROR, "Failed to prepare %s UDP socket
r=%s:%u<->l=%s:%u\n",
+is_ctrl ? "CTRL" : "DATA", host_remote, port_remote,
host_local, port_local);
+ else
+ LOGP(DTRX, LOGL_NOTICE, "%s UDP socket %s ready\n", is_ctrl ?
"CTRL" : "DATA", osmo_sock_get_name2(rc));
+
+ return rc;
+}
+
/* Init TRX interface (TRXC, TRXD sockets and FSM) */
struct trx_instance *trx_if_open(void *tall_ctx,
const char *local_host, const char *remote_host,
@@ -658,20 +664,17 @@
INIT_LLIST_HEAD(&trx->trx_ctrl_list);
/* Open sockets */
- rc = trx_udp_open(trx, &trx->trx_ofd_ctrl, local_host,
- base_port + 101, remote_host, base_port + 1, trx_ctrl_read_cb);
+ rc = trx_udp_open(trx, true, local_host, base_port + 101, remote_host,
base_port + 1);
if (rc < 0)
goto udp_error;
- rc = trx_udp_open(trx, &trx->trx_ofd_data, local_host,
- base_port + 102, remote_host, base_port + 2, trx_data_rx_cb);
+ rc = trx_udp_open(trx, false, local_host, base_port + 102, remote_host,
base_port + 2);
if (rc < 0)
goto udp_error;
return trx;
udp_error:
- LOGP(DTRX, LOGL_ERROR, "Couldn't establish UDP connection\n");
osmo_fsm_inst_free(trx->fsm);
talloc_free(trx);
return NULL;
--
To view, visit https://gerrit.osmocom.org/13367
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I33b01879f6ea468941e5dab5b46492be8fe5730d
Gerrit-Change-Number: 13367
Gerrit-PatchSet: 1
Gerrit-Owner: Max
Change in osmocom-bb[master]: trxcon: log FBSB timer events
Hello Vadim Yanitskiy, Harald Welte, osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13364 to look at the new patch set (#2). Change subject: trxcon: log FBSB timer events .. trxcon: log FBSB timer events Change-Id: I0168d43951494f4010df891f391ddad4b57493d7 --- M src/host/trxcon/l1ctl.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/64/13364/2 -- To view, visit https://gerrit.osmocom.org/13364 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0168d43951494f4010df891f391ddad4b57493d7 Gerrit-Change-Number: 13364 Gerrit-PatchSet: 2 Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: osmith
