Change in osmo-sgsn[master]: gbproxy: Add SGSN NRI configuration
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21705 ) Change subject: gbproxy: Add SGSN NRI configuration .. Patch Set 4: Code-Review-1 FYI: daniel and I had a phone call some days ago, from my memory we agreed that the 'sgsn' would be come a first-class object (with name, linked into a global list in the gbproxy_config) and that we won't be piggy-backing the NRI bits into the NSE. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21705 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Id67592aa7712e5e04e7264b2fb8f26d57eb7e69e Gerrit-Change-Number: 21705 Gerrit-PatchSet: 4 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Fri, 18 Dec 2020 10:39:01 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sgsn[master]: gbproxy: Add "show gbproxy cell ..." VTY command
Hello Jenkins Builder, fixeria, daniel, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21692 to look at the new patch set (#8). Change subject: gbproxy: Add "show gbproxy cell ..." VTY command .. gbproxy: Add "show gbproxy cell ..." VTY command This allows the user to inspect CELL related gb-proxy state. Change-Id: Iad1e8bbc358df9a3b3392404a70445a169dfebd5 --- M src/gbproxy/gb_proxy_vty.c 1 file changed, 42 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/92/21692/8 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21692 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iad1e8bbc358df9a3b3392404a70445a169dfebd5 Gerrit-Change-Number: 21692 Gerrit-PatchSet: 8 Gerrit-Owner: laforge Gerrit-Assignee: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-MessageType: newpatchset
Change in osmo-sgsn[master]: gbproxy: Add "show gbproxy cell ..." VTY command
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21692 ) Change subject: gbproxy: Add "show gbproxy cell ..." VTY command .. Patch Set 8: (1 comment) https://gerrit.osmocom.org/c/osmo-sgsn/+/21692/7/src/gbproxy/gb_proxy_vty.c File src/gbproxy/gb_proxy_vty.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/21692/7/src/gbproxy/gb_proxy_vty.c@251 PS7, Line 251: DEFUN(show_gbproxy_cell, show_gbproxy_cell_cmd, "show gbproxy cell [stats]", > This looks wrong to me: you have 4 words in the command vector, and 5 > docstrings? nice catch. Indeed I was first thinking of adding an additional qualifier like "all" which we can then later exntend with some other qualifier like "bvci ..." or "cell-id ..." But I guess we can do the same without that "all". Will fix. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21692 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iad1e8bbc358df9a3b3392404a70445a169dfebd5 Gerrit-Change-Number: 21692 Gerrit-PatchSet: 8 Gerrit-Owner: laforge Gerrit-Assignee: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Fri, 18 Dec 2020 10:42:09 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment
Change in osmo-sgsn[master]: gbproxy: Add "show gbproxy cell ..." VTY command
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21692 ) Change subject: gbproxy: Add "show gbproxy cell ..." VTY command .. Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21692 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iad1e8bbc358df9a3b3392404a70445a169dfebd5 Gerrit-Change-Number: 21692 Gerrit-PatchSet: 8 Gerrit-Owner: laforge Gerrit-Assignee: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Fri, 18 Dec 2020 10:42:43 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ci[master]: Add master + gerrit job for osmo-e1-hardware
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/21764 ) Change subject: Add master + gerrit job for osmo-e1-hardware .. Patch Set 3: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/21764 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I02295e157f909bca985c1919a7828da0554ee1ef Gerrit-Change-Number: 21764 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 18 Dec 2020 10:43:12 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ci[master]: Add master + gerrit job for osmo-e1-hardware
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ci/+/21764 )
Change subject: Add master + gerrit job for osmo-e1-hardware
..
Add master + gerrit job for osmo-e1-hardware
Change-Id: I02295e157f909bca985c1919a7828da0554ee1ef
---
M jobs/gerrit-verifications.yml
M jobs/master-builds.yml
2 files changed, 46 insertions(+), 0 deletions(-)
Approvals:
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved; Verified
diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml
index 8d3efc7..8d3e2cd 100644
--- a/jobs/gerrit-verifications.yml
+++ b/jobs/gerrit-verifications.yml
@@ -117,6 +117,26 @@
gerrit_project: 'erlang/{repos}'
cmd: '{docker_run} {docker_img_erlang} /build/contrib/jenkins.sh'
+ - osmo-e1-hardware:
+ docker_run: |
+ARTIFACT_STORE="$HOME/jenkins_build_artifact_store"
+mkdir -p "$ARTIFACT_STORE"
+docker run --rm=true \
+ --cap-add SYS_PTRACE \
+ -e ARTIFACT_STORE=/artifact_store \
+ -e ASCIIDOC_WARNINGS_CHECK="1" \
+ -e HOME=/build \
+ -e JOB_NAME="$JOB_NAME" \
+ -e MAKE=make \
+ -e OSMOPY_DEBUG_TCP_SOCKETS="1" \
+ -e PARALLEL_MAKE="$PARALLEL_MAKE" \
+ -e WITH_MANUALS="1" \
+ -w /build -i -u build \
+ -v "$PWD:/build" -v "$HOME/bin:/build_bin" \
+ -v "$ARTIFACT_STORE:/artifact_store" \
+ docker_img: 'registry.osmocom.org/$USER/fpga-build'
+ cmd: 'docker pull {docker_img} && {docker_run} {docker_img}
/build/contrib/jenkins.sh'
+
- osmo-ggsn:
a1_name: GTP
a1: !!python/tuple [--enable-gtp-linux,--disable-gtp-linux]
@@ -309,6 +329,8 @@
choosing-strategy: gerrit
wipe-workspace: false
skip-tag: true
+ submodule:
+ recursive: true
triggers:
- gerrit:
diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml
index a7f4f30..566f1bf 100644
--- a/jobs/master-builds.yml
+++ b/jobs/master-builds.yml
@@ -197,6 +197,28 @@
concurrent: false
cmd: 'PUBLISH=1 ASCIIDOC_WARNINGS_CHECK=1
./contrib/jenkins_bts_model.sh "$BTS_MODEL"'
+ - osmo-e1-hardware:
+ docker_run: |
+ARTIFACT_STORE="$HOME/jenkins_build_artifact_store"
+mkdir -p "$ARTIFACT_STORE"
+docker run --rm=true \
+ --cap-add SYS_PTRACE \
+ -e ARTIFACT_STORE=/artifact_store \
+ -e ASCIIDOC_WARNINGS_CHECK="1" \
+ -e HOME=/build \
+ -e JOB_NAME="$JOB_NAME" \
+ -e MAKE=make \
+ -e OSMOPY_DEBUG_TCP_SOCKETS="1" \
+ -e PARALLEL_MAKE="$PARALLEL_MAKE" \
+ -e PUBLISH="1" \
+ -e WITH_MANUALS="1" \
+ -w /build -i -u build \
+ -v "$PWD:/build" -v "$HOME/bin:/build_bin" \
+ -v "$ARTIFACT_STORE:/artifact_store" \
+ -v "$HOME/.ssh:/home/build/.ssh:ro" \
+ docker_img: 'registry.osmocom.org/$USER/fpga-build'
+ cmd: 'docker pull {docker_img} && {docker_run} {docker_img}
/build/contrib/jenkins.sh --publish'
+
- osmo-fl2k
- osmo-ggsn:
a1_name: GTP
@@ -397,6 +419,8 @@
name:
wipe-workspace: false
skip-tag: true
+ submodule:
+ recursive: true
triggers:
- pollscm:
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/21764
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I02295e157f909bca985c1919a7828da0554ee1ef
Gerrit-Change-Number: 21764
Gerrit-PatchSet: 3
Gerrit-Owner: laforge
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-pcu[master]: Convert GprsMS and helpers classes to C
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/21748 ) Change subject: Convert GprsMS and helpers classes to C .. Patch Set 6: Code-Review+1 it's of course a masive change and hard to review (no matter how you do it). I presume you have executed all available tests against this without any regressions and did some manual testing, too? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21748 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I0b50e3367aaad9dcada76da97b438e452c8b230c Gerrit-Change-Number: 21748 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 18 Dec 2020 10:47:42 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in pysim[master]: Readme.md: update apt-get invocation for python3 dep.
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/21680 ) Change subject: Readme.md: update apt-get invocation for python3 dep. .. Readme.md: update apt-get invocation for python3 dep. Change-Id: Icb09204d6bc0d89fa8b793ff6df773cdefc19c5b --- M README.md 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/README.md b/README.md index 7074ffa..105ca3f 100644 --- a/README.md +++ b/README.md @@ -40,8 +40,8 @@ Example for Debian: - apt-get install python-pyscard python-serial python-pip - pip install pytlv + apt-get install python3-pyscard python3-serial python3-pip + pip3 install pytlv Mailing List -- To view, visit https://gerrit.osmocom.org/c/pysim/+/21680 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icb09204d6bc0d89fa8b793ff6df773cdefc19c5b Gerrit-Change-Number: 21680 Gerrit-PatchSet: 1 Gerrit-Owner: roh Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in pysim[master]: Readme.md: update apt-get invocation for python3 dep.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/21680 ) Change subject: Readme.md: update apt-get invocation for python3 dep. .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/21680 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icb09204d6bc0d89fa8b793ff6df773cdefc19c5b Gerrit-Change-Number: 21680 Gerrit-PatchSet: 1 Gerrit-Owner: roh Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 18 Dec 2020 10:49:28 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: vty: add commands for MS/BS Power Control parameters
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21685 ) Change subject: vty: add commands for MS/BS Power Control parameters .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21685 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ifd6ea29c3b9dbaccf92856131d5fb2e352b84eb2 Gerrit-Change-Number: 21685 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 18 Dec 2020 10:50:37 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: PCU_Tests_SNS: improve SGSN originated BVC-RESETs
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20923 ) Change subject: PCU_Tests_SNS: improve SGSN originated BVC-RESETs .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20923 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id681749d75073c1d50a4b0a2e86f0a2dd0955b45 Gerrit-Change-Number: 20923 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 18 Dec 2020 10:52:08 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: PCU_Tests_SNS: improve SGSN originated BVC-RESETs
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20923 )
Change subject: PCU_Tests_SNS: improve SGSN originated BVC-RESETs
..
PCU_Tests_SNS: improve SGSN originated BVC-RESETs
The BVC-RESETs are a little bit more complicated. The PCU will send
a BVC-RESET after the NSE become available.
Ensure the RESET is received and ignored so there is no race condition
if both sides send a BVC-RESET at the same time.
The test case TC_sns_1c1u_so_bvc_reset is still failing because the PCU can't
handle BVC-RESETs properly (both PTP and signalling).
Change-Id: Id681749d75073c1d50a4b0a2e86f0a2dd0955b45
---
M library/RAW_NS.ttcn
M pcu/PCU_Tests_SNS.ttcn
2 files changed, 32 insertions(+), 6 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/library/RAW_NS.ttcn b/library/RAW_NS.ttcn
index 8540f38..7f7b6c4 100644
--- a/library/RAW_NS.ttcn
+++ b/library/RAW_NS.ttcn
@@ -68,16 +68,23 @@
}
-function f_ns_exp(template PDU_NS exp_rx, integer idx := 0) runs on RAW_NS_CT
return PDU_NS {
+public altstep ax_rx_fail_on_any_ns(integer idx := 0) runs on RAW_NS_CT {
var NS_RecvFrom nrf;
- log("f_ns_exp() expecting ", exp_rx);
- alt {
- [] NSCP[idx].receive(t_NS_RecvFrom(exp_rx)) -> value nrf { }
[] NSCP[idx].receive(t_NS_RecvFrom(?)) -> value nrf {
setverdict(fail, "Received unexpected NS: ", nrf);
mtc.stop;
}
+}
+
+function f_ns_exp(template PDU_NS exp_rx, integer idx := 0) runs on RAW_NS_CT
return PDU_NS {
+ var NS_RecvFrom nrf;
+ log("f_ns_exp() expecting ", exp_rx);
+ /* last activated altstep has the lowest priority */
+ var default d := activate(ax_rx_fail_on_any_ns());
+ alt {
+ [] NSCP[idx].receive(t_NS_RecvFrom(exp_rx)) -> value nrf { }
}
+ deactivate(d);
return nrf.msg;
}
diff --git a/pcu/PCU_Tests_SNS.ttcn b/pcu/PCU_Tests_SNS.ttcn
index aed363b..ea78761 100644
--- a/pcu/PCU_Tests_SNS.ttcn
+++ b/pcu/PCU_Tests_SNS.ttcn
@@ -297,11 +297,21 @@
f_outgoing_ns_alive(1);
if (sgsn_originated_reset) {
+ /* Expect BVC-RESET, but ignore it to prevent a race condition
of BVC RESETs */
+ var template PDU_NS pdu := tr_NS_UNITDATA(t_SduCtrlB, 0,
decmatch tr_BVC_RESET(?, 0, omit));
+ f_ns_exp(pdu);
+ /* SGSN originated BVC-RESET on an uninitialized signalling BVC
*/
f_tx_bvc_reset_rx_ack(0, omit, omit);
+
+ /* Expect BVC-RESET PTP BVC, but ignore it to prevent a race
condition of BVC RESETs */
+ pdu := tr_NS_UNITDATA(t_SduCtrlB, 0, decmatch tr_BVC_RESET(?,
mp_gb_cfg.bvc[0].bvci, mp_gb_cfg.bvc[0].cell_id));
+ f_ns_exp(pdu);
+ /* SGSN originated BVC-RESET on an uninitialized PTP BVC */
f_tx_bvc_reset_rx_ack(mp_gb_cfg.bvc[0].bvci, omit,
mp_gb_cfg.bvc[0].cell_id);
} else {
- /* Expect BVC-RESET for signaling (0) and ptp BVCI */
+ /* Expect BVC-RESET for signaling BVCI=0 */
as_rx_bvc_reset_tx_ack(0, omit, omit, oneshot := true);
+ /* Expect BVC-RESET from the PCU on PTP BVC */
as_rx_bvc_reset_tx_ack(mp_gb_cfg.bvc[0].bvci,
mp_gb_cfg.bvc[0].cell_id, omit, oneshot := true);
}
/* Expect UNBLOCK for ptp BVCI on signaling NS-VC (idx==0) */
@@ -347,11 +357,20 @@
f_outgoing_ns_alive_no_ack(idx := 0);
if (sgsn_originated_reset) {
+ /* Expect BVC-RESET, but ignore it to prevent a race condition
of BVC RESETs */
+ var template PDU_NS pdu := tr_NS_UNITDATA(t_SduCtrlB, 0,
decmatch tr_BVC_RESET(?, 0, omit));
+ f_ns_exp(pdu, idx := 1);
+ /* SGSN originated BVC-RESET on an uninitialized sign BVC */
f_tx_bvc_reset_rx_ack(0, omit, omit, idx := 1);
+
+ /* Expect BVC-RESET PTP BVC, but ignore it to prevent a race
condition of BVC RESETs */
+ pdu := tr_NS_UNITDATA(t_SduCtrlB, 0, decmatch tr_BVC_RESET(?,
mp_gb_cfg.bvc[0].bvci, mp_gb_cfg.bvc[0].cell_id));
+ f_ns_exp(pdu, idx := 1);
f_tx_bvc_reset_rx_ack(mp_gb_cfg.bvc[0].bvci, omit,
mp_gb_cfg.bvc[0].cell_id, idx := 1);
} else {
- /* Expect BVC-RESET for signaling BVCI=0 and ptp BVCI */
+ /* Expect BVC-RESET for signaling BVCI=0 */
as_rx_bvc_reset_tx_ack(0, omit, omit, oneshot := true, idx :=
1);
+ /* Expect BVC-RESET from the PCU on PTP BVC */
as_rx_bvc_reset_tx_ack(mp_gb_cfg.bvc[0].bvci,
mp_gb_cfg.bvc[0].cell_id, omit, oneshot := true, idx := 1);
}
/* Expect UNBLOCK for ptp BVCI on signaling NS-VC (idx==1) */
--
To view, visit https://gerrit.osmocom.or
Change in libosmocore[master]: gprs_ns2: fr: fix crash when frame relay interface doesn't exists
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21750 ) Change subject: gprs_ns2: fr: fix crash when frame relay interface doesn't exists .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21750 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I815b6ef5c3df780ac94461a05975a2b70898b01e Gerrit-Change-Number: 21750 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 18 Dec 2020 10:52:35 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gprs_ns2: fr: fix crash when frame relay interface doesn't exists
laforge has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/21750 )
Change subject: gprs_ns2: fr: fix crash when frame relay interface doesn't
exists
..
gprs_ns2: fr: fix crash when frame relay interface doesn't exists
When a frame relay interface doesn't exist gprs_ns2_fr_bind() would
detect this but still return a success.
Change-Id: I815b6ef5c3df780ac94461a05975a2b70898b01e
---
M src/gb/gprs_ns2_fr.c
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/gb/gprs_ns2_fr.c b/src/gb/gprs_ns2_fr.c
index 8147f66..fc6f166 100644
--- a/src/gb/gprs_ns2_fr.c
+++ b/src/gb/gprs_ns2_fr.c
@@ -514,8 +514,8 @@
fr_link->tx_cb_data = bind;
priv->link = fr_link;
- priv->ifindex = devname2ifindex(netif);
- if (priv->ifindex < 0) {
+ priv->ifindex = rc = devname2ifindex(netif);
+ if (rc < 0) {
LOGP(DLNS, LOGL_ERROR, "Can not get interface index for
interface %s\n", netif);
goto err_fr;
}
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21750
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I815b6ef5c3df780ac94461a05975a2b70898b01e
Gerrit-Change-Number: 21750
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in libosmocore[master]: gprs_ns2: fr: setup the device to correct FR/LMI settings
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21752 ) Change subject: gprs_ns2: fr: setup the device to correct FR/LMI settings .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/21752/3/src/gb/gprs_ns2_fr.c File src/gb/gprs_ns2_fr.c: https://gerrit.osmocom.org/c/libosmocore/+/21752/3/src/gb/gprs_ns2_fr.c@449 PS3, Line 449: st as we just saw some fall-out from other strncpy (instead of osmo_strlcpy), it might make sense to go for the latter straight away? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21752 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I04786d2b864860b08c2e1afdb199470f4b80cc3b Gerrit-Change-Number: 21752 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 18 Dec 2020 10:56:45 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmocore[master]: fix strncpy bug in gprs_ns2_fr_bind()
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21780 ) Change subject: fix strncpy bug in gprs_ns2_fr_bind() .. Patch Set 1: @lynxis, this is what I referred to in your fr-ioctl related patch -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21780 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id53e940c7a39ab154966548f4173a179c5bc9151 Gerrit-Change-Number: 21780 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Fri, 18 Dec 2020 11:11:57 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmocore[master]: gprs_ns2_fr.c: compiler error: replace strncpy() with OSMO_STRLCPY_AR...
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21779 ) Change subject: gprs_ns2_fr.c: compiler error: replace strncpy() with OSMO_STRLCPY_ARRAY() .. gprs_ns2_fr.c: compiler error: replace strncpy() with OSMO_STRLCPY_ARRAY() My gcc (Debian 8.3.0-6) 8.3.0 refuses to build this strncpy() use: it issues the buffer length as n and thus potentially fails to account for the terminating nul. The line after that fixes the problem, so it's not an actual bug. Anyway, we have a policy to never use strncpy(), and have osmo_strlcpy() and OSMO_STRLCPY_ARRAY() for this. This strncpy() was introduced last month during first addition of gprs_ns2_fr.c: commit 841817ec52186029ca01f0c082ed84f2dc5ffcc5 ns2: add support for frame relay Change-Id Id3b49f93d33c271f77cd9c9db03cde6b727a4d30 Change-Id: I494a6fb7ccd7938a39e8956f73ec4282da38d7fb --- M src/gb/gprs_ns2_fr.c 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/gb/gprs_ns2_fr.c b/src/gb/gprs_ns2_fr.c index fc6f166..1ff80ed 100644 --- a/src/gb/gprs_ns2_fr.c +++ b/src/gb/gprs_ns2_fr.c @@ -296,8 +296,7 @@ memset(&ifr, 0, sizeof(ifr)); - strncpy(ifr.ifr_name, ifname, sizeof(ifr.ifr_name)); - ifr.ifr_name[sizeof(ifr.ifr_name)-1] = 0; + OSMO_STRLCPY_ARRAY(ifr.ifr_name, ifname); rc = ioctl(sk, SIOCGIFINDEX, &ifr); close(sk); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21779 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I494a6fb7ccd7938a39e8956f73ec4282da38d7fb Gerrit-Change-Number: 21779 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in libosmocore[master]: fix strncpy bug in gprs_ns2_fr_bind()
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21780 ) Change subject: fix strncpy bug in gprs_ns2_fr_bind() .. fix strncpy bug in gprs_ns2_fr_bind() This use of strncpy() fails to account for the terminating nul character. Use OSMO_STRLCPY_ARRAY() instead. (Interestingly my compiler doesn't complain about this one, though it failed on another similar use of strncpy().) Change-Id: Id53e940c7a39ab154966548f4173a179c5bc9151 --- M src/gb/gprs_ns2_fr.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/gb/gprs_ns2_fr.c b/src/gb/gprs_ns2_fr.c index 1ff80ed..782e5a3 100644 --- a/src/gb/gprs_ns2_fr.c +++ b/src/gb/gprs_ns2_fr.c @@ -497,7 +497,7 @@ rc = -EINVAL; goto err_priv; } - strncpy(priv->netif, netif, sizeof(priv->netif)); + OSMO_STRLCPY_ARRAY(priv->netif, netif); if (result) *result = bind; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21780 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id53e940c7a39ab154966548f4173a179c5bc9151 Gerrit-Change-Number: 21780 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in docker-playground[master]: Introduce osmo-ran docker image set up
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/21263 ) Change subject: Introduce osmo-ran docker image set up .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/21263 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If5d22e9fa818310cbb4adc34bd7aceb4416ec969 Gerrit-Change-Number: 21263 Gerrit-PatchSet: 7 Gerrit-Owner: pespin Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 18 Dec 2020 11:45:10 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: Convert GprsMS and helpers classes to C
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/21748 ) Change subject: Convert GprsMS and helpers classes to C .. Patch Set 6: > Patch Set 6: Code-Review+1 > > it's of course a masive change and hard to review (no matter how you do it). > > I presume you have executed all available tests against this without any > regressions and did some manual testing, too? Yes, I wrote exactly that a few comments above :) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21748 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I0b50e3367aaad9dcada76da97b438e452c8b230c Gerrit-Change-Number: 21748 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 18 Dec 2020 11:57:10 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-sgsn[master]: gbproxy: Add "show gbproxy cell ..." VTY command
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21692 ) Change subject: gbproxy: Add "show gbproxy cell ..." VTY command .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21692 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iad1e8bbc358df9a3b3392404a70445a169dfebd5 Gerrit-Change-Number: 21692 Gerrit-PatchSet: 8 Gerrit-Owner: laforge Gerrit-Assignee: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Fri, 18 Dec 2020 12:11:25 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: cosmetic: bsc: Fix tab<->space indent
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21785 )
Change subject: cosmetic: bsc: Fix tab<->space indent
..
cosmetic: bsc: Fix tab<->space indent
Change-Id: I8b8670fb820d258a5a56f3fdb007f7e59bfd374f
---
M bsc/BSC_Tests.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/85/21785/1
diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index 2695ce2..175b820 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -2331,7 +2331,7 @@
private function f_tc_si2quater_n_earfcns(integer n) runs on test_CT
{
var template SystemInformationConfig sic :=
SystemInformationConfig_default;
-sic.si2quater := f_tr_si2quater_earfcns(n);
+ sic.si2quater := f_tr_si2quater_earfcns(n);
var template CellSelIndValue cells := f_tr_rr_chan_rel_earfcns(n);
f_test_si2quater(n, sic, cells);
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21785
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8b8670fb820d258a5a56f3fdb007f7e59bfd374f
Gerrit-Change-Number: 21785
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-MessageType: newchange
Change in osmo-bsc[master]: power_control: add new structures and default parameters
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bsc/+/21786 )
Change subject: power_control: add new structures and default parameters
..
power_control: add new structures and default parameters
Change-Id: I7fb8ccb997490b40a061d09c241359aaabc37c4a
Related: SYS#4918
---
M include/osmocom/bsc/bts.h
M include/osmocom/bsc/gsm_data.h
M src/osmo-bsc/bts.c
M src/osmo-bsc/gsm_data.c
4 files changed, 142 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/86/21786/1
diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h
index d2f1307..fc5ec40 100644
--- a/include/osmocom/bsc/bts.h
+++ b/include/osmocom/bsc/bts.h
@@ -470,6 +470,10 @@
/* osmocom specific FACCH/SACCH repetition mode flags set by VTY to
* enable/disable certain ACCH repeation features individually */
struct abis_rsl_osmo_rep_acch_cap repeated_acch_policy;
+
+ /* MS/BS Power Control parameters */
+ struct gsm_power_ctrl_params *ms_power_ctrl;
+ struct gsm_power_ctrl_params *bs_power_ctrl;
};
#define GSM_BTS_SI2Q(bts, i) (struct gsm48_system_information_type_2quater
*)((bts)->si_buf[SYSINFO_TYPE_2quater][i])
diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index 3472f39..f9d5736 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -1269,4 +1269,74 @@
int bsc_sccp_inst_next_conn_id(struct osmo_sccp_instance *sccp);
+/* MS/BS Power related measurement averaging algo */
+enum gsm_power_ctrl_meas_avg_algo {
+ GSM_PWR_CTRL_MEAS_AVG_ALGO_NONE = 0x00,
+ GSM_PWR_CTRL_MEAS_AVG_ALGO_UNWEIGHTED = 0x01,
+ GSM_PWR_CTRL_MEAS_AVG_ALGO_WEIGHTED = 0x02,
+ GSM_PWR_CTRL_MEAS_AVG_ALGO_MOD_MEDIAN = 0x03,
+ /* EWMA is an Osmocom specific algo */
+ GSM_PWR_CTRL_MEAS_AVG_ALGO_OSMO_EWMA= 0x04,
+};
+
+/* MS/BS Power related measurement parameters */
+struct gsm_power_ctrl_meas_params {
+ /* Thresholds (see 3GPP TS 45.008, section A.3.2.1) */
+ uint8_t lower_thresh; /* lower (decreasing) direction */
+ uint8_t upper_thresh; /* upper (increasing) direction */
+
+ /* Threshold Comparators for lower (decreasing) direction */
+ uint8_t lower_cmp_p; /* P1 for RxLev, P3 for RxQual */
+ uint8_t lower_cmp_n; /* N1 for RxLev, N3 for RxQual */
+ /* Threshold Comparators for upper (increasing) direction */
+ uint8_t upper_cmp_p; /* P2 for RxLev, P4 for RxQual */
+ uint8_t upper_cmp_n; /* N2 for RxLev, N4 for RxQual */
+
+ /* Hreqave and Hreqt (see 3GPP TS 45.008, Annex A) */
+ uint8_t h_reqave;
+ uint8_t h_reqt;
+
+ /* AVG algorithm and its specific parameters */
+ enum gsm_power_ctrl_meas_avg_algo algo;
+ union {
+ /* Exponentially Weighted Moving Average */
+ struct {
+ /* Smoothing factor: higher the value - less smoothing
*/
+ uint8_t alpha; /* 1 .. 99 (in %) */
+ } ewma;
+ };
+};
+
+enum gsm_power_ctrl_dir {
+ GSM_PWR_CTRL_DIR_UL, /* MS Power Control */
+ GSM_PWR_CTRL_DIR_DL, /* BS Power Control */
+};
+
+enum gsm_power_ctrl_mode {
+ /* Do not send MS/BS Power Control IEs */
+ GSM_PWR_CTRL_MODE_NONE = 0,
+ /* Send MS/BS Power IE only (with target level) */
+ GSM_PWR_CTRL_MODE_STATIC,
+ /* Send MS/BS Power [Parameters] IEs (dynamic mode) */
+ GSM_PWR_CTRL_MODE_DYN_BTS,
+};
+
+/* MS/BS Power Control Parameters */
+struct gsm_power_ctrl_params {
+ /* Power Control direction: Uplink or Downlink */
+ enum gsm_power_ctrl_dir dir;
+ /* Power Control mode to be used by the BTS */
+ enum gsm_power_ctrl_mode mode;
+
+ /* Power change step size (dynamic mode only) */
+ uint8_t inc_step_size_db; /* increasing direction */
+ uint8_t red_step_size_db; /* reducing direction */
+
+ /* Measurement averaging parameters for RxLev & RxQual */
+ struct gsm_power_ctrl_meas_params rxqual_meas;
+ struct gsm_power_ctrl_meas_params rxlev_meas;
+};
+
+extern const struct gsm_power_ctrl_params power_ctrl_params_def;
+
#endif /* _GSM_DATA_H */
diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c
index 0c7fde9..68eb101 100644
--- a/src/osmo-bsc/bts.c
+++ b/src/osmo-bsc/bts.c
@@ -349,6 +349,16 @@
bts->repeated_acch_policy.rxqual = 4;
+ /* MS Power Control parameters (defaults) */
+ bts->ms_power_ctrl = talloc(bts, struct gsm_power_ctrl_params);
+ *bts->ms_power_ctrl = power_ctrl_params_def;
+ bts->ms_power_ctrl->dir = GSM_PWR_CTRL_DIR_UL;
+
+ /* BS Power Control parameters (defaults) */
+ bts->bs_power_ctrl = talloc(bts, struct gsm_power_ctrl_params);
+ *bts->bs_power_ctrl = power_ctrl_params_def;
+ bts->bs_po
Change in osmo-bsc[master]: power_control: add VTY commands for per-BTS configuration
Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/21685 to look at the new patch set (#2). Change subject: power_control: add VTY commands for per-BTS configuration .. power_control: add VTY commands for per-BTS configuration Change-Id: Ifd6ea29c3b9dbaccf92856131d5fb2e352b84eb2 Related: SYS#4918 --- M include/osmocom/bsc/vty.h M src/osmo-bsc/bsc_vty.c M src/osmo-bsc/osmo_bsc_main.c M tests/Makefile.am A tests/power_ctrl.vty 5 files changed, 670 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/85/21685/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21685 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ifd6ea29c3b9dbaccf92856131d5fb2e352b84eb2 Gerrit-Change-Number: 21685 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-bsc[master]: power_control: send ip.access specific meas processing defaults
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bsc/+/21788 )
Change subject: power_control: send ip.access specific meas processing defaults
..
power_control: send ip.access specific meas processing defaults
Thanks to this message, there is no need to include MS/BS Power
Control parameters in every RSL CHANnel ACTIvation message.
Instead, we send them only once, and then send empty IEs.
Change-Id: I46ae4e6003a1839ee57f8e941a54bf479f7e532d
Related: SYS#4918
---
M include/osmocom/bsc/abis_rsl.h
M src/osmo-bsc/abis_rsl.c
M src/osmo-bsc/osmo_bsc_main.c
3 files changed, 35 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/88/21788/1
diff --git a/include/osmocom/bsc/abis_rsl.h b/include/osmocom/bsc/abis_rsl.h
index 964e282..81a0224 100644
--- a/include/osmocom/bsc/abis_rsl.h
+++ b/include/osmocom/bsc/abis_rsl.h
@@ -101,6 +101,8 @@
/* required for Nokia BTS power control */
int rsl_bs_power_control(struct gsm_bts_trx *trx, uint8_t channel, uint8_t
reduction);
+/* ip.access specific "Measurement Pre-processing Defaults" */
+int rsl_tx_ipacc_meas_preproc_def(struct gsm_bts_trx *trx);
int rsl_release_sapis_from(struct gsm_lchan *lchan, int start,
enum rsl_rel_mode release_mode);
diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c
index 917726a..27d0dad 100644
--- a/src/osmo-bsc/abis_rsl.c
+++ b/src/osmo-bsc/abis_rsl.c
@@ -2642,3 +2642,30 @@
return abis_rsl_sendmsg(msg);
}
+
+/* ip.access specific "Measurement Pre-processing Defaults" */
+int rsl_tx_ipacc_meas_preproc_def(struct gsm_bts_trx *trx)
+{
+ struct msgb *msg = rsl_msgb_alloc();
+ struct abis_rsl_common_hdr *ch;
+
+ ch = (struct abis_rsl_common_hdr *) msgb_put(msg, sizeof(*ch));
+ ch->msg_discr = ABIS_RSL_MDISC_TRX;
+ ch->msg_type = RSL_MT_IPAC_MEAS_PREPROC_DFT;
+
+ /* BS/MS Power IEs (to be re-defined in channel specific messages) */
+ if (trx->bts->ms_power_ctrl->mode != GSM_PWR_CTRL_MODE_NONE)
+ msgb_tv_put(msg, RSL_IE_MS_POWER, 0); /* maximum */
+ if (trx->bts->bs_power_ctrl->mode != GSM_PWR_CTRL_MODE_NONE)
+ msgb_tv_put(msg, RSL_IE_BS_POWER, 0); /* no attenuation */
+
+ /* BS/MS Power Parameters IEs (if supported by BTS model) */
+ add_power_control_params(msg, trx->bts, GSM_PWR_CTRL_DIR_UL);
+ add_power_control_params(msg, trx->bts, GSM_PWR_CTRL_DIR_DL);
+
+ /* TODO: "Pre-processing Parameters" IE can be sent in subsequent
messages */
+
+ msg->dst = trx->rsl_link;
+
+ return abis_rsl_sendmsg(msg);
+}
diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c
index df5235e..7be594a 100644
--- a/src/osmo-bsc/osmo_bsc_main.c
+++ b/src/osmo-bsc/osmo_bsc_main.c
@@ -340,6 +340,12 @@
rsl_nokia_si_end(trx);
}
+ /* ip.access specific "Measurement Pre-processing Defaults" */
+ if (is_ipaccess_bts(trx->bts) &&
+ (trx->bts->ms_power_ctrl->mode != GSM_PWR_CTRL_MODE_NONE ||
+trx->bts->bs_power_ctrl->mode != GSM_PWR_CTRL_MODE_NONE))
+ rsl_tx_ipacc_meas_preproc_def(trx);
+
for (i = 0; i < ARRAY_SIZE(trx->ts); i++) {
struct gsm_bts_trx_ts *ts = &trx->ts[i];
generate_ma_for_ts(ts);
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21788
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I46ae4e6003a1839ee57f8e941a54bf479f7e532d
Gerrit-Change-Number: 21788
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-bsc[master]: power_control: send RSL_IE_{MS, BS}_POWER_PARAM on CHANnel ACTIVation
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bsc/+/21787 )
Change subject: power_control: send RSL_IE_{MS,BS}_POWER_PARAM on CHANnel
ACTIVation
..
power_control: send RSL_IE_{MS,BS}_POWER_PARAM on CHANnel ACTIVation
Change-Id: I586b1c9e16390757b015c2871a36abc3975e0fc4
Related: SYS#4918
---
M include/osmocom/bsc/bts.h
M src/osmo-bsc/abis_rsl.c
2 files changed, 65 insertions(+), 8 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/87/21787/1
diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h
index fc5ec40..97e2ff8 100644
--- a/include/osmocom/bsc/bts.h
+++ b/include/osmocom/bsc/bts.h
@@ -184,6 +184,9 @@
void (*e1line_bind_ops)(struct e1inp_line *line);
+ /* (Optional) encoding function for MS/BS Power Control paramaters */
+ int (*enc_power_params)(struct msgb *msg, const struct
gsm_power_ctrl_params *cp);
+
void (*config_write_bts)(struct vty *vty, struct gsm_bts *bts);
void (*config_write_trx)(struct vty *vty, struct gsm_bts_trx *trx);
void (*config_write_ts)(struct vty *vty, struct gsm_bts_trx_ts *ts);
diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c
index f8ea5a5..917726a 100644
--- a/src/osmo-bsc/abis_rsl.c
+++ b/src/osmo-bsc/abis_rsl.c
@@ -486,6 +486,59 @@
}
}
+static void add_power_control_params(struct msgb *msg,
+const struct gsm_bts *bts,
+enum gsm_power_ctrl_dir dir)
+{
+ const struct gsm_power_ctrl_params *cp;
+ uint8_t tag, msg_len, *ie_len;
+ int rc;
+
+ if (dir == GSM_PWR_CTRL_DIR_UL) {
+ tag = RSL_IE_MS_POWER_PARAM;
+ cp = bts->ms_power_ctrl;
+ } else {
+ tag = RSL_IE_BS_POWER_PARAM;
+ cp = bts->bs_power_ctrl;
+ }
+
+ /* These parameters are only valid for dynamic mode */
+ if (cp->mode != GSM_PWR_CTRL_MODE_DYN_BTS)
+ return;
+
+ switch (bts->type) {
+ case GSM_BTS_TYPE_NANOBTS:
+ case GSM_BTS_TYPE_OSMOBTS:
+ /* For both ip.access nanoBTS and osmoBTS we send MS/BS Power
Control
+* parameters once - right after the RSL connection is
established.
+* However, we may still need to send an empty IE here in order
to
+* indicate that dynamic power control is to be performed by
BTS. */
+ msgb_tlv_put(msg, tag, 0, NULL);
+ return;
+ default:
+ /* Since IE {MS,BS}_POWER_PARAM content is operator dependent,
it's not
+* known if non-osmocom BTS models will support an empty IE, so
let's
+* better skip sending it unless we know for sure what each
expects. */
+ if (bts->model->enc_power_params == NULL)
+ return;
+
+ /* Put tag first, length will be updated later */
+ ie_len = msgb_tl_put(msg, tag);
+ msg_len = msgb_length(msg);
+
+ rc = bts->model->enc_power_params(msg, cp);
+ if (rc != 0) {
+ LOGP(DRSL, LOGL_ERROR, "Failed to encode MS/BS Power
Control "
+"parameters, omitting this IE (tag 0x%02x)\n",
tag);
+ msgb_get(msg, msg_len - 2);
+ return;
+ }
+
+ /* Update length part of the containing IE */
+ *ie_len = msgb_length(msg) - msg_len;
+ }
+}
+
/* Chapter 8.4.1 */
int rsl_tx_chan_activ(struct gsm_lchan *lchan, uint8_t act_type, uint8_t
ho_ref)
{
@@ -570,15 +623,16 @@
break;
}
- msgb_tv_put(msg, RSL_IE_BS_POWER, lchan->bs_power);
- msgb_tv_put(msg, RSL_IE_MS_POWER, lchan->ms_power);
+ if (bts->bs_power_ctrl->mode != GSM_PWR_CTRL_MODE_NONE)
+ msgb_tv_put(msg, RSL_IE_BS_POWER, lchan->bs_power);
+ if (bts->ms_power_ctrl->mode != GSM_PWR_CTRL_MODE_NONE)
+ msgb_tv_put(msg, RSL_IE_MS_POWER, lchan->ms_power);
+
msgb_tv_put(msg, RSL_IE_TIMING_ADVANCE, ta);
- /* indicate MS power control to be performed by BTS: */
- if (bts->type == GSM_BTS_TYPE_OSMOBTS)
- msgb_tl_put(msg, RSL_IE_MS_POWER_PARAM);
- /* else: Since IE MS_POWER_PARAM content is operator dependent, it's not
- known if non-osmocom BTS models will support an empty IE, so let's
- better skip sending it unless we know for sure what each expects. */
+
+ /* BS/MS Power Control Parameters (if supported by BTS model) */
+ add_power_control_params(msg, bts, GSM_PWR_CTRL_DIR_DL);
+ add_power_control_params(msg, bts, GSM_PWR_CTRL_DIR_UL);
mr_config_for_bts(lchan, msg);
rep_acch_cap_for_bts(lchan, msg);
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21787
To uns
Change in libosmocore[master]: Revert "rest_octets: fix encoding of 3G Early Classmark Sending Restr...
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/21789 )
Change subject: Revert "rest_octets: fix encoding of 3G Early Classmark Sending
Restriction"
..
Revert "rest_octets: fix encoding of 3G Early Classmark Sending Restriction"
This reverts commit c9eab828ea4a9f508a013cf5cc1e0384a0e62e4c.
The initial code was correct, which has also been used in osmo-bsc until
recently, where it moved to use this function from libosmocore and
errors started to show up in TTCN3 tests.
See 3GPP TS 44.018 Section 10.5.2.34 / Table 10.5.2.34.1: "SI 3 Rest
Octets information element":
"""
::=
...
<3G Early Classmark Sending Restriction>
...
<3G Early Classmark Sending Restriction>::= L | H;
"""
Change-Id: I0ee48d3240c62c4d2e15063b26da7a2a617f383e
Related: OS#3075
Related: SYS#4021
---
M src/gsm/gsm48_rest_octets.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/89/21789/1
diff --git a/src/gsm/gsm48_rest_octets.c b/src/gsm/gsm48_rest_octets.c
index 3a424f7..90f2b03 100644
--- a/src/gsm/gsm48_rest_octets.c
+++ b/src/gsm/gsm48_rest_octets.c
@@ -611,9 +611,9 @@
/* 3G Early Classmark Sending Restriction. If H, then controlled by
* early_cm_ctrl above */
if (si3->early_cm_restrict_3g)
- bitvec_set_bit(&bv, H);
- else
bitvec_set_bit(&bv, L);
+ else
+ bitvec_set_bit(&bv, H);
if (si3->si2quater_indicator) {
bitvec_set_bit(&bv, H); /* indicator struct present */
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21789
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0ee48d3240c62c4d2e15063b26da7a2a617f383e
Gerrit-Change-Number: 21789
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-MessageType: newchange
Change in osmo-bsc[master]: power_control: add encoder for ip.access nanoBTS and osmoBTS
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21683 ) Change subject: power_control: add encoder for ip.access nanoBTS and osmoBTS .. Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21683 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3798a6a02132bafe8f1fef6e93bbb42036d76ac9 Gerrit-Change-Number: 21683 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 18 Dec 2020 16:23:48 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-bsc[master]: power_control: add new structures and default parameters
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21786 ) Change subject: power_control: add new structures and default parameters .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21786 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7fb8ccb997490b40a061d09c241359aaabc37c4a Gerrit-Change-Number: 21786 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 18 Dec 2020 16:34:48 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: power_control: send RSL_IE_{MS, BS}_POWER_PARAM on CHANnel ACTIVation
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/21787 )
Change subject: power_control: send RSL_IE_{MS,BS}_POWER_PARAM on CHANnel
ACTIVation
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/c/osmo-bsc/+/21787/1/src/osmo-bsc/abis_rsl.c
File src/osmo-bsc/abis_rsl.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/21787/1/src/osmo-bsc/abis_rsl.c@516
PS1, Line 516: msgb_tlv_put(msg, tag, 0, NULL);
If we have a cb pointer for it, why not move this into a function and set it
during bts_init() of NANOBTS and OSMOBTS?
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21787
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I586b1c9e16390757b015c2871a36abc3975e0fc4
Gerrit-Change-Number: 21787
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin
Gerrit-Comment-Date: Fri, 18 Dec 2020 16:37:54 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in osmo-bsc[master]: power_control: add encoder for ip.access nanoBTS and osmoBTS
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21683 ) Change subject: power_control: add encoder for ip.access nanoBTS and osmoBTS .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/21683/2/src/osmo-bsc/bts_ipaccess_nanobts.c File src/osmo-bsc/bts_ipaccess_nanobts.c: https://gerrit.osmocom.org/c/osmo-bsc/+/21683/2/src/osmo-bsc/bts_ipaccess_nanobts.c@71 PS2, Line 71: .enc_power_params = &enc_power_params, IIUC this code is still not called due to the switch from previous commit? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21683 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3798a6a02132bafe8f1fef6e93bbb42036d76ac9 Gerrit-Change-Number: 21683 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Fri, 18 Dec 2020 16:39:21 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-bsc[master]: power_control: send ip.access specific meas processing defaults
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21788 ) Change subject: power_control: send ip.access specific meas processing defaults .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I46ae4e6003a1839ee57f8e941a54bf479f7e532d Gerrit-Change-Number: 21788 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 18 Dec 2020 16:40:43 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: power_control: add VTY commands for per-BTS configuration
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21685 ) Change subject: power_control: add VTY commands for per-BTS configuration .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21685 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ifd6ea29c3b9dbaccf92856131d5fb2e352b84eb2 Gerrit-Change-Number: 21685 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 18 Dec 2020 16:42:33 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: power_control: add encoder for ip.access nanoBTS and osmoBTS
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21683 ) Change subject: power_control: add encoder for ip.access nanoBTS and osmoBTS .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/21683/2/src/osmo-bsc/bts_ipaccess_nanobts.c File src/osmo-bsc/bts_ipaccess_nanobts.c: https://gerrit.osmocom.org/c/osmo-bsc/+/21683/2/src/osmo-bsc/bts_ipaccess_nanobts.c@71 PS2, Line 71: .enc_power_params = &enc_power_params, > IIUC this code is still not called due to the switch from previous commit? Correct, see https://gerrit.osmocom.org/c/osmo-bsc/+/21788. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21683 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3798a6a02132bafe8f1fef6e93bbb42036d76ac9 Gerrit-Change-Number: 21683 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Fri, 18 Dec 2020 16:43:07 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in libosmocore[master]: Revert "rest_octets: fix encoding of 3G Early Classmark Sending Restr...
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21789 ) Change subject: Revert "rest_octets: fix encoding of 3G Early Classmark Sending Restriction" .. Patch Set 1: I confirm latest TTCN3 BSC_Tests regressions in TC_si2quater_*_earfcns are fixed with this revert applied. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21789 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0ee48d3240c62c4d2e15063b26da7a2a617f383e Gerrit-Change-Number: 21789 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 18 Dec 2020 16:43:42 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmocore[master]: Revert "rest_octets: fix encoding of 3G Early Classmark Sending Restr...
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21789 ) Change subject: Revert "rest_octets: fix encoding of 3G Early Classmark Sending Restriction" .. Patch Set 1: btw, description of the L/H values: 3G Early Classmark Sending Restriction (1 bit field): * L: Neither UTRAN, CDMA2000 nor GERAN IU MODE CLASSMARK CHANGE message shall be sent with the Early classmark sending * H: The sending of UTRAN,CDMA2000 and GERAN IU MODECLASSMARK CHANGE messages are controlled by the Early Classmark Sending Control parameter -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21789 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0ee48d3240c62c4d2e15063b26da7a2a617f383e Gerrit-Change-Number: 21789 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 18 Dec 2020 16:46:37 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-bsc[master]: power_control: send RSL_IE_{MS, BS}_POWER_PARAM on CHANnel ACTIVation
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/21787 )
Change subject: power_control: send RSL_IE_{MS,BS}_POWER_PARAM on CHANnel
ACTIVation
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/c/osmo-bsc/+/21787/1/src/osmo-bsc/abis_rsl.c
File src/osmo-bsc/abis_rsl.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/21787/1/src/osmo-bsc/abis_rsl.c@516
PS1, Line 516: msgb_tlv_put(msg, tag, 0, NULL);
> If we have a cb pointer for it, why not move this into a function and set it
> during bts_init() of NA […]
Not sure if I understand what you mean. Do you suggest to move appending RSL
IEs to bts->model->enc_power_params()? I think it's better to keep these
encoding functions abstracted from dealing with RSL IEs.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21787
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I586b1c9e16390757b015c2871a36abc3975e0fc4
Gerrit-Change-Number: 21787
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin
Gerrit-Comment-Date: Fri, 18 Dec 2020 16:55:58 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
Gerrit-MessageType: comment
Change in osmo-bsc[master]: power_control: send RSL_IE_{MS, BS}_POWER_PARAM on CHANnel ACTIVation
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/21787 )
Change subject: power_control: send RSL_IE_{MS,BS}_POWER_PARAM on CHANnel
ACTIVation
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/c/osmo-bsc/+/21787/1/src/osmo-bsc/abis_rsl.c
File src/osmo-bsc/abis_rsl.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/21787/1/src/osmo-bsc/abis_rsl.c@516
PS1, Line 516: msgb_tlv_put(msg, tag, 0, NULL);
> Not sure if I understand what you mean. […]
TThe 2 switch cases above (nanobts, osmobts), are afaiu the same as the default
one when calling a enc_power_rams as a NOOP, am I correct?
So if we have an abstracted way to set the IE contents (enc_power_params func
pointer), why do we want to have this switch case for osmobts and nanobts?
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21787
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I586b1c9e16390757b015c2871a36abc3975e0fc4
Gerrit-Change-Number: 21787
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin
Gerrit-Comment-Date: Fri, 18 Dec 2020 17:00:46 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria
Comment-In-Reply-To: pespin
Gerrit-MessageType: comment
Change in osmo-bsc[master]: power_control: send RSL_IE_{MS, BS}_POWER_PARAM on CHANnel ACTIVation
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/21787 )
Change subject: power_control: send RSL_IE_{MS,BS}_POWER_PARAM on CHANnel
ACTIVation
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/c/osmo-bsc/+/21787/1/src/osmo-bsc/abis_rsl.c
File src/osmo-bsc/abis_rsl.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/21787/1/src/osmo-bsc/abis_rsl.c@516
PS1, Line 516: msgb_tlv_put(msg, tag, 0, NULL);
> TThe 2 switch cases above (nanobts, osmobts), are afaiu the same as the
> default one when calling a enc_power_rams as a NOOP, am I correct?
Yes, if bts->model->enc_power_params() would append no vendor-specific IEs,
then we get an empty TLV (L=0) like in the two cases above. If
bts->model->enc_power_params is NULL, then MS/BS Power Parameters IE is not
included at all.
> So if we have an abstracted way to set the IE contents (enc_power_params func
> pointer), why do we want to have this switch case for osmobts and nanobts?
Because ip.access models allow us to send all parameters only once, in
"Measurement Pre-processing Defaults" message, and then avoid repeating them
again and again in CHANnel ACTIVation messages. So we use this possibility
here. For other BTS models you still need to send those parameters in every
CHANnel ACTIVation message.
And I intentionally kept this decision logic (whether to send an empty IE)
separate from bts->model->enc_power_params(), because this function does not
(and is not supposed to) know in which cases we should skip parameters and in
which we should add them.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21787
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I586b1c9e16390757b015c2871a36abc3975e0fc4
Gerrit-Change-Number: 21787
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin
Gerrit-Comment-Date: Fri, 18 Dec 2020 17:44:04 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
Comment-In-Reply-To: fixeria
Gerrit-MessageType: comment
Change in osmo-bsc[master]: power_control: send RSL_IE_{MS, BS}_POWER_PARAM on CHANnel ACTIVation
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/21787 )
Change subject: power_control: send RSL_IE_{MS,BS}_POWER_PARAM on CHANnel
ACTIVation
..
Patch Set 1:
So I find the way you chose to structure abstraction a bit weird tbh. That
being said, I'm not going to block this, but I think it'd be less confusing if
for instance, you added a function pointer for "initial" setup and one for
"channel_act" setup of the IE, and implement that in each bts type.
Or for instance put the initial IE setup in the the ipacc_tx_..._def you are
adding in the last commit, and use the function pointer you add in this commit
as the "channel activ" one.
It's all even more confusing because you spread all this through different
commits. Just sharing my opinion in case you want to give it another thought.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21787
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I586b1c9e16390757b015c2871a36abc3975e0fc4
Gerrit-Change-Number: 21787
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin
Gerrit-Comment-Date: Fri, 18 Dec 2020 17:51:09 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in osmo-bsc[master]: power_control: send RSL_IE_{MS, BS}_POWER_PARAM on CHANnel ACTIVation
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/21787 )
Change subject: power_control: send RSL_IE_{MS,BS}_POWER_PARAM on CHANnel
ACTIVation
..
Patch Set 1:
> Or for instance put the initial IE setup in the the ipacc_tx_..._def you are
> adding in the last commit, and use the function pointer you add in this
> commit as the "channel activ" one.
I actually found a problem in rsl_tx_ipacc_meas_preproc_def(): it would always
send empty MS/BS Parameters :/ Thanks for directing my attention towards this
part of the code.
> It's all even more confusing because you spread all this through different
> commits. Just sharing my opinion in case you want to give it another thought.
I agree that the current order is confusing, so I'll rework the patch set and
reorder changes in a more readable way.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21787
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I586b1c9e16390757b015c2871a36abc3975e0fc4
Gerrit-Change-Number: 21787
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin
Gerrit-Comment-Date: Fri, 18 Dec 2020 18:10:49 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in osmo-pcu[master]: tbf: Fix wrong verb used in log message
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-pcu/+/21790 )
Change subject: tbf: Fix wrong verb used in log message
..
tbf: Fix wrong verb used in log message
Change-Id: Id9f8df9a5c0e0f88a811c5d7f06821cb4f30ab93
---
M src/tbf.cpp
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/90/21790/1
diff --git a/src/tbf.cpp b/src/tbf.cpp
index fde44ba..28e24b8 100644
--- a/src/tbf.cpp
+++ b/src/tbf.cpp
@@ -932,7 +932,7 @@
LOGP(DTBF, LOGL_DEBUG, "+ TX : Packet Downlink
Assignment +\n");
rc = encode_gsm_rlcmac_downlink(&bv, mac_control_block);
if (rc < 0) {
- LOGP(DTBF, LOGL_ERROR, "Decoding of Packet Downlink Ass failed
(%d)\n", rc);
+ LOGP(DTBF, LOGL_ERROR, "Encoding of Packet Downlink Ass failed
(%d)\n", rc);
goto free_ret;
}
LOGP(DTBF, LOGL_DEBUG, "- TX : Packet Downlink
Assignment -\n");
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21790
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Id9f8df9a5c0e0f88a811c5d7f06821cb4f30ab93
Gerrit-Change-Number: 21790
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-MessageType: newchange
Change in osmo-bsc[master]: abis_rsl: turn rsl_msgb_alloc() a macro and move it to header
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bsc/+/21791 )
Change subject: abis_rsl: turn rsl_msgb_alloc() a macro and move it to header
..
abis_rsl: turn rsl_msgb_alloc() a macro and move it to header
Also, take a chance to make talloc chunk names more informative.
Change-Id: Id25c4bf1e06f697328d10777d6449c83006e8466
---
M include/osmocom/bsc/abis_rsl.h
M src/osmo-bsc/abis_rsl.c
2 files changed, 7 insertions(+), 8 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/91/21791/1
diff --git a/include/osmocom/bsc/abis_rsl.h b/include/osmocom/bsc/abis_rsl.h
index 964e282..58eca29 100644
--- a/include/osmocom/bsc/abis_rsl.h
+++ b/include/osmocom/bsc/abis_rsl.h
@@ -35,6 +35,13 @@
#define GSM48_LEN2PLEN(a) (((a) << 2) | 1)
+#define RSL_ALLOC_SIZE 1024
+#define RSL_ALLOC_HEADROOM 128
+
+#define rsl_msgb_alloc(args...) \
+ msgb_alloc_headroom(RSL_ALLOC_SIZE, RSL_ALLOC_HEADROOM, \
+ __FILE__ ":" OSMO_STRINGIFY_VAL(__LINE__))
+
const char *ip_to_a(uint32_t ip);
int rsl_bcch_info(const struct gsm_bts_trx *trx, enum osmo_sysinfo_type
si_type, const uint8_t *data, int len);
diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c
index f8ea5a5..a803a03 100644
--- a/src/osmo-bsc/abis_rsl.c
+++ b/src/osmo-bsc/abis_rsl.c
@@ -55,8 +55,6 @@
#include
#include
#include
-#define RSL_ALLOC_SIZE 1024
-#define RSL_ALLOC_HEADROOM 128
static void send_lchan_signal(int sig_no, struct gsm_lchan *lchan,
struct gsm_meas_rep *resp)
@@ -146,12 +144,6 @@
return lchan;
}
-static struct msgb *rsl_msgb_alloc(void)
-{
- return msgb_alloc_headroom(RSL_ALLOC_SIZE, RSL_ALLOC_HEADROOM,
- "RSL");
-}
-
static void pad_macblock(uint8_t *out, const uint8_t *in, int len)
{
memcpy(out, in, len);
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21791
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Id25c4bf1e06f697328d10777d6449c83006e8466
Gerrit-Change-Number: 21791
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-bsc[master]: power_control: add encoder for ip.access nanoBTS and OsmoBTS
Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/21683 to look at the new patch set (#3). Change subject: power_control: add encoder for ip.access nanoBTS and OsmoBTS .. power_control: add encoder for ip.access nanoBTS and OsmoBTS Change-Id: I3798a6a02132bafe8f1fef6e93bbb42036d76ac9 Related: SYS#4918 --- M src/osmo-bsc/bts_ipaccess_nanobts.c 1 file changed, 146 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/83/21683/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21683 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3798a6a02132bafe8f1fef6e93bbb42036d76ac9 Gerrit-Change-Number: 21683 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in osmo-bsc[master]: power_control: add encoding/init API to 'struct gsm_bts_model'
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21792 ) Change subject: power_control: add encoding/init API to 'struct gsm_bts_model' .. power_control: add encoding/init API to 'struct gsm_bts_model' This change introduces two optional function pointers: - power_ctrl_enc_rsl_params() - this function will be called by the A-bis/RSL code in order to encode MS/BS Power control parameters for CHANnel ACTIVation and MS/BS POWER CONTROL messages. - power_ctrl_send_def_params() - this function will be called for each transceiver on A-bis/RSL link establishment in order to send default MS/BS Power control parameters. Change-Id: Iba3ad5d8d549a6676050272f85b21c9b4c219d21 Related: SYS#4918 --- M include/osmocom/bsc/bts.h 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/92/21792/1 diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h index fc5ec40..180bd64 100644 --- a/include/osmocom/bsc/bts.h +++ b/include/osmocom/bsc/bts.h @@ -184,6 +184,11 @@ void (*e1line_bind_ops)(struct e1inp_line *line); + /* (Optional) function for encoding MS/BS Power Control paramaters */ + int (*power_ctrl_enc_rsl_params)(struct msgb *msg, const struct gsm_power_ctrl_params *cp); + /* (Optional) function for sending default MS/BS Power Control paramaters */ + int (*power_ctrl_send_def_params)(const struct gsm_bts_trx *trx); + void (*config_write_bts)(struct vty *vty, struct gsm_bts *bts); void (*config_write_trx)(struct vty *vty, struct gsm_bts_trx *trx); void (*config_write_ts)(struct vty *vty, struct gsm_bts_trx_ts *ts); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21792 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iba3ad5d8d549a6676050272f85b21c9b4c219d21 Gerrit-Change-Number: 21792 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
Change in osmo-bsc[master]: power_control: add VTY command for re-sending default parameters
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bsc/+/21794 )
Change subject: power_control: add VTY command for re-sending default parameters
..
power_control: add VTY command for re-sending default parameters
Change-Id: I35e9147d5536f9901ac63f605d87ae112c024401
Related: SYS#4918
---
M src/osmo-bsc/bsc_vty.c
1 file changed, 37 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/94/21794/1
diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index 49f5e51..056c0fd 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -5646,7 +5646,8 @@
return CMD_SUCCESS;
}
-DEFUN(bts_resend, bts_resend_cmd,
+DEFUN(bts_resend_sysinfo,
+ bts_resend_sysinfo_cmd,
"bts <0-255> resend-system-information",
"BTS Specific Commands\n" BTS_NR_STR
"Re-generate + re-send BCCH SYSTEM INFORMATION\n")
@@ -5679,6 +5680,39 @@
return CMD_SUCCESS;
}
+DEFUN(bts_resend_power_ctrl_params,
+ bts_resend_power_ctrl_params_cmd,
+ "bts <0-255> resend-power-control-defaults",
+ "BTS Specific Commands\n" BTS_NR_STR
+ "Re-generate + re-send default MS/BS Power control parameters\n")
+{
+ const struct gsm_bts_trx *trx;
+ const struct gsm_bts *bts;
+ int bts_nr = atoi(argv[0]);
+
+ bts = gsm_bts_num(gsmnet_from_vty(vty), bts_nr);
+ if (!bts) {
+ vty_out(vty, "%% No such BTS (%d)%s", bts_nr, VTY_NEWLINE);
+ return CMD_WARNING;
+ }
+
+ if (bts->model->power_ctrl_send_def_params == NULL) {
+ vty_out(vty, "%% Sending default MS/BS Power control parameters
"
+ "for BTS%d is not implemented%s", bts_nr, VTY_NEWLINE);
+ return CMD_WARNING;
+ }
+
+ llist_for_each_entry(trx, &bts->trx_list, list) {
+ if (bts->model->power_ctrl_send_def_params(trx) != 0) {
+ vty_out(vty, "%% Failed to send default MS/BS Power
control parameters "
+ "to BTS%d/TRX%d%s", bts_nr, trx->nr,
VTY_NEWLINE);
+ return CMD_WARNING;
+ }
+ }
+
+ return CMD_SUCCESS;
+}
+
DEFUN(smscb_cmd, smscb_cmd_cmd,
"bts <0-255> smscb-command (normal|schedule|default) <1-4> HEXSTRING",
@@ -7675,7 +7709,8 @@
install_element(ENABLE_NODE, &drop_bts_cmd);
install_element(ENABLE_NODE, &restart_bts_cmd);
- install_element(ENABLE_NODE, &bts_resend_cmd);
+ install_element(ENABLE_NODE, &bts_resend_sysinfo_cmd);
+ install_element(ENABLE_NODE, &bts_resend_power_ctrl_params_cmd);
install_element(ENABLE_NODE, &pdch_act_cmd);
install_element(ENABLE_NODE, &lchan_act_cmd);
install_element(ENABLE_NODE, &lchan_act_all_cmd);
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21794
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I35e9147d5536f9901ac63f605d87ae112c024401
Gerrit-Change-Number: 21794
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-bsc[master]: power_control: send default parameters from bootstrap_rsl()
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bsc/+/21793 )
Change subject: power_control: send default parameters from bootstrap_rsl()
..
power_control: send default parameters from bootstrap_rsl()
Change-Id: Ic99e61cc3eb5aa054964abbd777fff66588c4a9a
Related: SYS#4918
---
M src/osmo-bsc/osmo_bsc_main.c
1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/93/21793/1
diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c
index df5235e..4ab0430 100644
--- a/src/osmo-bsc/osmo_bsc_main.c
+++ b/src/osmo-bsc/osmo_bsc_main.c
@@ -310,6 +310,7 @@
static void bootstrap_rsl(struct gsm_bts_trx *trx)
{
unsigned int i;
+ int rc;
LOG_TRX(trx, DRSL, LOGL_NOTICE, "bootstrapping RSL "
"on ARFCN %u using MCC-MNC %s LAC=%u CID=%u BSIC=%u\n",
@@ -340,6 +341,15 @@
rsl_nokia_si_end(trx);
}
+ if (trx->bts->model->power_ctrl_send_def_params != NULL) {
+ rc = trx->bts->model->power_ctrl_send_def_params(trx);
+ if (rc) {
+ LOG_TRX(trx, DRSL, LOGL_ERROR, "Failed to send default "
+ "MS/BS Power control parameters (rc=%d)\n", rc);
+ /* TODO: should we drop RSL connection here? */
+ }
+ }
+
for (i = 0; i < ARRAY_SIZE(trx->ts); i++) {
struct gsm_bts_trx_ts *ts = &trx->ts[i];
generate_ma_for_ts(ts);
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21793
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ic99e61cc3eb5aa054964abbd777fff66588c4a9a
Gerrit-Change-Number: 21793
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-bsc[master]: power_control: add encoder for ip.access nanoBTS and OsmoBTS
Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/21683 to look at the new patch set (#4). Change subject: power_control: add encoder for ip.access nanoBTS and OsmoBTS .. power_control: add encoder for ip.access nanoBTS and OsmoBTS Change-Id: I3798a6a02132bafe8f1fef6e93bbb42036d76ac9 Related: SYS#4918 --- M src/osmo-bsc/bts_ipaccess_nanobts.c 1 file changed, 146 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/83/21683/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21683 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3798a6a02132bafe8f1fef6e93bbb42036d76ac9 Gerrit-Change-Number: 21683 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in osmo-bsc[master]: power_control: add VTY command for re-sending default parameters
fixeria has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-bsc/+/21794 ) Change subject: power_control: add VTY command for re-sending default parameters .. power_control: add VTY command for re-sending default parameters Change-Id: I35e9147d5536f9901ac63f605d87ae112c024401 Related: SYS#4918 --- M src/osmo-bsc/bsc_vty.c 1 file changed, 37 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/94/21794/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21794 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I35e9147d5536f9901ac63f605d87ae112c024401 Gerrit-Change-Number: 21794 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset
Change in osmo-bsc[master]: power_control: add VTY commands for per-BTS configuration
Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/21685 to look at the new patch set (#4). Change subject: power_control: add VTY commands for per-BTS configuration .. power_control: add VTY commands for per-BTS configuration Change-Id: Ifd6ea29c3b9dbaccf92856131d5fb2e352b84eb2 Related: SYS#4918 --- M include/osmocom/bsc/vty.h M src/osmo-bsc/bsc_vty.c M src/osmo-bsc/osmo_bsc_main.c M tests/Makefile.am A tests/power_ctrl.vty 5 files changed, 670 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/85/21685/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21685 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ifd6ea29c3b9dbaccf92856131d5fb2e352b84eb2 Gerrit-Change-Number: 21685 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-bsc[master]: power_control: send default parameters from bootstrap_rsl()
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21788 ) Change subject: power_control: send default parameters from bootstrap_rsl() .. Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I46ae4e6003a1839ee57f8e941a54bf479f7e532d Gerrit-Change-Number: 21788 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 19 Dec 2020 00:07:38 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-bsc[master]: power_control: send default parameters from bootstrap_rsl()
fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21793 ) Change subject: power_control: send default parameters from bootstrap_rsl() .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21793 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic99e61cc3eb5aa054964abbd777fff66588c4a9a Gerrit-Change-Number: 21793 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-CC: Jenkins Builder Gerrit-MessageType: abandon
Change in osmo-bsc[master]: power_control: make use of MS/BS parameters in RSL messages
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21787 ) Change subject: power_control: make use of MS/BS parameters in RSL messages .. Patch Set 3: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21787 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I586b1c9e16390757b015c2871a36abc3975e0fc4 Gerrit-Change-Number: 21787 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Sat, 19 Dec 2020 00:10:02 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_20.04/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_20.04/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_20.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 167s] [COMPILING libboard/qmod/source/wwan_perst.c] [ 167s] [COMPILING libboard/qmod/source/card_pres.c] [ 167s] [COMPILING libboard/qmod/source/wwan_led.c] [ 167s] [COMPILING libboard/qmod/source/i2c.c] [ 168s] [COMPILING libboard/qmod/source/board_qmod.c] [ 168s] [COMPILING apps/dfu/main.c] [ 168s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c] [ 168s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c] [ 168s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c] [ 168s] Memory region Used Size Region Size %age Used [ 168s] rom: 16588 B16 KB101.25% [ 168s] ram: 11672 B48 KB 23.75/usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom' [ 168s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: region `rom' overflowed by 204 bytes [ 168s] collect2: error: ld returned 1 exit status [ 168s] % [ 168s] make[2]: *** [Makefile:234: flash] Error 1 [ 168s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 168s] make[1]: *** [Makefile:13: fw-qmod-dfu] Error 2 [ 168s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 168s] dh_auto_build: error: make -j1 returned exit code 2 [ 168s] make: *** [debian/rules:16: build] Error 25 [ 168s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 168s] ### VM INTERACTION START ### [ 171s] [ 160.690790] sysrq: Power Off [ 171s] [ 160.697132] reboot: Power down [ 172s] ### VM INTERACTION END ### [ 172s] [ 172s] lamb55 failed "build simtrace2_0.7.0.69.aadd.dsc" at Sat Dec 19 01:48:29 UTC 2020. [ 172s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_20.10/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_20.10/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_20.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 174s] [COMPILING apps/dfu/main.c] [ 175s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c] [ 175s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c] [ 175s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c] [ 175s] Memory region Used Size Region Size %age Used [ 175s] rom: 16580 B16 KB101.20% [ 175s] ram: 11672 B48 KB 23.75/usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 175s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 175s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom' [ 175s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 175s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 175s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 175s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: region `rom' overflowed by 196 bytes [ 175s] collect2: error: ld returned 1 exit status [ 175s] % [ 175s] make[2]: *** [Makefile:234: flash] Error 1 [ 175s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 175s] make[1]: *** [Makefile:13: fw-qmod-dfu] Error 2 [ 175s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 175s] dh_auto_build: error: make -j1 returned exit code 2 [ 175s] make: *** [debian/rules:16: build] Error 25 [ 175s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 175s] ### VM INTERACTION START ### [ 178s] [ 165.791248] sysrq: Power Off [ 178s] [ 165.796577] reboot: Power down [ 178s] ### VM INTERACTION END ### [ 178s] [ 178s] lamb13 failed "build simtrace2_0.7.0.69.aadd.dsc" at Sat Dec 19 01:48:50 UTC 2020. [ 178s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Change in osmo-bsc[master]: power_control: add encoder for ip.access nanoBTS and OsmoBTS
Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/21683 to look at the new patch set (#5). Change subject: power_control: add encoder for ip.access nanoBTS and OsmoBTS .. power_control: add encoder for ip.access nanoBTS and OsmoBTS Change-Id: I3798a6a02132bafe8f1fef6e93bbb42036d76ac9 Related: SYS#4918 --- M src/osmo-bsc/bts_ipaccess_nanobts.c 1 file changed, 155 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/83/21683/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21683 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3798a6a02132bafe8f1fef6e93bbb42036d76ac9 Gerrit-Change-Number: 21683 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-MessageType: newpatchset
