[M] Change in osmo-ttcn3-hacks[master]: mgw: add f_TC_amr_switch_to_iuup
neels has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34539?usp=email )
Change subject: mgw: add f_TC_amr_switch_to_iuup
..
mgw: add f_TC_amr_switch_to_iuup
Change-Id: I08eca9ea123029c37892d5de7c94a8ed6cc0a913
---
M mgw/MGCP_Test.ttcn
1 file changed, 160 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/39/34539/1
diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn
index 73591b2..ca6e520 100644
--- a/mgw/MGCP_Test.ttcn
+++ b/mgw/MGCP_Test.ttcn
@@ -3078,6 +3078,155 @@
mp_local_ipv4, mp_remote_ipv4);
}
+ function f_tc_amr_switch_to_iuup(charstring local_ip_a, charstring
remote_ip_a,
+IuUP_RabFlowCombinationList rfcl_a,
+charstring local_ip_b, charstring
remote_ip_b) runs on dummy_CT {
+ var RtpFlowData flow[2];
+ var RtpemStats stats[2];
+ var MgcpResponse resp;
+ var MgcpEndpoint ep := c_mgw_ep_rtpbridge & "2@" & c_mgw_domain;
+ var MgcpCallId call_id := '1227'H;
+ var integer num_pkts_tx[2];
+ var integer temp;
+
+ f_init(ep);
+
+ /* Create the first connection in receive only mode (RNC side,
IuUP-Init active) */
+ flow[0] := valueof(t_RtpFlow(local_ip_a, remote_ip_a, 96,
"VND.3GPP.IUFP/16000"));
+ flow[0].em.portnr := 1;
+ flow[0].rtp_cfg := c_RtpemDefaultCfg;
+ flow[0].rtp_cfg.tx_payloads[0].payload_type :=
flow[0].codec_descr[0].pt;
+ flow[0].rtp_cfg.rx_payloads[0].payload_type :=
flow[0].codec_descr[0].pt;
+ flow[0].rtp_cfg.tx_payloads[0].fixed_payload :=
'4f28959ffeb80181f5c4e83d176c897b4a4e333298333419a493ca63ded6e0'O;
+ /* flow[1].rtp_cfg.rx_payloads[0].fixed_payload converted
AMR-BE-RTP->AMR-IUUP*/
+ flow[0].rtp_cfg.rx_payloads[0].fixed_payload :=
'08556d944c71a1a081e7ead20424448ecd82b8111897c4794e7740'O;
+ flow[0].rtp_cfg.iuup_mode := true;
+ flow[0].rtp_cfg.iuup_cfg.active_init := true;
+ flow[0].rtp_cfg.iuup_cfg.rab_flow_combs := rfcl_a;
+ f_flow_create(RTPEM[0], ep, call_id, "recvonly", flow[0], true);
+ f_rtpem_mode(RTPEM[0], RTPEM_MODE_RXONLY);
+
+ /* Create the second connection. This connection will be also
+* in receive only mode (CN side, regular RTP) */
+ flow[1] := valueof(t_RtpFlow(local_ip_b, remote_ip_b, 112,
"AMR/8000"));
+ flow[1].em.portnr := 2;
+ flow[1].rtp_cfg := c_RtpemDefaultCfg;
+ flow[1].rtp_cfg.tx_payloads[0].payload_type :=
flow[1].codec_descr[0].pt;
+ flow[1].rtp_cfg.rx_payloads[0].payload_type :=
flow[1].codec_descr[0].pt;
+ flow[1].rtp_cfg.tx_payloads[0].fixed_payload :=
'0382155b65131c68682079fab481091123b360ae044625f11e539dd0'O;
+ /* flow[0].rtp_cfg.rx_payloads[0].fixed_payload converted
AMR-IuUP->AMR-BE-RTP*/
+ flow[1].rtp_cfg.rx_payloads[0].fixed_payload :=
'f3d3ca2567ffae00607d713a0f45db225ed2938ccca60ccd066924f298f7b5b8'O;
+ flow[1].rtp_cfg.iuup_mode := false;
+ f_flow_create(RTPEM[1], ep, call_id, "recvonly", flow[1], true);
+ f_rtpem_mode(RTPEM[1], RTPEM_MODE_RXONLY);
+
+ /* The first leg starts transmitting */
+ f_rtpem_mode(RTPEM[0], RTPEM_MODE_TXONLY);
+ f_sleep(0.5);
+ stats[0] := f_rtpem_stats_get(RTPEM[0]);
+ if (stats[0].num_pkts_rx_err_disabled != 0) {
+ setverdict(fail, "received packets from MGW on recvonly
connection 0");
+ mtc.stop;
+ }
+ stats[1] := f_rtpem_stats_get(RTPEM[1]);
+ if (stats[1].num_pkts_rx_err_disabled != 0) {
+ setverdict(fail, "received packets from MGW on recvonly
connection 1");
+ mtc.stop;
+ }
+
+ /* The second leg starts transmitting a little later */
+ f_rtpem_mode(RTPEM[1], RTPEM_MODE_TXONLY);
+ f_sleep(1.0);
+ stats[0] := f_rtpem_stats_get(RTPEM[0]);
+ if (stats[0].num_pkts_rx_err_disabled != 0) {
+ setverdict(fail, "received packets from MGW on recvonly
connection 0");
+ mtc.stop;
+ }
+ stats[1] := f_rtpem_stats_get(RTPEM[1]);
+ if (stats[1].num_pkts_rx_err_disabled != 0) {
+ setverdict(fail, "received packets from MGW on recvonly
connection 1");
+ mtc.stop;
+ }
+
+
[S] Change in osmo-ttcn3-hacks[master]: osmo-mgw.cfg syntax fix
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34538?usp=email ) Change subject: osmo-mgw.cfg syntax fix .. osmo-mgw.cfg syntax fix was added with mismatching indent in "mgw: Update to contain similar config from docker-playground.git" commit cec73acdd4fa4ddc39ab44853ece0888b3e1bf34 I2aa4d86e548d6644f1dd9358f6b8b48a19c96c3c Change-Id: I5d4d1af40410bfdcc1280f45b85a8ae0c7b94a80 --- M mgw/osmo-mgw.cfg 1 file changed, 24 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/38/34538/1 diff --git a/mgw/osmo-mgw.cfg b/mgw/osmo-mgw.cfg index 3844e79..2af7dff 100644 --- a/mgw/osmo-mgw.cfg +++ b/mgw/osmo-mgw.cfg @@ -60,12 +60,12 @@ osmux off osmux bind-ip 127.0.0.1 osmux bind-ip-v6 ::1 - trunk 1 - sdp audio-payload send-ptime - sdp audio-payload send-name - no rtp keep-alive - loop 0 - no rtcp-omit - no rtp-patch - allow-transcoding - line 0 + trunk 1 + sdp audio-payload send-ptime + sdp audio-payload send-name + no rtp keep-alive + loop 0 + no rtcp-omit + no rtp-patch + allow-transcoding + line 0 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34538?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5d4d1af40410bfdcc1280f45b85a8ae0c7b94a80 Gerrit-Change-Number: 34538 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange
[S] Change in osmo-ttcn3-hacks[master]: IuUP_Emulation: fix AMR SID SDU size
neels has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34537?usp=email )
Change subject: IuUP_Emulation: fix AMR SID SDU size
..
IuUP_Emulation: fix AMR SID SDU size
See 3GPP TS 26.102 Table 6-2, an AMR SID should have 39 bits.
Change-Id: I9afb28ca6e23f7976edcc130ea012be34e04eb4b
---
M library/IuUP_Emulation.ttcn
1 file changed, 13 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/37/34537/1
diff --git a/library/IuUP_Emulation.ttcn b/library/IuUP_Emulation.ttcn
index b649e44..3bda958 100644
--- a/library/IuUP_Emulation.ttcn
+++ b/library/IuUP_Emulation.ttcn
@@ -35,7 +35,7 @@
}
template (value) IuUP_RabFlowCombination t_IuUP_RFC_AMR_12_2(IuUP_RFCI rfci)
:= t_IuUP_RFC(rfci, {81, 103, 60}, 1);
-template (value) IuUP_RabFlowCombination t_IuUP_RFC_AMR_SID(IuUP_RFCI rfci) :=
t_IuUP_RFC(rfci, {34, 0, 0}, 7);
+template (value) IuUP_RabFlowCombination t_IuUP_RFC_AMR_SID(IuUP_RFCI rfci) :=
t_IuUP_RFC(rfci, {39, 0, 0}, 7);
template (value) IuUP_RabFlowCombination t_IuUP_RFC_AMR_NO_DATA(IuUP_RFCI
rfci) := t_IuUP_RFC(rfci, {0, 0, 0}, 1);
@@ -46,7 +46,7 @@
ipti := 1
}, {
rfci := 1,
- sub_flow_bits := {34, 0, 0},
+ sub_flow_bits := {39, 0, 0},
ipti := 7
}, {
rfci := 2,
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34537?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9afb28ca6e23f7976edcc130ea012be34e04eb4b
Gerrit-Change-Number: 34537
Gerrit-PatchSet: 1
Gerrit-Owner: neels
Gerrit-MessageType: newchange
[S] Change in libosmocore[master]: osmo_io: Clean up code
Attention is currently required from: arehbein. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34524?usp=email ) Change subject: osmo_io: Clean up code .. Patch Set 1: Code-Review-1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34524?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I77f7ae2b211507f420d87c484ec75ee054fceb63 Gerrit-Change-Number: 34524 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-Attention: arehbein Gerrit-Comment-Date: Tue, 26 Sep 2023 20:54:35 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in libosmocore[master]: osmo_io: Clean up code
Attention is currently required from: arehbein. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34524?usp=email ) Change subject: osmo_io: Clean up code .. Patch Set 1: (1 comment) Patchset: PS1: osmo_iofd_init() is only called from the main thread, it needs to be public similar to osmo_select_init() to initialize TLS in a multithreaded program. See osmo-remsim/src/client/user_ifdhandler.c where osmo_select_init() is called explicitly. I'd suggest to only fix the declaration in the header to match the function name. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34524?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I77f7ae2b211507f420d87c484ec75ee054fceb63 Gerrit-Change-Number: 34524 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-Attention: arehbein Gerrit-Comment-Date: Tue, 26 Sep 2023 20:54:17 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[S] Change in osmo-trx[master]: ms: reduce rx burst queue size
Attention is currently required from: Hoernchen. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/34272?usp=email ) Change subject: ms: reduce rx burst queue size .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/34272?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ifb8bf2894c87e4234e3d3f65d66c1e98c8f63c53 Gerrit-Change-Number: 34272 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Attention: Hoernchen Gerrit-Comment-Date: Tue, 26 Sep 2023 20:36:29 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: pcu: Fail immediately in TC_n3105_max_t3195
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34536?usp=email )
Change subject: pcu: Fail immediately in TC_n3105_max_t3195
..
pcu: Fail immediately in TC_n3105_max_t3195
Change-Id: I55b97037c014478451790e1943c617a634fe2457
---
M pcu/PCU_Tests.ttcn
1 file changed, 19 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/36/34536/1
diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn
index 6917404..45b1883 100644
--- a/pcu/PCU_Tests.ttcn
+++ b/pcu/PCU_Tests.ttcn
@@ -1955,7 +1955,6 @@
var integer N3105 := 0;
timer T_3195 := 1.0 + 0.1; /* 0.1: some extra time to avoid race
conditions between test and IUT */
var integer num_poll_recv := 0;
- var template RlcmacDlBlock dl_block_exp;
/* Initialize NS/BSSGP side */
f_init_bssgp();
@@ -2041,10 +2040,17 @@
log("T_3195 timeout");
/* Done in alt, wait for pending RTS initiated previously in
* above case before continuing (expect empty block): */
- dl_block_exp := omit;
- BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr,
+ alt {
+ [] BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr,
tr_PCUIF_DATA(nr.trx_nr,
nr.ts_nr, sapi := PCU_IF_SAPI_PDTCH),
- dl_block_exp));
+ omit)); /* DONE, continue after
altstep. */
+ [] BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr,
+ tr_PCUIF_DATA(nr.trx_nr,
nr.ts_nr, sapi := PCU_IF_SAPI_PDTCH),
+ tr_RLCMAC_DL_DUMMY_CTRL)) {
+ setverdict(fail, "Rx unexpected DUMMY message, expected
empty data block");
+ f_shutdown(__BFILE__, __LINE__);
+ }
+ }
}
[] BTS.receive {
setverdict(fail, "Unexpected BTS message");
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34536?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I55b97037c014478451790e1943c617a634fe2457
Gerrit-Change-Number: 34536
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-MessageType: newchange
[S] Change in osmo-ttcn3-hacks[master]: WIP
pespin has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34535?usp=email ) Change subject: WIP .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34535?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idd821049315ae4d0cf83f551d5fc1f2961545291 Gerrit-Change-Number: 34535 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-CC: Jenkins Builder Gerrit-MessageType: abandon
[S] Change in osmo-ttcn3-hacks[master]: WIP
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34535?usp=email ) Change subject: WIP .. WIP Change-Id: Idd821049315ae4d0cf83f551d5fc1f2961545291 --- M pcu/PCU_Tests.ttcn 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/35/34535/1 diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index 012a0be..6917404 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -1953,7 +1953,7 @@ var GprsMS ms; const integer N3105_MAX := 2; var integer N3105 := 0; - timer T_3195 := 1.0; + timer T_3195 := 1.0 + 0.1; /* 0.1: some extra time to avoid race conditions between test and IUT */ var integer num_poll_recv := 0; var template RlcmacDlBlock dl_block_exp; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34535?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idd821049315ae4d0cf83f551d5fc1f2961545291 Gerrit-Change-Number: 34535 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange
[S] Change in osmocom-bb[master]: modem: fix grr_st_packet_access_action(): shift rr->cr_hist properly
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34534?usp=email ) Change subject: modem: fix grr_st_packet_access_action(): shift rr->cr_hist properly .. modem: fix grr_st_packet_access_action(): shift rr->cr_hist properly Pass size in bytes to memcpy(), not number of elements! Change-Id: I687435f5458e766d9d61143d6e4255f089fe1caf Fixes: 6db5f8b9c "modem: get rid of app_data.chan_req, use ms->rrlayer" Related: OS#5500, OS#6131 --- M src/host/layer23/src/modem/grr.c 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/host/layer23/src/modem/grr.c b/src/host/layer23/src/modem/grr.c index a029dd8..4e29909 100644 --- a/src/host/layer23/src/modem/grr.c +++ b/src/host/layer23/src/modem/grr.c @@ -688,7 +688,8 @@ } /* shift the CHANNEL REQUEST history buffer */ - memmove(>cr_hist[1], >cr_hist[0], ARRAY_SIZE(rr->cr_hist) - 1); + memmove(>cr_hist[1], >cr_hist[0], + sizeof(rr->cr_hist) - sizeof(rr->cr_hist[0])); /* store the new entry */ rr->cr_hist[0].ref = *ref; rr->cr_hist[0].ref.ra = rr->cr_ra; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34534?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I687435f5458e766d9d61143d6e4255f089fe1caf Gerrit-Change-Number: 34534 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged
[L] Change in osmocom-bb[master]: ASCI: Add group receive and transmit mode support to MM layer
Attention is currently required from: jolly.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/34492?usp=email )
Change subject: ASCI: Add group receive and transmit mode support to MM layer
..
Patch Set 8:
(3 comments)
File src/host/layer23/src/mobile/gsm48_mm.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/34492/comment/10ea07b5_7619540d
PS8, Line 4643: if (rr_prim != -1) {
Doing `goto` from the `default` branch above might be a more elegant solution.
(Gerrit highlighting is rather confusing, it looks as if the whole block was
changed, but actually it was only shifted right).
https://gerrit.osmocom.org/c/osmocom-bb/+/34492/comment/53ededef_24de43e8
PS8, Line 4813: nothing here
TODO/FIXME?
https://gerrit.osmocom.org/c/osmocom-bb/+/34492/comment/82842821_cdcae8a9
PS8, Line 4851: nothing here
TODO/FIXME?
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34492?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I05957182a57423ad947ab200b52f65fde859e110
Gerrit-Change-Number: 34492
Gerrit-PatchSet: 8
Gerrit-Owner: jolly
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-CC: fixeria
Gerrit-Attention: jolly
Gerrit-Comment-Date: Tue, 26 Sep 2023 15:39:01 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
[XL] Change in osmocom-bb[master]: ASCI: Add group receive mode support to RR layer
Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34531?usp=email ) Change subject: ASCI: Add group receive mode support to RR layer .. Patch Set 3: Code-Review+1 (1 comment) File src/host/layer23/src/mobile/gsm48_rr.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34531/comment/df87faa1_090abc16 PS3, Line 5335: access bursts `an access burst`? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34531?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia7d806b354fb3be5729bff8ac9aa1c7ad7a8b539 Gerrit-Change-Number: 34531 Gerrit-PatchSet: 3 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Tue, 26 Sep 2023 15:31:32 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[L] Change in osmocom-bb[master]: ASCI: Add ASCI notification support to RR layer
Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34530?usp=email ) Change subject: ASCI: Add ASCI notification support to RR layer .. Patch Set 3: Code-Review-1 (10 comments) File src/host/layer23/src/mobile/gsm48_rr.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34530/comment/7ad01536_86ad894e PS3, Line 1331: uint8_t *gcr `const` https://gerrit.osmocom.org/c/osmocom-bb/+/34530/comment/56f2f0ee_e66ae20c PS3, Line 1387: uint8_t *gcr `const` https://gerrit.osmocom.org/c/osmocom-bb/+/34530/comment/7348a4ae_c9178028 PS3, Line 1399: uint8_t *gcr, uint8_t *ch_desc both `const` https://gerrit.osmocom.org/c/osmocom-bb/+/34530/comment/1bf90897_7b7b4b41 PS3, Line 1440: return -ENOMEM; You may be leaking the memory allocated by `asci_notif_alloc()` here. Maybe just use `OSMO_ASSERT(nmsg != NULL)`? NULL is unlikely anyway... https://gerrit.osmocom.org/c/osmocom-bb/+/34530/comment/fc1eebf2_4e6f1fe2 PS3, Line 1461: 5*8 The comment states 36 bits, but you allocate (5 * 8) bytes? I guess you need 5 bytes here, or just `OSMO_BYTES_FOR_BITS(36)`. https://gerrit.osmocom.org/c/osmocom-bb/+/34530/comment/37c943f4_10f54735 PS3, Line 1467: 3*8 Same here, `OSMO_BYTES_FOR_BITS(24)`, because: ``` \param[in] size Number of bytes in the vector ``` https://gerrit.osmocom.org/c/osmocom-bb/+/34530/comment/f2581c45_059f561f PS3, Line 1473: \n This is going to break the logstring formatting, better use just one `\n`. https://gerrit.osmocom.org/c/osmocom-bb/+/34530/comment/87f6829b_24176fad PS3, Line 1482: if (chd_bv) `bitvec_free()` is NULL safe, so these checks are redundant. https://gerrit.osmocom.org/c/osmocom-bb/+/34530/comment/596ddc34_3dea3de9 PS3, Line 1494: msgb_l3len(msg) - sizeof(*sgh); Is it guaranteed by the caller that `msgb_l3len(msg)` is always `>= sizeof(*sgh)`? If not, we may end up with a negative value here and thus huge bitvec length. AFAICS, it's not (see my comments to 34529). https://gerrit.osmocom.org/c/osmocom-bb/+/34530/comment/5e22edaa_c1637cdf PS3, Line 1519: msgb_l3len(msg) - sizeof(*nn); Same here. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34530?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I49df02cb4d99d9aab1ea3ca13beb2ea00ae4c9f4 Gerrit-Change-Number: 34530 Gerrit-PatchSet: 3 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Tue, 26 Sep 2023 15:18:08 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmocom-bb[master]: modem: fix grr_st_packet_access_action(): shift rr->cr_hist properly
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34534?usp=email ) Change subject: modem: fix grr_st_packet_access_action(): shift rr->cr_hist properly .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34534?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I687435f5458e766d9d61143d6e4255f089fe1caf Gerrit-Change-Number: 34534 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Tue, 26 Sep 2023 15:10:03 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmocom-bb[master]: ASCI: Prepare gsm48_rr_rx_acch for voice group channel
Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34529?usp=email ) Change subject: ASCI: Prepare gsm48_rr_rx_acch for voice group channel .. Patch Set 3: (4 comments) File src/host/layer23/src/mobile/gsm48_rr.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34529/comment/56bd95db_5345a46b PS3, Line 4882: N201_Bter_SACCH These defines can also be found is libosmocore.git. But I see that they're not in a header file, unfortunately. https://gerrit.osmocom.org/c/osmocom-bb/+/34529/comment/89ef37d5_0ec61e83 PS3, Line 4889: struct gsm48_system_information_type_header *sih; : struct gsm48_hdr_sh *sgh; : struct gsm48_hdr *gh; all `const`? https://gerrit.osmocom.org/c/osmocom-bb/+/34529/comment/a4121561_73e6e496 PS3, Line 4895: sgh = msgb_l3(msg); do we want to check `if (msgb_l3len(msg) < sizeof(*sgh))` here? https://gerrit.osmocom.org/c/osmocom-bb/+/34529/comment/d194695f_932eac3a PS3, Line 4909: sih = msgb_l3(msg); do we want to check `if (msgb_l3len(msg) < sizeof(*sih))` here? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34529?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I39b27396a31137b3c4bdcb40dccdf3de60458fe2 Gerrit-Change-Number: 34529 Gerrit-PatchSet: 3 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: jolly Gerrit-Comment-Date: Tue, 26 Sep 2023 14:50:48 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[S] Change in osmocom-bb[master]: ASCI: Add interface for group receive/transmit mode support to RR layer
Attention is currently required from: jolly, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34528?usp=email ) Change subject: ASCI: Add interface for group receive/transmit mode support to RR layer .. Patch Set 3: Code-Review+2 (1 comment) Patchset: PS3: > As usually, I'd really like to get these introduced in the same patch where > they are used. Do you want to spend hours reviewing one bomb patch? It's easier to review stuff when it's split across multiple commits, and looks like this was exactly the goal here. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34528?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1abd56c63d15af1cff8bde7589a571cb5bb5506f Gerrit-Change-Number: 34528 Gerrit-PatchSet: 3 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Attention: jolly Gerrit-Attention: pespin Gerrit-Comment-Date: Tue, 26 Sep 2023 14:41:57 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[S] Change in osmocom-bb[master]: ASCI: Add channel notification event to MM events
Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34488?usp=email ) Change subject: ASCI: Add channel notification event to MM events .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34488?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ifee286ba4628356cc19b5dc75f1843287c5d2342 Gerrit-Change-Number: 34488 Gerrit-PatchSet: 8 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Tue, 26 Sep 2023 14:36:55 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmocom-bb[master]: Fix request reference value in gsm48_match_ra()
Attention is currently required from: jolly, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34486?usp=email ) Change subject: Fix request reference value in gsm48_match_ra() .. Patch Set 8: (1 comment) File src/host/layer23/src/mobile/gsm48_rr.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34486/comment/11748ca5_cfde56b7 PS8, Line 2365: struct gsm48_req_ref *ref I believe we would not have such a bug if this pointer was `const`. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34486?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iec636d368e20030beac2861bff61b1a06e7b4821 Gerrit-Change-Number: 34486 Gerrit-PatchSet: 8 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Attention: pespin Gerrit-Comment-Date: Tue, 26 Sep 2023 14:35:02 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[S] Change in osmocom-bb[master]: Fix request reference value in gsm48_match_ra()
Attention is currently required from: jolly, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34486?usp=email ) Change subject: Fix request reference value in gsm48_match_ra() .. Patch Set 8: Code-Review+2 (1 comment) File src/host/layer23/src/mobile/gsm48_rr.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34486/comment/5223fa4c_d096097e PS5, Line 2377: ia_t1 = ref->t1; > There was a space in front of the third tab. Thanks for clarifying. I just found out that Gerrit does show this, but only when using the `Unified diff` instead of `Side-by-side diff`. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34486?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iec636d368e20030beac2861bff61b1a06e7b4821 Gerrit-Change-Number: 34486 Gerrit-PatchSet: 8 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Attention: pespin Gerrit-Comment-Date: Tue, 26 Sep 2023 14:30:50 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: jolly Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[S] Change in osmocom-bb[master]: modem: fix grr_st_packet_access_action(): shift rr->cr_hist properly
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34534?usp=email ) Change subject: modem: fix grr_st_packet_access_action(): shift rr->cr_hist properly .. modem: fix grr_st_packet_access_action(): shift rr->cr_hist properly Pass size in bytes to memcpy(), not number of elements! Change-Id: I687435f5458e766d9d61143d6e4255f089fe1caf Fixes: 6db5f8b9c "modem: get rid of app_data.chan_req, use ms->rrlayer" Related: OS#5500, OS#6131 --- M src/host/layer23/src/modem/grr.c 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/34/34534/1 diff --git a/src/host/layer23/src/modem/grr.c b/src/host/layer23/src/modem/grr.c index a029dd8..4e29909 100644 --- a/src/host/layer23/src/modem/grr.c +++ b/src/host/layer23/src/modem/grr.c @@ -688,7 +688,8 @@ } /* shift the CHANNEL REQUEST history buffer */ - memmove(>cr_hist[1], >cr_hist[0], ARRAY_SIZE(rr->cr_hist) - 1); + memmove(>cr_hist[1], >cr_hist[0], + sizeof(rr->cr_hist) - sizeof(rr->cr_hist[0])); /* store the new entry */ rr->cr_hist[0].ref = *ref; rr->cr_hist[0].ref.ra = rr->cr_ra; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34534?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I687435f5458e766d9d61143d6e4255f089fe1caf Gerrit-Change-Number: 34534 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
[S] Change in osmo-pcu[master]: pdch_ul_controller: migrate from fn_cmp() to gsm0502_fncmp()
fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/34521?usp=email )
Change subject: pdch_ul_controller: migrate from fn_cmp() to gsm0502_fncmp()
..
pdch_ul_controller: migrate from fn_cmp() to gsm0502_fncmp()
This function is also needed in osmocom-bb.git, so it becomes
a library function (part of libosmogsm).
Change-Id: I6a8502c2b2015ca7d0452ab9f5da0484a03ce91e
Depends: libosmocore.git I9590f2e836fc48650decf1564b6ab46306c4fe2d
Depends: libosmocore.git Ie8bb9c49c6f81b8f4a1766547d6943f9880d1186
---
M TODO-RELEASE
M src/pdch_ul_controller.c
2 files changed, 21 insertions(+), 18 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, approved
diff --git a/TODO-RELEASE b/TODO-RELEASE
index cbfda24..73ad83b 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -7,3 +7,4 @@
# If any interfaces have been added since the last public release: c:r:a + 1.
# If any interfaces have been removed or changed since the last public
release: c:r:0.
#librarywhatdescription / commit summary line
+libosmocore > 1.9.0added gsm0502_fncmp()
diff --git a/src/pdch_ul_controller.c b/src/pdch_ul_controller.c
index c0e26de..661957b 100644
--- a/src/pdch_ul_controller.c
+++ b/src/pdch_ul_controller.c
@@ -17,6 +17,8 @@
#include
#include
+#include
+
#include "pdch_ul_controller.h"
#include "bts.h"
#include "sba.h"
@@ -43,20 +45,6 @@
{ 0, NULL }
};
-#define GSM_MAX_FN_THRESH (GSM_MAX_FN >> 1)
-/* 0: equal, -1: fn1 BEFORE fn2, 1: fn1 AFTER fn2 */
-static inline int fn_cmp(uint32_t fn1, uint32_t fn2)
-{
- if (fn1 == fn2)
- return 0;
- /* FN1 goes before FN2: */
- if ((fn1 < fn2 && (fn2 - fn1) < GSM_MAX_FN_THRESH) ||
- (fn1 > fn2 && (fn1 - fn2) > GSM_MAX_FN_THRESH))
- return -1;
- /* FN1 goes after FN2: */
- return 1;
-}
-
struct pdch_ulc *pdch_ulc_alloc(struct gprs_rlcmac_pdch *pdch, void *ctx)
{
struct pdch_ulc* ulc;
@@ -78,7 +66,7 @@
while (node) {
it = rb_entry(node, struct pdch_ulc_node, node);
- res = fn_cmp(it->fn, fn);
+ res = gsm0502_fncmp(it->fn, fn);
if (res > 0) /* it->fn AFTER fn */
node = node->rb_left;
else if (res < 0) /* it->fn BEFORE fn */
@@ -167,7 +155,7 @@
for (node = rb_first(>tree_root); node; node = rb_next(node)) {
it = container_of(node, struct pdch_ulc_node, node);
- res = fn_cmp(it->fn, check_fn);
+ res = gsm0502_fncmp(it->fn, check_fn);
if (res > 0) { /* it->fn AFTER check_fn */
/* Next reserved FN is passed check_fn, hence it means
check_fn is free */
return check_fn;
@@ -203,7 +191,7 @@
it = container_of(*n, struct pdch_ulc_node, node);
parent = *n;
- res = fn_cmp(item->fn, it->fn);
+ res = gsm0502_fncmp(item->fn, it->fn);
if (res < 0) { /* item->fn "BEFORE" it->fn */
n = &((*n)->rb_left);
} else if (res > 0) { /* item->fn "AFTER" it->fn */
@@ -305,7 +293,7 @@
struct rb_node *first;
while ((first = rb_first(>tree_root))) {
item = container_of(first, struct pdch_ulc_node, node);
- res = fn_cmp(item->fn, fn);
+ res = gsm0502_fncmp(item->fn, fn);
if (res > 0) /* item->fn AFTER fn */
break;
if (res < 0) { /* item->fn BEFORE fn */
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34521?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I6a8502c2b2015ca7d0452ab9f5da0484a03ce91e
Gerrit-Change-Number: 34521
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
[S] Change in osmo-pcu[master]: bts: bts_tfi_find_free(): fix -Wmaybe-uninitialized (false positive)
fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/34533?usp=email )
Change subject: bts: bts_tfi_find_free(): fix -Wmaybe-uninitialized (false
positive)
..
bts: bts_tfi_find_free(): fix -Wmaybe-uninitialized (false positive)
We cannot see how uninitialized access is possible, but gcc v13.2.1
does complain about it. Let's work this around by assigning an
invalid value, like trx_count_free_tfi() does.
src/bts.cpp: In function 'int bts_tfi_find_free(const gprs_rlcmac_bts*,
gprs_rlcmac_tbf_direction,
uint8_t*, int8_t)':
warning: 'tmp_first_tfi' may be used uninitialized [-Wmaybe-uninitialized]
Change-Id: Ia446cdf573ee25e6da6b4aa917972c63472229bb
Fixes: OS#6190
---
M src/bts.cpp
1 file changed, 20 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, approved
diff --git a/src/bts.cpp b/src/bts.cpp
index 0950f7a..50c21a3 100644
--- a/src/bts.cpp
+++ b/src/bts.cpp
@@ -642,7 +642,7 @@
/* find a TFI that is unused on all PDCH */
for (trx = trx_from; trx <= trx_to; trx++) {
- uint8_t tmp_first_tfi;
+ uint8_t tmp_first_tfi = 0xff; /* make gcc happy */
unsigned int tmp_cnt;
tmp_cnt = trx_count_free_tfi(>trx[trx], dir,
_first_tfi);
if (tmp_cnt > best_cnt) {
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34533?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ia446cdf573ee25e6da6b4aa917972c63472229bb
Gerrit-Change-Number: 34533
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
[M] Change in osmocom-bb[master]: trxcon/l1sched: rework dequeueing of PDCH Tx prims
fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/34523?usp=email )
Change subject: trxcon/l1sched: rework dequeueing of PDCH Tx prims
..
trxcon/l1sched: rework dequeueing of PDCH Tx prims
When an UL BLOCK.req is received late, i.e. after the first Tx burst
of the respective TDMA Fn was requested by the PHY, a domino effect
can be observed: the stale Tx primitive remains in the queue and
prevents transmission of the next primitive, even if the later was
received in time. This breaks transmission of consecutive UL blocks.
Don't let stale primitives poison the Tx queue: drop them like before,
but keep looking for a primitive with the matching TDMA Fn. If found
a primitive with TDMA Fn past the current one, stop the iteration.
Change-Id: I439615639b8e840b9fd4f3af6934d9f298f32216
Depends: libosmocore.git I9590f2e836fc48650decf1564b6ab46306c4fe2d
Depends: libosmocore.git Ie8bb9c49c6f81b8f4a1766547d6943f9880d1186
Related: OS#5500
---
M src/host/trxcon/src/sched_lchan_pdtch.c
1 file changed, 40 insertions(+), 12 deletions(-)
Approvals:
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, but someone else must approve
Jenkins Builder: Verified
fixeria: Looks good to me, approved
diff --git a/src/host/trxcon/src/sched_lchan_pdtch.c
b/src/host/trxcon/src/sched_lchan_pdtch.c
index 0f8a25f..915b060 100644
--- a/src/host/trxcon/src/sched_lchan_pdtch.c
+++ b/src/host/trxcon/src/sched_lchan_pdtch.c
@@ -26,6 +26,7 @@
#include
#include
+#include
#include
#include
#include
@@ -104,20 +105,25 @@
static struct msgb *prim_dequeue_pdtch(struct l1sched_lchan_state *lchan,
uint32_t fn)
{
- const struct l1sched_prim *prim;
- struct msgb *msg;
+ while (!llist_empty(>tx_prims)) {
+ struct msgb *msg = llist_first_entry(>tx_prims, struct
msgb, list);
+ const struct l1sched_prim *prim = l1sched_prim_from_msgb(msg);
+ int ret = gsm0502_fncmp(prim->data_req.frame_nr, fn);
- msg = msgb_dequeue(>tx_prims);
- if (msg == NULL)
- return NULL;
- prim = l1sched_prim_from_msgb(msg);
+ if (OSMO_LIKELY(ret == 0)) { /* it's a match! */
+ llist_del(>list);
+ return msg;
+ } else if (ret > 0) { /* not now, come back later */
+ break;
+ } /* else: the ship has sailed, drop your ticket */
- if (OSMO_LIKELY(prim->data_req.frame_nr == fn))
- return msg;
- LOGP_LCHAND(lchan, LOGL_ERROR,
- "%s(): dropping Tx primitive (current Fn=%u, prim Fn=%u)\n",
- __func__, fn, prim->data_req.frame_nr);
- msgb_free(msg);
+ LOGP_LCHAND(lchan, LOGL_ERROR,
+ "%s(): dropping stale Tx primitive (current Fn=%u,
prim Fn=%u)\n",
+ __func__, fn, prim->data_req.frame_nr);
+ llist_del(>list);
+ msgb_free(msg);
+ }
+
return NULL;
}
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34523?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I439615639b8e840b9fd4f3af6934d9f298f32216
Gerrit-Change-Number: 34523
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
[S] Change in osmocom-bb[master]: l1gprs: migrate to gsm0502_fncmp() from libosmogsm
fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/34522?usp=email )
Change subject: l1gprs: migrate to gsm0502_fncmp() from libosmogsm
..
l1gprs: migrate to gsm0502_fncmp() from libosmogsm
Change-Id: I10261aa114b5dce3efee26ea84a1caa50c49a1d2
Depends: libosmocore.git I9590f2e836fc48650decf1564b6ab46306c4fe2d
Depends: libosmocore.git Ie8bb9c49c6f81b8f4a1766547d6943f9880d1186
Related: OS#5500
---
M src/shared/l1gprs.c
1 file changed, 13 insertions(+), 14 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, approved
diff --git a/src/shared/l1gprs.c b/src/shared/l1gprs.c
index bfbda59..3294a42 100644
--- a/src/shared/l1gprs.c
+++ b/src/shared/l1gprs.c
@@ -344,19 +344,6 @@
LOG_TBF_ARGS(preq), preq->start_fn);
}
-/* Check if the current TDMA Fn is past the start TDMA Fn.
- * Based on fn_cmp() implementation from osmo-pcu.git, simplified. */
-static bool l1gprs_check_fn(uint32_t current, uint32_t start)
-{
- const uint32_t thresh = GSM_TDMA_HYPERFRAME / 2;
-
- if ((current < start && (start - current) < thresh) ||
- (current > start && (current - start) > thresh))
- return false;
-
- return true;
-}
-
/* Check the list of pending TBFs and move those with expired Fn to the active
list */
static void l1gprs_check_pending_tbfs(struct l1gprs_state *gprs, uint32_t fn)
{
@@ -364,7 +351,7 @@
struct l1gprs_tbf *tbf;
llist_for_each_entry_safe(preq, tmp, >tbf_list_pending, list) {
- if (!l1gprs_check_fn(fn, preq->start_fn))
+ if (gsm0502_fncmp(fn, preq->start_fn) < 0)
continue;
LOGP_GPRS(gprs, LOGL_INFO,
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34522?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I10261aa114b5dce3efee26ea84a1caa50c49a1d2
Gerrit-Change-Number: 34522
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-MessageType: merged
[M] Change in osmocom-bb[master]: Refactoring encoding of mobile identity at mobile application
Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34484?usp=email ) Change subject: Refactoring encoding of mobile identity at mobile application .. Patch Set 7: Code-Review+1 (2 comments) Patchset: PS7: BTW, this is already the 2nd time we're migrating from old deprecated to a new (not yet deprecated) API. Let's see how long this new API will last :P File src/host/layer23/include/osmocom/bb/mobile/gsm48_mm.h: https://gerrit.osmocom.org/c/osmocom-bb/+/34484/comment/d6b33307_18808dba PS7, Line 243: gsm48_encode_mi_lv I am afraid we may end up having a naming conflict with libosmocore some day, since I am seeing plenty of `gsm48_encode_*` symbols in there. Not blocking, just wanted to point this out. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34484?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9ff429bd50d718530fdad64a276053a35c8928f2 Gerrit-Change-Number: 34484 Gerrit-PatchSet: 7 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Tue, 26 Sep 2023 14:14:10 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmocom-bb[master]: ASCI: Add UIC support to random access burst
Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34482?usp=email ) Change subject: ASCI: Add UIC support to random access burst .. Patch Set 7: (1 comment) File src/target/firmware/layer1/prim_rach.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34482/comment/733afdd5_65412408 PS7, Line 135: int8_t unsigned -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34482?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I4039734676949aefa5be4b5298764b8ba7e1b8ed Gerrit-Change-Number: 34482 Gerrit-PatchSet: 7 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: jolly Gerrit-Comment-Date: Tue, 26 Sep 2023 14:05:02 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
Attention is currently required from: arehbein, daniel, fixeria, osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email ) Change subject: stream: Add client-side (segmentation) support for IPA .. Patch Set 21: Code-Review+1 (3 comments) Patchset: PS20: > After adapting `stream_test. […] Is this just about the test? Are we using REUSEADDR and/or REUSEPORT? Patchset: PS21: > The plan is to tackle this kind of task once these preliminary libosmo-netif > changes have been submi […] Done PS21: > The patch for fixing the aliasing problem has been merged. […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 21 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: osmith Gerrit-Attention: osmith Gerrit-Attention: arehbein Gerrit-Attention: fixeria Gerrit-Attention: daniel Gerrit-Comment-Date: Tue, 26 Sep 2023 14:01:22 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith Comment-In-Reply-To: arehbein Comment-In-Reply-To: laforge Comment-In-Reply-To: daniel Gerrit-MessageType: comment
[S] Change in osmocom-bb[master]: Transmit access bursts on DCCH of TCH channels
Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34481?usp=email ) Change subject: Transmit access bursts on DCCH of TCH channels .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34481?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1a972d9bac5749c67c1b139825400854f7cf1490 Gerrit-Change-Number: 34481 Gerrit-PatchSet: 7 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Tue, 26 Sep 2023 14:00:56 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmocom-bb[master]: ASCI: Show NCH position in VTY together with system information
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34496?usp=email ) Change subject: ASCI: Show NCH position in VTY together with system information .. Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34496?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I5e0a9d469eb70608502dca881808621fa153b666 Gerrit-Change-Number: 34496 Gerrit-PatchSet: 9 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Tue, 26 Sep 2023 13:59:10 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[L] Change in osmocom-bb[master]: ASCI: Add group receive and transmit mode support to MM layer
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34492?usp=email ) Change subject: ASCI: Add group receive and transmit mode support to MM layer .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34492?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I05957182a57423ad947ab200b52f65fde859e110 Gerrit-Change-Number: 34492 Gerrit-PatchSet: 8 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Tue, 26 Sep 2023 13:58:55 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmocom-bb[master]: ASCI: Add a flag to turn transmitter off or on
Attention is currently required from: jolly, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34479?usp=email ) Change subject: ASCI: Add a flag to turn transmitter off or on .. Patch Set 7: Code-Review+2 (1 comment) File include/l1ctl_proto.h: https://gerrit.osmocom.org/c/osmocom-bb/+/34479/comment/90ecf100_14a41550 PS5, Line 217: uint8_t tch_flags; > I decided to move the tch_flags to the end of the structures. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34479?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I20133523adc3b204cd2181bfe664fe66020a10e3 Gerrit-Change-Number: 34479 Gerrit-PatchSet: 7 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Attention: pespin Gerrit-Comment-Date: Tue, 26 Sep 2023 13:58:49 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: jolly Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[XL] Change in osmocom-bb[master]: ASCI: Add group receive mode support to RR layer
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34531?usp=email ) Change subject: ASCI: Add group receive mode support to RR layer .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34531?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia7d806b354fb3be5729bff8ac9aa1c7ad7a8b539 Gerrit-Change-Number: 34531 Gerrit-PatchSet: 3 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Tue, 26 Sep 2023 13:58:37 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[L] Change in osmocom-bb[master]: ASCI: Add ASCI notification support to RR layer
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34530?usp=email ) Change subject: ASCI: Add ASCI notification support to RR layer .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34530?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I49df02cb4d99d9aab1ea3ca13beb2ea00ae4c9f4 Gerrit-Change-Number: 34530 Gerrit-PatchSet: 3 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Tue, 26 Sep 2023 13:58:25 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmocom-bb[master]: ASCI: Prepare gsm48_rr_rx_acch for voice group channel
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34529?usp=email ) Change subject: ASCI: Prepare gsm48_rr_rx_acch for voice group channel .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34529?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I39b27396a31137b3c4bdcb40dccdf3de60458fe2 Gerrit-Change-Number: 34529 Gerrit-PatchSet: 3 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Tue, 26 Sep 2023 13:57:27 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmocom-bb[master]: ASCI: Add interface for group receive/transmit mode support to RR layer
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34528?usp=email ) Change subject: ASCI: Add interface for group receive/transmit mode support to RR layer .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34528?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1abd56c63d15af1cff8bde7589a571cb5bb5506f Gerrit-Change-Number: 34528 Gerrit-PatchSet: 3 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Tue, 26 Sep 2023 13:57:14 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmocom-bb[master]: ASCI: Add channel notification event to MM events
Attention is currently required from: fixeria, jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34488?usp=email ) Change subject: ASCI: Add channel notification event to MM events .. Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34488?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ifee286ba4628356cc19b5dc75f1843287c5d2342 Gerrit-Change-Number: 34488 Gerrit-PatchSet: 8 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: jolly Gerrit-Attention: fixeria Gerrit-Comment-Date: Tue, 26 Sep 2023 13:56:49 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmocom-bb[master]: Transmit access bursts on DCCH of TCH channels
Attention is currently required from: fixeria, jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34481?usp=email ) Change subject: Transmit access bursts on DCCH of TCH channels .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34481?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1a972d9bac5749c67c1b139825400854f7cf1490 Gerrit-Change-Number: 34481 Gerrit-PatchSet: 7 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: jolly Gerrit-Attention: fixeria Gerrit-Comment-Date: Tue, 26 Sep 2023 13:55:35 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmocom-bb[master]: ASCI: Increase channel request history to 5 entries
Attention is currently required from: fixeria, jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34485?usp=email ) Change subject: ASCI: Increase channel request history to 5 entries .. Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34485?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I62f18685bf05663f3ee6e94f6884ffb9a6b07ea4 Gerrit-Change-Number: 34485 Gerrit-PatchSet: 8 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: jolly Gerrit-Attention: fixeria Gerrit-Comment-Date: Tue, 26 Sep 2023 13:56:33 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmocom-bb[master]: Refactoring encoding of mobile identity at mobile application
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34484?usp=email ) Change subject: Refactoring encoding of mobile identity at mobile application .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34484?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9ff429bd50d718530fdad64a276053a35c8928f2 Gerrit-Change-Number: 34484 Gerrit-PatchSet: 7 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Tue, 26 Sep 2023 13:56:22 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmocom-bb[master]: ASCI: Add support flags to mobile (and VTY) for VGCS/VBS
Attention is currently required from: fixeria, jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34483?usp=email ) Change subject: ASCI: Add support flags to mobile (and VTY) for VGCS/VBS .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34483?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia23eb190e533660cce4ba4c856a83b5f3d534202 Gerrit-Change-Number: 34483 Gerrit-PatchSet: 7 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Attention: fixeria Gerrit-Comment-Date: Tue, 26 Sep 2023 13:56:02 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmocom-bb[master]: ASCI: Add UIC support to random access burst
Attention is currently required from: fixeria, jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34482?usp=email ) Change subject: ASCI: Add UIC support to random access burst .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34482?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I4039734676949aefa5be4b5298764b8ba7e1b8ed Gerrit-Change-Number: 34482 Gerrit-PatchSet: 7 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: jolly Gerrit-Attention: fixeria Gerrit-Comment-Date: Tue, 26 Sep 2023 13:55:51 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmocom-bb[master]: ASCI: Add a flag to turn transmitter off or on
Attention is currently required from: fixeria, jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34479?usp=email ) Change subject: ASCI: Add a flag to turn transmitter off or on .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34479?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I20133523adc3b204cd2181bfe664fe66020a10e3 Gerrit-Change-Number: 34479 Gerrit-PatchSet: 7 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Attention: fixeria Gerrit-Comment-Date: Tue, 26 Sep 2023 13:55:16 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmocom-bb[master]: trxcon/l1sched: rework dequeueing of PDCH Tx prims
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34523?usp=email ) Change subject: trxcon/l1sched: rework dequeueing of PDCH Tx prims .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34523?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I439615639b8e840b9fd4f3af6934d9f298f32216 Gerrit-Change-Number: 34523 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 26 Sep 2023 13:55:15 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmocom-bb[master]: l1gprs: migrate to gsm0502_fncmp() from libosmogsm
Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34522?usp=email ) Change subject: l1gprs: migrate to gsm0502_fncmp() from libosmogsm .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34522?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I10261aa114b5dce3efee26ea84a1caa50c49a1d2 Gerrit-Change-Number: 34522 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Attention: laforge Gerrit-Comment-Date: Tue, 26 Sep 2023 13:55:12 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[L] Change in osmocom-bb[master]: ASCI: Add GCC/BCC (call control) to mobility management
Attention is currently required from: fixeria, jolly, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34476?usp=email ) Change subject: ASCI: Add GCC/BCC (call control) to mobility management .. Patch Set 5: Code-Review+2 (1 comment) File src/host/layer23/src/mobile/gsm48_mm.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34476/comment/288f419a_4c948334 PS3, Line 789: case GSM48_MMGCC_CLASS: > This is where the receive function for GCC and BCC (call control) is added in > a later patch. Done -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34476?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If6f3cea4b2ca839559596a6ee5a3d169c6d85dbe Gerrit-Change-Number: 34476 Gerrit-PatchSet: 5 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Attention: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Tue, 26 Sep 2023 13:53:47 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: jolly Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[M] Change in osmocom-bb[master]: ASCI: Get timing advance and TX power only when included
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34477?usp=email ) Change subject: ASCI: Get timing advance and TX power only when included .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34477?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I87fcd44bba221ab4c5fbd2c79557db2444a10b88 Gerrit-Change-Number: 34477 Gerrit-PatchSet: 6 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Tue, 26 Sep 2023 13:54:07 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmocom-bb[master]: ASCI: MM connections are defined by 'ref' and 'protocol' tuple
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34478?usp=email ) Change subject: ASCI: MM connections are defined by 'ref' and 'protocol' tuple .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34478?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic280cd8c60077bb2c2ef641f4cddd3b36eee Gerrit-Change-Number: 34478 Gerrit-PatchSet: 7 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Tue, 26 Sep 2023 13:54:20 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmocom-bb[master]: trxcon/l1sched: rework dequeueing of PDCH Tx prims
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34523?usp=email ) Change subject: trxcon/l1sched: rework dequeueing of PDCH Tx prims .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34523?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I439615639b8e840b9fd4f3af6934d9f298f32216 Gerrit-Change-Number: 34523 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Tue, 26 Sep 2023 13:52:38 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-pcu[master]: pdch_ul_controller: migrate from fn_cmp() to gsm0502_fncmp()
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34521?usp=email ) Change subject: pdch_ul_controller: migrate from fn_cmp() to gsm0502_fncmp() .. Patch Set 5: (1 comment) Patchset: PS3: > missing update to TODO-RELEASE Done -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34521?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6a8502c2b2015ca7d0452ab9f5da0484a03ce91e Gerrit-Change-Number: 34521 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: pespin Gerrit-Comment-Date: Tue, 26 Sep 2023 13:49:31 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[S] Change in osmo-pcu[master]: pdch_ul_controller: migrate from fn_cmp() to gsm0502_fncmp()
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34521?usp=email ) Change subject: pdch_ul_controller: migrate from fn_cmp() to gsm0502_fncmp() .. Patch Set 4: (1 comment) File TODO-RELEASE: https://gerrit.osmocom.org/c/osmo-pcu/+/34521/comment/e2204b9d_66d03311 PS4, Line 10: libosmogsmgsm0502_fncmp() Ie8bb9c49c6f81b8f4a1766547d6943f9880d1186 > Please put "libosmocore > 1.9.0", the Change Id is not needed. Then feel free > to merge. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34521?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6a8502c2b2015ca7d0452ab9f5da0484a03ce91e Gerrit-Change-Number: 34521 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: pespin Gerrit-Comment-Date: Tue, 26 Sep 2023 13:49:17 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[S] Change in osmo-pcu[master]: bts: bts_tfi_find_free(): fix -Wmaybe-uninitialized (false positive)
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34533?usp=email ) Change subject: bts: bts_tfi_find_free(): fix -Wmaybe-uninitialized (false positive) .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34533?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia446cdf573ee25e6da6b4aa917972c63472229bb Gerrit-Change-Number: 34533 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria Gerrit-Comment-Date: Tue, 26 Sep 2023 13:47:08 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-pcu[master]: pdch_ul_controller: migrate from fn_cmp() to gsm0502_fncmp()
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34521?usp=email ) Change subject: pdch_ul_controller: migrate from fn_cmp() to gsm0502_fncmp() .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34521?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6a8502c2b2015ca7d0452ab9f5da0484a03ce91e Gerrit-Change-Number: 34521 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Tue, 26 Sep 2023 13:46:18 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-pcu[master]: bts: bts_tfi_find_free(): fix -Wmaybe-uninitialized (false positive)
fixeria has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-pcu/+/34533?usp=email ) Change subject: bts: bts_tfi_find_free(): fix -Wmaybe-uninitialized (false positive) .. bts: bts_tfi_find_free(): fix -Wmaybe-uninitialized (false positive) We cannot see how uninitialized access is possible, but gcc v13.2.1 does complain about it. Let's work this around by assigning an invalid value, like trx_count_free_tfi() does. src/bts.cpp: In function 'int bts_tfi_find_free(const gprs_rlcmac_bts*, gprs_rlcmac_tbf_direction, uint8_t*, int8_t)': warning: 'tmp_first_tfi' may be used uninitialized [-Wmaybe-uninitialized] Change-Id: Ia446cdf573ee25e6da6b4aa917972c63472229bb Fixes: OS#6190 --- M src/bts.cpp 1 file changed, 20 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/33/34533/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34533?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia446cdf573ee25e6da6b4aa917972c63472229bb Gerrit-Change-Number: 34533 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset
[S] Change in osmo-pcu[master]: bts: bts_tfi_find_free(): fix -Wmaybe-uninitialized (false positive)
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-pcu/+/34533?usp=email )
Change subject: bts: bts_tfi_find_free(): fix -Wmaybe-uninitialized (false
positive)
..
bts: bts_tfi_find_free(): fix -Wmaybe-uninitialized (false positive)
We cannot see how uninitialized access is possible, but gcc v13.2.1
does complain about it. Let's work this around by assigning an
invalid value, like trx_count_free_tfi() does.
Change-Id: Ia446cdf573ee25e6da6b4aa917972c63472229bb
Fixes: OS#6190
---
M src/bts.cpp
1 file changed, 15 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/33/34533/1
diff --git a/src/bts.cpp b/src/bts.cpp
index 0950f7a..50c21a3 100644
--- a/src/bts.cpp
+++ b/src/bts.cpp
@@ -642,7 +642,7 @@
/* find a TFI that is unused on all PDCH */
for (trx = trx_from; trx <= trx_to; trx++) {
- uint8_t tmp_first_tfi;
+ uint8_t tmp_first_tfi = 0xff; /* make gcc happy */
unsigned int tmp_cnt;
tmp_cnt = trx_count_free_tfi(>trx[trx], dir,
_first_tfi);
if (tmp_cnt > best_cnt) {
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34533?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ia446cdf573ee25e6da6b4aa917972c63472229bb
Gerrit-Change-Number: 34533
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
[S] Change in osmo-pcu[master]: pdch_ul_controller: migrate from fn_cmp() to gsm0502_fncmp()
Attention is currently required from: fixeria. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/34521?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: pdch_ul_controller: migrate from fn_cmp() to gsm0502_fncmp() .. pdch_ul_controller: migrate from fn_cmp() to gsm0502_fncmp() This function is also needed in osmocom-bb.git, so it becomes a library function (part of libosmogsm). Change-Id: I6a8502c2b2015ca7d0452ab9f5da0484a03ce91e Depends: libosmocore.git I9590f2e836fc48650decf1564b6ab46306c4fe2d Depends: libosmocore.git Ie8bb9c49c6f81b8f4a1766547d6943f9880d1186 --- M TODO-RELEASE M src/pdch_ul_controller.c 2 files changed, 21 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/21/34521/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34521?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6a8502c2b2015ca7d0452ab9f5da0484a03ce91e Gerrit-Change-Number: 34521 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-MessageType: newpatchset
[M] Change in osmo-bsc[master]: sccplite: Support multiple MGW in MGW pool
Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34511?usp=email ) Change subject: sccplite: Support multiple MGW in MGW pool .. Patch Set 1: (7 comments) Patchset: PS1: cosmetics and a log level, otherwise LGTM File src/osmo-bsc/osmo_bsc_mgcp.c: https://gerrit.osmocom.org/c/osmo-bsc/+/34511/comment/082e857d_1f79e967 PS1, Line 59: filled buf size 0 https://gerrit.osmocom.org/c/osmo-bsc/+/34511/comment/333b024b_700de504 PS1, Line 66: if (!eol) cosmetic: new line after the variable definitions? https://gerrit.osmocom.org/c/osmo-bsc/+/34511/comment/46029111_373ba5b7 PS1, Line 121: with https://gerrit.osmocom.org/c/osmo-bsc/+/34511/comment/23fc7974_70958db0 PS1, Line 123: Sine Since https://gerrit.osmocom.org/c/osmo-bsc/+/34511/comment/fc2cf5ec_adc713bc PS1, Line 132: LOGL_NOTICE maybe LOGL_DEBUG? otherwise, if there are multiple mgws in the pool, this will appear quite a lot as I understand https://gerrit.osmocom.org/c/osmo-bsc/+/34511/comment/6d3ac72b_ac801720 PS1, Line 170: indentation -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34511?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia106a21b7692eb5b2ac3b5ac2b358bedbc3b9da6 Gerrit-Change-Number: 34511 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Attention: pespin Gerrit-Comment-Date: Tue, 26 Sep 2023 13:15:52 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[S] Change in libosmo-gprs[master]: rlcmac: Fix compilation error 'rlcmac_prim may be used uninitialized'
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34532?usp=email ) Change subject: rlcmac: Fix compilation error 'rlcmac_prim may be used uninitialized' .. Patch Set 1: Code-Review+2 (1 comment) File src/rlcmac/tbf_ul_ass_fsm.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/34532/comment/d99e3269_e3952b72 PS1, Line 121: default > For the record: I intentionally did not add the `default` branch, because I > expected that a warning […] Perhaps the following like triggers the compiler: ``` ctx->ass_type = *(enum gprs_rlcmac_tbf_ul_ass_type *)data; ``` -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34532?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ica93447bc1f2e60984be7c9c73b153b4eb508aaa Gerrit-Change-Number: 34532 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Attention: pespin Gerrit-Comment-Date: Tue, 26 Sep 2023 12:55:02 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria Gerrit-MessageType: comment
[S] Change in libosmo-gprs[master]: rlcmac: Fix compilation error 'rlcmac_prim may be used uninitialized'
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34532?usp=email ) Change subject: rlcmac: Fix compilation error 'rlcmac_prim may be used uninitialized' .. rlcmac: Fix compilation error 'rlcmac_prim may be used uninitialized' Change-Id: Ica93447bc1f2e60984be7c9c73b153b4eb508aaa --- M src/rlcmac/tbf_ul_ass_fsm.c 1 file changed, 12 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/rlcmac/tbf_ul_ass_fsm.c b/src/rlcmac/tbf_ul_ass_fsm.c index 64797aa..b1be58c 100644 --- a/src/rlcmac/tbf_ul_ass_fsm.c +++ b/src/rlcmac/tbf_ul_ass_fsm.c @@ -118,7 +118,9 @@ LOGPFSML(ctx->fi, LOGL_INFO, "Requesting two-phase packet access using CCCH\n"); rlcmac_prim = gprs_rlcmac_prim_alloc_l1ctl_rach8_req(0x70); break; - /* TODO: EGPRS specific modes (11-bit RACH) */ + default: + /* TODO: EGPRS specific modes (11-bit RACH) */ + return -ENOTSUP; } return gprs_rlcmac_prim_call_down_cb(rlcmac_prim); -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34532?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ica93447bc1f2e60984be7c9c73b153b4eb508aaa Gerrit-Change-Number: 34532 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-MessageType: merged
[S] Change in libosmo-gprs[master]: rlcmac: Fix compilation error 'rlcmac_prim may be used uninitialized'
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34532?usp=email ) Change subject: rlcmac: Fix compilation error 'rlcmac_prim may be used uninitialized' .. Patch Set 1: Code-Review+1 (2 comments) Commit Message: https://gerrit.osmocom.org/c/libosmo-gprs/+/34532/comment/f206c296_be149194 PS1, Line 7: error Is it really an error? Or a warning that becomes an error when building with `--disable-werror`? File src/rlcmac/tbf_ul_ass_fsm.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/34532/comment/1378440f_5568a280 PS1, Line 121: default For the record: I intentionally did not add the `default` branch, because I expected that a warning would be thrown whenever a new enum item is added to `enum gprs_rlcmac_tbf_ul_ass_type`. I think I also did this in other projects. But looks like the compiler is over defensive here :/ -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34532?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ica93447bc1f2e60984be7c9c73b153b4eb508aaa Gerrit-Change-Number: 34532 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Attention: pespin Gerrit-Comment-Date: Tue, 26 Sep 2023 12:52:48 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in libosmo-gprs[master]: rlcmac: Fix compilation error 'rlcmac_prim may be used uninitialized'
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34532?usp=email ) Change subject: rlcmac: Fix compilation error 'rlcmac_prim may be used uninitialized' .. Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/libosmo-gprs/+/34532/comment/9e4a21bf_60933ab1 PS1, Line 7: error > Is it really an error? Or a warning that becomes an error when building with > `--disable-werror`? Done File src/rlcmac/tbf_ul_ass_fsm.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/34532/comment/43e99161_34d8904c PS1, Line 121: default > For the record: I intentionally did not add the `default` branch, because I > expected that a warning […] In this case, I can understand the compilation warning because one can still possibly add whatever uint value you want to that variable. So it's actually possible that it contains any other value and hence rlcmac_prim indeed ends up being uninitialized after the switch This is really a fix. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34532?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ica93447bc1f2e60984be7c9c73b153b4eb508aaa Gerrit-Change-Number: 34532 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Attention: fixeria Gerrit-Comment-Date: Tue, 26 Sep 2023 12:54:02 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment
[S] Change in libosmo-gprs[master]: rlcmac: Fix compilation error 'rlcmac_prim may be used uninitialized'
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34532?usp=email ) Change subject: rlcmac: Fix compilation error 'rlcmac_prim may be used uninitialized' .. rlcmac: Fix compilation error 'rlcmac_prim may be used uninitialized' Change-Id: Ica93447bc1f2e60984be7c9c73b153b4eb508aaa --- M src/rlcmac/tbf_ul_ass_fsm.c 1 file changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/32/34532/1 diff --git a/src/rlcmac/tbf_ul_ass_fsm.c b/src/rlcmac/tbf_ul_ass_fsm.c index 64797aa..b1be58c 100644 --- a/src/rlcmac/tbf_ul_ass_fsm.c +++ b/src/rlcmac/tbf_ul_ass_fsm.c @@ -118,7 +118,9 @@ LOGPFSML(ctx->fi, LOGL_INFO, "Requesting two-phase packet access using CCCH\n"); rlcmac_prim = gprs_rlcmac_prim_alloc_l1ctl_rach8_req(0x70); break; - /* TODO: EGPRS specific modes (11-bit RACH) */ + default: + /* TODO: EGPRS specific modes (11-bit RACH) */ + return -ENOTSUP; } return gprs_rlcmac_prim_call_down_cb(rlcmac_prim); -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34532?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ica93447bc1f2e60984be7c9c73b153b4eb508aaa Gerrit-Change-Number: 34532 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange
[M] Change in osmocom-bb[master]: trxcon/l1sched: rework dequeueing of PDCH Tx prims
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34523?usp=email ) Change subject: trxcon/l1sched: rework dequeueing of PDCH Tx prims .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34523?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I439615639b8e840b9fd4f3af6934d9f298f32216 Gerrit-Change-Number: 34523 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Tue, 26 Sep 2023 12:35:06 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-pcu[master]: pdch_ul_controller: migrate from fn_cmp() to gsm0502_fncmp()
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34521?usp=email ) Change subject: pdch_ul_controller: migrate from fn_cmp() to gsm0502_fncmp() .. Patch Set 4: (1 comment) File TODO-RELEASE: https://gerrit.osmocom.org/c/osmo-pcu/+/34521/comment/3ff4aa42_0776e27d PS4, Line 10: libosmogsmgsm0502_fncmp() Ie8bb9c49c6f81b8f4a1766547d6943f9880d1186 Please put "libosmocore > 1.9.0", the Change Id is not needed. Then feel free to merge. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34521?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6a8502c2b2015ca7d0452ab9f5da0484a03ce91e Gerrit-Change-Number: 34521 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Tue, 26 Sep 2023 12:33:57 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[S] Change in osmocom-bb[master]: ASCI: Show NCH position in VTY together with system information
Attention is currently required from: jolly, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34496?usp=email ) Change subject: ASCI: Show NCH position in VTY together with system information .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34496?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I5e0a9d469eb70608502dca881808621fa153b666 Gerrit-Change-Number: 34496 Gerrit-PatchSet: 9 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Attention: jolly Gerrit-Attention: laforge Gerrit-Comment-Date: Tue, 26 Sep 2023 12:32:10 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[XL] Change in osmocom-bb[master]: ASCI: Add GCC/BCC layer to support voice group/broadcast calls
Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email ) Change subject: ASCI: Add GCC/BCC layer to support voice group/broadcast calls .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I22eacd018f18c18ba83dbd3dd874cf029344674d Gerrit-Change-Number: 34494 Gerrit-PatchSet: 9 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Tue, 26 Sep 2023 12:31:28 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[L] Change in osmocom-bb[master]: ASCI: Add group receive and transmit mode support to MM layer
Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34492?usp=email ) Change subject: ASCI: Add group receive and transmit mode support to MM layer .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34492?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I05957182a57423ad947ab200b52f65fde859e110 Gerrit-Change-Number: 34492 Gerrit-PatchSet: 8 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Tue, 26 Sep 2023 12:31:10 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[XL] Change in osmocom-bb[master]: ASCI: Add group receive mode support to RR layer
Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34531?usp=email ) Change subject: ASCI: Add group receive mode support to RR layer .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34531?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia7d806b354fb3be5729bff8ac9aa1c7ad7a8b539 Gerrit-Change-Number: 34531 Gerrit-PatchSet: 3 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Tue, 26 Sep 2023 12:30:13 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmocom-bb[master]: trxcon/l1sched: rework dequeueing of PDCH Tx prims
Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34523?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: trxcon/l1sched: rework dequeueing of PDCH Tx prims .. trxcon/l1sched: rework dequeueing of PDCH Tx prims When an UL BLOCK.req is received late, i.e. after the first Tx burst of the respective TDMA Fn was requested by the PHY, a domino effect can be observed: the stale Tx primitive remains in the queue and prevents transmission of the next primitive, even if the later was received in time. This breaks transmission of consecutive UL blocks. Don't let stale primitives poison the Tx queue: drop them like before, but keep looking for a primitive with the matching TDMA Fn. If found a primitive with TDMA Fn past the current one, stop the iteration. Change-Id: I439615639b8e840b9fd4f3af6934d9f298f32216 Depends: libosmocore.git I9590f2e836fc48650decf1564b6ab46306c4fe2d Depends: libosmocore.git Ie8bb9c49c6f81b8f4a1766547d6943f9880d1186 Related: OS#5500 --- M src/host/trxcon/src/sched_lchan_pdtch.c 1 file changed, 40 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/23/34523/4 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34523?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I439615639b8e840b9fd4f3af6934d9f298f32216 Gerrit-Change-Number: 34523 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Attention: fixeria Gerrit-Attention: pespin Gerrit-MessageType: newpatchset
[S] Change in osmo-pcu[master]: pdch_ul_controller: migrate from fn_cmp() to gsm0502_fncmp()
Attention is currently required from: fixeria. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/34521?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: pdch_ul_controller: migrate from fn_cmp() to gsm0502_fncmp() .. pdch_ul_controller: migrate from fn_cmp() to gsm0502_fncmp() This function is also needed in osmocom-bb.git, so it becomes a library function (part of libosmogsm). Change-Id: I6a8502c2b2015ca7d0452ab9f5da0484a03ce91e Depends: libosmocore.git I9590f2e836fc48650decf1564b6ab46306c4fe2d Depends: libosmocore.git Ie8bb9c49c6f81b8f4a1766547d6943f9880d1186 --- M TODO-RELEASE M src/pdch_ul_controller.c 2 files changed, 21 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/21/34521/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34521?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6a8502c2b2015ca7d0452ab9f5da0484a03ce91e Gerrit-Change-Number: 34521 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-MessageType: newpatchset
[L] Change in osmocom-bb[master]: ASCI: Add ASCI notification support to RR layer
Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34530?usp=email ) Change subject: ASCI: Add ASCI notification support to RR layer .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34530?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I49df02cb4d99d9aab1ea3ca13beb2ea00ae4c9f4 Gerrit-Change-Number: 34530 Gerrit-PatchSet: 3 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Tue, 26 Sep 2023 11:47:18 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmocom-bb[master]: ASCI: Prepare gsm48_rr_rx_acch for voice group channel
Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34529?usp=email ) Change subject: ASCI: Prepare gsm48_rr_rx_acch for voice group channel .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34529?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I39b27396a31137b3c4bdcb40dccdf3de60458fe2 Gerrit-Change-Number: 34529 Gerrit-PatchSet: 3 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Tue, 26 Sep 2023 11:46:40 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmocom-bb[master]: ASCI: Add interface for group receive/transmit mode support to RR layer
Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34528?usp=email ) Change subject: ASCI: Add interface for group receive/transmit mode support to RR layer .. Patch Set 3: (1 comment) Patchset: PS3: As usually, I'd really like to get these introduced in the same patch where they are used. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34528?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1abd56c63d15af1cff8bde7589a571cb5bb5506f Gerrit-Change-Number: 34528 Gerrit-PatchSet: 3 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Tue, 26 Sep 2023 11:46:08 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[S] Change in osmocom-bb[master]: ASCI: Add channel notification event to MM events
Attention is currently required from: fixeria, jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34488?usp=email ) Change subject: ASCI: Add channel notification event to MM events .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34488?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ifee286ba4628356cc19b5dc75f1843287c5d2342 Gerrit-Change-Number: 34488 Gerrit-PatchSet: 8 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: jolly Gerrit-Attention: fixeria Gerrit-Comment-Date: Tue, 26 Sep 2023 11:43:32 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmocom-bb[master]: ASCI: Increase channel request history to 5 entries
Attention is currently required from: fixeria, jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34485?usp=email ) Change subject: ASCI: Increase channel request history to 5 entries .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34485?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I62f18685bf05663f3ee6e94f6884ffb9a6b07ea4 Gerrit-Change-Number: 34485 Gerrit-PatchSet: 8 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: jolly Gerrit-Attention: fixeria Gerrit-Comment-Date: Tue, 26 Sep 2023 11:42:34 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmocom-bb[master]: Refactoring encoding of mobile identity at mobile application
Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34484?usp=email ) Change subject: Refactoring encoding of mobile identity at mobile application .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34484?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9ff429bd50d718530fdad64a276053a35c8928f2 Gerrit-Change-Number: 34484 Gerrit-PatchSet: 7 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Tue, 26 Sep 2023 11:41:17 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmocom-bb[master]: ASCI: Add support flags to mobile (and VTY) for VGCS/VBS
Attention is currently required from: fixeria, jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34483?usp=email ) Change subject: ASCI: Add support flags to mobile (and VTY) for VGCS/VBS .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34483?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia23eb190e533660cce4ba4c856a83b5f3d534202 Gerrit-Change-Number: 34483 Gerrit-PatchSet: 7 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Attention: fixeria Gerrit-Comment-Date: Tue, 26 Sep 2023 11:40:15 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmocom-bb[master]: ASCI: Add UIC support to random access burst
Attention is currently required from: fixeria, jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34482?usp=email ) Change subject: ASCI: Add UIC support to random access burst .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34482?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I4039734676949aefa5be4b5298764b8ba7e1b8ed Gerrit-Change-Number: 34482 Gerrit-PatchSet: 7 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: jolly Gerrit-Attention: fixeria Gerrit-Comment-Date: Tue, 26 Sep 2023 11:39:58 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmocom-bb[master]: Transmit access bursts on DCCH of TCH channels
Attention is currently required from: fixeria, jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34481?usp=email ) Change subject: Transmit access bursts on DCCH of TCH channels .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34481?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1a972d9bac5749c67c1b139825400854f7cf1490 Gerrit-Change-Number: 34481 Gerrit-PatchSet: 7 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: jolly Gerrit-Attention: fixeria Gerrit-Comment-Date: Tue, 26 Sep 2023 11:39:04 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmocom-bb[master]: ASCI: Add a flag to turn transmitter off or on
Attention is currently required from: fixeria, jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34479?usp=email ) Change subject: ASCI: Add a flag to turn transmitter off or on .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34479?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I20133523adc3b204cd2181bfe664fe66020a10e3 Gerrit-Change-Number: 34479 Gerrit-PatchSet: 7 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Attention: fixeria Gerrit-Comment-Date: Tue, 26 Sep 2023 11:38:26 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmocom-bb[master]: trxcon/l1sched: rework dequeueing of PDCH Tx prims
Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34523?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: trxcon/l1sched: rework dequeueing of PDCH Tx prims .. trxcon/l1sched: rework dequeueing of PDCH Tx prims When an UL BLOCK.req is received late, i.e. after the first Tx burst of the respective TDMA Fn was requested by the PHY, a domino effect can be observed: the stale Tx primitive remains in the queue and prevents transmission of the next primitive, even if the later was received in time. This breaks transmission of consecutive UL blocks. Don't let stale primitives poison the Tx queue: drop them like before, but keep looking for a primitive with the matching TDMA Fn. If found a primitive with TDMA Fn past the current one, stop the iteration. Change-Id: I439615639b8e840b9fd4f3af6934d9f298f32216 Depends: libosmocore.git I9590f2e836fc48650decf1564b6ab46306c4fe2d Depends: libosmocore.git Ie8bb9c49c6f81b8f4a1766547d6943f9880d1186 Related: OS#5500 --- M src/host/trxcon/src/sched_lchan_pdtch.c 1 file changed, 39 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/23/34523/3 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34523?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I439615639b8e840b9fd4f3af6934d9f298f32216 Gerrit-Change-Number: 34523 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Attention: fixeria Gerrit-Attention: pespin Gerrit-MessageType: newpatchset
[S] Change in osmo-pcu[master]: pdch_ul_controller: migrate from fn_cmp() to gsm0502_fncmp()
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34521?usp=email ) Change subject: pdch_ul_controller: migrate from fn_cmp() to gsm0502_fncmp() .. Patch Set 3: (1 comment) Patchset: PS3: missing update to TODO-RELEASE -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34521?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6a8502c2b2015ca7d0452ab9f5da0484a03ce91e Gerrit-Change-Number: 34521 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Tue, 26 Sep 2023 11:36:40 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[M] Change in osmocom-bb[master]: trxcon/l1sched: rework dequeueing of PDCH Tx prims
Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/34523?usp=email )
Change subject: trxcon/l1sched: rework dequeueing of PDCH Tx prims
..
Patch Set 2:
(1 comment)
This change is ready for review.
File src/host/trxcon/src/sched_lchan_pdtch.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/34523/comment/a11b2d31_d0993852
PS1, Line 110: llist_for_each_entry(msg, >tx_prims, list) {
> Ah, indeed. Thanks.
Done
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34523?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I439615639b8e840b9fd4f3af6934d9f298f32216
Gerrit-Change-Number: 34523
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin
Gerrit-Attention: pespin
Gerrit-Comment-Date: Tue, 26 Sep 2023 11:30:49 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria
Comment-In-Reply-To: pespin
Gerrit-MessageType: comment
[S] Change in osmocom-bb[master]: l1gprs: migrate to gsm0502_fncmp() from libosmogsm
Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34522?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified-1 by Jenkins Builder Change subject: l1gprs: migrate to gsm0502_fncmp() from libosmogsm .. l1gprs: migrate to gsm0502_fncmp() from libosmogsm Change-Id: I10261aa114b5dce3efee26ea84a1caa50c49a1d2 Depends: libosmocore.git I9590f2e836fc48650decf1564b6ab46306c4fe2d Depends: libosmocore.git Ie8bb9c49c6f81b8f4a1766547d6943f9880d1186 Related: OS#5500 --- M src/shared/l1gprs.c 1 file changed, 13 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/22/34522/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34522?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I10261aa114b5dce3efee26ea84a1caa50c49a1d2 Gerrit-Change-Number: 34522 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: laforge Gerrit-Attention: fixeria Gerrit-MessageType: newpatchset
[S] Change in osmocom-bb[master]: ASCI: Add protocol type to trans_find_by_callref() function
Attention is currently required from: jolly. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34493?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: ASCI: Add protocol type to trans_find_by_callref() function .. ASCI: Add protocol type to trans_find_by_callref() function This is required, because different protocols may share the same callref, but use different protocols. E.g. a voice group call can share the same callref with a voice broadcast call, but these calls are different transactions. Related: OS#5364 Change-Id: Ifea3a81aae3b4ae897851f867b13fa987c8cbe11 --- M src/host/layer23/include/osmocom/bb/mobile/transaction.h M src/host/layer23/src/mobile/gsm411_sms.c M src/host/layer23/src/mobile/gsm480_ss.c M src/host/layer23/src/mobile/gsm48_cc.c M src/host/layer23/src/mobile/transaction.c 5 files changed, 22 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/93/34493/8 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34493?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ifea3a81aae3b4ae897851f867b13fa987c8cbe11 Gerrit-Change-Number: 34493 Gerrit-PatchSet: 8 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-MessageType: newpatchset
[S] Change in osmocom-bb[master]: ASCI: Add uplink free/busy event to MM events
Attention is currently required from: jolly, pespin. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34489?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: ASCI: Add uplink free/busy event to MM events .. ASCI: Add uplink free/busy event to MM events Related: OS#5364 Change-Id: I3f8d97a0359ea9560d6d6bfd8238ddc6492c56e8 --- M src/host/layer23/include/osmocom/bb/mobile/gsm48_mm.h 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/89/34489/8 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34489?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3f8d97a0359ea9560d6d6bfd8238ddc6492c56e8 Gerrit-Change-Number: 34489 Gerrit-PatchSet: 8 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Attention: jolly Gerrit-Attention: pespin Gerrit-MessageType: newpatchset
[L] Change in osmocom-bb[master]: ASCI: Add VTY commands to control voice group/broadcast calls
Attention is currently required from: jolly. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34495?usp=email to look at the new patch set (#9). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: ASCI: Add VTY commands to control voice group/broadcast calls .. ASCI: Add VTY commands to control voice group/broadcast calls Related: OS#5364 Change-Id: Id32253b4e10b8df48e819d8a92bbcda332dd11e6 --- M src/host/layer23/include/osmocom/bb/mobile/vty.h M src/host/layer23/src/mobile/vty_interface.c 2 files changed, 248 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/95/34495/9 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34495?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id32253b4e10b8df48e819d8a92bbcda332dd11e6 Gerrit-Change-Number: 34495 Gerrit-PatchSet: 9 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-MessageType: newpatchset
[S] Change in osmocom-bb[master]: Fix unset sapi in gsm48_rr_data_ind()
Attention is currently required from: jolly. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34487?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: Fix unset sapi in gsm48_rr_data_ind() .. Fix unset sapi in gsm48_rr_data_ind() The gsm48_rr_hdr is pushed into the message before sending data to MM layer. SAPI was not set in this header. Change-Id: I8345a562050d52d491f3b7192c979d455a63931c --- M src/host/layer23/src/mobile/gsm48_rr.c 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/87/34487/8 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34487?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8345a562050d52d491f3b7192c979d455a63931c Gerrit-Change-Number: 34487 Gerrit-PatchSet: 8 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-MessageType: newpatchset
[S] Change in osmocom-bb[master]: ASCI: Add two logging categories for group and broadcast call control
Attention is currently required from: jolly. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34480?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: ASCI: Add two logging categories for group and broadcast call control .. ASCI: Add two logging categories for group and broadcast call control Related: OS#5364 Change-Id: I77f634c7098137a5412ea56ddc0e794e629d1982 --- M src/host/layer23/include/osmocom/bb/common/logging.h M src/host/layer23/src/common/logging.c 2 files changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/80/34480/7 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34480?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I77f634c7098137a5412ea56ddc0e794e629d1982 Gerrit-Change-Number: 34480 Gerrit-PatchSet: 7 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-MessageType: newpatchset
[S] Change in osmocom-bb[master]: Fix request reference value in gsm48_match_ra()
Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34486?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: Fix request reference value in gsm48_match_ra() .. Fix request reference value in gsm48_match_ra() Do not overwrite the given request reference pointer with the history buffer's reference. This makes no sense. Without this fix only the response to the first access burst could be matched correctly. Change-Id: Iec636d368e20030beac2861bff61b1a06e7b4821 --- M src/host/layer23/src/mobile/gsm48_rr.c 1 file changed, 21 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/86/34486/8 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34486?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iec636d368e20030beac2861bff61b1a06e7b4821 Gerrit-Change-Number: 34486 Gerrit-PatchSet: 8 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Attention: pespin Gerrit-MessageType: newpatchset
[S] Change in osmocom-bb[master]: ASCI: Add UIC support to random access burst
Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34482?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: ASCI: Add UIC support to random access burst .. ASCI: Add UIC support to random access burst A different identity code can be used on uplink access bursts on voice group channel. This is optional for the network, but mandatory for the MS side. If the network does not define a UIC, the BSIC is used instead. BSIC is used for RACH channel and handover. Related: OS#5364 Change-Id: I4039734676949aefa5be4b5298764b8ba7e1b8ed --- M include/l1ctl_proto.h M src/host/layer23/include/osmocom/bb/common/l1ctl.h M src/host/layer23/src/common/l1ctl.c M src/host/layer23/src/common/l1ctl_lapdm_glue.c M src/host/layer23/src/modem/grr.c M src/target/firmware/include/layer1/prim.h M src/target/firmware/include/layer1/sync.h M src/target/firmware/layer1/l23_api.c M src/target/firmware/layer1/prim_rach.c 9 files changed, 35 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/82/34482/7 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34482?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I4039734676949aefa5be4b5298764b8ba7e1b8ed Gerrit-Change-Number: 34482 Gerrit-PatchSet: 7 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: fixeria Gerrit-Attention: pespin Gerrit-MessageType: newpatchset
[M] Change in osmocom-bb[master]: ASCI: Add a flag to turn transmitter off or on
Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34479?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: ASCI: Add a flag to turn transmitter off or on .. ASCI: Add a flag to turn transmitter off or on This flag can be used to turn transmitter off for "group receive mode" or for handover procedure. The flag is stored in the channel description of the mobile application. It is sent to layer 1 when switching to dedicated channel or when changing TCH mode. At the layer 1 the transmitter is turned off while the receiver is still active. This is done by: * scheduling a TX dummy task for TCH bursts * scheduling no TX task for SACCH bursts * not enabling the transmit window Related: OS#5364 Change-Id: I20133523adc3b204cd2181bfe664fe66020a10e3 --- M include/l1ctl_proto.h M src/host/layer23/include/osmocom/bb/common/l1ctl.h M src/host/layer23/include/osmocom/bb/common/osmocom_data.h M src/host/layer23/include/osmocom/bb/mobile/gsm48_rr.h M src/host/layer23/src/common/l1ctl.c M src/host/layer23/src/misc/app_cbch_sniff.c M src/host/layer23/src/mobile/gsm414.c M src/host/layer23/src/mobile/gsm48_rr.c M src/host/layer23/src/modem/grr.c M src/target/firmware/include/layer1/async.h M src/target/firmware/include/layer1/sync.h M src/target/firmware/layer1/async.c M src/target/firmware/layer1/l23_api.c M src/target/firmware/layer1/prim_tch.c 14 files changed, 92 insertions(+), 42 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/79/34479/7 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34479?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I20133523adc3b204cd2181bfe664fe66020a10e3 Gerrit-Change-Number: 34479 Gerrit-PatchSet: 7 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: pespin Gerrit-Attention: fixeria Gerrit-Attention: pespin Gerrit-MessageType: newpatchset
[S] Change in osmo-pcu[master]: pdch_ul_controller: migrate from fn_cmp() to gsm0502_fncmp()
Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/34521?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: pdch_ul_controller: migrate from fn_cmp() to gsm0502_fncmp() .. pdch_ul_controller: migrate from fn_cmp() to gsm0502_fncmp() This function is also needed in osmocom-bb.git, so it becomes a library function (part of libosmogsm). Change-Id: I6a8502c2b2015ca7d0452ab9f5da0484a03ce91e Depends: libosmocore.git I9590f2e836fc48650decf1564b6ab46306c4fe2d Depends: libosmocore.git Ie8bb9c49c6f81b8f4a1766547d6943f9880d1186 --- M src/pdch_ul_controller.c 1 file changed, 20 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/21/34521/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34521?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6a8502c2b2015ca7d0452ab9f5da0484a03ce91e Gerrit-Change-Number: 34521 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: pespin Gerrit-Attention: fixeria Gerrit-MessageType: newpatchset
[S] Change in osmo-pcu[master]: pdch_ul_controller: migrate from fn_cmp() to gsm0502_fncmp()
Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/34521?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified-1 by Jenkins Builder Change subject: pdch_ul_controller: migrate from fn_cmp() to gsm0502_fncmp() .. pdch_ul_controller: migrate from fn_cmp() to gsm0502_fncmp() This function is also needed in osmocom-bb.git, so it becomes a library function (part of libosmogsm). Change-Id: I6a8502c2b2015ca7d0452ab9f5da0484a03ce91e Depends: libosmocore.git I9590f2e836fc48650decf1564b6ab46306c4fe2d Depends: libosmocore.git Ie8bb9c49c6f81b8f4a1766547d6943f9880d1186 --- M src/pdch_ul_controller.c 1 file changed, 18 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/21/34521/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34521?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6a8502c2b2015ca7d0452ab9f5da0484a03ce91e Gerrit-Change-Number: 34521 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: pespin Gerrit-Attention: fixeria Gerrit-MessageType: newpatchset
[S] Change in libosmocore[master]: gsm: rename s/gsm0502_fn_compare/gsm0502_fncmp/
fixeria has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/34527?usp=email )
Change subject: gsm: rename s/gsm0502_fn_compare/gsm0502_fncmp/
..
gsm: rename s/gsm0502_fn_compare/gsm0502_fncmp/
Change-Id: Ie8bb9c49c6f81b8f4a1766547d6943f9880d1186
Related: OS#5500
---
M include/osmocom/gsm/gsm0502.h
M tests/gsm0502/gsm0502_test.c
2 files changed, 24 insertions(+), 14 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, approved
diff --git a/include/osmocom/gsm/gsm0502.h b/include/osmocom/gsm/gsm0502.h
index 6624e70..0ac1387 100644
--- a/include/osmocom/gsm/gsm0502.h
+++ b/include/osmocom/gsm/gsm0502.h
@@ -70,7 +70,7 @@
* \returns similarly to memcmp(), -1 if fn1 goes before fn2;
* 0 if fn1 equals fn2;
* 1 if fn1 goes after fn2. */
-static inline int gsm0502_fn_compare(uint32_t fn1, uint32_t fn2)
+static inline int gsm0502_fncmp(uint32_t fn1, uint32_t fn2)
{
const uint32_t thresh = GSM_TDMA_HYPERFRAME / 2;
diff --git a/tests/gsm0502/gsm0502_test.c b/tests/gsm0502/gsm0502_test.c
index d78a94d..7768abb 100644
--- a/tests/gsm0502/gsm0502_test.c
+++ b/tests/gsm0502/gsm0502_test.c
@@ -148,28 +148,28 @@
printf("\n");
}
-static void test_gsm0502_fn_compare(void)
+static void test_gsm0502_fncmp(void)
{
- OSMO_ASSERT(gsm0502_fn_compare(1337, 1337) == 0);
- OSMO_ASSERT(gsm0502_fn_compare(42, 1337)== -1);
- OSMO_ASSERT(gsm0502_fn_compare(1337, 42)== 1);
- OSMO_ASSERT(gsm0502_fn_compare(42, 0) == 1);
+ OSMO_ASSERT(gsm0502_fncmp(1337, 1337) == 0);
+ OSMO_ASSERT(gsm0502_fncmp(42, 1337) == -1);
+ OSMO_ASSERT(gsm0502_fncmp(1337, 42) == 1);
+ OSMO_ASSERT(gsm0502_fncmp(42, 0)== 1);
/* 2715642 is very close to the Fn period (GSM_TDMA_HYPERFRAME) */
- OSMO_ASSERT(gsm0502_fn_compare(2715642, 42) == -1);
- OSMO_ASSERT(gsm0502_fn_compare(42, 2715642) == 1);
- OSMO_ASSERT(gsm0502_fn_compare(0, 2715642) == 1);
+ OSMO_ASSERT(gsm0502_fncmp(2715642, 42) == -1);
+ OSMO_ASSERT(gsm0502_fncmp(42, 2715642) == 1);
+ OSMO_ASSERT(gsm0502_fncmp(0, 2715642) == 1);
/* 1357824 is half of the Fn period (GSM_TDMA_HYPERFRAME) */
- OSMO_ASSERT(gsm0502_fn_compare(1357820, 1357824)== -1);
- OSMO_ASSERT(gsm0502_fn_compare(1357820, 1357825)== -1);
- OSMO_ASSERT(gsm0502_fn_compare(1357824, 1357820)== 1);
- OSMO_ASSERT(gsm0502_fn_compare(1357825, 1357820)== 1);
+ OSMO_ASSERT(gsm0502_fncmp(1357820, 1357824) == -1);
+ OSMO_ASSERT(gsm0502_fncmp(1357820, 1357825) == -1);
+ OSMO_ASSERT(gsm0502_fncmp(1357824, 1357820) == 1);
+ OSMO_ASSERT(gsm0502_fncmp(1357825, 1357820) == 1);
}
int main(int argc, char **argv)
{
test_gsm0502_fn_remap();
- test_gsm0502_fn_compare();
+ test_gsm0502_fncmp();
return EXIT_SUCCESS;
}
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34527?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ie8bb9c49c6f81b8f4a1766547d6943f9880d1186
Gerrit-Change-Number: 34527
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
[S] Change in osmo-mgw[master]: mgcp-client: Introduce API osmo_mgcpc_ep_local_name()
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34510?usp=email ) Change subject: mgcp-client: Introduce API osmo_mgcpc_ep_local_name() .. Patch Set 2: (1 comment) File src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c: https://gerrit.osmocom.org/c/osmo-mgw/+/34510/comment/4ce29242_e0824760 PS1, Line 184: const char *sep; > add a new line before the assert? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34510?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I18d7bdf650c0ec87ae16ed4944aed9f495400137 Gerrit-Change-Number: 34510 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 26 Sep 2023 10:51:09 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Gerrit-MessageType: comment
[S] Change in osmo-mgw[master]: mgcp-client: Introduce API osmo_mgcpc_ep_local_name()
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-mgw/+/34510?usp=email )
Change subject: mgcp-client: Introduce API osmo_mgcpc_ep_local_name()
..
mgcp-client: Introduce API osmo_mgcpc_ep_local_name()
Change-Id: I18d7bdf650c0ec87ae16ed4944aed9f495400137
---
M include/osmocom/mgcp_client/mgcp_client_endpoint_fsm.h
M src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c
2 files changed, 34 insertions(+), 0 deletions(-)
Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
osmith: Looks good to me, approved
diff --git a/include/osmocom/mgcp_client/mgcp_client_endpoint_fsm.h
b/include/osmocom/mgcp_client/mgcp_client_endpoint_fsm.h
index f21f40e..3daa09d 100644
--- a/include/osmocom/mgcp_client/mgcp_client_endpoint_fsm.h
+++ b/include/osmocom/mgcp_client/mgcp_client_endpoint_fsm.h
@@ -45,6 +45,7 @@
void osmo_mgcpc_ep_clear(struct osmo_mgcpc_ep *ep);
const char *osmo_mgcpc_ep_name(const struct osmo_mgcpc_ep *ep);
+const char *osmo_mgcpc_ep_local_name(const struct osmo_mgcpc_ep *ep);
const char *osmo_mgcpc_ep_ci_name(const struct osmo_mgcpc_ep_ci *ci);
const char *osmo_mgcpc_ep_ci_id(const struct osmo_mgcpc_ep_ci *ci);
struct mgcp_client *osmo_mgcpc_ep_client(const struct osmo_mgcpc_ep *ep);
diff --git a/src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c
b/src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c
index a01bbdc..105e54b 100644
--- a/src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c
+++ b/src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c
@@ -173,6 +173,30 @@
return osmo_fsm_inst_name(ep->fi);
}
+/*! Get "local endpoint name" part of the endpoint name:
(local-endpoint-name@domain-name)
+ *
+ * \param ep The MGCP Endpoint
+ * \returns the local endpoint name if found, NULL on error.
+ */
+const char *osmo_mgcpc_ep_local_name(const struct osmo_mgcpc_ep *ep)
+{
+ static char buf[1024];
+ const char *sep;
+
+ OSMO_ASSERT(ep);
+ sep = strchr(ep->endpoint, '@');
+ if (!sep) {
+ OSMO_STRLCPY_ARRAY(buf, ep->endpoint);
+ return buf;
+ }
+ if (sep - ep->endpoint >= sizeof(buf))
+ return NULL;
+
+ memcpy(buf, ep->endpoint, sep - ep->endpoint);
+ buf[sep - ep->endpoint] = '\0';
+ return buf;
+}
+
const char *mgcp_conn_peer_name(const struct mgcp_conn_peer *info)
{
/* I'd be fine with a smaller buffer and accept truncation, but gcc
possibly refuses to build if
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34510?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I18d7bdf650c0ec87ae16ed4944aed9f495400137
Gerrit-Change-Number: 34510
Gerrit-PatchSet: 2
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: osmith
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
[S] Change in libosmocore[master]: sockaddr_str.h Fix OSMO_SOCKADDR_STR_FMT_ARGS_NOT_NULL syntax error
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34509?usp=email ) Change subject: sockaddr_str.h Fix OSMO_SOCKADDR_STR_FMT_ARGS_NOT_NULL syntax error .. sockaddr_str.h Fix OSMO_SOCKADDR_STR_FMT_ARGS_NOT_NULL syntax error It's fine changing the define because due to the previous error it means basically that it was never used so far, because using it triggers a compilation error. The error was introduced because I ended up not using this in the past after submitting this code, and now that I want to use it it went noticed that it fails. Change-Id: Iee361d740845257fa62c9093e30e8079fa933827 --- M include/osmocom/core/sockaddr_str.h 1 file changed, 18 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/core/sockaddr_str.h b/include/osmocom/core/sockaddr_str.h index 2d3e7e9..c646f49 100644 --- a/include/osmocom/core/sockaddr_str.h +++ b/include/osmocom/core/sockaddr_str.h @@ -63,7 +63,7 @@ ((R)->af == AF_INET6) ? "[" : "", \ (R)->ip, \ ((R)->af == AF_INET6) ? "]" : "", \ - (R)->port : 0 + (R)->port #define OSMO_SOCKADDR_STR_FMT_ARGS(R) \ ((R) && (R)->af == AF_INET6) ? "[" : "", \ (R) ? (R)->ip : "NULL", \ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34509?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iee361d740845257fa62c9093e30e8079fa933827 Gerrit-Change-Number: 34509 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged
[M] Change in osmocom-bb[master]: ASCI: MM connections are defined by 'ref' and 'protocol' tuple
Attention is currently required from: jolly, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34478?usp=email ) Change subject: ASCI: MM connections are defined by 'ref' and 'protocol' tuple .. Patch Set 6: Code-Review+1 (1 comment) Patchset: PS6: I find it it a bit weird that you are printing an uint16_t with 0x03%x, but ok :) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34478?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic280cd8c60077bb2c2ef641f4cddd3b36eee Gerrit-Change-Number: 34478 Gerrit-PatchSet: 6 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Attention: jolly Gerrit-Attention: laforge Gerrit-Comment-Date: Tue, 26 Sep 2023 10:47:59 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmocom-bb[master]: ASCI: Get timing advance and TX power only when included
Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34477?usp=email ) Change subject: ASCI: Get timing advance and TX power only when included .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34477?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I87fcd44bba221ab4c5fbd2c79557db2444a10b88 Gerrit-Change-Number: 34477 Gerrit-PatchSet: 5 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Tue, 26 Sep 2023 10:46:58 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[L] Change in osmocom-bb[master]: ASCI: Add GCC/BCC (call control) to mobility management
Attention is currently required from: fixeria, jolly, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34476?usp=email ) Change subject: ASCI: Add GCC/BCC (call control) to mobility management .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34476?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If6f3cea4b2ca839559596a6ee5a3d169c6d85dbe Gerrit-Change-Number: 34476 Gerrit-PatchSet: 4 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Attention: laforge Gerrit-Attention: fixeria Gerrit-Comment-Date: Tue, 26 Sep 2023 10:46:28 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
