Re: windowmaker - application icon missing at first start

[Wolfgang Lux]

Hi Riccardo,

> I noticed we recently have a strange behaviour, which is slightly
> different from setup (= installation on different computers) to setup I have
> 
> The first time I start a GNUstep application with windowmaker (I mean
> the first GNUstep app started ever after X11 start essentially) it has a
> bad icon.
> - on some setup it has a "generic" icon by windowmaker
> - on other setups it has a black looking icon, as only the "mask" of the
> icon, the contours are drawn
> 
> A restart of the app and then starting any other app, fixes that.
> 
> 
> This was not happening before.

Actually, this has been happening before, but it was fixed about five years ago 
in this commit:
  
https://github.com/gnustep/libs-back/commit/1e1185abb364f2ffcb5f06f62c1241d419b8b697#diff-c3c9abc7461037f8abf3f590d909cff84c39bc7817b79d7dfd379b38a3756385

> I think it is related to at least this
> commit - merge:
> 
> https://github.com/mozilla/newtab-dev/raw/6be44da368fb869a3d3e1975f515857352a7d9fc/browser/modules/ProcessHangMonitor.jsm

I assume you meant this commit instead
  
https://github.com/gnustep/libs-back/commit/31b7c4ed2f8efa0127605511aaf4eafef6a3d1c8
And, yes, your suspicion is correct because it exactly comments out the earlier 
fix.

Wolfgang

Re: windowmaker - application icon missing at first start

[Sergii Stoian]

Hi,

> On Oct 17, 2020, at 00:27, Wolfgang Lux  wrote:
> 
> Hi Riccardo,
> 
>> I noticed we recently have a strange behaviour, which is slightly
>> different from setup (= installation on different computers) to setup I have
>> 
>> The first time I start a GNUstep application with windowmaker (I mean
>> the first GNUstep app started ever after X11 start essentially) it has a
>> bad icon.
>> - on some setup it has a "generic" icon by windowmaker
>> - on other setups it has a black looking icon, as only the "mask" of the
>> icon, the contours are drawn

Riccardo, could you please provide more info on your specific setups?
Do you have “UseWindowMakerIcons” set to “NO” in NSGlobalDomain?

>> 
>> A restart of the app and then starting any other app, fixes that.
>> 
>> 
>> This was not happening before.
> 
> Actually, this has been happening before, but it was fixed about five years 
> ago in this commit:
>  
> https://github.com/gnustep/libs-back/commit/1e1185abb364f2ffcb5f06f62c1241d419b8b697#diff-c3c9abc7461037f8abf3f590d909cff84c39bc7817b79d7dfd379b38a3756385
> 
>> I think it is related to at least this
>> commit - merge:
>> 
>> https://github.com/mozilla/newtab-dev/raw/6be44da368fb869a3d3e1975f515857352a7d9fc/browser/modules/ProcessHangMonitor.jsm
> 
> I assume you meant this commit instead
>  
> https://github.com/gnustep/libs-back/commit/31b7c4ed2f8efa0127605511aaf4eafef6a3d1c8
> And, yes, your suspicion is correct because it exactly comments out the 
> earlier fix.

As stated in description to this commit it fixes flickering of appicon at 
application start. Quote: “This fix based on the fact that root application 
window (ROOT) is mapped in `-orderwindow:::` and this is the event of 
application recognition by WindowMaker because it is a first application window 
that is mapped.”. That "root application window" is called “group leader” and 
saved in every application window structure (WWindow) member `main_window` 
inside WM. It holds all required properties to be detected by WM correctly.

The earlier fix probably masks other unknown problem. My WindowMaker 0.95.7 
default configuration tests work like a charm.
Wolfgang, do you observe the same behaviour as Riccardo? I yes, could you 
please share your setup?

> Wolfgang
> 
> 

Sergii

Re: windowmaker - application icon missing at first start

[Gregory Casamento]

Alessandro,

The SystemPreferences icon has always had an issue with WindowMaker.  It's
just a normal tiff, but, for some reason, it shows up as color inverted
when docked in the WindowMaker dock, but normal when the application is
started.  When you first start an application in GNUstep the icon gets
written to ~/GNUstep/Library/WindowMaker/CachedPixmaps when the application
is launched.  I forget where precisely in the code this occurs.

I believe this corruption might have something to do with your problem as
the second time it is invoked it reads the version of the icon that was
cached in the directory I indicated above.

There are a number of possible solutions:
1) Fix the tiff so that WindowMaker doesn't have an issue
2) Fix WindowMaker (or GNUstep, in case the caching is happening in our
code... I am not sure it is)

I have included a screenshot of what is happening on my system to
illustrate what I'm referring to.  Please find it attached.  I hope some of
this additional information helps.

Yours, GC

On Sat, Oct 17, 2020 at 4:32 AM Alessandro Sangiuliano 
wrote:

> This morning I had more time to do better test.
>
> I have to add that in my case is just SystemPreferences icon that is not
> showed at first start.
>
> With Gorm and ProjectCenter, the window is showed as expected at first run!
>
> Maybe is just a little bug relative to SystemPreferences in my case, or
> just some request that SystemPreferences is doing and I'm not handling.
>
> Alex.
>
> --
> *Da:* Gnustep-dev  per
> conto di Alessandro Sangiuliano 
> *Inviato:* sabato 17 ottobre 2020 04:59
> *A:* undefined 
> *Cc:* undefined 
> *Oggetto:* R: windowmaker - application icon missing at first start
>
> I wrote this email some days ago to Fred privately, because I was thinking
> that the problem was relative to my window manager that is young and ealyy
> stage, so i post here too bcause the problem is quite similar.
>
> Hi Fred,
>
> I write becaus ethe gnustep support in uroswm is almost completed, but
> there are few things to fix, actually in the miniwindow managment. Explain
> it with words would be a bit complex especially with my english, so I made
> a gif pic to share with you.
>
> Here is the lin that will expire after one month:
>
> https://ibb.co/3ND5Dhw
>
> Now i explain the problem in steps amd you will noticed them in the gif:
>
> 1) First time run uroswm
> 2) First time a GNUstep App
> 3) When the App is first time started the miniwindow on the left-bottom
> corner doesn't draw the icon, or better, it draws the icon but disappers
> quite soon. The icon just appears for some instants and then disappers.
> 4) I close the App
> 5) I run again the app
> 6) At this point, the App is started for the second time, ll works as
> expecetd and the miniwindow draws the icon ans show it as expected.
>
> Don't be scared by bad colors in the gif i just set low quality to the
> recorder.
>
> Why at the first start of theapp the icon is not painted as we expects?
> Maybe at the first run GS is doing some particular requests or
> setting/asking for soe extended window manager hints?
>
> Thank you,
> Alex
>
>
> --
> *Da:* Gnustep-dev  per
> conto di Riccardo Mottola 
> *Inviato:* venerdì 16 ottobre 2020 11:40
> *A:* gnustep-dev@gnu.org 
> *Oggetto:* windowmaker - application icon missing at first start
>
> Hi!
>
> I noticed we recently have a strange behaviour, which is slightly
> different from setup (= installation on different computers) to setup I
> have
>
> The first time I start a GNUstep application with windowmaker (I mean
> the first GNUstep app started ever after X11 start essentially) it has a
> bad icon.
> - on some setup it has a "generic" icon by windowmaker
> - on other setups it has a black looking icon, as only the "mask" of the
> icon, the contours are drawn
>
> A restart of the app and then starting any other app, fixes that.
>
>
> This was not happening before. I think it is related to at least this
> commit - merge:
>
>
> https://github.com/mozilla/newtab-dev/raw/6be44da368fb869a3d3e1975f515857352a7d9fc/browser/modules/ProcessHangMonitor.jsm
>
> Can you reproduce? How is it for you?
>
> Riccardo
>
>
>

-- 
Gregory Casamento
GNUstep Lead Developer / OLC, Principal Consultant
http://www.gnustep.org - http://heronsperch.blogspot.com
https://www.patreon.com/bePatron?u=352392 - Become a Patron
https://gf.me/u/x8m3sx - My GNUstep GoFundMe
https://teespring.com/stores/gnustep - Store

Re: windowmaker - application icon missing at first start

[Gregory Casamento]

I have made a change that uses a png file as the icon instead of the tiff
and this appears to resolve the issue I showed in my attachment.  This is
not a general fix as there are a few other apps that show this issue.  One
of them is InnerSpace in the GAP project.  Please give this a try.

GC

On Sat, Oct 17, 2020 at 7:11 AM Gregory Casamento 
wrote:

>
> Alessandro,
>
> The SystemPreferences icon has always had an issue with WindowMaker.  It's
> just a normal tiff, but, for some reason, it shows up as color inverted
> when docked in the WindowMaker dock, but normal when the application is
> started.  When you first start an application in GNUstep the icon gets
> written to ~/GNUstep/Library/WindowMaker/CachedPixmaps when the application
> is launched.  I forget where precisely in the code this occurs.
>
> I believe this corruption might have something to do with your problem as
> the second time it is invoked it reads the version of the icon that was
> cached in the directory I indicated above.
>
> There are a number of possible solutions:
> 1) Fix the tiff so that WindowMaker doesn't have an issue
> 2) Fix WindowMaker (or GNUstep, in case the caching is happening in our
> code... I am not sure it is)
>
> I have included a screenshot of what is happening on my system to
> illustrate what I'm referring to.  Please find it attached.  I hope some of
> this additional information helps.
>
> Yours, GC
>
> On Sat, Oct 17, 2020 at 4:32 AM Alessandro Sangiuliano <
> alex2...@hotmail.com> wrote:
>
>> This morning I had more time to do better test.
>>
>> I have to add that in my case is just SystemPreferences icon that is not
>> showed at first start.
>>
>> With Gorm and ProjectCenter, the window is showed as expected at first
>> run!
>>
>> Maybe is just a little bug relative to SystemPreferences in my case, or
>> just some request that SystemPreferences is doing and I'm not handling.
>>
>> Alex.
>>
>> --
>> *Da:* Gnustep-dev  per
>> conto di Alessandro Sangiuliano 
>> *Inviato:* sabato 17 ottobre 2020 04:59
>> *A:* undefined 
>> *Cc:* undefined 
>> *Oggetto:* R: windowmaker - application icon missing at first start
>>
>> I wrote this email some days ago to Fred privately, because I was
>> thinking that the problem was relative to my window manager that is young
>> and ealyy stage, so i post here too bcause the problem is quite similar.
>>
>> Hi Fred,
>>
>> I write becaus ethe gnustep support in uroswm is almost completed, but
>> there are few things to fix, actually in the miniwindow managment. Explain
>> it with words would be a bit complex especially with my english, so I made
>> a gif pic to share with you.
>>
>> Here is the lin that will expire after one month:
>>
>> https://ibb.co/3ND5Dhw
>>
>> Now i explain the problem in steps amd you will noticed them in the gif:
>>
>> 1) First time run uroswm
>> 2) First time a GNUstep App
>> 3) When the App is first time started the miniwindow on the left-bottom
>> corner doesn't draw the icon, or better, it draws the icon but disappers
>> quite soon. The icon just appears for some instants and then disappers.
>> 4) I close the App
>> 5) I run again the app
>> 6) At this point, the App is started for the second time, ll works as
>> expecetd and the miniwindow draws the icon ans show it as expected.
>>
>> Don't be scared by bad colors in the gif i just set low quality to the
>> recorder.
>>
>> Why at the first start of theapp the icon is not painted as we expects?
>> Maybe at the first run GS is doing some particular requests or
>> setting/asking for soe extended window manager hints?
>>
>> Thank you,
>> Alex
>>
>>
>> --
>> *Da:* Gnustep-dev  per
>> conto di Riccardo Mottola 
>> *Inviato:* venerdì 16 ottobre 2020 11:40
>> *A:* gnustep-dev@gnu.org 
>> *Oggetto:* windowmaker - application icon missing at first start
>>
>> Hi!
>>
>> I noticed we recently have a strange behaviour, which is slightly
>> different from setup (= installation on different computers) to setup I
>> have
>>
>> The first time I start a GNUstep application with windowmaker (I mean
>> the first GNUstep app started ever after X11 start essentially) it has a
>> bad icon.
>> - on some setup it has a "generic" icon by windowmaker
>> - on other setups it has a black looking icon, as only the "mask" of the
>> icon, the contours are drawn
>>
>> A restart of the app and then starting any other app, fixes that.
>>
>>
>> This was not happening before. I think it is related to at least this
>> commit - merge:
>>
>>
>> https://github.com/mozilla/newtab-dev/raw/6be44da368fb869a3d3e1975f515857352a7d9fc/browser/modules/ProcessHangMonitor.jsm
>>
>> Can you reproduce? How is it for you?
>>
>> Riccardo
>>
>>
>>
>
> --
> Gregory Casamento
> GNUstep Lead Developer / OLC, Principal Consultant
> http://www.gnustep.org - http://heronsperch.blogspot.com
> https://www.patreon.com/bePatron?u=352392 - Become a Patron
> https://gf.me/u/x8m3sx - My GNUstep GoFundMe
> https://t

Re: windowmaker - application icon missing at first start

[alex22_7]

Hi Greg thank you for your help.

I don't have the ~/GNUstep/Library/WindowMaker/CachedPixmaps folder because I 
don't use WindowMaker but the one you see in the pic I attached in the previous 
email is the window manager I'm coding, uroswm.
In the while I made other tests; i try to put ll the tests toghether i made 
until now (with a summary of the first 2):
Test case 1:
1) start uroswm for the first time;
2)start systemPreferences for the first time -> Icon window not working as 
expected, just a gray square is shown.
3) Close SystemPreferences app
4) Start again SystemPreference -> now the icon window is shown as expected

Test case 2:
1) start uroswm for the first time;
2) Start another app like Gorm or ProkectCenter for the first time-> all is 
working as expected the icon window too

Test case 3 (the new one):
1) start uroswm for the first time;
2) Start another app like Gorm or ProkectCenter -> all is working as expected 
the icon window too
3) start SystemPreferences for the first time -> all is working as expected the 
icon window too

So in the last test case I discovered that if we run uroswm for the first time 
and some other app that are not SystemPreferences, for the first time, fixes 
the problem, then running SystemPreferences indeed has the icon working 
correctly.
Also, uroswm has the support for _NET_WM_ICON and it is able to get the 
SystemPreferences' icon image from the icon window (the 64 x 64 window on the 
left-bottom corner), for test I also save it in /tmp/Icon.png using cairo and 
it works correctly (uroswm caches the icons for the app window in an array).
I was thinking to force the icon to be drawn from uroswm, but for some reason 
cairo saves to /tmp/Icon.png but won't paint the icon to the 64x64 window, and 
for now i don't know the reason.. I already made the code to do this job, 
because when clicking on the uroswm's miniaturize button, it creates an image ( 
a screenshot of the client window without the decorations) scales it and paints 
in the miniaturized window the screenshot, that is just the preview of the 
content of the window, having the same behavior that osx has when you 
miniaturize the window; all this is made using cairo and works.
However the focus is on these 3 test cases; they are showing an hidden problem 
that could be mine (uroswm) or from SystemPreferences.
Actually, I'm pretty sur ethe problem is from uroswm, beause other window 
managers are working without any problems. Is just a bit hard discovering which 
could be the problem, especially when the other apps are just working.
Alex
Inviato da Mailspring (https://getmailspring.com/), la migliore app di posta 
elettronica gratuita per il lavoro
On ott 17 2020, at 1:11 pm, Gregory Casamento  wrote:
>
> Alessandro,
>
> The SystemPreferences icon has always had an issue with WindowMaker. It's 
> just a normal tiff, but, for some reason, it shows up as color inverted when 
> docked in the WindowMaker dock, but normal when the application is started. 
> When you first start an application in GNUstep the icon gets written to 
> ~/GNUstep/Library/WindowMaker/CachedPixmaps when the application is launched. 
> I forget where precisely in the code this occurs.
>
> I believe this corruption might have something to do with your problem as the 
> second time it is invoked it reads the version of the icon that was cached in 
> the directory I indicated above.
>
> There are a number of possible solutions:
> 1) Fix the tiff so that WindowMaker doesn't have an issue
> 2) Fix WindowMaker (or GNUstep, in case the caching is happening in our 
> code... I am not sure it is)
>
> I have included a screenshot of what is happening on my system to illustrate 
> what I'm referring to. Please find it attached. I hope some of this 
> additional information helps.
>
> Yours, GC
> On Sat, Oct 17, 2020 at 4:32 AM Alessandro Sangiuliano  (mailto:alex2...@hotmail.com)> wrote:
> > This morning I had more time to do better test.
> >
> > I have to add that in my case is just SystemPreferences icon that is not 
> > showed at first start.
> >
> > With Gorm and ProjectCenter, the window is showed as expected at first run!
> >
> > Maybe is just a little bug relative to SystemPreferences in my case, or 
> > just some request that SystemPreferences is doing and I'm not handling.
> >
> > Alex.
> >
> > Da: Gnustep-dev  > (mailto:hotmail@gnu.org)> per conto di Alessandro Sangiuliano 
> > mailto:alex2...@hotmail.com)>
> > Inviato: sabato 17 ottobre 2020 04:59
> > A: undefined mailto:gnustep-dev@gnu.org)>
> > Cc: undefined mailto:gnustep-dev@gnu.org)>
> > Oggetto: R: windowmaker - application icon missing at first start
> >
> >
> > I wrote this email some days ago to Fred privately, because I was thinking 
> > that the problem was relative to my window manager that is young and ealyy 
> > stage, so i post here too bcause the problem is quite similar.
> >
> >
> > Hi Fred,
> > I write becaus ethe gnustep support in uroswm is almost completed, but

Re: windowmaker - application icon missing at first start

[alex22_7]

I just tried but it doesn't solve my problem.

Alex
Inviato da Mailspring (https://getmailspring.com/), la migliore app di posta 
elettronica gratuita per il lavoro
On ott 17 2020, at 1:42 pm, Gregory Casamento  wrote:
>
> I have made a change that uses a png file as the icon instead of the tiff and 
> this appears to resolve the issue I showed in my attachment. This is not a 
> general fix as there are a few other apps that show this issue. One of them 
> is InnerSpace in the GAP project. Please give this a try.
>
> GC
> On Sat, Oct 17, 2020 at 7:11 AM Gregory Casamento  (mailto:greg.casame...@gmail.com)> wrote:
> >
> > Alessandro,
> >
> > The SystemPreferences icon has always had an issue with WindowMaker. It's 
> > just a normal tiff, but, for some reason, it shows up as color inverted 
> > when docked in the WindowMaker dock, but normal when the application is 
> > started. When you first start an application in GNUstep the icon gets 
> > written to ~/GNUstep/Library/WindowMaker/CachedPixmaps when the application 
> > is launched. I forget where precisely in the code this occurs.
> >
> > I believe this corruption might have something to do with your problem as 
> > the second time it is invoked it reads the version of the icon that was 
> > cached in the directory I indicated above.
> >
> > There are a number of possible solutions:
> > 1) Fix the tiff so that WindowMaker doesn't have an issue
> > 2) Fix WindowMaker (or GNUstep, in case the caching is happening in our 
> > code... I am not sure it is)
> >
> > I have included a screenshot of what is happening on my system to 
> > illustrate what I'm referring to. Please find it attached. I hope some of 
> > this additional information helps.
> >
> > Yours, GC
> > On Sat, Oct 17, 2020 at 4:32 AM Alessandro Sangiuliano 
> > mailto:alex2...@hotmail.com)> wrote:
> > > This morning I had more time to do better test.
> > >
> > > I have to add that in my case is just SystemPreferences icon that is not 
> > > showed at first start.
> > >
> > > With Gorm and ProjectCenter, the window is showed as expected at first 
> > > run!
> > >
> > > Maybe is just a little bug relative to SystemPreferences in my case, or 
> > > just some request that SystemPreferences is doing and I'm not handling.
> > >
> > > Alex.
> > >
> > > Da: Gnustep-dev  > > (mailto:hotmail@gnu.org)> per conto di Alessandro Sangiuliano 
> > > mailto:alex2...@hotmail.com)>
> > > Inviato: sabato 17 ottobre 2020 04:59
> > > A: undefined mailto:gnustep-dev@gnu.org)>
> > > Cc: undefined mailto:gnustep-dev@gnu.org)>
> > > Oggetto: R: windowmaker - application icon missing at first start
> > >
> > >
> > > I wrote this email some days ago to Fred privately, because I was 
> > > thinking that the problem was relative to my window manager that is young 
> > > and ealyy stage, so i post here too bcause the problem is quite similar.
> > >
> > >
> > > Hi Fred,
> > > I write becaus ethe gnustep support in uroswm is almost completed, but 
> > > there are few things to fix, actually in the miniwindow managment. 
> > > Explain it with words would be a bit complex especially with my english, 
> > > so I made a gif pic to share with you.
> > > Here is the lin that will expire after one month:
> > > https://ibb.co/3ND5Dhw
> > > Now i explain the problem in steps amd you will noticed them in the gif:
> > > 1) First time run uroswm
> > > 2) First time a GNUstep App
> > > 3) When the App is first time started the miniwindow on the left-bottom 
> > > corner doesn't draw the icon, or better, it draws the icon but disappers 
> > > quite soon. The icon just appears for some instants and then disappers.
> > > 4) I close the App
> > > 5) I run again the app
> > > 6) At this point, the App is started for the second time, ll works as 
> > > expecetd and the miniwindow draws the icon ans show it as expected.
> > >
> > > Don't be scared by bad colors in the gif i just set low quality to the 
> > > recorder.
> > > Why at the first start of theapp the icon is not painted as we expects? 
> > > Maybe at the first run GS is doing some particular requests or 
> > > setting/asking for soe extended window manager hints?
> > > Thank you,
> > > Alex
> > >
> > >
> > >
> > >
> > > Da: Gnustep-dev  > > (mailto:hotmail@gnu.org)> per conto di Riccardo Mottola 
> > > mailto:riccardo.mott...@libero.it)>
> > > Inviato: venerdì 16 ottobre 2020 11:40
> > > A: gnustep-dev@gnu.org (mailto:gnustep-dev@gnu.org)  > > (mailto:gnustep-dev@gnu.org)>
> > > Oggetto: windowmaker - application icon missing at first start
> > >
> > >
> > > Hi!
> > >
> > > I noticed we recently have a strange behaviour, which is slightly
> > > different from setup (= installation on different computers) to setup I 
> > > have
> > >
> > > The first time I start a GNUstep application with windowmaker (I mean
> > > the first GNUstep app started ever after X11 start essentially) it has a
> > > bad icon.
> > > - on some setup it has a "generic" icon by windowmaker
> > > - on other 

Re: windowmaker - application icon missing at first start

[Gregory Casamento]

Darn.  Sorry, it was worth a try.  I have to say I am REALLY happy to see
so much progress on your window manager.  Great stuff!  I look forward to
trying it out. :)

GC


On Sat, Oct 17, 2020 at 7:51 AM  wrote:

> I just tried but it doesn't solve my problem.
>
> Alex
>
> Inviato da Mailspring , la migliore app di
> posta elettronica gratuita per il lavoro
> On ott 17 2020, at 1:42 pm, Gregory Casamento 
> wrote:
>
>
> I have made a change that uses a png file as the icon instead of the tiff
> and this appears to resolve the issue I showed in my attachment.  This is
> not a general fix as there are a few other apps that show this issue.  One
> of them is InnerSpace in the GAP project.  Please give this a try.
>
> GC
>
> On Sat, Oct 17, 2020 at 7:11 AM Gregory Casamento <
> greg.casame...@gmail.com> wrote:
>
>
> Alessandro,
>
> The SystemPreferences icon has always had an issue with WindowMaker.  It's
> just a normal tiff, but, for some reason, it shows up as color inverted
> when docked in the WindowMaker dock, but normal when the application is
> started.  When you first start an application in GNUstep the icon gets
> written to ~/GNUstep/Library/WindowMaker/CachedPixmaps when the application
> is launched.  I forget where precisely in the code this occurs.
>
> I believe this corruption might have something to do with your problem as
> the second time it is invoked it reads the version of the icon that was
> cached in the directory I indicated above.
>
> There are a number of possible solutions:
> 1) Fix the tiff so that WindowMaker doesn't have an issue
> 2) Fix WindowMaker (or GNUstep, in case the caching is happening in our
> code... I am not sure it is)
>
> I have included a screenshot of what is happening on my system to
> illustrate what I'm referring to.  Please find it attached.  I hope some of
> this additional information helps.
>
> Yours, GC
>
> On Sat, Oct 17, 2020 at 4:32 AM Alessandro Sangiuliano <
> alex2...@hotmail.com> wrote:
>
> This morning I had more time to do better test.
>
> I have to add that in my case is just SystemPreferences icon that is not
> showed at first start.
>
> With Gorm and ProjectCenter, the window is showed as expected at first run!
>
> Maybe is just a little bug relative to SystemPreferences in my case, or
> just some request that SystemPreferences is doing and I'm not handling.
>
> Alex.
>
> *Da:* Gnustep-dev  per
> conto di Alessandro Sangiuliano 
> *Inviato:* sabato 17 ottobre 2020 04:59
> *A:* undefined 
> *Cc:* undefined 
> *Oggetto:* R: windowmaker - application icon missing at first start
>
> I wrote this email some days ago to Fred privately, because I was thinking
> that the problem was relative to my window manager that is young and ealyy
> stage, so i post here too bcause the problem is quite similar.
>
> Hi Fred,
>
> I write becaus ethe gnustep support in uroswm is almost completed, but
> there are few things to fix, actually in the miniwindow managment. Explain
> it with words would be a bit complex especially with my english, so I made
> a gif pic to share with you.
>
> Here is the lin that will expire after one month:
>
> https://ibb.co/3ND5Dhw
>
> Now i explain the problem in steps amd you will noticed them in the gif:
>
> 1) First time run uroswm
> 2) First time a GNUstep App
> 3) When the App is first time started the miniwindow on the left-bottom
> corner doesn't draw the icon, or better, it draws the icon but disappers
> quite soon. The icon just appears for some instants and then disappers.
> 4) I close the App
> 5) I run again the app
> 6) At this point, the App is started for the second time, ll works as
> expecetd and the miniwindow draws the icon ans show it as expected.
>
> Don't be scared by bad colors in the gif i just set low quality to the
> recorder.
>
> Why at the first start of theapp the icon is not painted as we expects?
> Maybe at the first run GS is doing some particular requests or
> setting/asking for soe extended window manager hints?
>
> Thank you,
> Alex
>
>
> *Da:* Gnustep-dev  per
> conto di Riccardo Mottola 
> *Inviato:* venerdì 16 ottobre 2020 11:40
> *A:* gnustep-dev@gnu.org 
> *Oggetto:* windowmaker - application icon missing at first start
>
> Hi!
>
> I noticed we recently have a strange behaviour, which is slightly
> different from setup (= installation on different computers) to setup I
> have
>
> The first time I start a GNUstep application with windowmaker (I mean
> the first GNUstep app started ever after X11 start essentially) it has a
> bad icon.
> - on some setup it has a "generic" icon by windowmaker
> - on other setups it has a black looking icon, as only the "mask" of the
> icon, the contours are drawn
>
> A restart of the app and then starting any other app, fixes that.
>
>
> This was not happening before. I think it is related to at least this
> commit - merge:
>
>
> https://github.com/mozilla/newtab-dev/raw/6be44da368fb869a3d3e1975f515857352a7d9fc/browser/modules/ProcessHang

Re: windowmaker - application icon missing at first start

[alex22_7]

Yes it doesn't solved my problem, but solved a SystemPreferences problem, So it 
was worth anyway.

As I said I'm pretty sure the problem is relative to my window manager, because 
with awesomewm and echinus it works as expected.
Inviato da Mailspring (https://getmailspring.com/), la migliore app di posta 
elettronica gratuita per il lavoro
On ott 17 2020, at 2:13 pm, Gregory Casamento  wrote:
> Darn. Sorry, it was worth a try. I have to say I am REALLY happy to see so 
> much progress on your window manager. Great stuff! I look forward to trying 
> it out. :)
>
> GC
>
> On Sat, Oct 17, 2020 at 7:51 AM  (mailto:alex2...@hotmail.com)> wrote:
> > I just tried but it doesn't solve my problem.
> >
> > Alex
> > Inviato da Mailspring (https://getmailspring.com/), la migliore app di 
> > posta elettronica gratuita per il lavoro
> > On ott 17 2020, at 1:42 pm, Gregory Casamento  > (mailto:greg.casame...@gmail.com)> wrote:
> > >
> > > I have made a change that uses a png file as the icon instead of the tiff 
> > > and this appears to resolve the issue I showed in my attachment. This is 
> > > not a general fix as there are a few other apps that show this issue. One 
> > > of them is InnerSpace in the GAP project. Please give this a try.
> > >
> > > GC
> > > On Sat, Oct 17, 2020 at 7:11 AM Gregory Casamento 
> > > mailto:greg.casame...@gmail.com)> wrote:
> > > >
> > > > Alessandro,
> > > >
> > > > The SystemPreferences icon has always had an issue with WindowMaker. 
> > > > It's just a normal tiff, but, for some reason, it shows up as color 
> > > > inverted when docked in the WindowMaker dock, but normal when the 
> > > > application is started. When you first start an application in GNUstep 
> > > > the icon gets written to ~/GNUstep/Library/WindowMaker/CachedPixmaps 
> > > > when the application is launched. I forget where precisely in the code 
> > > > this occurs.
> > > >
> > > > I believe this corruption might have something to do with your problem 
> > > > as the second time it is invoked it reads the version of the icon that 
> > > > was cached in the directory I indicated above.
> > > >
> > > > There are a number of possible solutions:
> > > > 1) Fix the tiff so that WindowMaker doesn't have an issue
> > > > 2) Fix WindowMaker (or GNUstep, in case the caching is happening in our 
> > > > code... I am not sure it is)
> > > >
> > > > I have included a screenshot of what is happening on my system to 
> > > > illustrate what I'm referring to. Please find it attached. I hope some 
> > > > of this additional information helps.
> > > >
> > > > Yours, GC
> > > > On Sat, Oct 17, 2020 at 4:32 AM Alessandro Sangiuliano 
> > > > mailto:alex2...@hotmail.com)> wrote:
> > > > > This morning I had more time to do better test.
> > > > >
> > > > > I have to add that in my case is just SystemPreferences icon that is 
> > > > > not showed at first start.
> > > > >
> > > > > With Gorm and ProjectCenter, the window is showed as expected at 
> > > > > first run!
> > > > >
> > > > > Maybe is just a little bug relative to SystemPreferences in my case, 
> > > > > or just some request that SystemPreferences is doing and I'm not 
> > > > > handling.
> > > > >
> > > > > Alex.
> > > > >
> > > > > Da: Gnustep-dev  > > > > (mailto:hotmail@gnu.org)> per conto di Alessandro Sangiuliano 
> > > > > mailto:alex2...@hotmail.com)>
> > > > > Inviato: sabato 17 ottobre 2020 04:59
> > > > > A: undefined mailto:gnustep-dev@gnu.org)>
> > > > > Cc: undefined mailto:gnustep-dev@gnu.org)>
> > > > > Oggetto: R: windowmaker - application icon missing at first start
> > > > >
> > > > >
> > > > > I wrote this email some days ago to Fred privately, because I was 
> > > > > thinking that the problem was relative to my window manager that is 
> > > > > young and ealyy stage, so i post here too bcause the problem is quite 
> > > > > similar.
> > > > >
> > > > >
> > > > > Hi Fred,
> > > > > I write becaus ethe gnustep support in uroswm is almost completed, 
> > > > > but there are few things to fix, actually in the miniwindow 
> > > > > managment. Explain it with words would be a bit complex especially 
> > > > > with my english, so I made a gif pic to share with you.
> > > > > Here is the lin that will expire after one month:
> > > > > https://ibb.co/3ND5Dhw
> > > > > Now i explain the problem in steps amd you will noticed them in the 
> > > > > gif:
> > > > > 1) First time run uroswm
> > > > > 2) First time a GNUstep App
> > > > > 3) When the App is first time started the miniwindow on the 
> > > > > left-bottom corner doesn't draw the icon, or better, it draws the 
> > > > > icon but disappers quite soon. The icon just appears for some 
> > > > > instants and then disappers.
> > > > > 4) I close the App
> > > > > 5) I run again the app
> > > > > 6) At this point, the App is started for the second time, ll works as 
> > > > > expecetd and the miniwindow draws the icon ans show it as expected.
> > > > >
> > > > > Don't be scared by bad colors in the gif i j

Re: windowmaker - application icon missing at first start

[Wolfgang Lux]

Hi Sergii,
> 
> 
> Hi,
> 
>> On Oct 17, 2020, at 00:27, Wolfgang Lux  wrote:
>> 
>> Hi Riccardo,
>> 
>>> I noticed we recently have a strange behaviour, which is slightly
>>> different from setup (= installation on different computers) to setup I have
>>> 
>>> The first time I start a GNUstep application with windowmaker (I mean
>>> the first GNUstep app started ever after X11 start essentially) it has a
>>> bad icon.
>>> - on some setup it has a "generic" icon by windowmaker
>>> - on other setups it has a black looking icon, as only the "mask" of the
>>> icon, the contours are drawn
> 
> Riccardo, could you please provide more info on your specific setups?
> Do you have “UseWindowMakerIcons” set to “NO” in NSGlobalDomain?
> 
>>> 
>>> A restart of the app and then starting any other app, fixes that.
>>> 
>>> 
>>> This was not happening before.
>> 
>> Actually, this has been happening before, but it was fixed about five years 
>> ago in this commit:
>> https://github.com/gnustep/libs-back/commit/1e1185abb364f2ffcb5f06f62c1241d419b8b697#diff-c3c9abc7461037f8abf3f590d909cff84c39bc7817b79d7dfd379b38a3756385
>> 
>>> I think it is related to at least this
>>> commit - merge:
>>> 
>>> https://github.com/mozilla/newtab-dev/raw/6be44da368fb869a3d3e1975f515857352a7d9fc/browser/modules/ProcessHangMonitor.jsm
>> 
>> I assume you meant this commit instead
>> https://github.com/gnustep/libs-back/commit/31b7c4ed2f8efa0127605511aaf4eafef6a3d1c8
>> And, yes, your suspicion is correct because it exactly comments out the 
>> earlier fix.
> 
> As stated in description to this commit it fixes flickering of appicon at 
> application start. Quote: “This fix based on the fact that root application 
> window (ROOT) is mapped in `-orderwindow:::` and this is the event of 
> application recognition by WindowMaker because it is a first application 
> window that is mapped.”. That "root application window" is called “group 
> leader” and saved in every application window structure (WWindow) member 
> `main_window` inside WM. It holds all required properties to be detected by 
> WM correctly.
> 
> The earlier fix probably masks other unknown problem. My WindowMaker 0.95.7 
> default configuration tests work like a charm.
> Wolfgang, do you observe the same behaviour as Riccardo? I yes, could you 
> please share your setup?

Sorry, I haven't been using WindowMaker for a while so I can't really 
contribute anything
here. However, I can perhaps try to better explain the rationale for the fix. 
Normally,
WindowMaker manages the app icon and the menu on the app icon itself. However, 
it does
allow GNUstep applications to override that app icon by supplying those on the 
app icon
windows. The problem here is that this works only if the app icon is the first 
window which
is opened by the GNUstep application. This is not a problem in general, as the 
first window
opened by gnustep-gui is the app icon. However, for the very first application 
in an X11
session, gnustep-back wants to determine the frame offsets and it does so by 
opening a set
of off-screen windows in the _checkStyle: method, which is called from 
setupRootWindow.
The important point here is that these windows are created *before* the app 
icon window is
created in the -window method. And at the point where the first auxiliary 
window is
created WindowMaker creates an app icon for our application itself. Our 
attempts to set the
icon and menu through the app icon window created by the -window method 
then go to the
wrong window are ignored by WindowMaker. The fix I had committed simply 
attempts to make
sure that our app icon window is created before the auxiliary windows. If you 
see a flickering
here, you might attempt to improve the fix by creating the app icon only when 
the backend
is actually going to call _checkStyle: and create any auxiliary windows.

Note that in a normal configuration the issue applies only to the first 
application started
in an X11 Session, but you can set the default GSIgnoreRootOffsets to YES to 
have the backend
determine the frame offsets for every application.

Hope this helps,
Wolfgang

Re: windowmaker - application icon missing at first start

[Sergii Stoian]

Hi Wolfgang,

> On Oct 18, 2020, at 14:38, Wolfgang Lux  wrote:
> 
> Hi Sergii,
>> 
>> 
>> Hi,
>> 
>>> On Oct 17, 2020, at 00:27, Wolfgang Lux  wrote:
>>> 
>>> Hi Riccardo,
>>> 
 I noticed we recently have a strange behaviour, which is slightly
 different from setup (= installation on different computers) to setup I 
 have
 
 The first time I start a GNUstep application with windowmaker (I mean
 the first GNUstep app started ever after X11 start essentially) it has a
 bad icon.
 - on some setup it has a "generic" icon by windowmaker
 - on other setups it has a black looking icon, as only the "mask" of the
 icon, the contours are drawn
>> 
>> Riccardo, could you please provide more info on your specific setups?
>> Do you have “UseWindowMakerIcons” set to “NO” in NSGlobalDomain?
>> 
 
 A restart of the app and then starting any other app, fixes that.
 
 
 This was not happening before.
>>> 
>>> Actually, this has been happening before, but it was fixed about five years 
>>> ago in this commit:
>>> https://github.com/gnustep/libs-back/commit/1e1185abb364f2ffcb5f06f62c1241d419b8b697#diff-c3c9abc7461037f8abf3f590d909cff84c39bc7817b79d7dfd379b38a3756385
>>> 
 I think it is related to at least this
 commit - merge:
 
 https://github.com/mozilla/newtab-dev/raw/6be44da368fb869a3d3e1975f515857352a7d9fc/browser/modules/ProcessHangMonitor.jsm
>>> 
>>> I assume you meant this commit instead
>>> https://github.com/gnustep/libs-back/commit/31b7c4ed2f8efa0127605511aaf4eafef6a3d1c8
>>> And, yes, your suspicion is correct because it exactly comments out the 
>>> earlier fix.
>> 
>> As stated in description to this commit it fixes flickering of appicon at 
>> application start. Quote: “This fix based on the fact that root application 
>> window (ROOT) is mapped in `-orderwindow:::` and this is the event of 
>> application recognition by WindowMaker because it is a first application 
>> window that is mapped.”. That "root application window" is called “group 
>> leader” and saved in every application window structure (WWindow) member 
>> `main_window` inside WM. It holds all required properties to be detected by 
>> WM correctly.
>> 
>> The earlier fix probably masks other unknown problem. My WindowMaker 0.95.7 
>> default configuration tests work like a charm.
>> Wolfgang, do you observe the same behaviour as Riccardo? I yes, could you 
>> please share your setup?
> 
> Sorry, I haven't been using WindowMaker for a while so I can't really 
> contribute anything
> here. However, I can perhaps try to better explain the rationale for the fix. 
> Normally,
> WindowMaker manages the app icon and the menu on the app icon itself. 
> However, it does
> allow GNUstep applications to override that app icon by supplying those on 
> the app icon
> windows. The problem here is that this works only if the app icon is the 
> first window which
> is opened by the GNUstep application. This is not a problem in general, as 
> the first window
> opened by gnustep-gui is the app icon. However, for the very first 
> application in an X11
> session, gnustep-back wants to determine the frame offsets and it does so by 
> opening a set
> of off-screen windows in the _checkStyle: method, which is called from 
> setupRootWindow.
> The important point here is that these windows are created *before* the app 
> icon window is
> created in the -window method. And at the point where the first auxiliary 
> window is
> created WindowMaker creates an app icon for our application itself. Our 
> attempts to set the
> icon and menu through the app icon window created by the -window method 
> then go to the
> wrong window are ignored by WindowMaker. The fix I had committed simply 
> attempts to make
> sure that our app icon window is created before the auxiliary windows. If you 
> see a flickering
> here, you might attempt to improve the fix by creating the app icon only when 
> the backend
> is actually going to call _checkStyle: and create any auxiliary windows.
> 
> Note that in a normal configuration the issue applies only to the first 
> application started
> in an X11 Session, but you can set the default GSIgnoreRootOffsets to YES to 
> have the backend
> determine the frame offsets for every application.
> 
> Hope this helps,
> Wolfgang

Thank you for excellent explanation. You’re absolutely right about _checkStyle: 
- I forgot about it since I’ve created a PR.
Although probably code was changed and it works slightly different now. 
_checkStyle: method is called from _setupRootWindow 
only if GSBackHandlesWindowDecorations is set to YES. At least now I understand 
what we should check in Riccardo's setup.

Riccardo, do you have GSBackHandlesWindowDecorations set to YES?

Sergii