date:20110207

This issues was worked out in ##gwt - had to do with a class that was not 
available to the GWT compiler. Still, the error reported is less than 
helpful.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.

Re: Help: Reusing RPC serialization between GWT and Java Applet

Every Async impl on the client gets a serializer instance to go with it - 
crack open the generated code to see what it comes up with. It is possible 
to subclass the ServiceInterfaceProxyGenerator to provide your own custom 
subclass of ProxyCreator which instead of setting the impl's superclass as 
RemoteServiceProxy would use some other impl of your devising. If I remember 
correctly, doInvoke can be overridden to pass off to some other class of 
your choosing, instead of sending data through the RequestBuilder. This is 
pretty easy to do, once you see how it all wires together, but it can take 
some time to learn. Additionally, this is something the GWT app would need 
to initiate – the RPC stuff doesn't work for the server to call the client.

Another option you might look into would be the AutoBeanCodex, used in 
AutoBean and RequestFactory stuff.

-Colin

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.

Re: Help: Reusing RPC serialization between GWT and Java Applet

2011-02-07 Thread Michael.Krog

Cool.

Before your reply I prototyped a hack on the requestbuilder and it
kinda works -
but its totally hacked. :)

I think Im getting the hang of how it all adds up in GWT-RPC, and your
suggestion
really makes sense. Im gonna give the extendes ProxyGenerator a try.



On 7 Feb., 20:26, Colin Alworth niloc...@gmail.com wrote:
 Every Async impl on the client gets a serializer instance to go with it -
 crack open the generated code to see what it comes up with. It is possible
 to subclass the ServiceInterfaceProxyGenerator to provide your own custom
 subclass of ProxyCreator which instead of setting the impl's superclass as
 RemoteServiceProxy would use some other impl of your devising. If I remember
 correctly, doInvoke can be overridden to pass off to some other class of
 your choosing, instead of sending data through the RequestBuilder. This is
 pretty easy to do, once you see how it all wires together, but it can take
 some time to learn. Additionally, this is something the GWT app would need
 to initiate – the RPC stuff doesn't work for the server to call the client.

 Another option you might look into would be the AutoBeanCodex, used in
 AutoBean and RequestFactory stuff.

 -Colin

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.

To Google Team: Re: Celltable rows selection with focus

2011-02-07 Thread Deepak Singh

Hello Team@google,

I could not find any solution to implement this feature but i need this
anyhow.
Can you guys give some solution to this. I am using GWT 2.1.1.

Hope the google team finds out some way out.

Thanks
Deepak

On Tue, Feb 1, 2011 at 12:39 AM, Zak zakn...@gmail.com wrote:

 These docs should help you:


 http://code.google.com/webtoolkit/doc/latest/DevGuideUiCellWidgets.html#selection

 On Jan 31, 11:42 am, Deepak Singh deepaksingh...@gmail.com wrote:
   Any suggestion pls...
 
  On Sun, Jan 30, 2011 at 4:00 PM, Deepak Singh deepaksingh...@gmail.com
 wrote:
 
   Hi,
 
   I am using GWT 2.1.1 and have one celltable working fine.
   I want to provide better user experience so i need to implement the
   following feature,
 
   I want the rows to be selected with focus and then get the selected
 object
   for further action.
   when the table is created and appeared first time, the focus should
   automatically go to first row and the row should automatically be
 selected
   and as focus moves through rows by using arrow keys, corresponding rows
   should be selected and i should be able to get the selected object with
   focus moving on.
 
   I tried to add FocusHandler to celltable but could not find any
 suitable
   API for this.
 
   Suggest some ways to acheive this.
 
   Thanks

 --
 You received this message because you are subscribed to the Google Groups
 Google Web Toolkit group.
 To post to this group, send email to google-web-toolkit@googlegroups.com.
 To unsubscribe from this group, send email to
 google-web-toolkit+unsubscr...@googlegroups.com.
 For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.



-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.

Re: Considering using Google Accounts for authentication. Good idea?

2011-02-07 Thread Thomas Broyer

It's always possible if you do it using servlet filters, similar to Spring 
Security. What you cannot use (judging from the docs only) is container 
based security:

App Engine does not support custom security roles (security-role) or 
alternate authentication mechanisms (login-config) in the deployment 
descriptor.

— Source: 
http://code.google.com/appengine/docs/java/config/webxml.html#Security_and_Authentication
 

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.

Re: To Google Team: Re: Celltable rows selection with focus

2011-02-07 Thread John LaBanca

I created an issue to track this:
http://code.google.com/p/google-web-toolkit/issues/detail?id=5990

Thanks,
John LaBanca
jlaba...@google.com


On Mon, Feb 7, 2011 at 4:24 PM, Deepak Singh deepaksingh...@gmail.comwrote:

 Hello Team@google,

 I could not find any solution to implement this feature but i need this
 anyhow.
 Can you guys give some solution to this. I am using GWT 2.1.1.

 Hope the google team finds out some way out.

 Thanks
 Deepak

 On Tue, Feb 1, 2011 at 12:39 AM, Zak zakn...@gmail.com wrote:

 These docs should help you:


 http://code.google.com/webtoolkit/doc/latest/DevGuideUiCellWidgets.html#selection

 On Jan 31, 11:42 am, Deepak Singh deepaksingh...@gmail.com wrote:
   Any suggestion pls...
 
  On Sun, Jan 30, 2011 at 4:00 PM, Deepak Singh deepaksingh...@gmail.com
 wrote:
 
   Hi,
 
   I am using GWT 2.1.1 and have one celltable working fine.
   I want to provide better user experience so i need to implement the
   following feature,
 
   I want the rows to be selected with focus and then get the selected
 object
   for further action.
   when the table is created and appeared first time, the focus should
   automatically go to first row and the row should automatically be
 selected
   and as focus moves through rows by using arrow keys, corresponding
 rows
   should be selected and i should be able to get the selected object
 with
   focus moving on.
 
   I tried to add FocusHandler to celltable but could not find any
 suitable
   API for this.
 
   Suggest some ways to acheive this.
 
   Thanks

 --
 You received this message because you are subscribed to the Google Groups
 Google Web Toolkit group.
 To post to this group, send email to google-web-toolkit@googlegroups.com.
 To unsubscribe from this group, send email to
 google-web-toolkit+unsubscr...@googlegroups.com.
 For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.


  --
 You received this message because you are subscribed to the Google Groups
 Google Web Toolkit group.
 To post to this group, send email to google-web-toolkit@googlegroups.com.
 To unsubscribe from this group, send email to
 google-web-toolkit+unsubscr...@googlegroups.com.
 For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.


-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.

Re: To Google Team: Re: Celltable rows selection with focus

2011-02-07 Thread zixzigma

don't you think this can be achieved by using selectionModel.setSelection  
and selecting the first item from the current range ?

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.

Associating editor errors with source widgets

Hello everyone,

Is there a recommended way to find and highlight a widget that is a source 
of an editor 
errorhttp://google-web-toolkit.googlecode.com/svn/javadoc/2.1/com/google/gwt/editor/client/EditorError.html?
 
 It is possible to get the absolute 
pathhttp://google-web-toolkit.googlecode.com/svn/javadoc/2.1/com/google/gwt/editor/client/EditorError.html#getAbsolutePath()
 within 
the edited object, but what is the recommended way to find a corresponding 
widget?

Thank you in advance! 

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.

Re: To Google Team: Re: Celltable rows selection with focus

2011-02-07 Thread John LaBanca

I think deepak wants to set native focus on the table so the user can use
keyboard navigation without having to click on a cell first.

Thanks,
John LaBanca
jlaba...@google.com


On Mon, Feb 7, 2011 at 5:50 PM, zixzigma zixzi...@gmail.com wrote:

 don't you think this can be achieved by using selectionModel.setSelection
 and selecting the first item from the current range ?

 --
 You received this message because you are subscribed to the Google Groups
 Google Web Toolkit group.
 To post to this group, send email to google-web-toolkit@googlegroups.com.
 To unsubscribe from this group, send email to
 google-web-toolkit+unsubscr...@googlegroups.com.
 For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.


-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.

Re: Force render of CellBrowser cell(s)

What kind of data editing do you perform?  If you change the name of a node 
do you need to redraw its ancestors and descendants?  If you delete a node, 
you probably only need to delete columns on the right without re-drawing 
columns on the left.
But may be I'm just missing something...

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.

Re: GWT Compilation Failed

2011-02-07 Thread Henry

I know this post is a bit old, but I recently came across the same 
compilation problem
and the problem/soln is 

I had an annotated class like:

@SuppressWarnings({})
public class LeftPanel 

my fix was to take out the @SuppressWarnings({})

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.

Re: No Source code is available for type client.Utilityt, did you forget to inherit a required module?

2011-02-07 Thread NAARAYANA REDDY NANDIGAMA

Thank you.

I have another requirement.. I have two buttons with same name validate. I
need to identify which button is clicked when I user click on any one of
validate buttton. I thought i can use button.getText but both buttons has
the same name so not sure what to do. Could you please advise me on this?

Thanks in advance,
On Mon, Feb 7, 2011 at 9:09 AM, Hilco Wijbenga hilco.wijbe...@gmail.comwrote:

On 5 February 2011 21:14, Dallas007 nandigam...@gmail.com wrote:
Hi,
i am new to GWT so need help please. I'm am not able to compile my
code due to below error.

Here are my project details,
I have added a new class Utility.java which is out side of Client
package. I have instantiae the Utiltity object inside cliant code and
imported the class. So I am not sure how to fix this could you please
advise me on this?. How to use my Utility class in side client code?

See
http://www.gwtapps.com/doc/html/com.google.gwt.doc.DeveloperGuide.Fundamentals.Modules.ModuleXml.html
,
specifically the source tag.

I would suggest you create a separate module for your utility code.
The generated JAR should contain:

org/example/utils/Code.java
org/example/utils/Code.class
org/example/Utilities.gwt.xml

Where Utilities.gwt.xml has

?xml version=1.0 encoding=UTF-8?
!DOCTYPE module
PUBLIC -//Google Inc.//DTD Google Web Toolkit 2.0.1//EN

http://google-web-toolkit.googlecode.com/svn/tags/2.0.1/distro-source/core/src/gwt-module.dtd

module rename-to=Utilities
inherits name=com.google.gwt.core.Core/
source path=utils/
/module

Then you can use inherits name=org.example.Utilities/ to use your
utility code in other modules.

Re: BestPractice : Use of the Editor Framework with MVP (Place, Activity) and RequestFactory

Thomas (and GWT team)

If a view is a singleton (as recommended by MVP), are there potential memory 
leaks with this approach?   When a second driver is created and initialized, 
does the first driver become completely detached from the view/editor?

Thanks for the advice.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.

Re: No Source code is available for type client.Utilityt, did you forget to inherit a required module?

2011-02-07 Thread Hilco Wijbenga

On 7 February 2011 17:41, NAARAYANA REDDY NANDIGAMA
nandigam...@gmail.com wrote:
 I have another requirement.. I have two buttons with same name validate. I
 need to identify which button is clicked when I user click on any one of
 validate buttton. I thought i can use button.getText but both buttons has
 the same name so not sure what to do. Could you please advise me on this?

I'm not sure what you mean by the same name. You can't have the same
id twice and I don't see why you would want that either.

Just do something like

g:Button ui:field=validateOneValidate/g:Button
g:Button ui:field=validateTwoValidate/g:Button

and in Java

(if you want to do something with the buttons themselves)
@UiField
Button validateOne;
@UiField
Button validateTwo;

(if you want to respond to clicks)
@UiHandler(validateOne)
void onClickValidateOne(ClickEvent event) {...}
@UiHandler(validateTwo)
void onClickValidateTwo(ClickEvent event) {...}

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.

Do ValueProxies require EntityLocator ?

2011-02-07 Thread zixzigma

Do ValueProxies require EntityLocator ?

EntityProxies require EntityLocator, but what about ValueProxies ?

Thank You

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.

Re: Associating editor errors with source widgets

What about getting the editor out of the EditorError by calling 
EditorError.getEditor()? I know it doesn't get a widget per se, but there 
seems to be a good reason for that - not all editors are also widgets, so 
you may need to deal differently with each type of editor's error.

My understanding was that it was up to the editor itself to say that it 
wants to hear about errors by implementing HasEditorErrorsT, and then 
processing its own (or its children's unconsumed) errors. Of course, you 
could do this at any level of the editor hierarchy, and then get the editor, 
and try to do something with that.

Hope this helps push you in the right direction,
Colin

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.

Re: BestPractice : Use of the Editor Framework with MVP (Place, Activity) and RequestFactory

For my part, I've not been creating a 'createEditorDriver()' method, but 
instead 'getEditorDriver()'. This way, there is no concern about binding and 
traversing the tree more than once.

Am I in error with this approach? Each time my presenters get a ref to the 
driver and have finished loading data, they call driver.edit (or .display) 
which should get rid of the old requestcontext, set up a new editor 
delegate, etc. The existing eventbus/factory should still be good.

The only concerns I had were for events that might have already been wired 
up, say from something implementing HasEditorDelegate, but it should be the 
implementing class's responsibility to clear out old registrations... Okay, 
so when (in either case) should those be cleared out? When setDelegate is 
called again? But what if it isn't called again – then do those subscribed 
events just keep going off? Or maybe take them out on .flush(), since you 
know then that the Editor cycle is finished?


-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.

Announcing GPE/GWT 2.2 RC1

2011-02-07 Thread Chris Ramsdale

   Today we're one step closer to shipping the Google Plugin for Eclipse and
   GWT SDK 2.2. The first release candidates of both of these products are
   ready for use, and can be installed and/or download via the links below.

   Google Plugin for Eclipse 2.2 RC1 (including the GWT SDK)
   Eclipse 3.6
   http://dl.google.com/eclipse/plugin/beta/e36

   Eclipse 3.5
   http://dl.google.com/eclipse/plugin/beta/e35

   Eclipse 3.4
   http://dl.google.com/eclipse/plugin/beta/e34




   GWT SDK 2.2 RC1 (standalone)

   
http://code.google.com/p/google-web-toolkit/downloads/detail?name=gwt-2.2-RC1.zip




   This release includes fixes and updates for the following items:
   - Fixed bad date formats in Swedish and others
  - Added initial version of HTML5 Audio and Video support
  - Added JRE 1.5 deprecation warning (see note below)
  - Fixed bad gwt-servlet dep in samples/expenses/pom.xml, per
  http://code.google.com/p/google-web-toolkit/issues/detail?id=5918
  - Fixed Javadoc:
  http://code.google.com/p/google-web-toolkit/issues/detail?q=5615
  - Fixed DynaTableRf paging infinite loop
  - Fixed CellBrowser hard to focus in IE
  - Bumped pom.xml version, and fix NPE in samples/expenses
  - Improved canvas for browsers (and permutations) with partial canvas
  support.
  - Updated DTRF to show the use of ServiceLocators and Locators
  - Fixed Showcase locales

   GPE 2.2 RC1
   - Fixed Widget is disposed errors that occur when editing Launch
  Configurations
  - Fixed NullPointerException that occurs when deleting a launch
  configuration that has been launched


   Version 2.2 will only have deprecated support for Java 1.5, resulting in
   warnings when building applications. While Java 1.5 will still work for at
   least the next release of GWT, developers should upgrade their version of
   Java to correct these warnings and ensure compatibility with future versions
   of GWT.




   -- Chris, on behalf of the GWT, App Engine, and Google Plugin teams

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.

Calling Window.getClientHeight() from Iframe returns wrong value

2011-02-07 Thread Oren

Hey,

I'm using GWT to write a simple FB canvas app. I noticed all my
centered dialogs are way off in terms of vertical placement. Digging
deeper I learned that Window.getClientHeight() returns the iframe
height and not the visible area's height and thus the dialogs are not
centered properly.

Does anyone know how I can overcome this issue and get my dialogs
centered properly? Didn't find much about it browsing through the
group discussions...

Thanks,
Oren.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.

GWT+SpringSecurity - handling session-timeout

2011-02-07 Thread andrew

Hi,

we are implementing an application using GWT2.1 + Spring security 3.0.
We use a SSO Kerberos authentication, if this fails, user can still
log in through a login page.

Our basic configuration is something like this:

sec:http entry-point-ref=entryPoint
sec:session-management invalid-session-url=/login.jsp /
sec:intercept-url pattern=/login.jsp* filters=none /
sec:intercept-url pattern=/images/* filters=none /
sec:intercept-url pattern=/css/* filters=none /
sec:intercept-url pattern=/* access=IS_AUTHENTICATED_FULLY /
sec:custom-filter ref=spnegoProcessingFilter
position=BASIC_AUTH_FILTER /
sec:form-login login-page=/login.jsp default-target-url=/
Portal.html always-use-default-target=false authentication-failure-
url=/login.jsp?login_error /
sec:logout logout-success-url=/login.jsp?logout invalidate-
session=true /
/sec:http

The authentication process works fine. Our problem is, how to deal
with the session time-out. SpringSecurity recognizes the the session
is invalid and calls in the filter chain a DefaultRedirectStrategy-
response.redirect(/login.jsp), how expected. But the redirect gets
lost and nothing happens. The user has to restart the browser or
recall the login URL by him self.

I read somewhere, that redirects are ignored by the GWT client, but
I'm not sure with this.

Any idea how to handle session-timeouts in GWT or how to make filter
redirects work for GWT clients?

Thanks for any advice,

Andrej

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.

Re: GWT + Google Spreadsheet Visualization API = Messed-up Data (Limit on size of JSON output?)

2011-02-07 Thread Chuck

... and the answer is: When you want to increment the amount of 
length(ROWS), don't put as the upper limit of length(COLUMNS).

It now seems to be grabbing all the data I'm looking for.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.

GWT + Google Spreadsheet Visualization API = Messed-up Data (Limit on size of JSON output?)

2011-02-07 Thread Chuck

I used to get my JSON data for my Web App using Google/alt-json-in-script, 
using the native method specified in the original documentation to do so.  
This worked well... until I wanted to use the new method, 
JsonpRequestBuilder and the Visualization API instead, for an application 
where I was making up to twelve different requests from the same spreadsheet 
- querying the spreadsheet to limit the amount of data returned.

I thought: what better than to just grab the data only twice in one gigantic 
chunk, and then manipulate it in Java GWT where I'm supposed to?  (Plus, it 
would make my code easier to read, debug, and reuse.)

The problem is that the Google spreadsheet I'm using is quite large - 27 
columns across, and around 1,000 rows.

After creating a new JsonpRequestBuilder, using a callback hack, and 
grabbing the data... it craps out after processing 26 rows successfully.

*java.lang.IllegalArgumentException: Something other than a Java object was 
returned from JSNI method 
'@collegesportssource.client.SchedSpreadsheetResponseJso$JsonSchedEntry::getTixlink()':
 
JS value of type int, expected java.lang.Object*

In the spreadsheet, getTixLink is a valid value, not an integer like it says 
here.  I made sure of this by adding a row in the spreadsheet before the 
error.  Sure enough, after 26 rows, same place, one row up, it gets the same 
error.

Looking at the URL from the Visualization API, it brings back all the data 
successfully.  So it's not a problem with the API, it's a problem within 
GWT.

So, my questions are:
* Is there a limit to the amount of JSON data transported by a singular 
JavaScriptObject via the JsonpRequestBuilder?
* Is there a way I can increase the size of this limit?  (Is it worth it?)
* If I can't, what sort of workaround can I use?  If I have to I could go 
back to my old, hard-to-debug-but-works version of native Javascript calls, 
but I would prefer not to.

Background:

SchedSpreadsheetResponseJso is an overlay type that contains my Spreadsheet 
record.

  private void loadSchedule() {
requestJsonSchedData(new 
AsyncCallbackSchedSpreadsheetResponseJso() {
@Override
public void onFailure(Throwable caught) {
Window.alert(Failure: + caught.getMessage());
} 
@Override
  public void onSuccess(SchedSpreadsheetResponseJso result) {
for( int count = 0; count  result.getColumns().length(); 
count++) {
  JsonSchedEntry jsonSchedEntry = 
result.getRows().get(count);
  addToSchedArray(field1, field2, field3..  field27);
}
}
});
}   

private static void 
requestJsonSchedData(AsyncCallbackSchedSpreadsheetResponseJso callback) {
JsonpRequestBuilder jsonp = new JsonpRequestBuilder();
jsonp.setTimeout(1000);
jsonp.requestObject(TEAM_SCHED, callback);
registerGoogleVisualizationAPICallbackMethod(); 
  }

private static native void 
registerGoogleVisualizationAPICallbackMethod() /*-{
$wnd.google = new Object();
var google = $wnd.google;
google.visualization = new Object();
var query = google.visualization.Query = new Object();
var counter = $wnd['__gwt_jsonp__']['__gwt_jsonp_counter__']-1;
query.setResponse = function(param) {
  $wnd['__gwt_jsonp__']['I'+counter].onSuccess(param);
  };
}-*/;

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.

setting debugId on nested menu item (UI Binder)

2011-02-07 Thread x-fission

Is there a way to set a debugId (for selenium testing) on a nested
menu item in UI binder? I have a setup similar to a typical menubar
such as:

g:MenuBar ui:field=topMenu
g:MenuItem ui:field=file
 bFile/b
 g:MenuBar
  g:MenuItem ui:field=saveSave/g:MenuItem
   g:MenuItem ui:field=printPrint/g:MenuItem
...(closing tags for everything)

If I set a debugId on all menuItems, only the top level menu item is
visible, and the rest are just indexed items (i.e. gwt-debug-file  for
the top level, and gwt-debug-file-item0 is save, gwt-debug-file-item1
is print, etc.). There is a way to set this up in the Java code using
a base id:

 ensureDebugId(file, file);
ensureDebugId(save, file, save) (file is the baseId argument)

this produces debugId's: gwt-debug-file, and gwt-debug-file-save. Cant
this baseId be set from UI binder?

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.

Re: Associating editor errors with source widgets

Thanks Colin, HasEditorErrorsT makes sense.  Just to recap this approach:

Every editor knows the primitive fields it's editing.  If the editor 
implements HadEditorErrors.showErrors(), it can simply compare 
primitiveField.asEditor() with error.getEditor() and highlight the erroneous 
primitiveField.

As an alternative, a wrapper around a primitive field, like 
ValueBoxEditorDecoratorT, can deal with the highlighting.

Thanks again!

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.

Re: how to add scroll bar in flowpanel ?

2011-02-07 Thread harry

hey thanks but i can't find anything from this will u please
elaborate?
i used scrollpanel in gwt it work nicely in desktop browser but it
doesn't even apear in mobile browser.
it display some of the content only but not appear scrollbar..
pls if u know than help

On Feb 7, 9:40 pm, John LaBanca jlaba...@google.com wrote:
 Most mobile web browsers do not support inline scrolling, only page level
 scrolling.  If you really need inline scrolling, you can take a look at the
 MobileScrollPanel we created for a demo a while back.  It scrolls in
 response to 
 TouchEvents.http://code.google.com/p/google-web-toolkit/source/browse/?#svn%2Ftru...

 Thanks,
 John LaBanca
 jlaba...@google.com







 On Mon, Feb 7, 2011 at 12:48 AM, harry hemangsha...@gmail.com wrote:
  i am developing an mobile application and i have a problem that i can
  not add scrollbar in it.
  i want to add scroll bar in my flow panel and i also want to fix my
  flowpanel's size fit to screen size.
  if anyone knows the solution pls tell me
  thanks in adv

  --
  You received this message because you are subscribed to the Google Groups
  Google Web Toolkit group.
  To post to this group, send email to google-web-toolkit@googlegroups.com.
  To unsubscribe from this group, send email to
  google-web-toolkit+unsubscr...@googlegroups.com.
  For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.

Implementing Contacts List with 'mark as favorite' checkbox

2011-02-07 Thread Nettar

Hello,

I am working on a contacts list application for which I am using
CellList with a custom ContactCell. I need to have a checkbox against
each contact in the list to tell if the contact is the favorite one.

Now, I want to capture 2 types of events on the contact cell:

1. clicking on the checkbox must toggle the contact's favorite status
2. clicking elsewhere on the contact cell must select the contact

I have not been able to differentiate these 2 events. If I add a
SelectionModel to the CellList, it fires even if I am clicking on the
checkbox.

Any suggestions please..

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.

Re: Are user defined Serilizable objects supported as Request parameters?

2011-02-07 Thread Daghan

Hi Thomas,

Do you know if there is an update on this? 

I saw on another post https://jira.springsource.org/browse/ROO-936 that 
you were exchanging notes with Ray Ryan on this.
You have mentioned a wrapper. 

Can you sketch a rough outline for the wrapper? 
Do you serialize to whole thing to a string and rebuild it back?

Thanks in advance for all your help

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.

Re: Announcing GPE/GWT 2.2 RC1

2011-02-07 Thread stuckagain

What features in Java 6 would be so fundamental to GWT that 1.5 becomes 
deprecated ?
 

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.

[gwt-contrib] Re: Introduces SkipInterfaceValidation annotation. (issue1338807)

2011-02-07 Thread bobv


http://code.google.com/p/google-web-toolkit/issues/detail?id=5988

Since you have a set of clearly-articulated reasons, I think this is a
good idea.


http://gwt-code-reviews.appspot.com/1338807/diff/1/4
File
user/src/com/google/gwt/requestfactory/shared/SkipInterfaceValidation.java
(right):

http://gwt-code-reviews.appspot.com/1338807/diff/1/4#newcode33
user/src/com/google/gwt/requestfactory/shared/SkipInterfaceValidation.java:33:
* When applied to an interface, the validator doesn't mandate the
presence of a
Is the interface-skipping implemented?

http://gwt-code-reviews.appspot.com/1338807/diff/1/5
File
user/test/com/google/gwt/requestfactory/server/RequestFactoryInterfaceValidatorTest.java
(left):

http://gwt-code-reviews.appspot.com/1338807/diff/1/5#oldcode98
user/test/com/google/gwt/requestfactory/server/RequestFactoryInterfaceValidatorTest.java:98:
interface DomainProxy extends EntityProxy {
These are supposed to be EntityProxy.  This test class was rushed and
doesn't actually check for particular error messages.  This type is used
by testMissingIdAndVersion(), which is now not failing for the wrong
reason.

http://gwt-code-reviews.appspot.com/1338807/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Handle Validation of Cascaded Generic properties. (issue1343801)

2011-02-07 Thread rchandia


LGTM, with nits


http://gwt-code-reviews.appspot.com/1343801/diff/1/8
File user/src/com/google/gwt/validation/rebind/Util.java (right):

http://gwt-code-reviews.appspot.com/1343801/diff/1/8#newcode93
user/src/com/google/gwt/validation/rebind/Util.java:93: * @return
Remove empty tags

http://gwt-code-reviews.appspot.com/1343801/diff/1/12
File
user/test/org/hibernate/jsr303/tck/tests/constraints/constraintcomposition/ConstraintCompositionGwtTest.java
(right):

http://gwt-code-reviews.appspot.com/1343801/diff/1/12#newcode46
user/test/org/hibernate/jsr303/tck/tests/constraints/constraintcomposition/ConstraintCompositionGwtTest.java:46:
fail(This test only fails on IE.  Forcing it to fail here to keep the
counts even. See Issie 5882.);
Issie - Issue

http://gwt-code-reviews.appspot.com/1343801/diff/1/12#newcode52
user/test/org/hibernate/jsr303/tck/tests/constraints/constraintcomposition/ConstraintCompositionGwtTest.java:52:
fail(This test only fails on IE.  Forcing it to fail here to keep the
counts even. See Issie 5882.);
Idem

http://gwt-code-reviews.appspot.com/1343801/diff/1/13
File
user/test/org/hibernate/jsr303/tck/tests/constraints/customconstraint/CustomConstraintValidatorGwtTest.java
(right):

http://gwt-code-reviews.appspot.com/1343801/diff/1/13#newcode36
user/test/org/hibernate/jsr303/tck/tests/constraints/customconstraint/CustomConstraintValidatorGwtTest.java:36:
fail(This test only fails on IE.  Forcing it to fail here to keep the
counts even. See Issie 5882.);
Idem

http://gwt-code-reviews.appspot.com/1343801/diff/1/14
File
user/test/org/hibernate/jsr303/tck/tests/constraints/validatorresolution/ValidatorResolutionGwtTest.java
(right):

http://gwt-code-reviews.appspot.com/1343801/diff/1/14#newcode40
user/test/org/hibernate/jsr303/tck/tests/constraints/validatorresolution/ValidatorResolutionGwtTest.java:40:
fail(This test only fails on IE.  Forcing it to fail here to keep the
counts even. See Issie 5882.);
Idem

http://gwt-code-reviews.appspot.com/1343801/diff/1/17
File
user/test/org/hibernate/jsr303/tck/tests/validation/ValidatePropertyGwtTest.java
(right):

http://gwt-code-reviews.appspot.com/1343801/diff/1/17#newcode52
user/test/org/hibernate/jsr303/tck/tests/validation/ValidatePropertyGwtTest.java:52:
fail(This test only fails on IE.  Forcing it to fail here to keep the
counts even. See Issie 5882.);
Idem

http://gwt-code-reviews.appspot.com/1343801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Generator Result Caching implementation for ClientBundle (issue1236801)

2011-02-07 Thread bobv



http://gwt-code-reviews.appspot.com/1236801/diff/110014/111010
File user/src/com/google/gwt/resources/ext/ClientBundleRequirements.java
(right):

http://gwt-code-reviews.appspot.com/1236801/diff/110014/111010#newcode66
user/src/com/google/gwt/resources/ext/ClientBundleRequirements.java:66:
* resolvedResourceUrl has changed.
This last sentence isn't clear.  Is the point of the extra resourceName
parameter to handle the automatically-generated resource types from
UiBinder?

http://gwt-code-reviews.appspot.com/1236801/diff/110014/111010#newcode72
user/src/com/google/gwt/resources/ext/ClientBundleRequirements.java:72:
* @param resolvedResourceUrl
Parameter descriptions.

http://gwt-code-reviews.appspot.com/1236801/diff/110014/111011
File user/src/com/google/gwt/resources/ext/ResourceContext.java (right):

http://gwt-code-reviews.appspot.com/1236801/diff/110014/111011#newcode158
user/src/com/google/gwt/resources/ext/ResourceContext.java:158: URL[]
getResourcesForMethod(JMethod method);
This is no longer used in this patch.  Any reason to keep it, since
RGU.findResources() can handle caching of JMethod-URL resolution?

http://gwt-code-reviews.appspot.com/1236801/diff/110014/111014
File
user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java
(right):

http://gwt-code-reviews.appspot.com/1236801/diff/110014/111014#newcode201
user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java:201:
private final SetString axes;
Sort fields alphabetically unless there's a reason to do otherwise.

http://gwt-code-reviews.appspot.com/1236801/diff/110014/111014#newcode211
user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java:211:
this.axesLocked = false;
Unnecessary.

http://gwt-code-reviews.appspot.com/1236801/diff/110014/111014#newcode231
user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java:231:
if (!canBeCacheable) {
With the if call before getConfigurationPropertyName(), this method will
have different error behavior if caching is or is not enabled.

http://gwt-code-reviews.appspot.com/1236801/diff/110014/111014#newcode306
user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java:306:
if (!(type instanceof JRealClassType)) {
Reverse the then-else clauses to avoid a negative test.

http://gwt-code-reviews.appspot.com/1236801/diff/110014/111014#newcode318
user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java:318:
// no further permutation axes can be added after this is called
Make javadoc.

http://gwt-code-reviews.appspot.com/1236801/diff/110014/111014#newcode649
user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java:649:
} catch (RuntimeException ruEx) {
Why?

http://gwt-code-reviews.appspot.com/1236801/diff/110014/111014#newcode668
user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java:668:
/*checkDependentResource
Old comment?

http://gwt-code-reviews.appspot.com/1236801/diff/110014/111015
File
user/src/com/google/gwt/resources/rebind/context/AbstractResourceContext.java
(right):

http://gwt-code-reviews.appspot.com/1236801/diff/110014/111015#newcode57
user/src/com/google/gwt/resources/rebind/context/AbstractResourceContext.java:57:
private MapJMethod, URL[] foundResourceMap = new HashMapJMethod,
URL[]();
Still needed?

http://gwt-code-reviews.appspot.com/1236801/diff/110014/111015#newcode58
user/src/com/google/gwt/resources/rebind/context/AbstractResourceContext.java:58:
private ClientBundleRequirements requirements = null;
Sort.

http://gwt-code-reviews.appspot.com/1236801/diff/110014/111017
File user/src/com/google/gwt/resources/rg/BundleResourceGenerator.java
(right):

http://gwt-code-reviews.appspot.com/1236801/diff/110014/111017#newcode41
user/src/com/google/gwt/resources/rg/BundleResourceGenerator.java:41: +
method.getReturnType().getQualifiedSourceName() + .class);
Does this need to add a requirement on the sub-bundle type, or is that
an implicit dependency of the top-level bundle?

http://gwt-code-reviews.appspot.com/1236801/diff/110014/111018
File user/src/com/google/gwt/resources/rg/CssResourceGenerator.java
(right):

http://gwt-code-reviews.appspot.com/1236801/diff/110014/111018#newcode134
user/src/com/google/gwt/resources/rg/CssResourceGenerator.java:134:
private static final String KEY_OBFUSCATION_PREFIX =
CssResource.obfuscationPrefix;
Sort.

http://gwt-code-reviews.appspot.com/1236801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] RequestFactory - EntityProxy AutoBean Category

2011-02-07 Thread Krishna

Hi,

Does RequestFactory EntityProxy supports AutoBean Category (http://
code.google.com/p/google-web-toolkit/wiki/AutoBean#Categories) ?

i. e. Can I define a Category for an EnitityProxy? If yes, how can I
do that?

It would be nice to define a category direct as an annotated Entity
method... If the method requires only getters/setters and other
category methods.
I know its not easy to restrict. Is it hard to allow Proxy as an
abstract class?

Thanks!
Krishna Caldas

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] RequestFactory - EntityProxy AutoBean Category

2011-02-07 Thread Ray Ryan

You can't do these things yet, but we've been discussing them.

On Thu, Feb 3, 2011 at 5:08 AM, Krishna krishnacal...@gmail.com wrote:

 Hi,

 Does RequestFactory EntityProxy supports AutoBean Category (http://
 code.google.com/p/google-web-toolkit/wiki/AutoBean#Categories) ?

 i. e. Can I define a Category for an EnitityProxy? If yes, how can I
 do that?

 It would be nice to define a category direct as an annotated Entity
 method... If the method requires only getters/setters and other
 category methods.
 I know its not easy to restrict. Is it hard to allow Proxy as an
 abstract class?

 Thanks!
 Krishna Caldas

 --
 http://groups.google.com/group/Google-Web-Toolkit-Contributors


-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Introduces SkipInterfaceValidation annotation. (issue1338807)

2011-02-07 Thread t . broyer


I think I'll revert the changes to the existing tests (keeping only the
changes introducing the new ones exercizing SkipInterfaceValidation),
and make a second patch about fixing them.


http://gwt-code-reviews.appspot.com/1338807/diff/1/4
File
user/src/com/google/gwt/requestfactory/shared/SkipInterfaceValidation.java
(right):

http://gwt-code-reviews.appspot.com/1338807/diff/1/4#newcode33
user/src/com/google/gwt/requestfactory/shared/SkipInterfaceValidation.java:33:
* When applied to an interface, the validator doesn't mandate the
presence of a
On 2011/02/07 14:42:55, bobv wrote:

Is the interface-skipping implemented?


Er, oops! I initially implemented it before deciding that it probably
wasn't a good idea (as I said before: it's a very advanced feature, so
you have to pay a bit for using it).
I then removed the ElementType.TYPE from the @Target but forgot to
update the javadoc.

http://gwt-code-reviews.appspot.com/1338807/diff/1/5
File
user/test/com/google/gwt/requestfactory/server/RequestFactoryInterfaceValidatorTest.java
(left):

http://gwt-code-reviews.appspot.com/1338807/diff/1/5#oldcode98
user/test/com/google/gwt/requestfactory/server/RequestFactoryInterfaceValidatorTest.java:98:
interface DomainProxy extends EntityProxy {
On 2011/02/07 14:42:55, bobv wrote:

These are supposed to be EntityProxy.  This test class was rushed and

doesn't

actually check for particular error messages.  This type is used by
testMissingIdAndVersion(), which is now not failing for the wrong

reason.

Or actually, it is *passing* for the wrong reason (not an EntityProxy
instead of missing Id and Version).

But testDateSubclass, for instance, could pass for the wrong reason if
you make DomainWithSqlDateProxy an EntityProxy (missing id and version
in addition to the expected not a transferable type)
(but in the current state of the patch, it's still passing for the wrong
reason: not an EntityProxy).

I think the proper fix is to add a new EntityProxy for
testMissingIdAndVersion; or to check that the errors.logs.contains() the
expected error (like the testBadLocatorName and testBadServiceName
tests).

Note that testUnexpectedIdAndVersion is probably passing for wrong
reasons: it's missing a findUnexpectedIdAndVersionDomain method, which I
don't think was what the method tried to test.
I manually checked every assertTrue(v.isPoisoned()) to make sure the
errors matched the test name, and it's the only one I found
(DomainWithOverloads is also missing the findDomainWithOverloads static
method, but once fixed or changed to a ValueProxy, the test passes for
the good reason; testUnexpectedIdAndVersion on the other hand fails once
you fix the missing finder method)

Also note that RFIV.getEntityProxyTypeName works equally well for
ValueProxy, so maybe it should be renamed?

http://gwt-code-reviews.appspot.com/1338807/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Handle Validation of Cascaded Generic properties. (issue1343801)

2011-02-07 Thread nchalko



http://gwt-code-reviews.appspot.com/1343801/diff/1/8
File user/src/com/google/gwt/validation/rebind/Util.java (right):

http://gwt-code-reviews.appspot.com/1343801/diff/1/8#newcode93
user/src/com/google/gwt/validation/rebind/Util.java:93: * @return
On 2011/02/07 15:33:16, rchandia wrote:

Remove empty tags


Done.

http://gwt-code-reviews.appspot.com/1343801/diff/1/12
File
user/test/org/hibernate/jsr303/tck/tests/constraints/constraintcomposition/ConstraintCompositionGwtTest.java
(right):

http://gwt-code-reviews.appspot.com/1343801/diff/1/12#newcode46
user/test/org/hibernate/jsr303/tck/tests/constraints/constraintcomposition/ConstraintCompositionGwtTest.java:46:
fail(This test only fails on IE.  Forcing it to fail here to keep the
counts even. See Issie 5882.);
On 2011/02/07 15:33:16, rchandia wrote:

Issie - Issue


Done. and the rest also.

http://gwt-code-reviews.appspot.com/1343801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Modifies CompiledClass to be serializable (issue1329802)


http://gwt-code-reviews.appspot.com/1329802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Modifies CompiledClass to be serializable (issue1329802)


updated patch


http://gwt-code-reviews.appspot.com/1329802/diff/1/2
File dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java
(right):

http://gwt-code-reviews.appspot.com/1329802/diff/1/2#newcode1
dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java:1:
package com.google.gwt.dev.javac;
On 2011/02/05 00:09:44, scottb wrote:

Need header comment.

Oops, this file snuck in by mistake.

http://gwt-code-reviews.appspot.com/1329802/diff/1/3
File dev/core/src/com/google/gwt/dev/javac/CompiledClass.java (right):

http://gwt-code-reviews.appspot.com/1329802/diff/1/3#newcode64
dev/core/src/com/google/gwt/dev/javac/CompiledClass.java:64: private
final String binaryName;
On 2011/02/05 00:09:44, scottb wrote:

Please don't change this terminology.  Binary name generally means

something

like com.google.Foo$Impl whereas internal name means

com/google/Foo$Impl.

Done.

http://gwt-code-reviews.appspot.com/1329802/diff/1/3#newcode76
dev/core/src/com/google/gwt/dev/javac/CompiledClass.java:76: */
On 2011/02/05 00:09:44, scottb wrote:

nameEnvironmentAnswer is just a cached thing that can be recreated,

but I do

wonder how the unit gets setup.

Yes, I was thinking that initUnit would need to be called to
re-initialize the unit variable.

I was considering CompiledClass in a vacuum.  Removed transient to just
let Java do its thing.

http://gwt-code-reviews.appspot.com/1329802/diff/1/3#newcode102
dev/core/src/com/google/gwt/dev/javac/CompiledClass.java:102:
CompiledClass(ClassFile classFile, CompiledClass enclosingClass) {
I moved this constructor logic all into JdtCompiler.

http://gwt-code-reviews.appspot.com/1329802/diff/1/3#newcode177
dev/core/src/com/google/gwt/dev/javac/CompiledClass.java:177: int length
= inputStream.readInt();
On 2011/02/05 00:09:44, scottb wrote:

Just use token = diskCache.transferFromStream(stream);



(See SyntheticArtifact.readObject).


Done.

http://gwt-code-reviews.appspot.com/1329802/diff/1/3#newcode185
dev/core/src/com/google/gwt/dev/javac/CompiledClass.java:185: byte[]
byteCode = diskCache.readByteArray(cacheToken);
On 2011/02/05 00:09:44, scottb wrote:

Just use diskCache.transferToStream(token, stream);



(See SyntheticArtifact.writeObject).


Done.

http://gwt-code-reviews.appspot.com/1329802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Removes @Override annotation from implemented interface methods. (issue1343802)


Reviewers: jbrosenberg,

Description:
Removes @Override annotation from implemented interface methods.


Please review this at http://gwt-code-reviews.appspot.com/1343802/show

Affected files:
  M dev/core/src/com/google/gwt/core/ext/GeneratorContextExtWrapper.java
  M dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java
  M user/src/com/google/gwt/editor/client/impl/AbstractEditorContext.java
  M user/src/com/google/gwt/editor/client/testing/FakeEditorContext.java
  M user/test/com/google/gwt/requestfactory/client/ui/EditorTest.java


Index: dev/core/src/com/google/gwt/core/ext/GeneratorContextExtWrapper.java
===
--- dev/core/src/com/google/gwt/core/ext/GeneratorContextExtWrapper.java	 
(revision 9677)
+++ dev/core/src/com/google/gwt/core/ext/GeneratorContextExtWrapper.java	 
(working copy)

@@ -88,7 +88,6 @@
 return false;
   }

-  @Override
   public boolean isProdMode() {
 throw new UnsupportedOperationException(
 isProdMode is only available from GeneratorContextExt.);
Index: dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java
===
--- dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java	 
(revision 9677)
+++ dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java	 
(working copy)

@@ -567,7 +567,6 @@
 return generatorResultCachingEnabled;
   }

-  @Override
   public boolean isProdMode() {
 return isProdMode;
   }
Index: user/src/com/google/gwt/editor/client/impl/AbstractEditorContext.java
===
--- user/src/com/google/gwt/editor/client/impl/AbstractEditorContext.java	 
(revision 9677)
+++ user/src/com/google/gwt/editor/client/impl/AbstractEditorContext.java	 
(working copy)

@@ -132,7 +132,6 @@
 visitor.endVisit(this);
   }

-  @Override
   public void traverseSyntheticCompositeEditor(EditorVisitor visitor) {
 if (asCompositeEditor() == null) {
   throw new IllegalStateException();
Index: user/src/com/google/gwt/editor/client/testing/FakeEditorContext.java
===
--- user/src/com/google/gwt/editor/client/testing/FakeEditorContext.java	 
(revision 9677)
+++ user/src/com/google/gwt/editor/client/testing/FakeEditorContext.java	 
(working copy)

@@ -126,7 +126,6 @@
   /**
* No-op.
*/
-  @Override
   public void traverseSyntheticCompositeEditor(EditorVisitor visitor) {
   }
 }
Index: user/test/com/google/gwt/requestfactory/client/ui/EditorTest.java
===
--- user/test/com/google/gwt/requestfactory/client/ui/EditorTest.java	 
(revision 9677)
+++ user/test/com/google/gwt/requestfactory/client/ui/EditorTest.java	 
(working copy)

@@ -56,7 +56,6 @@
 protected final SimpleEditorString userName = SimpleEditor.of();
 RequestContext ctx;

-@Override
 public void setRequestContext(RequestContext ctx) {
   this.ctx = ctx;
 }


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Modifies CompiledClass to be serializable (issue1329802)

2011-02-07 Thread scottb


LGTM


http://gwt-code-reviews.appspot.com/1329802/diff/1004/6
File dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java (right):

http://gwt-code-reviews.appspot.com/1329802/diff/1004/6#newcode267
dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java:267: String
internalName = CharOperation.charToString(binding.constantPoolName());
Funny, but I was playing with this exact code for a different reason,
and ClassFile.fileName()) actually gives the right answer, too.

http://gwt-code-reviews.appspot.com/1329802/diff/1004/7
File dev/core/test/com/google/gwt/dev/javac/CompiledClassTest.java
(right):

http://gwt-code-reviews.appspot.com/1329802/diff/1004/7#newcode33
dev/core/test/com/google/gwt/dev/javac/CompiledClassTest.java:33: File f
=  File.createTempFile(tCCS, .object);
Delete on exit?

Actually, the test is probably cleaner if you just write/read with
BAOS/BAIS and don't hit the disk at all, it's just an unnecessary
failure point.

http://gwt-code-reviews.appspot.com/1329802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Update getGeckoVersion() to support beta versions of Firefox. (issue1343803)

2011-02-07 Thread pdr


Reviewers: jlabanca,

Description:
Update getGeckoVersion() to support beta versions of Firefox.

Previously, gecko versions of the form 2.0b10 would cause the regex to
get mad because it is missing a second period. This change updates the
gecko version detector to support gecko versions such as 1.2.3, 1.2, and
2.0b10.


Please review this at http://gwt-code-reviews.appspot.com/1343803/show

Affected files:
  M user/src/com/google/gwt/dom/client/DOMImplMozilla.java


Index: user/src/com/google/gwt/dom/client/DOMImplMozilla.java
===
--- user/src/com/google/gwt/dom/client/DOMImplMozilla.java  (revision 9677)
+++ user/src/com/google/gwt/dom/client/DOMImplMozilla.java  (working copy)
@@ -19,12 +19,12 @@
  * Mozilla implementation of StandardBrowser.
  */
 class DOMImplMozilla extends DOMImplStandard {
-
+
   private static native int getGeckoVersion() /*-{
-var result =  
/rv:([0-9]+)\.([0-9]+)\.([0-9]+)?/.exec(navigator.userAgent.toLowerCase());
+var result =  
/rv:([0-9]+)\.([0-9]+)(\.([0-9]+))?.*?/.exec(navigator.userAgent.toLowerCase());

 if (result  result.length = 3) {
-  var version = (parseInt(result[1]) * 100) + (parseInt(result[2])  
* 1000) +

-parseInt(result.length == 4 ? result[3] : 0);
+  var version = (parseInt(result[1]) * 100) + (parseInt(result[2])  
* 1000) +

+parseInt(result.length = 5  !isNaN(result[4]) ? result[4] : 0);
   return version;
 }
 return -1; // not gecko
@@ -40,7 +40,7 @@
 int geckoVersion = getGeckoVersion();
 return (geckoVersion != -1)  (geckoVersion = 1009000);
   }
-
+
   /**
* Return true if using Gecko 1.9.1 (Firefox 3.5) or earlier.
*


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Removes @Override annotation from implemented interface methods. (issue1343802)

2011-02-07 Thread jbrosenberg


LGTM

http://gwt-code-reviews.appspot.com/1343802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Modifies CompiledClass to be serializable (issue1329802)

2011-02-07 Thread tobyr



http://gwt-code-reviews.appspot.com/1329802/diff/1004/5
File dev/core/src/com/google/gwt/dev/javac/CompiledClass.java (right):

http://gwt-code-reviews.appspot.com/1329802/diff/1004/5#newcode47
dev/core/src/com/google/gwt/dev/javac/CompiledClass.java:47: private
transient long cacheToken;
I'm just going to echo our face to face discussion which is that disk
caching this stuff seems strange. It's not particularly large and we
know we access it several times. Throwing in intervening disk accesses
can't help. Can we see if just keeping the bytes in memory improves
things?

http://gwt-code-reviews.appspot.com/1329802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Generator Result Caching implementation for ClientBundle (issue1236801)

2011-02-07 Thread jbrosenberg


http://gwt-code-reviews.appspot.com/1236801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Modifies CompiledClass to be serializable (issue1329802)