[gwt-contrib] Re: Support withCredentials attribute for XHR requests (Chrome 3+, Firefox 3.5+, Opera12+, Safari 4+... (issue1879804)

2013-01-24 Thread cromwellian

LGTM


http://gwt-code-reviews.appspot.com/1879804/

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors




[gwt-contrib] Re: Support withCredentials attribute for XHR requests (Chrome 3+, Firefox 3.5+, Opera12+, Safari 4+... (issue1879804)

2013-01-16 Thread t . broyer


http://gwt-code-reviews.appspot.com/1879804/diff/1/user/src/com/google/gwt/xhr/client/XMLHttpRequest.java
File user/src/com/google/gwt/xhr/client/XMLHttpRequest.java (right):

http://gwt-code-reviews.appspot.com/1879804/diff/1/user/src/com/google/gwt/xhr/client/XMLHttpRequest.java#newcode377
user/src/com/google/gwt/xhr/client/XMLHttpRequest.java:377: if
(withCredentials in this.xmlHttpRequest) {
Is this check really needed? That XHR class is low-level, you're
supposed to know what you're doing when using it. Calling
setWithCredentials() on a non-cross-origin request is probably a
mistake, and I wouldn't really care that it throws in browsers not
supporting CORS (e.g. IE up to and including IE9), and if the browser
doesn't support CORS and you try to do a cross-origin request, then
open() would throw anyway, so it doesn't seem worth it to avoid an
exception in setWithCredentials.

http://gwt-code-reviews.appspot.com/1879804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Support withCredentials attribute for XHR requests (Chrome 3+, Firefox 3.5+, Opera12+, Safari 4+... (issue1879804)

2013-01-16 Thread t . broyer

FYI, an issue related to this change:
https://code.google.com/p/google-web-toolkit/issues/detail?id=7677

http://gwt-code-reviews.appspot.com/1879804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


Re: gwt 2.0 plugin crashes firefox 3.5 in OS X 10.4

2010-01-03 Thread Par
Yes, this is the same issue.
It is already entered.

Thanks.
Pardeep

On Dec 28 2009, 8:28 am, Chris Ramsdale cramsd...@google.com wrote:
 Checkout:

 http://code.google.com/p/google-web-toolkit/issues/detail?id=4413

 If this is the same issue that you are experiencing, start the issue (or the
 original issue).

 Thanks,
 Chris

 On Thu, Dec 17, 2009 at 2:59 AM, Par pardeeps...@gmail.com wrote:
  Hi,

  I have just upgraded to gwt 2.0 and added an eclipse plugin for os x
  10.4.11. Running in development mode, i was asked to download gwt-dev
  plugin. After downloading it, the firefox doesn't start and crashes.

  I then started firefox in safe mode and disabled all plugins and
  removed the gwt plugin. The firefox starts normally then.

  To run gwt application, i reverted back to gwt 1.7 (by disabling the
  eclipse gwt 2.0 plugin)  but when i run the application in hosted mode
  in 1.7, I get the following error and gwt hosted mode crashes.

  Let me know if i am missing something.

  dyld: lazy symbol binding failed: Symbol not found: _strerror$UNIX2003
   Referenced from: /Library/Internet
  Plug-Ins/gwt-dev.webplugin/Contents/MacOS/gwt-dev
   Expected in: /usr/lib/libSystem.B.dylib

  dyld: Symbol not found: _strerror$UNIX2003
   Referenced from: /Library/Internet
  Plug-Ins/gwt-dev.webplugin/Contents/MacOS/gwt-dev
   Expected in: /usr/lib/libSystem.B.dylib

   Thanks.
  Pardeep

  --

  You received this message because you are subscribed to the Google Groups
  Google Web Toolkit group.
  To post to this group, send email to google-web-tool...@googlegroups.com.
  To unsubscribe from this group, send email to
  google-web-toolkit+unsubscr...@googlegroups.comgoogle-web-toolkit%2bunsubscr...@googlegroups.com
  .
  For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.

--

You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.




Re: gwt 2.0 plugin crashes firefox 3.5 in OS X 10.4

2009-12-27 Thread Chris Ramsdale
Checkout:

http://code.google.com/p/google-web-toolkit/issues/detail?id=4413

If this is the same issue that you are experiencing, start the issue (or the
original issue).

Thanks,
Chris

On Thu, Dec 17, 2009 at 2:59 AM, Par pardeeps...@gmail.com wrote:

 Hi,

 I have just upgraded to gwt 2.0 and added an eclipse plugin for os x
 10.4.11. Running in development mode, i was asked to download gwt-dev
 plugin. After downloading it, the firefox doesn't start and crashes.

 I then started firefox in safe mode and disabled all plugins and
 removed the gwt plugin. The firefox starts normally then.

 To run gwt application, i reverted back to gwt 1.7 (by disabling the
 eclipse gwt 2.0 plugin)  but when i run the application in hosted mode
 in 1.7, I get the following error and gwt hosted mode crashes.

 Let me know if i am missing something.

 dyld: lazy symbol binding failed: Symbol not found: _strerror$UNIX2003
  Referenced from: /Library/Internet
 Plug-Ins/gwt-dev.webplugin/Contents/MacOS/gwt-dev
  Expected in: /usr/lib/libSystem.B.dylib

 dyld: Symbol not found: _strerror$UNIX2003
  Referenced from: /Library/Internet
 Plug-Ins/gwt-dev.webplugin/Contents/MacOS/gwt-dev
  Expected in: /usr/lib/libSystem.B.dylib

  Thanks.
 Pardeep

 --

 You received this message because you are subscribed to the Google Groups
 Google Web Toolkit group.
 To post to this group, send email to google-web-tool...@googlegroups.com.
 To unsubscribe from this group, send email to
 google-web-toolkit+unsubscr...@googlegroups.comgoogle-web-toolkit%2bunsubscr...@googlegroups.com
 .
 For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.




--

You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.




gwt 2.0 plugin crashes firefox 3.5 in OS X 10.4

2009-12-18 Thread Pardeep Sood
Hi,

I have just upgraded to gwt 2.0 and added an eclipse plugin for os x
10.4.11. Running in development mode, i was asked to download gwt-dev
plugin. After downloading it, the firefox doesn't start and crashes.

I then started firefox in safe mode and disabled all plugins and
removed the gwt plugin. The firefox starts normally then.

To run gwt application, i reverted back to gwt 1.7 (by disabling the
eclipse gwt 2.0 plugin)  but when i run the application in hosted mode
in 1.7, I get the following error and gwt hosted mode crashes.

Let me know if i am missing something.

dyld: lazy symbol binding failed: Symbol not found: _strerror$UNIX2003
 Referenced from: /Library/Internet
Plug-Ins/gwt-dev.webplugin/Contents/MacOS/gwt-dev
 Expected in: /usr/lib/libSystem.B.dylib

dyld: Symbol not found: _strerror$UNIX2003
 Referenced from: /Library/Internet
Plug-Ins/gwt-dev.webplugin/Contents/MacOS/gwt-dev
 Expected in: /usr/lib/libSystem.B.dylib

 Thanks.
Pardeep

--

You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.




gwt 2.0 plugin crashes firefox 3.5 in OS X 10.4

2009-12-18 Thread Par
Hi,

I have just upgraded to gwt 2.0 and added an eclipse plugin for os x
10.4.11. Running in development mode, i was asked to download gwt-dev
plugin. After downloading it, the firefox doesn't start and crashes.

I then started firefox in safe mode and disabled all plugins and
removed the gwt plugin. The firefox starts normally then.

To run gwt application, i reverted back to gwt 1.7 (by disabling the
eclipse gwt 2.0 plugin)  but when i run the application in hosted mode
in 1.7, I get the following error and gwt hosted mode crashes.

Let me know if i am missing something.

dyld: lazy symbol binding failed: Symbol not found: _strerror$UNIX2003
 Referenced from: /Library/Internet
Plug-Ins/gwt-dev.webplugin/Contents/MacOS/gwt-dev
 Expected in: /usr/lib/libSystem.B.dylib

dyld: Symbol not found: _strerror$UNIX2003
 Referenced from: /Library/Internet
Plug-Ins/gwt-dev.webplugin/Contents/MacOS/gwt-dev
 Expected in: /usr/lib/libSystem.B.dylib

 Thanks.
Pardeep

--

You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.




gwt 2.0 plugin crashes firefox 3.5 in OS X 10.4

2009-12-18 Thread Par
Hi,

I have just upgraded to gwt 2.0 and added an eclipse plugin for os x
10.4.11. Running in development mode, i was asked to download gwt-dev
plugin. After downloading it, the firefox doesn't start and crashes.

I then started firefox in safe mode and disabled all plugins and
removed the gwt plugin. The firefox starts normally then.

To run gwt application, i reverted back to gwt 1.7 (by disabling the
eclipse gwt 2.0 plugin)  but when i run the application in hosted mode
in 1.7, I get the following error and gwt hosted mode crashes.

Let me know if i am missing something.

dyld: lazy symbol binding failed: Symbol not found: _strerror$UNIX2003
 Referenced from: /Library/Internet
Plug-Ins/gwt-dev.webplugin/Contents/MacOS/gwt-dev
 Expected in: /usr/lib/libSystem.B.dylib

dyld: Symbol not found: _strerror$UNIX2003
 Referenced from: /Library/Internet
Plug-Ins/gwt-dev.webplugin/Contents/MacOS/gwt-dev
 Expected in: /usr/lib/libSystem.B.dylib

 Thanks.
Pardeep

--

You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.




Re: GWT 2 mailstone 2+selenium+testng+firefox 3.5,keep asking to install plugin

2009-11-12 Thread Cliff Zhao
Selenium has its customized profile for firefox and IE, I think that you
need to let Selenium start your firefox profile that have the plugin
installed.

On Thu, Nov 12, 2009 at 2:57 AM, Alex Luya alexander.l...@gmail.com wrote:

 (All uitilities are latest version )
 I use following code to test my login page:
 -
 import com.thoughtworks.selenium.DefaultSelenium;
 import com.thoughtworks.selenium.Selenium;

 public class Login
 {
@Test
public void Login() throws Exception
{
Selenium selenium = new DefaultSelenium(localhost, ,
 *firefox,http://localhost:/;);
selenium.start();
selenium.open(/CRM.html?gwt.hosted=127.0.0.1:9997);
selenium.type(gwt-debug-userName, admin);
selenium.type(gwt-debug-password, admin);
selenium.click(gwt-debug-login);
selenium.stop();
}
 }
 --
 after firefox opened,it keeps asking me to install gwt plugin(but the
 plugin has been installed and functioned properly),and I try to
 refresh page,no changes,then I copy the url,close firefox and reopen
 it,pasted url just copied,it works.that is strange.why is it when I
 use Selenium to open firefox,it asked me to install already installed
 plugin.

 --

 You received this message because you are subscribed to the Google Groups
 Google Web Toolkit group.
 To post to this group, send email to google-web-tool...@googlegroups.com.
 To unsubscribe from this group, send email to
 google-web-toolkit+unsubscr...@googlegroups.comgoogle-web-toolkit%2bunsubscr...@googlegroups.com
 .
 For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=.




--

You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=.




Re: GWT 2 mailstone 2+selenium+testng+firefox 3.5,keep asking to install plugin

2009-11-12 Thread Alex Luya
Yeah,thank you Cliff,I figured it out
---
cmdjava -jar selenium-server.jar -firefoxProfileTemplate C:
\Documents and Settings\your account name\Application Data\Mozilla
\Firefox\Profiles\xxx.default

Above command line will force selenium-server to start with specified
profile.

On 12 nov, 15:43, Cliff Zhao zha...@gmail.com wrote:
 Selenium has its customized profile for firefox and IE, I think that you
 need to let Selenium start your firefox profile that have the plugin
 installed.



 On Thu, Nov 12, 2009 at 2:57 AM, Alex Luya alexander.l...@gmail.com wrote:
  (All uitilities are latest version )
  I use following code to test my login page:
  -
  import com.thoughtworks.selenium.DefaultSelenium;
  import com.thoughtworks.selenium.Selenium;

  public class Login
  {
        �...@test
         public void Login() throws Exception
         {
                 Selenium selenium = new DefaultSelenium(localhost, ,
  *firefox,http://localhost:/;);
                 selenium.start();
                 selenium.open(/CRM.html?gwt.hosted=127.0.0.1:9997);
                 selenium.type(gwt-debug-userName, admin);
                 selenium.type(gwt-debug-password, admin);
                 selenium.click(gwt-debug-login);
                 selenium.stop();
         }
  }
  --
  after firefox opened,it keeps asking me to install gwt plugin(but the
  plugin has been installed and functioned properly),and I try to
  refresh page,no changes,then I copy the url,close firefox and reopen
  it,pasted url just copied,it works.that is strange.why is it when I
  use Selenium to open firefox,it asked me to install already installed
  plugin.

  --

  You received this message because you are subscribed to the Google Groups
  Google Web Toolkit group.
  To post to this group, send email to google-web-tool...@googlegroups.com.
  To unsubscribe from this group, send email to
  google-web-toolkit+unsubscr...@googlegroups.comgoogle-web-toolkit%2Bunsubs 
  cr...@googlegroups.com
  .
  For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=.

--

You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=.




GWT 2 mailstone 2+selenium+testng+firefox 3.5,keep asking to install plugin

2009-11-11 Thread Alex Luya
(All uitilities are latest version )
I use following code to test my login page:
-
import com.thoughtworks.selenium.DefaultSelenium;
import com.thoughtworks.selenium.Selenium;

public class Login
{
@Test
public void Login() throws Exception
{
Selenium selenium = new DefaultSelenium(localhost, ,
*firefox,http://localhost:/;);
selenium.start();
selenium.open(/CRM.html?gwt.hosted=127.0.0.1:9997);
selenium.type(gwt-debug-userName, admin);
selenium.type(gwt-debug-password, admin);
selenium.click(gwt-debug-login);
selenium.stop();
}
}
--
after firefox opened,it keeps asking me to install gwt plugin(but the
plugin has been installed and functioned properly),and I try to
refresh page,no changes,then I copy the url,close firefox and reopen
it,pasted url just copied,it works.that is strange.why is it when I
use Selenium to open firefox,it asked me to install already installed
plugin.

--

You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=.




[gwt-contrib] Firefox 3.5 allows cross site XHRs

2009-09-29 Thread jlabanca

Reviewers: Ray Ryan,

Description:
Description:
===
Firefox 3.5 allows cross site XHR requests without any way to disable
the option.  Only the server can deny the request.

Fix:

Fixed RequestBuilderTest to check for FF3.5. We currently do the same
for Safari 2, which fails silently.

Please review this at http://gwt-code-reviews.appspot.com/73802

Affected files:
   user/test/com/google/gwt/http/client/RequestBuilderTest.java


Index: user/test/com/google/gwt/http/client/RequestBuilderTest.java
===
--- user/test/com/google/gwt/http/client/RequestBuilderTest.java
(revision  
6245)
+++ user/test/com/google/gwt/http/client/RequestBuilderTest.java
(working  
copy)
@@ -45,6 +45,25 @@
  return ua.indexOf(webkit) != -1;
}-*/;

+  /**
+   * HACK: Part of a work around for FF 3.5's failure to throw an  
exception when
+   * an XmlHttpRequest that violates the same origin policy is made.
+   */
+  private static native boolean isFirefox35() /*-{
+var ua = navigator.userAgent.toLowerCase();
+if (ua.indexOf(gecko) == -1) {
+  return false;
+}
+var result = /firefox\/([0-9]+\.[0-9]+)/.exec(ua.toLowerCase());
+if (result  result.length == 2) {
+  var version = parseFloat(result[1]);
+  if (version = 3.5) {
+return true;
+  }
+}
+return false;
+  }-*/;
+
@Override
public String getModuleName() {
  return com.google.gwt.http.RequestBuilderTest;
@@ -109,13 +128,17 @@
  }
});

-  if (isSafari()) {
+  if (isSafari() || isFirefox35()) {
  /*
   * HACK: Safari 2.0.4 will not throw an exception for XHR's that  
violate
   * the same-origin policy. It appears to silently ignore them so  
we do
   * not fail this test if we are on Safari and the
   * RequestPermissionException is not thrown. Even though Safari  
3.0.4
   * does throw an exception in this case, we exclude it anyway.
+ *
+ * FF3.5 allows XHR's to violate the same-origin policy and offers  
no
+ * way to disable the feature from the client. Only the server can  
block
+ * the same origin policy.
   */
} else {
  /*



--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---



[gwt-contrib] Re: Firefox 3.5 allows cross site XHRs

2009-09-29 Thread rjrjr

LGTM


http://gwt-code-reviews.appspot.com/73802/diff/1/2
File user/test/com/google/gwt/http/client/RequestBuilderTest.java
(right):

http://gwt-code-reviews.appspot.com/73802/diff/1/2#newcode64
Line 64: return false;
Should we log a bug on FireFox requesting an exception be thrown?

http://gwt-code-reviews.appspot.com/73802

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---



[gwt-contrib] Re: Firefox 3.5 allows cross site XHRs

2009-09-29 Thread rjrjr

LGTM


http://gwt-code-reviews.appspot.com/73802/diff/1/2
File user/test/com/google/gwt/http/client/RequestBuilderTest.java
(right):

http://gwt-code-reviews.appspot.com/73802/diff/1/2#newcode64
Line 64: return false;
Should we log a bug on FireFox requesting an exception be thrown?

http://gwt-code-reviews.appspot.com/73802

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---



[gwt-contrib] Re: Firefox 3.5 allows cross site XHRs

2009-09-29 Thread jlabanca

You can read through this doc for details:
https://developer.mozilla.org/En/HTTP_access_control

Essentially, if an XHR response includes the following header, the cross
site request is allowed:
Access-Control-Allow-Origin: *

If the XHR response includes the following header instead, the request
is denied:
Access-Control-Allow-Origin: http://mysite.com


http://gwt-code-reviews.appspot.com/73802/diff/1/2
File user/test/com/google/gwt/http/client/RequestBuilderTest.java
(right):

http://gwt-code-reviews.appspot.com/73802/diff/1/2#newcode64
Line 64: return false;
Its a feature, not a bug.  FireFox has adopted a new proposed standard
where its up to the server to determine which origins can access the
content.

At some point, we should setup a publicly visible server that always
denies cross site requests.  It would be helpful to us and others.

http://gwt-code-reviews.appspot.com/73802

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---



Re: FireFox 3.5

2009-07-09 Thread Algian

Does anyone know how I can modify the GWT package to include these two
classes?

Unless the release dates for GWT 1.6.5 are close. Does anyone know
what the planned date is?
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to Google-Web-Toolkit@googlegroups.com
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/Google-Web-Toolkit?hl=en
-~--~~~~--~~--~--~---



Re: problem with rounded corners using DecoratorPanel + Firefox 3.5

2009-07-06 Thread alex.d

I've seen similar effects when tried to set decorator panel's size
manually. Try to play with the size of panel's inner widgets.

On 5 Jul., 16:50, mike mikebannis...@gmail.com wrote:
 Rounded corners on GWT's DecoratorPanels don't look right for me in
 FF3.5. See the gap below this upper right-hand corner:

 http://img.skitch.com/20090705-c95g8b1cn33t22wnypk4h5mjwt.jpg

 Anyone else having this problem? The showcase app uses rounded corners
 without issue. What am I doing wrong?

 I'm on GWT 1.6.4.

 -Mike
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to Google-Web-Toolkit@googlegroups.com
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/Google-Web-Toolkit?hl=en
-~--~~~~--~~--~--~---



Re: problem with rounded corners using DecoratorPanel + Firefox 3.5

2009-07-06 Thread mike

Hi Alex,

Thanks for your response.

I'm not setting the size of the decorator panel (though I did try). My
test onModuleLoad looks like this (using no css):

DecoratorPanel testDec = new DecoratorPanel();
SimplePanel testSimple = new SimplePanel();
testSimple.setHeight(100px);
testSimple.setWidth(100px);
testDec.add(testSimple);
RootPanel.get().add(testDec);

I've tried a bunch of different variations on this using both Standard
and Chrome themes.

While the showcase app's corners are OK the popup that get when you
generate a new project has the problem.

-Mike

On Jul 6, 3:55 am, alex.d alex.dukhov...@googlemail.com wrote:
 I've seen similar effects when tried to set decorator panel's size
 manually. Try to play with the size of panel's inner widgets.

 On 5 Jul., 16:50, mike mikebannis...@gmail.com wrote:

  Rounded corners on GWT's DecoratorPanels don't look right for me in
  FF3.5. See the gap below this upper right-hand corner:

 http://img.skitch.com/20090705-c95g8b1cn33t22wnypk4h5mjwt.jpg

  Anyone else having this problem? The showcase app uses rounded corners
  without issue. What am I doing wrong?

  I'm on GWT 1.6.4.

  -Mike


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to Google-Web-Toolkit@googlegroups.com
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/Google-Web-Toolkit?hl=en
-~--~~~~--~~--~--~---



Re: problem with rounded corners using DecoratorPanel + Firefox 3.5

2009-07-06 Thread mike

Ah, just figured it out... very frustrated with myself for not
thinking of this sooner (I won't say how many hours I burnt up).

I did a fresh install of 3.5 on another user account and it did not
have the same problem. It ends up that somehow my zoom in FF got set
to -1 causing weirdness on decorated corners.

Thanks again Alex.

-Mike

On Jul 6, 11:29 am, mike mikebannis...@gmail.com wrote:
 Hi Alex,

 Thanks for your response.

 I'm not setting the size of the decorator panel (though I did try). My
 test onModuleLoad looks like this (using no css):

 DecoratorPanel testDec = new DecoratorPanel();
 SimplePanel testSimple = new SimplePanel();
 testSimple.setHeight(100px);
 testSimple.setWidth(100px);
 testDec.add(testSimple);
 RootPanel.get().add(testDec);

 I've tried a bunch of different variations on this using both Standard
 and Chrome themes.

 While the showcase app's corners are OK the popup that get when you
 generate a new project has the problem.

 -Mike

 On Jul 6, 3:55 am, alex.d alex.dukhov...@googlemail.com wrote:

  I've seen similar effects when tried to set decorator panel's size
  manually. Try to play with the size of panel's inner widgets.

  On 5 Jul., 16:50, mike mikebannis...@gmail.com wrote:

   Rounded corners on GWT's DecoratorPanels don't look right for me in
   FF3.5. See the gap below this upper right-hand corner:

  http://img.skitch.com/20090705-c95g8b1cn33t22wnypk4h5mjwt.jpg

   Anyone else having this problem? The showcase app uses rounded corners
   without issue. What am I doing wrong?

   I'm on GWT 1.6.4.

   -Mike


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to Google-Web-Toolkit@googlegroups.com
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/Google-Web-Toolkit?hl=en
-~--~~~~--~~--~--~---



problem with rounded corners using DecoratorPanel + Firefox 3.5

2009-07-06 Thread mike

I'm assuming you accidentally changed the title. You should probably
start a new thread (sorry I'm new myself and don't have an answer).

On Jul 6, 12:09 pm, Piotr Kirklewski
pkirklew...@gabaedevelopment.com wrote:
 Hi there

 How can I change the marker color please ?
 Do I have to create new icon ?
 Or is there a simpler way to do that ?

 Regards

 PEter
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to Google-Web-Toolkit@googlegroups.com
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/Google-Web-Toolkit?hl=en
-~--~~~~--~~--~--~---



Re: problem with rounded corners using DecoratorPanel + Firefox 3.5

2009-07-06 Thread mike

By the way, I went back to see if FF3.0 displays this way and it does
not. So maybe it's a bug in FF3.5 or something that GWT should program
around?

On Jul 6, 12:22 pm, mike mikebannis...@gmail.com wrote:
 I'm assuming you accidentally changed the title. You should probably
 start a new thread (sorry I'm new myself and don't have an answer).

 On Jul 6, 12:09 pm, Piotr Kirklewski

 pkirklew...@gabaedevelopment.com wrote:
  Hi there

  How can I change the marker color please ?
  Do I have to create new icon ?
  Or is there a simpler way to do that ?

  Regards

  PEter


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to Google-Web-Toolkit@googlegroups.com
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/Google-Web-Toolkit?hl=en
-~--~~~~--~~--~--~---



problem with rounded corners using DecoratorPanel + Firefox 3.5

2009-07-06 Thread mike

Peter, if you have a question that's not about rounded corners on
DecoratorPanels then go here:

http://groups.google.com/group/Google-Web-Toolkit

Then click where it says New post.

Please stop changing the subject of this thread. Thank you.

-Mike

On Jul 6, 12:30 pm, Piotr Kirklewski
pkirklew...@gabaedevelopment.com wrote:
 I should also say that I'm playing around with GWT maps.
 The default marker color is red I need to change it to blue but cant
 find a method on the list which allows that.
 Regards
 Peter

 Piotr Kirklewski wrote:
  Hi there

  How can I change the marker color please ?
  Do I have to create new icon ?
  Or is there a simpler way to do that ?

  Regards

  PEter


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to Google-Web-Toolkit@googlegroups.com
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/Google-Web-Toolkit?hl=en
-~--~~~~--~~--~--~---



problem with rounded corners using DecoratorPanel + Firefox 3.5

2009-07-05 Thread mike

Rounded corners on GWT's DecoratorPanels don't look right for me in
FF3.5. See the gap below this upper right-hand corner:

http://img.skitch.com/20090705-c95g8b1cn33t22wnypk4h5mjwt.jpg

Anyone else having this problem? The showcase app uses rounded corners
without issue. What am I doing wrong?

I'm on GWT 1.6.4.

-Mike
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to Google-Web-Toolkit@googlegroups.com
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/Google-Web-Toolkit?hl=en
-~--~~~~--~~--~--~---



Re: FireFox 3.5

2009-07-02 Thread jridley

Great.  Do you know of a time frame in which either FF 3.5.1 or GWT
1.6.5 will be released?

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to Google-Web-Toolkit@googlegroups.com
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/Google-Web-Toolkit?hl=en
-~--~~~~--~~--~--~---



FireFox 3.5

2009-06-30 Thread Scooter

I tested our gwt app today on FireFox 3.5 on OSX now that it has been
released. Lots of very nasty javascript errors related to DOM with a
copy and paste as an example. Using GWT 1.6.4. The application loads
and I don't get error messages until I execute a particular part of
the application. I am using GXT for GUI so it could be a GXT related
issue.

Is FireFox 3.5 formally supported?

[FATAL] Uncaught Exception:
com.google.gwt.core.client.JavaScriptException:
(NS_ERROR_DOM_NOT_SUPPORTED_ERR): Operation is not supported
code: 9
INDEX_SIZE_ERR: 1
DOMSTRING_SIZE_ERR: 2
HIERARCHY_REQUEST_ERR: 3
WRONG_DOCUMENT_ERR: 4
INVALID_CHARACTER_ERR: 5
NO_DATA_ALLOWED_ERR: 6
NO_MODIFICATION_ALLOWED_ERR: 7
NOT_FOUND_ERR: 8
NOT_SUPPORTED_ERR: 9
INUSE_ATTRIBUTE_ERR: 10
INVALID_STATE_ERR: 11
SYNTAX_ERR: 12
INVALID_MODIFICATION_ERR: 13
NAMESPACE_ERR: 14
INVALID_ACCESS_ERR: 15
VALIDATION_ERR: 16
TYPE_MISMATCH_ERR: 17
result: 2152923145
filename: 
http://localhost:8084/edu.scripps.hddesktop.Main/91F6113CB504FAA289B3017C98A2CE93.cache.html
lineNumber: 2403
columnNumber: 0
inner: null
data: null
[FATAL] Uncaught Exception:
com.google.gwt.core.client.JavaScriptException:
(NS_ERROR_DOM_NOT_SUPPORTED_ERR): Operation is not supported
code: 9
INDEX_SIZE_ERR: 1
DOMSTRING_SIZE_ERR: 2
HIERARCHY_REQUEST_ERR: 3
WRONG_DOCUMENT_ERR: 4
INVALID_CHARACTER_ERR: 5
NO_DATA_ALLOWED_ERR: 6
NO_MODIFICATION_ALLOWED_ERR: 7
NOT_FOUND_ERR: 8
NOT_SUPPORTED_ERR: 9
INUSE_ATTRIBUTE_ERR: 10
INVALID_STATE_ERR: 11
SYNTAX_ERR: 12
INVALID_MODIFICATION_ERR: 13
NAMESPACE_ERR: 14
INVALID_ACCESS_ERR: 15
VALIDATION_ERR: 16
TYPE_MISMATCH_ERR: 17
result: 2152923145
filename: 
http://localhost:8084/edu.scripps.hddesktop.Main/91F6113CB504FAA289B3017C98A2CE93.cache.html
lineNumber: 2403
columnNumber: 0
inner: null
data: null
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to Google-Web-Toolkit@googlegroups.com
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/Google-Web-Toolkit?hl=en
-~--~~~~--~~--~--~---



Re: FireFox 3.5

2009-06-30 Thread walrus

I am using GXT for GUI so it could be a GXT related issue.

It's not GXT related. We are not using GXT, but are facing the very
same issue.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to Google-Web-Toolkit@googlegroups.com
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/Google-Web-Toolkit?hl=en
-~--~~~~--~~--~--~---



Re: FireFox 3.5

2009-06-30 Thread Scooter

I was able to figure out how to trigger the error in my application.
It appears related to a mouse being moved in and out of a text boxes.
It could be tooltips related. If I move the mouse quickly across a
couple text fields in a form then I get the error. If I move in and
out of a single text field then no error. If I move the mouse slowly
across multiple text fields no error.


On Jun 30, 3:26 pm, walrus ask...@gmail.com wrote:
 I am using GXT for GUI so it could be a GXT related issue.

 It's not GXT related. We are not using GXT, but are facing the very
 same issue.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to Google-Web-Toolkit@googlegroups.com
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/Google-Web-Toolkit?hl=en
-~--~~~~--~~--~--~---



Re: FireFox 3.5

2009-06-30 Thread Thomas Broyer



On 30 juin, 21:26, walrus ask...@gmail.com wrote:
 I am using GXT for GUI so it could be a GXT related issue.

 It's not GXT related. We are not using GXT, but are facing the very
 same issue.

For those not following commits and/or the GWT-Contributors group,
this is a bug in FF3.5 (will be fixed in 3.5.1) and a workaround has
been committed earlier today and will be part of the upcoming GWT
1.6.5 (http://code.google.com/p/google-web-toolkit/source/detail?
r=5641 )
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to Google-Web-Toolkit@googlegroups.com
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/Google-Web-Toolkit?hl=en
-~--~~~~--~~--~--~---



[gwt-contrib] Fix for Firefox 3.5 relatedTarget bug (https://bugzilla.mozilla.org/show_bug.cgi?id=497780)

2009-06-30 Thread jgw

Reviewers: jlabanca,



Please review this at http://gwt-code-reviews.appspot.com/49803

Affected files:
   M user/src/com/google/gwt/dom/client/DOMImplMozilla.java
   M user/src/com/google/gwt/user/client/impl/DOMImplStandard.java


Index: user/src/com/google/gwt/dom/client/DOMImplMozilla.java
===
--- user/src/com/google/gwt/dom/client/DOMImplMozilla.java  (revision 5638)
+++ user/src/com/google/gwt/dom/client/DOMImplMozilla.java  (working copy)
@@ -37,6 +37,20 @@
}-*/;

@Override
+  public native EventTarget eventGetRelatedTarget(NativeEvent evt) /*-{
+// Hack around Mozilla bug 497780 (relatedTarget sometimes returns XUL
+// elements). Trying to access relatedTarget.nodeName will throw an
+// exception if it's a XUL element.
+var relatedTarget = evt.relatedTarget;
+try {
+  var nodeName = relatedTarget.nodeName;
+  return relatedTarget;
+} catch (e) {
+  return null;
+}
+  }-*/;
+
+  @Override
public int getAbsoluteLeft(Element elem) {
  return  
getAbsoluteLeftImpl(elem.getOwnerDocument().getViewportElement(),
  elem);
Index: user/src/com/google/gwt/user/client/impl/DOMImplStandard.java
===
--- user/src/com/google/gwt/user/client/impl/DOMImplStandard.java   
(revision  
5638)
+++ user/src/com/google/gwt/user/client/impl/DOMImplStandard.java   
(working  
copy)
@@ -39,22 +39,30 @@
private static JavaScriptObject dispatchEvent;

@Override
-  public native Element eventGetFromElement(Event evt) /*-{
-if (evt.type == mouseover)
-  return evt.relatedTarget;
-if (evt.type == mouseout)
-  return evt.target;
+  public Element eventGetFromElement(Event evt) {
+if (evt.getType().equals(mouseover)) {
+  return evt.getRelatedTarget().cast();
+}
+
+if (evt.getType().equals(mouseout)) {
+  return evt.getTarget().cast();
+}
+
  return null;
-  }-*/;
+  }

@Override
-  public native Element eventGetToElement(Event evt) /*-{
-if (evt.type == mouseover)
-  return evt.target;
-if (evt.type == mouseout)
-  return evt.relatedTarget;
+  public Element eventGetToElement(Event evt) {
+if (evt.getType().equals(mouseover)) {
+  return evt.getTarget().cast();
+}
+
+if (evt.getType().equals(mouseout)) {
+  return evt.getRelatedTarget().cast();
+}
+
  return null;
-  }-*/;
+  }

@Override
public native Element getChild(Element elem, int index) /*-{



--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---



[gwt-contrib] Re: Fix for Firefox 3.5 relatedTarget bug (https://bugzilla.mozilla.org/show_bug.cgi?id=497780)

2009-06-30 Thread jgw

Note that the referenced Firefox bug is marked as fixed/resolved, but it
didn't make it into the Firefox 3.5 release branch (they're expecting to
ship a fix in 3.5.1, which essentially means we're all going to be stuck
with this behavior for at least a year or so).

I've tested this patch on a large internal application that was throwing
exceptions because of the aforementioned bug, and it very clearly fixed
the issue.


http://gwt-code-reviews.appspot.com/49803/diff/1/3
File user/src/com/google/gwt/user/client/impl/DOMImplStandard.java
(right):

http://gwt-code-reviews.appspot.com/49803/diff/1/3#newcode65
Line 65: }
Changing these methods to simply use the Java Event.getRelatedTarget()
methods ensures that relatedTarget will always be accessed through the
guarded method.

Also, don't worry about the .cast() calls -- these (old) methods have
always assumed that an Element would get returned (as opposed to an
EventTarget). So they're no more wrong than they ever were :)

http://gwt-code-reviews.appspot.com/49803

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---



[gwt-contrib] Re: Fix for Firefox 3.5 relatedTarget bug (https://bugzilla.mozilla.org/show_bug.cgi?id=497780)

2009-06-30 Thread jlabanca

LGTM

http://gwt-code-reviews.appspot.com/49803

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---



[gwt-contrib] Re: Fix for Firefox 3.5 relatedTarget bug (https://bugzilla.mozilla.org/show_bug.cgi?id=497780)

2009-06-30 Thread jgw

On 2009/06/30 13:45:55, jlabanca wrote:
 LGTM

Thanks, commited at r5641.

http://gwt-code-reviews.appspot.com/49803

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---



[gwt-contrib] [google-web-toolkit commit] r5643 - Merging r5641 from trunk (Fix for Firefox 3.5 Event.relatedTarget bug).

2009-06-30 Thread codesite-noreply

Author: j...@google.com
Date: Tue Jun 30 08:39:59 2009
New Revision: 5643

Modified:
releases/1.6/user/src/com/google/gwt/dom/client/DOMImplMozilla.java
 
releases/1.6/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java

Log:
Merging r5641 from trunk (Fix for Firefox 3.5 Event.relatedTarget bug).


Modified:  
releases/1.6/user/src/com/google/gwt/dom/client/DOMImplMozilla.java
==
--- releases/1.6/user/src/com/google/gwt/dom/client/DOMImplMozilla.java  
(original)
+++ releases/1.6/user/src/com/google/gwt/dom/client/DOMImplMozilla.java Tue  
Jun 30 08:39:59 2009
@@ -38,6 +38,20 @@
}-*/;

@Override
+  public native EventTarget eventGetRelatedTarget(NativeEvent evt) /*-{
+// Hack around Mozilla bug 497780 (relatedTarget sometimes returns XUL
+// elements). Trying to access relatedTarget.nodeName will throw an
+// exception if it's a XUL element.
+var relatedTarget = evt.relatedTarget;
+try {
+  var nodeName = relatedTarget.nodeName;
+  return relatedTarget;
+} catch (e) {
+  return null;
+}
+  }-*/;
+
+  @Override
public int getAbsoluteLeft(Element elem) {
  return  
getAbsoluteLeftImpl(elem.getOwnerDocument().getViewportElement(),
  elem);

Modified:  
releases/1.6/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java
==
---  
releases/1.6/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java  
 
(original)
+++  
releases/1.6/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java  
 
Tue Jun 30 08:39:59 2009
@@ -39,22 +39,30 @@
private static JavaScriptObject dispatchEvent;

@Override
-  public native Element eventGetFromElement(Event evt) /*-{
-if (evt.type == mouseover)
-  return evt.relatedTarget;
-if (evt.type == mouseout)
-  return evt.target;
+  public Element eventGetFromElement(Event evt) {
+if (evt.getType().equals(mouseover)) {
+  return evt.getRelatedTarget().cast();
+}
+
+if (evt.getType().equals(mouseout)) {
+  return evt.getTarget().cast();
+}
+
  return null;
-  }-*/;
+  }

@Override
-  public native Element eventGetToElement(Event evt) /*-{
-if (evt.type == mouseover)
-  return evt.target;
-if (evt.type == mouseout)
-  return evt.relatedTarget;
+  public Element eventGetToElement(Event evt) {
+if (evt.getType().equals(mouseover)) {
+  return evt.getTarget().cast();
+}
+
+if (evt.getType().equals(mouseout)) {
+  return evt.getRelatedTarget().cast();
+}
+
  return null;
-  }-*/;
+  }

@Override
public native Element getChild(Element elem, int index) /*-{

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---



[gwt-contrib] [google-web-toolkit commit] r5641 - Fix for Firefox 3.5 relatedTarget bug (https://bugzilla.mozilla.org/show_bug.cgi?id=497780)

2009-06-30 Thread codesite-noreply

Author: j...@google.com
Date: Tue Jun 30 08:01:08 2009
New Revision: 5641

Modified:
trunk/user/src/com/google/gwt/dom/client/DOMImplMozilla.java
trunk/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java

Log:
Fix for Firefox 3.5 relatedTarget bug  
(https://bugzilla.mozilla.org/show_bug.cgi?id=497780)
Review: http://gwt-code-reviews.appspot.com/49803


Modified: trunk/user/src/com/google/gwt/dom/client/DOMImplMozilla.java
==
--- trunk/user/src/com/google/gwt/dom/client/DOMImplMozilla.java
(original)
+++ trunk/user/src/com/google/gwt/dom/client/DOMImplMozilla.javaTue Jun 
30  
08:01:08 2009
@@ -37,6 +37,20 @@
}-*/;

@Override
+  public native EventTarget eventGetRelatedTarget(NativeEvent evt) /*-{
+// Hack around Mozilla bug 497780 (relatedTarget sometimes returns XUL
+// elements). Trying to access relatedTarget.nodeName will throw an
+// exception if it's a XUL element.
+var relatedTarget = evt.relatedTarget;
+try {
+  var nodeName = relatedTarget.nodeName;
+  return relatedTarget;
+} catch (e) {
+  return null;
+}
+  }-*/;
+
+  @Override
public int getAbsoluteLeft(Element elem) {
  return  
getAbsoluteLeftImpl(elem.getOwnerDocument().getViewportElement(),
  elem);

Modified:  
trunk/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java
==
--- trunk/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java  
(original)
+++ trunk/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java Tue  
Jun 30 08:01:08 2009
@@ -39,22 +39,30 @@
private static JavaScriptObject dispatchEvent;

@Override
-  public native Element eventGetFromElement(Event evt) /*-{
-if (evt.type == mouseover)
-  return evt.relatedTarget;
-if (evt.type == mouseout)
-  return evt.target;
+  public Element eventGetFromElement(Event evt) {
+if (evt.getType().equals(mouseover)) {
+  return evt.getRelatedTarget().cast();
+}
+
+if (evt.getType().equals(mouseout)) {
+  return evt.getTarget().cast();
+}
+
  return null;
-  }-*/;
+  }

@Override
-  public native Element eventGetToElement(Event evt) /*-{
-if (evt.type == mouseover)
-  return evt.target;
-if (evt.type == mouseout)
-  return evt.relatedTarget;
+  public Element eventGetToElement(Event evt) {
+if (evt.getType().equals(mouseover)) {
+  return evt.getTarget().cast();
+}
+
+if (evt.getType().equals(mouseout)) {
+  return evt.getRelatedTarget().cast();
+}
+
  return null;
-  }-*/;
+  }

@Override
public native Element getChild(Element elem, int index) /*-{

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---



[gwt-contrib] [google-web-toolkit commit] r5642 - Merging r5641 from trunk (Fix for Firefox 3.5 Event.relatedTarget bug).

2009-06-30 Thread codesite-noreply

Author: j...@google.com
Date: Tue Jun 30 08:39:50 2009
New Revision: 5642

Modified:
 
branches/snapshot-2009.06.16-r5570/user/src/com/google/gwt/dom/client/DOMImplMozilla.java
 
branches/snapshot-2009.06.16-r5570/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java

Log:
Merging r5641 from trunk (Fix for Firefox 3.5 Event.relatedTarget bug).


Modified:  
branches/snapshot-2009.06.16-r5570/user/src/com/google/gwt/dom/client/DOMImplMozilla.java
==
---  
branches/snapshot-2009.06.16-r5570/user/src/com/google/gwt/dom/client/DOMImplMozilla.java

(original)
+++  
branches/snapshot-2009.06.16-r5570/user/src/com/google/gwt/dom/client/DOMImplMozilla.java

Tue Jun 30 08:39:50 2009
@@ -37,6 +37,20 @@
}-*/;

@Override
+  public native EventTarget eventGetRelatedTarget(NativeEvent evt) /*-{
+// Hack around Mozilla bug 497780 (relatedTarget sometimes returns XUL
+// elements). Trying to access relatedTarget.nodeName will throw an
+// exception if it's a XUL element.
+var relatedTarget = evt.relatedTarget;
+try {
+  var nodeName = relatedTarget.nodeName;
+  return relatedTarget;
+} catch (e) {
+  return null;
+}
+  }-*/;
+
+  @Override
public int getAbsoluteLeft(Element elem) {
  return  
getAbsoluteLeftImpl(elem.getOwnerDocument().getViewportElement(),
  elem);

Modified:  
branches/snapshot-2009.06.16-r5570/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java
==
---  
branches/snapshot-2009.06.16-r5570/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java
 
(original)
+++  
branches/snapshot-2009.06.16-r5570/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java
 
Tue Jun 30 08:39:50 2009
@@ -39,22 +39,30 @@
private static JavaScriptObject dispatchEvent;

@Override
-  public native Element eventGetFromElement(Event evt) /*-{
-if (evt.type == mouseover)
-  return evt.relatedTarget;
-if (evt.type == mouseout)
-  return evt.target;
+  public Element eventGetFromElement(Event evt) {
+if (evt.getType().equals(mouseover)) {
+  return evt.getRelatedTarget().cast();
+}
+
+if (evt.getType().equals(mouseout)) {
+  return evt.getTarget().cast();
+}
+
  return null;
-  }-*/;
+  }

@Override
-  public native Element eventGetToElement(Event evt) /*-{
-if (evt.type == mouseover)
-  return evt.target;
-if (evt.type == mouseout)
-  return evt.relatedTarget;
+  public Element eventGetToElement(Event evt) {
+if (evt.getType().equals(mouseover)) {
+  return evt.getTarget().cast();
+}
+
+if (evt.getType().equals(mouseout)) {
+  return evt.getRelatedTarget().cast();
+}
+
  return null;
-  }-*/;
+  }

@Override
public native Element getChild(Element elem, int index) /*-{

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---