[gwt-contrib] Should GWT support WebGL without Elemental ? (or should Elemental be extended to support more browsers ?)

2013-07-29 Thread Alberto Mancini
Hi,
hope this is the right list for this discussion.

WebGL is today supported at least  by FF and, according to 
http://caniuse.com/webgl, also the next release of IE will support it so I 
wonder if
should GWT support WebGL (without Elemental).

As i see in previous mails in this group, and in other GWT related groups, 
the direction of the community is to move code 'out' of the core
but in my opinion the support of browser-related-features has to be 
provided by GWT and not by external libraries, comments ?  

Elemental seems to me the right place where to have non-so-standard 
features but supporting just chrome is not enough and I can't imagine alone 
the work needed to 
extend it to ff & co.  
I remember a post, that I cannot find anymore actually, about extending 
Elemental to support at least ff, there is any work in that direction or 
is better to leave generating-code-from-webidl just for chrome ? 


Thank you,
   Alberto

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Re: Add Map support to RequestFactory (issue 6132056)

2013-07-29 Thread James Horsley
I ported the CR to gerrit a couple of months back
https://gwt-review.googlesource.com/#/c/3186/

Last update I got was that it's pending further review by Thomas Broyer
who's currently tied up with modularization and mavenization. I'm seeing
other RF changes going on though so hopefully it won't require too much
reworking of my original commit.


I totally understand there are limited resources for reviewing this stuff
but it would be quite frustrating if many changes were necessary to my
patch due to underlying changes. I submitted the patch over a year ago and
it's the 6th highest starred issue on the issue tracker from what I can
tell.



On 29 July 2013 16:27,  wrote:

> On 2012/10/30 08:28:07, james.horsley wrote:
>
>> On 2012/06/08 17:20:06, rdayal wrote:
>> > Yep, you're on the CLA list.
>> >
>> > On Fri Jun 08 05:15:45 GMT-400 2012, James Horsley
>> 
>> > wrote:
>> >
>> > > Just to check, was everything okay with the CLA I signed?
>> > >
>> > > On 7 June 2012 16:56, James Horsley
>>
>  wrote:
>
>> > >
>> > > Thanks Rajeev. Let me know if there's anything else you need with
>>
> it.
>
>> > >
>> > >
>> > > On 7 June 2012 16:18, Rajeev Dayal 
>>
> wrote:
>
>> > >
>> > > Thomas, thanks for jumping in.
>> > >
>> > > James, as Thomas said, we'll defer this to 2.5.1, but we'd
>>
> definitely like
>
>> > > to get it in there, as it's an important patch. We just didn't
>>
> want to
>
>> > > force this patch in 2.5.0, which is what we would have to do with
>>
> the
>
>> > > current workload.
>> > >
>> > > Thanks so much for working on this.
>> > >
>> > >
>> > > On Thu Jun 07 06:23:58 GMT-400 2012,
>>
>  wrote:
>
>> > >
>> > > Totally agree on this needing another round. Also, hearing about
>>
> the
>
>> > > plans for a 2.5.1 release which this could potentially be a
>>
> candidate
>
>> > > for is great.
>> > >
>> > > Thanks again.
>> > >
>> > > On 2012/06/07 09:56:52, t.broyer wrote:
>> > > > On 2012/06/07 09:22:24, james.horsley wrote:
>> > > > > Thanks for all your help with the patch Thomas. Sad to hear it
>>
> won't
>
>> > > make it
>> > > > > into GWT 2.5 as we were really looking to use RF with Maps
>>
> without
>
>> > > having to
>> > > > use
>> > > > > a patched version of GWT built from source internally.
>> > >
>> > > > We're planning a 2.5.1 soon after 2.5.
>> > > > There are also several issues with Map support in AutoBeans
>>
> (reported
>
>> > > only
>> > > > recently) which I'd like to get fixed at the same time (some of
>>
> them
>
>> > > are related
>> > > > to how maps are encoded/decoded, so I'd like to have it the same
>>
> in
>
>> > > both
>> > > > AutoBeans and RF; see
>> > > >
>>
> http://code.google.com/p/**google-web-toolkit/issues/**detail?id=7395for
>
>> > > instance,
>> > > > which you seem to have avoided by using a slightly different
>> > > serialization path
>> > > > for keys, where String keys are encoded as "\"foo\"", vs. "foo"
>>
> in
>
>> > > AutoBean's
>> > > > serialization).
>> > > > Finally, to be honest, I think we need at least one more round
>>
> here: I
>
>> > > need some
>> > > > more time to wrap my head around it.
>> > >
>> > >
>> > >
>> > >
>> >
>>
>
> http://codereview.appspot.com/**6132056/%253Chttps://www.**
> google.com/url?sa=D&q=http://**codereview.appspot.com/**6132056/
> >
>
>> > >
>> > >
>> > >
>> > >
>>
>
>  I'm possibly being a bit eager given 2.5 GA only just went out but
>>
> thought I'd
>
>> just ping on this with regards to the 2.5.1 release that had been
>>
> mentioned.
>
> Anything new on this?
>
> https://codereview.appspot.**com/6132056/
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




Re: [gwt-contrib] Should GWT support WebGL without Elemental ? (or should Elemental be extended to support more browsers ?)

2013-07-29 Thread Goktug Gokdogan
Not specific to WebGL but for anything becomes part of the GWT core, we
want it to first evolve and 'be proven' as a 3rd party library first (when
it is feasible).



On Mon, Jul 29, 2013 at 2:03 AM, Alberto Mancini wrote:

> Hi,
> hope this is the right list for this discussion.
>
> WebGL is today supported at least  by FF and, according to
> http://caniuse.com/webgl, also the next release of IE will support it so
> I wonder if
> should GWT support WebGL (without Elemental).
>
> As i see in previous mails in this group, and in other GWT related groups,
> the direction of the community is to move code 'out' of the core
> but in my opinion the support of browser-related-features has to be
> provided by GWT and not by external libraries, comments ?
>
> Elemental seems to me the right place where to have non-so-standard
> features but supporting just chrome is not enough and I can't imagine alone
> the work needed to
> extend it to ff & co.
> I remember a post, that I cannot find anymore actually, about extending
> Elemental to support at least ff, there is any work in that direction or
> is better to leave generating-code-from-webidl just for chrome ?
>
>
> Thank you,
>Alberto
>
>  --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors
> ---
> You received this message because you are subscribed to the Google Groups
> "GWT Contributors" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Client side sorting in a celltable with ListDataProvider & ListHandler

2013-07-29 Thread stuckagain
Hi,

I tried to discuss this in the GWT google groups, but I did not get any 
feedback there. I figured since this was a strange design choice in GWT 
that I should discuss it here:

I just lost 2 hours on getting client side sorting to work correctly in my 
DataGrid backed by a ListDataProvider. I was using the 
ColumnSortEvent$ListHandler class that was mentioned in the documentation 
to handle the client-side sorting.
 
I was calling setList( rows ) on the DataProvider to update the table. When 
you call setList, the DataGrid is being updated correctly. But clicking on 
a column to sort (client side) does not work, nothing is being sorted.

I did some investigation an the problem is actually very simple. The The 
ColumnSortEvent$ListHandler class takes a List as argument instead of the 
ListDataProvider. When you call setList() on the DataProvider a new wrapper 
is created and so the ListHandler is looking at the wrong one (the empty 
list in my case hence no sort effect at all).
 
Wouldn't it be better that the ListHandler would keep a reference to the 
ListDataProvider instead of using the List ? Then it can call getList() on 
it when a sort is needed.
 
It is now a bit asymetric: calling setList() updates the table rows, but 
the sorter does not know... I am sure many many people fall in this trap!
At least the documentation should maybe point this out. I just replaced the 
ListHandler with my own that just calls getList() on the ListDataProvider 
everytime a sort is needed, that works completely transparently. I don't 
want to create and reconfigure a ListHandler every time I update the table 
data. 

calling clear() and addAll() is an alternative, but it is awkward and 
should at least be documented.

David

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Re: Client side sorting in a celltable with ListDataProvider & ListHandler

2013-07-29 Thread Thomas Broyer
See (in no particular order):

   - https://code.google.com/p/google-web-toolkit/issues/detail?id=7072
   - https://code.google.com/p/google-web-toolkit/issues/detail?id=7114
   - https://code.google.com/p/google-web-toolkit/issues/detail?id=6686 (which 
   you actually found)
   
What change to the documentation would you propose? Made it clear(er) that 
getList will return a new object after setList is called?

And as one of the above-linked issues points out, an alternative to 
clearn/addAll is to setList on the ListHandler (using the getList of the 
ListDataProvider) each time you setList on the ListDataProvider.

On Monday, July 29, 2013 9:36:40 PM UTC+2, stuckagain wrote:
>
> Hi,
>
> I tried to discuss this in the GWT google groups, but I did not get any 
> feedback there. I figured since this was a strange design choice in GWT 
> that I should discuss it here:
>
> I just lost 2 hours on getting client side sorting to work correctly in my 
> DataGrid backed by a ListDataProvider. I was using the 
> ColumnSortEvent$ListHandler class that was mentioned in the documentation 
> to handle the client-side sorting.
>  
> I was calling setList( rows ) on the DataProvider to update the table. 
> When you call setList, the DataGrid is being updated correctly. But 
> clicking on a column to sort (client side) does not work, nothing is being 
> sorted.
>
> I did some investigation an the problem is actually very simple. The The 
> ColumnSortEvent$ListHandler class takes a List as argument instead of the 
> ListDataProvider. When you call setList() on the DataProvider a new wrapper 
> is created and so the ListHandler is looking at the wrong one (the empty 
> list in my case hence no sort effect at all).
>  
> Wouldn't it be better that the ListHandler would keep a reference to the 
> ListDataProvider instead of using the List ? Then it can call getList() on 
> it when a sort is needed.
>  
> It is now a bit asymetric: calling setList() updates the table rows, but 
> the sorter does not know... I am sure many many people fall in this trap!
> At least the documentation should maybe point this out. I just replaced 
> the ListHandler with my own that just calls getList() on the 
> ListDataProvider everytime a sort is needed, that works completely 
> transparently. I don't want to create and reconfigure a ListHandler every 
> time I update the table data. 
>
> calling clear() and addAll() is an alternative, but it is awkward and 
> should at least be documented.
>
> David
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




Re: [gwt-contrib] Should GWT support WebGL without Elemental ? (or should Elemental be extended to support more browsers ?)

2013-07-29 Thread Alberto Mancini
Actually that makes sense.
I found that moving all the WebGL code off from elemental is
straightforward and my first test works as expected.

To proceed in the attempt of building a '3rd party' lib with the
webgl-bindings taken from elemental (but based on the GWT Canvas) i need to
fix
http://code.google.com/p/google-web-toolkit/issues/detail?id=6512 adding a
JSO as second arg of getContext, i will try to send a patch later
so I see if this path is acceptable.

Then I will need some tests, has anyone webgl code for that use ?

Thank you,
   Alberto.



On Mon, Jul 29, 2013 at 9:05 PM, Goktug Gokdogan  wrote:

> Not specific to WebGL but for anything becomes part of the GWT core, we
> want it to first evolve and 'be proven' as a 3rd party library first (when
> it is feasible).
>
>
>
> On Mon, Jul 29, 2013 at 2:03 AM, Alberto Mancini wrote:
>
>> Hi,
>> hope this is the right list for this discussion.
>>
>> WebGL is today supported at least  by FF and, according to
>> http://caniuse.com/webgl, also the next release of IE will support it so
>> I wonder if
>> should GWT support WebGL (without Elemental).
>>
>> As i see in previous mails in this group, and in other GWT related
>> groups, the direction of the community is to move code 'out' of the core
>> but in my opinion the support of browser-related-features has to be
>> provided by GWT and not by external libraries, comments ?
>>
>> Elemental seems to me the right place where to have non-so-standard
>> features but supporting just chrome is not enough and I can't imagine alone
>> the work needed to
>> extend it to ff & co.
>> I remember a post, that I cannot find anymore actually, about extending
>> Elemental to support at least ff, there is any work in that direction or
>> is better to leave generating-code-from-webidl just for chrome ?
>>
>>
>> Thank you,
>>Alberto
>>
>>  --
>> http://groups.google.com/group/Google-Web-Toolkit-Contributors
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "GWT Contributors" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.
>>
>>
>>
>
>  --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors
> ---
> You received this message because you are subscribed to the Google Groups
> "GWT Contributors" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.