[gwt-contrib] Change in gwt[master]: Adding Integer.compare to emulation

[Daniel Kurka]

Hello Leeroy Jenkins,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3180

to look at the new patch set (#2).

Change subject: Adding Integer.compare to emulation
..

Adding Integer.compare to emulation

fixes ISSUE 7998

Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Review-Link: https://gwt-review.googlesource.com/#/c/3180/
---
M user/super/com/google/gwt/emul/java/lang/Integer.java
1 file changed, 4 insertions(+), 0 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Adding Integer.compare to emulation

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Adding Integer.compare to emulation
..


Patch Set 2:

(1 comment)

Can't seem to see your other comments, did you publish?


File user/super/com/google/gwt/emul/java/lang/Integer.java
Line 61: return (x < y) ? -1 : ((x == y) ? 0 : 1);
Done


--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

[Daniel Kurka]

Hello Thomas Broyer, Leeroy Jenkins,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3180

to look at the new patch set (#3).

Change subject: adding compare for several number types  -Byte.compare  
-Short.compare -Integer.compare -Long.compare -Float.compare  (Double  
already exists)  fixes issue 7998

..

adding compare for several number types

-Byte.compare
-Short.compare
-Integer.compare
-Long.compare
-Float.compare

(Double already exists)

fixes issue 7998

Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Review-Link: https://gwt-review.googlesource.com/#/c/3180/
---
M user/super/com/google/gwt/emul/java/lang/Byte.java
M user/super/com/google/gwt/emul/java/lang/Integer.java
M user/super/com/google/gwt/emul/java/lang/Long.java
M user/super/com/google/gwt/emul/java/lang/Short.java
M user/test/com/google/gwt/emultest/java/lang/ByteTest.java
M user/test/com/google/gwt/emultest/java/lang/FloatTest.java
M user/test/com/google/gwt/emultest/java/lang/IntegerTest.java
M user/test/com/google/gwt/emultest/java/lang/LongTest.java
M user/test/com/google/gwt/emultest/java/lang/ShortTest.java
9 files changed, 46 insertions(+), 0 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

[Daniel Kurka]

Hello Thomas Broyer, Leeroy Jenkins,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3180

to look at the new patch set (#4).

Change subject: adding compare for several number types  -Byte.compare  
-Short.compare -Integer.compare -Long.compare -Float.compare  (Double  
already exists)  fixes issue 7998

..

adding compare for several number types

-Byte.compare
-Short.compare
-Integer.compare
-Long.compare
-Float.compare

(Double already exists)

fixes issue 7998

Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Review-Link: https://gwt-review.googlesource.com/#/c/3180/
---
M user/super/com/google/gwt/emul/java/lang/Byte.java
M user/super/com/google/gwt/emul/java/lang/Integer.java
M user/super/com/google/gwt/emul/java/lang/Long.java
M user/super/com/google/gwt/emul/java/lang/Short.java
M user/test/com/google/gwt/emultest/java/lang/ByteTest.java
M user/test/com/google/gwt/emultest/java/lang/FloatTest.java
M user/test/com/google/gwt/emultest/java/lang/IntegerTest.java
M user/test/com/google/gwt/emultest/java/lang/LongTest.java
M user/test/com/google/gwt/emultest/java/lang/ShortTest.java
9 files changed, 46 insertions(+), 0 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

[Daniel Kurka]

Hello Thomas Broyer, Leeroy Jenkins,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3180

to look at the new patch set (#5).

Change subject: adding compare for several number types  -Byte.compare  
-Short.compare -Integer.compare -Long.compare -Float.compare  (Double  
already exists)  fixes issue 7998

..

adding compare for several number types

-Byte.compare
-Short.compare
-Integer.compare
-Long.compare
-Float.compare

(Double already exists)

fixes issue 7998

Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Review-Link: https://gwt-review.googlesource.com/#/c/3180/
---
M user/super/com/google/gwt/emul/java/lang/Byte.java
M user/super/com/google/gwt/emul/java/lang/Integer.java
M user/super/com/google/gwt/emul/java/lang/Long.java
M user/super/com/google/gwt/emul/java/lang/Short.java
M user/test/com/google/gwt/emultest/java/lang/ByteTest.java
M user/test/com/google/gwt/emultest/java/lang/FloatTest.java
M user/test/com/google/gwt/emultest/java/lang/IntegerTest.java
M user/test/com/google/gwt/emultest/java/lang/LongTest.java
M user/test/com/google/gwt/emultest/java/lang/ShortTest.java
9 files changed, 46 insertions(+), 0 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

[Daniel Kurka]

Hello Thomas Broyer, Leeroy Jenkins,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3180

to look at the new patch set (#6).

Change subject: adding compare for several number types  -Byte.compare  
-Short.compare -Integer.compare -Long.compare -Float.compare  (Double  
already exists)  fixes issue 7998

..

adding compare for several number types

-Byte.compare
-Short.compare
-Integer.compare
-Long.compare
-Float.compare

(Double already exists)

fixes issue 7998

Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Review-Link: https://gwt-review.googlesource.com/#/c/3180/
---
M user/super/com/google/gwt/emul/java/lang/Byte.java
M user/super/com/google/gwt/emul/java/lang/Integer.java
M user/super/com/google/gwt/emul/java/lang/Long.java
M user/super/com/google/gwt/emul/java/lang/Short.java
M user/test/com/google/gwt/emultest/java/lang/ByteTest.java
M user/test/com/google/gwt/emultest/java/lang/FloatTest.java
M user/test/com/google/gwt/emultest/java/lang/IntegerTest.java
M user/test/com/google/gwt/emultest/java/lang/LongTest.java
M user/test/com/google/gwt/emultest/java/lang/ShortTest.java
9 files changed, 48 insertions(+), 14 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 6
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: adding compare for several number types  -Byte.compare  
-Short.compare -Integer.compare -Long.compare -Float.compare  (Double  
already exists)  fixes issue 7998

..


Patch Set 5:

(3 comments)


File user/super/com/google/gwt/emul/java/lang/Byte.java
Line 37: return (x < y) ? -1 : ((x == y) ? 0 : 1);
Updated compareTo to use compare as well, but did not go for if/else  
combination




File user/super/com/google/gwt/emul/java/lang/Integer.java
Line 61: return signum(x - y);
rewrote compareTo here as well



File user/test/com/google/gwt/emultest/java/lang/ByteTest.java
Line 38: assertTrue("Byte.compare failed for 1 == 1",  
Byte.compare((byte) 1, (byte) 1) == 0);

Done


--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: adding compare for several number types  -Byte.compare  
-Short.compare -Integer.compare -Long.compare -Float.compare  (Double  
already exists)  fixes issue 7998

..


Patch Set 6:

Sorry about the comments getting messed up.

Gerrit still confuses me somtimes. Am I supposed to update comments first  
and then supply another patch or the other way around?


@Thomas you were right about the FloatTests emul failed in prod mode,  
jenkins did not catch that.


I will update Float.compare/ FloatTest

--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 6
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

[Daniel Kurka]

Hello Thomas Broyer, Leeroy Jenkins,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3180

to look at the new patch set (#7).

Change subject: adding compare for several number types  -Byte.compare  
-Short.compare -Integer.compare -Long.compare -Float.compare  (Double  
already exists)  fixes issue 7998

..

adding compare for several number types

-Byte.compare
-Short.compare
-Integer.compare
-Long.compare
-Float.compare

(Double already exists)

fixes issue 7998

Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Review-Link: https://gwt-review.googlesource.com/#/c/3180/
---
M user/super/com/google/gwt/emul/java/lang/Byte.java
M user/super/com/google/gwt/emul/java/lang/Float.java
M user/super/com/google/gwt/emul/java/lang/Integer.java
M user/super/com/google/gwt/emul/java/lang/Long.java
M user/super/com/google/gwt/emul/java/lang/Short.java
M user/test/com/google/gwt/emultest/java/lang/ByteTest.java
M user/test/com/google/gwt/emultest/java/lang/FloatTest.java
M user/test/com/google/gwt/emultest/java/lang/IntegerTest.java
M user/test/com/google/gwt/emultest/java/lang/LongTest.java
M user/test/com/google/gwt/emultest/java/lang/ShortTest.java
10 files changed, 64 insertions(+), 14 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 7
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: adding compare for several number types  -Byte.compare  
-Short.compare -Integer.compare -Long.compare -Float.compare  (Double  
already exists)  fixes issue 7998

..


Patch Set 7:

(5 comments)


File user/super/com/google/gwt/emul/java/lang/Byte.java
Line 100: return Byte.compare(value, b.value);
Done



File user/super/com/google/gwt/emul/java/lang/Float.java
Line 37: if (isNaN(x)) {
There was no bug for this, I just ran the tests in prod mode and they  
failed with NaN.



Line 46:
Done



File user/super/com/google/gwt/emul/java/lang/Short.java
Line 37: return (x < y) ? -1 : ((x == y) ? 0 : 1);
Not sure if there are any performance implications here with coercion



File user/test/com/google/gwt/emultest/java/lang/FloatTest.java
Line 59:
Done


--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 7
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

[Daniel Kurka]

Hello John A. Tamplin, Thomas Broyer, Leeroy Jenkins,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3180

to look at the new patch set (#8).

Change subject: adding compare for several number types  -Byte.compare  
-Short.compare -Integer.compare -Long.compare -Float.compare  (Double  
already exists)  fixes issue 7998

..

adding compare for several number types

-Byte.compare
-Short.compare
-Integer.compare
-Long.compare
-Float.compare

(Double already exists)

fixes issue 7998

Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Review-Link: https://gwt-review.googlesource.com/#/c/3180/
---
M user/super/com/google/gwt/emul/java/lang/Byte.java
M user/super/com/google/gwt/emul/java/lang/Float.java
M user/super/com/google/gwt/emul/java/lang/Integer.java
M user/super/com/google/gwt/emul/java/lang/Long.java
M user/super/com/google/gwt/emul/java/lang/Short.java
M user/test/com/google/gwt/emultest/java/lang/ByteTest.java
M user/test/com/google/gwt/emultest/java/lang/FloatTest.java
M user/test/com/google/gwt/emultest/java/lang/IntegerTest.java
M user/test/com/google/gwt/emultest/java/lang/LongTest.java
M user/test/com/google/gwt/emultest/java/lang/ShortTest.java
10 files changed, 82 insertions(+), 28 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 8
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: adding compare for several number types  -Byte.compare  
-Short.compare -Integer.compare -Long.compare -Float.compare  (Double  
already exists)  fixes issue 7998

..


Patch Set 8:

@Andrey could you open another bug for this, so this patch does not grow  
even more?


--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 8
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

[Daniel Kurka]

Hello John A. Tamplin, Thomas Broyer, Leeroy Jenkins,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3180

to look at the new patch set (#9).

Change subject: adding compare for several number types  -Byte.compare  
-Short.compare -Integer.compare -Long.compare -Float.compare  (Double  
already exists)  fixes issue 7998

..

adding compare for several number types

-Byte.compare
-Short.compare
-Integer.compare
-Long.compare
-Float.compare

(Double already exists)

fixes issue 7998

Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Review-Link: https://gwt-review.googlesource.com/#/c/3180/
---
M user/super/com/google/gwt/emul/java/lang/Byte.java
M user/super/com/google/gwt/emul/java/lang/Float.java
M user/super/com/google/gwt/emul/java/lang/Integer.java
M user/super/com/google/gwt/emul/java/lang/Long.java
M user/super/com/google/gwt/emul/java/lang/Short.java
M user/test/com/google/gwt/emultest/java/lang/ByteTest.java
M user/test/com/google/gwt/emultest/java/lang/FloatTest.java
M user/test/com/google/gwt/emultest/java/lang/IntegerTest.java
M user/test/com/google/gwt/emultest/java/lang/LongTest.java
M user/test/com/google/gwt/emultest/java/lang/ShortTest.java
10 files changed, 83 insertions(+), 35 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 9
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: adding compare for several number types  -Byte.compare  
-Short.compare -Integer.compare -Long.compare -Float.compare  (Double  
already exists)  fixes issue 7998

..


Patch Set 8:

(2 comments)


File user/super/com/google/gwt/emul/java/lang/Byte.java
Line 100: return Byte.compare(value, b.value);
Done



File user/test/com/google/gwt/emultest/java/lang/FloatTest.java
Line 66:
Done


--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 8
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Emulate Boolean.compare(boolean,boolean), Character.compare(...

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Emulate Boolean.compare(boolean,boolean),  
Character.compare(char,char)

..


Patch Set 1:

(5 comments)


File user/super/com/google/gwt/emul/java/lang/Character.java
Line 174: // JLS specifies that the chars are promoted to int before  
subtraction.
I am not quite sure if this works with the GWT compiler though, did you run  
your tests in web mode?




File user/test/com/google/gwt/emultest/java/lang/BooleanTest.java
Line 52:   public void testCompare() {
nit: sort alphabetically (move up)



File user/test/com/google/gwt/emultest/java/lang/CharacterTest.java
Line 238: assertTrue("Character.compare failed for 'A' < 'B'",  
Character.compare(Character.valueOf('A'), Character.valueOf('B')) < 0);

nit: formatting?


Line 239: assertTrue("Character.compare failed for 'B' > 'A'",  
Character.compare(Character.valueOf('B'), Character.valueOf('A')) > 0);

nit: formatting?


Line 241: assertTrue("Character.compare failed for '\uA001'  
'\uA000'", Character.compare(Character.valueOf('\uA001'),  

Character.valueOf('\uA000')) > 0);
nit:formatting?


--
To view, visit https://gwt-review.googlesource.com/3183
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00df601b33cb5e270be45819c1ad54ae9c955869
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Emulate Boolean.compare(boolean,boolean), Character.compare(...

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Emulate Boolean.compare(boolean,boolean),  
Character.compare(char,char)

..


Patch Set 2:

(1 comment)


File user/test/com/google/gwt/emultest/java/lang/BooleanTest.java
Line 62:   public void testCompare() {
I actually meant this to go over testCtor :)


--
To view, visit https://gwt-review.googlesource.com/3183
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00df601b33cb5e270be45819c1ad54ae9c955869
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Emulate Boolean.compare(boolean,boolean), Character.compare(...

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Emulate Boolean.compare(boolean,boolean),  
Character.compare(char,char)

..


Patch Set 2:

(1 comment)


File user/test/com/google/gwt/emultest/java/lang/BooleanTest.java
Line 62:   public void testCompare() {
We are discussing right now internally and if we get an agreement we will  
forward to the steering committee, but right now we are still ordering.



--
To view, visit https://gwt-review.googlesource.com/3183
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00df601b33cb5e270be45819c1ad54ae9c955869
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: adding compare for several number types  -Byte.compare  
-Short.compare -Integer.compare -Long.compare -Float.compare  (Double  
already exists)  fixes issue 7998

..


Patch Set 9:

I'll leave this open for another 1-2 days to give other the chance to  
comment


--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 9
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Emulate Boolean.compare(boolean,boolean), Character.compare(...

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Emulate Boolean.compare(boolean,boolean),  
Character.compare(char,char)

..


Patch Set 3: Code-Review+1

Lets leave this open for another 1-2 days to give the others a chance to  
comment, but LGTM


--
To view, visit https://gwt-review.googlesource.com/3183
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00df601b33cb5e270be45819c1ad54ae9c955869
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Emulate Boolean.compare(boolean,boolean), Character.compare(...

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Emulate Boolean.compare(boolean,boolean),  
Character.compare(char,char)

..


Patch Set 4: Code-Review+1

LGTM

--
To view, visit https://gwt-review.googlesource.com/3183
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00df601b33cb5e270be45819c1ad54ae9c955869
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: adding compare for several number types  -Byte.compare  
-Short.compare -Integer.compare -Long.compare -Float.compare  (Double  
already exists)  fixes issue 7998

..


Patch Set 9:

(4 comments)


File user/super/com/google/gwt/emul/java/lang/Float.java
Line 37: if (isNaN(x)) {
I don't think its a good idea, since with this we would have to do  
something like:


if(!isNaN(x) && !isNaN(y)) {
// do normal stuff
}else{
//test again
}

If we want to change this, we should also change this in Double.compare  
(its implemented the same way)




File user/super/com/google/gwt/emul/java/lang/Short.java
Line 37: return Integer.compare(x, y);
I don"t really understand what the difference would be between prod vs. dev  
if we do not use x-y. Correct me if I am wrong but one should never rely on  
the exact value returned from compare.




File user/test/com/google/gwt/emultest/java/lang/FloatTest.java
Line 81:   }
In JavaScript something like this passes:
assertEquals(0, Float.compare(0.0f, -0.0f));

While it does not pass in Java. Do we want to make sure we cover this  
corner case (as well as others) and take the performance hit?


Not sure here. Could we just cover this in the docs of the JRE Emulation?



File user/test/com/google/gwt/emultest/java/lang/IntegerTest.java
Line 120: assertEquals(0, Integer.compare(1, 1));
We actually look terrible at the Borders:

This will just fail:
Integer.compare(Integer.MAX_VALUE,  Integer.MIN_VALUE) > 0

since we do not got overflow for ints in javascript.

I am not sure how to handle such corner cases, do we want to handle them,  
any input?



--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 9
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Make Element.hasTagName(...) case-insensitive.

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Make Element.hasTagName(...) case-insensitive.
..


Patch Set 4: Code-Review+1

LGTM, please address Manuel's comment

--
To view, visit https://gwt-review.googlesource.com/2975
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib24bee7fa494c0345a7bc97e1b5df1095a05d024
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roy Paterson 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Manuel Carrasco Moñino 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Make Element.hasTagName(...) case-insensitive.

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Make Element.hasTagName(...) case-insensitive.
..


Patch Set 5: Code-Review+2

LGTM

You can submit this change now using the publish & submit button

--
To view, visit https://gwt-review.googlesource.com/2975
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib24bee7fa494c0345a7bc97e1b5df1095a05d024
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roy Paterson 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Manuel Carrasco Moñino 
Gerrit-Reviewer: Roy Paterson 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Change DOM access in HTMLTable for IE

[Daniel Kurka]

Daniel Kurka has uploaded a new change for review.

  https://gwt-review.googlesource.com/3212


Change subject: Change DOM access in HTMLTable for IE
..

Change DOM access in HTMLTable for IE

using table.rows or table.rows[i].cells
causes memory leaks in IE

Added two different implementations
to access table rows and cells. One for
IE and one for the rest

fixes issue 6938

Change-Id: I5789589a307f457a1295b9ed72111ad4c040fa97
---
A user/src/com/google/gwt/user/HTMLTable.gwt.xml
M user/src/com/google/gwt/user/User.gwt.xml
M user/src/com/google/gwt/user/client/ui/FlexTable.java
M user/src/com/google/gwt/user/client/ui/HTMLTable.java
4 files changed, 136 insertions(+), 23 deletions(-)



diff --git a/user/src/com/google/gwt/user/HTMLTable.gwt.xml  
b/user/src/com/google/gwt/user/HTMLTable.gwt.xml

new file mode 100644
index 000..18ded5d
--- /dev/null
+++ b/user/src/com/google/gwt/user/HTMLTable.gwt.xml
@@ -0,0 +1,37 @@
+
+
+
+
+
+
+
+
+
+
+
+
+

+
+
+
+
+

+
+  
+  
+
+  
+  class="com.google.gwt.user.client.ui.HTMLTable.HTMLTableStandardImpl">
+class="com.google.gwt.user.client.ui.HTMLTable.HTMLTableImpl"/>

+  
+
+  
+  class="com.google.gwt.user.client.ui.HTMLTable.HTMLTableIEImpl">
+class="com.google.gwt.user.client.ui.HTMLTable.HTMLTableImpl"/>

+
+  
+  
+  
+
+  
+
diff --git a/user/src/com/google/gwt/user/User.gwt.xml  
b/user/src/com/google/gwt/user/User.gwt.xml

index 5f9b89c..1cf42ef 100644
--- a/user/src/com/google/gwt/user/User.gwt.xml
+++ b/user/src/com/google/gwt/user/User.gwt.xml
@@ -48,6 +48,7 @@



+   



diff --git a/user/src/com/google/gwt/user/client/ui/FlexTable.java  
b/user/src/com/google/gwt/user/client/ui/FlexTable.java

index 5eecb9c..5ec2999 100644
--- a/user/src/com/google/gwt/user/client/ui/FlexTable.java
+++ b/user/src/com/google/gwt/user/client/ui/FlexTable.java
@@ -16,7 +16,6 @@
 package com.google.gwt.user.client.ui;

 import com.google.gwt.user.client.DOM;
-import com.google.gwt.user.client.Element;

 /**
  * A flexible table that creates cells on demand. It can be jagged (that  
is,

@@ -91,14 +90,6 @@
   DOM.setElementPropertyInt(ensureElement(row, column), "rowSpan",  
rowSpan);

 }
   }
-
-  private static native void addCells(Element table, int row, int num)/*-{
-var rowElem = table.rows[row];
-for(var i = 0; i < num; i++){
-  var cell = $doc.createElement("td");
-  rowElem.appendChild(cell);
-}
-  }-*/;

   public FlexTable() {
 super();
diff --git a/user/src/com/google/gwt/user/client/ui/HTMLTable.java  
b/user/src/com/google/gwt/user/client/ui/HTMLTable.java

index 05e528f..2d43f24 100644
--- a/user/src/com/google/gwt/user/client/ui/HTMLTable.java
+++ b/user/src/com/google/gwt/user/client/ui/HTMLTable.java
@@ -15,6 +15,7 @@
  */
 package com.google.gwt.user.client.ui;

+import com.google.gwt.core.shared.GWT;
 import com.google.gwt.dom.client.Document;
 import com.google.gwt.dom.client.TableCellElement;
 import com.google.gwt.dom.client.TableRowElement;
@@ -27,9 +28,9 @@
 import com.google.gwt.event.dom.client.DragEnterEvent;
 import com.google.gwt.event.dom.client.DragEnterHandler;
 import com.google.gwt.event.dom.client.DragEvent;
+import com.google.gwt.event.dom.client.DragHandler;
 import com.google.gwt.event.dom.client.DragLeaveEvent;
 import com.google.gwt.event.dom.client.DragLeaveHandler;
-import com.google.gwt.event.dom.client.DragHandler;
 import com.google.gwt.event.dom.client.DragOverEvent;
 import com.google.gwt.event.dom.client.DragOverHandler;
 import com.google.gwt.event.dom.client.DragStartEvent;
@@ -63,6 +64,84 @@
 @SuppressWarnings("deprecation")
 public abstract class HTMLTable extends Panel implements  
SourcesTableEvents,

 HasAllDragAndDropHandlers, HasClickHandlers, HasDoubleClickHandlers {
+
+  public interface HTMLTableImpl {
+
+public Element getRow(Element elem, int row);
+
+public int getDOMCellCount(Element tableBody, int row);
+
+public int getDOMRowCount(Element elem);
+
+public void addCells(Element table, int row, int num);
+
+public Element getCellElement(Element table, int row, int col);
+
+  }
+
+  public static class HTMLTableStandardImpl implements HTMLTableImpl {
+
+@Override
+public native Element getRow(Element elem, int row) /*-{
+  return elem.rows[row];
+}-*/;
+
+@Override
+public native int getDOMCellCount(Element tableBody, int row) /*-{
+  return tableBody.rows[row].cells.length;
+}-*/;
+
+@Override
+public native int getDOMRowCount(Element elem) /*-{
+  return elem.rows.length;
+}-*/;
+
+@Override
+public native void addCells(Element table, int row, int num) /*-{
+  var rowElem = table.rows[row];
+  for(var i = 0; i < num; i++){
+var cell = $doc.createElement("td");
+

[gwt-contrib] Change in gwt[master]: Change DOM access in HTMLTable for IE

[Daniel Kurka]

Hello Leeroy Jenkins,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3212

to look at the new patch set (#2).

Change subject: Change DOM access in HTMLTable for IE
..

Change DOM access in HTMLTable for IE

using table.rows or table.rows[i].cells
causes memory leaks in IE

Added two different implementations
to access table rows and cells. One for
IE and one for the rest

fixes issue 6938

Change-Id: I5789589a307f457a1295b9ed72111ad4c040fa97
Review-Link: https://gwt-review.googlesource.com/#/c/3212/
---
A user/src/com/google/gwt/user/HTMLTable.gwt.xml
M user/src/com/google/gwt/user/User.gwt.xml
M user/src/com/google/gwt/user/client/ui/FlexTable.java
M user/src/com/google/gwt/user/client/ui/HTMLTable.java
4 files changed, 144 insertions(+), 23 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3212
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5789589a307f457a1295b9ed72111ad4c040fa97
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [gwt-contrib] Re: widget interfaces

[Daniel Kurka]

Hi Stephen,

I actually don't want to complicate the whole thing by throwing another
thing into the discussion, so feel free to tell me off, but here I go:

If we construct these interfaces along the lines of todays widgets how
would one add other things along them, like touch support?

Note: there is a different between a click and a touchstart, no touchmove
and touchend.

In mgwt we unify those situations as a TapEvent, but I am not sure if we
want to introduce something like this into GWT proper yet.
I am just a little worried that it might be very hard to fit a new widget
concept under these interfaces, but maybe we can plan ahead or not bother
at all.
Just wanted to bring up my concerns.

Other than that I am very much in favor of adding these to GWT proper since
I found myself rewriting those a couple of times.

-Daniel





On Thu, Jun 6, 2013 at 7:32 AM, Stephen Haberman
wrote:

>
> > Just for the sake of correctness;
> > You can still have similar stubs like you have today based on
> > gwt-mockito (if you don't like mockito's 'expect' style).
>
> Ah, sorry, my fault for not looking in to it more. Thanks for the
> correction.
>
> - Stephen
>
> --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors
> ---
> You received this message because you are subscribed to the Google Groups
> "GWT Contributors" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
>


-- 
Google Germany GmbH
*Dienerstr. 12*
*80331 München*

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Katherine Stephens

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [gwt-contrib] serializing final fields

[Daniel Kurka]

I am very much in favor of moving things forward with breaking changes as
long as we can see most of the damage up front.

Let me check internally if we can find out if Johns concerns are valid so
we might be able to implement this much simpler.


On Thu, Jun 6, 2013 at 9:05 AM, David  wrote:

> Hi,
>
> If you ask me, not serializing the final field was more a bug than a
> feature. (I know, GWT RPC is not the same as Java serialization)
>
> Do I need to enable something to get warnings on final fields not being
> serialized in 2.5.1 or is that standard behaviour.
>
> I am a very active user of the final keyword since it allow my IDE and
> Java compiler to warn me when I forget to initialize it. So I am a bit
> suprised that I did not see any warnings yet.
>
> David
>
> On Thu, Jun 6, 2013 at 7:36 AM, Stephen Haberman  > wrote:
>
>>
>> > Does having the flag really make it that much more complicated?
>>
>> It would not seem like it, but yes. :-)
>>
>> Specifically passing the context down through the layers to the right
>> spot to say "do I serialize final fields?" took a bit--one of the first
>> patches that went by used a static field to avoid a lot of method
>> signatures, but it assumed only one GWT module/setting running at a
>> time.
>>
>> It was also complicated by having to play nicely with the current "warn
>> on finalize field" flag.
>>
>> Both of these are trivial in the big scheme of GWT-RPC, but every
>> little simplification helps.
>>
>> - Stephen
>>
>> --
>> http://groups.google.com/group/Google-Web-Toolkit-Contributors
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "GWT Contributors" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.
>>
>>
>>
>  --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors
> ---
> You received this message because you are subscribed to the Google Groups
> "GWT Contributors" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
>



-- 
Google Germany GmbH
*Dienerstr. 12*
*80331 München*

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Katherine Stephens

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Wrong JavaDoc for MouseWheelEvent.getDeltaY()

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Wrong JavaDoc for MouseWheelEvent.getDeltaY()
..


Patch Set 1: Code-Review+2

--
To view, visit https://gwt-review.googlesource.com/3187
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I445111ab363a89aafb0f23a72de1bdc4971bae1c
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Wrong JavaDoc for MouseWheelEvent.getDeltaY()

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Wrong JavaDoc for MouseWheelEvent.getDeltaY()
..


Patch Set 1:

seems like leeroy is a sleep again

--
To view, visit https://gwt-review.googlesource.com/3187
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I445111ab363a89aafb0f23a72de1bdc4971bae1c
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Remove unused, package-private FastStringMap.

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Remove unused, package-private FastStringMap.
..


Patch Set 1: Code-Review+1

--
To view, visit https://gwt-review.googlesource.com/3280
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8dd9f897a044ba53be5fc74fabb40a382b9ef119
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Stephen Haberman 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Add interfaces for widgets.

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Add interfaces for widgets.
..


Patch Set 1:

(4 comments)

just a few nits so far


File user/src/com/google/gwt/dom/client/Element.java
Line 785:
nit: trailing spaces



File user/src/com/google/gwt/user/client/Element.java
Line 38:
nit: trailing spaces



File user/src/com/google/gwt/user/client/ui/HasWidgets.java
Line 34:
nit: trailing spaces



File user/src/com/google/gwt/user/client/ui/IsWidget2.java
Line 14:  *
nit: trailing space


--
To view, visit https://gwt-review.googlesource.com/3231
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd17162d37e367720829bcdaf9a350e446c833b9
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Stephen Haberman 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: GWT RPC not working if GWT application is started from file ...

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: GWT RPC not working if GWT application is started from file  
system ISSUE 7436

..


Patch Set 5:

Hi Thomas,

the change is not about @RemoteServiceRelativePath. This is about making  
GWT RPC work when loaded from file system.


Because moduleBaseURL is final in RemoteServiceProxy there is no way of  
setting this at runtime today, it alway defaults to moduleBase and this is  
somewhat file:// for phonegap applications. (same for chrome extension)


While GWT RPC is really bad for applications where you are not in control  
of the update cycle it is still widely used with gwt-phonegap and there we  
use JSNI trickery to make it work. I would much rather see a straight  
forward way directly in GWT.


--
To view, visit https://gwt-review.googlesource.com/1652
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I294b53c705ff82e572cd4b17c60a0e89c1b294de
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Add support for 'ImageResource' to @url substitution in css....

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Add support for 'ImageResource' to @url substitution in  
css. Only 'DataResource' used to be supported.

..


Patch Set 1: Code-Review+1

--
To view, visit https://gwt-review.googlesource.com/3290
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6ae9fe0ace59eb682a77a761fe252bf46cafa9f
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Emmanuel Pellereau 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Enable EntityProxyId as an RequestFactory service method arg...

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Enable EntityProxyId as an RequestFactory service method  
argument.

..


Patch Set 1:

(5 comments)


File  
user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java

Line 1496:   public void onSuccess(SimpleFooProxy foo) {
nit: trailing whitespace


Line 1508:
nit:trailing whitespace


Line 1523:
nit:trailing whitespace



File  
user/test/com/google/web/bindery/requestfactory/shared/SimpleFooRequest.java

Line 127:
nit:trailing whitespace


Line 129:
nit:trailing whitespace


--
To view, visit https://gwt-review.googlesource.com/3091
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0427c3c6614abef71cd0dcc08acdff4d28bc9a5
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Sam Hough 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Add show relative to Element in PopupPanel

[Daniel Kurka]

Daniel Kurka has uploaded a new change for review.

  https://gwt-review.googlesource.com/3340


Change subject: Add show relative to Element in PopupPanel
..

Add show relative to Element in PopupPanel

fixes issue 6006

Change-Id: I8991b1cb1c3ec4ecabd299ee4c5bf4e5992e4b5e
---
M user/src/com/google/gwt/user/client/ui/PopupPanel.java
1 file changed, 17 insertions(+), 3 deletions(-)



diff --git a/user/src/com/google/gwt/user/client/ui/PopupPanel.java  
b/user/src/com/google/gwt/user/client/ui/PopupPanel.java

index ddcad33..a4a9d36 100644
--- a/user/src/com/google/gwt/user/client/ui/PopupPanel.java
+++ b/user/src/com/google/gwt/user/client/ui/PopupPanel.java
@@ -36,12 +36,12 @@
 import com.google.gwt.i18n.client.LocaleInfo;
 import com.google.gwt.user.client.DOM;
 import com.google.gwt.user.client.Event;
+import com.google.gwt.user.client.Event.NativePreviewEvent;
+import com.google.gwt.user.client.Event.NativePreviewHandler;
 import com.google.gwt.user.client.EventPreview;
 import com.google.gwt.user.client.History;
 import com.google.gwt.user.client.Timer;
 import com.google.gwt.user.client.Window;
-import com.google.gwt.user.client.Event.NativePreviewEvent;
-import com.google.gwt.user.client.Event.NativePreviewHandler;
 import com.google.gwt.user.client.ui.impl.PopupImpl;

 import java.util.ArrayList;
@@ -1029,6 +1029,20 @@
* @param target the target to show the popup below
*/
   public final void showRelativeTo(final UIObject target) {
+showRelativeTo(target.getElement());
+  }
+
+  /**
+   * Normally, the popup is positioned directly below the relative target,  
with
+   * its left edge aligned with the left edge of the target. Depending on  
the

+   * width and height of the popup and the distance from the target to the
+   * bottom and right edges of the window, the popup may be displayed  
directly
+   * above the target, and/or its right edge may be aligned with the right  
edge

+   * of the target.
+   *
+   * @param target the target to show the popup below
+   */
+  public final void showRelativeTo(final Element target) {
 // Set the position of the popup right before it is shown.
 setPopupPositionAndShow(new PositionCallback() {
   public void setPosition(int offsetWidth, int offsetHeight) {
@@ -1191,7 +1205,7 @@
* @param offsetWidth the drop down's offset width
* @param offsetHeight the drop down's offset height
*/
-  private void position(final UIObject relativeObject, int offsetWidth,
+  private void position(final Element relativeObject, int offsetWidth,
   int offsetHeight) {
 // Calculate left position for the popup. The computation for
 // the left position is bidi-sensitive.

--
To view, visit https://gwt-review.googlesource.com/3340
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8991b1cb1c3ec4ecabd299ee4c5bf4e5992e4b5e
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

[Daniel Kurka]

Hello John A. Tamplin, Thomas Broyer, Leeroy Jenkins,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3180

to look at the new patch set (#10).

Change subject: adding compare for several number types  -Byte.compare  
-Short.compare -Integer.compare -Long.compare -Float.compare  (Double  
already exists)  fixes issue 7998

..

adding compare for several number types

-Byte.compare
-Short.compare
-Integer.compare
-Long.compare
-Float.compare

(Double already exists)

fixes issue 7998

Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Review-Link: https://gwt-review.googlesource.com/#/c/3180/
---
M user/super/com/google/gwt/emul/java/lang/Byte.java
M user/super/com/google/gwt/emul/java/lang/Double.java
M user/super/com/google/gwt/emul/java/lang/Float.java
M user/super/com/google/gwt/emul/java/lang/Integer.java
M user/super/com/google/gwt/emul/java/lang/Long.java
M user/super/com/google/gwt/emul/java/lang/Short.java
M user/test/com/google/gwt/emultest/java/lang/ByteTest.java
M user/test/com/google/gwt/emultest/java/lang/FloatTest.java
M user/test/com/google/gwt/emultest/java/lang/IntegerTest.java
M user/test/com/google/gwt/emultest/java/lang/LongTest.java
M user/test/com/google/gwt/emultest/java/lang/ShortTest.java
11 files changed, 91 insertions(+), 43 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 10
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: adding compare for several number types  -Byte.compare  
-Short.compare -Integer.compare -Long.compare -Float.compare  (Double  
already exists)  fixes issue 7998

..


Patch Set 9:

(6 comments)


File user/super/com/google/gwt/emul/java/lang/Byte.java
Line 37: return Integer.compare(x, y);
Done



File user/super/com/google/gwt/emul/java/lang/Float.java
Line 37: if (isNaN(x)) {
changed order



File user/super/com/google/gwt/emul/java/lang/Integer.java
Line 61: return signum(x - y);
see:  
https://code.google.com/p/google-web-toolkit/issues/detail?id=8185&thanks=8185




File user/super/com/google/gwt/emul/java/lang/Short.java
Line 37: return Integer.compare(x, y);
Done



File user/test/com/google/gwt/emultest/java/lang/FloatTest.java
Line 81:   }
see:  
https://code.google.com/p/google-web-toolkit/issues/detail?id=8185&thanks=8185




File user/test/com/google/gwt/emultest/java/lang/IntegerTest.java
Line 120: assertEquals(0, Integer.compare(1, 1));
Let's deal with the corner cases in another CL:  
https://code.google.com/p/google-web-toolkit/issues/detail?id=8185



--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 9
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

[Daniel Kurka]

Hello John A. Tamplin, Thomas Broyer, Leeroy Jenkins,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3180

to look at the new patch set (#11).

Change subject: adding compare for several number types  -Byte.compare  
-Short.compare -Integer.compare -Long.compare -Float.compare  (Double  
already exists)  fixes issue 7998

..

adding compare for several number types

-Byte.compare
-Short.compare
-Integer.compare
-Long.compare
-Float.compare

(Double already exists)

fixes issue 7998

Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Review-Link: https://gwt-review.googlesource.com/#/c/3180/
---
M user/super/com/google/gwt/emul/java/lang/Byte.java
M user/super/com/google/gwt/emul/java/lang/Float.java
M user/super/com/google/gwt/emul/java/lang/Integer.java
M user/super/com/google/gwt/emul/java/lang/Long.java
M user/super/com/google/gwt/emul/java/lang/Short.java
M user/test/com/google/gwt/emultest/java/lang/ByteTest.java
M user/test/com/google/gwt/emultest/java/lang/FloatTest.java
M user/test/com/google/gwt/emultest/java/lang/IntegerTest.java
M user/test/com/google/gwt/emultest/java/lang/LongTest.java
M user/test/com/google/gwt/emultest/java/lang/ShortTest.java
10 files changed, 83 insertions(+), 35 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 11
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [gwt-contrib] Re: ValueListBox should implement HasEnabled (6112) (issue1832803)

[Daniel Kurka]

Hi Patrick,

foo is often used as a place holder, so something like:
git add foo
should mean:
git add my_cool_edited_file

-Daniel


On Mon, Jun 10, 2013 at 3:35 PM, Patrick Tucker  wrote:

> From the gwtproject "Making GWT Better" page section "Gerrit Setup" step 3:
>
>> Make a change and commit it locally using git (e.g., edit a file foo and
>> then run ?git commit -m ?my first change? foo?).
>
>
> What does foo represent?
>
> Thanks,
> Pat
>
>
> On Mon, May 20, 2013 at 3:18 PM, Thomas Broyer  wrote:
>
>> Should be http://gwtproject.org/makinggwtbetter.html
>>
>> On Sunday, May 19, 2013 10:00:01 PM UTC+2, Patrick Tucker wrote:
>>>
>>> I started from scratch and was able to get it mostly working.  Is there
>>> a doc that explains the right way to submit a patch?
>>>
>>> On Friday, May 17, 2013 1:19:33 PM UTC-4, Patrick Tucker wrote:

 Windows 7 Pro

 On Friday, May 17, 2013 12:51:47 PM UTC-4, Matthew Dempsky wrote:

> On Fri, May 17, 2013 at 9:45 AM, Patrick Tucker wrote:
>
>> I'm not sure where to find the file that you are referring to, it is
>> not in my eclipse install folder?
>>
>
> John was referring to the "eclipse" directory in the GWT source code
> tree: 
> https://gwt.**googlesource.com/gwt/+/master/**eclipse/README.txt
>
> I was playing with the settings and tried removing one of the source
>> folders so that I could add it back and got an error saying the file 
>> system
>> is read only.  Any idea why it would do that?
>>
>
> Not sure, that sounds odd to me.  Just out of curiosity, what OS are
> you using?
>
>
> When you prepared the patch from Rietveld, did you checkout the code
> from Subversion or use the 2.5.1 SDK release zip file?  If you were 
> already
> using Subversion, I would expect using Git shouldn't be any different to
> setup in Eclipse since the source tree should be the same.
>

>  --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors
> ---
> You received this message because you are subscribed to the Google Groups
> "GWT Contributors" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
>



-- 
Google Germany GmbH
*Dienerstr. 12*
*80331 München*

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Katherine Stephens

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [gwt-contrib] Work to do for bug 3042

[Daniel Kurka]

Hi Adolfo,

this is not my issue and I am not solely responsible for it.

We should see wait and see if anybody opposes to adding this to GWT, before
you actually start working on it, so that your time will not be wasted.
On the other hand you can already setup your IDE and tools to be able to
start. James pointed out the resources. If there is anything wrong /
unclear in those resources please let us know. Or you could even send a
patch for the homepage to be updated.

- Daniel


On Mon, Jun 10, 2013 at 8:07 PM, Adolfo Panizo Touzon <
adolfo.pan...@gmail.com> wrote:

> Thanks James!
>
> But I have done those steps yet (*indeed I read in that link I should ask
> here first :D*) . When I said the necessary work I meant the steps for
> develop the RichTextArea according to the GWT steering committee (for this
> issue I think Daniel is responsible) so I need to wait for his opinion.
>
> Thanks anyway for your quick response.
>
> Adolfo.
>
>
> On Mon, Jun 10, 2013 at 1:02 PM, James Horsley wrote:
>
>> Adolfo,
>>
>> To get the source checked out and compiling follow:
>> http://www.gwtproject.org/makinggwtbetter.html#workingoncode
>>
>> To submit the patch use:
>> http://www.gwtproject.org/makinggwtbetter.html#submittingpatches
>>
>> I recently had to move an old svn patch into gerrit and the following
>> gave a very simple way to apply it
>> http://stackoverflow.com/questions/659467/how-to-apply-svn-diff-to-gitjust 
>> remember to clean up any leftover .orij and .rej files.
>>
>> Cheers,
>> James
>>
>>
>> On 10 June 2013 10:01, Adolfo Panizo  wrote:
>>
>>> Hi,
>>>
>>> as I wrote in the 
>>> issue,
>>> I am able to do the necessary work for solving it.  So, can you guide me
>>> about the steps that I need to follow in order to create a patch properly?
>>>
>>> Would you like to reuse some code of the old 
>>> patch
>>> ?
>>>
>>> I am going to contact the creator of it because maybe he continues
>>> interested on fixing the issue and rebase the patch with the last code.
>>>
>>> Of course if there are other issues related to RichTextArea I can solve
>>> as well.
>>>
>>> Thanks in advance,
>>>
>>> Adolfo.
>>>
>>>
>>>  --
>>> http://groups.google.com/group/Google-Web-Toolkit-Contributors
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "GWT Contributors" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com
>>> .
>>> For more options, visit https://groups.google.com/groups/opt_out.
>>>
>>>
>>>
>>
>>  --
>> http://groups.google.com/group/Google-Web-Toolkit-Contributors
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "GWT Contributors" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.
>>
>>
>>
>
>
>
> --
> El precio es lo que pagas. El valor es lo que recibes.
> Warren Buffet
>
> --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors
> ---
> You received this message because you are subscribed to the Google Groups
> "GWT Contributors" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
>



-- 
Google Germany GmbH
*Dienerstr. 12*
*80331 München*

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Katherine Stephens

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Fix for 8188 (http://code.google.com/p/google-web-toolkit/is...

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Fix for 8188  
(http://code.google.com/p/google-web-toolkit/issues/detail?id=8188)

..


Patch Set 1: Code-Review+1

LGTM to me, but please address Thomas comments.

--
To view, visit https://gwt-review.googlesource.com/3380
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c25c0e486e02a3b5ed1a8804d5276cebc0877c6
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Denis Anisimov 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Add show relative to Element in PopupPanel

[Daniel Kurka]

Hello Leeroy Jenkins, Thomas Broyer,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3340

to look at the new patch set (#2).

Change subject: Add show relative to Element in PopupPanel
..

Add show relative to Element in PopupPanel

fixes issue 6006

Change-Id: I8991b1cb1c3ec4ecabd299ee4c5bf4e5992e4b5e
---
M tools/api-checker/config/gwt25_26userApi.conf
M user/src/com/google/gwt/user/client/ui/PopupPanel.java
2 files changed, 20 insertions(+), 3 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3340
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8991b1cb1c3ec4ecabd299ee4c5bf4e5992e4b5e
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Adds Timer#isRunning().

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Adds Timer#isRunning().
..


Patch Set 2:

(3 comments)


File user/src/com/google/gwt/user/client/Timer.java
Line 110:   throw new IllegalArgumentException("must be non-negative");
can we unify the IllegalArgumentExceptions in schedule and  
scheduleRepeating as well?


< 0 vs. <=0


Line 151:
Shouldn't timer.isRunning be true if the timer code is executing. How about  
we defer update until after run has been called?


Maybe even add a test for this



File user/test/com/google/gwt/user/client/TimerTest.java
Line 86:   // Issue  
https://code.google.com/p/google-web-toolkit/issues/detail?id=8101

I am not sure if this sufficiently tests fur bug 8101.

To me this reads like IE must have added the timer to the event loop  
already, so I think we actually need a busy wait here to test for that



--
To view, visit https://gwt-review.googlesource.com/3321
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0133c64de75d5d95cff863c5ab950d474dda0c56
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: adding compare for several number types  -Byte.compare  
-Short.compare -Integer.compare -Long.compare -Float.compare  (Double  
already exists)  fixes issue 7998

..


Patch Set 11:

Changing the order in Float/Double compare will lead to an unreachable code  
compiler warning.


This must be the reason why Double was implemented the way it was.

--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 11
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Change DOM access in HTMLTable for IE

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Change DOM access in HTMLTable for IE
..


Patch Set 2:

Going forward this would be the right approach. Not sure though how we make  
those permutation dependent.



I would not like to introduce calling children for other browsers, since I  
don't really know which other nodes might be included outside of IE. I  
would suggest waiting for the new widget concept for GWT 3.0 and then go  
through the widgets and update them (and not putting that much more effort  
into them right now).


--
To view, visit https://gwt-review.googlesource.com/3212
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5789589a307f457a1295b9ed72111ad4c040fa97
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Add methods to HasTreeItems

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Add methods to HasTreeItems
..


Patch Set 2:

I am very much in favor of deprecation, but I think we need some time to  
get there.


We can include these changes in the mean time. I am wondering if we are  
going to see internal breakage due to the new methods.


--
To view, visit https://gwt-review.googlesource.com/2520
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a1a20be6dba36f3978d08178b92269b2736f157
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Adds Timer#isRunning().

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Adds Timer#isRunning().
..


Patch Set 2:

(1 comment)


File user/src/com/google/gwt/user/client/Timer.java
Line 151:
lets add a note in the javadoc of is running making this clear.


--
To view, visit https://gwt-review.googlesource.com/3321
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0133c64de75d5d95cff863c5ab950d474dda0c56
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: adding compare for several number types

[Daniel Kurka]

Hello John A. Tamplin, Thomas Broyer, Leeroy Jenkins,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3180

to look at the new patch set (#12).

Change subject: adding compare for several number types
..

adding compare for several number types

-Byte.compare
-Short.compare
-Integer.compare
-Long.compare
-Float.compare

(Double already exists)

fixes issue 7998

Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Review-Link: https://gwt-review.googlesource.com/#/c/3180/
---
M user/super/com/google/gwt/emul/java/lang/Byte.java
M user/super/com/google/gwt/emul/java/lang/Double.java
M user/super/com/google/gwt/emul/java/lang/Float.java
M user/super/com/google/gwt/emul/java/lang/Integer.java
M user/super/com/google/gwt/emul/java/lang/Long.java
M user/super/com/google/gwt/emul/java/lang/Short.java
M user/test/com/google/gwt/emultest/java/lang/ByteTest.java
M user/test/com/google/gwt/emultest/java/lang/FloatTest.java
M user/test/com/google/gwt/emultest/java/lang/IntegerTest.java
M user/test/com/google/gwt/emultest/java/lang/LongTest.java
M user/test/com/google/gwt/emultest/java/lang/ShortTest.java
11 files changed, 84 insertions(+), 50 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 12
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: adding compare for several number types

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: adding compare for several number types
..


Patch Set 12:

Updated Patch to deal with normal numbers first, but I don't think this  
ends up being more readable. But I am fine either way.


Float.compare also uses Double.compare to avoid redundancy.

--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 12
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Add show relative to Element in PopupPanel

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Add show relative to Element in PopupPanel
..


Patch Set 2:

(2 comments)


File tools/api-checker/config/gwt25_26userApi.conf
Line 176: #adding method to PopupPanel to show relative to an Element
Done


Line 177:  
com.google.gwt.user.client.ui.PopupPanel::showRelativeTo(Lcom/google/gwt/dom/client/Element;)  
OVERLOADED_METHOD_CALL

Done


--
To view, visit https://gwt-review.googlesource.com/3340
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8991b1cb1c3ec4ecabd299ee4c5bf4e5992e4b5e
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Add show relative to Element in PopupPanel

[Daniel Kurka]

Hello Leeroy Jenkins, Thomas Broyer,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3340

to look at the new patch set (#3).

Change subject: Add show relative to Element in PopupPanel
..

Add show relative to Element in PopupPanel

fixes issue 6006

Change-Id: I8991b1cb1c3ec4ecabd299ee4c5bf4e5992e4b5e
---
M tools/api-checker/config/gwt25_26userApi.conf
M user/src/com/google/gwt/user/client/ui/PopupPanel.java
2 files changed, 20 insertions(+), 3 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3340
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8991b1cb1c3ec4ecabd299ee4c5bf4e5992e4b5e
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Change DOM access in HTMLTable for IE

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Change DOM access in HTMLTable for IE
..


Patch Set 2:

(2 comments)


File user/src/com/google/gwt/user/HTMLTable.gwt.xml
Line 2: 

Done


Line 23:   
Done


--
To view, visit https://gwt-review.googlesource.com/3212
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5789589a307f457a1295b9ed72111ad4c040fa97
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Change DOM access in HTMLTable for IE

[Daniel Kurka]

Hello Leeroy Jenkins,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3212

to look at the new patch set (#3).

Change subject: Change DOM access in HTMLTable for IE
..

Change DOM access in HTMLTable for IE

using table.rows or table.rows[i].cells
causes memory leaks in IE

Added two different implementations
to access table rows and cells. One for
IE and one for the rest

fixes issue 6938

Change-Id: I5789589a307f457a1295b9ed72111ad4c040fa97
Review-Link: https://gwt-review.googlesource.com/#/c/3212/
---
A user/src/com/google/gwt/user/HTMLTable.gwt.xml
M user/src/com/google/gwt/user/User.gwt.xml
M user/src/com/google/gwt/user/client/ui/FlexTable.java
M user/src/com/google/gwt/user/client/ui/HTMLTable.java
4 files changed, 144 insertions(+), 23 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3212
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5789589a307f457a1295b9ed72111ad4c040fa97
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Change DOM access in HTMLTable for IE

[Daniel Kurka]

Hello Thomas Broyer, Leeroy Jenkins,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3212

to look at the new patch set (#4).

Change subject: Change DOM access in HTMLTable for IE
..

Change DOM access in HTMLTable for IE

using table.rows or table.rows[i].cells
causes memory leaks in IE

Added two different implementations
to access table rows and cells. One for
IE and one for the rest

fixes issue 6938

Change-Id: I5789589a307f457a1295b9ed72111ad4c040fa97
Review-Link: https://gwt-review.googlesource.com/#/c/3212/
---
A user/src/com/google/gwt/user/HTMLTable.gwt.xml
M user/src/com/google/gwt/user/User.gwt.xml
M user/src/com/google/gwt/user/client/ui/FlexTable.java
M user/src/com/google/gwt/user/client/ui/HTMLTable.java
4 files changed, 144 insertions(+), 23 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3212
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5789589a307f457a1295b9ed72111ad4c040fa97
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Change DOM access in HTMLTable for IE

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Change DOM access in HTMLTable for IE
..


Patch Set 4:

I am about to test behavior on IE10 and see if it leaks as well. If it does  
not we can simply leave it as is and mark this as an IE quirk.


--
To view, visit https://gwt-review.googlesource.com/3212
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5789589a307f457a1295b9ed72111ad4c040fa97
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Change DOM access in HTMLTable for IE

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Change DOM access in HTMLTable for IE
..


Patch Set 4:

So IE10 leaks as well without the workaround.

Sending out a repro to MS, but I think we have to deal with that. I would  
like to implement this without any major changes in other parts of the SDK,  
but we might want to open a bug just to be sure that we are not leaking  
memory on other occasions as well.


--
To view, visit https://gwt-review.googlesource.com/3212
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5789589a307f457a1295b9ed72111ad4c040fa97
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Add drawImage(VideoElement, …) overloads

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Add drawImage(VideoElement, …) overloads
..


Patch Set 1: Code-Review+2

--
To view, visit https://gwt-review.googlesource.com/3421
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I31012c21053d0e8219b731ff547ecb9c7364854a
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Thomas Broyer 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Change DOM access in HTMLTable for IE

[Daniel Kurka]

Hello Thomas Broyer, Leeroy Jenkins,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3212

to look at the new patch set (#5).

Change subject: Change DOM access in HTMLTable for IE
..

Change DOM access in HTMLTable for IE

using table.rows or table.rows[i].cells
causes memory leaks in IE

Added two different implementations
to access table rows and cells. One for
IE and one for the rest

fixes issue 6938

Change-Id: I5789589a307f457a1295b9ed72111ad4c040fa97
Review-Link: https://gwt-review.googlesource.com/#/c/3212/
---
A user/src/com/google/gwt/user/HTMLTable.gwt.xml
M user/src/com/google/gwt/user/User.gwt.xml
M user/src/com/google/gwt/user/client/ui/FlexTable.java
M user/src/com/google/gwt/user/client/ui/HTMLTable.java
4 files changed, 144 insertions(+), 23 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3212
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5789589a307f457a1295b9ed72111ad4c040fa97
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Change DOM access in HTMLTable for IE

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Change DOM access in HTMLTable for IE
..


Patch Set 4:

(1 comment)


File user/src/com/google/gwt/user/HTMLTable.gwt.xml
Line 15: 

Done


--
To view, visit https://gwt-review.googlesource.com/3212
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5789589a307f457a1295b9ed72111ad4c040fa97
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Adding a DOM clear method to RootPanel

[Daniel Kurka]

Hello Matthew Dempsky, Leeroy Jenkins, Brian Slesinsky,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/2512

to look at the new patch set (#5).

Change subject: Adding a DOM clear method to RootPanel
..

Adding a DOM clear method to RootPanel

By calling rootPanel.clear(true) the user can clear
widgets AND DOM elements located under this RootPanel.

fixes Issue 516

Change-Id: I712989276142460b91514713eaf8d8f74dbecd7b
Review-Link: https://gwt-review.googlesource.com/#/c/2512/
---
M user/src/com/google/gwt/user/client/ui/RootPanel.java
M user/test/com/google/gwt/user/client/ui/RootPanelTest.java
2 files changed, 91 insertions(+), 0 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/2512
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I712989276142460b91514713eaf8d8f74dbecd7b
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Adding a DOM clear method to RootPanel

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Adding a DOM clear method to RootPanel
..


Patch Set 4:

(1 comment)


File user/src/com/google/gwt/user/client/ui/RootPanel.java
Line 311:* {@code getElement().appendChild(...)}.
Done


--
To view, visit https://gwt-review.googlesource.com/2512
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I712989276142460b91514713eaf8d8f74dbecd7b
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Adding a DOM clear method to RootPanel

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Adding a DOM clear method to RootPanel
..


Patch Set 5:

I would like to see this get landed or abandoned. I think having it would  
have a small value, but if Brian feels strongly I could also drop it.


At the very least we should update javadoc and all removeChildren to  
dom.Element


@Hilbrand

A clear(true) will remove the history frame. But it is only used for IE6  
anyway and we are phasing that out.


--
To view, visit https://gwt-review.googlesource.com/2512
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I712989276142460b91514713eaf8d8f74dbecd7b
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Adding a DOM clear method to RootPanel

[Daniel Kurka]

Hello Matthew Dempsky, Leeroy Jenkins, Brian Slesinsky,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/2512

to look at the new patch set (#6).

Change subject: Adding a DOM clear method to RootPanel
..

Adding a DOM clear method to RootPanel

By calling rootPanel.clear(true) the user can clear
widgets AND DOM elements located under this RootPanel.

fixes Issue 516

Change-Id: I712989276142460b91514713eaf8d8f74dbecd7b
Review-Link: https://gwt-review.googlesource.com/#/c/2512/
---
M user/src/com/google/gwt/user/client/ui/RootPanel.java
M user/test/com/google/gwt/user/client/ui/RootPanelTest.java
2 files changed, 88 insertions(+), 0 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/2512
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I712989276142460b91514713eaf8d8f74dbecd7b
Gerrit-PatchSet: 6
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Adding a DOM clear method to RootPanel

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Adding a DOM clear method to RootPanel
..


Patch Set 6:

With that rationale we should name it clearWidgetsAndDom?

--
To view, visit https://gwt-review.googlesource.com/2512
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I712989276142460b91514713eaf8d8f74dbecd7b
Gerrit-PatchSet: 6
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: adding compare for several number types

[Daniel Kurka]

Hello John A. Tamplin, Thomas Broyer, Leeroy Jenkins,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3180

to look at the new patch set (#13).

Change subject: adding compare for several number types
..

adding compare for several number types

-Byte.compare
-Short.compare
-Integer.compare
-Long.compare
-Float.compare

(Double already exists)

fixes issue 7998

Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Review-Link: https://gwt-review.googlesource.com/#/c/3180/
---
M user/super/com/google/gwt/emul/java/lang/Byte.java
M user/super/com/google/gwt/emul/java/lang/Double.java
M user/super/com/google/gwt/emul/java/lang/Float.java
M user/super/com/google/gwt/emul/java/lang/Integer.java
M user/super/com/google/gwt/emul/java/lang/Long.java
M user/super/com/google/gwt/emul/java/lang/Short.java
M user/test/com/google/gwt/emultest/java/lang/ByteTest.java
M user/test/com/google/gwt/emultest/java/lang/FloatTest.java
M user/test/com/google/gwt/emultest/java/lang/IntegerTest.java
M user/test/com/google/gwt/emultest/java/lang/LongTest.java
M user/test/com/google/gwt/emultest/java/lang/ShortTest.java
11 files changed, 86 insertions(+), 52 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 13
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: adding compare for several number types

[Daniel Kurka]

Hello John A. Tamplin, Thomas Broyer, Leeroy Jenkins,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3180

to look at the new patch set (#14).

Change subject: adding compare for several number types
..

adding compare for several number types

-Byte.compare
-Short.compare
-Integer.compare
-Long.compare
-Float.compare

(Double already exists)

fixes issue 7998

Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Review-Link: https://gwt-review.googlesource.com/#/c/3180/
---
M user/super/com/google/gwt/emul/java/lang/Byte.java
M user/super/com/google/gwt/emul/java/lang/Double.java
M user/super/com/google/gwt/emul/java/lang/Float.java
M user/super/com/google/gwt/emul/java/lang/Integer.java
M user/super/com/google/gwt/emul/java/lang/Long.java
M user/super/com/google/gwt/emul/java/lang/Short.java
M user/test/com/google/gwt/emultest/java/lang/ByteTest.java
M user/test/com/google/gwt/emultest/java/lang/FloatTest.java
M user/test/com/google/gwt/emultest/java/lang/IntegerTest.java
M user/test/com/google/gwt/emultest/java/lang/LongTest.java
M user/test/com/google/gwt/emultest/java/lang/ShortTest.java
11 files changed, 85 insertions(+), 51 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 14
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: John A. Tamplin 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: adding compare for several number types

[Daniel Kurka]

Daniel Kurka has submitted this change and it was merged.

Change subject: adding compare for several number types
..


adding compare for several number types

-Byte.compare
-Short.compare
-Integer.compare
-Long.compare
-Float.compare

(Double already exists)

fixes issue 7998

Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Review-Link: https://gwt-review.googlesource.com/#/c/3180/
---
M user/super/com/google/gwt/emul/java/lang/Byte.java
M user/super/com/google/gwt/emul/java/lang/Double.java
M user/super/com/google/gwt/emul/java/lang/Float.java
M user/super/com/google/gwt/emul/java/lang/Integer.java
M user/super/com/google/gwt/emul/java/lang/Long.java
M user/super/com/google/gwt/emul/java/lang/Short.java
M user/test/com/google/gwt/emultest/java/lang/ByteTest.java
M user/test/com/google/gwt/emultest/java/lang/FloatTest.java
M user/test/com/google/gwt/emultest/java/lang/IntegerTest.java
M user/test/com/google/gwt/emultest/java/lang/LongTest.java
M user/test/com/google/gwt/emultest/java/lang/ShortTest.java
11 files changed, 85 insertions(+), 51 deletions(-)

Approvals:
  Leeroy Jenkins: Verified
  Goktug Gokdogan: Looks good to me, approved



diff --git a/user/super/com/google/gwt/emul/java/lang/Byte.java  
b/user/super/com/google/gwt/emul/java/lang/Byte.java

index 664589e..ec3e4d9 100644
--- a/user/super/com/google/gwt/emul/java/lang/Byte.java
+++ b/user/super/com/google/gwt/emul/java/lang/Byte.java
@@ -33,6 +33,10 @@
 private static Byte[] boxedValues = new Byte[256];
   }

+  public static int compare(byte x, byte y) {
+return x - y;
+  }
+
   public static Byte decode(String s) throws NumberFormatException {
 return Byte.valueOf((byte) __decodeAndValidateInt(s, MIN_VALUE,  
MAX_VALUE));

   }
@@ -93,13 +97,7 @@
   }

   public int compareTo(Byte b) {
-if (value < b.value) {
-  return -1;
-} else if (value > b.value) {
-  return 1;
-} else {
-  return 0;
-}
+return compare(value, b.value);
   }

   @Override
diff --git a/user/super/com/google/gwt/emul/java/lang/Double.java  
b/user/super/com/google/gwt/emul/java/lang/Double.java

index e32f9d2..74bdcd9 100644
--- a/user/super/com/google/gwt/emul/java/lang/Double.java
+++ b/user/super/com/google/gwt/emul/java/lang/Double.java
@@ -86,22 +86,24 @@
   };

   public static int compare(double x, double y) {
+if (x < y) {
+  return -1;
+}
+if (x > y) {
+  return 1;
+}
+if (x == y) {
+  return 0;
+}
+
 if (isNaN(x)) {
   if (isNaN(y)) {
 return 0;
   } else {
 return 1;
   }
-} else if (isNaN(y)) {
-  return -1;
-}
-
-if (x < y) {
-  return -1;
-} else if (x > y) {
-  return 1;
 } else {
-  return 0;
+  return -1;
 }
   }

diff --git a/user/super/com/google/gwt/emul/java/lang/Float.java  
b/user/super/com/google/gwt/emul/java/lang/Float.java

index fe4bc2b..84e2ef1 100644
--- a/user/super/com/google/gwt/emul/java/lang/Float.java
+++ b/user/super/com/google/gwt/emul/java/lang/Float.java
@@ -34,13 +34,7 @@
   private static final long POWER_32_INT = 4294967296L;

   public static int compare(float x, float y) {
-if (x < y) {
-  return -1;
-} else if (x > y) {
-  return 1;
-} else {
-  return 0;
-}
+return Double.compare(x, y);
   }

   public static int floatToIntBits(float value) {
@@ -187,13 +181,7 @@
   }

   public int compareTo(Float b) {
-if (value < b.value) {
-  return -1;
-} else if (value > b.value) {
-  return 1;
-} else {
-  return 0;
-}
+return compare(value, b.value);
   }

   @Override
diff --git a/user/super/com/google/gwt/emul/java/lang/Integer.java  
b/user/super/com/google/gwt/emul/java/lang/Integer.java

index 04e2b00..a0c2f6f 100644
--- a/user/super/com/google/gwt/emul/java/lang/Integer.java
+++ b/user/super/com/google/gwt/emul/java/lang/Integer.java
@@ -57,6 +57,10 @@
 return x & 0x003f;
   }

+  public static int compare(int x, int y) {
+return signum(x - y);
+  }
+
   public static Integer decode(String s) throws NumberFormatException {
 return Integer.valueOf((int) __decodeAndValidateInt(s, MIN_VALUE,  
MAX_VALUE));

   }
@@ -287,13 +291,7 @@
   }

   public int compareTo(Integer b) {
-if (value < b.value) {
-  return -1;
-} else if (value > b.value) {
-  return 1;
-} else {
-  return 0;
-}
+return compare(value, b.value);
   }

   @Override
diff --git a/user/super/com/google/gwt/emul/java/lang/Long.java  
b/user/super/com/google/gwt/emul/java/lang/Long.java

index c0b08d7..eaee9ec 100644
--- a/user/super/com/google/gwt/emul/java/lang/Long.java
+++ b/user/super/com/google/gwt/emul/java/lang/Long.java
@@ -58,6 +58,10 @@
 return Integer.bitCount(high) + Integer.bitCount(low);
   }

+  public static int compare(long x, long y) {
+return signum(x - y);
+  }

[gwt-contrib] Change in gwt[master]: Adding a DOM clear method to RootPanel

[Daniel Kurka]

Daniel Kurka has submitted this change and it was merged.

Change subject: Adding a DOM clear method to RootPanel
..


Adding a DOM clear method to RootPanel

By calling rootPanel.clear(true) the user can clear
widgets AND DOM elements located under this RootPanel.

fixes Issue 516

Change-Id: I712989276142460b91514713eaf8d8f74dbecd7b
Review-Link: https://gwt-review.googlesource.com/#/c/2512/
---
M user/src/com/google/gwt/user/client/ui/RootPanel.java
M user/test/com/google/gwt/user/client/ui/RootPanelTest.java
2 files changed, 88 insertions(+), 0 deletions(-)

Approvals:
  Leeroy Jenkins: Verified
  Brian Slesinsky: Looks good to me, approved



diff --git a/user/src/com/google/gwt/user/client/ui/RootPanel.java  
b/user/src/com/google/gwt/user/client/ui/RootPanel.java

index 8d22da0..c4929c6 100644
--- a/user/src/com/google/gwt/user/client/ui/RootPanel.java
+++ b/user/src/com/google/gwt/user/client/ui/RootPanel.java
@@ -300,4 +300,27 @@
 super(elem. cast());
 onAttach();
   }
+
+  /**
+   * Clears the rootPanel. If clearDom is true, then also remove any DOM
+   * elements that are not widgets.
+   *
+   * By default {@link #clear()} will only remove children that are GWT  
widgets.
+   * This method also provides the option to remove all children including  
the
+   * non-widget DOM elements that are directly added (e.g. elements added  
via

+   * {@code getElement().appendChild(...)}.
+   *
+   * @param clearDom if {@code true} this method will also remove any DOM
+   *  elements that are not widgets.
+   */
+  public void clear(boolean clearDom) {
+clear();
+
+if (clearDom) {
+  com.google.gwt.user.client.Element containerElement = getElement();
+  while (containerElement.hasChildNodes()) {
+containerElement.removeChild(containerElement.getFirstChild());
+  }
+}
+  }
 }
diff --git a/user/test/com/google/gwt/user/client/ui/RootPanelTest.java  
b/user/test/com/google/gwt/user/client/ui/RootPanelTest.java

index 6584fef..d455bd1 100644
--- a/user/test/com/google/gwt/user/client/ui/RootPanelTest.java
+++ b/user/test/com/google/gwt/user/client/ui/RootPanelTest.java
@@ -19,6 +19,7 @@
 import com.google.gwt.dom.client.Document;
 import com.google.gwt.dom.client.Element;
 import com.google.gwt.junit.client.GWTTestCase;
+import com.google.gwt.user.client.DOM;

 /**
  * Tests {@link RootPanel}.
@@ -28,6 +29,56 @@
   @Override
   public String getModuleName() {
 return "com.google.gwt.user.User";
+  }
+
+  public void testClearRootPanelAndDOM() {
+
+RootPanel rootPanel = createDOM("testClearRootPanelAndDOM");
+
+rootPanel.add(new Button("a"));
+rootPanel.add(new Button("b"));
+
+com.google.gwt.user.client.Element newDiv = DOM.createDiv();
+newDiv.setInnerText("c");
+rootPanel.getElement().appendChild(newDiv);
+
+assertEquals(3, rootPanel.getElement().getChildCount());
+
+rootPanel.clear(true);
+assertEquals(0, rootPanel.getElement().getChildCount());
+  }
+
+  public void testClearRootPanel() {
+
+RootPanel rootPanel = createDOM("testClearRootPanel");
+
+rootPanel.add(new Button("a"));
+rootPanel.add(new Button("b"));
+
+com.google.gwt.user.client.Element newDiv = DOM.createDiv();
+newDiv.setInnerText("c");
+rootPanel.getElement().appendChild(newDiv);
+
+assertEquals(3, rootPanel.getElement().getChildCount());
+
+rootPanel.clear(false);
+assertEquals(1, rootPanel.getElement().getChildCount());
+
+// clean up
+rootPanel.clear(true);
+assertEquals(0, rootPanel.getElement().getChildCount());
+  }
+
+  public void testClearRootPanelContainingTextNodes() {
+
+RootPanel rootPanel = createDOM("testClearRootPanelAndDOM");
+
+rootPanel.getElement().setInnerHTML("Some mixed content");
+
+assertEquals(3, rootPanel.getElement().getChildCount());
+
+rootPanel.clear(true);
+assertEquals(0, rootPanel.getElement().getChildCount());
   }

   public void testDetachNowWithErrorOnDetach() {
@@ -131,4 +182,18 @@
 RootPanel.getBodyElement().appendChild(elem);
 return elem;
   }
+
+  private RootPanel createDOM(String id) {
+// create our own part in the document
+com.google.gwt.user.client.Element div = DOM.createDiv();
+div.setId(id);
+Document.get().getBody().appendChild(div);
+
+// get it via RootPanel
+RootPanel rootPanel = RootPanel.get(id);
+
+// no elements in the DOM prior to test
+assertEquals(0, rootPanel.getElement().getChildCount());
+return rootPanel;
+  }
 }

--
To view, visit https://gwt-review.googlesource.com/2512
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I712989276142460b91514713eaf8d8f74dbecd7b
Gerrit-PatchSet: 6
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Ku

[gwt-contrib] Change in gwt[master]: Adding a DOM clear method to RootPanel

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Adding a DOM clear method to RootPanel
..


Patch Set 7:

@Manuel good catch.

We do not need to care about the History Frame (I looked it up before  
submitting the patch), but we care about the iframe with code, especially  
when using Async Loading, because then we still need the frame.


I will follow up with a new patch addressing the bug issue 8200 I just  
filed.


--
To view, visit https://gwt-review.googlesource.com/2512
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I712989276142460b91514713eaf8d8f74dbecd7b
Gerrit-PatchSet: 7
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Manuel Carrasco Moñino 
Gerrit-Reviewer: Matthew Dempsky 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: making RootPanel.clear(true) respects GWT loader iframei

[Daniel Kurka]

Daniel Kurka has uploaded a new change for review.

  https://gwt-review.googlesource.com/3430


Change subject: making RootPanel.clear(true) respects GWT loader iframei
..

making RootPanel.clear(true) respects GWT loader iframei

fixes issue 8200

Change-Id: If876b04c453a1d4e170870e97f3a82d0d86599d5
---
M user/src/com/google/gwt/user/client/ui/RootPanel.java
M user/test/com/google/gwt/user/client/ui/RootPanelTest.java
2 files changed, 49 insertions(+), 2 deletions(-)



diff --git a/user/src/com/google/gwt/user/client/ui/RootPanel.java  
b/user/src/com/google/gwt/user/client/ui/RootPanel.java

index c4929c6..6cf2e06 100644
--- a/user/src/com/google/gwt/user/client/ui/RootPanel.java
+++ b/user/src/com/google/gwt/user/client/ui/RootPanel.java
@@ -15,11 +15,13 @@
  */
 package com.google.gwt.user.client.ui;

+import com.google.gwt.core.client.GWT;
 import com.google.gwt.core.client.impl.Disposable;
 import com.google.gwt.core.client.impl.Impl;
 import com.google.gwt.dom.client.BodyElement;
 import com.google.gwt.dom.client.Document;
 import com.google.gwt.dom.client.Element;
+import com.google.gwt.dom.client.Node;
 import com.google.gwt.event.logical.shared.CloseEvent;
 import com.google.gwt.event.logical.shared.CloseHandler;
 import com.google.gwt.i18n.client.BidiUtils;
@@ -28,8 +30,10 @@
 import com.google.gwt.user.client.Event;
 import com.google.gwt.user.client.Window;

+import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.HashSet;
+import java.util.List;
 import java.util.Map;
 import java.util.Set;

@@ -317,10 +321,32 @@
 clear();

 if (clearDom) {
-  com.google.gwt.user.client.Element containerElement = getElement();
+  List nodesToReAttach = new ArrayList();
+  Element containerElement = getElement();
   while (containerElement.hasChildNodes()) {
-containerElement.removeChild(containerElement.getFirstChild());
+Node child = containerElement.getFirstChild();
+
+if (!shouldNodeBeRemoved(child)) {
+  nodesToReAttach.add(child);
+}
+containerElement.removeChild(child);
+  }
+
+  for (Node node : nodesToReAttach) {
+containerElement.appendChild(node);
   }
 }
   }
+
+  private boolean shouldNodeBeRemoved(Node child) {
+if (Element.is(child)) {
+  Element childElement = (Element) child;
+  // do not remove GWT's iframe that is used for loading code
+  if ("iframe".equalsIgnoreCase(childElement.getTagName())
+  && GWT.getModuleName().equals(childElement.getId())) {
+return false;
+  }
+}
+return true;
+  }
 }
diff --git a/user/test/com/google/gwt/user/client/ui/RootPanelTest.java  
b/user/test/com/google/gwt/user/client/ui/RootPanelTest.java

index d455bd1..5a3ad2e 100644
--- a/user/test/com/google/gwt/user/client/ui/RootPanelTest.java
+++ b/user/test/com/google/gwt/user/client/ui/RootPanelTest.java
@@ -15,6 +15,7 @@
  */
 package com.google.gwt.user.client.ui;

+import com.google.gwt.core.client.GWT;
 import com.google.gwt.dom.client.DivElement;
 import com.google.gwt.dom.client.Document;
 import com.google.gwt.dom.client.Element;
@@ -69,6 +70,26 @@
 assertEquals(0, rootPanel.getElement().getChildCount());
   }

+  public void testClearRootPanelWithGWTFrame() {
+
+RootPanel rootPanel = createDOM("testClearRootPanel");
+
+rootPanel.add(new Button("a"));
+rootPanel.add(new Button("b"));
+
+rootPanel.clear(true);
+assertEquals(0, rootPanel.getElement().getChildCount());
+
+Element iFrame = DOM.createIFrame();
+iFrame.setId(GWT.getModuleName());
+rootPanel.getElement().appendChild(iFrame);
+
+assertEquals(1, rootPanel.getElement().getChildCount());
+
+rootPanel.clear(true);
+assertEquals(1, rootPanel.getElement().getChildCount());
+  }
+
   public void testClearRootPanelContainingTextNodes() {

 RootPanel rootPanel = createDOM("testClearRootPanelAndDOM");

--
To view, visit https://gwt-review.googlesource.com/3430
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If876b04c453a1d4e170870e97f3a82d0d86599d5
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: making RootPanel.clear(true) respects GWT loader iframei

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: making RootPanel.clear(true) respects GWT loader iframei
..


Patch Set 1:

(2 comments)


File user/src/com/google/gwt/user/client/ui/RootPanel.java
Line 329: if (!shouldNodeBeRemoved(child)) {
If I don't remove them we will see the same node in the next iteration and  
since iterating this way is the fastest way to do it. I am okay with  
reatttaching an element.



Line 346:   && GWT.getModuleName().equals(childElement.getId())) {
You are right this will break IE6 History, but I am not willing to add  
extra complexity just to keep IE6 happy, since this will get released with  
GWT 2.6, its fine.



--
To view, visit https://gwt-review.googlesource.com/3430
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If876b04c453a1d4e170870e97f3a82d0d86599d5
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Manuel Carrasco Moñino 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: making RootPanel.clear(true) respects GWT loader iframei

[Daniel Kurka]

Hello Leeroy Jenkins,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3430

to look at the new patch set (#2).

Change subject: making RootPanel.clear(true) respects GWT loader iframei
..

making RootPanel.clear(true) respects GWT loader iframei

fixes issue 8200

Change-Id: If876b04c453a1d4e170870e97f3a82d0d86599d5
---
M user/src/com/google/gwt/user/client/ui/RootPanel.java
M user/test/com/google/gwt/user/client/ui/RootPanelTest.java
2 files changed, 49 insertions(+), 2 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3430
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If876b04c453a1d4e170870e97f3a82d0d86599d5
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Manuel Carrasco Moñino 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: making RootPanel.clear(true) respects GWT loader iframe

[Daniel Kurka]

Hello Leeroy Jenkins,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3430

to look at the new patch set (#3).

Change subject: making RootPanel.clear(true) respects GWT loader iframe
..

making RootPanel.clear(true) respects GWT loader iframe

fixes issue 8200

Change-Id: If876b04c453a1d4e170870e97f3a82d0d86599d5
---
M user/src/com/google/gwt/user/client/ui/RootPanel.java
M user/test/com/google/gwt/user/client/ui/RootPanelTest.java
2 files changed, 49 insertions(+), 2 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3430
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If876b04c453a1d4e170870e97f3a82d0d86599d5
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Manuel Carrasco Moñino 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: making RootPanel.clear(true) respects GWT loader iframe

[Daniel Kurka]

Hello Leeroy Jenkins,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3430

to look at the new patch set (#4).

Change subject: making RootPanel.clear(true) respects GWT loader iframe
..

making RootPanel.clear(true) respects GWT loader iframe

fixes issue 8200

Change-Id: If876b04c453a1d4e170870e97f3a82d0d86599d5
---
M user/src/com/google/gwt/user/client/ui/RootPanel.java
M user/test/com/google/gwt/user/client/ui/RootPanelTest.java
2 files changed, 43 insertions(+), 3 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3430
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If876b04c453a1d4e170870e97f3a82d0d86599d5
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Manuel Carrasco Moñino 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: making RootPanel.clear(true) respects GWT loader iframe

[Daniel Kurka]

Hello Thomas Broyer, Leeroy Jenkins,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3430

to look at the new patch set (#5).

Change subject: making RootPanel.clear(true) respects GWT loader iframe
..

making RootPanel.clear(true) respects GWT loader iframe

fixes issue 8200

Change-Id: If876b04c453a1d4e170870e97f3a82d0d86599d5
---
M user/src/com/google/gwt/user/client/ui/RootPanel.java
M user/test/com/google/gwt/user/client/ui/RootPanelTest.java
2 files changed, 44 insertions(+), 3 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3430
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If876b04c453a1d4e170870e97f3a82d0d86599d5
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Manuel Carrasco Moñino 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: making RootPanel.clear(true) respects GWT loader iframe

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: making RootPanel.clear(true) respects GWT loader iframe
..


Patch Set 4:

(1 comment)


File user/src/com/google/gwt/user/client/ui/RootPanel.java
Line 338:   if ("iframe".equalsIgnoreCase(childElement.getTagName())
Done


--
To view, visit https://gwt-review.googlesource.com/3430
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If876b04c453a1d4e170870e97f3a82d0d86599d5
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Manuel Carrasco Moñino 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Adding key codes

[Daniel Kurka]

Daniel Kurka has uploaded a new patch set (#2).

Change subject: Adding key codes
..

Adding key codes

fixes issue 8203

Change-Id: Ia1cd903123d79db81ceb44103892e168d38a4e4e
---
M user/src/com/google/gwt/event/dom/client/KeyCodes.java
1 file changed, 345 insertions(+), 10 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3480
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia1cd903123d79db81ceb44103892e168d38a4e4e
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Adding key codes

[Daniel Kurka]

Daniel Kurka has uploaded a new change for review.

  https://gwt-review.googlesource.com/3480


Change subject: Adding key codes
..

Adding key codes

fixes issue 8203

Change-Id: Ia1cd903123d79db81ceb44103892e168d38a4e4e
---
M user/src/com/google/gwt/event/dom/client/KeyCodes.java
1 file changed, 345 insertions(+), 10 deletions(-)



diff --git a/user/src/com/google/gwt/event/dom/client/KeyCodes.java  
b/user/src/com/google/gwt/event/dom/client/KeyCodes.java

index 5a28ccb..be9a414 100644
--- a/user/src/com/google/gwt/event/dom/client/KeyCodes.java
+++ b/user/src/com/google/gwt/event/dom/client/KeyCodes.java
@@ -29,6 +29,213 @@
  * {@link com.google.gwt.user.client.ui.KeyboardListener}.
  */
 public class KeyCodes {
+
+  /**
+   * Key code for A
+   */
+  public static final int KEY_A = 65;
+  /**
+   * Key code for B
+   */
+  public static final int KEY_B = 66;
+  /**
+   * Key code for C
+   */
+  public static final int KEY_C = 67;
+  /**
+   * Key code for D
+   */
+  public static final int KEY_D = 68;
+  /**
+   * Key code for E
+   */
+  public static final int KEY_E = 69;
+  /**
+   * Key code for F
+   */
+  public static final int KEY_F = 70;
+  /**
+   * Key code for G
+   */
+  public static final int KEY_G = 71;
+  /**
+   * Key code for H
+   */
+  public static final int KEY_H = 72;
+  /**
+   * Key code for I
+   */
+  public static final int KEY_I = 73;
+  /**
+   * Key code for J
+   */
+  public static final int KEY_J = 74;
+  /**
+   * Key code for K
+   */
+  public static final int KEY_K = 75;
+  /**
+   * Key code for L
+   */
+  public static final int KEY_L = 76;
+  /**
+   * Key code for M
+   */
+  public static final int KEY_M = 77;
+  /**
+   * Key code for N
+   */
+  public static final int KEY_N = 78;
+  /**
+   * Key code for O
+   */
+  public static final int KEY_O = 79;
+  /**
+   * Key code for P
+   */
+  public static final int KEY_P = 80;
+  /**
+   * Key code for Q
+   */
+  public static final int KEY_Q = 81;
+  /**
+   * Key code for R
+   */
+  public static final int KEY_R = 82;
+  /**
+   * Key code for S
+   */
+  public static final int KEY_S = 83;
+  /**
+   * Key code for T
+   */
+  public static final int KEY_T = 84;
+  /**
+   * Key code for U
+   */
+  public static final int KEY_U = 85;
+  /**
+   * Key code for V
+   */
+  public static final int KEY_V = 86;
+  /**
+   * Key code for W
+   */
+  public static final int KEY_W = 87;
+  /**
+   * Key code for X
+   */
+  public static final int KEY_X = 88;
+  /**
+   * Key code for Y
+   */
+  public static final int KEY_Y = 89;
+  /**
+   * Key code for Z
+   */
+  public static final int KEY_Z = 90;
+
+  /**
+   * Key code number 0
+   */
+  public static final int KEY_ZERO = 48;
+  /**
+   * Key code number 1
+   */
+  public static final int KEY_ONE = 49;
+  /**
+   * Key code number 2
+   */
+  public static final int KEY_TWO = 50;
+  /**
+   * Key code number 3
+   */
+  public static final int KEY_THREE = 51;
+  /**
+   * Key code number 4
+   */
+  public static final int KEY_FOUR = 52;
+  /**
+   * Key code number 5
+   */
+  public static final int KEY_FIVE = 53;
+  /**
+   * Key code number 6
+   */
+  public static final int KEY_SIX = 54;
+  /**
+   * Key code number 7
+   */
+  public static final int KEY_SEVEN = 55;
+  /**
+   * Key code number 8
+   */
+  public static final int KEY_EIGHT = 56;
+  /**
+   * Key code number 9
+   */
+  public static final int KEY_NINE = 57;
+
+  /**
+   * Key code for number 0 on numeric keyboard
+   */
+  public static final int KEY_NUM_ZERO = 96;
+  /**
+   * Key code for number 1 on numeric keyboard
+   */
+  public static final int KEY_NUM_ONE = 97;
+  /**
+   * Key code for number 2 on numeric keyboard
+   */
+  public static final int KEY_NUM_TWO = 98;
+  /**
+   * Key code for number 3 on numeric keyboard
+   */
+  public static final int KEY_NUM_THREE = 99;
+  /**
+   * Key code for number 4 on numeric keyboard
+   */
+  public static final int KEY_NUM_FOUR = 100;
+  /**
+   * Key code for number 5 on numeric keyboard
+   */
+  public static final int KEY_NUM_FIVE = 101;
+  /**
+   * Key code for number 6 on numeric keyboard
+   */
+  public static final int KEY_NUM_SIX = 102;
+  /**
+   * Key code for number 7 on numeric keyboard
+   */
+  public static final int KEY_NUM_SEVEN = 103;
+  /**
+   * Key code for number 8 on numeric keyboard
+   */
+  public static final int KEY_NUM_EIGHT = 104;
+  /**
+   * Key code for number 9 on numeric keyboard
+   */
+  public static final int KEY_NUM_NINE = 105;
+  /**
+   * Key code for multiply on numeric keyboard
+   */
+  public static final int KEY_NUM_MULTIPLY = 106;
+  /**
+   * Key code for plus on numeric keyboard
+   */
+  public static final int KEY_NUM_PLUS = 107;
+  /**
+   * Key code for minus on numeric keyboard
+   */
+  public static final int KEY_NUM_MINUS = 109;
+  /**
+   * Key code for period on numeric keyboard

[gwt-contrib] Change in gwt[master]: Adding key codes

[Daniel Kurka]

Daniel Kurka has submitted this change and it was merged.

Change subject: Adding key codes
..


Adding key codes

fixes issue 8203

Change-Id: Ia1cd903123d79db81ceb44103892e168d38a4e4e
---
M user/src/com/google/gwt/event/dom/client/KeyCodes.java
1 file changed, 345 insertions(+), 10 deletions(-)

Approvals:
  Ray Cromwell: Verified; Looks good to me, approved



diff --git a/user/src/com/google/gwt/event/dom/client/KeyCodes.java  
b/user/src/com/google/gwt/event/dom/client/KeyCodes.java

index 5a28ccb..699510e 100644
--- a/user/src/com/google/gwt/event/dom/client/KeyCodes.java
+++ b/user/src/com/google/gwt/event/dom/client/KeyCodes.java
@@ -29,6 +29,213 @@
  * {@link com.google.gwt.user.client.ui.KeyboardListener}.
  */
 public class KeyCodes {
+
+  /**
+   * Key code for A
+   */
+  public static final int KEY_A = 65;
+  /**
+   * Key code for B
+   */
+  public static final int KEY_B = 66;
+  /**
+   * Key code for C
+   */
+  public static final int KEY_C = 67;
+  /**
+   * Key code for D
+   */
+  public static final int KEY_D = 68;
+  /**
+   * Key code for E
+   */
+  public static final int KEY_E = 69;
+  /**
+   * Key code for F
+   */
+  public static final int KEY_F = 70;
+  /**
+   * Key code for G
+   */
+  public static final int KEY_G = 71;
+  /**
+   * Key code for H
+   */
+  public static final int KEY_H = 72;
+  /**
+   * Key code for I
+   */
+  public static final int KEY_I = 73;
+  /**
+   * Key code for J
+   */
+  public static final int KEY_J = 74;
+  /**
+   * Key code for K
+   */
+  public static final int KEY_K = 75;
+  /**
+   * Key code for L
+   */
+  public static final int KEY_L = 76;
+  /**
+   * Key code for M
+   */
+  public static final int KEY_M = 77;
+  /**
+   * Key code for N
+   */
+  public static final int KEY_N = 78;
+  /**
+   * Key code for O
+   */
+  public static final int KEY_O = 79;
+  /**
+   * Key code for P
+   */
+  public static final int KEY_P = 80;
+  /**
+   * Key code for Q
+   */
+  public static final int KEY_Q = 81;
+  /**
+   * Key code for R
+   */
+  public static final int KEY_R = 82;
+  /**
+   * Key code for S
+   */
+  public static final int KEY_S = 83;
+  /**
+   * Key code for T
+   */
+  public static final int KEY_T = 84;
+  /**
+   * Key code for U
+   */
+  public static final int KEY_U = 85;
+  /**
+   * Key code for V
+   */
+  public static final int KEY_V = 86;
+  /**
+   * Key code for W
+   */
+  public static final int KEY_W = 87;
+  /**
+   * Key code for X
+   */
+  public static final int KEY_X = 88;
+  /**
+   * Key code for Y
+   */
+  public static final int KEY_Y = 89;
+  /**
+   * Key code for Z
+   */
+  public static final int KEY_Z = 90;
+
+  /**
+   * Key code number 0
+   */
+  public static final int KEY_ZERO = 48;
+  /**
+   * Key code number 1
+   */
+  public static final int KEY_ONE = 49;
+  /**
+   * Key code number 2
+   */
+  public static final int KEY_TWO = 50;
+  /**
+   * Key code number 3
+   */
+  public static final int KEY_THREE = 51;
+  /**
+   * Key code number 4
+   */
+  public static final int KEY_FOUR = 52;
+  /**
+   * Key code number 5
+   */
+  public static final int KEY_FIVE = 53;
+  /**
+   * Key code number 6
+   */
+  public static final int KEY_SIX = 54;
+  /**
+   * Key code number 7
+   */
+  public static final int KEY_SEVEN = 55;
+  /**
+   * Key code number 8
+   */
+  public static final int KEY_EIGHT = 56;
+  /**
+   * Key code number 9
+   */
+  public static final int KEY_NINE = 57;
+
+  /**
+   * Key code for number 0 on numeric keyboard
+   */
+  public static final int KEY_NUM_ZERO = 96;
+  /**
+   * Key code for number 1 on numeric keyboard
+   */
+  public static final int KEY_NUM_ONE = 97;
+  /**
+   * Key code for number 2 on numeric keyboard
+   */
+  public static final int KEY_NUM_TWO = 98;
+  /**
+   * Key code for number 3 on numeric keyboard
+   */
+  public static final int KEY_NUM_THREE = 99;
+  /**
+   * Key code for number 4 on numeric keyboard
+   */
+  public static final int KEY_NUM_FOUR = 100;
+  /**
+   * Key code for number 5 on numeric keyboard
+   */
+  public static final int KEY_NUM_FIVE = 101;
+  /**
+   * Key code for number 6 on numeric keyboard
+   */
+  public static final int KEY_NUM_SIX = 102;
+  /**
+   * Key code for number 7 on numeric keyboard
+   */
+  public static final int KEY_NUM_SEVEN = 103;
+  /**
+   * Key code for number 8 on numeric keyboard
+   */
+  public static final int KEY_NUM_EIGHT = 104;
+  /**
+   * Key code for number 9 on numeric keyboard
+   */
+  public static final int KEY_NUM_NINE = 105;
+  /**
+   * Key code for multiply on numeric keyboard
+   */
+  public static final int KEY_NUM_MULTIPLY = 106;
+  /**
+   * Key code for plus on numeric keyboard
+   */
+  public static final int KEY_NUM_PLUS = 107;
+  /**
+   * Key code for minus on numeric keyboard
+   */
+  public static final int KEY_NUM_MINUS = 109;
+  /**
+   * Key code for period

[gwt-contrib] Change in gwt[master]: Adds Node#removeAllChildren.

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Adds Node#removeAllChildren.
..


Patch Set 1:

(3 comments)


File user/src/com/google/gwt/dom/client/Node.java
Line 303:   /**
Is there a reason to do this in JSNI, instead of Java?



File user/test/com/google/gwt/dom/client/NodeTest.java
Line 43: ButtonElement btn0 = doc.createPushButtonElement();
why did you change this?


Line 52: ButtonElement btn1 = doc.createPushButtonElement();
same here


--
To view, visit https://gwt-review.googlesource.com/3511
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic607bf6523a41c0ee4020a12e8505b1d8b39d916
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Adds Element#toggleClassName.

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Adds Element#toggleClassName.
..


Patch Set 1: Code-Review+2

--
To view, visit https://gwt-review.googlesource.com/3501
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b2a507d5ee8482a91aae28c9dc9a6b6826afb2f
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Adds Node#removeAllChildren.

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Adds Node#removeAllChildren.
..


Patch Set 1:

(1 comment)


File user/src/com/google/gwt/dom/client/Node.java
Line 298: while (this.lastChild) {
for some reason this is actually way slower. I am looking into this, but  
see: http://jsperf.com/innerhtml-vs-removechild/47



--
To view, visit https://gwt-review.googlesource.com/3511
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic607bf6523a41c0ee4020a12e8505b1d8b39d916
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Manuel Carrasco Moñino 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Adds Node#removeAllChildren.

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Adds Node#removeAllChildren.
..


Patch Set 1: Code-Review+2

(1 comment)


File user/src/com/google/gwt/dom/client/Node.java
Line 303:   /**
I was just curious, sounds good to me


--
To view, visit https://gwt-review.googlesource.com/3511
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic607bf6523a41c0ee4020a12e8505b1d8b39d916
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Manuel Carrasco Moñino 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Adds Timer#isRunning().

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Adds Timer#isRunning().
..


Patch Set 2: Code-Review+2

--
To view, visit https://gwt-review.googlesource.com/3321
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0133c64de75d5d95cff863c5ab950d474dda0c56
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Issue 8220: Support for java.lang.reflect.Type - fixed

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Issue 8220: Support for java.lang.reflect.Type - fixed
..


Patch Set 1:

(4 comments)


File user/super/com/google/gwt/emul/java/lang/reflect/Type.java
Line 3:  *
nit: whitespace


Line 7:  *
nit: whitespace


Line 9:  *
nit: whitespace


Line 20:  *
nit: whitespace


--
To view, visit https://gwt-review.googlesource.com/3560
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I94ae5fc5f6ed248a8247ce0088246e71e4b32603
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Jörg Hohwiller 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Fix javadoc in JsDate to list correct number for december

[Daniel Kurka]

Daniel Kurka has uploaded a new change for review.

  https://gwt-review.googlesource.com/3610


Change subject: Fix javadoc in JsDate to list correct number for december
..

Fix javadoc in JsDate to list correct number for december

fixes issue 8212

Change-Id: I216195de9d5eb63d1e38a93895684c71ec80a1d6
---
M user/src/com/google/gwt/core/client/JsDate.java
1 file changed, 2 insertions(+), 2 deletions(-)



diff --git a/user/src/com/google/gwt/core/client/JsDate.java  
b/user/src/com/google/gwt/core/client/JsDate.java

index 3aa61bc..7a351f0 100644
--- a/user/src/com/google/gwt/core/client/JsDate.java
+++ b/user/src/com/google/gwt/core/client/JsDate.java
@@ -160,7 +160,7 @@
   }-*/;

   /**
-   * Returns the month, from 0 (January) to 6
+   * Returns the month, from 0 (January) to 11
* December.
*/
   public final native int getMonth() /*-{
@@ -238,7 +238,7 @@
   }-*/;

   /**
-   * Returns the month, from 0 (January) to 6
+   * Returns the month, from 0 (January) to 11
* December, in UTC.
*/
   public final native int getUTCMonth() /*-{

--
To view, visit https://gwt-review.googlesource.com/3610
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I216195de9d5eb63d1e38a93895684c71ec80a1d6
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Let ValueListBox implement HasEnabled

[Daniel Kurka]

Daniel Kurka has uploaded a new change for review.

  https://gwt-review.googlesource.com/3611


Change subject: Let ValueListBox implement HasEnabled
..

Let ValueListBox implement HasEnabled

fixes issue 6112

Change-Id: Ib866657960d0a3d41e0b3b1f08fa9a97091149a9
---
M user/src/com/google/gwt/user/client/ui/ValueListBox.java
M user/test/com/google/gwt/user/client/ui/ValueListBoxTest.java
2 files changed, 20 insertions(+), 1 deletion(-)



diff --git a/user/src/com/google/gwt/user/client/ui/ValueListBox.java  
b/user/src/com/google/gwt/user/client/ui/ValueListBox.java

index 1bdbdf8..61f6f85 100644
--- a/user/src/com/google/gwt/user/client/ui/ValueListBox.java
+++ b/user/src/com/google/gwt/user/client/ui/ValueListBox.java
@@ -42,7 +42,8 @@
  * @param  the value type
  */
 public class ValueListBox extends Composite implements
-Focusable, HasConstrainedValue, IsEditor> {
+Focusable, HasConstrainedValue, HasEnabled,
+IsEditor> {

   private final List values = new ArrayList();
   private final Map valueKeyToIndex = new HashMapInteger>();

@@ -97,6 +98,11 @@
 return value;
   }

+  @Override
+  public boolean isEnabled() {
+return getListBox().isEnabled();
+  }
+
   public void setAcceptableValues(Collection newValues) {
 values.clear();
 valueKeyToIndex.clear();
@@ -116,6 +122,11 @@
   }

   @Override
+  public void setEnabled(boolean enabled) {
+getListBox().setEnabled(enabled);
+  }
+
+  @Override
   public void setFocus(boolean focused) {
 getListBox().setFocus(focused);
   }
diff --git a/user/test/com/google/gwt/user/client/ui/ValueListBoxTest.java  
b/user/test/com/google/gwt/user/client/ui/ValueListBoxTest.java

index bc6384e..6014125 100644
--- a/user/test/com/google/gwt/user/client/ui/ValueListBoxTest.java
+++ b/user/test/com/google/gwt/user/client/ui/ValueListBoxTest.java
@@ -65,6 +65,14 @@
 return "com.google.gwt.user.User";
   }

+  public void testEnabled() {
+subject.setEnabled(true);
+assertEquals(true, subject.isEnabled());
+
+subject.setEnabled(false);
+assertEquals(false, subject.isEnabled());
+  }
+
   public void xx_testExtraValueSet() {  // TODO(rjrjr) Strange failures on  
firefox

 Foo[] values = new Foo[] {new Foo("able"), new Foo("baker")};
 Foo baz = new Foo("baz");

--
To view, visit https://gwt-review.googlesource.com/3611
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib866657960d0a3d41e0b3b1f08fa9a97091149a9
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Making DialogBox clear handlers on auto hide

[Daniel Kurka]

Daniel Kurka has uploaded a new change for review.

  https://gwt-review.googlesource.com/3612


Change subject: Making DialogBox clear handlers on auto hide
..

Making DialogBox clear handlers on auto hide

fixes issue 6356

Change-Id: Iaa4c76643eecf1b51820861f193de36ed44e9f41
---
M user/src/com/google/gwt/user/client/ui/DialogBox.java
1 file changed, 9 insertions(+), 0 deletions(-)



diff --git a/user/src/com/google/gwt/user/client/ui/DialogBox.java  
b/user/src/com/google/gwt/user/client/ui/DialogBox.java

index 50f3666..c6f439d 100644
--- a/user/src/com/google/gwt/user/client/ui/DialogBox.java
+++ b/user/src/com/google/gwt/user/client/ui/DialogBox.java
@@ -301,6 +301,15 @@
   }

   @Override
+  public void hide(boolean autoClosed) {
+if (resizeHandlerRegistration != null) {
+  resizeHandlerRegistration.removeHandler();
+  resizeHandlerRegistration = null;
+}
+super.hide(autoClosed);
+  }
+
+  @Override
   public void onBrowserEvent(Event event) {
 // If we're not yet dragging, only trigger mouse events if the event  
occurs

 // in the caption wrapper

--
To view, visit https://gwt-review.googlesource.com/3612
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaa4c76643eecf1b51820861f193de36ed44e9f41
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Making DialogBox clear handlers on auto hide

[Daniel Kurka]

Daniel Kurka has uploaded a new patch set (#2).

Change subject: Making DialogBox clear handlers on auto hide
..

Making DialogBox clear handlers on auto hide

fixes issue 6356

Change-Id: Iaa4c76643eecf1b51820861f193de36ed44e9f41
---
M user/src/com/google/gwt/user/client/ui/DialogBox.java
1 file changed, 9 insertions(+), 0 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3612
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaa4c76643eecf1b51820861f193de36ed44e9f41
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Add wrap method to Canvas

[Daniel Kurka]

Daniel Kurka has uploaded a new change for review.

  https://gwt-review.googlesource.com/3613


Change subject: Add wrap method to Canvas
..

Add wrap method to Canvas

fixes issue 6683

Change-Id: Ieca5c14e41b495da75004fa080409fca1b21b3d5
---
M user/src/com/google/gwt/canvas/client/Canvas.java
1 file changed, 14 insertions(+), 0 deletions(-)



diff --git a/user/src/com/google/gwt/canvas/client/Canvas.java  
b/user/src/com/google/gwt/canvas/client/Canvas.java

index 99a314d..1018024 100644
--- a/user/src/com/google/gwt/canvas/client/Canvas.java
+++ b/user/src/com/google/gwt/canvas/client/Canvas.java
@@ -22,6 +22,7 @@
 import com.google.gwt.dom.client.Document;
 import com.google.gwt.dom.client.PartialSupport;
 import com.google.gwt.user.client.ui.FocusWidget;
+import com.google.gwt.user.client.ui.RootPanel;

 /**
  * A widget representing a <canvas> element.
@@ -51,6 +52,19 @@
 return new Canvas(element);
   }

+  public Canvas wrap(CanvasElement element) {
+if (!isSupported()) {
+  return null;
+}
+Canvas canvas = new Canvas(element);
+
+// Mark it attached and remember it for cleanup.
+canvas.onAttach();
+RootPanel.detachOnWindowClose(canvas);
+
+return canvas;
+  }
+
   /**
* Runtime check for whether the canvas element is supported in this  
browser.

*

--
To view, visit https://gwt-review.googlesource.com/3613
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieca5c14e41b495da75004fa080409fca1b21b3d5
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Add wrap method to Canvas

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Add wrap method to Canvas
..


Patch Set 1:

(2 comments)


File user/src/com/google/gwt/canvas/client/Canvas.java
Line 55:   public Canvas wrap(CanvasElement element) {
Done


Line 56: if (!isSupported()) {
Done


--
To view, visit https://gwt-review.googlesource.com/3613
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieca5c14e41b495da75004fa080409fca1b21b3d5
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Add wrap method to Canvas

[Daniel Kurka]

Hello Leeroy Jenkins, Thomas Broyer,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3613

to look at the new patch set (#2).

Change subject: Add wrap method to Canvas
..

Add wrap method to Canvas

fixes issue 6683

Change-Id: Ieca5c14e41b495da75004fa080409fca1b21b3d5
---
M user/src/com/google/gwt/canvas/client/Canvas.java
1 file changed, 29 insertions(+), 1 deletion(-)


--
To view, visit https://gwt-review.googlesource.com/3613
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ieca5c14e41b495da75004fa080409fca1b21b3d5
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Let ValueListBox implement HasEnabled

[Daniel Kurka]

Hello Leeroy Jenkins, Thomas Broyer, Jens Nehlmeier,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3611

to look at the new patch set (#2).

Change subject: Let ValueListBox implement HasEnabled
..

Let ValueListBox implement HasEnabled

fixes issue 6112

Change-Id: Ib866657960d0a3d41e0b3b1f08fa9a97091149a9
---
M user/src/com/google/gwt/user/client/ui/ValueListBox.java
M user/test/com/google/gwt/user/client/ui/ValueListBoxTest.java
2 files changed, 20 insertions(+), 1 deletion(-)


--
To view, visit https://gwt-review.googlesource.com/3611
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib866657960d0a3d41e0b3b1f08fa9a97091149a9
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Jens Nehlmeier 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Add wrap method to Canvas

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Add wrap method to Canvas
..


Patch Set 2:

(1 comment)


File user/src/com/google/gwt/canvas/client/Canvas.java
Line 84: return isSupported(Document.get().createCanvasElement());
All major browsers now support canvas, so normally this check will return  
true (see: http://caniuse.com/canvas).


So I am actually think we could remove the whole ifSupported meme at least  
for GWT 3.0


Tested on IE8 to see if this introduces unwanted behavior, but looked fine.


--
To view, visit https://gwt-review.googlesource.com/3613
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieca5c14e41b495da75004fa080409fca1b21b3d5
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Add toString to SafeHtmlString to help debuging

[Daniel Kurka]

Daniel Kurka has uploaded a new change for review.

  https://gwt-review.googlesource.com/3614


Change subject: Add toString to SafeHtmlString to help debuging
..

Add toString to SafeHtmlString to help debuging

Change-Id: I29a12f293513a0b7458c15c01217d2c9fe1df60e
---
M user/src/com/google/gwt/safehtml/shared/SafeHtmlString.java
1 file changed, 5 insertions(+), 0 deletions(-)



diff --git a/user/src/com/google/gwt/safehtml/shared/SafeHtmlString.java  
b/user/src/com/google/gwt/safehtml/shared/SafeHtmlString.java

index 66afd65..f514f8b 100644
--- a/user/src/com/google/gwt/safehtml/shared/SafeHtmlString.java
+++ b/user/src/com/google/gwt/safehtml/shared/SafeHtmlString.java
@@ -76,4 +76,9 @@
   public int hashCode() {
 return html.hashCode();
   }
+
+  @Override
+  public String toString() {
+return "safe: \"" + asString() + "\"";
+  }
 }

--
To view, visit https://gwt-review.googlesource.com/3614
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I29a12f293513a0b7458c15c01217d2c9fe1df60e
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Making DialogBox clear handlers on auto hide

[Daniel Kurka]

Hello Thomas Broyer, Leeroy Jenkins,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3612

to look at the new patch set (#3).

Change subject: Making DialogBox clear handlers on auto hide
..

Making DialogBox clear handlers on auto hide

fixes issue 6356

Change-Id: Iaa4c76643eecf1b51820861f193de36ed44e9f41
---
M user/src/com/google/gwt/user/client/ui/DialogBox.java
M user/test/com/google/gwt/user/client/ui/DialogBoxTest.java
2 files changed, 31 insertions(+), 3 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3612
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaa4c76643eecf1b51820861f193de36ed44e9f41
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Making DialogBox clear handlers on auto hide

[Daniel Kurka]

Daniel Kurka has posted comments on this change.

Change subject: Making DialogBox clear handlers on auto hide
..


Patch Set 3:

I think not duplicating code, but adding a test is the best way to go here.

--
To view, visit https://gwt-review.googlesource.com/3612
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa4c76643eecf1b51820861f193de36ed44e9f41
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Undeprecate setMultipleSelect in ListBox

[Daniel Kurka]

Daniel Kurka has uploaded a new change for review.

  https://gwt-review.googlesource.com/3615


Change subject: Undeprecate setMultipleSelect in ListBox
..

Undeprecate setMultipleSelect in ListBox

Changing ListBox from multi select to single
used to fail sometimes in IE6.

Removing the deprecation allows for an easier
way of using ListBox with UiBinder without
UiConstructor.

fixes issue 4831

Change-Id: I7e40cc95530c42733a7bfb26fea858e28c3cd90b
---
M user/src/com/google/gwt/user/client/ui/ListBox.java
1 file changed, 3 insertions(+), 7 deletions(-)



diff --git a/user/src/com/google/gwt/user/client/ui/ListBox.java  
b/user/src/com/google/gwt/user/client/ui/ListBox.java

index e363a93..0c042c7 100644
--- a/user/src/com/google/gwt/user/client/ui/ListBox.java
+++ b/user/src/com/google/gwt/user/client/ui/ListBox.java
@@ -463,15 +463,11 @@
   }

   /**
-   * Sets whether this list allows multiple selections. NOTE: The  
preferred

-   * way of enabling multiple selections in a list box is by using the
-   * {@link #ListBox(boolean)} constructor. Using this method can  
spuriously

-   * fail on Internet Explorer 6.0.
-   *
+   * Sets whether this list allows multiple selections. NOTE:
+   * Using this method can spuriously fail on Internet Explorer 6.0.
+   *
* @param multiple true to allow multiple selections
-   * @deprecated use {@link #ListBox(boolean)} instead
*/
-  @Deprecated
   public void setMultipleSelect(boolean multiple) {
 getSelectElement().setMultiple(multiple);
   }

--
To view, visit https://gwt-review.googlesource.com/3615
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e40cc95530c42733a7bfb26fea858e28c3cd90b
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Add Object.clone as throwing implementation

[Daniel Kurka]

Daniel Kurka has uploaded a new change for review.

  https://gwt-review.googlesource.com/3616


Change subject: Add Object.clone as throwing implementation
..

Add Object.clone as throwing implementation

fixes issue 5068

Change-Id: Ie89b7874953e1d6378fa2a5cb19beb3c34689218
---
A user/super/com/google/gwt/emul/java/lang/CloneNotSupportedException.java
M user/super/com/google/gwt/emul/java/lang/Object.java
2 files changed, 35 insertions(+), 0 deletions(-)



diff --git  
a/user/super/com/google/gwt/emul/java/lang/CloneNotSupportedException.java  
b/user/super/com/google/gwt/emul/java/lang/CloneNotSupportedException.java

new file mode 100644
index 000..3acfa8c
--- /dev/null
+++  
b/user/super/com/google/gwt/emul/java/lang/CloneNotSupportedException.java

@@ -0,0 +1,31 @@
+/*
+ * Copyright 2013 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may  
not
+ * use this file except in compliance with the License. You may obtain a  
copy of

+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,  
WITHOUT

+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations  
under

+ * the License.
+ */
+package java.lang;
+
+/**
+ * See + *  
href="http://java.sun.com/j2se/1.5.0/docs/api/java/lang/CloneNotSupportedException.html";>the

+ * official Java API doc for details.
+ */
+public class CloneNotSupportedException extends Exception {
+
+  public CloneNotSupportedException() {
+  }
+
+  public CloneNotSupportedException(String message) {
+super(message);
+  }
+}
diff --git a/user/super/com/google/gwt/emul/java/lang/Object.java  
b/user/super/com/google/gwt/emul/java/lang/Object.java

index 63717d2..0e4c659 100644
--- a/user/super/com/google/gwt/emul/java/lang/Object.java
+++ b/user/super/com/google/gwt/emul/java/lang/Object.java
@@ -83,6 +83,10 @@
 return getClass().getName() + '@' + Integer.toHexString(hashCode());
   }

+  protected Object clone() {
+throw new CloneNotSupportedException("GWT does not implement  
Object.clone()");

+  }
+
   /**
* Never called; here for JRE compatibility.
*

--
To view, visit https://gwt-review.googlesource.com/3616
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie89b7874953e1d6378fa2a5cb19beb3c34689218
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Add Object.clone as throwing implementation

[Daniel Kurka]

Hello Leeroy Jenkins,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3616

to look at the new patch set (#2).

Change subject: Add Object.clone as throwing implementation
..

Add Object.clone as throwing implementation

fixes issue 5068

Change-Id: Ie89b7874953e1d6378fa2a5cb19beb3c34689218
---
A user/super/com/google/gwt/emul/java/lang/CloneNotSupportedException.java
M user/super/com/google/gwt/emul/java/lang/Object.java
2 files changed, 35 insertions(+), 0 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3616
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie89b7874953e1d6378fa2a5cb19beb3c34689218
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka 
Gerrit-Reviewer: Leeroy Jenkins 

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.