[gwt-contrib] Re: Update the Missing Plugin page for FF5 support (issue1465807)
On 2011/06/27 19:47:26, conroy wrote: True, but I don't want that to be a listing of every version we ever support. Instead, I'll just keep PPC marked as 3.x and the bifurcation of platform support can be inferred by the platforms that firefox supports at the various versions. I have re-exported and updated the firefox-old message to note that 5.0 as the upper bound. On Mon, Jun 27, 2011 at 3:42 PM, mailto:fabio...@google.com wrote: http://gwt-code-reviews.**appspot.com/1465807/diff/1/** plugins/MissingPlugin/war/**MissingPlugin.htmlhttp://gwt-code-reviews.appspot.com/1465807/diff/1/plugins/MissingPlugin/war/MissingPlugin.html File plugins/MissingPlugin/war/**MissingPlugin.html (right): http://gwt-code-reviews.**appspot.com/1465807/diff/1/** plugins/MissingPlugin/war/**MissingPlugin.html#newcode84http://gwt-code-reviews.appspot.com/1465807/diff/1/plugins/MissingPlugin/war/MissingPlugin.html#newcode84 plugins/MissingPlugin/war/**MissingPlugin.html:84: platforms : Win x86, Linux x86/x86_64, Mac x86/PPC(3.x only)/x86_64 (4.0+) only, can we safely say 4.0+? it seems ff versions are coming faster more furious then ever... http://gwt-code-reviews.**appspot.com/1465807/%3Chttp://gwt-code-reviews.appspot.com/1465807/ fine by me. LGTM just wanted to bring up that users will see/expect that missingplugin saying we support all FF versions but then potentially having the install failing. we probably need to keep an eye on the groups a clarify in the case it happens. go for it. http://gwt-code-reviews.appspot.com/1465807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Install files for version 1.0.10242 (Chrome,FFx,Safari) and 1.2.10242(IEx) (issue1449810)
On 2011/06/01 22:05:56, conroy wrote: On 2011/06/01 21:14:56, codefu wrote: On 2011/06/01 21:11:48, codefu wrote: Included are the binary files: gwt-dev-plugin.crx gwt-dev-plugin.xpi gwt-dev-plugin.dmg gwt-dev-plugin-x86.msi gwt-dev-plugin-x64.msi While you're tweaking the Chrome DevModeOptions, I think it would be useful to have labels for each of the input text boxes since it's not clear that they map to host + codeserver SGTM http://gwt-code-reviews.appspot.com/1449810/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] GWT support for Chrome Frame (issue1449808)
Reviewers: jgw, jlabanca,
Description:
GWT support for Chrome Frame
http://code.google.com/p/google-web-toolkit/issues/detail?id=5166
Please review this at http://gwt-code-reviews.appspot.com/1449808/
Affected files:
M user/src/com/google/gwt/user/rebind/UserAgentPropertyGenerator.java
Index: user/src/com/google/gwt/user/rebind/UserAgentPropertyGenerator.java
===
--- user/src/com/google/gwt/user/rebind/UserAgentPropertyGenerator.java
(revision 10241)
+++ user/src/com/google/gwt/user/rebind/UserAgentPropertyGenerator.java
(working copy)
@@ -55,10 +55,28 @@
.println(return (ua.indexOf('opera') != -1);)
.returns('opera'),
- // webkit family
+ // webkit family (chrome, safari and chromeframe).
new UserAgentPropertyGeneratorPredicate(safari)
.getPredicateBlock()
-.println(return (ua.indexOf('webkit') != -1);)
+.println(return ()
+ .println((ua.indexOf('webkit') != -1))
+ .println(||)
+ .println((function() {)
+.println(if (ua.indexOf('chromeframe') != -1) {)
+ .println(return true;)
+.println(})
+.println(if (typeof window['ActiveXObject'] != 'undefined')
{)
+ .println(try {)
+.println(var obj = new
ActiveXObject('ChromeTab.ChromeFrame');)
+.println(if (obj) {)
+ .println(obj.registerBhoIfNeeded();)
+ .println(return true;)
+.println(})
+ .println(} catch(e) { })
+.println(})
+.println(return false;)
+.println(})())
+.println())
.returns('safari'),
// IE9
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: * Soft permutations fail to collapse. Collapse 'derived' properties chain when 'parent' properti... (issue1424803)
http://gwt-code-reviews.appspot.com/1424803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: * Soft permutations fail to collapse. Collapse 'derived' properties chain when 'parent' properti... (issue1424803)
http://gwt-code-reviews.appspot.com/1424803/diff/1/dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java
File dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java
(right):
http://gwt-code-reviews.appspot.com/1424803/diff/1/dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java#newcode45
dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java:45: *
Collapses derived properties.
On 2011/04/18 22:35:35, bobv wrote:
Expand this comment to roughly describe the process implemented for
future
maintainers.
Done.
http://gwt-code-reviews.appspot.com/1424803/diff/1/dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java#newcode52
dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java:52: //
find collapsed properties
On 2011/04/18 22:35:35, bobv wrote:
For each input property, determine if it has a collapsed-value
equivalence set
containing the associated input value.
Done.
http://gwt-code-reviews.appspot.com/1424803/diff/1/dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java#newcode68
dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java:68:
MapString, ArrayListString dependencies = new TreeMapString,
ArrayListString();
On 2011/04/18 22:35:35, bobv wrote:
Make this a MapBindingProperty, ListString. Add doc: A map of
binding
properties to the names of the properties that must be evaluated prior
to
computing the value of the key object.
Done.
http://gwt-code-reviews.appspot.com/1424803/diff/1/dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java#newcode72
dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java:72: if
(deps.size() 0) {
On 2011/04/18 22:35:35, bobv wrote:
!deps.isEmpty()
Done.
http://gwt-code-reviews.appspot.com/1424803/diff/1/dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java#newcode76
dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java:76: for
(Map.EntryString, ArrayListString e : dependencies.entrySet()) {
On 2011/04/18 22:35:35, bobv wrote:
What is this loop doing?
Done.
http://gwt-code-reviews.appspot.com/1424803/diff/1/user/src/com/google/gwt/user/tools/templates/sample/_srcFolder_/_moduleFolder_/_moduleShortName_.gwt.xmlsrc
File
user/src/com/google/gwt/user/tools/templates/sample/_srcFolder_/_moduleFolder_/_moduleShortName_.gwt.xmlsrc
(right):
http://gwt-code-reviews.appspot.com/1424803/diff/1/user/src/com/google/gwt/user/tools/templates/sample/_srcFolder_/_moduleFolder_/_moduleShortName_.gwt.xmlsrc#newcode26
user/src/com/google/gwt/user/tools/templates/sample/_srcFolder_/_moduleFolder_/_moduleShortName_.gwt.xmlsrc:26:
permutations into a single compiled unit. As a consequence, collapsed
units
On 2011/04/18 22:35:35, bobv wrote:
into a single output file
Done.
http://gwt-code-reviews.appspot.com/1424803/diff/1/user/src/com/google/gwt/user/tools/templates/sample/_srcFolder_/_moduleFolder_/_moduleShortName_.gwt.xmlsrc#newcode39
user/src/com/google/gwt/user/tools/templates/sample/_srcFolder_/_moduleFolder_/_moduleShortName_.gwt.xmlsrc:39:
By default, GWT will collapse permutations of older and less used
browsers.
On 2011/04/18 22:35:35, bobv wrote:
s/GWT/this template/
?
http://gwt-code-reviews.appspot.com/1424803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: * Soft permutations fail to collapse. Collapse 'derived' properties chain when 'parent' properti... (issue1424803)
http://gwt-code-reviews.appspot.com/1424803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: * Soft permutations fail to collapse. Collapse 'derived' properties chain when 'parent' properti... (issue1424803)
http://gwt-code-reviews.appspot.com/1424803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] * Soft permutations fail to collapse. Collapse 'derived' properties chain when 'parent' properti... (issue1424803)
Reviewers: jlabanca, rjrjr, robertvawter, Description: * Soft permutations fail to collapse. Collapse 'derived' properties chain when 'parent' properties are collapsed. http://code.google.com/p/google-web-toolkit/issues/detail?id=6258 * Default project template collapses older browsers (ie6[7] and opera). Please review this at http://gwt-code-reviews.appspot.com/1424803/ Affected files: M dev/core/src/com/google/gwt/dev/Precompile.java M dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java M dev/core/test/com/google/gwt/dev/util/test/PropertyPermutationsTest.java M user/src/com/google/gwt/user/tools/templates/sample/_srcFolder_/_moduleFolder_/_moduleShortName_.gwt.xmlsrc -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: * Soft permutations fail to collapse. Collapse 'derived' properties chain when 'parent' properti... (issue1424803)
On 2011/04/18 19:09:21, fabiomfv wrote: ping http://gwt-code-reviews.appspot.com/1424803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: make it possible to just use devmode on a particular module while allowing the (issue1408802)
LGTM http://gwt-code-reviews.appspot.com/1408802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fixing typo in comments (issue1402802)
LGTM http://gwt-code-reviews.appspot.com/1402802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] ie9 bug fixes. (issue1383809)
Reviewers: jlabanca,
Description:
ie9 bug fixes.
Please review this at http://gwt-code-reviews.appspot.com/1383809/
Affected files:
M user/src/com/google/gwt/dom/client/DOMImplStandard.java
M user/src/com/google/gwt/user/client/ui/CheckBox.java
Index: user/src/com/google/gwt/dom/client/DOMImplStandard.java
===
--- user/src/com/google/gwt/dom/client/DOMImplStandard.java (revision 9888)
+++ user/src/com/google/gwt/dom/client/DOMImplStandard.java (working copy)
@@ -36,6 +36,7 @@
var elem = doc.createElement(INPUT);
elem.type = 'radio';
elem.name = name;
+elem.value = 'on';
return elem;
}-*/;
Index: user/src/com/google/gwt/user/client/ui/CheckBox.java
===
--- user/src/com/google/gwt/user/client/ui/CheckBox.java(revision 9888)
+++ user/src/com/google/gwt/user/client/ui/CheckBox.java(working copy)
@@ -85,6 +85,7 @@
public CheckBox() {
this(DOM.createInputCheck());
setStyleName(gwt-CheckBox);
+setFormValue(on);
}
/**
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] ie9 richtexteditor event fix. (issue1384808)
Reviewers: jlabanca,
Description:
ie9 richtexteditor event fix.
Please review this at http://gwt-code-reviews.appspot.com/1384808/
Affected files:
M user/src/com/google/gwt/user/client/ui/impl/RichTextAreaImplIE6.java
Index: user/src/com/google/gwt/user/client/ui/impl/RichTextAreaImplIE6.java
===
--- user/src/com/google/gwt/user/client/ui/impl/RichTextAreaImplIE6.java
(revision 9888)
+++ user/src/com/google/gwt/user/client/ui/impl/RichTextAreaImplIE6.java
(working copy)
@@ -91,12 +91,14 @@
var elem =
th...@com.google.gwt.user.client.ui.impl.RichTextAreaImpl::elem;
var body = elem.contentWindow.document.body;
-var handler = $entry(function() {
+var handler = $entry(function(evt) {
if (elem.__listener) {
if
(@com.google.gwt.user.client.impl.DOMImpl::isMyListener(Ljava/lang/Object;)(elem.__listener))
{
// Weird: this code has the context of the script frame, but we
need the
// event from the edit iframe's window.
- var evt = elem.contentWindow.event;
+ // this code is shared with all IE implementations (see
RichText.gwt.xml)
+ // the event can be passed in as argument (IE9) or from the
content window (IE8/7/6)
+ evt = evt || elem.contentWindow.event;
@com.google.gwt.user.client.DOM::dispatchEvent(Lcom/google/gwt/user/client/Event;Lcom/google/gwt/user/client/Element;Lcom/google/gwt/user/client/EventListener;)(evt,
elem, elem.__listener);
}
}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] non fatal js exception escapes in IE9 devmode. (issue1387802)
Reviewers: jlabanca,
Description:
non fatal js exception escapes in IE9 devmode.
http://code.google.com/p/google-web-toolkit/issues/detail?id=6135
Please review this at http://gwt-code-reviews.appspot.com/1387802/
Affected files:
M user/src/com/google/gwt/core/client/impl/Impl.java
M user/src/com/google/gwt/user/client/impl/DOMImplStandard.java
M user/src/com/google/gwt/user/client/impl/DOMImplStandardBase.java
Index: user/src/com/google/gwt/core/client/impl/Impl.java
===
--- user/src/com/google/gwt/core/client/impl/Impl.java (revision 9860)
+++ user/src/com/google/gwt/core/client/impl/Impl.java (working copy)
@@ -167,7 +167,7 @@
if (@com.google.gwt.core.client.GWT::isScript()()) {
return jsFunction.apply(thisObj, arguments);
} else {
- _ = jsFunction.apply(thisObj, arguments);
+ var _ = jsFunction.apply(thisObj, arguments);
if (_ != null) {
// Wrap for Development Mode
_ = Object(_);
Index: user/src/com/google/gwt/user/client/impl/DOMImplStandard.java
===
--- user/src/com/google/gwt/user/client/impl/DOMImplStandard.java (revision
9860)
+++ user/src/com/google/gwt/user/client/impl/DOMImplStandard.java (working
copy)
@@ -145,8 +145,38 @@
@Override
protected native void initEventSystem() /*-{
+
@com.google.gwt.user.client.impl.DOMImplStandard::dispatchCapturedEvent =
$entry(function(evt) {
+ if
(!@com.google.gwt.user.client.DOM::previewEvent(Lcom/google/gwt/user/client/Event;)(evt))
{
+evt.stopPropagation();
+evt.preventDefault();
+return false;
+ }
+ return true;
+});
+
+@com.google.gwt.user.client.impl.DOMImplStandard::dispatchEvent =
$entry(function(evt) {
+ var listener, curElem = this;
+ while (curElem !(listener = curElem.__listener)) {
+curElem = curElem.parentNode;
+ }
+ if (curElem curElem.nodeType != 1) {
+curElem = null;
+ }
+ if (listener) {
+if
(@com.google.gwt.user.client.impl.DOMImpl::isMyListener(Ljava/lang/Object;)(listener))
{
+
@com.google.gwt.user.client.DOM::dispatchEvent(Lcom/google/gwt/user/client/Event;Lcom/google/gwt/user/client/Element;Lcom/google/gwt/user/client/EventListener;)(evt,
curElem, listener);
+}
+ }
+});
+
+
@com.google.gwt.user.client.impl.DOMImplStandard::dispatchUnhandledEvent =
$entry(function(evt) {
+ this.__gwtLastUnhandledEvent = evt.type;
+
@com.google.gwt.user.client.impl.DOMImplStandard::dispatchEvent.call(this,
evt);
+});
+
@com.google.gwt.user.client.impl.DOMImplStandard::dispatchCapturedMouseEvent
= $entry(function(evt) {
- if
((@com.google.gwt.user.client.impl.DOMImplStandard::dispatchCapturedEvent)(evt))
{
+ var dispatchCapturedEventFn =
@com.google.gwt.user.client.impl.DOMImplStandard::dispatchCapturedEvent;
+ if (dispatchCapturedEventFn(evt)) {
var cap =
@com.google.gwt.user.client.impl.DOMImplStandard::captureElem;
if (cap cap.__listener) {
if
(@com.google.gwt.user.client.impl.DOMImpl::isMyListener(Ljava/lang/Object;)(cap.__listener))
{
@@ -155,38 +185,6 @@
}
}
}
-});
-
-
@com.google.gwt.user.client.impl.DOMImplStandard::dispatchCapturedEvent =
$entry(function(evt) {
- if
(!@com.google.gwt.user.client.DOM::previewEvent(Lcom/google/gwt/user/client/Event;)(evt))
{
-evt.stopPropagation();
-evt.preventDefault();
-return false;
- }
-
- return true;
-});
-
-
@com.google.gwt.user.client.impl.DOMImplStandard::dispatchUnhandledEvent =
$entry(function(evt) {
- this.__gwtLastUnhandledEvent = evt.type;
-
@com.google.gwt.user.client.impl.DOMImplStandard::dispatchEvent.call(this,
evt);
-});
-
-@com.google.gwt.user.client.impl.DOMImplStandard::dispatchEvent =
$entry(function(evt) {
- var listener, curElem = this;
- while (curElem !(listener = curElem.__listener)) {
-curElem = curElem.parentNode;
- }
-
- if (curElem curElem.nodeType != 1) {
-curElem = null;
- }
-
- if (listener) {
-if
(@com.google.gwt.user.client.impl.DOMImpl::isMyListener(Ljava/lang/Object;)(listener))
{
-
@com.google.gwt.user.client.DOM::dispatchEvent(Lcom/google/gwt/user/client/Event;Lcom/google/gwt/user/client/Element;Lcom/google/gwt/user/client/EventListener;)(evt,
curElem, listener);
-}
- }
});
$wnd.addEventListener('click',
@com.google.gwt.user.client.impl.DOMImplStandard::dispatchCapturedMouseEvent,
true);
Index: user/src/com/google/gwt/user/client/impl/DOMImplStandardBase.java
===
--- user/src/com/google/gwt/user/client/impl/DOMImplStandardBase.java
(revision
[gwt-contrib] Re: non fatal js exception escapes in IE9 devmode. (issue1387802)
http://gwt-code-reviews.appspot.com/1387802/diff/1/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java
File user/src/com/google/gwt/user/client/impl/DOMImplStandard.java
(right):
http://gwt-code-reviews.appspot.com/1387802/diff/1/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java#newcode179
user/src/com/google/gwt/user/client/impl/DOMImplStandard.java:179: if
(dispatchCapturedEventFn(evt)) {
On 2011/03/17 16:00:06, jlabanca wrote:
Why do we need to create the variable here?
Ie9 quirk. for some bizzare reason, that fails in IE9. since it's
harmless to just deref the function as var and then invoke, it makes ie9
happy.
http://gwt-code-reviews.appspot.com/1387802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: IE9 support (BETA). (issue1383801)
http://gwt-code-reviews.appspot.com/1383801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: IE9 support (BETA). (issue1383801)
http://gwt-code-reviews.appspot.com/1383801/diff/6001/dev/core/src/com/google/gwt/dev/shell/StandardRebindOracle.java File dev/core/src/com/google/gwt/dev/shell/StandardRebindOracle.java (right): http://gwt-code-reviews.appspot.com/1383801/diff/6001/dev/core/src/com/google/gwt/dev/shell/StandardRebindOracle.java#newcode164 dev/core/src/com/google/gwt/dev/shell/StandardRebindOracle.java:164: logger.log(TreeLogger.WARN, Could not find an exact match rule. Using 'closest' rule + On 2011/03/11 14:59:42, jlabanca wrote: I would prefer an INFO here. The only way to get rid of the warning is to add a rule for IE9 to every deferred binding, which suggests that falling back is wrong. I don't really agree with that, and I'm worried that this is going to spam builds. Done. http://gwt-code-reviews.appspot.com/1383801/diff/6001/user/src/com/google/gwt/dom/client/DOMImplStandardBase.java File user/src/com/google/gwt/dom/client/DOMImplStandardBase.java (right): http://gwt-code-reviews.appspot.com/1383801/diff/6001/user/src/com/google/gwt/dom/client/DOMImplStandardBase.java#newcode2 user/src/com/google/gwt/dom/client/DOMImplStandardBase.java:2: * Copyright 2010 Google Inc. On 2011/03/11 14:59:42, jlabanca wrote: 2011 Done. http://gwt-code-reviews.appspot.com/1383801/diff/6001/user/src/com/google/gwt/storage/Storage.gwt.xml File user/src/com/google/gwt/storage/Storage.gwt.xml (right): http://gwt-code-reviews.appspot.com/1383801/diff/6001/user/src/com/google/gwt/storage/Storage.gwt.xml#newcode44 user/src/com/google/gwt/storage/Storage.gwt.xml:44: when-property-is name=user.agent value=safari / On 2011/03/11 15:07:15, jlabanca wrote: Wrap with any tag Done. http://gwt-code-reviews.appspot.com/1383801/diff/6001/user/src/com/google/gwt/user/Tree.gwt.xml File user/src/com/google/gwt/user/Tree.gwt.xml (right): http://gwt-code-reviews.appspot.com/1383801/diff/6001/user/src/com/google/gwt/user/Tree.gwt.xml#newcode26 user/src/com/google/gwt/user/Tree.gwt.xml:26: when-property-is name=user.agent value=ie9/ On 2011/03/11 14:59:42, jlabanca wrote: Use consistent tabs, or convert all to spaces. Done. http://gwt-code-reviews.appspot.com/1383801/diff/6001/user/src/com/google/gwt/user/Window.gwt.xml File user/src/com/google/gwt/user/Window.gwt.xml (right): http://gwt-code-reviews.appspot.com/1383801/diff/6001/user/src/com/google/gwt/user/Window.gwt.xml#newcode28 user/src/com/google/gwt/user/Window.gwt.xml:28: when-property-is name=user.agent value=ie9/ On 2011/03/11 14:59:42, jlabanca wrote: convert to spaces Done. http://gwt-code-reviews.appspot.com/1383801/diff/6001/user/src/com/google/gwt/user/client/impl/DOMImplIE9.java File user/src/com/google/gwt/user/client/impl/DOMImplIE9.java (right): http://gwt-code-reviews.appspot.com/1383801/diff/6001/user/src/com/google/gwt/user/client/impl/DOMImplIE9.java#newcode2 user/src/com/google/gwt/user/client/impl/DOMImplIE9.java:2: * Copyright 2008 Google Inc. On 2011/03/11 14:59:42, jlabanca wrote: 2011 Done. http://gwt-code-reviews.appspot.com/1383801/diff/6001/user/src/com/google/gwt/user/client/impl/DOMImplStandardBase.java File user/src/com/google/gwt/user/client/impl/DOMImplStandardBase.java (right): http://gwt-code-reviews.appspot.com/1383801/diff/6001/user/src/com/google/gwt/user/client/impl/DOMImplStandardBase.java#newcode2 user/src/com/google/gwt/user/client/impl/DOMImplStandardBase.java:2: * Copyright 2008 Google Inc. On 2011/03/11 14:59:42, jlabanca wrote: 2011 Done. http://gwt-code-reviews.appspot.com/1383801/diff/6001/user/src/com/google/gwt/user/client/impl/DOMImplWebkit.java File user/src/com/google/gwt/user/client/impl/DOMImplWebkit.java (right): http://gwt-code-reviews.appspot.com/1383801/diff/6001/user/src/com/google/gwt/user/client/impl/DOMImplWebkit.java#newcode2 user/src/com/google/gwt/user/client/impl/DOMImplWebkit.java:2: * Copyright 2008 Google Inc. On 2011/03/11 14:59:42, jlabanca wrote: 2011 Done. http://gwt-code-reviews.appspot.com/1383801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Increasing the timeout of GWT user tests to 5 hours. Between the ever increasing number of test ... (issue1380803)
LGTM http://gwt-code-reviews.appspot.com/1380803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] IE9 support (BETA). (issue1383801)
Reviewers: jlabanca, rjrjr, jat, Description: IE9 support (BETA). known issues: IE9 devmode throws non fatal js exception. Please review this at http://gwt-code-reviews.appspot.com/1383801/ Affected files: M dev/core/src/com/google/gwt/dev/shell/StandardRebindOracle.java M user/src/com/google/gwt/dom/DOM.gwt.xml A user/src/com/google/gwt/dom/client/DOMImplIE9.java D user/src/com/google/gwt/dom/client/DOMImplSafari.java A user/src/com/google/gwt/dom/client/DOMImplStandardBase.java A user/src/com/google/gwt/dom/client/DOMImplWebkit.java M user/src/com/google/gwt/layout/Layout.gwt.xml M user/src/com/google/gwt/resources/Resources.gwt.xml M user/src/com/google/gwt/storage/Storage.gwt.xml M user/src/com/google/gwt/user/DOM.gwt.xml M user/src/com/google/gwt/user/Focus.gwt.xml M user/src/com/google/gwt/user/Hyperlink.gwt.xml M user/src/com/google/gwt/user/RichText.gwt.xml M user/src/com/google/gwt/user/Tree.gwt.xml M user/src/com/google/gwt/user/Window.gwt.xml M user/src/com/google/gwt/user/cellview/CellView.gwt.xml M user/src/com/google/gwt/user/cellview/client/CellBasedWidgetImplTrident.java A user/src/com/google/gwt/user/client/impl/DOMImplIE9.java D user/src/com/google/gwt/user/client/impl/DOMImplSafari.java A user/src/com/google/gwt/user/client/impl/DOMImplStandardBase.java A user/src/com/google/gwt/user/client/impl/DOMImplWebkit.java M user/src/com/google/gwt/xml/XML.gwt.xml M user/super/com/google/gwt/emul/EmulationWithUserAgent.gwt.xml M user/test/com/google/gwt/canvas/client/CanvasTest.java M user/test/com/google/gwt/canvas/dom/client/Context2dTest.java M user/test/com/google/gwt/storage/client/StorageTest.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] add ie9 user.agent with fallback binding to ie8. (in preparation for ie9 support). (issue1369808)
Reviewers: rjrjr, jlabanca, jat, Description: add ie9 user.agent with fallback binding to ie8. (in preparation for ie9 support). Please review this at http://gwt-code-reviews.appspot.com/1369808/ Affected files: M user/src/com/google/gwt/user/UserAgent.gwt.xml Index: user/src/com/google/gwt/user/UserAgent.gwt.xml === --- user/src/com/google/gwt/user/UserAgent.gwt.xml (revision 9822) +++ user/src/com/google/gwt/user/UserAgent.gwt.xml (working copy) @@ -24,6 +24,7 @@ extend-property name=user.agent values=gecko1_8 / extend-property name=user.agent values=safari / extend-property name=user.agent values=opera / + extend-property name=user.agent values=ie9 fallback-value=ie8 / property-provider name=user.agent generator=com.google.gwt.user.rebind.UserAgentPropertyGenerator/ !-- Set to false to avoid runtime warnings for mismatched runtime and -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] property fall back value evaluation scheme - enable fall back bindings. (issue1369807)
Reviewers: rjrjr, jat, bobv, jlabanca, fredsa, Description: property fall back value evaluation scheme - enable fall back bindings. Please review this at http://gwt-code-reviews.appspot.com/1369807/ Affected files: M dev/core/src/com/google/gwt/core/ext/DefaultSelectionProperty.java M dev/core/src/com/google/gwt/core/ext/SelectionProperty.java M dev/core/src/com/google/gwt/dev/cfg/BindingProperty.java M dev/core/src/com/google/gwt/dev/cfg/ConditionWhenPropertyIs.java M dev/core/src/com/google/gwt/dev/cfg/DeferredBindingQuery.java M dev/core/src/com/google/gwt/dev/cfg/ModuleDefSchema.java M dev/core/src/com/google/gwt/dev/cfg/Rule.java M dev/core/src/com/google/gwt/dev/cfg/StaticPropertyOracle.java M dev/core/src/com/google/gwt/dev/shell/ModuleSpacePropertyOracle.java M dev/core/src/com/google/gwt/dev/shell/StandardRebindOracle.java M dev/core/src/com/google/gwt/dev/util/xml/HandlerArgs.java M dev/core/src/com/google/gwt/dev/util/xml/HandlerParam.java M dev/core/test/com/google/gwt/dev/js/JsCoerceIntShiftTest.java M user/src/com/google/gwt/user/UserAgent.gwt.xml M user/src/com/google/gwt/user/rebind/UserAgentGenerator.java M user/src/com/google/gwt/user/rebind/UserAgentPropertyGenerator.java A user/src/com/google/gwt/user/rebind/UserAgentPropertyGeneratorPredicate.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: property fall back value evaluation scheme - enable fall back bindings. (issue1369807)
I agree that less permutations is better, but I would add a twist to the question: even if we could should we? if one could only predict all issues we will have with IE9 and then would we fix on safariimpl based on (is ua==msie)? fork then and implement implIE9 to fix something? I don't know of any test we can use to confidently assert that ie9 is and will be 100% safari friendly. I would vote for having it now and invest more time on trying to collapse if possible in increments. On 2011/03/04 19:12:30, rjrjr wrote: Does the new IE9 value for user.agent imply yet another permutation? We should really avoid that if we can, and so far it sounds like it might not be needed. Can we introduce IE9 without causing a new hard perm? On Fri, Mar 4, 2011 at 11:07 AM, https://mail.google.com/mail/?view=cmfs=1tf=1to=j...@google.com wrote: Mostly LGTM Needs a unit test for property fallback behavior. http://gwt-code-reviews.appspot.com/1369807/ http://gwt-code-reviews.appspot.com/1369807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: property fall back value evaluation scheme - enable fall back bindings. (issue1369807)
http://gwt-code-reviews.appspot.com/1369807/diff/1/dev/core/src/com/google/gwt/core/ext/DefaultSelectionProperty.java File dev/core/src/com/google/gwt/core/ext/DefaultSelectionProperty.java (right): http://gwt-code-reviews.appspot.com/1369807/diff/1/dev/core/src/com/google/gwt/core/ext/DefaultSelectionProperty.java#newcode89 dev/core/src/com/google/gwt/core/ext/DefaultSelectionProperty.java:89: On 2011/03/04 19:04:54, jlabanca wrote: extra spaces Done. http://gwt-code-reviews.appspot.com/1369807/diff/1/dev/core/src/com/google/gwt/dev/cfg/ModuleDefSchema.java File dev/core/src/com/google/gwt/dev/cfg/ModuleDefSchema.java (right): http://gwt-code-reviews.appspot.com/1369807/diff/1/dev/core/src/com/google/gwt/dev/cfg/ModuleDefSchema.java#newcode163 dev/core/src/com/google/gwt/dev/cfg/ModuleDefSchema.java:163: On 2011/03/04 19:04:54, jlabanca wrote: spaces Done. http://gwt-code-reviews.appspot.com/1369807/diff/1/dev/core/src/com/google/gwt/dev/shell/StandardRebindOracle.java File dev/core/src/com/google/gwt/dev/shell/StandardRebindOracle.java (right): http://gwt-code-reviews.appspot.com/1369807/diff/1/dev/core/src/com/google/gwt/dev/shell/StandardRebindOracle.java#newcode137 dev/core/src/com/google/gwt/dev/shell/StandardRebindOracle.java:137: On 2011/03/04 19:04:54, jlabanca wrote: spaces Done. http://gwt-code-reviews.appspot.com/1369807/diff/1/user/src/com/google/gwt/user/rebind/UserAgentPropertyGenerator.java File user/src/com/google/gwt/user/rebind/UserAgentPropertyGenerator.java (right): http://gwt-code-reviews.appspot.com/1369807/diff/1/user/src/com/google/gwt/user/rebind/UserAgentPropertyGenerator.java#newcode50 user/src/com/google/gwt/user/rebind/UserAgentPropertyGenerator.java:50: // Opera On 2011/03/04 19:04:54, jlabanca wrote: Move // Opera comment down a line. Done. http://gwt-code-reviews.appspot.com/1369807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] user.agent proposal. (issue1354806)
Reviewers: bobv, rjrjr,
Description:
user.agent proposal.
Please review this at http://gwt-code-reviews.appspot.com/1354806/show
Affected files:
M user/src/com/google/gwt/user/UserAgent.gwt.xml
Index: user/src/com/google/gwt/user/UserAgent.gwt.xml
===
--- user/src/com/google/gwt/user/UserAgent.gwt.xml (revision 9744)
+++ user/src/com/google/gwt/user/UserAgent.gwt.xml (working copy)
@@ -19,10 +19,77 @@
module
!-- Browser-sensitive code should use the 'user.agent' property --
- define-property name=user.agent
values=ie6,ie8,gecko1_8,safari,opera/
-
+
+ !--
+ DEPRECATED - prefer new user.agent.{ua}OrLater, where {ua} is a user
+ agent specification name.
+ example: user.agent.IE8OrLater
+ --
+ define-property name=user.agent
values=ie6,ie8,gecko1_8,safari,opera/
+
+ !-- todo: will go away once we agree on this plan - add remaining ua
(safari,ff, opera) --
property-provider name=user.agent
generator=com.google.gwt.user.rebind.UserAgentPropertyGenerator/
+ define-property name=user.agent.IE6OrLater values=true,false/
+ property-provider name=user.agent.IE6OrLater![CDATA[
+function makeVersion(result) {
+ return (parseInt(result[1]) * 1000) + parseInt(result[2]);
+}
+var ua = navigator.userAgent.toLowerCase();
+if (ua.indexOf(msie) != -1) {
+ var result = /msie ([0-9]+)\.([0-9]+)/.exec(ua);
+ if (result result.length == 3) {
+var v = makeVersion(result);
+if (v 7000) {
+ return true;
+}
+ }
+}
+return false;
+ ]]
+ /property-provider
+ set-property name=user.agent value=ie6
+when-property-is name=user.agent.IE6OrLater value=true/
+ /set-property
+
+ define-property name=user.agent.IE7OrLater values=true,false/
+ property-provider name=user.agent.IE7OrLater![CDATA[
+function makeVersion(result) {
+ return (parseInt(result[1]) * 1000) + parseInt(result[2]);
+}
+var ua = navigator.userAgent.toLowerCase();
+if (ua.indexOf(msie) != -1) {
+ var result = /msie ([0-9]+)\.([0-9]+)/.exec(ua);
+ if (result result.length == 3) {
+var v = makeVersion(result);
+if (v 8000) {
+ return true;
+}
+ }
+}
+return false;
+ ]]
+ /property-provider
+ set-property name=user.agent value=ie6
+when-property-is name=user.agent.IE7OrLater value=true/
+ /set-property
+
+ define-property name=user.agent.IE8OrLater values=true,false/
+ property-provider name=user.agent.IE8OrLater![CDATA[
+return ((navigator.userAgent.toLowerCase().indexOf('msie') != -1)
(document.documentMode == 8)).toString();
+ ]]
+ /property-provider
+ set-property name=user.agent value=ie8
+ when-property-is name=user.agent.IE8OrLater value=true/
+ /set-property
+
+ define-property name=user.agent.IE9OrLater values=true,false/
+ property-provider name=user.agent.IE9OrLater![CDATA[
+ return ((navigator.userAgent.toLowerCase().indexOf('msie') != -1)
(document.documentMode == 9)).toString();
+ ]]
+ /property-provider
+
+
!-- Set to false to avoid runtime warnings for mismatched runtime and
--
!-- compile time user.agent values --
define-configuration-property name=user.agent.runtimeWarning
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix the mac build for leopard users of the npapi/xpcom plugins. (issue1323802)
LTGM http://gwt-code-reviews.appspot.com/1323802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Update the mac xpcom plugin for Gecko 2.0 (FF4). This is a platform switch for (issue1311802)
LGTM http://gwt-code-reviews.appspot.com/1311802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Update MissingPlugin.html for FF4 support (issue1322802)
lgtm http://gwt-code-reviews.appspot.com/1322802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Update MissingPlugin.html to reflect new Chrome platform support (issue1184801)
LGTM http://gwt-code-reviews.appspot.com/1184801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: IE devmode plugin: 64 bits support end-to-end, build fixes cleanup, other polishing items. (issue1116801)
The binaries are part of the CL. it seems that rietveld does not show them, but you can see them in the internal tool. Also, legal cleared the inclusion of wix binaries under third_party. I added a README.txt under wix folder as suggested by legal (please eyeball it to make sure I did not write anything outrageous). http://gwt-code-reviews.appspot.com/1116801/diff/9001/10004 File plugins/ie/installer/README.txt (right): http://gwt-code-reviews.appspot.com/1116801/diff/9001/10004#newcode16 plugins/ie/installer/README.txt:16: 4) Test the installation. Yes, make sure it works on x86, x64, it cleans the registry and folder upon uninstall, etc. On 2010/12/01 16:46:48, jat wrote: Should stick to 80 columns in the text files. Done. http://gwt-code-reviews.appspot.com/1116801/diff/9001/10005 File plugins/ie/installer/build.cmd (right): http://gwt-code-reviews.appspot.com/1116801/diff/9001/10005#newcode28 plugins/ie/installer/build.cmd:28: %~dp0wix\heat.exe file %BINARY_DIR%\%BINARY_FILE% -v -nologo -gg -g1 -dr INSTALLDIR -generate components -directoryid ff -cg oophmDll -out %~dp0oophm.wxs -var var.binDir On 2010/12/01 16:46:48, jat wrote: What are the %~dp0* references? %~dp0 references the folder where the script is (that is different from %cd% as %cd% can change by script commands, whereas dp0 can be thought as the 'physical' location of the script). http://gwt-code-reviews.appspot.com/1116801/diff/9001/10009 File plugins/ie/installer/oophm.wxs (right): http://gwt-code-reviews.appspot.com/1116801/diff/9001/10009#newcode2 plugins/ie/installer/oophm.wxs:2: Wix xmlns=http://schemas.microsoft.com/wix/2006/wi; On 2010/12/01 16:46:48, jat wrote: Maybe this file should be renamed to DevModePlugin.wxs or something like that -- while it isn't worth it to clean up existing references to OOPHM in names, we probably shouldn't add any more. You should also get jlabanca to look over the WIX files, since he got that working initially. I will consider renaming on another change. since all references are to oophm, I would keep this name for the sake of consistency. please let me know if you feel strongly about this. Also, will fw to jlabanca for cr as well. http://gwt-code-reviews.appspot.com/1116801/diff/9001/10014 File plugins/ie/oophm/oophm/dllmain.cpp (right): http://gwt-code-reviews.appspot.com/1116801/diff/9001/10014#newcode34 plugins/ie/oophm/oophm/dllmain.cpp:34: DisableThreadLibraryCalls(hInstance); On 2010/12/01 16:46:48, jat wrote: Use spaces instead of tabs on these lines. Done. http://gwt-code-reviews.appspot.com/1116801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: IE devmode plugin: 64 bits support end-to-end, build fixes cleanup, other polishing items. (issue1116801)
http://gwt-code-reviews.appspot.com/1116801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: IE devmode plugin: 64 bits support end-to-end, build fixes cleanup, other polishing items. (issue1116801)
http://gwt-code-reviews.appspot.com/1116801/diff/1/6 File plugins/ie/installer/build.cmd (right): http://gwt-code-reviews.appspot.com/1116801/diff/1/6#newcode8 plugins/ie/installer/build.cmd:8: echo IMPORTANT: Make sure %~dp0oophm.wsx is checked out and writable! On 2010/11/18 16:17:54, conroy wrote: Rather than just blindly warning about this, why not test and error if the files aren't writable? Also, s/prebuild/prebuilt Done. http://gwt-code-reviews.appspot.com/1116801/diff/1/11 File plugins/ie/installer/wix/candle.exe.config (right): http://gwt-code-reviews.appspot.com/1116801/diff/1/11#newcode3 plugins/ie/installer/wix/candle.exe.config:3: Copyright (c) Microsoft Corporation. All rights reserved. On 2010/11/18 16:17:54, conroy wrote: does this msft copyright need to be here? if anything, shouldn't all these new files be getting the standard GWT copyright notice? this a MS tool licensed to OS. I believe removing the copyright might be an issue. http://gwt-code-reviews.appspot.com/1116801/diff/1/15 File plugins/ie/oophm/oophm/dllmain.cpp (right): http://gwt-code-reviews.appspot.com/1116801/diff/1/15#newcode36 plugins/ie/oophm/oophm/dllmain.cpp:36: AllowDialog::setHInstance(hInstance); On 2010/11/18 16:17:54, conroy wrote: indentation looks off here Done. http://gwt-code-reviews.appspot.com/1116801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: IE devmode plugin: 64 bits support end-to-end, build fixes cleanup, other polishing items. (issue1116801)
http://gwt-code-reviews.appspot.com/1116801/diff/1/11 File plugins/ie/installer/wix/candle.exe.config (right): http://gwt-code-reviews.appspot.com/1116801/diff/1/11#newcode3 plugins/ie/installer/wix/candle.exe.config:3: Copyright (c) Microsoft Corporation. All rights reserved. On 2010/11/22 16:40:40, fabiomfv wrote: On 2010/11/18 16:17:54, conroy wrote: does this msft copyright need to be here? if anything, shouldn't all these new files be getting the standard GWT copyright notice? this a MS tool licensed to OS. I believe removing the copyright might be an issue. I will check with legal just in case (thanks Philip). http://gwt-code-reviews.appspot.com/1116801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Add a permissions model to the Chrome NPAPI plugin. (issue1084801)
http://gwt-code-reviews.appspot.com/1084801/diff/57001/58022 File plugins/npapi/VisualStudio/npapi-plugin.sln (right): http://gwt-code-reviews.appspot.com/1084801/diff/57001/58022#newcode3 plugins/npapi/VisualStudio/npapi-plugin.sln:3: # Visual Studio 2008 On 2010/11/18 22:02:02, jat wrote: Are we making a conscious decision to drop support for VS2005? Yes. http://gwt-code-reviews.appspot.com/1084801/diff/57001/58023 File plugins/npapi/VisualStudio/npapi-plugin.vcproj (right): http://gwt-code-reviews.appspot.com/1084801/diff/57001/58023#newcode74 plugins/npapi/VisualStudio/npapi-plugin.vcproj:74: DataExecutionPrevention=0 On 2010/11/18 22:02:02, jat wrote: Why not DEP if we are switching to VS2008? mainly because there are known issues of DEP with ATL and we did not test that extensively. http://gwt-code-reviews.appspot.com/1084801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] IE devmode plugin: 64 bits support end-to-end, build fixes cleanup, other polishing items. (issue1115801)
Reviewers: jat, knorton, conroy, Description: IE devmode plugin: 64 bits support end-to-end, build fixes cleanup, other polishing items. Please review this at http://gwt-code-reviews.appspot.com/1115801/show Affected files: A plugins/ie/README.txt A plugins/ie/build.cmd D plugins/ie/build.xml M plugins/ie/installer/README.txt A plugins/ie/installer/build.cmd D plugins/ie/installer/build.xml A plugins/ie/installer/generate-wxsfile.cmd M plugins/ie/installer/installer.wxs.xml A plugins/ie/installer/oophm.wxs A plugins/ie/installer/wix/candle.exe.config A plugins/ie/installer/wix/heat.exe.config A plugins/ie/installer/wix/light.exe.config M plugins/ie/oophm/oophm.sln M plugins/ie/oophm/oophm/dllmain.cpp M plugins/ie/oophm/oophm/oophm.vcproj M plugins/ie/oophm/oophm/plugin.htm -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Add a permissions model to the Chrome NPAPI plugin. (issue1084801)
http://gwt-code-reviews.appspot.com/1084801/diff/28001/29020 File plugins/npapi/VisualStudio/npapi-plugin.vcproj (left): http://gwt-code-reviews.appspot.com/1084801/diff/28001/29020#oldcode1 plugins/npapi/VisualStudio/npapi-plugin.vcproj:1: ?xml version=1.0 encoding=UTF-8? not sure how you are building this project. I could not find any targets in build.xml or any other reference to devenv.exe you may also want to double check that the bin is release flavor as the default is debug when you invoke vs build. http://gwt-code-reviews.appspot.com/1084801/diff/28001/29020#oldcode4 plugins/npapi/VisualStudio/npapi-plugin.vcproj:4: Version=8.00 not sure what the intent was, but if you put back allowdialog.h you will need to add allowdialog.cpp in the project as well. http://gwt-code-reviews.appspot.com/1084801/diff/28001/29020#oldcode7 plugins/npapi/VisualStudio/npapi-plugin.vcproj:7: RootNamespace=npapi-plugin Also, maybe it will be in the next step, but It seems that the out bin is not checked out for replacement. I am guessing it will done a later step. http://gwt-code-reviews.appspot.com/1084801/diff/28001/29020#oldcode9 plugins/npapi/VisualStudio/npapi-plugin.vcproj:9: I made most of these fixes on my box and it is building fine. if you will I can roll them in your CL, bar knowing how you want to invoke the vs build. http://gwt-code-reviews.appspot.com/1084801/diff/28001/29028 File plugins/platform/Win/AllowDialog.h (left): http://gwt-code-reviews.appspot.com/1084801/diff/28001/29028#oldcode1 plugins/platform/Win/AllowDialog.h:1: #ifndef _H_AllowDialog looks like allowdialog.h is still referenced in main.cpp. http://gwt-code-reviews.appspot.com/1084801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Add a permissions model to the Chrome NPAPI plugin. (issue1084801)
http://gwt-code-reviews.appspot.com/1084801/diff/28001/29020 File plugins/npapi/VisualStudio/npapi-plugin.vcproj (left): http://gwt-code-reviews.appspot.com/1084801/diff/28001/29020#oldcode1 plugins/npapi/VisualStudio/npapi-plugin.vcproj:1: ?xml version=1.0 encoding=UTF-8? On 2010/11/12 21:53:42, conroy wrote: On 2010/11/12 20:50:38, fabiomfv wrote: not sure how you are building this project. I could not find any targets in build.xml or any other reference to devenv.exe you may also want to double check that the bin is release flavor as the default is debug when you invoke vs build. huh? the build.xml is brand new and is just for building the DevModeOptions GWT module. I meant to ask how we build the plugin for windows. what invokes the project (msbuild, devenv, ant) to build. I just wanted to make sure we can build this solution successfully with these changes. http://gwt-code-reviews.appspot.com/1084801/diff/28001/29020#oldcode4 plugins/npapi/VisualStudio/npapi-plugin.vcproj:4: Version=8.00 On 2010/11/12 21:53:42, conroy wrote: On 2010/11/12 20:50:38, fabiomfv wrote: not sure what the intent was, but if you put back allowdialog.h you will need to add allowdialog.cpp in the project as well. the intent is to nuke it so we have a common, platform independent UI. my comment is that the vcproj as-is is broken and will not build. http://gwt-code-reviews.appspot.com/1084801/diff/28001/29020#oldcode9 plugins/npapi/VisualStudio/npapi-plugin.vcproj:9: On 2010/11/12 21:53:42, conroy wrote: On 2010/11/12 20:50:38, fabiomfv wrote: I made most of these fixes on my box and it is building fine. if you will I can roll them in your CL, bar knowing how you want to invoke the vs build. my only changes here are just to nuke the allowdialog/preferences stuff. hopefully these changes didn't break the build. are you saying the build was already borked before this CL? i think the mechanism for building before was just invoking the build in VS, no? in either case, send me a patch and I'll update accordingly. I just wanted to brought up that allowdialog.h was deleted in the CL and main.cpp still references it int the windows build. this will break the build for windows. http://gwt-code-reviews.appspot.com/1084801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: The proposed fix will disambiguate setter overloads by ranking them according (issue993801)
ping. On 2010/10/14 19:46:03, fabiomfv wrote: +1. there is the possibility of choosing incorrectly since we are not able to look at the parameter type 'passed in' (proposed fix 2 would work on that basis, but is a higher impact change). As Ray mentioned, the safe workaround is to provide a different name. On Thu, Oct 14, 2010 at 3:22 PM, Ray Ryan mailto:rj...@google.com wrote: By providing a setter with a different name, I guess. An alternative would be to provide a new annotation, but that still presumes that they control the widget source, not much of a win. On Thu, Oct 14, 2010 at 12:11 PM, mailto:b...@google.com wrote: How does the user override the heuristic if it chooses incorrectly? http://gwt-code-reviews.appspot.com/993801/show http://gwt-code-reviews.appspot.com/993801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Update the npapi plugin to support OSX. (issue1036801)
http://gwt-code-reviews.appspot.com/1036801/diff/6001/7001 File plugins/npapi/Makefile (right): http://gwt-code-reviews.appspot.com/1036801/diff/6001/7001#newcode47 plugins/npapi/Makefile:47: CFLAGS += -DBROWSER_NPAPI -DXP_UNIX -fshort-wchar out of curiosity, why are we defining XP_UNIX for a presumably mac build? http://gwt-code-reviews.appspot.com/1036801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Update the npapi plugin to support OSX. (issue1036801)
On 2010/10/20 19:44:12, conroy wrote: http://gwt-code-reviews.appspot.com/1036801/diff/6001/7001 File plugins/npapi/Makefile (right): http://gwt-code-reviews.appspot.com/1036801/diff/6001/7001#newcode47 plugins/npapi/Makefile:47: CFLAGS += -DBROWSER_NPAPI -DXP_UNIX -fshort-wchar On 2010/10/20 19:31:06, fabiomfv wrote: out of curiosity, why are we defining XP_UNIX for a presumably mac build? Mac is a variant of Unix. The other npapi plugin code I looked at all defined XP_UNIX for both linux and mac builds. I guess want I really meant was why we don't need XP_MACOSX explicitly and only XP_UNIX? for instance, looking at makefile.mac it seems they refer to both. http://gwt-code-reviews.appspot.com/1036801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Update the npapi plugin to support OSX. (issue1036801)
On 2010/10/20 20:06:42, conroy wrote: I'm glad you mention this: In the latest version of the patch I'm nuking Makefile.mac (amongst other cruft) since unused bits like this laying around just cause confusion. XP_MACOSX is set higher up in the Makefile on the OS==mac check. I set XP_UNIX there so that linux and mac can share it. On Wed, Oct 20, 2010 at 4:00 PM, mailto:fabio...@google.com wrote: On 2010/10/20 19:44:12, conroy wrote: http://gwt-code-reviews.appspot.com/1036801/diff/6001/7001 File plugins/npapi/Makefile (right): http://gwt-code-reviews.appspot.com/1036801/diff/6001/7001#newcode47 plugins/npapi/Makefile:47: CFLAGS += -DBROWSER_NPAPI -DXP_UNIX -fshort-wchar On 2010/10/20 19:31:06, fabiomfv wrote: out of curiosity, why are we defining XP_UNIX for a presumably mac build? Mac is a variant of Unix. The other npapi plugin code I looked at all defined XP_UNIX for both linux and mac builds. I guess want I really meant was why we don't need XP_MACOSX explicitly and only XP_UNIX? for instance, looking at makefile.mac it seems they refer to both. http://gwt-code-reviews.appspot.com/1036801/show Sorry, somehow I did not see the XP_MACOSX def up above the script (I guess I am still getting used to the rietveld review ui). LGTM2 http://gwt-code-reviews.appspot.com/1036801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: The proposed fix will disambiguate setter overloads by ranking them according (issue993801)
http://gwt-code-reviews.appspot.com/993801/diff/1/2
File user/src/com/google/gwt/uibinder/rebind/model/OwnerFieldClass.java
(right):
http://gwt-code-reviews.appspot.com/993801/diff/1/2#newcode46
user/src/com/google/gwt/uibinder/rebind/model/OwnerFieldClass.java:46:
private static HashMapString, Integer typeRank;
On 2010/10/13 20:50:11, rjrjr wrote:
Make this final. You can build it in another map in your static
initializer, and
fill in typeRank via Collections.unmodifiableMap()
Done.
http://gwt-code-reviews.appspot.com/993801/diff/1/2#newcode46
user/src/com/google/gwt/uibinder/rebind/model/OwnerFieldClass.java:46:
private static HashMapString, Integer typeRank;
On 2010/10/13 20:50:11, rjrjr wrote:
Make this final. You can build it in another map in your static
initializer, and
fill in typeRank via Collections.unmodifiableMap()
Done.
http://gwt-code-reviews.appspot.com/993801/diff/1/2#newcode51
user/src/com/google/gwt/uibinder/rebind/model/OwnerFieldClass.java:51:
typeRank.put(java.lang.Boolean, 2);
On 2010/10/13 20:50:11, rjrjr wrote:
Seems like you could rank the java.lang types as 3, so that you prefer
setBaz(boolean) to setBaz(Boolean). (Remember to add that test if you
make this
change, and to set your default cost to 4. And you might want to put
that
default cost in a constant next to this map.)
I will take your suggestion, though it is not entirely clear to me the
benefits of this approach. the original thinking was that a type would
be either in the primitive type family or in the reference type family.
the current approach was to choose the autoboxed primitive types as
reference types the same way java treats boxed primitive types. anyhow,
I think you are right.
http://gwt-code-reviews.appspot.com/993801/diff/1/2#newcode186
user/src/com/google/gwt/uibinder/rebind/model/OwnerFieldClass.java:186:
!sameParameterTypes(preferredMethod, method)) {
On 2010/10/13 20:50:11, rjrjr wrote:
The sameParameterTypes call is required to distinguish overrides from
super
methods, right?
yes. when you say 'mention that', I am assuming you mean comment that.
(done).
Should mention that, and be sure unit test covers it.
2) Will add a specific unit test for this case. just to be clear on what
to expect in terms of behavior, an overridden method with the same
formal signature will *not* be considered ambiguous.
http://gwt-code-reviews.appspot.com/993801/diff/1/2#newcode334
user/src/com/google/gwt/uibinder/rebind/model/OwnerFieldClass.java:334:
* Ranks given method based on parameter conversion cost.
On 2010/10/13 20:50:11, rjrjr wrote:
Please document the ranking here, like you did in the patch
description
Done.
http://gwt-code-reviews.appspot.com/993801/diff/1/2#newcode362
user/src/com/google/gwt/uibinder/rebind/model/OwnerFieldClass.java:362:
private boolean sameParameterTypes(final JMethod m1, final JMethod m2) {
On 2010/10/13 20:50:11, rjrjr wrote:
why?
Done.
http://gwt-code-reviews.appspot.com/993801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: The proposed fix will disambiguate setter overloads by ranking them according (issue993801)
http://gwt-code-reviews.appspot.com/993801/diff/1/3
File
user/test/com/google/gwt/uibinder/rebind/model/OwnerFieldClassTest.java
(right):
http://gwt-code-reviews.appspot.com/993801/diff/1/3#newcode146
user/test/com/google/gwt/uibinder/rebind/model/OwnerFieldClassTest.java:146:
public void testCheckBoxValueSetters() throws Exception {
On 2010/10/13 20:50:11, rjrjr wrote:
Thanks for the test, but you need more to cover your various ranking
scenarios.
Done.
http://gwt-code-reviews.appspot.com/993801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: The proposed fix will disambiguate setter overloads by ranking them according (issue993801)
http://gwt-code-reviews.appspot.com/993801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] The proposed fix will disambiguate setter overloads by ranking them according (issue993801)
Reviewers: rjrjr, Description: The proposed fix will disambiguate setter overloads by ranking them according to the 'cost' of conversion. Fewer arguments will be preferred over many arguments (e.g. setValue(boolean) will be preferred over setValue(boolean, boolean)). Within a group os setters with the same number of arguments, Strings will be preferred over other primitive types (boxed or not); and primitive types will be preferred over non-primitive types. The fix also reduces the need of two passes over the list of setters during disambiguation, now done in one pass. Please review this at http://gwt-code-reviews.appspot.com/993801/show Affected files: M user/src/com/google/gwt/uibinder/rebind/model/OwnerFieldClass.java M user/test/com/google/gwt/uibinder/rebind/model/OwnerFieldClassTest.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
