[gwt-contrib] Again restore r10697 now that LazyPanel support is more robust. (issue1579803)
Reviewers: rchandia,
Description:
Again restore r10697 now that LazyPanel support is more robust.
*** Original change description ***
Change default of UiBinder.useLazyWidgetBuilders to true, in
preparation for deleting the old code.
Please review this at http://gwt-code-reviews.appspot.com/1579803/
Affected files:
M user/src/com/google/gwt/uibinder/UiBinder.gwt.xml
M user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java
M user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
Index: user/src/com/google/gwt/uibinder/UiBinder.gwt.xml
===
--- user/src/com/google/gwt/uibinder/UiBinder.gwt.xml (revision 10719)
+++ user/src/com/google/gwt/uibinder/UiBinder.gwt.xml (working copy)
@@ -27,11 +27,11 @@
is-multi-valued="false"/>
value="true"/>
-
+
is-multi-valued="false"/>
- value="false"/>
+ value="true"/>
class="com.google.gwt.uibinder.client.UiRenderer"/>
Index: user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java
===
--- user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java
(revision 10719)
+++ user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java (working
copy)
@@ -52,6 +52,7 @@
private static final String LAZY_WIDGET_BUILDERS_PROPERTY
= "UiBinder.useLazyWidgetBuilders";
private static boolean gaveSafeHtmlWarning;
+ private static boolean gaveLazyBuildersWarning;
/**
* Given a UiBinder interface, return the path to its ui.xml file,
suitable
@@ -212,7 +213,14 @@
}
private Boolean useLazyWidgetBuilders(MortalLogger logger,
PropertyOracle propertyOracle) {
-return extractConfigProperty(logger, propertyOracle,
LAZY_WIDGET_BUILDERS_PROPERTY, false);
+Boolean rtn = extractConfigProperty(logger, propertyOracle,
LAZY_WIDGET_BUILDERS_PROPERTY, false);
+if (!gaveLazyBuildersWarning && !rtn) {
+ logger.warn("Configuration property %s is false. Deprecated code
generation is in play. " +
+ "This property will soon become a no-op.",
+ LAZY_WIDGET_BUILDERS_PROPERTY);
+ gaveLazyBuildersWarning = true;
+}
+return rtn;
}
private Boolean useSafeHtmlTemplates(MortalLogger logger, PropertyOracle
propertyOracle) {
@@ -221,7 +229,8 @@
if (!gaveSafeHtmlWarning && !rtn) {
logger.warn("Configuration property %s is false! UiBinder SafeHtml
integration is off, "
- + "leaving your users more vulnerable to cross-site scripting
attacks.",
+ + "leaving your users more vulnerable to cross-site scripting
attacks. This property " +
+ "will soon become a no-op, and SafeHtml integration will always
be on.",
XSS_SAFE_CONFIG_PROPERTY);
gaveSafeHtmlWarning = true;
}
Index: user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
===
--- user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java (revision
10719)
+++ user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java (working
copy)
@@ -1006,7 +1006,7 @@
*/
public String tokenForSafeUriExpression(XMLElement source, String
expression) {
if (!useSafeHtmlTemplates) {
- return tokenForStringExpression(source, expression + ".asString()");
+ return tokenForStringExpression(source, expression);
}
htmlTemplates.noteUri(expression);
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Keeps LazyPanelParser from breaking existing templates that use (issue1577804)
Reviewers: rchandia, Description: Keeps LazyPanelParser from breaking existing templates that use @UiField(provided = true) to get LazyPanels into templates. Please review this at http://gwt-code-reviews.appspot.com/1577804/ Affected files: M user/src/com/google/gwt/uibinder/elementparsers/LazyPanelParser.java M user/test/com/google/gwt/uibinder/LazyWidgetBuilderSuite.java M user/test/com/google/gwt/uibinder/test/client/CellPanelParserIntegrationTest.java A user/test/com/google/gwt/uibinder/test/client/LazyPanelParserIntegrationTest.Renderable.ui.xml A user/test/com/google/gwt/uibinder/test/client/LazyPanelParserIntegrationTest.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Restores r10697 now that the CellPanelParser fixes are in place (issue1578803)
Reviewers: rchandia,
Description:
Restores r10697 now that the CellPanelParser fixes are in place
*** Original change description ***
Change default of UiBinder.useLazyWidgetBuilders to true, in
preparation for deleting the old code.
Also fixes unreported bad code gen for things like
when
safehtml is off. Fix is a bit squirrelly, but
Please review this at http://gwt-code-reviews.appspot.com/1578803/
Affected files:
M user/src/com/google/gwt/uibinder/UiBinder.gwt.xml
M user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java
M user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
Index: user/src/com/google/gwt/uibinder/UiBinder.gwt.xml
===
--- user/src/com/google/gwt/uibinder/UiBinder.gwt.xml (revision 10709)
+++ user/src/com/google/gwt/uibinder/UiBinder.gwt.xml (working copy)
@@ -27,11 +27,11 @@
is-multi-valued="false"/>
value="true"/>
-
+
is-multi-valued="false"/>
- value="false"/>
+ value="true"/>
class="com.google.gwt.uibinder.client.UiRenderer"/>
Index: user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java
===
--- user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java
(revision 10709)
+++ user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java (working
copy)
@@ -52,6 +52,7 @@
private static final String LAZY_WIDGET_BUILDERS_PROPERTY
= "UiBinder.useLazyWidgetBuilders";
private static boolean gaveSafeHtmlWarning;
+ private static boolean gaveLazyBuildersWarning;
/**
* Given a UiBinder interface, return the path to its ui.xml file,
suitable
@@ -212,7 +213,14 @@
}
private Boolean useLazyWidgetBuilders(MortalLogger logger,
PropertyOracle propertyOracle) {
-return extractConfigProperty(logger, propertyOracle,
LAZY_WIDGET_BUILDERS_PROPERTY, false);
+Boolean rtn = extractConfigProperty(logger, propertyOracle,
LAZY_WIDGET_BUILDERS_PROPERTY, false);
+if (!gaveLazyBuildersWarning && !rtn) {
+ logger.warn("Configuration property %s is false. Deprecated code
generation is in play. " +
+ "This property will soon become a no-op.",
+ LAZY_WIDGET_BUILDERS_PROPERTY);
+ gaveLazyBuildersWarning = true;
+}
+return rtn;
}
private Boolean useSafeHtmlTemplates(MortalLogger logger, PropertyOracle
propertyOracle) {
@@ -221,7 +229,8 @@
if (!gaveSafeHtmlWarning && !rtn) {
logger.warn("Configuration property %s is false! UiBinder SafeHtml
integration is off, "
- + "leaving your users more vulnerable to cross-site scripting
attacks.",
+ + "leaving your users more vulnerable to cross-site scripting
attacks. This property " +
+ "will soon become a no-op, and SafeHtml integration will always
be on.",
XSS_SAFE_CONFIG_PROPERTY);
gaveSafeHtmlWarning = true;
}
Index: user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
===
--- user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java (revision
10709)
+++ user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java (working
copy)
@@ -1006,7 +1006,7 @@
*/
public String tokenForSafeUriExpression(XMLElement source, String
expression) {
if (!useSafeHtmlTemplates) {
- return tokenForStringExpression(source, expression + ".asString()");
+ return tokenForStringExpression(source, expression);
}
htmlTemplates.noteUri(expression);
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Small fix to CellPanelParser to make it work with lazy widget (issue1577803)
http://gwt-code-reviews.appspot.com/1577803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Small fix to CellPanelParser to make it work with lazy widget (issue1577803)
http://gwt-code-reviews.appspot.com/1577803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Add the final two TCK test classes. (issue1576803)
LGTM http://gwt-code-reviews.appspot.com/1576803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: The rest of the TCK xml tests. (issue1573805)
LGTM http://gwt-code-reviews.appspot.com/1573805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Makes sure the RenderablePanel inherits all attributes from the PotentialElement when realizing ... (issue1556805)
LGTM http://gwt-code-reviews.appspot.com/1556805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Re-submit: Iterating over all attributed when realizing PotentialElements. (issue1573804)
LGTM Looks good again. What was the fix? http://gwt-code-reviews.appspot.com/1573804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Keep track of TCK coverage. (issue1575803)
LGTM http://gwt-code-reviews.appspot.com/1575803/diff/5001/user/style/html/junit-noframes.xsl File user/style/html/junit-noframes.xsl (right): http://gwt-code-reviews.appspot.com/1575803/diff/5001/user/style/html/junit-noframes.xsl#newcode287 user/style/html/junit-noframes.xsl:287: indentation is a bit wonky http://gwt-code-reviews.appspot.com/1575803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Change default of UiBinder.useLazyWidgetBuilders to true, in (issue1574803)
No broken test, ready for review. http://gwt-code-reviews.appspot.com/1574803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Keep track of TCK coverage. (issue1575803)
On 2011/10/17 18:35:43, Nick Chalko wrote: Redundant with http://gwt-code-reviews.appspot.com/1567804/? http://gwt-code-reviews.appspot.com/1575803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: More TCK tests (issue1567804)
LGTM http://gwt-code-reviews.appspot.com/1567804/diff/1/user/test/org/hibernate/jsr303/tck/tests/bootstrap/customprovider/TckTest.gwt.xml File user/test/org/hibernate/jsr303/tck/tests/bootstrap/customprovider/TckTest.gwt.xml (right): http://gwt-code-reviews.appspot.com/1567804/diff/1/user/test/org/hibernate/jsr303/tck/tests/bootstrap/customprovider/TckTest.gwt.xml#newcode4 user/test/org/hibernate/jsr303/tck/tests/bootstrap/customprovider/TckTest.gwt.xml:4: Copyright 2010 Google Inc. 2011. Others? http://gwt-code-reviews.appspot.com/1567804/diff/1/user/test/org/hibernate/jsr303/tck/tests/bootstrap/customprovider/TckTestValidatorFactory.java File user/test/org/hibernate/jsr303/tck/tests/bootstrap/customprovider/TckTestValidatorFactory.java (right): http://gwt-code-reviews.appspot.com/1567804/diff/1/user/test/org/hibernate/jsr303/tck/tests/bootstrap/customprovider/TckTestValidatorFactory.java#newcode16 user/test/org/hibernate/jsr303/tck/tests/bootstrap/customprovider/TckTestValidatorFactory.java:16: package org.hibernate.jsr303.tck.tests.bootstrap.customprovider; Is it really appropriate for this to be in the org.hibernate space rather than com.google.gwt? http://gwt-code-reviews.appspot.com/1567804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Change default of UiBinder.useLazyWidgetBuilders to true, in (issue1574803)
Oops, I think my fix actually broke a test, still digging. I'll ping when this is really ready. http://gwt-code-reviews.appspot.com/1574803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change default of UiBinder.useLazyWidgetBuilders to true, in (issue1574803)
Reviewers: rchandia,
Description:
Change default of UiBinder.useLazyWidgetBuilders to true, in
preparation for deleting the old code.
Also fixes unreported bad code gen for things like
when
safehtml is off. Fix is a bit squirrelly, but the intent is to delete
the code
in question almost immediately if nothing blows up with new default.
Review by: rchan...@google.com
Please review this at http://gwt-code-reviews.appspot.com/1574803/
Affected files:
M user/src/com/google/gwt/uibinder/UiBinder.gwt.xml
M user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java
M user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
Index: user/src/com/google/gwt/uibinder/UiBinder.gwt.xml
===
--- user/src/com/google/gwt/uibinder/UiBinder.gwt.xml (revision 10704)
+++ user/src/com/google/gwt/uibinder/UiBinder.gwt.xml (working copy)
@@ -27,11 +27,11 @@
is-multi-valued="false"/>
value="true"/>
-
+
is-multi-valued="false"/>
- value="false"/>
+ value="true"/>
class="com.google.gwt.uibinder.client.UiRenderer"/>
Index: user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java
===
--- user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java
(revision 10704)
+++ user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java (working
copy)
@@ -52,6 +52,7 @@
private static final String LAZY_WIDGET_BUILDERS_PROPERTY
= "UiBinder.useLazyWidgetBuilders";
private static boolean gaveSafeHtmlWarning;
+ private static boolean gaveLazyBuildersWarning;
/**
* Given a UiBinder interface, return the path to its ui.xml file,
suitable
@@ -212,7 +213,14 @@
}
private Boolean useLazyWidgetBuilders(MortalLogger logger,
PropertyOracle propertyOracle) {
-return extractConfigProperty(logger, propertyOracle,
LAZY_WIDGET_BUILDERS_PROPERTY, false);
+Boolean rtn = extractConfigProperty(logger, propertyOracle,
LAZY_WIDGET_BUILDERS_PROPERTY, false);
+if (!gaveLazyBuildersWarning && !rtn) {
+ logger.warn("Configuration property %s is false. Deprecated code
generation is in play. " +
+ "This property will soon become a no-op.",
+ LAZY_WIDGET_BUILDERS_PROPERTY);
+ gaveLazyBuildersWarning = true;
+}
+return rtn;
}
private Boolean useSafeHtmlTemplates(MortalLogger logger, PropertyOracle
propertyOracle) {
@@ -221,7 +229,8 @@
if (!gaveSafeHtmlWarning && !rtn) {
logger.warn("Configuration property %s is false! UiBinder SafeHtml
integration is off, "
- + "leaving your users more vulnerable to cross-site scripting
attacks.",
+ + "leaving your users more vulnerable to cross-site scripting
attacks. This property " +
+ "will soon become a no-op, and SafeHtml integration will always
be on.",
XSS_SAFE_CONFIG_PROPERTY);
gaveSafeHtmlWarning = true;
}
Index: user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
===
--- user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java (revision
10704)
+++ user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java (working
copy)
@@ -1030,7 +1030,7 @@
*/
public String tokenForSafeUriExpression(XMLElement source, String
expression) {
if (!useSafeHtmlTemplates) {
- return tokenForStringExpression(source, expression + ".asString()");
+ return tokenForStringExpression(source, expression);
}
htmlTemplates.noteUri(expression);
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change default of UiBinder.useLazyWidgetBuilders to true, in (issue1572803)
Reviewers: rchandia,
Description:
Change default of UiBinder.useLazyWidgetBuilders to true, in
preparation for deleting the old code.
Please review this at http://gwt-code-reviews.appspot.com/1572803/
Affected files:
M user/src/com/google/gwt/uibinder/UiBinder.gwt.xml
M user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java
M user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
Index: user/src/com/google/gwt/uibinder/UiBinder.gwt.xml
===
--- user/src/com/google/gwt/uibinder/UiBinder.gwt.xml (revision 10704)
+++ user/src/com/google/gwt/uibinder/UiBinder.gwt.xml (working copy)
@@ -27,11 +27,11 @@
is-multi-valued="false"/>
value="true"/>
-
+
is-multi-valued="false"/>
- value="false"/>
+ value="true"/>
class="com.google.gwt.uibinder.client.UiRenderer"/>
Index: user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java
===
--- user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java
(revision 10704)
+++ user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java (working
copy)
@@ -52,6 +52,7 @@
private static final String LAZY_WIDGET_BUILDERS_PROPERTY
= "UiBinder.useLazyWidgetBuilders";
private static boolean gaveSafeHtmlWarning;
+ private static boolean gaveLazyBuildersWarning;
/**
* Given a UiBinder interface, return the path to its ui.xml file,
suitable
@@ -212,7 +213,14 @@
}
private Boolean useLazyWidgetBuilders(MortalLogger logger,
PropertyOracle propertyOracle) {
-return extractConfigProperty(logger, propertyOracle,
LAZY_WIDGET_BUILDERS_PROPERTY, false);
+Boolean rtn = extractConfigProperty(logger, propertyOracle,
LAZY_WIDGET_BUILDERS_PROPERTY, false);
+if (!gaveLazyBuildersWarning && !rtn) {
+ logger.warn("Configuration property %s is false. Deprecated code
generation is in play. " +
+ "This property will soon become a no-op.",
+ LAZY_WIDGET_BUILDERS_PROPERTY);
+ gaveLazyBuildersWarning = true;
+}
+return rtn;
}
private Boolean useSafeHtmlTemplates(MortalLogger logger, PropertyOracle
propertyOracle) {
@@ -221,7 +229,8 @@
if (!gaveSafeHtmlWarning && !rtn) {
logger.warn("Configuration property %s is false! UiBinder SafeHtml
integration is off, "
- + "leaving your users more vulnerable to cross-site scripting
attacks.",
+ + "leaving your users more vulnerable to cross-site scripting
attacks. This property " +
+ "will soon become a no-op, and SafeHtml integration will always
be on.",
XSS_SAFE_CONFIG_PROPERTY);
gaveSafeHtmlWarning = true;
}
Index: user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
===
--- user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java (revision
10704)
+++ user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java (working
copy)
@@ -1030,7 +1030,7 @@
*/
public String tokenForSafeUriExpression(XMLElement source, String
expression) {
if (!useSafeHtmlTemplates) {
- return tokenForStringExpression(source, expression + ".asString()");
+ return tokenForStringExpression(source, expression);
}
htmlTemplates.noteUri(expression);
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Add HasEnabled to SuggestBox (issue1567803)
r10703 http://gwt-code-reviews.appspot.com/1567803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Improves Dev Mode reporting of JavaScriptException to include method (issue1570803)
Some day I'll remember to run tests *before* posting for review. But since that day is not today, PTAL http://gwt-code-reviews.appspot.com/1570803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Improves Dev Mode reporting of JavaScriptException to include method (issue1570803)
http://gwt-code-reviews.appspot.com/1570803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Add HasEnabled to SuggestBox (issue1567803)
LGTM Nice tests there, thanks. I'll put this through the test gauntlet and submit. http://gwt-code-reviews.appspot.com/1567803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Reorganize validation classes and minimize visibility in preperation for (issue1565807)
LGTM http://gwt-code-reviews.appspot.com/1565807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Improves Dev Mode reporting of JavaScriptException to include method (issue1570803)
PTAL http://gwt-code-reviews.appspot.com/1570803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Improves Dev Mode reporting of JavaScriptException to include method (issue1570803)
http://gwt-code-reviews.appspot.com/1570803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Improves Dev Mode reporting of JavaScriptException to include method (issue1570803)
http://gwt-code-reviews.appspot.com/1570803/diff/1/dev/core/src/com/google/gwt/dev/shell/BrowserChannelServer.java
File dev/core/src/com/google/gwt/dev/shell/BrowserChannelServer.java
(right):
http://gwt-code-reviews.appspot.com/1570803/diff/1/dev/core/src/com/google/gwt/dev/shell/BrowserChannelServer.java#newcode245
dev/core/src/com/google/gwt/dev/shell/BrowserChannelServer.java:245:
exceptionValue, methodName + "(" + args + "), return value: " +
returnJsValue);
Oops, no doubt. Thanks.
On 2011/10/13 00:02:19, tobyr wrote:
Do you want Arrays.toString(args) instead of args?
http://gwt-code-reviews.appspot.com/1570803/diff/1/dev/core/src/com/google/gwt/dev/shell/ModuleSpace.java
File dev/core/src/com/google/gwt/dev/shell/ModuleSpace.java (right):
http://gwt-code-reviews.appspot.com/1570803/diff/1/dev/core/src/com/google/gwt/dev/shell/ModuleSpace.java#newcode60
dev/core/src/com/google/gwt/dev/shell/ModuleSpace.java:60: * session's
thread.
On 2011/10/13 00:02:19, tobyr wrote:
Rather than duping the doc, something like:
Equivalent to {@link
#createJavaScriptException(ClassLoader,Object,String)
createJavaScriptException(cl, exception, "")}
Done.
http://gwt-code-reviews.appspot.com/1570803/diff/1/user/src/com/google/gwt/core/client/JavaScriptException.java
File user/src/com/google/gwt/core/client/JavaScriptException.java
(right):
http://gwt-code-reviews.appspot.com/1570803/diff/1/user/src/com/google/gwt/core/client/JavaScriptException.java#newcode191
user/src/com/google/gwt/core/client/JavaScriptException.java:191:
description = description + ": " + getDescription(e);
Description now defaults to "", and a "manual" description can be passed
in to the constructor. getDescription(Object) is a static method that
gets info out of an exception or one or two other kinds of objects. The
init call here ensures that we see both the optional description and the
summary of e.
I'll doc it, or rename the static method to clear things up.
On 2011/10/13 00:02:19, tobyr wrote:
I'm a little confused by what's going on here, since you seem to be
overloading
the meaning of description.
http://gwt-code-reviews.appspot.com/1570803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Improves Dev Mode reporting of JavaScriptException to include method (issue1570803)
Ready for review Mr. Toby. http://gwt-code-reviews.appspot.com/1570803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Added a getter for the ResettableEventBus object. (issue1569803)
On 2011/10/12 21:47:29, maximilian.ruppaner wrote: LGTM http://gwt-code-reviews.appspot.com/1569803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fixed a typo in exclude NonTckTest flag, that was causing the TCK results count to be wrong. (issue1571803)
LGTM Oopsie. http://gwt-code-reviews.appspot.com/1571803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Improves Dev Mode reporting of JavaScriptException to include method (issue1570803)
Reviewers: tobyr,
Description:
Improves Dev Mode reporting of JavaScriptException to include method
name and args.
Review by: to...@google.com
Please review this at http://gwt-code-reviews.appspot.com/1570803/
Affected files:
M dev/core/src/com/google/gwt/dev/shell/BrowserChannelServer.java
M dev/core/src/com/google/gwt/dev/shell/ModuleSpace.java
M user/src/com/google/gwt/core/client/JavaScriptException.java
Index: dev/core/src/com/google/gwt/dev/shell/BrowserChannelServer.java
===
--- dev/core/src/com/google/gwt/dev/shell/BrowserChannelServer.java
(revision 10696)
+++ dev/core/src/com/google/gwt/dev/shell/BrowserChannelServer.java
(working copy)
@@ -241,8 +241,8 @@
// JSException
exceptionValue = returnValue.getValue().toString();
}
-RuntimeException exception = ModuleSpace.createJavaScriptException(
-ccl, exceptionValue);
+RuntimeException exception =
ModuleSpace.createJavaScriptException(ccl,
+exceptionValue, methodName + "(" + args + "), return value: "
+ returnJsValue);
// reset the stack trace to here to minimize GWT infrastructure in
// the stack trace
exception.fillInStackTrace();
Index: dev/core/src/com/google/gwt/dev/shell/ModuleSpace.java
===
--- dev/core/src/com/google/gwt/dev/shell/ModuleSpace.java (revision 10696)
+++ dev/core/src/com/google/gwt/dev/shell/ModuleSpace.java (working copy)
@@ -61,13 +61,23 @@
*/
protected static RuntimeException createJavaScriptException(ClassLoader
cl,
Object exception) {
+return createJavaScriptException(cl, exception, "");
+ }
+
+ /**
+ * Create a JavaScriptException object. This must be done reflectively,
since
+ * this class will have been loaded from a ClassLoader other than the
+ * session's thread.
+ */
+ protected static RuntimeException createJavaScriptException(ClassLoader
cl,
+ Object exception, String message) {
Exception caught;
try {
Class javaScriptExceptionClass = Class.forName(
"com.google.gwt.core.client.JavaScriptException", true, cl);
Constructor ctor =
javaScriptExceptionClass.getDeclaredConstructor(
- Object.class);
- return (RuntimeException) ctor.newInstance(new Object[] {exception});
+ Object.class, String.class);
+ return (RuntimeException) ctor.newInstance(new Object[] {message,
exception});
} catch (InstantiationException e) {
caught = e;
} catch (IllegalAccessException e) {
Index: user/src/com/google/gwt/core/client/JavaScriptException.java
===
--- user/src/com/google/gwt/core/client/JavaScriptException.java (revision
10696)
+++ user/src/com/google/gwt/core/client/JavaScriptException.java (working
copy)
@@ -82,7 +82,7 @@
* The original description of the JavaScript exception this class wraps,
* initialized as e.message.
*/
- private String description;
+ private String description = "";
/**
* The underlying exception this class wraps.
@@ -104,7 +104,18 @@
* @param e the object caught in JavaScript that triggered the exception
*/
public JavaScriptException(Object e) {
+this(e, "");
+ }
+
+ /**
+ * @param e the object caught in JavaScript that triggered the exception
+ * @param description to include in getMessage(), e.g. at the top of a
stack
+ * trace
+ */
+ public JavaScriptException(Object e, String description) {
this.e = e;
+this.description = description;
+
/*
* In Development Mode, JavaScriptExceptions are created exactly when
the
* native method returns and their stack traces are fixed-up by the
@@ -117,7 +128,7 @@
StackTraceCreator.createStackTrace(this);
}
}
-
+
public JavaScriptException(String name, String description) {
this.message = "JavaScript " + name + " exception: " + description;
this.name = name;
@@ -177,8 +188,8 @@
private void init() {
name = getName(e);
-description = getDescription(e);
-message = "(" + name + "): " + description + getProperties(e);
+description = description + ": " + getDescription(e);
+message = "(" + name + ") " + getProperties(e) + description;
}
}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Added a getter for the ResettableEventBus object. (issue1569803)
Thanks for the patch. Please be sure to run ant test (which will tell
you that you need to put this method in alphabetical order). And please
extend ActivityManagerTest, particularly checking that the returned bus
actually is reset as expected.
http://gwt-code-reviews.appspot.com/1569803/diff/1/user/src/com/google/gwt/activity/shared/ActivityManager.java
File user/src/com/google/gwt/activity/shared/ActivityManager.java
(right):
http://gwt-code-reviews.appspot.com/1569803/diff/1/user/src/com/google/gwt/activity/shared/ActivityManager.java#newcode265
user/src/com/google/gwt/activity/shared/ActivityManager.java:265: * the
current activity is stopped, so activities will rarely need to hold on
the bit after "... is stopped" doesn't make a lot of sense here.
http://gwt-code-reviews.appspot.com/1569803/diff/1/user/src/com/google/gwt/activity/shared/ActivityManager.java#newcode272
user/src/com/google/gwt/activity/shared/ActivityManager.java:272: public
EventBus getActivityEventBus() {
How about "getActiveEventBus"
http://gwt-code-reviews.appspot.com/1569803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Add HasEnabled to SuggestBox (issue1567803)
Thanks for taking this over Stephen. Could you extend SuggestBoxTest to cover it? Also, have you looked at the behavior manually? Does it actually work as expected? In particular I'm wondering what happens if the user tabs into the box. http://gwt-code-reviews.appspot.com/1567803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Make client-side JUnit 3 classes available without GWTTestCase. (issue1564803)
LGTM http://gwt-code-reviews.appspot.com/1564803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Add stub support for AutoBeanFactorySource to GWT emul code. (issue1562803)
On 2011/10/05 05:27:27, mbx wrote: LGTM Thanks Mike. http://gwt-code-reviews.appspot.com/1562803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Segregate JRE Resource tests for more targeted testing (issue1561804)
Reviewers: skybrian,
Description:
Segregate JRE Resource tests for more targeted testing
Review by: skybr...@google.com
Please review this at http://gwt-code-reviews.appspot.com/1561804/
Affected files:
A user/test/com/google/gwt/resources/ResourcesJreSuite.java
M user/test/com/google/gwt/resources/ResourcesSuite.java
Index: user/test/com/google/gwt/resources/ResourcesJreSuite.java
===
--- user/test/com/google/gwt/resources/ResourcesJreSuite.java (revision 0)
+++ user/test/com/google/gwt/resources/ResourcesJreSuite.java (revision 0)
@@ -0,0 +1,33 @@
+/*
+ * Copyright 2008 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may
not
+ * use this file except in compliance with the License. You may obtain a
copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package com.google.gwt.resources;
+
+import com.google.gwt.junit.tools.GWTTestSuite;
+import com.google.gwt.resources.rg.CssOutputTestCase;
+
+import junit.framework.Test;
+
+/**
+ * JRE tests of the ClientBundle framework.
+ */
+public class ResourcesJreSuite {
+ public static Test suite() {
+
+GWTTestSuite suite = new GWTTestSuite("JRE test for
com.google.gwt.resources");
+suite.addTestSuite(CssOutputTestCase.class);
+return suite;
+ }
+}
Index: user/test/com/google/gwt/resources/ResourcesSuite.java
===
--- user/test/com/google/gwt/resources/ResourcesSuite.java (revision 10678)
+++ user/test/com/google/gwt/resources/ResourcesSuite.java (working copy)
@@ -17,13 +17,13 @@
import com.google.gwt.junit.tools.GWTTestSuite;
import com.google.gwt.resources.client.CSSResourceTest;
+import com.google.gwt.resources.client.DataResourceDoNotEmbedTest;
+import com.google.gwt.resources.client.DataResourceMimeTypeTest;
import com.google.gwt.resources.client.ExternalTextResourceJsonpTest;
import com.google.gwt.resources.client.ExternalTextResourceTest;
import com.google.gwt.resources.client.ImageResourceNoInliningTest;
import com.google.gwt.resources.client.ImageResourceTest;
import com.google.gwt.resources.client.NestedBundleTest;
-import com.google.gwt.resources.client.DataResourceDoNotEmbedTest;
-import com.google.gwt.resources.client.DataResourceMimeTypeTest;
import com.google.gwt.resources.client.TextResourceTest;
import com.google.gwt.resources.css.CssExternalTest;
import com.google.gwt.resources.css.CssNodeClonerTest;
@@ -33,7 +33,6 @@
import com.google.gwt.resources.css.UnknownAtRuleTest;
import com.google.gwt.resources.ext.ResourceGeneratorUtilTest;
import com.google.gwt.resources.rg.CssClassNamesTestCase;
-import com.google.gwt.resources.rg.CssOutputTestCase;
import junit.framework.Test;
@@ -47,7 +46,6 @@
suite.addTestSuite(CssClassNamesTestCase.class);
suite.addTestSuite(CssExternalTest.class);
suite.addTestSuite(CssNodeClonerTest.class);
-suite.addTestSuite(CssOutputTestCase.class);
suite.addTestSuite(CssReorderTest.class);
suite.addTestSuite(CSSResourceTest.class);
suite.addTestSuite(CssRtlTest.class);
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: to set property values (issue1524803)
Justin, I'm having trouble applying the patch. Do you need to sync and post a new one? On 2011/10/03 17:19:57, rjrjr wrote: LGTM I agree, I don't think you're making things worse, just subject to the same problems that are already there. I'll submit this today or tomorrow presuming Rafa doesn't shout me down. Thanks for this! On 2011/10/03 04:46:22, justin_hickman wrote: > Any updates to this issue? From my investigations, the behavior with the > element exhibits identical behavior to what is already in > uibinder using just Widget references. http://gwt-code-reviews.appspot.com/1524803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: to set property values (issue1524803)
LGTM I agree, I don't think you're making things worse, just subject to the same problems that are already there. I'll submit this today or tomorrow presuming Rafa doesn't shout me down. Thanks for this! On 2011/10/03 04:46:22, justin_hickman wrote: Any updates to this issue? From my investigations, the behavior with the element exhibits identical behavior to what is already in uibinder using just Widget references. http://gwt-code-reviews.appspot.com/1524803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Generated EditorContext class names take actual parameterization into account. (issue1352806)
Thomas, if you still want this in can you make the me reviewer? http://gwt-code-reviews.appspot.com/1352806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix name clash between RequestContext and the FindRequest impl interface. (issue1559803)
On 2011/09/23 20:00:59, rjrjr wrote: Review requested http://gwt-code-reviews.appspot.com/1559803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Fix name clash between RequestContext and the FindRequest impl interface. (issue1559803)
Reviewers: cromwellian, Description: Fix name clash between RequestContext and the FindRequest impl interface. I think this was only able to compile due to a javac bug. When I reinstalled eclipse today (don't ask, just don't ask), this line started failng with: Name clash: The method find(EntityProxyId) of type FindRequest has the same erasure as find(EntityProxyId) of type RequestContext but does not override it Installing a fresh OpenJDK showed the same fail in an ant build. Please review this at http://gwt-code-reviews.appspot.com/1559803/ Affected files: M user/src/com/google/web/bindery/requestfactory/shared/impl/FindRequest.java Index: user/src/com/google/web/bindery/requestfactory/shared/impl/FindRequest.java === --- user/src/com/google/web/bindery/requestfactory/shared/impl/FindRequest.java (revision 10670) +++ user/src/com/google/web/bindery/requestfactory/shared/impl/FindRequest.java (working copy) @@ -31,5 +31,5 @@ /** * Use the implicit lookup in passing EntityProxy types to service methods. */ - Request find(EntityProxyId proxy); + Request find(EntityProxyId proxyId); } \ No newline at end of file -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Allow @defs with multiple values (issue1557803)
On 2011/09/22 23:35:21, unnurg wrote: LGTM encore http://gwt-code-reviews.appspot.com/1557803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Makes sure all attributes from the PotentialElement can be inherited (issue1556803)
LGTM with one typo fixed
http://gwt-code-reviews.appspot.com/1556803/diff/2002/user/src/com/google/gwt/user/client/ui/PotentialElement.java
File user/src/com/google/gwt/user/client/ui/PotentialElement.java
(right):
http://gwt-code-reviews.appspot.com/1556803/diff/2002/user/src/com/google/gwt/user/client/ui/PotentialElement.java#newcode74
user/src/com/google/gwt/user/client/ui/PotentialElement.java:74: *
Creates and {@link HtmlElementBuilder} instance inheriting all
attributes
Creates an
http://gwt-code-reviews.appspot.com/1556803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Allow DateBox to fire events with null date values for invalid and empty input (issue1552803)
LGTM http://gwt-code-reviews.appspot.com/1552803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fixes some errors in the eclipse readme, and fixes some marker files. (issue1553803)
Tidied, submitting. http://gwt-code-reviews.appspot.com/1553803/diff/1/eclipse/README.txt File eclipse/README.txt (right): http://gwt-code-reviews.appspot.com/1553803/diff/1/eclipse/README.txt#newcode115 eclipse/README.txt:115: Project->Properties->Java Compiler->AnnotationProcessor->Factory Path It's actually not part of the optional On 2011/09/19 22:45:49, rchandia wrote: Indent to make it visually make it part of "Optional:" http://gwt-code-reviews.appspot.com/1553803/diff/1/eclipse/README.txt#newcode121 eclipse/README.txt:121: This adds a directory named '.apt-generated' to the source path, and puts on the APT factory path annotation processors required by the RequestFactory unit tests On 2011/09/19 22:45:49, rchandia wrote: Format 80 cols Done. http://gwt-code-reviews.appspot.com/1553803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Introduces BrowserEvents string constants (issue1550803)
PTAL
http://gwt-code-reviews.appspot.com/1550803/diff/1/user/src/com/google/gwt/dom/client/Document.java
File user/src/com/google/gwt/dom/client/Document.java (right):
http://gwt-code-reviews.appspot.com/1550803/diff/1/user/src/com/google/gwt/dom/client/Document.java#newcode18
user/src/com/google/gwt/dom/client/Document.java:18: import static
com.google.gwt.dom.client.BrowserEvents.*;
We have an auto-importer setting against it. Fixed here and in
ClickableTextCell.
On 2011/09/19 14:26:41, jlabanca wrote:
Do we have a rule against importing .*?
http://gwt-code-reviews.appspot.com/1550803/diff/1/user/src/com/google/gwt/dom/client/Document.java#newcode571
user/src/com/google/gwt/dom/client/Document.java:571:
@SuppressWarnings("deprecation")
Eclipse seems to think so. But it also seems not to notice the
@SuppressWarnings and keep nagging. Reverted.
On 2011/09/19 14:26:41, jlabanca wrote:
Do you need to suppress deprecation on a deprecated method?
http://gwt-code-reviews.appspot.com/1550803/diff/1/user/src/com/google/gwt/user/cellview/client/CellBasedWidgetImplTrident.java
File
user/src/com/google/gwt/user/cellview/client/CellBasedWidgetImplTrident.java
(right):
http://gwt-code-reviews.appspot.com/1550803/diff/1/user/src/com/google/gwt/user/cellview/client/CellBasedWidgetImplTrident.java#newcode162
user/src/com/google/gwt/user/cellview/client/CellBasedWidgetImplTrident.java:162:
if (BrowserEvents.FOCUSIN.equals(type)) {
I think Thomas wins here.
On 2011/09/19 14:26:41, jlabanca wrote:
FOCUSIN is IE specific. I would leave the string in this case, or
create a
static private String in this impl class.
http://gwt-code-reviews.appspot.com/1550803/diff/1/user/src/com/google/gwt/user/cellview/client/CellBasedWidgetImplTrident.java#newcode175
user/src/com/google/gwt/user/cellview/client/CellBasedWidgetImplTrident.java:175:
} else if ("focusout".equals(type)) {
And adding this to BrowserEvents
http://gwt-code-reviews.appspot.com/1550803/diff/1/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java
File user/src/com/google/gwt/user/client/impl/DOMImplStandard.java
(right):
http://gwt-code-reviews.appspot.com/1550803/diff/1/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java#newcode57
user/src/com/google/gwt/user/client/impl/DOMImplStandard.java:57: if
(evt.getType().equals(BrowserEvents.MOUSEOUT)) {
Thanks!
On 2011/09/19 14:26:41, jlabanca wrote:
MOUSEOUT/MOUSEOVER
http://gwt-code-reviews.appspot.com/1550803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Introduces BrowserEvents string constants (issue1550803)
http://gwt-code-reviews.appspot.com/1550803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Fixes some errors in the eclipse readme, and fixes some marker files. (issue1553803)
Reviewers: rchandia, Description: Fixes some errors in the eclipse readme, and fixes some marker files. Please review this at http://gwt-code-reviews.appspot.com/1553803/ Affected files: M eclipse/README.txt A samples/hello/war/WEB-INF/classes/marker Index: eclipse/README.txt === --- eclipse/README.txt (revision 10645) +++ eclipse/README.txt (working copy) @@ -107,15 +107,23 @@ Select project 'gwt-user' -Project->Preferences->Java Compiler->AnnotationProcessor +Project->Properties->Java Compiler->AnnotationProcessor - Check Enable project specific settings - Check Enable annotation processing - -This adds a directory named '.apt-generated' to the source path. +- Optional: check Enable processing in editor (for on-the-fly validation of RequestFactory interfaces) + +Project->Properties->Java Compiler->AnnotationProcessor->Factory Path +- Add Variable +- Select GWT_TOOLS and click Extend +- Select lib/requestfactory and the most recently dated requestfactory-apt--MM-DD.jar +- Optional: deselect org.eclipse.jst.ws.annoations.core if eclipse has added it, it can make eclipse sluggish + +This adds a directory named '.apt-generated' to the source path, and puts on the APT factory path annotation processors required by the RequestFactory unit tests + == Checkstyle == -Checkstyle is used to enforce good programming style. +Checkstyle is used to enforce good programming style. Its use in Eclipse is optional, since it is also run as part of the acceptance test suite. 1. Install Checkstyle version 4.4.3 (newer versions will not work) @@ -156,7 +164,7 @@ Window->Preferences->Run/Debug->String Substitution->New... Set the Name to "gwt_devjar". -Set the Value to the approprate path for your install -- for example: +Set the Value to the appropriate path for your install -- for example: \trunk\build\staging\gwt-0.0.0\gwt-dev.jar /trunk/build/staging/gwt-0.0.0/gwt-dev.jar Description can be left blank. Index: samples/hello/war/WEB-INF/classes/marker === --- samples/hello/war/WEB-INF/classes/marker(revision 0) +++ samples/hello/war/WEB-INF/classes/marker(revision 0) -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Enable FF6 Plugin in MissingPlugin Page. (issue1551803)
LGTM http://gwt-code-reviews.appspot.com/1551803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Do RF validation via APT instead of command line. (issue1547804)
http://gwt-code-reviews.appspot.com/1547804/diff/8/samples/dynatablerf/pom.xml File samples/dynatablerf/pom.xml (right): http://gwt-code-reviews.appspot.com/1547804/diff/8/samples/dynatablerf/pom.xml#newcode136 samples/dynatablerf/pom.xml:136: as an additional source dir--> It basically auto-installed, so I think they'll figure it out. http://gwt-code-reviews.appspot.com/1547804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Remove uneeded samples checkstyle exception. (issue1548804)
On 2011/09/16 21:23:38, Nick Chalko wrote: LGTM http://gwt-code-reviews.appspot.com/1548804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Do RF validation via APT instead of command line. (issue1547804)
Also, David: I confirmed that we can deploy without that logging stuff, no harm. http://gwt-code-reviews.appspot.com/1547804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Do RF validation via APT instead of command line. (issue1547804)
Back to all apt all the time. I've learned the lesson from Jeff, but don't need most of it. * We're using build-helper to expose target/generated-sources/apt as a source path (no need for clean up under the target umbrella). * We also don't need his resource setting because we are not generating client code * And there is no need to turn on Eclipse's built in apt support unless you want the very cool red squiggles http://gwt-code-reviews.appspot.com/1547804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Do RF validation via APT instead of command line. (issue1547804)
http://gwt-code-reviews.appspot.com/1547804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Do RF validation via APT instead of command line. (issue1547804)
http://gwt-code-reviews.appspot.com/1547804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Do RF validation via APT instead of command line. (issue1547804)
I was getting all excited about something that wasn't broken. MobileWebApp is the troubled sample, blessed with being at the intersection of m2e, gpe and gae. Anyway, I think these are done now. http://gwt-code-reviews.appspot.com/1547804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Do RF validation via APT instead of command line. (issue1547804)
http://gwt-code-reviews.appspot.com/1547804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Do RF validation via APT instead of command line. (issue1547804)
On 2011/09/15 19:48:26, rjrjr wrote: Okay, ready. Best bet is to diff against v1: http://gwt-code-reviews.appspot.com/1547804/diff2/1:6/samples/dynatablerf/pom.xml http://gwt-code-reviews.appspot.com/1547804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Do RF validation via APT instead of command line. (issue1547804)
http://gwt-code-reviews.appspot.com/1547804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Do RF validation via APT instead of command line. (issue1547804)
Oops, haven't posted patch thee yet, one sec… http://gwt-code-reviews.appspot.com/1547804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Do RF validation via APT instead of command line. (issue1547804)
On 2011/09/15 19:35:38, rjrjr wrote: Rajeev and I decided to go with two pom's. The default one is pretty much what was in place already, cleaned up a bit. It uses the command line validation tool, and seems to import into Indigo J2EE just fine. pom-eclipse-import.xml is much simpler and works at the command line. In theory, when m2e gets its act together it should also work for importing into eclipse. Until that happy day, I'm leaving it in the project for reference. So did you notice the buried lead? ** I am importing this into Eclipse J2EE and running it without incident from GPE 2.4.0.r37v201108301710 ** I've been very careful to ensure that nothing was run at the command line first. mvn clean eclipse:clean, git clean -f -d, rm -f .settings. Find reveals no .class files lurking anywhere and no sneaky generated .java. Why is this working for me? About the only thing of substance that I've changed is importing both requestfactory-server (for json deps) and gwt-servlet (for ValidationTool), instead of only importing the latter and dealing with its json deps by hand. Dave and Rajeev, can you patch and reproduce the success? http://gwt-code-reviews.appspot.com/1547804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Do RF validation via APT instead of command line. (issue1547804)
http://gwt-code-reviews.appspot.com/1547804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Do RF validation via APT instead of command line. (issue1547804)
http://gwt-code-reviews.appspot.com/1547804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Introduces BrowserEvents string constants (issue1550803)
RayC, John is on vacation. Can you review? Please keep a good eye out for typos. http://gwt-code-reviews.appspot.com/1550803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Do RF validation via APT instead of command line. (issue1547804)
More: if this solves whatever problem it is you're trying to solve, we'll need to make the same change to mobilewebapp, and update the pom.xml recipe on that wiki page. @drfibonacci, notice that I had to make make gwt-servlet into a real dependency instead of just a runtime one. Is that okay? Also, I tried making dependencies on just requestfactory-servlet, or requestfactory-apt, but those artifacts don't appear to be in maven central. Should they be? http://gwt-code-reviews.appspot.com/1547804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Do RF validation via APT instead of command line. (issue1547804)
Rajeev, this changes the DynaTableRf sample to use APT for rf validation instead of the command line tool. * mvn gwt:run works just fine at the command line * it imports into indigo (required the lifecycle mapping brain damage) * m2e can launch it as a maven goal * gpe run as web app works iff I manually turn on eclipse's apt, per http://code.google.com/p/google-web-toolkit/wiki/RequestFactoryInterfaceValidation http://gwt-code-reviews.appspot.com/1547804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Do RF validation via APT instead of command line. (issue1547804)
Reviewers: drfibonacci,
Description:
Do RF validation via APT instead of command line.
Please review this at http://gwt-code-reviews.appspot.com/1547804/
Affected files:
M samples/dynatablerf/pom.xml
Index: samples/dynatablerf/pom.xml
===
--- samples/dynatablerf/pom.xml (revision 10645)
+++ samples/dynatablerf/pom.xml (working copy)
@@ -30,7 +30,7 @@
gwt-servlet
${gwtVersion}
- runtime
+
com.google.gwt
@@ -98,6 +98,7 @@
${project.build.directory}/${project.build.finalName}/WEB-INF/classes
+
org.codehaus.mojo
@@ -144,32 +145,6 @@
-
-
-org.codehaus.mojo
-exec-maven-plugin
-1.2
-
-
-process-classes
-
- VerifyRequestFactoryInterfaces
- java
-
--cp
-
-
com.google.web.bindery.requestfactory.apt.ValidationTool
-${project.build.outputDirectory}
-
com.google.gwt.sample.dynatablerf.shared.DynaTableRequestFactory
-
-
-
- exec
-
-
-
-
-
maven-resources-plugin
@@ -208,6 +183,30 @@
com.google.gwt.eclipse.core.gwtNature
+
+
+
+
+org.bsc.maven
+maven-processor-plugin
+2.0.5
+
+
+process
+
+ process
+
+generate-sources
+
+
+
+
com.google.web.bindery.requestfactory.apt.RfValidator
+
+
+
+
@@ -234,6 +233,19 @@
+
+
+org.bsc.maven
+maven-processor-plugin
+[2.0.5,)
+
+ process
+
+
+
+
+
+
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fixes fake even dispatch in UiRendererEventsTest for IE8 and less (issue1550804)
LGTM Sweet. Thanks for the fix. http://gwt-code-reviews.appspot.com/1550804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Introduces BrowserEvents string constants (issue1550803)
Reviewers: jlabanca, Description: Introduces BrowserEvents string constants Please review this at http://gwt-code-reviews.appspot.com/1550803/ Affected files: M user/src/com/google/gwt/cell/client/AbstractCell.java M user/src/com/google/gwt/cell/client/AbstractInputCell.java M user/src/com/google/gwt/cell/client/ActionCell.java M user/src/com/google/gwt/cell/client/ButtonCell.java M user/src/com/google/gwt/cell/client/ButtonCellBase.java M user/src/com/google/gwt/cell/client/Cell.java M user/src/com/google/gwt/cell/client/CheckboxCell.java M user/src/com/google/gwt/cell/client/ClickableTextCell.java M user/src/com/google/gwt/cell/client/DatePickerCell.java M user/src/com/google/gwt/cell/client/EditTextCell.java M user/src/com/google/gwt/cell/client/ImageLoadingCell.java M user/src/com/google/gwt/cell/client/SelectionCell.java M user/src/com/google/gwt/cell/client/TextInputCell.java A user/src/com/google/gwt/dom/client/BrowserEvents.java M user/src/com/google/gwt/dom/client/Document.java M user/src/com/google/gwt/event/dom/client/BlurEvent.java M user/src/com/google/gwt/event/dom/client/CanPlayThroughEvent.java M user/src/com/google/gwt/event/dom/client/ChangeEvent.java M user/src/com/google/gwt/event/dom/client/ClickEvent.java M user/src/com/google/gwt/event/dom/client/ContextMenuEvent.java M user/src/com/google/gwt/event/dom/client/DoubleClickEvent.java M user/src/com/google/gwt/event/dom/client/DragEndEvent.java M user/src/com/google/gwt/event/dom/client/DragEnterEvent.java M user/src/com/google/gwt/event/dom/client/DragEvent.java M user/src/com/google/gwt/event/dom/client/DragLeaveEvent.java M user/src/com/google/gwt/event/dom/client/DragOverEvent.java M user/src/com/google/gwt/event/dom/client/DragStartEvent.java M user/src/com/google/gwt/event/dom/client/DropEvent.java M user/src/com/google/gwt/event/dom/client/EndedEvent.java M user/src/com/google/gwt/event/dom/client/ErrorEvent.java M user/src/com/google/gwt/event/dom/client/FocusEvent.java M user/src/com/google/gwt/event/dom/client/GestureChangeEvent.java M user/src/com/google/gwt/event/dom/client/GestureEndEvent.java M user/src/com/google/gwt/event/dom/client/GestureStartEvent.java M user/src/com/google/gwt/event/dom/client/KeyDownEvent.java M user/src/com/google/gwt/event/dom/client/KeyPressEvent.java M user/src/com/google/gwt/event/dom/client/KeyUpEvent.java M user/src/com/google/gwt/event/dom/client/LoadEvent.java M user/src/com/google/gwt/event/dom/client/LoseCaptureEvent.java M user/src/com/google/gwt/event/dom/client/MouseDownEvent.java M user/src/com/google/gwt/event/dom/client/MouseMoveEvent.java M user/src/com/google/gwt/event/dom/client/MouseOutEvent.java M user/src/com/google/gwt/event/dom/client/MouseOverEvent.java M user/src/com/google/gwt/event/dom/client/MouseUpEvent.java M user/src/com/google/gwt/event/dom/client/MouseWheelEvent.java M user/src/com/google/gwt/event/dom/client/ProgressEvent.java M user/src/com/google/gwt/event/dom/client/ScrollEvent.java M user/src/com/google/gwt/event/dom/client/TouchCancelEvent.java M user/src/com/google/gwt/event/dom/client/TouchEndEvent.java M user/src/com/google/gwt/event/dom/client/TouchMoveEvent.java M user/src/com/google/gwt/event/dom/client/TouchStartEvent.java M user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java M user/src/com/google/gwt/user/cellview/client/AbstractHasData.java M user/src/com/google/gwt/user/cellview/client/CellBasedWidgetImplStandard.java M user/src/com/google/gwt/user/cellview/client/CellBasedWidgetImplTrident.java M user/src/com/google/gwt/user/cellview/client/CellBrowser.java M user/src/com/google/gwt/user/cellview/client/CellList.java M user/src/com/google/gwt/user/cellview/client/CellTable.java M user/src/com/google/gwt/user/cellview/client/CellTree.java M user/src/com/google/gwt/user/cellview/client/CellTreeNodeView.java M user/src/com/google/gwt/user/client/impl/DOMImplIE9.java M user/src/com/google/gwt/user/client/impl/DOMImplStandard.java M user/src/com/google/gwt/user/client/ui/Image.java M user/src/com/google/gwt/view/client/DefaultSelectionEventManager.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Makes the @GwtTransient mechanism work for any annotation with that (issue1544803)
http://gwt-code-reviews.appspot.com/1544803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Makes the @GwtTransient mechanism work for any annotation with that (issue1544803)
Reviewers: cromwellian,
Description:
Makes the @GwtTransient mechanism work for any annotation with that
simple name.
Please review this at http://gwt-code-reviews.appspot.com/1544803/
Affected files:
M user/src/com/google/gwt/user/client/rpc/GwtTransient.java
M
user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java
M user/src/com/google/gwt/user/server/rpc/impl/SerializabilityUtil.java
A user/test/com/google/gwt/user/rebind/rpc/GwtTransient.java
M
user/test/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilderTest.java
Index: user/src/com/google/gwt/user/client/rpc/GwtTransient.java
===
--- user/src/com/google/gwt/user/client/rpc/GwtTransient.java (revision
10639)
+++ user/src/com/google/gwt/user/client/rpc/GwtTransient.java (working copy)
@@ -27,6 +27,10 @@
* transient keyword should be used in preference to this
* annotation. However, for types used with multiple serialization
systems, it
* can be useful.
+ *
+ * Note that GWT will actually accept any annotation named GwtTransient
for this
+ * purpose. This is done to allow libraries to support GWT serialization
without
+ * creating a direct dependency on the GWT distribution.
*/
@Documented
@Retention(RetentionPolicy.RUNTIME)
Index:
user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java
===
---
user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java
(revision 10639)
+++
user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java
(working copy)
@@ -452,6 +452,15 @@
return (JRealClassType) type;
}
+ static boolean hasGwtTransientAnnotation(JField field) {
+for (Annotation a : field.getAnnotations()) {
+ if
(a.annotationType().getSimpleName().equals(GwtTransient.class.getSimpleName()))
{
+return true;
+ }
+}
+return false;
+ }
+
/**
* @param type the type to query
* @return true if the type is annotated with @PersistenceCapable(...,
@@ -607,7 +616,7 @@
return false;
}
-if (field.isAnnotationPresent(GwtTransient.class)) {
+if (hasGwtTransientAnnotation(field)) {
return false;
}
Index: user/src/com/google/gwt/user/server/rpc/impl/SerializabilityUtil.java
===
--- user/src/com/google/gwt/user/server/rpc/impl/SerializabilityUtil.java
(revision 10639)
+++ user/src/com/google/gwt/user/server/rpc/impl/SerializabilityUtil.java
(working copy)
@@ -25,6 +25,7 @@
import com.google.gwt.user.server.rpc.ServerCustomFieldSerializer;
import java.io.UnsupportedEncodingException;
+import java.lang.annotation.Annotation;
import java.lang.reflect.Field;
import java.lang.reflect.GenericArrayType;
import java.lang.reflect.Modifier;
@@ -463,6 +464,18 @@
SerializabilityUtil.resolveTypesWorker(methodType, resolvedTypes,
true);
}
+ /**
+ * Returns true if this field has an annotation named "GwtTransient".
+ */
+ static boolean hasGwtTransientAnnotation(Field field) {
+for (Annotation a : field.getAnnotations()) {
+ if
(a.annotationType().getSimpleName().equals(GwtTransient.class.getSimpleName()))
{
+return true;
+ }
+}
+return false;
+ }
+
static boolean isNotStaticTransientOrFinal(Field field) {
/*
* Only serialize fields that are not static, transient (including
@@ -470,7 +483,7 @@
*/
int fieldModifiers = field.getModifiers();
return !Modifier.isStatic(fieldModifiers)
&& !Modifier.isTransient(fieldModifiers)
-&& !field.isAnnotationPresent(GwtTransient.class)
&& !Modifier.isFinal(fieldModifiers);
+&& !hasGwtTransientAnnotation(field)
&& !Modifier.isFinal(fieldModifiers);
}
/**
Index: user/test/com/google/gwt/user/rebind/rpc/GwtTransient.java
===
--- user/test/com/google/gwt/user/rebind/rpc/GwtTransient.java (revision 0)
+++ user/test/com/google/gwt/user/rebind/rpc/GwtTransient.java (revision 0)
@@ -0,0 +1,24 @@
+/*
+ * Copyright 2011 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may
not
+ * use this file except in compliance with the License. You may obtain a
copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package com.google.gwt.user.rebind.rpc;
+
+/**
+ * Used to test that any annotation named @GwtTransient gets the job done.
Need
+ * to define both a real class (Ty
[gwt-contrib] Re: Converts the validation sample to build with maven. (issue1537805)
Submitting http://gwt-code-reviews.appspot.com/1537805/diff/5004/samples/validation/src/main/java/com/google/gwt/sample/validation/Validation.gwt.xml File samples/validation/src/main/java/com/google/gwt/sample/validation/Validation.gwt.xml (right): http://gwt-code-reviews.appspot.com/1537805/diff/5004/samples/validation/src/main/java/com/google/gwt/sample/validation/Validation.gwt.xml#newcode16 samples/validation/src/main/java/com/google/gwt/sample/validation/Validation.gwt.xml:16: Wasn't actually necessary. Tidied it up. On 2011/09/12 23:54:30, Nick Chalko wrote: Why the separate module for super source? Please leave a comment explaining. http://gwt-code-reviews.appspot.com/1537805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Converts the validation sample to build with maven. (issue1537805)
http://gwt-code-reviews.appspot.com/1537805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Converts the validation sample to build with maven. (issue1537805)
http://gwt-code-reviews.appspot.com/1537805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fixes logging and character set warnings for dynatablerf and mobilewebapp samples. (issue1543803)
And, ready for review please. Or advice on stomping the last errors. The org.mortbay.log.StdErrLog one is kind of aggravating, since it seems like it's simply misrouted, should be an [INFO] http://gwt-code-reviews.appspot.com/1543803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fixes logging and character set warnings for dynatablerf and mobilewebapp samples. (issue1543803)
DTRF runs without warnings. mobilewebapp is down to the following, which is an improvement at least. [WARNING] Don't declare gwt-dev as a project dependency. This may introduce complex dependency conflicts [INFO] create exploded Jetty webapp in /Users/rjrjr/src/gwt-g5/google3/third_party/java_src/gwt/svn/trunk/samples/mobilewebapp/target/MobileWebApp-1.0-SNAPSHOT [ERROR] 2011-09-12 18:39:32.155:INFO::Logging to STDERR via org.mortbay.log.StdErrLog [ERROR] 2011-09-12 18:39:32.311:INFO::jetty-6.1.x [ERROR] 2011-09-12 18:39:32.995:INFO::Started SelectChannelConnector@0.0.0.0: [ERROR] 2011-09-12 11:39:33.804 java[85356:d203] Unable to obtain JNIEnv for context:0 http://gwt-code-reviews.appspot.com/1543803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Fixes logging and character set warnings for dynatablerf and mobilewebapp samples. (issue1543803)
Reviewers: rchandia,
Description:
Fixes logging and character set warnings for dynatablerf and
mobilewebapp samples.
Please review this at http://gwt-code-reviews.appspot.com/1543803/
Affected files:
M samples/dynatablerf/pom.xml
A samples/dynatablerf/src/main/resources/log4j.properties
M samples/mobilewebapp/pom.xml
D samples/mobilewebapp/src/main/java/log4j.properties
A samples/mobilewebapp/src/main/resources/log4j.properties
D samples/mobilewebapp/src/main/webapp/WEB-INF/logging.properties
Index: samples/dynatablerf/pom.xml
===
--- samples/dynatablerf/pom.xml (revision 10639)
+++ samples/dynatablerf/pom.xml (working copy)
@@ -16,6 +16,10 @@
1.6
1.6
+
+
+UTF-8
+
UTF-8
Index: samples/dynatablerf/src/main/resources/log4j.properties
===
--- samples/dynatablerf/src/main/resources/log4j.properties (revision 0)
+++ samples/dynatablerf/src/main/resources/log4j.properties (revision 0)
@@ -0,0 +1,5 @@
+#log4j configuration, needed by hibernate validator.
+log4j.rootLogger=INFO, stdout
+
+log4j.appender.stdout=org.apache.log4j.ConsoleAppender
+log4j.appender.stdout.layout=org.apache.log4j.PatternLayout
\ No newline at end of file
Index: samples/mobilewebapp/pom.xml
===
--- samples/mobilewebapp/pom.xml(revision 10639)
+++ samples/mobilewebapp/pom.xml(working copy)
@@ -22,6 +22,9 @@
${user.home}/.m2/repository/com/google/appengine/appengine-java-sdk/${gae.version}/appengine-java-sdk-${gae.version}
1
+
+UTF-8
+
UTF-8
Index: samples/mobilewebapp/src/main/java/log4j.properties
===
--- samples/mobilewebapp/src/main/java/log4j.properties (revision 10639)
+++ samples/mobilewebapp/src/main/java/log4j.properties (working copy)
@@ -1,24 +0,0 @@
-# A default log4j configuration for log4j users.
-#
-# To use this configuration, deploy it into your application's
WEB-INF/classes
-# directory. You are also encouraged to edit it as you like.
-
-# Configure the console as our one appender
-log4j.appender.A1=org.apache.log4j.ConsoleAppender
-log4j.appender.A1.layout=org.apache.log4j.PatternLayout
-log4j.appender.A1.layout.ConversionPattern=%d{HH:mm:ss,SSS} %-5p [%c]
- %m%n
-
-# tighten logging on the DataNucleus Categories
-log4j.category.DataNucleus.JDO=WARN, A1
-log4j.category.DataNucleus.Persistence=WARN, A1
-log4j.category.DataNucleus.Cache=WARN, A1
-log4j.category.DataNucleus.MetaData=WARN, A1
-log4j.category.DataNucleus.General=WARN, A1
-log4j.category.DataNucleus.Utility=WARN, A1
-log4j.category.DataNucleus.Transaction=WARN, A1
-log4j.category.DataNucleus.Datastore=WARN, A1
-log4j.category.DataNucleus.ClassLoading=WARN, A1
-log4j.category.DataNucleus.Plugin=WARN, A1
-log4j.category.DataNucleus.ValueGeneration=WARN, A1
-log4j.category.DataNucleus.Enhancer=WARN, A1
-log4j.category.DataNucleus.SchemaTool=WARN, A1
Index: samples/mobilewebapp/src/main/resources/log4j.properties
===
--- samples/mobilewebapp/src/main/resources/log4j.properties(revision 0)
+++ samples/mobilewebapp/src/main/resources/log4j.properties(revision 0)
@@ -0,0 +1,4 @@
+log4j.rootLogger=INFO, stdout
+
+log4j.appender.stdout=org.apache.log4j.ConsoleAppender
+log4j.appender.stdout.layout=org.apache.log4j.PatternLayout
\ No newline at end of file
Index: samples/mobilewebapp/src/main/webapp/WEB-INF/logging.properties
===
--- samples/mobilewebapp/src/main/webapp/WEB-INF/logging.properties
(revision 10639)
+++ samples/mobilewebapp/src/main/webapp/WEB-INF/logging.properties
(working copy)
@@ -1,13 +0,0 @@
-# A default java.util.logging configuration.
-# (All App Engine logging is through java.util.logging by default).
-#
-# To use this configuration, copy it into your application's WEB-INF
-# folder and add the following to your appengine-web.xml:
-#
-#
-# value="WEB-INF/logging.properties"/>
-#
-#
-
-# Set the default logging level for all loggers to WARNING
-.level = WARNING
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Support older bash interpreter in maven upload script (issue1537806)
LGTM
Works on my Mac, thanks for the fixes. One echo request.
http://gwt-code-reviews.appspot.com/1537806/diff/1/maven/lib-gwt.sh
File maven/lib-gwt.sh (right):
http://gwt-code-reviews.appspot.com/1537806/diff/1/maven/lib-gwt.sh#newcode101
maven/lib-gwt.sh:101: # once we rename the jar files for Maven
echo "Removing INDEX.LIST from gwt-${i}"
http://gwt-code-reviews.appspot.com/1537806/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Converts the validation sample to build with maven. (issue1537805)
http://gwt-code-reviews.appspot.com/1537805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Converts the validation sample to build with maven. (issue1537805)
Ready for review. Please not the log4j.properties file and the removal of ScriptAssert.java http://gwt-code-reviews.appspot.com/1537805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Converts the validation sample to build with maven. (issue1537805)
http://gwt-code-reviews.appspot.com/1537805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Convert DynaTableRF to use maven. Clean up the docs in the other two (issue1537803)
Thanks Hilco. The upload script is getting confused when I try to update the patch. I'll have to start a new one. http://gwt-code-reviews-hr.appspot.com/1537803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Scripts and configuration to upload GWT bits to Maven repos (issue1520810)
LGTM With one last tweak. http://gwt-code-reviews.appspot.com/1520810/diff/7016/maven/lib-gwt.sh File maven/lib-gwt.sh (right): http://gwt-code-reviews.appspot.com/1520810/diff/7016/maven/lib-gwt.sh#newcode99 maven/lib-gwt.sh:99: maven-deploy-file $mavenRepoUrl $mavenRepoId $pomDir/gwt/pom.xml $pomDir/gwt/pom.xml This should happen between the for loops. http://gwt-code-reviews.appspot.com/1520810/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Converts the validation sample to build with maven. (issue1537805)
http://gwt-code-reviews.appspot.com/1537805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Scripts and configuration to upload GWT bits to Maven repos (issue1520810)
http://gwt-code-reviews.appspot.com/1520810/diff/10020/maven/README.txt
File maven/README.txt (right):
http://gwt-code-reviews.appspot.com/1520810/diff/10020/maven/README.txt#newcode10
maven/README.txt:10: build/dist if you've just built it). By default,
the script deploys to your local Maven repo.
could you reflow this doc to fit in 100 or 80 chars?
http://gwt-code-reviews.appspot.com/1520810/diff/10020/maven/lib-gwt.sh
File maven/lib-gwt.sh (right):
http://gwt-code-reviews.appspot.com/1520810/diff/10020/maven/lib-gwt.sh#newcode110
maven/lib-gwt.sh:110: curExpandDir=$jarExpandDir-${i}
So you're still processing files in midstream. I'm worried about
something unexpected happening here when we're halfway through a
canonical push, leaving us with a difficult mess to clean up. Seems like
you'd be better off with two for loops, one for processing and one that
does only deploy calls. (Does maven give us no way to batch or set up a
transaction?)
http://gwt-code-reviews.appspot.com/1520810/diff/10020/maven/push-gwt.sh
File maven/push-gwt.sh (right):
http://gwt-code-reviews.appspot.com/1520810/diff/10020/maven/push-gwt.sh#newcode12
maven/push-gwt.sh:12: #
GWT_MAVEN_REPO_URL=https://oss.sonatype.org/content/repositories/google-snapshots/
What will happen if I run this script from the wrong directory?
http://gwt-code-reviews.appspot.com/1520810/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Converts the validation sample to build with maven. (issue1537805)
Getting closer, still not ready for review. I learned how to pull in both the binary and the source for hibernate validator. Now getting the app's "An error occurred" dialog when sending, nothing in the console. At launch still seeing the ClassNotFound exception below. Will debug in the morning, but if anyone has clue to share in the meantime I'll be obliged. 00:00:30.295 [SPAM] Resolving org.hibernate.validator.constraints.ScriptAssert 00:00:30.296 [SPAM] Found type 'org.hibernate.validator.constraints.ScriptAssert' 00:00:30.296 [ERROR] Annotation error: cannot resolve org.hibernate.validator.constraints.impl.ScriptAssertValidator java.lang.ClassNotFoundException: org.hibernate.validator.constraints.impl.ScriptAssertValidator at java.net.URLClassLoader$1.run(URLClassLoader.java:202) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:190) at java.lang.ClassLoader.loadClass(ClassLoader.java:306) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301) at java.lang.ClassLoader.loadClass(ClassLoader.java:247) at java.lang.Class.forName0(Native Method) at java.lang.Class.forName(Class.java:247) at com.google.gwt.dev.javac.TypeOracleMediator.resolveAnnotationValue(TypeOracleMediator.java:750) at com.google.gwt.dev.javac.TypeOracleMediator.resolveAnnotationValue(TypeOracleMediator.java:689) at com.google.gwt.dev.javac.TypeOracleMediator.createAnnotation(TypeOracleMediator.java:498) at com.google.gwt.dev.javac.TypeOracleMediator.resolveAnnotation(TypeOracleMediator.java:648) at com.google.gwt.dev.javac.TypeOracleMediator.resolveAnnotations(TypeOracleMediator.java:663) at com.google.gwt.dev.javac.TypeOracleMediator.resolveClass(TypeOracleMediator.java:809) at com.google.gwt.dev.javac.TypeOracleMediator.addNewTypes(TypeOracleMediator.java:439) at com.google.gwt.dev.javac.TypeOracleMediatorFromSource.addNewUnits(TypeOracleMediatorFromSource.java:52) at com.google.gwt.dev.javac.CompilationState.assimilateUnits(CompilationState.java:164) at com.google.gwt.dev.javac.CompilationState.(CompilationState.java:82) at com.google.gwt.dev.javac.CompilationStateBuilder.doBuildFrom(CompilationStateBuilder.java:450) at com.google.gwt.dev.javac.CompilationStateBuilder.buildFrom(CompilationStateBuilder.java:370) at com.google.gwt.dev.cfg.ModuleDef.getCompilationState(ModuleDef.java:360) at com.google.gwt.dev.DevModeBase$UiBrowserWidgetHostImpl.createModuleSpaceHost(DevModeBase.java:110) at com.google.gwt.dev.shell.OophmSessionHandler.loadModule(OophmSessionHandler.java:197) at com.google.gwt.dev.shell.BrowserChannelServer.processConnection(BrowserChannelServer.java:525) at com.google.gwt.dev.shell.BrowserChannelServer.run(BrowserChannelServer.java:363) at java.lang.Thread.run(Thread.java:680)00:00:30.297 [ERROR] Annotation error: expected class java.lang.Class, got null http://gwt-code-reviews.appspot.com/1537805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Converts the validation sample to build with maven. (issue1537805)
http://gwt-code-reviews.appspot.com/1537805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Converts the validation sample to build with maven. (issue1537805)
http://gwt-code-reviews.appspot.com/1537805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Converts the validation sample to build with maven. (issue1537805)
I'm stuck. At runtime in dev mode (when I send a name to be validated from the client), I'm getting "No source code is available" errors for the hibernate validators. e.g. 00:00:57.069 [ERROR] Errors in '/Users/rjrjr/src/gwt-g5/google3/third_party/java_src/gwt/svn/trunk/samples/validation/target/.generated/com/google/gwt/sample/validation/shared/_PersonValidatorImpl.java' 00:00:57.069 [ERROR] Line 36: No source code is available for type org.hibernate.validator.constraints.impl.SizeValidatorForString; did you forget to inherit a required module? 00:00:57.069 [ERROR] Line 36: No source code is available for type org.hibernate.validator.constraints.impl.SizeValidatorForCollection; did you forget to inherit a required module? 00:00:57.069 [ERROR] Line 36: No source code is available for type org.hibernate.validator.constraints.impl.SizeValidatorForMap; did you forget to inherit a required module? 00:00:57.070 [ERROR] Line 57: No source code is available for type org.hibernate.validator.constraints.impl.NotNullValidator; did you forget to inherit a required module? 00:00:57.070 [ERROR] Line 87: No source code is available for type org.hibernate.validator.constraints.impl.MaxValidatorForNumber; did you forget to inherit a required module? 00:00:57.070 [ERROR] Line 87: No source code is available for type org.hibernate.validator.constraints.impl.MaxValidatorForString; did you forget to inherit a required module? And maybe this is a clue, or just noise -- on launch I see this complaint: 00:00:08.075 [SPAM] Resolving org.hibernate.validator.constraints.ScriptAssert 00:00:08.075 [SPAM] Found type 'org.hibernate.validator.constraints.ScriptAssert' 00:00:08.075 [ERROR] Annotation error: cannot resolve org.hibernate.validator.constraints.impl.ScriptAssertValidator java.lang.ClassNotFoundException: org.hibernate.validator.constraints.impl.ScriptAssertValidator at java.net.URLClassLoader$1.run(URLClassLoader.java:202) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:190) at java.lang.ClassLoader.loadClass(ClassLoader.java:306) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301) at java.lang.ClassLoader.loadClass(ClassLoader.java:247) at java.lang.Class.forName0(Native Method) at java.lang.Class.forName(Class.java:247) at com.google.gwt.dev.javac.TypeOracleMediator.resolveAnnotationValue(TypeOracleMediator.java:750) at com.google.gwt.dev.javac.TypeOracleMediator.resolveAnnotationValue(TypeOracleMediator.java:689) at com.google.gwt.dev.javac.TypeOracleMediator.createAnnotation(TypeOracleMediator.java:498) at com.google.gwt.dev.javac.TypeOracleMediator.resolveAnnotation(TypeOracleMediator.java:648) at com.google.gwt.dev.javac.TypeOracleMediator.resolveAnnotations(TypeOracleMediator.java:663) at com.google.gwt.dev.javac.TypeOracleMediator.resolveClass(TypeOracleMediator.java:809) at com.google.gwt.dev.javac.TypeOracleMediator.addNewTypes(TypeOracleMediator.java:439) at com.google.gwt.dev.javac.TypeOracleMediatorFromSource.addNewUnits(TypeOracleMediatorFromSource.java:52) at com.google.gwt.dev.javac.CompilationState.assimilateUnits(CompilationState.java:164) at com.google.gwt.dev.javac.CompilationState.(CompilationState.java:82) at com.google.gwt.dev.javac.CompilationStateBuilder.doBuildFrom(CompilationStateBuilder.java:450) at com.google.gwt.dev.javac.CompilationStateBuilder.buildFrom(CompilationStateBuilder.java:370) at com.google.gwt.dev.cfg.ModuleDef.getCompilationState(ModuleDef.java:360) at com.google.gwt.dev.DevModeBase$UiBrowserWidgetHostImpl.createModuleSpaceHost(DevModeBase.java:110) at com.google.gwt.dev.shell.OophmSessionHandler.loadModule(OophmSessionHandler.java:197) at com.google.gwt.dev.shell.BrowserChannelServer.processConnection(BrowserChannelServer.java:525) at com.google.gwt.dev.shell.BrowserChannelServer.run(BrowserChannelServer.java:363) at java.lang.Thread.run(Thread.java:680)00:00:08.075 [ERROR] Annotation error: expected class java.lang.Class, got null http://gwt-code-reviews.appspot.com/1537805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Converts the validation sample to build with maven. (issue1537805)
Reviewers: drfibonacci, rchandia, Description: Converts the validation sample to build with maven. Please review this at http://gwt-code-reviews.appspot.com/1537805/ Affected files: D eclipse/samples/Validation/.checkstyle D eclipse/samples/Validation/.classpath D eclipse/samples/Validation/.project D eclipse/samples/Validation/Validation-gwtc.launch D eclipse/samples/Validation/Validation.launch M samples/build.xml A samples/validation/README-MAVEN.txt M samples/validation/build.xml A samples/validation/pom.xml D samples/validation/src/com/google/gwt/sample/validation/COPYING D samples/validation/src/com/google/gwt/sample/validation/Validation.gwt.xml D samples/validation/src/com/google/gwt/sample/validation/client/CustomValidationMessagesResolver.java D samples/validation/src/com/google/gwt/sample/validation/client/GreetingService.java D samples/validation/src/com/google/gwt/sample/validation/client/GreetingServiceAsync.java D samples/validation/src/com/google/gwt/sample/validation/client/SampleValidatorFactory.java D samples/validation/src/com/google/gwt/sample/validation/client/Validation.java D samples/validation/src/com/google/gwt/sample/validation/client/ValidationMessages.java D samples/validation/src/com/google/gwt/sample/validation/client/ValidationMessages.properties D samples/validation/src/com/google/gwt/sample/validation/client/ValidationView.java D samples/validation/src/com/google/gwt/sample/validation/client/ValidationView.ui.xml D samples/validation/src/com/google/gwt/sample/validation/server/GreetingServiceImpl.java D samples/validation/src/com/google/gwt/sample/validation/shared/Address.java D samples/validation/src/com/google/gwt/sample/validation/shared/ClientGroup.java D samples/validation/src/com/google/gwt/sample/validation/shared/NoOp.java D samples/validation/src/com/google/gwt/sample/validation/shared/NoOpValidator.java D samples/validation/src/com/google/gwt/sample/validation/shared/Person.java D samples/validation/src/com/google/gwt/sample/validation/shared/ServerConstraint.java D samples/validation/src/com/google/gwt/sample/validation/shared/ServerGroup.java D samples/validation/src/com/google/gwt/sample/validation/shared/ServerValidator.java D samples/validation/src/com/google/gwt/sample/validation/shared/Zip.java D samples/validation/src/com/google/gwt/sample/validation/super/com/google/gwt/sample/validation/shared/ServerValidator.java A samples/validation/src/main/java/com/google/gwt/sample/validation/COPYING A samples/validation/src/main/java/com/google/gwt/sample/validation/Validation.gwt.xml A samples/validation/src/main/java/com/google/gwt/sample/validation/client/CustomValidationMessagesResolver.java A samples/validation/src/main/java/com/google/gwt/sample/validation/client/GreetingService.java A samples/validation/src/main/java/com/google/gwt/sample/validation/client/GreetingServiceAsync.java A samples/validation/src/main/java/com/google/gwt/sample/validation/client/SampleValidatorFactory.java A samples/validation/src/main/java/com/google/gwt/sample/validation/client/Validation.java A samples/validation/src/main/java/com/google/gwt/sample/validation/client/ValidationMessages.java A samples/validation/src/main/java/com/google/gwt/sample/validation/client/ValidationMessages.properties A samples/validation/src/main/java/com/google/gwt/sample/validation/client/ValidationView.java A samples/validation/src/main/java/com/google/gwt/sample/validation/client/ValidationView.ui.xml A samples/validation/src/main/java/com/google/gwt/sample/validation/server/GreetingServiceImpl.java A samples/validation/src/main/java/com/google/gwt/sample/validation/shared/Address.java A samples/validation/src/main/java/com/google/gwt/sample/validation/shared/ClientGroup.java A samples/validation/src/main/java/com/google/gwt/sample/validation/shared/NoOp.java A samples/validation/src/main/java/com/google/gwt/sample/validation/shared/NoOpValidator.java A samples/validation/src/main/java/com/google/gwt/sample/validation/shared/Person.java A samples/validation/src/main/java/com/google/gwt/sample/validation/shared/ServerConstraint.java A samples/validation/src/main/java/com/google/gwt/sample/validation/shared/ServerGroup.java A samples/validation/src/main/java/com/google/gwt/sample/validation/shared/ServerValidator.java A samples/validation/src/main/java/com/google/gwt/sample/validation/shared/Zip.java A samples/validation/src/main/resources/com/google/gwt/sample/validation/SuperSource.gwt.xml A samples/validation/src/main/resources/com/google/gwt/sample/validation/super/com/google/gwt/sample/validation/shared/ServerValidator.java A samples/validation/src/main/webapp/Validation.css A samples/validation/src/main/webapp/Validation.html D samples/validation/war/Validation.css D samples/validation/war
[gwt-contrib] Re: Fixes ant build of DynatableRf sample (issue1537804)
On 2011/09/08 18:43:20, rchandia wrote: LGTM http://gwt-code-reviews.appspot.com/1537804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Event handling support for UiRenderer (issue1534806)
http://gwt-code-reviews.appspot.com/1534806/diff/10001/user/src/com/google/gwt/uibinder/client/impl/AbstractUiRenderer.java
File
user/src/com/google/gwt/uibinder/client/impl/AbstractUiRenderer.java
(right):
http://gwt-code-reviews.appspot.com/1534806/diff/10001/user/src/com/google/gwt/uibinder/client/impl/AbstractUiRenderer.java#newcode60
user/src/com/google/gwt/uibinder/client/impl/AbstractUiRenderer.java:60:
if (!isParentOrRenderer(parentOrRoot, RENDERED_ATTRIBUTE)) {
Should call the single arg version.
This method is null tolerant. Should it NPE instead? If so, does that
fix belong in isParentOrRenderer(Element, String)?
http://gwt-code-reviews.appspot.com/1534806/diff/10001/user/src/com/google/gwt/uibinder/client/impl/AbstractUiRenderer.java#newcode322
user/src/com/google/gwt/uibinder/client/impl/AbstractUiRenderer.java:322:
* Walks up the parents of the {@code rendered} element to ascertain that
it is attached to the
In DevMode, ...
... Always returns true in ProdMode
http://gwt-code-reviews.appspot.com/1534806/diff/10001/user/src/com/google/gwt/uibinder/client/impl/UiBinderUtil.java
File user/src/com/google/gwt/uibinder/client/impl/UiBinderUtil.java
(right):
http://gwt-code-reviews.appspot.com/1534806/diff/10001/user/src/com/google/gwt/uibinder/client/impl/UiBinderUtil.java#newcode28
user/src/com/google/gwt/uibinder/client/impl/UiBinderUtil.java:28:
public class UiBinderUtil {
As we discussed offline, it might not be the right time to make this
move. But if you keep it, could you add a note to the issue tracker
mentioning it as a breaking change (tag ReleaseNote=breakingChange)
http://gwt-code-reviews.appspot.com/1534806/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Scripts and configuration to upload GWT bits to Maven repos (issue1520810)
http://gwt-code-reviews.appspot.com/1520810/diff/12001/maven/lib-gwt.sh File maven/lib-gwt.sh (right): http://gwt-code-reviews.appspot.com/1520810/diff/12001/maven/lib-gwt.sh#newcode87 maven/lib-gwt.sh:87: maven-deploy-file $mavenRepoUrl $mavenRepoId "$jarExpandDir-user/gwt-user-sources.jar" $pomDir/gwt/gwt-servlet/pom.xml sources You're allowing the deploy attempt to continue when a maven-deploy-file call fails. Is that intentional? http://gwt-code-reviews.appspot.com/1520810/diff/12001/maven/lib-gwt.sh#newcode91 maven/lib-gwt.sh:91: # Remove bundled org/json classes Wouldn't it be more robust to do all of this prepping before doing any of the maven-deploy-file calls? http://gwt-code-reviews.appspot.com/1520810/diff/12001/maven/lib-gwt.sh#newcode105 maven/lib-gwt.sh:105: # Clean up Should make this an exit hook http://gwt-code-reviews.appspot.com/1520810/diff/12001/maven/lib-maven-deploy.sh File maven/lib-maven-deploy.sh (right): http://gwt-code-reviews.appspot.com/1520810/diff/12001/maven/lib-maven-deploy.sh#newcode28 maven/lib-maven-deploy.sh:28: echo "WARNING: Unable to deploy $artifactId in repo! Cannot find corresponding file!" Shouldn't you die at this point? Or return 1 and have the caller die? http://gwt-code-reviews.appspot.com/1520810/diff/12001/maven/poms/gwt/gwt-user/pom-template.xml File maven/poms/gwt/gwt-user/pom-template.xml (right): http://gwt-code-reviews.appspot.com/1520810/diff/12001/maven/poms/gwt/gwt-user/pom-template.xml#newcode20 maven/poms/gwt/gwt-user/pom-template.xml:20: out-dent http://gwt-code-reviews.appspot.com/1520810/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Scripts and configuration to upload GWT bits to Maven repos (issue1520810)
Mark, could you review this too? http://gwt-code-reviews.appspot.com/1520810/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Event handling support for UiRenderer (issue1534806)
http://gwt-code-reviews.appspot.com/1534806/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java File user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java (right): http://gwt-code-reviews.appspot.com/1534806/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#newcode1215 user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:1215: formatMethodError(targetType, jMethod), e.getMessage()); Could you consolidate all these identical die calls into a single private method? http://gwt-code-reviews.appspot.com/1534806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: to set property values (issue1524803)
Thanks for the test. Rafa, I've lost track of what to worry about wrt the ordering. Should we be tossing a LazyPanel or something like that into his test to shake things out? http://gwt-code-reviews.appspot.com/1524803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix http://code.google.com/p/google-web-toolkit/issues/detail?id=6161 (issue1520807)
http://gwt-code-reviews.appspot.com/1520807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix http://code.google.com/p/google-web-toolkit/issues/detail?id=6161 (issue1520807)
On 2011/09/02 20:37:51, rjrjr wrote: Ah, what the hell. No failing tests so far when I make it toxic. http://gwt-code-reviews.appspot.com/1520807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix http://code.google.com/p/google-web-toolkit/issues/detail?id=6161 (issue1520807)
http://gwt-code-reviews.appspot.com/1520807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Update the missing plugin page to stop taunting Safari 5.1 users, and (issue1536803)
Kelly, can you take another look? Now sniffing on the Safari version rather than the Webkit version, so that 5.0.6 isn't blocked. http://gwt-code-reviews.appspot.com/1536803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Update the missing plugin page to stop taunting Safari 5.1 users, and (issue1536803)
http://gwt-code-reviews.appspot.com/1536803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Event handling support for UiRenderer (issue1534806)
Nice.
http://gwt-code-reviews.appspot.com/1534806/diff/1/user/src/com/google/gwt/uibinder/client/AbstractUiRenderer.java
File user/src/com/google/gwt/uibinder/client/AbstractUiRenderer.java
(right):
http://gwt-code-reviews.appspot.com/1534806/diff/1/user/src/com/google/gwt/uibinder/client/AbstractUiRenderer.java#newcode27
user/src/com/google/gwt/uibinder/client/AbstractUiRenderer.java:27:
public abstract class AbstractUiRenderer implements UiRenderer {
This should be in an impl package. I've long regretted not doing that
with UiBinderUtil (and bonus points if you move it there too).
http://gwt-code-reviews.appspot.com/1534806/diff/1/user/src/com/google/gwt/uibinder/client/AbstractUiRenderer.java#newcode34
user/src/com/google/gwt/uibinder/client/AbstractUiRenderer.java:34:
public abstract static class UiRendererDispatcher implements
HasHandlers {
Can this be protected?
http://gwt-code-reviews.appspot.com/1534806/diff/1/user/src/com/google/gwt/uibinder/client/AbstractUiRenderer.java#newcode43
user/src/com/google/gwt/uibinder/client/AbstractUiRenderer.java:43:
private int methodIndex;
Are these going to get clobbered on recursive calls?
http://gwt-code-reviews.appspot.com/1534806/diff/1/user/src/com/google/gwt/uibinder/client/AbstractUiRenderer.java#newcode72
user/src/com/google/gwt/uibinder/client/AbstractUiRenderer.java:72:
table = UiRendererUtilsImpl.buildDispatchMap(keys, values);
Are you rebuilding this table for each event dispatch? If so, sounds
slow. Or does the dom hold on to a pointer to this thing?
http://gwt-code-reviews.appspot.com/1534806/diff/1/user/src/com/google/gwt/uibinder/client/UiRendererUtilsImpl.java
File user/src/com/google/gwt/uibinder/client/UiRendererUtilsImpl.java
(right):
http://gwt-code-reviews.appspot.com/1534806/diff/1/user/src/com/google/gwt/uibinder/client/UiRendererUtilsImpl.java#newcode29
user/src/com/google/gwt/uibinder/client/UiRendererUtilsImpl.java:29:
public class UiRendererUtilsImpl {
Can all these public static things instead be protected members on
AbstractUiRenderer?
http://gwt-code-reviews.appspot.com/1534806/diff/1/user/src/com/google/gwt/uibinder/client/UiRendererUtilsImpl.java#newcode31
user/src/com/google/gwt/uibinder/client/UiRendererUtilsImpl.java:31:
public static final int NO_HANDLER_FOUND = -1;
do these constants really need to be public?
http://gwt-code-reviews.appspot.com/1534806/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
File user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
(right):
http://gwt-code-reviews.appspot.com/1534806/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#newcode192
user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:192:
List methods = new
ArrayList(Arrays.asList(type.getMethods()));
this won't work with superclasses. use
JClassType.getInheritableMethods(), and should add a unit test for that
case.
http://gwt-code-reviews.appspot.com/1534806/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#newcode244
user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:244:
JMethod[] allMethods = type.getMethods();
ditto. Should do a general search for getMethods
http://gwt-code-reviews.appspot.com/1534806/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#newcode414
user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:414: throw
new RuntimeException("UiRenderer is not a parametrizable type in " +
binderType);
parameterizable
http://gwt-code-reviews.appspot.com/1534806/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#newcode1202
user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:1202: try {
Should use the TypeOracle, not reflection
http://gwt-code-reviews.appspot.com/1534806/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#newcode1465
user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:1465: *
Validates each {@code eventMethod} (e.g. {@code onBrowserEvent()}).
(e.g. {@code void onBrowserEvent(HandlerType o, NativeEvent e, Element
parent, A a, B b, ...);})
http://gwt-code-reviews.appspot.com/1534806/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#newcode1470
user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:1470: *
(if it has any methods annotated with {@code @UiHandler})
d/if it has/
http://gwt-code-reviews.appspot.com/1534806/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#newcode1515
user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:1515: *
The second parameter must be of type {@link
com.google.gwt.dom.client.Element Element}
What do you think about making the element type optional too? I'd be
okay with requiring it to be in place if they want to use other optional
parameters.
http://gwt-code-reviews.appspot.com/1534806/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#newcode2140
user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:2140: //
ClickEvent.getType();
Should this happen lazily
[gwt-contrib] Re: Event handling support for UiRenderer (issue1534806)
On 2011/08/31 17:44:19, rchandia wrote: Could you post a sample of the generated code somewhere? Nothing fancy or permanent, I'm just too lazy to patch this and harvest my own. http://gwt-code-reviews.appspot.com/1534806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
