Re: [classlib] enabling AWT/Swing by default (was: Re: svn commit: r452826 - in /incubator/harmony/enhanced/classlib/trunk: depends/libs/build/ depends/libs/windows.x86/ make/depends.properties make/d

[Alexei Zakharov]

Hi Oleg,


On the other hand, why don't we allow Harmony to accept invalid names
and provide a default replacements for them if there is a set/get/is
method for the specified property? It seems to me more user-friendly
then throw IntrospectionException in this situation. It looks like the
specification doesn't require PropertyDescriptor to throw an exception
in this case.


Well, the specification states here:

==
public PropertyDescriptor(String propertyName,
 Class? beanClass,
 String readMethodName,
 String writeMethodName)
  throws IntrospectionException
...
Parameters:
...
   readMethodName - The name of the method used for reading the
property value. May be null if the property is write-only.
   writeMethodName - The name of the method used for writing the
property value. May be null if the property is read-only.
Throws:
   IntrospectionException - if an exception occurs during introspection.
==

So we have the description of the valid parameter case, null parameter
case and the exception that can be thrown. IMHO the natural conclusion
from that is that the exception will be thrown in case of invalid
parameter. Moreover, if the implementation does not validate method
names it will never throw IntrospectionException. But it is described
by the spec.
BTW, PropertyDescriptor(String, Method, Method) validates both methods
and throws IntrospectionException if something is wrong.


This will also prevent us from breaking applications
that uses this RI behavior.


Actually I don't belive they exist in our world. :) May be we can
leave the current functionality for now and get back to this if
encounter one of such apps?

Regards,

2006/10/5, Oleg Khaschansky [EMAIL PROTECTED]:

Alexey,

Agree. I haven't noticed that RI doesn't accept invalid write method.
Then its behavior looks illogical. Actually, I asked about comments
especially because I expected a feedback from beans authors. Thank
you.

On the other hand, why don't we allow Harmony to accept invalid names
and provide a default replacements for them if there is a set/get/is
method for the specified property? It seems to me more user-friendly
then throw IntrospectionException in this situation. It looks like the
specification doesn't require PropertyDescriptor to throw an exception
in this case. This will also prevent us from breaking applications
that uses this RI behavior.
What is your opinion?

On 10/5/06, Alexei Zakharov [EMAIL PROTECTED] wrote:
 Oleg,

  + we need to fix in beans the fact that the following code:
  new PropertyDescriptor(propertyName, c.getClass(), 1, null);
  will throw IntrospectionException on Harmony, but will return the
  valid property descriptor with the getter method on RI.
  Any thoughts on this? Or should I proceed with a patch for the both issues?

 I've already written my thoughts about this issue in [1]. In short: I
 don't think we should follow the RI behavior since it is inconsistent.
 Why it accepts invalid read method and throws exception on invalid
 write method? No logic.

 [1] 
http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200609.mbox/[EMAIL 
PROTECTED]

 Thanks,

 2006/10/4, Oleg Khaschansky [EMAIL PROTECTED]:
  I found the reason of this failure. It is an IntrospectionException
  while executing a following method from the TransferHandler class:
 
 private PropertyDescriptor getPropertyDescriptor(final JComponent c) {
 PropertyDescriptor result = null;
 try {
 result = new PropertyDescriptor(propertyName, c.getClass());
 } catch (IntrospectionException e) {
 
 }
 return result;
 }
  It tries to get the PropertyDescriptor for the class JButton and
  property name insets, but fails because there's no setInsets method.
  So, flavors array stays uninitialized and getTransferDataFlavors
  method returns null which is a cause of a NPE.
 
  The quick fix for this issue could be changing this method to the following:
 
 private PropertyDescriptor getPropertyDescriptor(final JComponent c) {
 PropertyDescriptor result = null;
 try {
 return result = new PropertyDescriptor(propertyName, 
c.getClass());
 } catch (IntrospectionException e) {
 }
 try {
 return result = new PropertyDescriptor(propertyName,
  c.getClass(), 1, null);
 } catch (IntrospectionException e) {
 }
 return result;
 }
 
  + we need to fix in beans the fact that the following code:
 
  new PropertyDescriptor(propertyName, c.getClass(), 1, null);
 
  will throw IntrospectionException on Harmony, but will return the
  valid property descriptor with the getter method on RI.
 
  Any thoughts on this? Or should I proceed with a patch for the both issues?
 
  Thanks,
   Oleg
 
  On 10/4/06, Mikhail Loenko [EMAIL PROTECTED] wrote:
   2006/10/4, Mark Hindess [EMAIL PROTECTED]:
   
On 4 October 2006 

Re: [classlib] enabling AWT/Swing by default (was: Re: svn commit: r452826 - in /incubator/harmony/enhanced/classlib/trunk: depends/libs/build/ depends/libs/windows.x86/ make/depends.properties make/d

[Oleg Khaschansky]

Ok. I am testing another patch for the TransferHandler which won't affect beans.

On 10/6/06, Alexei Zakharov [EMAIL PROTECTED] wrote:

Hi Oleg,

 On the other hand, why don't we allow Harmony to accept invalid names
 and provide a default replacements for them if there is a set/get/is
 method for the specified property? It seems to me more user-friendly
 then throw IntrospectionException in this situation. It looks like the
 specification doesn't require PropertyDescriptor to throw an exception
 in this case.

Well, the specification states here:

==
public PropertyDescriptor(String propertyName,
  Class? beanClass,
  String readMethodName,
  String writeMethodName)
   throws IntrospectionException
...
Parameters:
...
readMethodName - The name of the method used for reading the
property value. May be null if the property is write-only.
writeMethodName - The name of the method used for writing the
property value. May be null if the property is read-only.
Throws:
IntrospectionException - if an exception occurs during introspection.
==

So we have the description of the valid parameter case, null parameter
case and the exception that can be thrown. IMHO the natural conclusion
from that is that the exception will be thrown in case of invalid
parameter. Moreover, if the implementation does not validate method
names it will never throw IntrospectionException. But it is described
by the spec.
BTW, PropertyDescriptor(String, Method, Method) validates both methods
and throws IntrospectionException if something is wrong.

 This will also prevent us from breaking applications
 that uses this RI behavior.

Actually I don't belive they exist in our world. :) May be we can
leave the current functionality for now and get back to this if
encounter one of such apps?

Regards,

2006/10/5, Oleg Khaschansky [EMAIL PROTECTED]:
 Alexey,

 Agree. I haven't noticed that RI doesn't accept invalid write method.
 Then its behavior looks illogical. Actually, I asked about comments
 especially because I expected a feedback from beans authors. Thank
 you.

 On the other hand, why don't we allow Harmony to accept invalid names
 and provide a default replacements for them if there is a set/get/is
 method for the specified property? It seems to me more user-friendly
 then throw IntrospectionException in this situation. It looks like the
 specification doesn't require PropertyDescriptor to throw an exception
 in this case. This will also prevent us from breaking applications
 that uses this RI behavior.
 What is your opinion?

 On 10/5/06, Alexei Zakharov [EMAIL PROTECTED] wrote:
  Oleg,
 
   + we need to fix in beans the fact that the following code:
   new PropertyDescriptor(propertyName, c.getClass(), 1, null);
   will throw IntrospectionException on Harmony, but will return the
   valid property descriptor with the getter method on RI.
   Any thoughts on this? Or should I proceed with a patch for the both 
issues?
 
  I've already written my thoughts about this issue in [1]. In short: I
  don't think we should follow the RI behavior since it is inconsistent.
  Why it accepts invalid read method and throws exception on invalid
  write method? No logic.
 
  [1] 
http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200609.mbox/[EMAIL 
PROTECTED]
 
  Thanks,
 
  2006/10/4, Oleg Khaschansky [EMAIL PROTECTED]:
   I found the reason of this failure. It is an IntrospectionException
   while executing a following method from the TransferHandler class:
  
  private PropertyDescriptor getPropertyDescriptor(final JComponent c) {
  PropertyDescriptor result = null;
  try {
  result = new PropertyDescriptor(propertyName, c.getClass());
  } catch (IntrospectionException e) {
  
  }
  return result;
  }
   It tries to get the PropertyDescriptor for the class JButton and
   property name insets, but fails because there's no setInsets method.
   So, flavors array stays uninitialized and getTransferDataFlavors
   method returns null which is a cause of a NPE.
  
   The quick fix for this issue could be changing this method to the 
following:
  
  private PropertyDescriptor getPropertyDescriptor(final JComponent c) {
  PropertyDescriptor result = null;
  try {
  return result = new PropertyDescriptor(propertyName, 
c.getClass());
  } catch (IntrospectionException e) {
  }
  try {
  return result = new PropertyDescriptor(propertyName,
   c.getClass(), 1, null);
  } catch (IntrospectionException e) {
  }
  return result;
  }
  
   + we need to fix in beans the fact that the following code:
  
   new PropertyDescriptor(propertyName, c.getClass(), 1, null);
  
   will throw IntrospectionException on Harmony, but will return the
   valid property descriptor with the getter method on RI.
  
   Any 

Re: [classlib] enabling AWT/Swing by default (was: Re: svn commit: r452826 - in /incubator/harmony/enhanced/classlib/trunk: depends/libs/build/ depends/libs/windows.x86/ make/depends.properties make/d

[Oleg Khaschansky]

Patch for the TransferHandlerTest failure is here:

http://issues.apache.org/jira/browse/HARMONY-1723

On 10/5/06, Mikhail Loenko [EMAIL PROTECTED] wrote:

2006/10/5, Oleg Khaschansky [EMAIL PROTECTED]:
 I found the reason of this failure. It is an IntrospectionException
 while executing a following method from the TransferHandler class:

private PropertyDescriptor getPropertyDescriptor(final JComponent c) {
PropertyDescriptor result = null;
try {
result = new PropertyDescriptor(propertyName, c.getClass());
} catch (IntrospectionException e) {

}
return result;
}
 It tries to get the PropertyDescriptor for the class JButton and
 property name insets, but fails because there's no setInsets method.
 So, flavors array stays uninitialized and getTransferDataFlavors
 method returns null which is a cause of a NPE.

 The quick fix for this issue could be changing this method to the following:

private PropertyDescriptor getPropertyDescriptor(final JComponent c) {
PropertyDescriptor result = null;
try {
return result = new PropertyDescriptor(propertyName, c.getClass());
} catch (IntrospectionException e) {
}
try {
return result = new PropertyDescriptor(propertyName,
 c.getClass(), 1, null);
} catch (IntrospectionException e) {
}
return result;
}

 + we need to fix in beans the fact that the following code:

 new PropertyDescriptor(propertyName, c.getClass(), 1, null);

 will throw IntrospectionException on Harmony, but will return the
 valid property descriptor with the getter method on RI.

 Any thoughts on this? Or should I proceed with a patch for the both issues?

Yes, please. When you submit a patch people will have a chance
to review and comment

Thanks,
Mikhail



 Thanks,
  Oleg

 On 10/4/06, Mikhail Loenko [EMAIL PROTECTED] wrote:
  2006/10/4, Mark Hindess [EMAIL PROTECTED]:
  
   On 4 October 2006 at 15:41, Tim Ellison [EMAIL PROTECTED] wrote:
Excuse the change in subject line...
  
   No problem.  I was just cursing myself for having forgotten to change
   it.
  
Mark Hindess wrote:
 With this change, the awt dependencies should now be automated for
 windows and at least fairly trivial (installing a few packages on
 Linux[0]).  I think it is time we removed the with.awt.swing flag.
 Anyone object?
   
To the contrary, ditch it.
   
 Please test the current setup with -Dwith.awt.swing=true and report 
any
 problems.
   
Problem 1:  My machine is too slow running all these tests.
  
   Mine too.  And I have wondered if the hourly builds will finish within
   the hour now.  We really should see if we can avoid the need to fork
   for every test.
 
  I've run the tests on my XP machine, 1 failed
 
  javax.swing.TransferHandlerTest#testCreateTransferable
 
  java.lang.NullPointerException at
  
javax.swing.TransferHandlerTest.testCreateTransferable(TransferHandlerTest.java:140)
  at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:25)
  at javax.swing.BasicSwingTestCase.runBareSuper(BasicSwingTestCase.java:115)
  at javax.swing.SwingTestCase$1.run(SwingTestCase.java:44) at
  java.awt.event.InvocationEvent.runAndNotify(InvocationEvent.java:88)
  at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:77) at
  java.awt.EventQueueCore.dispatchEventImpl(EventQueueCore.java:131) at
  java.awt.EventQueue.dispatchEvent(EventQueue.java:144) at
  java.awt.EventDispatchThread.runModalLoop(EventDispatchThread.java:75)
  at java.awt.EventDispatchThread.run(EventDispatchThread.java:48)
 
  Thanks,
  Mikhail
 
 
  
   Regards,
Mark.
  
Regards,
Tim
   
 [0] Details of the required packages for distributions other than
 Debian/Ubuntu would be welcome.

 On 4 October 2006 at 10:24, [EMAIL PROTECTED] wrote:
 Author: hindessm
 Date: Wed Oct  4 03:24:29 2006
 New Revision: 452826

 URL: http://svn.apache.org/viewvc?view=revrev=452826
 Log:
 Update check/fetch depends targets to handle the awt dependencies.

 Modified:
 incubator/harmony/enhanced/classlib/trunk/depends/libs/build/   
(props
 ch
 anged)
 
incubator/harmony/enhanced/classlib/trunk/depends/libs/windows.x86/
(pr
 ops changed)
 incubator/harmony/enhanced/classlib/trunk/make/depends.properties
 incubator/harmony/enhanced/classlib/trunk/make/depends.xml

 Propchange: 
incubator/harmony/enhanced/classlib/trunk/depends/libs/build/
 
--
---
 -
 --- svn:ignore (original)
 +++ svn:ignore Wed Oct  4 03:24:29 2006
 @@ -1,3 +1,4 @@
  jpeg
  lcms
  png
 +winxp_2006-09-28.txt

 Propchange: 
incubator/harmony/enhanced/classlib/trunk/depends/libs/windows
.x8
 6

Re: [classlib] enabling AWT/Swing by default (was: Re: svn commit: r452826 - in /incubator/harmony/enhanced/classlib/trunk: depends/libs/build/ depends/libs/windows.x86/ make/depends.properties make/d

[Alexei Zakharov]

Oleg,


+ we need to fix in beans the fact that the following code:
new PropertyDescriptor(propertyName, c.getClass(), 1, null);
will throw IntrospectionException on Harmony, but will return the
valid property descriptor with the getter method on RI.
Any thoughts on this? Or should I proceed with a patch for the both issues?


I've already written my thoughts about this issue in [1]. In short: I
don't think we should follow the RI behavior since it is inconsistent.
Why it accepts invalid read method and throws exception on invalid
write method? No logic.

[1] 
http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200609.mbox/[EMAIL
 PROTECTED]

Thanks,

2006/10/4, Oleg Khaschansky [EMAIL PROTECTED]:

I found the reason of this failure. It is an IntrospectionException
while executing a following method from the TransferHandler class:

   private PropertyDescriptor getPropertyDescriptor(final JComponent c) {
   PropertyDescriptor result = null;
   try {
   result = new PropertyDescriptor(propertyName, c.getClass());
   } catch (IntrospectionException e) {

   }
   return result;
   }
It tries to get the PropertyDescriptor for the class JButton and
property name insets, but fails because there's no setInsets method.
So, flavors array stays uninitialized and getTransferDataFlavors
method returns null which is a cause of a NPE.

The quick fix for this issue could be changing this method to the following:

   private PropertyDescriptor getPropertyDescriptor(final JComponent c) {
   PropertyDescriptor result = null;
   try {
   return result = new PropertyDescriptor(propertyName, c.getClass());
   } catch (IntrospectionException e) {
   }
   try {
   return result = new PropertyDescriptor(propertyName,
c.getClass(), 1, null);
   } catch (IntrospectionException e) {
   }
   return result;
   }

+ we need to fix in beans the fact that the following code:

new PropertyDescriptor(propertyName, c.getClass(), 1, null);

will throw IntrospectionException on Harmony, but will return the
valid property descriptor with the getter method on RI.

Any thoughts on this? Or should I proceed with a patch for the both issues?

Thanks,
 Oleg

On 10/4/06, Mikhail Loenko [EMAIL PROTECTED] wrote:
 2006/10/4, Mark Hindess [EMAIL PROTECTED]:
 
  On 4 October 2006 at 15:41, Tim Ellison [EMAIL PROTECTED] wrote:
   Excuse the change in subject line...
 
  No problem.  I was just cursing myself for having forgotten to change
  it.
 
   Mark Hindess wrote:
With this change, the awt dependencies should now be automated for
windows and at least fairly trivial (installing a few packages on
Linux[0]).  I think it is time we removed the with.awt.swing flag.
Anyone object?
  
   To the contrary, ditch it.
  
Please test the current setup with -Dwith.awt.swing=true and report any
problems.
  
   Problem 1:  My machine is too slow running all these tests.
 
  Mine too.  And I have wondered if the hourly builds will finish within
  the hour now.  We really should see if we can avoid the need to fork
  for every test.

 I've run the tests on my XP machine, 1 failed

 javax.swing.TransferHandlerTest#testCreateTransferable

 java.lang.NullPointerException at
 
javax.swing.TransferHandlerTest.testCreateTransferable(TransferHandlerTest.java:140)
 at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:25)
 at javax.swing.BasicSwingTestCase.runBareSuper(BasicSwingTestCase.java:115)
 at javax.swing.SwingTestCase$1.run(SwingTestCase.java:44) at
 java.awt.event.InvocationEvent.runAndNotify(InvocationEvent.java:88)
 at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:77) at
 java.awt.EventQueueCore.dispatchEventImpl(EventQueueCore.java:131) at
 java.awt.EventQueue.dispatchEvent(EventQueue.java:144) at
 java.awt.EventDispatchThread.runModalLoop(EventDispatchThread.java:75)
 at java.awt.EventDispatchThread.run(EventDispatchThread.java:48)



--
Alexei Zakharov,
Intel Middleware Product Division

-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [classlib] enabling AWT/Swing by default (was: Re: svn commit: r452826 - in /incubator/harmony/enhanced/classlib/trunk: depends/libs/build/ depends/libs/windows.x86/ make/depends.properties make/d

[Oleg Khaschansky]

Alexey,

Agree. I haven't noticed that RI doesn't accept invalid write method.
Then its behavior looks illogical. Actually, I asked about comments
especially because I expected a feedback from beans authors. Thank
you.

On the other hand, why don't we allow Harmony to accept invalid names
and provide a default replacements for them if there is a set/get/is
method for the specified property? It seems to me more user-friendly
then throw IntrospectionException in this situation. It looks like the
specification doesn't require PropertyDescriptor to throw an exception
in this case. This will also prevent us from breaking applications
that uses this RI behavior.
What is your opinion?

On 10/5/06, Alexei Zakharov [EMAIL PROTECTED] wrote:

Oleg,

 + we need to fix in beans the fact that the following code:
 new PropertyDescriptor(propertyName, c.getClass(), 1, null);
 will throw IntrospectionException on Harmony, but will return the
 valid property descriptor with the getter method on RI.
 Any thoughts on this? Or should I proceed with a patch for the both issues?

I've already written my thoughts about this issue in [1]. In short: I
don't think we should follow the RI behavior since it is inconsistent.
Why it accepts invalid read method and throws exception on invalid
write method? No logic.

[1] 
http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200609.mbox/[EMAIL
 PROTECTED]

Thanks,

2006/10/4, Oleg Khaschansky [EMAIL PROTECTED]:
 I found the reason of this failure. It is an IntrospectionException
 while executing a following method from the TransferHandler class:

private PropertyDescriptor getPropertyDescriptor(final JComponent c) {
PropertyDescriptor result = null;
try {
result = new PropertyDescriptor(propertyName, c.getClass());
} catch (IntrospectionException e) {

}
return result;
}
 It tries to get the PropertyDescriptor for the class JButton and
 property name insets, but fails because there's no setInsets method.
 So, flavors array stays uninitialized and getTransferDataFlavors
 method returns null which is a cause of a NPE.

 The quick fix for this issue could be changing this method to the following:

private PropertyDescriptor getPropertyDescriptor(final JComponent c) {
PropertyDescriptor result = null;
try {
return result = new PropertyDescriptor(propertyName, c.getClass());
} catch (IntrospectionException e) {
}
try {
return result = new PropertyDescriptor(propertyName,
 c.getClass(), 1, null);
} catch (IntrospectionException e) {
}
return result;
}

 + we need to fix in beans the fact that the following code:

 new PropertyDescriptor(propertyName, c.getClass(), 1, null);

 will throw IntrospectionException on Harmony, but will return the
 valid property descriptor with the getter method on RI.

 Any thoughts on this? Or should I proceed with a patch for the both issues?

 Thanks,
  Oleg

 On 10/4/06, Mikhail Loenko [EMAIL PROTECTED] wrote:
  2006/10/4, Mark Hindess [EMAIL PROTECTED]:
  
   On 4 October 2006 at 15:41, Tim Ellison [EMAIL PROTECTED] wrote:
Excuse the change in subject line...
  
   No problem.  I was just cursing myself for having forgotten to change
   it.
  
Mark Hindess wrote:
 With this change, the awt dependencies should now be automated for
 windows and at least fairly trivial (installing a few packages on
 Linux[0]).  I think it is time we removed the with.awt.swing flag.
 Anyone object?
   
To the contrary, ditch it.
   
 Please test the current setup with -Dwith.awt.swing=true and report 
any
 problems.
   
Problem 1:  My machine is too slow running all these tests.
  
   Mine too.  And I have wondered if the hourly builds will finish within
   the hour now.  We really should see if we can avoid the need to fork
   for every test.
 
  I've run the tests on my XP machine, 1 failed
 
  javax.swing.TransferHandlerTest#testCreateTransferable
 
  java.lang.NullPointerException at
  
javax.swing.TransferHandlerTest.testCreateTransferable(TransferHandlerTest.java:140)
  at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:25)
  at javax.swing.BasicSwingTestCase.runBareSuper(BasicSwingTestCase.java:115)
  at javax.swing.SwingTestCase$1.run(SwingTestCase.java:44) at
  java.awt.event.InvocationEvent.runAndNotify(InvocationEvent.java:88)
  at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:77) at
  java.awt.EventQueueCore.dispatchEventImpl(EventQueueCore.java:131) at
  java.awt.EventQueue.dispatchEvent(EventQueue.java:144) at
  java.awt.EventDispatchThread.runModalLoop(EventDispatchThread.java:75)
  at java.awt.EventDispatchThread.run(EventDispatchThread.java:48)
 

--
Alexei Zakharov,
Intel Middleware Product Division

-
Terms of use : 

Re: svn commit: r452826 - in /incubator/harmony/enhanced/classlib/trunk: depends/libs/build/ depends/libs/windows.x86/ make/depends.properties make/depends.xml

[Mark Hindess]

With this change, the awt dependencies should now be automated for
windows and at least fairly trivial (installing a few packages on
Linux[0]).  I think it is time we removed the with.awt.swing flag.
Anyone object?

Please test the current setup with -Dwith.awt.swing=true and report any
problems.

Regards,
 Mark.

[0] Details of the required packages for distributions other than
Debian/Ubuntu would be welcome.

On 4 October 2006 at 10:24, [EMAIL PROTECTED] wrote:
 Author: hindessm
 Date: Wed Oct  4 03:24:29 2006
 New Revision: 452826
 
 URL: http://svn.apache.org/viewvc?view=revrev=452826
 Log:
 Update check/fetch depends targets to handle the awt dependencies.
 
 Modified:
 incubator/harmony/enhanced/classlib/trunk/depends/libs/build/   (props ch
 anged)
 incubator/harmony/enhanced/classlib/trunk/depends/libs/windows.x86/   (pr
 ops changed)
 incubator/harmony/enhanced/classlib/trunk/make/depends.properties
 incubator/harmony/enhanced/classlib/trunk/make/depends.xml
 
 Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/build/
 -
 -
 --- svn:ignore (original)
 +++ svn:ignore Wed Oct  4 03:24:29 2006
 @@ -1,3 +1,4 @@
  jpeg
  lcms
  png
 +winxp_2006-09-28.txt
 
 Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/windows.x8
 6/
 -
 -
 --- svn:ignore (original)
 +++ svn:ignore Wed Oct  4 03:24:29 2006
 @@ -1 +1,2 @@
  msvcr71.dll
 +swing_awt_deps_winxp_2006-09-28.tgz
 
 Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.properties
 URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/m
 ake/depends.properties?view=diffrev=452826r1=452825r2=452826
 =
 =
 --- incubator/harmony/enhanced/classlib/trunk/make/depends.properties (origin
 al)
 +++ incubator/harmony/enhanced/classlib/trunk/make/depends.properties Wed Oct
   4 03:24:29 2006
 @@ -98,3 +98,11 @@
  servlet-api.jar=${jetty.dir}/servlet-api-2.5-6.0.0.jar
  servlet-api.md5=c27c02fb0a00cc3a7d05ea993a9bf56e
  servlet-api.url=${ibiblio.base}/maven2/jetty/servlet-api/2.5-6.0.0/servlet-a
 pi-2.5-6.0.0.jar
 +
 +people.apache.base=http://people.apache.org/~geirm/harmony/
 +awtdeps.dir=${depends.dir}/libs/windows.x86
 +awtdeps.tar=${awtdeps.dir}/swing_awt_deps_winxp_2006-09-28.tgz
 +awtdeps.url=${people.apache.base}swing_awt_deps_winxp_2006-09-28.tgz
 +awtdeps.md5=d61a27e4b305d9fcabaaacf34f8f534a
 +awtdeps.extract.dir=${depends.dir}/libs/build
 +awtdeps.testfile=${awtdeps.extract.dir}/winxp_2006-09-28.txt
 
 Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.xml
 URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/m
 ake/depends.xml?view=diffrev=452826r1=452825r2=452826
 =
 =
 --- incubator/harmony/enhanced/classlib/trunk/make/depends.xml (original)
 +++ incubator/harmony/enhanced/classlib/trunk/make/depends.xml Wed Oct  4 03:
 24:29 2006
 @@ -72,17 +72,22 @@
  
  /target
  
 -target name=-check-win if=is.windows
 +target name=-check-win if=is.windows
 +depends=-really-check-win,-awt-tar-extract /
 +
 +target name=-really-check-win if=is.windows
  
   check-one-file src=${msvcr71.url} dest=${msvcr71.dll} /
  
 -/target
 +check-one-file src=${awtdeps.url} dest=${awtdeps.tar} /
 +
 + uptodate property=awtdeps.uptodate
 +  srcfile=${awtdeps.tar}
 +  targetfile=${awtdeps.testfile} /
  
 -target name=-check-unix if=with.awt.swing
 -antcall target=--check-unix /
  /target
  
 -target name=--check-unix if=is.unix
 +target name=-check-unix if=is.unix
  
  property name=lcms.msg
value=liblcms development package not installed
 @@ -214,6 +219,10 @@
   download-one-file src=${msvcr71.url} dest=${msvcr71.dll}
 md5=${msvcr71.md5} /
  
 + mkdir dir=${awtdeps.dir} /
 + download-one-file src=${awtdeps.url} dest=${awtdeps.tar}
 +   md5=${awtdeps.md5} /
 +
  /target
  
  macrodef name=download-one-file
 @@ -298,6 +307,14 @@
   jar destfile=${bcprov.jar} basedir=${bcprov.dir}/temp
   manifest=${bcprov.dir}/temp/META-INF/MANIFEST.MF /
   delete dir=${bcprov.dir}/temp /
 +/target
 +
 +target name=-awt-tar-extract unless=awtdeps.uptodate
 +echoExtracting awt dependencies/echo
 + untar src=${awtdeps.tar} dest=${awtdeps.extract.dir}
 +   compression=gzip /
 +echo file=${awtdeps.testfile}
 +  message=${awtdeps.tar} extracted${line.separator} /
  /target
  
  macrodef name=check-one-link
 



-
Terms

Re: svn commit: r452826 - in /incubator/harmony/enhanced/classlib/trunk: depends/libs/build/ depends/libs/windows.x86/ make/depends.properties make/depends.xml

[Geir Magnusson Jr.]

Any reason why we couldn't do the same thing for linux that we're doing 
for windows in terms of having these libraries pre-compiled and easy to 
drop in?


geir

Mark Hindess wrote:

With this change, the awt dependencies should now be automated for
windows and at least fairly trivial (installing a few packages on
Linux[0]).  I think it is time we removed the with.awt.swing flag.
Anyone object?

Please test the current setup with -Dwith.awt.swing=true and report any
problems.

Regards,
 Mark.

[0] Details of the required packages for distributions other than
Debian/Ubuntu would be welcome.

On 4 October 2006 at 10:24, [EMAIL PROTECTED] wrote:

Author: hindessm
Date: Wed Oct  4 03:24:29 2006
New Revision: 452826

URL: http://svn.apache.org/viewvc?view=revrev=452826
Log:
Update check/fetch depends targets to handle the awt dependencies.

Modified:
incubator/harmony/enhanced/classlib/trunk/depends/libs/build/   (props ch
anged)
incubator/harmony/enhanced/classlib/trunk/depends/libs/windows.x86/   (pr
ops changed)
incubator/harmony/enhanced/classlib/trunk/make/depends.properties
incubator/harmony/enhanced/classlib/trunk/make/depends.xml

Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/build/
-
-
--- svn:ignore (original)
+++ svn:ignore Wed Oct  4 03:24:29 2006
@@ -1,3 +1,4 @@
 jpeg
 lcms
 png
+winxp_2006-09-28.txt

Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/windows.x8
6/
-
-
--- svn:ignore (original)
+++ svn:ignore Wed Oct  4 03:24:29 2006
@@ -1 +1,2 @@
 msvcr71.dll
+swing_awt_deps_winxp_2006-09-28.tgz

Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.properties
URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/m
ake/depends.properties?view=diffrev=452826r1=452825r2=452826
=
=
--- incubator/harmony/enhanced/classlib/trunk/make/depends.properties (origin
al)
+++ incubator/harmony/enhanced/classlib/trunk/make/depends.properties Wed Oct
  4 03:24:29 2006
@@ -98,3 +98,11 @@
 servlet-api.jar=${jetty.dir}/servlet-api-2.5-6.0.0.jar
 servlet-api.md5=c27c02fb0a00cc3a7d05ea993a9bf56e
 servlet-api.url=${ibiblio.base}/maven2/jetty/servlet-api/2.5-6.0.0/servlet-a
pi-2.5-6.0.0.jar
+
+people.apache.base=http://people.apache.org/~geirm/harmony/
+awtdeps.dir=${depends.dir}/libs/windows.x86
+awtdeps.tar=${awtdeps.dir}/swing_awt_deps_winxp_2006-09-28.tgz
+awtdeps.url=${people.apache.base}swing_awt_deps_winxp_2006-09-28.tgz
+awtdeps.md5=d61a27e4b305d9fcabaaacf34f8f534a
+awtdeps.extract.dir=${depends.dir}/libs/build
+awtdeps.testfile=${awtdeps.extract.dir}/winxp_2006-09-28.txt

Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.xml
URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/m
ake/depends.xml?view=diffrev=452826r1=452825r2=452826
=
=
--- incubator/harmony/enhanced/classlib/trunk/make/depends.xml (original)
+++ incubator/harmony/enhanced/classlib/trunk/make/depends.xml Wed Oct  4 03:
24:29 2006
@@ -72,17 +72,22 @@
 
 /target
 
-target name=-check-win if=is.windows

+target name=-check-win if=is.windows
+depends=-really-check-win,-awt-tar-extract /
+
+target name=-really-check-win if=is.windows
 
 	check-one-file src=${msvcr71.url} dest=${msvcr71.dll} /
 
-/target

+check-one-file src=${awtdeps.url} dest=${awtdeps.tar} /
+
+   uptodate property=awtdeps.uptodate
+  srcfile=${awtdeps.tar}
+  targetfile=${awtdeps.testfile} /
 
-target name=-check-unix if=with.awt.swing

-antcall target=--check-unix /
 /target
 
-target name=--check-unix if=is.unix

+target name=-check-unix if=is.unix
 
 property name=lcms.msg

   value=liblcms development package not installed
@@ -214,6 +219,10 @@
download-one-file src=${msvcr71.url} dest=${msvcr71.dll}
md5=${msvcr71.md5} /
 
+	mkdir dir=${awtdeps.dir} /

+   download-one-file src=${awtdeps.url} dest=${awtdeps.tar}
+   md5=${awtdeps.md5} /
+
 /target
 
 macrodef name=download-one-file

@@ -298,6 +307,14 @@
jar destfile=${bcprov.jar} basedir=${bcprov.dir}/temp
  manifest=${bcprov.dir}/temp/META-INF/MANIFEST.MF /
delete dir=${bcprov.dir}/temp /
+/target
+
+target name=-awt-tar-extract unless=awtdeps.uptodate
+echoExtracting awt dependencies/echo
+   untar src=${awtdeps.tar} dest=${awtdeps.extract.dir}
+   compression=gzip /
+echo file=${awtdeps.testfile}
+  message=${awtdeps.tar} extracted${line.separator} /
 /target
 
 macrodef name=check-one-link

[classlib] enabling AWT/Swing by default (was: Re: svn commit: r452826 - in /incubator/harmony/enhanced/classlib/trunk: depends/libs/build/ depends/libs/windows.x86/ make/depends.properties make/depen

[Tim Ellison]

Excuse the change in subject line...

Mark Hindess wrote:
 With this change, the awt dependencies should now be automated for
 windows and at least fairly trivial (installing a few packages on
 Linux[0]).  I think it is time we removed the with.awt.swing flag.
 Anyone object?

To the contrary, ditch it.

 Please test the current setup with -Dwith.awt.swing=true and report any
 problems.

Problem 1:  My machine is too slow running all these tests.

Regards,
Tim

 [0] Details of the required packages for distributions other than
 Debian/Ubuntu would be welcome.
 
 On 4 October 2006 at 10:24, [EMAIL PROTECTED] wrote:
 Author: hindessm
 Date: Wed Oct  4 03:24:29 2006
 New Revision: 452826

 URL: http://svn.apache.org/viewvc?view=revrev=452826
 Log:
 Update check/fetch depends targets to handle the awt dependencies.

 Modified:
 incubator/harmony/enhanced/classlib/trunk/depends/libs/build/   (props ch
 anged)
 incubator/harmony/enhanced/classlib/trunk/depends/libs/windows.x86/   (pr
 ops changed)
 incubator/harmony/enhanced/classlib/trunk/make/depends.properties
 incubator/harmony/enhanced/classlib/trunk/make/depends.xml

 Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/build/
 -
 -
 --- svn:ignore (original)
 +++ svn:ignore Wed Oct  4 03:24:29 2006
 @@ -1,3 +1,4 @@
  jpeg
  lcms
  png
 +winxp_2006-09-28.txt

 Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/windows.x8
 6/
 -
 -
 --- svn:ignore (original)
 +++ svn:ignore Wed Oct  4 03:24:29 2006
 @@ -1 +1,2 @@
  msvcr71.dll
 +swing_awt_deps_winxp_2006-09-28.tgz

 Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.properties
 URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/m
 ake/depends.properties?view=diffrev=452826r1=452825r2=452826
 =
 =
 --- incubator/harmony/enhanced/classlib/trunk/make/depends.properties (origin
 al)
 +++ incubator/harmony/enhanced/classlib/trunk/make/depends.properties Wed Oct
   4 03:24:29 2006
 @@ -98,3 +98,11 @@
  servlet-api.jar=${jetty.dir}/servlet-api-2.5-6.0.0.jar
  servlet-api.md5=c27c02fb0a00cc3a7d05ea993a9bf56e
  servlet-api.url=${ibiblio.base}/maven2/jetty/servlet-api/2.5-6.0.0/servlet-a
 pi-2.5-6.0.0.jar
 +
 +people.apache.base=http://people.apache.org/~geirm/harmony/
 +awtdeps.dir=${depends.dir}/libs/windows.x86
 +awtdeps.tar=${awtdeps.dir}/swing_awt_deps_winxp_2006-09-28.tgz
 +awtdeps.url=${people.apache.base}swing_awt_deps_winxp_2006-09-28.tgz
 +awtdeps.md5=d61a27e4b305d9fcabaaacf34f8f534a
 +awtdeps.extract.dir=${depends.dir}/libs/build
 +awtdeps.testfile=${awtdeps.extract.dir}/winxp_2006-09-28.txt

 Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.xml
 URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/m
 ake/depends.xml?view=diffrev=452826r1=452825r2=452826
 =
 =
 --- incubator/harmony/enhanced/classlib/trunk/make/depends.xml (original)
 +++ incubator/harmony/enhanced/classlib/trunk/make/depends.xml Wed Oct  4 03:
 24:29 2006
 @@ -72,17 +72,22 @@
  
  /target
  
 -target name=-check-win if=is.windows
 +target name=-check-win if=is.windows
 +depends=-really-check-win,-awt-tar-extract /
 +
 +target name=-really-check-win if=is.windows
  
  check-one-file src=${msvcr71.url} dest=${msvcr71.dll} /
  
 -/target
 +check-one-file src=${awtdeps.url} dest=${awtdeps.tar} /
 +
 +uptodate property=awtdeps.uptodate
 +  srcfile=${awtdeps.tar}
 +  targetfile=${awtdeps.testfile} /
  
 -target name=-check-unix if=with.awt.swing
 -antcall target=--check-unix /
  /target
  
 -target name=--check-unix if=is.unix
 +target name=-check-unix if=is.unix
  
  property name=lcms.msg
value=liblcms development package not installed
 @@ -214,6 +219,10 @@
  download-one-file src=${msvcr71.url} dest=${msvcr71.dll}
 md5=${msvcr71.md5} /
  
 +mkdir dir=${awtdeps.dir} /
 +download-one-file src=${awtdeps.url} dest=${awtdeps.tar}
 +   md5=${awtdeps.md5} /
 +
  /target
  
  macrodef name=download-one-file
 @@ -298,6 +307,14 @@
  jar destfile=${bcprov.jar} basedir=${bcprov.dir}/temp
   manifest=${bcprov.dir}/temp/META-INF/MANIFEST.MF /
  delete dir=${bcprov.dir}/temp /
 +/target
 +
 +target name=-awt-tar-extract unless=awtdeps.uptodate
 +echoExtracting awt dependencies/echo
 +untar src=${awtdeps.tar} dest=${awtdeps.extract.dir}
 +   compression=gzip /
 +echo file=${awtdeps.testfile}
 +  message=${awtdeps.tar} extracted${line.separator

Re: [classlib] enabling AWT/Swing by default (was: Re: svn commit: r452826 - in /incubator/harmony/enhanced/classlib/trunk: depends/libs/build/ depends/libs/windows.x86/ make/depends.properties make/d

[Mark Hindess]

On 4 October 2006 at 15:41, Tim Ellison [EMAIL PROTECTED] wrote:
 Excuse the change in subject line...

No problem.  I was just cursing myself for having forgotten to change
it.

 Mark Hindess wrote:
  With this change, the awt dependencies should now be automated for
  windows and at least fairly trivial (installing a few packages on
  Linux[0]).  I think it is time we removed the with.awt.swing flag.
  Anyone object?
 
 To the contrary, ditch it.
 
  Please test the current setup with -Dwith.awt.swing=true and report any
  problems.
 
 Problem 1:  My machine is too slow running all these tests.

Mine too.  And I have wondered if the hourly builds will finish within 
the hour now.  We really should see if we can avoid the need to fork 
for every test.

Regards,
 Mark.

 Regards,
 Tim
 
  [0] Details of the required packages for distributions other than
  Debian/Ubuntu would be welcome.
  
  On 4 October 2006 at 10:24, [EMAIL PROTECTED] wrote:
  Author: hindessm
  Date: Wed Oct  4 03:24:29 2006
  New Revision: 452826
 
  URL: http://svn.apache.org/viewvc?view=revrev=452826
  Log:
  Update check/fetch depends targets to handle the awt dependencies.
 
  Modified:
  incubator/harmony/enhanced/classlib/trunk/depends/libs/build/   (props
  ch
  anged)
  incubator/harmony/enhanced/classlib/trunk/depends/libs/windows.x86/   
 (pr
  ops changed)
  incubator/harmony/enhanced/classlib/trunk/make/depends.properties
  incubator/harmony/enhanced/classlib/trunk/make/depends.xml
 
  Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/build/
  --
 ---
  -
  --- svn:ignore (original)
  +++ svn:ignore Wed Oct  4 03:24:29 2006
  @@ -1,3 +1,4 @@
   jpeg
   lcms
   png
  +winxp_2006-09-28.txt
 
  Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/windows
 .x8
  6/
  --
 ---
  -
  --- svn:ignore (original)
  +++ svn:ignore Wed Oct  4 03:24:29 2006
  @@ -1 +1,2 @@
   msvcr71.dll
  +swing_awt_deps_winxp_2006-09-28.tgz
 
  Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.propertie
 s
  URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trun
 k/m
  ake/depends.properties?view=diffrev=452826r1=452825r2=452826
  ==
 ===
  =
  --- incubator/harmony/enhanced/classlib/trunk/make/depends.properties (ori
 gin
  al)
  +++ incubator/harmony/enhanced/classlib/trunk/make/depends.properties Wed 
 Oct
4 03:24:29 2006
  @@ -98,3 +98,11 @@
   servlet-api.jar=${jetty.dir}/servlet-api-2.5-6.0.0.jar
   servlet-api.md5=c27c02fb0a00cc3a7d05ea993a9bf56e
   servlet-api.url=${ibiblio.base}/maven2/jetty/servlet-api/2.5-6.0.0/servle
 t-a
  pi-2.5-6.0.0.jar
  +
  +people.apache.base=http://people.apache.org/~geirm/harmony/
  +awtdeps.dir=${depends.dir}/libs/windows.x86
  +awtdeps.tar=${awtdeps.dir}/swing_awt_deps_winxp_2006-09-28.tgz
  +awtdeps.url=${people.apache.base}swing_awt_deps_winxp_2006-09-28.tgz
  +awtdeps.md5=d61a27e4b305d9fcabaaacf34f8f534a
  +awtdeps.extract.dir=${depends.dir}/libs/build
  +awtdeps.testfile=${awtdeps.extract.dir}/winxp_2006-09-28.txt
 
  Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.xml
  URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trun
 k/m
  ake/depends.xml?view=diffrev=452826r1=452825r2=452826
  ==
 ===
  =
  --- incubator/harmony/enhanced/classlib/trunk/make/depends.xml (original)
  +++ incubator/harmony/enhanced/classlib/trunk/make/depends.xml Wed Oct  4 
 03:
  24:29 2006
  @@ -72,17 +72,22 @@
   
   /target
   
  -target name=-check-win if=is.windows
  +target name=-check-win if=is.windows
  +depends=-really-check-win,-awt-tar-extract /
  +
  +target name=-really-check-win if=is.windows
   
 check-one-file src=${msvcr71.url} dest=${msvcr71.dll} /
   
  -/target
  +check-one-file src=${awtdeps.url} dest=${awtdeps.tar} /
  +
  +  uptodate property=awtdeps.uptodate
  +  srcfile=${awtdeps.tar}
  +  targetfile=${awtdeps.testfile} /
   
  -target name=-check-unix if=with.awt.swing
  -antcall target=--check-unix /
   /target
   
  -target name=--check-unix if=is.unix
  +target name=-check-unix if=is.unix
   
   property name=lcms.msg
 value=liblcms development package not installed
  @@ -214,6 +219,10 @@
 download-one-file src=${msvcr71.url} dest=${msvcr71.dll}
  md5=${msvcr71.md5} /
   
  +  mkdir dir=${awtdeps.dir} /
  +  download-one-file src=${awtdeps.url} dest=${awtdeps.tar}
  +   md5=${awtdeps.md5} /
  +
   /target
   
   macrodef name=download-one-file
  @@ -298,6 +307,14 @@
 jar destfile

Re: svn commit: r452826 - in /incubator/harmony/enhanced/classlib/trunk: depends/libs/build/ depends/libs/windows.x86/ make/depends.properties make/depends.xml

[Mark Hindess]

Since most (all?) distributions provide versions of these libraries (and
maintain them - regular security fixes for example) why would we want
to maintain them ourselves?  It's not a job I'd want.

Really the same is true for zlib and to an extent icu.  If someone
else is doing the work maintaining them, we should use what they are a
providing not make more work for ourselves.  We should also try to use
the dynamic libraries if possible.

With the exception of icu, most of these libraries change very little
over time so there should be few if any interoperability issues.

I can only really see a good argument for maintaining icu binaries since
it is changing more frequently and many distributions seem to have
rather old versions.

Regards,
 Mark.

On 4 October 2006 at 10:40, Geir Magnusson Jr. [EMAIL PROTECTED] wrote:
 Any reason why we couldn't do the same thing for linux that we're doing 
 for windows in terms of having these libraries pre-compiled and easy to 
 drop in?
 
 geir
 
 Mark Hindess wrote:
  With this change, the awt dependencies should now be automated for
  windows and at least fairly trivial (installing a few packages on
  Linux[0]).  I think it is time we removed the with.awt.swing flag.
  Anyone object?
  
  Please test the current setup with -Dwith.awt.swing=true and report any
  problems.
  
  Regards,
   Mark.
  
  [0] Details of the required packages for distributions other than
  Debian/Ubuntu would be welcome.
  
  On 4 October 2006 at 10:24, [EMAIL PROTECTED] wrote:
  Author: hindessm
  Date: Wed Oct  4 03:24:29 2006
  New Revision: 452826
 
  URL: http://svn.apache.org/viewvc?view=revrev=452826
  Log:
  Update check/fetch depends targets to handle the awt dependencies.
 
  Modified:
  incubator/harmony/enhanced/classlib/trunk/depends/libs/build/   (props
  ch
  anged)
  incubator/harmony/enhanced/classlib/trunk/depends/libs/windows.x86/   
 (pr
  ops changed)
  incubator/harmony/enhanced/classlib/trunk/make/depends.properties
  incubator/harmony/enhanced/classlib/trunk/make/depends.xml
 
  Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/build/
  --
 ---
  -
  --- svn:ignore (original)
  +++ svn:ignore Wed Oct  4 03:24:29 2006
  @@ -1,3 +1,4 @@
   jpeg
   lcms
   png
  +winxp_2006-09-28.txt
 
  Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/windows
 .x8
  6/
  --
 ---
  -
  --- svn:ignore (original)
  +++ svn:ignore Wed Oct  4 03:24:29 2006
  @@ -1 +1,2 @@
   msvcr71.dll
  +swing_awt_deps_winxp_2006-09-28.tgz
 
  Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.propertie
 s
  URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trun
 k/m
  ake/depends.properties?view=diffrev=452826r1=452825r2=452826
  ==
 ===
  =
  --- incubator/harmony/enhanced/classlib/trunk/make/depends.properties (ori
 gin
  al)
  +++ incubator/harmony/enhanced/classlib/trunk/make/depends.properties Wed 
 Oct
4 03:24:29 2006
  @@ -98,3 +98,11 @@
   servlet-api.jar=${jetty.dir}/servlet-api-2.5-6.0.0.jar
   servlet-api.md5=c27c02fb0a00cc3a7d05ea993a9bf56e
   servlet-api.url=${ibiblio.base}/maven2/jetty/servlet-api/2.5-6.0.0/servle
 t-a
  pi-2.5-6.0.0.jar
  +
  +people.apache.base=http://people.apache.org/~geirm/harmony/
  +awtdeps.dir=${depends.dir}/libs/windows.x86
  +awtdeps.tar=${awtdeps.dir}/swing_awt_deps_winxp_2006-09-28.tgz
  +awtdeps.url=${people.apache.base}swing_awt_deps_winxp_2006-09-28.tgz
  +awtdeps.md5=d61a27e4b305d9fcabaaacf34f8f534a
  +awtdeps.extract.dir=${depends.dir}/libs/build
  +awtdeps.testfile=${awtdeps.extract.dir}/winxp_2006-09-28.txt
 
  Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.xml
  URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trun
 k/m
  ake/depends.xml?view=diffrev=452826r1=452825r2=452826
  ==
 ===
  =
  --- incubator/harmony/enhanced/classlib/trunk/make/depends.xml (original)
  +++ incubator/harmony/enhanced/classlib/trunk/make/depends.xml Wed Oct  4 
 03:
  24:29 2006
  @@ -72,17 +72,22 @@
   
   /target
   
  -target name=-check-win if=is.windows
  +target name=-check-win if=is.windows
  +depends=-really-check-win,-awt-tar-extract /
  +
  +target name=-really-check-win if=is.windows
   
 check-one-file src=${msvcr71.url} dest=${msvcr71.dll} /
   
  -/target
  +check-one-file src=${awtdeps.url} dest=${awtdeps.tar} /
  +
  +  uptodate property=awtdeps.uptodate
  +  srcfile=${awtdeps.tar}
  +  targetfile=${awtdeps.testfile} /
   
  -target name=-check-unix if=with.awt.swing
  -antcall target=--check-unix /
   /target
   
  -target name=--check-unix

Re: [classlib] enabling AWT/Swing by default (was: Re: svn commit: r452826 - in /incubator/harmony/enhanced/classlib/trunk: depends/libs/build/ depends/libs/windows.x86/ make/depends.properties make/d

[Mikhail Loenko]

2006/10/4, Mark Hindess [EMAIL PROTECTED]:


On 4 October 2006 at 15:41, Tim Ellison [EMAIL PROTECTED] wrote:
 Excuse the change in subject line...

No problem.  I was just cursing myself for having forgotten to change
it.

 Mark Hindess wrote:
  With this change, the awt dependencies should now be automated for
  windows and at least fairly trivial (installing a few packages on
  Linux[0]).  I think it is time we removed the with.awt.swing flag.
  Anyone object?

 To the contrary, ditch it.

  Please test the current setup with -Dwith.awt.swing=true and report any
  problems.

 Problem 1:  My machine is too slow running all these tests.

Mine too.  And I have wondered if the hourly builds will finish within
the hour now.  We really should see if we can avoid the need to fork
for every test.


I've run the tests on my XP machine, 1 failed

javax.swing.TransferHandlerTest#testCreateTransferable

java.lang.NullPointerException at
javax.swing.TransferHandlerTest.testCreateTransferable(TransferHandlerTest.java:140)
at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:25)
at javax.swing.BasicSwingTestCase.runBareSuper(BasicSwingTestCase.java:115)
at javax.swing.SwingTestCase$1.run(SwingTestCase.java:44) at
java.awt.event.InvocationEvent.runAndNotify(InvocationEvent.java:88)
at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:77) at
java.awt.EventQueueCore.dispatchEventImpl(EventQueueCore.java:131) at
java.awt.EventQueue.dispatchEvent(EventQueue.java:144) at
java.awt.EventDispatchThread.runModalLoop(EventDispatchThread.java:75)
at java.awt.EventDispatchThread.run(EventDispatchThread.java:48)

Thanks,
Mikhail




Regards,
 Mark.

 Regards,
 Tim

  [0] Details of the required packages for distributions other than
  Debian/Ubuntu would be welcome.
 
  On 4 October 2006 at 10:24, [EMAIL PROTECTED] wrote:
  Author: hindessm
  Date: Wed Oct  4 03:24:29 2006
  New Revision: 452826
 
  URL: http://svn.apache.org/viewvc?view=revrev=452826
  Log:
  Update check/fetch depends targets to handle the awt dependencies.
 
  Modified:
  incubator/harmony/enhanced/classlib/trunk/depends/libs/build/   (props
  ch
  anged)
  incubator/harmony/enhanced/classlib/trunk/depends/libs/windows.x86/
 (pr
  ops changed)
  incubator/harmony/enhanced/classlib/trunk/make/depends.properties
  incubator/harmony/enhanced/classlib/trunk/make/depends.xml
 
  Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/build/
  --
 ---
  -
  --- svn:ignore (original)
  +++ svn:ignore Wed Oct  4 03:24:29 2006
  @@ -1,3 +1,4 @@
   jpeg
   lcms
   png
  +winxp_2006-09-28.txt
 
  Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/windows
 .x8
  6/
  --
 ---
  -
  --- svn:ignore (original)
  +++ svn:ignore Wed Oct  4 03:24:29 2006
  @@ -1 +1,2 @@
   msvcr71.dll
  +swing_awt_deps_winxp_2006-09-28.tgz
 
  Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.propertie
 s
  URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trun
 k/m
  ake/depends.properties?view=diffrev=452826r1=452825r2=452826
  ==
 ===
  =
  --- incubator/harmony/enhanced/classlib/trunk/make/depends.properties (ori
 gin
  al)
  +++ incubator/harmony/enhanced/classlib/trunk/make/depends.properties Wed
 Oct
4 03:24:29 2006
  @@ -98,3 +98,11 @@
   servlet-api.jar=${jetty.dir}/servlet-api-2.5-6.0.0.jar
   servlet-api.md5=c27c02fb0a00cc3a7d05ea993a9bf56e
   servlet-api.url=${ibiblio.base}/maven2/jetty/servlet-api/2.5-6.0.0/servle
 t-a
  pi-2.5-6.0.0.jar
  +
  +people.apache.base=http://people.apache.org/~geirm/harmony/
  +awtdeps.dir=${depends.dir}/libs/windows.x86
  +awtdeps.tar=${awtdeps.dir}/swing_awt_deps_winxp_2006-09-28.tgz
  +awtdeps.url=${people.apache.base}swing_awt_deps_winxp_2006-09-28.tgz
  +awtdeps.md5=d61a27e4b305d9fcabaaacf34f8f534a
  +awtdeps.extract.dir=${depends.dir}/libs/build
  +awtdeps.testfile=${awtdeps.extract.dir}/winxp_2006-09-28.txt
 
  Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.xml
  URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trun
 k/m
  ake/depends.xml?view=diffrev=452826r1=452825r2=452826
  ==
 ===
  =
  --- incubator/harmony/enhanced/classlib/trunk/make/depends.xml (original)
  +++ incubator/harmony/enhanced/classlib/trunk/make/depends.xml Wed Oct  4
 03:
  24:29 2006
  @@ -72,17 +72,22 @@
 
   /target
 
  -target name=-check-win if=is.windows
  +target name=-check-win if=is.windows
  +depends=-really-check-win,-awt-tar-extract /
  +
  +target name=-really-check-win if=is.windows
 
 check-one-file src=${msvcr71.url} dest=${msvcr71.dll} /
 
  -/target
  +check-one-file src=${awtdeps.url

Re: svn commit: r452826 - in /incubator/harmony/enhanced/classlib/trunk: depends/libs/build/ depends/libs/windows.x86/ make/depends.properties make/depends.xml

[Geir Magnusson Jr.]

Mark Hindess wrote:

Since most (all?) distributions provide versions of these libraries (and
maintain them - regular security fixes for example) why would we want
to maintain them ourselves?  It's not a job I'd want.


I'm not advocating maintenance, but simply defining the set that we 
build and test with.


I'm not a fan of having certified builds be dependent on whatever random 
stuff the user downloads to /usr/lib




Really the same is true for zlib and to an extent icu.  If someone
else is doing the work maintaining them, we should use what they are a
providing not make more work for ourselves.  We should also try to use
the dynamic libraries if possible.


Yes, on the first sentence, not so sure on the last, simply because 
there's value in testing a fixed set of versions of stuff.




With the exception of icu, most of these libraries change very little
over time so there should be few if any interoperability issues.

I can only really see a good argument for maintaining icu binaries since
it is changing more frequently and many distributions seem to have
rather old versions.

Regards,
 Mark.

On 4 October 2006 at 10:40, Geir Magnusson Jr. [EMAIL PROTECTED] wrote:
Any reason why we couldn't do the same thing for linux that we're doing 
for windows in terms of having these libraries pre-compiled and easy to 
drop in?


geir

Mark Hindess wrote:

With this change, the awt dependencies should now be automated for
windows and at least fairly trivial (installing a few packages on
Linux[0]).  I think it is time we removed the with.awt.swing flag.
Anyone object?

Please test the current setup with -Dwith.awt.swing=true and report any
problems.

Regards,
 Mark.

[0] Details of the required packages for distributions other than
Debian/Ubuntu would be welcome.

On 4 October 2006 at 10:24, [EMAIL PROTECTED] wrote:

Author: hindessm
Date: Wed Oct  4 03:24:29 2006
New Revision: 452826

URL: http://svn.apache.org/viewvc?view=revrev=452826
Log:
Update check/fetch depends targets to handle the awt dependencies.

Modified:
incubator/harmony/enhanced/classlib/trunk/depends/libs/build/   (props

 ch

anged)
incubator/harmony/enhanced/classlib/trunk/depends/libs/windows.x86/   

(pr

ops changed)
incubator/harmony/enhanced/classlib/trunk/make/depends.properties
incubator/harmony/enhanced/classlib/trunk/make/depends.xml

Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/build/
--

---

-
--- svn:ignore (original)
+++ svn:ignore Wed Oct  4 03:24:29 2006
@@ -1,3 +1,4 @@
 jpeg
 lcms
 png
+winxp_2006-09-28.txt

Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/windows

.x8

6/
--

---

-
--- svn:ignore (original)
+++ svn:ignore Wed Oct  4 03:24:29 2006
@@ -1 +1,2 @@
 msvcr71.dll
+swing_awt_deps_winxp_2006-09-28.tgz

Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.propertie

s

URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trun

k/m

ake/depends.properties?view=diffrev=452826r1=452825r2=452826
==

===

=
--- incubator/harmony/enhanced/classlib/trunk/make/depends.properties (ori

gin

al)
+++ incubator/harmony/enhanced/classlib/trunk/make/depends.properties Wed 

Oct

  4 03:24:29 2006
@@ -98,3 +98,11 @@
 servlet-api.jar=${jetty.dir}/servlet-api-2.5-6.0.0.jar
 servlet-api.md5=c27c02fb0a00cc3a7d05ea993a9bf56e
 servlet-api.url=${ibiblio.base}/maven2/jetty/servlet-api/2.5-6.0.0/servle

t-a

pi-2.5-6.0.0.jar
+
+people.apache.base=http://people.apache.org/~geirm/harmony/
+awtdeps.dir=${depends.dir}/libs/windows.x86
+awtdeps.tar=${awtdeps.dir}/swing_awt_deps_winxp_2006-09-28.tgz
+awtdeps.url=${people.apache.base}swing_awt_deps_winxp_2006-09-28.tgz
+awtdeps.md5=d61a27e4b305d9fcabaaacf34f8f534a
+awtdeps.extract.dir=${depends.dir}/libs/build
+awtdeps.testfile=${awtdeps.extract.dir}/winxp_2006-09-28.txt

Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.xml
URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trun

k/m

ake/depends.xml?view=diffrev=452826r1=452825r2=452826
==

===

=
--- incubator/harmony/enhanced/classlib/trunk/make/depends.xml (original)
+++ incubator/harmony/enhanced/classlib/trunk/make/depends.xml Wed Oct  4 

03:

24:29 2006
@@ -72,17 +72,22 @@
 
 /target
 
-target name=-check-win if=is.windows

+target name=-check-win if=is.windows
+depends=-really-check-win,-awt-tar-extract /
+
+target name=-really-check-win if=is.windows
 
 	check-one-file src=${msvcr71.url} dest=${msvcr71.dll} /
 
-/target

+check-one-file src=${awtdeps.url} dest=${awtdeps.tar} /
+
+   uptodate property=awtdeps.uptodate
+  srcfile=${awtdeps.tar

Re: [classlib] enabling AWT/Swing by default (was: Re: svn commit: r452826 - in /incubator/harmony/enhanced/classlib/trunk: depends/libs/build/ depends/libs/windows.x86/ make/depends.properties make/d

[Oleg Khaschansky]

I found the reason of this failure. It is an IntrospectionException
while executing a following method from the TransferHandler class:

   private PropertyDescriptor getPropertyDescriptor(final JComponent c) {
   PropertyDescriptor result = null;
   try {
   result = new PropertyDescriptor(propertyName, c.getClass());
   } catch (IntrospectionException e) {

   }
   return result;
   }
It tries to get the PropertyDescriptor for the class JButton and
property name insets, but fails because there's no setInsets method.
So, flavors array stays uninitialized and getTransferDataFlavors
method returns null which is a cause of a NPE.

The quick fix for this issue could be changing this method to the following:

   private PropertyDescriptor getPropertyDescriptor(final JComponent c) {
   PropertyDescriptor result = null;
   try {
   return result = new PropertyDescriptor(propertyName, c.getClass());
   } catch (IntrospectionException e) {
   }
   try {
   return result = new PropertyDescriptor(propertyName,
c.getClass(), 1, null);
   } catch (IntrospectionException e) {
   }
   return result;
   }

+ we need to fix in beans the fact that the following code:

new PropertyDescriptor(propertyName, c.getClass(), 1, null);

will throw IntrospectionException on Harmony, but will return the
valid property descriptor with the getter method on RI.

Any thoughts on this? Or should I proceed with a patch for the both issues?

Thanks,
 Oleg

On 10/4/06, Mikhail Loenko [EMAIL PROTECTED] wrote:

2006/10/4, Mark Hindess [EMAIL PROTECTED]:

 On 4 October 2006 at 15:41, Tim Ellison [EMAIL PROTECTED] wrote:
  Excuse the change in subject line...

 No problem.  I was just cursing myself for having forgotten to change
 it.

  Mark Hindess wrote:
   With this change, the awt dependencies should now be automated for
   windows and at least fairly trivial (installing a few packages on
   Linux[0]).  I think it is time we removed the with.awt.swing flag.
   Anyone object?
 
  To the contrary, ditch it.
 
   Please test the current setup with -Dwith.awt.swing=true and report any
   problems.
 
  Problem 1:  My machine is too slow running all these tests.

 Mine too.  And I have wondered if the hourly builds will finish within
 the hour now.  We really should see if we can avoid the need to fork
 for every test.

I've run the tests on my XP machine, 1 failed

javax.swing.TransferHandlerTest#testCreateTransferable

java.lang.NullPointerException at
javax.swing.TransferHandlerTest.testCreateTransferable(TransferHandlerTest.java:140)
at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:25)
at javax.swing.BasicSwingTestCase.runBareSuper(BasicSwingTestCase.java:115)
at javax.swing.SwingTestCase$1.run(SwingTestCase.java:44) at
java.awt.event.InvocationEvent.runAndNotify(InvocationEvent.java:88)
at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:77) at
java.awt.EventQueueCore.dispatchEventImpl(EventQueueCore.java:131) at
java.awt.EventQueue.dispatchEvent(EventQueue.java:144) at
java.awt.EventDispatchThread.runModalLoop(EventDispatchThread.java:75)
at java.awt.EventDispatchThread.run(EventDispatchThread.java:48)

Thanks,
Mikhail



 Regards,
  Mark.

  Regards,
  Tim
 
   [0] Details of the required packages for distributions other than
   Debian/Ubuntu would be welcome.
  
   On 4 October 2006 at 10:24, [EMAIL PROTECTED] wrote:
   Author: hindessm
   Date: Wed Oct  4 03:24:29 2006
   New Revision: 452826
  
   URL: http://svn.apache.org/viewvc?view=revrev=452826
   Log:
   Update check/fetch depends targets to handle the awt dependencies.
  
   Modified:
   incubator/harmony/enhanced/classlib/trunk/depends/libs/build/   
(props
   ch
   anged)
   incubator/harmony/enhanced/classlib/trunk/depends/libs/windows.x86/
  (pr
   ops changed)
   incubator/harmony/enhanced/classlib/trunk/make/depends.properties
   incubator/harmony/enhanced/classlib/trunk/make/depends.xml
  
   Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/build/
   
--
  ---
   -
   --- svn:ignore (original)
   +++ svn:ignore Wed Oct  4 03:24:29 2006
   @@ -1,3 +1,4 @@
jpeg
lcms
png
   +winxp_2006-09-28.txt
  
   Propchange: 
incubator/harmony/enhanced/classlib/trunk/depends/libs/windows
  .x8
   6/
   
--
  ---
   -
   --- svn:ignore (original)
   +++ svn:ignore Wed Oct  4 03:24:29 2006
   @@ -1 +1,2 @@
msvcr71.dll
   +swing_awt_deps_winxp_2006-09-28.tgz
  
   Modified: 
incubator/harmony/enhanced/classlib/trunk/make/depends.propertie
  s
   URL: 
http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trun
  k/m
   ake/depends.properties?view=diffrev=452826r1=452825r2=452826
   
==
  ===
   =
   --- incubator

Re: [classlib] enabling AWT/Swing by default (was: Re: svn commit: r452826 - in /incubator/harmony/enhanced/classlib/trunk: depends/libs/build/ depends/libs/windows.x86/ make/depends.properties make/d

[Mikhail Loenko]

2006/10/5, Oleg Khaschansky [EMAIL PROTECTED]:

I found the reason of this failure. It is an IntrospectionException
while executing a following method from the TransferHandler class:

   private PropertyDescriptor getPropertyDescriptor(final JComponent c) {
   PropertyDescriptor result = null;
   try {
   result = new PropertyDescriptor(propertyName, c.getClass());
   } catch (IntrospectionException e) {

   }
   return result;
   }
It tries to get the PropertyDescriptor for the class JButton and
property name insets, but fails because there's no setInsets method.
So, flavors array stays uninitialized and getTransferDataFlavors
method returns null which is a cause of a NPE.

The quick fix for this issue could be changing this method to the following:

   private PropertyDescriptor getPropertyDescriptor(final JComponent c) {
   PropertyDescriptor result = null;
   try {
   return result = new PropertyDescriptor(propertyName, c.getClass());
   } catch (IntrospectionException e) {
   }
   try {
   return result = new PropertyDescriptor(propertyName,
c.getClass(), 1, null);
   } catch (IntrospectionException e) {
   }
   return result;
   }

+ we need to fix in beans the fact that the following code:

new PropertyDescriptor(propertyName, c.getClass(), 1, null);

will throw IntrospectionException on Harmony, but will return the
valid property descriptor with the getter method on RI.

Any thoughts on this? Or should I proceed with a patch for the both issues?


Yes, please. When you submit a patch people will have a chance
to review and comment

Thanks,
Mikhail




Thanks,
 Oleg

On 10/4/06, Mikhail Loenko [EMAIL PROTECTED] wrote:
 2006/10/4, Mark Hindess [EMAIL PROTECTED]:
 
  On 4 October 2006 at 15:41, Tim Ellison [EMAIL PROTECTED] wrote:
   Excuse the change in subject line...
 
  No problem.  I was just cursing myself for having forgotten to change
  it.
 
   Mark Hindess wrote:
With this change, the awt dependencies should now be automated for
windows and at least fairly trivial (installing a few packages on
Linux[0]).  I think it is time we removed the with.awt.swing flag.
Anyone object?
  
   To the contrary, ditch it.
  
Please test the current setup with -Dwith.awt.swing=true and report any
problems.
  
   Problem 1:  My machine is too slow running all these tests.
 
  Mine too.  And I have wondered if the hourly builds will finish within
  the hour now.  We really should see if we can avoid the need to fork
  for every test.

 I've run the tests on my XP machine, 1 failed

 javax.swing.TransferHandlerTest#testCreateTransferable

 java.lang.NullPointerException at
 
javax.swing.TransferHandlerTest.testCreateTransferable(TransferHandlerTest.java:140)
 at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:25)
 at javax.swing.BasicSwingTestCase.runBareSuper(BasicSwingTestCase.java:115)
 at javax.swing.SwingTestCase$1.run(SwingTestCase.java:44) at
 java.awt.event.InvocationEvent.runAndNotify(InvocationEvent.java:88)
 at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:77) at
 java.awt.EventQueueCore.dispatchEventImpl(EventQueueCore.java:131) at
 java.awt.EventQueue.dispatchEvent(EventQueue.java:144) at
 java.awt.EventDispatchThread.runModalLoop(EventDispatchThread.java:75)
 at java.awt.EventDispatchThread.run(EventDispatchThread.java:48)

 Thanks,
 Mikhail


 
  Regards,
   Mark.
 
   Regards,
   Tim
  
[0] Details of the required packages for distributions other than
Debian/Ubuntu would be welcome.
   
On 4 October 2006 at 10:24, [EMAIL PROTECTED] wrote:
Author: hindessm
Date: Wed Oct  4 03:24:29 2006
New Revision: 452826
   
URL: http://svn.apache.org/viewvc?view=revrev=452826
Log:
Update check/fetch depends targets to handle the awt dependencies.
   
Modified:
incubator/harmony/enhanced/classlib/trunk/depends/libs/build/   
(props
ch
anged)
incubator/harmony/enhanced/classlib/trunk/depends/libs/windows.x86/
   (pr
ops changed)
incubator/harmony/enhanced/classlib/trunk/make/depends.properties
incubator/harmony/enhanced/classlib/trunk/make/depends.xml
   
Propchange: 
incubator/harmony/enhanced/classlib/trunk/depends/libs/build/

--
   ---
-
--- svn:ignore (original)
+++ svn:ignore Wed Oct  4 03:24:29 2006
@@ -1,3 +1,4 @@
 jpeg
 lcms
 png
+winxp_2006-09-28.txt
   
Propchange: 
incubator/harmony/enhanced/classlib/trunk/depends/libs/windows
   .x8
6/

--
   ---
-
--- svn:ignore (original)
+++ svn:ignore Wed Oct  4 03:24:29 2006
@@ -1 +1,2 @@
 msvcr71.dll
+swing_awt_deps_winxp_2006-09-28.tgz
   
Modified: 
incubator/harmony/enhanced/classlib/trunk/make/depends.propertie
   s

Re: svn commit: r425315 - in /incubator/harmony/enhanced/classlib/trunk: depends/files/ modules/security/ modules/security/make/ modules/security/src/main/java/common/java/security/ modules/security/s

[Igor Stolyarov]

Mikhail, after your commit, I can't build Harmony:


   [javac]
C:\new_harmony\Harmony\enhanced\classlib\trunk\modules\security\src\
main\java\common\org\apache\harmony\security\provider\crypto\SHA1PRNG_SecureRand
omImpl.java:28: cannot find symbol
   [javac] symbol  : class RandomBitsSupplier
   [javac] location: package org.apache.harmony.security.provider.crypto
   [javac] import
org.apache.harmony.security.provider.crypto.RandomBitsSupplie
r;
   [javac]^
   [javac]
C:\new_harmony\Harmony\enhanced\classlib\trunk\modules\security\src\
main\java\common\org\apache\harmony\security\provider\crypto\SHA1PRNG_SecureRand
omImpl.java:253: cannot find symbol
   [javac] symbol  : variable RandomBitsSupplier
   [javac] location: class
org.apache.harmony.security.provider.crypto.SHA1PRNG
_SecureRandomImpl
   [javac] myRandom.engineSetSeed(
RandomBitsSupplier.getRandomBits(
DIGEST_LENGTH));
   [javac]^
   [javac]
C:\new_harmony\Harmony\enhanced\classlib\trunk\modules\security\src\
main\java\common\org\apache\harmony\security\provider\crypto\SHA1PRNG_SecureRand
omImpl.java:297: cannot find symbol
   [javac] symbol  : variable RandomBitsSupplier
   [javac] location: class
org.apache.harmony.security.provider.crypto.SHA1PRNG
_SecureRandomImpl
   [javac] updateSeed(RandomBitsSupplier.getRandomBits
(DIGEST_LENGT
H));
   [javac]^
   [javac] Note: * uses or overrides a deprecated API.
   [javac] Note: Recompile with -Xlint:deprecation for details.
   [javac] Note: Some input files use unchecked or unsafe operations.
   [javac] Note: Recompile with -Xlint:unchecked for details.
   [javac] 3 errors

BUILD FAILED

Re: svn commit: r425315 - in /incubator/harmony/enhanced/classlib/trunk: depends/files/ modules/security/ modules/security/make/ modules/security/src/main/java/common/java/security/ modules/security/s

[Mikhail Loenko]

try ant rebuild

2006/7/25, Igor Stolyarov [EMAIL PROTECTED]:

Mikhail, after your commit, I can't build Harmony:


   [javac]
C:\new_harmony\Harmony\enhanced\classlib\trunk\modules\security\src\
main\java\common\org\apache\harmony\security\provider\crypto\SHA1PRNG_SecureRand
omImpl.java:28: cannot find symbol
   [javac] symbol  : class RandomBitsSupplier
   [javac] location: package org.apache.harmony.security.provider.crypto
   [javac] import
org.apache.harmony.security.provider.crypto.RandomBitsSupplie
r;
   [javac]^
   [javac]
C:\new_harmony\Harmony\enhanced\classlib\trunk\modules\security\src\
main\java\common\org\apache\harmony\security\provider\crypto\SHA1PRNG_SecureRand
omImpl.java:253: cannot find symbol
   [javac] symbol  : variable RandomBitsSupplier
   [javac] location: class
org.apache.harmony.security.provider.crypto.SHA1PRNG
_SecureRandomImpl
   [javac] myRandom.engineSetSeed(
RandomBitsSupplier.getRandomBits(
DIGEST_LENGTH));
   [javac]^
   [javac]
C:\new_harmony\Harmony\enhanced\classlib\trunk\modules\security\src\
main\java\common\org\apache\harmony\security\provider\crypto\SHA1PRNG_SecureRand
omImpl.java:297: cannot find symbol
   [javac] symbol  : variable RandomBitsSupplier
   [javac] location: class
org.apache.harmony.security.provider.crypto.SHA1PRNG
_SecureRandomImpl
   [javac] updateSeed(RandomBitsSupplier.getRandomBits
(DIGEST_LENGT
H));
   [javac]^
   [javac] Note: * uses or overrides a deprecated API.
   [javac] Note: Recompile with -Xlint:deprecation for details.
   [javac] Note: Some input files use unchecked or unsafe operations.
   [javac] Note: Recompile with -Xlint:unchecked for details.
   [javac] 3 errors

BUILD FAILED




-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r425315 - in /incubator/harmony/enhanced/classlib/trunk: depends/files/ modules/security/ modules/security/make/ modules/security/src/main/java/common/java/security/ modules/security/s

[Stepan Mishura]

I see the same error messages in Eclipse - can be fixed by adding
'src/main/java/windows' as classpathentry. So in case of Linux
'src/main/java/linux' has to be added.

I think that it is a little bit inconvenient because '.classpath' file can
not contain both entries (both contains a class with the same name -
RandomBitsSupplier). So everybody who works with 'security' module under
Eclipse has to remember about it and add mannually corresponding entry (at
least at once).

Thanks,
Stepan.

On 7/25/06, Mikhail Loenko wrote:


try ant rebuild

2006/7/25, Igor Stolyarov:
 Mikhail, after your commit, I can't build Harmony:


[javac]
 C:\new_harmony\Harmony\enhanced\classlib\trunk\modules\security\src\

main\java\common\org\apache\harmony\security\provider\crypto\SHA1PRNG_SecureRand
 omImpl.java:28: cannot find symbol
[javac] symbol  : class RandomBitsSupplier
[javac] location: package org.apache.harmony.security.provider.crypto
[javac] import
 org.apache.harmony.security.provider.crypto.RandomBitsSupplie
 r;
[javac]^
[javac]
 C:\new_harmony\Harmony\enhanced\classlib\trunk\modules\security\src\

main\java\common\org\apache\harmony\security\provider\crypto\SHA1PRNG_SecureRand
 omImpl.java:253: cannot find symbol
[javac] symbol  : variable RandomBitsSupplier
[javac] location: class
 org.apache.harmony.security.provider.crypto.SHA1PRNG
 _SecureRandomImpl
[javac] myRandom.engineSetSeed(
 RandomBitsSupplier.getRandomBits(
 DIGEST_LENGTH));
[javac]^
[javac]
 C:\new_harmony\Harmony\enhanced\classlib\trunk\modules\security\src\

main\java\common\org\apache\harmony\security\provider\crypto\SHA1PRNG_SecureRand
 omImpl.java:297: cannot find symbol
[javac] symbol  : variable RandomBitsSupplier
[javac] location: class
 org.apache.harmony.security.provider.crypto.SHA1PRNG
 _SecureRandomImpl
[javac] updateSeed(RandomBitsSupplier.getRandomBits
 (DIGEST_LENGT
 H));
[javac]^
[javac] Note: * uses or overrides a deprecated API.
[javac] Note: Recompile with -Xlint:deprecation for details.
[javac] Note: Some input files use unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.
[javac] 3 errors

 BUILD FAILED



--
Thanks,
Stepan Mishura
Intel Middleware Products Division

--
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r420823 - in /incubator/harmony/enhanced/classlib/trunk/depends/libs/build: ./ README.txt fetch-awt-depends.sh

[Alexey Petrenko]

I've finally finished building awt with the jpeg and png binaries from
the GnuWin32.
Everything seems fine.  Tests are loading and draw png and jpeg images
whithout any problem.

But we face 3 problems here:
1. lcms version in GnuWin32 is not compatible with Harmony.
2. png libary from GnuWin32 requires zlib1.dll which is known as
hyzlib.dll in Harmony.
3. Potential license problem mentioned by Geir.

2006/7/13, Geir Magnusson Jr [EMAIL PROTECTED]:



Alexey Petrenko wrote:
 2006/7/12, Mark Hindess [EMAIL PROTECTED]:

 On 12 July 2006 at 12:50, Alexey Petrenko
 [EMAIL PROTECTED] wrote:
 
  I've just returned from the vacation.  And I have planned to work
  on trying to run awt with GnuWin32 libraries today. But we have few
  predicatble issues with them.
 Excellent.  Thanks Alexey.
 But as I said we got few predictable problems here:
 1. Not all the libraries in GnuWin32 have needed versions.
 2. Libraries form GnuWin32 are looking for zlib1.dll which is renamed
 in Harmony class lib.
Let me ask the obvious question.  Does using GNUWin32 add any code from
GNUWin32 to our artifacts?

No we do not need any source code from GnuWin32 except of binaries.
I've used headers, lib and dll files.


If so, we can't use it because of the odd and somewhat confusing
restrictions in the license here :

http://gnuwin32.sourceforge.net/license.html

Thanks for pointing on this license.

I'm not really sure can we use binaries or not according this license.
It seems that we can if the GnuWin32 binaries will be downloaded by
the user...

But if we can't we still got 3 more options:
1. Build jpeg, png and lcms libraries, put them into Harmony (or
other) site and download it from build script.
2. Integrate jpeg, png and lcms sources into Harmony
3. Download jpeg, png and lcms source from their sites and build them
from Harmony build script.

SY, Alexey

--
Alexey A. Petrenko
Intel Middleware Products Division

-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r420823 - in /incubator/harmony/enhanced/classlib/trunk/depends/libs/build: ./ README.txt fetch-awt-depends.sh

[Alexey Petrenko]

Mark,

I've just returned from the vacation. And I have planned to work on
trying to run awt with GnuWin32 libraries today. But we have few
predicatble issues with them.

We also did not finish the talks about integrating the needed sources
into Harmony class library since the licenses seems to be Apache
authorized. As we did with zlib.

And we also have possibility to update Harmony build script to
download and build this libraries...

SY, Alexey

2006/7/11, Mark Hindess [EMAIL PROTECTED]:


I've checked in a script so that:

  svn co ... classlib
  cd classlib
  ant fetch-depends
  sh depends/libs/build/fetch-awt-depends.sh
  ant -Dwith.awt.swing=true rebuild

should work on Debian Linux.  Updates for other distributions would be
very welcome.

Any update on what to do on Windows?

I'm hoping to get the misc natives from the awt contribution integrated
today (or maybe tomorrow) then I'll start on the awt natives so it would
be good to resolve this issue.

Regards,
 Mark.

On 11 July 2006 at 12:43, [EMAIL PROTECTED] wrote:
 Author: hindessm
 Date: Tue Jul 11 05:43:09 2006
 New Revision: 420823

 URL: http://svn.apache.org/viewvc?rev=420823view=rev
 Log:
 Added README.txt for AWT dependencies - mostly taken from contribution README
 .
 Added helper script for Linux - Debian/Ubuntu only but could be updated for
 other common distros.


 Added:
 incubator/harmony/enhanced/classlib/trunk/depends/libs/build/   (with pro
 ps)
 incubator/harmony/enhanced/classlib/trunk/depends/libs/build/README.txt
  (with props)
 incubator/harmony/enhanced/classlib/trunk/depends/libs/build/fetch-awt-de
 pends.sh   (with props)

 Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/build/
 -
 -
 --- svn:ignore (added)
 +++ svn:ignore Tue Jul 11 05:43:09 2006
 @@ -0,0 +1,3 @@
 +jpeg
 +lcms
 +png

 Added: incubator/harmony/enhanced/classlib/trunk/depends/libs/build/README.tx
 t
 URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/d
 epends/libs/build/README.txt?rev=420823view=auto
 =
 =
 --- incubator/harmony/enhanced/classlib/trunk/depends/libs/build/README.txt (
 added)
 +++ incubator/harmony/enhanced/classlib/trunk/depends/libs/build/README.txt T
 ue Jul 11 05:43:09 2006
 @@ -0,0 +1,175 @@
 +Dependencies for AWT
 +
 +
 +For Debian/Ubuntu, it should be possible to run:
 +
 +  sh depends/libs/build/fetch-awt-depends.sh
 +
 +to construct the dependency tree.
 +
 +On other platforms the dependencies must be build using the following
 +instructions.
 +
 +
 +1. Building the external libraries
 +--
 +
 +To enable image decoding (JPEG and PNG images) and color management
 +with awt, build the IJG JPEG, Libpng and the Little CMS libraries.
 +
 +After performing the instructions below, you create the following
 +directory tree structure:
 +
 +EXTRACT_DIR/depends/libs/build
 +   |
 +   \---jpeg
 +   ||
 +   |+--- cderror.h
 +   |+--- jinclude.h
 +   |+--- jpeglib.h
 +   |+--- cdjpeg.h
 +   |+--- jdct.h
 +   |+--- jmemsys.h
 +   |+--- jversion.h
 +   |+--- jchuff.h
 +   |+--- jdhuff.h
 +   |+--- jmorecfg.h
 +   |+--- jerror.h
 +   |+--- jpegint.h
 +   |+--- jconfig.lnx and/or jconfig.vc
 +   |+--- libjpeg.lib and/or libjpeg.ia32 and/or libjpeg.ipf
 +   \---png
 +   ||
 +   |+--- png.h
 +   |+--- pngconf.h
 +   |+--- libpng.lib and/or libpng.ia32 and/or libpng.ipf
 +   \---lcms
 +   ||
 +   |+--- icc34.h
 +   |+--- lcms.h
 +   |+--- lcms114.lib and/or liblcms.ia32 and/or liblcms.ipf
 +   ...
 +
 +NOTE: The tree above indicates the files required for this contribution,
 +  not all the files distributed with each library.
 +
 +Further in the document, EXTERNAL_LIBS_DIR denotes the directory
 +EXTRACT_DIR/depends/libs/build.
 +
 +1.1 Building the IJG IPEG library
 +
 +System: Windows* IA-32
 +
 +1. Change the directory to the IJG JPEG library source directory;
 +   normally, jpeg-6b.
 +2. Copy the file jconfig.vc to jconfig.h.
 +3. Copy the jconfig.vc file to the EXTERNAL_LIBS_DIR/jpeg/ directory.
 +4. Start the Microsoft* Windows* SDK build environment or
 +   the Visual Studio .NET* 2003 Command Prompt.
 +5. Build the library by running:
 +
 + For the release version: nmake nodebug=1 /f makefile.vc
 + For the debug version: nmake /f makefile.vc
 +
 +6. Copy the file libjpeg.lib to the EXTERNAL_LIBS_DIR/jpeg directory.
 +7. Copy the required header files to the EXTERNAL_LIBS_DIR/jpeg
 +   directory.  For a list of required files, see the tree view above.
 +
 +System: Linux* IA-32
 +
 +1. Change the directory to the IJG

Re: svn commit: r420823 - in /incubator/harmony/enhanced/classlib/trunk/depends/libs/build: ./ README.txt fetch-awt-depends.sh

[Mark Hindess]

On 12 July 2006 at 12:50, Alexey Petrenko [EMAIL PROTECTED] wrote:

 I've just returned from the vacation.  And I have planned to work
 on trying to run awt with GnuWin32 libraries today. But we have few
 predicatble issues with them.

Excellent.  Thanks Alexey.

 We also did not finish the talks about integrating the needed sources
 into Harmony class library since the licenses seems to be Apache
 authorized. As we did with zlib.

I suspect this would be a difficult path.

 And we also have possibility to update Harmony build script to
 download and build this libraries...

I think this might be the best option if we don't have a usable source
of binary downloads.

Regards,
 Mark.



-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r420823 - in /incubator/harmony/enhanced/classlib/trunk/depends/libs/build: ./ README.txt fetch-awt-depends.sh

[Alexey Petrenko]

2006/7/12, Mark Hindess [EMAIL PROTECTED]:


On 12 July 2006 at 12:50, Alexey Petrenko [EMAIL PROTECTED] wrote:

 I've just returned from the vacation.  And I have planned to work
 on trying to run awt with GnuWin32 libraries today. But we have few
 predicatble issues with them.
Excellent.  Thanks Alexey.

But as I said we got few predictable problems here:
1. Not all the libraries in GnuWin32 have needed versions.
2. Libraries form GnuWin32 are looking for zlib1.dll which is renamed
in Harmony class lib.


 We also did not finish the talks about integrating the needed sources
 into Harmony class library since the licenses seems to be Apache
 authorized. As we did with zlib.
I suspect this would be a difficult path.

Why we could include zlib and could not include others? ;)
The only problem I see is synchronization with the libraries main tree...


 And we also have possibility to update Harmony build script to
 download and build this libraries...
I think this might be the best option if we don't have a usable source
of binary downloads.

Probably so...

SY, Alexey

--
Alexey A. Petrenko
Intel Middleware Products Division

-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r420823 - in /incubator/harmony/enhanced/classlib/trunk/depends/libs/build: ./ README.txt fetch-awt-depends.sh

[Geir Magnusson Jr]

Alexey Petrenko wrote:
 2006/7/12, Mark Hindess [EMAIL PROTECTED]:

 On 12 July 2006 at 12:50, Alexey Petrenko
 [EMAIL PROTECTED] wrote:
 
  I've just returned from the vacation.  And I have planned to work
  on trying to run awt with GnuWin32 libraries today. But we have few
  predicatble issues with them.
 Excellent.  Thanks Alexey.
 But as I said we got few predictable problems here:
 1. Not all the libraries in GnuWin32 have needed versions.
 2. Libraries form GnuWin32 are looking for zlib1.dll which is renamed
 in Harmony class lib.

Let me ask the obvious question.  Does using GNUWin32 add any code from
GNUWin32 to our artifacts?

If so, we can't use it because of the odd and somewhat confusing
restrictions in the license here :

http://gnuwin32.sourceforge.net/license.html

geir

-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r420823 - in /incubator/harmony/enhanced/classlib/trunk/depends/libs/build: ./ README.txt fetch-awt-depends.sh

[Mark Hindess]

I've checked in a script so that:

  svn co ... classlib
  cd classlib
  ant fetch-depends
  sh depends/libs/build/fetch-awt-depends.sh
  ant -Dwith.awt.swing=true rebuild

should work on Debian Linux.  Updates for other distributions would be
very welcome.

Any update on what to do on Windows?

I'm hoping to get the misc natives from the awt contribution integrated
today (or maybe tomorrow) then I'll start on the awt natives so it would
be good to resolve this issue.

Regards,
 Mark.

On 11 July 2006 at 12:43, [EMAIL PROTECTED] wrote:
 Author: hindessm
 Date: Tue Jul 11 05:43:09 2006
 New Revision: 420823
 
 URL: http://svn.apache.org/viewvc?rev=420823view=rev
 Log:
 Added README.txt for AWT dependencies - mostly taken from contribution README
 .
 Added helper script for Linux - Debian/Ubuntu only but could be updated for
 other common distros.
 
 
 Added:
 incubator/harmony/enhanced/classlib/trunk/depends/libs/build/   (with pro
 ps)
 incubator/harmony/enhanced/classlib/trunk/depends/libs/build/README.txt  
  (with props)
 incubator/harmony/enhanced/classlib/trunk/depends/libs/build/fetch-awt-de
 pends.sh   (with props)
 
 Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/build/
 -
 -
 --- svn:ignore (added)
 +++ svn:ignore Tue Jul 11 05:43:09 2006
 @@ -0,0 +1,3 @@
 +jpeg
 +lcms
 +png
 
 Added: incubator/harmony/enhanced/classlib/trunk/depends/libs/build/README.tx
 t
 URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/d
 epends/libs/build/README.txt?rev=420823view=auto
 =
 =
 --- incubator/harmony/enhanced/classlib/trunk/depends/libs/build/README.txt (
 added)
 +++ incubator/harmony/enhanced/classlib/trunk/depends/libs/build/README.txt T
 ue Jul 11 05:43:09 2006
 @@ -0,0 +1,175 @@
 +Dependencies for AWT
 +
 +
 +For Debian/Ubuntu, it should be possible to run:
 +
 +  sh depends/libs/build/fetch-awt-depends.sh
 +
 +to construct the dependency tree.
 +
 +On other platforms the dependencies must be build using the following
 +instructions.
 +
 +
 +1. Building the external libraries
 +--
 +
 +To enable image decoding (JPEG and PNG images) and color management
 +with awt, build the IJG JPEG, Libpng and the Little CMS libraries.
 +
 +After performing the instructions below, you create the following
 +directory tree structure:
 +
 +EXTRACT_DIR/depends/libs/build
 +   |
 +   \---jpeg
 +   ||
 +   |+--- cderror.h
 +   |+--- jinclude.h
 +   |+--- jpeglib.h
 +   |+--- cdjpeg.h
 +   |+--- jdct.h
 +   |+--- jmemsys.h
 +   |+--- jversion.h
 +   |+--- jchuff.h
 +   |+--- jdhuff.h
 +   |+--- jmorecfg.h
 +   |+--- jerror.h
 +   |+--- jpegint.h
 +   |+--- jconfig.lnx and/or jconfig.vc
 +   |+--- libjpeg.lib and/or libjpeg.ia32 and/or libjpeg.ipf
 +   \---png
 +   ||
 +   |+--- png.h
 +   |+--- pngconf.h
 +   |+--- libpng.lib and/or libpng.ia32 and/or libpng.ipf
 +   \---lcms
 +   ||
 +   |+--- icc34.h
 +   |+--- lcms.h
 +   |+--- lcms114.lib and/or liblcms.ia32 and/or liblcms.ipf
 +   ...
 +
 +NOTE: The tree above indicates the files required for this contribution,
 +  not all the files distributed with each library.
 +
 +Further in the document, EXTERNAL_LIBS_DIR denotes the directory
 +EXTRACT_DIR/depends/libs/build.
 +
 +1.1 Building the IJG IPEG library
 +
 +System: Windows* IA-32
 +
 +1. Change the directory to the IJG JPEG library source directory;
 +   normally, jpeg-6b.
 +2. Copy the file jconfig.vc to jconfig.h.
 +3. Copy the jconfig.vc file to the EXTERNAL_LIBS_DIR/jpeg/ directory.
 +4. Start the Microsoft* Windows* SDK build environment or
 +   the Visual Studio .NET* 2003 Command Prompt.
 +5. Build the library by running:
 +
 + For the release version: nmake nodebug=1 /f makefile.vc
 + For the debug version: nmake /f makefile.vc
 +
 +6. Copy the file libjpeg.lib to the EXTERNAL_LIBS_DIR/jpeg directory.
 +7. Copy the required header files to the EXTERNAL_LIBS_DIR/jpeg
 +   directory.  For a list of required files, see the tree view above.
 +
 +System: Linux* IA-32
 +
 +1. Change the directory to the IJG JPEG library source directory;
 +   normally, jpeg-6b.
 +2. Configure the build by running:
 +
 + For the release version: ./configure CFLAGS=’-O2 -fpic’
 + For the debug version: ./configure CFLAGS=’-g -fpic’
 +
 +3. Copy the file jconfig.h created during the previous step to
 +   the EXTERNAL_LIBS_DIR/jpeg/jconfig.lnx directory.
 +4. To build the library, run:
 +
 + make
 +
 +5. Copy the resulting libjpeg.a file to the file

[build] New ECJ depends requires update to build machine (RE: svn commit: r418841 - in /incubator/harmony/enhanced/classlib/trunk: depends/jars/ make/depends.properties modules/tools/src/main/java/org

[Nathan Beyer]

To whoever can handle it, 

I've updated the dependencies and Compiler class to use a new version of the
Eclipse compiler JAR. The final 3.2 release was shipped the other day.

Sorry for the inconvenience.

-Nathan

 -Original Message-
 From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
 Sent: Monday, July 03, 2006 3:30 PM
 To: [EMAIL PROTECTED]
 Subject: svn commit: r418841 - in
 /incubator/harmony/enhanced/classlib/trunk: depends/jars/
 make/depends.properties
 modules/tools/src/main/java/org/apache/harmony/tools/javac/Compiler.java
 
 Author: ndbeyer
 Date: Mon Jul  3 13:29:39 2006
 New Revision: 418841
 
 URL: http://svn.apache.org/viewvc?rev=418841view=rev
 Log:
 Update dependencies and javac to use the final 3.2 release of ecj.jar.
 
 Modified:
 incubator/harmony/enhanced/classlib/trunk/depends/jars/   (props
 changed)
 incubator/harmony/enhanced/classlib/trunk/make/depends.properties
 
 incubator/harmony/enhanced/classlib/trunk/modules/tools/src/main/java/org/
 apache/harmony/tools/javac/Compiler.java
 
 Propchange: incubator/harmony/enhanced/classlib/trunk/depends/jars/
 --
 
 --- svn:ignore (original)
 +++ svn:ignore Mon Jul  3 13:29:39 2006
 @@ -10,3 +10,4 @@
  xalan-j_2.6.0
  xerces_2.6.2
  ecj_3.2MAINT
 +ecj_3.2
 
 Modified:
 incubator/harmony/enhanced/classlib/trunk/make/depends.properties
 URL:
 http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/mak
 e/depends.properties?rev=418841r1=418840r2=418841view=diff
 ==
 
 --- incubator/harmony/enhanced/classlib/trunk/make/depends.properties
 (original)
 +++ incubator/harmony/enhanced/classlib/trunk/make/depends.properties Mon
 Jul  3 13:29:39 2006
 @@ -60,10 +60,10 @@
  icu4j.url=http://www.ibiblio.org/maven2/com/ibm/icu/icu4j/3.4.4/icu4j-
 3.4.4.jar
  icu4j.md5=92422a9465ccc608bc7a8ae9cf594509
 
 -ecj.dir=${depends.jars}/ecj_3.2MAINT
 -ecj.jar=${ecj.dir}/ecj_3.2MAINT.jar
 -ecj.url=http://download.eclipse.org/eclipse/downloads/drops/M20060609-
 1217/ecj.jar
 -ecj.md5=d72629440a9f6cd281f7e58fcaee1ecb
 +ecj.dir=${depends.jars}/ecj_3.2
 +ecj.jar=${ecj.dir}/ecj_3.2.jar
 +ecj.url=http://download.eclipse.org/eclipse/downloads/drops/R-3.2-
 200606291905/ecj.jar
 +ecj.md5=633e14a4dc14ca578b5548c3c088172f
 
  mx4j.dir=${depends.jars}/mx4j_3.0.1
  mx4j.jar=${mx4j.dir}/mx4j.jar
 
 Modified:
 incubator/harmony/enhanced/classlib/trunk/modules/tools/src/main/java/org/
 apache/harmony/tools/javac/Compiler.java
 URL:
 http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/mod
 ules/tools/src/main/java/org/apache/harmony/tools/javac/Compiler.java?rev=
 418841r1=418840r2=418841view=diff
 ==
 
 ---
 incubator/harmony/enhanced/classlib/trunk/modules/tools/src/main/java/org/
 apache/harmony/tools/javac/Compiler.java (original)
 +++
 incubator/harmony/enhanced/classlib/trunk/modules/tools/src/main/java/org/
 apache/harmony/tools/javac/Compiler.java Mon Jul  3 13:29:39 2006
 @@ -36,14 +36,14 @@
  ISO8859_1);
 
  /* FIXME: Hard-coded for now, the name of the ECJ JAR file */
 -static final String ECJ_JAR_FILE = ecj_3.2MAINT.jar;
 +static final String ECJ_JAR_FILE = ecj_3.2.jar;
 
  /* The name of the ECJ compiler class */
  static final String MAIN_CLASS_NAME =
 org.eclipse.jdt.internal.compiler.batch.Main;
 
  /*
   * Invokes the compiler with the given command-line arguments. The
 supported
 - * arguments can be determined form the usage mesage.
 + * arguments can be determined form the usage message.
   */
  public static void main(String[] args) {
  Compiler myself = new Compiler();
 @@ -62,7 +62,7 @@
  }
 
  // Reference to ECJ 'Main' compiler class.
 -Class ecjCompilerClass;
 +Class? ecjCompilerClass;
 
  // An instance of the ECJ compiler
  Object mainInst;
 @@ -122,7 +122,7 @@
  PrintWriter errWriter = new PrintWriter(esw);
 
  // Create a new instance of the compiler
 -Constructor ctor = ecjCompilerClass.getConstructor(new Class[] {
 +Constructor? ctor = ecjCompilerClass.getConstructor(new Class[]
 {
  PrintWriter.class, PrintWriter.class, Boolean.TYPE });
 
  mainInst = ctor.newInstance(new Object[] { outWriter, errWriter,


-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r417248 - in /incubator/harmony/enhanced/classlib/trunk: depends/build/ modules/luni/ modules/luni/src/main/native/launcher/ modules/luni/src/main/native/launcher/linux/ modules/luni/s

[Gregory Shimansky]

Hello Tim

I've got another classlib build problem on linux. In the file below I had to 
add $(DLLPATH)libhysig.so to MDLLIBFILES list or I get this error from 
linker:


Execute:Java13CommandLauncher: Executing 'make' with
 [exec] cc  \ 
[exec] ../shared/main.o ../shared/cmain.o ../shared/launcher_copyright.o 
../shared/strbuf.o ../shared/libhlp.o   
\
[exec] -g -Xlinker --start-group 
/home/gregory/work/Harmony/harmony/enhanced/classlib/trunk/deploy/jdk/jre/bin/libhyprt.so
 
/home/gregory/work/Harmony/harmony/enhanced/classlib/trunk/deploy/jdk/jre/bin/libhythr.so
 -Xlinker --end-group 
\
 [exec] -o ../java -lm -lpthread -lc -ldl \
 [exec] -Xlinker -z -Xlinker origin \
 [exec] -Xlinker -rpath -Xlinker \$ORIGIN/ \
 [exec] -Xlinker -rpath-link -Xlinker .. 
[exec] 
/usr/lib/gcc/i686-pc-linux-gnu/3.4.6/../../../../i686-pc-linux-gnu/bin/ld: 
warning: libhysig.so, needed 
by 
/home/gregory/work/Harmony/harmony/enhanced/classlib/trunk/deploy/jdk/jre/bin/libhyprt.so,
 
not found (try using -rpath or -rpath-link)
 
[exec] 
/home/gregory/work/Harmony/harmony/enhanced/classlib/trunk/deploy/jdk/jre/bin/libhyprt.so:
 
undefined reference to [EMAIL PROTECTED]'
 
[exec] 
/home/gregory/work/Harmony/harmony/enhanced/classlib/trunk/deploy/jdk/jre/bin/libhyprt.so:
 
undefined reference to [EMAIL PROTECTED]'
 
[exec] 
/home/gregory/work/Harmony/harmony/enhanced/classlib/trunk/deploy/jdk/jre/bin/libhyprt.so:
 
undefined reference to [EMAIL PROTECTED]'
 
[exec] 
/home/gregory/work/Harmony/harmony/enhanced/classlib/trunk/deploy/jdk/jre/bin/libhyprt.so:
 
undefined reference to [EMAIL PROTECTED]'
 [exec] collect2: ld returned 1 exit status
 [exec] make: *** [../java] Ошибка 1


On Monday 26 June 2006 21:36 [EMAIL PROTECTED] wrote:
 Author: tellison
 Date: Mon Jun 26 10:35:59 2006
 New Revision: 417248

 URL: http://svn.apache.org/viewvc?rev=417248view=rev
 Log:
 Apply patch HARMONY-668 (Move vmls and launcher natives to luni module)

snip/

 ===
=== ---
 incubator/harmony/enhanced/classlib/trunk/native-src/linux.IA32/launcher/ma
kefile (original) +++
 incubator/harmony/enhanced/classlib/trunk/modules/luni/src/main/native/laun
cher/linux/makefile Mon Jun 26 10:35:59 2006 @@ -18,10 +18,11 @@

  include $(HY_HDK)/build/make/makefile.include

 +SHAREDSUB=../shared/
  BUILDFILES = $(SHAREDSUB)main.o $(SHAREDSUB)cmain.o \
   $(SHAREDSUB)launcher_copyright.o $(SHAREDSUB)strbuf.o \
   $(SHAREDSUB)libhlp.o
 -MDLLIBFILES = ../libhyprt.so ../libhythr.so
 +MDLLIBFILES = $(DLLPATH)libhyprt.so $(DLLPATH)libhythr.so
  EXENAME = $(EXEPATH)java

  include $(HY_HDK)/build/make/rules.mk

snip/
-- 
Gregory Shimansky, Intel Middleware Products Division

-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r417248 - in /incubator/harmony/enhanced/classlib/trunk: depends/build/ modules/luni/ modules/luni/src/main/native/launcher/ modules/luni/src/main/native/launcher/linux/ modules/luni/s

[Mark Hindess]

Fixed in r417277.

-Mark.

On 26 June 2006 at 22:45, Gregory Shimansky [EMAIL PROTECTED] wrote:
 Hello Tim
 
 I've got another classlib build problem on linux. In the file below I had to 
 add $(DLLPATH)libhysig.so to MDLLIBFILES list or I get this error from 
 linker:
 
 
 Execute:Java13CommandLauncher: Executing 'make' with
  [exec] cc  \ 
 [exec] ../shared/main.o ../shared/cmain.o ../shared/launcher_copyright.o ../s
 hared/strbuf.o ../shared/libhlp.o   
 \
 [exec] -g -Xlinker --start-group /home/gregory/work/Harmony/harmony/enhanced/
 classlib/trunk/deploy/jdk/jre/bin/libhyprt.so /home/gregory/work/Harmony/harm
 ony/enhanced/classlib/trunk/deploy/jdk/jre/bin/libhythr.so -Xlinker --end-gro
 up 
 \
  [exec] -o ../java -lm -lpthread -lc -ldl \
  [exec] -Xlinker -z -Xlinker origin \
  [exec] -Xlinker -rpath -Xlinker \$ORIGIN/ \
  [exec] -Xlinker -rpath-link -Xlinker .. 
 [exec] /usr/lib/gcc/i686-pc-linux-gnu/3.4.6/../../../../i686-pc-linux-gnu/bin
 /ld: 
 warning: libhysig.so, needed 
 by /home/gregory/work/Harmony/harmony/enhanced/classlib/trunk/deploy/jdk/jre/
 bin/libhyprt.so, 
 not found (try using -rpath or -rpath-link)
  
 [exec] /home/gregory/work/Harmony/harmony/enhanced/classlib/trunk/deploy/jdk/
 jre/bin/libhyprt.so: 
 undefined reference to [EMAIL PROTECTED]'
  
 [exec] /home/gregory/work/Harmony/harmony/enhanced/classlib/trunk/deploy/jdk/
 jre/bin/libhyprt.so: 
 undefined reference to [EMAIL PROTECTED]'
  
 [exec] /home/gregory/work/Harmony/harmony/enhanced/classlib/trunk/deploy/jdk/
 jre/bin/libhyprt.so: 
 undefined reference to [EMAIL PROTECTED]'
  
 [exec] /home/gregory/work/Harmony/harmony/enhanced/classlib/trunk/deploy/jdk/
 jre/bin/libhyprt.so: 
 undefined reference to [EMAIL PROTECTED]'
  [exec] collect2: ld returned 1 exit status
  [exec] make: *** [../java] Ошибка 1
 
 
 On Monday 26 June 2006 21:36 [EMAIL PROTECTED] wrote:
  Author: tellison
  Date: Mon Jun 26 10:35:59 2006
  New Revision: 417248
 
  URL: http://svn.apache.org/viewvc?rev=417248view=rev
  Log:
  Apply patch HARMONY-668 (Move vmls and launcher natives to luni module)
 
 snip/
 
  ===
 === ---
  incubator/harmony/enhanced/classlib/trunk/native-src/linux.IA32/launcher/ma
 kefile (original) +++
  incubator/harmony/enhanced/classlib/trunk/modules/luni/src/main/native/laun
 cher/linux/makefile Mon Jun 26 10:35:59 2006 @@ -18,10 +18,11 @@
 
   include $(HY_HDK)/build/make/makefile.include
 
  +SHAREDSUB=../shared/
   BUILDFILES = $(SHAREDSUB)main.o $(SHAREDSUB)cmain.o \
  $(SHAREDSUB)launcher_copyright.o $(SHAREDSUB)strbuf.o \
  $(SHAREDSUB)libhlp.o
  -MDLLIBFILES = ../libhyprt.so ../libhythr.so
  +MDLLIBFILES = $(DLLPATH)libhyprt.so $(DLLPATH)libhythr.so
   EXENAME = $(EXEPATH)java
 
   include $(HY_HDK)/build/make/rules.mk
 
 snip/
 -- 
 Gregory Shimansky, Intel Middleware Products Division
 
 -
 Terms of use : http://incubator.apache.org/harmony/mailing.html
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]





-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r417248 - in /incubator/harmony/enhanced/classlib/trunk: depends/build/ modules/luni/ modules/luni/src/main/native/launcher/ modules/luni/src/main/native/launcher/linux/ modules/luni/s

[Gregory Shimansky]

Cool. Thanks a lot Mark. You've fixed it better than I suggested.

On Monday 26 June 2006 22:58 Mark Hindess wrote:
 Fixed in r417277.

 -Mark.

 On 26 June 2006 at 22:45, Gregory Shimansky [EMAIL PROTECTED] wrote:
  Hello Tim
 
  I've got another classlib build problem on linux. In the file below I had
  to add $(DLLPATH)libhysig.so to MDLLIBFILES list or I get this error from
  linker:
 
 
  Execute:Java13CommandLauncher: Executing 'make' with
   [exec] cc  \
  [exec] ../shared/main.o ../shared/cmain.o ../shared/launcher_copyright.o
  ../s hared/strbuf.o ../shared/libhlp.o
  \
  [exec] -g -Xlinker --start-group
  /home/gregory/work/Harmony/harmony/enhanced/
  classlib/trunk/deploy/jdk/jre/bin/libhyprt.so
  /home/gregory/work/Harmony/harm
  ony/enhanced/classlib/trunk/deploy/jdk/jre/bin/libhythr.so -Xlinker
  --end-gro up
  \
   [exec] -o ../java -lm -lpthread -lc -ldl \
   [exec] -Xlinker -z -Xlinker origin \
   [exec] -Xlinker -rpath -Xlinker \$ORIGIN/ \
   [exec] -Xlinker -rpath-link -Xlinker ..
  [exec]
  /usr/lib/gcc/i686-pc-linux-gnu/3.4.6/../../../../i686-pc-linux-gnu/bin
  /ld:
  warning: libhysig.so, needed
  by
  /home/gregory/work/Harmony/harmony/enhanced/classlib/trunk/deploy/jdk/jre
 / bin/libhyprt.so,
  not found (try using -rpath or -rpath-link)
 
  [exec]
  /home/gregory/work/Harmony/harmony/enhanced/classlib/trunk/deploy/jdk/
  jre/bin/libhyprt.so:
  undefined reference to [EMAIL PROTECTED]'
 
  [exec]
  /home/gregory/work/Harmony/harmony/enhanced/classlib/trunk/deploy/jdk/
  jre/bin/libhyprt.so:
  undefined reference to [EMAIL PROTECTED]'
 
  [exec]
  /home/gregory/work/Harmony/harmony/enhanced/classlib/trunk/deploy/jdk/
  jre/bin/libhyprt.so:
  undefined reference to [EMAIL PROTECTED]'
 
  [exec]
  /home/gregory/work/Harmony/harmony/enhanced/classlib/trunk/deploy/jdk/
  jre/bin/libhyprt.so:
  undefined reference to [EMAIL PROTECTED]'
   [exec] collect2: ld returned 1 exit status
   [exec] make: *** [../java] Ошибка 1
 
  On Monday 26 June 2006 21:36 [EMAIL PROTECTED] wrote:
   Author: tellison
   Date: Mon Jun 26 10:35:59 2006
   New Revision: 417248
  
   URL: http://svn.apache.org/viewvc?rev=417248view=rev
   Log:
   Apply patch HARMONY-668 (Move vmls and launcher natives to luni module)
 
  snip/
 
   ===
   === ---
   incubator/harmony/enhanced/classlib/trunk/native-src/linux.IA32/launche
  r/ma kefile (original) +++
   incubator/harmony/enhanced/classlib/trunk/modules/luni/src/main/native/
  laun cher/linux/makefile Mon Jun 26 10:35:59 2006 @@ -18,10 +18,11 @@
  
include $(HY_HDK)/build/make/makefile.include
  
   +SHAREDSUB=../shared/
BUILDFILES = $(SHAREDSUB)main.o $(SHAREDSUB)cmain.o \
 $(SHAREDSUB)launcher_copyright.o $(SHAREDSUB)strbuf.o \
 $(SHAREDSUB)libhlp.o
   -MDLLIBFILES = ../libhyprt.so ../libhythr.so
   +MDLLIBFILES = $(DLLPATH)libhyprt.so $(DLLPATH)libhythr.so
EXENAME = $(EXEPATH)java
  
include $(HY_HDK)/build/make/rules.mk
 
  snip/

-- 
Gregory Shimansky, Intel Middleware Products Division

-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r415915 - /incubator/harmony/enhanced/classlib/trunk/depends/jars/

[Mark Hindess]

This change reminded me about something.  The big javac in
make/build-java.xml currently has:

  classpath
fileset dir=${depends.jars}
  include name=**/*.jar /
/fileset
  /classpath

which means that if you have old versions of dependencies in
depends/jars/*/*.jar then they will be picked up by the build.  I
actually saw a compiler error the other day because of this - building
with a version of ecj.

I assume Mikhail put these back because (like me) he likes to keep
the old versions around just in case he wants to test an old classlib
version - for instance doing a binary chop to find when a regression
occurred.

The fix for this would be to defined in depends.xml a reference property
that defined the fileset for the current versions of these dependencies.
I will take a look at this unless anyone objects.

Regards,
 Mark.

On 21 June 2006 at 5:24, [EMAIL PROTECTED] wrote:
 Author: mloenko
 Date: Tue Jun 20 22:24:58 2006
 New Revision: 415915
 
 URL: http://svn.apache.org/viewvc?rev=415915view=rev
 Log:
 add depends jars to svn:ignore
 
 Modified:
 incubator/harmony/enhanced/classlib/trunk/depends/jars/   (props changed)
 
 Propchange: incubator/harmony/enhanced/classlib/trunk/depends/jars/
 -
 -
 --- svn:ignore (original)
 +++ svn:ignore Tue Jun 20 22:24:58 2006
 @@ -1,3 +1,4 @@
 +
  bcprov-jdk14-133
  ecj_3.2RC5
  icu4j_3.4.4
 @@ -5,3 +6,7 @@
  mx4j_3.0.1
  xalan-j_2.7.0
  xerces_2.8.0
 +bcprov-jdk14-132
 +junit_3.8.1
 +xalan-j_2.6.0
 +xerces_2.6.2
 



-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r415915 - /incubator/harmony/enhanced/classlib/trunk/depends/jars/

[Mikhail Loenko]

Hi Mark,

I've added the things to svn::ignore to not commit the binaries accidently.

Mikhail

2006/6/22, Mark Hindess [EMAIL PROTECTED]:


This change reminded me about something.  The big javac in
make/build-java.xml currently has:

 classpath
   fileset dir=${depends.jars}
 include name=**/*.jar /
   /fileset
 /classpath

which means that if you have old versions of dependencies in
depends/jars/*/*.jar then they will be picked up by the build.  I
actually saw a compiler error the other day because of this - building
with a version of ecj.

I assume Mikhail put these back because (like me) he likes to keep
the old versions around just in case he wants to test an old classlib
version - for instance doing a binary chop to find when a regression
occurred.

The fix for this would be to defined in depends.xml a reference property
that defined the fileset for the current versions of these dependencies.
I will take a look at this unless anyone objects.

Regards,
 Mark.

On 21 June 2006 at 5:24, [EMAIL PROTECTED] wrote:
 Author: mloenko
 Date: Tue Jun 20 22:24:58 2006
 New Revision: 415915

 URL: http://svn.apache.org/viewvc?rev=415915view=rev
 Log:
 add depends jars to svn:ignore

 Modified:
 incubator/harmony/enhanced/classlib/trunk/depends/jars/   (props changed)

 Propchange: incubator/harmony/enhanced/classlib/trunk/depends/jars/
 -
 -
 --- svn:ignore (original)
 +++ svn:ignore Tue Jun 20 22:24:58 2006
 @@ -1,3 +1,4 @@
 +
  bcprov-jdk14-133
  ecj_3.2RC5
  icu4j_3.4.4
 @@ -5,3 +6,7 @@
  mx4j_3.0.1
  xalan-j_2.7.0
  xerces_2.8.0
 +bcprov-jdk14-132
 +junit_3.8.1
 +xalan-j_2.6.0
 +xerces_2.6.2




-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r390995 - in /incubator/harmony/enhanced/classlib/trunk: depends/files/bootclasspath.properties depends/jars/ depends/jars/icu4j_3_4.jar make/build-java.xml make/depends.properties mak

[Tim Ellison]

Heads up once again, the build now expects that your ICU4J jar file
resides in a particular directory and will complain if it doesn't exist.

You can download the checked dependencies using
  ant -f make/depends.xml download

Regards,
Tim

[EMAIL PROTECTED] wrote:
 Author: tellison
 Date: Mon Apr  3 03:33:18 2006
 New Revision: 390995
 
 URL: http://svn.apache.org/viewcvs?rev=390995view=rev
 Log:
 Update to ICU4J version 3.4.4 and make it a downloaded dependency
 
 Removed:
 incubator/harmony/enhanced/classlib/trunk/depends/jars/icu4j_3_4.jar
 Modified:
 
 incubator/harmony/enhanced/classlib/trunk/depends/files/bootclasspath.properties
 incubator/harmony/enhanced/classlib/trunk/depends/jars/   (props changed)
 incubator/harmony/enhanced/classlib/trunk/make/build-java.xml
 incubator/harmony/enhanced/classlib/trunk/make/depends.properties
 incubator/harmony/enhanced/classlib/trunk/make/depends.xml
 
 Modified: 
 incubator/harmony/enhanced/classlib/trunk/depends/files/bootclasspath.properties
 URL: 
 http://svn.apache.org/viewcvs/incubator/harmony/enhanced/classlib/trunk/depends/files/bootclasspath.properties?rev=390995r1=390994r2=390995view=diff
 ==
 --- 
 incubator/harmony/enhanced/classlib/trunk/depends/files/bootclasspath.properties
  (original)
 +++ 
 incubator/harmony/enhanced/classlib/trunk/depends/files/bootclasspath.properties
  Mon Apr  3 03:33:18 2006
 @@ -161,7 +161,7 @@
  # ICU functionality for text/characters is provided by JNI wrappers
  # to ICU4C and pure-Java implementation in the ICU4J JAR file.
  bootclasspath.32=icu4jni-3.4.jar
 -bootclasspath.33=icu4j_3_4.jar
 +bootclasspath.33=icu4j_3.4.4/icu4j_3_4_4.jar
  
  # The following JARs are from Xerces/Xalan
  bootclasspath.34=xalan-j_2.6.0/xalan.jar
 
 Propchange: incubator/harmony/enhanced/classlib/trunk/depends/jars/
 --
 --- svn:ignore (original)
 +++ svn:ignore Mon Apr  3 03:33:18 2006
 @@ -3,3 +3,4 @@
  xerces_2.6.2
  bcprov-jdk14-131
  bcprov-jdk14-132
 +icu4j_3.4.4
 
 Modified: incubator/harmony/enhanced/classlib/trunk/make/build-java.xml
 URL: 
 http://svn.apache.org/viewcvs/incubator/harmony/enhanced/classlib/trunk/make/build-java.xml?rev=390995r1=390994r2=390995view=diff
 ==
 --- incubator/harmony/enhanced/classlib/trunk/make/build-java.xml (original)
 +++ incubator/harmony/enhanced/classlib/trunk/make/build-java.xml Mon Apr  3 
 03:33:18 2006
 @@ -253,16 +253,11 @@
  src path=modules/security/src/linux/javasrc /
  src path=modules/security-kernel/src/main/java /
  src path=modules/x-net/src/main/java/ /
 -
  src path=modules/rmi/src/main/java /
  src path=modules/sql/src/main/java /
 -
  src path=modules/text/src/main/java /
 -
  src path=modules/jndi/src/main/java /
 -
  src path=modules/logging/src/main/java /
 -
  src path=modules/prefs/src/main/java /
  
  classpath location=${build.output} /
 @@ -338,6 +333,8 @@
  patternset includes=*.jar /
  patternset includes=xerces_2.6.2/*.jar /
  patternset includes=xalan-j_2.6.0/*.jar /
 +patternset includes=icu4j_3.4.4/*.jar /
 +
  /fileset
  /copy
  
 
 Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.properties
 URL: 
 http://svn.apache.org/viewcvs/incubator/harmony/enhanced/classlib/trunk/make/depends.properties?rev=390995r1=390994r2=390995view=diff
 ==
 --- incubator/harmony/enhanced/classlib/trunk/make/depends.properties 
 (original)
 +++ incubator/harmony/enhanced/classlib/trunk/make/depends.properties Mon Apr 
  3 03:33:18 2006
 @@ -54,3 +54,8 @@
  msvcr71.dll=${msvcr71.dir}/msvcr71.dll
  
 msvcr71.url=http://www.dlldump.com/cgi-bin/testwrap/downloadcounts.cgi?rt=countpath=dllfiles/M/MSVCR71.dll
  msvcr71.md5=86f1895ae8c5e8b17d99ece768a70732
 +
 +icu4j.dir=${depends.jars}/icu4j_3.4.4
 +icu4j.jar=${icu4j.dir}/icu4j_3_4_4.jar
 +icu4j.url=ftp://ftp.software.ibm.com/software/globalization/icu/icu4j/3.4.4/icu4j_3_4_4.jar
 +icu4j.md5=92422a9465ccc608bc7a8ae9cf594509
 
 Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.xml
 URL: 
 http://svn.apache.org/viewcvs/incubator/harmony/enhanced/classlib/trunk/make/depends.xml?rev=390995r1=390994r2=390995view=diff
 ==
 --- incubator/harmony/enhanced/classlib/trunk/make/depends.xml (original)
 +++ incubator/harmony/enhanced/classlib/trunk/make/depends.xml Mon Apr  3 
 03:33:18 2006
 @@ -42,6 +42,8 @@
  
   check-one-file src=${bcprov.url} dest=${signed.bcprov.jar} /
  
 + check-one-file src=${icu4j.url} dest

Re: enhanced/classlib/trunk/depends

[George Harley]

Jean-frederic Clere wrote:

Tim Ellison wrote:


Jean-frederic Clere wrote:
 


Mark Hindess wrote:

  

Using touch .now; sleep 2; (cd make; ant) ; find depends ... \!
-anewer .now on both builds shows that the only files that aren't
accessed by either build are the README files and:

depends/files/java.security

That probably isn't needed since the build uses:

modules/security/src/java.home/lib/security/java.security

instead.

But that's the only one that's obviously redundant.




Yep... I would prefer to classlib depends directory a readme that tells
classlib depends on:
CU4C version 3.4 (how to get and install it).
ICU4JNI
FDLIBM
zlib
  



Like this?
http://svn.apache.org/viewcvs.cgi/incubator/harmony/enhanced/classlib/trunk/depends/oss/README.txt?view=markup 

 

The README.txt doesn't tell how depends/jars/icu4j_3_4.jar is build, 
does it?



The README.txt contains the link to the ICU4J home where the binary jars 
may be downloaded from. You can also pick up source and build 
instructions from there if you want. Building the icu4j jar should not 
have to be done for Harmony.


Best regards,
George



Cheers

Jean-Frederic


Regards,
Tim

 


Cheers

Jean-Frederic

  

Regards,
Mark.

On 04/03/06, Jean-frederic Clere [EMAIL PROTECTED] wrote:




Hi,

There are a lot of objects in this repos directory, do we really need
them?

Cheers
Jean-Frederic
 
  

--
Mark Hindess [EMAIL PROTECTED]
IBM Java Technology Centre, UK.




  


 

Re: enhanced/classlib/trunk/depends

[Mark Hindess]

On 3/7/06, Jean-frederic Clere [EMAIL PROTECTED] wrote:

 Well I am complaining the svn contains binary files that could be
 easly rebuild... Should I propose an additional ant target to build
 those components?

 Done... (for Linux for the moment), please comment

Would you intend for this to be executed as part of the build - e.g.
replacing the current zlib unzip step with a download and unzip step? 
Or as a once only pre-requisite step?

I'd be a little concerned at the icu sudo make install step.  You
might be overwriting someone's existing install which they might not
be expecting.  My Debian install already has icu in /usr and adding
different version in /usr/local is just
going to lead to problems since other applications will be expecting
the version in /usr but might - due to /usr/local/bin/icu-config being
first in the path - get the harmony installed version.

Long term, I'd like to see the dependencies use existing installed
versions of packages where possible.  For instance, making use of zlib
that is a standard component of all major linux distributions.  (I
have a patch to remove zlib from the linux natives already if anyone
cares.  I don't think it really helps unless we also fix the windows
story.)

In the short term, the current setup is simple and helps control
differences, which avoids confusion that may be created by picking up
different versions of these dependencies.

Regards,
 Mark.

--
Mark Hindess [EMAIL PROTECTED]
IBM Java Technology Centre, UK.

Re: enhanced/classlib/trunk/depends

[Jean-frederic Clere]

Tim Ellison wrote:


Jean-frederic Clere wrote:
 


Mark Hindess wrote:

   


Using touch .now; sleep 2; (cd make; ant) ; find depends ... \!
-anewer .now on both builds shows that the only files that aren't
accessed by either build are the README files and:

depends/files/java.security

That probably isn't needed since the build uses:

modules/security/src/java.home/lib/security/java.security

instead.

But that's the only one that's obviously redundant.


 


Yep... I would prefer to classlib depends directory a readme that tells
classlib depends on:
CU4C version 3.4 (how to get and install it).
ICU4JNI
FDLIBM
zlib
   




Like this?
http://svn.apache.org/viewcvs.cgi/incubator/harmony/enhanced/classlib/trunk/depends/oss/README.txt?view=markup
 

The README.txt doesn't tell how depends/jars/icu4j_3_4.jar is build, 
does it?


Cheers

Jean-Frederic


Regards,
Tim

 


Cheers

Jean-Frederic

   


Regards,
Mark.

On 04/03/06, Jean-frederic Clere [EMAIL PROTECTED] wrote:


 


Hi,

There are a lot of objects in this repos directory, do we really need
them?

Cheers
Jean-Frederic
 
   


--
Mark Hindess [EMAIL PROTECTED]
IBM Java Technology Centre, UK.



 

   



 

Re: enhanced/classlib/trunk/depends

[Jean-frederic Clere]

Tim Ellison wrote:


Jean-frederic Clere wrote:
 


Tim Ellison wrote:

   


Jean-frederic Clere wrote:


 


Mark Hindess wrote:

 
   


Using touch .now; sleep 2; (cd make; ant) ; find depends ... \!
-anewer .now on both builds shows that the only files that aren't
accessed by either build are the README files and:

depends/files/java.security

That probably isn't needed since the build uses:

modules/security/src/java.home/lib/security/java.security

instead.

But that's the only one that's obviously redundant.


   
 


Yep... I would prefer to classlib depends directory a readme that tells
classlib depends on:
CU4C version 3.4 (how to get and install it).
ICU4JNI
FDLIBM
zlib
 
   


Like this?
http://svn.apache.org/viewcvs.cgi/incubator/harmony/enhanced/classlib/trunk/depends/oss/README.txt?view=markup



 


Well I am complaining the svn contains binary files that could be
easly rebuild... Should I propose an additional ant target to build
those components?
   



Sure - send it along.
 


Done... (for Linux for the moment), please comment

Cheers

Jean-Frederic


Thanks
Tim

 


On 04/03/06, Jean-frederic Clere [EMAIL PROTECTED] wrote:


   
 


Hi,

There are a lot of objects in this repos directory, do we really need
them?

Cheers
Jean-Frederic

 
   


--
Mark Hindess [EMAIL PROTECTED]
IBM Java Technology Centre, UK.



   
 

 
   




 

   



 



?xml version=1.0 encoding=UTF-8?

!-- http://www.apache.org/licenses/LICENSE-2.0 --

project name=build-depends default=build basedir=.
  target name=build

!-- ICU4C version 3.4 --
get src=ftp://ftp.software.ibm.com/software/globalization/icu/3.4.1/icu-3.4.1.tgz; dest=file.tar.gz /
gunzip src=file.tar.gz dest=file.tar/
untar src=file.tar dest=icu4c/
exec dir=icu4c/icu/source executable=chmod
  arg value=+x /
  arg value=runConfigureICU /
  arg value=configure /
  arg value=install-sh /
/exec
exec dir=icu4c/icu/source executable=${basedir}/icu4c/icu/source/runConfigureICU output=runConfigureICU.txt
  arg value=Linux /
/exec
exec dir=icu4c/icu/source executable=gmake /
exec dir=icu4c/icu/source executable=sudo
  arg value=gmake /
  arg value=install /
/exec

!-- ICU4JNI version 3.4 with Patch 01 --
get src=ftp://ftp.software.ibm.com/software/globalization/icu/icu4j/icu4jni/3.4/icu4jni_3_4.zip; dest=file.zip /
unzip src=file.zip dest=icu4jni /
!-- Add something to apply the patch --
fixcrlf srcdir=icu4jni/icu4jni
   eol=lf 
   eof=remove
   includes=**/config*
/
exec dir=icu4jni/icu4jni executable=chmod
  arg value=+x /
  arg value=configure /
/exec
property environment=env/
exec dir=icu4jni/icu4jni executable=${basedir}/icu4jni/icu4jni/configure
!-- xxx icu-config is installed somewhere --
env key=PATH path=${env.PATH}:${basedir}/icu4c/icu/source/config/
/exec
exec dir=icu4jni/icu4jni executable=gmake
  arg value=check /
/exec

!-- FDLIBM version 5.2 (There is a 5.3!) --
get src=http://www.validlab.com/software/fdlibm52.tar.gz; dest=file.tar.gz /
gunzip src=file.tar.gz dest=file.tar/
untar src=file.tar dest=fdlibm/
exec dir=fdlibm/fdlibm52 executable=gmake
/exec

  /target
  target name=toto
!-- ZLIB version 1.2.3 --
get src=http://www.zlib.net/zlib-1.2.3.tar.gz; dest=file.tar.gz /
gunzip src=file.tar.gz dest=file.tar/
untar src=file.tar dest=zip/
fixcrlf srcdir=zip
   eol=lf 
   eof=remove
   includes=**/configure
/
exec dir=zip executable=chmod
  arg value=+x /
  arg value=configure /
/exec
exec dir=zip executable=${basedir}/zip/configure/
exec dir=zip executable=gmake/
!-- the zip file is broken [at least configure is broken) --
!--
unzip src=oss/zlib_1.2.3.zip dest=zip/
exec dir=zip executable=configure/
--

  /target
/project

Re: enhanced/classlib/trunk/depends

[Tim Ellison]

Jean-frederic Clere wrote:
 Mark Hindess wrote:
 
 Using touch .now; sleep 2; (cd make; ant) ; find depends ... \!
 -anewer .now on both builds shows that the only files that aren't
 accessed by either build are the README files and:

  depends/files/java.security

 That probably isn't needed since the build uses:

  modules/security/src/java.home/lib/security/java.security

 instead.

 But that's the only one that's obviously redundant.
  

 Yep... I would prefer to classlib depends directory a readme that tells
 classlib depends on:
 CU4C version 3.4 (how to get and install it).
 ICU4JNI
 FDLIBM
 zlib


Like this?
http://svn.apache.org/viewcvs.cgi/incubator/harmony/enhanced/classlib/trunk/depends/oss/README.txt?view=markup

Regards,
Tim

 Cheers
 
 Jean-Frederic
 
 Regards,
 Mark.

 On 04/03/06, Jean-frederic Clere [EMAIL PROTECTED] wrote:
  

 Hi,

 There are a lot of objects in this repos directory, do we really need
 them?

 Cheers
 Jean-Frederic
   

 -- 
 Mark Hindess [EMAIL PROTECTED]
 IBM Java Technology Centre, UK.

  

 
 

-- 

Tim Ellison ([EMAIL PROTECTED])
IBM Java technology centre, UK.

Re: enhanced/classlib/trunk/depends

[Jean-frederic Clere]

Tim Ellison wrote:


Jean-frederic Clere wrote:
 


Mark Hindess wrote:

   


Using touch .now; sleep 2; (cd make; ant) ; find depends ... \!
-anewer .now on both builds shows that the only files that aren't
accessed by either build are the README files and:

depends/files/java.security

That probably isn't needed since the build uses:

modules/security/src/java.home/lib/security/java.security

instead.

But that's the only one that's obviously redundant.


 


Yep... I would prefer to classlib depends directory a readme that tells
classlib depends on:
CU4C version 3.4 (how to get and install it).
ICU4JNI
FDLIBM
zlib
   




Like this?
http://svn.apache.org/viewcvs.cgi/incubator/harmony/enhanced/classlib/trunk/depends/oss/README.txt?view=markup
 

Well I am complaining the svn contains binary files that could be 
easly rebuild... Should I propose an additional ant target to build 
those components?


Cheers

Jean-Frederic


Regards,
Tim

 


Cheers

Jean-Frederic

   


Regards,
Mark.

On 04/03/06, Jean-frederic Clere [EMAIL PROTECTED] wrote:


 


Hi,

There are a lot of objects in this repos directory, do we really need
them?

Cheers
Jean-Frederic
 
   


--
Mark Hindess [EMAIL PROTECTED]
IBM Java Technology Centre, UK.



 

   



 

Re: enhanced/classlib/trunk/depends

[Tim Ellison]

Jean-frederic Clere wrote:
 Tim Ellison wrote:
 
 Jean-frederic Clere wrote:
  

 Mark Hindess wrote:

   
 Using touch .now; sleep 2; (cd make; ant) ; find depends ... \!
 -anewer .now on both builds shows that the only files that aren't
 accessed by either build are the README files and:

 depends/files/java.security

 That probably isn't needed since the build uses:

 modules/security/src/java.home/lib/security/java.security

 instead.

 But that's the only one that's obviously redundant.


 
 Yep... I would prefer to classlib depends directory a readme that tells
 classlib depends on:
 CU4C version 3.4 (how to get and install it).
 ICU4JNI
 FDLIBM
 zlib
   


 Like this?
 http://svn.apache.org/viewcvs.cgi/incubator/harmony/enhanced/classlib/trunk/depends/oss/README.txt?view=markup

  

 Well I am complaining the svn contains binary files that could be
 easly rebuild... Should I propose an additional ant target to build
 those components?

Sure - send it along.

Thanks
Tim

 On 04/03/06, Jean-frederic Clere [EMAIL PROTECTED] wrote:


 
 Hi,

 There are a lot of objects in this repos directory, do we really need
 them?

 Cheers
 Jean-Frederic
  
   
 -- 
 Mark Hindess [EMAIL PROTECTED]
 IBM Java Technology Centre, UK.



 
   

  

 
 

-- 

Tim Ellison ([EMAIL PROTECTED])
IBM Java technology centre, UK.

enhanced/classlib/trunk/depends

[Jean-frederic Clere]

Hi,

There are a lot of objects in this repos directory, do we really need them?

Cheers

Jean-Frederic

Re: enhanced/classlib/trunk/depends

[Mark Hindess]

Using touch .now; sleep 2; (cd make; ant) ; find depends ... \!
-anewer .now on both builds shows that the only files that aren't
accessed by either build are the README files and:

  depends/files/java.security

That probably isn't needed since the build uses:

  modules/security/src/java.home/lib/security/java.security

instead.

But that's the only one that's obviously redundant.

Regards,
 Mark.

On 04/03/06, Jean-frederic Clere [EMAIL PROTECTED] wrote:
 Hi,

 There are a lot of objects in this repos directory, do we really need them?

 Cheers
 Jean-Frederic

--
Mark Hindess [EMAIL PROTECTED]
IBM Java Technology Centre, UK.

Re: enhanced/classlib/trunk/depends

[Jean-frederic Clere]

Mark Hindess wrote:


Using touch .now; sleep 2; (cd make; ant) ; find depends ... \!
-anewer .now on both builds shows that the only files that aren't
accessed by either build are the README files and:

 depends/files/java.security

That probably isn't needed since the build uses:

 modules/security/src/java.home/lib/security/java.security

instead.

But that's the only one that's obviously redundant.
 

Yep... I would prefer to classlib depends directory a readme that tells 
classlib depends on:

CU4C version 3.4 (how to get and install it).
ICU4JNI
FDLIBM
zlib

Cheers

Jean-Frederic


Regards,
Mark.

On 04/03/06, Jean-frederic Clere [EMAIL PROTECTED] wrote:
 


Hi,

There are a lot of objects in this repos directory, do we really need them?

Cheers
Jean-Frederic
   



--
Mark Hindess [EMAIL PROTECTED]
IBM Java Technology Centre, UK.

 

Re: enhanced/classlib/trunk/depends

[Geir Magnusson Jr]

It would be nicer if it was automated.  We'll evolve, but are trying to 
make it simple to get and build and play with.


Jean-frederic Clere wrote:

Mark Hindess wrote:


Using touch .now; sleep 2; (cd make; ant) ; find depends ... \!
-anewer .now on both builds shows that the only files that aren't
accessed by either build are the README files and:

 depends/files/java.security

That probably isn't needed since the build uses:

 modules/security/src/java.home/lib/security/java.security

instead.

But that's the only one that's obviously redundant.
 

Yep... I would prefer to classlib depends directory a readme that tells 
classlib depends on:

CU4C version 3.4 (how to get and install it).
ICU4JNI
FDLIBM
zlib

Cheers

Jean-Frederic


Regards,
Mark.

On 04/03/06, Jean-frederic Clere [EMAIL PROTECTED] wrote:
 


Hi,

There are a lot of objects in this repos directory, do we really need 
them?


Cheers
Jean-Frederic
  


--
Mark Hindess [EMAIL PROTECTED]
IBM Java Technology Centre, UK.