Re: svn commit: r407752 - in /incubator/harmony/enhanced/classlib/trunk/modules/luni/src: main/java/org/apache/harmony/luni/internal/net/www/protocol/http/HttpURLConnection.java
Stepan Mishura wrote:
Hi George,
On 5/19/06, George Harley wrote:
Stepan Mishura wrote:
[SNIP]
Hi Stepan,
Is your preference to separate out all remote server dependent tests
(that could be made work with a locally installed server) from the
normal test flow ?
Yes.
For instance, have them run in a separate junit batch
that was dependent on an Ant property value (e.g. run.net.tests) ?
Another possibility is to invoke the tests under discussion via a JUnit
TestSuite - again, perhaps depending on an Ant property.
Basically I want to be sure here that we are talking about a logical
separation of the tests using Ant and JUnit techniques and not a
physical separation of files in the file system.
We can separate them in any acceptable way. All I want that we clearly
define which tests require 'remote server' to be run and keep these test
separately from 'normal test flow'. For this particular case I believe
that
there is no need in 'remote server' and we can use local server stub.
Thanks,
Stepan.
Hi Stepan,
I agree that we can modify this test so that there is no need for a
remote server and that we can use something local. Jetty or equivalent
is a good basis for such local server stubs. It is fast, it is
lightweight, it can be started and stopped very simply from within Ant
(so that it only runs for the duration of a specified batch of unit
tests) and may also be completely controlled from Java test code so that
we can configure its behaviour for any test case from within that test
case. It's architecture means that we do not have to run it as a
complete web server but can stub out any aspect of its runtime behaviour
we wish in order to suit the purposes of the test(s).
I don't really understand why such network tests making use of a small,
embedded server running locally would need to be considered as outside
of the normal test flow.
Best regards,
George
Best regards,
George
Best regards,
George
Stepan Mishura wrote:
Richard, George
I'm not fan of tests that depend on network connection. Is it
necessary for
this test:
+ public void test_getOutputStream_afterConnection() throws
Exception {
+ URLConnection uc = new
URL(http://www.apache.org;).openConnectionhttp://www.apache.org
).openconnection/
();
+ uc.setDoOutput(true);
+ uc.connect();
+ assertNotNull(uc.getOutputStream());
+ }
Thanks,
Stepan Mishura
--
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r407752 - in /incubator/harmony/enhanced/classlib/trunk/modules/luni/src: main/java/org/apache/harmony/luni/internal/net/www/protocol/http/HttpURLConnection.java
Hi Mikhail
I didn't study details of net testing so I can not say for sure - I expect
that with some minor improvements the prototype can be used for most of
testing scenarios (I mean scenarios where a test opens connection and
optionally send/receive some message.)
Thanks,
Stepan.
On 5/19/06, Mikhail Loenko wrote:
Hi Stepan
how far the prototype from what is desired?
Thanks,
Mikhail
2006/5/19, Stepan Mishura [EMAIL PROTECTED]:
On 5/19/06, Stepan Mishura wrote:
Hi George,
see below
On 5/19/06, George Harley wrote:
Hi Stepan,
Yes, there is probably scope for adding some logic to this test
method
where - in the event of no network connection we write a message to
stderr and move on. An alternative is to provide for connections to
be
opened up against a server on the local machine. A couple of days
ago I
spent some time adding the small, lightweight (and Apache licensed)
Jetty server to the LUNI tests. In my local sandbox the LUNI
make/build.xml file the run.tests target was updated to start up
Jetty
-- run the LUNI tests -- stop Jetty. It worked fine apart from a
glitch I had getting the cgi-bin to work properly in Jetty.
Apparently
this is a fairly common problem when it is used on Windows. I'm
starting
to feel that it might be best to exclude the one or two cgi-bin
related
tests in the LUNI tests for now in the interests of bringing Jetty
on
board. It would certainly help get some more java.net tests up and
running and enable this particular test case to run without the need
for
a network connection. What do you think ?
I think that we should try to develop small local test server that
just
opens connection and optionally send/receive test message. There is a
prototype of such test server (see HARMONY-167) and but I didn't
integrate
it with tests yet.
Sorry, wrong JIRA number - see HARMONY-164
Thanks,
Stepan.
I would, of course, float the Jetty proposal on the dev list first
to
make sure we were all happy with the suggestion :-)
I'm OK only if we separate tests with Jetty from common test suite
run.
Thanks,
Stepan.
Best regards,
George
Stepan Mishura wrote:
Richard, George
I'm not fan of tests that depend on network connection. Is it
necessary for
this test:
+ public void test_getOutputStream_afterConnection() throws
Exception
{
+ URLConnection uc = new
URL(http://www.apache.org ).openConnectionhttp://www.apache.org
).openconnection/
();
+ uc.setDoOutput(true);
+ uc.connect();
+ assertNotNull( uc.getOutputStream());
+ }
Thanks,
Stepan Mishura
--
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r407752 - in /incubator/harmony/enhanced/classlib/trunk/modules/luni/src: main/java/org/apache/harmony/luni/internal/net/www/protocol/http/HttpURLConnection.java
Hi George,
On 5/19/06, George Harley wrote:
Stepan Mishura wrote:
[SNIP]
Hi Stepan,
Is your preference to separate out all remote server dependent tests
(that could be made work with a locally installed server) from the
normal test flow ?
Yes.
For instance, have them run in a separate junit batch
that was dependent on an Ant property value (e.g. run.net.tests) ?
Another possibility is to invoke the tests under discussion via a JUnit
TestSuite - again, perhaps depending on an Ant property.
Basically I want to be sure here that we are talking about a logical
separation of the tests using Ant and JUnit techniques and not a
physical separation of files in the file system.
We can separate them in any acceptable way. All I want that we clearly
define which tests require 'remote server' to be run and keep these test
separately from 'normal test flow'. For this particular case I believe that
there is no need in 'remote server' and we can use local server stub.
Thanks,
Stepan.
Best regards,
George
Best regards,
George
Stepan Mishura wrote:
Richard, George
I'm not fan of tests that depend on network connection. Is it
necessary for
this test:
+ public void test_getOutputStream_afterConnection() throws
Exception {
+ URLConnection uc = new
URL(http://www.apache.org;).openConnectionhttp://www.apache.org
).openconnection/
();
+ uc.setDoOutput(true);
+ uc.connect();
+ assertNotNull(uc.getOutputStream());
+ }
Thanks,
Stepan Mishura
--
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r407752 - in /incubator/harmony/enhanced/classlib/trunk/modules/luni/src: main/java/org/apache/harmony/luni/internal/net/www/protocol/http/HttpURLConnection.java
Richard, George
I'm not fan of tests that depend on network connection. Is it necessary for
this test:
+ public void test_getOutputStream_afterConnection() throws Exception {
+ URLConnection uc = new
URL(http://www.apache.org;).openConnectionhttp://www.apache.org;).openconnection/
();
+ uc.setDoOutput(true);
+ uc.connect();
+ assertNotNull(uc.getOutputStream());
+ }
Thanks,
Stepan Mishura
--
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r407752 - in /incubator/harmony/enhanced/classlib/trunk/modules/luni/src: main/java/org/apache/harmony/luni/internal/net/www/protocol/http/HttpURLConnection.java
Hi Stepan,
Yes, there is probably scope for adding some logic to this test method
where - in the event of no network connection we write a message to
stderr and move on. An alternative is to provide for connections to be
opened up against a server on the local machine. A couple of days ago I
spent some time adding the small, lightweight (and Apache licensed)
Jetty server to the LUNI tests. In my local sandbox the LUNI
make/build.xml file the run.tests target was updated to start up Jetty
-- run the LUNI tests -- stop Jetty. It worked fine apart from a
glitch I had getting the cgi-bin to work properly in Jetty. Apparently
this is a fairly common problem when it is used on Windows. I'm starting
to feel that it might be best to exclude the one or two cgi-bin related
tests in the LUNI tests for now in the interests of bringing Jetty on
board. It would certainly help get some more java.net tests up and
running and enable this particular test case to run without the need for
a network connection. What do you think ?
I would, of course, float the Jetty proposal on the dev list first to
make sure we were all happy with the suggestion :-)
Best regards,
George
Stepan Mishura wrote:
Richard, George
I'm not fan of tests that depend on network connection. Is it
necessary for
this test:
+ public void test_getOutputStream_afterConnection() throws Exception {
+ URLConnection uc = new
URL(http://www.apache.org;).openConnectionhttp://www.apache.org;).openconnection/
();
+ uc.setDoOutput(true);
+ uc.connect();
+ assertNotNull(uc.getOutputStream());
+ }
Thanks,
Stepan Mishura
--
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r407752 - in /incubator/harmony/enhanced/classlib/trunk/modules/luni/src: main/java/org/apache/harmony/luni/internal/net/www/protocol/http/HttpURLConnection.java
Hi George
Wasn't that you who strictly opposed logging to stderr ~3-5 months ago? :)
As I remember, you said that no one will read that stderr.
I think the tests we have here are kind of needing 'exotic' configuration,
and they should be separated and not included to the regular pre-commit run.
Thanks,
Mikhail
2006/5/19, George Harley [EMAIL PROTECTED]:
Hi Stepan,
Yes, there is probably scope for adding some logic to this test method
where - in the event of no network connection we write a message to
stderr and move on. An alternative is to provide for connections to be
opened up against a server on the local machine. A couple of days ago I
spent some time adding the small, lightweight (and Apache licensed)
Jetty server to the LUNI tests. In my local sandbox the LUNI
make/build.xml file the run.tests target was updated to start up Jetty
-- run the LUNI tests -- stop Jetty. It worked fine apart from a
glitch I had getting the cgi-bin to work properly in Jetty. Apparently
this is a fairly common problem when it is used on Windows. I'm starting
to feel that it might be best to exclude the one or two cgi-bin related
tests in the LUNI tests for now in the interests of bringing Jetty on
board. It would certainly help get some more java.net tests up and
running and enable this particular test case to run without the need for
a network connection. What do you think ?
I would, of course, float the Jetty proposal on the dev list first to
make sure we were all happy with the suggestion :-)
Best regards,
George
Stepan Mishura wrote:
Richard, George
I'm not fan of tests that depend on network connection. Is it
necessary for
this test:
+ public void test_getOutputStream_afterConnection() throws Exception {
+ URLConnection uc = new
URL(http://www.apache.org;).openConnectionhttp://www.apache.org;).openconnection/
();
+ uc.setDoOutput(true);
+ uc.connect();
+ assertNotNull(uc.getOutputStream());
+ }
Thanks,
Stepan Mishura
--
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r407752 - in /incubator/harmony/enhanced/classlib/trunk/modules/luni/src: main/java/org/apache/harmony/luni/internal/net/www/protocol/http/HttpURLConnection.java
Mikhail Loenko wrote:
Hi George
Wasn't that you who strictly opposed logging to stderr ~3-5 months
ago? :)
As I remember, you said that no one will read that stderr.
Hi Mikahil,
Did I say that ? :-)
Actually I still feel that way. That's why I would really rather that we
had a local lightweight server that would enable the test to run as
nature intended.
I think the tests we have here are kind of needing 'exotic'
configuration,
and they should be separated and not included to the regular
pre-commit run.
So, for instance, all tests that had a dependency on a remote server
would be run in a separate suite ? Would the introduction of a local
server such as Jetty - that would get started and stopped as part of the
normal test run - remove the need for something like that ?
I'm off to double check on what I have said in previous emails... :-)
Best regards,
George
Thanks,
Mikhail
2006/5/19, George Harley [EMAIL PROTECTED]:
Hi Stepan,
Yes, there is probably scope for adding some logic to this test method
where - in the event of no network connection we write a message to
stderr and move on. An alternative is to provide for connections to be
opened up against a server on the local machine. A couple of days ago I
spent some time adding the small, lightweight (and Apache licensed)
Jetty server to the LUNI tests. In my local sandbox the LUNI
make/build.xml file the run.tests target was updated to start up Jetty
-- run the LUNI tests -- stop Jetty. It worked fine apart from a
glitch I had getting the cgi-bin to work properly in Jetty. Apparently
this is a fairly common problem when it is used on Windows. I'm starting
to feel that it might be best to exclude the one or two cgi-bin related
tests in the LUNI tests for now in the interests of bringing Jetty on
board. It would certainly help get some more java.net tests up and
running and enable this particular test case to run without the need for
a network connection. What do you think ?
I would, of course, float the Jetty proposal on the dev list first to
make sure we were all happy with the suggestion :-)
Best regards,
George
Stepan Mishura wrote:
Richard, George
I'm not fan of tests that depend on network connection. Is it
necessary for
this test:
+ public void test_getOutputStream_afterConnection() throws
Exception {
+ URLConnection uc = new
URL(http://www.apache.org;).openConnectionhttp://www.apache.org;).openconnection/
();
+ uc.setDoOutput(true);
+ uc.connect();
+ assertNotNull(uc.getOutputStream());
+ }
Thanks,
Stepan Mishura
--
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r407752 - in /incubator/harmony/enhanced/classlib/trunk/modules/luni/src: main/java/org/apache/harmony/luni/internal/net/www/protocol/http/HttpURLConnection.java
Hi George,
see below
On 5/19/06, George Harley wrote:
Hi Stepan,
Yes, there is probably scope for adding some logic to this test method
where - in the event of no network connection we write a message to
stderr and move on. An alternative is to provide for connections to be
opened up against a server on the local machine. A couple of days ago I
spent some time adding the small, lightweight (and Apache licensed)
Jetty server to the LUNI tests. In my local sandbox the LUNI
make/build.xml file the run.tests target was updated to start up Jetty
-- run the LUNI tests -- stop Jetty. It worked fine apart from a
glitch I had getting the cgi-bin to work properly in Jetty. Apparently
this is a fairly common problem when it is used on Windows. I'm starting
to feel that it might be best to exclude the one or two cgi-bin related
tests in the LUNI tests for now in the interests of bringing Jetty on
board. It would certainly help get some more java.net tests up and
running and enable this particular test case to run without the need for
a network connection. What do you think ?
I think that we should try to develop small local test server that just
opens connection and optionally send/receive test message. There is a
prototype of such test server (see HARMONY-167) and but I didn't integrate
it with tests yet.
I would, of course, float the Jetty proposal on the dev list first to
make sure we were all happy with the suggestion :-)
I'm OK only if we separate tests with Jetty from common test suite run.
Thanks,
Stepan.
Best regards,
George
Stepan Mishura wrote:
Richard, George
I'm not fan of tests that depend on network connection. Is it
necessary for
this test:
+ public void test_getOutputStream_afterConnection() throws Exception {
+ URLConnection uc = new
URL(http://www.apache.org;).openConnectionhttp://www.apache.org
).openconnection/
();
+ uc.setDoOutput(true);
+ uc.connect();
+ assertNotNull(uc.getOutputStream());
+ }
Thanks,
Stepan Mishura
--
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--
Thanks,
Stepan Mishura
Intel Middleware Products Division
--
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r407752 - in /incubator/harmony/enhanced/classlib/trunk/modules/luni/src: main/java/org/apache/harmony/luni/internal/net/www/protocol/http/HttpURLConnection.java
On 5/19/06, Stepan Mishura wrote:
Hi George,
see below
On 5/19/06, George Harley wrote:
Hi Stepan,
Yes, there is probably scope for adding some logic to this test method
where - in the event of no network connection we write a message to
stderr and move on. An alternative is to provide for connections to be
opened up against a server on the local machine. A couple of days ago I
spent some time adding the small, lightweight (and Apache licensed)
Jetty server to the LUNI tests. In my local sandbox the LUNI
make/build.xml file the run.tests target was updated to start up Jetty
-- run the LUNI tests -- stop Jetty. It worked fine apart from a
glitch I had getting the cgi-bin to work properly in Jetty. Apparently
this is a fairly common problem when it is used on Windows. I'm starting
to feel that it might be best to exclude the one or two cgi-bin related
tests in the LUNI tests for now in the interests of bringing Jetty on
board. It would certainly help get some more java.net tests up and
running and enable this particular test case to run without the need for
a network connection. What do you think ?
I think that we should try to develop small local test server that just
opens connection and optionally send/receive test message. There is a
prototype of such test server (see HARMONY-167) and but I didn't integrate
it with tests yet.
Sorry, wrong JIRA number - see HARMONY-164
Thanks,
Stepan.
I would, of course, float the Jetty proposal on the dev list first to
make sure we were all happy with the suggestion :-)
I'm OK only if we separate tests with Jetty from common test suite run.
Thanks,
Stepan.
Best regards,
George
Stepan Mishura wrote:
Richard, George
I'm not fan of tests that depend on network connection. Is it
necessary for
this test:
+ public void test_getOutputStream_afterConnection() throws Exception
{
+ URLConnection uc = new
URL(http://www.apache.org ).openConnectionhttp://www.apache.org
).openconnection/
();
+ uc.setDoOutput(true);
+ uc.connect();
+ assertNotNull( uc.getOutputStream());
+ }
Thanks,
Stepan Mishura
--
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--
Thanks,
Stepan Mishura
Intel Middleware Products Division
--
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--
Thanks,
Stepan Mishura
Intel Middleware Products Division
--
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r407752 - in /incubator/harmony/enhanced/classlib/trunk/modules/luni/src: main/java/org/apache/harmony/luni/internal/net/www/protocol/http/HttpURLConnection.java
Hi Stepan
how far the prototype from what is desired?
Thanks,
Mikhail
2006/5/19, Stepan Mishura [EMAIL PROTECTED]:
On 5/19/06, Stepan Mishura wrote:
Hi George,
see below
On 5/19/06, George Harley wrote:
Hi Stepan,
Yes, there is probably scope for adding some logic to this test method
where - in the event of no network connection we write a message to
stderr and move on. An alternative is to provide for connections to be
opened up against a server on the local machine. A couple of days ago I
spent some time adding the small, lightweight (and Apache licensed)
Jetty server to the LUNI tests. In my local sandbox the LUNI
make/build.xml file the run.tests target was updated to start up Jetty
-- run the LUNI tests -- stop Jetty. It worked fine apart from a
glitch I had getting the cgi-bin to work properly in Jetty. Apparently
this is a fairly common problem when it is used on Windows. I'm starting
to feel that it might be best to exclude the one or two cgi-bin related
tests in the LUNI tests for now in the interests of bringing Jetty on
board. It would certainly help get some more java.net tests up and
running and enable this particular test case to run without the need for
a network connection. What do you think ?
I think that we should try to develop small local test server that just
opens connection and optionally send/receive test message. There is a
prototype of such test server (see HARMONY-167) and but I didn't integrate
it with tests yet.
Sorry, wrong JIRA number - see HARMONY-164
Thanks,
Stepan.
I would, of course, float the Jetty proposal on the dev list first to
make sure we were all happy with the suggestion :-)
I'm OK only if we separate tests with Jetty from common test suite run.
Thanks,
Stepan.
Best regards,
George
Stepan Mishura wrote:
Richard, George
I'm not fan of tests that depend on network connection. Is it
necessary for
this test:
+ public void test_getOutputStream_afterConnection() throws Exception
{
+ URLConnection uc = new
URL(http://www.apache.org ).openConnectionhttp://www.apache.org
).openconnection/
();
+ uc.setDoOutput(true);
+ uc.connect();
+ assertNotNull( uc.getOutputStream());
+ }
Thanks,
Stepan Mishura
--
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--
Thanks,
Stepan Mishura
Intel Middleware Products Division
--
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--
Thanks,
Stepan Mishura
Intel Middleware Products Division
--
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r407752 - in /incubator/harmony/enhanced/classlib/trunk/modules/luni/src: main/java/org/apache/harmony/luni/internal/net/www/protocol/http/HttpURLConnection.java
Stepan Mishura wrote:
Hi George,
see below
On 5/19/06, George Harley wrote:
Hi Stepan,
Yes, there is probably scope for adding some logic to this test method
where - in the event of no network connection we write a message to
stderr and move on. An alternative is to provide for connections to be
opened up against a server on the local machine. A couple of days ago I
spent some time adding the small, lightweight (and Apache licensed)
Jetty server to the LUNI tests. In my local sandbox the LUNI
make/build.xml file the run.tests target was updated to start up Jetty
-- run the LUNI tests -- stop Jetty. It worked fine apart from a
glitch I had getting the cgi-bin to work properly in Jetty. Apparently
this is a fairly common problem when it is used on Windows. I'm starting
to feel that it might be best to exclude the one or two cgi-bin related
tests in the LUNI tests for now in the interests of bringing Jetty on
board. It would certainly help get some more java.net tests up and
running and enable this particular test case to run without the need for
a network connection. What do you think ?
I think that we should try to develop small local test server that just
opens connection and optionally send/receive test message. There is a
prototype of such test server (see HARMONY-167) and but I didn't
integrate
it with tests yet.
I would, of course, float the Jetty proposal on the dev list first to
make sure we were all happy with the suggestion :-)
I'm OK only if we separate tests with Jetty from common test suite run.
Thanks,
Stepan.
Hi Stepan,
Is your preference to separate out all remote server dependent tests
(that could be made work with a locally installed server) from the
normal test flow ? For instance, have them run in a separate junit batch
that was dependent on an Ant property value (e.g. run.net.tests) ?
Another possibility is to invoke the tests under discussion via a JUnit
TestSuite - again, perhaps depending on an Ant property.
Basically I want to be sure here that we are talking about a logical
separation of the tests using Ant and JUnit techniques and not a
physical separation of files in the file system.
Best regards,
George
Best regards,
George
Stepan Mishura wrote:
Richard, George
I'm not fan of tests that depend on network connection. Is it
necessary for
this test:
+ public void test_getOutputStream_afterConnection() throws
Exception {
+ URLConnection uc = new
URL(http://www.apache.org;).openConnectionhttp://www.apache.org
).openconnection/
();
+ uc.setDoOutput(true);
+ uc.connect();
+ assertNotNull(uc.getOutputStream());
+ }
Thanks,
Stepan Mishura
--
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
