Re: [PHP-DEV] php-src is now on git

[Christopher Jones]

On 03/19/2012 03:26 PM, Kris Craig wrote:

On Mon, Mar 19, 2012 at 3:07 PM, Christopher Jones<
christopher.jo...@oracle.com>  wrote:




On 03/19/2012 01:31 PM, Kris Craig wrote:


Here's what I wound-up doing: The merge entries on the workflow page now
contain "--no-ff" and I added an entry to the FAQ about the merge.ff option
available in newer clients. This way we should be covered either way. =)
--Kris



Is this supported by the php-src repo?  This is what I get after using
--no-ff:

$ git push origin
To 
https://git.php.net/**repository/php-src.git
  ! [rejected]PHP-5.3 ->  PHP-5.3 (non-fast-forward)
  ! [rejected]PHP-5.4 ->  PHP-5.4 (non-fast-forward)
  ! [rejected]master ->  master (non-fast-forward)
error: failed to push some refs to 'https://git.php.net/**
repository/php-src.git'
To prevent you from losing history, non-fast-forward updates were rejected
Merge the remote changes (e.g. 'git pull') before pushing again.  See the
'Note about fast-forwards' section of 'git push --help' for details.


--
Email: christopher.jo...@oracle.com
Tel:  +1 650 506 8630
Blog:  http://blogs.oracle.com/opal/



That error can sometimes be misleading.  I've noticed that it typically
happens if you're trying to push a branch containing merged commits to a
remote version of that branch that is newer than the one your commits were
merged into (i.e. you forgot to do a git pull followed by a git rebase
before doing the merge).  I can't say for certain but that's a likely
possibility that that's what happened in your case.


Could be.  Thanks for the details.

Chris


--
Email: christopher.jo...@oracle.com
Tel:  +1 650 506 8630
Blog:  http://blogs.oracle.com/opal/

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] php-src is now on git

[Kris Craig]

On Mon, Mar 19, 2012 at 4:03 PM, Ferenc Kovacs  wrote:

>
>> Specifically, I noticed the "SSH Key" field in user administration (is
>> that
>> new or was that always there?).
>
>
> https://wiki.php.net/vcs/gitfaq#using_ssh
>
> --
> Ferenc Kovács
> @Tyr43l - http://tyrael.hu
>

Lol yep that's where I found it!  What I'm asking though is whether this
should be the *recommended* approach on the workflow page.  I.e. are there
any potential problems with having too many people using the SSH login at
once, for example?

--Kris

Re: [PHP-DEV] php-src is now on git

[Ferenc Kovacs]

>
>
> Specifically, I noticed the "SSH Key" field in user administration (is that
> new or was that always there?).


https://wiki.php.net/vcs/gitfaq#using_ssh

-- 
Ferenc Kovács
@Tyr43l - http://tyrael.hu

Re: [PHP-DEV] php-src is now on git

[Kris Craig]

Question:

On Mon, Mar 19, 2012 at 2:01 PM, Kris Craig  wrote:

>
>
> On Mon, Mar 19, 2012 at 1:39 PM, Christopher Jones <
> christopher.jo...@oracle.com> wrote:
>
>>
>>
>> On 03/19/2012 01:31 PM, Kris Craig wrote:
>>
>>>  I added an entry to the FAQ about the merge.ff option
>>> available in newer clients.
>>>
>>
>> Would it be more visible if that comment was moved to the Recommended Git
>> Settings section?
>>
>>
>> Chris
>>
>> --
>> Email: christopher.jo...@oracle.com
>> Tel:  +1 650 506 8630
>> Blog:  http://blogs.oracle.com/opal/
>>
>>
> Hmm good idea, I'll move it there and mention the client version
> requirement (tnx for looking that up, Gábor!).
>
> --Kris
>
>
Regarding the recommended method for using git clone, after a little
tinkering I realized that I do, in fact, have SSH access for Git-- Or, to
be more precise, I didn't have access but I had the ability to make it so
that I did.

Specifically, I noticed the "SSH Key" field in user administration (is that
new or was that always there?).  By using ssh-keygen and adding the
newly-generated public key to that field in my php.net user account, I was
able to successfully perform a git clone using g...@git.php.net:php-src.git.

So here's my question:  Assuming everyone with SVN karma can do this as
well, is there any cost that would make it undesirable for us to recommend
wide use of this?  I.e. I remember somebody mentioning something about
limited SSH ports available.  Could you elaborate on that?

If it is doable, then I'd recommend scrapping my previous suggestion and
going with the SSH option (though still mentioning the https one as an
lighter-weight alternative) and also adding a brief section on how to
configure add/configure the necessary keys to make it work.  Again I'm more
than happy to do the heavy lifting on actually updating the docs; I just
want to make sure we're all on the same page before I do.


Thanks!  =)

--Kris

Re: [PHP-DEV] php-src is now on git

[Kris Craig]

On Mon, Mar 19, 2012 at 3:07 PM, Christopher Jones <
christopher.jo...@oracle.com> wrote:

>
>
> On 03/19/2012 01:31 PM, Kris Craig wrote:
>
>> Here's what I wound-up doing: The merge entries on the workflow page now
>> contain "--no-ff" and I added an entry to the FAQ about the merge.ff option
>> available in newer clients. This way we should be covered either way. =)
>> --Kris
>>
>
> Is this supported by the php-src repo?  This is what I get after using
> --no-ff:
>
> $ git push origin
> To 
> https://git.php.net/**repository/php-src.git
>  ! [rejected]PHP-5.3 -> PHP-5.3 (non-fast-forward)
>  ! [rejected]PHP-5.4 -> PHP-5.4 (non-fast-forward)
>  ! [rejected]master -> master (non-fast-forward)
> error: failed to push some refs to 'https://git.php.net/**
> repository/php-src.git '
> To prevent you from losing history, non-fast-forward updates were rejected
> Merge the remote changes (e.g. 'git pull') before pushing again.  See the
> 'Note about fast-forwards' section of 'git push --help' for details.
>
>
> --
> Email: christopher.jo...@oracle.com
> Tel:  +1 650 506 8630
> Blog:  http://blogs.oracle.com/opal/
>
>
That error can sometimes be misleading.  I've noticed that it typically
happens if you're trying to push a branch containing merged commits to a
remote version of that branch that is newer than the one your commits were
merged into (i.e. you forgot to do a git pull followed by a git rebase
before doing the merge).  I can't say for certain but that's a likely
possibility that that's what happened in your case.

Moving forward, we should probably add that to the workflow as it can save
a lot of headaches moving forward.  Specifically, when merging in a branch:


   1. git checkout 
   2. git pull [destination branch]
   3. git checkout 
   4. git rebase 
   5. git checkout 
   6. git merge --no-ff 
   7. git push origin [destination branch]
   8. git branch -d 

What often happens is that you'll pull a branch then start working on a
feature branch.  However, while you're doing that, somebody else pushes a
newer version of the branch you pulled.  If you then merge into the older
"revision" of that branch without first making sure it's up-to-date,
everything will blow up in your face when you try to do a push.  Despite
the migraines this tends to cause, it's actually a good thing that it does
this.  After all, we don't *want* an older version of a branch being dumped
on top of a newer version.  That would get very ugly lol.  The only
downside is that the resulting error message when using --no-ff is
needlessly confusing for newcomers.

Assuming that's what happened in your case, you've got some damage control
to do.  Whenever I'm training people in the office on using Git and they
make this inevitable mistake, I always tell them to think of the damage
control as good practice lol.  =)

Anyway, assuming you haven't yet deleted the original feature branch, this
will be really easy:


   1. git checkout -b  
  - Creates a backup copy of the outdated branch with the merges.
   2. git branch -D 
  - Deletes the corrupted branch.  Note that uppercase "-D" is required
  since this is considered an "unsafe" delete.
   3. git checkout -b  origin/
  - Re-creates the branch you just deleted, this time just grabbing the
  one currently on the remote origin.
   4. git checkout 
  - Checkout the feature branch that you originally merged into the
  develop branch.
   5. git rebase 
  - Your feature branch will now be based off of the current develop
  branch that you just pulled from the remote origin.
   6. git checkout 
   7. git merge --no-ff 
  - Merge the newly-rebased feature branch into this branch.
   8. git push origin [corrupted branch name]
  - Now your push should be successful.


I hope that helps!  =)

--Kris

Re: [PHP-DEV] php-src is now on git

[Christopher Jones]

On 03/19/2012 01:31 PM, Kris Craig wrote:
Here's what I wound-up doing: The merge entries on the workflow page now contain "--no-ff" and I added an entry to the FAQ about the merge.ff option available in newer clients. This way we should be covered either way. =) --Kris 


Is this supported by the php-src repo?  This is what I get after using --no-ff:

$ git push origin
To https://git.php.net/repository/php-src.git
 ! [rejected]PHP-5.3 -> PHP-5.3 (non-fast-forward)
 ! [rejected]PHP-5.4 -> PHP-5.4 (non-fast-forward)
 ! [rejected]master -> master (non-fast-forward)
error: failed to push some refs to 'https://git.php.net/repository/php-src.git'
To prevent you from losing history, non-fast-forward updates were rejected
Merge the remote changes (e.g. 'git pull') before pushing again.  See the
'Note about fast-forwards' section of 'git push --help' for details.

--
Email: christopher.jo...@oracle.com
Tel:  +1 650 506 8630
Blog:  http://blogs.oracle.com/opal/


--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] i hope using set_exception_handler and set_error_handler in php extension code.

[Richard Lynch]

On Fri, March 16, 2012 8:33 pm, langwan wrote:
> i hope using set_exception_handler and set_error_handler in php
> extension
> code.
> hi, all:
>
> i write php monitor extension now.
>
> 1. question
>
> i hope using set_exception_handler or set_error_handler in
> PHP_RINIT_FUNCTION()
>
> for example:
>
> PHP_RINIT_FUNCTION(my)
> {
> set_exception_handler(my_exception_handler);
> }
>
> please help me.

You need to separate PHP userland functions (http://php.net/) from C
functions in core/extensions (http://lxr.php.net/)

Find the C source for PHP set_exception_handler in LXR, and see what
it calls.  Then call the same thing.

> 2. question
>
> i hope print $e->getMessage() info in
> PHP_FUNCTION(my_exception_handler).

You'll have to find the Exception structure somewhere in the guts of
try/catch implementation, probably tied to the yacc (bison?) (I
forget) code that gets turned into the basic syntax.

There should be some kind of base Exception struct somewhere in there,
that will probably have a "message" element.

You're trying to write an extension in C.  You'll have to find the
underlying C function for any PHP function, and figure out enough
about how it works to re-tool it to your needs.

Hope that helps.

PS
I am *so* not an expert, but I stumbled my way through writing a
sample extension once.


-- 
brain cancer update:
http://richardlynch.blogspot.com/search/label/brain%20tumor
Donate:
https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=FS9NLTNEEKWBE



-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: [PHP-CVS] [git] commit php-src.git: UPGRADING

[David Soria Parra]

On 2012-03-19, Michael Wallner  wrote:
> Shouldn't the commit mails reference the push mail?
> Looks a bit messy without relations of commit/push mails.
>

they should, it's just not working yet. I will look into it.

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] PHP5.4 'nannying'

[Richard Lynch]

On Sun, March 18, 2012 6:35 am, Reindl Harald wrote:
>
>
> Am 18.03.2012 10:14, schrieb Lester Caine:
>> I think what I am probably looking for is a clean guide as to how
>> code SHOULD be written nowadays in order to avoid
>> the nanny messages since it's certainly not my normal practice after
>> 10 years of coding in PHP5 ...

I once worked with a team that didn't believe in E_NOTICE...

I turned it on, and flooded the logs on a shard DEV.

I turned it off.  Copied the source to my own box, ran it with
E_NOTICE, did some grep/sed/awk mumbo-jumbo to find the most common
messages, fixed those, and committed them.

And found, corrected, and closed about 5 long-standing bugs in the
process.

They started to think maybe I was on to something here... :-)

We turned E_NOTICE back on at that point, as it was only an odd script
once in a while that went to the logs.  Or new code from that one guy
who still didn't quite "get" it for awhile... He came around after we
fixed a couple of his newly-introduced bugs that were triggering
E_NOTICE...

-- 
brain cancer update:
http://richardlynch.blogspot.com/search/label/brain%20tumor
Donate:
https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=FS9NLTNEEKWBE



-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] php-src is now on git

[Kris Craig]

On Mon, Mar 19, 2012 at 1:39 PM, Christopher Jones <
christopher.jo...@oracle.com> wrote:

>
>
> On 03/19/2012 01:31 PM, Kris Craig wrote:
>
>>  I added an entry to the FAQ about the merge.ff option
>> available in newer clients.
>>
>
> Would it be more visible if that comment was moved to the Recommended Git
> Settings section?
>
>
> Chris
>
> --
> Email: christopher.jo...@oracle.com
> Tel:  +1 650 506 8630
> Blog:  http://blogs.oracle.com/opal/
>
>
Hmm good idea, I'll move it there and mention the client version
requirement (tnx for looking that up, Gábor!).

--Kris

[PHP-DEV] Re: [PHP-CVS] [git] commit php-src.git: ext/hash/tests/mhash_001.phpt ext/hash/tests/mhash_003.phpt

[Michael Wallner]

Should the commit to bugs.php.net hook already work?
A link was obviously added to the commit message, but the bug was not commented.

Just in case...

On 19 March 2012 22:04, Michael Wallner  wrote:
> Commit: 260e77709ddfe9e72e2b7f11393673b6ee18a7f9
> Author: Michael Wallner(m...@php.net)         Mon, 19 Mar 2012 21:49:47 +0100
> Committer: Michael Wallner(m...@php.net)      Mon, 19 Mar 2012 21:49:47 +0100
> Parents: 867d980574ec8086cc40634fbd62af257504b8ea
>
> Link: 
> http://git.php.net/?p=php-src.git;a=commitdiff;h=260e77709ddfe9e72e2b7f11393673b6ee18a7f9
>
> Log:
> fix tests failing due to corrected hash tiger
>
> mhash_00{1,3}.phpt were failing because of the corrected hash tiger byte
> output order
>
> fixes bug #60922:
>  tests fail for mhash() and mhash_keygen_s2k() functions and MHASH_TIGER
>
> Bugs:
> https://bugs.php.net/60922
>
> Changed paths:
>  M  ext/hash/tests/mhash_001.phpt
>  M  ext/hash/tests/mhash_003.phpt
>
>
> Diff:
> 260e77709ddfe9e72e2b7f11393673b6ee18a7f9
> diff --git a/ext/hash/tests/mhash_001.phpt b/ext/hash/tests/mhash_001.phpt
> index 5df0378..e8aac9b 100644
> --- a/ext/hash/tests/mhash_001.phpt
> +++ b/ext/hash/tests/mhash_001.phpt
> @@ -16,7 +16,7 @@ $supported_hash_al = array(
>  "MHASH_HAVAL160"  => "c6b36f87750b18576981bc17b4f22271947bf9cb",
>  "MHASH_RIPEMD160" => "6c47435aa1d359c4b7c6af46349f0c3e1258583d",
>  "MHASH_GOST"      => 
> "101b0a2552cebdf5137cadf15147f21e55b6432935bb9c2c03c7e28d188b2d9e",
> -"MHASH_TIGER"     => "fdb9019a79c33a95677e2097abae91eb0de00b3054bb5c39",
> +"MHASH_TIGER"     => "953ac3799a01b9fdeb91aeab97207e67395cbb54300be00d",
>  "MHASH_CRC32"     => "83041db8",
>  "MHASH_CRC32B"    => "df5ab7a4"
>  );
> diff --git a/ext/hash/tests/mhash_003.phpt b/ext/hash/tests/mhash_003.phpt
> index 7dcf247..38d1a8b 100644
> --- a/ext/hash/tests/mhash_003.phpt
> +++ b/ext/hash/tests/mhash_003.phpt
> @@ -16,7 +16,7 @@ $supported_hash_al = array(
>  "MHASH_HAVAL160"   => 
> "d6e5f0ef07f3facced646eedb6364758ecde6dc6fb061e00a496f5ceb723f78ea135884d9682226ded69c11d8431240ef97cad583c4f29593bbf3dd3cab0b8792eb3d86022ca6002ebd0d9b4429909d4af85bed2b5a96b3e47b9b8cac919c1177ec40d7e",
>  "MHASH_RIPEMD160"  => 
> "e4d5db469af29f78e2b90dc735c9cf020a1d5b19a6674458677794d4dca144d426c562aff98d8e866a8a924299ebf6b0ea9a1637f987a1fb5de9b647edc35b1447605e1babc3084be7a003931117eb33432d4142e225df044b033f3ff64bb4a18682a4f9",
>  "MHASH_GOST"       => 
> "c044f669bd7e8643953d77c682fd179242d9df157dadf873be4d9601e4647c018234689359e7220ab0492a6240d184c478634073dea87f79be7f86fd4e2564f7d709b68a46440a121250e00fc7d57d45a9c07ee23a704ff4148c0dad7077ec527b194d87",
> -"MHASH_TIGER"      => 
> "67eac97b9dca0a47b1f6262f330264e4ce1c233760fe3255f642512fd3127929baccf1e758236b2768a4c2c0c06e118b19e40e2f04a5f745820fb8a99bdbc00698702a4d3120171856c4c94bda79ba1b4f60d509d7f8954da818a29797368dd47c1122aa",
> +"MHASH_TIGER"      => 
> "470aca9d7bc9ea67e46402332f26f6b15532fe6037231cce297912d32f5142f6276b2358e7f1ccba8b116ec0c0c2a46845f7a5042f0ee41906c0db9ba9b80f82181720314d2a70981bba79da4bc9c4564d95f8d709d5604fd48d369797a218a862196f48",
>  "MHASH_CRC32"      => 
> "481c40148c26185f9a59ef18e86f51c5d2d0315b46711d22ae08c1ccdd669fe956c817380815e3a545f6ee453c9da48d1d994dbc3ac8ba85a572108412f06b2a16b1489cda75b118e82f7d9bdfdb68336957bbf19e4a3f76750d6985a53dd557229dfcf3",
>  "MHASH_CRC32B"     => 
> "65ab6cb5fb7d3ea67f5da92a9bd746b6628a13368fcbcd43af49092e9c6a960fd030a5ce3c1f0ddb512ec698be96e77969748db66278b0fd837d24d8c898f50bd70993b48cc8accf4b44c54431e91385ddf04c7560a1a7368fc9e6f763457c90b07f04f1"
>  );
>
>
> --
> PHP CVS Mailing List (http://www.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
>



-- 
Regards,
Mike

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] TSRMLS_* keywords in PHP source

[Richard Lynch]

On Mon, March 19, 2012 2:45 pm, Barbu Paul Gheorghe wrote:
> What role does the keywords TSRMLS_CC, TSRMLS_DC, TSRMLS_D have when
> passed
> along with a argument in PHP's source?
> For example in this random file:
>
> http://lxr.php.net/opengrok/xref/PHP_5_4/ext/intl/formatter/formatter_data.c
>
>
> I don't even know if "keyword" is the right technical term for it
> because it's
> the first time I see this kind of call in C:

It's a macro.

You can find it in the zend / tsrm files.

If I recall correctly the _CC and _DC and _D have to do with whether
you need a comma (,) after the macro or not...

It's been awhile, so don't quote me on that.

-- 
brain cancer update:
http://richardlynch.blogspot.com/search/label/brain%20tumor
Donate:
https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=FS9NLTNEEKWBE



-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] php-src is now on git

[Gábor Fási]

On Mon, Mar 19, 2012 at 21:31, Kris Craig  wrote:
> I don't know off the top of my head which version it was implemented in,
> but I'm pretty sure it was relatively recent.

It was introduced in 1.7.6, that came out around Summer 2011.

-- Gábor

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] php-src is now on git

[Christopher Jones]

On 03/19/2012 01:31 PM, Kris Craig wrote:

  I added an entry to the FAQ about the merge.ff option
available in newer clients.


Would it be more visible if that comment was moved to the Recommended Git 
Settings section?

Chris

--
Email: christopher.jo...@oracle.com
Tel:  +1 650 506 8630
Blog:  http://blogs.oracle.com/opal/

Re: [PHP-DEV] php-src is now on git

[Kris Craig]

On Mon, Mar 19, 2012 at 1:16 PM, Simon Schick
wrote:

> 2012/3/19 Kris Craig :
> > Simon,
> >
> > Yes that's a great recommendation and it should definitely be included
> > IMHO!  However, the merge.ff option is relatively new and is not
> available
> > in many older Git clients that are still in use.  So the --no-ff tag will
> > still probably be necessary for some people.  Perhaps we should recommend
> > both, or would that make things too confusing?
> >
> > --Kris
> >
>
> Hi, Kris
>
> Don't really know ... Do you know which version of GIT is the first
> who implements this feature? Would it be a problem to require an
> update or the people should find their own solution?
> I think that people who don't know much about GIT or are just starting
> with GIT should be fine with that as they haven't done much with that
> or just installed the latest version.
> The only problem I can see here is that some linux-distributions
> (Debian for example) tends to keep old versions in their repositories
> ;) Anyways ...
> I think it would be max-information to link the
> stackoverflow-discussion there if someone has a question to that. But
> this (of course) has to be describe it in a easy understandable way :)
> and I think that's the most dificult part.
>
> Bye
> Simon
>

I don't know off the top of my head which version it was implemented in,
but I'm pretty sure it was relatively recent.

Here's what I wound-up doing:  The merge entries on the workflow page now
contain "--no-ff" and I added an entry to the FAQ about the merge.ff option
available in newer clients.  This way we should be covered either way.  =)

--Kris

Re: [PHP-DEV] php-src is now on git

[David Soria Parra]

On 2012-03-19, Kris Craig  wrote:
> --f46d043892b5b345eb04bb9cfe02
> Content-Type: text/plain; charset=ISO-8859-1
>
> Hey Chris,
>
> On Mon, Mar 19, 2012 at 11:40 AM, Christopher Jones <
> christopher.jo...@oracle.com> wrote:
> I sense your hostility but I think you misunderstood my question.  The
> workflow page currently recommends the "git:" one for cloning (which
> doesn't work for me, either).  I think it should be changed to "https://";,
> and I fully intend on making the change myself but first I wanted to ask
> here to make sure there wasn't a reason why they went with "git:" instead
> (i.e. I don't want to step on anybody's toes).

git:// is recommended when you can use it. The access is limited due to
port limiations, but the protocl itself is superior to https for
the purpose.

http is a fallback when you cannot use ssh (developers only) or git

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] php-src is now on git

[Simon Schick]

2012/3/19 Kris Craig :
> Simon,
>
> Yes that's a great recommendation and it should definitely be included
> IMHO!  However, the merge.ff option is relatively new and is not available
> in many older Git clients that are still in use.  So the --no-ff tag will
> still probably be necessary for some people.  Perhaps we should recommend
> both, or would that make things too confusing?
>
> --Kris
>

Hi, Kris

Don't really know ... Do you know which version of GIT is the first
who implements this feature? Would it be a problem to require an
update or the people should find their own solution?
I think that people who don't know much about GIT or are just starting
with GIT should be fine with that as they haven't done much with that
or just installed the latest version.
The only problem I can see here is that some linux-distributions
(Debian for example) tends to keep old versions in their repositories
;) Anyways ...
I think it would be max-information to link the
stackoverflow-discussion there if someone has a question to that. But
this (of course) has to be describe it in a easy understandable way :)
and I think that's the most dificult part.

Bye
Simon

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Antw.: [PHP-DEV] php-src is now on git

[dso...@gmx.net]

Its a good idea. Go ahead and change it.

Gesendet mit meinem HTC

- Reply message -
Von: "Kris Craig" 
An: "Simon Schick" 
Cc: "David Soria Parra" , 
Betreff: [PHP-DEV] php-src is now on git
Datum: Mo., Mär. 19, 2012 19:58


Simon,

On Mon, Mar 19, 2012 at 11:55 AM, Simon Schick
wrote:

> 2012/3/19 Kris Craig :
> > Hey,
> >
> > Could we modify the workflow to recommend using the "--no-ff" switch when
> > merging in a feature branch?  This is by and large the recommended
> approach
> > as it preserves the feature branch's commit history, making it
> > *much*easier to sort through complex features that contain numerous
> > commits.
> >
> > --Kris
>
> Hi, Kris
>
> I'd instead suggest to execute the following command in the git-repository:
>
> git config --add merge.ff false
>
> Then you do not have to add --no-ff to every merge-command you're doing.
>
> You could even set it per branch if you want :) (just to round it up ..)
>
> http://stackoverflow.com/questions/2500296/can-i-make-fast-forwarding-be-off-by-default-in-git
>
> Bye
> Simon
>

Yes that's a great recommendation and it should definitely be included
IMHO!  However, the merge.ff option is relatively new and is not available
in many older Git clients that are still in use.  So the --no-ff tag will
still probably be necessary for some people.  Perhaps we should recommend
both, or would that make things too confusing?

--Kris

Re: [PHP-DEV] TSRMLS_* keywords in PHP source

[Jelle Zijlstra]

Those are macros that are defined only if PHP's Thread-Safe Resource
Manager is enabled at compile time; it passes in additional information
needed by the TSRM.

2012/3/19 Barbu Paul Gheorghe 

> Hello!
>
> What role does the keywords TSRMLS_CC, TSRMLS_DC, TSRMLS_D have when
> passed along with a argument in PHP's source?
> For example in this random file:
>
> http://lxr.php.net/opengrok/**xref/PHP_5_4/ext/intl/**
> formatter/formatter_data.c
>
>
> I don't even know if "keyword" is the right technical term for it because
> it's the first time I see this kind of call in C:
>
> foo(data_type variable_name "keyword");
>
> --
> Barbu Paul - Gheorghe
> Common sense is not so common - Voltaire
> Visit My GitHub profile to see my open-source projects -
> https://github.com/paullik
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

[PHP-DEV] TSRMLS_* keywords in PHP source

[Barbu Paul Gheorghe]

Hello!

What role does the keywords TSRMLS_CC, TSRMLS_DC, TSRMLS_D have when passed 
along with a argument in PHP's source?

For example in this random file:

http://lxr.php.net/opengrok/xref/PHP_5_4/ext/intl/formatter/formatter_data.c


I don't even know if "keyword" is the right technical term for it because it's 
the first time I see this kind of call in C:


foo(data_type variable_name "keyword");

--
Barbu Paul - Gheorghe
Common sense is not so common - Voltaire
Visit My GitHub profile to see my open-source projects - 
https://github.com/paullik

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] php-src is now on git

[Alexander Moskaliov]

I think we can add it now, because we have  already  moved to git all web
sources.
With regards, Alexander Moskaliov
ir...@irker.net


2012/3/19 Christopher Jones 

> Do you want to add it back (now or as appropriate), mentioning webprojects
> & documentation?

[PHP-DEV] Re: [PHP-CVS] [git] commit php-src.git: UPGRADING

[Michael Wallner]

Shouldn't the commit mails reference the push mail?
Looks a bit messy without relations of commit/push mails.

On 19 March 2012 20:33, Michael Wallner  wrote:
> Commit: 867d980574ec8086cc40634fbd62af257504b8ea
> Author: Michael Wallner(m...@php.net)         Mon, 19 Mar 2012 20:15:54 +0100
> Committer: Michael Wallner(m...@php.net)      Mon, 19 Mar 2012 20:15:54 +0100
> Parents: f5f5ca5d77cfe47b9556b3cc37fbf9605b822e5c
>
> Link: 
> http://git.php.net/?p=php-src.git;a=commitdiff;h=867d980574ec8086cc40634fbd62af257504b8ea
>
> Log:
> add note about corrected tiger hash output
>
> Changed paths:
>  M  UPGRADING
>
>
> Diff:
> 867d980574ec8086cc40634fbd62af257504b8ea
> diff --git a/UPGRADING b/UPGRADING
> index bbc5478..d92e057 100755
> --- a/UPGRADING
> +++ b/UPGRADING
> @@ -467,6 +467,10 @@ b. Extensions with changed behavior
>        is set with date.timezone and/or date_default_timezone_set().
>        Instead it will always fall back to "UTC".
>
> +   - Hash extension
> +     - the output of the tiger hash family has been corrected, see
> +       https://bugs.php.net/61307
> +
>  ===
>  10. Changes in SAPI support
>  ===
>
>
> --
> PHP CVS Mailing List (http://www.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
>



-- 
Regards,
Mike

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] php-src is now on git

[Kris Craig]

FYI-

On Mon, Mar 19, 2012 at 8:24 AM, David Soria Parra  wrote:

> Hi Internals,
>
> The initial migration is done and initial testing was successful.
>
>  http://git.php.net/?p=php-src.git;a=summary
>  http://github.com/php/php-src
>
> Please note that some branches and tags were renamed to make
> the repository cleaner.
>
> Please checkout the repository and play around. I have created
> a workflow wiki page at https://wiki.php.net/vcs/gitworkflow.
> There is also an FAQ at https://wiki.php.net/vcs/gitfaq.
>
> If you have questions about the workflow or problems let me know.
> General git questions should be asked in the appropriate IRC channels
> and mailinglists.
>
> David
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>
If you don't already have Git installed on your system and aren't sure
how/where to get it, I added a list on the FAQ for all major operating
systems.

--Kris

Re: [PHP-DEV] php-src is now on git

[Kris Craig]

Simon,

On Mon, Mar 19, 2012 at 11:55 AM, Simon Schick
wrote:

> 2012/3/19 Kris Craig :
> > Hey,
> >
> > Could we modify the workflow to recommend using the "--no-ff" switch when
> > merging in a feature branch?  This is by and large the recommended
> approach
> > as it preserves the feature branch's commit history, making it
> > *much*easier to sort through complex features that contain numerous
> > commits.
> >
> > --Kris
>
> Hi, Kris
>
> I'd instead suggest to execute the following command in the git-repository:
>
> git config --add merge.ff false
>
> Then you do not have to add --no-ff to every merge-command you're doing.
>
> You could even set it per branch if you want :) (just to round it up ..)
>
> http://stackoverflow.com/questions/2500296/can-i-make-fast-forwarding-be-off-by-default-in-git
>
> Bye
> Simon
>

Yes that's a great recommendation and it should definitely be included
IMHO!  However, the merge.ff option is relatively new and is not available
in many older Git clients that are still in use.  So the --no-ff tag will
still probably be necessary for some people.  Perhaps we should recommend
both, or would that make things too confusing?

--Kris

Re: [PHP-DEV] php-src is now on git

[Simon Schick]

2012/3/19 Kris Craig :
> Hey,
>
> Could we modify the workflow to recommend using the "--no-ff" switch when
> merging in a feature branch?  This is by and large the recommended approach
> as it preserves the feature branch's commit history, making it
> *much*easier to sort through complex features that contain numerous
> commits.
>
> --Kris

Hi, Kris

I'd instead suggest to execute the following command in the git-repository:

git config --add merge.ff false

Then you do not have to add --no-ff to every merge-command you're doing.

You could even set it per branch if you want :) (just to round it up ..)
http://stackoverflow.com/questions/2500296/can-i-make-fast-forwarding-be-off-by-default-in-git

Bye
Simon

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] php-src is now on git

[Christopher Jones]

On 03/19/2012 11:46 AM, Alexander Moskaliov wrote:

Really it was a mistake to do this option recommended (I did it =)). But I 
think for webprojects and documentation will need to mention this option.

With regards, Alexander Moskaliov
ir...@irker.net 


Do you want to add it back (now or as appropriate), mentioning webprojects & 
documentation?

Chris

--
Email: christopher.jo...@oracle.com
Tel:  +1 650 506 8630
Blog:  http://blogs.oracle.com/opal/

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] php-src is now on git

[Kris Craig]

On Mon, Mar 19, 2012 at 11:46 AM, Alexander Moskaliov wrote:

> Really it was a mistake to do this option recommended (I did it =)). But
> I think for webprojects and documentation will need to mention this option.
>
> With regards, Alexander Moskaliov
> ir...@irker.net
>
>
> 2012/3/19 Christopher Jones 
>
> >
> >
> > On 03/19/2012 10:19 AM, David Soria Parra wrote:
> >
> >  Also a small thing - gitfaq recommends git config core.autocrlf
> >>> input, but we have some files in win32 which do not work with this
> >>> setting (at least on my Mac).
> >>>
> >>
> >> ah okay, can you remove it please? Thanks
> >>
> >
> > Done.
> >
> > --
> > Email: christopher.jo...@oracle.com
> > Tel:  +1 650 506 8630
> > Blog:  http://blogs.oracle.com/opal/
> >
> >
> > --
> > PHP Internals - PHP Runtime Development Mailing List
> > To unsubscribe, visit: http://www.php.net/unsub.php
> >
> >
>

Ahh ok then I figured it was probably something like that but wanted to
make sure lol.  I'll go ahead and make the correction.  =)

--Kris

Re: [PHP-DEV] php-src is now on git

[Kris Craig]

Hey Chris,

On Mon, Mar 19, 2012 at 11:40 AM, Christopher Jones <
christopher.jo...@oracle.com> wrote:

>
>
> On 03/19/2012 11:34 AM, Kris Craig wrote:
>
>  I noticed that the workflow page recommends using the SSH URL for cloning.
>> However, isn't that one much more limited access?  I.e. for myself at
>> least, it just prompts for a password (presumably for the SSH "git" user)
>> which of course I don't have.  Is there a reason why that's recommended or
>> is it just a typo?  If the latter, I'd be inclined to change it to the SSL
>> (i.e. https) URL (which the FAQ recommends for clone/push and utilizes
>> php.net credentials) to minimize confusion.
>>
>>
> Which exact bit are you talking about, and did you check the page commit
> history?
>
> I added https:// because git: is not usable from where I am.
>
> I believe from your emails you have more git experience than me, and I
> know you've been asked several times to contribute to the docs: go do it.
>
> Chris
>
>
>
> --
> Email: christopher.jo...@oracle.com
> Tel:  +1 650 506 8630
> Blog:  http://blogs.oracle.com/opal/
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>
I sense your hostility but I think you misunderstood my question.  The
workflow page currently recommends the "git:" one for cloning (which
doesn't work for me, either).  I think it should be changed to "https://";,
and I fully intend on making the change myself but first I wanted to ask
here to make sure there wasn't a reason why they went with "git:" instead
(i.e. I don't want to step on anybody's toes).

If nobody objects then yeah I'll gladly update it myself.  =)

--Kris

Re: [PHP-DEV] php-src is now on git

[Alexander Moskaliov]

Really it was a mistake to do this option recommended (I did it =)). But
I think for webprojects and documentation will need to mention this option.

With regards, Alexander Moskaliov
ir...@irker.net


2012/3/19 Christopher Jones 

>
>
> On 03/19/2012 10:19 AM, David Soria Parra wrote:
>
>  Also a small thing - gitfaq recommends git config core.autocrlf
>>> input, but we have some files in win32 which do not work with this
>>> setting (at least on my Mac).
>>>
>>
>> ah okay, can you remove it please? Thanks
>>
>
> Done.
>
> --
> Email: christopher.jo...@oracle.com
> Tel:  +1 650 506 8630
> Blog:  http://blogs.oracle.com/opal/
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

Re: [PHP-DEV] php-src is now on git

[Christopher Jones]

On 03/19/2012 11:34 AM, Kris Craig wrote:


I noticed that the workflow page recommends using the SSH URL for cloning.
However, isn't that one much more limited access?  I.e. for myself at
least, it just prompts for a password (presumably for the SSH "git" user)
which of course I don't have.  Is there a reason why that's recommended or
is it just a typo?  If the latter, I'd be inclined to change it to the SSL
(i.e. https) URL (which the FAQ recommends for clone/push and utilizes
php.net credentials) to minimize confusion.



Which exact bit are you talking about, and did you check the page commit
history?

I added https:// because git: is not usable from where I am.

I believe from your emails you have more git experience than me, and I
know you've been asked several times to contribute to the docs: go do it.

Chris


--
Email: christopher.jo...@oracle.com
Tel:  +1 650 506 8630
Blog:  http://blogs.oracle.com/opal/

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] php-src is now on git

[Kris Craig]

Me again,

On Mon, Mar 19, 2012 at 11:34 AM, Kris Craig  wrote:

> Also,
>
>
> On Mon, Mar 19, 2012 at 11:21 AM, Kris Craig  wrote:
>
>> Hey,
>>
>>
>> On Mon, Mar 19, 2012 at 8:24 AM, David Soria Parra  wrote:
>>
>>> Hi Internals,
>>>
>>> The initial migration is done and initial testing was successful.
>>>
>>>  http://git.php.net/?p=php-src.git;a=summary
>>>  http://github.com/php/php-src
>>>
>>> Please note that some branches and tags were renamed to make
>>> the repository cleaner.
>>>
>>> Please checkout the repository and play around. I have created
>>> a workflow wiki page at https://wiki.php.net/vcs/gitworkflow.
>>> There is also an FAQ at https://wiki.php.net/vcs/gitfaq.
>>>
>>> If you have questions about the workflow or problems let me know.
>>> General git questions should be asked in the appropriate IRC channels
>>> and mailinglists.
>>>
>>> David
>>>
>>> --
>>> PHP Internals - PHP Runtime Development Mailing List
>>> To unsubscribe, visit: http://www.php.net/unsub.php
>>>
>>>
>> Could we modify the workflow to recommend using the "--no-ff" switch when
>> merging in a feature branch?  This is by and large the recommended approach
>> as it preserves the feature branch's commit history, making it *much*easier 
>> to sort through complex features that contain numerous commits.
>>
>> --Kris
>>
>>
> I noticed that the workflow page recommends using the SSH URL for
> cloning.  However, isn't that one much more limited access?  I.e. for
> myself at least, it just prompts for a password (presumably for the SSH
> "git" user) which of course I don't have.  Is there a reason why that's
> recommended or is it just a typo?  If the latter, I'd be inclined to change
> it to the SSL (i.e. https) URL (which the FAQ recommends for clone/push and
> utilizes php.net credentials) to minimize confusion.
>
> --Kris
>
>
Also on the workflow page, it shouldn't be necessary to do "git checkout -b
PHP-5.3 origin/PHP-5.3" if the local repo is already tracking from remote
(which it is if you did a git clone to set it up).  Instead, you can simply
do "git checkout PHP-5.3" and it will automatically track from the remote
branch and pull the necessary data to create a local working copy.

Any objections to me changing that?  The less confusing we can make it,
particularly for people who are already struggling with the SVN
withdrawals, the better IMHO.  =)

--Kris

Re: [PHP-DEV] php-src is now on git

[Kris Craig]

Also,

On Mon, Mar 19, 2012 at 11:21 AM, Kris Craig  wrote:

> Hey,
>
>
> On Mon, Mar 19, 2012 at 8:24 AM, David Soria Parra  wrote:
>
>> Hi Internals,
>>
>> The initial migration is done and initial testing was successful.
>>
>>  http://git.php.net/?p=php-src.git;a=summary
>>  http://github.com/php/php-src
>>
>> Please note that some branches and tags were renamed to make
>> the repository cleaner.
>>
>> Please checkout the repository and play around. I have created
>> a workflow wiki page at https://wiki.php.net/vcs/gitworkflow.
>> There is also an FAQ at https://wiki.php.net/vcs/gitfaq.
>>
>> If you have questions about the workflow or problems let me know.
>> General git questions should be asked in the appropriate IRC channels
>> and mailinglists.
>>
>> David
>>
>> --
>> PHP Internals - PHP Runtime Development Mailing List
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>>
> Could we modify the workflow to recommend using the "--no-ff" switch when
> merging in a feature branch?  This is by and large the recommended approach
> as it preserves the feature branch's commit history, making it *much*easier 
> to sort through complex features that contain numerous commits.
>
> --Kris
>
>
I noticed that the workflow page recommends using the SSH URL for cloning.
However, isn't that one much more limited access?  I.e. for myself at
least, it just prompts for a password (presumably for the SSH "git" user)
which of course I don't have.  Is there a reason why that's recommended or
is it just a typo?  If the latter, I'd be inclined to change it to the SSL
(i.e. https) URL (which the FAQ recommends for clone/push and utilizes
php.net credentials) to minimize confusion.

--Kris

Re: [PHP-DEV] php-src is now on git

[Kris Craig]

Hey,

On Mon, Mar 19, 2012 at 8:24 AM, David Soria Parra  wrote:

> Hi Internals,
>
> The initial migration is done and initial testing was successful.
>
>  http://git.php.net/?p=php-src.git;a=summary
>  http://github.com/php/php-src
>
> Please note that some branches and tags were renamed to make
> the repository cleaner.
>
> Please checkout the repository and play around. I have created
> a workflow wiki page at https://wiki.php.net/vcs/gitworkflow.
> There is also an FAQ at https://wiki.php.net/vcs/gitfaq.
>
> If you have questions about the workflow or problems let me know.
> General git questions should be asked in the appropriate IRC channels
> and mailinglists.
>
> David
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>
Could we modify the workflow to recommend using the "--no-ff" switch when
merging in a feature branch?  This is by and large the recommended approach
as it preserves the feature branch's commit history, making it
*much*easier to sort through complex features that contain numerous
commits.

--Kris

Re: [PHP-DEV] php-src is now on git

[Christopher Jones]

On 03/19/2012 10:19 AM, David Soria Parra wrote:


Also a small thing - gitfaq recommends git config core.autocrlf
input, but we have some files in win32 which do not work with this
setting (at least on my Mac).


ah okay, can you remove it please? Thanks


Done.

--
Email: christopher.jo...@oracle.com
Tel:  +1 650 506 8630
Blog:  http://blogs.oracle.com/opal/

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] php-src is now on git

[David Soria Parra]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1


>> [git] branch PHP-5.4 updated. | [git] commit ab33e5176ae
>> ext/lib/date
> 
> Can we strip out as much "nonsense" from there as possible? I am
> mostly interested in the short part of the commit message; and not
> the words "commit", and the hash.

we can strip [git]
i personally think "commit" and the hash are necessary information but
if people disagree we can change it. the current format shouldnt be a
problem for the main purpose of filtering mails based on paths.


> I was mostly wondering where they are going to be sent to though..
>  PHP-CVS I hope?
php-cvs

> 
> cheers, Derick
> 

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJPZ20fAAoJEAT0aMuPE7Z1w/oP/0sLoQYAPM4dUCzX+fOU96Xy
efiZccfsWfj8VZ5XUEUtA1dYYmGQeYt5TL+SLxdS//L2e6g7Ndi7ANcbDTDb+XGe
W3/dLJxQbyksY773hr2kCWzMV5oZpbaqGKAj5jQlQnsNt6H54lyo0eY/JgaqY7YQ
2EhPHLGZiYRqZkcsjB09PqqyutJRLXkOd5ef6VjAlynZ+x6duC67zw/9LbYzGrSB
Mmw7y8o7dqvs+fPJJXPvUBPOvu5hJP9hW0VJEIzMsq0i8lanhtfjVNelcfXACuMY
U/SLSjdOoQTe/JNSVujTH8evZesLyuLKn/gs1XwY4nIl98Glhv/JSrq/RvC6lFAe
ewghEOX7swr/VmSeFBwQ7miLGRn/dKD7d+FY+Ay6FaADXUx9KwGHhvdp1YLPvwnd
C5/RrZFEC4fcnjwcJ68B/jhr4ZtRs0g/9WVZ4l1/8rWOviQqiEOrXgoELim+LYy3
yX0r8rmXICreuE0TaxBSS4VABsHk0guerT+XbB0TDysKyaMgE9RDx820A5aOPyUI
BWLzDsibU8J5bJS81VetSbnq6YYWelxoCzsmFtRiSW+R1+xvu2rJeh7sWJYtwkc7
/FL2ftuQTysSUxb5zpXVt1F2MLQc62eonU4SBBvqY73PAZZ0jGHyiaJtrqLzI3qv
WLelvoXKqgLCedNJkyDc
=T/FL
-END PGP SIGNATURE-

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] php-src is now on git

[Derick Rethans]

On Mon, 19 Mar 2012, David Soria Parra wrote:

> On 03/19/2012 06:20 PM, Derick Rethans wrote:
> > On Mon, 19 Mar 2012, David Soria Parra wrote:
> > 
> >> There is also an FAQ at https://wiki.php.net/vcs/gitfaq.
> > 
> > I can't find in the FAQ what's happening with the commit mails. Can
> > you add that (and CC this list too)? (Refering to "The git
> > push/commit email notification process is under discussion (Jan
> > 2012). For mail lists see http://php.net/mailing-lists.php"; as well
> > in the FAQ).
> 
> I will add that.
> 
> For every push a mail with a log what revisions are pushed will be
> mailed. For every commit in the push a follow up with changed files in
> the subject will be mailed too.
> 
> The format should be:
> 
>  [git] branch PHP-5.4 updated.
>| [git] commit ab33e5176ae ext/lib/date

Can we strip out as much "nonsense" from there as possible? I am mostly 
interested in the short part of the commit message; and not the words 
"commit", and the hash.

I was mostly wondering where they are going to be sent to though.. 
PHP-CVS I hope?

cheers,
Derick

-- 
http://derickrethans.nl | http://xdebug.org
Like Xdebug? Consider a donation: http://xdebug.org/donate.php
twitter: @derickr and @xdebug

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] php-src is now on git

[David Soria Parra]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 03/19/2012 06:20 PM, Derick Rethans wrote:
> On Mon, 19 Mar 2012, David Soria Parra wrote:
> 
>> There is also an FAQ at https://wiki.php.net/vcs/gitfaq.
> 
> I can't find in the FAQ what's happening with the commit mails. Can
> you add that (and CC this list too)? (Refering to "The git
> push/commit email notification process is under discussion (Jan
> 2012). For mail lists see http://php.net/mailing-lists.php"; as well
> in the FAQ).

I will add that.

For every push a mail with a log what revisions are pushed will be
mailed. For every commit in the push a follow up with changed files in
the subject will be mailed too.

The format should be:

 [git] branch PHP-5.4 updated.
   | [git] commit ab33e5176ae ext/lib/date


> 
> cheers, Derick
> 

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJPZ2vOAAoJEAT0aMuPE7Z1LFAP/ja9A4mmyQbIpy69kKUEAcIh
/XwxUF6R0xHdYsZ7JdKm7awiMIgxTYa0kdn3uvR0PREGt4MmPHIaO3Kaahg434tp
0zTbSlfnUKP3AyN1RdJ/gii23n6FHHC56qpKH+FdMQ6zVyNMWG6FczBypnL4w9uv
/ucMsM9Y98jviL55mV2b/Gb7ZOHgBbi5sXSyY+iRRBXeV9JSclHppGwR7rfy7K+8
Qeuqce1aoEgKfNxUO6fGHOZYRD8AYOrdRNlOXT+sI0MzvbT+p5jW6t0Hlv4vczMY
QTU2w28zr8ceyQYS4xghYMdqPcg/5+ogyGikGutVS38qBnnuJ1kT9VwR8L5zKFKo
NZU54pbqbsr4J4aB+mMXETJ9kaOIEEJLvRxYlyzwVzq1XWNyKbhvGi9JX3BLyolU
hgkYaWuzd77/ZjzY+JXUWpO+OIFQpjafZC8wxHEvhHRzslBfOBhdDSuub+vT15OD
QBpyuBAe2VvJ2P3VwFJ1lzSNp/buiPp7mD1fPbRo5qibDm1sqkd8KPRGztQeggBH
nx2UCsuCXKnnIRbsPiM9I37IVh1unYUv81myRmx96LYoH2o7guwQ44Ak8XmBPOKD
gSkfJ6FQPEbvFCcQqJ6hiUZvzK0p9YJtMUEEBIDajQpDQMalQ7MfIa5ypQwnIZ1u
WJAXVFsYkQO+57ySstva
=k8nl
-END PGP SIGNATURE-

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] php-src is now on git

[Stas Malyshev]

Hi!

> I don't know if someone asked just that before:
> Are there plans reducing this list?
> Branches (at least to me) seems to be something like big features,
> bugfixes or releases that are or could actively be developed in the
> future.

With git, cost of branches is near zero, so we don't need to be too
aggressive, and git workflow usually involves branching a lot. Of
course, not every branch has to live in the main php repo :)

-- 
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] php-src is now on git

[David Soria Parra]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 03/19/2012 06:16 PM, Simon Schick wrote:
> 2012/3/19 David Soria Parra : Hi, David
> 
> Thanks for this great step!
> 
> As I quickly viewed into the github-repository I recognized the
> big list of branches ... 52 is quite a big list ..
> 
> I don't know if someone asked just that before: Are there plans
> reducing this list? Branches (at least to me) seems to be something
> like big features, bugfixes or releases that are or could actively
> be developed in the future. One step is for example closing all the
> php-4.x branches and leave them as tagged open-end if changes are
> not merged ...

absolutly. We carrying around a lot of branches since 2001. Neither
gwynne nor I wanted to remove the branches. People with full
repository access are free to cleanup the branches and tags if they
are sure that they are not longer needed. I personally dont think i am
in the position to judge which branch or tag to delete and which not.


-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJPZ2stAAoJEAT0aMuPE7Z1awoQAKLRXhY8BHbHoIbCmbO0vz/p
7LC5WdhiQ8HLp73HpmMf/jzS6D2+8nIOCKGi4cs1tht6nqG9IqKPZRTly+XY1Bu+
KOEysrbb1/OFBSl0B2ks+KiIrS5wVvWwkfHrNcEHsE/kdUdlRT73S3k5gkHN/fzo
CLC0eZ+V/x6Tbd2Uf/nzS8ZM4b/2KdGnUCJw08nKsU5MmeUt85zTsRTAunaBzUQy
cSiVCEFJ7TMyWTPGBECXtMu+dUJFlmjcLSRe7kFyZ1YHgX7b2WZHNi4OkLrAK5Kl
ypFCr7wgHhTsR9/C3+ZzPD4BRJJvLfCWxHJz4qWl8j4fJ2SBLoHsvv/Q4alruhGY
Z0D7HsySZgh1iCfDYXslzSY7HAkfUGLZtVh2L8ezPrCeZ+GO4aHMiQwsEbnq5G4Z
NOxTR5HQBmyB2j+bc5Gsc63dxcDnySpBlmvh1XxZBYX1mSyLAlz/XzKsFpPTKOJr
I4x8eA/qf449sCMr19+m3Evy6T6uGgzEwOKuer2+K086UIfbubL12hiS29Dj5IYN
XjGcRFBHtCrGQXHNfSvMe+A3HRVCzx5Qu5UjjVm9L93+h2mn7Ix8e7bS9LAlMj3n
KZ7SHCQGoL+WknYJOfr2YFurXUgM+3n4g/beXjVbHGE88IYTaS+7f5hUtIwLMHUM
Ase72LeLJxIkN78pXCst
=IPhy
-END PGP SIGNATURE-

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] php-src is now on git

[Derick Rethans]

On Mon, 19 Mar 2012, David Soria Parra wrote:

> There is also an FAQ at https://wiki.php.net/vcs/gitfaq.

I can't find in the FAQ what's happening with the commit mails. Can you 
add that (and CC this list too)? (Refering to "The git push/commit email 
notification process is under discussion (Jan 2012). For mail lists see 
http://php.net/mailing-lists.php"; as well in the FAQ).

cheers,
Derick

-- 
http://derickrethans.nl | http://xdebug.org
Like Xdebug? Consider a donation: http://xdebug.org/donate.php
twitter: @derickr and @xdebug

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] php-src is now on git

[David Soria Parra]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 03/19/2012 06:18 PM, Stas Malyshev wrote:
> Hi!
> 
>> The initial migration is done and initial testing was
>> successful.
> 
> Thanks David! This is awesome! Great work and I think it will make 
> developing PHP and contributing to the project much easier.  I
> think we should do php.net frontpage announcement.

can someone do that?

> 
>> Please note that some branches and tags were renamed to make the
>> repository cleaner.
> 
> We need then to fix our docs on wiki - some of them say 5.4, some
> PHP_5_4.
> 
> Also a small thing - gitfaq recommends git config core.autocrlf
> input, but we have some files in win32 which do not work with this
> setting (at least on my Mac).

ah okay, can you remove it please? Thanks

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJPZ2qvAAoJEAT0aMuPE7Z1e0sP/3gsDzHWhbb1YS+uwDQRfd/B
jjuVy4eoBmfVXPZgLvCDRtLs1WzsmShfNQtI2jGr8ZZ9tTDrbLs624VZNXpoQudW
SEFhyePPm/SRACFrpxLkAAd1vKrT+ZKUdpTjAgvK99lb29nbtYqwDp4S918+cGaP
3wlL5V0lacVL15cNs/mHZA3JE2wkvhyXVIVwnv8xjVxE7NE2NSfrkCJGlbYeJN8y
uo5Yl9oa8uRzuYdi3NakvFJzqaNqxsrl299nk91kpY9eusyYR+elzUUik+yipp3H
yhTie4/3HeNIbZM+g72BOfKFJoTKkkxvbLCKuuQwcUCHh0SBNnZeh27f7e0Yp+YX
SjTY5GF3G3xtcC3/yLUR08/G7GCrwquwU350lk1Amjyb+5mSC1XFyAQ78/Cq9Sc8
itEwwqO1MjaQk7iE9KABqwb1M48ZZXlcfbO6Pz1RkShSuG1Uxy2Eb9crnii6bJJg
RCNdJxf43p3lX1SLqP7mz0LXF1KQwpvueAN8I83BzprgYv/hT5zu8wII+frcJTWp
NJKudPVHPS8viXKVSBDfQ5WGzCpfNKLQte4QpKZQ81aVeuyyXNjrKBgy6h2Wr20E
KUE2JoUy6SjM7zL+1IeieYSsU3PKE+1nZXLmgPWWOyBjR2+oYX2aOLgIGKJJHJC9
A2PwEZR4kErUIBcAnoof
=ngSq
-END PGP SIGNATURE-

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] php-src is now on git

[Stas Malyshev]

Hi!

> The initial migration is done and initial testing was successful.

Thanks David! This is awesome! Great work and I think it will make
developing PHP and contributing to the project much easier.  I think we
should do php.net frontpage announcement.

> Please note that some branches and tags were renamed to make
> the repository cleaner.

We need then to fix our docs on wiki - some of them say 5.4, some PHP_5_4.

Also a small thing - gitfaq recommends git config core.autocrlf input,
but we have some files in win32 which do not work with this setting (at
least on my Mac).
-- 
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] php-src is now on git

[Simon Schick]

2012/3/19 David Soria Parra :
> Hi Internals,
>
> The initial migration is done and initial testing was successful.
>
>  http://git.php.net/?p=php-src.git;a=summary
>  http://github.com/php/php-src
>
> Please note that some branches and tags were renamed to make
> the repository cleaner.
>
> Please checkout the repository and play around. I have created
> a workflow wiki page at https://wiki.php.net/vcs/gitworkflow.
> There is also an FAQ at https://wiki.php.net/vcs/gitfaq.
>
> If you have questions about the workflow or problems let me know.
> General git questions should be asked in the appropriate IRC channels
> and mailinglists.
>
> David
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>

Hi, David

Thanks for this great step!

As I quickly viewed into the github-repository I recognized the big
list of branches ... 52 is quite a big list ..

I don't know if someone asked just that before:
Are there plans reducing this list?
Branches (at least to me) seems to be something like big features,
bugfixes or releases that are or could actively be developed in the
future.
One step is for example closing all the php-4.x branches and leave
them as tagged open-end if changes are not merged ...

Bye
Simon

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] php-src is now on git

[David Soria Parra]

Hi Internals,

The initial migration is done and initial testing was successful.

  http://git.php.net/?p=php-src.git;a=summary
  http://github.com/php/php-src

Please note that some branches and tags were renamed to make
the repository cleaner.

Please checkout the repository and play around. I have created
a workflow wiki page at https://wiki.php.net/vcs/gitworkflow.
There is also an FAQ at https://wiki.php.net/vcs/gitfaq.

If you have questions about the workflow or problems let me know.
General git questions should be asked in the appropriate IRC channels
and mailinglists.

David

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Scalar-type-hinting - which way is the best to go?

[Lazare Inepologlou]

Hello Simon,

> in_array("123abc", array(3, 7, 123, 28)) === true

This is a pointless example, because the first argument of in_array is of
type "mixed" and not "int". So, this may cause many headaches, but it is
irrelevant to the discussion about scalar type hints.


Lazare INEPOLOGLOU
Ingénieur Logiciel


2012/3/19 Simon Schick 

> 2012/3/18 Adam Jon Richardson :
> > On Sun, Mar 18, 2012 at 7:12 AM, Simon Schick
> > wrote:
> >
> >>
> >> Hi, All
> >>
> >> Just to add an example why I want a more strictly type-check here as
> >> we have in the current type-juggling:
> >>
> >>
> http://www.brandonsavage.net/an-xss-vulerability-in-the-making/?utm_source=rss&utm_medium=rss&utm_campaign=an-xss-vulerability-in-the-making
> >
> >
> > I see the example given as one of poor validation, not a reason for more
> > strict type checking in a dynamic, weakly typed language.
> >
> > One could:
> >
> > - use a regex
> > - setting the third argument (strict comparison) of in_array() to true
> -OR-
> > looping through the array and checking equivalence with ===
> > - ensure the type juggled value (the integer form) was returned and used
> > rather than using the original string
> >
> > I actually like the conversation on scalar type hinting, and I've even
> > offered some ideas for integrating a form of it, too. However, poor input
> > validation is not one of the reasons that I would use to justify its
> > inclusion. The goal of proper input validation should be to account for
> > page requests that include invalid data and provide appropriate feedback
> > within the natural flow of the application. Erring out when calling a
> more
> > strongly typed function at runtime does not provide this type of
> > application flow.
> >
> > Adam
>
> Hi, Adam
>
> I totally agree that type-hinting should not cover what the programmer
> should do for validating the given input ...
> But I just wanted to point out that this is something the author (and
> I) would never expect to happen ...
>
> in_array("123abc", array(3, 7, 123, 28)) === true
>
> But that's another thing :)
> I just wanted to point out that I don't want to have the string
> "123abc" accepted as an integer :)
>
> Anyways ... This thread should be a discussion about the whole
> concept, not the details.
> Sorry for getting off-context here.
>
> Bye
> Simon
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>