[jira] [Work logged] (ARTEMIS-4759) Restore compatibility with LiveOnlyPolicyConfiguration

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4759?focusedWorklogId=917421=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917421
 ]

ASF GitHub Bot logged work on ARTEMIS-4759:
---

Author: ASF GitHub Bot
Created on: 03/May/24 04:53
Start Date: 03/May/24 04:53
Worklog Time Spent: 10m 
  Work Description: jbertram opened a new pull request, #4922:
URL: https://github.com/apache/activemq-artemis/pull/4922

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 917421)
Remaining Estimate: 0h
Time Spent: 10m

> Restore compatibility with LiveOnlyPolicyConfiguration
> --
>
> Key: ARTEMIS-4759
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4759
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> During the work for ARTEMIS-3474 
> {{org.apache.activemq.artemis.core.config.ha.LiveOnlyPolicyConfiguration}} 
> was deprecated for removal. However, one of the changes broke compatibility 
> so that folks who were embedding the broker and using 
> {{LiveOnlyPolicyConfiguration}} for their configuration started receiving a 
> {{ClassCastException}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4758) Hardening Mirroring

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4758?focusedWorklogId=917417=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917417
 ]

ASF GitHub Bot logged work on ARTEMIS-4758:
---

Author: ASF GitHub Bot
Created on: 03/May/24 04:31
Start Date: 03/May/24 04:31
Worklog Time Spent: 10m 
  Work Description: brusdev commented on code in PR #4918:
URL: https://github.com/apache/activemq-artemis/pull/4918#discussion_r1588635621


##
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/ProtonProtocolManagerFactory.java:
##
@@ -87,7 +87,8 @@ public String getModuleName() {
@Override
public void loadProtocolServices(ActiveMQServer server, 
List services) {
   try {
- AckManager ackManager = AckManagerProvider.getManager(server, false);
+ AckManager ackManager = AckManagerProvider.getManager(server);
+ services.add(ackManager);

Review Comment:
   It seems that the same instance of the AckManager could be added multiple 
times to the list of services.





Issue Time Tracking
---

Worklog Id: (was: 917417)
Time Spent: 1h 20m  (was: 1h 10m)

> Hardening Mirroring
> ---
>
> Key: ARTEMIS-4758
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4758
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Clebert Suconic
>Priority: Major
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> I have been extensively testing mirroring, and I'm hardening it as an overal 
> task, improving its behavior:
> - Page Transactions on mirror target are now optional.
>   * If you had an interrupt mirror while the target destination was paging, 
> duplicate detection would be ineffective unless you used paged transactions
>   * Users can now configure the ack manager retries intervals.
>   Say you need some time to remove a consumer from a target mirror. The 
> delivering references would prevent acks from happening. You can allow bigger 
> retry intervals and number of retries by tinkiering with ack manager retry 
> parameters.
>   * The ackManager was only restarted when new acks were coming in. If you 
> stopped receiving acks on a target server and restarted that server with 
> pending acks, those acks would never be exercised. The AckManager retries are 
> now restarted as soon as the server is started.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4743) Improve CLI Queue Stat Output: Split lines and include internal queue attribute

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4743?focusedWorklogId=917415=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917415
 ]

ASF GitHub Bot logged work on ARTEMIS-4743:
---

Author: ASF GitHub Bot
Created on: 03/May/24 03:26
Start Date: 03/May/24 03:26
Worklog Time Spent: 10m 
  Work Description: brusdev commented on code in PR #4921:
URL: https://github.com/apache/activemq-artemis/pull/4921#discussion_r1588631240


##
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/queue/StatQueue.java:
##
@@ -99,6 +100,12 @@ public enum OPERATION {
@Option(names = "--include-management", description = "Include queues 
created for notification management in the output")
private boolean includeManagement = false;
 
+   @Option(names = "--loop", description = "Keep Queue Stat in a forever loop, 
that you can interrupt with Ctrl-C, sleeping for --loop-time between each 
iteration.")

Review Comment:
   In kubectl the name of a similar option is `watch`





Issue Time Tracking
---

Worklog Id: (was: 917415)
Time Spent: 3h 10m  (was: 3h)

> Improve CLI Queue Stat Output: Split lines and include internal queue 
> attribute
> ---
>
> Key: ARTEMIS-4743
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4743
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Affects Versions: 2.33.0
>Reporter: Clebert Suconic
>Priority: Major
> Fix For: 2.34.0
>
>  Time Spent: 3h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4743) Improve CLI Queue Stat Output: Split lines and include internal queue attribute

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4743?focusedWorklogId=917386=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917386
 ]

ASF GitHub Bot logged work on ARTEMIS-4743:
---

Author: ASF GitHub Bot
Created on: 02/May/24 21:53
Start Date: 02/May/24 21:53
Worklog Time Spent: 10m 
  Work Description: clebertsuconic merged PR #4921:
URL: https://github.com/apache/activemq-artemis/pull/4921




Issue Time Tracking
---

Worklog Id: (was: 917386)
Time Spent: 3h  (was: 2h 50m)

> Improve CLI Queue Stat Output: Split lines and include internal queue 
> attribute
> ---
>
> Key: ARTEMIS-4743
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4743
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Affects Versions: 2.33.0
>Reporter: Clebert Suconic
>Priority: Major
> Fix For: 2.34.0
>
>  Time Spent: 3h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4758) Hardening Mirroring

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4758?focusedWorklogId=917384=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917384
 ]

ASF GitHub Bot logged work on ARTEMIS-4758:
---

Author: ASF GitHub Bot
Created on: 02/May/24 21:23
Start Date: 02/May/24 21:23
Worklog Time Spent: 10m 
  Work Description: clebertsuconic merged PR #4918:
URL: https://github.com/apache/activemq-artemis/pull/4918




Issue Time Tracking
---

Worklog Id: (was: 917384)
Time Spent: 1h 10m  (was: 1h)

> Hardening Mirroring
> ---
>
> Key: ARTEMIS-4758
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4758
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Clebert Suconic
>Priority: Major
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> I have been extensively testing mirroring, and I'm hardening it as an overal 
> task, improving its behavior:
> - Page Transactions on mirror target are now optional.
>   * If you had an interrupt mirror while the target destination was paging, 
> duplicate detection would be ineffective unless you used paged transactions
>   * Users can now configure the ack manager retries intervals.
>   Say you need some time to remove a consumer from a target mirror. The 
> delivering references would prevent acks from happening. You can allow bigger 
> retry intervals and number of retries by tinkiering with ack manager retry 
> parameters.
>   * The ackManager was only restarted when new acks were coming in. If you 
> stopped receiving acks on a target server and restarted that server with 
> pending acks, those acks would never be exercised. The AckManager retries are 
> now restarted as soon as the server is started.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4758) Hardening Mirroring

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4758?focusedWorklogId=917383=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917383
 ]

ASF GitHub Bot logged work on ARTEMIS-4758:
---

Author: ASF GitHub Bot
Created on: 02/May/24 21:23
Start Date: 02/May/24 21:23
Worklog Time Spent: 10m 
  Work Description: clebertsuconic commented on PR #4918:
URL: 
https://github.com/apache/activemq-artemis/pull/4918#issuecomment-2091691493

   I need to merge this.. 
   
   We can always follow up with further changes and PRs if needed.




Issue Time Tracking
---

Worklog Id: (was: 917383)
Time Spent: 1h  (was: 50m)

> Hardening Mirroring
> ---
>
> Key: ARTEMIS-4758
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4758
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Clebert Suconic
>Priority: Major
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> I have been extensively testing mirroring, and I'm hardening it as an overal 
> task, improving its behavior:
> - Page Transactions on mirror target are now optional.
>   * If you had an interrupt mirror while the target destination was paging, 
> duplicate detection would be ineffective unless you used paged transactions
>   * Users can now configure the ack manager retries intervals.
>   Say you need some time to remove a consumer from a target mirror. The 
> delivering references would prevent acks from happening. You can allow bigger 
> retry intervals and number of retries by tinkiering with ack manager retry 
> parameters.
>   * The ackManager was only restarted when new acks were coming in. If you 
> stopped receiving acks on a target server and restarted that server with 
> pending acks, those acks would never be exercised. The AckManager retries are 
> now restarted as soon as the server is started.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4743) Improve CLI Queue Stat Output: Split lines and include internal queue attribute

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4743?focusedWorklogId=917380=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917380
 ]

ASF GitHub Bot logged work on ARTEMIS-4743:
---

Author: ASF GitHub Bot
Created on: 02/May/24 20:51
Start Date: 02/May/24 20:51
Worklog Time Spent: 10m 
  Work Description: clebertsuconic opened a new pull request, #4921:
URL: https://github.com/apache/activemq-artemis/pull/4921

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 917380)
Time Spent: 2h 50m  (was: 2h 40m)

> Improve CLI Queue Stat Output: Split lines and include internal queue 
> attribute
> ---
>
> Key: ARTEMIS-4743
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4743
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Affects Versions: 2.33.0
>Reporter: Clebert Suconic
>Priority: Major
> Fix For: 2.34.0
>
>  Time Spent: 2h 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4749) SIMILAR_BRANCHES.SWITCH in ../activemq/artemis/utils/ThreadDumpUtil.java

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4749?focusedWorklogId=917371=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917371
 ]

ASF GitHub Bot logged work on ARTEMIS-4749:
---

Author: ASF GitHub Bot
Created on: 02/May/24 19:38
Start Date: 02/May/24 19:38
Worklog Time Spent: 10m 
  Work Description: clebertsuconic merged PR #4920:
URL: https://github.com/apache/activemq-artemis/pull/4920




Issue Time Tracking
---

Worklog Id: (was: 917371)
Time Spent: 20m  (was: 10m)

> SIMILAR_BRANCHES.SWITCH in ../activemq/artemis/utils/ThreadDumpUtil.java
> 
>
> Key: ARTEMIS-4749
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4749
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.25.0
>Reporter: e.bykhanova
>Assignee: Justin Bertram
>Priority: Minor
> Attachments: image-2024-05-01-13-29-32-686.png, 
> image-2024-05-01-13-30-38-262.png
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The static analyzer has detected SIMILAR_BRANCHES.SWITCH: we have identical 
> branches in switch node in [private static String threadInfoToString] 
> [https://github.com/apache/activemq-artemis/blob/fb1b362b473cad51ae5d05a897be02b1fa8461d4/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ThreadDumpUtil.java#L106-L113|#L106-L113]
>  
> !image-2024-05-01-13-30-38-262.png|width=663,height=411!
>  
> It seems better to change code this way: 
>  
> {{case WAITING:}}
> {{case TIMED_WAITING:}}
> {{                  sb.append("\t-  waiting on " + 
> threadInfo.getLockInfo());}}
> {{                  sb.append('\n');}}
> {{                  break;}}
> {{               default:}}
>  
> Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE.
> Author E. Bykhanova (e.bykhan...@fobos-nt.ru).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4749) SIMILAR_BRANCHES.SWITCH in ../activemq/artemis/utils/ThreadDumpUtil.java

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4749?focusedWorklogId=917368=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917368
 ]

ASF GitHub Bot logged work on ARTEMIS-4749:
---

Author: ASF GitHub Bot
Created on: 02/May/24 19:03
Start Date: 02/May/24 19:03
Worklog Time Spent: 10m 
  Work Description: jbertram opened a new pull request, #4920:
URL: https://github.com/apache/activemq-artemis/pull/4920

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 917368)
Remaining Estimate: 0h
Time Spent: 10m

> SIMILAR_BRANCHES.SWITCH in ../activemq/artemis/utils/ThreadDumpUtil.java
> 
>
> Key: ARTEMIS-4749
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4749
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.25.0
>Reporter: e.bykhanova
>Priority: Minor
> Attachments: image-2024-05-01-13-29-32-686.png, 
> image-2024-05-01-13-30-38-262.png
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The static analyzer has detected SIMILAR_BRANCHES.SWITCH: we have identical 
> branches in switch node in [private static String threadInfoToString] 
> [https://github.com/apache/activemq-artemis/blob/fb1b362b473cad51ae5d05a897be02b1fa8461d4/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ThreadDumpUtil.java#L106-L113|#L106-L113]
>  
> !image-2024-05-01-13-30-38-262.png|width=663,height=411!
>  
> It seems better to change code this way: 
>  
> {{case WAITING:}}
> {{case TIMED_WAITING:}}
> {{                  sb.append("\t-  waiting on " + 
> threadInfo.getLockInfo());}}
> {{                  sb.append('\n');}}
> {{                  break;}}
> {{               default:}}
>  
> Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE.
> Author E. Bykhanova (e.bykhan...@fobos-nt.ru).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4751) Upgrade to Apache parent 32

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4751?focusedWorklogId=917357=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917357
 ]

ASF GitHub Bot logged work on ARTEMIS-4751:
---

Author: ASF GitHub Bot
Created on: 02/May/24 18:18
Start Date: 02/May/24 18:18
Worklog Time Spent: 10m 
  Work Description: jbertram commented on code in PR #4911:
URL: https://github.com/apache/activemq-artemis/pull/4911#discussion_r1588105088


##
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/artemis.profile:
##
@@ -37,7 +37,7 @@ HAWTIO_ROLE='${role}'
 
 # Java Opts
 if [ -z "$JAVA_ARGS" ]; then
-JAVA_ARGS="-XX:AutoBoxCacheMax=2 -XX:+PrintClassHistogram -XX:+UseG1GC 
-XX:+UseStringDeduplication -Xms512M -Xmx${java-memory} 
-Dhawtio.disableProxy=true -Dhawtio.realm=activemq -Dhawtio.offline=true 
-Dhawtio.rolePrincipalClasses=org.apache.activemq.artemis.spi.core.security.jaas.RolePrincipal
 
-Dhawtio.http.strictTransportSecurity=max-age=31536000;includeSubDomains;preload
 -Djolokia.policyLocation=${ARTEMIS_INSTANCE_ETC_URI}jolokia-access.xml 
-Dlog4j2.disableJmx=true ${java-opts}"
+JAVA_ARGS="-XX:AutoBoxCacheMax=2 -XX:+PrintClassHistogram -XX:+UseG1GC 
-XX:+UseStringDeduplication -Xms512M -Xmx${java-memory} 
-Dhawtio.disableProxy=true -Dhawtio.realm=activemq -Dhawtio.offline=true 
-Dhawtio.rolePrincipalClasses=org.apache.activemq.artemis.spi.core.security.jaas.RolePrincipal
 
-Dhawtio.http.strictTransportSecurity=max-age=31536000;includeSubDomains;preload
 -Djolokia.policyLocation=${ARTEMIS_INSTANCE_ETC_URI}jolokia-access.xml 
-Dlog4j2.disableJmx=true --add-opens java.base/jdk.internal.misc=ALL-UNNAMED 
${java-opts}"

Review Comment:
   Good call. Done.





Issue Time Tracking
---

Worklog Id: (was: 917357)
Time Spent: 50m  (was: 40m)

> Upgrade to Apache parent 32
> ---
>
> Key: ARTEMIS-4751
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4751
> Project: ActiveMQ Artemis
>  Issue Type: Dependency upgrade
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4751) Upgrade to Apache parent 32

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4751?focusedWorklogId=917356=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917356
 ]

ASF GitHub Bot logged work on ARTEMIS-4751:
---

Author: ASF GitHub Bot
Created on: 02/May/24 18:17
Start Date: 02/May/24 18:17
Worklog Time Spent: 10m 
  Work Description: jbertram commented on code in PR #4911:
URL: https://github.com/apache/activemq-artemis/pull/4911#discussion_r1588104823


##
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/messages/perf/MicrosClock.java:
##
@@ -43,23 +45,28 @@ public static boolean isAvailable() {
}
 
public static long now() {
-  long epochSecond = offset;
-  long nanoAdjustment = 
jdk.internal.misc.VM.getNanoTimeAdjustment(epochSecond);
+  try {
+ long epochSecond = offset;
+ Class vm = Class.forName("jdk.internal.misc.VM");
+ Method getNanoTimeAdjustment = vm.getMethod("getNanoTimeAdjustment", 
long.class);
+ long nanoAdjustment = (long) 
getNanoTimeAdjustment.invoke(getNanoTimeAdjustment, epochSecond);

Review Comment:
   Done.





Issue Time Tracking
---

Worklog Id: (was: 917356)
Time Spent: 40m  (was: 0.5h)

> Upgrade to Apache parent 32
> ---
>
> Key: ARTEMIS-4751
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4751
> Project: ActiveMQ Artemis
>  Issue Type: Dependency upgrade
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4758) Hardening Mirroring

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4758?focusedWorklogId=917346=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917346
 ]

ASF GitHub Bot logged work on ARTEMIS-4758:
---

Author: ASF GitHub Bot
Created on: 02/May/24 17:52
Start Date: 02/May/24 17:52
Worklog Time Spent: 10m 
  Work Description: clebertsuconic commented on code in PR #4918:
URL: https://github.com/apache/activemq-artemis/pull/4918#discussion_r1588051242


##
artemis-server/src/main/java/org/apache/activemq/artemis/core/transaction/Transaction.java:
##
@@ -109,4 +109,8 @@ enum State {
 
/** To be used on control transactions that are meant as internal and don't 
really require a hard sync. */
Transaction setAsync(boolean async);
+
+   default boolean isAllowPageTransaction() {
+  return true;
+   }

Review Comment:
   MirrorTransactions will disable page transaction by default. 
   
   I have corrected the names





Issue Time Tracking
---

Worklog Id: (was: 917346)
Time Spent: 50m  (was: 40m)

> Hardening Mirroring
> ---
>
> Key: ARTEMIS-4758
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4758
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Clebert Suconic
>Priority: Major
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> I have been extensively testing mirroring, and I'm hardening it as an overal 
> task, improving its behavior:
> - Page Transactions on mirror target are now optional.
>   * If you had an interrupt mirror while the target destination was paging, 
> duplicate detection would be ineffective unless you used paged transactions
>   * Users can now configure the ack manager retries intervals.
>   Say you need some time to remove a consumer from a target mirror. The 
> delivering references would prevent acks from happening. You can allow bigger 
> retry intervals and number of retries by tinkiering with ack manager retry 
> parameters.
>   * The ackManager was only restarted when new acks were coming in. If you 
> stopped receiving acks on a target server and restarted that server with 
> pending acks, those acks would never be exercised. The AckManager retries are 
> now restarted as soon as the server is started.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4751) Upgrade to Apache parent 32

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4751?focusedWorklogId=917340=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917340
 ]

ASF GitHub Bot logged work on ARTEMIS-4751:
---

Author: ASF GitHub Bot
Created on: 02/May/24 17:28
Start Date: 02/May/24 17:28
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on code in PR #4911:
URL: https://github.com/apache/activemq-artemis/pull/4911#discussion_r1588019978


##
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/messages/perf/MicrosClock.java:
##
@@ -43,23 +45,28 @@ public static boolean isAvailable() {
}
 
public static long now() {
-  long epochSecond = offset;
-  long nanoAdjustment = 
jdk.internal.misc.VM.getNanoTimeAdjustment(epochSecond);
+  try {
+ long epochSecond = offset;
+ Class vm = Class.forName("jdk.internal.misc.VM");
+ Method getNanoTimeAdjustment = vm.getMethod("getNanoTimeAdjustment", 
long.class);
+ long nanoAdjustment = (long) 
getNanoTimeAdjustment.invoke(getNanoTimeAdjustment, epochSecond);

Review Comment:
   This might be better done once, e.g during the initial availability checks, 
and then the Method reused here rather than doing lookups every time, given the 
aimed usage ?



##
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/artemis.profile:
##
@@ -37,7 +37,7 @@ HAWTIO_ROLE='${role}'
 
 # Java Opts
 if [ -z "$JAVA_ARGS" ]; then
-JAVA_ARGS="-XX:AutoBoxCacheMax=2 -XX:+PrintClassHistogram -XX:+UseG1GC 
-XX:+UseStringDeduplication -Xms512M -Xmx${java-memory} 
-Dhawtio.disableProxy=true -Dhawtio.realm=activemq -Dhawtio.offline=true 
-Dhawtio.rolePrincipalClasses=org.apache.activemq.artemis.spi.core.security.jaas.RolePrincipal
 
-Dhawtio.http.strictTransportSecurity=max-age=31536000;includeSubDomains;preload
 -Djolokia.policyLocation=${ARTEMIS_INSTANCE_ETC_URI}jolokia-access.xml 
-Dlog4j2.disableJmx=true ${java-opts}"
+JAVA_ARGS="-XX:AutoBoxCacheMax=2 -XX:+PrintClassHistogram -XX:+UseG1GC 
-XX:+UseStringDeduplication -Xms512M -Xmx${java-memory} 
-Dhawtio.disableProxy=true -Dhawtio.realm=activemq -Dhawtio.offline=true 
-Dhawtio.rolePrincipalClasses=org.apache.activemq.artemis.spi.core.security.jaas.RolePrincipal
 
-Dhawtio.http.strictTransportSecurity=max-age=31536000;includeSubDomains;preload
 -Djolokia.policyLocation=${ARTEMIS_INSTANCE_ETC_URI}jolokia-access.xml 
-Dlog4j2.disableJmx=true --add-opens java.base/jdk.internal.misc=ALL-UNNAMED 
${java-opts}"

Review Comment:
   Hadnt actually considered this possibility...but if doing it, is there a 
windows equivalent needed somewhere?





Issue Time Tracking
---

Worklog Id: (was: 917340)
Time Spent: 0.5h  (was: 20m)

> Upgrade to Apache parent 32
> ---
>
> Key: ARTEMIS-4751
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4751
> Project: ActiveMQ Artemis
>  Issue Type: Dependency upgrade
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4758) Hardening Mirroring

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4758?focusedWorklogId=917333=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917333
 ]

ASF GitHub Bot logged work on ARTEMIS-4758:
---

Author: ASF GitHub Bot
Created on: 02/May/24 16:37
Start Date: 02/May/24 16:37
Worklog Time Spent: 10m 
  Work Description: clebertsuconic commented on code in PR #4918:
URL: https://github.com/apache/activemq-artemis/pull/4918#discussion_r1587950084


##
artemis-commons/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQScheduledComponent.java:
##
@@ -212,15 +212,19 @@ public long getPeriod() {
}
 
public synchronized ActiveMQScheduledComponent setPeriod(long period) {
-  this.period = period;
-  restartIfNeeded();
+  if (this.period != period) {
+ this.period = period;
+ restartIfNeeded();
+  }
   return this;
}
 
public synchronized ActiveMQScheduledComponent setPeriod(long period, 
TimeUnit unit) {
-  this.period = period;
-  this.timeUnit = unit;
-  restartIfNeeded();
+  if (this.period != period && this.timeUnit != unit) {

Review Comment:
   Yeah... there's a bug in here... 
   
   
   which means I'm not testing this :)
   
   
   Will add a test





Issue Time Tracking
---

Worklog Id: (was: 917333)
Time Spent: 40m  (was: 0.5h)

> Hardening Mirroring
> ---
>
> Key: ARTEMIS-4758
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4758
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Clebert Suconic
>Priority: Major
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> I have been extensively testing mirroring, and I'm hardening it as an overal 
> task, improving its behavior:
> - Page Transactions on mirror target are now optional.
>   * If you had an interrupt mirror while the target destination was paging, 
> duplicate detection would be ineffective unless you used paged transactions
>   * Users can now configure the ack manager retries intervals.
>   Say you need some time to remove a consumer from a target mirror. The 
> delivering references would prevent acks from happening. You can allow bigger 
> retry intervals and number of retries by tinkiering with ack manager retry 
> parameters.
>   * The ackManager was only restarted when new acks were coming in. If you 
> stopped receiving acks on a target server and restarted that server with 
> pending acks, those acks would never be exercised. The AckManager retries are 
> now restarted as soon as the server is started.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4758) Hardening Mirroring

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4758?focusedWorklogId=917331=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917331
 ]

ASF GitHub Bot logged work on ARTEMIS-4758:
---

Author: ASF GitHub Bot
Created on: 02/May/24 16:33
Start Date: 02/May/24 16:33
Worklog Time Spent: 10m 
  Work Description: clebertsuconic commented on code in PR #4918:
URL: https://github.com/apache/activemq-artemis/pull/4918#discussion_r1587943211


##
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/MirrorTransaction.java:
##
@@ -49,4 +51,13 @@ protected synchronized void 
afterCommit(List operationsToC
   }
}
 
+   @Override
+   public boolean isAllowPageTransaction() {
+  return ignorePageTransaction;
+   }
+
+   public MirrorTransaction setIgnorePageTransaction(boolean 
ignorePageTransaction) {
+  this.ignorePageTransaction = ignorePageTransaction;
+  return this;
+   }

Review Comment:
   ohhh I renamed the method and forgot to rename that one.. thanks





Issue Time Tracking
---

Worklog Id: (was: 917331)
Time Spent: 0.5h  (was: 20m)

> Hardening Mirroring
> ---
>
> Key: ARTEMIS-4758
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4758
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Clebert Suconic
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> I have been extensively testing mirroring, and I'm hardening it as an overal 
> task, improving its behavior:
> - Page Transactions on mirror target are now optional.
>   * If you had an interrupt mirror while the target destination was paging, 
> duplicate detection would be ineffective unless you used paged transactions
>   * Users can now configure the ack manager retries intervals.
>   Say you need some time to remove a consumer from a target mirror. The 
> delivering references would prevent acks from happening. You can allow bigger 
> retry intervals and number of retries by tinkiering with ack manager retry 
> parameters.
>   * The ackManager was only restarted when new acks were coming in. If you 
> stopped receiving acks on a target server and restarted that server with 
> pending acks, those acks would never be exercised. The AckManager retries are 
> now restarted as soon as the server is started.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4758) Hardening Mirroring

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4758?focusedWorklogId=917320=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917320
 ]

ASF GitHub Bot logged work on ARTEMIS-4758:
---

Author: ASF GitHub Bot
Created on: 02/May/24 16:16
Start Date: 02/May/24 16:16
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on code in PR #4918:
URL: https://github.com/apache/activemq-artemis/pull/4918#discussion_r1587899745


##
artemis-server/src/main/java/org/apache/activemq/artemis/core/config/Configuration.java:
##
@@ -1509,4 +1509,32 @@ default String resolvePropertiesSources(String 
propertiesFileUrl) {
 
void setManagementRbacPrefix(String prefix);
 
+   /** This configures the Mirror Ack Manager number of attempts on queues 
before trying page acks.
+*  It is not intended to be configured through the XML.
+*  The default value here is 5. */
+   int getMirrorAckManagerMinQueueAttempts();
+
+   Configuration setMirrorAckManagerMinQueueAttempts(int minQueueAttempts);
+
+   /** This configures the Mirror Ack Manager number of attempts on page acks.
+*  It is not intended to be configured through the XML.
+*  The default value here is 2. */
+   int getMirrorAckManagerMaxPageAttempts();
+
+   Configuration setMirrorAckManagerMaxPageAttempts(int maxPageAttempts);
+
+   /** This configures the interval in which the Mirror AckManager will retry 
acks when
+*  It is not intended to be configured through the XML.
+*  The default value here is 100, and this is in milliseconds. */
+   int getMirrorAckManagerRetryDelay();
+
+   Configuration setMirrorAckManagerRetryDelay(int delay);
+
+   /** Should Mirror use Page Transactions When target destinations is paging?
+*  When a target queue on the mirror is paged, the mirror will not record 
a page transaction for every message.
+*  The default is false, and the overhead of paged messages will be 
smaller, but there is a possibility of eventual duplicates in case of 
interrupted communication between the mirror source and target.
+*  If you set this to false there will be extra syncs and a record stored 
on the journal for the page-transaction additionally to the record in the page 
store. */

Review Comment:
   The 'default is false, and the overhead will be smaller'but then, 'if 
you set this false, there will be \' ?Which is it?



##
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/MirrorTransaction.java:
##
@@ -49,4 +51,13 @@ protected synchronized void 
afterCommit(List operationsToC
   }
}
 
+   @Override
+   public boolean isAllowPageTransaction() {
+  return ignorePageTransaction;
+   }
+
+   public MirrorTransaction setIgnorePageTransaction(boolean 
ignorePageTransaction) {
+  this.ignorePageTransaction = ignorePageTransaction;
+  return this;
+   }

Review Comment:
   The naming of the methods, and the variable feels off. The variable defaults 
to false, so ignorePageTransaction=false, meaning the return of 
'isAllowPageTransaction()' is false. So it 'isnt ignored', but it also 'isnt 
allowed'? Confusing. Is there a better name here for one of them to make 
clearer?



##
artemis-commons/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQScheduledComponent.java:
##
@@ -212,15 +212,19 @@ public long getPeriod() {
}
 
public synchronized ActiveMQScheduledComponent setPeriod(long period) {
-  this.period = period;
-  restartIfNeeded();
+  if (this.period != period) {
+ this.period = period;
+ restartIfNeeded();
+  }
   return this;
}
 
public synchronized ActiveMQScheduledComponent setPeriod(long period, 
TimeUnit unit) {
-  this.period = period;
-  this.timeUnit = unit;
-  restartIfNeeded();
+  if (this.period != period && this.timeUnit != unit) {

Review Comment:
   Should this not be using "||" rather than "&&" so that if _either_ the 
period or time units changes,  it updates things.
   
   Though that itself still isnt quite foolproof either, as both changes could 
effectively cancel each other out...e.g 1 sec vs 1000 ms. Probably more of a 
corner case there.
   
   Should probably check the units aren't null..



##
artemis-server/src/main/java/org/apache/activemq/artemis/core/transaction/Transaction.java:
##
@@ -109,4 +109,8 @@ enum State {
 
/** To be used on control transactions that are meant as internal and don't 
really require a hard sync. */
Transaction setAsync(boolean async);
+
+   default boolean isAllowPageTransaction() {
+  return true;
+   }

Review Comment:
   Similar confusion that this code default is true, but the overriding method 
looks to get a field value thats false by default?





Issue Time Tracking
---

[jira] [Work logged] (ARTEMIS-1769) Return JMS Session's ClientID via JMX

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1769?focusedWorklogId=917312=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917312
 ]

ASF GitHub Bot logged work on ARTEMIS-1769:
---

Author: ASF GitHub Bot
Created on: 02/May/24 15:42
Start Date: 02/May/24 15:42
Worklog Time Spent: 10m 
  Work Description: gemmellr merged PR #4919:
URL: https://github.com/apache/activemq-artemis/pull/4919




Issue Time Tracking
---

Worklog Id: (was: 917312)
Time Spent: 40m  (was: 0.5h)

> Return JMS Session's ClientID via JMX
> -
>
> Key: ARTEMIS-1769
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1769
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.5.0
>Reporter: Maxim Kalina
>Assignee: Justin Bertram
>Priority: Minor
>  Labels: patch
> Fix For: 2.34.0
>
> Attachments: return_jms_session's_clientID_via_JMX_if_exists.patch
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> As discussed in the mailing list, currently there is no possibility to get 
> the JMS session's *clientID* via JMX.
>  
> I've attached the patch that extends the *ActiveMQServerControlImpl* and 
> *SessionView* classes to return the *clientID* if available.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4751) Upgrade to Apache parent 32

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4751?focusedWorklogId=917310=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917310
 ]

ASF GitHub Bot logged work on ARTEMIS-4751:
---

Author: ASF GitHub Bot
Created on: 02/May/24 15:24
Start Date: 02/May/24 15:24
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on code in PR #4911:
URL: https://github.com/apache/activemq-artemis/pull/4911#discussion_r1587297455


##
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/messages/perf/MicrosClock.java:
##
@@ -1,65 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.apache.activemq.artemis.cli.commands.messages.perf;
-
-import java.util.concurrent.TimeUnit;
-
-public class MicrosClock {
-
-   // no need for volatile here
-   private static long offset = -1;
-   private static long NANOS_PER_SECOND = TimeUnit.SECONDS.toNanos(1);
-
-   private static final boolean AVAILABLE = checkAvailable();
-
-   private static boolean checkAvailable() {
-  try {
- final long now = now();
- if (now < 0) {
-return false;
- }
- return true;
-  } catch (Throwable t) {
- return false;
-  }
-   }
-
-   public static boolean isAvailable() {
-  return AVAILABLE;
-   }
-
-   public static long now() {
-  long epochSecond = offset;
-  long nanoAdjustment = 
jdk.internal.misc.VM.getNanoTimeAdjustment(epochSecond);
-
-  if (nanoAdjustment == -1) {
- epochSecond = System.currentTimeMillis() / 1000 - 1024;
- nanoAdjustment = 
jdk.internal.misc.VM.getNanoTimeAdjustment(epochSecond);
- if (nanoAdjustment == -1) {
-throw new InternalError("Offset " + epochSecond + " is not in 
range");
- } else {
-offset = epochSecond;
- }
-  }
-  final long secs = Math.addExact(epochSecond, 
Math.floorDiv(nanoAdjustment, NANOS_PER_SECOND));
-  final long secsInUs = TimeUnit.SECONDS.toMicros(secs);
-  final long nsOffset = (int) Math.floorMod(nanoAdjustment, 
NANOS_PER_SECOND);
-  final long usOffset = TimeUnit.NANOSECONDS.toMicros(nsOffset);
-  return secsInUs + usOffset;
-   }

Review Comment:
   Seems like this could fairly significantly change the behaviour of the tool 
given its using this for rates and timing. Also feels weird as it all still 
references the MicrosTimeProvider that used this in various places. 
   
   Can this be done with reflection and still work, instead of removing it? If 
so, seems like it probably should be rather than the (silent?) change to 
existing behaviour.





Issue Time Tracking
---

Worklog Id: (was: 917310)
Time Spent: 20m  (was: 10m)

> Upgrade to Apache parent 32
> ---
>
> Key: ARTEMIS-4751
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4751
> Project: ActiveMQ Artemis
>  Issue Type: Dependency upgrade
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4754) Make configuring security for AMQP federation user accounts simpler

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4754?focusedWorklogId=917304=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917304
 ]

ASF GitHub Bot logged work on ARTEMIS-4754:
---

Author: ASF GitHub Bot
Created on: 02/May/24 14:54
Start Date: 02/May/24 14:54
Worklog Time Spent: 10m 
  Work Description: gemmellr merged PR #4916:
URL: https://github.com/apache/activemq-artemis/pull/4916




Issue Time Tracking
---

Worklog Id: (was: 917304)
Time Spent: 40m  (was: 0.5h)

> Make configuring security for AMQP federation user accounts simpler
> ---
>
> Key: ARTEMIS-4754
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4754
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: AMQP
>Affects Versions: 2.33.0
>Reporter: Timothy A. Bish
>Assignee: Timothy A. Bish
>Priority: Major
> Fix For: 2.34.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> When creating the user account used to restrict access when securing an AMQP 
> federation account the currently implementation requires giving the 
> federation overly broad access so that it can create control and event queues 
> used for its internal mechanisms.  We should make this easier and more narrow 
> so that a federation user can be granted access to a more limited set of 
> resources for internal federation mechanics besides access to those addresses 
> and queues which will be targets of federation.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-1769) Return JMS Session's ClientID via JMX

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1769?focusedWorklogId=917303=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917303
 ]

ASF GitHub Bot logged work on ARTEMIS-1769:
---

Author: ASF GitHub Bot
Created on: 02/May/24 14:45
Start Date: 02/May/24 14:45
Worklog Time Spent: 10m 
  Work Description: jbertram opened a new pull request, #4919:
URL: https://github.com/apache/activemq-artemis/pull/4919

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 917303)
Time Spent: 0.5h  (was: 20m)

> Return JMS Session's ClientID via JMX
> -
>
> Key: ARTEMIS-1769
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1769
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.5.0
>Reporter: Maxim Kalina
>Assignee: Justin Bertram
>Priority: Minor
>  Labels: patch
> Fix For: 2.34.0
>
> Attachments: return_jms_session's_clientID_via_JMX_if_exists.patch
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> As discussed in the mailing list, currently there is no possibility to get 
> the JMS session's *clientID* via JMX.
>  
> I've attached the patch that extends the *ActiveMQServerControlImpl* and 
> *SessionView* classes to return the *clientID* if available.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4758) Hardening Mirroring

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4758?focusedWorklogId=917302=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917302
 ]

ASF GitHub Bot logged work on ARTEMIS-4758:
---

Author: ASF GitHub Bot
Created on: 02/May/24 14:30
Start Date: 02/May/24 14:30
Worklog Time Spent: 10m 
  Work Description: clebertsuconic opened a new pull request, #4918:
URL: https://github.com/apache/activemq-artemis/pull/4918

   This is a list of improvements done as part of this commit / task:
   
   * Page Transactions on mirror target are now optional.
   
   If you had an interrupt mirror while the target destination was paging, 
duplicate detection would be ineffective unless you used paged transactions 
Users can now configure the ack manager retries intervals. Say you need some 
time to remove a consumer from a target mirror. The delivering references would 
prevent acks from happening. You can allow bigger retry intervals and number of 
retries by tinkiering with ack manager retry parameters.
   
   * AckManager restarted independent of incoming acks
   
   The ackManager was only restarted when new acks were coming in. If you 
stopped receiving acks on a target server and restarted that server with 
pending acks, those acks would never be exercised. The AckManager retries are 
now restarted as soon as the server is started.




Issue Time Tracking
---

Worklog Id: (was: 917302)
Remaining Estimate: 0h
Time Spent: 10m

> Hardening Mirroring
> ---
>
> Key: ARTEMIS-4758
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4758
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Clebert Suconic
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> I have been extensively testing mirroring, and I'm hardening it as an overal 
> task, improving its behavior:
> - Page Transactions on mirror target are now optional.
>   * If you had an interrupt mirror while the target destination was paging, 
> duplicate detection would be ineffective unless you used paged transactions
>   * Users can now configure the ack manager retries intervals.
>   Say you need some time to remove a consumer from a target mirror. The 
> delivering references would prevent acks from happening. You can allow bigger 
> retry intervals and number of retries by tinkiering with ack manager retry 
> parameters.
>   * The ackManager was only restarted when new acks were coming in. If you 
> stopped receiving acks on a target server and restarted that server with 
> pending acks, those acks would never be exercised. The AckManager retries are 
> now restarted as soon as the server is started.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4754) Make configuring security for AMQP federation user accounts simpler

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4754?focusedWorklogId=917296=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917296
 ]

ASF GitHub Bot logged work on ARTEMIS-4754:
---

Author: ASF GitHub Bot
Created on: 02/May/24 13:55
Start Date: 02/May/24 13:55
Worklog Time Spent: 10m 
  Work Description: tabish121 commented on PR #4916:
URL: 
https://github.com/apache/activemq-artemis/pull/4916#issuecomment-2090563287

   > LGTM too. Might be best for e.g @jbertram to look before merge too, given 
the match change.
   
   @jbertram actually helped me figure out why the wildcards weren't working on 
the internal addresses. We both thought it should be working already before 
tracking down the change here.




Issue Time Tracking
---

Worklog Id: (was: 917296)
Time Spent: 0.5h  (was: 20m)

> Make configuring security for AMQP federation user accounts simpler
> ---
>
> Key: ARTEMIS-4754
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4754
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: AMQP
>Affects Versions: 2.33.0
>Reporter: Timothy A. Bish
>Assignee: Timothy A. Bish
>Priority: Major
> Fix For: 2.34.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> When creating the user account used to restrict access when securing an AMQP 
> federation account the currently implementation requires giving the 
> federation overly broad access so that it can create control and event queues 
> used for its internal mechanisms.  We should make this easier and more narrow 
> so that a federation user can be granted access to a more limited set of 
> resources for internal federation mechanics besides access to those addresses 
> and queues which will be targets of federation.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4754) Make configuring security for AMQP federation user accounts simpler

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4754?focusedWorklogId=917275=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917275
 ]

ASF GitHub Bot logged work on ARTEMIS-4754:
---

Author: ASF GitHub Bot
Created on: 02/May/24 11:35
Start Date: 02/May/24 11:35
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on PR #4916:
URL: 
https://github.com/apache/activemq-artemis/pull/4916#issuecomment-2090279928

   LGTM too. Might be best for e.g @jbertram to look before merge too, given 
the match change.




Issue Time Tracking
---

Worklog Id: (was: 917275)
Time Spent: 20m  (was: 10m)

> Make configuring security for AMQP federation user accounts simpler
> ---
>
> Key: ARTEMIS-4754
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4754
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: AMQP
>Affects Versions: 2.33.0
>Reporter: Timothy A. Bish
>Assignee: Timothy A. Bish
>Priority: Major
> Fix For: 2.34.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> When creating the user account used to restrict access when securing an AMQP 
> federation account the currently implementation requires giving the 
> federation overly broad access so that it can create control and event queues 
> used for its internal mechanisms.  We should make this easier and more narrow 
> so that a federation user can be granted access to a more limited set of 
> resources for internal federation mechanics besides access to those addresses 
> and queues which will be targets of federation.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=917271=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917271
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 02/May/24 11:28
Start Date: 02/May/24 11:28
Worklog Time Spent: 10m 
  Work Description: gemmellr merged PR #14:
URL: https://github.com/apache/activemq-artemis-console/pull/14




Issue Time Tracking
---

Worklog Id: (was: 917271)
Time Spent: 10h 10m  (was: 10h)

> Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
> Fix For: console-1.0.0
>
>  Time Spent: 10h 10m
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> As it can run standalone and be built seperately, this will be released 
> independently from [https://github.com/apache/activemq-artemis-console] and 
> the output later consumed in Artemis releases (similar to artemis-native).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=917270=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917270
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 02/May/24 11:18
Start Date: 02/May/24 11:18
Worklog Time Spent: 10m 
  Work Description: andytaylor opened a new pull request, #14:
URL: https://github.com/apache/activemq-artemis-console/pull/14

   more upgrades to components in extension




Issue Time Tracking
---

Worklog Id: (was: 917270)
Time Spent: 10h  (was: 9h 50m)

> Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
> Fix For: console-1.0.0
>
>  Time Spent: 10h
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> As it can run standalone and be built seperately, this will be released 
> independently from [https://github.com/apache/activemq-artemis-console] and 
> the output later consumed in Artemis releases (similar to artemis-native).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=917261=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917261
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 02/May/24 09:41
Start Date: 02/May/24 09:41
Worklog Time Spent: 10m 
  Work Description: gemmellr merged PR #11:
URL: https://github.com/apache/activemq-artemis-console/pull/11




Issue Time Tracking
---

Worklog Id: (was: 917261)
Time Spent: 9h 50m  (was: 9h 40m)

> Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
> Fix For: console-1.0.0
>
>  Time Spent: 9h 50m
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> As it can run standalone and be built seperately, this will be released 
> independently from [https://github.com/apache/activemq-artemis-console] and 
> the output later consumed in Artemis releases (similar to artemis-native).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4752) Upgrade ErrorProne to 2.27.0

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4752?focusedWorklogId=917255=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917255
 ]

ASF GitHub Bot logged work on ARTEMIS-4752:
---

Author: ASF GitHub Bot
Created on: 02/May/24 09:13
Start Date: 02/May/24 09:13
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on PR #4912:
URL: 
https://github.com/apache/activemq-artemis/pull/4912#issuecomment-2089978398

   I only asked not to merge the other one and have me roll related changes 
into my work since it was quite big but wasnt actually 'fixing' anything that 
was 'broken', so it would have been annoying to deal with the conflicts given 
that...this is fixing stuff, so it goes in and I deal with it along with the 
other rebase stuff needed. (Happily its also smaller).




Issue Time Tracking
---

Worklog Id: (was: 917255)
Time Spent: 40m  (was: 0.5h)

> Upgrade ErrorProne to 2.27.0
> 
>
> Key: ARTEMIS-4752
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4752
> Project: ActiveMQ Artemis
>  Issue Type: Dependency upgrade
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4752) Upgrade ErrorProne to 2.27.0

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4752?focusedWorklogId=917253=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917253
 ]

ASF GitHub Bot logged work on ARTEMIS-4752:
---

Author: ASF GitHub Bot
Created on: 02/May/24 09:10
Start Date: 02/May/24 09:10
Worklog Time Spent: 10m 
  Work Description: gemmellr merged PR #4912:
URL: https://github.com/apache/activemq-artemis/pull/4912




Issue Time Tracking
---

Worklog Id: (was: 917253)
Time Spent: 0.5h  (was: 20m)

> Upgrade ErrorProne to 2.27.0
> 
>
> Key: ARTEMIS-4752
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4752
> Project: ActiveMQ Artemis
>  Issue Type: Dependency upgrade
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=917247=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917247
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 02/May/24 08:54
Start Date: 02/May/24 08:54
Worklog Time Spent: 10m 
  Work Description: andytaylor opened a new pull request, #11:
URL: https://github.com/apache/activemq-artemis-console/pull/11

   upgrade components in extension
   
   https://issues.apache.org/jira/browse/ARTEMIS-4680




Issue Time Tracking
---

Worklog Id: (was: 917247)
Time Spent: 9h 40m  (was: 9.5h)

> Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
> Fix For: console-1.0.0
>
>  Time Spent: 9h 40m
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> As it can run standalone and be built seperately, this will be released 
> independently from [https://github.com/apache/activemq-artemis-console] and 
> the output later consumed in Artemis releases (similar to artemis-native).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (AMQ-9488) Upgrade to jackson 2.17.0

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/AMQ-9488?focusedWorklogId=917240=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917240
 ]

ASF GitHub Bot logged work on AMQ-9488:
---

Author: ASF GitHub Bot
Created on: 02/May/24 07:55
Start Date: 02/May/24 07:55
Worklog Time Spent: 10m 
  Work Description: jbonofre merged PR #1212:
URL: https://github.com/apache/activemq/pull/1212




Issue Time Tracking
---

Worklog Id: (was: 917240)
Time Spent: 20m  (was: 10m)

> Upgrade to jackson 2.17.0
> -
>
> Key: AMQ-9488
> URL: https://issues.apache.org/jira/browse/AMQ-9488
> Project: ActiveMQ Classic
>  Issue Type: Dependency upgrade
>  Components: Broker, Transport
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4757) Upgrade Netty to 4.1.109.Final

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4757?focusedWorklogId=917211=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917211
 ]

ASF GitHub Bot logged work on ARTEMIS-4757:
---

Author: ASF GitHub Bot
Created on: 02/May/24 00:08
Start Date: 02/May/24 00:08
Worklog Time Spent: 10m 
  Work Description: jbertram opened a new pull request, #4917:
URL: https://github.com/apache/activemq-artemis/pull/4917

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 917211)
Remaining Estimate: 0h
Time Spent: 10m

> Upgrade Netty to 4.1.109.Final
> --
>
> Key: ARTEMIS-4757
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4757
> Project: ActiveMQ Artemis
>  Issue Type: Dependency upgrade
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4754) Make configuring security for AMQP federation user accounts simpler

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4754?focusedWorklogId=917197=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917197
 ]

ASF GitHub Bot logged work on ARTEMIS-4754:
---

Author: ASF GitHub Bot
Created on: 01/May/24 20:46
Start Date: 01/May/24 20:46
Worklog Time Spent: 10m 
  Work Description: tabish121 opened a new pull request, #4916:
URL: https://github.com/apache/activemq-artemis/pull/4916

   When creating internal temporary queues for the federation control links and 
the events link we should use a structured naming convention to ease in 
configuring security for the federation user where all internal names fall 
under a root prefix which can be used to grant read and write access for the 
federation user. This change allows security on the wildcarded address 
"$ACTIVEMQ_ARTEMIS_FEDERATION.#". This change also includes some further 
restrictions added to federation resources and adds support for wildcarding '$' 
prefixed addresses.




Issue Time Tracking
---

Worklog Id: (was: 917197)
Remaining Estimate: 0h
Time Spent: 10m

> Make configuring security for AMQP federation user accounts simpler
> ---
>
> Key: ARTEMIS-4754
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4754
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: AMQP
>Affects Versions: 2.33.0
>Reporter: Timothy A. Bish
>Assignee: Timothy A. Bish
>Priority: Major
> Fix For: 2.34.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> When creating the user account used to restrict access when securing an AMQP 
> federation account the currently implementation requires giving the 
> federation overly broad access so that it can create control and event queues 
> used for its internal mechanisms.  We should make this easier and more narrow 
> so that a federation user can be granted access to a more limited set of 
> resources for internal federation mechanics besides access to those addresses 
> and queues which will be targets of federation.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4756) Upgrade Commons IO to 2.16.1

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4756?focusedWorklogId=917193=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917193
 ]

ASF GitHub Bot logged work on ARTEMIS-4756:
---

Author: ASF GitHub Bot
Created on: 01/May/24 20:29
Start Date: 01/May/24 20:29
Worklog Time Spent: 10m 
  Work Description: jbertram opened a new pull request, #4915:
URL: https://github.com/apache/activemq-artemis/pull/4915

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 917193)
Remaining Estimate: 0h
Time Spent: 10m

> Upgrade Commons IO to 2.16.1
> 
>
> Key: ARTEMIS-4756
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4756
> Project: ActiveMQ Artemis
>  Issue Type: Dependency upgrade
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4755) Upgrade Jackson to 2.17.0

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4755?focusedWorklogId=917191=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917191
 ]

ASF GitHub Bot logged work on ARTEMIS-4755:
---

Author: ASF GitHub Bot
Created on: 01/May/24 20:26
Start Date: 01/May/24 20:26
Worklog Time Spent: 10m 
  Work Description: jbertram opened a new pull request, #4913:
URL: https://github.com/apache/activemq-artemis/pull/4913

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 917191)
Remaining Estimate: 0h
Time Spent: 10m

> Upgrade Jackson to 2.17.0
> -
>
> Key: ARTEMIS-4755
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4755
> Project: ActiveMQ Artemis
>  Issue Type: Dependency upgrade
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4753) Upgrade CheckStyle to 10.16.0

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4753?focusedWorklogId=917192=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917192
 ]

ASF GitHub Bot logged work on ARTEMIS-4753:
---

Author: ASF GitHub Bot
Created on: 01/May/24 20:26
Start Date: 01/May/24 20:26
Worklog Time Spent: 10m 
  Work Description: jbertram opened a new pull request, #4914:
URL: https://github.com/apache/activemq-artemis/pull/4914

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 917192)
Remaining Estimate: 0h
Time Spent: 10m

> Upgrade CheckStyle to 10.16.0
> -
>
> Key: ARTEMIS-4753
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4753
> Project: ActiveMQ Artemis
>  Issue Type: Dependency upgrade
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4752) Upgrade ErrorProne to 2.27.0

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4752?focusedWorklogId=917175=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917175
 ]

ASF GitHub Bot logged work on ARTEMIS-4752:
---

Author: ASF GitHub Bot
Created on: 01/May/24 19:45
Start Date: 01/May/24 19:45
Worklog Time Spent: 10m 
  Work Description: jbertram commented on PR #4912:
URL: 
https://github.com/apache/activemq-artemis/pull/4912#issuecomment-2089002247

   @gemmellr, I don't meant to step on your toes with your work on the JUnit 5 
upgrade, but these test changes were necessary for the upgrade. If necessary we 
can certainly wait until your done if you prefer.




Issue Time Tracking
---

Worklog Id: (was: 917175)
Time Spent: 20m  (was: 10m)

> Upgrade ErrorProne to 2.27.0
> 
>
> Key: ARTEMIS-4752
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4752
> Project: ActiveMQ Artemis
>  Issue Type: Dependency upgrade
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4752) Upgrade ErrorProne to 2.27.0

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4752?focusedWorklogId=917173=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917173
 ]

ASF GitHub Bot logged work on ARTEMIS-4752:
---

Author: ASF GitHub Bot
Created on: 01/May/24 19:44
Start Date: 01/May/24 19:44
Worklog Time Spent: 10m 
  Work Description: jbertram opened a new pull request, #4912:
URL: https://github.com/apache/activemq-artemis/pull/4912

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 917173)
Remaining Estimate: 0h
Time Spent: 10m

> Upgrade ErrorProne to 2.27.0
> 
>
> Key: ARTEMIS-4752
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4752
> Project: ActiveMQ Artemis
>  Issue Type: Dependency upgrade
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4751) Upgrade to Apache parent 32

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4751?focusedWorklogId=917154=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917154
 ]

ASF GitHub Bot logged work on ARTEMIS-4751:
---

Author: ASF GitHub Bot
Created on: 01/May/24 18:48
Start Date: 01/May/24 18:48
Worklog Time Spent: 10m 
  Work Description: jbertram opened a new pull request, #4911:
URL: https://github.com/apache/activemq-artemis/pull/4911

   Due to https://github.com/apache/maven-apache-parent/pull/188 the property 
`maven.compiler.release` is now being set which precludes exporting and using 
any internal Java classes. Therefore this commit removed references to 
`--add-exports` from the build and removed any usage of the relevant classes 
from the code-base.




Issue Time Tracking
---

Worklog Id: (was: 917154)
Remaining Estimate: 0h
Time Spent: 10m

> Upgrade to Apache parent 32
> ---
>
> Key: ARTEMIS-4751
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4751
> Project: ActiveMQ Artemis
>  Issue Type: Dependency upgrade
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=917138=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917138
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 01/May/24 16:06
Start Date: 01/May/24 16:06
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on PR #2:
URL: 
https://github.com/apache/activemq-artemis-console/pull/2#issuecomment-2088688383

   Seems good to me now, and given its been over a month across 2 repos without 
a single comment from anybody else...merged.




Issue Time Tracking
---

Worklog Id: (was: 917138)
Time Spent: 9.5h  (was: 9h 20m)

> Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>  Time Spent: 9.5h
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> A WIP can be found 
> [here|https://github.com/andytaylor/activemq-artemis/tree/artemis-console-ng]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=917137=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917137
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 01/May/24 16:05
Start Date: 01/May/24 16:05
Worklog Time Spent: 10m 
  Work Description: gemmellr merged PR #2:
URL: https://github.com/apache/activemq-artemis-console/pull/2




Issue Time Tracking
---

Worklog Id: (was: 917137)
Time Spent: 9h 20m  (was: 9h 10m)

> Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>  Time Spent: 9h 20m
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> A WIP can be found 
> [here|https://github.com/andytaylor/activemq-artemis/tree/artemis-console-ng]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=917116=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917116
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 01/May/24 12:28
Start Date: 01/May/24 12:28
Worklog Time Spent: 10m 
  Work Description: andytaylor commented on code in PR #2:
URL: 
https://github.com/apache/activemq-artemis-console/pull/2#discussion_r1586246683


##
pom.xml:
##
@@ -0,0 +1,226 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+
+org.apache
+apache
+31
+org.apache:apache
+
+
+org.apache.activemq
+artemis-console-project
+pom
+1.0.0-SNAPSHOT
+
+
+
+artemis-console-extension
+artemis-console-war
+artemis-console-distribution
+
+
+ActiveMQ Artemis Console Plugin
+https://activemq.apache.org/components/artemis/
+
+
+11
+11
+11
+4.0.0
+5.0.0
+2.0.12
+2.22.1
+11.0.20
+v20.9.0
+v1.22.21
+1.15.0
+ Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>  Time Spent: 9h 10m
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> A WIP can be found 
> [here|https://github.com/andytaylor/activemq-artemis/tree/artemis-console-ng]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=917113=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917113
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 01/May/24 10:44
Start Date: 01/May/24 10:44
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on code in PR #2:
URL: 
https://github.com/apache/activemq-artemis-console/pull/2#discussion_r1586077228


##
artemis-console-extension/pom.xml:
##
@@ -0,0 +1,104 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+
+org.apache.activemq
+artemis-console-project
+1.0.0-SNAPSHOT
+
+
+org.apache.activemq
+artemis-console-extension
+pom
+
+
+ActiveMQ Artemis Console

Review Comment:
   ActiveMQ Artemis Console Extension?



##
NOTICE:
##
@@ -0,0 +1,5 @@
+Apache ActiveMQ Artemis Console Plugin

Review Comment:
   Drop the "Plugin" now ?



##
pom.xml:
##
@@ -0,0 +1,226 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+
+org.apache
+apache
+31
+org.apache:apache
+
+
+org.apache.activemq
+artemis-console-project
+pom
+1.0.0-SNAPSHOT
+
+
+
+artemis-console-extension
+artemis-console-war
+artemis-console-distribution
+
+
+ActiveMQ Artemis Console Plugin
+https://activemq.apache.org/components/artemis/
+
+
+11
+11
+11
+4.0.0
+5.0.0
+2.0.12
+2.22.1
+11.0.20
+v20.9.0
+v1.22.21
+1.15.0
+ Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>  Time Spent: 9h
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> A WIP can be found 
> [here|https://github.com/andytaylor/activemq-artemis/tree/artemis-console-ng]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=917105=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917105
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 01/May/24 06:47
Start Date: 01/May/24 06:47
Worklog Time Spent: 10m 
  Work Description: andytaylor commented on code in PR #2:
URL: 
https://github.com/apache/activemq-artemis-console/pull/2#discussion_r1585945246


##
README.md:
##
@@ -1 +1,62 @@
-# activemq-artemis-console
+# Apache ActiveMQ Artemis Console
+
+
+The [Apache ActiveMQ Artemis](https://activemq.apache.org/components/artemis/) 
Console Plugin is written using [Hawtio v4](https://github.com/hawtio/hawtio).
+The plugin is written in TypeScript. Since a Hawtio plugin is based on React 
and [Webpack Module Federation](https://module-federation.github.io/),
+this project uses Yarn v3 and [CRACO](https://craco.js.org/) as the build 
tools.
+
+The WAR file created by this project is consumed by ActiveMQ Artemis but can 
be developed and run standalone.
+
+
+### Build
+
+The following command first builds the `artemis-console-extension` frontend 
project and then compiles and packages 
+the main Java project Web Archive in `artemis-console-war`.
+
+```console
+mvn clean install
+```
+
+Building the frontend project 'artemis-console-extension' can take time, so if 
you build it once and make no changes on the project afterwards, you 
+can speed up the whole build by skipping the frontend part next time.
+
+```console
+mvn install -Dskip.yarn
+```
+
+### Test run
+
+You can quickly run and test the console by using `jetty-maven-plugin` 
configured in `pom.xml`. It launches an embedded 
+Jetty server and deploys the plugin WAR application. From the 
'artemis-console-war' directory run:
+
+```console
+cd artemis-console-war
+mvn jetty:run -Dskip.yarn
+```
+
+You can access the Artemis console with the sample plugin at: 


Review Comment:
   Ive added some docs explaining how to use.





Issue Time Tracking
---

Worklog Id: (was: 917105)
Time Spent: 8h 40m  (was: 8.5h)

> Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>  Time Spent: 8h 40m
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> A WIP can be found 
> [here|https://github.com/andytaylor/activemq-artemis/tree/artemis-console-ng]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=917106=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917106
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 01/May/24 06:47
Start Date: 01/May/24 06:47
Worklog Time Spent: 10m 
  Work Description: andytaylor commented on code in PR #2:
URL: 
https://github.com/apache/activemq-artemis-console/pull/2#discussion_r1585945469


##
artemis-console-extension/artemis-extension/src/artemis-extension/artemis/brokers/BrokerTopology.tsx:
##
@@ -0,0 +1,671 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import * as React from 'react';
+
+import { RegionsIcon as Icon1 } from '@patternfly/react-icons';
+import { FolderOpenIcon as Icon2 } from '@patternfly/react-icons';
+import { ClusterIcon } from '@patternfly/react-icons';
+
+import {
+  ColaLayout,
+  ComponentFactory,
+  DefaultEdge,
+  DefaultGroup,
+  DefaultNode,
+  DragObjectWithType,
+  Edge,
+  EdgeModel,
+  EdgeStyle,
+  Graph,
+  GraphComponent,
+  graphDropTargetSpec,
+  GRAPH_LAYOUT_END_EVENT,
+  groupDropTargetSpec,
+  Layout,
+  LayoutFactory,
+  Model,
+  ModelKind,
+  Node,
+  nodeDragSourceSpec,
+  nodeDropTargetSpec,
+  NodeModel,
+  NodeShape,
+  NodeStatus,
+  observer,
+  SELECTION_EVENT,
+  TopologyView,
+  Visualization,
+  VisualizationProvider,
+  VisualizationSurface,
+  withDndDrop,
+  WithDndDropProps,
+  withDragNode,
+  WithDragNodeProps,
+  withPanZoom,
+  withSelection,
+  WithSelectionProps,
+  withTargetDrag
+} from '@patternfly/react-topology';
+import { useEffect, useState } from 'react';
+import { artemisService, BrokerInfo } from '../artemis-service';
+import { eventService } from '@hawtio/react';
+import { ToolbarItem, Select, SelectVariant, SelectOption } from 
'@patternfly/react-core';
+
+
+const BadgeColors = [
+  {
+name: 'A',
+badgeColor: '#ace12e',
+badgeTextColor: '#0f280d',
+badgeBorderColor: '#486b00'
+  },
+  {
+name: 'B',
+badgeColor: '#F2F0FC',
+badgeTextColor: '#5752d1',
+badgeBorderColor: '#CBC1FF'
+  },
+  {
+name: 'Broker',
+badgeColor: '#c12766',
+badgeTextColor: 'white',
+badgeBorderColor: '#CBC1FF'
+  },
+  {
+name: 'Address',
+badgeColor: '#3e489f',
+badgeTextColor: 'white',
+badgeBorderColor: '#CBC1FF'
+  },
+  {
+name: 'Queue',
+badgeColor: '#50621d',
+badgeTextColor: 'white',
+badgeBorderColor: '#CBC1FF'
+  },
+  {
+name: 'Internal Address',
+badgeColor: 'white',
+badgeTextColor: 'black',
+badgeBorderColor: '#CBC1FF'
+  },
+  {
+name: 'Internal Queue',
+badgeColor: 'white',
+badgeTextColor: 'black',
+badgeBorderColor: '#CBC1FF'
+  }
+];
+
+interface ControllerState {
+  selectedIds: string[];
+  viewOptions: ViewOptions;
+}
+
+type CustomNodeProps = {
+  element: Node;
+} & WithDragNodeProps;
+
+const CustomNode: React.FC = ({ element, onSelect, selected, ...rest 
 }) => {
+
+  const data = element.getData();
+  const Icon = data.isAlternate ? Icon2 : Icon1;
+  const badgeColors = BadgeColors.find(badgeColor => badgeColor.name === 
data.badge);
+
+  return (  
+
+  
+
+  
+
+  );
+};
+
+const BrokerCustomNode: React.FC = observer(({ element, onSelect, 
selected, ...rest }) => {
+  const data = element.getData();
+  const Icon = ClusterIcon;
+  const badgeColors = BadgeColors.find(badgeColor => badgeColor.name === 
data.badge);
+  const { viewOptions } = element.getController().getState();
+
+  return (
+
+  
+
+  
+
+  );
+});
+
+const AddressCustomNode: React.FC = ({ element, onSelect, selected, ...rest 
 }) => {
+  const data = element.getData();
+  const badgeColors = BadgeColors.find(badgeColor => badgeColor.name === 
data.badge);
+  const { viewOptions } = element.getController().getState();
+
+  return (
+
+
+  );
+};
+
+const InternalAddressCustomNode: React.FC = ({ element, onSelect, selected, 
...rest  }) => {
+  const data = element.getData();
+  const badgeColors = BadgeColors.find(badgeColor => badgeColor.name === 
data.badge);

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=917103=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917103
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 01/May/24 06:46
Start Date: 01/May/24 06:46
Worklog Time Spent: 10m 
  Work Description: andytaylor commented on code in PR #2:
URL: 
https://github.com/apache/activemq-artemis-console/pull/2#discussion_r1585944729


##
artemis-console-war/pom.xml:
##
@@ -0,0 +1,111 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+
+org.apache.activemq
+artemis-console-project
+1.0.0-SNAPSHOT
+
+
+org.apache.activemq
+artemis-console-war
+war
+
+
+ActiveMQ Artemis Console War
+
+
+ Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>  Time Spent: 8h 20m
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> A WIP can be found 
> [here|https://github.com/andytaylor/activemq-artemis/tree/artemis-console-ng]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=917104=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917104
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 01/May/24 06:46
Start Date: 01/May/24 06:46
Worklog Time Spent: 10m 
  Work Description: andytaylor commented on code in PR #2:
URL: 
https://github.com/apache/activemq-artemis-console/pull/2#discussion_r1585945037


##
artemis-console-war/pom.xml:
##
@@ -0,0 +1,111 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+
+org.apache.activemq
+artemis-console-project
+1.0.0-SNAPSHOT
+
+
+org.apache.activemq
+artemis-console-war
+war
+
+
+ActiveMQ Artemis Console War
+
+
+ Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>  Time Spent: 8.5h
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> A WIP can be found 
> [here|https://github.com/andytaylor/activemq-artemis/tree/artemis-console-ng]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-3622) MQTT can deadlock on client connection / disconnection

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-3622?focusedWorklogId=917049=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917049
 ]

ASF GitHub Bot logged work on ARTEMIS-3622:
---

Author: ASF GitHub Bot
Created on: 30/Apr/24 16:11
Start Date: 30/Apr/24 16:11
Worklog Time Spent: 10m 
  Work Description: jbertram opened a new pull request, #4909:
URL: https://github.com/apache/activemq-artemis/pull/4909

   This commit fixes the deadlock described on ARTEMIS-3622 by moving the 
synchronization "up" a level from the MQTTSession to the MQTTConnectionManager. 
It also eliminates the synchronization on the MQTTSessionState in the 
MQTTConnectionManager because it's no longer needed. This change should not 
only eliminate the deadlock, but improve performance relatively as well.
   
   There is no test associated with this commit as I wasn't able to reproduce 
the deadlock with any kind of straight-forward test. There was a test linked on 
the Jira, but it involved intrusive and fragile scaffolding and wasn't 
ultimately tenable. That said, I did test this fix with that test and it was 
successful. In any case, I think static analysis should be sufficient here as 
the changes are pretty straight-forward.




Issue Time Tracking
---

Worklog Id: (was: 917049)
Remaining Estimate: 0h
Time Spent: 10m

> MQTT can deadlock on client connection / disconnection
> --
>
> Key: ARTEMIS-3622
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3622
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: MQTT
>Affects Versions: 2.19.0
> Environment: Using the latest java 17 and artemis 2.19 but looking at 
> the code, it should affect 2.20 as well.
>Reporter: Marcelo Takeshi Fukushima
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> It seems that the {{MQTTProtocolHandler}} and {{MQTTConnectionManager}} are 
> on a racing condition and can deadlock themselves on misbehaving clients. I'm 
> including the relevant stack trace (ignore thread 11 that is just waiting for 
> the lock).
> Looking at the relevant code, it seems that the clean-up thread (88 on the 
> {{{}MQTTFailureListener{}}}) starts cleaning up the session state and then 
> the session, but when {{MQTTSession.stop}} calls 
> {{{}MQTTSessionState.clear{}}}, the session state is no longer the same (a 
> racy connection has replaced the session state with a brand new under the 
> same client-id).
> I think the methods connect and disconnect on the {{MQTTConnectionManager}} 
> could be marked as synchronized as a whole, to prevent racy connects / 
> disconnects (but since I don't know all the ins and outs of the code, you 
> guys might have a better fix).
> {noformat}
> Found one Java-level deadlock:
> =
> "Thread-11 
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$6@640f11a1)":
>   waiting to lock monitor 0x7f6d003368c0 (object 0x00045f29f240, a 
> org.apache.activemq.artemis.core.protocol.mqtt.MQTTSessionState),
>   which is held by "Thread-24 
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$6@640f11a1)"
> "Thread-24 
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$6@640f11a1)":
>   waiting to lock monitor 0x7f6d00336a80 (object 0x00045f2a1068, a 
> org.apache.activemq.artemis.core.protocol.mqtt.MQTTSession),
>   which is held by "Thread-88 
> (ActiveMQ-remoting-threads-ActiveMQServerImpl::name=0.0.0.0-212232499)"
> "Thread-88 
> (ActiveMQ-remoting-threads-ActiveMQServerImpl::name=0.0.0.0-212232499)":
>   waiting to lock monitor 0x7f6d003368c0 (object 0x00045f29f240, a 
> org.apache.activemq.artemis.core.protocol.mqtt.MQTTSessionState),
>   which is held by "Thread-24 
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$6@640f11a1)"
> Java stack information for the threads listed above:
> ===
> "Thread-11 
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$6@640f11a1)":
>   at 
> org.apache.activemq.artemis.core.protocol.mqtt.MQTTConnectionManager.disconnect(MQTTConnectionManager.java:150)
>   - waiting to lock <0x00045f29f240> (a 
> org.apache.activemq.artemis.core.protocol.mqtt.MQTTSessionState)
>   at 
> org.apache.activemq.artemis.core.protocol.mqtt.MQTTFailureListener.connectionFailed(MQTTFailureListener.java:37)
>   at 
> org.apache.activemq.artemis.core.protocol.mqtt.MQTTConnection.fail(MQTTConnection.java:150)
>   at 
> 

[jira] [Work logged] (AMQ-9499) Upgrade to maven-shade-plugin 3.5.3

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/AMQ-9499?focusedWorklogId=917018=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917018
 ]

ASF GitHub Bot logged work on AMQ-9499:
---

Author: ASF GitHub Bot
Created on: 30/Apr/24 13:05
Start Date: 30/Apr/24 13:05
Worklog Time Spent: 10m 
  Work Description: jbonofre opened a new pull request, #1217:
URL: https://github.com/apache/activemq/pull/1217

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 917018)
Remaining Estimate: 0h
Time Spent: 10m

> Upgrade to maven-shade-plugin 3.5.3
> ---
>
> Key: AMQ-9499
> URL: https://issues.apache.org/jira/browse/AMQ-9499
> Project: ActiveMQ Classic
>  Issue Type: Dependency upgrade
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (AMQ-9492) Upgrade to Apache POM 32

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/AMQ-9492?focusedWorklogId=917015=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917015
 ]

ASF GitHub Bot logged work on AMQ-9492:
---

Author: ASF GitHub Bot
Created on: 30/Apr/24 12:56
Start Date: 30/Apr/24 12:56
Worklog Time Spent: 10m 
  Work Description: jbonofre opened a new pull request, #1216:
URL: https://github.com/apache/activemq/pull/1216

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 917015)
Remaining Estimate: 0h
Time Spent: 10m

> Upgrade to Apache POM 32
> 
>
> Key: AMQ-9492
> URL: https://issues.apache.org/jira/browse/AMQ-9492
> Project: ActiveMQ Classic
>  Issue Type: Dependency upgrade
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (AMQ-9491) Upgrade to ASM 9.7

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/AMQ-9491?focusedWorklogId=917014=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917014
 ]

ASF GitHub Bot logged work on AMQ-9491:
---

Author: ASF GitHub Bot
Created on: 30/Apr/24 12:53
Start Date: 30/Apr/24 12:53
Worklog Time Spent: 10m 
  Work Description: jbonofre opened a new pull request, #1215:
URL: https://github.com/apache/activemq/pull/1215

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 917014)
Remaining Estimate: 0h
Time Spent: 10m

> Upgrade to ASM 9.7
> --
>
> Key: AMQ-9491
> URL: https://issues.apache.org/jira/browse/AMQ-9491
> Project: ActiveMQ Classic
>  Issue Type: Dependency upgrade
>  Components: Broker
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (AMQ-9490) Upgrade to commons-logging 1.3.1

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/AMQ-9490?focusedWorklogId=917012=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917012
 ]

ASF GitHub Bot logged work on AMQ-9490:
---

Author: ASF GitHub Bot
Created on: 30/Apr/24 12:51
Start Date: 30/Apr/24 12:51
Worklog Time Spent: 10m 
  Work Description: jbonofre opened a new pull request, #1214:
URL: https://github.com/apache/activemq/pull/1214

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 917012)
Remaining Estimate: 0h
Time Spent: 10m

> Upgrade to commons-logging 1.3.1
> 
>
> Key: AMQ-9490
> URL: https://issues.apache.org/jira/browse/AMQ-9490
> Project: ActiveMQ Classic
>  Issue Type: Dependency upgrade
>  Components: Broker
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (AMQ-9489) Upgrade to commons-io 2.16.1

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/AMQ-9489?focusedWorklogId=917010=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917010
 ]

ASF GitHub Bot logged work on AMQ-9489:
---

Author: ASF GitHub Bot
Created on: 30/Apr/24 12:49
Start Date: 30/Apr/24 12:49
Worklog Time Spent: 10m 
  Work Description: jbonofre opened a new pull request, #1213:
URL: https://github.com/apache/activemq/pull/1213

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 917010)
Remaining Estimate: 0h
Time Spent: 10m

> Upgrade to commons-io 2.16.1
> 
>
> Key: AMQ-9489
> URL: https://issues.apache.org/jira/browse/AMQ-9489
> Project: ActiveMQ Classic
>  Issue Type: Dependency upgrade
>  Components: Broker
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (AMQ-9488) Upgrade to jackson 2.17.0

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/AMQ-9488?focusedWorklogId=917007=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917007
 ]

ASF GitHub Bot logged work on AMQ-9488:
---

Author: ASF GitHub Bot
Created on: 30/Apr/24 12:47
Start Date: 30/Apr/24 12:47
Worklog Time Spent: 10m 
  Work Description: jbonofre opened a new pull request, #1212:
URL: https://github.com/apache/activemq/pull/1212

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 917007)
Remaining Estimate: 0h
Time Spent: 10m

> Upgrade to jackson 2.17.0
> -
>
> Key: AMQ-9488
> URL: https://issues.apache.org/jira/browse/AMQ-9488
> Project: ActiveMQ Classic
>  Issue Type: Dependency upgrade
>  Components: Broker, Transport
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (AMQ-9457) Add activemq-bom

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/AMQ-9457?focusedWorklogId=916935=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916935
 ]

ASF GitHub Bot logged work on AMQ-9457:
---

Author: ASF GitHub Bot
Created on: 30/Apr/24 00:36
Start Date: 30/Apr/24 00:36
Worklog Time Spent: 10m 
  Work Description: mattrpav merged PR #1178:
URL: https://github.com/apache/activemq/pull/1178




Issue Time Tracking
---

Worklog Id: (was: 916935)
Time Spent: 2h  (was: 1h 50m)

> Add activemq-bom
> 
>
> Key: AMQ-9457
> URL: https://issues.apache.org/jira/browse/AMQ-9457
> Project: ActiveMQ Classic
>  Issue Type: New Feature
>Reporter: Matt Pavlovich
>Assignee: Matt Pavlovich
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> Add an activemq-bom to assist in managing dependencies when using activemq 
> artifacts



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (AMQ-9480) Update activemq-osgi import for Jetty 11

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/AMQ-9480?focusedWorklogId=916933=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916933
 ]

ASF GitHub Bot logged work on AMQ-9480:
---

Author: ASF GitHub Bot
Created on: 30/Apr/24 00:27
Start Date: 30/Apr/24 00:27
Worklog Time Spent: 10m 
  Work Description: mattrpav merged PR #1205:
URL: https://github.com/apache/activemq/pull/1205




Issue Time Tracking
---

Worklog Id: (was: 916933)
Time Spent: 20m  (was: 10m)

> Update activemq-osgi import for Jetty 11
> 
>
> Key: AMQ-9480
> URL: https://issues.apache.org/jira/browse/AMQ-9480
> Project: ActiveMQ Classic
>  Issue Type: Task
>  Components: OSGi/Karaf
>Reporter: Matt Pavlovich
>Assignee: Matt Pavlovich
>Priority: Minor
> Fix For: 6.2.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (AMQ-9486) Upgrade Spring 6.1.6

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/AMQ-9486?focusedWorklogId=916931=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916931
 ]

ASF GitHub Bot logged work on AMQ-9486:
---

Author: ASF GitHub Bot
Created on: 30/Apr/24 00:14
Start Date: 30/Apr/24 00:14
Worklog Time Spent: 10m 
  Work Description: mattrpav merged PR #1211:
URL: https://github.com/apache/activemq/pull/1211




Issue Time Tracking
---

Worklog Id: (was: 916931)
Time Spent: 20m  (was: 10m)

> Upgrade Spring 6.1.6
> 
>
> Key: AMQ-9486
> URL: https://issues.apache.org/jira/browse/AMQ-9486
> Project: ActiveMQ Classic
>  Issue Type: Dependency upgrade
>Reporter: Matt Pavlovich
>Assignee: Matt Pavlovich
>Priority: Minor
> Fix For: 6.2.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (AMQ-9486) Upgrade Spring 6.1.6

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/AMQ-9486?focusedWorklogId=916873=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916873
 ]

ASF GitHub Bot logged work on AMQ-9486:
---

Author: ASF GitHub Bot
Created on: 29/Apr/24 16:07
Start Date: 29/Apr/24 16:07
Worklog Time Spent: 10m 
  Work Description: mattrpav opened a new pull request, #1211:
URL: https://github.com/apache/activemq/pull/1211

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 916873)
Remaining Estimate: 0h
Time Spent: 10m

> Upgrade Spring 6.1.6
> 
>
> Key: AMQ-9486
> URL: https://issues.apache.org/jira/browse/AMQ-9486
> Project: ActiveMQ Classic
>  Issue Type: Dependency upgrade
>Reporter: Matt Pavlovich
>Assignee: Matt Pavlovich
>Priority: Minor
> Fix For: 6.2.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4746) SIMILAR_BRANCHES.SWITCH Identical branches in switch node

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4746?focusedWorklogId=916776=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916776
 ]

ASF GitHub Bot logged work on ARTEMIS-4746:
---

Author: ASF GitHub Bot
Created on: 28/Apr/24 20:42
Start Date: 28/Apr/24 20:42
Worklog Time Spent: 10m 
  Work Description: jbertram merged PR #4908:
URL: https://github.com/apache/activemq-artemis/pull/4908




Issue Time Tracking
---

Worklog Id: (was: 916776)
Time Spent: 20m  (was: 10m)

> SIMILAR_BRANCHES.SWITCH Identical branches in switch node
> -
>
> Key: ARTEMIS-4746
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4746
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 2.33.0
>Reporter: Andrey Slepykh
>Assignee: Clebert Suconic
>Priority: Trivial
> Fix For: 2.34.0
>
> Attachments: Screenshot from 2024-04-28 17-46-07.png
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> In [class JMSExceptionHelper|#L27]]
> In this stack of screenshots I show that there is unnecessary logic, by 
> correcting which you can reduce the load on the computer and shorten the code
> !Screenshot from 2024-04-28 17-46-07.png!
> Some cases can be classified into groups, such as:
> a) 
>  # case CONNECTION_TIMEDOUT:
>     2. case INTERNAL_ERROR:
>     3. case NOT_CONNECTED:
> b)
>  # {{case ILLEGAL_STATE:}}
>     2. {{{}case OBJECT_CLOSED{}}}{{{}:{}}}
>     3. {{case UNSUPPORTED_PACKET}}
> c)
>    1. {{case QUEUE_DOES_NOT_EXIST:}}
>    2. {{case QUEUE_EXISTS:}}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4746) SIMILAR_BRANCHES.SWITCH Identical branches in switch node

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4746?focusedWorklogId=916773=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916773
 ]

ASF GitHub Bot logged work on ARTEMIS-4746:
---

Author: ASF GitHub Bot
Created on: 28/Apr/24 18:32
Start Date: 28/Apr/24 18:32
Worklog Time Spent: 10m 
  Work Description: clebertsuconic opened a new pull request, #4908:
URL: https://github.com/apache/activemq-artemis/pull/4908

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 916773)
Remaining Estimate: 0h
Time Spent: 10m

> SIMILAR_BRANCHES.SWITCH Identical branches in switch node
> -
>
> Key: ARTEMIS-4746
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4746
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: ActiveMQ-Artemis-Native
>Affects Versions: 2.25.0
>Reporter: Andrey Slepykh
>Assignee: Clebert Suconic
>Priority: Major
> Attachments: Screenshot from 2024-04-28 17-46-07.png
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> In [class JMSExceptionHelper|#L27]]
> In this stack of screenshots I show that there is unnecessary logic, by 
> correcting which you can reduce the load on the computer and shorten the code
> !Screenshot from 2024-04-28 17-46-07.png!
> Some cases can be classified into groups, such as:
> a) 
>  # case CONNECTION_TIMEDOUT:
>     2. case INTERNAL_ERROR:
>     3. case NOT_CONNECTED:
> b)
>  # {{case ILLEGAL_STATE:}}
>     2. {{{}case OBJECT_CLOSED{}}}{{{}:{}}}
>     3. {{case UNSUPPORTED_PACKET}}
> c)
>    1. {{case QUEUE_DOES_NOT_EXIST:}}
>    2. {{case QUEUE_EXISTS:}}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-1769) Return JMS Session's ClientID via JMX

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1769?focusedWorklogId=916739=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916739
 ]

ASF GitHub Bot logged work on ARTEMIS-1769:
---

Author: ASF GitHub Bot
Created on: 27/Apr/24 14:38
Start Date: 27/Apr/24 14:38
Worklog Time Spent: 10m 
  Work Description: jbertram merged PR #4892:
URL: https://github.com/apache/activemq-artemis/pull/4892




Issue Time Tracking
---

Worklog Id: (was: 916739)
Time Spent: 20m  (was: 10m)

> Return JMS Session's ClientID via JMX
> -
>
> Key: ARTEMIS-1769
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1769
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.5.0
>Reporter: Maxim Kalina
>Assignee: Justin Bertram
>Priority: Minor
>  Labels: patch
> Attachments: return_jms_session's_clientID_via_JMX_if_exists.patch
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> As discussed in the mailing list, currently there is no possibility to get 
> the JMS session's *clientID* via JMX.
>  
> I've attached the patch that extends the *ActiveMQServerControlImpl* and 
> *SessionView* classes to return the *clientID* if available.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4740) Reduce unnecessary boxing

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4740?focusedWorklogId=916738=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916738
 ]

ASF GitHub Bot logged work on ARTEMIS-4740:
---

Author: ASF GitHub Bot
Created on: 27/Apr/24 14:36
Start Date: 27/Apr/24 14:36
Worklog Time Spent: 10m 
  Work Description: jbertram merged PR #4901:
URL: https://github.com/apache/activemq-artemis/pull/4901




Issue Time Tracking
---

Worklog Id: (was: 916738)
Time Spent: 20m  (was: 10m)

> Reduce unnecessary boxing
> -
>
> Key: ARTEMIS-4740
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4740
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4745) Allow configuration of AMQP federation pull consumer batch size

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4745?focusedWorklogId=916653=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916653
 ]

ASF GitHub Bot logged work on ARTEMIS-4745:
---

Author: ASF GitHub Bot
Created on: 26/Apr/24 15:29
Start Date: 26/Apr/24 15:29
Worklog Time Spent: 10m 
  Work Description: gemmellr merged PR #4907:
URL: https://github.com/apache/activemq-artemis/pull/4907




Issue Time Tracking
---

Worklog Id: (was: 916653)
Time Spent: 0.5h  (was: 20m)

> Allow configuration of AMQP federation pull consumer batch size 
> 
>
> Key: ARTEMIS-4745
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4745
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: AMQP
>Affects Versions: 2.33.0
>Reporter: Timothy A. Bish
>Assignee: Timothy A. Bish
>Priority: Minor
> Fix For: 2.34.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> When Queue federation receiver links are configured to only pull messages 
> from the remote when local capacity allows it they grant a fixed credit 
> window amount of link credits currently.  In some cases control over this 
> batch size value is beneficial.  We can add an additional configuration 
> property to convey this limit to the federation configuration



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4745) Allow configuration of AMQP federation pull consumer batch size

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4745?focusedWorklogId=916646=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916646
 ]

ASF GitHub Bot logged work on ARTEMIS-4745:
---

Author: ASF GitHub Bot
Created on: 26/Apr/24 15:04
Start Date: 26/Apr/24 15:04
Worklog Time Spent: 10m 
  Work Description: tabish121 commented on PR #4907:
URL: 
https://github.com/apache/activemq-artemis/pull/4907#issuecomment-2079572871

   I've run the full test suite with these changes




Issue Time Tracking
---

Worklog Id: (was: 916646)
Time Spent: 20m  (was: 10m)

> Allow configuration of AMQP federation pull consumer batch size 
> 
>
> Key: ARTEMIS-4745
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4745
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: AMQP
>Affects Versions: 2.33.0
>Reporter: Timothy A. Bish
>Assignee: Timothy A. Bish
>Priority: Minor
> Fix For: 2.34.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> When Queue federation receiver links are configured to only pull messages 
> from the remote when local capacity allows it they grant a fixed credit 
> window amount of link credits currently.  In some cases control over this 
> batch size value is beneficial.  We can add an additional configuration 
> property to convey this limit to the federation configuration



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4745) Allow configuration of AMQP federation pull consumer batch size

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4745?focusedWorklogId=916645=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916645
 ]

ASF GitHub Bot logged work on ARTEMIS-4745:
---

Author: ASF GitHub Bot
Created on: 26/Apr/24 15:04
Start Date: 26/Apr/24 15:04
Worklog Time Spent: 10m 
  Work Description: tabish121 opened a new pull request, #4907:
URL: https://github.com/apache/activemq-artemis/pull/4907

   Allow for configuration of the batch size granted to the remote when an AMQP 
federation queue receiver is pulling messages only when there is local capacity 
to handle them. Some code housekeeping is done here to make adding future 
properties a bit simpler and require fewer changes.




Issue Time Tracking
---

Worklog Id: (was: 916645)
Remaining Estimate: 0h
Time Spent: 10m

> Allow configuration of AMQP federation pull consumer batch size 
> 
>
> Key: ARTEMIS-4745
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4745
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: AMQP
>Affects Versions: 2.33.0
>Reporter: Timothy A. Bish
>Assignee: Timothy A. Bish
>Priority: Minor
> Fix For: 2.34.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> When Queue federation receiver links are configured to only pull messages 
> from the remote when local capacity allows it they grant a fixed credit 
> window amount of link credits currently.  In some cases control over this 
> batch size value is beneficial.  We can add an additional configuration 
> property to convey this limit to the federation configuration



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4305) Zero persistence does not work in kubernetes

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4305?focusedWorklogId=916585=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916585
 ]

ASF GitHub Bot logged work on ARTEMIS-4305:
---

Author: ASF GitHub Bot
Created on: 26/Apr/24 08:24
Start Date: 26/Apr/24 08:24
Worklog Time Spent: 10m 
  Work Description: iiliev2 commented on PR #4899:
URL: 
https://github.com/apache/activemq-artemis/pull/4899#issuecomment-2078890094

   Initially I attempted what you suggest about lazy initializing the node id 
like that, precicely because I wanted to keep the code changes to a minimum. 
However, that ended up being much more complicated(rather than simplified), 
because of the way `ClientSessionFactoryImpl` creates a new connection object 
on re-connects. It is very hard to reason about both when reading the code and 
when needing to debug it at runtime. So instead of this, I had to fill the 
missing gaps to use the data that is already there anyway, just wasn't being 
propagated deep enough.
   
   IMO from a functional standpoint, adding the `TransportConfiguration` to the 
connector(and connection) is the right thing to do here anyway. I assume due to 
historical reasons, those classes were working with a subset of the data, and 
no one had a good reason to fix this until now. For example 
`NettyConnection#getConnectorConfig` was creating a bogus transport 
configuration, even though when it was created there was a configuration which 
was not being passed to it.
   
   `Ping` is already the only `Packet` that is being modified. Why do you want 
to use a raw `byte[]` rather than `UUID`? IMO that will be more confusing - it 
suggests that there could be other kind of data that can be contained.




Issue Time Tracking
---

Worklog Id: (was: 916585)
Time Spent: 0.5h  (was: 20m)

> Zero persistence does not work in kubernetes
> 
>
> Key: ARTEMIS-4305
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4305
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Ivan Iliev
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> In a cluster deployed in kubernetes, when a node is destroyed it terminates 
> the process and shuts down the network before the process has a chance to 
> close connections. Then a new node might be brought up, reusing the old 
> node’s ip. If this happens before the connection ttl, from artemis’ point of 
> view, it looks like as if the connection came back. Yet it is actually not 
> the same, the peer has a new node id, etc. This messes things up with the 
> cluster, the old message flow record is invalid.
> One way to fix it could be if the {{Ping}} messages which are typically used 
> to detect dead connections could use some sort of connection id to match that 
> the other side is really the one which it is supposed to be.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4305) Zero persistence does not work in kubernetes

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4305?focusedWorklogId=916557=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916557
 ]

ASF GitHub Bot logged work on ARTEMIS-4305:
---

Author: ASF GitHub Bot
Created on: 26/Apr/24 04:26
Start Date: 26/Apr/24 04:26
Worklog Time Spent: 10m 
  Work Description: jbertram commented on PR #4899:
URL: 
https://github.com/apache/activemq-artemis/pull/4899#issuecomment-2078606956

   I think you could simplify this quite a bit. Here's what I suggest...
   
   - Don't modify any packet aside from `Ping` and only modify it with a new 
`byte[]`.
   - The broker should send its node ID in every `Ping`.
   - The first time the client receives a `Ping` it should save the node ID.
   - If a client ever receives a `Ping` that is different from the one it has 
saved then it should disconnect.




Issue Time Tracking
---

Worklog Id: (was: 916557)
Time Spent: 20m  (was: 10m)

> Zero persistence does not work in kubernetes
> 
>
> Key: ARTEMIS-4305
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4305
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Ivan Iliev
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> In a cluster deployed in kubernetes, when a node is destroyed it terminates 
> the process and shuts down the network before the process has a chance to 
> close connections. Then a new node might be brought up, reusing the old 
> node’s ip. If this happens before the connection ttl, from artemis’ point of 
> view, it looks like as if the connection came back. Yet it is actually not 
> the same, the peer has a new node id, etc. This messes things up with the 
> cluster, the old message flow record is invalid.
> One way to fix it could be if the {{Ping}} messages which are typically used 
> to detect dead connections could use some sort of connection id to match that 
> the other side is really the one which it is supposed to be.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4744) AMQP broker connections don't fully support multi host URIs

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4744?focusedWorklogId=916476=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916476
 ]

ASF GitHub Bot logged work on ARTEMIS-4744:
---

Author: ASF GitHub Bot
Created on: 25/Apr/24 17:29
Start Date: 25/Apr/24 17:29
Worklog Time Spent: 10m 
  Work Description: gemmellr merged PR #4906:
URL: https://github.com/apache/activemq-artemis/pull/4906




Issue Time Tracking
---

Worklog Id: (was: 916476)
Time Spent: 1h 20m  (was: 1h 10m)

> AMQP broker connections don't fully support multi host URIs
> ---
>
> Key: ARTEMIS-4744
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4744
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 2.33.0
>Reporter: Timothy A. Bish
>Assignee: Timothy A. Bish
>Priority: Major
> Fix For: 2.34.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> When configuring a multi host connection URI for an AMQP broker connection 
> the connection will utilize some but not all of the configuration.  The 
> broker will attempt connection to each host and port part specific on the URI 
> but does not apply configuration specific to a given host.  This can lead to 
> failure on connect due to using the TLS configuration from the first host 
> when attempting to connect to the following N hosts.  Users need to be able 
> to configure TLS specific options per host as values such as host 
> verification, SNI and trust stores can vary amongst hosts.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4744) AMQP broker connections don't fully support multi host URIs

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4744?focusedWorklogId=916473=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916473
 ]

ASF GitHub Bot logged work on ARTEMIS-4744:
---

Author: ASF GitHub Bot
Created on: 25/Apr/24 17:25
Start Date: 25/Apr/24 17:25
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on code in PR #4906:
URL: https://github.com/apache/activemq-artemis/pull/4906#discussion_r1579867663


##
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/connect/AMQPConnectSaslTest.java:
##
@@ -214,4 +216,186 @@ private void doConnectWithExternalTestImpl(boolean 
requireClientCert) throws Exc
  peer.waitForScriptToComplete(5, TimeUnit.SECONDS);
   }
}
+
+   @Test(timeout = 20_000)
+   public void testReconnectConnectsWithVerifyHostOffOnSecondURI() throws 
Exception {
+  final String keyStorePath = 
this.getClass().getClassLoader().getResource(UNKNOWN_SERVER_KEYSTORE_NAME).getFile();
+
+  ProtonTestServerOptions server1Options = new ProtonTestServerOptions();
+  server1Options.setSecure(true);
+  server1Options.setKeyStoreLocation(keyStorePath);
+  server1Options.setKeyStorePassword(SERVER_KEYSTORE_PASSWORD);
+  server1Options.setVerifyHost(false);
+
+  ProtonTestServerOptions server2Options = new ProtonTestServerOptions();
+  server2Options.setSecure(true);
+  server2Options.setKeyStoreLocation(keyStorePath);
+  server2Options.setKeyStorePassword(SERVER_KEYSTORE_PASSWORD);
+  server2Options.setVerifyHost(false);
+
+  try (ProtonTestServer firstPeer = new ProtonTestServer(server1Options);
+   ProtonTestServer secondPeer = new ProtonTestServer(server2Options)) 
{
+
+ firstPeer.expectConnectionToDrop();
+ firstPeer.start();
+
+ secondPeer.expectSASLHeader().respondWithSASLHeader();
+ secondPeer.remoteSaslMechanisms().withMechanisms(EXTERNAL, 
PLAIN).queue();
+ 
secondPeer.expectSaslInit().withMechanism(PLAIN).withInitialResponse(secondPeer.saslPlainInitialResponse(USER,
 PASSWD));
+ secondPeer.remoteSaslOutcome().withCode(SaslCode.OK).queue();
+ secondPeer.expectAMQPHeader().respondWithAMQPHeader();
+ secondPeer.expectOpen().respond();
+ secondPeer.expectBegin().respond();
+ secondPeer.start();
+
+ final URI firstPeerURI = firstPeer.getServerURI();
+ logger.debug("Connect test started, first peer listening on: {}", 
firstPeerURI);
+
+ final URI secondPeerURI = secondPeer.getServerURI();
+ logger.debug("Connect test started, second peer listening on: {}", 
secondPeerURI);
+
+ // First connection fails because we use a server certificate with 
whose common name
+ // doesn't match the host, second connection should work as we 
disable host verification
+ String amqpServerConnectionURI =
+"(tcp://localhost:" + firstPeerURI.getPort() + "?verifyHost=true" +
+",tcp://localhost:" + secondPeerURI.getPort() + 
"?verifyHost=false)" +
+   "?sslEnabled=true;trustStorePath=" + SERVER_TRUSTSTORE_NAME +
+   ";trustStorePassword=" + SERVER_TRUSTSTORE_PASSWORD;

Review Comment:
   I have been fine with updating the docs to match the previous tests. Just 
seemed rather off for the 2 to dramatically differ is all :)





Issue Time Tracking
---

Worklog Id: (was: 916473)
Time Spent: 1h 10m  (was: 1h)

> AMQP broker connections don't fully support multi host URIs
> ---
>
> Key: ARTEMIS-4744
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4744
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 2.33.0
>Reporter: Timothy A. Bish
>Assignee: Timothy A. Bish
>Priority: Major
> Fix For: 2.34.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> When configuring a multi host connection URI for an AMQP broker connection 
> the connection will utilize some but not all of the configuration.  The 
> broker will attempt connection to each host and port part specific on the URI 
> but does not apply configuration specific to a given host.  This can lead to 
> failure on connect due to using the TLS configuration from the first host 
> when attempting to connect to the following N hosts.  Users need to be able 
> to configure TLS specific options per host as values such as host 
> verification, SNI and trust stores can vary amongst hosts.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4726) Removing scheduled message from queue via management can cause negative message count

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4726?focusedWorklogId=916467=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916467
 ]

ASF GitHub Bot logged work on ARTEMIS-4726:
---

Author: ASF GitHub Bot
Created on: 25/Apr/24 17:19
Start Date: 25/Apr/24 17:19
Worklog Time Spent: 10m 
  Work Description: jbertram commented on PR #4894:
URL: 
https://github.com/apache/activemq-artemis/pull/4894#issuecomment-2077786240

   @clebertsuconic, can you review and merge for 2.34.0?




Issue Time Tracking
---

Worklog Id: (was: 916467)
Time Spent: 20m  (was: 10m)

> Removing scheduled message from queue via management can cause negative 
> message count
> -
>
> Key: ARTEMIS-4726
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4726
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Web Console
>Affects Versions: 2.31.0
> Environment: NAME="Oracle Linux Server"
> VERSION="8.6"
> ID="ol"
> ID_LIKE="fedora"
> VARIANT="Server"
> VARIANT_ID="server"
> VERSION_ID="8.6"
> PLATFORM_ID="platform:el8"
> PRETTY_NAME="Oracle Linux Server 8.6"
> ANSI_COLOR="0;31"
> CPE_NAME="cpe:/o:oracle:linux:8:6:server"
> HOME_URL="https://linux.oracle.com/;
> BUG_REPORT_URL="https://bugzilla.oracle.com/;
> ORACLE_BUGZILLA_PRODUCT="Oracle Linux 8"
> ORACLE_BUGZILLA_PRODUCT_VERSION=8.6
> ORACLE_SUPPORT_PRODUCT="Oracle Linux"
> ORACLE_SUPPORT_PRODUCT_VERSION=8.6
>  
> java version "17.0.8" 2023-07-18 LTS
> Java(TM) SE Runtime Environment Oracle GraalVM 17.0.8+9.1 (build 
> 17.0.8+9-LTS-jvmci-23.0-b14)
> Java HotSpot(TM) 64-Bit Server VM Oracle GraalVM 17.0.8+9.1 (build 
> 17.0.8+9-LTS-jvmci-23.0-b14, mixed mode, sharing)
>  
>  
>  
>Reporter: Juanjo Marin
>Assignee: Justin Bertram
>Priority: Minor
> Attachments: Queue1.PNG, Queue2.PNG, Queue3.PNG, RemoveMessage1.PNG, 
> RemoveMessage2.PNG, listScheduledMessage.PNG, listScheduledMessage.txt, 
> listScheduledMessages2.txt, removeAll.PNG
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> When we delete a scheduled message that has not yet been sent, it subtracts 2 
> from the message counter. This only happens when the message has not been 
> delivered. The queue counter does not recover at any point, but the queue 
> continues to function normally.
> If we remove all messages, the remaining ones are deleted, but the queue goes 
> into negative. In one of our tests, the queue stopped functioning correctly 
> and only messages could be inserted; it did not allow consuming them in any 
> way. We haven't been able to reproduce it again.
> I attach screenshots and evidence.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4734) Null dereferencing in ReplicationManager.java

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4734?focusedWorklogId=916466=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916466
 ]

ASF GitHub Bot logged work on ARTEMIS-4734:
---

Author: ASF GitHub Bot
Created on: 25/Apr/24 17:18
Start Date: 25/Apr/24 17:18
Worklog Time Spent: 10m 
  Work Description: jbertram merged PR #4900:
URL: https://github.com/apache/activemq-artemis/pull/4900




Issue Time Tracking
---

Worklog Id: (was: 916466)
Time Spent: 20m  (was: 10m)

> Null dereferencing in ReplicationManager.java
> -
>
> Key: ARTEMIS-4734
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4734
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Galkin Alexey
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> {{repliToken}} can be 0.
> In 
> {{org.apache.activemq.artemis.core.replication.ReplicationManager#sendReplicatePacket(org.apache.activemq.artemis.core.protocol.core.Packet,
>  boolean, org.apache.activemq.artemis.utils.ReusableLatch)}} the 
> {{repliToken}} is initialized with the value returned by ([line 
> 464|https://github.com/apache/activemq-artemis/blob/main/artemis-server/src/main/java/org/apache/activemq/artemis/core/replication/ReplicationManager.java])
>  {{OperationContextImpl.getContext(ioExecutorFactory)}}, i.e.:
> {code:java}
> final OperationContext repliToken = 
> OperationContextImpl.getContext(ioExecutorFactory);{code}
> Inside this method, a call is made to 
> {{OperationContextImpl.threadLocalContext.get()}}([line 
> 61|https://github.com/apache/activemq-artemis/blob/main/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/OperationContextImpl.java]),
>  which returns the value from the thread that was set earlier. If no value 
> was set in the stream, then token will be {{null}}.
> {code:java}
> OperationContext token = OperationContextImpl.threadLocalContext.get();{code}
> If {{ioExecutorFactory}} is {{null}} and there is no value set in the thread, 
> then the {{repliToken}} will remain {{null}} because the backing 
> {{getContext()}} method also returns {{null}} in this case.
>  So {{repliToken}} can be 0 if {{ioExecutorFactory}} is {{null}} and there is 
> no value set in the thread.
> Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE.
> Author Alexey Galkin.
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4420) User authentication leaks into non-Artemis servlets

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4420?focusedWorklogId=916464=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916464
 ]

ASF GitHub Bot logged work on ARTEMIS-4420:
---

Author: ASF GitHub Bot
Created on: 25/Apr/24 17:18
Start Date: 25/Apr/24 17:18
Worklog Time Spent: 10m 
  Work Description: jbertram commented on PR #4897:
URL: 
https://github.com/apache/activemq-artemis/pull/4897#issuecomment-2077784652

   @clebertsuconic, let's get this into 2.34.0. Can you review and merge? 
Thanks!




Issue Time Tracking
---

Worklog Id: (was: 916464)
Time Spent: 20m  (was: 10m)

> User authentication leaks into non-Artemis servlets
> ---
>
> Key: ARTEMIS-4420
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4420
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.30.0
>Reporter: Dries Harnie
>Priority: Minor
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> ActiveMQ Artemis supports audit logs, which log all administrative actions 
> that happen on the broker.
> These logs identify the "current user" for an administrative access [by one 
> of two 
> methods|https://github.com/apache/activemq-artemis/blob/main/artemis-commons/src/main/java/org/apache/activemq/artemis/logs/AuditLogger.java#L67-L73]:
>  # The {{Subject}} associated with the current security manager context, or
>  # A {{{}ThreadLocal{}}}, which is set by JolokiaFilter as part of 
> interaction with the admin console.
> For a non-Artemis servlet such as [the metrics 
> plugin|https://github.com/rh-messaging/artemis-prometheus-metrics-plugin], 
> this {{ThreadLocal}} is set to whatever {{Subject}} made the previous request 
> on this thread. This leads to situations where metric accesses are logged as 
> being done by ghost users.
> To reproduce the issue:
>  # Set up Artemis with the default admin/admin user and [the metrics 
> plugin|https://github.com/rh-messaging/artemis-prometheus-metrics-plugin].
>  # Enable audit logging ({{{}logger.audit_base{}}} should be at {{INFO}} 
> level)
>  # Tail -f the audit log and start the server
>  # Log in to the admin console
>  # Observe that a lot of audit logs fly by for {*}admin(amq)@127.0.0.1{*}.
>  # Access the metrics with eg {{{}curl http://localhost:8161/metrics/{}}}.
>  # Observe that a lot of audit logs fly by for {*}admin(amq)@127.0.0.1{*}, 
> even though these requests are completely anonymous.
>  
> I think the solution involves a modification to 
> {{org.apache.activemq.artemis.component.JolokiaFilter}} but I do not 
> understand the purpose of the code after the {{doFilter}} invocation.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4744) AMQP broker connections don't fully support multi host URIs

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4744?focusedWorklogId=916456=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916456
 ]

ASF GitHub Bot logged work on ARTEMIS-4744:
---

Author: ASF GitHub Bot
Created on: 25/Apr/24 17:02
Start Date: 25/Apr/24 17:02
Worklog Time Spent: 10m 
  Work Description: tabish121 commented on code in PR #4906:
URL: https://github.com/apache/activemq-artemis/pull/4906#discussion_r1579840786


##
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/connect/AMQPConnectSaslTest.java:
##
@@ -214,4 +216,186 @@ private void doConnectWithExternalTestImpl(boolean 
requireClientCert) throws Exc
  peer.waitForScriptToComplete(5, TimeUnit.SECONDS);
   }
}
+
+   @Test(timeout = 20_000)
+   public void testReconnectConnectsWithVerifyHostOffOnSecondURI() throws 
Exception {
+  final String keyStorePath = 
this.getClass().getClassLoader().getResource(UNKNOWN_SERVER_KEYSTORE_NAME).getFile();
+
+  ProtonTestServerOptions server1Options = new ProtonTestServerOptions();
+  server1Options.setSecure(true);
+  server1Options.setKeyStoreLocation(keyStorePath);
+  server1Options.setKeyStorePassword(SERVER_KEYSTORE_PASSWORD);
+  server1Options.setVerifyHost(false);
+
+  ProtonTestServerOptions server2Options = new ProtonTestServerOptions();
+  server2Options.setSecure(true);
+  server2Options.setKeyStoreLocation(keyStorePath);
+  server2Options.setKeyStorePassword(SERVER_KEYSTORE_PASSWORD);
+  server2Options.setVerifyHost(false);
+
+  try (ProtonTestServer firstPeer = new ProtonTestServer(server1Options);
+   ProtonTestServer secondPeer = new ProtonTestServer(server2Options)) 
{
+
+ firstPeer.expectConnectionToDrop();
+ firstPeer.start();
+
+ secondPeer.expectSASLHeader().respondWithSASLHeader();
+ secondPeer.remoteSaslMechanisms().withMechanisms(EXTERNAL, 
PLAIN).queue();
+ 
secondPeer.expectSaslInit().withMechanism(PLAIN).withInitialResponse(secondPeer.saslPlainInitialResponse(USER,
 PASSWD));
+ secondPeer.remoteSaslOutcome().withCode(SaslCode.OK).queue();
+ secondPeer.expectAMQPHeader().respondWithAMQPHeader();
+ secondPeer.expectOpen().respond();
+ secondPeer.expectBegin().respond();
+ secondPeer.start();
+
+ final URI firstPeerURI = firstPeer.getServerURI();
+ logger.debug("Connect test started, first peer listening on: {}", 
firstPeerURI);
+
+ final URI secondPeerURI = secondPeer.getServerURI();
+ logger.debug("Connect test started, second peer listening on: {}", 
secondPeerURI);
+
+ // First connection fails because we use a server certificate with 
whose common name
+ // doesn't match the host, second connection should work as we 
disable host verification
+ String amqpServerConnectionURI =
+"(tcp://localhost:" + firstPeerURI.getPort() + "?verifyHost=true" +
+",tcp://localhost:" + secondPeerURI.getPort() + 
"?verifyHost=false)" +
+   "?sslEnabled=true;trustStorePath=" + SERVER_TRUSTSTORE_NAME +
+   ";trustStorePassword=" + SERVER_TRUSTSTORE_PASSWORD;

Review Comment:
   I think I have figured out the fragment style URI it wants and have updated 
the tests so it should match the broker connection documentation (although that 
is the least obvious format).





Issue Time Tracking
---

Worklog Id: (was: 916456)
Time Spent: 1h  (was: 50m)

> AMQP broker connections don't fully support multi host URIs
> ---
>
> Key: ARTEMIS-4744
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4744
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 2.33.0
>Reporter: Timothy A. Bish
>Assignee: Timothy A. Bish
>Priority: Major
> Fix For: 2.34.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> When configuring a multi host connection URI for an AMQP broker connection 
> the connection will utilize some but not all of the configuration.  The 
> broker will attempt connection to each host and port part specific on the URI 
> but does not apply configuration specific to a given host.  This can lead to 
> failure on connect due to using the TLS configuration from the first host 
> when attempting to connect to the following N hosts.  Users need to be able 
> to configure TLS specific options per host as values such as host 
> verification, SNI and trust stores can vary amongst hosts.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4744) AMQP broker connections don't fully support multi host URIs

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4744?focusedWorklogId=916440=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916440
 ]

ASF GitHub Bot logged work on ARTEMIS-4744:
---

Author: ASF GitHub Bot
Created on: 25/Apr/24 16:19
Start Date: 25/Apr/24 16:19
Worklog Time Spent: 10m 
  Work Description: tabish121 commented on code in PR #4906:
URL: https://github.com/apache/activemq-artemis/pull/4906#discussion_r1579781176


##
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/connect/AMQPConnectSaslTest.java:
##
@@ -214,4 +216,186 @@ private void doConnectWithExternalTestImpl(boolean 
requireClientCert) throws Exc
  peer.waitForScriptToComplete(5, TimeUnit.SECONDS);
   }
}
+
+   @Test(timeout = 20_000)
+   public void testReconnectConnectsWithVerifyHostOffOnSecondURI() throws 
Exception {
+  final String keyStorePath = 
this.getClass().getClassLoader().getResource(UNKNOWN_SERVER_KEYSTORE_NAME).getFile();
+
+  ProtonTestServerOptions server1Options = new ProtonTestServerOptions();
+  server1Options.setSecure(true);
+  server1Options.setKeyStoreLocation(keyStorePath);
+  server1Options.setKeyStorePassword(SERVER_KEYSTORE_PASSWORD);
+  server1Options.setVerifyHost(false);
+
+  ProtonTestServerOptions server2Options = new ProtonTestServerOptions();
+  server2Options.setSecure(true);
+  server2Options.setKeyStoreLocation(keyStorePath);
+  server2Options.setKeyStorePassword(SERVER_KEYSTORE_PASSWORD);
+  server2Options.setVerifyHost(false);
+
+  try (ProtonTestServer firstPeer = new ProtonTestServer(server1Options);
+   ProtonTestServer secondPeer = new ProtonTestServer(server2Options)) 
{
+
+ firstPeer.expectConnectionToDrop();
+ firstPeer.start();
+
+ secondPeer.expectSASLHeader().respondWithSASLHeader();
+ secondPeer.remoteSaslMechanisms().withMechanisms(EXTERNAL, 
PLAIN).queue();
+ 
secondPeer.expectSaslInit().withMechanism(PLAIN).withInitialResponse(secondPeer.saslPlainInitialResponse(USER,
 PASSWD));
+ secondPeer.remoteSaslOutcome().withCode(SaslCode.OK).queue();
+ secondPeer.expectAMQPHeader().respondWithAMQPHeader();
+ secondPeer.expectOpen().respond();
+ secondPeer.expectBegin().respond();
+ secondPeer.start();
+
+ final URI firstPeerURI = firstPeer.getServerURI();
+ logger.debug("Connect test started, first peer listening on: {}", 
firstPeerURI);
+
+ final URI secondPeerURI = secondPeer.getServerURI();
+ logger.debug("Connect test started, second peer listening on: {}", 
secondPeerURI);
+
+ // First connection fails because we use a server certificate with 
whose common name
+ // doesn't match the host, second connection should work as we 
disable host verification
+ String amqpServerConnectionURI =
+"(tcp://localhost:" + firstPeerURI.getPort() + "?verifyHost=true" +
+",tcp://localhost:" + secondPeerURI.getPort() + 
"?verifyHost=false)" +
+   "?sslEnabled=true;trustStorePath=" + SERVER_TRUSTSTORE_NAME +
+   ";trustStorePassword=" + SERVER_TRUSTSTORE_PASSWORD;

Review Comment:
   I cannot make it work using a '#' and I've based what I've used on other 
code I cam across elsewhere.  If someone that can understand how the parser is 
supposed to work wants to document it further that'd be great but I am not that 
person. 





Issue Time Tracking
---

Worklog Id: (was: 916440)
Time Spent: 50m  (was: 40m)

> AMQP broker connections don't fully support multi host URIs
> ---
>
> Key: ARTEMIS-4744
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4744
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 2.33.0
>Reporter: Timothy A. Bish
>Assignee: Timothy A. Bish
>Priority: Major
> Fix For: 2.34.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> When configuring a multi host connection URI for an AMQP broker connection 
> the connection will utilize some but not all of the configuration.  The 
> broker will attempt connection to each host and port part specific on the URI 
> but does not apply configuration specific to a given host.  This can lead to 
> failure on connect due to using the TLS configuration from the first host 
> when attempting to connect to the following N hosts.  Users need to be able 
> to configure TLS specific options per host as values such as host 
> verification, SNI and trust stores can vary amongst hosts.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4744) AMQP broker connections don't fully support multi host URIs

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4744?focusedWorklogId=916436=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916436
 ]

ASF GitHub Bot logged work on ARTEMIS-4744:
---

Author: ASF GitHub Bot
Created on: 25/Apr/24 15:59
Start Date: 25/Apr/24 15:59
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on code in PR #4906:
URL: https://github.com/apache/activemq-artemis/pull/4906#discussion_r1579751853


##
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/connect/AMQPConnectSaslTest.java:
##
@@ -214,4 +216,186 @@ private void doConnectWithExternalTestImpl(boolean 
requireClientCert) throws Exc
  peer.waitForScriptToComplete(5, TimeUnit.SECONDS);
   }
}
+
+   @Test(timeout = 20_000)
+   public void testReconnectConnectsWithVerifyHostOffOnSecondURI() throws 
Exception {
+  final String keyStorePath = 
this.getClass().getClassLoader().getResource(UNKNOWN_SERVER_KEYSTORE_NAME).getFile();
+
+  ProtonTestServerOptions server1Options = new ProtonTestServerOptions();
+  server1Options.setSecure(true);
+  server1Options.setKeyStoreLocation(keyStorePath);
+  server1Options.setKeyStorePassword(SERVER_KEYSTORE_PASSWORD);
+  server1Options.setVerifyHost(false);
+
+  ProtonTestServerOptions server2Options = new ProtonTestServerOptions();
+  server2Options.setSecure(true);
+  server2Options.setKeyStoreLocation(keyStorePath);
+  server2Options.setKeyStorePassword(SERVER_KEYSTORE_PASSWORD);
+  server2Options.setVerifyHost(false);
+
+  try (ProtonTestServer firstPeer = new ProtonTestServer(server1Options);
+   ProtonTestServer secondPeer = new ProtonTestServer(server2Options)) 
{
+
+ firstPeer.expectConnectionToDrop();
+ firstPeer.start();
+
+ secondPeer.expectSASLHeader().respondWithSASLHeader();
+ secondPeer.remoteSaslMechanisms().withMechanisms(EXTERNAL, 
PLAIN).queue();
+ 
secondPeer.expectSaslInit().withMechanism(PLAIN).withInitialResponse(secondPeer.saslPlainInitialResponse(USER,
 PASSWD));
+ secondPeer.remoteSaslOutcome().withCode(SaslCode.OK).queue();
+ secondPeer.expectAMQPHeader().respondWithAMQPHeader();
+ secondPeer.expectOpen().respond();
+ secondPeer.expectBegin().respond();
+ secondPeer.start();
+
+ final URI firstPeerURI = firstPeer.getServerURI();
+ logger.debug("Connect test started, first peer listening on: {}", 
firstPeerURI);
+
+ final URI secondPeerURI = secondPeer.getServerURI();
+ logger.debug("Connect test started, second peer listening on: {}", 
secondPeerURI);
+
+ // First connection fails because we use a server certificate with 
whose common name
+ // doesn't match the host, second connection should work as we 
disable host verification
+ String amqpServerConnectionURI =
+"(tcp://localhost:" + firstPeerURI.getPort() + "?verifyHost=true" +
+",tcp://localhost:" + secondPeerURI.getPort() + 
"?verifyHost=false)" +
+   "?sslEnabled=true;trustStorePath=" + SERVER_TRUSTSTORE_NAME +
+   ";trustStorePassword=" + SERVER_TRUSTSTORE_PASSWORD;
+
+ AMQPBrokerConnectConfiguration amqpConnection =
+new AMQPBrokerConnectConfiguration(getTestName(), 
amqpServerConnectionURI);
+ amqpConnection.setRetryInterval(100); // Allow reconnects

Review Comment:
   Maybe put a limit on attempts, just in case?



##
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/connect/AMQPConnectSaslTest.java:
##
@@ -214,4 +216,186 @@ private void doConnectWithExternalTestImpl(boolean 
requireClientCert) throws Exc
  peer.waitForScriptToComplete(5, TimeUnit.SECONDS);
   }
}
+
+   @Test(timeout = 20_000)
+   public void testReconnectConnectsWithVerifyHostOffOnSecondURI() throws 
Exception {
+  final String keyStorePath = 
this.getClass().getClassLoader().getResource(UNKNOWN_SERVER_KEYSTORE_NAME).getFile();
+
+  ProtonTestServerOptions server1Options = new ProtonTestServerOptions();
+  server1Options.setSecure(true);
+  server1Options.setKeyStoreLocation(keyStorePath);
+  server1Options.setKeyStorePassword(SERVER_KEYSTORE_PASSWORD);
+  server1Options.setVerifyHost(false);
+
+  ProtonTestServerOptions server2Options = new ProtonTestServerOptions();
+  server2Options.setSecure(true);
+  server2Options.setKeyStoreLocation(keyStorePath);
+  server2Options.setKeyStorePassword(SERVER_KEYSTORE_PASSWORD);
+  server2Options.setVerifyHost(false);
+
+  try (ProtonTestServer firstPeer = new ProtonTestServer(server1Options);
+   ProtonTestServer secondPeer = new ProtonTestServer(server2Options)) 
{
+
+ firstPeer.expectConnectionToDrop();
+

[jira] [Work logged] (ARTEMIS-4744) AMQP broker connections don't fully support multi host URIs

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4744?focusedWorklogId=916428=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916428
 ]

ASF GitHub Bot logged work on ARTEMIS-4744:
---

Author: ASF GitHub Bot
Created on: 25/Apr/24 15:33
Start Date: 25/Apr/24 15:33
Worklog Time Spent: 10m 
  Work Description: tabish121 commented on PR #4906:
URL: 
https://github.com/apache/activemq-artemis/pull/4906#issuecomment-2077588560

   I've run this through the full test suite a few times. 




Issue Time Tracking
---

Worklog Id: (was: 916428)
Time Spent: 0.5h  (was: 20m)

> AMQP broker connections don't fully support multi host URIs
> ---
>
> Key: ARTEMIS-4744
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4744
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 2.33.0
>Reporter: Timothy A. Bish
>Assignee: Timothy A. Bish
>Priority: Major
> Fix For: 2.34.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> When configuring a multi host connection URI for an AMQP broker connection 
> the connection will utilize some but not all of the configuration.  The 
> broker will attempt connection to each host and port part specific on the URI 
> but does not apply configuration specific to a given host.  This can lead to 
> failure on connect due to using the TLS configuration from the first host 
> when attempting to connect to the following N hosts.  Users need to be able 
> to configure TLS specific options per host as values such as host 
> verification, SNI and trust stores can vary amongst hosts.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4744) AMQP broker connections don't fully support multi host URIs

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4744?focusedWorklogId=916405=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916405
 ]

ASF GitHub Bot logged work on ARTEMIS-4744:
---

Author: ASF GitHub Bot
Created on: 25/Apr/24 14:55
Start Date: 25/Apr/24 14:55
Worklog Time Spent: 10m 
  Work Description: jbertram commented on PR #4906:
URL: 
https://github.com/apache/activemq-artemis/pull/4906#issuecomment-2077451300

   Nitpick - there's a typo in the commit message (i.e. "suppoert").




Issue Time Tracking
---

Worklog Id: (was: 916405)
Time Spent: 20m  (was: 10m)

> AMQP broker connections don't fully support multi host URIs
> ---
>
> Key: ARTEMIS-4744
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4744
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 2.33.0
>Reporter: Timothy A. Bish
>Assignee: Timothy A. Bish
>Priority: Major
> Fix For: 2.34.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> When configuring a multi host connection URI for an AMQP broker connection 
> the connection will utilize some but not all of the configuration.  The 
> broker will attempt connection to each host and port part specific on the URI 
> but does not apply configuration specific to a given host.  This can lead to 
> failure on connect due to using the TLS configuration from the first host 
> when attempting to connect to the following N hosts.  Users need to be able 
> to configure TLS specific options per host as values such as host 
> verification, SNI and trust stores can vary amongst hosts.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4744) AMQP broker connections don't fully support multi host URIs

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4744?focusedWorklogId=916401=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916401
 ]

ASF GitHub Bot logged work on ARTEMIS-4744:
---

Author: ASF GitHub Bot
Created on: 25/Apr/24 14:45
Start Date: 25/Apr/24 14:45
Worklog Time Spent: 10m 
  Work Description: tabish121 opened a new pull request, #4906:
URL: https://github.com/apache/activemq-artemis/pull/4906

   Create a new NettyConnector for each connection attempt that is configured 
from distinct broker connection URIs which allows for differing TLS 
configuration per remote connection configuration.




Issue Time Tracking
---

Worklog Id: (was: 916401)
Remaining Estimate: 0h
Time Spent: 10m

> AMQP broker connections don't fully support multi host URIs
> ---
>
> Key: ARTEMIS-4744
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4744
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 2.33.0
>Reporter: Timothy A. Bish
>Assignee: Timothy A. Bish
>Priority: Major
> Fix For: 2.34.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> When configuring a multi host connection URI for an AMQP broker connection 
> the connection will utilize some but not all of the configuration.  The 
> broker will attempt connection to each host and port part specific on the URI 
> but does not apply configuration specific to a given host.  This can lead to 
> failure on connect due to using the TLS configuration from the first host 
> when attempting to connect to the following N hosts.  Users need to be able 
> to configure TLS specific options per host as values such as host 
> verification, SNI and trust stores can vary amongst hosts.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=916371=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916371
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 25/Apr/24 12:24
Start Date: 25/Apr/24 12:24
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on code in PR #2:
URL: 
https://github.com/apache/activemq-artemis-console/pull/2#discussion_r1579378435


##
artemis-console-war/pom.xml:
##
@@ -0,0 +1,111 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+
+org.apache.activemq
+artemis-console-project
+1.0.0-SNAPSHOT
+
+
+org.apache.activemq
+artemis-console-war
+war
+
+
+ActiveMQ Artemis Console War
+
+
+ Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>  Time Spent: 8h 10m
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> A WIP can be found 
> [here|https://github.com/andytaylor/activemq-artemis/tree/artemis-console-ng]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=916370=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916370
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 25/Apr/24 12:16
Start Date: 25/Apr/24 12:16
Worklog Time Spent: 10m 
  Work Description: andytaylor commented on code in PR #2:
URL: 
https://github.com/apache/activemq-artemis-console/pull/2#discussion_r1579368288


##
artemis-console-war/pom.xml:
##
@@ -0,0 +1,111 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+
+org.apache.activemq
+artemis-console-project
+1.0.0-SNAPSHOT
+
+
+org.apache.activemq
+artemis-console-war
+war
+
+
+ActiveMQ Artemis Console War
+
+
+ Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>  Time Spent: 8h
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> A WIP can be found 
> [here|https://github.com/andytaylor/activemq-artemis/tree/artemis-console-ng]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4741) Use specific assertion methods

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4741?focusedWorklogId=916364=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916364
 ]

ASF GitHub Bot logged work on ARTEMIS-4741:
---

Author: ASF GitHub Bot
Created on: 25/Apr/24 11:41
Start Date: 25/Apr/24 11:41
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on PR #4902:
URL: 
https://github.com/apache/activemq-artemis/pull/4902#issuecomment-2076984557

   > I started doing equivalent updates and though the assertNull changes 
definitely make sense, its not clear a lot of the assertTrue/assertFalse 
changes necessarily do. They are mostly checking Boolean (rather than boolean) 
return values, so by changing them to assertTrue/assertFalse they are 
potentially just going to throw an NPE before the assertion actually happens. 
I'd be inclined to leave those ones as-is.
   
   I went through them all, less were Boolean than it initially seemed. I 
converted almost all of them (left the 10 or so where the type wasnt even known 
to be Boolean, since the assertEquals handles both the null and the type) and 
added assertNotNulls beforehand for the Boolean ones. 
   
   In addition to these original changes, also converted an 
assertNotEquals(null, foo) into assertNotNull(foo).




Issue Time Tracking
---

Worklog Id: (was: 916364)
Time Spent: 50m  (was: 40m)

> Use specific assertion methods
> --
>
> Key: ARTEMIS-4741
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4741
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=916211=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916211
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 24/Apr/24 15:49
Start Date: 24/Apr/24 15:49
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on code in PR #2:
URL: 
https://github.com/apache/activemq-artemis-console/pull/2#discussion_r1578032690


##
artemis-console-war/pom.xml:
##
@@ -0,0 +1,111 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+
+org.apache.activemq
+artemis-console-project
+1.0.0-SNAPSHOT
+
+
+org.apache.activemq
+artemis-console-war
+war
+
+
+ActiveMQ Artemis Console War
+
+
+ Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>  Time Spent: 7h 50m
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> A WIP can be found 
> [here|https://github.com/andytaylor/activemq-artemis/tree/artemis-console-ng]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4743) Improve CLI Queue Stat Output: Split lines and include internal queue attribute

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4743?focusedWorklogId=916188=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916188
 ]

ASF GitHub Bot logged work on ARTEMIS-4743:
---

Author: ASF GitHub Bot
Created on: 24/Apr/24 14:26
Start Date: 24/Apr/24 14:26
Worklog Time Spent: 10m 
  Work Description: clebertsuconic merged PR #4905:
URL: https://github.com/apache/activemq-artemis/pull/4905




Issue Time Tracking
---

Worklog Id: (was: 916188)
Time Spent: 2h 40m  (was: 2.5h)

> Improve CLI Queue Stat Output: Split lines and include internal queue 
> attribute
> ---
>
> Key: ARTEMIS-4743
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4743
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Affects Versions: 2.33.0
>Reporter: Clebert Suconic
>Priority: Major
>  Time Spent: 2h 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (AMQ-9485) Host activemq-protobuf modules in main source tree

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/AMQ-9485?focusedWorklogId=916187=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916187
 ]

ASF GitHub Bot logged work on AMQ-9485:
---

Author: ASF GitHub Bot
Created on: 24/Apr/24 14:17
Start Date: 24/Apr/24 14:17
Worklog Time Spent: 10m 
  Work Description: mattrpav opened a new pull request, #1209:
URL: https://github.com/apache/activemq/pull/1209

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 916187)
Remaining Estimate: 0h
Time Spent: 10m

> Host activemq-protobuf modules in main source tree
> --
>
> Key: AMQ-9485
> URL: https://issues.apache.org/jira/browse/AMQ-9485
> Project: ActiveMQ Classic
>  Issue Type: Task
>Reporter: Matt Pavlovich
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=916161=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916161
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 24/Apr/24 11:00
Start Date: 24/Apr/24 11:00
Worklog Time Spent: 10m 
  Work Description: andytaylor commented on PR #2:
URL: 
https://github.com/apache/activemq-artemis-console/pull/2#issuecomment-2074679300

   Yes it is expected




Issue Time Tracking
---

Worklog Id: (was: 916161)
Time Spent: 7h 40m  (was: 7.5h)

> Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>  Time Spent: 7h 40m
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> A WIP can be found 
> [here|https://github.com/andytaylor/activemq-artemis/tree/artemis-console-ng]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=916160=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916160
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 24/Apr/24 10:43
Start Date: 24/Apr/24 10:43
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on PR #2:
URL: 
https://github.com/apache/activemq-artemis-console/pull/2#issuecomment-2074654002

   Ok. To be clear though, it does also happen in CI:
   ```
   [INFO] Installing node version v20.9.0
   [INFO] Downloading 
https://nodejs.org/dist/v20.9.0/node-v20.9.0-linux-x64.tar.gz to 
/home/runner/.m2/repository/com/github/eirslett/node/20.9.0/node-20.9.0-linux-x64.tar.gz
   [INFO] No proxies configured
   [INFO] No proxy was configured, downloading directly
   [INFO] Unpacking 
/home/runner/.m2/repository/com/github/eirslett/node/20.9.0/node-20.9.0-linux-x64.tar.gz
 into 
/home/runner/work/activemq-artemis-console/activemq-artemis-console/artemis-console-extension/artemis-extension/node/tmp
   [INFO] Copying node binary from 
/home/runner/work/activemq-artemis-console/activemq-artemis-console/artemis-console-extension/artemis-extension/node/tmp/node-v20.9.0-linux-x64/bin/node
 to 
/home/runner/work/activemq-artemis-console/activemq-artemis-console/artemis-console-extension/artemis-extension/node/node
   [INFO] Installed node locally.
   [INFO] Installing Yarn version v1.22.21
   [INFO] Downloading 
https://github.com/yarnpkg/yarn/releases/download/v1.22.21/yarn-v1.22.21.tar.gz 
to 
/home/runner/.m2/repository/com/github/eirslett/yarn/1.22.21/yarn-1.22.21.tar.gz
   [INFO] No proxies configured
   [INFO] No proxy was configured, downloading directly
   [INFO] Unpacking 
/home/runner/.m2/repository/com/github/eirslett/yarn/1.22.21/yarn-1.22.21.tar.gz
 into 
/home/runner/work/activemq-artemis-console/activemq-artemis-console/artemis-console-extension/artemis-extension/node/yarn
   [INFO] Installed Yarn locally.
   ```
   
   https://github.com/apache/activemq-artemis-console/pull/2/checks#step:4:1308




Issue Time Tracking
---

Worklog Id: (was: 916160)
Time Spent: 7.5h  (was: 7h 20m)

> Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>  Time Spent: 7.5h
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> A WIP can be found 
> [here|https://github.com/andytaylor/activemq-artemis/tree/artemis-console-ng]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4741) Use specific assertion methods

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4741?focusedWorklogId=916159=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916159
 ]

ASF GitHub Bot logged work on ARTEMIS-4741:
---

Author: ASF GitHub Bot
Created on: 24/Apr/24 10:35
Start Date: 24/Apr/24 10:35
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on PR #4902:
URL: 
https://github.com/apache/activemq-artemis/pull/4902#issuecomment-2074641040

   I started doing equivalent updates and though the assertNull changes 
definitely make sense, its not clear a lot of the assertTrue/assertFalse 
changes necessarily do. They are mostly checking Boolean (rather than boolean) 
return values, so by changing them to assertTrue/assertFalse they are 
potentially just going to throw an NPE before the assertion actually happens. 
I'd be inclined to leave those ones as-is.




Issue Time Tracking
---

Worklog Id: (was: 916159)
Time Spent: 40m  (was: 0.5h)

> Use specific assertion methods
> --
>
> Key: ARTEMIS-4741
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4741
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=916130=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916130
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 24/Apr/24 06:41
Start Date: 24/Apr/24 06:41
Worklog Time Spent: 10m 
  Work Description: andytaylor commented on PR #2:
URL: 
https://github.com/apache/activemq-artemis-console/pull/2#issuecomment-2074183992

   If your project is using Yarn Berry (2.x or above), the Yarn version is 
handled per project but a Yarn 1.x install is still needed as a "bootstrap". 
The plugin will try to detect .yarnrc.yml file in the current Maven 
project/module folder, at the root of the multi-module project if relevant, and 
in the folder from which the mvn command was run. If detected, the plugin will 
assume your project is using Yarn Berry. It will install the 1.x Yarn version 
you specify with yarnVersion as bootstrap, then hand over to your 
project-specific version.
   
   It has detected an older version in your env which doesnt happen in CI. In 
short this is expected.




Issue Time Tracking
---

Worklog Id: (was: 916130)
Time Spent: 7h 20m  (was: 7h 10m)

> Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>  Time Spent: 7h 20m
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> A WIP can be found 
> [here|https://github.com/andytaylor/activemq-artemis/tree/artemis-console-ng]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4743) Improve CLI Queue Stat Output: Split lines and include internal queue attribute

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4743?focusedWorklogId=916121=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916121
 ]

ASF GitHub Bot logged work on ARTEMIS-4743:
---

Author: ASF GitHub Bot
Created on: 24/Apr/24 03:34
Start Date: 24/Apr/24 03:34
Worklog Time Spent: 10m 
  Work Description: clebertsuconic commented on PR #4905:
URL: 
https://github.com/apache/activemq-artemis/pull/4905#issuecomment-2073954333

   same thing, but including management queues:
   
   ```
   bin % ./artemis queue stat --include-management
   Connection brokerURL = tcp://localhost:61616
   |NAME |ADDRESS  
|CONSUMER|MESSAGE|MESSAGES|DELIVERING|MESSAGES|SCHEDULED| ROUTING |INTERNAL|
   | | | COUNT  | COUNT | ADDED 
 |  COUNT   | ACKED  |  COUNT  |  TYPE   ||
   |$sys.mqtt.sessions   |$sys.mqtt.sessions   |   0|   0   |   0   
 |0 |   0|0| ANYCAST |  true  |
   |DLQ  |DLQ  |   0|   0   |   0   
 |0 |   0|0| ANYCAST | false  |
   |ExpiryQueue  |ExpiryQueue  |   0|   0   |   0   
 |0 |   0|0| ANYCAST | false  |
   |TEST |TEST |   0|   0   |   0   
 |0 |   0|0| ANYCAST | false  |
   |activemq.management.0fc9e|activemq.management.0fc9e|   1|   1   |   1   
 |1 |   0|0|MULTICAST| false  |
   |  b03-3934-4f2a-8eec-5202|  b03-3934-4f2a-8eec-5202||   |   
 |  || | ||
   |  4975e39d   |  4975e39d   ||   |   
 |  || | ||
   |activemq.management.44065|activemq.management.44065|   1|   1   |   1   
 |1 |   0|0|MULTICAST| false  |
   |  c77-addc-410b-8270-e996|  c77-addc-410b-8270-e996||   |   
 |  || | ||
   |  9dc830b2   |  9dc830b2   ||   |   
 |  || | ||
   |activemq.management.98058|activemq.management.98058|   1|   0   |   0   
 |0 |   0|0|MULTICAST| false  |
   |  71f-0572-4664-953c-bb2c|  71f-0572-4664-953c-bb2c||   |   
 |  || | ||
   |  4f5a1842   |  4f5a1842   ||   |   
 |  || | ||
   ```




Issue Time Tracking
---

Worklog Id: (was: 916121)
Time Spent: 2.5h  (was: 2h 20m)

> Improve CLI Queue Stat Output: Split lines and include internal queue 
> attribute
> ---
>
> Key: ARTEMIS-4743
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4743
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Affects Versions: 2.33.0
>Reporter: Clebert Suconic
>Priority: Major
>  Time Spent: 2.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4743) Improve CLI Queue Stat Output: Split lines and include internal queue attribute

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4743?focusedWorklogId=916120=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916120
 ]

ASF GitHub Bot logged work on ARTEMIS-4743:
---

Author: ASF GitHub Bot
Created on: 24/Apr/24 03:33
Start Date: 24/Apr/24 03:33
Worklog Time Spent: 10m 
  Work Description: clebertsuconic commented on PR #4905:
URL: 
https://github.com/apache/activemq-artemis/pull/4905#issuecomment-2073953407

   this is the last updated:
   
   ```
   Connection brokerURL = tcp://localhost:61616
   |NAME  |ADDRESS   
|CONSUMER|MESSAGE|MESSAGES|DELIVERING|MESSAGES|SCHEDULED|ROUTING|INTERNAL|
   |  |  | COUNT  | COUNT | ADDED  |  COUNT   | 
ACKED  |  COUNT  | TYPE  ||
   |$sys.mqtt.sessions|$sys.mqtt.sessions|   0|   0   |   0|0 | 
  0|0|ANYCAST|  true  |
   |DLQ   |DLQ   |   0|   0   |   0|0 | 
  0|0|ANYCAST| false  |
   |ExpiryQueue   |ExpiryQueue   |   0|   0   |   0|0 | 
  0|0|ANYCAST| false  |
   |TEST  |TEST  |   0|   0   |   0|0 | 
  0|0|ANYCAST| false  |
   ```




Issue Time Tracking
---

Worklog Id: (was: 916120)
Time Spent: 2h 20m  (was: 2h 10m)

> Improve CLI Queue Stat Output: Split lines and include internal queue 
> attribute
> ---
>
> Key: ARTEMIS-4743
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4743
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Affects Versions: 2.33.0
>Reporter: Clebert Suconic
>Priority: Major
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4743) Improve CLI Queue Stat Output: Split lines and include internal queue attribute

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4743?focusedWorklogId=916116=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916116
 ]

ASF GitHub Bot logged work on ARTEMIS-4743:
---

Author: ASF GitHub Bot
Created on: 24/Apr/24 03:11
Start Date: 24/Apr/24 03:11
Worklog Time Spent: 10m 
  Work Description: clebertsuconic commented on code in PR #4905:
URL: https://github.com/apache/activemq-artemis/pull/4905#discussion_r1577182698


##
docs/user-manual/versions.adoc:
##
@@ -32,6 +32,8 @@ However, connections will no longer be pooled regardless of 
the configuration.
   ** This was done in an attempt to allow administrators to act when things 
are not working as expected, to get metrics on these objects and allow more 
transparency for the broker.
   ** this includes all Openwire Advisor queues and addresses, MQTT internal 
objects, Cluster Store and Forward (SNF) Queues, Mirror SNF.
   ** You may want to revisit authorizations if you mean to control access to 
certain users on the web console.
+* The CLI operation `./artemis queue stat` has its output improved and 
updated. If you parse the previous output you will see differences in the 
output.

Review Comment:
   @erwindon as promised ^^^
   let me know if you can think of a better text here or anywhere else 





Issue Time Tracking
---

Worklog Id: (was: 916116)
Time Spent: 2h 10m  (was: 2h)

> Improve CLI Queue Stat Output: Split lines and include internal queue 
> attribute
> ---
>
> Key: ARTEMIS-4743
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4743
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Affects Versions: 2.33.0
>Reporter: Clebert Suconic
>Priority: Major
>  Time Spent: 2h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (AMQ-9484) Support exporting kahadb messages from a queue with an offset

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/AMQ-9484?focusedWorklogId=916113=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916113
 ]

ASF GitHub Bot logged work on AMQ-9484:
---

Author: ASF GitHub Bot
Created on: 24/Apr/24 01:10
Start Date: 24/Apr/24 01:10
Worklog Time Spent: 10m 
  Work Description: mattrpav opened a new pull request, #1208:
URL: https://github.com/apache/activemq/pull/1208

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 916113)
Time Spent: 40m  (was: 0.5h)

> Support exporting kahadb messages from a queue with an offset
> -
>
> Key: AMQ-9484
> URL: https://issues.apache.org/jira/browse/AMQ-9484
> Project: ActiveMQ Classic
>  Issue Type: New Feature
>Reporter: Matt Pavlovich
>Assignee: Matt Pavlovich
>Priority: Minor
> Fix For: 6.2.0, 5.18.5
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Support exporting and pulling messages from a MessageStore with an offset, to 
> prevent loading _every_ message into memory (and subsequent required gc). 
> For example, if a user wants to export the last message from a queue with 
> 1,000 messages, they can scan over the index skipping most messages vs 
> loading all messages into memory to get to the last message.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4705) Remove unnecessary field from STOMP HeartBeater

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4705?focusedWorklogId=916112=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916112
 ]

ASF GitHub Bot logged work on ARTEMIS-4705:
---

Author: ASF GitHub Bot
Created on: 24/Apr/24 01:02
Start Date: 24/Apr/24 01:02
Worklog Time Spent: 10m 
  Work Description: jbertram merged PR #4898:
URL: https://github.com/apache/activemq-artemis/pull/4898




Issue Time Tracking
---

Worklog Id: (was: 916112)
Time Spent: 20m  (was: 10m)

> Remove unnecessary field from STOMP HeartBeater
> ---
>
> Key: ARTEMIS-4705
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4705
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.25.0
>Reporter: Andrey Slepykh
>Assignee: Justin Bertram
>Priority: Major
> Attachments: Screenshot from 2024-03-30 11-21-54.png
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> line [266 
> |https://github.com/apache/activemq-artemis/blob/fb1b362b473cad51ae5d05a897be02b1fa8461d4/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/v11/StompFrameHandlerV11.java#L266]
>  declares the variable "shutdown" which is not used anywhere else, but takes 
> up memory
> !Screenshot from 2024-03-30 11-21-54.png!
> Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE.
> Author: Firsov Vladimir, BMSTU (fvv22u...@student.bmstu.ru)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (AMQ-9484) Support exporting kahadb messages from a queue with an offset

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/AMQ-9484?focusedWorklogId=916086=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916086
 ]

ASF GitHub Bot logged work on AMQ-9484:
---

Author: ASF GitHub Bot
Created on: 23/Apr/24 18:01
Start Date: 23/Apr/24 18:01
Worklog Time Spent: 10m 
  Work Description: mattrpav commented on PR #1207:
URL: https://github.com/apache/activemq/pull/1207#issuecomment-2073055053

   One reason I thought iterating over the index was preferred vs seeking over 
the index was to skip over and not include any messages in the ackedAndPrepared 
collection.
   
   ```
   if (ackedAndPrepared != null && 
ackedAndPrepared.contains(entry.getValue().messageId)) {
   continue;
   }
   ```




Issue Time Tracking
---

Worklog Id: (was: 916086)
Time Spent: 0.5h  (was: 20m)

> Support exporting kahadb messages from a queue with an offset
> -
>
> Key: AMQ-9484
> URL: https://issues.apache.org/jira/browse/AMQ-9484
> Project: ActiveMQ Classic
>  Issue Type: New Feature
>Reporter: Matt Pavlovich
>Assignee: Matt Pavlovich
>Priority: Minor
> Fix For: 6.2.0, 5.18.5
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Support exporting and pulling messages from a MessageStore with an offset, to 
> prevent loading _every_ message into memory (and subsequent required gc). 
> For example, if a user wants to export the last message from a queue with 
> 1,000 messages, they can scan over the index skipping most messages vs 
> loading all messages into memory to get to the last message.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (AMQ-9484) Support exporting kahadb messages from a queue with an offset

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/AMQ-9484?focusedWorklogId=916084=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916084
 ]

ASF GitHub Bot logged work on AMQ-9484:
---

Author: ASF GitHub Bot
Created on: 23/Apr/24 17:42
Start Date: 23/Apr/24 17:42
Worklog Time Spent: 10m 
  Work Description: cshannon commented on PR #1207:
URL: https://github.com/apache/activemq/pull/1207#issuecomment-2073017418

   I only took a quick glance but 2 things stand out to me immediately that are 
issues:
   
   1. The current PR is using recoverNextMessages() which changes state of the 
cursor, so this definitely won't work in an online broker without breaking the 
queue if the intent is for a user to use this to export while a broker is 
online.
   2. This scans through the index and just skips when you could just use 
MessageOrderIndex with the order iterator and skip ahead by setting the batch 
location on the index
   
   This needs a bit more context with use cases to see how this is intended to 
be used to probably know the best way of doing some of this




Issue Time Tracking
---

Worklog Id: (was: 916084)
Time Spent: 20m  (was: 10m)

> Support exporting kahadb messages from a queue with an offset
> -
>
> Key: AMQ-9484
> URL: https://issues.apache.org/jira/browse/AMQ-9484
> Project: ActiveMQ Classic
>  Issue Type: New Feature
>Reporter: Matt Pavlovich
>Assignee: Matt Pavlovich
>Priority: Minor
> Fix For: 6.2.0, 5.18.5
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Support exporting and pulling messages from a MessageStore with an offset, to 
> prevent loading _every_ message into memory (and subsequent required gc). 
> For example, if a user wants to export the last message from a queue with 
> 1,000 messages, they can scan over the index skipping most messages vs 
> loading all messages into memory to get to the last message.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (AMQ-9484) Support exporting kahadb messages from a queue with an offset

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/AMQ-9484?focusedWorklogId=916076=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916076
 ]

ASF GitHub Bot logged work on AMQ-9484:
---

Author: ASF GitHub Bot
Created on: 23/Apr/24 16:44
Start Date: 23/Apr/24 16:44
Worklog Time Spent: 10m 
  Work Description: mattrpav opened a new pull request, #1207:
URL: https://github.com/apache/activemq/pull/1207

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 916076)
Remaining Estimate: 0h
Time Spent: 10m

> Support exporting kahadb messages from a queue with an offset
> -
>
> Key: AMQ-9484
> URL: https://issues.apache.org/jira/browse/AMQ-9484
> Project: ActiveMQ Classic
>  Issue Type: New Feature
>Reporter: Matt Pavlovich
>Assignee: Matt Pavlovich
>Priority: Minor
> Fix For: 6.2.0, 5.18.5
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4743) Improve CLI Queue Stat Output: Split lines and include internal queue attribute

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4743?focusedWorklogId=916071=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916071
 ]

ASF GitHub Bot logged work on ARTEMIS-4743:
---

Author: ASF GitHub Bot
Created on: 23/Apr/24 16:21
Start Date: 23/Apr/24 16:21
Worklog Time Spent: 10m 
  Work Description: clebertsuconic commented on PR #4905:
URL: 
https://github.com/apache/activemq-artemis/pull/4905#issuecomment-2072859043

   @erwindon but I will add a note to the release notes pointing the change




Issue Time Tracking
---

Worklog Id: (was: 916071)
Time Spent: 2h  (was: 1h 50m)

> Improve CLI Queue Stat Output: Split lines and include internal queue 
> attribute
> ---
>
> Key: ARTEMIS-4743
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4743
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Affects Versions: 2.33.0
>Reporter: Clebert Suconic
>Priority: Major
>  Time Spent: 2h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4743) Improve CLI Queue Stat Output: Split lines and include internal queue attribute

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4743?focusedWorklogId=916069=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916069
 ]

ASF GitHub Bot logged work on ARTEMIS-4743:
---

Author: ASF GitHub Bot
Created on: 23/Apr/24 16:08
Start Date: 23/Apr/24 16:08
Worklog Time Spent: 10m 
  Work Description: clebertsuconic commented on PR #4905:
URL: 
https://github.com/apache/activemq-artemis/pull/4905#issuecomment-2072831889

   @jbertram last iteraction... notice I renamed some of the titles...
   
   
   ```
   bin % ./artemis queue stat
   Connection brokerURL = tcp://localhost:61616
   |NAME |ADDRESS  
|CONSUMERS|MESSAGES|MESSAGES|DELIVERING|ACKED|SCHEDULED|ROUTING  |INTERNAL|
   | | | |COUNT   
|ADDED   |  | | | ||
   |$ACTIVEMQ_ARTEMIS_MIRROR_|$ACTIVEMQ_ARTEMIS_MIRROR_|1|0   |10   
   |0 |10   |0|ANYCAST  |true|
   |  mirror |  mirror | || 
   |  | | | ||
   |$sys.mqtt.sessions   |$sys.mqtt.sessions   |0|0   |0
   |0 |0|0|ANYCAST  |true|
   |DLQ  |DLQ  |0|0   |0
   |0 |0|0|ANYCAST  |false   |
   |ExpiryQueue  |ExpiryQueue  |0|0   |0
   |0 |0|0|ANYCAST  |false   |
   |activemq.management.60de5|activemq.management.60de5|1|0   |0
   |0 |0|0|MULTICAST|false   |
   |  b0e-ae80-4b75-bf92-10af|  b0e-ae80-4b75-bf92-10af| || 
   |  | | | ||
   |  9e724fc4   |  9e724fc4   | || 
   |  | | | ||
   |activemq.management.6be36|activemq.management.6be36|1|1   |1
   |1 |0|0|MULTICAST|false   |
   |  de9-a7ec-411a-bd53-3411|  de9-a7ec-411a-bd53-3411| || 
   |  | | | ||
   |  cee197a3   |  cee197a3   | || 
   |  | | | ||
   |activemq.management.812a5|activemq.management.812a5|1|1   |1
   |1 |0|0|MULTICAST|false   |
   |  363-f5bc-4517-99d2-9af2|  363-f5bc-4517-99d2-9af2| || 
   |  | | | ||
   |  4c725f4b   |  4c725f4b   | || 
   |  | | | ||
   |myQueue  |myQueue  |0|0   |0
   |0 |0|0|ANYCAST  |false   |
   
   ```




Issue Time Tracking
---

Worklog Id: (was: 916069)
Time Spent: 1h 50m  (was: 1h 40m)

> Improve CLI Queue Stat Output: Split lines and include internal queue 
> attribute
> ---
>
> Key: ARTEMIS-4743
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4743
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Affects Versions: 2.33.0
>Reporter: Clebert Suconic
>Priority: Major
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4743) Improve CLI Queue Stat Output: Split lines and include internal queue attribute

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4743?focusedWorklogId=916067=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916067
 ]

ASF GitHub Bot logged work on ARTEMIS-4743:
---

Author: ASF GitHub Bot
Created on: 23/Apr/24 16:07
Start Date: 23/Apr/24 16:07
Worklog Time Spent: 10m 
  Work Description: clebertsuconic commented on PR #4905:
URL: 
https://github.com/apache/activemq-artemis/pull/4905#issuecomment-2072830198

   @erwindon you can use curl with some jolokia-fu as well :) 
   
   
   Don't ask me how to use it.. every time I needed it I figured out how to use 
it to then forget again :) 
   
   But it should be easy enough.




Issue Time Tracking
---

Worklog Id: (was: 916067)
Time Spent: 1h 40m  (was: 1.5h)

> Improve CLI Queue Stat Output: Split lines and include internal queue 
> attribute
> ---
>
> Key: ARTEMIS-4743
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4743
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Affects Versions: 2.33.0
>Reporter: Clebert Suconic
>Priority: Major
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4743) Improve CLI Queue Stat Output: Split lines and include internal queue attribute

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4743?focusedWorklogId=916066=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916066
 ]

ASF GitHub Bot logged work on ARTEMIS-4743:
---

Author: ASF GitHub Bot
Created on: 23/Apr/24 15:53
Start Date: 23/Apr/24 15:53
Worklog Time Spent: 10m 
  Work Description: erwindon commented on PR #4905:
URL: 
https://github.com/apache/activemq-artemis/pull/4905#issuecomment-2072800210

   @clebertsuconic
   Thanks for the replies!
   Personally I'm using both JMX and metrics, so I'm fine with this kind of 
improvements.
   But I also remember that I used this years ago before I mastered the JMX api 
:-)
   thus the above little check...




Issue Time Tracking
---

Worklog Id: (was: 916066)
Time Spent: 1.5h  (was: 1h 20m)

> Improve CLI Queue Stat Output: Split lines and include internal queue 
> attribute
> ---
>
> Key: ARTEMIS-4743
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4743
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Affects Versions: 2.33.0
>Reporter: Clebert Suconic
>Priority: Major
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4741) Use specific assertion methods

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4741?focusedWorklogId=916065=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916065
 ]

ASF GitHub Bot logged work on ARTEMIS-4741:
---

Author: ASF GitHub Bot
Created on: 23/Apr/24 15:40
Start Date: 23/Apr/24 15:40
Worklog Time Spent: 10m 
  Work Description: jbertram closed pull request #4902: ARTEMIS-4741 use 
specific assertion methods
URL: https://github.com/apache/activemq-artemis/pull/4902




Issue Time Tracking
---

Worklog Id: (was: 916065)
Time Spent: 0.5h  (was: 20m)

> Use specific assertion methods
> --
>
> Key: ARTEMIS-4741
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4741
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)