[jira] [Work logged] (ARTEMIS-4797) Failover connection references are not always cleaned up in NettyAcceptor, leaking memory

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4797?focusedWorklogId=922588=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922588
 ]

ASF GitHub Bot logged work on ARTEMIS-4797:
---

Author: ASF GitHub Bot
Created on: 07/Jun/24 14:00
Start Date: 07/Jun/24 14:00
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on PR #4960:
URL: 
https://github.com/apache/activemq-artemis/pull/4960#issuecomment-2154908286

   Your Jira and PR comments are aimed at Acceptor behaviour, and you note on 
the Jira that you are using Openwire clients...however the changed bits are 
also used by the Artemis Core client. I'm not familiar with this code, but it 
seems to me like the change could result in the connectionDestroyed listener 
callback being called for clients when it wouldnt currently be, after the 
connectionException listener callback could already have been called, 
potentially causing a double-failover or other weirdness?




Issue Time Tracking
---

Worklog Id: (was: 922588)
Time Spent: 0.5h  (was: 20m)

> Failover connection references are not always cleaned up in NettyAcceptor, 
> leaking memory
> -
>
> Key: ARTEMIS-4797
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4797
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: OpenWire
>Reporter: Josh Byster
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> I'm still trying to parse through exactly what conditions this occurs in, 
> since I'm able to reproduce it in a very specific production setup but not in 
> an isolated environment locally.
> For context, we have custom slow consumer detection that closes connection 
> IDs with slow consumers. These connections are connected via failover 
> transport using client ActiveMQ Classic 5.16.4 (OpenWire). This seems to be 
> specific to Netty.
> It appears this specific order of events causes the connection to not get 
> cleaned up and retained indefinitely on the broker. With frequent kicking of 
> connections, this ends up causing the broker to eventually OOM.
> 1. Connection is created, {{ActiveMQServerChannelHandler}} is created as well
> 2. {{ActiveMQServerChannelHandler#createConnection}} is called, {{active}} 
> flag is set {{true}}.
> 3. A few minutes go by, then we call 
> {{ActiveMQServerControl#closeConnectionWithID}} with the connection ID.
> 4. {{ActiveMQChannelHandler#exceptionCaught}} gets called—*this is the key 
> point that causes issues*. The connection is cleaned up if and only if this 
> is *not* called. The root cause of the exception is 
> {{AbstractChannel.close(ChannelPromise)}}, however the comment above it says 
> this is normal for failover.
> 5. The {{active}} flag is set to {{false}}.
> 6. {{ActiveMQChannelHandler#channelInactive}} gets called, but does *not* 
> call {{listener.connectionDestroyed}} since the {{active}} flag is false.
> 7. The connection is never removed from the {{connections}} map in 
> {{NettyAcceptor}}, causing a leak and eventual OOM of the broker if it 
> happens frequently enough.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4796) Simplify SimpleString API

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4796?focusedWorklogId=922540=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922540
 ]

ASF GitHub Bot logged work on ARTEMIS-4796:
---

Author: ASF GitHub Bot
Created on: 07/Jun/24 10:44
Start Date: 07/Jun/24 10:44
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on PR #4959:
URL: 
https://github.com/apache/activemq-artemis/pull/4959#issuecomment-2154566142

   Same general review comment as last time. There are still several references 
to toSimpleString (outside compatibility tests). There is now-unused deprecated 
stuff that isn't tested.




Issue Time Tracking
---

Worklog Id: (was: 922540)
Time Spent: 3h  (was: 2h 50m)

> Simplify SimpleString API
> -
>
> Key: ARTEMIS-4796
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4796
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 3h
>  Remaining Estimate: 0h
>
> Instead of using the verbosely named {{toSimpleString}} static factory method 
> (and its overloaded counterparts), {{SimpleString}} should provide {{of}} 
> implementations. This change would make the code more concise and readable. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4799) Broker Connection Receiver attach handled incorrectly

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4799?focusedWorklogId=922536=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922536
 ]

ASF GitHub Bot logged work on ARTEMIS-4799:
---

Author: ASF GitHub Bot
Created on: 07/Jun/24 10:21
Start Date: 07/Jun/24 10:21
Worklog Time Spent: 10m 
  Work Description: gemmellr merged PR #4963:
URL: https://github.com/apache/activemq-artemis/pull/4963




Issue Time Tracking
---

Worklog Id: (was: 922536)
Time Spent: 20m  (was: 10m)

> Broker Connection Receiver attach handled incorrectly
> -
>
> Key: ARTEMIS-4799
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4799
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 2.34.0
>Reporter: Timothy A. Bish
>Assignee: Timothy A. Bish
>Priority: Minor
> Fix For: 2.35.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The AMQP Broker Connection Receiver configuration creates a receiver for 
> messages from a remote AMQP source however the attach handling is not 
> properly handled leading to a receiver that thinks it is operating as an 
> opened anonymous relay sender meaning it only routes messages with a set 'To' 
> field in the properties.  The receiver attach should be using the locally 
> defined target as the address for incoming messages and ignore an 'To' value 
> in the message properties.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4802) Depricated master,slave,check-for-live-server tags in examples/features/ha/replicated-failback sample

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4802?focusedWorklogId=922450=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922450
 ]

ASF GitHub Bot logged work on ARTEMIS-4802:
---

Author: ASF GitHub Bot
Created on: 07/Jun/24 05:48
Start Date: 07/Jun/24 05:48
Worklog Time Spent: 10m 
  Work Description: susinda opened a new pull request, #10:
URL: https://github.com/apache/activemq-artemis-examples/pull/10

   Fixing the use of deprecating tags master, slave, check-for-live-server in 
ha/replicated-failback sample with their new values
   primary, backup and check-for-active-server 




Issue Time Tracking
---

Worklog Id: (was: 922450)
Remaining Estimate: 0h
Time Spent: 10m

> Depricated master,slave,check-for-live-server tags in 
> examples/features/ha/replicated-failback sample
> -
>
> Key: ARTEMIS-4802
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4802
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: ActiveMQ-Artemis-Examples
>Affects Versions: 2.34.0
>Reporter: Susinda Perera
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> When starting active mq ha samples it gives below log messages. 
>  
> {code:java}
> INFO [org.apache.activemq.artemis.core.server] AMQ221038: Configuration 
> option 'master' is deprecated and will be removed in a future version. Use 
> 'primary' instead. Consult the manual for details.
> INFO [org.apache.activemq.artemis.core.server] AMQ221038: Configuration 
> option 'check-for-live-server' is deprecated and will be removed in a future 
> version. Use 'check-for-active-server' instead. Consult the manual for 
> details.
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4801) AMQP Session address query cache can have invalid state for long lived sessions

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4801?focusedWorklogId=922430=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922430
 ]

ASF GitHub Bot logged work on ARTEMIS-4801:
---

Author: ASF GitHub Bot
Created on: 07/Jun/24 01:07
Start Date: 07/Jun/24 01:07
Worklog Time Spent: 10m 
  Work Description: clebertsuconic merged PR #4965:
URL: https://github.com/apache/activemq-artemis/pull/4965




Issue Time Tracking
---

Worklog Id: (was: 922430)
Time Spent: 20m  (was: 10m)

> AMQP Session address query cache can have invalid state for long lived 
> sessions
> ---
>
> Key: ARTEMIS-4801
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4801
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 2.34.0
>Reporter: Timothy A. Bish
>Assignee: Timothy A. Bish
>Priority: Major
> Fix For: 2.35.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The AMQPSessionCallback retains a map of AddressQueryResult instances for 
> previous address checks.  This map is not updated if the state of broker 
> addresses changes, neither addresses added, removed or updated states are 
> reflected in the cache.  This leads to issues for long running sessions where 
> a link attach may fail for a non-existent address and on a later attempt 
> should succeed if the address was added but can't because the cache will 
> still hold the non-exists query result.  Other scenarios are possible such as 
> an address removed and re-added with different routing type but the former 
> case is more serious. 
> The cache should be removed and if a similar optimization is actually found 
> to be needed a better mechanism should be chosen to avoid the issues found.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4801) AMQP Session address query cache can have invalid state for long lived sessions

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4801?focusedWorklogId=922426=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922426
 ]

ASF GitHub Bot logged work on ARTEMIS-4801:
---

Author: ASF GitHub Bot
Created on: 06/Jun/24 20:54
Start Date: 06/Jun/24 20:54
Worklog Time Spent: 10m 
  Work Description: tabish121 opened a new pull request, #4965:
URL: https://github.com/apache/activemq-artemis/pull/4965

   When caching address query results the remote session can be blocked forever 
from creating links on an address if the "does not exist" value is cached since 
it is never updated again and will always report "does not exist" even if the 
address is added manually via management later. The cache state can cause other 
issues for long running sessions as well and should be removed to avoid attach 
failures for cases where the current broker state could allow the attach to 
succeed but the cached entry won't allow it.




Issue Time Tracking
---

Worklog Id: (was: 922426)
Remaining Estimate: 0h
Time Spent: 10m

> AMQP Session address query cache can have invalid state for long lived 
> sessions
> ---
>
> Key: ARTEMIS-4801
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4801
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 2.34.0
>Reporter: Timothy A. Bish
>Assignee: Timothy A. Bish
>Priority: Major
> Fix For: 2.35.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The AMQPSessionCallback retains a map of AddressQueryResult instances for 
> previous address checks.  This map is not updated if the state of broker 
> addresses changes, neither addresses added, removed or updated states are 
> reflected in the cache.  This leads to issues for long running sessions where 
> a link attach may fail for a non-existent address and on a later attempt 
> should succeed if the address was added but can't because the cache will 
> still hold the non-exists query result.  Other scenarios are possible such as 
> an address removed and re-added with different routing type but the former 
> case is more serious. 
> The cache should be removed and if a similar optimization is actually found 
> to be needed a better mechanism should be chosen to avoid the issues found.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4800) Simplify QueueConfiguration API

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4800?focusedWorklogId=922424=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922424
 ]

ASF GitHub Bot logged work on ARTEMIS-4800:
---

Author: ASF GitHub Bot
Created on: 06/Jun/24 20:23
Start Date: 06/Jun/24 20:23
Worklog Time Spent: 10m 
  Work Description: jbertram opened a new pull request, #4964:
URL: https://github.com/apache/activemq-artemis/pull/4964

   This commit does the following:
   
- deprecate all QueueConfiguration ctors
- add `of` static factory methods for all the deprecated ctors
- replace any uses of the normal ctors with the `of` counterparts
   
   This makes the code more concise and readable.




Issue Time Tracking
---

Worklog Id: (was: 922424)
Remaining Estimate: 0h
Time Spent: 10m

> Simplify QueueConfiguration API
> ---
>
> Key: ARTEMIS-4800
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4800
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4799) Broker Connection Receiver attach handled incorrectly

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4799?focusedWorklogId=922415=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922415
 ]

ASF GitHub Bot logged work on ARTEMIS-4799:
---

Author: ASF GitHub Bot
Created on: 06/Jun/24 17:48
Start Date: 06/Jun/24 17:48
Worklog Time Spent: 10m 
  Work Description: tabish121 opened a new pull request, #4963:
URL: https://github.com/apache/activemq-artemis/pull/4963

   The receiver attach in broker connection does not wait for the remote attach 
to arrive before creating the broker side receiver plumbing which leads to the 
broker treating the remote sender as an anonymous relay when it is not and 
should not be. Await the remote attach in response to the attach sent by the 
broker connection to finish the link setup but use the locally defined target 
address vs the remote to route the incoming messages.




Issue Time Tracking
---

Worklog Id: (was: 922415)
Remaining Estimate: 0h
Time Spent: 10m

> Broker Connection Receiver attach handled incorrectly
> -
>
> Key: ARTEMIS-4799
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4799
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 2.34.0
>Reporter: Timothy A. Bish
>Assignee: Timothy A. Bish
>Priority: Minor
> Fix For: 2.35.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The AMQP Broker Connection Receiver configuration creates a receiver for 
> messages from a remote AMQP source however the attach handling is not 
> properly handled leading to a receiver that thinks it is operating as an 
> opened anonymous relay sender meaning it only routes messages with a set 'To' 
> field in the properties.  The receiver attach should be using the locally 
> defined target as the address for incoming messages and ignore an 'To' value 
> in the message properties.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4796) Simplify SimpleString API

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4796?focusedWorklogId=922397=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922397
 ]

ASF GitHub Bot logged work on ARTEMIS-4796:
---

Author: ASF GitHub Bot
Created on: 06/Jun/24 15:53
Start Date: 06/Jun/24 15:53
Worklog Time Spent: 10m 
  Work Description: clebertsuconic merged PR #4959:
URL: https://github.com/apache/activemq-artemis/pull/4959




Issue Time Tracking
---

Worklog Id: (was: 922397)
Time Spent: 2h 50m  (was: 2h 40m)

> Simplify SimpleString API
> -
>
> Key: ARTEMIS-4796
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4796
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> Instead of using the verbosely named {{toSimpleString}} static factory method 
> (and its overloaded counterparts), {{SimpleString}} should provide {{of}} 
> implementations. This change would make the code more concise and readable. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4796) Simplify SimpleString API

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4796?focusedWorklogId=922396=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922396
 ]

ASF GitHub Bot logged work on ARTEMIS-4796:
---

Author: ASF GitHub Bot
Created on: 06/Jun/24 15:53
Start Date: 06/Jun/24 15:53
Worklog Time Spent: 10m 
  Work Description: clebertsuconic commented on PR #4959:
URL: 
https://github.com/apache/activemq-artemis/pull/4959#issuecomment-2152869890

   lets merge and review? otherwise you will keep rebasing forever 




Issue Time Tracking
---

Worklog Id: (was: 922396)
Time Spent: 2h 40m  (was: 2.5h)

> Simplify SimpleString API
> -
>
> Key: ARTEMIS-4796
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4796
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> Instead of using the verbosely named {{toSimpleString}} static factory method 
> (and its overloaded counterparts), {{SimpleString}} should provide {{of}} 
> implementations. This change would make the code more concise and readable. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4796) Simplify SimpleString API

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4796?focusedWorklogId=922381=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922381
 ]

ASF GitHub Bot logged work on ARTEMIS-4796:
---

Author: ASF GitHub Bot
Created on: 06/Jun/24 15:24
Start Date: 06/Jun/24 15:24
Worklog Time Spent: 10m 
  Work Description: jbertram commented on PR #4959:
URL: 
https://github.com/apache/activemq-artemis/pull/4959#issuecomment-2152810047

   I rebased and changed as many of the remaining references to deprecated 
methods that I could. There are a handful of references to deprecated methods 
in the compatibility tests, but those must remain due to the fact that those 
tests are actually using older versions that don't have the new methods.




Issue Time Tracking
---

Worklog Id: (was: 922381)
Time Spent: 2.5h  (was: 2h 20m)

> Simplify SimpleString API
> -
>
> Key: ARTEMIS-4796
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4796
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> Instead of using the verbosely named {{toSimpleString}} static factory method 
> (and its overloaded counterparts), {{SimpleString}} should provide {{of}} 
> implementations. This change would make the code more concise and readable. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4796) Simplify SimpleString API

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4796?focusedWorklogId=922313=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922313
 ]

ASF GitHub Bot logged work on ARTEMIS-4796:
---

Author: ASF GitHub Bot
Created on: 06/Jun/24 10:10
Start Date: 06/Jun/24 10:10
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on PR #4959:
URL: 
https://github.com/apache/activemq-artemis/pull/4959#issuecomment-2151907691

   The change should probably be rebased to current main, which has already 
added new use of the now-deprecated bits that this misses switching over.
   
   From doing a grep, there also looks to remain a number of other existing 
uses of toSimpleString that perhaps should be updated also.
   
   Feels like we should be unit testing any otherwise-unused deprecated bits, 
but it doesnt appear like either of the two SimpleStringTest classes do so.




Issue Time Tracking
---

Worklog Id: (was: 922313)
Time Spent: 2h 20m  (was: 2h 10m)

> Simplify SimpleString API
> -
>
> Key: ARTEMIS-4796
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4796
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> Instead of using the verbosely named {{toSimpleString}} static factory method 
> (and its overloaded counterparts), {{SimpleString}} should provide {{of}} 
> implementations. This change would make the code more concise and readable. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4798) Address Size differs between Mirror and Source queue, leading to OME scenarios

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4798?focusedWorklogId=922262=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922262
 ]

ASF GitHub Bot logged work on ARTEMIS-4798:
---

Author: ASF GitHub Bot
Created on: 05/Jun/24 23:40
Start Date: 05/Jun/24 23:40
Worklog Time Spent: 10m 
  Work Description: clebertsuconic commented on PR #4961:
URL: 
https://github.com/apache/activemq-artemis/pull/4961#issuecomment-2151129118

   there is a test failure I need to investigate.. a negative counter in the 
address size on BrokerInSyncTest::testLVQ
   
   there could be something else in there..




Issue Time Tracking
---

Worklog Id: (was: 922262)
Time Spent: 20m  (was: 10m)

> Address Size differs between Mirror and Source queue, leading to OME scenarios
> --
>
> Key: ARTEMIS-4798
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4798
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.34.0
>Reporter: Clebert Suconic
>Assignee: Clebert Suconic
>Priority: Major
> Fix For: 2.35.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Say you configure the broker to mirror.
> You stop the mirror target (shutdown the server).
> Now you send and consume from a destination, keeping the destination's size 
> close to zero.
> You may get an OME on that situation.
> This is because the calculation on the address-size only computes the main 
> body of the message at the original queue. While Mirror will only get a small 
> portion on the reference, in such cases you would end up with lazy starts in 
> paging... and things could go wrong.
> To fix that, both Mirror and the source queue should get the body portion of 
> the size.
> Basically while we route the message, we check if the address is not the 
> original and the Mirror SNF should also get the same portion of the size in 
> its calculation.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4796) Simplify SimpleString API

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4796?focusedWorklogId=922242=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922242
 ]

ASF GitHub Bot logged work on ARTEMIS-4796:
---

Author: ASF GitHub Bot
Created on: 05/Jun/24 19:56
Start Date: 05/Jun/24 19:56
Worklog Time Spent: 10m 
  Work Description: clebertsuconic commented on PR #4959:
URL: 
https://github.com/apache/activemq-artemis/pull/4959#issuecomment-2150845722

   We can merge it I think. 




Issue Time Tracking
---

Worklog Id: (was: 922242)
Time Spent: 2h 10m  (was: 2h)

> Simplify SimpleString API
> -
>
> Key: ARTEMIS-4796
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4796
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> Instead of using the verbosely named {{toSimpleString}} static factory method 
> (and its overloaded counterparts), {{SimpleString}} should provide {{of}} 
> implementations. This change would make the code more concise and readable. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4796) Simplify SimpleString API

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4796?focusedWorklogId=922240=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922240
 ]

ASF GitHub Bot logged work on ARTEMIS-4796:
---

Author: ASF GitHub Bot
Created on: 05/Jun/24 18:50
Start Date: 05/Jun/24 18:50
Worklog Time Spent: 10m 
  Work Description: jbertram commented on code in PR #4959:
URL: https://github.com/apache/activemq-artemis/pull/4959#discussion_r1628281605


##
artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java:
##
@@ -56,20 +56,37 @@ public final class SimpleString implements CharSequence, 
Serializable, Comparabl
 * @param string String used to instantiate a SimpleString.
 * @return A new SimpleString
 */
-   public static SimpleString toSimpleString(final String string) {
+   public static SimpleString of(final String string) {
   if (string == null) {
  return null;
   }
   return new SimpleString(string);
}
 
-   public static SimpleString toSimpleString(final String string, 
StringSimpleStringPool pool) {
+   public static SimpleString of(final String string, StringSimpleStringPool 
pool) {
   if (pool == null) {
- return toSimpleString(string);
+ return of(string);
   }
   return pool.getOrCreate(string);
}
 
+   public static SimpleString of(final byte[] data) {
+  return new SimpleString(data);
+   }
+
+   public static SimpleString of(final char c) {
+  return new SimpleString(c);
+   }
+
+   @Deprecated(forRemoval = true)
+   public static SimpleString toSimpleString(final String string) {
+  return of(string);
+   }
+
+   @Deprecated(forRemoval = true)
+   public static SimpleString toSimpleString(final String string, 
StringSimpleStringPool pool) {
+  return of(string, pool);
+   }

Review Comment:
   I fleshed out the JavaDoc on both the old and new methods as well as 
deprecating the constructors.





Issue Time Tracking
---

Worklog Id: (was: 922240)
Time Spent: 2h  (was: 1h 50m)

> Simplify SimpleString API
> -
>
> Key: ARTEMIS-4796
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4796
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> Instead of using the verbosely named {{toSimpleString}} static factory method 
> (and its overloaded counterparts), {{SimpleString}} should provide {{of}} 
> implementations. This change would make the code more concise and readable. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4796) Simplify SimpleString API

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4796?focusedWorklogId=922237=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922237
 ]

ASF GitHub Bot logged work on ARTEMIS-4796:
---

Author: ASF GitHub Bot
Created on: 05/Jun/24 18:14
Start Date: 05/Jun/24 18:14
Worklog Time Spent: 10m 
  Work Description: jbertram commented on PR #4959:
URL: 
https://github.com/apache/activemq-artemis/pull/4959#issuecomment-2150671313

   That said, if we can remove `SimpleString` completely I'm good with that 
too. Of course, this PR is not mutually exclusive with that objective. Consider 
it a stop-gap on the way.




Issue Time Tracking
---

Worklog Id: (was: 922237)
Time Spent: 1h 50m  (was: 1h 40m)

> Simplify SimpleString API
> -
>
> Key: ARTEMIS-4796
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4796
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Instead of using the verbosely named {{toSimpleString}} static factory method 
> (and its overloaded counterparts), {{SimpleString}} should provide {{of}} 
> implementations. This change would make the code more concise and readable. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4796) Simplify SimpleString API

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4796?focusedWorklogId=922236=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922236
 ]

ASF GitHub Bot logged work on ARTEMIS-4796:
---

Author: ASF GitHub Bot
Created on: 05/Jun/24 18:13
Start Date: 05/Jun/24 18:13
Worklog Time Spent: 10m 
  Work Description: jbertram commented on PR #4959:
URL: 
https://github.com/apache/activemq-artemis/pull/4959#issuecomment-2150668986

   As far as I'm aware, the "of" naming convention was introduced in 2008 in 
the second edition of Joshua Block's _Effective Java_. He identified it as a 
way to draw attention to static factories and adhere to common naming 
conventions. It is a more concise version of `valueOf` which is also used 
prolifically throughout the Java API. It's an industry standard at this point.




Issue Time Tracking
---

Worklog Id: (was: 922236)
Time Spent: 1h 40m  (was: 1.5h)

> Simplify SimpleString API
> -
>
> Key: ARTEMIS-4796
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4796
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Instead of using the verbosely named {{toSimpleString}} static factory method 
> (and its overloaded counterparts), {{SimpleString}} should provide {{of}} 
> implementations. This change would make the code more concise and readable. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4796) Simplify SimpleString API

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4796?focusedWorklogId=922234=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922234
 ]

ASF GitHub Bot logged work on ARTEMIS-4796:
---

Author: ASF GitHub Bot
Created on: 05/Jun/24 17:30
Start Date: 05/Jun/24 17:30
Worklog Time Spent: 10m 
  Work Description: tabish121 commented on PR #4959:
URL: 
https://github.com/apache/activemq-artemis/pull/4959#issuecomment-2150593808

   > > I don't really like the name "of" but that's just my personal taste 
probably... (of kind of kicks my OCD.. being a preposition, I feel like of 
what? :)
   > > but as I said.. that's my personal preference only...
   > > but I don't want to get in the way.. I will get used to it :) and I'm +1 
to merge it.. and you should probably merge it soon before you have to rebase 
it.
   > > +1 from me.
   > 
   > I presume it comes from the trend of Map.of(..) etc factory helpers. I 
dont mind it, though I personally wouldnt have changed it here given I'd rather 
SimpleString vanish, along with all the realted conversions and the byte 
doubling etc etc that come with it.
   
   Agreed with Robbie on the name, it matches some Collections APIs etc and 
isn't hard to grok plus its just less verbose.  But I'd also like to see an 
effort towards removing the SimpleString to simplify working with the broker 
internals.  




Issue Time Tracking
---

Worklog Id: (was: 922234)
Time Spent: 1.5h  (was: 1h 20m)

> Simplify SimpleString API
> -
>
> Key: ARTEMIS-4796
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4796
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Instead of using the verbosely named {{toSimpleString}} static factory method 
> (and its overloaded counterparts), {{SimpleString}} should provide {{of}} 
> implementations. This change would make the code more concise and readable. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4796) Simplify SimpleString API

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4796?focusedWorklogId=922233=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922233
 ]

ASF GitHub Bot logged work on ARTEMIS-4796:
---

Author: ASF GitHub Bot
Created on: 05/Jun/24 17:22
Start Date: 05/Jun/24 17:22
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on PR #4959:
URL: 
https://github.com/apache/activemq-artemis/pull/4959#issuecomment-2150579148

   > I don't really like the name "of" but that's just my personal taste 
probably... (of kind of kicks my OCD.. being a preposition, I feel like of 
what? :)
   > 
   > but as I said.. that's my personal preference only...
   > 
   > but I don't want to get in the way.. I will get used to it :) and I'm +1 
to merge it.. and you should probably merge it soon before you have to rebase 
it.
   > 
   > +1 from me.
   
   I presume it comes from the trend of Map.of(..) etc factory helpers. I dont 
mind it, though I personally wouldnt have changed it here given I'd rather 
SimpleString vanish, along with all the realted conversions and the byte 
doubling etc etc that come with it.
   




Issue Time Tracking
---

Worklog Id: (was: 922233)
Time Spent: 1h 20m  (was: 1h 10m)

> Simplify SimpleString API
> -
>
> Key: ARTEMIS-4796
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4796
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Instead of using the verbosely named {{toSimpleString}} static factory method 
> (and its overloaded counterparts), {{SimpleString}} should provide {{of}} 
> implementations. This change would make the code more concise and readable. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4796) Simplify SimpleString API

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4796?focusedWorklogId=922230=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922230
 ]

ASF GitHub Bot logged work on ARTEMIS-4796:
---

Author: ASF GitHub Bot
Created on: 05/Jun/24 17:08
Start Date: 05/Jun/24 17:08
Worklog Time Spent: 10m 
  Work Description: clebertsuconic commented on PR #4959:
URL: 
https://github.com/apache/activemq-artemis/pull/4959#issuecomment-2150554643

   I don't really like the name "of" but that's just my personal taste 
probably... (of kind of kicks my OCD.. being a preposition, I feel like of 
what? :) 
   
   
   but as I said.. that's my personal preference only...
   
   
   but I don't want to get in the way.. I will get used to it :) and I'm +1 to 
merge it..  and you should probably merge it soon before you have to rebase it.
   
   +1 from me.




Issue Time Tracking
---

Worklog Id: (was: 922230)
Time Spent: 1h 10m  (was: 1h)

> Simplify SimpleString API
> -
>
> Key: ARTEMIS-4796
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4796
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Instead of using the verbosely named {{toSimpleString}} static factory method 
> (and its overloaded counterparts), {{SimpleString}} should provide {{of}} 
> implementations. This change would make the code more concise and readable. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4796) Simplify SimpleString API

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4796?focusedWorklogId=99=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-99
 ]

ASF GitHub Bot logged work on ARTEMIS-4796:
---

Author: ASF GitHub Bot
Created on: 05/Jun/24 17:03
Start Date: 05/Jun/24 17:03
Worklog Time Spent: 10m 
  Work Description: clebertsuconic commented on PR #4959:
URL: 
https://github.com/apache/activemq-artemis/pull/4959#issuecomment-2150545961

   I wouldn't mind seeing SimpleString gone. Change the packets in Core to send 
char[] ... and be gone!
   
   But that would require a lot of testing.. especially around the pools on 
reading?




Issue Time Tracking
---

Worklog Id: (was: 99)
Time Spent: 1h  (was: 50m)

> Simplify SimpleString API
> -
>
> Key: ARTEMIS-4796
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4796
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Instead of using the verbosely named {{toSimpleString}} static factory method 
> (and its overloaded counterparts), {{SimpleString}} should provide {{of}} 
> implementations. This change would make the code more concise and readable. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4798) Address Size differs between Mirror and Source queue, leading to OME scenarios

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4798?focusedWorklogId=98=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-98
 ]

ASF GitHub Bot logged work on ARTEMIS-4798:
---

Author: ASF GitHub Bot
Created on: 05/Jun/24 16:49
Start Date: 05/Jun/24 16:49
Worklog Time Spent: 10m 
  Work Description: clebertsuconic opened a new pull request, #4961:
URL: https://github.com/apache/activemq-artemis/pull/4961

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 98)
Remaining Estimate: 0h
Time Spent: 10m

> Address Size differs between Mirror and Source queue, leading to OME scenarios
> --
>
> Key: ARTEMIS-4798
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4798
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.34.0
>Reporter: Clebert Suconic
>Assignee: Clebert Suconic
>Priority: Major
> Fix For: 2.35.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Say you configure the broker to mirror.
> You stop the mirror target (shutdown the server).
> Now you send and consume from a destination, keeping the destination's size 
> close to zero.
> You may get an OME on that situation.
> This is because the calculation on the address-size only computes the main 
> body of the message at the original queue. While Mirror will only get a small 
> portion on the reference, in such cases you would end up with lazy starts in 
> paging... and things could go wrong.
> To fix that, both Mirror and the source queue should get the body portion of 
> the size.
> Basically while we route the message, we check if the address is not the 
> original and the Mirror SNF should also get the same portion of the size in 
> its calculation.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4797) Failover connection references are not always cleaned up in NettyAcceptor, leaking memory

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4797?focusedWorklogId=922213=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922213
 ]

ASF GitHub Bot logged work on ARTEMIS-4797:
---

Author: ASF GitHub Bot
Created on: 05/Jun/24 15:41
Start Date: 05/Jun/24 15:41
Worklog Time Spent: 10m 
  Work Description: joshb1050 commented on PR #4960:
URL: 
https://github.com/apache/activemq-artemis/pull/4960#issuecomment-2150387876

   I am running this swapped into the environment in which this was originally 
detected and it has not appeared to leak any memory so far.




Issue Time Tracking
---

Worklog Id: (was: 922213)
Time Spent: 20m  (was: 10m)

> Failover connection references are not always cleaned up in NettyAcceptor, 
> leaking memory
> -
>
> Key: ARTEMIS-4797
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4797
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: OpenWire
>Reporter: Josh Byster
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> I'm still trying to parse through exactly what conditions this occurs in, 
> since I'm able to reproduce it in a very specific production setup but not in 
> an isolated environment locally.
> For context, we have custom slow consumer detection that closes connection 
> IDs with slow consumers. These connections are connected via failover 
> transport using client ActiveMQ Classic 5.16.4 (OpenWire). This seems to be 
> specific to Netty.
> It appears this specific order of events causes the connection to not get 
> cleaned up and retained indefinitely on the broker. With frequent kicking of 
> connections, this ends up causing the broker to eventually OOM.
> 1. Connection is created, {{ActiveMQServerChannelHandler}} is created as well
> 2. {{ActiveMQServerChannelHandler#createConnection}} is called, {{active}} 
> flag is set {{true}}.
> 3. A few minutes go by, then we call 
> {{ActiveMQServerControl#closeConnectionWithID}} with the connection ID.
> 4. {{ActiveMQChannelHandler#exceptionCaught}} gets called—*this is the key 
> point that causes issues*. The connection is cleaned up if and only if this 
> is *not* called. The root cause of the exception is 
> {{AbstractChannel.close(ChannelPromise)}}, however the comment above it says 
> this is normal for failover.
> 5. The {{active}} flag is set to {{false}}.
> 6. {{ActiveMQChannelHandler#channelInactive}} gets called, but does *not* 
> call {{listener.connectionDestroyed}} since the {{active}} flag is false.
> 7. The connection is never removed from the {{connections}} map in 
> {{NettyAcceptor}}, causing a leak and eventual OOM of the broker if it 
> happens frequently enough.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4797) Failover connection references are not always cleaned up in NettyAcceptor, leaking memory

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4797?focusedWorklogId=922212=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922212
 ]

ASF GitHub Bot logged work on ARTEMIS-4797:
---

Author: ASF GitHub Bot
Created on: 05/Jun/24 15:39
Start Date: 05/Jun/24 15:39
Worklog Time Spent: 10m 
  Work Description: joshb1050 opened a new pull request, #4960:
URL: https://github.com/apache/activemq-artemis/pull/4960

   If an exception is caught before the channel is deemed inactive, the 
reference to the Netty connection will not get destroyed and will leak memory 
in `NettyAcceptor`.
   
   This commit adds a flag when an exception is encountered so that the 
connection is still destroyed in this case when the channel becomes inactive.




Issue Time Tracking
---

Worklog Id: (was: 922212)
Remaining Estimate: 0h
Time Spent: 10m

> Failover connection references are not always cleaned up in NettyAcceptor, 
> leaking memory
> -
>
> Key: ARTEMIS-4797
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4797
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: OpenWire
>Reporter: Josh Byster
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> I'm still trying to parse through exactly what conditions this occurs in, 
> since I'm able to reproduce it in a very specific production setup but not in 
> an isolated environment locally.
> For context, we have custom slow consumer detection that closes connection 
> IDs with slow consumers. These connections are connected via failover 
> transport using client ActiveMQ Classic 5.16.4 (OpenWire). This seems to be 
> specific to Netty.
> It appears this specific order of events causes the connection to not get 
> cleaned up and retained indefinitely on the broker. With frequent kicking of 
> connections, this ends up causing the broker to eventually OOM.
> 1. Connection is created, {{ActiveMQServerChannelHandler}} is created as well
> 2. {{ActiveMQServerChannelHandler#createConnection}} is called, {{active}} 
> flag is set {{true}}.
> 3. A few minutes go by, then we call 
> {{ActiveMQServerControl#closeConnectionWithID}} with the connection ID.
> 4. {{ActiveMQChannelHandler#exceptionCaught}} gets called—*this is the key 
> point that causes issues*. The connection is cleaned up if and only if this 
> is *not* called. The root cause of the exception is 
> {{AbstractChannel.close(ChannelPromise)}}, however the comment above it says 
> this is normal for failover.
> 5. The {{active}} flag is set to {{false}}.
> 6. {{ActiveMQChannelHandler#channelInactive}} gets called, but does *not* 
> call {{listener.connectionDestroyed}} since the {{active}} flag is false.
> 7. The connection is never removed from the {{connections}} map in 
> {{NettyAcceptor}}, causing a leak and eventual OOM of the broker if it 
> happens frequently enough.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4780) Artemis web console does not ever set 'artemisJmxDomain' in localStorage

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4780?focusedWorklogId=922206=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922206
 ]

ASF GitHub Bot logged work on ARTEMIS-4780:
---

Author: ASF GitHub Bot
Created on: 05/Jun/24 15:03
Start Date: 05/Jun/24 15:03
Worklog Time Spent: 10m 
  Work Description: joshb1050 commented on PR #18:
URL: 
https://github.com/apache/activemq-artemis-console/pull/18#issuecomment-2150302868

   The tricky piece of this is the WAR is provided separately and so we have to 
run a custom shader to shade it. However it doesn't rewrite the JMX domain as 
part of the shading process as it's just a string in a TS file.

   I think what's unexpected is the JMXDomain is configurable as one says but 
the console doesn't pick up on it, hence the confusion.
   
   Custom compilation does work changing the hardcoded value and we could do 
that if that's the best approach forward. Thanks for looking at this.




Issue Time Tracking
---

Worklog Id: (was: 922206)
Time Spent: 1h  (was: 50m)

> Artemis web console does not ever set 'artemisJmxDomain' in localStorage
> 
>
> Key: ARTEMIS-4780
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4780
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.32.0
>Reporter: Josh Byster
>Assignee: Andy Taylor
>Priority: Minor
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> We relocate our artemis packages as part of our shading process. 
> I did set up:
> 
> {code:java}
> aActiveMQServer.getConfiguration().setJMXDomain("com.abc.shaded.org.apache.activemq.artemis");
> {code}
> However the web console does not show up. I noticed in the code it's because 
> we try to read in localStorage['artemisJmxDomain'] but never actually set it 
> as far as I can tell. Thus we always default to org.apache.activemq.artemis.
> Everything works properly when setting localStorage['artemisJmxDomain'] = 
> "com.abc.shaded.org.apache.activemq.artemis"



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4780) Artemis web console does not ever set 'artemisJmxDomain' in localStorage

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4780?focusedWorklogId=922191=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922191
 ]

ASF GitHub Bot logged work on ARTEMIS-4780:
---

Author: ASF GitHub Bot
Created on: 05/Jun/24 13:48
Start Date: 05/Jun/24 13:48
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on PR #18:
URL: 
https://github.com/apache/activemq-artemis-console/pull/18#issuecomment-2150011256

   Well, from the JIRA I think it actually _is_ configurable on the broker 
(unclear why)...but seems like either noone has ever used that, or used it 
together with the console at the same time, or changed the console to match.




Issue Time Tracking
---

Worklog Id: (was: 922191)
Time Spent: 50m  (was: 40m)

> Artemis web console does not ever set 'artemisJmxDomain' in localStorage
> 
>
> Key: ARTEMIS-4780
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4780
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.32.0
>Reporter: Josh Byster
>Assignee: Andy Taylor
>Priority: Minor
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> We relocate our artemis packages as part of our shading process. 
> I did set up:
> 
> {code:java}
> aActiveMQServer.getConfiguration().setJMXDomain("com.abc.shaded.org.apache.activemq.artemis");
> {code}
> However the web console does not show up. I noticed in the code it's because 
> we try to read in localStorage['artemisJmxDomain'] but never actually set it 
> as far as I can tell. Thus we always default to org.apache.activemq.artemis.
> Everything works properly when setting localStorage['artemisJmxDomain'] = 
> "com.abc.shaded.org.apache.activemq.artemis"



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4780) Artemis web console does not ever set 'artemisJmxDomain' in localStorage

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4780?focusedWorklogId=922174=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922174
 ]

ASF GitHub Bot logged work on ARTEMIS-4780:
---

Author: ASF GitHub Bot
Created on: 05/Jun/24 12:48
Start Date: 05/Jun/24 12:48
Worklog Time Spent: 10m 
  Work Description: andytaylor commented on PR #18:
URL: 
https://github.com/apache/activemq-artemis-console/pull/18#issuecomment-2149772044

   For some reason I thought the domain was configurable so I think I agree. I 
will close this




Issue Time Tracking
---

Worklog Id: (was: 922174)
Time Spent: 40m  (was: 0.5h)

> Artemis web console does not ever set 'artemisJmxDomain' in localStorage
> 
>
> Key: ARTEMIS-4780
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4780
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.32.0
>Reporter: Josh Byster
>Assignee: Andy Taylor
>Priority: Minor
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> We relocate our artemis packages as part of our shading process. 
> I did set up:
> 
> {code:java}
> aActiveMQServer.getConfiguration().setJMXDomain("com.abc.shaded.org.apache.activemq.artemis");
> {code}
> However the web console does not show up. I noticed in the code it's because 
> we try to read in localStorage['artemisJmxDomain'] but never actually set it 
> as far as I can tell. Thus we always default to org.apache.activemq.artemis.
> Everything works properly when setting localStorage['artemisJmxDomain'] = 
> "com.abc.shaded.org.apache.activemq.artemis"



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4780) Artemis web console does not ever set 'artemisJmxDomain' in localStorage

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4780?focusedWorklogId=922173=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922173
 ]

ASF GitHub Bot logged work on ARTEMIS-4780:
---

Author: ASF GitHub Bot
Created on: 05/Jun/24 12:48
Start Date: 05/Jun/24 12:48
Worklog Time Spent: 10m 
  Work Description: andytaylor closed pull request #18: ARTEMIS-4780 - 
Allow JMX Domain to be discoverable
URL: https://github.com/apache/activemq-artemis-console/pull/18




Issue Time Tracking
---

Worklog Id: (was: 922173)
Time Spent: 0.5h  (was: 20m)

> Artemis web console does not ever set 'artemisJmxDomain' in localStorage
> 
>
> Key: ARTEMIS-4780
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4780
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.32.0
>Reporter: Josh Byster
>Assignee: Andy Taylor
>Priority: Minor
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> We relocate our artemis packages as part of our shading process. 
> I did set up:
> 
> {code:java}
> aActiveMQServer.getConfiguration().setJMXDomain("com.abc.shaded.org.apache.activemq.artemis");
> {code}
> However the web console does not show up. I noticed in the code it's because 
> we try to read in localStorage['artemisJmxDomain'] but never actually set it 
> as far as I can tell. Thus we always default to org.apache.activemq.artemis.
> Everything works properly when setting localStorage['artemisJmxDomain'] = 
> "com.abc.shaded.org.apache.activemq.artemis"



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4780) Artemis web console does not ever set 'artemisJmxDomain' in localStorage

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4780?focusedWorklogId=922160=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922160
 ]

ASF GitHub Bot logged work on ARTEMIS-4780:
---

Author: ASF GitHub Bot
Created on: 05/Jun/24 11:53
Start Date: 05/Jun/24 11:53
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on PR #18:
URL: 
https://github.com/apache/activemq-artemis-console/pull/18#issuecomment-2149643584

   This feels off. The whole point of the domain in the object name is to avoid 
clashing, as some other component could easily have broker= in its mbean names.
   
   I see from JIRA that this is coming up due to shading the broker. Presumably 
the console bits should be shaded too in that case? Is there a way the value 
could be taken from a file, such that shading it could [be made to] update that 
also?




Issue Time Tracking
---

Worklog Id: (was: 922160)
Time Spent: 20m  (was: 10m)

> Artemis web console does not ever set 'artemisJmxDomain' in localStorage
> 
>
> Key: ARTEMIS-4780
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4780
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.32.0
>Reporter: Josh Byster
>Assignee: Andy Taylor
>Priority: Minor
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> We relocate our artemis packages as part of our shading process. 
> I did set up:
> 
> {code:java}
> aActiveMQServer.getConfiguration().setJMXDomain("com.abc.shaded.org.apache.activemq.artemis");
> {code}
> However the web console does not show up. I noticed in the code it's because 
> we try to read in localStorage['artemisJmxDomain'] but never actually set it 
> as far as I can tell. Thus we always default to org.apache.activemq.artemis.
> Everything works properly when setting localStorage['artemisJmxDomain'] = 
> "com.abc.shaded.org.apache.activemq.artemis"



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4545) Allow node ID to be configured

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4545?focusedWorklogId=922149=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922149
 ]

ASF GitHub Bot logged work on ARTEMIS-4545:
---

Author: ASF GitHub Bot
Created on: 05/Jun/24 11:24
Start Date: 05/Jun/24 11:24
Worklog Time Spent: 10m 
  Work Description: gtully commented on PR #4951:
URL: 
https://github.com/apache/activemq-artemis/pull/4951#issuecomment-2149588357

   Another use case is jdbc, it currently uses a new uuid as the node id, it 
too could benefit from a shared identity, allowing a restart/reconnect of an 
existing lock owner to retain a valid lease. At the moment, any restart results 
in a a full lease expiry because the node id is not consistent. 
   If the nodeid is configured through this logic then we can avoid the change
   
   
https://github.com/apache/activemq-artemis/blob/main/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/jdbc/JdbcNodeManager.java#L70
   




Issue Time Tracking
---

Worklog Id: (was: 922149)
Time Spent: 0.5h  (was: 20m)

> Allow node ID to be configured
> --
>
> Key: ARTEMIS-4545
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4545
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> In certain situations it would be beneficial to configure the node ID rather 
> than having it automatically generated. 
> For example, when using replication + failback if the primary server fails 
> the backup will take over. Then when the primary is restarted it will 
> initiate failback. However, if the primary broker's journal is damaged or 
> lost during the initial failure then it won't be able to initiate failback 
> because it won't have the same node ID as the backup. This kind of situation 
> is not uncommon in cloud environments where there is no persistent, attached 
> storage.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4796) Simplify SimpleString API

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4796?focusedWorklogId=922146=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922146
 ]

ASF GitHub Bot logged work on ARTEMIS-4796:
---

Author: ASF GitHub Bot
Created on: 05/Jun/24 11:22
Start Date: 05/Jun/24 11:22
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on PR #4959:
URL: 
https://github.com/apache/activemq-artemis/pull/4959#issuecomment-2149585374

   Bigger 'SimpleString API simplication': deletion? :)




Issue Time Tracking
---

Worklog Id: (was: 922146)
Time Spent: 50m  (was: 40m)

> Simplify SimpleString API
> -
>
> Key: ARTEMIS-4796
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4796
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Instead of using the verbosely named {{toSimpleString}} static factory method 
> (and its overloaded counterparts), {{SimpleString}} should provide {{of}} 
> implementations. This change would make the code more concise and readable. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4796) Simplify SimpleString API

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4796?focusedWorklogId=922145=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922145
 ]

ASF GitHub Bot logged work on ARTEMIS-4796:
---

Author: ASF GitHub Bot
Created on: 05/Jun/24 11:20
Start Date: 05/Jun/24 11:20
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on code in PR #4959:
URL: https://github.com/apache/activemq-artemis/pull/4959#discussion_r1627254132


##
artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java:
##
@@ -56,20 +56,37 @@ public final class SimpleString implements CharSequence, 
Serializable, Comparabl
 * @param string String used to instantiate a SimpleString.
 * @return A new SimpleString
 */
-   public static SimpleString toSimpleString(final String string) {
+   public static SimpleString of(final String string) {
   if (string == null) {
  return null;
   }
   return new SimpleString(string);
}
 
-   public static SimpleString toSimpleString(final String string, 
StringSimpleStringPool pool) {
+   public static SimpleString of(final String string, StringSimpleStringPool 
pool) {
   if (pool == null) {
- return toSimpleString(string);
+ return of(string);
   }
   return pool.getOrCreate(string);
}
 
+   public static SimpleString of(final byte[] data) {
+  return new SimpleString(data);
+   }
+
+   public static SimpleString of(final char c) {
+  return new SimpleString(c);
+   }
+
+   @Deprecated(forRemoval = true)
+   public static SimpleString toSimpleString(final String string) {
+  return of(string);
+   }
+
+   @Deprecated(forRemoval = true)
+   public static SimpleString toSimpleString(final String string, 
StringSimpleStringPool pool) {
+  return of(string, pool);
+   }

Review Comment:
   In this type of change its typical to have javadoc @ deprecated as well, 
indicating the replacement that should be used instead. E.g here the 
constructor is not deprecated (related question: should it also be?), so 
someone might notice the deprecation and switch to the constructor instead 
rather than the new 'of'.





Issue Time Tracking
---

Worklog Id: (was: 922145)
Time Spent: 40m  (was: 0.5h)

> Simplify SimpleString API
> -
>
> Key: ARTEMIS-4796
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4796
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Instead of using the verbosely named {{toSimpleString}} static factory method 
> (and its overloaded counterparts), {{SimpleString}} should provide {{of}} 
> implementations. This change would make the code more concise and readable. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4545) Allow node ID to be configured

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4545?focusedWorklogId=922137=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922137
 ]

ASF GitHub Bot logged work on ARTEMIS-4545:
---

Author: ASF GitHub Bot
Created on: 05/Jun/24 11:15
Start Date: 05/Jun/24 11:15
Worklog Time Spent: 10m 
  Work Description: gtully commented on PR #4951:
URL: 
https://github.com/apache/activemq-artemis/pull/4951#issuecomment-2149567599

   Have you seen: 
https://github.com/apache/activemq-artemis/blob/576622571a839720d83d800b12a7f2b2448b30d9/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ReplicationPrimaryActivation.java#L171
   
   with the zk locker we can have peer brokers that coordinate on a shared node 
id. it is called the coordinator-id in the zk activation config, but ends up as 
the node-id. With the potential for unknown backups with replication, the node 
id has to be reset. However this new config could make it simpler for pure 
peers, where there is no replication b/c the it is non persistent or uses a 
shared store.
   
   I guess we need to allow these to coexist or document that they must be used 
independently. 




Issue Time Tracking
---

Worklog Id: (was: 922137)
Time Spent: 20m  (was: 10m)

> Allow node ID to be configured
> --
>
> Key: ARTEMIS-4545
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4545
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> In certain situations it would be beneficial to configure the node ID rather 
> than having it automatically generated. 
> For example, when using replication + failback if the primary server fails 
> the backup will take over. Then when the primary is restarted it will 
> initiate failback. However, if the primary broker's journal is damaged or 
> lost during the initial failure then it won't be able to initiate failback 
> because it won't have the same node ID as the backup. This kind of situation 
> is not uncommon in cloud environments where there is no persistent, attached 
> storage.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4702) Only run command needs custom JVM settings

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4702?focusedWorklogId=922130=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922130
 ]

ASF GitHub Bot logged work on ARTEMIS-4702:
---

Author: ASF GitHub Bot
Created on: 05/Jun/24 10:48
Start Date: 05/Jun/24 10:48
Worklog Time Spent: 10m 
  Work Description: gtully commented on code in PR #4885:
URL: https://github.com/apache/activemq-artemis/pull/4885#discussion_r1627495954


##
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/artemis.profile:
##
@@ -36,7 +36,7 @@ ARTEMIS_INSTANCE_ETC_URI='${artemis.instance.etc.uri}'
 HAWTIO_ROLE='${role}'
 
 # Java Opts
-if [ -z "$JAVA_ARGS" ]; then
+if [ -z "$JAVA_ARGS" ] && [ "$1" = "run" ]; then

Review Comment:
   There is a related problem with the log4j2 config, see: 
https://issues.apache.org/jira/browse/ARTEMIS-4785
   
   in that case, we need to keep the logging just for the broker run and not 
for any other command. the comment on that jira has lots of good info.





Issue Time Tracking
---

Worklog Id: (was: 922130)
Time Spent: 0.5h  (was: 20m)

> Only run command needs custom JVM settings
> --
>
> Key: ARTEMIS-4702
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4702
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Right now every {{artemis}} command uses the same JVM settings from 
> {{artemis.profile}}. So, for example, if the settings included {{-Xms8G 
> -Xmx8G}} for running the broker (i.e. the {{run}} command) those same 
> settings would be used for the {{queue stat}}, {{consumer}}, {{producer}}, 
> etc. commands as well. At best, it's overkill to use 8G of memory for these 
> secondary commands and at worst it can actually prevent them from operating 
> at all (e.g. if the machine is low on memory).
> JVM settings really only need to apply to the {{run}} command.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4760) Creating MQTT consumer should work if auto-create-queues is false

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4760?focusedWorklogId=922090=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922090
 ]

ASF GitHub Bot logged work on ARTEMIS-4760:
---

Author: ASF GitHub Bot
Created on: 05/Jun/24 08:06
Start Date: 05/Jun/24 08:06
Worklog Time Spent: 10m 
  Work Description: gemmellr merged PR #4955:
URL: https://github.com/apache/activemq-artemis/pull/4955




Issue Time Tracking
---

Worklog Id: (was: 922090)
Time Spent: 0.5h  (was: 20m)

> Creating MQTT consumer should work if auto-create-queues is false
> -
>
> Key: ARTEMIS-4760
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4760
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4796) Simplify SimpleString API

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4796?focusedWorklogId=922045=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922045
 ]

ASF GitHub Bot logged work on ARTEMIS-4796:
---

Author: ASF GitHub Bot
Created on: 04/Jun/24 21:52
Start Date: 04/Jun/24 21:52
Worklog Time Spent: 10m 
  Work Description: jbertram commented on code in PR #4959:
URL: https://github.com/apache/activemq-artemis/pull/4959#discussion_r1626641094


##
artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java:
##
@@ -79,6 +96,8 @@ public static SimpleString toSimpleString(final String 
string, StringSimpleStrin
public SimpleString(final String string) {
   int len = string.length();
 
+  String.valueOf(1);

Review Comment:
   Whoops. That was left in by mistake.





Issue Time Tracking
---

Worklog Id: (was: 922045)
Time Spent: 0.5h  (was: 20m)

> Simplify SimpleString API
> -
>
> Key: ARTEMIS-4796
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4796
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Instead of using the verbosely named {{toSimpleString}} static factory method 
> (and its overloaded counterparts), {{SimpleString}} should provide {{of}} 
> implementations. This change would make the code more concise and readable. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4796) Simplify SimpleString API

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4796?focusedWorklogId=922043=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922043
 ]

ASF GitHub Bot logged work on ARTEMIS-4796:
---

Author: ASF GitHub Bot
Created on: 04/Jun/24 21:47
Start Date: 04/Jun/24 21:47
Worklog Time Spent: 10m 
  Work Description: tabish121 commented on code in PR #4959:
URL: https://github.com/apache/activemq-artemis/pull/4959#discussion_r1626637601


##
artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java:
##
@@ -79,6 +96,8 @@ public static SimpleString toSimpleString(final String 
string, StringSimpleStrin
public SimpleString(final String string) {
   int len = string.length();
 
+  String.valueOf(1);

Review Comment:
   What is this for in this context?





Issue Time Tracking
---

Worklog Id: (was: 922043)
Time Spent: 20m  (was: 10m)

> Simplify SimpleString API
> -
>
> Key: ARTEMIS-4796
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4796
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Instead of using the verbosely named {{toSimpleString}} static factory method 
> (and its overloaded counterparts), {{SimpleString}} should provide {{of}} 
> implementations. This change would make the code more concise and readable. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4796) Simplify SimpleString API

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4796?focusedWorklogId=922039=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922039
 ]

ASF GitHub Bot logged work on ARTEMIS-4796:
---

Author: ASF GitHub Bot
Created on: 04/Jun/24 21:18
Start Date: 04/Jun/24 21:18
Worklog Time Spent: 10m 
  Work Description: jbertram opened a new pull request, #4959:
URL: https://github.com/apache/activemq-artemis/pull/4959

   This commit does the following:
   
- deprecate the verbosely named `toSimpleString` static factory methods
- add `of` static factory methods for all the ctors
- replace any uses of the normal ctors with the `of` counterparts
   
   This makes the code more concise and readable.




Issue Time Tracking
---

Worklog Id: (was: 922039)
Remaining Estimate: 0h
Time Spent: 10m

> Simplify SimpleString API
> -
>
> Key: ARTEMIS-4796
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4796
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Instead of using the verbosely named {{toSimpleString}} static factory method 
> (and its overloaded counterparts), {{SimpleString}} should provide {{of}} 
> implementations. This change would make the code more concise and readable. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4795) Enforce queue filter when sending to FQQN

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4795?focusedWorklogId=922035=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922035
 ]

ASF GitHub Bot logged work on ARTEMIS-4795:
---

Author: ASF GitHub Bot
Created on: 04/Jun/24 20:11
Start Date: 04/Jun/24 20:11
Worklog Time Spent: 10m 
  Work Description: jbertram opened a new pull request, #4958:
URL: https://github.com/apache/activemq-artemis/pull/4958

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 922035)
Remaining Estimate: 0h
Time Spent: 10m

> Enforce queue filter when sending to FQQN
> -
>
> Key: ARTEMIS-4795
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4795
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> When sending a message directly to an FQQN the queue's filter is not enforced 
> on the message which is sent.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4792) Add support for setting consumer priority on AMQP Receiver Source addresses

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4792?focusedWorklogId=922010=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922010
 ]

ASF GitHub Bot logged work on ARTEMIS-4792:
---

Author: ASF GitHub Bot
Created on: 04/Jun/24 16:38
Start Date: 04/Jun/24 16:38
Worklog Time Spent: 10m 
  Work Description: gemmellr merged PR #4956:
URL: https://github.com/apache/activemq-artemis/pull/4956




Issue Time Tracking
---

Worklog Id: (was: 922010)
Time Spent: 40m  (was: 0.5h)

> Add support for setting consumer priority on AMQP Receiver Source addresses
> ---
>
> Key: ARTEMIS-4792
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4792
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: AMQP
>Affects Versions: 2.34.0
>Reporter: Timothy A. Bish
>Assignee: Timothy A. Bish
>Priority: Minor
> Fix For: 2.35.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> When creating a receiver link from a client the only way currently to adjust 
> the consumer priority on the broker is to set a value in the receiver 
> properties to indicate the desired priority.  For some client AMQP client 
> libraries this is not simple or not possible in the provided API.  To solve 
> this we can add support for parsing URI type options from the source address 
> of the receiver attach and look for the option "consumer-priority" which is 
> also used by the Core client to configure consumer priority (Openwire clients 
> can do the same via an openwire client property "consumer.priority").
> This updates the client receiver attach to extract properties from the 
> address the source which have the form:
> {code:java}
> address?consumer-priority=1{code}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4792) Add support for setting consumer priority on AMQP Receiver Source addresses

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4792?focusedWorklogId=921984=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921984
 ]

ASF GitHub Bot logged work on ARTEMIS-4792:
---

Author: ASF GitHub Bot
Created on: 04/Jun/24 14:49
Start Date: 04/Jun/24 14:49
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on code in PR #4956:
URL: https://github.com/apache/activemq-artemis/pull/4956#discussion_r1626157503


##
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/DefaultSenderController.java:
##
@@ -440,7 +474,7 @@ public void close() throws Exception {
  }
   } else if (source != null && source.getDynamic() && 
(source.getExpiryPolicy() == TerminusExpiryPolicy.LINK_DETACH || 
source.getExpiryPolicy() == TerminusExpiryPolicy.SESSION_END)) {
  try {
-
sessionSPI.removeTemporaryQueue(SimpleString.toSimpleString(source.getAddress()));
+
sessionSPI.removeTemporaryQueue(SimpleString.toSimpleString(getSourceAddress(source)));

Review Comment:
   Can this one use the new variable too?





Issue Time Tracking
---

Worklog Id: (was: 921984)
Time Spent: 0.5h  (was: 20m)

> Add support for setting consumer priority on AMQP Receiver Source addresses
> ---
>
> Key: ARTEMIS-4792
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4792
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: AMQP
>Affects Versions: 2.34.0
>Reporter: Timothy A. Bish
>Assignee: Timothy A. Bish
>Priority: Minor
> Fix For: 2.35.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> When creating a receiver link from a client the only way currently to adjust 
> the consumer priority on the broker is to set a value in the receiver 
> properties to indicate the desired priority.  For some client AMQP client 
> libraries this is not simple or not possible in the provided API.  To solve 
> this we can add support for parsing URI type options from the source address 
> of the receiver attach and look for the option "consumer-priority" which is 
> also used by the Core client to configure consumer priority (Openwire clients 
> can do the same via an openwire client property "consumer.priority").
> This updates the client receiver attach to extract properties from the 
> address the source which have the form:
> {code:java}
> address?consumer-priority=1{code}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4760) Creating MQTT consumer should work if auto-create-queues is false

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4760?focusedWorklogId=921953=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921953
 ]

ASF GitHub Bot logged work on ARTEMIS-4760:
---

Author: ASF GitHub Bot
Created on: 04/Jun/24 11:24
Start Date: 04/Jun/24 11:24
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on code in PR #4955:
URL: https://github.com/apache/activemq-artemis/pull/4955#discussion_r1625737345


##
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTSubscriptionManager.java:
##
@@ -146,20 +147,20 @@ synchronized void stop() throws Exception {
   }
}
 
-   private Queue createQueueForSubscription(String rawTopicName, String 
parsedTopicName) throws Exception {
+   private Queue createQueueForSubscription(String rawTopicName, String 
parsedTopicName, boolean isFullyQualified) throws Exception {
   String coreAddress = 
MQTTUtil.getCoreAddressFromMqttTopic(parsedTopicName, 
session.getWildcardConfiguration());
   String coreQueue = MQTTUtil.getCoreQueueFromMqttTopic(rawTopicName, 
session.getState().getClientId(), session.getWildcardConfiguration());
 
-  // check to see if a subscription queue already exists.
+  // check to see if a subscription queue already exists
   Queue q = session.getServer().locateQueue(coreQueue);
 
-  // The queue does not exist so we need to create it.
+  // the subscription queue does not exist so we need to create it
   if (q == null) {
  SimpleString sAddress = SimpleString.toSimpleString(coreAddress);
 
- // Check we can auto create queues.
+ // only check if we can auto create queues if it's FQQN
  BindingQueryResult bindingQueryResult = 
session.getServerSession().executeBindingQuery(sAddress);
- if (!bindingQueryResult.isAutoCreateQueues()) {
+ if (!bindingQueryResult.isAutoCreateQueues() && isFullyQualified) {

Review Comment:
   To align to the comment, it should check the isFullyQualified variable 
first, rather than _always_ calling the isAutoCreateQueues() method regardless 
of its value as it currently is.





Issue Time Tracking
---

Worklog Id: (was: 921953)
Time Spent: 20m  (was: 10m)

> Creating MQTT consumer should work if auto-create-queues is false
> -
>
> Key: ARTEMIS-4760
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4760
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4792) Add support for setting consumer priority on AMQP Receiver Source addresses

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4792?focusedWorklogId=921932=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921932
 ]

ASF GitHub Bot logged work on ARTEMIS-4792:
---

Author: ASF GitHub Bot
Created on: 04/Jun/24 09:36
Start Date: 04/Jun/24 09:36
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on code in PR #4956:
URL: https://github.com/apache/activemq-artemis/pull/4956#discussion_r1625678167


##
artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/ParameterisedAddress.java:
##
@@ -106,4 +107,46 @@ public static boolean isParameterised(SimpleString 
address) {
   return URISupport.containsQuery(address);
}
 
+   public static SimpleString extractAddress(SimpleString address) {
+  return SimpleString.toSimpleString(extractAddress(address.toString()));
+   }
+
+   /**
+* Given an address string, extract only the query portion if the address is
+* parameterized, otherwise return an empty {@link Map}.
+*
+* @param address
+*   The address to operate on.
+*
+* @return a {@link Map} containing the parameters associated with the 
given address.
+*/
+   @SuppressWarnings("unchecked")
+   public static Map extractParameters(String address) {
+  final int index = address.indexOf('?');
+
+  if (index == -1) {
+ return Collections.EMPTY_MAP;
+  } else {
+ return parseQuery(address);
+  }
+   }
+
+   /**
+* Given an address string, extract only the address portion if the address 
is
+* parameterized, otherwise just return the provided address.
+*
+* @param address
+*   The address to operate on.
+*
+* @return the original address minus any appended parameters.
+*/
+   public static String extractAddress(String address) {
+  final int index = address.indexOf('?');
+
+  if (index == -1) {
+ return address;
+  } else {
+ return address.substring(0, index);
+  }
+   }

Review Comment:
   The methods cant handle a null but dont say that and the 'otherwise return 
provided' bit might imply otherwise. Should either say so or handle it.



##
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/DefaultSenderController.java:
##
@@ -409,16 +419,38 @@ public Consumer init(ProtonServerSenderContext 
senderContext) throws Exception {
   // have not honored what it asked for.
   source.setFilter(supportedFilters.isEmpty() ? null : supportedFilters);
 
-  boolean browseOnly = !multicast && source.getDistributionMode() != null 
&& source.getDistributionMode().equals(COPY);
+  final boolean browseOnly = !multicast && source.getDistributionMode() != 
null && source.getDistributionMode().equals(COPY);
+  final Number consumerPriority = 
getReceiverPriority(protonSender.getRemoteProperties(), 
extractConsumerPriority(addressParameters));
+
+  // Any new parameters used should be extracted from the values parsed 
from the address to avoid this log message.
+  if (!addressParameters.isEmpty()) {
+ final String unusedParametersMessage = ""
++ " Not all specified address options were applicable to the 
created server consumer."
++ " Check the options are spelled correctly."
++ " Unused parameters=[" + addressParameters + "].";
+
+ logger.debug(unusedParametersMessage);
+  }
+
+  return sessionSPI.createSender(senderContext, queue, multicast ? null : 
selector, browseOnly, consumerPriority);
+   }
+
+   private static Number extractConsumerPriority(Map 
addressParameters) {
+  if (addressParameters != null && !addressParameters.isEmpty() ) {
+ final String priorityString = 
addressParameters.remove(QueueConfiguration.CONSUMER_PRIORITY);
+ if (priorityString != null) {
+return Integer.valueOf(priorityString);
+ }
+  }
 
-  return (Consumer) sessionSPI.createSender(senderContext, queue, 
multicast ? null : selector, browseOnly);
+  return null;
}
 
@Override
public void close() throws Exception {
   Source source = (Source) protonSender.getSource();
-  if (source != null && source.getAddress() != null && multicast) {
- SimpleString queueName = 
SimpleString.toSimpleString(source.getAddress());
+  if (source != null && getSourceAddress(source) != null && multicast) {

Review Comment:
   Given that getSourceAddress(source) handles null Source values, would seem 
like this could be put in a variable here rather than potentially doing the 
extraction twice as it is.



##
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/DefaultSenderController.java:
##
@@ -207,6 +212,10 @@ public Consumer init(ProtonServerSenderContext 

[jira] [Work logged] (ARTEMIS-4787) Anycast queue does not auto-create if already multicast queue on same address

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4787?focusedWorklogId=921842=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921842
 ]

ASF GitHub Bot logged work on ARTEMIS-4787:
---

Author: ASF GitHub Bot
Created on: 03/Jun/24 20:19
Start Date: 03/Jun/24 20:19
Worklog Time Spent: 10m 
  Work Description: jbertram commented on PR #4957:
URL: 
https://github.com/apache/activemq-artemis/pull/4957#issuecomment-2146048881

   BTW, I already ran the full test-suite on this and there were no failures 
related to my changes.




Issue Time Tracking
---

Worklog Id: (was: 921842)
Time Spent: 20m  (was: 10m)

> Anycast queue does not auto-create if already multicast queue on same address
> -
>
> Key: ARTEMIS-4787
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4787
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Reporter: Josh Byster
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> As a preface, I am aware that creating both anycast and multicast queues on 
> the same address is an anti-pattern and not recommended. However, this is 
> causing difficulties migrating over legacy clients from using Classic to 
> Artemis.
> If one creates a JMS topic on an address, and then tries to create a JMS 
> queue, it fails to create. However, if the order is flipped (creating a 
> queue, then a topic), there is no exception.
> It seems like the issue is in this area of {{ServerSessionImpl}}:
> {code:java}
> Bindings bindings = 
> server.getPostOffice().lookupBindingsForAddress(unPrefixedAddress);
> if (bindings != null && bindings.hasLocalBinding() && !queueConfig.isFqqn()) {
>// The address has another queue with a different name, which is fine. 
> Just ignore it.
>result = AutoCreateResult.EXISTED;{code}
> Please see test below to reproduce, which throws the exception immediately as 
> seen in production.
> {code:java}
> package org.apache.activemq.artemis.tests.integration;
> import org.apache.activemq.artemis.api.core.client.ClientSession;
> import org.apache.activemq.artemis.api.core.client.ClientSessionFactory;
> import org.apache.activemq.artemis.api.core.client.ServerLocator;
> import org.apache.activemq.artemis.core.server.ActiveMQServer;
> import org.apache.activemq.artemis.core.settings.impl.AddressSettings;
> import org.apache.activemq.artemis.tests.util.ActiveMQTestBase;
> import org.junit.Before;
> import org.junit.Test;
> import javax.jms.Connection;
> import javax.jms.ConnectionFactory;
> import javax.jms.MessageConsumer;
> import javax.jms.Queue;
> import javax.jms.Session;
> import javax.jms.Topic;
> import java.util.HashMap;
> public class QueueTopicSameNameTest extends ActiveMQTestBase {
> protected ActiveMQServer server;
> @Override
> @Before
> public void setUp() throws Exception {
> super.setUp();
> server = createServer(true, createDefaultNettyConfig());
> server.start();
> }
> @Test
> public void testTopicThenQueueCreate() throws Exception {
> String myAddr = "TEST";
> ConnectionFactory cf = new 
> org.apache.activemq.ActiveMQConnectionFactory("failover:(tcp://localhost:61616)");
> Connection c = cf.createConnection();
> Session s = c.createSession();
> Topic t = s.createTopic(myAddr);
> MessageConsumer consumer = s.createConsumer(t);
> Queue q = s.createQueue(myAddr);
> MessageConsumer otherConsumer = s.createConsumer(q);
> c.close();
> }
> }{code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4787) Anycast queue does not auto-create if already multicast queue on same address

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4787?focusedWorklogId=921841=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921841
 ]

ASF GitHub Bot logged work on ARTEMIS-4787:
---

Author: ASF GitHub Bot
Created on: 03/Jun/24 20:18
Start Date: 03/Jun/24 20:18
Worklog Time Spent: 10m 
  Work Description: jbertram opened a new pull request, #4957:
URL: https://github.com/apache/activemq-artemis/pull/4957

   There's an edge-case in the auto-creation logic for anycast queues that 
checks to see if any queue already exists on the address and if so then nothing 
further is created. It's not clear to me what use-case this is for, and it 
precludes the use-case detailed on ARTEMIS-4787 where a migrating user has 
overlapping names for JMS queues and topics.
   
   This commit removes this edge-case and adds a test to verify auto-creation 
works properly with both OpenWire and Core. The test includes methods for AMQP, 
but they are disabled since the AMQP protocol handler doesn't handle this 
use-case at all. This PR is specifically for OpenWire.




Issue Time Tracking
---

Worklog Id: (was: 921841)
Remaining Estimate: 0h
Time Spent: 10m

> Anycast queue does not auto-create if already multicast queue on same address
> -
>
> Key: ARTEMIS-4787
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4787
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Reporter: Josh Byster
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> As a preface, I am aware that creating both anycast and multicast queues on 
> the same address is an anti-pattern and not recommended. However, this is 
> causing difficulties migrating over legacy clients from using Classic to 
> Artemis.
> If one creates a JMS topic on an address, and then tries to create a JMS 
> queue, it fails to create. However, if the order is flipped (creating a 
> queue, then a topic), there is no exception.
> It seems like the issue is in this area of {{ServerSessionImpl}}:
> {code:java}
> Bindings bindings = 
> server.getPostOffice().lookupBindingsForAddress(unPrefixedAddress);
> if (bindings != null && bindings.hasLocalBinding() && !queueConfig.isFqqn()) {
>// The address has another queue with a different name, which is fine. 
> Just ignore it.
>result = AutoCreateResult.EXISTED;{code}
> Please see test below to reproduce, which throws the exception immediately as 
> seen in production.
> {code:java}
> package org.apache.activemq.artemis.tests.integration;
> import org.apache.activemq.artemis.api.core.client.ClientSession;
> import org.apache.activemq.artemis.api.core.client.ClientSessionFactory;
> import org.apache.activemq.artemis.api.core.client.ServerLocator;
> import org.apache.activemq.artemis.core.server.ActiveMQServer;
> import org.apache.activemq.artemis.core.settings.impl.AddressSettings;
> import org.apache.activemq.artemis.tests.util.ActiveMQTestBase;
> import org.junit.Before;
> import org.junit.Test;
> import javax.jms.Connection;
> import javax.jms.ConnectionFactory;
> import javax.jms.MessageConsumer;
> import javax.jms.Queue;
> import javax.jms.Session;
> import javax.jms.Topic;
> import java.util.HashMap;
> public class QueueTopicSameNameTest extends ActiveMQTestBase {
> protected ActiveMQServer server;
> @Override
> @Before
> public void setUp() throws Exception {
> super.setUp();
> server = createServer(true, createDefaultNettyConfig());
> server.start();
> }
> @Test
> public void testTopicThenQueueCreate() throws Exception {
> String myAddr = "TEST";
> ConnectionFactory cf = new 
> org.apache.activemq.ActiveMQConnectionFactory("failover:(tcp://localhost:61616)");
> Connection c = cf.createConnection();
> Session s = c.createSession();
> Topic t = s.createTopic(myAddr);
> MessageConsumer consumer = s.createConsumer(t);
> Queue q = s.createQueue(myAddr);
> MessageConsumer otherConsumer = s.createConsumer(q);
> c.close();
> }
> }{code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4792) Add support for setting consumer priority on AMQP Receiver Source addresses

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4792?focusedWorklogId=921836=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921836
 ]

ASF GitHub Bot logged work on ARTEMIS-4792:
---

Author: ASF GitHub Bot
Created on: 03/Jun/24 19:32
Start Date: 03/Jun/24 19:32
Worklog Time Spent: 10m 
  Work Description: tabish121 opened a new pull request, #4956:
URL: https://github.com/apache/activemq-artemis/pull/4956

   …ress
   
   Allow the Source address to provide consumer priority on the address using 
the same option value as a core consumer '?consumer-priority=X'. The change 
parses any query string appended to an address and uses the address portion as 
the actual receiver address and currently only looks at consumer priority 
values in the extracted address query parameters and ignores any other options 
found. The existing consumer priority taken from link properties takes 
precedence over the value placed on the address query options if both are 
present.




Issue Time Tracking
---

Worklog Id: (was: 921836)
Remaining Estimate: 0h
Time Spent: 10m

> Add support for setting consumer priority on AMQP Receiver Source addresses
> ---
>
> Key: ARTEMIS-4792
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4792
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: AMQP
>Affects Versions: 2.34.0
>Reporter: Timothy A. Bish
>Assignee: Timothy A. Bish
>Priority: Minor
> Fix For: 2.35.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> When creating a receiver link from a client the only way currently to adjust 
> the consumer priority on the broker is to set a value in the receiver 
> properties to indicate the desired priority.  For some client AMQP client 
> libraries this is not simple or not possible in the provided API.  To solve 
> this we can add support for parsing URI type options from the source address 
> of the receiver attach and look for the option "consumer-priority" which is 
> also used by the Core client to configure consumer priority (Openwire clients 
> can do the same via an openwire client property "consumer.priority").
> This updates the client receiver attach to extract properties from the 
> address the source which have the form:
> {code:java}
> address?consumer-priority=1{code}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4760) Creating MQTT consumer should work if auto-create-queues is false

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4760?focusedWorklogId=921815=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921815
 ]

ASF GitHub Bot logged work on ARTEMIS-4760:
---

Author: ASF GitHub Bot
Created on: 03/Jun/24 17:19
Start Date: 03/Jun/24 17:19
Worklog Time Spent: 10m 
  Work Description: jbertram opened a new pull request, #4955:
URL: https://github.com/apache/activemq-artemis/pull/4955

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 921815)
Remaining Estimate: 0h
Time Spent: 10m

> Creating MQTT consumer should work if auto-create-queues is false
> -
>
> Key: ARTEMIS-4760
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4760
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4791) Update to JUnit 5.10.2

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4791?focusedWorklogId=921813=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921813
 ]

ASF GitHub Bot logged work on ARTEMIS-4791:
---

Author: ASF GitHub Bot
Created on: 03/Jun/24 16:49
Start Date: 03/Jun/24 16:49
Worklog Time Spent: 10m 
  Work Description: gemmellr merged PR #4954:
URL: https://github.com/apache/activemq-artemis/pull/4954




Issue Time Tracking
---

Worklog Id: (was: 921813)
Time Spent: 20m  (was: 10m)

> Update to JUnit 5.10.2
> --
>
> Key: ARTEMIS-4791
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4791
> Project: ActiveMQ Artemis
>  Issue Type: Dependency upgrade
>  Components: Tests
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
>Priority: Minor
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Update to JUnit 5.10.2



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4791) Update to JUnit 5.10.2

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4791?focusedWorklogId=921809=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921809
 ]

ASF GitHub Bot logged work on ARTEMIS-4791:
---

Author: ASF GitHub Bot
Created on: 03/Jun/24 16:03
Start Date: 03/Jun/24 16:03
Worklog Time Spent: 10m 
  Work Description: gemmellr opened a new pull request, #4954:
URL: https://github.com/apache/activemq-artemis/pull/4954

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 921809)
Remaining Estimate: 0h
Time Spent: 10m

> Update to JUnit 5.10.2
> --
>
> Key: ARTEMIS-4791
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4791
> Project: ActiveMQ Artemis
>  Issue Type: Dependency upgrade
>  Components: Tests
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Update to JUnit 5.10.2



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4790) Use JUnit 5 for the test suite

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4790?focusedWorklogId=921797=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921797
 ]

ASF GitHub Bot logged work on ARTEMIS-4790:
---

Author: ASF GitHub Bot
Created on: 03/Jun/24 15:06
Start Date: 03/Jun/24 15:06
Worklog Time Spent: 10m 
  Work Description: jbertram merged PR #4953:
URL: https://github.com/apache/activemq-artemis/pull/4953




Issue Time Tracking
---

Worklog Id: (was: 921797)
Time Spent: 0.5h  (was: 20m)

> Use JUnit 5 for the test suite
> --
>
> Key: ARTEMIS-4790
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4790
> Project: ActiveMQ Artemis
>  Issue Type: Task
>  Components: Tests
>Affects Versions: 2.33.0
>Reporter: Robbie Gemmell
>Priority: Major
> Fix For: 2.35.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Switch to using JUnit 5 for the test suite, primarily using the new JUnit 
> Jupiter API and associated junit-jupiter-engine engine, but with select use 
> of junit-vintage-engine for some specific tests/models, e.g those that 
> require specific third party JUnit 4 Runners, or rely on dependencies that 
> fix them at JUnit 4 / 3.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4790) Use JUnit 5 for the test suite

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4790?focusedWorklogId=921796=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921796
 ]

ASF GitHub Bot logged work on ARTEMIS-4790:
---

Author: ASF GitHub Bot
Created on: 03/Jun/24 15:06
Start Date: 03/Jun/24 15:06
Worklog Time Spent: 10m 
  Work Description: jbertram commented on PR #4953:
URL: 
https://github.com/apache/activemq-artemis/pull/4953#issuecomment-2145441213

   After a skim I'm proceeding with a commit-then-review approach to avoid 
having to rebase this more than you've already had to.




Issue Time Tracking
---

Worklog Id: (was: 921796)
Time Spent: 20m  (was: 10m)

> Use JUnit 5 for the test suite
> --
>
> Key: ARTEMIS-4790
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4790
> Project: ActiveMQ Artemis
>  Issue Type: Task
>  Components: Tests
>Affects Versions: 2.33.0
>Reporter: Robbie Gemmell
>Priority: Major
> Fix For: 2.35.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Switch to using JUnit 5 for the test suite, primarily using the new JUnit 
> Jupiter API and associated junit-jupiter-engine engine, but with select use 
> of junit-vintage-engine for some specific tests/models, e.g those that 
> require specific third party JUnit 4 Runners, or rely on dependencies that 
> fix them at JUnit 4 / 3.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4790) Use JUnit 5 for the test suite

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4790?focusedWorklogId=921782=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921782
 ]

ASF GitHub Bot logged work on ARTEMIS-4790:
---

Author: ASF GitHub Bot
Created on: 03/Jun/24 14:28
Start Date: 03/Jun/24 14:28
Worklog Time Spent: 10m 
  Work Description: gemmellr opened a new pull request, #4953:
URL: https://github.com/apache/activemq-artemis/pull/4953

   
   
   Use JUnit 5 for the test suite; primarily the Jupiter API and 
junit-jupiter-engine, but junit-vintage-engine for a few select modules or test 
classes that rely on runners or deps that still need the earlier APIs.
   
   Given the changes are test-only and the significant amount of time I have 
already spent rebasing them to this point, I'd like to merge this quickly and 
then address tweaking as followups.
   




Issue Time Tracking
---

Worklog Id: (was: 921782)
Remaining Estimate: 0h
Time Spent: 10m

> Use JUnit 5 for the test suite
> --
>
> Key: ARTEMIS-4790
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4790
> Project: ActiveMQ Artemis
>  Issue Type: Task
>  Components: Tests
>Affects Versions: 2.33.0
>Reporter: Robbie Gemmell
>Priority: Major
> Fix For: 2.35.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Switch to using JUnit 5 for the test suite, primarily using the new JUnit 
> Jupiter API and associated junit-jupiter-engine engine, but with select use 
> of junit-vintage-engine for some specific tests/models, e.g those that 
> require specific third party JUnit 4 Runners, or rely on dependencies that 
> fix them at JUnit 4 / 3.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4780) Artemis web console does not ever set 'artemisJmxDomain' in localStorage

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4780?focusedWorklogId=921726=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921726
 ]

ASF GitHub Bot logged work on ARTEMIS-4780:
---

Author: ASF GitHub Bot
Created on: 03/Jun/24 10:31
Start Date: 03/Jun/24 10:31
Worklog Time Spent: 10m 
  Work Description: andytaylor opened a new pull request, #18:
URL: https://github.com/apache/activemq-artemis-console/pull/18

   This is because users can change this, the code now searched for *:broker=*




Issue Time Tracking
---

Worklog Id: (was: 921726)
Remaining Estimate: 0h
Time Spent: 10m

> Artemis web console does not ever set 'artemisJmxDomain' in localStorage
> 
>
> Key: ARTEMIS-4780
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4780
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.32.0
>Reporter: Josh Byster
>Assignee: Andy Taylor
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> We relocate our artemis packages as part of our shading process. 
> I did set up:
> 
> {code:java}
> aActiveMQServer.getConfiguration().setJMXDomain("com.abc.shaded.org.apache.activemq.artemis");
> {code}
> However the web console does not show up. I noticed in the code it's because 
> we try to read in localStorage['artemisJmxDomain'] but never actually set it 
> as far as I can tell. Thus we always default to org.apache.activemq.artemis.
> Everything works properly when setting localStorage['artemisJmxDomain'] = 
> "com.abc.shaded.org.apache.activemq.artemis"



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (AMQ-9448) RedeliveryPolicy causing lock in dispatcher

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/AMQ-9448?focusedWorklogId=921617=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921617
 ]

ASF GitHub Bot logged work on AMQ-9448:
---

Author: ASF GitHub Bot
Created on: 01/Jun/24 06:55
Start Date: 01/Jun/24 06:55
Worklog Time Spent: 10m 
  Work Description: thezbyg commented on PR #1177:
URL: https://github.com/apache/activemq/pull/1177#issuecomment-2143330637

   Yes. This is the stack trace of "JobScheduler:JMS" thread blocked by itself 
due to acquiring read lock on store while iterating scheduled jobs in 
mainLoop() method and then attempting to acquire write lock to write a new 
scheduled job information:
   `
   "JobScheduler:JMS" #28 daemon prio=5 os_prio=0 cpu=11.62ms elapsed=117.73s 
tid=0x7f43d1344b50 nid=0x185b waiting on condition  [0x7f4356cfe000]
  java.lang.Thread.State: WAITING (parking)
at jdk.internal.misc.Unsafe.park(java.base@17.0.8/Native Method)
- parking to wait for  <0x8bd25150> (a 
java.util.concurrent.locks.ReentrantReadWriteLock$NonfairSync)
at 
java.util.concurrent.locks.LockSupport.park(java.base@17.0.8/LockSupport.java:211)
at 
java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire(java.base@17.0.8/AbstractQueuedSynchronizer.java:715)
at 
java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire(java.base@17.0.8/AbstractQueuedSynchronizer.java:938)
at 
java.util.concurrent.locks.ReentrantReadWriteLock$WriteLock.lock(java.base@17.0.8/ReentrantReadWriteLock.java:959)
at 
org.apache.activemq.store.kahadb.scheduler.JobSchedulerStoreImpl$8.visit(JobSchedulerStoreImpl.java:684)
at 
org.apache.activemq.store.kahadb.data.KahaAddScheduledJobCommand.visit(KahaAddScheduledJobCommand.java:283)
at 
org.apache.activemq.store.kahadb.scheduler.JobSchedulerStoreImpl.process(JobSchedulerStoreImpl.java:679)
at 
org.apache.activemq.store.kahadb.AbstractKahaDBStore.store(AbstractKahaDBStore.java:495)
at 
org.apache.activemq.store.kahadb.AbstractKahaDBStore.store(AbstractKahaDBStore.java:403)
at 
org.apache.activemq.store.kahadb.scheduler.JobSchedulerImpl.doSchedule(JobSchedulerImpl.java:252)
at 
org.apache.activemq.store.kahadb.scheduler.JobSchedulerImpl.schedule(JobSchedulerImpl.java:100)
at 
org.apache.activemq.store.kahadb.scheduler.JobSchedulerImpl.mainLoop(JobSchedulerImpl.java:782)
at 
org.apache.activemq.store.kahadb.scheduler.JobSchedulerImpl.run(JobSchedulerImpl.java:699)
at java.lang.Thread.run(java.base@17.0.8/Thread.java:833)
   `
   
   Full dump:
   [dump.txt](https://github.com/user-attachments/files/15520722/dump.txt)
   




Issue Time Tracking
---

Worklog Id: (was: 921617)
Time Spent: 50m  (was: 40m)

> RedeliveryPolicy causing lock in dispatcher
> ---
>
> Key: AMQ-9448
> URL: https://issues.apache.org/jira/browse/AMQ-9448
> Project: ActiveMQ Classic
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 5.18.3
> Environment: ubuntu-22.04
> corretto-17
>Reporter: Oliver Holzmann
>Priority: Critical
> Attachments: doNotFireJobsWhileStoreLockIsHeld.patch, jstack1.out
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> We are using ActiveMQ with redeliveryPolicy enabled:
> {code:java}
> 
>  redeliveryDelay="1000" />
> {code}
> When a message exceeds maximumRedeliveries the queue is "frozen". This means 
> the consumers can't read any messages and qrowing the queue in web console 
> causes error 504. 
> A thread dump shows a blocked JobScheduler:JMS thread:
> {code:java}
> priority : 5
> thread Id : x7fb985664960
> native Id : xae
> state : BLOCKED
> StackTrace:
> "JobScheduler:JMS" #75 daemon prio=5 os_prio=0 cpu=478.63ms elapsed=757.29s 
> tid=0x7fb985664960 nid=0xae waiting for monitor entry [0x7fb80def1000]
> java.lang.Thread.State: BLOCKED (on object monitor)
> at 
> org.apache.activemq.broker.region.PrefetchSubscription.dispatchPending(PrefetchSubscription.java:647)
> waiting to lock <0x00077ebc62a0> (a java.lang.Object) locked 
> <0x00077ebc6290> (a java.lang.Object)
> at 
> org.apache.activemq.broker.region.PrefetchSubscription.add(PrefetchSubscription.java:159)
> at org.apache.activemq.broker.region.Queue.doActualDispatch(Queue.java:2208)
> at org.apache.activemq.broker.region.Queue.doDispatch(Queue.java:2156)
> at org.apache.activemq.broker.region.Queue.pageInMessages(Queue.java:2307)
> at org.apache.activemq.broker.region.Queue.iterate(Queue.java:1728) locked 
> <0x00077ebc5178> (a java.lang.Object)
> at org.apache.activemq.broker.region.Queue.wakeup(Queue.java:1977)
> at org.apache.activemq.broker.region.Queue.messageSent(Queue.java:1971)
> at 
> 

[jira] [Work logged] (ARTEMIS-4789) Page.destroy race with cleanup

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4789?focusedWorklogId=921580=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921580
 ]

ASF GitHub Bot logged work on ARTEMIS-4789:
---

Author: ASF GitHub Bot
Created on: 31/May/24 20:05
Start Date: 31/May/24 20:05
Worklog Time Spent: 10m 
  Work Description: clebertsuconic merged PR #4950:
URL: https://github.com/apache/activemq-artemis/pull/4950




Issue Time Tracking
---

Worklog Id: (was: 921580)
Time Spent: 0.5h  (was: 20m)

> Page.destroy race with cleanup
> --
>
> Key: ARTEMIS-4789
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4789
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.33.0
>Reporter: Clebert Suconic
>Assignee: Clebert Suconic
>Priority: Major
> Fix For: 2.34.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> There's a rare race between Queue.destroy and cleanup.
> if the cleanup is called while depaging is still happening you might endup 
> with a Critical IO exception as the storage folder is removed.
> This is the reason why testPagingStoreDestroyed(derby) was eventually failing.
> testPagingStoreDestroyed serves as the verification for this issue, as this 
> is intended as the test fix.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (AMQ-9448) RedeliveryPolicy causing lock in dispatcher

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/AMQ-9448?focusedWorklogId=921576=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921576
 ]

ASF GitHub Bot logged work on AMQ-9448:
---

Author: ASF GitHub Bot
Created on: 31/May/24 19:37
Start Date: 31/May/24 19:37
Worklog Time Spent: 10m 
  Work Description: mattrpav commented on PR #1177:
URL: https://github.com/apache/activemq/pull/1177#issuecomment-2142874447

   Do you have a thread dump of the deadlock occurring?




Issue Time Tracking
---

Worklog Id: (was: 921576)
Time Spent: 40m  (was: 0.5h)

> RedeliveryPolicy causing lock in dispatcher
> ---
>
> Key: AMQ-9448
> URL: https://issues.apache.org/jira/browse/AMQ-9448
> Project: ActiveMQ Classic
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 5.18.3
> Environment: ubuntu-22.04
> corretto-17
>Reporter: Oliver Holzmann
>Priority: Critical
> Attachments: doNotFireJobsWhileStoreLockIsHeld.patch, jstack1.out
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> We are using ActiveMQ with redeliveryPolicy enabled:
> {code:java}
> 
>  redeliveryDelay="1000" />
> {code}
> When a message exceeds maximumRedeliveries the queue is "frozen". This means 
> the consumers can't read any messages and qrowing the queue in web console 
> causes error 504. 
> A thread dump shows a blocked JobScheduler:JMS thread:
> {code:java}
> priority : 5
> thread Id : x7fb985664960
> native Id : xae
> state : BLOCKED
> StackTrace:
> "JobScheduler:JMS" #75 daemon prio=5 os_prio=0 cpu=478.63ms elapsed=757.29s 
> tid=0x7fb985664960 nid=0xae waiting for monitor entry [0x7fb80def1000]
> java.lang.Thread.State: BLOCKED (on object monitor)
> at 
> org.apache.activemq.broker.region.PrefetchSubscription.dispatchPending(PrefetchSubscription.java:647)
> waiting to lock <0x00077ebc62a0> (a java.lang.Object) locked 
> <0x00077ebc6290> (a java.lang.Object)
> at 
> org.apache.activemq.broker.region.PrefetchSubscription.add(PrefetchSubscription.java:159)
> at org.apache.activemq.broker.region.Queue.doActualDispatch(Queue.java:2208)
> at org.apache.activemq.broker.region.Queue.doDispatch(Queue.java:2156)
> at org.apache.activemq.broker.region.Queue.pageInMessages(Queue.java:2307)
> at org.apache.activemq.broker.region.Queue.iterate(Queue.java:1728) locked 
> <0x00077ebc5178> (a java.lang.Object)
> at org.apache.activemq.broker.region.Queue.wakeup(Queue.java:1977)
> at org.apache.activemq.broker.region.Queue.messageSent(Queue.java:1971)
> at 
> org.apache.activemq.broker.region.Queue.doPendingCursorAdditions(Queue.java:832)
> at org.apache.activemq.broker.region.Queue.tryOrderedCursorAdd(Queue.java:927)
> at org.apache.activemq.broker.region.Queue.doMessageSend(Queue.java:906)
> at org.apache.activemq.broker.region.Queue.send(Queue.java:756)
> at 
> org.apache.activemq.broker.region.DestinationFilter.send(DestinationFilter.java:138)
> at 
> org.apache.activemq.broker.region.AbstractRegion.send(AbstractRegion.java:511)
> at org.apache.activemq.broker.region.RegionBroker.send(RegionBroker.java:477)
> at 
> org.apache.activemq.broker.jmx.ManagedRegionBroker.send(ManagedRegionBroker.java:343)
> at org.apache.activemq.broker.BrokerFilter.send(BrokerFilter.java:154)
> at 
> org.apache.activemq.broker.scheduler.SchedulerBroker.scheduledJob(SchedulerBroker.java:429)
> at 
> org.apache.activemq.store.kahadb.scheduler.JobSchedulerImpl.fireJob(JobSchedulerImpl.java:823)
> at 
> org.apache.activemq.store.kahadb.scheduler.JobSchedulerImpl.mainLoop(JobSchedulerImpl.java:753)
> at 
> org.apache.activemq.store.kahadb.scheduler.JobSchedulerImpl.run(JobSchedulerImpl.java:699)
> at java.lang.Thread.run(java.base@17.0.10/Thread.java:840)
> Locked ownable synchronizers: <0x00077ebc3ed0> (a 
> java.util.concurrent.locks.ReentrantReadWriteLock$NonfairSync)
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (AMQ-9484) Support exporting kahadb messages from a queue with an offset

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/AMQ-9484?focusedWorklogId=921575=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921575
 ]

ASF GitHub Bot logged work on AMQ-9484:
---

Author: ASF GitHub Bot
Created on: 31/May/24 19:26
Start Date: 31/May/24 19:26
Worklog Time Spent: 10m 
  Work Description: mattrpav commented on PR #1207:
URL: https://github.com/apache/activemq/pull/1207#issuecomment-2142861478

   Closing in favor of https://github.com/apache/activemq/pull/1208




Issue Time Tracking
---

Worklog Id: (was: 921575)
Time Spent: 1h 10m  (was: 1h)

> Support exporting kahadb messages from a queue with an offset
> -
>
> Key: AMQ-9484
> URL: https://issues.apache.org/jira/browse/AMQ-9484
> Project: ActiveMQ Classic
>  Issue Type: New Feature
>Reporter: Matt Pavlovich
>Assignee: Matt Pavlovich
>Priority: Minor
> Fix For: 6.2.0, 5.18.5
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Support exporting and pulling messages from a MessageStore with an offset, to 
> prevent loading _every_ message into memory (and subsequent required gc). 
> For example, if a user wants to export the last message from a queue with 
> 1,000 messages, they can scan over the index skipping most messages vs 
> loading all messages into memory to get to the last message.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (AMQ-9484) Support exporting kahadb messages from a queue with an offset

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/AMQ-9484?focusedWorklogId=921573=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921573
 ]

ASF GitHub Bot logged work on AMQ-9484:
---

Author: ASF GitHub Bot
Created on: 31/May/24 19:26
Start Date: 31/May/24 19:26
Worklog Time Spent: 10m 
  Work Description: mattrpav commented on PR #1207:
URL: https://github.com/apache/activemq/pull/1207#issuecomment-2142861143

   Closing in favor of https://github.com/apache/activemq/pull/1208




Issue Time Tracking
---

Worklog Id: (was: 921573)
Time Spent: 50m  (was: 40m)

> Support exporting kahadb messages from a queue with an offset
> -
>
> Key: AMQ-9484
> URL: https://issues.apache.org/jira/browse/AMQ-9484
> Project: ActiveMQ Classic
>  Issue Type: New Feature
>Reporter: Matt Pavlovich
>Assignee: Matt Pavlovich
>Priority: Minor
> Fix For: 6.2.0, 5.18.5
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Support exporting and pulling messages from a MessageStore with an offset, to 
> prevent loading _every_ message into memory (and subsequent required gc). 
> For example, if a user wants to export the last message from a queue with 
> 1,000 messages, they can scan over the index skipping most messages vs 
> loading all messages into memory to get to the last message.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (AMQ-9484) Support exporting kahadb messages from a queue with an offset

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/AMQ-9484?focusedWorklogId=921574=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921574
 ]

ASF GitHub Bot logged work on AMQ-9484:
---

Author: ASF GitHub Bot
Created on: 31/May/24 19:26
Start Date: 31/May/24 19:26
Worklog Time Spent: 10m 
  Work Description: mattrpav closed pull request #1207: WIP: [AMQ-9484] 
Support exporting kahadb messages from a queue with an offset - Option B
URL: https://github.com/apache/activemq/pull/1207




Issue Time Tracking
---

Worklog Id: (was: 921574)
Time Spent: 1h  (was: 50m)

> Support exporting kahadb messages from a queue with an offset
> -
>
> Key: AMQ-9484
> URL: https://issues.apache.org/jira/browse/AMQ-9484
> Project: ActiveMQ Classic
>  Issue Type: New Feature
>Reporter: Matt Pavlovich
>Assignee: Matt Pavlovich
>Priority: Minor
> Fix For: 6.2.0, 5.18.5
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Support exporting and pulling messages from a MessageStore with an offset, to 
> prevent loading _every_ message into memory (and subsequent required gc). 
> For example, if a user wants to export the last message from a queue with 
> 1,000 messages, they can scan over the index skipping most messages vs 
> loading all messages into memory to get to the last message.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4789) Page.destroy race with cleanup

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4789?focusedWorklogId=921553=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921553
 ]

ASF GitHub Bot logged work on ARTEMIS-4789:
---

Author: ASF GitHub Bot
Created on: 31/May/24 14:45
Start Date: 31/May/24 14:45
Worklog Time Spent: 10m 
  Work Description: clebertsuconic commented on PR #4950:
URL: 
https://github.com/apache/activemq-artemis/pull/4950#issuecomment-2142425235

   I will squash this change after some tests.
   
   I'm using a valid commit message in case someone hit merge before I finish 
the test, but I intend to squash it.




Issue Time Tracking
---

Worklog Id: (was: 921553)
Time Spent: 20m  (was: 10m)

> Page.destroy race with cleanup
> --
>
> Key: ARTEMIS-4789
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4789
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.33.0
>Reporter: Clebert Suconic
>Assignee: Clebert Suconic
>Priority: Major
> Fix For: 2.34.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> There's a rare race between Queue.destroy and cleanup.
> if the cleanup is called while depaging is still happening you might endup 
> with a Critical IO exception as the storage folder is removed.
> This is the reason why testPagingStoreDestroyed(derby) was eventually failing.
> testPagingStoreDestroyed serves as the verification for this issue, as this 
> is intended as the test fix.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4545) Allow node ID to be configured

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4545?focusedWorklogId=921548=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921548
 ]

ASF GitHub Bot logged work on ARTEMIS-4545:
---

Author: ASF GitHub Bot
Created on: 31/May/24 14:09
Start Date: 31/May/24 14:09
Worklog Time Spent: 10m 
  Work Description: AntonRoskvist opened a new pull request, #4951:
URL: https://github.com/apache/activemq-artemis/pull/4951

   This turned out to be quite a bit more involved than what I originally 
anticipated, please let me know if anything is missing or is otherwise looking 
strange 




Issue Time Tracking
---

Worklog Id: (was: 921548)
Remaining Estimate: 0h
Time Spent: 10m

> Allow node ID to be configured
> --
>
> Key: ARTEMIS-4545
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4545
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> In certain situations it would be beneficial to configure the node ID rather 
> than having it automatically generated. 
> For example, when using replication + failback if the primary server fails 
> the backup will take over. Then when the primary is restarted it will 
> initiate failback. However, if the primary broker's journal is damaged or 
> lost during the initial failure then it won't be able to initiate failback 
> because it won't have the same node ID as the backup. This kind of situation 
> is not uncommon in cloud environments where there is no persistent, attached 
> storage.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4789) Page.destroy race with cleanup

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4789?focusedWorklogId=921465=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921465
 ]

ASF GitHub Bot logged work on ARTEMIS-4789:
---

Author: ASF GitHub Bot
Created on: 31/May/24 02:07
Start Date: 31/May/24 02:07
Worklog Time Spent: 10m 
  Work Description: clebertsuconic opened a new pull request, #4950:
URL: https://github.com/apache/activemq-artemis/pull/4950

   this is fixing PagingTest::testPagingStoreDestroyed(db=derby) (or any other 
DB).
   
   This could eventually also fail on journal.
   
   The cleanup could act on a destroyed folder, and issue an IOException 
stopping the server with this race.
   
   You would need the server active cleaning messages while the queue is being 
removed.




Issue Time Tracking
---

Worklog Id: (was: 921465)
Remaining Estimate: 0h
Time Spent: 10m

> Page.destroy race with cleanup
> --
>
> Key: ARTEMIS-4789
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4789
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.33.0
>Reporter: Clebert Suconic
>Assignee: Clebert Suconic
>Priority: Major
> Fix For: 2.34.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> There's a rare race between Queue.destroy and cleanup.
> if the cleanup is called while depaging is still happening you might endup 
> with a Critical IO exception as the storage folder is removed.
> This is the reason why testPagingStoreDestroyed(derby) was eventually failing.
> testPagingStoreDestroyed serves as the verification for this issue, as this 
> is intended as the test fix.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4788) AMQP Federation Broker connection can deadlock broker shutdown

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4788?focusedWorklogId=921461=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921461
 ]

ASF GitHub Bot logged work on ARTEMIS-4788:
---

Author: ASF GitHub Bot
Created on: 30/May/24 23:44
Start Date: 30/May/24 23:44
Worklog Time Spent: 10m 
  Work Description: clebertsuconic commented on PR #4949:
URL: 
https://github.com/apache/activemq-artemis/pull/4949#issuecomment-2141010191

   LGTM




Issue Time Tracking
---

Worklog Id: (was: 921461)
Time Spent: 20m  (was: 10m)

> AMQP Federation Broker connection can deadlock broker shutdown
> --
>
> Key: ARTEMIS-4788
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4788
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 2.33.0, 2.34.0
>Reporter: Timothy A. Bish
>Assignee: Timothy A. Bish
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> In a rare race between broker shutdown and create of federation consumer the 
> broker connection federation manager can deadlock and hang the shutdown of 
> the broker. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4788) AMQP Federation Broker connection can deadlock broker shutdown

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4788?focusedWorklogId=921462=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921462
 ]

ASF GitHub Bot logged work on ARTEMIS-4788:
---

Author: ASF GitHub Bot
Created on: 30/May/24 23:44
Start Date: 30/May/24 23:44
Worklog Time Spent: 10m 
  Work Description: clebertsuconic merged PR #4949:
URL: https://github.com/apache/activemq-artemis/pull/4949




Issue Time Tracking
---

Worklog Id: (was: 921462)
Time Spent: 0.5h  (was: 20m)

> AMQP Federation Broker connection can deadlock broker shutdown
> --
>
> Key: ARTEMIS-4788
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4788
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 2.33.0, 2.34.0
>Reporter: Timothy A. Bish
>Assignee: Timothy A. Bish
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> In a rare race between broker shutdown and create of federation consumer the 
> broker connection federation manager can deadlock and hang the shutdown of 
> the broker. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4788) AMQP Federation Broker connection can deadlock broker shutdown

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4788?focusedWorklogId=921451=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921451
 ]

ASF GitHub Bot logged work on ARTEMIS-4788:
---

Author: ASF GitHub Bot
Created on: 30/May/24 22:15
Start Date: 30/May/24 22:15
Worklog Time Spent: 10m 
  Work Description: tabish121 opened a new pull request, #4949:
URL: https://github.com/apache/activemq-artemis/pull/4949

   Race on consumer create and broker shutdown could lead to a deadlocak trying 
to access configuration from the policy manager while the federation instance 
is trying to shutdown the policy manager.




Issue Time Tracking
---

Worklog Id: (was: 921451)
Remaining Estimate: 0h
Time Spent: 10m

> AMQP Federation Broker connection can deadlock broker shutdown
> --
>
> Key: ARTEMIS-4788
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4788
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 2.33.0, 2.34.0
>Reporter: Timothy A. Bish
>Assignee: Timothy A. Bish
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> In a rare race between broker shutdown and create of federation consumer the 
> broker connection federation manager can deadlock and hang the shutdown of 
> the broker. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4165) Page transactions not getting deleted on queue deletion

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4165?focusedWorklogId=921389=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921389
 ]

ASF GitHub Bot logged work on ARTEMIS-4165:
---

Author: ASF GitHub Bot
Created on: 30/May/24 13:31
Start Date: 30/May/24 13:31
Worklog Time Spent: 10m 
  Work Description: clebertsuconic merged PR #4948:
URL: https://github.com/apache/activemq-artemis/pull/4948




Issue Time Tracking
---

Worklog Id: (was: 921389)
Time Spent: 50m  (was: 40m)

> Page transactions not getting deleted on queue deletion
> ---
>
> Key: ARTEMIS-4165
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4165
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.28.0
>Reporter: Iliya Grushevskiy
>Priority: Major
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> If the queue contains paged messages then during queue deletion those message 
> records won't be updated. That will lead to journal grows as those records 
> will never get removed from journal.
> {code:java}
> operation@AddRecordTX;txID=107743391288,recordID=107743391443;userRecordType=35;isUpdate=false;compactCount=18;PageTransactionInfoImpl(transactionID=107743391288,id=107743391443,numberOfMessages=1)
> operation@Commit;txID=107743391288,numberOfRecords=1
> operation@AddRecordTX;txID=107743391258,recordID=107743391446;userRecordType=35;isUpdate=false;compactCount=18;PageTransactionInfoImpl(transactionID=107743391258,id=107743391446,numberOfMessages=1){code}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (AMQ-9510) Upgrade to jmock 2.13.1

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/AMQ-9510?focusedWorklogId=921372=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921372
 ]

ASF GitHub Bot logged work on AMQ-9510:
---

Author: ASF GitHub Bot
Created on: 30/May/24 09:25
Start Date: 30/May/24 09:25
Worklog Time Spent: 10m 
  Work Description: jbonofre opened a new pull request, #1235:
URL: https://github.com/apache/activemq/pull/1235

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 921372)
Remaining Estimate: 0h
Time Spent: 10m

> Upgrade to jmock 2.13.1
> ---
>
> Key: AMQ-9510
> URL: https://issues.apache.org/jira/browse/AMQ-9510
> Project: ActiveMQ Classic
>  Issue Type: Dependency upgrade
>  Components: Test Cases
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (AMQ-9509) Upgrade to jetty 11.0.21

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/AMQ-9509?focusedWorklogId=921369=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921369
 ]

ASF GitHub Bot logged work on AMQ-9509:
---

Author: ASF GitHub Bot
Created on: 30/May/24 09:21
Start Date: 30/May/24 09:21
Worklog Time Spent: 10m 
  Work Description: jbonofre opened a new pull request, #1234:
URL: https://github.com/apache/activemq/pull/1234

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 921369)
Remaining Estimate: 0h
Time Spent: 10m

> Upgrade to jetty 11.0.21
> 
>
> Key: AMQ-9509
> URL: https://issues.apache.org/jira/browse/AMQ-9509
> Project: ActiveMQ Classic
>  Issue Type: Dependency upgrade
>  Components: Broker, Transport, Web Console
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (AMQ-9508) Upgrade to commons-logging 1.3.2

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/AMQ-9508?focusedWorklogId=921368=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921368
 ]

ASF GitHub Bot logged work on AMQ-9508:
---

Author: ASF GitHub Bot
Created on: 30/May/24 09:19
Start Date: 30/May/24 09:19
Worklog Time Spent: 10m 
  Work Description: jbonofre opened a new pull request, #1233:
URL: https://github.com/apache/activemq/pull/1233

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 921368)
Remaining Estimate: 0h
Time Spent: 10m

> Upgrade to commons-logging 1.3.2
> 
>
> Key: AMQ-9508
> URL: https://issues.apache.org/jira/browse/AMQ-9508
> Project: ActiveMQ Classic
>  Issue Type: Dependency upgrade
>  Components: Broker
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (AMQ-9507) Upgrade to commons-daemon 1.4.0

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/AMQ-9507?focusedWorklogId=921367=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921367
 ]

ASF GitHub Bot logged work on AMQ-9507:
---

Author: ASF GitHub Bot
Created on: 30/May/24 09:18
Start Date: 30/May/24 09:18
Worklog Time Spent: 10m 
  Work Description: jbonofre opened a new pull request, #1232:
URL: https://github.com/apache/activemq/pull/1232

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 921367)
Remaining Estimate: 0h
Time Spent: 10m

> Upgrade to commons-daemon 1.4.0
> ---
>
> Key: AMQ-9507
> URL: https://issues.apache.org/jira/browse/AMQ-9507
> Project: ActiveMQ Classic
>  Issue Type: Dependency upgrade
>  Components: Broker
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (AMQ-9506) Upgrade to jackson 2.17.1

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/AMQ-9506?focusedWorklogId=921366=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921366
 ]

ASF GitHub Bot logged work on AMQ-9506:
---

Author: ASF GitHub Bot
Created on: 30/May/24 09:14
Start Date: 30/May/24 09:14
Worklog Time Spent: 10m 
  Work Description: jbonofre opened a new pull request, #1231:
URL: https://github.com/apache/activemq/pull/1231

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 921366)
Remaining Estimate: 0h
Time Spent: 10m

> Upgrade to jackson 2.17.1
> -
>
> Key: AMQ-9506
> URL: https://issues.apache.org/jira/browse/AMQ-9506
> Project: ActiveMQ Classic
>  Issue Type: Dependency upgrade
>  Components: Broker, Web Console
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (AMQ-9497) Upgrade to maven-jar-plugin 3.4.1

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/AMQ-9497?focusedWorklogId=921364=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921364
 ]

ASF GitHub Bot logged work on AMQ-9497:
---

Author: ASF GitHub Bot
Created on: 30/May/24 09:09
Start Date: 30/May/24 09:09
Worklog Time Spent: 10m 
  Work Description: jbonofre merged PR #1228:
URL: https://github.com/apache/activemq/pull/1228




Issue Time Tracking
---

Worklog Id: (was: 921364)
Time Spent: 20m  (was: 10m)

> Upgrade to maven-jar-plugin 3.4.1
> -
>
> Key: AMQ-9497
> URL: https://issues.apache.org/jira/browse/AMQ-9497
> Project: ActiveMQ Classic
>  Issue Type: Dependency upgrade
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (AMQ-9511) Upgrade to Spring 6.1.8

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/AMQ-9511?focusedWorklogId=921365=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921365
 ]

ASF GitHub Bot logged work on AMQ-9511:
---

Author: ASF GitHub Bot
Created on: 30/May/24 09:09
Start Date: 30/May/24 09:09
Worklog Time Spent: 10m 
  Work Description: jbonofre merged PR #1230:
URL: https://github.com/apache/activemq/pull/1230




Issue Time Tracking
---

Worklog Id: (was: 921365)
Time Spent: 20m  (was: 10m)

> Upgrade to Spring 6.1.8
> ---
>
> Key: AMQ-9511
> URL: https://issues.apache.org/jira/browse/AMQ-9511
> Project: ActiveMQ Classic
>  Issue Type: Dependency upgrade
>  Components: Broker
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (AMQ-9496) Upgrade to maven-compiler-plugin 3.13.0

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/AMQ-9496?focusedWorklogId=921363=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921363
 ]

ASF GitHub Bot logged work on AMQ-9496:
---

Author: ASF GitHub Bot
Created on: 30/May/24 09:08
Start Date: 30/May/24 09:08
Worklog Time Spent: 10m 
  Work Description: jbonofre merged PR #1227:
URL: https://github.com/apache/activemq/pull/1227




Issue Time Tracking
---

Worklog Id: (was: 921363)
Time Spent: 20m  (was: 10m)

> Upgrade to maven-compiler-plugin 3.13.0
> ---
>
> Key: AMQ-9496
> URL: https://issues.apache.org/jira/browse/AMQ-9496
> Project: ActiveMQ Classic
>  Issue Type: Dependency upgrade
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4165) Page transactions not getting deleted on queue deletion

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4165?focusedWorklogId=921280=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921280
 ]

ASF GitHub Bot logged work on ARTEMIS-4165:
---

Author: ASF GitHub Bot
Created on: 29/May/24 19:35
Start Date: 29/May/24 19:35
Worklog Time Spent: 10m 
  Work Description: clebertsuconic commented on PR #4948:
URL: 
https://github.com/apache/activemq-artemis/pull/4948#issuecomment-2138128437

   @jbertram I was just making the PR for the temporary branch @iliya-gr had 
created.. I just realized it was a few years ago.
   
   I will update the PR to remove the page transactions without using ACK 
records.




Issue Time Tracking
---

Worklog Id: (was: 921280)
Time Spent: 40m  (was: 0.5h)

> Page transactions not getting deleted on queue deletion
> ---
>
> Key: ARTEMIS-4165
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4165
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.28.0
>Reporter: Iliya Grushevskiy
>Priority: Major
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> If the queue contains paged messages then during queue deletion those message 
> records won't be updated. That will lead to journal grows as those records 
> will never get removed from journal.
> {code:java}
> operation@AddRecordTX;txID=107743391288,recordID=107743391443;userRecordType=35;isUpdate=false;compactCount=18;PageTransactionInfoImpl(transactionID=107743391288,id=107743391443,numberOfMessages=1)
> operation@Commit;txID=107743391288,numberOfRecords=1
> operation@AddRecordTX;txID=107743391258,recordID=107743391446;userRecordType=35;isUpdate=false;compactCount=18;PageTransactionInfoImpl(transactionID=107743391258,id=107743391446,numberOfMessages=1){code}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4165) Page transactions not getting deleted on queue deletion

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4165?focusedWorklogId=921275=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921275
 ]

ASF GitHub Bot logged work on ARTEMIS-4165:
---

Author: ASF GitHub Bot
Created on: 29/May/24 19:18
Start Date: 29/May/24 19:18
Worklog Time Spent: 10m 
  Work Description: clebertsuconic commented on PR #4948:
URL: 
https://github.com/apache/activemq-artemis/pull/4948#issuecomment-2138100968

   Before this change, Upon a restart the broker would check for orphaned Page 
Transactions and not right away as the queue is removed.
   
   With this change in place the broker will now just remove the messages from 
paging as it would on regular messages, and they would be acked accordingly.
   
   
   This is probably also good for mirroring... although I didn't check the 
result of such event on mirror.




Issue Time Tracking
---

Worklog Id: (was: 921275)
Time Spent: 0.5h  (was: 20m)

> Page transactions not getting deleted on queue deletion
> ---
>
> Key: ARTEMIS-4165
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4165
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.28.0
>Reporter: Iliya Grushevskiy
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> If the queue contains paged messages then during queue deletion those message 
> records won't be updated. That will lead to journal grows as those records 
> will never get removed from journal.
> {code:java}
> operation@AddRecordTX;txID=107743391288,recordID=107743391443;userRecordType=35;isUpdate=false;compactCount=18;PageTransactionInfoImpl(transactionID=107743391288,id=107743391443,numberOfMessages=1)
> operation@Commit;txID=107743391288,numberOfRecords=1
> operation@AddRecordTX;txID=107743391258,recordID=107743391446;userRecordType=35;isUpdate=false;compactCount=18;PageTransactionInfoImpl(transactionID=107743391258,id=107743391446,numberOfMessages=1){code}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4165) Page transactions not getting deleted on queue deletion

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4165?focusedWorklogId=921272=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921272
 ]

ASF GitHub Bot logged work on ARTEMIS-4165:
---

Author: ASF GitHub Bot
Created on: 29/May/24 18:50
Start Date: 29/May/24 18:50
Worklog Time Spent: 10m 
  Work Description: jbertram commented on PR #4948:
URL: 
https://github.com/apache/activemq-artemis/pull/4948#issuecomment-2138056875

   Looking at the solution I'm not sure how it actually addresses the problem. 
Can you provide a short description of why it works?




Issue Time Tracking
---

Worklog Id: (was: 921272)
Time Spent: 20m  (was: 10m)

> Page transactions not getting deleted on queue deletion
> ---
>
> Key: ARTEMIS-4165
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4165
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.28.0
>Reporter: Iliya Grushevskiy
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> If the queue contains paged messages then during queue deletion those message 
> records won't be updated. That will lead to journal grows as those records 
> will never get removed from journal.
> {code:java}
> operation@AddRecordTX;txID=107743391288,recordID=107743391443;userRecordType=35;isUpdate=false;compactCount=18;PageTransactionInfoImpl(transactionID=107743391288,id=107743391443,numberOfMessages=1)
> operation@Commit;txID=107743391288,numberOfRecords=1
> operation@AddRecordTX;txID=107743391258,recordID=107743391446;userRecordType=35;isUpdate=false;compactCount=18;PageTransactionInfoImpl(transactionID=107743391258,id=107743391446,numberOfMessages=1){code}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4165) Page transactions not getting deleted on queue deletion

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4165?focusedWorklogId=921269=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921269
 ]

ASF GitHub Bot logged work on ARTEMIS-4165:
---

Author: ASF GitHub Bot
Created on: 29/May/24 18:39
Start Date: 29/May/24 18:39
Worklog Time Spent: 10m 
  Work Description: clebertsuconic opened a new pull request, #4948:
URL: https://github.com/apache/activemq-artemis/pull/4948

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 921269)
Remaining Estimate: 0h
Time Spent: 10m

> Page transactions not getting deleted on queue deletion
> ---
>
> Key: ARTEMIS-4165
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4165
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.28.0
>Reporter: Iliya Grushevskiy
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> If the queue contains paged messages then during queue deletion those message 
> records won't be updated. That will lead to journal grows as those records 
> will never get removed from journal.
> {code:java}
> operation@AddRecordTX;txID=107743391288,recordID=107743391443;userRecordType=35;isUpdate=false;compactCount=18;PageTransactionInfoImpl(transactionID=107743391288,id=107743391443,numberOfMessages=1)
> operation@Commit;txID=107743391288,numberOfRecords=1
> operation@AddRecordTX;txID=107743391258,recordID=107743391446;userRecordType=35;isUpdate=false;compactCount=18;PageTransactionInfoImpl(transactionID=107743391258,id=107743391446,numberOfMessages=1){code}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (AMQ-9455) DestinationPolicy to support MessageStrategy

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/AMQ-9455?focusedWorklogId=921235=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921235
 ]

ASF GitHub Bot logged work on AMQ-9455:
---

Author: ASF GitHub Bot
Created on: 29/May/24 14:48
Start Date: 29/May/24 14:48
Worklog Time Spent: 10m 
  Work Description: cshannon commented on PR #1182:
URL: https://github.com/apache/activemq/pull/1182#issuecomment-2137605913

   So I double checked and yeah we pretty much just used "Strategy" for 
everything. So maybe we could make it more descriptive by adding an extra word 
to the name that describes it better like `MessageStrategy `instead 
of just MessageStrategy to convey what it is. Not sure... maybe 
MessageInterceptorStrategy, MessageEnricherStrategy, MessageMutatorStrategy, 
etc. I'm open for ideas




Issue Time Tracking
---

Worklog Id: (was: 921235)
Time Spent: 40m  (was: 0.5h)

> DestinationPolicy to support MessageStrategy
> 
>
> Key: AMQ-9455
> URL: https://issues.apache.org/jira/browse/AMQ-9455
> Project: ActiveMQ Classic
>  Issue Type: New Feature
>Reporter: Matt Pavlovich
>Assignee: Matt Pavlovich
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> A configurable list of message policy entries that will all for message 
> enrichment and enforcement of message content policies.
> This feature would serve to replace broker-wide plugins:
> ForcePersistencyModeBrokerPlugin
> TimeStampingBrokerPLugin
> UserIDBroker



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (AMQ-9455) DestinationPolicy to support MessageStrategy

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/AMQ-9455?focusedWorklogId=921234=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921234
 ]

ASF GitHub Bot logged work on AMQ-9455:
---

Author: ASF GitHub Bot
Created on: 29/May/24 14:45
Start Date: 29/May/24 14:45
Worklog Time Spent: 10m 
  Work Description: mattrpav commented on PR #1182:
URL: https://github.com/apache/activemq/pull/1182#issuecomment-2137597700

   @cshannon agreed, great points.  +1 on returning the object in the API.
   
   1. Re naming

Issue Time Tracking
---

Worklog Id: (was: 921234)
Time Spent: 0.5h  (was: 20m)

> DestinationPolicy to support MessageStrategy
> 
>
> Key: AMQ-9455
> URL: https://issues.apache.org/jira/browse/AMQ-9455
> Project: ActiveMQ Classic
>  Issue Type: New Feature
>Reporter: Matt Pavlovich
>Assignee: Matt Pavlovich
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> A configurable list of message policy entries that will all for message 
> enrichment and enforcement of message content policies.
> This feature would serve to replace broker-wide plugins:
> ForcePersistencyModeBrokerPlugin
> TimeStampingBrokerPLugin
> UserIDBroker



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (AMQ-9455) DestinationPolicy to support MessageStrategy

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/AMQ-9455?focusedWorklogId=921233=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921233
 ]

ASF GitHub Bot logged work on AMQ-9455:
---

Author: ASF GitHub Bot
Created on: 29/May/24 14:36
Start Date: 29/May/24 14:36
Worklog Time Spent: 10m 
  Work Description: cshannon commented on PR #1182:
URL: https://github.com/apache/activemq/pull/1182#issuecomment-2137575544

   It's not really clear to me when I first read this what MessageStrategy was 
supposed to be from the name so I'm wondering if we should rename it. if this 
is supposed to be essentially an interceptor framework to mutate a message the 
maybe we just call it something like MessageInterceptor. However, I know we 
used the term "Strategy" elsewhere 
   
   Also, the API may need some discussion. A lot of times with something like 
this you might want to return the message so you can chain it and actually 
return an entirely different object, but this could have its own problems with 
things like potential memory usage not being tracked correctly. This only 
supports mutating in place which can have problems as well.
   
   Anyways, the main thing is just making sure the public API is well thought 
out, named well, decide if we want to allow mutating in place only or not, etc 
because once it's out there it's hard to change it as people will create 
implementations.




Issue Time Tracking
---

Worklog Id: (was: 921233)
Time Spent: 20m  (was: 10m)

> DestinationPolicy to support MessageStrategy
> 
>
> Key: AMQ-9455
> URL: https://issues.apache.org/jira/browse/AMQ-9455
> Project: ActiveMQ Classic
>  Issue Type: New Feature
>Reporter: Matt Pavlovich
>Assignee: Matt Pavlovich
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> A configurable list of message policy entries that will all for message 
> enrichment and enforcement of message content policies.
> This feature would serve to replace broker-wide plugins:
> ForcePersistencyModeBrokerPlugin
> TimeStampingBrokerPLugin
> UserIDBroker



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=921214=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921214
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 29/May/24 12:15
Start Date: 29/May/24 12:15
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on PR #17:
URL: 
https://github.com/apache/activemq-artemis-console/pull/17#issuecomment-2137267999

   Pushed a small fixup, then merged.




Issue Time Tracking
---

Worklog Id: (was: 921214)
Time Spent: 11h 50m  (was: 11h 40m)

> Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
> Fix For: console-1.0.0
>
>  Time Spent: 11h 50m
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> As it can run standalone and be built seperately, this will be released 
> independently from [https://github.com/apache/activemq-artemis-console] and 
> the output later consumed in Artemis releases (similar to artemis-native).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=921213=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921213
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 29/May/24 12:14
Start Date: 29/May/24 12:14
Worklog Time Spent: 10m 
  Work Description: gemmellr merged PR #17:
URL: https://github.com/apache/activemq-artemis-console/pull/17




Issue Time Tracking
---

Worklog Id: (was: 921213)
Time Spent: 11h 40m  (was: 11.5h)

> Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
> Fix For: console-1.0.0
>
>  Time Spent: 11h 40m
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> As it can run standalone and be built seperately, this will be released 
> independently from [https://github.com/apache/activemq-artemis-console] and 
> the output later consumed in Artemis releases (similar to artemis-native).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=921209=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921209
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 29/May/24 11:45
Start Date: 29/May/24 11:45
Worklog Time Spent: 10m 
  Work Description: andytaylor commented on PR #17:
URL: 
https://github.com/apache/activemq-artemis-console/pull/17#issuecomment-2137212380

   updated as per comments




Issue Time Tracking
---

Worklog Id: (was: 921209)
Time Spent: 11.5h  (was: 11h 20m)

> Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
> Fix For: console-1.0.0
>
>  Time Spent: 11.5h
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> As it can run standalone and be built seperately, this will be released 
> independently from [https://github.com/apache/activemq-artemis-console] and 
> the output later consumed in Artemis releases (similar to artemis-native).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=921192=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921192
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 29/May/24 09:51
Start Date: 29/May/24 09:51
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on code in PR #17:
URL: 
https://github.com/apache/activemq-artemis-console/pull/17#discussion_r1618584239


##
LICENSE:
##
@@ -201,150 +201,10 @@
See the License for the specific language governing permissions and
limitations under the License.
 
-
-= For The Node cjs file for yarn under 
artemis-extension/.yarn/releases/yarn-.cjs =
-
-
-*
- * Copyright (c) 2014-present, Jon Schlinkert.
- * Licensed under the MIT License.
- */
-/*!
- * is-extglob 
- *
- * Copyright (c) 2014-2016, Jon Schlinkert.
- * Licensed under the MIT License.
- */
-/*!
- * is-glob 
- *
- * Copyright (c) 2014-2017, Jon Schlinkert.
- * Released under the MIT License.
- */
-/*!
- * is-number 
- *
- * Copyright (c) 2014-present, Jon Schlinkert.
- * Released under the MIT License.
- */
-/*!
- * is-windows 
- *
- * Copyright © 2015-2018, Jon Schlinkert.
- * Released under the MIT License.
- */
-/*!
- * to-regex-range 
- *
- * Copyright (c) 2015-present, Jon Schlinkert.
- * Released under the MIT License.
- */
-/**
-  @license
-  Copyright (c) 2015, Rebecca Turner
-
-  Permission to use, copy, modify, and/or distribute this software for any
-  purpose with or without fee is hereby granted, provided that the above
-  copyright notice and this permission notice appear in all copies.
-
-  THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH
-  REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY 
AND
-  FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
-  INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM
-  LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR
-  OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
-  PERFORMANCE OF THIS SOFTWARE.
- */
-/**
-  @license
-  Copyright Joyent, Inc. and other Node contributors.
-
-  Permission is hereby granted, free of charge, to any person obtaining a
-  copy of this software and associated documentation files (the
-  "Software"), to deal in the Software without restriction, including
-  without limitation the rights to use, copy, modify, merge, publish,
-  distribute, sublicense, and/or sell copies of the Software, and to permit
-  persons to whom the Software is furnished to do so, subject to the
-  following conditions:
-
-  The above copyright notice and this permission notice shall be included
-  in all copies or substantial portions of the Software.
-
-  THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
-  OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
-  MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
-  NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
-  DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
-  OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
-  USE OR OTHER DEALINGS IN THE SOFTWARE.
-*/
-/**
-  @license
-  Copyright Node.js contributors. All rights reserved.
-
-  Permission is hereby granted, free of charge, to any person obtaining a copy
-  of this software and associated documentation files (the "Software"), to
-  deal in the Software without restriction, including without limitation the
-  rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
-  sell copies of the Software, and to permit persons to whom the Software is
-  furnished to do so, subject to the following conditions:
-
-  The above copyright notice and this permission notice shall be included in
-  all copies or substantial portions of the Software.
-
-  THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-  IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-  FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-  AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-  LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
-  FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
-  IN THE SOFTWARE.
-*/
-/**
-  @license
-  The MIT License 

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=921190=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921190
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 29/May/24 09:25
Start Date: 29/May/24 09:25
Worklog Time Spent: 10m 
  Work Description: andytaylor opened a new pull request, #17:
URL: https://github.com/apache/activemq-artemis-console/pull/17

   Tidy up the license files




Issue Time Tracking
---

Worklog Id: (was: 921190)
Time Spent: 11h 10m  (was: 11h)

> Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
> Fix For: console-1.0.0
>
>  Time Spent: 11h 10m
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> As it can run standalone and be built seperately, this will be released 
> independently from [https://github.com/apache/activemq-artemis-console] and 
> the output later consumed in Artemis releases (similar to artemis-native).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4306) Add authn/z metrics

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4306?focusedWorklogId=921164=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921164
 ]

ASF GitHub Bot logged work on ARTEMIS-4306:
---

Author: ASF GitHub Bot
Created on: 29/May/24 04:12
Start Date: 29/May/24 04:12
Worklog Time Spent: 10m 
  Work Description: jbertram commented on PR #4944:
URL: 
https://github.com/apache/activemq-artemis/pull/4944#issuecomment-2136478558

   Test-suite looks good with regard to this PR now. Thank for the heads up!




Issue Time Tracking
---

Worklog Id: (was: 921164)
Time Spent: 1h 10m  (was: 1h)

> Add authn/z metrics
> ---
>
> Key: ARTEMIS-4306
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4306
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Justin Bertram
>Priority: Major
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> It would be useful to have metrics for authn/z successes and failures as well 
> as for metrics related to the corresponding caches.
> See this discussion on the users mailing list for more details: 
> https://lists.apache.org/thread/g6ygyo4kb3xhygq8hpw7vsl3l2g5qt92



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4306) Add authn/z metrics

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4306?focusedWorklogId=921153=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921153
 ]

ASF GitHub Bot logged work on ARTEMIS-4306:
---

Author: ASF GitHub Bot
Created on: 29/May/24 02:25
Start Date: 29/May/24 02:25
Worklog Time Spent: 10m 
  Work Description: jbertram commented on PR #4944:
URL: 
https://github.com/apache/activemq-artemis/pull/4944#issuecomment-2136401900

   It only really broke 2 tests. It's just those two tests are parameterized 
and inherited so the failures multiply. I verified the fixes locally and 
pushed. I'm running the test-suite now to fully verify.




Issue Time Tracking
---

Worklog Id: (was: 921153)
Time Spent: 1h  (was: 50m)

> Add authn/z metrics
> ---
>
> Key: ARTEMIS-4306
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4306
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Justin Bertram
>Priority: Major
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> It would be useful to have metrics for authn/z successes and failures as well 
> as for metrics related to the corresponding caches.
> See this discussion on the users mailing list for more details: 
> https://lists.apache.org/thread/g6ygyo4kb3xhygq8hpw7vsl3l2g5qt92



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4784) Large messages are being kept on the ReplicationEndpoint after they are closed.

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4784?focusedWorklogId=921146=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921146
 ]

ASF GitHub Bot logged work on ARTEMIS-4784:
---

Author: ASF GitHub Bot
Created on: 29/May/24 01:04
Start Date: 29/May/24 01:04
Worklog Time Spent: 10m 
  Work Description: clebertsuconic merged PR #4947:
URL: https://github.com/apache/activemq-artemis/pull/4947




Issue Time Tracking
---

Worklog Id: (was: 921146)
Time Spent: 20m  (was: 10m)

> Large messages are being kept on the ReplicationEndpoint after they are 
> closed.
> ---
>
> Key: ARTEMIS-4784
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4784
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Clebert Suconic
>Assignee: Clebert Suconic
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The entries for these large messages need to be removed as soon as the file 
> is closed:
> https://github.com/apache/activemq-artemis/blob/49189cd7e63a64fcda947dbd72fd7849348b71c9/artemis-server/src/main/java/org/apache/activemq/artemis/core/replication/ReplicationEndpoint.java#L134
> When a remove is needed a new object should be created instead of keeping the 
> hash longer.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4306) Add authn/z metrics

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4306?focusedWorklogId=921138=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921138
 ]

ASF GitHub Bot logged work on ARTEMIS-4306:
---

Author: ASF GitHub Bot
Created on: 28/May/24 23:47
Start Date: 28/May/24 23:47
Worklog Time Spent: 10m 
  Work Description: clebertsuconic commented on PR #4944:
URL: 
https://github.com/apache/activemq-artemis/pull/4944#issuecomment-2136276774

   @jbertram did you run the testsuite on this?
   because it broke quite a few tests.




Issue Time Tracking
---

Worklog Id: (was: 921138)
Time Spent: 50m  (was: 40m)

> Add authn/z metrics
> ---
>
> Key: ARTEMIS-4306
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4306
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Justin Bertram
>Priority: Major
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> It would be useful to have metrics for authn/z successes and failures as well 
> as for metrics related to the corresponding caches.
> See this discussion on the users mailing list for more details: 
> https://lists.apache.org/thread/g6ygyo4kb3xhygq8hpw7vsl3l2g5qt92



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4306) Add authn/z metrics

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4306?focusedWorklogId=921133=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921133
 ]

ASF GitHub Bot logged work on ARTEMIS-4306:
---

Author: ASF GitHub Bot
Created on: 28/May/24 21:27
Start Date: 28/May/24 21:27
Worklog Time Spent: 10m 
  Work Description: clebertsuconic merged PR #4944:
URL: https://github.com/apache/activemq-artemis/pull/4944




Issue Time Tracking
---

Worklog Id: (was: 921133)
Time Spent: 40m  (was: 0.5h)

> Add authn/z metrics
> ---
>
> Key: ARTEMIS-4306
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4306
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Justin Bertram
>Priority: Major
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> It would be useful to have metrics for authn/z successes and failures as well 
> as for metrics related to the corresponding caches.
> See this discussion on the users mailing list for more details: 
> https://lists.apache.org/thread/g6ygyo4kb3xhygq8hpw7vsl3l2g5qt92



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4306) Add authn/z metrics

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4306?focusedWorklogId=921130=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921130
 ]

ASF GitHub Bot logged work on ARTEMIS-4306:
---

Author: ASF GitHub Bot
Created on: 28/May/24 21:12
Start Date: 28/May/24 21:12
Worklog Time Spent: 10m 
  Work Description: jbertram commented on code in PR #4944:
URL: https://github.com/apache/activemq-artemis/pull/4944#discussion_r1617897308


##
artemis-server/src/main/resources/schema/artemis-configuration.xsd:
##
@@ -4913,6 +4913,14 @@

 
 
+

Review Comment:
   The instances of Caffeine caches which are related to security is what is 
being instrumented here. Metrics that are made available when this is set to 
`true` are things like:
   
   - `cache.size`
   - `cache.puts`
   - `cache.gets` tagged by `result` - either `hit` or `miss`
   - `cache.evictions`
   - `cache.eviction.weight`
   
   Therefore, calling it `security-caches` seems appropriate.





Issue Time Tracking
---

Worklog Id: (was: 921130)
Time Spent: 0.5h  (was: 20m)

> Add authn/z metrics
> ---
>
> Key: ARTEMIS-4306
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4306
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Justin Bertram
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> It would be useful to have metrics for authn/z successes and failures as well 
> as for metrics related to the corresponding caches.
> See this discussion on the users mailing list for more details: 
> https://lists.apache.org/thread/g6ygyo4kb3xhygq8hpw7vsl3l2g5qt92



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4306) Add authn/z metrics

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4306?focusedWorklogId=921129=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921129
 ]

ASF GitHub Bot logged work on ARTEMIS-4306:
---

Author: ASF GitHub Bot
Created on: 28/May/24 21:07
Start Date: 28/May/24 21:07
Worklog Time Spent: 10m 
  Work Description: clebertsuconic commented on code in PR #4944:
URL: https://github.com/apache/activemq-artemis/pull/4944#discussion_r1617892944


##
artemis-server/src/main/resources/schema/artemis-configuration.xsd:
##
@@ -4913,6 +4913,14 @@

 
 
+

Review Comment:
   shouldn't this be called security-events, perhaps security-attempts?





Issue Time Tracking
---

Worklog Id: (was: 921129)
Time Spent: 20m  (was: 10m)

> Add authn/z metrics
> ---
>
> Key: ARTEMIS-4306
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4306
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Justin Bertram
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> It would be useful to have metrics for authn/z successes and failures as well 
> as for metrics related to the corresponding caches.
> See this discussion on the users mailing list for more details: 
> https://lists.apache.org/thread/g6ygyo4kb3xhygq8hpw7vsl3l2g5qt92



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4784) Large messages are being kept on the ReplicationEndpoint after they are closed.

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4784?focusedWorklogId=921120=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921120
 ]

ASF GitHub Bot logged work on ARTEMIS-4784:
---

Author: ASF GitHub Bot
Created on: 28/May/24 20:09
Start Date: 28/May/24 20:09
Worklog Time Spent: 10m 
  Work Description: clebertsuconic opened a new pull request, #4947:
URL: https://github.com/apache/activemq-artemis/pull/4947

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 921120)
Remaining Estimate: 0h
Time Spent: 10m

> Large messages are being kept on the ReplicationEndpoint after they are 
> closed.
> ---
>
> Key: ARTEMIS-4784
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4784
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Clebert Suconic
>Assignee: Clebert Suconic
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The entries for these large messages need to be removed as soon as the file 
> is closed:
> https://github.com/apache/activemq-artemis/blob/49189cd7e63a64fcda947dbd72fd7849348b71c9/artemis-server/src/main/java/org/apache/activemq/artemis/core/replication/ReplicationEndpoint.java#L134
> When a remove is needed a new object should be created instead of keeping the 
> hash longer.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=921031=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921031
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 28/May/24 11:04
Start Date: 28/May/24 11:04
Worklog Time Spent: 10m 
  Work Description: gemmellr merged PR #16:
URL: https://github.com/apache/activemq-artemis-console/pull/16




Issue Time Tracking
---

Worklog Id: (was: 921031)
Time Spent: 11h  (was: 10h 50m)

> Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
> Fix For: console-1.0.0
>
>  Time Spent: 11h
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> As it can run standalone and be built seperately, this will be released 
> independently from [https://github.com/apache/activemq-artemis-console] and 
> the output later consumed in Artemis releases (similar to artemis-native).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (ARTEMIS-4306) Add authn/z metrics

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4306?focusedWorklogId=921000=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921000
 ]

ASF GitHub Bot logged work on ARTEMIS-4306:
---

Author: ASF GitHub Bot
Created on: 27/May/24 22:24
Start Date: 27/May/24 22:24
Worklog Time Spent: 10m 
  Work Description: jbertram opened a new pull request, #4944:
URL: https://github.com/apache/activemq-artemis/pull/4944

   This commit includes the following changes:
   
- Management operations to get sucess & failure counts for authn and authz 
along with the corresponding audit logging.
- Export the aforementioned authn & authz metrics.
- Export metrics for the underlying authn & authz caches including the 
ability to enable/disable them.
- Update metrics tests to validate tags in addition to keys and values.
- Update documentation to explain new functionality and clarify existing 
metric tags.




Issue Time Tracking
---

Worklog Id: (was: 921000)
Remaining Estimate: 0h
Time Spent: 10m

> Add authn/z metrics
> ---
>
> Key: ARTEMIS-4306
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4306
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Justin Bertram
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> It would be useful to have metrics for authn/z successes and failures as well 
> as for metrics related to the corresponding caches.
> See this discussion on the users mailing list for more details: 
> https://lists.apache.org/thread/g6ygyo4kb3xhygq8hpw7vsl3l2g5qt92



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (AMQ-9511) Upgrade to Spring 6.1.8

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/AMQ-9511?focusedWorklogId=920948=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-920948
 ]

ASF GitHub Bot logged work on AMQ-9511:
---

Author: ASF GitHub Bot
Created on: 27/May/24 08:34
Start Date: 27/May/24 08:34
Worklog Time Spent: 10m 
  Work Description: jbonofre opened a new pull request, #1230:
URL: https://github.com/apache/activemq/pull/1230

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 920948)
Remaining Estimate: 0h
Time Spent: 10m

> Upgrade to Spring 6.1.8
> ---
>
> Key: AMQ-9511
> URL: https://issues.apache.org/jira/browse/AMQ-9511
> Project: ActiveMQ Classic
>  Issue Type: Dependency upgrade
>  Components: Broker
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (AMQ-9498) Upgrade to maven-xbean-plugin 4.25

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/AMQ-9498?focusedWorklogId=920942=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-920942
 ]

ASF GitHub Bot logged work on AMQ-9498:
---

Author: ASF GitHub Bot
Created on: 27/May/24 07:33
Start Date: 27/May/24 07:33
Worklog Time Spent: 10m 
  Work Description: jbonofre opened a new pull request, #1229:
URL: https://github.com/apache/activemq/pull/1229

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 920942)
Time Spent: 0.5h  (was: 20m)

> Upgrade to maven-xbean-plugin 4.25
> --
>
> Key: AMQ-9498
> URL: https://issues.apache.org/jira/browse/AMQ-9498
> Project: ActiveMQ Classic
>  Issue Type: Dependency upgrade
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (AMQ-9497) Upgrade to maven-jar-plugin 3.4.1

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/AMQ-9497?focusedWorklogId=920941=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-920941
 ]

ASF GitHub Bot logged work on AMQ-9497:
---

Author: ASF GitHub Bot
Created on: 27/May/24 07:32
Start Date: 27/May/24 07:32
Worklog Time Spent: 10m 
  Work Description: jbonofre opened a new pull request, #1228:
URL: https://github.com/apache/activemq/pull/1228

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 920941)
Remaining Estimate: 0h
Time Spent: 10m

> Upgrade to maven-jar-plugin 3.4.1
> -
>
> Key: AMQ-9497
> URL: https://issues.apache.org/jira/browse/AMQ-9497
> Project: ActiveMQ Classic
>  Issue Type: Dependency upgrade
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact

[jira] [Work logged] (AMQ-9496) Upgrade to maven-compiler-plugin 3.13.0

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/AMQ-9496?focusedWorklogId=920939=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-920939
 ]

ASF GitHub Bot logged work on AMQ-9496:
---

Author: ASF GitHub Bot
Created on: 27/May/24 07:30
Start Date: 27/May/24 07:30
Worklog Time Spent: 10m 
  Work Description: jbonofre opened a new pull request, #1227:
URL: https://github.com/apache/activemq/pull/1227

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 920939)
Remaining Estimate: 0h
Time Spent: 10m

> Upgrade to maven-compiler-plugin 3.13.0
> ---
>
> Key: AMQ-9496
> URL: https://issues.apache.org/jira/browse/AMQ-9496
> Project: ActiveMQ Classic
>  Issue Type: Dependency upgrade
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact