[jira] [Commented] (GEODE-136) Fix possible NullPointerException in Gfsh's 'list regions' command's GetRegionsFunction.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15547069#comment-15547069
 ] 

ASF GitHub Bot commented on GEODE-136:
--

Github user kjduling closed the pull request at:

https://github.com/apache/incubator-geode/pull/252


> Fix possible NullPointerException in Gfsh's 'list regions' command's 
> GetRegionsFunction.
> 
>
> Key: GEODE-136
> URL: https://issues.apache.org/jira/browse/GEODE-136
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Affects Versions: 1.0.0-incubating
> Environment: GemFire Manager + Gfsh
>Reporter: John Blum
>Assignee: Kevin Duling
>  Labels: ApacheGeode, CLI, GFSH, GetRegionsFunction, list-regions
> Fix For: 1.0.0-incubating
>
>
> The following line 
> ([#48|https://github.com/apache/incubator-geode/blob/develop/gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/GetRegionsFunction.java#L48])
>  in the {{GetRegionsFunction}} class could possibly lead to a NPE if the 
> {{regions}} _Set_ is null since the {{regions.isEmpty()}} call proceeds the 
> {{regions == null}} check.
> Of course, one should argue whether {{Cache.rootRegions()}} should be 
> returning a null _Set_ at all rather than an empty _Set_ if there are in fact 
> no "root" _Regions_ in the Geode _Cache_.
> But then, one could also argue that this {{GetRegionsFunction}} should not be 
> returning a null "array" if there are no "root" _Regions_ in the Geode 
> _Cache_ either.  It too should be returning an "empty" array.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-136) Fix possible NullPointerException in Gfsh's 'list regions' command's GetRegionsFunction.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15547060#comment-15547060
 ] 

ASF GitHub Bot commented on GEODE-136:
--

GitHub user kjduling opened a pull request:

https://github.com/apache/incubator-geode/pull/252

GEODE-136: Fix possible NullPointerException in GetRegionsFunction



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kjduling/incubator-geode feature/GEODE-136

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/252.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #252


commit 56a35e2b60c9a039dda06e5af7c0af431e8d3096
Author: Anthony Baker 
Date:   2016-10-01T16:22:25Z

Bump version after creating release/1.0.0-incubating branch

commit e04519dc3eced1254f58eaebee9c241ee335dbab
Author: Jinmei Liao 
Date:   2016-10-03T17:51:05Z

GEODE-420: fix Pulse test when not using any SSLConfig

commit 8929e93bd129b303aae8f9e1b13daf3c3991d1a4
Author: Anthony Baker 
Date:   2016-10-01T23:55:44Z

Add FlakyTest category to tests with open bugs

Annotate test methods with FlakyTest category if there is an open
bug for that test. This will improve the signal/noise ratio for
unit/integration/distributed tests.  Flaky tests are still run
as part of precheckin and flakyTest targets.

commit c80cba2c81f55736121a0d12d7e01b3249c20bdd
Author: Kevin Duling 
Date:   2016-09-26T23:10:34Z

GEODE-1902 - Add GEMFIRE_VERBOSE LogMarker as alias of GEODE_VERBOSE for 
backwards compatibility

This closes #247

commit 8703f2a71526a35f8945698611d18a0b8b9bd373
Author: Kirk Lund 
Date:   2016-10-04T18:45:46Z

GEODE-1902: reformat code

commit 375c6c5bcf3ee4ab52bb6bf4b34ca3eb26065ef9
Author: Kirk Lund 
Date:   2016-10-04T20:11:03Z

GEODE-1902: add ACCEPT and DENY tests for GEODE_VERBOSE and GEMFIRE_VERBOSE

commit 1feea53c2032bc79df39a653945e53d24f9c9291
Author: Jason Huynh 
Date:   2016-10-04T16:31:14Z

GEODE-1963: Add lucene xsd to website content

commit 118c0d467e0ad80d98ff2aaa1a3d22d26b40696f
Author: Kirk Lund 
Date:   2016-10-04T21:38:10Z

GEODE-1902: add apache license header

commit 71627eb8154477c742eb045732967826b2fc1b47
Author: Dave Barnes 
Date:   2016-10-04T22:10:16Z

GEODE-1963 Fix a pathname typo in the website README.md revealed during the 
recent lucene.xsd addition.

commit 15a5267c47852efbed14cb9b85614a1208145c33
Author: nabarun 
Date:   2016-10-04T22:11:30Z

GEODE-1384: Stat issues were fixed as a part of other tickets.

* Code refactored to have the correct order of creation of cache, 
region and sender receivers.

commit f0dab0aa3b33306b82ec31ee3fff0cceda1ac719
Author: nabarun 
Date:   2016-10-04T22:15:23Z

GEODE-1147: Removed flaky class tag

* Test was fixed in a prior commit.

commit f82626f46babe0f5fcce8dafd5deab2ca6b86860
Author: nabarun 
Date:   2016-10-04T22:26:45Z

GEODE-1804: Refactored the test

* Refactored the test to have the correct order of creation of cache, 
region and sender-receivers.
* Additional validity check for the local region size.

commit 0b61ae69d8486c137a30160c22d8985c37f76324
Author: nabarun 
Date:   2016-10-04T22:33:13Z

GEODE-1364: Resolved as a part of GEODE-1588

commit 18c2dc3fb0067ac529ddd228c746e20f87ac2c9a
Author: nabarun 
Date:   2016-10-04T22:35:44Z

GEODE-1148: Removing the flaky tag

* Test resolved as a part of prior commit.

commit 3c7f4b7eed8852cd0589ad07ad34824fa2869c68
Author: Kevin Duling 
Date:   2016-10-04T23:39:19Z

GEODE-136: Fix possible NullPointerException in Gfsh's 'list regions' 
command's GetRegionsFunction.




> Fix possible NullPointerException in Gfsh's 'list regions' command's 
> GetRegionsFunction.
> 
>
> Key: GEODE-136
> URL: https://issues.apache.org/jira/browse/GEODE-136
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Affects Versions: 1.0.0-incubating
> Environment: GemFire Manager + Gfsh
>Reporter: John Blum
>Assignee: Kevin Duling
>  Labels: ApacheGeode, CLI, GFSH, GetRegionsFunction, list-regions
> Fix For: 1.0.0-incubating
>
>
> The following line 
> 

[jira] [Commented] (GEODE-1907) QueryDataFunction does not add LIMIT clause if space is missing after FROM clause

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15537355#comment-15537355
 ] 

ASF GitHub Bot commented on GEODE-1907:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/249


> QueryDataFunction does not add LIMIT clause if space is missing after FROM 
> clause
> -
>
> Key: GEODE-1907
> URL: https://issues.apache.org/jira/browse/GEODE-1907
> Project: Geode
>  Issue Type: Bug
>  Components: management, querying
>Reporter: Kirk Lund
>Assignee: Jared Stewart
>Priority: Minor
>
> Apparently "SELECT * FROM/MyRegion" is a valid query in Geode, however if 
> this query is used from GFSH or Pulse, then QueryDataFunction will fail to 
> add a LIMIT clause because there is no space between FROM and the region name.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1907) QueryDataFunction does not add LIMIT clause if space is missing after FROM clause

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15536974#comment-15536974
 ] 

ASF GitHub Bot commented on GEODE-1907:
---

Github user kirklund commented on the issue:

https://github.com/apache/incubator-geode/pull/249
  
+1 pulling in now


> QueryDataFunction does not add LIMIT clause if space is missing after FROM 
> clause
> -
>
> Key: GEODE-1907
> URL: https://issues.apache.org/jira/browse/GEODE-1907
> Project: Geode
>  Issue Type: Bug
>  Components: management, querying
>Reporter: Kirk Lund
>Assignee: Jared Stewart
>Priority: Minor
>
> Apparently "SELECT * FROM/MyRegion" is a valid query in Geode, however if 
> this query is used from GFSH or Pulse, then QueryDataFunction will fail to 
> add a LIMIT clause because there is no space between FROM and the region name.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1548) jmx-manager-hostname-for-clients not honored

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15536949#comment-15536949
 ] 

ASF GitHub Bot commented on GEODE-1548:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/248


> jmx-manager-hostname-for-clients not honored
> 
>
> Key: GEODE-1548
> URL: https://issues.apache.org/jira/browse/GEODE-1548
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, management
>Reporter: Swapnil Bawaskar
>Assignee: Jared Stewart
>
> While running Geode on AWS, found that {{jmx-manager-hostname-for-clients}} 
> is not being honored resulting in not being able to connect to gfsh from 
> outside AWS.
> I started a locator in AWS with the following command:
> {noformat}
> gfsh>start locator --name=locator 
> --J=-Dgemfire.jmx-manager-hostname-for-clients= 
> --hostname-for-clients=
> {noformat}
> When trying to connect to this locator from my laptop I get the following 
> error:
> {noformat}
> gfsh>connect --locator=52.41.104.182[10334]
> Connecting to Locator at [host=52.41.104.182, port=10334] ..
> Connecting to Manager at 
> [host=ec2-52-41-104-182.us-west-2.compute.amazonaws.com, port=1099] ..
> Could not connect to : 
> [host=ec2-52-41-104-182.us-west-2.compute.amazonaws.com, port=1099]. Failed 
> to retrieve RMIServer stub: javax.naming.CommunicationException [Root 
> exception is java.rmi.ConnectIOException: error during JRMP connection 
> establishment; nested exception is:
> java.net.SocketException: Connection reset]
> {noformat}
> Note that gfsh is trying to connect to the public dns for the instance, not 
> using the {{jmx-manager-hostname-for-clients}} property provided.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1548) jmx-manager-hostname-for-clients not honored

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15536945#comment-15536945
 ] 

ASF GitHub Bot commented on GEODE-1548:
---

Github user jinmeiliao commented on the issue:

https://github.com/apache/incubator-geode/pull/248
  
+1


> jmx-manager-hostname-for-clients not honored
> 
>
> Key: GEODE-1548
> URL: https://issues.apache.org/jira/browse/GEODE-1548
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, management
>Reporter: Swapnil Bawaskar
>Assignee: Jared Stewart
>
> While running Geode on AWS, found that {{jmx-manager-hostname-for-clients}} 
> is not being honored resulting in not being able to connect to gfsh from 
> outside AWS.
> I started a locator in AWS with the following command:
> {noformat}
> gfsh>start locator --name=locator 
> --J=-Dgemfire.jmx-manager-hostname-for-clients= 
> --hostname-for-clients=
> {noformat}
> When trying to connect to this locator from my laptop I get the following 
> error:
> {noformat}
> gfsh>connect --locator=52.41.104.182[10334]
> Connecting to Locator at [host=52.41.104.182, port=10334] ..
> Connecting to Manager at 
> [host=ec2-52-41-104-182.us-west-2.compute.amazonaws.com, port=1099] ..
> Could not connect to : 
> [host=ec2-52-41-104-182.us-west-2.compute.amazonaws.com, port=1099]. Failed 
> to retrieve RMIServer stub: javax.naming.CommunicationException [Root 
> exception is java.rmi.ConnectIOException: error during JRMP connection 
> establishment; nested exception is:
> java.net.SocketException: Connection reset]
> {noformat}
> Note that gfsh is trying to connect to the public dns for the instance, not 
> using the {{jmx-manager-hostname-for-clients}} property provided.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1548) jmx-manager-hostname-for-clients not honored

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15536927#comment-15536927
 ] 

ASF GitHub Bot commented on GEODE-1548:
---

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/248#discussion_r81409537
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/management/internal/security/JavaRmiServerNameJunitTest.java
 ---
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.geode.management.internal.security;
+
+import static org.apache.geode.distributed.ConfigurationProperties.*;
+import static org.junit.Assert.*;
+
+import java.util.Properties;
+
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+import org.apache.geode.cache.CacheFactory;
+import org.apache.geode.internal.AvailablePort;
+import org.apache.geode.test.junit.categories.UnitTest;
+
+@Category(UnitTest.class)
--- End diff --

Thanks for clarifying that distinction.  I pushed another commit with this 
change.


> jmx-manager-hostname-for-clients not honored
> 
>
> Key: GEODE-1548
> URL: https://issues.apache.org/jira/browse/GEODE-1548
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, management
>Reporter: Swapnil Bawaskar
>Assignee: Jared Stewart
>
> While running Geode on AWS, found that {{jmx-manager-hostname-for-clients}} 
> is not being honored resulting in not being able to connect to gfsh from 
> outside AWS.
> I started a locator in AWS with the following command:
> {noformat}
> gfsh>start locator --name=locator 
> --J=-Dgemfire.jmx-manager-hostname-for-clients= 
> --hostname-for-clients=
> {noformat}
> When trying to connect to this locator from my laptop I get the following 
> error:
> {noformat}
> gfsh>connect --locator=52.41.104.182[10334]
> Connecting to Locator at [host=52.41.104.182, port=10334] ..
> Connecting to Manager at 
> [host=ec2-52-41-104-182.us-west-2.compute.amazonaws.com, port=1099] ..
> Could not connect to : 
> [host=ec2-52-41-104-182.us-west-2.compute.amazonaws.com, port=1099]. Failed 
> to retrieve RMIServer stub: javax.naming.CommunicationException [Root 
> exception is java.rmi.ConnectIOException: error during JRMP connection 
> establishment; nested exception is:
> java.net.SocketException: Connection reset]
> {noformat}
> Note that gfsh is trying to connect to the public dns for the instance, not 
> using the {{jmx-manager-hostname-for-clients}} property provided.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1548) jmx-manager-hostname-for-clients not honored

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15536911#comment-15536911
 ] 

ASF GitHub Bot commented on GEODE-1548:
---

Github user metatype commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/248#discussion_r81408700
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/management/internal/security/JavaRmiServerNameJunitTest.java
 ---
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.geode.management.internal.security;
+
+import static org.apache.geode.distributed.ConfigurationProperties.*;
+import static org.junit.Assert.*;
+
+import java.util.Properties;
+
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+import org.apache.geode.cache.CacheFactory;
+import org.apache.geode.internal.AvailablePort;
+import org.apache.geode.test.junit.categories.UnitTest;
+
+@Category(UnitTest.class)
--- End diff --

Oh got it, I missed the previous comment around @IntegrationTest.


> jmx-manager-hostname-for-clients not honored
> 
>
> Key: GEODE-1548
> URL: https://issues.apache.org/jira/browse/GEODE-1548
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, management
>Reporter: Swapnil Bawaskar
>Assignee: Jared Stewart
>
> While running Geode on AWS, found that {{jmx-manager-hostname-for-clients}} 
> is not being honored resulting in not being able to connect to gfsh from 
> outside AWS.
> I started a locator in AWS with the following command:
> {noformat}
> gfsh>start locator --name=locator 
> --J=-Dgemfire.jmx-manager-hostname-for-clients= 
> --hostname-for-clients=
> {noformat}
> When trying to connect to this locator from my laptop I get the following 
> error:
> {noformat}
> gfsh>connect --locator=52.41.104.182[10334]
> Connecting to Locator at [host=52.41.104.182, port=10334] ..
> Connecting to Manager at 
> [host=ec2-52-41-104-182.us-west-2.compute.amazonaws.com, port=1099] ..
> Could not connect to : 
> [host=ec2-52-41-104-182.us-west-2.compute.amazonaws.com, port=1099]. Failed 
> to retrieve RMIServer stub: javax.naming.CommunicationException [Root 
> exception is java.rmi.ConnectIOException: error during JRMP connection 
> establishment; nested exception is:
> java.net.SocketException: Connection reset]
> {noformat}
> Note that gfsh is trying to connect to the public dns for the instance, not 
> using the {{jmx-manager-hostname-for-clients}} property provided.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1548) jmx-manager-hostname-for-clients not honored

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15536909#comment-15536909
 ] 

ASF GitHub Bot commented on GEODE-1548:
---

Github user metatype commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/248#discussion_r81408523
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/management/internal/security/JavaRmiServerNameJunitTest.java
 ---
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.geode.management.internal.security;
+
+import static org.apache.geode.distributed.ConfigurationProperties.*;
+import static org.junit.Assert.*;
+
+import java.util.Properties;
+
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+import org.apache.geode.cache.CacheFactory;
+import org.apache.geode.internal.AvailablePort;
+import org.apache.geode.test.junit.categories.UnitTest;
+
+@Category(UnitTest.class)
--- End diff --

Isn't the convention to use *JUnitTest for unit tests?


> jmx-manager-hostname-for-clients not honored
> 
>
> Key: GEODE-1548
> URL: https://issues.apache.org/jira/browse/GEODE-1548
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, management
>Reporter: Swapnil Bawaskar
>Assignee: Jared Stewart
>
> While running Geode on AWS, found that {{jmx-manager-hostname-for-clients}} 
> is not being honored resulting in not being able to connect to gfsh from 
> outside AWS.
> I started a locator in AWS with the following command:
> {noformat}
> gfsh>start locator --name=locator 
> --J=-Dgemfire.jmx-manager-hostname-for-clients= 
> --hostname-for-clients=
> {noformat}
> When trying to connect to this locator from my laptop I get the following 
> error:
> {noformat}
> gfsh>connect --locator=52.41.104.182[10334]
> Connecting to Locator at [host=52.41.104.182, port=10334] ..
> Connecting to Manager at 
> [host=ec2-52-41-104-182.us-west-2.compute.amazonaws.com, port=1099] ..
> Could not connect to : 
> [host=ec2-52-41-104-182.us-west-2.compute.amazonaws.com, port=1099]. Failed 
> to retrieve RMIServer stub: javax.naming.CommunicationException [Root 
> exception is java.rmi.ConnectIOException: error during JRMP connection 
> establishment; nested exception is:
> java.net.SocketException: Connection reset]
> {noformat}
> Note that gfsh is trying to connect to the public dns for the instance, not 
> using the {{jmx-manager-hostname-for-clients}} property provided.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1907) QueryDataFunction does not add LIMIT clause if space is missing after FROM clause

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15536847#comment-15536847
 ] 

ASF GitHub Bot commented on GEODE-1907:
---

Github user kirklund commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/249#discussion_r81404596
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/beans/QueryDataFunction.java
 ---
@@ -360,31 +373,36 @@ public static Object queryData(final String query,
 for (String regionPath : regionsInQuery) {
   DistributedRegionMXBean regionMBean = 
service.getDistributedRegionMXBean(regionPath);
   if (regionMBean == null) {
-return new 
JsonisedErroMessage(ManagementStrings.QUERY__MSG__REGIONS_NOT_FOUND.toLocalizedString(regionPath)).toString();
+return new 
JsonisedErroMessage(ManagementStrings.QUERY__MSG__REGIONS_NOT_FOUND.toLocalizedString(regionPath))
+  .toString();
   } else {
 Set associatedMembers = 
DataCommands.getRegionAssociatedMembers(regionPath, cache, true);
 
 if (inputMembers != null && inputMembers.size() > 0) {
   if (!associatedMembers.containsAll(inputMembers)) {
-return new 
JsonisedErroMessage(ManagementStrings.QUERY__MSG__REGIONS_NOT_FOUND_ON_MEMBERS.toLocalizedString(regionPath))
-  .toString();
+return new 
JsonisedErroMessage(ManagementStrings.QUERY__MSG__REGIONS_NOT_FOUND_ON_MEMBERS
+  .toLocalizedString(regionPath)).toString();
   }
 }
   }
 
 }
   } else {
-return new 
JsonisedErroMessage(ManagementStrings.QUERY__MSG__INVALID_QUERY.toLocalizedString("Region
 mentioned in query probably missing /")).toString();
+return new 
JsonisedErroMessage(ManagementStrings.QUERY__MSG__INVALID_QUERY.toLocalizedString("Region
 mentioned in query probably missing /"))
+  .toString();
   }
 
   // Validate
   if (regionsInQuery.size() > 1 && inputMembers == null) {
 for (String regionPath : regionsInQuery) {
   DistributedRegionMXBean regionMBean = 
service.getDistributedRegionMXBean(regionPath);
 
-  if 
(regionMBean.getRegionType().equals(DataPolicy.PARTITION.toString()) || 
-  
regionMBean.getRegionType().equals(DataPolicy.PERSISTENT_PARTITION.toString())) 
{
-return new 
JsonisedErroMessage(ManagementStrings.QUERY__MSG__JOIN_OP_EX.toLocalizedString()).toString();
+  if (regionMBean.getRegionType()
--- End diff --

I updated the formatters in etc/ including etc/intellijIdeaCodeStyle.xml to 
prevent these whacky linefeeds. Please update and rerun the formatter. The 
changes look good and I'll pull it in as soon as you've reformatted. Thanks!


> QueryDataFunction does not add LIMIT clause if space is missing after FROM 
> clause
> -
>
> Key: GEODE-1907
> URL: https://issues.apache.org/jira/browse/GEODE-1907
> Project: Geode
>  Issue Type: Bug
>  Components: management, querying
>Reporter: Kirk Lund
>Assignee: Jared Stewart
>Priority: Minor
>
> Apparently "SELECT * FROM/MyRegion" is a valid query in Geode, however if 
> this query is used from GFSH or Pulse, then QueryDataFunction will fail to 
> add a LIMIT clause because there is no space between FROM and the region name.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1548) jmx-manager-hostname-for-clients not honored

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15536809#comment-15536809
 ] 

ASF GitHub Bot commented on GEODE-1548:
---

Github user kirklund commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/248#discussion_r81402893
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/management/internal/security/JavaRmiServerNameJunitTest.java
 ---
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.geode.management.internal.security;
+
+import static org.apache.geode.distributed.ConfigurationProperties.*;
+import static org.junit.Assert.*;
+
+import java.util.Properties;
+
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+import org.apache.geode.cache.CacheFactory;
+import org.apache.geode.internal.AvailablePort;
+import org.apache.geode.test.junit.categories.UnitTest;
+
+@Category(UnitTest.class)
--- End diff --

The test name is ok but I'd probably make it 
JavaRmiServerNameIntegrationTest.java


> jmx-manager-hostname-for-clients not honored
> 
>
> Key: GEODE-1548
> URL: https://issues.apache.org/jira/browse/GEODE-1548
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, management
>Reporter: Swapnil Bawaskar
>Assignee: Jared Stewart
>
> While running Geode on AWS, found that {{jmx-manager-hostname-for-clients}} 
> is not being honored resulting in not being able to connect to gfsh from 
> outside AWS.
> I started a locator in AWS with the following command:
> {noformat}
> gfsh>start locator --name=locator 
> --J=-Dgemfire.jmx-manager-hostname-for-clients= 
> --hostname-for-clients=
> {noformat}
> When trying to connect to this locator from my laptop I get the following 
> error:
> {noformat}
> gfsh>connect --locator=52.41.104.182[10334]
> Connecting to Locator at [host=52.41.104.182, port=10334] ..
> Connecting to Manager at 
> [host=ec2-52-41-104-182.us-west-2.compute.amazonaws.com, port=1099] ..
> Could not connect to : 
> [host=ec2-52-41-104-182.us-west-2.compute.amazonaws.com, port=1099]. Failed 
> to retrieve RMIServer stub: javax.naming.CommunicationException [Root 
> exception is java.rmi.ConnectIOException: error during JRMP connection 
> establishment; nested exception is:
> java.net.SocketException: Connection reset]
> {noformat}
> Note that gfsh is trying to connect to the public dns for the instance, not 
> using the {{jmx-manager-hostname-for-clients}} property provided.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1548) jmx-manager-hostname-for-clients not honored

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15536803#comment-15536803
 ] 

ASF GitHub Bot commented on GEODE-1548:
---

Github user kirklund commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/248#discussion_r81402616
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/management/internal/security/JavaRmiServerNameJunitTest.java
 ---
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.geode.management.internal.security;
+
+import static org.apache.geode.distributed.ConfigurationProperties.*;
+import static org.junit.Assert.*;
+
+import java.util.Properties;
+
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+import org.apache.geode.cache.CacheFactory;
+import org.apache.geode.internal.AvailablePort;
+import org.apache.geode.test.junit.categories.UnitTest;
+
+@Category(UnitTest.class)
--- End diff --

Since this test is testing more than one class (it's creating a Cache and 
using networking resources), it should have @Category(IntegrationTest.class).


> jmx-manager-hostname-for-clients not honored
> 
>
> Key: GEODE-1548
> URL: https://issues.apache.org/jira/browse/GEODE-1548
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, management
>Reporter: Swapnil Bawaskar
>Assignee: Jared Stewart
>
> While running Geode on AWS, found that {{jmx-manager-hostname-for-clients}} 
> is not being honored resulting in not being able to connect to gfsh from 
> outside AWS.
> I started a locator in AWS with the following command:
> {noformat}
> gfsh>start locator --name=locator 
> --J=-Dgemfire.jmx-manager-hostname-for-clients= 
> --hostname-for-clients=
> {noformat}
> When trying to connect to this locator from my laptop I get the following 
> error:
> {noformat}
> gfsh>connect --locator=52.41.104.182[10334]
> Connecting to Locator at [host=52.41.104.182, port=10334] ..
> Connecting to Manager at 
> [host=ec2-52-41-104-182.us-west-2.compute.amazonaws.com, port=1099] ..
> Could not connect to : 
> [host=ec2-52-41-104-182.us-west-2.compute.amazonaws.com, port=1099]. Failed 
> to retrieve RMIServer stub: javax.naming.CommunicationException [Root 
> exception is java.rmi.ConnectIOException: error during JRMP connection 
> establishment; nested exception is:
> java.net.SocketException: Connection reset]
> {noformat}
> Note that gfsh is trying to connect to the public dns for the instance, not 
> using the {{jmx-manager-hostname-for-clients}} property provided.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1907) QueryDataFunction does not add LIMIT clause if space is missing after FROM clause

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15536419#comment-15536419
 ] 

ASF GitHub Bot commented on GEODE-1907:
---

GitHub user jaredjstewart opened a pull request:

https://github.com/apache/incubator-geode/pull/249

GEODE-1907: QueryDataFunction now adds LIMIT clause if space is missi…

…ng after FROM clause

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jaredjstewart/incubator-geode 
feature/GEODE-1907

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/249.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #249


commit 6fb64a7b671af3054a38610c245f51ab9c30c342
Author: Jared Stewart 
Date:   2016-09-29T19:47:15Z

GEODE-1907: QueryDataFunction now adds LIMIT clause if space is missing 
after FROM clause




> QueryDataFunction does not add LIMIT clause if space is missing after FROM 
> clause
> -
>
> Key: GEODE-1907
> URL: https://issues.apache.org/jira/browse/GEODE-1907
> Project: Geode
>  Issue Type: Bug
>  Components: management, querying
>Reporter: Kirk Lund
>Assignee: Jared Stewart
>Priority: Minor
>
> Apparently "SELECT * FROM/MyRegion" is a valid query in Geode, however if 
> this query is used from GFSH or Pulse, then QueryDataFunction will fail to 
> add a LIMIT clause because there is no space between FROM and the region name.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1548) jmx-manager-hostname-for-clients not honored

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533536#comment-15533536
 ] 

ASF GitHub Bot commented on GEODE-1548:
---

GitHub user jaredjstewart opened a pull request:

https://github.com/apache/incubator-geode/pull/248

GEODE-1548: Specifying --J=-Dgemfire.jmx-manager-hostname-for-clients…

… now automatically sets -Djava.rmi.server.hostname

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jaredjstewart/incubator-geode 
feature/GEODE-1548

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/248.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #248


commit f114abc84c0719c0ee256fce8fb717ccfee8dfa1
Author: Jared Stewart 
Date:   2016-09-29T17:43:30Z

GEODE-1548: Specifying --J=-Dgemfire.jmx-manager-hostname-for-clients now 
automatically sets -Djava.rmi.server.hostname




> jmx-manager-hostname-for-clients not honored
> 
>
> Key: GEODE-1548
> URL: https://issues.apache.org/jira/browse/GEODE-1548
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, management
>Reporter: Swapnil Bawaskar
>Assignee: Jared Stewart
> Fix For: 1.0.0-incubating.M3
>
>
> While running Geode on AWS, found that {{jmx-manager-hostname-for-clients}} 
> is not being honored resulting in not being able to connect to gfsh from 
> outside AWS.
> I started a locator in AWS with the following command:
> {noformat}
> gfsh>start locator --name=locator 
> --J=-Dgemfire.jmx-manager-hostname-for-clients= 
> --hostname-for-clients=
> {noformat}
> When trying to connect to this locator from my laptop I get the following 
> error:
> {noformat}
> gfsh>connect --locator=52.41.104.182[10334]
> Connecting to Locator at [host=52.41.104.182, port=10334] ..
> Connecting to Manager at 
> [host=ec2-52-41-104-182.us-west-2.compute.amazonaws.com, port=1099] ..
> Could not connect to : 
> [host=ec2-52-41-104-182.us-west-2.compute.amazonaws.com, port=1099]. Failed 
> to retrieve RMIServer stub: javax.naming.CommunicationException [Root 
> exception is java.rmi.ConnectIOException: error during JRMP connection 
> establishment; nested exception is:
> java.net.SocketException: Connection reset]
> {noformat}
> Note that gfsh is trying to connect to the public dns for the instance, not 
> using the {{jmx-manager-hostname-for-clients}} property provided.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1905) Address UnknownPropertyException when running tests with Gradle 3.0+

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504245#comment-15504245
 ] 

ASF GitHub Bot commented on GEODE-1905:
---

GitHub user jaredjstewart opened a pull request:

https://github.com/apache/incubator-geode/pull/242

GEODE-1905: Address UnknownPropertyException when running tests with Gradle 
3.0+

AvailablePortFinder was deprecated in [Gradle 
2.8](https://docs.gradle.org/2.8/release-notes#deprecated-classes-and-constants)
 and removed in Gradle 3.0.  

I took a look into how the Gradle project itself dealt with this change, 
and they [use]( 
https://github.com/gradle/gradle/blob/2703311c33e8a295ba7ccb29a62ed8be761ef66f/subprojects/internal-performance-testing/src/main/groovy/org/gradle/performance/fixture/HonestProfilerCollector.groovy)
  the Apache MINA library's 
[org.apache.mina.util.AvailablePortFinder](https://mina.apache.org/mina-project/apidocs/src-html/org/apache/mina/util/AvailablePortFinder.html)
 class.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jaredjstewart/incubator-geode 
feature/GEODE-1905

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/242.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #242


commit a609f86ad662c6d501afd068c68e36a8b302eef3
Author: Jared Stewart 
Date:   2016-09-19T17:37:18Z

GEODE-1905: Address UnknownPropertyException when running tests with Gradle 
3.0+




> Address UnknownPropertyException when running tests with Gradle 3.0+
> 
>
> Key: GEODE-1905
> URL: https://issues.apache.org/jira/browse/GEODE-1905
> Project: Geode
>  Issue Type: Improvement
>Reporter: Jared Stewart
>Assignee: Jared Stewart
>  Labels: build, management
>
> When executing 'gradle test' with a Gradle version >=3.0, the task fails with 
> the following exception:
> {code}
> FAILURE: Build completed with 15 failures.
> 1: Task failed with an exception.
> ---
> * Where:
> Script 'geode/gradle/test.gradle' line: 22
> * What went wrong:
> Execution failed for task ':extensions/geode-modules:test'.
> > Could not get unknown property 'AvailablePortFinder' for root project 
> > 'geode' of type org.gradle.api.Project.
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output.
> ==
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1899) Address the custom 'clean' gradle task warning

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494697#comment-15494697
 ] 

ASF GitHub Bot commented on GEODE-1899:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/240


> Address the custom 'clean' gradle task warning
> --
>
> Key: GEODE-1899
> URL: https://issues.apache.org/jira/browse/GEODE-1899
> Project: Geode
>  Issue Type: Improvement
>  Components: build, management
>Reporter: Jared Stewart
>Assignee: Jared Stewart
>Priority: Minor
>
> Geode cannot be built using the latest release of Gradle: 
> {code}Defining custom 'clean' task when using the standard Gradle lifecycle 
> plugins has been deprecated and is scheduled to be removed in Gradle 3.0{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1899) Address the custom 'clean' gradle task warning

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494679#comment-15494679
 ] 

ASF GitHub Bot commented on GEODE-1899:
---

Github user jinmeiliao commented on the issue:

https://github.com/apache/incubator-geode/pull/240
  
+1


> Address the custom 'clean' gradle task warning
> --
>
> Key: GEODE-1899
> URL: https://issues.apache.org/jira/browse/GEODE-1899
> Project: Geode
>  Issue Type: Improvement
>  Components: build, management
>Reporter: Jared Stewart
>Assignee: Jared Stewart
>Priority: Minor
>
> Geode cannot be built using the latest release of Gradle: 
> {code}Defining custom 'clean' task when using the standard Gradle lifecycle 
> plugins has been deprecated and is scheduled to be removed in Gradle 3.0{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-599) CI Failure: DistributedAckPersistentRegionCCEDUnitTest.testClearWithConcurrentEventsAsync

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494645#comment-15494645
 ] 

ASF GitHub Bot commented on GEODE-599:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/239


> CI Failure: 
> DistributedAckPersistentRegionCCEDUnitTest.testClearWithConcurrentEventsAsync
> -
>
> Key: GEODE-599
> URL: https://issues.apache.org/jira/browse/GEODE-599
> Project: Geode
>  Issue Type: Bug
>  Components: core
>Reporter: Dan Smith
>Assignee: Scott Jewell
>  Labels: CI, Flaky
>
> Revision: 25c8f0cc48e831d6afb459767a42c1c98fb47996
> {noformat}
> junit.framework.AssertionFailedError: region contents are not consistent 
> expected: but was:
>   at junit.framework.Assert.fail(Assert.java:57)
>   at junit.framework.Assert.failNotEquals(Assert.java:329)
>   at junit.framework.Assert.assertEquals(Assert.java:78)
>   at junit.framework.TestCase.assertEquals(TestCase.java:244)
>   at 
> com.gemstone.gemfire.cache30.MultiVMRegionTestCase.z_versionTestClearWithConcurrentEvents(MultiVMRegionTestCase.java:8304)
>   at 
> com.gemstone.gemfire.cache30.MultiVMRegionTestCase.versionTestClearWithConcurrentEventsAsync(MultiVMRegionTestCase.java:8266)
>   at 
> com.gemstone.gemfire.cache30.DistributedAckRegionCCEDUnitTest.testClearWithConcurrentEventsAsync(DistributedAckRegionCCEDUnitTest.java:296)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at junit.framework.TestCase.runTest(TestCase.java:176)
>   at junit.framework.TestCase.runBare(TestCase.java:141)
>   at junit.framework.TestResult$1.protect(TestResult.java:122)
>   at junit.framework.TestResult.runProtected(TestResult.java:142)
>   at junit.framework.TestResult.run(TestResult.java:125)
>   at junit.framework.TestCase.run(TestCase.java:129)
>   at junit.framework.TestSuite.runTest(TestSuite.java:252)
>   at junit.framework.TestSuite.run(TestSuite.java:247)
>   at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:86)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:105)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:56)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:64)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:50)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.messaging.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.messaging.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:106)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.messaging.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:360)
>   at 
> org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
>   at 
> org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> 

[jira] [Commented] (GEODE-599) CI Failure: DistributedAckPersistentRegionCCEDUnitTest.testClearWithConcurrentEventsAsync

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494601#comment-15494601
 ] 

ASF GitHub Bot commented on GEODE-599:
--

Github user dschneider-pivotal commented on the issue:

https://github.com/apache/incubator-geode/pull/239
  
this looks good; I will pull it in


> CI Failure: 
> DistributedAckPersistentRegionCCEDUnitTest.testClearWithConcurrentEventsAsync
> -
>
> Key: GEODE-599
> URL: https://issues.apache.org/jira/browse/GEODE-599
> Project: Geode
>  Issue Type: Bug
>  Components: core
>Reporter: Dan Smith
>Assignee: Scott Jewell
>  Labels: CI, Flaky
>
> Revision: 25c8f0cc48e831d6afb459767a42c1c98fb47996
> {noformat}
> junit.framework.AssertionFailedError: region contents are not consistent 
> expected: but was:
>   at junit.framework.Assert.fail(Assert.java:57)
>   at junit.framework.Assert.failNotEquals(Assert.java:329)
>   at junit.framework.Assert.assertEquals(Assert.java:78)
>   at junit.framework.TestCase.assertEquals(TestCase.java:244)
>   at 
> com.gemstone.gemfire.cache30.MultiVMRegionTestCase.z_versionTestClearWithConcurrentEvents(MultiVMRegionTestCase.java:8304)
>   at 
> com.gemstone.gemfire.cache30.MultiVMRegionTestCase.versionTestClearWithConcurrentEventsAsync(MultiVMRegionTestCase.java:8266)
>   at 
> com.gemstone.gemfire.cache30.DistributedAckRegionCCEDUnitTest.testClearWithConcurrentEventsAsync(DistributedAckRegionCCEDUnitTest.java:296)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at junit.framework.TestCase.runTest(TestCase.java:176)
>   at junit.framework.TestCase.runBare(TestCase.java:141)
>   at junit.framework.TestResult$1.protect(TestResult.java:122)
>   at junit.framework.TestResult.runProtected(TestResult.java:142)
>   at junit.framework.TestResult.run(TestResult.java:125)
>   at junit.framework.TestCase.run(TestCase.java:129)
>   at junit.framework.TestSuite.runTest(TestSuite.java:252)
>   at junit.framework.TestSuite.run(TestSuite.java:247)
>   at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:86)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:105)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:56)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:64)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:50)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.messaging.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.messaging.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:106)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.messaging.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:360)
>   at 
> org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
>   at 
> org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
>   at 
> 

[jira] [Commented] (GEODE-1899) Address the custom 'clean' gradle task warning

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494604#comment-15494604
 ] 

ASF GitHub Bot commented on GEODE-1899:
---

GitHub user jaredjstewart opened a pull request:

https://github.com/apache/incubator-geode/pull/240

GEODE-1899: Renamed the custom 'clean' task to work with Gradle 3.0+



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jaredjstewart/incubator-geode 
feature/GEODE-1899

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/240.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #240


commit 804a1cabc78357bea13844dd767afcc66a7426af
Author: Jared Stewart 
Date:   2016-09-15T20:24:34Z

GEODE-1899: Renamed the custom 'clean' task to work with Gradle 3.0+




> Address the custom 'clean' gradle task warning
> --
>
> Key: GEODE-1899
> URL: https://issues.apache.org/jira/browse/GEODE-1899
> Project: Geode
>  Issue Type: Improvement
>  Components: build, management
>Reporter: Jared Stewart
>Assignee: Jared Stewart
>Priority: Minor
>
> Geode cannot be built using the latest release of Gradle: 
> {code}Defining custom 'clean' task when using the standard Gradle lifecycle 
> plugins has been deprecated and is scheduled to be removed in Gradle 3.0{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-599) CI Failure: DistributedAckPersistentRegionCCEDUnitTest.testClearWithConcurrentEventsAsync

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494500#comment-15494500
 ] 

ASF GitHub Bot commented on GEODE-599:
--

GitHub user gemzdude opened a pull request:

https://github.com/apache/incubator-geode/pull/239

GEODE-599: Remove Flaky annotation from previously failing tests



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gemzdude/incubator-geode feature/GEODE-599

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/239.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #239


commit 002ecafed83d2b32245ae79dac4cb5e8e84b2abc
Author: Scott Jewell 
Date:   2016-09-14T22:54:31Z

GEODE-599: Remove Flaky annotation from previously failing tests

commit 0add81aee7f1126ca8021cd7f84064fa2c11f75e
Author: Scott Jewell 
Date:   2016-09-15T17:35:27Z

Merge remote-tracking branch 'origin/develop' into feature/GEODE-599




> CI Failure: 
> DistributedAckPersistentRegionCCEDUnitTest.testClearWithConcurrentEventsAsync
> -
>
> Key: GEODE-599
> URL: https://issues.apache.org/jira/browse/GEODE-599
> Project: Geode
>  Issue Type: Bug
>  Components: core
>Reporter: Dan Smith
>Assignee: Scott Jewell
>  Labels: CI, Flaky
>
> Revision: 25c8f0cc48e831d6afb459767a42c1c98fb47996
> {noformat}
> junit.framework.AssertionFailedError: region contents are not consistent 
> expected: but was:
>   at junit.framework.Assert.fail(Assert.java:57)
>   at junit.framework.Assert.failNotEquals(Assert.java:329)
>   at junit.framework.Assert.assertEquals(Assert.java:78)
>   at junit.framework.TestCase.assertEquals(TestCase.java:244)
>   at 
> com.gemstone.gemfire.cache30.MultiVMRegionTestCase.z_versionTestClearWithConcurrentEvents(MultiVMRegionTestCase.java:8304)
>   at 
> com.gemstone.gemfire.cache30.MultiVMRegionTestCase.versionTestClearWithConcurrentEventsAsync(MultiVMRegionTestCase.java:8266)
>   at 
> com.gemstone.gemfire.cache30.DistributedAckRegionCCEDUnitTest.testClearWithConcurrentEventsAsync(DistributedAckRegionCCEDUnitTest.java:296)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at junit.framework.TestCase.runTest(TestCase.java:176)
>   at junit.framework.TestCase.runBare(TestCase.java:141)
>   at junit.framework.TestResult$1.protect(TestResult.java:122)
>   at junit.framework.TestResult.runProtected(TestResult.java:142)
>   at junit.framework.TestResult.run(TestResult.java:125)
>   at junit.framework.TestCase.run(TestCase.java:129)
>   at junit.framework.TestSuite.runTest(TestSuite.java:252)
>   at junit.framework.TestSuite.run(TestSuite.java:247)
>   at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:86)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:105)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:56)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:64)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:50)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.messaging.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.messaging.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:106)
>   at 

[jira] [Commented] (GEODE-599) CI Failure: DistributedAckPersistentRegionCCEDUnitTest.testClearWithConcurrentEventsAsync

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494433#comment-15494433
 ] 

ASF GitHub Bot commented on GEODE-599:
--

Github user gemzdude closed the pull request at:

https://github.com/apache/incubator-geode/pull/238


> CI Failure: 
> DistributedAckPersistentRegionCCEDUnitTest.testClearWithConcurrentEventsAsync
> -
>
> Key: GEODE-599
> URL: https://issues.apache.org/jira/browse/GEODE-599
> Project: Geode
>  Issue Type: Bug
>  Components: core
>Reporter: Dan Smith
>Assignee: Scott Jewell
>  Labels: CI, Flaky
>
> Revision: 25c8f0cc48e831d6afb459767a42c1c98fb47996
> {noformat}
> junit.framework.AssertionFailedError: region contents are not consistent 
> expected: but was:
>   at junit.framework.Assert.fail(Assert.java:57)
>   at junit.framework.Assert.failNotEquals(Assert.java:329)
>   at junit.framework.Assert.assertEquals(Assert.java:78)
>   at junit.framework.TestCase.assertEquals(TestCase.java:244)
>   at 
> com.gemstone.gemfire.cache30.MultiVMRegionTestCase.z_versionTestClearWithConcurrentEvents(MultiVMRegionTestCase.java:8304)
>   at 
> com.gemstone.gemfire.cache30.MultiVMRegionTestCase.versionTestClearWithConcurrentEventsAsync(MultiVMRegionTestCase.java:8266)
>   at 
> com.gemstone.gemfire.cache30.DistributedAckRegionCCEDUnitTest.testClearWithConcurrentEventsAsync(DistributedAckRegionCCEDUnitTest.java:296)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at junit.framework.TestCase.runTest(TestCase.java:176)
>   at junit.framework.TestCase.runBare(TestCase.java:141)
>   at junit.framework.TestResult$1.protect(TestResult.java:122)
>   at junit.framework.TestResult.runProtected(TestResult.java:142)
>   at junit.framework.TestResult.run(TestResult.java:125)
>   at junit.framework.TestCase.run(TestCase.java:129)
>   at junit.framework.TestSuite.runTest(TestSuite.java:252)
>   at junit.framework.TestSuite.run(TestSuite.java:247)
>   at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:86)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:105)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:56)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:64)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:50)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.messaging.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.messaging.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:106)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.messaging.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:360)
>   at 
> org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
>   at 
> org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 

[jira] [Commented] (GEODE-1821) CI Failure: PersistentColocatedPartitionedRegionDUnitTest.testFullTreeOfColocatedChildPRsWithMissingRegions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15468757#comment-15468757
 ] 

ASF GitHub Bot commented on GEODE-1821:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/237


> CI Failure: 
> PersistentColocatedPartitionedRegionDUnitTest.testFullTreeOfColocatedChildPRsWithMissingRegions
> ---
>
> Key: GEODE-1821
> URL: https://issues.apache.org/jira/browse/GEODE-1821
> Project: Geode
>  Issue Type: Bug
>  Components: persistence, regions
>Reporter: Anilkumar Gingade
>Assignee: Kenneth Howe
>
> Build #3755 (Aug 24, 2016 5:09:20 AM)
> Revision: 37269735eec44f51ee53075718afe2fa85edc22e
> refs/remotes/origin/develop
> Error Message
> java.util.concurrent.TimeoutException: Timed out waiting 3 milliseconds 
> for AsyncInvocation to complete.
> Stacktrace
> java.util.concurrent.TimeoutException: Timed out waiting 3 milliseconds 
> for AsyncInvocation to complete.
>   at 
> com.gemstone.gemfire.test.dunit.AsyncInvocation.timeoutIfAlive(AsyncInvocation.java:443)
>   at 
> com.gemstone.gemfire.test.dunit.AsyncInvocation.get(AsyncInvocation.java:390)
>   at 
> com.gemstone.gemfire.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest.testFullTreeOfColocatedChildPRsWithMissingRegions(PersistentColocatedPartitionedRegionDUnitTest.java:1197)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   

[jira] [Commented] (GEODE-1821) CI Failure: PersistentColocatedPartitionedRegionDUnitTest.testFullTreeOfColocatedChildPRsWithMissingRegions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15468722#comment-15468722
 ] 

ASF GitHub Bot commented on GEODE-1821:
---

Github user dschneider-pivotal commented on the issue:

https://github.com/apache/incubator-geode/pull/237
  
This looks good. I will pull it in


> CI Failure: 
> PersistentColocatedPartitionedRegionDUnitTest.testFullTreeOfColocatedChildPRsWithMissingRegions
> ---
>
> Key: GEODE-1821
> URL: https://issues.apache.org/jira/browse/GEODE-1821
> Project: Geode
>  Issue Type: Bug
>  Components: persistence, regions
>Reporter: Anilkumar Gingade
>Assignee: Kenneth Howe
>
> Build #3755 (Aug 24, 2016 5:09:20 AM)
> Revision: 37269735eec44f51ee53075718afe2fa85edc22e
> refs/remotes/origin/develop
> Error Message
> java.util.concurrent.TimeoutException: Timed out waiting 3 milliseconds 
> for AsyncInvocation to complete.
> Stacktrace
> java.util.concurrent.TimeoutException: Timed out waiting 3 milliseconds 
> for AsyncInvocation to complete.
>   at 
> com.gemstone.gemfire.test.dunit.AsyncInvocation.timeoutIfAlive(AsyncInvocation.java:443)
>   at 
> com.gemstone.gemfire.test.dunit.AsyncInvocation.get(AsyncInvocation.java:390)
>   at 
> com.gemstone.gemfire.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest.testFullTreeOfColocatedChildPRsWithMissingRegions(PersistentColocatedPartitionedRegionDUnitTest.java:1197)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
>   at 

[jira] [Commented] (GEODE-1821) CI Failure: PersistentColocatedPartitionedRegionDUnitTest.testFullTreeOfColocatedChildPRsWithMissingRegions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15459864#comment-15459864
 ] 

ASF GitHub Bot commented on GEODE-1821:
---

GitHub user pdxrunner opened a pull request:

https://github.com/apache/incubator-geode/pull/237

GEODE-1821: fix termination of invokeAsync threads



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pdxrunner/incubator-geode feature/GEODE-1821

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/237.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #237


commit 699f8ab61420f8ff3a1611856b0ebeeaab617904
Author: Ken Howe 
Date:   2016-08-26T20:03:44Z

GEODE-1821: fix termination of invokeAsync threads




> CI Failure: 
> PersistentColocatedPartitionedRegionDUnitTest.testFullTreeOfColocatedChildPRsWithMissingRegions
> ---
>
> Key: GEODE-1821
> URL: https://issues.apache.org/jira/browse/GEODE-1821
> Project: Geode
>  Issue Type: Bug
>  Components: persistence, regions
>Reporter: Anilkumar Gingade
>Assignee: Kenneth Howe
>
> Build #3755 (Aug 24, 2016 5:09:20 AM)
> Revision: 37269735eec44f51ee53075718afe2fa85edc22e
> refs/remotes/origin/develop
> Error Message
> java.util.concurrent.TimeoutException: Timed out waiting 3 milliseconds 
> for AsyncInvocation to complete.
> Stacktrace
> java.util.concurrent.TimeoutException: Timed out waiting 3 milliseconds 
> for AsyncInvocation to complete.
>   at 
> com.gemstone.gemfire.test.dunit.AsyncInvocation.timeoutIfAlive(AsyncInvocation.java:443)
>   at 
> com.gemstone.gemfire.test.dunit.AsyncInvocation.get(AsyncInvocation.java:390)
>   at 
> com.gemstone.gemfire.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest.testFullTreeOfColocatedChildPRsWithMissingRegions(PersistentColocatedPartitionedRegionDUnitTest.java:1197)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> 

[jira] [Commented] (GEODE-1818) Bug37377DUnitTest passes with NPE suspect strings in log

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15453932#comment-15453932
 ] 

ASF GitHub Bot commented on GEODE-1818:
---

Github user upthewaterspout commented on the issue:

https://github.com/apache/incubator-geode/pull/235
  
It would be nice to rename this test to something other than 
Bug37377DUnitTest, since no one knows what that means.


> Bug37377DUnitTest passes with NPE suspect strings in log
> 
>
> Key: GEODE-1818
> URL: https://issues.apache.org/jira/browse/GEODE-1818
> Project: Geode
>  Issue Type: Bug
>  Components: tests
>Reporter: Scott Jewell
>
> This test appears to pass but in fact is not working properly.
> The following messages appear in the log:
> [vm_1]java.lang.NullPointerException
> [vm_1]at Remote Member 'india(26730):32771' in 
> com.gemstone.gemfire.internal.cache.AbstractRegionMap.processVersionTagForGII(AbstractRegionMap.java:540)
> [vm_1]at Remote Member 'india(26730):32771' in 
> com.gemstone.gemfire.internal.cache.AbstractRegionMap.initialImagePut(AbstractRegionMap.java:931)
> [vm_1]at Remote Member 'india(26730):32771' in 
> com.gemstone.gemfire.internal.cache.InitialImageOperation.processChunk(InitialImageOperation.java:915)
> [vm_1]at Remote Member 'india(26730):32771' in 
> com.gemstone.gemfire.internal.cache.InitialImageOperation$ImageProcessor.process(InitialImageOperation.java:1222)
> [vm_1]at Remote Member 'india(26730):32771' in 
> com.gemstone.gemfire.distributed.internal.ReplyMessage.process(ReplyMessage.java:225)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1818) Bug37377DUnitTest passes with NPE suspect strings in log

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15453861#comment-15453861
 ] 

ASF GitHub Bot commented on GEODE-1818:
---

Github user dschneider-pivotal commented on the issue:

https://github.com/apache/incubator-geode/pull/235
  
this looks good. I will pull it in


> Bug37377DUnitTest passes with NPE suspect strings in log
> 
>
> Key: GEODE-1818
> URL: https://issues.apache.org/jira/browse/GEODE-1818
> Project: Geode
>  Issue Type: Bug
>  Components: tests
>Reporter: Scott Jewell
>
> This test appears to pass but in fact is not working properly.
> The following messages appear in the log:
> [vm_1]java.lang.NullPointerException
> [vm_1]at Remote Member 'india(26730):32771' in 
> com.gemstone.gemfire.internal.cache.AbstractRegionMap.processVersionTagForGII(AbstractRegionMap.java:540)
> [vm_1]at Remote Member 'india(26730):32771' in 
> com.gemstone.gemfire.internal.cache.AbstractRegionMap.initialImagePut(AbstractRegionMap.java:931)
> [vm_1]at Remote Member 'india(26730):32771' in 
> com.gemstone.gemfire.internal.cache.InitialImageOperation.processChunk(InitialImageOperation.java:915)
> [vm_1]at Remote Member 'india(26730):32771' in 
> com.gemstone.gemfire.internal.cache.InitialImageOperation$ImageProcessor.process(InitialImageOperation.java:1222)
> [vm_1]at Remote Member 'india(26730):32771' in 
> com.gemstone.gemfire.distributed.internal.ReplyMessage.process(ReplyMessage.java:225)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1818) Bug37377DUnitTest passes with NPE suspect strings in log

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15453456#comment-15453456
 ] 

ASF GitHub Bot commented on GEODE-1818:
---

GitHub user gemzdude opened a pull request:

https://github.com/apache/incubator-geode/pull/235

GEODE-1818: Bug37377DUnitTest passes with NPE suspect strings in log

This is an older test which had experienced some severe "code rot".

Modified code to conform to current product behavior.
Removed use of internal APIs and dummy remote clear event from test.
Updated remote method execution to utilize new lambda technique.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gemzdude/incubator-geode develop

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/235.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #235


commit 58ea56aeba4cfa4b1a45d9f0242284823af42385
Author: Scott Jewell 
Date:   2016-08-31T17:54:05Z

GEODE-1818: Bug37377DUnitTest passes with NPE suspect strings in log




> Bug37377DUnitTest passes with NPE suspect strings in log
> 
>
> Key: GEODE-1818
> URL: https://issues.apache.org/jira/browse/GEODE-1818
> Project: Geode
>  Issue Type: Bug
>  Components: tests
>Reporter: Scott Jewell
>
> This test appears to pass but in fact is not working properly.
> The following messages appear in the log:
> [vm_1]java.lang.NullPointerException
> [vm_1]at Remote Member 'india(26730):32771' in 
> com.gemstone.gemfire.internal.cache.AbstractRegionMap.processVersionTagForGII(AbstractRegionMap.java:540)
> [vm_1]at Remote Member 'india(26730):32771' in 
> com.gemstone.gemfire.internal.cache.AbstractRegionMap.initialImagePut(AbstractRegionMap.java:931)
> [vm_1]at Remote Member 'india(26730):32771' in 
> com.gemstone.gemfire.internal.cache.InitialImageOperation.processChunk(InitialImageOperation.java:915)
> [vm_1]at Remote Member 'india(26730):32771' in 
> com.gemstone.gemfire.internal.cache.InitialImageOperation$ImageProcessor.process(InitialImageOperation.java:1222)
> [vm_1]at Remote Member 'india(26730):32771' in 
> com.gemstone.gemfire.distributed.internal.ReplyMessage.process(ReplyMessage.java:225)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1617) Regions can be created with a variety of characters that are unsupported

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435736#comment-15435736
 ] 

ASF GitHub Bot commented on GEODE-1617:
---

Github user joeymcallister commented on the issue:

https://github.com/apache/incubator-geode/pull/201
  
@seankarson @kjduling The document has been updated. Thanks for the heads 
up!


> Regions can be created with a variety of characters that are unsupported
> 
>
> Key: GEODE-1617
> URL: https://issues.apache.org/jira/browse/GEODE-1617
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Affects Versions: 1.0.0-incubating.M2
>Reporter: Kevin Duling
>Assignee: Kevin Duling
>
> Per this 
> [thread|https://www.mail-archive.com/dev@geode.incubator.apache.org/msg04046.html],
>  and this 
> [thread|https://www.mail-archive.com/dev@geode.incubator.apache.org/msg07079.html]
>  on the dev forums and [geode 
> documentation|http://docs-geode-develop.cfapps.io/docs/basic_config/data_regions/region_naming.html],
>  region names may only consist of alphanumeric characters, an underscore, and 
> a hyphen.  These rules are not enforced.
> E.g., it is possible to create a region with:
> {{gfsh> create region --name=not^good --type=REPLICATE}}
> Some of these regions may be removed with the {{destroy}} command, while 
> others cannot be located.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1617) Regions can be created with a variety of characters that are unsupported

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435169#comment-15435169
 ] 

ASF GitHub Bot commented on GEODE-1617:
---

Github user kjduling commented on the issue:

https://github.com/apache/incubator-geode/pull/201
  
Good catch.

@davebarnes97 @karensmolermiller Can either of you follow up on this?  
Looks like we've a page out of date.


> Regions can be created with a variety of characters that are unsupported
> 
>
> Key: GEODE-1617
> URL: https://issues.apache.org/jira/browse/GEODE-1617
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Affects Versions: 1.0.0-incubating.M2
>Reporter: Kevin Duling
>Assignee: Kevin Duling
>
> Per this 
> [thread|https://www.mail-archive.com/dev@geode.incubator.apache.org/msg04046.html],
>  and this 
> [thread|https://www.mail-archive.com/dev@geode.incubator.apache.org/msg07079.html]
>  on the dev forums and [geode 
> documentation|http://docs-geode-develop.cfapps.io/docs/basic_config/data_regions/region_naming.html],
>  region names may only consist of alphanumeric characters, an underscore, and 
> a hyphen.  These rules are not enforced.
> E.g., it is possible to create a region with:
> {{gfsh> create region --name=not^good --type=REPLICATE}}
> Some of these regions may be removed with the {{destroy}} command, while 
> others cannot be located.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1617) Regions can be created with a variety of characters that are unsupported

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435113#comment-15435113
 ] 

ASF GitHub Bot commented on GEODE-1617:
---

Github user seankarson commented on the issue:

https://github.com/apache/incubator-geode/pull/201
  
The example in the docs for how to create a dynamic region on the server no 
longer works in M3 due to this fix.


http://geode.docs.pivotal.io/docs/developing/region_options/dynamic_region_creation.html

Removing an underscore from "__regionAttributesMetadata" does the trick.

I'm happy to make a PR against the docs to fix this, but it doesn't seem 
like there is an M3 branch


> Regions can be created with a variety of characters that are unsupported
> 
>
> Key: GEODE-1617
> URL: https://issues.apache.org/jira/browse/GEODE-1617
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Affects Versions: 1.0.0-incubating.M2
>Reporter: Kevin Duling
>Assignee: Kevin Duling
>
> Per this 
> [thread|https://www.mail-archive.com/dev@geode.incubator.apache.org/msg04046.html],
>  and this 
> [thread|https://www.mail-archive.com/dev@geode.incubator.apache.org/msg07079.html]
>  on the dev forums and [geode 
> documentation|http://docs-geode-develop.cfapps.io/docs/basic_config/data_regions/region_naming.html],
>  region names may only consist of alphanumeric characters, an underscore, and 
> a hyphen.  These rules are not enforced.
> E.g., it is possible to create a region with:
> {{gfsh> create region --name=not^good --type=REPLICATE}}
> Some of these regions may be removed with the {{destroy}} command, while 
> others cannot be located.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1128) Add log messages and enhance the output of list-missing-disk-stores to report missing colocated regions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427364#comment-15427364
 ] 

ASF GitHub Bot commented on GEODE-1128:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/234


> Add log messages and enhance the output of list-missing-disk-stores to report 
> missing colocated regions
> ---
>
> Key: GEODE-1128
> URL: https://issues.apache.org/jira/browse/GEODE-1128
> Project: Geode
>  Issue Type: Bug
>  Components: persistence
>Reporter: Dan Smith
>Assignee: Kenneth Howe
>
> Persistent recovery waits until all colocated regions are created. This is 
> necessary in order to maintain colocation. However, it can result in 
> surprising behavior if a user doesn't create a region or, in the case of 
> GEODE-1117, geode doesn't create an internal region.
> We need a warning level log message indicating that some colocated regions 
> are missing. We do have a log message after 15 seconds if other members have 
> not created persistent regions - see the code in 
> RedundancyLogger.logWaitingForMembers.
> We should enhance the logger to report any missing colocated regions as well.
> The list-missing-disk-stores command should also be enhanced to report 
> missing colocated regions



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1128) Add log messages and enhance the output of list-missing-disk-stores to report missing colocated regions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427346#comment-15427346
 ] 

ASF GitHub Bot commented on GEODE-1128:
---

Github user dschneider-pivotal commented on the issue:

https://github.com/apache/incubator-geode/pull/234
  
this looks good, I will pull it in


> Add log messages and enhance the output of list-missing-disk-stores to report 
> missing colocated regions
> ---
>
> Key: GEODE-1128
> URL: https://issues.apache.org/jira/browse/GEODE-1128
> Project: Geode
>  Issue Type: Bug
>  Components: persistence
>Reporter: Dan Smith
>Assignee: Kenneth Howe
>
> Persistent recovery waits until all colocated regions are created. This is 
> necessary in order to maintain colocation. However, it can result in 
> surprising behavior if a user doesn't create a region or, in the case of 
> GEODE-1117, geode doesn't create an internal region.
> We need a warning level log message indicating that some colocated regions 
> are missing. We do have a log message after 15 seconds if other members have 
> not created persistent regions - see the code in 
> RedundancyLogger.logWaitingForMembers.
> We should enhance the logger to report any missing colocated regions as well.
> The list-missing-disk-stores command should also be enhanced to report 
> missing colocated regions



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1128) Add log messages and enhance the output of list-missing-disk-stores to report missing colocated regions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427280#comment-15427280
 ] 

ASF GitHub Bot commented on GEODE-1128:
---

GitHub user pdxrunner opened a pull request:

https://github.com/apache/incubator-geode/pull/234

GEODE-1128: Fixes for colocation configuration problems

1) Test parent regions on child region creates and throw 
IllegalStateException
if parent region does not exist.
Missing parent regions were not being checked for, which resulted in NPE's 
getting thrown.

2) Log warnings when persistent colocated child regions don't exist.
Persistent data recovery cannot complete for any region in a colocation 
hierarchy if there are child regions that don't exist. The absence of any 
warning logs for this condition made it difficult to diagnose configuration 
problems.

3) Create Unit and DUnit tests for new exceptions and warnings

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pdxrunner/incubator-geode feature/GEODE-1128

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/234.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #234


commit fd6b6b1c52f81977c990259853c2dd996f3a280d
Author: Ken Howe 
Date:   2016-08-18T22:00:22Z

GEODE-1128: Fixes for colocation configuration problems

Test parent regions on child region creates and throw IllegalStateException
if parent region does not exist

Log warnings when persistent colocated child regions don't exist

Create Unit and DUnit tests for new exceptions and warnings




> Add log messages and enhance the output of list-missing-disk-stores to report 
> missing colocated regions
> ---
>
> Key: GEODE-1128
> URL: https://issues.apache.org/jira/browse/GEODE-1128
> Project: Geode
>  Issue Type: Bug
>  Components: persistence
>Reporter: Dan Smith
>Assignee: Kenneth Howe
>
> Persistent recovery waits until all colocated regions are created. This is 
> necessary in order to maintain colocation. However, it can result in 
> surprising behavior if a user doesn't create a region or, in the case of 
> GEODE-1117, geode doesn't create an internal region.
> We need a warning level log message indicating that some colocated regions 
> are missing. We do have a log message after 15 seconds if other members have 
> not created persistent regions - see the code in 
> RedundancyLogger.logWaitingForMembers.
> We should enhance the logger to report any missing colocated regions as well.
> The list-missing-disk-stores command should also be enhanced to report 
> missing colocated regions



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-599) CI Failure: DistributedAckPersistentRegionCCEDUnitTest.testClearWithConcurrentEventsAsync

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15423244#comment-15423244
 ] 

ASF GitHub Bot commented on GEODE-599:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/232


> CI Failure: 
> DistributedAckPersistentRegionCCEDUnitTest.testClearWithConcurrentEventsAsync
> -
>
> Key: GEODE-599
> URL: https://issues.apache.org/jira/browse/GEODE-599
> Project: Geode
>  Issue Type: Bug
>  Components: core
>Reporter: Dan Smith
>Assignee: Scott Jewell
>  Labels: CI, Flaky
>
> Revision: 25c8f0cc48e831d6afb459767a42c1c98fb47996
> {noformat}
> junit.framework.AssertionFailedError: region contents are not consistent 
> expected: but was:
>   at junit.framework.Assert.fail(Assert.java:57)
>   at junit.framework.Assert.failNotEquals(Assert.java:329)
>   at junit.framework.Assert.assertEquals(Assert.java:78)
>   at junit.framework.TestCase.assertEquals(TestCase.java:244)
>   at 
> com.gemstone.gemfire.cache30.MultiVMRegionTestCase.z_versionTestClearWithConcurrentEvents(MultiVMRegionTestCase.java:8304)
>   at 
> com.gemstone.gemfire.cache30.MultiVMRegionTestCase.versionTestClearWithConcurrentEventsAsync(MultiVMRegionTestCase.java:8266)
>   at 
> com.gemstone.gemfire.cache30.DistributedAckRegionCCEDUnitTest.testClearWithConcurrentEventsAsync(DistributedAckRegionCCEDUnitTest.java:296)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at junit.framework.TestCase.runTest(TestCase.java:176)
>   at junit.framework.TestCase.runBare(TestCase.java:141)
>   at junit.framework.TestResult$1.protect(TestResult.java:122)
>   at junit.framework.TestResult.runProtected(TestResult.java:142)
>   at junit.framework.TestResult.run(TestResult.java:125)
>   at junit.framework.TestCase.run(TestCase.java:129)
>   at junit.framework.TestSuite.runTest(TestSuite.java:252)
>   at junit.framework.TestSuite.run(TestSuite.java:247)
>   at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:86)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:105)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:56)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:64)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:50)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.messaging.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.messaging.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:106)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.messaging.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:360)
>   at 
> org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
>   at 
> org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> 

[jira] [Commented] (GEODE-599) CI Failure: DistributedAckPersistentRegionCCEDUnitTest.testClearWithConcurrentEventsAsync

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15421528#comment-15421528
 ] 

ASF GitHub Bot commented on GEODE-599:
--

GitHub user gemzdude opened a pull request:

https://github.com/apache/incubator-geode/pull/232

Feature/geode 599

GEODE-599 CI Failure: 
DistributedAckPersistentRegionCCEDUnitTest.testClearWithConcurrentEventsAsync

Region consistency errors possible with region clear and concurrent 
operations.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gemzdude/incubator-geode feature/GEODE-599

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/232.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #232


commit f87e2f4ecad1b9f96d1a164bf2b03e5705fa1243
Author: Scott Jewell 
Date:   2016-07-08T22:52:03Z

GEODE-599: CI Failure: 
DistributedAckPersistentRegionCCEDUnitTest.testClearWithConcurrentEventsAsync

Cache modification lock was being released before operation distribution to 
other members.
This provided a small window in which an operation from another thread 
could update the
region prior to the other members receiving notification (i.e. down leveled)

commit bfbbfd536946543b78003ee2c4bc50b8d1972276
Author: Scott Jewell 
Date:   2016-07-12T18:05:04Z

GEODE-599: CI Failure: 
DistributedAckPersistentRegionCCEDUnitTest.testClearWithConcurrentEventsAsync 
region inconsistencies




> CI Failure: 
> DistributedAckPersistentRegionCCEDUnitTest.testClearWithConcurrentEventsAsync
> -
>
> Key: GEODE-599
> URL: https://issues.apache.org/jira/browse/GEODE-599
> Project: Geode
>  Issue Type: Bug
>  Components: core
>Reporter: Dan Smith
>Assignee: Darrel Schneider
>  Labels: CI, Flaky
>
> Revision: 25c8f0cc48e831d6afb459767a42c1c98fb47996
> {noformat}
> junit.framework.AssertionFailedError: region contents are not consistent 
> expected: but was:
>   at junit.framework.Assert.fail(Assert.java:57)
>   at junit.framework.Assert.failNotEquals(Assert.java:329)
>   at junit.framework.Assert.assertEquals(Assert.java:78)
>   at junit.framework.TestCase.assertEquals(TestCase.java:244)
>   at 
> com.gemstone.gemfire.cache30.MultiVMRegionTestCase.z_versionTestClearWithConcurrentEvents(MultiVMRegionTestCase.java:8304)
>   at 
> com.gemstone.gemfire.cache30.MultiVMRegionTestCase.versionTestClearWithConcurrentEventsAsync(MultiVMRegionTestCase.java:8266)
>   at 
> com.gemstone.gemfire.cache30.DistributedAckRegionCCEDUnitTest.testClearWithConcurrentEventsAsync(DistributedAckRegionCCEDUnitTest.java:296)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at junit.framework.TestCase.runTest(TestCase.java:176)
>   at junit.framework.TestCase.runBare(TestCase.java:141)
>   at junit.framework.TestResult$1.protect(TestResult.java:122)
>   at junit.framework.TestResult.runProtected(TestResult.java:142)
>   at junit.framework.TestResult.run(TestResult.java:125)
>   at junit.framework.TestCase.run(TestCase.java:129)
>   at junit.framework.TestSuite.runTest(TestSuite.java:252)
>   at junit.framework.TestSuite.run(TestSuite.java:247)
>   at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:86)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:105)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:56)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:64)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:50)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> 

[jira] [Commented] (GEODE-1744) Probable Bugs from == use

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419667#comment-15419667
 ] 

ASF GitHub Bot commented on GEODE-1744:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/230


> Probable Bugs from == use
> -
>
> Key: GEODE-1744
> URL: https://issues.apache.org/jira/browse/GEODE-1744
> Project: Geode
>  Issue Type: Bug
>Reporter: Grace Meilen
>Assignee: Grace Meilen
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1673) SampleSecurityManager should cause start to fail if security.json cannot be found

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419638#comment-15419638
 ] 

ASF GitHub Bot commented on GEODE-1673:
---

Github user gracemeilen closed the pull request at:

https://github.com/apache/incubator-geode/pull/228


> SampleSecurityManager should cause start to fail if security.json cannot be 
> found
> -
>
> Key: GEODE-1673
> URL: https://issues.apache.org/jira/browse/GEODE-1673
> Project: Geode
>  Issue Type: Bug
>  Components: security
>Reporter: Kirk Lund
>Assignee: Grace Meilen
> Fix For: 1.0.0-incubating
>
>
> When following the instructions on 
> https://cwiki.apache.org/confluence/display/GEODE/Using+Custom+SecurityManager,
>  if the user forgets to specify "--classpath=." then the locator will start 
> up but cannot be connected to.
> The SampleSecurityManager should instead cause the start to fail if 
> security.json cannot be found.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1648) Provide ability to disable security for some components

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419573#comment-15419573
 ] 

ASF GitHub Bot commented on GEODE-1648:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/224


> Provide ability to disable security for some components
> ---
>
> Key: GEODE-1648
> URL: https://issues.apache.org/jira/browse/GEODE-1648
> Project: Geode
>  Issue Type: Sub-task
>  Components: security
>Reporter: Swapnil Bawaskar
>Assignee: Grace Meilen
>
> When the new {{SecurityManager}} interface is used, it will enable 
> authentication and authorization for client-server, jmx, peer-to-peer and 
> WAN. Not all users will want authentication and authorization for all these 
> components as explained in this comment: 
> https://issues.apache.org/jira/browse/GEODE-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369089#comment-15369089
> We should add new geode properties:
> {noformat}
> enable-peer-to-peer-authentication
> enable-client-server-security
> enable-msnsgement-security
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1744) Probable Bugs from == use

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419131#comment-15419131
 ] 

ASF GitHub Bot commented on GEODE-1744:
---

Github user gracemeilen commented on the issue:

https://github.com/apache/incubator-geode/pull/230
  
Checked in a fix due to a unit test failing


> Probable Bugs from == use
> -
>
> Key: GEODE-1744
> URL: https://issues.apache.org/jira/browse/GEODE-1744
> Project: Geode
>  Issue Type: Bug
>Reporter: Grace Meilen
>Assignee: Grace Meilen
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1744) Probable Bugs from == use

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417992#comment-15417992
 ] 

ASF GitHub Bot commented on GEODE-1744:
---

Github user gracemeilen commented on the issue:

https://github.com/apache/incubator-geode/pull/230
  
Updated this to use StringUtils, added unit tests to verify


> Probable Bugs from == use
> -
>
> Key: GEODE-1744
> URL: https://issues.apache.org/jira/browse/GEODE-1744
> Project: Geode
>  Issue Type: Bug
>Reporter: Grace Meilen
>Assignee: Grace Meilen
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1744) Probable Bugs from == use

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417492#comment-15417492
 ] 

ASF GitHub Bot commented on GEODE-1744:
---

Github user kjduling commented on the issue:

https://github.com/apache/incubator-geode/pull/230
  
No existing test exposed this.  This is in reaction to a code analysis.  
Case by case, the code may or may not be doing what the developer intended 
because of the nature of == vs .equals().  If the == test is true, then the 
.equals() test must also be true.  However, just because == is false does not 
mean .equals() is not true.

Existing testing did not reveal this.  I'll work with Grace to come up with 
tests to verify.


> Probable Bugs from == use
> -
>
> Key: GEODE-1744
> URL: https://issues.apache.org/jira/browse/GEODE-1744
> Project: Geode
>  Issue Type: Bug
>Reporter: Grace Meilen
>Assignee: Grace Meilen
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1744) Probable Bugs from == use

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416117#comment-15416117
 ] 

ASF GitHub Bot commented on GEODE-1744:
---

Github user kjduling commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/230#discussion_r74340943
  
--- Diff: 
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/AbstractCliAroundInterceptor.java
 ---
@@ -88,7 +88,7 @@ protected Response readYesNo(String message, Response 
defaultResponse) {
   try {
 String userInput = interact(message);
 
-if (userInput == null || userInput == "") {
+if (userInput.isEmpty()) {
--- End diff --

Here you need to keep the null check or it could throw an NPE, so:
  if (userInput == null || userInput.isEmpty()) {



> Probable Bugs from == use
> -
>
> Key: GEODE-1744
> URL: https://issues.apache.org/jira/browse/GEODE-1744
> Project: Geode
>  Issue Type: Bug
>Reporter: Grace Meilen
>Assignee: Grace Meilen
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1744) Probable Bugs from == use

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416106#comment-15416106
 ] 

ASF GitHub Bot commented on GEODE-1744:
---

Github user kjduling commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/230#discussion_r74340020
  
--- Diff: 
geode-core/src/main/java/com/gemstone/gemfire/admin/AlertLevel.java ---
@@ -145,8 +147,8 @@ public boolean equals(Object other) {
final AlertLevel that = (AlertLevel) other;
 
if (this.severity != that.severity) return false;
-   if (this.name != that.name &&
-   !(this.name != null &&
+   if (!Objects.equals(this.name, that.name) &&
+!(this.name != null &&
this.name.equals(that.name))) return false;
 
--- End diff --

Yep, absolutely correct.


> Probable Bugs from == use
> -
>
> Key: GEODE-1744
> URL: https://issues.apache.org/jira/browse/GEODE-1744
> Project: Geode
>  Issue Type: Bug
>Reporter: Grace Meilen
>Assignee: Grace Meilen
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1744) Probable Bugs from == use

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416085#comment-15416085
 ] 

ASF GitHub Bot commented on GEODE-1744:
---

Github user kjduling commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/230#discussion_r74338007
  
--- Diff: 
geode-core/src/main/java/com/gemstone/gemfire/admin/AlertLevel.java ---
@@ -145,8 +147,8 @@ public boolean equals(Object other) {
final AlertLevel that = (AlertLevel) other;
 
if (this.severity != that.severity) return false;
-   if (this.name != that.name &&
-   !(this.name != null &&
+   if (!Objects.equals(this.name, that.name) &&
+!(this.name != null &&
this.name.equals(that.name))) return false;
 
--- End diff --

I think that the point of this code is to compare whether or not the 
'other' name is the equivalent string to this.name.  A better way to test for 
that is to move the NPE check up, then compare:

if (this.name != null && 
this.name.equals(that.name)) return false;


> Probable Bugs from == use
> -
>
> Key: GEODE-1744
> URL: https://issues.apache.org/jira/browse/GEODE-1744
> Project: Geode
>  Issue Type: Bug
>Reporter: Grace Meilen
>Assignee: Grace Meilen
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1744) Probable Bugs from == use

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416095#comment-15416095
 ] 

ASF GitHub Bot commented on GEODE-1744:
---

Github user metatype commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/230#discussion_r74339073
  
--- Diff: 
geode-core/src/main/java/com/gemstone/gemfire/admin/AlertLevel.java ---
@@ -145,8 +147,8 @@ public boolean equals(Object other) {
final AlertLevel that = (AlertLevel) other;
 
if (this.severity != that.severity) return false;
-   if (this.name != that.name &&
-   !(this.name != null &&
+   if (!Objects.equals(this.name, that.name) &&
+!(this.name != null &&
this.name.equals(that.name))) return false;
 
--- End diff --

@kjduling I think you need a `!` in there somewhere.


> Probable Bugs from == use
> -
>
> Key: GEODE-1744
> URL: https://issues.apache.org/jira/browse/GEODE-1744
> Project: Geode
>  Issue Type: Bug
>Reporter: Grace Meilen
>Assignee: Grace Meilen
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1744) Probable Bugs from == use

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416093#comment-15416093
 ] 

ASF GitHub Bot commented on GEODE-1744:
---

Github user metatype commented on the issue:

https://github.com/apache/incubator-geode/pull/230
  
Is there a test that exposes the probable bug and verifies that the issue 
is fixed?


> Probable Bugs from == use
> -
>
> Key: GEODE-1744
> URL: https://issues.apache.org/jira/browse/GEODE-1744
> Project: Geode
>  Issue Type: Bug
>Reporter: Grace Meilen
>Assignee: Grace Meilen
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1744) Probable Bugs from == use

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416037#comment-15416037
 ] 

ASF GitHub Bot commented on GEODE-1744:
---

GitHub user gracemeilen opened a pull request:

https://github.com/apache/incubator-geode/pull/230

GEODE-1744: Probable bugs from == use fixed



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gracemeilen/incubator-geode feature/GEODE-1744

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/230.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #230


commit 5f1077151108acdbab6b7459f175c48e10cf7cba
Author: gmeilen 
Date:   2016-08-09T16:48:32Z

GEODE-1648: Introduce security-enabled-components and tests

commit 4edd4569ada4ac706800c55d860850145822355b
Author: gmeilen 
Date:   2016-08-10T21:18:32Z

GEODE-1744:Probable bugs from == use fixed




> Probable Bugs from == use
> -
>
> Key: GEODE-1744
> URL: https://issues.apache.org/jira/browse/GEODE-1744
> Project: Geode
>  Issue Type: Bug
>Reporter: Grace Meilen
>Assignee: Grace Meilen
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1715) gfsh ignores socket buffer size and message time to live while starting a server.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412474#comment-15412474
 ] 

ASF GitHub Bot commented on GEODE-1715:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/221


> gfsh ignores socket buffer size and message time to live while starting a 
> server.
> -
>
> Key: GEODE-1715
> URL: https://issues.apache.org/jira/browse/GEODE-1715
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Srikrishan Malik
>
> These tunables are set in the serverLauncher instance used to create the 
> command line but are not included in the command line.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1673) SampleSecurityManager should cause start to fail if security.json cannot be found

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411971#comment-15411971
 ] 

ASF GitHub Bot commented on GEODE-1673:
---

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/228#discussion_r73898764
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/security/templates/SampleSecurityManager.java
 ---
@@ -126,26 +126,33 @@ public boolean authorize(final Principal principal, 
final ResourcePermission con
 
   @Override
   public void init(final Properties securityProperties) throws 
NotAuthorizedException {
-String jsonPropertyValue = 
securityProperties.getProperty(SECURITY_JSON);
+boolean initialized = false;
+
+String jsonPropertyValue = securityProperties != null ? 
securityProperties.getProperty(SECURITY_JSON) : null;
 if (jsonPropertyValue == null) {
-  throw new AuthenticationFailedException("SampleSecurityManager: 
property [" + SECURITY_JSON + "] must be set.");
-}
+  initialized = initializeFromJsonResource(DEFAULT_JSON_FILE_NAME);
+} else {
 
-// 1st try to load value as a json resource
-boolean initialized = initializeFromJsonResource(jsonPropertyValue);
+  // 1st try to load value as a json resource
+  initialized = initializeFromJsonResource(jsonPropertyValue);
 
-// 2nd try to load value as a json file
-if (!initialized) {
-  initialized = initializeFromJsonFile(new File(jsonPropertyValue));
-}
+  // 2nd try to load value as a json file
--- End diff --

Do we really need the 2nd try and 3rd try? We don't use 
SampleSeucurityManager this way. If we can get rid these additional tries, then 
the init could be simple as this:

String jsonPropertyValue = securityProperties.getProperty(SECURITY_JSON);
if(jsonPropertyValue == null) jsonPropertyValue = DEFAULT_JSON_FILE_NAME;
if(!initializeFromJsonResource(jsonPropertyValue)){
  // throw exception
}



> SampleSecurityManager should cause start to fail if security.json cannot be 
> found
> -
>
> Key: GEODE-1673
> URL: https://issues.apache.org/jira/browse/GEODE-1673
> Project: Geode
>  Issue Type: Bug
>  Components: security
>Reporter: Kirk Lund
>Assignee: Grace Meilen
> Fix For: 1.0.0-incubating
>
>
> When following the instructions on 
> https://cwiki.apache.org/confluence/display/GEODE/Using+Custom+SecurityManager,
>  if the user forgets to specify "--classpath=." then the locator will start 
> up but cannot be connected to.
> The SampleSecurityManager should instead cause the start to fail if 
> security.json cannot be found.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1673) SampleSecurityManager should cause start to fail if security.json cannot be found

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411974#comment-15411974
 ] 

ASF GitHub Bot commented on GEODE-1673:
---

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/228#discussion_r73898883
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/security/templates/SampleSecurityManagerTest.java
 ---
@@ -65,6 +65,16 @@ public void setUp() throws Exception {
   }
 
   @Test
+  public void shouldDefaultToSecurityJsonInClasspathIfNullProperties() 
throws Exception {
+this.sampleSecurityManager.init(null);
+  }
+
+  @Test
+  public void shouldDefaultToSecurityJsonInClasspathIfEmptyProperties() 
throws Exception {
+this.sampleSecurityManager.init(new Properties());
--- End diff --

add some asserts here.


> SampleSecurityManager should cause start to fail if security.json cannot be 
> found
> -
>
> Key: GEODE-1673
> URL: https://issues.apache.org/jira/browse/GEODE-1673
> Project: Geode
>  Issue Type: Bug
>  Components: security
>Reporter: Kirk Lund
>Assignee: Grace Meilen
> Fix For: 1.0.0-incubating
>
>
> When following the instructions on 
> https://cwiki.apache.org/confluence/display/GEODE/Using+Custom+SecurityManager,
>  if the user forgets to specify "--classpath=." then the locator will start 
> up but cannot be connected to.
> The SampleSecurityManager should instead cause the start to fail if 
> security.json cannot be found.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1673) SampleSecurityManager should cause start to fail if security.json cannot be found

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411972#comment-15411972
 ] 

ASF GitHub Bot commented on GEODE-1673:
---

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/228#discussion_r73898847
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/security/templates/SampleSecurityManagerTest.java
 ---
@@ -65,6 +65,16 @@ public void setUp() throws Exception {
   }
 
   @Test
+  public void shouldDefaultToSecurityJsonInClasspathIfNullProperties() 
throws Exception {
+this.sampleSecurityManager.init(null);
--- End diff --

should we add some asserts here?


> SampleSecurityManager should cause start to fail if security.json cannot be 
> found
> -
>
> Key: GEODE-1673
> URL: https://issues.apache.org/jira/browse/GEODE-1673
> Project: Geode
>  Issue Type: Bug
>  Components: security
>Reporter: Kirk Lund
>Assignee: Grace Meilen
> Fix For: 1.0.0-incubating
>
>
> When following the instructions on 
> https://cwiki.apache.org/confluence/display/GEODE/Using+Custom+SecurityManager,
>  if the user forgets to specify "--classpath=." then the locator will start 
> up but cannot be connected to.
> The SampleSecurityManager should instead cause the start to fail if 
> security.json cannot be found.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1715) gfsh ignores socket buffer size and message time to live while starting a server.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410817#comment-15410817
 ] 

ASF GitHub Bot commented on GEODE-1715:
---

Github user sribits commented on the issue:

https://github.com/apache/incubator-geode/pull/221
  
Is there any additional work required on this pull request before it can 
actually be pulled?


> gfsh ignores socket buffer size and message time to live while starting a 
> server.
> -
>
> Key: GEODE-1715
> URL: https://issues.apache.org/jira/browse/GEODE-1715
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Srikrishan Malik
>
> These tunables are set in the serverLauncher instance used to create the 
> command line but are not included in the command line.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1673) SampleSecurityManager should cause start to fail if security.json cannot be found

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410216#comment-15410216
 ] 

ASF GitHub Bot commented on GEODE-1673:
---

GitHub user gracemeilen opened a pull request:

https://github.com/apache/incubator-geode/pull/228

GEODE-1673: Use security.json as default



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gracemeilen/incubator-geode 
feature/GEODE-1673-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/228.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #228


commit 97588e2966a50c6be7e6ea70c14c0e9f07bc6594
Author: gmeilen 
Date:   2016-08-02T18:29:40Z

GEODE-1673: Use security.json as default




> SampleSecurityManager should cause start to fail if security.json cannot be 
> found
> -
>
> Key: GEODE-1673
> URL: https://issues.apache.org/jira/browse/GEODE-1673
> Project: Geode
>  Issue Type: Bug
>  Components: security
>Reporter: Kirk Lund
>Assignee: Grace Meilen
> Fix For: 1.0.0-incubating
>
>
> When following the instructions on 
> https://cwiki.apache.org/confluence/display/GEODE/Using+Custom+SecurityManager,
>  if the user forgets to specify "--classpath=." then the locator will start 
> up but cannot be connected to.
> The SampleSecurityManager should instead cause the start to fail if 
> security.json cannot be found.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1648) Provide ability to disable security for some components

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408492#comment-15408492
 ] 

ASF GitHub Bot commented on GEODE-1648:
---

Github user kirklund commented on the issue:

https://github.com/apache/incubator-geode/pull/224
  
1) we need to fix the javadocs for security-enabled-components on 
DistributedSystem class
2) move SecurableComponent enum into internal.security pkg
3) consider collapsing SecurableComponents interface into 
SecurableComponent enum (we don't really need both




> Provide ability to disable security for some components
> ---
>
> Key: GEODE-1648
> URL: https://issues.apache.org/jira/browse/GEODE-1648
> Project: Geode
>  Issue Type: Sub-task
>  Components: security
>Reporter: Swapnil Bawaskar
>Assignee: Grace Meilen
>
> When the new {{SecurityManager}} interface is used, it will enable 
> authentication and authorization for client-server, jmx, peer-to-peer and 
> WAN. Not all users will want authentication and authorization for all these 
> components as explained in this comment: 
> https://issues.apache.org/jira/browse/GEODE-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369089#comment-15369089
> We should add new geode properties:
> {noformat}
> enable-peer-to-peer-authentication
> enable-client-server-security
> enable-msnsgement-security
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1712) Need unit tests for classes using Integrated Security

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408122#comment-15408122
 ] 

ASF GitHub Bot commented on GEODE-1712:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/226


> Need unit tests for classes using Integrated Security
> -
>
> Key: GEODE-1712
> URL: https://issues.apache.org/jira/browse/GEODE-1712
> Project: Geode
>  Issue Type: Test
>  Components: tests
>Affects Versions: 1.0.0-incubating.M1
>Reporter: Grace Meilen
>Assignee: Grace Meilen
>  Labels: security
>
> Most of the classes using Integrated Security (GEODE-17) do not have Unit 
> Tests (some have Integrated Test coverage).
> We need to wrap GeodeSecurityUtil in an interface (SecurityService) that can 
> be mocked so it's possible to write Unit Tests for all of the classes using 
> Integrated Security.
> Client command classes that need Unit Tests:
> * CommitCommand
> * ContainsKey
> * ContainsKey66
> * CreateRegion
> * Destroy65
> * DestroyRegion
> * Destroy
> * ExecuteFunction65
> * ExecuteFunction66
> * ExecuteFunction
> * Get70
> * GetAll70
> * GetAll651
> * GetAll
> * GetAllWithCallback
> * GetClientPartitionAttributesCommand66
> * GetClientPartitionAttributesCommand
> * Invalidate
> * KeySet
> * Put61
> * Put65
> * Put
> * RegisterInterest61
> * RegisterInterestList61
> * RegisterInterestList66
> * RegisterInterest
> * RemoveAll
> * Request
> * UnregisterInterest
> Non-core client command classes needing Unit Tests:
> * CloseCQ
> * ExecuteCQ
> * ExecuteCQ61
> * GetCQStats
> * GetDurableCQs
> * MonitorCQ
> * StopCQ
> More classes needing Unit Tests:
> * AcceptorImpl
> * CacheClientProxy
> * HandShake
> * ServerConnection
> * CreateAllterDestroyRegionCommands
> * DataCommands
> * IndexCommands
> * DataCommandFunction
> * CommandProcessor
> * AccessControlMBean
> * MBeanServerWrapper
> * LoginHandlerInterceptor
> * LuceneIndexCommands
> * SystemManagementService



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1712) Need unit tests for classes using Integrated Security

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406350#comment-15406350
 ] 

ASF GitHub Bot commented on GEODE-1712:
---

GitHub user gracemeilen opened a pull request:

https://github.com/apache/incubator-geode/pull/226

GEODE-1712: introduce SecurityService interface for mocking

GEODE-1712: add missing categories and fix test failure
* fix changes recommended in review
GEODE-1712: add static factory methods to SecurityService
GEODE-1713: cleanup imports
GEODE-1712: introduce SecurityService interface for mocking
* create Unit Tests for client commands that use security

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gracemeilen/incubator-geode 
feature/GEODE-1712-3

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/226.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #226


commit 449e5c4c3dcc26b982fa822b9a8d210c6dd9732d
Author: gmeilen 
Date:   2016-07-18T20:13:11Z

GEODE-1712: introduce SecurityService interface for mocking

* create Unit Tests for client commands that use security

commit b136c20417bdff2b9e7c6778471b12f48e2aedd2
Author: gmeilen 
Date:   2016-07-28T17:46:30Z

GEODE-1713: cleanup imports

commit b549bcc14ee2eeb1c0d5895965b3082875219fa5
Author: gmeilen 
Date:   2016-07-28T20:20:23Z

GEODE-1712: add static factory methods to SecurityService

commit cb08cfcee874fe67e5a64518e08b7e517d59f04c
Author: gmeilen 
Date:   2016-08-03T18:15:55Z

GEODE-1712: add missing categories and fix test failures




> Need unit tests for classes using Integrated Security
> -
>
> Key: GEODE-1712
> URL: https://issues.apache.org/jira/browse/GEODE-1712
> Project: Geode
>  Issue Type: Test
>  Components: tests
>Affects Versions: 1.0.0-incubating.M1
>Reporter: Grace Meilen
>Assignee: Grace Meilen
>  Labels: security
>
> Most of the classes using Integrated Security (GEODE-17) do not have Unit 
> Tests (some have Integrated Test coverage).
> We need to wrap GeodeSecurityUtil in an interface (SecurityService) that can 
> be mocked so it's possible to write Unit Tests for all of the classes using 
> Integrated Security.
> Client command classes that need Unit Tests:
> * CommitCommand
> * ContainsKey
> * ContainsKey66
> * CreateRegion
> * Destroy65
> * DestroyRegion
> * Destroy
> * ExecuteFunction65
> * ExecuteFunction66
> * ExecuteFunction
> * Get70
> * GetAll70
> * GetAll651
> * GetAll
> * GetAllWithCallback
> * GetClientPartitionAttributesCommand66
> * GetClientPartitionAttributesCommand
> * Invalidate
> * KeySet
> * Put61
> * Put65
> * Put
> * RegisterInterest61
> * RegisterInterestList61
> * RegisterInterestList66
> * RegisterInterest
> * RemoveAll
> * Request
> * UnregisterInterest
> Non-core client command classes needing Unit Tests:
> * CloseCQ
> * ExecuteCQ
> * ExecuteCQ61
> * GetCQStats
> * GetDurableCQs
> * MonitorCQ
> * StopCQ
> More classes needing Unit Tests:
> * AcceptorImpl
> * CacheClientProxy
> * HandShake
> * ServerConnection
> * CreateAllterDestroyRegionCommands
> * DataCommands
> * IndexCommands
> * DataCommandFunction
> * CommandProcessor
> * AccessControlMBean
> * MBeanServerWrapper
> * LoginHandlerInterceptor
> * LuceneIndexCommands
> * SystemManagementService



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1712) Need unit tests for classes using Integrated Security

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406346#comment-15406346
 ] 

ASF GitHub Bot commented on GEODE-1712:
---

Github user gracemeilen closed the pull request at:

https://github.com/apache/incubator-geode/pull/223


> Need unit tests for classes using Integrated Security
> -
>
> Key: GEODE-1712
> URL: https://issues.apache.org/jira/browse/GEODE-1712
> Project: Geode
>  Issue Type: Test
>  Components: tests
>Affects Versions: 1.0.0-incubating.M1
>Reporter: Grace Meilen
>Assignee: Grace Meilen
>  Labels: security
>
> Most of the classes using Integrated Security (GEODE-17) do not have Unit 
> Tests (some have Integrated Test coverage).
> We need to wrap GeodeSecurityUtil in an interface (SecurityService) that can 
> be mocked so it's possible to write Unit Tests for all of the classes using 
> Integrated Security.
> Client command classes that need Unit Tests:
> * CommitCommand
> * ContainsKey
> * ContainsKey66
> * CreateRegion
> * Destroy65
> * DestroyRegion
> * Destroy
> * ExecuteFunction65
> * ExecuteFunction66
> * ExecuteFunction
> * Get70
> * GetAll70
> * GetAll651
> * GetAll
> * GetAllWithCallback
> * GetClientPartitionAttributesCommand66
> * GetClientPartitionAttributesCommand
> * Invalidate
> * KeySet
> * Put61
> * Put65
> * Put
> * RegisterInterest61
> * RegisterInterestList61
> * RegisterInterestList66
> * RegisterInterest
> * RemoveAll
> * Request
> * UnregisterInterest
> Non-core client command classes needing Unit Tests:
> * CloseCQ
> * ExecuteCQ
> * ExecuteCQ61
> * GetCQStats
> * GetDurableCQs
> * MonitorCQ
> * StopCQ
> More classes needing Unit Tests:
> * AcceptorImpl
> * CacheClientProxy
> * HandShake
> * ServerConnection
> * CreateAllterDestroyRegionCommands
> * DataCommands
> * IndexCommands
> * DataCommandFunction
> * CommandProcessor
> * AccessControlMBean
> * MBeanServerWrapper
> * LoginHandlerInterceptor
> * LuceneIndexCommands
> * SystemManagementService



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1712) Need unit tests for classes using Integrated Security

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404600#comment-15404600
 ] 

ASF GitHub Bot commented on GEODE-1712:
---

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/223#discussion_r73215457
  
--- Diff: 
geode-core/src/main/java/com/gemstone/gemfire/internal/security/IntegratedSecurityService.java
 ---
@@ -0,0 +1,164 @@
+package com.gemstone.gemfire.internal.security;
+
+import java.util.Properties;
+import java.util.concurrent.Callable;
+
+import org.apache.geode.security.ResourcePermission;
+import org.apache.geode.security.SecurityManager;
+import org.apache.logging.log4j.Logger;
+import org.apache.shiro.subject.Subject;
+import org.apache.shiro.util.ThreadState;
+
+import com.gemstone.gemfire.internal.logging.LogService;
+import com.gemstone.gemfire.management.internal.security.ResourceOperation;
+
+public class IntegratedSecurityService implements SecurityService {
+
+  private static Logger logger = 
LogService.getLogger(LogService.SECURITY_LOGGER_NAME);
+
+  private static SecurityService defaultInstance = new 
IntegratedSecurityService();
+
--- End diff --

Can someone just call new IntegratedSecurityService()? If so, probably just 
create a private constructor here to prevent that.


> Need unit tests for classes using Integrated Security
> -
>
> Key: GEODE-1712
> URL: https://issues.apache.org/jira/browse/GEODE-1712
> Project: Geode
>  Issue Type: Test
>  Components: tests
>Affects Versions: 1.0.0-incubating.M1
>Reporter: Grace Meilen
>Assignee: Grace Meilen
>  Labels: security
>
> Most of the classes using Integrated Security (GEODE-17) do not have Unit 
> Tests (some have Integrated Test coverage).
> We need to wrap GeodeSecurityUtil in an interface (SecurityService) that can 
> be mocked so it's possible to write Unit Tests for all of the classes using 
> Integrated Security.
> Client command classes that need Unit Tests:
> * CommitCommand
> * ContainsKey
> * ContainsKey66
> * CreateRegion
> * Destroy65
> * DestroyRegion
> * Destroy
> * ExecuteFunction65
> * ExecuteFunction66
> * ExecuteFunction
> * Get70
> * GetAll70
> * GetAll651
> * GetAll
> * GetAllWithCallback
> * GetClientPartitionAttributesCommand66
> * GetClientPartitionAttributesCommand
> * Invalidate
> * KeySet
> * Put61
> * Put65
> * Put
> * RegisterInterest61
> * RegisterInterestList61
> * RegisterInterestList66
> * RegisterInterest
> * RemoveAll
> * Request
> * UnregisterInterest
> Non-core client command classes needing Unit Tests:
> * CloseCQ
> * ExecuteCQ
> * ExecuteCQ61
> * GetCQStats
> * GetDurableCQs
> * MonitorCQ
> * StopCQ
> More classes needing Unit Tests:
> * AcceptorImpl
> * CacheClientProxy
> * HandShake
> * ServerConnection
> * CreateAllterDestroyRegionCommands
> * DataCommands
> * IndexCommands
> * DataCommandFunction
> * CommandProcessor
> * AccessControlMBean
> * MBeanServerWrapper
> * LoginHandlerInterceptor
> * LuceneIndexCommands
> * SystemManagementService



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1648) Provide ability to disable security for some components

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404574#comment-15404574
 ] 

ASF GitHub Bot commented on GEODE-1648:
---

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/224#discussion_r73213204
  
--- Diff: 
geode-core/src/main/java/com/gemstone/gemfire/management/internal/ManagementAgent.java
 ---
@@ -509,8 +510,7 @@ private void registerAccessControlMBean() {
 
 
   private boolean isIntegratedSecurity() {
--- End diff --

We can get rid of this method. I believe this is called to check if we need 
to enabled pulse security in the same file as well. Yeah, what about pulse 
security? Do we need to add another enum or just say if jmx is enabled. pulse 
should be enabled as well?


> Provide ability to disable security for some components
> ---
>
> Key: GEODE-1648
> URL: https://issues.apache.org/jira/browse/GEODE-1648
> Project: Geode
>  Issue Type: Sub-task
>  Components: security
>Reporter: Swapnil Bawaskar
>
> When the new {{SecurityManager}} interface is used, it will enable 
> authentication and authorization for client-server, jmx, peer-to-peer and 
> WAN. Not all users will want authentication and authorization for all these 
> components as explained in this comment: 
> https://issues.apache.org/jira/browse/GEODE-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369089#comment-15369089
> We should add new geode properties:
> {noformat}
> enable-peer-to-peer-authentication
> enable-client-server-security
> enable-msnsgement-security
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1648) Provide ability to disable security for some components

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404573#comment-15404573
 ] 

ASF GitHub Bot commented on GEODE-1648:
---

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/224#discussion_r73212878
  
--- Diff: 
geode-core/src/main/java/com/gemstone/gemfire/management/internal/ManagementAgent.java
 ---
@@ -447,8 +449,7 @@ public synchronized void start() throws IOException {
   }
 };
 
-String shiroConfig = this.config.getShiroInit();
-if (! StringUtils.isBlank(shiroConfig) || isIntegratedSecurity()) {
+if (isIntegratedSecurity()) {
--- End diff --

probably be easier to read if it just read "if 
(GeodeSecurityUtil.isJmxSecurityEnabled())" here.


> Provide ability to disable security for some components
> ---
>
> Key: GEODE-1648
> URL: https://issues.apache.org/jira/browse/GEODE-1648
> Project: Geode
>  Issue Type: Sub-task
>  Components: security
>Reporter: Swapnil Bawaskar
>
> When the new {{SecurityManager}} interface is used, it will enable 
> authentication and authorization for client-server, jmx, peer-to-peer and 
> WAN. Not all users will want authentication and authorization for all these 
> components as explained in this comment: 
> https://issues.apache.org/jira/browse/GEODE-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369089#comment-15369089
> We should add new geode properties:
> {noformat}
> enable-peer-to-peer-authentication
> enable-client-server-security
> enable-msnsgement-security
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1648) Provide ability to disable security for some components

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404552#comment-15404552
 ] 

ASF GitHub Bot commented on GEODE-1648:
---

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/224#discussion_r73211230
  
--- Diff: 
geode-core/src/main/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtil.java
 ---
@@ -471,16 +499,27 @@ public static PostProcessor getPostProcessor() {
 return postProcessor;
   }
 
-  public static boolean isClientSecurityRequired() {
-return isClientAuthenticator || isIntegratedSecurity;
+  public static boolean isIntegratedSecurity(){
--- End diff --

We can get rid of this public method now. I believe now all the other 
components are just using component specific security enabled function.


> Provide ability to disable security for some components
> ---
>
> Key: GEODE-1648
> URL: https://issues.apache.org/jira/browse/GEODE-1648
> Project: Geode
>  Issue Type: Sub-task
>  Components: security
>Reporter: Swapnil Bawaskar
>
> When the new {{SecurityManager}} interface is used, it will enable 
> authentication and authorization for client-server, jmx, peer-to-peer and 
> WAN. Not all users will want authentication and authorization for all these 
> components as explained in this comment: 
> https://issues.apache.org/jira/browse/GEODE-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369089#comment-15369089
> We should add new geode properties:
> {noformat}
> enable-peer-to-peer-authentication
> enable-client-server-security
> enable-msnsgement-security
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1648) Provide ability to disable security for some components

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404517#comment-15404517
 ] 

ASF GitHub Bot commented on GEODE-1648:
---

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/224#discussion_r73207985
  
--- Diff: 
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/AbstractDistributionConfig.java
 ---
@@ -498,6 +502,29 @@ protected String checkRedisBindAddress(String value) {
 return value;
   }
 
+  /**
+   * First check if sslComponents are in the list of valid components. If 
so, check that no other *-ssl-* properties other than cluster-ssl-* are set.
--- End diff --

comments need to be changed here.


> Provide ability to disable security for some components
> ---
>
> Key: GEODE-1648
> URL: https://issues.apache.org/jira/browse/GEODE-1648
> Project: Geode
>  Issue Type: Sub-task
>  Components: security
>Reporter: Swapnil Bawaskar
>
> When the new {{SecurityManager}} interface is used, it will enable 
> authentication and authorization for client-server, jmx, peer-to-peer and 
> WAN. Not all users will want authentication and authorization for all these 
> components as explained in this comment: 
> https://issues.apache.org/jira/browse/GEODE-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369089#comment-15369089
> We should add new geode properties:
> {noformat}
> enable-peer-to-peer-authentication
> enable-client-server-security
> enable-msnsgement-security
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1648) Provide ability to disable security for some components

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404502#comment-15404502
 ] 

ASF GitHub Bot commented on GEODE-1648:
---

GitHub user gracemeilen opened a pull request:

https://github.com/apache/incubator-geode/pull/224

GEODE-1648: Introduce security-enabled-components and tests



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gracemeilen/incubator-geode feature/GEODE-1648

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/224.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #224


commit 4d9796e57bfa26cb1207145106eccb78447292a0
Author: gmeilen 
Date:   2016-08-02T17:52:18Z

GEODE-1648: Introduce security-enabled-components and tests




> Provide ability to disable security for some components
> ---
>
> Key: GEODE-1648
> URL: https://issues.apache.org/jira/browse/GEODE-1648
> Project: Geode
>  Issue Type: Sub-task
>  Components: security
>Reporter: Swapnil Bawaskar
>
> When the new {{SecurityManager}} interface is used, it will enable 
> authentication and authorization for client-server, jmx, peer-to-peer and 
> WAN. Not all users will want authentication and authorization for all these 
> components as explained in this comment: 
> https://issues.apache.org/jira/browse/GEODE-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369089#comment-15369089
> We should add new geode properties:
> {noformat}
> enable-peer-to-peer-authentication
> enable-client-server-security
> enable-msnsgement-security
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1674) Race condition in HashIndexSetIterator leads to ArrayOutOfBoundsException

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404326#comment-15404326
 ] 

ASF GitHub Bot commented on GEODE-1674:
---

Github user nabarunnag closed the pull request at:

https://github.com/apache/incubator-geode/pull/215


> Race condition in HashIndexSetIterator leads to ArrayOutOfBoundsException
> -
>
> Key: GEODE-1674
> URL: https://issues.apache.org/jira/browse/GEODE-1674
> Project: Geode
>  Issue Type: Bug
>  Components: querying
>Reporter: nabarun
>
> Object array may be reassigned by the time the function is trying to access 
> current element and the mask value may be larger than the size of the array 
> and this will lead to array out bounds exception.
> location : private HashIndexSetIterator(Object keyToMatch, Object[] objects) 
> in HashIndexSet.java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1674) Race condition in HashIndexSetIterator leads to ArrayOutOfBoundsException

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404325#comment-15404325
 ] 

ASF GitHub Bot commented on GEODE-1674:
---

Github user nabarunnag commented on the issue:

https://github.com/apache/incubator-geode/pull/215
  
Checked in


> Race condition in HashIndexSetIterator leads to ArrayOutOfBoundsException
> -
>
> Key: GEODE-1674
> URL: https://issues.apache.org/jira/browse/GEODE-1674
> Project: Geode
>  Issue Type: Bug
>  Components: querying
>Reporter: nabarun
>
> Object array may be reassigned by the time the function is trying to access 
> current element and the mask value may be larger than the size of the array 
> and this will lead to array out bounds exception.
> location : private HashIndexSetIterator(Object keyToMatch, Object[] objects) 
> in HashIndexSet.java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1682) provide ability to start developer REST api from gfsh

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404260#comment-15404260
 ] 

ASF GitHub Bot commented on GEODE-1682:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/218


> provide ability to start developer REST api from gfsh
> -
>
> Key: GEODE-1682
> URL: https://issues.apache.org/jira/browse/GEODE-1682
> Project: Geode
>  Issue Type: Sub-task
>  Components: docs, gfsh
>Reporter: Swapnil Bawaskar
>Assignee: Avinash
>
> To start REST api users have to add {{--J=-Dgemfire.start-dev-rest-api=true}} 
> to the {{start server}} command. 
> There should be a {noformat}--start-rest-api{noformat} option for the {{start 
> server}} command to start the rest api a 
> {noformat}--http-service-port{noformat} to configure the port and a 
> {noformat}--http-service-bind-address{noformat} option for the bind address.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-11) Lucene Integration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402997#comment-15402997
 ] 

ASF GitHub Bot commented on GEODE-11:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/222


> Lucene Integration
> --
>
> Key: GEODE-11
> URL: https://issues.apache.org/jira/browse/GEODE-11
> Project: Geode
>  Issue Type: New Feature
>  Components: querying
>Reporter: Dan Smith
>Assignee: xiaojian zhou
>
> This is a feature that has been under development for GemFire but was not 
> part of the initial drop of code for geode.
> Allow Lucene indexes to be stored in Geode regions allowing users to do text 
> searches on data stored in Geode. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-11) Lucene Integration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402947#comment-15402947
 ] 

ASF GitHub Bot commented on GEODE-11:
-

Github user gesterzhou commented on the issue:

https://github.com/apache/incubator-geode/pull/222
  
+1


> Lucene Integration
> --
>
> Key: GEODE-11
> URL: https://issues.apache.org/jira/browse/GEODE-11
> Project: Geode
>  Issue Type: New Feature
>  Components: querying
>Reporter: Dan Smith
>Assignee: xiaojian zhou
>
> This is a feature that has been under development for GemFire but was not 
> part of the initial drop of code for geode.
> Allow Lucene indexes to be stored in Geode regions allowing users to do text 
> searches on data stored in Geode. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-11) Lucene Integration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402915#comment-15402915
 ] 

ASF GitHub Bot commented on GEODE-11:
-

GitHub user aparnard opened a pull request:

https://github.com/apache/incubator-geode/pull/222

GEODE-11: Fixing creation of replicated region after an error is thrown

If a replicated region is created after a lucene index is defined, an error 
is thrown but the region is still created (since this check is done in the 
afterCreate method). This was fixed by moving the check to the beforeCreate 
method of the region listener.

Signed-off-by: Gester Zhou 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/aparnard/incubator-geode 
feature/GEODE-11-create-index-bug

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/222.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #222


commit e059013070cb61b468cbe8f3c14bcd3e70aadbd4
Author: Aparna Dharmakkan 
Date:   2016-08-01T21:54:39Z

GEODE-11: Fixing creation of replicated region after index creation.

If a replicated region is created after a lucene index is defined, an error 
is thrown but the region is created (since this check is done in the 
afterCreate method). This was fixed by moving the check to the beforeCreate 
method of the region listener.

Signed-off-by: Gester Zhou 




> Lucene Integration
> --
>
> Key: GEODE-11
> URL: https://issues.apache.org/jira/browse/GEODE-11
> Project: Geode
>  Issue Type: New Feature
>  Components: querying
>Reporter: Dan Smith
>Assignee: xiaojian zhou
>
> This is a feature that has been under development for GemFire but was not 
> part of the initial drop of code for geode.
> Allow Lucene indexes to be stored in Geode regions allowing users to do text 
> searches on data stored in Geode. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1715) gfsh ignores socket buffer size and message time to live while starting a server.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15400919#comment-15400919
 ] 

ASF GitHub Bot commented on GEODE-1715:
---

GitHub user srimalik opened a pull request:

https://github.com/apache/incubator-geode/pull/221

GEODE-1715: Add socket-buffer-size and message-time-to-live to server…

GEODE-1715: Add socket-buffer-size and message-time-to-live to server…

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/srimalik/incubator-geode BUG/GEODE-1715

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/221.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #221






> gfsh ignores socket buffer size and message time to live while starting a 
> server.
> -
>
> Key: GEODE-1715
> URL: https://issues.apache.org/jira/browse/GEODE-1715
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Srikrishan Malik
>
> These tunables are set in the serverLauncher instance used to create the 
> command line but are not included in the command line.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-11) Lucene Integration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15400289#comment-15400289
 ] 

ASF GitHub Bot commented on GEODE-11:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/220


> Lucene Integration
> --
>
> Key: GEODE-11
> URL: https://issues.apache.org/jira/browse/GEODE-11
> Project: Geode
>  Issue Type: New Feature
>  Components: querying
>Reporter: Dan Smith
>Assignee: xiaojian zhou
>
> This is a feature that has been under development for GemFire but was not 
> part of the initial drop of code for geode.
> Allow Lucene indexes to be stored in Geode regions allowing users to do text 
> searches on data stored in Geode. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-11) Lucene Integration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15400267#comment-15400267
 ] 

ASF GitHub Bot commented on GEODE-11:
-

Github user gesterzhou commented on the issue:

https://github.com/apache/incubator-geode/pull/220
  
+1


> Lucene Integration
> --
>
> Key: GEODE-11
> URL: https://issues.apache.org/jira/browse/GEODE-11
> Project: Geode
>  Issue Type: New Feature
>  Components: querying
>Reporter: Dan Smith
>Assignee: xiaojian zhou
>
> This is a feature that has been under development for GemFire but was not 
> part of the initial drop of code for geode.
> Allow Lucene indexes to be stored in Geode regions allowing users to do text 
> searches on data stored in Geode. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-11) Lucene Integration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15400244#comment-15400244
 ] 

ASF GitHub Bot commented on GEODE-11:
-

GitHub user aparnard opened a pull request:

https://github.com/apache/incubator-geode/pull/220

GEODE-11: Lucene gfsh exceptions and return keys of search results

- Added exception handling to lucene search and describe gfsh commands to 
handle region not found, index not found and invalid query string exceptions.

- Added an option to the lucene search command to return only keys of the 
search results. Added dunit and junit tests to verify

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/aparnard/incubator-geode 
feature/GEODE-11-Lucene-gfsh-exceptions

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/220.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #220


commit f522b036131b37137f9a94a74f9c5753a19db09e
Author: Aparna Dharmakkan 
Date:   2016-07-29T21:48:19Z

GEODE-11: Added exception handling to lucene gfsh commands

Added exception handling to lucene search and describe gfsh commands to 
handle region not found, index not found and invalid query string exceptions.

commit ad776cc01c968336dc88abee998a957a9b9a728a
Author: Aparna Dharmakkan 
Date:   2016-07-29T23:15:09Z

GEODE-11: gfsh lucene search command returns only keys

Added an option to the lucene search command to return only keys of the 
search results. Added dunit and junit tests to verify

Signed-off-by: Gester Zhou 




> Lucene Integration
> --
>
> Key: GEODE-11
> URL: https://issues.apache.org/jira/browse/GEODE-11
> Project: Geode
>  Issue Type: New Feature
>  Components: querying
>Reporter: Dan Smith
>Assignee: xiaojian zhou
>
> This is a feature that has been under development for GemFire but was not 
> part of the initial drop of code for geode.
> Allow Lucene indexes to be stored in Geode regions allowing users to do text 
> searches on data stored in Geode. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1682) provide ability to start developer REST api from gfsh

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399591#comment-15399591
 ] 

ASF GitHub Bot commented on GEODE-1682:
---

Github user kirklund commented on the issue:

https://github.com/apache/incubator-geode/pull/218
  
Hi @davinash, there was one test failure in precheckin that needs to be 
fixed:

:geode-core:integrationTest


com.gemstone.gemfire.management.internal.cli.commands.HelpCommandsIntegrationTest
 > testOfflineHelp FAILED
org.junit.ComparisonFailure: expected:<...iguration(=value)?]
[PARAMETERS
<...snip...>
use-cluster-configuration
When set to true, the server requests the configuration from 
locator's cluster
configuration service.
Required: false
Default (if the parameter is specified without value): true
Default (if the parameter is not specified): true
start-rest-api
When set to true, will start the REST API service.
Required: false
Default (if the parameter is specified without value): true
Default (if the parameter is not specified): false
http-service-port
Port on which HTTP Service will listen on
Required: false
Default (if the parameter is not specified): 8080
http-service-bind-address
The IP address on which the HTTP Service will be bound.  By 
default, the Server is bound to
all local addresses.
Required: fals]e>
at org.junit.Assert.assertEquals(Assert.java:115)
at org.junit.Assert.assertEquals(Assert.java:144)
at 
com.gemstone.gemfire.management.internal.cli.commands.HelpCommandsIntegrationTest.testOfflineHelp(HelpCommandsIntegrationTest.java:100)

3229 tests completed, 1 failed, 175 skipped
:geode-core:integrationTest FAILED



> provide ability to start developer REST api from gfsh
> -
>
> Key: GEODE-1682
> URL: https://issues.apache.org/jira/browse/GEODE-1682
> Project: Geode
>  Issue Type: Sub-task
>  Components: docs, gfsh
>Reporter: Swapnil Bawaskar
>Assignee: Avinash
>
> To start REST api users have to add {{--J=-Dgemfire.start-dev-rest-api=true}} 
> to the {{start server}} command. 
> There should be a {noformat}--start-rest-api{noformat} option for the {{start 
> server}} command to start the rest api a 
> {noformat}--http-service-port{noformat} to configure the port and a 
> {noformat}--http-service-bind-address{noformat} option for the bind address.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-11) Lucene Integration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15398597#comment-15398597
 ] 

ASF GitHub Bot commented on GEODE-11:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/219


> Lucene Integration
> --
>
> Key: GEODE-11
> URL: https://issues.apache.org/jira/browse/GEODE-11
> Project: Geode
>  Issue Type: New Feature
>  Components: querying
>Reporter: Dan Smith
>Assignee: xiaojian zhou
>
> This is a feature that has been under development for GemFire but was not 
> part of the initial drop of code for geode.
> Allow Lucene indexes to be stored in Geode regions allowing users to do text 
> searches on data stored in Geode. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-11) Lucene Integration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15398585#comment-15398585
 ] 

ASF GitHub Bot commented on GEODE-11:
-

Github user gesterzhou commented on the issue:

https://github.com/apache/incubator-geode/pull/219
  
+1



> Lucene Integration
> --
>
> Key: GEODE-11
> URL: https://issues.apache.org/jira/browse/GEODE-11
> Project: Geode
>  Issue Type: New Feature
>  Components: querying
>Reporter: Dan Smith
>Assignee: xiaojian zhou
>
> This is a feature that has been under development for GemFire but was not 
> part of the initial drop of code for geode.
> Allow Lucene indexes to be stored in Geode regions allowing users to do text 
> searches on data stored in Geode. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1694) Add committer Karen Smoler Miller to Geode website

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15398437#comment-15398437
 ] 

ASF GitHub Bot commented on GEODE-1694:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/216


> Add committer Karen Smoler Miller to Geode website
> --
>
> Key: GEODE-1694
> URL: https://issues.apache.org/jira/browse/GEODE-1694
> Project: Geode
>  Issue Type: Improvement
>Reporter: Joey McAllister
>Assignee: Joey McAllister
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1682) provide ability to start developer REST api from gfsh

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15397736#comment-15397736
 ] 

ASF GitHub Bot commented on GEODE-1682:
---

Github user kirklund commented on the issue:

https://github.com/apache/incubator-geode/pull/218
  
I'll merge it to develop, run tests and commit it if everything passes -- 
the commit will automatically close the PR and you'll receive a notification. 
Thanks Avinash!


> provide ability to start developer REST api from gfsh
> -
>
> Key: GEODE-1682
> URL: https://issues.apache.org/jira/browse/GEODE-1682
> Project: Geode
>  Issue Type: Sub-task
>  Components: docs, gfsh
>Reporter: Swapnil Bawaskar
>Assignee: Avinash
>
> To start REST api users have to add {{--J=-Dgemfire.start-dev-rest-api=true}} 
> to the {{start server}} command. 
> There should be a {noformat}--start-rest-api{noformat} option for the {{start 
> server}} command to start the rest api a 
> {noformat}--http-service-port{noformat} to configure the port and a 
> {noformat}--http-service-bind-address{noformat} option for the bind address.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1682) provide ability to start developer REST api from gfsh

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396713#comment-15396713
 ] 

ASF GitHub Bot commented on GEODE-1682:
---

Github user davinash commented on the issue:

https://github.com/apache/incubator-geode/pull/218
  
what is the next step for merge, I do not see that option. May be I am 
missing something !!!


> provide ability to start developer REST api from gfsh
> -
>
> Key: GEODE-1682
> URL: https://issues.apache.org/jira/browse/GEODE-1682
> Project: Geode
>  Issue Type: Sub-task
>  Components: gfsh
>Reporter: Swapnil Bawaskar
>Assignee: Avinash
>
> To start REST api users have to add {{--J=-Dgemfire.start-dev-rest-api=true}} 
> to the {{start server}} command. 
> There should be a {noformat}--start-rest-api{noformat} option for the {{start 
> server}} command to start the rest api a 
> {noformat}--http-service-port{noformat} to configure the port and a 
> {noformat}--http-service-bind-address{noformat} option for the bind address.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1682) provide ability to start developer REST api from gfsh

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396660#comment-15396660
 ] 

ASF GitHub Bot commented on GEODE-1682:
---

Github user sbawaska commented on the issue:

https://github.com/apache/incubator-geode/pull/218
  
+1


> provide ability to start developer REST api from gfsh
> -
>
> Key: GEODE-1682
> URL: https://issues.apache.org/jira/browse/GEODE-1682
> Project: Geode
>  Issue Type: Sub-task
>  Components: gfsh
>Reporter: Swapnil Bawaskar
>Assignee: Avinash
>
> To start REST api users have to add {{--J=-Dgemfire.start-dev-rest-api=true}} 
> to the {{start server}} command. 
> There should be a {noformat}--start-rest-api{noformat} option for the {{start 
> server}} command to start the rest api a 
> {noformat}--http-service-port{noformat} to configure the port and a 
> {noformat}--http-service-bind-address{noformat} option for the bind address.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-11) Lucene Integration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396631#comment-15396631
 ] 

ASF GitHub Bot commented on GEODE-11:
-

GitHub user aparnard opened a pull request:

https://github.com/apache/incubator-geode/pull/219

feature/GEODE-11-Lucene search with limit and pagination in gfsh

- Added limit option to the lucene search gfsh command to limit the number 
of search results to return.
- Added page size option to the lucene search gfsh command to paginate the 
search results.
- Added dunit and junit tests to verify the above.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/aparnard/incubator-geode 
feature/GEODE-11-gfsh-lucene-query

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/219.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #219


commit 4285edd41910297e1d921059582692da85c28a67
Author: Aparna Dharmakkan 
Date:   2016-07-20T20:50:59Z

GEODE-11: Added Limit to lucene search gfsh commands

Added an option to specify limit in gfsh search. Added a dunit test to 
verify.

commit 801bbe98751aa52111a07f492ec9ef08f97e85a2
Author: Aparna Dharmakkan 
Date:   2016-07-27T21:40:08Z

GEODE-11 : Pagination for gfsh lucene search command

Added pagination for gfsh lucene search results. Added junit test to verify.




> Lucene Integration
> --
>
> Key: GEODE-11
> URL: https://issues.apache.org/jira/browse/GEODE-11
> Project: Geode
>  Issue Type: New Feature
>  Components: querying
>Reporter: Dan Smith
>Assignee: xiaojian zhou
>
> This is a feature that has been under development for GemFire but was not 
> part of the initial drop of code for geode.
> Allow Lucene indexes to be stored in Geode regions allowing users to do text 
> searches on data stored in Geode. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-11) Lucene Integration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396433#comment-15396433
 ] 

ASF GitHub Bot commented on GEODE-11:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/217


> Lucene Integration
> --
>
> Key: GEODE-11
> URL: https://issues.apache.org/jira/browse/GEODE-11
> Project: Geode
>  Issue Type: New Feature
>  Components: querying
>Reporter: Dan Smith
>Assignee: xiaojian zhou
>
> This is a feature that has been under development for GemFire but was not 
> part of the initial drop of code for geode.
> Allow Lucene indexes to be stored in Geode regions allowing users to do text 
> searches on data stored in Geode. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-11) Lucene Integration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396400#comment-15396400
 ] 

ASF GitHub Bot commented on GEODE-11:
-

Github user gesterzhou commented on the issue:

https://github.com/apache/incubator-geode/pull/217
  
+1


> Lucene Integration
> --
>
> Key: GEODE-11
> URL: https://issues.apache.org/jira/browse/GEODE-11
> Project: Geode
>  Issue Type: New Feature
>  Components: querying
>Reporter: Dan Smith
>Assignee: xiaojian zhou
>
> This is a feature that has been under development for GemFire but was not 
> part of the initial drop of code for geode.
> Allow Lucene indexes to be stored in Geode regions allowing users to do text 
> searches on data stored in Geode. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1682) provide ability to start developer REST api from gfsh

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395034#comment-15395034
 ] 

ASF GitHub Bot commented on GEODE-1682:
---

Github user davinash commented on the issue:

https://github.com/apache/incubator-geode/pull/218
  
Thanks @kirklund for initial review. I have updated the PR with addition of 
Tests


> provide ability to start developer REST api from gfsh
> -
>
> Key: GEODE-1682
> URL: https://issues.apache.org/jira/browse/GEODE-1682
> Project: Geode
>  Issue Type: Sub-task
>  Components: gfsh
>Reporter: Swapnil Bawaskar
>Assignee: Avinash
>
> To start REST api users have to add {{--J=-Dgemfire.start-dev-rest-api=true}} 
> to the {{start server}} command. 
> There should be a {noformat}--start-rest-api{noformat} option for the {{start 
> server}} command to start the rest api a 
> {noformat}--http-service-port{noformat} to configure the port and a 
> {noformat}--http-service-bind-address{noformat} option for the bind address.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1682) provide ability to start developer REST api from gfsh

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15394478#comment-15394478
 ] 

ASF GitHub Bot commented on GEODE-1682:
---

Github user kirklund commented on the issue:

https://github.com/apache/incubator-geode/pull/218
  
Thank you for the pull request Avinash! Please look into writing some new 
tests that verify the changes.


> provide ability to start developer REST api from gfsh
> -
>
> Key: GEODE-1682
> URL: https://issues.apache.org/jira/browse/GEODE-1682
> Project: Geode
>  Issue Type: Sub-task
>  Components: gfsh
>Reporter: Swapnil Bawaskar
>Assignee: Avinash
>
> To start REST api users have to add {{--J=-Dgemfire.start-dev-rest-api=true}} 
> to the {{start server}} command. 
> There should be a {noformat}--start-rest-api{noformat} option for the {{start 
> server}} command to start the rest api a 
> {noformat}--http-service-port{noformat} to configure the port and a 
> {noformat}--http-service-bind-address{noformat} option for the bind address.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-11) Lucene Integration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15394157#comment-15394157
 ] 

ASF GitHub Bot commented on GEODE-11:
-

Github user upthewaterspout commented on the issue:

https://github.com/apache/incubator-geode/pull/217
  
This change is mixing internal classes in the public API. You're adding 
getDefinedIndexes to the public API, but it returns LuceneIndexCreationProfile 
objects which is an internal class. Looking at LuceneIndexCreationProfile, I 
think these methods probably don't belong on LuceneService. Maybe put these 
methods on InternalLuceneService?

I think setFieldAnalyzerStrings is not a good name, because it's not 
actually setting anything on the object. Same with 
setFieldAnalyzerStringsFromProfile.

The boolean "status" field in in LuceneIndexDetails is confusing - what 
does true or false mean? Maybe it should be named initialized?


> Lucene Integration
> --
>
> Key: GEODE-11
> URL: https://issues.apache.org/jira/browse/GEODE-11
> Project: Geode
>  Issue Type: New Feature
>  Components: querying
>Reporter: Dan Smith
>Assignee: xiaojian zhou
>
> This is a feature that has been under development for GemFire but was not 
> part of the initial drop of code for geode.
> Allow Lucene indexes to be stored in Geode regions allowing users to do text 
> searches on data stored in Geode. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1682) provide ability to start developer REST api from gfsh

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15393783#comment-15393783
 ] 

ASF GitHub Bot commented on GEODE-1682:
---

GitHub user davinash opened a pull request:

https://github.com/apache/incubator-geode/pull/218

GEODE-1682: Adding options for starting Geode REST API using gfsh

GEODE-1682: 

- Added option in gfsh to start REST `start-rest-api`
- Added option for http service port `http-service-port`
- Added option for http service bind address `http-service-bind-address`
- Update `gemfireProperties` to for `cache` creation.
- Verified Manually ( both with `start-rest-api` and without )
- Ran the precheckin 
   - Test Failing ( 
ConcurrentParallelGatewaySenderOffHeapDUnitTest#testPartitionedParallelPropagationHA

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davinash/incubator-geode GEODE-1682

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/218.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #218


commit 93aa57c84b8bf057ea70765267f8eb79dfcdf5e1
Author: Avinash 
Date:   2016-07-25T08:59:53Z

GEODE-1682: Adding options for starting Geode REST API using gfsh




> provide ability to start developer REST api from gfsh
> -
>
> Key: GEODE-1682
> URL: https://issues.apache.org/jira/browse/GEODE-1682
> Project: Geode
>  Issue Type: Sub-task
>  Components: gfsh
>Reporter: Swapnil Bawaskar
>Assignee: Avinash
>
> To start REST api users have to add {{--J=-Dgemfire.start-dev-rest-api=true}} 
> to the {{start server}} command. 
> There should be a {noformat}--start-rest-api{noformat} option for the {{start 
> server}} command to start the rest api a 
> {noformat}--http-service-port{noformat} to configure the port and a 
> {noformat}--http-service-bind-address{noformat} option for the bind address.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-88) Build fails on Windows with Caused by: java.lang.ClassCastException: org.dom4j.DocumentFactory cannot be cast to org.dom4j.DocumentFactory

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15393359#comment-15393359
 ] 

ASF GitHub Bot commented on GEODE-88:
-

Github user doribd commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/199#discussion_r72201660
  
--- Diff: 
geode-client-native/src/cppcache/impl/ThinClientRedundancyManager.hpp ---
@@ -56,7 +56,7 @@ namespace gemfire {
void netDown( );
void acquireRedundancyLock( ) { m_redundantEndpointsLock.acquire_read( 
); }
void releaseRedundancyLock( ) { m_redundantEndpointsLock.release( ); }
-   volatile bool allEndPointDiscon() { return m_IsAllEpDisCon;}
+   bool allEndPointDiscon() { return m_IsAllEpDisCon;} //Copyright: Amdocs 
Software Systems Limited, 2016
--- End diff --

Are we required to remove this line?


> Build fails on Windows with Caused by: java.lang.ClassCastException: 
> org.dom4j.DocumentFactory cannot be cast to org.dom4j.DocumentFactory
> --
>
> Key: GEODE-88
> URL: https://issues.apache.org/jira/browse/GEODE-88
> Project: Geode
>  Issue Type: Bug
>Reporter: Kirk Lund
>Assignee: Kirk Lund
> Fix For: 1.0.0-incubating.M1
>
>
> Caused by: java.lang.ExceptionInInitializerError
> at org.dom4j.DocumentFactory.createNamespace(DocumentFactory.java:185)
> at 
> org.dom4j.tree.NamespaceStack.createNamespace(NamespaceStack.java:407)
> at org.dom4j.tree.NamespaceStack.push(NamespaceStack.java:276)
> at 
> org.dom4j.io.SAXContentHandler.startPrefixMapping(SAXContentHandler.java:191)
> at 
> com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.startNamespaceMapping(AbstractSAXParser.java:2164)
> at 
> com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.startElement(AbstractSAXParser.java:469)
> at 
> com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.scanStartElement(XMLNSDocumentScannerImpl.java:379)
> at 
> com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl$NSContentDriver.scanRootElementHook(XMLNSDocumentScannerImpl.java:605)
> at 
> com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDriver.next(XMLDocumentFragmentScannerImpl.java:3138)
> at 
> com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl$PrologDriver.next(XMLDocumentScannerImpl.java:880)
> at 
> com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:606)
> at 
> com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.next(XMLNSDocumentScannerImpl.java:117)
> at 
> com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:510)
> at 
> com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:848)
> at 
> com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:777)
> at 
> com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:141)
> at 
> com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1213)
> at 
> com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:649)
> at org.dom4j.io.SAXReader.read(SAXReader.java:465)
> at 
> org.hibernate.build.gradle.publish.auth.maven.SettingsXmlCredentialsProvider.extractCredentialsFromSettings(SettingsXmlCredentialsProvider.java:85)
> at 
> org.hibernate.build.gradle.publish.auth.maven.SettingsXmlCredentialsProvider.(SettingsXmlCredentialsProvider.java:62)
> at 
> org.hibernate.build.gradle.publish.auth.maven.SettingsXmlCredentialsProvider.(SettingsXmlCredentialsProvider.java:54)
> at 
> org.hibernate.build.gradle.publish.auth.maven.CredentialsProviderRegistry.buildStandardAuthenticationProviders(CredentialsProviderRegistry.java:39)
> at 
> org.hibernate.build.gradle.publish.auth.maven.CredentialsProviderRegistry.(CredentialsProviderRegistry.java:34)
> at 
> org.hibernate.build.gradle.publish.auth.maven.AuthenticationManager.apply(AuthenticationManager.java:37)
> at 
> org.hibernate.build.gradle.publish.auth.maven.AuthenticationManager.apply(AuthenticationManager.java:34)
> at 
> org.gradle.api.internal.plugins.ImperativeOnlyPluginApplicator.applyImperative(ImperativeOnlyPluginApplicator.java:35)
> at 
> org.gradle.api.internal.plugins.RulesCapablePluginApplicator.applyImperative(RulesCapablePluginApplicator.java:42)
> at 
> 

[jira] [Commented] (GEODE-11) Lucene Integration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15392904#comment-15392904
 ] 

ASF GitHub Bot commented on GEODE-11:
-

GitHub user aparnard opened a pull request:

https://github.com/apache/incubator-geode/pull/217

feature/GEODE-11-Defining lucene index 

- Added a definedIndexMap field in LuceneServiceImpl to store the 
uninitialized lucene indexes
- Added a field "status" to the list and describe lucene gfsh commands to 
differentiate between defined and initialized indexes.
- Added a dunit test for the create index gfsh command to verify if the 
indexes created through gfsh are stored in definedIndexMap.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/aparnard/incubator-geode 
feature/GEODE-11-define-index

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/217.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #217


commit 6e2e24a18838ae9538f9e45ad2dd4ed18a8370e1
Author: Aparna Dharmakkan 
Date:   2016-07-25T19:21:21Z

GEODE-11: Adding a defined index field in LuceneServiceImpl

Added a definedIndexMap field in LuceneServiceImpl to store the 
uninitialized lucene indexes

Signed-off-by: Gester Zhou 

commit e90c83a67f6591f9d8ae24777d96cceb09dd34a7
Author: Aparna Dharmakkan 
Date:   2016-07-26T00:02:05Z

GEODE-11: Added status to gfsh commands

Added a field status(initialized/defined wrt region creation) to list and 
describe lucene commands.
Added a dunit test for create index command to verify that the created 
index is stored in definedIndexMap.

Signed-off-by: Gester Zhou 




> Lucene Integration
> --
>
> Key: GEODE-11
> URL: https://issues.apache.org/jira/browse/GEODE-11
> Project: Geode
>  Issue Type: New Feature
>  Components: querying
>Reporter: Dan Smith
>Assignee: xiaojian zhou
>
> This is a feature that has been under development for GemFire but was not 
> part of the initial drop of code for geode.
> Allow Lucene indexes to be stored in Geode regions allowing users to do text 
> searches on data stored in Geode. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1694) Add committer Karen Smoler Miller to Geode website

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15392888#comment-15392888
 ] 

ASF GitHub Bot commented on GEODE-1694:
---

GitHub user joeymcallister opened a pull request:

https://github.com/apache/incubator-geode/pull/216

Feature/geode 1694

GEODE-1694 Add Karen Smoler Miller to commiters

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/joeymcallister/incubator-geode 
feature/GEODE-1694

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/216.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #216


commit 8edfe6027058736ac4698fdc9f4382acc651ebc7
Author: Joey McAllister 
Date:   2016-07-25T23:35:41Z

Merge remote-tracking branch 'apache/develop' into develop

commit 81c1ac641b491bf592d866b65a27985877c81e2e
Author: Joey McAllister 
Date:   2016-07-26T00:01:41Z

GEODE-1694 Add Karen Smoler Miller to committers




> Add committer Karen Smoler Miller to Geode website
> --
>
> Key: GEODE-1694
> URL: https://issues.apache.org/jira/browse/GEODE-1694
> Project: Geode
>  Issue Type: Improvement
>Reporter: Joey McAllister
>Assignee: Joey McAllister
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1673) SampleSecurityManager should cause start to fail if security.json cannot be found

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15392417#comment-15392417
 ] 

ASF GitHub Bot commented on GEODE-1673:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/212


> SampleSecurityManager should cause start to fail if security.json cannot be 
> found
> -
>
> Key: GEODE-1673
> URL: https://issues.apache.org/jira/browse/GEODE-1673
> Project: Geode
>  Issue Type: Bug
>  Components: security
>Reporter: Kirk Lund
>Assignee: Grace Meilen
>
> When following the instructions on 
> https://cwiki.apache.org/confluence/display/GEODE/Using+Custom+SecurityManager,
>  if the user forgets to specify "--classpath=." then the locator will start 
> up but cannot be connected to.
> The SampleSecurityManager should instead cause the start to fail if 
> security.json cannot be found.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1617) Regions can be created with a variety of characters that are unsupported

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15392335#comment-15392335
 ] 

ASF GitHub Bot commented on GEODE-1617:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/201


> Regions can be created with a variety of characters that are unsupported
> 
>
> Key: GEODE-1617
> URL: https://issues.apache.org/jira/browse/GEODE-1617
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Affects Versions: 1.0.0-incubating.M2
>Reporter: Kevin Duling
>Assignee: Kevin Duling
>
> Per this 
> [thread|https://www.mail-archive.com/dev@geode.incubator.apache.org/msg04046.html],
>  and this 
> [thread|https://www.mail-archive.com/dev@geode.incubator.apache.org/msg07079.html]
>  on the dev forums and [geode 
> documentation|http://docs-geode-develop.cfapps.io/docs/basic_config/data_regions/region_naming.html],
>  region names may only consist of alphanumeric characters, an underscore, and 
> a hyphen.  These rules are not enforced.
> E.g., it is possible to create a region with:
> {{gfsh> create region --name=not^good --type=REPLICATE}}
> Some of these regions may be removed with the {{destroy}} command, while 
> others cannot be located.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1674) Race condition in HashIndexSetIterator leads to ArrayOutOfBoundsException

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15388258#comment-15388258
 ] 

ASF GitHub Bot commented on GEODE-1674:
---

GitHub user nabarunnag opened a pull request:

https://github.com/apache/incubator-geode/pull/215

GEODE-1674: Using a immuatable object to pass the HashIndexSet and its mask


* Immutable ojects pairs the mask and set together
* There is no race condition in which the mask differs from the set 
leading to any ArrayOutOfBoundsException.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-1674

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/215.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #215


commit 04f5ebbf9466d47e66c45ce0fdbab8302f290611
Author: nabarun 
Date:   2016-07-19T17:31:52Z

GEODE-1674: Using a immuatable object to pass the HashIndexSet and its mask

* Immutable ojects pairs the mask and set together
* There is no race condition in which the mask differs from the set 
leading to any ArrayOutOfBoundsException.




> Race condition in HashIndexSetIterator leads to ArrayOutOfBoundsException
> -
>
> Key: GEODE-1674
> URL: https://issues.apache.org/jira/browse/GEODE-1674
> Project: Geode
>  Issue Type: Bug
>  Components: querying
>Reporter: nabarun
>
> Object array may be reassigned by the time the function is trying to access 
> current element and the mask value may be larger than the size of the array 
> and this will lead to array out bounds exception.
> location : private HashIndexSetIterator(Object keyToMatch, Object[] objects) 
> in HashIndexSet.java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1680) Change "list regions" to DATA:READ permissions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387924#comment-15387924
 ] 

ASF GitHub Bot commented on GEODE-1680:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/214


> Change "list regions" to DATA:READ permissions
> --
>
> Key: GEODE-1680
> URL: https://issues.apache.org/jira/browse/GEODE-1680
> Project: Geode
>  Issue Type: Task
>  Components: gfsh, security
>Reporter: Kevin Duling
>Assignee: Kevin Duling
>
> Currently, "list regions" requires CLUSTER:READ permissions. Since Region is 
> a data resource, this should be DATA:READ



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1680) Change "list regions" to DATA:READ permissions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387919#comment-15387919
 ] 

ASF GitHub Bot commented on GEODE-1680:
---

Github user jinmeiliao commented on the issue:

https://github.com/apache/incubator-geode/pull/214
  
+1. I'll pull this in


> Change "list regions" to DATA:READ permissions
> --
>
> Key: GEODE-1680
> URL: https://issues.apache.org/jira/browse/GEODE-1680
> Project: Geode
>  Issue Type: Task
>  Components: gfsh, security
>Reporter: Kevin Duling
>Assignee: Kevin Duling
>
> Currently, "list regions" requires CLUSTER:READ permissions. Since Region is 
> a data resource, this should be DATA:READ



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1680) Change "list regions" to DATA:READ permissions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387900#comment-15387900
 ] 

ASF GitHub Bot commented on GEODE-1680:
---

GitHub user kjduling opened a pull request:

https://github.com/apache/incubator-geode/pull/214

GEODE-1680: Change "list regions" to DATA:READ permissions

Edited the annotations for listRegions in RegionCommands and updated unit 
tests.

precheckin done

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kjduling/incubator-geode feature/GEODE-1680

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/214.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #214


commit c1748119342740db098c87ea541b4242ed782566
Author: Kevin J. Duling 
Date:   2016-07-20T18:50:22Z

GEODE-1680: Change "list regions" to DATA:READ permissions

Edited the annotations for listRegions in RegionCommands and updated unit 
tests.




> Change "list regions" to DATA:READ permissions
> --
>
> Key: GEODE-1680
> URL: https://issues.apache.org/jira/browse/GEODE-1680
> Project: Geode
>  Issue Type: Task
>  Components: gfsh, security
>Reporter: Kevin Duling
>Assignee: Kevin Duling
>
> Currently, "list regions" requires CLUSTER:READ permissions. Since Region is 
> a data resource, this should be DATA:READ



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1647) Enable use of SecurityManager for peer authentication

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15386777#comment-15386777
 ] 

ASF GitHub Bot commented on GEODE-1647:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/210


> Enable use of SecurityManager for peer authentication
> -
>
> Key: GEODE-1647
> URL: https://issues.apache.org/jira/browse/GEODE-1647
> Project: Geode
>  Issue Type: Sub-task
>  Components: security
>Reporter: Kirk Lund
>Assignee: Grace Meilen
>
> Since the clients and JMX both support SecurityManager for authentication, 
> the peer-to-peer authentication should also be able to use SecurityManager so 
> that the users could truly have one callback for all authentication.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1617) Regions can be created with a variety of characters that are unsupported

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15386387#comment-15386387
 ] 

ASF GitHub Bot commented on GEODE-1617:
---

Github user dschneider-pivotal commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/201#discussion_r71580837
  
--- Diff: 
geode-core/src/test/java/com/gemstone/gemfire/cache/query/QueryJUnitTest.java 
---
@@ -117,6 +118,7 @@ public void test002UnicodeInQuery() {
   }
 
   @Test
+  @Ignore // GEODE-1617 - Regions can be created with a variety of 
characters that are unsupported
--- End diff --

Shouldn't these tests be removed instead of ignored?


> Regions can be created with a variety of characters that are unsupported
> 
>
> Key: GEODE-1617
> URL: https://issues.apache.org/jira/browse/GEODE-1617
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Affects Versions: 1.0.0-incubating.M2
>Reporter: Kevin Duling
>Assignee: Kevin Duling
>
> Per this 
> [thread|https://www.mail-archive.com/dev@geode.incubator.apache.org/msg04046.html],
>  and this 
> [thread|https://www.mail-archive.com/dev@geode.incubator.apache.org/msg07079.html]
>  on the dev forums and [geode 
> documentation|http://docs-geode-develop.cfapps.io/docs/basic_config/data_regions/region_naming.html],
>  region names may only consist of alphanumeric characters, an underscore, and 
> a hyphen.  These rules are not enforced.
> E.g., it is possible to create a region with:
> {{gfsh> create region --name=not^good --type=REPLICATE}}
> Some of these regions may be removed with the {{destroy}} command, while 
> others cannot be located.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1617) Regions can be created with a variety of characters that are unsupported

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15386366#comment-15386366
 ] 

ASF GitHub Bot commented on GEODE-1617:
---

Github user dschneider-pivotal commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/201#discussion_r71579111
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/redis/GeodeRedisServer.java ---
@@ -424,14 +429,26 @@ private void initializeRedis() {
   RegionFactory rfString = 
cache.createRegionFactory(DEFAULT_REGION_TYPE);
   RegionFactory rfHLL = 
cache.createRegionFactory(DEFAULT_REGION_TYPE);
   Region stringsRegion;
-  if ((stringsRegion = this.cache.getRegion(STRING_REGION)) == null)
-stringsRegion = rfString.create(GeodeRedisServer.STRING_REGION);
+  InternalRegionArguments ira = new 
InternalRegionArguments().setInternalRegion(true);
+  AttributesFactory af = new AttributesFactory();
+  af.setScope(Scope.LOCAL);
+  RegionAttributes ra = af.create();
   Region hLLRegion;
-  if ((hLLRegion = this.cache.getRegion(HLL_REGION)) == null)
-hLLRegion = rfHLL.create(HLL_REGION);
   Region redisMetaData;
-  if ((redisMetaData = this.cache.getRegion(REDIS_META_DATA_REGION)) 
== null)
-redisMetaData = rfMeta.create(REDIS_META_DATA_REGION);
+  try {
+if ((stringsRegion = this.cache.getRegion(STRING_REGION)) == null)
+  stringsRegion = rfString.create(GeodeRedisServer.STRING_REGION, 
ra, ira);
+if ((hLLRegion = this.cache.getRegion(HLL_REGION)) == null)
+  hLLRegion = rfHLL.create(HLL_REGION, ra, ira);
+if ((redisMetaData = this.cache.getRegion(REDIS_META_DATA_REGION)) 
== null)
+  redisMetaData = rfMeta.create(REDIS_META_DATA_REGION, ra, ira);
+  }
+  catch (IOException | ClassNotFoundException e) {
--- End diff --

The addition of this try/catch does not look related to region names. Seems 
like it should have its own ticket.


> Regions can be created with a variety of characters that are unsupported
> 
>
> Key: GEODE-1617
> URL: https://issues.apache.org/jira/browse/GEODE-1617
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Affects Versions: 1.0.0-incubating.M2
>Reporter: Kevin Duling
>Assignee: Kevin Duling
>
> Per this 
> [thread|https://www.mail-archive.com/dev@geode.incubator.apache.org/msg04046.html],
>  and this 
> [thread|https://www.mail-archive.com/dev@geode.incubator.apache.org/msg07079.html]
>  on the dev forums and [geode 
> documentation|http://docs-geode-develop.cfapps.io/docs/basic_config/data_regions/region_naming.html],
>  region names may only consist of alphanumeric characters, an underscore, and 
> a hyphen.  These rules are not enforced.
> E.g., it is possible to create a region with:
> {{gfsh> create region --name=not^good --type=REPLICATE}}
> Some of these regions may be removed with the {{destroy}} command, while 
> others cannot be located.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)