[jira] [Commented] (HAWQ-917) Refactor feature tests for data type check with new googletest framework

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374323#comment-15374323
 ] 

ASF GitHub Bot commented on HAWQ-917:
-

Github user paul-guo- commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/787#discussion_r70563325
  
--- Diff: src/test/feature/type/ans/int8.ans ---
@@ -175,131 +179,131 @@ SELECT '' AS to_char_4, to_char( (q1 * -1), 
'S'), to_char( (q2 *
 SELECT '' AS to_char_5,  to_char(q2, 'MI') FROM 
INT8_TBL  ;
  to_char_5 |  to_char  
 ---+---
-   |   123
|   456
|  4567890123456789
+   |   123
|  4567890123456789
| -4567890123456789
 (5 rows)
 
 SELECT '' AS to_char_6,  to_char(q2, 'FMS')FROM 
INT8_TBL  ;
  to_char_6 |  to_char  
 ---+---
-   | +123
| +456
-   | -4567890123456789
| +4567890123456789
+   | +123
| +4567890123456789
+   | -4567890123456789
 (5 rows)
 
 SELECT '' AS to_char_7,  to_char(q2, 'FMTHPR') FROM 
INT8_TBL ;
  to_char_7 |  to_char   
 ---+
-   | 123RD
-   | <4567890123456789>
+   | 456TH
| 4567890123456789TH
+   | 123RD
| 4567890123456789TH
-   | 456TH
+   | <4567890123456789>
 (5 rows)
 
 SELECT '' AS to_char_8,  to_char(q2, 'SGth')   FROM 
INT8_TBL ;
  to_char_8 |   to_char   
 ---+-
-   | + 123rd
-   | -4567890123456789
+   | + 456th
| +4567890123456789th
+   | + 123rd
| +4567890123456789th
-   | + 456th
+   | -4567890123456789
 (5 rows)
 
 SELECT '' AS to_char_9,  to_char(q2, '0999')   FROM 
INT8_TBL ;
  to_char_9 |  to_char  
 ---+---
-   |  0123
|  0456
|  4567890123456789
+   |  0123
|  4567890123456789
| -4567890123456789
 (5 rows)
 
 SELECT '' AS to_char_10, to_char(q2, 'S0999')  FROM 
INT8_TBL ;
  to_char_10 |  to_char  
 +---
-| +0123
 | +0456
-| -4567890123456789
 | +4567890123456789
+| +0123
 | +4567890123456789
+| -4567890123456789
 (5 rows)
 
 SELECT '' AS to_char_11, to_char(q2, 'FM0999') FROM 
INT8_TBL ;
  to_char_11 |  to_char  
 +---
-| 0123
 | 0456
 | 4567890123456789
+| 0123
 | 4567890123456789
 | -4567890123456789
 (5 rows)
 
 SELECT '' AS to_char_12, to_char(q2, 'FM.000') FROM 
INT8_TBL ;
  to_char_12 |to_char
 +---
-| 123.000
 | 456.000
-| -4567890123456789.000
 | 4567890123456789.000
+| 123.000
 | 4567890123456789.000
+| -4567890123456789.000
 (5 rows)
 
 SELECT '' AS to_char_13, to_char(q2, 'L.000')  FROM 
INT8_TBL ;
  to_char_13 |to_char 
 +
-|123.000
-|456.000
-|   4567890123456789.000
-|   4567890123456789.000
-|  -4567890123456789.000
+| $  456.000
+| $ 4567890123456789.000
+| $  123.000
+| $ 4567890123456789.000
+| $-4567890123456789.000
--- End diff --

I looked into this. I is related to currency info of the locale. You are 
right this probably need a bit more work.


> Refactor feature tests for data type check with new googletest framework
> 
>
> Key: HAWQ-917
> URL: https://issues.apache.org/jira/browse/HAWQ-917
> Project: Apache HAWQ
>  Issue Type: Sub-task
>Reporter: Paul Guo
>   

[GitHub] incubator-hawq pull request #787: HAWQ-917. Refactor feature tests for data ...

[paul-guo-]

Github user paul-guo- commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/787#discussion_r70563325
  
--- Diff: src/test/feature/type/ans/int8.ans ---
@@ -175,131 +179,131 @@ SELECT '' AS to_char_4, to_char( (q1 * -1), 
'S'), to_char( (q2 *
 SELECT '' AS to_char_5,  to_char(q2, 'MI') FROM 
INT8_TBL  ;
  to_char_5 |  to_char  
 ---+---
-   |   123
|   456
|  4567890123456789
+   |   123
|  4567890123456789
| -4567890123456789
 (5 rows)
 
 SELECT '' AS to_char_6,  to_char(q2, 'FMS')FROM 
INT8_TBL  ;
  to_char_6 |  to_char  
 ---+---
-   | +123
| +456
-   | -4567890123456789
| +4567890123456789
+   | +123
| +4567890123456789
+   | -4567890123456789
 (5 rows)
 
 SELECT '' AS to_char_7,  to_char(q2, 'FMTHPR') FROM 
INT8_TBL ;
  to_char_7 |  to_char   
 ---+
-   | 123RD
-   | <4567890123456789>
+   | 456TH
| 4567890123456789TH
+   | 123RD
| 4567890123456789TH
-   | 456TH
+   | <4567890123456789>
 (5 rows)
 
 SELECT '' AS to_char_8,  to_char(q2, 'SGth')   FROM 
INT8_TBL ;
  to_char_8 |   to_char   
 ---+-
-   | + 123rd
-   | -4567890123456789
+   | + 456th
| +4567890123456789th
+   | + 123rd
| +4567890123456789th
-   | + 456th
+   | -4567890123456789
 (5 rows)
 
 SELECT '' AS to_char_9,  to_char(q2, '0999')   FROM 
INT8_TBL ;
  to_char_9 |  to_char  
 ---+---
-   |  0123
|  0456
|  4567890123456789
+   |  0123
|  4567890123456789
| -4567890123456789
 (5 rows)
 
 SELECT '' AS to_char_10, to_char(q2, 'S0999')  FROM 
INT8_TBL ;
  to_char_10 |  to_char  
 +---
-| +0123
 | +0456
-| -4567890123456789
 | +4567890123456789
+| +0123
 | +4567890123456789
+| -4567890123456789
 (5 rows)
 
 SELECT '' AS to_char_11, to_char(q2, 'FM0999') FROM 
INT8_TBL ;
  to_char_11 |  to_char  
 +---
-| 0123
 | 0456
 | 4567890123456789
+| 0123
 | 4567890123456789
 | -4567890123456789
 (5 rows)
 
 SELECT '' AS to_char_12, to_char(q2, 'FM.000') FROM 
INT8_TBL ;
  to_char_12 |to_char
 +---
-| 123.000
 | 456.000
-| -4567890123456789.000
 | 4567890123456789.000
+| 123.000
 | 4567890123456789.000
+| -4567890123456789.000
 (5 rows)
 
 SELECT '' AS to_char_13, to_char(q2, 'L.000')  FROM 
INT8_TBL ;
  to_char_13 |to_char 
 +
-|123.000
-|456.000
-|   4567890123456789.000
-|   4567890123456789.000
-|  -4567890123456789.000
+| $  456.000
+| $ 4567890123456789.000
+| $  123.000
+| $ 4567890123456789.000
+| $-4567890123456789.000
--- End diff --

I looked into this. I is related to currency info of the locale. You are 
right this probably need a bit more work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (HAWQ-917) Refactor feature tests for data type check with new googletest framework

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374258#comment-15374258
 ] 

ASF GitHub Bot commented on HAWQ-917:
-

Github user xunzhang commented on the issue:

https://github.com/apache/incubator-hawq/pull/787
  
@paul-guo- , LGTM except above comments. Another comments is that according 
to the folders names defined by @yaoj2 , I suggest you to move your test cases 
into `catalog` folder instead of independent `type`.


> Refactor feature tests for data type check with new googletest framework
> 
>
> Key: HAWQ-917
> URL: https://issues.apache.org/jira/browse/HAWQ-917
> Project: Apache HAWQ
>  Issue Type: Sub-task
>Reporter: Paul Guo
>Assignee: Paul Guo
>
> This needs to refactor the following 15 test cases.
> ../../../regress/sql/boolean.sql
> ../../../regress/sql/char.sql
> ../../../regress/sql/date.sql
> ../../../regress/sql/float4.sql
> ../../../regress/sql/float8.sql
> ../../../regress/sql/int2.sql
> ../../../regress/sql/int4.sql
> ../../../regress/sql/int8.sql
> ../../../regress/sql/money.sql
> ../../../regress/sql/name.sql
> ../../../regress/sql/oid.sql
> ../../../regress/sql/text.sql
> ../../../regress/sql/time.sql
> ../../../regress/sql/type_sanity.sql
> ../../../regress/sql/varchar.sql



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-hawq issue #787: HAWQ-917. Refactor feature tests for data type ch...

[xunzhang]

Github user xunzhang commented on the issue:

https://github.com/apache/incubator-hawq/pull/787
  
@paul-guo- , LGTM except above comments. Another comments is that according 
to the folders names defined by @yaoj2 , I suggest you to move your test cases 
into `catalog` folder instead of independent `type`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Resolved] (HAWQ-918) Fix memtuple forming bug when null-saved size is larger than 32763 bytes

[Lin Wen (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lin Wen resolved HAWQ-918.
--
Resolution: Fixed

> Fix memtuple forming bug when null-saved size is larger than 32763 bytes
> 
>
> Key: HAWQ-918
> URL: https://issues.apache.org/jira/browse/HAWQ-918
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Query Execution
>Reporter: Lin Wen
>Assignee: Lin Wen
> Attachments: run.sql
>
>
> When run a sql, an error happens in QE:
> psql:run.sql:24: ERROR:  Query Executor Error in seg2 localhost:4 
> pid=55810: server closed the connection unexpectedly
> DETAIL:
>   This probably means the server terminated abnormally
>   before or while processing the request.
> 2016-07-13 00:21:53.951987 CST,,,p34013,th0,,,2016-07-13 00:21:29 
> CST,0,con33,cmd33,seg1,slice2"PANIC","XX000","Unexpected internal error: 
> Segment process received signal SIGSEGV",,,0"10x8b764e postgres 
>  + 0x8b764e
> 20x3b66e0f710 libpthread.so.0  + 0x66e0f710
> 30x3b6668995b libc.so.6 memcpy + 0x2eb
> 40x8940d8 postgres textout + 0x58
> 50x8c32d7 postgres DirectFunctionCall1 + 0x47
> 60x88a126 postgres text_timestamp + 0xc6
> 70x669b47 postgres  + 0x669b47
> 80x669fe9 postgres  + 0x669fe9
> 90x66f54e postgres ExecProject + 0x23e
> 10   0x680695 postgres ExecAgg + 0x525
> 11   0x6643b1 postgres ExecProcNode + 0x221
> 12   0x689da8 postgres ExecLimit + 0x218
> 13   0x664521 postgres ExecProcNode + 0x391
> 14   0x68d549 postgres ExecMotion + 0x39
> 15   0x6643c1 postgres ExecProcNode + 0x231
> 16   0x660752 postgres  + 0x660752
> 17   0x6610ea postgres ExecutorRun + 0x4ca
> 18   0x7e4c3a postgres PortalRun + 0x58a
> 19   0x7dab64 postgres  + 0x7dab64
> 20   0x7dfaf5 postgres PostgresMain + 0x2b65
> 21   0x790e7f postgres  + 0x790e7f
> 22   0x793b39 postgres PostmasterMain + 0x759
> 23   0x4a19cf postgres main + 0x50f
> 24   0x3b6661ed5d libc.so.6 __libc_start_main + 0xfd
> 25   0x4a1a4d postgres  + 0x4a1a4d



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HAWQ-917) Refactor feature tests for data type check with new googletest framework

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374211#comment-15374211
 ] 

ASF GitHub Bot commented on HAWQ-917:
-

Github user paul-guo- commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/787#discussion_r70556890
  
--- Diff: src/test/feature/type/TestType.cpp ---
@@ -0,0 +1,77 @@
+#include "gtest/gtest.h"
+
+#include "lib/sql_util.h"
+
+using std::string;
--- End diff --

It could compile without this. sql_util.h has included . Do we 
really need to include this?


> Refactor feature tests for data type check with new googletest framework
> 
>
> Key: HAWQ-917
> URL: https://issues.apache.org/jira/browse/HAWQ-917
> Project: Apache HAWQ
>  Issue Type: Sub-task
>Reporter: Paul Guo
>Assignee: Paul Guo
>
> This needs to refactor the following 15 test cases.
> ../../../regress/sql/boolean.sql
> ../../../regress/sql/char.sql
> ../../../regress/sql/date.sql
> ../../../regress/sql/float4.sql
> ../../../regress/sql/float8.sql
> ../../../regress/sql/int2.sql
> ../../../regress/sql/int4.sql
> ../../../regress/sql/int8.sql
> ../../../regress/sql/money.sql
> ../../../regress/sql/name.sql
> ../../../regress/sql/oid.sql
> ../../../regress/sql/text.sql
> ../../../regress/sql/time.sql
> ../../../regress/sql/type_sanity.sql
> ../../../regress/sql/varchar.sql



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-hawq pull request #787: HAWQ-917. Refactor feature tests for data ...

[xunzhang]

Github user xunzhang commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/787#discussion_r70556754
  
--- Diff: src/test/feature/type/TestType.cpp ---
@@ -0,0 +1,77 @@
+#include "gtest/gtest.h"
+
+#include "lib/sql_util.h"
+
+using std::string;
--- End diff --

add `#incude `


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (HAWQ-917) Refactor feature tests for data type check with new googletest framework

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374203#comment-15374203
 ] 

ASF GitHub Bot commented on HAWQ-917:
-

Github user xunzhang commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/787#discussion_r70556665
  
--- Diff: src/test/feature/type/ans/int8.ans ---
@@ -175,131 +179,131 @@ SELECT '' AS to_char_4, to_char( (q1 * -1), 
'S'), to_char( (q2 *
 SELECT '' AS to_char_5,  to_char(q2, 'MI') FROM 
INT8_TBL  ;
  to_char_5 |  to_char  
 ---+---
-   |   123
|   456
|  4567890123456789
+   |   123
|  4567890123456789
| -4567890123456789
 (5 rows)
 
 SELECT '' AS to_char_6,  to_char(q2, 'FMS')FROM 
INT8_TBL  ;
  to_char_6 |  to_char  
 ---+---
-   | +123
| +456
-   | -4567890123456789
| +4567890123456789
+   | +123
| +4567890123456789
+   | -4567890123456789
 (5 rows)
 
 SELECT '' AS to_char_7,  to_char(q2, 'FMTHPR') FROM 
INT8_TBL ;
  to_char_7 |  to_char   
 ---+
-   | 123RD
-   | <4567890123456789>
+   | 456TH
| 4567890123456789TH
+   | 123RD
| 4567890123456789TH
-   | 456TH
+   | <4567890123456789>
 (5 rows)
 
 SELECT '' AS to_char_8,  to_char(q2, 'SGth')   FROM 
INT8_TBL ;
  to_char_8 |   to_char   
 ---+-
-   | + 123rd
-   | -4567890123456789
+   | + 456th
| +4567890123456789th
+   | + 123rd
| +4567890123456789th
-   | + 456th
+   | -4567890123456789
 (5 rows)
 
 SELECT '' AS to_char_9,  to_char(q2, '0999')   FROM 
INT8_TBL ;
  to_char_9 |  to_char  
 ---+---
-   |  0123
|  0456
|  4567890123456789
+   |  0123
|  4567890123456789
| -4567890123456789
 (5 rows)
 
 SELECT '' AS to_char_10, to_char(q2, 'S0999')  FROM 
INT8_TBL ;
  to_char_10 |  to_char  
 +---
-| +0123
 | +0456
-| -4567890123456789
 | +4567890123456789
+| +0123
 | +4567890123456789
+| -4567890123456789
 (5 rows)
 
 SELECT '' AS to_char_11, to_char(q2, 'FM0999') FROM 
INT8_TBL ;
  to_char_11 |  to_char  
 +---
-| 0123
 | 0456
 | 4567890123456789
+| 0123
 | 4567890123456789
 | -4567890123456789
 (5 rows)
 
 SELECT '' AS to_char_12, to_char(q2, 'FM.000') FROM 
INT8_TBL ;
  to_char_12 |to_char
 +---
-| 123.000
 | 456.000
-| -4567890123456789.000
 | 4567890123456789.000
+| 123.000
 | 4567890123456789.000
+| -4567890123456789.000
 (5 rows)
 
 SELECT '' AS to_char_13, to_char(q2, 'L.000')  FROM 
INT8_TBL ;
  to_char_13 |to_char 
 +
-|123.000
-|456.000
-|   4567890123456789.000
-|   4567890123456789.000
-|  -4567890123456789.000
+| $  456.000
+| $ 4567890123456789.000
+| $  123.000
+| $ 4567890123456789.000
+| $-4567890123456789.000
--- End diff --

Why did you add `$` sign here?


> Refactor feature tests for data type check with new googletest framework
> 
>
> Key: HAWQ-917
> URL: https://issues.apache.org/jira/browse/HAWQ-917
> Project: Apache HAWQ
>  Issue Type: Sub-task
>Reporter: Paul Guo
>Assignee: Paul Guo
>
> This needs to refactor the following 15 test cases.
> 

[GitHub] incubator-hawq pull request #787: HAWQ-917. Refactor feature tests for data ...

[xunzhang]

Github user xunzhang commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/787#discussion_r70556665
  
--- Diff: src/test/feature/type/ans/int8.ans ---
@@ -175,131 +179,131 @@ SELECT '' AS to_char_4, to_char( (q1 * -1), 
'S'), to_char( (q2 *
 SELECT '' AS to_char_5,  to_char(q2, 'MI') FROM 
INT8_TBL  ;
  to_char_5 |  to_char  
 ---+---
-   |   123
|   456
|  4567890123456789
+   |   123
|  4567890123456789
| -4567890123456789
 (5 rows)
 
 SELECT '' AS to_char_6,  to_char(q2, 'FMS')FROM 
INT8_TBL  ;
  to_char_6 |  to_char  
 ---+---
-   | +123
| +456
-   | -4567890123456789
| +4567890123456789
+   | +123
| +4567890123456789
+   | -4567890123456789
 (5 rows)
 
 SELECT '' AS to_char_7,  to_char(q2, 'FMTHPR') FROM 
INT8_TBL ;
  to_char_7 |  to_char   
 ---+
-   | 123RD
-   | <4567890123456789>
+   | 456TH
| 4567890123456789TH
+   | 123RD
| 4567890123456789TH
-   | 456TH
+   | <4567890123456789>
 (5 rows)
 
 SELECT '' AS to_char_8,  to_char(q2, 'SGth')   FROM 
INT8_TBL ;
  to_char_8 |   to_char   
 ---+-
-   | + 123rd
-   | -4567890123456789
+   | + 456th
| +4567890123456789th
+   | + 123rd
| +4567890123456789th
-   | + 456th
+   | -4567890123456789
 (5 rows)
 
 SELECT '' AS to_char_9,  to_char(q2, '0999')   FROM 
INT8_TBL ;
  to_char_9 |  to_char  
 ---+---
-   |  0123
|  0456
|  4567890123456789
+   |  0123
|  4567890123456789
| -4567890123456789
 (5 rows)
 
 SELECT '' AS to_char_10, to_char(q2, 'S0999')  FROM 
INT8_TBL ;
  to_char_10 |  to_char  
 +---
-| +0123
 | +0456
-| -4567890123456789
 | +4567890123456789
+| +0123
 | +4567890123456789
+| -4567890123456789
 (5 rows)
 
 SELECT '' AS to_char_11, to_char(q2, 'FM0999') FROM 
INT8_TBL ;
  to_char_11 |  to_char  
 +---
-| 0123
 | 0456
 | 4567890123456789
+| 0123
 | 4567890123456789
 | -4567890123456789
 (5 rows)
 
 SELECT '' AS to_char_12, to_char(q2, 'FM.000') FROM 
INT8_TBL ;
  to_char_12 |to_char
 +---
-| 123.000
 | 456.000
-| -4567890123456789.000
 | 4567890123456789.000
+| 123.000
 | 4567890123456789.000
+| -4567890123456789.000
 (5 rows)
 
 SELECT '' AS to_char_13, to_char(q2, 'L.000')  FROM 
INT8_TBL ;
  to_char_13 |to_char 
 +
-|123.000
-|456.000
-|   4567890123456789.000
-|   4567890123456789.000
-|  -4567890123456789.000
+| $  456.000
+| $ 4567890123456789.000
+| $  123.000
+| $ 4567890123456789.000
+| $-4567890123456789.000
--- End diff --

Why did you add `$` sign here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (HAWQ-917) Refactor feature tests for data type check with new googletest framework

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374199#comment-15374199
 ] 

ASF GitHub Bot commented on HAWQ-917:
-

Github user wengyanqing commented on the issue:

https://github.com/apache/incubator-hawq/pull/787
  
LGTM


> Refactor feature tests for data type check with new googletest framework
> 
>
> Key: HAWQ-917
> URL: https://issues.apache.org/jira/browse/HAWQ-917
> Project: Apache HAWQ
>  Issue Type: Sub-task
>Reporter: Paul Guo
>Assignee: Paul Guo
>
> This needs to refactor the following 15 test cases.
> ../../../regress/sql/boolean.sql
> ../../../regress/sql/char.sql
> ../../../regress/sql/date.sql
> ../../../regress/sql/float4.sql
> ../../../regress/sql/float8.sql
> ../../../regress/sql/int2.sql
> ../../../regress/sql/int4.sql
> ../../../regress/sql/int8.sql
> ../../../regress/sql/money.sql
> ../../../regress/sql/name.sql
> ../../../regress/sql/oid.sql
> ../../../regress/sql/text.sql
> ../../../regress/sql/time.sql
> ../../../regress/sql/type_sanity.sql
> ../../../regress/sql/varchar.sql



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-hawq issue #787: HAWQ-917. Refactor feature tests for data type ch...

[wengyanqing]

Github user wengyanqing commented on the issue:

https://github.com/apache/incubator-hawq/pull/787
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Closed] (HAWQ-19) Money type overflow

[Lei Chang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lei Chang closed HAWQ-19.
-
Resolution: Fixed

It is already in.

> Money type overflow
> ---
>
> Key: HAWQ-19
> URL: https://issues.apache.org/jira/browse/HAWQ-19
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Catalog
>Reporter: Feng Tian
>Assignee: Ming LI
> Fix For: 2.0.0.0-incubating
>
>
> Use tpch schema, but change l_extendedprice to use MONEY type, run Q1, you 
> should see negative amounts.   
> I believe this is due to overflow.
> Side mark, postgres 9 money type use 8 bytes and will return correct result.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HAWQ-19) Money type overflow

[Lei Chang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lei Chang updated HAWQ-19:
--
Fix Version/s: (was: 2.0.0)
   2.0.0.0-incubating

> Money type overflow
> ---
>
> Key: HAWQ-19
> URL: https://issues.apache.org/jira/browse/HAWQ-19
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Catalog
>Reporter: Feng Tian
>Assignee: Ming LI
> Fix For: 2.0.0.0-incubating
>
>
> Use tpch schema, but change l_extendedprice to use MONEY type, run Q1, you 
> should see negative amounts.   
> I believe this is due to overflow.
> Side mark, postgres 9 money type use 8 bytes and will return correct result.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HAWQ-918) Fix memtuple forming bug when null-saved size is larger than 32763 bytes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374159#comment-15374159
 ] 

ASF GitHub Bot commented on HAWQ-918:
-

Github user linwen closed the pull request at:

https://github.com/apache/incubator-hawq/pull/789


> Fix memtuple forming bug when null-saved size is larger than 32763 bytes
> 
>
> Key: HAWQ-918
> URL: https://issues.apache.org/jira/browse/HAWQ-918
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Query Execution
>Reporter: Lin Wen
>Assignee: Lin Wen
> Attachments: run.sql
>
>
> When run a sql, an error happens in QE:
> psql:run.sql:24: ERROR:  Query Executor Error in seg2 localhost:4 
> pid=55810: server closed the connection unexpectedly
> DETAIL:
>   This probably means the server terminated abnormally
>   before or while processing the request.
> 2016-07-13 00:21:53.951987 CST,,,p34013,th0,,,2016-07-13 00:21:29 
> CST,0,con33,cmd33,seg1,slice2"PANIC","XX000","Unexpected internal error: 
> Segment process received signal SIGSEGV",,,0"10x8b764e postgres 
>  + 0x8b764e
> 20x3b66e0f710 libpthread.so.0  + 0x66e0f710
> 30x3b6668995b libc.so.6 memcpy + 0x2eb
> 40x8940d8 postgres textout + 0x58
> 50x8c32d7 postgres DirectFunctionCall1 + 0x47
> 60x88a126 postgres text_timestamp + 0xc6
> 70x669b47 postgres  + 0x669b47
> 80x669fe9 postgres  + 0x669fe9
> 90x66f54e postgres ExecProject + 0x23e
> 10   0x680695 postgres ExecAgg + 0x525
> 11   0x6643b1 postgres ExecProcNode + 0x221
> 12   0x689da8 postgres ExecLimit + 0x218
> 13   0x664521 postgres ExecProcNode + 0x391
> 14   0x68d549 postgres ExecMotion + 0x39
> 15   0x6643c1 postgres ExecProcNode + 0x231
> 16   0x660752 postgres  + 0x660752
> 17   0x6610ea postgres ExecutorRun + 0x4ca
> 18   0x7e4c3a postgres PortalRun + 0x58a
> 19   0x7dab64 postgres  + 0x7dab64
> 20   0x7dfaf5 postgres PostgresMain + 0x2b65
> 21   0x790e7f postgres  + 0x790e7f
> 22   0x793b39 postgres PostmasterMain + 0x759
> 23   0x4a19cf postgres main + 0x50f
> 24   0x3b6661ed5d libc.so.6 __libc_start_main + 0xfd
> 25   0x4a1a4d postgres  + 0x4a1a4d



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-hawq pull request #789: HAWQ-918. Fix memtuple forming bug when nu...

[linwen]

Github user linwen closed the pull request at:

https://github.com/apache/incubator-hawq/pull/789


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (HAWQ-918) Fix memtuple forming bug when null-saved size is larger than 32763 bytes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374142#comment-15374142
 ] 

ASF GitHub Bot commented on HAWQ-918:
-

Github user huor commented on the issue:

https://github.com/apache/incubator-hawq/pull/789
  
+1


> Fix memtuple forming bug when null-saved size is larger than 32763 bytes
> 
>
> Key: HAWQ-918
> URL: https://issues.apache.org/jira/browse/HAWQ-918
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Query Execution
>Reporter: Lin Wen
>Assignee: Lin Wen
> Attachments: run.sql
>
>
> When run a sql, an error happens in QE:
> psql:run.sql:24: ERROR:  Query Executor Error in seg2 localhost:4 
> pid=55810: server closed the connection unexpectedly
> DETAIL:
>   This probably means the server terminated abnormally
>   before or while processing the request.
> 2016-07-13 00:21:53.951987 CST,,,p34013,th0,,,2016-07-13 00:21:29 
> CST,0,con33,cmd33,seg1,slice2"PANIC","XX000","Unexpected internal error: 
> Segment process received signal SIGSEGV",,,0"10x8b764e postgres 
>  + 0x8b764e
> 20x3b66e0f710 libpthread.so.0  + 0x66e0f710
> 30x3b6668995b libc.so.6 memcpy + 0x2eb
> 40x8940d8 postgres textout + 0x58
> 50x8c32d7 postgres DirectFunctionCall1 + 0x47
> 60x88a126 postgres text_timestamp + 0xc6
> 70x669b47 postgres  + 0x669b47
> 80x669fe9 postgres  + 0x669fe9
> 90x66f54e postgres ExecProject + 0x23e
> 10   0x680695 postgres ExecAgg + 0x525
> 11   0x6643b1 postgres ExecProcNode + 0x221
> 12   0x689da8 postgres ExecLimit + 0x218
> 13   0x664521 postgres ExecProcNode + 0x391
> 14   0x68d549 postgres ExecMotion + 0x39
> 15   0x6643c1 postgres ExecProcNode + 0x231
> 16   0x660752 postgres  + 0x660752
> 17   0x6610ea postgres ExecutorRun + 0x4ca
> 18   0x7e4c3a postgres PortalRun + 0x58a
> 19   0x7dab64 postgres  + 0x7dab64
> 20   0x7dfaf5 postgres PostgresMain + 0x2b65
> 21   0x790e7f postgres  + 0x790e7f
> 22   0x793b39 postgres PostmasterMain + 0x759
> 23   0x4a19cf postgres main + 0x50f
> 24   0x3b6661ed5d libc.so.6 __libc_start_main + 0xfd
> 25   0x4a1a4d postgres  + 0x4a1a4d



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-hawq issue #789: HAWQ-918. Fix memtuple forming bug when null-save...

[huor]

Github user huor commented on the issue:

https://github.com/apache/incubator-hawq/pull/789
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (HAWQ-171) Upgrade PXF to Java 8

[Shivram Mani (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shivram Mani updated HAWQ-171:
--
Fix Version/s: (was: 2.0.0)
   backlog

> Upgrade PXF to Java 8
> -
>
> Key: HAWQ-171
> URL: https://issues.apache.org/jira/browse/HAWQ-171
> Project: Apache HAWQ
>  Issue Type: Improvement
>  Components: PXF
>Reporter: Shivram Mani
>Assignee: Shivram Mani
> Fix For: backlog
>
>
> JDK 8 has introduced a slew of new features including support for a Stream 
> API, lambda expressions and security and performance improvements. Updating 
> PXF to use JDK8 would allow us to benefit using these improvements.
> Overview of changes intorduced in JDK8 
> http://www.oracle.com/technetwork/java/javase/8-whats-new-2157071.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-hawq pull request #788: HAWQ-915. RAT is failing on the latest mas...

[paul-guo-]

Github user paul-guo- commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/788#discussion_r70552418
  
--- Diff: pom.xml ---
@@ -37,14 +37,32 @@
   
   tools/bin/src/stream/* 
 
-  
+  
+  
   tools/bin/pythonSrc/PyGreSQL-4.0/**
+  tools/bin/pythonSrc/PSI-0.3b2_gp/**
+  tools/bin/pythonSrc/lockfile-0.9.1/**
+  
+  tools/bin/pythonSrc/pychecker-0.8.18/**
+  tools/bin/pythonSrc/unittest2-0.5.1/**
--- End diff --

PKG-INFO is wrong (just noticed).

tools/bin/pythonSrc/unittest2-0.5.1]$ head setup.py

#! /usr/bin/env python
# setup.py
# Install script for unittest2
# Copyright (C) 2010 Michael Foord
# E-mail: fuzzyman AT voidspace DOT org DOT uk

# This software is licensed under the terms of the BSD license.
# http://www.voidspace.org.uk/python/license.shtml

import os

2016-07-13 7:58 GMT+08:00 Roman V Shaposhnik :

> In pom.xml
> :
>
> >tools/bin/pythonSrc/PyGreSQL-4.0/**
> > +  tools/bin/pythonSrc/PSI-0.3b2_gp/**
> > +  tools/bin/pythonSrc/lockfile-0.9.1/**
> > +  
> > +  
tools/bin/pythonSrc/pychecker-0.8.18/**
> > +  tools/bin/pythonSrc/unittest2-0.5.1/**
>
> unittest2-0.5.1/PKG-INFO says License is unknown. Please provide support
> for your claim that this is a BSD licensed code.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> 
,
> or mute the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (HAWQ-915) RAT is failing on the latest master

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374140#comment-15374140
 ] 

ASF GitHub Bot commented on HAWQ-915:
-

Github user paul-guo- commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/788#discussion_r70552418
  
--- Diff: pom.xml ---
@@ -37,14 +37,32 @@
   
   tools/bin/src/stream/* 
 
-  
+  
+  
   tools/bin/pythonSrc/PyGreSQL-4.0/**
+  tools/bin/pythonSrc/PSI-0.3b2_gp/**
+  tools/bin/pythonSrc/lockfile-0.9.1/**
+  
+  tools/bin/pythonSrc/pychecker-0.8.18/**
+  tools/bin/pythonSrc/unittest2-0.5.1/**
--- End diff --

PKG-INFO is wrong (just noticed).

tools/bin/pythonSrc/unittest2-0.5.1]$ head setup.py

#! /usr/bin/env python
# setup.py
# Install script for unittest2
# Copyright (C) 2010 Michael Foord
# E-mail: fuzzyman AT voidspace DOT org DOT uk

# This software is licensed under the terms of the BSD license.
# http://www.voidspace.org.uk/python/license.shtml

import os

2016-07-13 7:58 GMT+08:00 Roman V Shaposhnik :

> In pom.xml
> :
>
> >tools/bin/pythonSrc/PyGreSQL-4.0/**
> > +  tools/bin/pythonSrc/PSI-0.3b2_gp/**
> > +  tools/bin/pythonSrc/lockfile-0.9.1/**
> > +  
> > +  
tools/bin/pythonSrc/pychecker-0.8.18/**
> > +  tools/bin/pythonSrc/unittest2-0.5.1/**
>
> unittest2-0.5.1/PKG-INFO says License is unknown. Please provide support
> for your claim that this is a BSD licensed code.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> 
,
> or mute the thread
> 

> .
>



> RAT is failing on the latest master
> ---
>
> Key: HAWQ-915
> URL: https://issues.apache.org/jira/browse/HAWQ-915
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Build
>Affects Versions: 2.0.0.0-incubating
>Reporter: Roman Shaposhnik
>Assignee: Lei Chang
>Priority: Blocker
> Fix For: 2.0.0.0-incubating
>
> Attachments: rat.txt
>
>
> Running RAT (via the usual mvn verify) on the current tree produces quite a 
> bit of hits on the source code added lately to the HAWQ's repo. The full 
> report is attached. This is a blocking JIRA for 2.0.0.0-incubating. PMC 
> members should very carefully go over the RAT report and either get rid of 
> offending code, update the licensing information or include it into the RAT 
> exclusion list. The later has to have explicit explanation of why the code 
> has to reside in the HAWQ repo as opposed to being a dependency.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HAWQ-19) Money type overflow

[Vineet Goel (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374128#comment-15374128
 ] 

Vineet Goel commented on HAWQ-19:
-

[~liming01] and [~ftian] - does this JIRA need to be targeted for 
"2.0.0.0-incubating" release? If not, we should change the Fix Version to 
"backlog" or another release. Please update the JIRA Fix Version field soon so 
"2.0.0.0-incubating" is not blocked.

> Money type overflow
> ---
>
> Key: HAWQ-19
> URL: https://issues.apache.org/jira/browse/HAWQ-19
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Catalog
>Reporter: Feng Tian
>Assignee: Ming LI
> Fix For: 2.0.0
>
>
> Use tpch schema, but change l_extendedprice to use MONEY type, run Q1, you 
> should see negative amounts.   
> I believe this is due to overflow.
> Side mark, postgres 9 money type use 8 bytes and will return correct result.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HAWQ-215) View gp_distributed_log and gp_distributed_xacts need to be removed if we don't want to support it anymore.

[Vineet Goel (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374110#comment-15374110
 ] 

Vineet Goel commented on HAWQ-215:
--

[~liming01] and [~doli] does this JIRA need to be targeted for 
"2.0.0.0-incubating" release? If not, we should change the Fix Version to 
"backlog" or another release. Please update the JIRA Fix Version field soon so 
"2.0.0.0-incubating" is not blocked.

> View gp_distributed_log and gp_distributed_xacts need to be removed if we 
> don't want to support it anymore.
> ---
>
> Key: HAWQ-215
> URL: https://issues.apache.org/jira/browse/HAWQ-215
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Catalog
>Reporter: Dong Li
>Assignee: Ming LI
> Fix For: 2.0.0
>
>
> View gp_distributed_log   depends on built-in function gp_distributed_log(). 
> And  gp_distributed_log() just return null. So the view can't work at all.
> So do view gp_distributed_xacts.
> {code}
> e=# select * from gp_distributed_log;
> ERROR:  function returning set of rows cannot return null value
> e=# select * from gp_distributed_xacts;
> ERROR:  function returning set of rows cannot return null value
> {code}
> function gp_distributed_log is defined in gp_distributed_log.c :27
> function gp_distributed_xacts  is defined in cdbdistributedxacts.c:44



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HAWQ-915) RAT is failing on the latest master

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374011#comment-15374011
 ] 

ASF GitHub Bot commented on HAWQ-915:
-

Github user rvs commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/788#discussion_r70544736
  
--- Diff: pom.xml ---
@@ -112,6 +130,10 @@
however it is tricky to maintain headers in them -->
   depends/libyarn/test/data/*
 
+  
+  depends/libhdfs3/test/data/*
+   depends/libhdfs3/debian/**
--- End diff --

a small nit: please fix a spurious whitespace


> RAT is failing on the latest master
> ---
>
> Key: HAWQ-915
> URL: https://issues.apache.org/jira/browse/HAWQ-915
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Build
>Affects Versions: 2.0.0.0-incubating
>Reporter: Roman Shaposhnik
>Assignee: Lei Chang
>Priority: Blocker
> Fix For: 2.0.0.0-incubating
>
> Attachments: rat.txt
>
>
> Running RAT (via the usual mvn verify) on the current tree produces quite a 
> bit of hits on the source code added lately to the HAWQ's repo. The full 
> report is attached. This is a blocking JIRA for 2.0.0.0-incubating. PMC 
> members should very carefully go over the RAT report and either get rid of 
> offending code, update the licensing information or include it into the RAT 
> exclusion list. The later has to have explicit explanation of why the code 
> has to reside in the HAWQ repo as opposed to being a dependency.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-hawq pull request #788: HAWQ-915. RAT is failing on the latest mas...

[rvs]

Github user rvs commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/788#discussion_r70544736
  
--- Diff: pom.xml ---
@@ -112,6 +130,10 @@
however it is tricky to maintain headers in them -->
   depends/libyarn/test/data/*
 
+  
+  depends/libhdfs3/test/data/*
+   depends/libhdfs3/debian/**
--- End diff --

a small nit: please fix a spurious whitespace


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #788: HAWQ-915. RAT is failing on the latest mas...

[rvs]

Github user rvs commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/788#discussion_r70544691
  
--- Diff: pom.xml ---
@@ -37,14 +37,32 @@
   
   tools/bin/src/stream/* 
 
-  
+  
+  
   tools/bin/pythonSrc/PyGreSQL-4.0/**
+  tools/bin/pythonSrc/PSI-0.3b2_gp/**
+  tools/bin/pythonSrc/lockfile-0.9.1/**
+  
+  tools/bin/pythonSrc/pychecker-0.8.18/**
+  tools/bin/pythonSrc/unittest2-0.5.1/**
+  
+  tools/bin/pythonSrc/pycrypto-2.0.1/**
+  
+  tools/bin/ext/**
+
+  
+  depends/thirdparty/thrift/**
+
+  
+  depends/thirdparty/googletest/**
 
   
   depends/libyarn/CMake/FindBoost.cmake
   depends/libyarn/CMake/FindGSasl.cmake
   depends/libyarn/CMake/FindKERBEROS.cmake
+ 
depends/libyarn/CMake/FindGoogleTest.cmake
--- End diff --

Where did this file come from? If you wrote it, please add AL header to it. 
If not -- indicate where it came from.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (HAWQ-915) RAT is failing on the latest master

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374004#comment-15374004
 ] 

ASF GitHub Bot commented on HAWQ-915:
-

Github user rvs commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/788#discussion_r70544564
  
--- Diff: pom.xml ---
@@ -37,14 +37,32 @@
   
   tools/bin/src/stream/* 
 
-  
+  
+  
   tools/bin/pythonSrc/PyGreSQL-4.0/**
+  tools/bin/pythonSrc/PSI-0.3b2_gp/**
+  tools/bin/pythonSrc/lockfile-0.9.1/**
+  
+  tools/bin/pythonSrc/pychecker-0.8.18/**
+  tools/bin/pythonSrc/unittest2-0.5.1/**
+  
+  tools/bin/pythonSrc/pycrypto-2.0.1/**
+  
+  tools/bin/ext/**
+
+  
+  depends/thirdparty/thrift/**
--- End diff --

What exactly is RAT complaining about? For ASF code this should not be a 
problem.


> RAT is failing on the latest master
> ---
>
> Key: HAWQ-915
> URL: https://issues.apache.org/jira/browse/HAWQ-915
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Build
>Affects Versions: 2.0.0.0-incubating
>Reporter: Roman Shaposhnik
>Assignee: Lei Chang
>Priority: Blocker
> Fix For: 2.0.0.0-incubating
>
> Attachments: rat.txt
>
>
> Running RAT (via the usual mvn verify) on the current tree produces quite a 
> bit of hits on the source code added lately to the HAWQ's repo. The full 
> report is attached. This is a blocking JIRA for 2.0.0.0-incubating. PMC 
> members should very carefully go over the RAT report and either get rid of 
> offending code, update the licensing information or include it into the RAT 
> exclusion list. The later has to have explicit explanation of why the code 
> has to reside in the HAWQ repo as opposed to being a dependency.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-hawq pull request #788: HAWQ-915. RAT is failing on the latest mas...

[rvs]

Github user rvs commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/788#discussion_r70544706
  
--- Diff: pom.xml ---
@@ -37,14 +37,32 @@
   
   tools/bin/src/stream/* 
 
-  
+  
+  
   tools/bin/pythonSrc/PyGreSQL-4.0/**
+  tools/bin/pythonSrc/PSI-0.3b2_gp/**
+  tools/bin/pythonSrc/lockfile-0.9.1/**
+  
+  tools/bin/pythonSrc/pychecker-0.8.18/**
+  tools/bin/pythonSrc/unittest2-0.5.1/**
+  
+  tools/bin/pythonSrc/pycrypto-2.0.1/**
+  
+  tools/bin/ext/**
+
+  
+  depends/thirdparty/thrift/**
+
+  
+  depends/thirdparty/googletest/**
 
   
   depends/libyarn/CMake/FindBoost.cmake
   depends/libyarn/CMake/FindGSasl.cmake
   depends/libyarn/CMake/FindKERBEROS.cmake
+ 
depends/libyarn/CMake/FindGoogleTest.cmake
  
depends/libhdfs3/CMake/FindBoost.cmake
+ 
depends/libhdfs3/CMake/FindGoogleTest.cmake
--- End diff --

Where did this file come from? If you wrote it, please add AL header to it. 
If not -- indicate where it came from.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (HAWQ-915) RAT is failing on the latest master

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374002#comment-15374002
 ] 

ASF GitHub Bot commented on HAWQ-915:
-

Github user rvs commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/788#discussion_r70544521
  
--- Diff: pom.xml ---
@@ -37,14 +37,32 @@
   
   tools/bin/src/stream/* 
 
-  
+  
+  
   tools/bin/pythonSrc/PyGreSQL-4.0/**
+  tools/bin/pythonSrc/PSI-0.3b2_gp/**
+  tools/bin/pythonSrc/lockfile-0.9.1/**
+  
+  tools/bin/pythonSrc/pychecker-0.8.18/**
+  tools/bin/pythonSrc/unittest2-0.5.1/**
+  
+  tools/bin/pythonSrc/pycrypto-2.0.1/**
+  
+  tools/bin/ext/**
--- End diff --

I am no comfortable with bulk exclusion here, especially since the code is 
Crypto related in one of the folders


> RAT is failing on the latest master
> ---
>
> Key: HAWQ-915
> URL: https://issues.apache.org/jira/browse/HAWQ-915
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Build
>Affects Versions: 2.0.0.0-incubating
>Reporter: Roman Shaposhnik
>Assignee: Lei Chang
>Priority: Blocker
> Fix For: 2.0.0.0-incubating
>
> Attachments: rat.txt
>
>
> Running RAT (via the usual mvn verify) on the current tree produces quite a 
> bit of hits on the source code added lately to the HAWQ's repo. The full 
> report is attached. This is a blocking JIRA for 2.0.0.0-incubating. PMC 
> members should very carefully go over the RAT report and either get rid of 
> offending code, update the licensing information or include it into the RAT 
> exclusion list. The later has to have explicit explanation of why the code 
> has to reside in the HAWQ repo as opposed to being a dependency.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-hawq pull request #788: HAWQ-915. RAT is failing on the latest mas...

[rvs]

Github user rvs commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/788#discussion_r70544564
  
--- Diff: pom.xml ---
@@ -37,14 +37,32 @@
   
   tools/bin/src/stream/* 
 
-  
+  
+  
   tools/bin/pythonSrc/PyGreSQL-4.0/**
+  tools/bin/pythonSrc/PSI-0.3b2_gp/**
+  tools/bin/pythonSrc/lockfile-0.9.1/**
+  
+  tools/bin/pythonSrc/pychecker-0.8.18/**
+  tools/bin/pythonSrc/unittest2-0.5.1/**
+  
+  tools/bin/pythonSrc/pycrypto-2.0.1/**
+  
+  tools/bin/ext/**
+
+  
+  depends/thirdparty/thrift/**
--- End diff --

What exactly is RAT complaining about? For ASF code this should not be a 
problem.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (HAWQ-915) RAT is failing on the latest master

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374001#comment-15374001
 ] 

ASF GitHub Bot commented on HAWQ-915:
-

Github user rvs commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/788#discussion_r70544439
  
--- Diff: pom.xml ---
@@ -37,14 +37,32 @@
   
   tools/bin/src/stream/* 
 
-  
+  
+  
   tools/bin/pythonSrc/PyGreSQL-4.0/**
+  tools/bin/pythonSrc/PSI-0.3b2_gp/**
+  tools/bin/pythonSrc/lockfile-0.9.1/**
+  
+  tools/bin/pythonSrc/pychecker-0.8.18/**
+  tools/bin/pythonSrc/unittest2-0.5.1/**
+  
--- End diff --

I am not sure this is ASF compatible since this code basically has no 
OSI-approved license attached to it


> RAT is failing on the latest master
> ---
>
> Key: HAWQ-915
> URL: https://issues.apache.org/jira/browse/HAWQ-915
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Build
>Affects Versions: 2.0.0.0-incubating
>Reporter: Roman Shaposhnik
>Assignee: Lei Chang
>Priority: Blocker
> Fix For: 2.0.0.0-incubating
>
> Attachments: rat.txt
>
>
> Running RAT (via the usual mvn verify) on the current tree produces quite a 
> bit of hits on the source code added lately to the HAWQ's repo. The full 
> report is attached. This is a blocking JIRA for 2.0.0.0-incubating. PMC 
> members should very carefully go over the RAT report and either get rid of 
> offending code, update the licensing information or include it into the RAT 
> exclusion list. The later has to have explicit explanation of why the code 
> has to reside in the HAWQ repo as opposed to being a dependency.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-hawq pull request #788: HAWQ-915. RAT is failing on the latest mas...

[rvs]

Github user rvs commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/788#discussion_r70544439
  
--- Diff: pom.xml ---
@@ -37,14 +37,32 @@
   
   tools/bin/src/stream/* 
 
-  
+  
+  
   tools/bin/pythonSrc/PyGreSQL-4.0/**
+  tools/bin/pythonSrc/PSI-0.3b2_gp/**
+  tools/bin/pythonSrc/lockfile-0.9.1/**
+  
+  tools/bin/pythonSrc/pychecker-0.8.18/**
+  tools/bin/pythonSrc/unittest2-0.5.1/**
+  
--- End diff --

I am not sure this is ASF compatible since this code basically has no 
OSI-approved license attached to it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (HAWQ-915) RAT is failing on the latest master

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15373998#comment-15373998
 ] 

ASF GitHub Bot commented on HAWQ-915:
-

Github user rvs commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/788#discussion_r70544327
  
--- Diff: pom.xml ---
@@ -37,14 +37,32 @@
   
   tools/bin/src/stream/* 
 
-  
+  
+  
   tools/bin/pythonSrc/PyGreSQL-4.0/**
+  tools/bin/pythonSrc/PSI-0.3b2_gp/**
+  tools/bin/pythonSrc/lockfile-0.9.1/**
+  
+  tools/bin/pythonSrc/pychecker-0.8.18/**
+  tools/bin/pythonSrc/unittest2-0.5.1/**
--- End diff --

unittest2-0.5.1/PKG-INFO says License is unknown. Please provide support 
for your claim that this is a BSD licensed code.


> RAT is failing on the latest master
> ---
>
> Key: HAWQ-915
> URL: https://issues.apache.org/jira/browse/HAWQ-915
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Build
>Affects Versions: 2.0.0.0-incubating
>Reporter: Roman Shaposhnik
>Assignee: Lei Chang
>Priority: Blocker
> Fix For: 2.0.0.0-incubating
>
> Attachments: rat.txt
>
>
> Running RAT (via the usual mvn verify) on the current tree produces quite a 
> bit of hits on the source code added lately to the HAWQ's repo. The full 
> report is attached. This is a blocking JIRA for 2.0.0.0-incubating. PMC 
> members should very carefully go over the RAT report and either get rid of 
> offending code, update the licensing information or include it into the RAT 
> exclusion list. The later has to have explicit explanation of why the code 
> has to reside in the HAWQ repo as opposed to being a dependency.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-hawq pull request #788: HAWQ-915. RAT is failing on the latest mas...

[rvs]

Github user rvs commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/788#discussion_r70544327
  
--- Diff: pom.xml ---
@@ -37,14 +37,32 @@
   
   tools/bin/src/stream/* 
 
-  
+  
+  
   tools/bin/pythonSrc/PyGreSQL-4.0/**
+  tools/bin/pythonSrc/PSI-0.3b2_gp/**
+  tools/bin/pythonSrc/lockfile-0.9.1/**
+  
+  tools/bin/pythonSrc/pychecker-0.8.18/**
+  tools/bin/pythonSrc/unittest2-0.5.1/**
--- End diff --

unittest2-0.5.1/PKG-INFO says License is unknown. Please provide support 
for your claim that this is a BSD licensed code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #788: HAWQ-915. RAT is failing on the latest mas...

[rvs]

Github user rvs commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/788#discussion_r70544369
  
--- Diff: pom.xml ---
@@ -37,14 +37,32 @@
   
   tools/bin/src/stream/* 
 
-  
+  
+  
   tools/bin/pythonSrc/PyGreSQL-4.0/**
+  tools/bin/pythonSrc/PSI-0.3b2_gp/**
+  tools/bin/pythonSrc/lockfile-0.9.1/**
+  
+  tools/bin/pythonSrc/pychecker-0.8.18/**
+  tools/bin/pythonSrc/unittest2-0.5.1/**
+  
+  tools/bin/pythonSrc/pycrypto-2.0.1/**
--- End diff --

At this point the agreement is that we're not distributing crypto code with 
HAWQ


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (HAWQ-915) RAT is failing on the latest master

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15373990#comment-15373990
 ] 

ASF GitHub Bot commented on HAWQ-915:
-

Github user rvs commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/788#discussion_r70544031
  
--- Diff: pom.xml ---
@@ -37,14 +37,32 @@
   
   tools/bin/src/stream/* 
 
-  
+  
+  
   tools/bin/pythonSrc/PyGreSQL-4.0/**
+  tools/bin/pythonSrc/PSI-0.3b2_gp/**
--- End diff --

For all these new additions don't forget to update the NOTICE file


> RAT is failing on the latest master
> ---
>
> Key: HAWQ-915
> URL: https://issues.apache.org/jira/browse/HAWQ-915
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Build
>Affects Versions: 2.0.0.0-incubating
>Reporter: Roman Shaposhnik
>Assignee: Lei Chang
>Priority: Blocker
> Fix For: 2.0.0.0-incubating
>
> Attachments: rat.txt
>
>
> Running RAT (via the usual mvn verify) on the current tree produces quite a 
> bit of hits on the source code added lately to the HAWQ's repo. The full 
> report is attached. This is a blocking JIRA for 2.0.0.0-incubating. PMC 
> members should very carefully go over the RAT report and either get rid of 
> offending code, update the licensing information or include it into the RAT 
> exclusion list. The later has to have explicit explanation of why the code 
> has to reside in the HAWQ repo as opposed to being a dependency.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HAWQ-915) RAT is failing on the latest master

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15373987#comment-15373987
 ] 

ASF GitHub Bot commented on HAWQ-915:
-

Github user rvs commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/788#discussion_r70543816
  
--- Diff: pom.xml ---
@@ -37,14 +37,32 @@
   
   tools/bin/src/stream/* 
 
-  
--- End diff --

Please leave this comment near PyGreSQL entry


> RAT is failing on the latest master
> ---
>
> Key: HAWQ-915
> URL: https://issues.apache.org/jira/browse/HAWQ-915
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Build
>Affects Versions: 2.0.0.0-incubating
>Reporter: Roman Shaposhnik
>Assignee: Lei Chang
>Priority: Blocker
> Fix For: 2.0.0.0-incubating
>
> Attachments: rat.txt
>
>
> Running RAT (via the usual mvn verify) on the current tree produces quite a 
> bit of hits on the source code added lately to the HAWQ's repo. The full 
> report is attached. This is a blocking JIRA for 2.0.0.0-incubating. PMC 
> members should very carefully go over the RAT report and either get rid of 
> offending code, update the licensing information or include it into the RAT 
> exclusion list. The later has to have explicit explanation of why the code 
> has to reside in the HAWQ repo as opposed to being a dependency.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HAWQ-919) pxf has some issues on RAT check

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15373734#comment-15373734
 ] 

ASF GitHub Bot commented on HAWQ-919:
-

Github user GodenYao closed the pull request at:

https://github.com/apache/incubator-hawq/pull/790


> pxf has some issues on RAT check
> 
>
> Key: HAWQ-919
> URL: https://issues.apache.org/jira/browse/HAWQ-919
> Project: Apache HAWQ
>  Issue Type: Sub-task
>  Components: PXF
>Reporter: Lei Chang
>Assignee: Goden Yao
>Priority: Blocker
> Fix For: 2.0.0.0-incubating
>
>
> json related tests has issues with RAT check



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (HAWQ-919) pxf has some issues on RAT check

[Goden Yao (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Goden Yao resolved HAWQ-919.

Resolution: Fixed

> pxf has some issues on RAT check
> 
>
> Key: HAWQ-919
> URL: https://issues.apache.org/jira/browse/HAWQ-919
> Project: Apache HAWQ
>  Issue Type: Sub-task
>  Components: PXF
>Reporter: Lei Chang
>Assignee: Goden Yao
>Priority: Blocker
> Fix For: 2.0.0.0-incubating
>
>
> json related tests has issues with RAT check



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-hawq pull request #790: HAWQ-919. add missing ASF license header

[GodenYao]

Github user GodenYao closed the pull request at:

https://github.com/apache/incubator-hawq/pull/790


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (HAWQ-919) pxf has some issues on RAT check

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15373511#comment-15373511
 ] 

ASF GitHub Bot commented on HAWQ-919:
-

Github user shivzone commented on the issue:

https://github.com/apache/incubator-hawq/pull/790
  
+1


> pxf has some issues on RAT check
> 
>
> Key: HAWQ-919
> URL: https://issues.apache.org/jira/browse/HAWQ-919
> Project: Apache HAWQ
>  Issue Type: Sub-task
>  Components: PXF
>Reporter: Lei Chang
>Assignee: Goden Yao
>Priority: Blocker
> Fix For: 2.0.0.0-incubating
>
>
> json related tests has issues with RAT check



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-hawq issue #790: HAWQ-919. add missing ASF license header

[shivzone]

Github user shivzone commented on the issue:

https://github.com/apache/incubator-hawq/pull/790
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (HAWQ-919) pxf has some issues on RAT check

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15373499#comment-15373499
 ] 

ASF GitHub Bot commented on HAWQ-919:
-

Github user sansanichfb commented on the issue:

https://github.com/apache/incubator-hawq/pull/790
  
+1


> pxf has some issues on RAT check
> 
>
> Key: HAWQ-919
> URL: https://issues.apache.org/jira/browse/HAWQ-919
> Project: Apache HAWQ
>  Issue Type: Sub-task
>  Components: PXF
>Reporter: Lei Chang
>Assignee: Goden Yao
>Priority: Blocker
> Fix For: 2.0.0.0-incubating
>
>
> json related tests has issues with RAT check



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-hawq issue #790: HAWQ-919. add missing ASF license header

[sansanichfb]

Github user sansanichfb commented on the issue:

https://github.com/apache/incubator-hawq/pull/790
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (HAWQ-919) pxf has some issues on RAT check

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15373496#comment-15373496
 ] 

ASF GitHub Bot commented on HAWQ-919:
-

GitHub user GodenYao opened a pull request:

https://github.com/apache/incubator-hawq/pull/790

HAWQ-919. add missing ASF license header



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/incubator-hawq HAWQ-919

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/790.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #790


commit fa88c325d030039fa74daee100381c0b6d07b3a0
Author: Goden Yao 
Date:   2016-07-12T19:10:27Z

add missing ASF license header




> pxf has some issues on RAT check
> 
>
> Key: HAWQ-919
> URL: https://issues.apache.org/jira/browse/HAWQ-919
> Project: Apache HAWQ
>  Issue Type: Sub-task
>  Components: PXF
>Reporter: Lei Chang
>Assignee: Goden Yao
>Priority: Blocker
> Fix For: 2.0.0.0-incubating
>
>
> json related tests has issues with RAT check



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-hawq pull request #790: HAWQ-919. add missing ASF license header

[GodenYao]

GitHub user GodenYao opened a pull request:

https://github.com/apache/incubator-hawq/pull/790

HAWQ-919. add missing ASF license header



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/incubator-hawq HAWQ-919

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/790.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #790


commit fa88c325d030039fa74daee100381c0b6d07b3a0
Author: Goden Yao 
Date:   2016-07-12T19:10:27Z

add missing ASF license header




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (HAWQ-919) pxf has some issues on RAT check

[Goden Yao (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Goden Yao updated HAWQ-919:
---
Description: json related tests has issues with RAT check

> pxf has some issues on RAT check
> 
>
> Key: HAWQ-919
> URL: https://issues.apache.org/jira/browse/HAWQ-919
> Project: Apache HAWQ
>  Issue Type: Sub-task
>  Components: PXF
>Reporter: Lei Chang
>Assignee: Goden Yao
>Priority: Blocker
> Fix For: 2.0.0.0-incubating
>
>
> json related tests has issues with RAT check



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-hawq issue #789: HAWQ-918. Fix memtuple forming bug when null-save...

[linwen]

Github user linwen commented on the issue:

https://github.com/apache/incubator-hawq/pull/789
  
The reason is
test cases for aggregates haven't been moved to new feature test framework 
yet.
So I add this test case in old installcheck.
And all the test cases for aggregates will be moved together within a new 
jira. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (HAWQ-918) Fix memtuple forming bug when null-saved size is larger than 32763 bytes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15373145#comment-15373145
 ] 

ASF GitHub Bot commented on HAWQ-918:
-

Github user linwen commented on the issue:

https://github.com/apache/incubator-hawq/pull/789
  
The reason is
test cases for aggregates haven't been moved to new feature test framework 
yet.
So I add this test case in old installcheck.
And all the test cases for aggregates will be moved together within a new 
jira. 


> Fix memtuple forming bug when null-saved size is larger than 32763 bytes
> 
>
> Key: HAWQ-918
> URL: https://issues.apache.org/jira/browse/HAWQ-918
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Query Execution
>Reporter: Lin Wen
>Assignee: Lin Wen
> Attachments: run.sql
>
>
> When run a sql, an error happens in QE:
> psql:run.sql:24: ERROR:  Query Executor Error in seg2 localhost:4 
> pid=55810: server closed the connection unexpectedly
> DETAIL:
>   This probably means the server terminated abnormally
>   before or while processing the request.
> 2016-07-13 00:21:53.951987 CST,,,p34013,th0,,,2016-07-13 00:21:29 
> CST,0,con33,cmd33,seg1,slice2"PANIC","XX000","Unexpected internal error: 
> Segment process received signal SIGSEGV",,,0"10x8b764e postgres 
>  + 0x8b764e
> 20x3b66e0f710 libpthread.so.0  + 0x66e0f710
> 30x3b6668995b libc.so.6 memcpy + 0x2eb
> 40x8940d8 postgres textout + 0x58
> 50x8c32d7 postgres DirectFunctionCall1 + 0x47
> 60x88a126 postgres text_timestamp + 0xc6
> 70x669b47 postgres  + 0x669b47
> 80x669fe9 postgres  + 0x669fe9
> 90x66f54e postgres ExecProject + 0x23e
> 10   0x680695 postgres ExecAgg + 0x525
> 11   0x6643b1 postgres ExecProcNode + 0x221
> 12   0x689da8 postgres ExecLimit + 0x218
> 13   0x664521 postgres ExecProcNode + 0x391
> 14   0x68d549 postgres ExecMotion + 0x39
> 15   0x6643c1 postgres ExecProcNode + 0x231
> 16   0x660752 postgres  + 0x660752
> 17   0x6610ea postgres ExecutorRun + 0x4ca
> 18   0x7e4c3a postgres PortalRun + 0x58a
> 19   0x7dab64 postgres  + 0x7dab64
> 20   0x7dfaf5 postgres PostgresMain + 0x2b65
> 21   0x790e7f postgres  + 0x790e7f
> 22   0x793b39 postgres PostmasterMain + 0x759
> 23   0x4a19cf postgres main + 0x50f
> 24   0x3b6661ed5d libc.so.6 __libc_start_main + 0xfd
> 25   0x4a1a4d postgres  + 0x4a1a4d



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HAWQ-918) Fix memtuple forming bug when null-saved size is larger than 32763 bytes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372958#comment-15372958
 ] 

ASF GitHub Bot commented on HAWQ-918:
-

Github user changleicn commented on the issue:

https://github.com/apache/incubator-hawq/pull/789
  
why do we still add the old installcheck tests? 


> Fix memtuple forming bug when null-saved size is larger than 32763 bytes
> 
>
> Key: HAWQ-918
> URL: https://issues.apache.org/jira/browse/HAWQ-918
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Query Execution
>Reporter: Lin Wen
>Assignee: Lin Wen
> Attachments: run.sql
>
>
> When run a sql, an error happens in QE:
> psql:run.sql:24: ERROR:  Query Executor Error in seg2 localhost:4 
> pid=55810: server closed the connection unexpectedly
> DETAIL:
>   This probably means the server terminated abnormally
>   before or while processing the request.
> 2016-07-13 00:21:53.951987 CST,,,p34013,th0,,,2016-07-13 00:21:29 
> CST,0,con33,cmd33,seg1,slice2"PANIC","XX000","Unexpected internal error: 
> Segment process received signal SIGSEGV",,,0"10x8b764e postgres 
>  + 0x8b764e
> 20x3b66e0f710 libpthread.so.0  + 0x66e0f710
> 30x3b6668995b libc.so.6 memcpy + 0x2eb
> 40x8940d8 postgres textout + 0x58
> 50x8c32d7 postgres DirectFunctionCall1 + 0x47
> 60x88a126 postgres text_timestamp + 0xc6
> 70x669b47 postgres  + 0x669b47
> 80x669fe9 postgres  + 0x669fe9
> 90x66f54e postgres ExecProject + 0x23e
> 10   0x680695 postgres ExecAgg + 0x525
> 11   0x6643b1 postgres ExecProcNode + 0x221
> 12   0x689da8 postgres ExecLimit + 0x218
> 13   0x664521 postgres ExecProcNode + 0x391
> 14   0x68d549 postgres ExecMotion + 0x39
> 15   0x6643c1 postgres ExecProcNode + 0x231
> 16   0x660752 postgres  + 0x660752
> 17   0x6610ea postgres ExecutorRun + 0x4ca
> 18   0x7e4c3a postgres PortalRun + 0x58a
> 19   0x7dab64 postgres  + 0x7dab64
> 20   0x7dfaf5 postgres PostgresMain + 0x2b65
> 21   0x790e7f postgres  + 0x790e7f
> 22   0x793b39 postgres PostmasterMain + 0x759
> 23   0x4a19cf postgres main + 0x50f
> 24   0x3b6661ed5d libc.so.6 __libc_start_main + 0xfd
> 25   0x4a1a4d postgres  + 0x4a1a4d



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-hawq issue #789: HAWQ-918. Fix memtuple forming bug when null-save...

[changleicn]

Github user changleicn commented on the issue:

https://github.com/apache/incubator-hawq/pull/789
  
why do we still add the old installcheck tests? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (HAWQ-918) Fix memtuple forming bug when null-saved size is larger than 32763 bytes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372836#comment-15372836
 ] 

ASF GitHub Bot commented on HAWQ-918:
-

Github user armenatzoglou commented on the issue:

https://github.com/apache/incubator-hawq/pull/789
  
LGTM. 


> Fix memtuple forming bug when null-saved size is larger than 32763 bytes
> 
>
> Key: HAWQ-918
> URL: https://issues.apache.org/jira/browse/HAWQ-918
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Query Execution
>Reporter: Lin Wen
>Assignee: Lin Wen
> Attachments: run.sql
>
>
> When run a sql, an error happens in QE:
> psql:run.sql:24: ERROR:  Query Executor Error in seg2 localhost:4 
> pid=55810: server closed the connection unexpectedly
> DETAIL:
>   This probably means the server terminated abnormally
>   before or while processing the request.
> 2016-07-13 00:21:53.951987 CST,,,p34013,th0,,,2016-07-13 00:21:29 
> CST,0,con33,cmd33,seg1,slice2"PANIC","XX000","Unexpected internal error: 
> Segment process received signal SIGSEGV",,,0"10x8b764e postgres 
>  + 0x8b764e
> 20x3b66e0f710 libpthread.so.0  + 0x66e0f710
> 30x3b6668995b libc.so.6 memcpy + 0x2eb
> 40x8940d8 postgres textout + 0x58
> 50x8c32d7 postgres DirectFunctionCall1 + 0x47
> 60x88a126 postgres text_timestamp + 0xc6
> 70x669b47 postgres  + 0x669b47
> 80x669fe9 postgres  + 0x669fe9
> 90x66f54e postgres ExecProject + 0x23e
> 10   0x680695 postgres ExecAgg + 0x525
> 11   0x6643b1 postgres ExecProcNode + 0x221
> 12   0x689da8 postgres ExecLimit + 0x218
> 13   0x664521 postgres ExecProcNode + 0x391
> 14   0x68d549 postgres ExecMotion + 0x39
> 15   0x6643c1 postgres ExecProcNode + 0x231
> 16   0x660752 postgres  + 0x660752
> 17   0x6610ea postgres ExecutorRun + 0x4ca
> 18   0x7e4c3a postgres PortalRun + 0x58a
> 19   0x7dab64 postgres  + 0x7dab64
> 20   0x7dfaf5 postgres PostgresMain + 0x2b65
> 21   0x790e7f postgres  + 0x790e7f
> 22   0x793b39 postgres PostmasterMain + 0x759
> 23   0x4a19cf postgres main + 0x50f
> 24   0x3b6661ed5d libc.so.6 __libc_start_main + 0xfd
> 25   0x4a1a4d postgres  + 0x4a1a4d



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-hawq issue #789: HAWQ-918. Fix memtuple forming bug when null-save...

[armenatzoglou]

Github user armenatzoglou commented on the issue:

https://github.com/apache/incubator-hawq/pull/789
  
LGTM. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (HAWQ-918) Fix memtuple forming bug when null-saved size is larger than 32763 bytes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372704#comment-15372704
 ] 

ASF GitHub Bot commented on HAWQ-918:
-

Github user xunzhang commented on the issue:

https://github.com/apache/incubator-hawq/pull/789
  
+1


> Fix memtuple forming bug when null-saved size is larger than 32763 bytes
> 
>
> Key: HAWQ-918
> URL: https://issues.apache.org/jira/browse/HAWQ-918
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Query Execution
>Reporter: Lin Wen
>Assignee: Lin Wen
> Attachments: run.sql
>
>
> When run a sql, an error happens in QE:
> psql:run.sql:24: ERROR:  Query Executor Error in seg2 localhost:4 
> pid=55810: server closed the connection unexpectedly
> DETAIL:
>   This probably means the server terminated abnormally
>   before or while processing the request.
> 2016-07-13 00:21:53.951987 CST,,,p34013,th0,,,2016-07-13 00:21:29 
> CST,0,con33,cmd33,seg1,slice2"PANIC","XX000","Unexpected internal error: 
> Segment process received signal SIGSEGV",,,0"10x8b764e postgres 
>  + 0x8b764e
> 20x3b66e0f710 libpthread.so.0  + 0x66e0f710
> 30x3b6668995b libc.so.6 memcpy + 0x2eb
> 40x8940d8 postgres textout + 0x58
> 50x8c32d7 postgres DirectFunctionCall1 + 0x47
> 60x88a126 postgres text_timestamp + 0xc6
> 70x669b47 postgres  + 0x669b47
> 80x669fe9 postgres  + 0x669fe9
> 90x66f54e postgres ExecProject + 0x23e
> 10   0x680695 postgres ExecAgg + 0x525
> 11   0x6643b1 postgres ExecProcNode + 0x221
> 12   0x689da8 postgres ExecLimit + 0x218
> 13   0x664521 postgres ExecProcNode + 0x391
> 14   0x68d549 postgres ExecMotion + 0x39
> 15   0x6643c1 postgres ExecProcNode + 0x231
> 16   0x660752 postgres  + 0x660752
> 17   0x6610ea postgres ExecutorRun + 0x4ca
> 18   0x7e4c3a postgres PortalRun + 0x58a
> 19   0x7dab64 postgres  + 0x7dab64
> 20   0x7dfaf5 postgres PostgresMain + 0x2b65
> 21   0x790e7f postgres  + 0x790e7f
> 22   0x793b39 postgres PostmasterMain + 0x759
> 23   0x4a19cf postgres main + 0x50f
> 24   0x3b6661ed5d libc.so.6 __libc_start_main + 0xfd
> 25   0x4a1a4d postgres  + 0x4a1a4d



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-hawq issue #789: HAWQ-918. Fix memtuple forming bug when null-save...

[xunzhang]

Github user xunzhang commented on the issue:

https://github.com/apache/incubator-hawq/pull/789
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (HAWQ-918) Fix memtuple forming bug when null-saved size is larger than 32763 bytes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372689#comment-15372689
 ] 

ASF GitHub Bot commented on HAWQ-918:
-

GitHub user linwen opened a pull request:

https://github.com/apache/incubator-hawq/pull/789

HAWQ-918. Fix memtuple forming bug when null-saved size is larger tha…

Please review, Thanks!

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/linwen/incubator-hawq hawq_918

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/789.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #789


commit cd5ad920d79a8d7bb612255daa1410769382e653
Author: Wen Lin 
Date:   2016-07-12T10:55:24Z

HAWQ-918. Fix memtuple forming bug when null-saved size is larger than 
32763 bytes




> Fix memtuple forming bug when null-saved size is larger than 32763 bytes
> 
>
> Key: HAWQ-918
> URL: https://issues.apache.org/jira/browse/HAWQ-918
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Query Execution
>Reporter: Lin Wen
>Assignee: Lin Wen
> Attachments: run.sql
>
>
> When run a sql, an error happens in QE:
> psql:run.sql:24: ERROR:  Query Executor Error in seg2 localhost:4 
> pid=55810: server closed the connection unexpectedly
> DETAIL:
>   This probably means the server terminated abnormally
>   before or while processing the request.
> 2016-07-13 00:21:53.951987 CST,,,p34013,th0,,,2016-07-13 00:21:29 
> CST,0,con33,cmd33,seg1,slice2"PANIC","XX000","Unexpected internal error: 
> Segment process received signal SIGSEGV",,,0"10x8b764e postgres 
>  + 0x8b764e
> 20x3b66e0f710 libpthread.so.0  + 0x66e0f710
> 30x3b6668995b libc.so.6 memcpy + 0x2eb
> 40x8940d8 postgres textout + 0x58
> 50x8c32d7 postgres DirectFunctionCall1 + 0x47
> 60x88a126 postgres text_timestamp + 0xc6
> 70x669b47 postgres  + 0x669b47
> 80x669fe9 postgres  + 0x669fe9
> 90x66f54e postgres ExecProject + 0x23e
> 10   0x680695 postgres ExecAgg + 0x525
> 11   0x6643b1 postgres ExecProcNode + 0x221
> 12   0x689da8 postgres ExecLimit + 0x218
> 13   0x664521 postgres ExecProcNode + 0x391
> 14   0x68d549 postgres ExecMotion + 0x39
> 15   0x6643c1 postgres ExecProcNode + 0x231
> 16   0x660752 postgres  + 0x660752
> 17   0x6610ea postgres ExecutorRun + 0x4ca
> 18   0x7e4c3a postgres PortalRun + 0x58a
> 19   0x7dab64 postgres  + 0x7dab64
> 20   0x7dfaf5 postgres PostgresMain + 0x2b65
> 21   0x790e7f postgres  + 0x790e7f
> 22   0x793b39 postgres PostmasterMain + 0x759
> 23   0x4a19cf postgres main + 0x50f
> 24   0x3b6661ed5d libc.so.6 __libc_start_main + 0xfd
> 25   0x4a1a4d postgres  + 0x4a1a4d



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-hawq pull request #789: HAWQ-918. Fix memtuple forming bug when nu...

[linwen]

GitHub user linwen opened a pull request:

https://github.com/apache/incubator-hawq/pull/789

HAWQ-918. Fix memtuple forming bug when null-saved size is larger tha…

Please review, Thanks!

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/linwen/incubator-hawq hawq_918

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/789.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #789


commit cd5ad920d79a8d7bb612255daa1410769382e653
Author: Wen Lin 
Date:   2016-07-12T10:55:24Z

HAWQ-918. Fix memtuple forming bug when null-saved size is larger than 
32763 bytes




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (HAWQ-918) Fix memtuple forming bug when null-saved size is larger than 32763 bytes

[Lin Wen (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372686#comment-15372686
 ] 

Lin Wen commented on HAWQ-918:
--

compute_null_save() is used to compute how many bytes a tuple saved by using
nullbitmap, formerly the return value is short type and can be easily exceeded
to a negative value which will corrupt memtuples and cause sigsegv.

> Fix memtuple forming bug when null-saved size is larger than 32763 bytes
> 
>
> Key: HAWQ-918
> URL: https://issues.apache.org/jira/browse/HAWQ-918
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Query Execution
>Reporter: Lin Wen
>Assignee: Lin Wen
> Attachments: run.sql
>
>
> When run a sql, an error happens in QE:
> psql:run.sql:24: ERROR:  Query Executor Error in seg2 localhost:4 
> pid=55810: server closed the connection unexpectedly
> DETAIL:
>   This probably means the server terminated abnormally
>   before or while processing the request.
> 2016-07-13 00:21:53.951987 CST,,,p34013,th0,,,2016-07-13 00:21:29 
> CST,0,con33,cmd33,seg1,slice2"PANIC","XX000","Unexpected internal error: 
> Segment process received signal SIGSEGV",,,0"10x8b764e postgres 
>  + 0x8b764e
> 20x3b66e0f710 libpthread.so.0  + 0x66e0f710
> 30x3b6668995b libc.so.6 memcpy + 0x2eb
> 40x8940d8 postgres textout + 0x58
> 50x8c32d7 postgres DirectFunctionCall1 + 0x47
> 60x88a126 postgres text_timestamp + 0xc6
> 70x669b47 postgres  + 0x669b47
> 80x669fe9 postgres  + 0x669fe9
> 90x66f54e postgres ExecProject + 0x23e
> 10   0x680695 postgres ExecAgg + 0x525
> 11   0x6643b1 postgres ExecProcNode + 0x221
> 12   0x689da8 postgres ExecLimit + 0x218
> 13   0x664521 postgres ExecProcNode + 0x391
> 14   0x68d549 postgres ExecMotion + 0x39
> 15   0x6643c1 postgres ExecProcNode + 0x231
> 16   0x660752 postgres  + 0x660752
> 17   0x6610ea postgres ExecutorRun + 0x4ca
> 18   0x7e4c3a postgres PortalRun + 0x58a
> 19   0x7dab64 postgres  + 0x7dab64
> 20   0x7dfaf5 postgres PostgresMain + 0x2b65
> 21   0x790e7f postgres  + 0x790e7f
> 22   0x793b39 postgres PostmasterMain + 0x759
> 23   0x4a19cf postgres main + 0x50f
> 24   0x3b6661ed5d libc.so.6 __libc_start_main + 0xfd
> 25   0x4a1a4d postgres  + 0x4a1a4d



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HAWQ-919) pxf has some issues on RAT check

[Paul Guo (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372662#comment-15372662
 ] 

Paul Guo commented on HAWQ-919:
---

After running "mvn apache-rat:check" under the root path of a hawq repo,
I saw following files have license issues (cat target/rat.txt)
You could either add license info into those files or mask them in pom.xml.


Unapproved licenses:

  pxf/pxf-json/src/test/resources/lexer-tests/array_objects_complex.json.state
  pxf/pxf-json/src/test/resources/lexer-tests/array_objects_empty.json.state
  pxf/pxf-json/src/test/resources/lexer-tests/array_of_numbers.json.state
  pxf/pxf-json/src/test/resources/lexer-tests/object_complex.json.state
  pxf/pxf-json/src/test/resources/lexer-tests/object_simple.json.state
  pxf/pxf-json/src/test/resources/lexer-tests/object_string_escaping.json.state
  pxf/pxf-json/src/test/resources/log4j.properties

> pxf has some issues on RAT check
> 
>
> Key: HAWQ-919
> URL: https://issues.apache.org/jira/browse/HAWQ-919
> Project: Apache HAWQ
>  Issue Type: Sub-task
>  Components: PXF
>Reporter: Lei Chang
>Assignee: Goden Yao
>Priority: Blocker
> Fix For: 2.0.0.0-incubating
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HAWQ-915) RAT is failing on the latest master

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372661#comment-15372661
 ] 

ASF GitHub Bot commented on HAWQ-915:
-

Github user changleicn commented on the issue:

https://github.com/apache/incubator-hawq/pull/788
  
@rvs to review.


> RAT is failing on the latest master
> ---
>
> Key: HAWQ-915
> URL: https://issues.apache.org/jira/browse/HAWQ-915
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Build
>Affects Versions: 2.0.0.0-incubating
>Reporter: Roman Shaposhnik
>Assignee: Lei Chang
>Priority: Blocker
> Fix For: 2.0.0.0-incubating
>
> Attachments: rat.txt
>
>
> Running RAT (via the usual mvn verify) on the current tree produces quite a 
> bit of hits on the source code added lately to the HAWQ's repo. The full 
> report is attached. This is a blocking JIRA for 2.0.0.0-incubating. PMC 
> members should very carefully go over the RAT report and either get rid of 
> offending code, update the licensing information or include it into the RAT 
> exclusion list. The later has to have explicit explanation of why the code 
> has to reside in the HAWQ repo as opposed to being a dependency.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-hawq issue #788: HAWQ-915. RAT is failing on the latest master

[changleicn]

Github user changleicn commented on the issue:

https://github.com/apache/incubator-hawq/pull/788
  
@rvs to review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (HAWQ-915) RAT is failing on the latest master

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372659#comment-15372659
 ] 

ASF GitHub Bot commented on HAWQ-915:
-

GitHub user paul-guo- opened a pull request:

https://github.com/apache/incubator-hawq/pull/788

HAWQ-915. RAT is failing on the latest master



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/paul-guo-/incubator-hawq rat2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/788.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #788


commit 0c825258cc886917477b60f706a87e7d3dd831f4
Author: Paul Guo 
Date:   2016-07-12T10:27:26Z

HAWQ-915. RAT is failing on the latest master




> RAT is failing on the latest master
> ---
>
> Key: HAWQ-915
> URL: https://issues.apache.org/jira/browse/HAWQ-915
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Build
>Affects Versions: 2.0.0.0-incubating
>Reporter: Roman Shaposhnik
>Assignee: Lei Chang
>Priority: Blocker
> Fix For: 2.0.0.0-incubating
>
> Attachments: rat.txt
>
>
> Running RAT (via the usual mvn verify) on the current tree produces quite a 
> bit of hits on the source code added lately to the HAWQ's repo. The full 
> report is attached. This is a blocking JIRA for 2.0.0.0-incubating. PMC 
> members should very carefully go over the RAT report and either get rid of 
> offending code, update the licensing information or include it into the RAT 
> exclusion list. The later has to have explicit explanation of why the code 
> has to reside in the HAWQ repo as opposed to being a dependency.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HAWQ-919) pxf has some issues on RAT check

[Lei Chang (JIRA)]

Lei Chang created HAWQ-919:
--

 Summary: pxf has some issues on RAT check
 Key: HAWQ-919
 URL: https://issues.apache.org/jira/browse/HAWQ-919
 Project: Apache HAWQ
  Issue Type: Sub-task
  Components: PXF
Reporter: Lei Chang
Assignee: Goden Yao






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-hawq pull request #788: HAWQ-915. RAT is failing on the latest mas...

[paul-guo-]

GitHub user paul-guo- opened a pull request:

https://github.com/apache/incubator-hawq/pull/788

HAWQ-915. RAT is failing on the latest master



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/paul-guo-/incubator-hawq rat2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/788.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #788


commit 0c825258cc886917477b60f706a87e7d3dd831f4
Author: Paul Guo 
Date:   2016-07-12T10:27:26Z

HAWQ-915. RAT is failing on the latest master




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (HAWQ-919) pxf has some issues on RAT check

[Lei Chang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lei Chang updated HAWQ-919:
---
Priority: Blocker  (was: Major)

> pxf has some issues on RAT check
> 
>
> Key: HAWQ-919
> URL: https://issues.apache.org/jira/browse/HAWQ-919
> Project: Apache HAWQ
>  Issue Type: Sub-task
>  Components: PXF
>Reporter: Lei Chang
>Assignee: Goden Yao
>Priority: Blocker
> Fix For: 2.0.0.0-incubating
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HAWQ-918) Fix memtuple forming bug when null-saved size is larger than 32763 bytes

[Lin Wen (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lin Wen updated HAWQ-918:
-
Attachment: run.sql

reproduce sql file

> Fix memtuple forming bug when null-saved size is larger than 32763 bytes
> 
>
> Key: HAWQ-918
> URL: https://issues.apache.org/jira/browse/HAWQ-918
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Query Execution
>Reporter: Lin Wen
>Assignee: Lin Wen
> Attachments: run.sql
>
>
> When run a sql, an error happens in QE:
> psql:run.sql:24: ERROR:  Query Executor Error in seg2 localhost:4 
> pid=55810: server closed the connection unexpectedly
> DETAIL:
>   This probably means the server terminated abnormally
>   before or while processing the request.
> 2016-07-13 00:21:53.951987 CST,,,p34013,th0,,,2016-07-13 00:21:29 
> CST,0,con33,cmd33,seg1,slice2"PANIC","XX000","Unexpected internal error: 
> Segment process received signal SIGSEGV",,,0"10x8b764e postgres 
>  + 0x8b764e
> 20x3b66e0f710 libpthread.so.0  + 0x66e0f710
> 30x3b6668995b libc.so.6 memcpy + 0x2eb
> 40x8940d8 postgres textout + 0x58
> 50x8c32d7 postgres DirectFunctionCall1 + 0x47
> 60x88a126 postgres text_timestamp + 0xc6
> 70x669b47 postgres  + 0x669b47
> 80x669fe9 postgres  + 0x669fe9
> 90x66f54e postgres ExecProject + 0x23e
> 10   0x680695 postgres ExecAgg + 0x525
> 11   0x6643b1 postgres ExecProcNode + 0x221
> 12   0x689da8 postgres ExecLimit + 0x218
> 13   0x664521 postgres ExecProcNode + 0x391
> 14   0x68d549 postgres ExecMotion + 0x39
> 15   0x6643c1 postgres ExecProcNode + 0x231
> 16   0x660752 postgres  + 0x660752
> 17   0x6610ea postgres ExecutorRun + 0x4ca
> 18   0x7e4c3a postgres PortalRun + 0x58a
> 19   0x7dab64 postgres  + 0x7dab64
> 20   0x7dfaf5 postgres PostgresMain + 0x2b65
> 21   0x790e7f postgres  + 0x790e7f
> 22   0x793b39 postgres PostmasterMain + 0x759
> 23   0x4a19cf postgres main + 0x50f
> 24   0x3b6661ed5d libc.so.6 __libc_start_main + 0xfd
> 25   0x4a1a4d postgres  + 0x4a1a4d



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (HAWQ-918) Fix memtuple forming bug when null-saved size is larger than 32763 bytes

[Lin Wen (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lin Wen reassigned HAWQ-918:


Assignee: Lin Wen  (was: Lei Chang)

> Fix memtuple forming bug when null-saved size is larger than 32763 bytes
> 
>
> Key: HAWQ-918
> URL: https://issues.apache.org/jira/browse/HAWQ-918
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Query Execution
>Reporter: Lin Wen
>Assignee: Lin Wen
>
> When run a sql, an error happens in QE:
> psql:run.sql:24: ERROR:  Query Executor Error in seg2 localhost:4 
> pid=55810: server closed the connection unexpectedly
> DETAIL:
>   This probably means the server terminated abnormally
>   before or while processing the request.
> 2016-07-13 00:21:53.951987 CST,,,p34013,th0,,,2016-07-13 00:21:29 
> CST,0,con33,cmd33,seg1,slice2"PANIC","XX000","Unexpected internal error: 
> Segment process received signal SIGSEGV",,,0"10x8b764e postgres 
>  + 0x8b764e
> 20x3b66e0f710 libpthread.so.0  + 0x66e0f710
> 30x3b6668995b libc.so.6 memcpy + 0x2eb
> 40x8940d8 postgres textout + 0x58
> 50x8c32d7 postgres DirectFunctionCall1 + 0x47
> 60x88a126 postgres text_timestamp + 0xc6
> 70x669b47 postgres  + 0x669b47
> 80x669fe9 postgres  + 0x669fe9
> 90x66f54e postgres ExecProject + 0x23e
> 10   0x680695 postgres ExecAgg + 0x525
> 11   0x6643b1 postgres ExecProcNode + 0x221
> 12   0x689da8 postgres ExecLimit + 0x218
> 13   0x664521 postgres ExecProcNode + 0x391
> 14   0x68d549 postgres ExecMotion + 0x39
> 15   0x6643c1 postgres ExecProcNode + 0x231
> 16   0x660752 postgres  + 0x660752
> 17   0x6610ea postgres ExecutorRun + 0x4ca
> 18   0x7e4c3a postgres PortalRun + 0x58a
> 19   0x7dab64 postgres  + 0x7dab64
> 20   0x7dfaf5 postgres PostgresMain + 0x2b65
> 21   0x790e7f postgres  + 0x790e7f
> 22   0x793b39 postgres PostmasterMain + 0x759
> 23   0x4a19cf postgres main + 0x50f
> 24   0x3b6661ed5d libc.so.6 __libc_start_main + 0xfd
> 25   0x4a1a4d postgres  + 0x4a1a4d



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HAWQ-918) Fix memtuple forming bug when null-saved size is larger than 32763 bytes

[Lin Wen (JIRA)]

Lin Wen created HAWQ-918:


 Summary: Fix memtuple forming bug when null-saved size is larger 
than 32763 bytes
 Key: HAWQ-918
 URL: https://issues.apache.org/jira/browse/HAWQ-918
 Project: Apache HAWQ
  Issue Type: Bug
  Components: Query Execution
Reporter: Lin Wen
Assignee: Lei Chang


When run a sql, an error happens in QE:
psql:run.sql:24: ERROR:  Query Executor Error in seg2 localhost:4 
pid=55810: server closed the connection unexpectedly
DETAIL:
This probably means the server terminated abnormally
before or while processing the request.

2016-07-13 00:21:53.951987 CST,,,p34013,th0,,,2016-07-13 00:21:29 
CST,0,con33,cmd33,seg1,slice2"PANIC","XX000","Unexpected internal error: 
Segment process received signal SIGSEGV",,,0"10x8b764e postgres 
 + 0x8b764e
20x3b66e0f710 libpthread.so.0  + 0x66e0f710
30x3b6668995b libc.so.6 memcpy + 0x2eb
40x8940d8 postgres textout + 0x58
50x8c32d7 postgres DirectFunctionCall1 + 0x47
60x88a126 postgres text_timestamp + 0xc6
70x669b47 postgres  + 0x669b47
80x669fe9 postgres  + 0x669fe9
90x66f54e postgres ExecProject + 0x23e
10   0x680695 postgres ExecAgg + 0x525
11   0x6643b1 postgres ExecProcNode + 0x221
12   0x689da8 postgres ExecLimit + 0x218
13   0x664521 postgres ExecProcNode + 0x391
14   0x68d549 postgres ExecMotion + 0x39
15   0x6643c1 postgres ExecProcNode + 0x231
16   0x660752 postgres  + 0x660752
17   0x6610ea postgres ExecutorRun + 0x4ca
18   0x7e4c3a postgres PortalRun + 0x58a
19   0x7dab64 postgres  + 0x7dab64
20   0x7dfaf5 postgres PostgresMain + 0x2b65
21   0x790e7f postgres  + 0x790e7f
22   0x793b39 postgres PostmasterMain + 0x759
23   0x4a19cf postgres main + 0x50f
24   0x3b6661ed5d libc.so.6 __libc_start_main + 0xfd
25   0x4a1a4d postgres  + 0x4a1a4d



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HAWQ-751) Add plr, pgcrypto, gporca into Apache HAWQ

[Lei Chang (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372550#comment-15372550
 ] 

Lei Chang commented on HAWQ-751:


didn't see issues from the email thread (see paul's answer), let's close this.

> Add plr, pgcrypto, gporca into Apache HAWQ
> --
>
> Key: HAWQ-751
> URL: https://issues.apache.org/jira/browse/HAWQ-751
> Project: Apache HAWQ
>  Issue Type: Bug
>Reporter: Paul Guo
>Assignee: Lei Chang
> Fix For: 2.0.0.0-incubating
>
>
> Due to license conflict, we can not put them into HAWQ, instead, we use "git 
> submodule".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (HAWQ-751) Add plr, pgcrypto, gporca into Apache HAWQ

[Lei Chang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lei Chang closed HAWQ-751.
--
Resolution: Fixed

> Add plr, pgcrypto, gporca into Apache HAWQ
> --
>
> Key: HAWQ-751
> URL: https://issues.apache.org/jira/browse/HAWQ-751
> Project: Apache HAWQ
>  Issue Type: Bug
>Reporter: Paul Guo
>Assignee: Lei Chang
> Fix For: 2.0.0.0-incubating
>
>
> Due to license conflict, we can not put them into HAWQ, instead, we use "git 
> submodule".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (HAWQ-867) Replace the git-submobule mechanism with git-clone

[Lei Chang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lei Chang closed HAWQ-867.
--
Resolution: Fixed

> Replace the git-submobule mechanism with git-clone
> --
>
> Key: HAWQ-867
> URL: https://issues.apache.org/jira/browse/HAWQ-867
> Project: Apache HAWQ
>  Issue Type: Bug
>Reporter: Paul Guo
>Assignee: Paul Guo
>Priority: Blocker
> Fix For: 2.0.0.0-incubating
>
>
> Currently some features/extensions (e.g. pycrytpo, gporca, etc) are embedded 
> into hawq code via the git submodule mechanism which is similar to a link. In 
> hawq git repo, during hawq build, it will download the submodule repos and 
> build those functionality, however if we decide to generate a source tarball 
> which is independent on the git repo, this will be an issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (HAWQ-808) Refactor feature test for external_oid with new framework

[hongwu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

hongwu resolved HAWQ-808.
-
Resolution: Done

> Refactor feature test for external_oid with new framework
> -
>
> Key: HAWQ-808
> URL: https://issues.apache.org/jira/browse/HAWQ-808
> Project: Apache HAWQ
>  Issue Type: Sub-task
>  Components: Tests
>Reporter: hongwu
>Assignee: hongwu
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-hawq pull request #786: HAWQ-808. Refactor feature test for extern...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-hawq/pull/786


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (HAWQ-917) Refactor feature tests for data type check with new googletest framework

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372268#comment-15372268
 ] 

ASF GitHub Bot commented on HAWQ-917:
-

GitHub user paul-guo- opened a pull request:

https://github.com/apache/incubator-hawq/pull/787

HAWQ-917. Refactor feature tests for data type check with new googlet…

…est framework

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/paul-guo-/incubator-hawq test

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/787.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #787


commit 1e62101c146511ee78c8d44a6c1ae0bf4a1def9a
Author: Paul Guo 
Date:   2016-07-12T06:12:19Z

HAWQ-917. Refactor feature tests for data type check with new googletest 
framework




> Refactor feature tests for data type check with new googletest framework
> 
>
> Key: HAWQ-917
> URL: https://issues.apache.org/jira/browse/HAWQ-917
> Project: Apache HAWQ
>  Issue Type: Sub-task
>Reporter: Paul Guo
>Assignee: Paul Guo
>
> This needs to refactor the following 15 test cases.
> ../../../regress/sql/boolean.sql
> ../../../regress/sql/char.sql
> ../../../regress/sql/date.sql
> ../../../regress/sql/float4.sql
> ../../../regress/sql/float8.sql
> ../../../regress/sql/int2.sql
> ../../../regress/sql/int4.sql
> ../../../regress/sql/int8.sql
> ../../../regress/sql/money.sql
> ../../../regress/sql/name.sql
> ../../../regress/sql/oid.sql
> ../../../regress/sql/text.sql
> ../../../regress/sql/time.sql
> ../../../regress/sql/type_sanity.sql
> ../../../regress/sql/varchar.sql



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HAWQ-808) Refactor feature test for external_oid with new framework

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372270#comment-15372270
 ] 

ASF GitHub Bot commented on HAWQ-808:
-

Github user yaoj2 commented on the issue:

https://github.com/apache/incubator-hawq/pull/786
  
LGTM


> Refactor feature test for external_oid with new framework
> -
>
> Key: HAWQ-808
> URL: https://issues.apache.org/jira/browse/HAWQ-808
> Project: Apache HAWQ
>  Issue Type: Sub-task
>  Components: Tests
>Reporter: hongwu
>Assignee: hongwu
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-hawq issue #786: HAWQ-808. Refactor feature test for external_oid ...

[yaoj2]

Github user yaoj2 commented on the issue:

https://github.com/apache/incubator-hawq/pull/786
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #786: HAWQ-808. Refactor feature test for external_oid ...

[huor]

Github user huor commented on the issue:

https://github.com/apache/incubator-hawq/pull/786
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #787: HAWQ-917. Refactor feature tests for data ...

[paul-guo-]

GitHub user paul-guo- opened a pull request:

https://github.com/apache/incubator-hawq/pull/787

HAWQ-917. Refactor feature tests for data type check with new googlet…

…est framework

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/paul-guo-/incubator-hawq test

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/787.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #787


commit 1e62101c146511ee78c8d44a6c1ae0bf4a1def9a
Author: Paul Guo 
Date:   2016-07-12T06:12:19Z

HAWQ-917. Refactor feature tests for data type check with new googletest 
framework




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #786: HAWQ-808. Refactor feature test for external_oid ...

[xunzhang]

Github user xunzhang commented on the issue:

https://github.com/apache/incubator-hawq/pull/786
  
cc @yaoj2 @huor 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (HAWQ-808) Refactor feature test for external_oid with new framework

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372238#comment-15372238
 ] 

ASF GitHub Bot commented on HAWQ-808:
-

Github user xunzhang commented on the issue:

https://github.com/apache/incubator-hawq/pull/786
  
cc @yaoj2 @huor 


> Refactor feature test for external_oid with new framework
> -
>
> Key: HAWQ-808
> URL: https://issues.apache.org/jira/browse/HAWQ-808
> Project: Apache HAWQ
>  Issue Type: Sub-task
>  Components: Tests
>Reporter: hongwu
>Assignee: hongwu
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HAWQ-808) Refactor feature test for external_oid with new framework

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372230#comment-15372230
 ] 

ASF GitHub Bot commented on HAWQ-808:
-

GitHub user xunzhang opened a pull request:

https://github.com/apache/incubator-hawq/pull/786

HAWQ-808. Refactor feature test for external_oid with new framework.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xunzhang/incubator-hawq HAWQ-808

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/786.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #786


commit 6ed166bcc3078e00ed1a4721439cb50be58a6b39
Author: xunzhang 
Date:   2016-07-12T06:14:08Z

HAWQ-808. Refactor feature test for external_oid with new framework.




> Refactor feature test for external_oid with new framework
> -
>
> Key: HAWQ-808
> URL: https://issues.apache.org/jira/browse/HAWQ-808
> Project: Apache HAWQ
>  Issue Type: Sub-task
>  Components: Tests
>Reporter: hongwu
>Assignee: hongwu
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-hawq pull request #786: HAWQ-808. Refactor feature test for extern...

[xunzhang]

GitHub user xunzhang opened a pull request:

https://github.com/apache/incubator-hawq/pull/786

HAWQ-808. Refactor feature test for external_oid with new framework.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xunzhang/incubator-hawq HAWQ-808

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/786.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #786


commit 6ed166bcc3078e00ed1a4721439cb50be58a6b39
Author: xunzhang 
Date:   2016-07-12T06:14:08Z

HAWQ-808. Refactor feature test for external_oid with new framework.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (HAWQ-808) Refactor feature test for external_oid with new framework

[hongwu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

hongwu updated HAWQ-808:

Summary: Refactor feature test for external_oid with new framework  (was: 
Add feature test for external_oid with new framework)

> Refactor feature test for external_oid with new framework
> -
>
> Key: HAWQ-808
> URL: https://issues.apache.org/jira/browse/HAWQ-808
> Project: Apache HAWQ
>  Issue Type: Sub-task
>  Components: Tests
>Reporter: hongwu
>Assignee: hongwu
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HAWQ-917) Refactor feature tests for data type check with new googletest framework

[Paul Guo (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul Guo updated HAWQ-917:
--
Issue Type: Sub-task  (was: Bug)
Parent: HAWQ-832

> Refactor feature tests for data type check with new googletest framework
> 
>
> Key: HAWQ-917
> URL: https://issues.apache.org/jira/browse/HAWQ-917
> Project: Apache HAWQ
>  Issue Type: Sub-task
>Reporter: Paul Guo
>Assignee: Paul Guo
>
> This needs to refactor the following 15 test cases.
> ../../../regress/sql/boolean.sql
> ../../../regress/sql/char.sql
> ../../../regress/sql/date.sql
> ../../../regress/sql/float4.sql
> ../../../regress/sql/float8.sql
> ../../../regress/sql/int2.sql
> ../../../regress/sql/int4.sql
> ../../../regress/sql/int8.sql
> ../../../regress/sql/money.sql
> ../../../regress/sql/name.sql
> ../../../regress/sql/oid.sql
> ../../../regress/sql/text.sql
> ../../../regress/sql/time.sql
> ../../../regress/sql/type_sanity.sql
> ../../../regress/sql/varchar.sql



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (HAWQ-917) Refactor feature tests for data type check with new googletest framework

[Paul Guo (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul Guo reassigned HAWQ-917:
-

Assignee: Paul Guo  (was: Lei Chang)

> Refactor feature tests for data type check with new googletest framework
> 
>
> Key: HAWQ-917
> URL: https://issues.apache.org/jira/browse/HAWQ-917
> Project: Apache HAWQ
>  Issue Type: Bug
>Reporter: Paul Guo
>Assignee: Paul Guo
>
> This needs to refactor the following 15 test cases.
> ../../../regress/sql/boolean.sql
> ../../../regress/sql/char.sql
> ../../../regress/sql/date.sql
> ../../../regress/sql/float4.sql
> ../../../regress/sql/float8.sql
> ../../../regress/sql/int2.sql
> ../../../regress/sql/int4.sql
> ../../../regress/sql/int8.sql
> ../../../regress/sql/money.sql
> ../../../regress/sql/name.sql
> ../../../regress/sql/oid.sql
> ../../../regress/sql/text.sql
> ../../../regress/sql/time.sql
> ../../../regress/sql/type_sanity.sql
> ../../../regress/sql/varchar.sql



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HAWQ-917) Refactor feature tests for data type check with new googletest framework

[Paul Guo (JIRA)]

Paul Guo created HAWQ-917:
-

 Summary: Refactor feature tests for data type check with new 
googletest framework
 Key: HAWQ-917
 URL: https://issues.apache.org/jira/browse/HAWQ-917
 Project: Apache HAWQ
  Issue Type: Bug
Reporter: Paul Guo
Assignee: Lei Chang


This needs to refactor the following 15 test cases.

../../../regress/sql/boolean.sql
../../../regress/sql/char.sql
../../../regress/sql/date.sql
../../../regress/sql/float4.sql
../../../regress/sql/float8.sql
../../../regress/sql/int2.sql
../../../regress/sql/int4.sql
../../../regress/sql/int8.sql
../../../regress/sql/money.sql
../../../regress/sql/name.sql
../../../regress/sql/oid.sql
../../../regress/sql/text.sql
../../../regress/sql/time.sql
../../../regress/sql/type_sanity.sql
../../../regress/sql/varchar.sql



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)