[GitHub] [hbase] virajjasani commented on a change in pull request #809: HBASE-23261 : Processing ZK BadVersionException during node transition
virajjasani commented on a change in pull request #809: HBASE-23261 :
Processing ZK BadVersionException during node transition
URL: https://github.com/apache/hbase/pull/809#discussion_r344433718
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java
##
@@ -868,7 +868,15 @@ public static int transitionNode(ZooKeeperWatcher zkw,
HRegionInfo region,
try {
rt = RegionTransition.createRegionTransition(
endState, region.getRegionName(), serverName, payload);
- if(!ZKUtil.setData(zkw, node, rt.toByteArray(), stat.getVersion())) {
+ boolean isDataSet;
+ try {
+isDataSet = ZKUtil.setData(zkw, node, rt.toByteArray(),
stat.getVersion());
+ } catch (KeeperException.BadVersionException e) {
Review comment:
Thanks @bharathv
Agree to all points, however the reason why this Exception is not handled in
setData() is because we don't want to touch other workflows, i.e. if some
workflow already has some logic when they catch this Exception(many workflows
do catch it), they would never get to do it anymore.
I understand that handling BVE in setData() would be better fix but there
are so many workflows currently using it that we should not risk impacting them
while fixing our specific case of node transitioning, but yes this can be done
in another Jira given that the impact is huge and involves multiple workflows.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #809: HBASE-23261 : Processing ZK BadVersionException during node transition
virajjasani commented on a change in pull request #809: HBASE-23261 :
Processing ZK BadVersionException during node transition
URL: https://github.com/apache/hbase/pull/809#discussion_r344433482
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java
##
@@ -868,7 +868,15 @@ public static int transitionNode(ZooKeeperWatcher zkw,
HRegionInfo region,
try {
rt = RegionTransition.createRegionTransition(
endState, region.getRegionName(), serverName, payload);
- if(!ZKUtil.setData(zkw, node, rt.toByteArray(), stat.getVersion())) {
+ boolean isDataSet;
+ try {
+isDataSet = ZKUtil.setData(zkw, node, rt.toByteArray(),
stat.getVersion());
+ } catch (KeeperException.BadVersionException e) {
+isDataSet = false;
+LOG.info("Received BadVersionException from ZK for " + encoded
Review comment:
I agree we can move to slf4j logger and improve this, but may be in another
Jira :)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #809: HBASE-23261 : Processing ZK BadVersionException during node transition
virajjasani commented on a change in pull request #809: HBASE-23261 :
Processing ZK BadVersionException during node transition
URL: https://github.com/apache/hbase/pull/809#discussion_r344433462
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZKSplitTransactionCoordination.java
##
@@ -163,6 +166,10 @@ public void waitForSplitTransaction(final
RegionServerServices services, Region
}
Thread.sleep(100);
spins++;
+if (spins > SPLIT_WAIT_TIMEOUT) {
Review comment:
That is correct. What used to happen so far is, even if in the first try if
setData() to ZK fails, we used to propagate BVE up the caller and then rollback
splitting, with this patch, we will retry setData() at least 10-15 times before
we throw this Exception and hence, the probability of rollback of splitting due
to BVE comes down to almost 0
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #809: HBASE-23261 : Processing ZK BadVersionException during node transition
virajjasani commented on a change in pull request #809: HBASE-23261 : Processing ZK BadVersionException during node transition URL: https://github.com/apache/hbase/pull/809#discussion_r344433272 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZKSplitTransactionCoordination.java ## @@ -40,6 +40,9 @@ private CoordinatedStateManager coordinationManager; private final ZooKeeperWatcher watcher; + // max wait for split transaction - 100 times in a loop with 100 ms of thread sleep each time + private static final int SPLIT_WAIT_TIMEOUT = 100; Review comment: this accounts for ~24 s due to calls involved in loop. even for busy cluster, by this time, we should be able to retry calling setData() to ZK at least 10 times which I think should be sufficient if ZK node version is changed. In fact, ideally, 2nd time only should be sufficient to retrieve correct ZK node version and successfully updating RIT info in ZK node. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase
[
https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970742#comment-16970742
]
Hudson commented on HBASE-22514:
Results for branch HBASE-22514
[build #174 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/174/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/174//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/174//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/174//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Move rsgroup feature into core of HBase
> ---
>
> Key: HBASE-22514
> URL: https://issues.apache.org/jira/browse/HBASE-22514
> Project: HBase
> Issue Type: Umbrella
> Components: Admin, Client, rsgroup
>Reporter: Yechao Chen
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22514.master.001.patch,
> image-2019-05-31-18-25-38-217.png
>
>
> The class RSGroupAdminClient is not public
> we need to use java api RSGroupAdminClient to manager RSG
> so RSGroupAdminClient should be public
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22356) API to get hdfs block distribution from regionservers
[
https://issues.apache.org/jira/browse/HBASE-22356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970717#comment-16970717
]
HBase QA commented on HBASE-22356:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
43s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:blue}0{color} | {color:blue} prototool {color} | {color:blue} 0m
0s{color} | {color:blue} prototool was not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
27s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
6s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
20s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
40s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 5m
5s{color} | {color:blue} Used deprecated FindBugs config; considering switching
to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 10m
56s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
16s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 2m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
13s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
21m 54s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
3m 1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 12m
47s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
50s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
29s{color} | {color:green} hbase-protocol in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
0s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}245m
57s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green}
[jira] [Commented] (HBASE-23262) Cannot load Master UI
[
https://issues.apache.org/jira/browse/HBASE-23262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970711#comment-16970711
]
Hudson commented on HBASE-23262:
Results for branch branch-2.1
[build #1704 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1704/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1704//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1704//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1704//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Cannot load Master UI
> -
>
> Key: HBASE-23262
> URL: https://issues.apache.org/jira/browse/HBASE-23262
> Project: HBase
> Issue Type: Bug
> Components: master, UI
>Affects Versions: 3.0.0
>Reporter: Karthik Palanisamy
>Assignee: Karthik Palanisamy
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.8, 2.2.3
>
>
> If no online regionservers then master UI can't be opened. This issue occurs
> when using RSGroupAdminEndpoint coprocessor(RSGrouping). The master home
> page tries to load rsgroup info from "hbase:rsgroup" table but currently no
> regionservers up and running.
>
> [http://172.26.70.200:16010|http://172.26.70.200:16010/]
> {code:java}
> HTTP ERROR 500
> Problem accessing /master-status.
> Reason:
> Server Error
> Caused by:
> java.io.UncheckedIOException:
> org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after
> attempts=2, exceptions:
> ...
> Tue Nov
> 05 23:58:51 UTC 2019, , org.apache.hadoop.hbase.exceptions.TimeoutIOException:
> Timeout(9450ms) waiting for region location for hbase:rsgroup, row='',
> replicaId=0
> at
> org.apache.hadoop.hbase.client.ResultScanner$1.hasNext(ResultScanner.java:55)
> at
> org.apache.hadoop.hbase.RSGroupTableAccessor.getAllRSGroupInfo(RSGroupTableAccessor.java:59)
> at
> org.apache.hadoop.hbase.tmpl.master.RSGroupListTmplImpl.renderNoFlush(RSGroupListTmplImpl.java:58)
> at
> org.apache.hadoop.hbase.tmpl.master.RSGroupListTmpl.renderNoFlush(RSGroupListTmpl.java:150)
> at
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmplImpl.renderNoFlush(MasterStatusTmplImpl.java:346)
> at
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmpl.renderNoFlush(MasterStatusTmpl.java:397)
> at
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmpl.render(MasterStatusTmpl.java:388)
> at
> org.apache.hadoop.hbase.master.MasterStatusServlet.doGet(MasterStatusServlet.java:79)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-18439) Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
[
https://issues.apache.org/jira/browse/HBASE-18439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970714#comment-16970714
]
Hudson commented on HBASE-18439:
Results for branch branch-2.1
[build #1704 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1704/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1704//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1704//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1704//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
> --
>
> Key: HBASE-18439
> URL: https://issues.apache.org/jira/browse/HBASE-18439
> Project: HBase
> Issue Type: Bug
> Components: integration tests
>Reporter: Mike Drob
>Assignee: Rabi Kumar K C
>Priority: Minor
> Labels: beginner
> Fix For: 3.0.0, 2.3.0, 1.6.0, 1.4.12, 1.3.7, 2.1.8, 2.2.3
>
>
> A bunch of the actions all use the same logger inherited from the super
> class. We should have them declare distinct loggers, either each one in class
> or perhaps we can do something dynamically like
> {{LogFactory.getLogger(MethodHandles.lookup().lookupClass()}} and drop the
> static modifier on the log field.
> I'm not sure that exact incantation would actually work, but the
> MethodHandles approach in general is how logger resolution happens in Solr
> and it actually works out pretty well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23236) Upgrade to yetus 0.11.1
[
https://issues.apache.org/jira/browse/HBASE-23236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970712#comment-16970712
]
Hudson commented on HBASE-23236:
Results for branch branch-2.1
[build #1704 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1704/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1704//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1704//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1704//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Upgrade to yetus 0.11.1
> ---
>
> Key: HBASE-23236
> URL: https://issues.apache.org/jira/browse/HBASE-23236
> Project: HBase
> Issue Type: Task
> Components: build
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 1.4.12, 1.3.7, 2.1.8, 1.5.1, 2.2.3
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23228) Allow for jdk8 specific modules on branch-1 in precommit/nightly testing
[
https://issues.apache.org/jira/browse/HBASE-23228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970713#comment-16970713
]
Hudson commented on HBASE-23228:
Results for branch branch-2.1
[build #1704 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1704/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1704//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1704//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1704//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Allow for jdk8 specific modules on branch-1 in precommit/nightly testing
>
>
> Key: HBASE-23228
> URL: https://issues.apache.org/jira/browse/HBASE-23228
> Project: HBase
> Issue Type: Improvement
> Components: build, test
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Fix For: 3.0.0, 2.3.0, 1.6.0, 1.4.12, 2.1.8, 2.2.3
>
>
> At least 1 feature backport is waiting on proper handling of jdk8 activated
> modules for our yetus personality (HBASE-22114 tinylfu).
> Implement the general handling here so that we don't have to worry about
> pushes to the PR branch overwriting it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #810: HBASE-22356 API to get hdfs block distribution from regionservers
Apache-HBase commented on issue #810: HBASE-22356 API to get hdfs block distribution from regionservers URL: https://github.com/apache/hbase/pull/810#issuecomment-552059771 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | prototool | 0m 1s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 36s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 12s | master passed | | +1 :green_heart: | compile | 2m 28s | master passed | | +1 :green_heart: | checkstyle | 2m 22s | master passed | | +1 :green_heart: | shadedjars | 4m 38s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 28s | master passed | | +0 :ok: | spotbugs | 4m 5s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 8m 59s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 58s | the patch passed | | +1 :green_heart: | compile | 2m 25s | the patch passed | | +1 :green_heart: | cc | 2m 25s | the patch passed | | +1 :green_heart: | javac | 2m 25s | the patch passed | | +1 :green_heart: | checkstyle | 2m 21s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 4m 39s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 15m 38s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | hbaseprotoc | 2m 29s | the patch passed | | +1 :green_heart: | javadoc | 1m 29s | the patch passed | | +1 :green_heart: | findbugs | 9m 32s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 43s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 0m 27s | hbase-protocol in the patch passed. | | +1 :green_heart: | unit | 1m 56s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 162m 53s | hbase-server in the patch passed. | | +1 :green_heart: | asflicense | 1m 32s | The patch does not generate ASF License warnings. | | | | 244m 31s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-810/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/810 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool | | uname | Linux f4e82d368a61 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-810/out/precommit/personality/provided.sh | | git revision | master / 08aae42156 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-810/1/testReport/ | | Max. process+thread count | 4589 (vs. ulimit of 1) | | modules | C: hbase-protocol-shaded hbase-protocol hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-810/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22480) Get block from BlockCache once and return this block to BlockCache twice make ref count error.
[
https://issues.apache.org/jira/browse/HBASE-22480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970676#comment-16970676
]
Hudson commented on HBASE-22480:
Results for branch branch-2
[build #2348 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2348/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2348//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2348//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2348//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Get block from BlockCache once and return this block to BlockCache twice make
> ref count error.
> --
>
> Key: HBASE-22480
> URL: https://issues.apache.org/jira/browse/HBASE-22480
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 2.2.2
>Reporter: Lijin Bin
>Assignee: Lijin Bin
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.3
>
> Attachments: HBASE-22480-branch-2.2-v1.patch,
> HBASE-22480-branch-2.2-v1.patch, HBASE-22480-branch-2.2-v1.patch,
> HBASE-22480-branch-2.2-v2.patch, HBASE-22480-master-v1.patch,
> HBASE-22480-master-v2.patch, HBASE-22480-master-v3.patch,
> HBASE-22480-master-v4.patch, HBASE-22480-master-v5.patch,
> HBASE-22480-master-v6.patch, HBASE-22480-master-v6.patch,
> HBASE-22480-master-v6.patch, HBASE-22480-master-v7.patch,
> HBASE-22480-master-v7.patch
>
>
> After debugging HBASE-22433, i find the problem it is that we get a block
> from BucketCache once and return this block to BucketCache twice and make the
> ref count error, sometimes the refCount can be negative.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23262) Cannot load Master UI
[
https://issues.apache.org/jira/browse/HBASE-23262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970677#comment-16970677
]
Hudson commented on HBASE-23262:
Results for branch branch-2
[build #2348 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2348/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2348//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2348//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2348//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Cannot load Master UI
> -
>
> Key: HBASE-23262
> URL: https://issues.apache.org/jira/browse/HBASE-23262
> Project: HBase
> Issue Type: Bug
> Components: master, UI
>Affects Versions: 3.0.0
>Reporter: Karthik Palanisamy
>Assignee: Karthik Palanisamy
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.8, 2.2.3
>
>
> If no online regionservers then master UI can't be opened. This issue occurs
> when using RSGroupAdminEndpoint coprocessor(RSGrouping). The master home
> page tries to load rsgroup info from "hbase:rsgroup" table but currently no
> regionservers up and running.
>
> [http://172.26.70.200:16010|http://172.26.70.200:16010/]
> {code:java}
> HTTP ERROR 500
> Problem accessing /master-status.
> Reason:
> Server Error
> Caused by:
> java.io.UncheckedIOException:
> org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after
> attempts=2, exceptions:
> ...
> Tue Nov
> 05 23:58:51 UTC 2019, , org.apache.hadoop.hbase.exceptions.TimeoutIOException:
> Timeout(9450ms) waiting for region location for hbase:rsgroup, row='',
> replicaId=0
> at
> org.apache.hadoop.hbase.client.ResultScanner$1.hasNext(ResultScanner.java:55)
> at
> org.apache.hadoop.hbase.RSGroupTableAccessor.getAllRSGroupInfo(RSGroupTableAccessor.java:59)
> at
> org.apache.hadoop.hbase.tmpl.master.RSGroupListTmplImpl.renderNoFlush(RSGroupListTmplImpl.java:58)
> at
> org.apache.hadoop.hbase.tmpl.master.RSGroupListTmpl.renderNoFlush(RSGroupListTmpl.java:150)
> at
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmplImpl.renderNoFlush(MasterStatusTmplImpl.java:346)
> at
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmpl.renderNoFlush(MasterStatusTmpl.java:397)
> at
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmpl.render(MasterStatusTmpl.java:388)
> at
> org.apache.hadoop.hbase.master.MasterStatusServlet.doGet(MasterStatusServlet.java:79)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22888) Share some stuffs with the initial reader when new stream reader created
[
https://issues.apache.org/jira/browse/HBASE-22888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970680#comment-16970680
]
Hudson commented on HBASE-22888:
Results for branch branch-2
[build #2348 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2348/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2348//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2348//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2348//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Share some stuffs with the initial reader when new stream reader created
>
>
> Key: HBASE-22888
> URL: https://issues.apache.org/jira/browse/HBASE-22888
> Project: HBase
> Issue Type: Improvement
> Components: HFile, regionserver
>Affects Versions: 2.0.0
>Reporter: chenxu
>Assignee: chenxu
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> When switching pread to stream read, new HFileReaderImpl will be create, but
> the two different readers do not share informations with each other. maybe we
> can divide HFileReaderImpl into two different class, such as HFilePreadReader
> and HFileStreamReader. When constructing HFileStreamReader, it will copy some
> stuffs (fileInfo, index, etc) from an already existing Reader, and no need to
> do prefetch operations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23228) Allow for jdk8 specific modules on branch-1 in precommit/nightly testing
[
https://issues.apache.org/jira/browse/HBASE-23228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970681#comment-16970681
]
Hudson commented on HBASE-23228:
Results for branch branch-2
[build #2348 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2348/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2348//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2348//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2348//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Allow for jdk8 specific modules on branch-1 in precommit/nightly testing
>
>
> Key: HBASE-23228
> URL: https://issues.apache.org/jira/browse/HBASE-23228
> Project: HBase
> Issue Type: Improvement
> Components: build, test
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Fix For: 3.0.0, 2.3.0, 1.6.0, 1.4.12, 2.1.8, 2.2.3
>
>
> At least 1 feature backport is waiting on proper handling of jdk8 activated
> modules for our yetus personality (HBASE-22114 tinylfu).
> Implement the general handling here so that we don't have to worry about
> pushes to the PR branch overwriting it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23236) Upgrade to yetus 0.11.1
[
https://issues.apache.org/jira/browse/HBASE-23236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970679#comment-16970679
]
Hudson commented on HBASE-23236:
Results for branch branch-2
[build #2348 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2348/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2348//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2348//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2348//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Upgrade to yetus 0.11.1
> ---
>
> Key: HBASE-23236
> URL: https://issues.apache.org/jira/browse/HBASE-23236
> Project: HBase
> Issue Type: Task
> Components: build
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 1.4.12, 1.3.7, 2.1.8, 1.5.1, 2.2.3
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-18439) Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
[
https://issues.apache.org/jira/browse/HBASE-18439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970682#comment-16970682
]
Hudson commented on HBASE-18439:
Results for branch branch-2
[build #2348 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2348/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2348//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2348//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2348//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
> --
>
> Key: HBASE-18439
> URL: https://issues.apache.org/jira/browse/HBASE-18439
> Project: HBase
> Issue Type: Bug
> Components: integration tests
>Reporter: Mike Drob
>Assignee: Rabi Kumar K C
>Priority: Minor
> Labels: beginner
> Fix For: 3.0.0, 2.3.0, 1.6.0, 1.4.12, 1.3.7, 2.1.8, 2.2.3
>
>
> A bunch of the actions all use the same logger inherited from the super
> class. We should have them declare distinct loggers, either each one in class
> or perhaps we can do something dynamically like
> {{LogFactory.getLogger(MethodHandles.lookup().lookupClass()}} and drop the
> static modifier on the log field.
> I'm not sure that exact incantation would actually work, but the
> MethodHandles approach in general is how logger resolution happens in Solr
> and it actually works out pretty well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23263) NPE in Quotas.jsp
[
https://issues.apache.org/jira/browse/HBASE-23263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970678#comment-16970678
]
Hudson commented on HBASE-23263:
Results for branch branch-2
[build #2348 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2348/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2348//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2348//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2348//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> NPE in Quotas.jsp
> -
>
> Key: HBASE-23263
> URL: https://issues.apache.org/jira/browse/HBASE-23263
> Project: HBase
> Issue Type: Bug
> Components: UI
>Affects Versions: 3.0.0
>Reporter: Karthik Palanisamy
>Assignee: Karthik Palanisamy
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.3
>
>
> QuotaManager will be started after master initialization. If no online
> regionservers then master will not be initialized and will throw NPE over
> accessing Quota page.
>
> [http://172.26.70.200:16010/quotas.jsp]
> {code:java}
> HTTP ERROR 500
> Problem accessing /quotas.jsp.
> Reason:
> Server Error
> Caused by:java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.generated.master.quotas_jsp._jspService(quotas_jsp.java:58)
> at
> org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:111)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
> at
> org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:840)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1780)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23236) Upgrade to yetus 0.11.1
[
https://issues.apache.org/jira/browse/HBASE-23236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970645#comment-16970645
]
Hudson commented on HBASE-23236:
Results for branch branch-1.3
[build #1032 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/1032/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/1032//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/1032//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/1032//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Upgrade to yetus 0.11.1
> ---
>
> Key: HBASE-23236
> URL: https://issues.apache.org/jira/browse/HBASE-23236
> Project: HBase
> Issue Type: Task
> Components: build
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 1.4.12, 1.3.7, 2.1.8, 1.5.1, 2.2.3
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23263) NPE in Quotas.jsp
[
https://issues.apache.org/jira/browse/HBASE-23263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970641#comment-16970641
]
Hudson commented on HBASE-23263:
Results for branch branch-2.2
[build #687 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/687/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/687//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/687//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/687//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> NPE in Quotas.jsp
> -
>
> Key: HBASE-23263
> URL: https://issues.apache.org/jira/browse/HBASE-23263
> Project: HBase
> Issue Type: Bug
> Components: UI
>Affects Versions: 3.0.0
>Reporter: Karthik Palanisamy
>Assignee: Karthik Palanisamy
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.3
>
>
> QuotaManager will be started after master initialization. If no online
> regionservers then master will not be initialized and will throw NPE over
> accessing Quota page.
>
> [http://172.26.70.200:16010/quotas.jsp]
> {code:java}
> HTTP ERROR 500
> Problem accessing /quotas.jsp.
> Reason:
> Server Error
> Caused by:java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.generated.master.quotas_jsp._jspService(quotas_jsp.java:58)
> at
> org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:111)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
> at
> org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:840)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1780)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22480) Get block from BlockCache once and return this block to BlockCache twice make ref count error.
[
https://issues.apache.org/jira/browse/HBASE-22480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970639#comment-16970639
]
Hudson commented on HBASE-22480:
Results for branch branch-2.2
[build #687 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/687/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/687//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/687//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/687//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Get block from BlockCache once and return this block to BlockCache twice make
> ref count error.
> --
>
> Key: HBASE-22480
> URL: https://issues.apache.org/jira/browse/HBASE-22480
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 2.2.2
>Reporter: Lijin Bin
>Assignee: Lijin Bin
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.3
>
> Attachments: HBASE-22480-branch-2.2-v1.patch,
> HBASE-22480-branch-2.2-v1.patch, HBASE-22480-branch-2.2-v1.patch,
> HBASE-22480-branch-2.2-v2.patch, HBASE-22480-master-v1.patch,
> HBASE-22480-master-v2.patch, HBASE-22480-master-v3.patch,
> HBASE-22480-master-v4.patch, HBASE-22480-master-v5.patch,
> HBASE-22480-master-v6.patch, HBASE-22480-master-v6.patch,
> HBASE-22480-master-v6.patch, HBASE-22480-master-v7.patch,
> HBASE-22480-master-v7.patch
>
>
> After debugging HBASE-22433, i find the problem it is that we get a block
> from BucketCache once and return this block to BucketCache twice and make the
> ref count error, sometimes the refCount can be negative.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23236) Upgrade to yetus 0.11.1
[
https://issues.apache.org/jira/browse/HBASE-23236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970642#comment-16970642
]
Hudson commented on HBASE-23236:
Results for branch branch-2.2
[build #687 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/687/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/687//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/687//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/687//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Upgrade to yetus 0.11.1
> ---
>
> Key: HBASE-23236
> URL: https://issues.apache.org/jira/browse/HBASE-23236
> Project: HBase
> Issue Type: Task
> Components: build
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 1.4.12, 1.3.7, 2.1.8, 1.5.1, 2.2.3
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23262) Cannot load Master UI
[
https://issues.apache.org/jira/browse/HBASE-23262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970640#comment-16970640
]
Hudson commented on HBASE-23262:
Results for branch branch-2.2
[build #687 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/687/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/687//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/687//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/687//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Cannot load Master UI
> -
>
> Key: HBASE-23262
> URL: https://issues.apache.org/jira/browse/HBASE-23262
> Project: HBase
> Issue Type: Bug
> Components: master, UI
>Affects Versions: 3.0.0
>Reporter: Karthik Palanisamy
>Assignee: Karthik Palanisamy
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.8, 2.2.3
>
>
> If no online regionservers then master UI can't be opened. This issue occurs
> when using RSGroupAdminEndpoint coprocessor(RSGrouping). The master home
> page tries to load rsgroup info from "hbase:rsgroup" table but currently no
> regionservers up and running.
>
> [http://172.26.70.200:16010|http://172.26.70.200:16010/]
> {code:java}
> HTTP ERROR 500
> Problem accessing /master-status.
> Reason:
> Server Error
> Caused by:
> java.io.UncheckedIOException:
> org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after
> attempts=2, exceptions:
> ...
> Tue Nov
> 05 23:58:51 UTC 2019, , org.apache.hadoop.hbase.exceptions.TimeoutIOException:
> Timeout(9450ms) waiting for region location for hbase:rsgroup, row='',
> replicaId=0
> at
> org.apache.hadoop.hbase.client.ResultScanner$1.hasNext(ResultScanner.java:55)
> at
> org.apache.hadoop.hbase.RSGroupTableAccessor.getAllRSGroupInfo(RSGroupTableAccessor.java:59)
> at
> org.apache.hadoop.hbase.tmpl.master.RSGroupListTmplImpl.renderNoFlush(RSGroupListTmplImpl.java:58)
> at
> org.apache.hadoop.hbase.tmpl.master.RSGroupListTmpl.renderNoFlush(RSGroupListTmpl.java:150)
> at
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmplImpl.renderNoFlush(MasterStatusTmplImpl.java:346)
> at
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmpl.renderNoFlush(MasterStatusTmpl.java:397)
> at
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmpl.render(MasterStatusTmpl.java:388)
> at
> org.apache.hadoop.hbase.master.MasterStatusServlet.doGet(MasterStatusServlet.java:79)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23228) Allow for jdk8 specific modules on branch-1 in precommit/nightly testing
[
https://issues.apache.org/jira/browse/HBASE-23228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970643#comment-16970643
]
Hudson commented on HBASE-23228:
Results for branch branch-2.2
[build #687 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/687/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/687//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/687//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/687//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Allow for jdk8 specific modules on branch-1 in precommit/nightly testing
>
>
> Key: HBASE-23228
> URL: https://issues.apache.org/jira/browse/HBASE-23228
> Project: HBase
> Issue Type: Improvement
> Components: build, test
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Fix For: 3.0.0, 2.3.0, 1.6.0, 1.4.12, 2.1.8, 2.2.3
>
>
> At least 1 feature backport is waiting on proper handling of jdk8 activated
> modules for our yetus personality (HBASE-22114 tinylfu).
> Implement the general handling here so that we don't have to worry about
> pushes to the PR branch overwriting it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] apurtell commented on issue #787: HBASE-23245 : MutableHistogram constructor changes and provide Histog…
apurtell commented on issue #787: HBASE-23245 : MutableHistogram constructor changes and provide Histog… URL: https://github.com/apache/hbase/pull/787#issuecomment-552023604 If no further concerns we can merge and backport this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] apurtell commented on a change in pull request #787: HBASE-23245 : MutableHistogram constructor changes and provide Histog…
apurtell commented on a change in pull request #787: HBASE-23245 :
MutableHistogram constructor changes and provide Histog…
URL: https://github.com/apache/hbase/pull/787#discussion_r344398956
##
File path:
hbase-metrics/src/main/java/org/apache/hadoop/hbase/metrics/impl/HistogramImpl.java
##
@@ -36,7 +36,7 @@
private final CounterImpl counter;
public HistogramImpl() {
-this(Integer.MAX_VALUE << 2);
+this((long) Integer.MAX_VALUE << 2);
Review comment:
I see, this is the change that required the test changes
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-22356) API to get hdfs block distribution from regionservers
[ https://issues.apache.org/jira/browse/HBASE-22356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970624#comment-16970624 ] Thiruvel Thirumoolan commented on HBASE-22356: -- [~binlijin] - Updated the patch on reviewboard for you to quickly see the differences and also submitted a PR to github master branch. Thanks for your time in reviews. > API to get hdfs block distribution from regionservers > - > > Key: HBASE-22356 > URL: https://issues.apache.org/jira/browse/HBASE-22356 > Project: HBase > Issue Type: Sub-task > Components: API, Balancer, regionserver >Reporter: Thiruvel Thirumoolan >Assignee: Thiruvel Thirumoolan >Priority: Major > Labels: balancer > Fix For: 3.0.0, 2.3.0, 1.6.0 > > Attachments: HBASE-22356.master.001.patch, > HBASE-22356.master.002.patch, HBASE-22356.master.003.patch > > > A RegionServer API has to be added which will return HDFSBlockDistribution > for all the regions it hosts. RS already has this info cached and updated > when flush/compaction happens. Master can query and get instead of hitting > the namenode and caching. The larger the cluster becomes, the more costly it > becomes to get this information and more stale the cached information becomes. > This jira is only to add the API to regionserver. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] apurtell commented on issue #796: HBASE-23251 - Add Column Family and Table Names to HFileContext and u…
apurtell commented on issue #796: HBASE-23251 - Add Column Family and Table Names to HFileContext and u… URL: https://github.com/apache/hbase/pull/796#issuecomment-552022689 Precommit looks good, are we good to go @openinx ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] thiruvel opened a new pull request #810: HBASE-22356 API to get hdfs block distribution from regionservers
thiruvel opened a new pull request #810: HBASE-22356 API to get hdfs block distribution from regionservers URL: https://github.com/apache/hbase/pull/810 @binlijin - This is comments addressed from your review on https://reviews.apache.org/r/70586/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22356) API to get hdfs block distribution from regionservers
[ https://issues.apache.org/jira/browse/HBASE-22356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiruvel Thirumoolan updated HBASE-22356: - Attachment: HBASE-22356.master.003.patch > API to get hdfs block distribution from regionservers > - > > Key: HBASE-22356 > URL: https://issues.apache.org/jira/browse/HBASE-22356 > Project: HBase > Issue Type: Sub-task > Components: API, Balancer, regionserver >Reporter: Thiruvel Thirumoolan >Assignee: Thiruvel Thirumoolan >Priority: Major > Labels: balancer > Fix For: 3.0.0, 2.3.0, 1.6.0 > > Attachments: HBASE-22356.master.001.patch, > HBASE-22356.master.002.patch, HBASE-22356.master.003.patch > > > A RegionServer API has to be added which will return HDFSBlockDistribution > for all the regions it hosts. RS already has this info cached and updated > when flush/compaction happens. Master can query and get instead of hitting > the namenode and caching. The larger the cluster becomes, the more costly it > becomes to get this information and more stale the cached information becomes. > This jira is only to add the API to regionserver. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-18439) Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
[
https://issues.apache.org/jira/browse/HBASE-18439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970623#comment-16970623
]
Hudson commented on HBASE-18439:
SUCCESS: Integrated in Jenkins build HBase-1.3-IT #671 (See
[https://builds.apache.org/job/HBase-1.3-IT/671/])
HBASE-18439 Subclasses of o.a.h.h.chaos.actions.Action all use the same
(jan.hentschel: rev f7ca22fd4890a952fcf8fa66254fe08567bf2306)
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartRandomRsAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/SplitRandomRegionOfTableAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/UnbalanceRegionsAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeSplitPolicyAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RollingBatchRestartRsAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeBloomFilterAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartRsHoldingMetaAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartRandomZKNodeAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeEncodingAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/AddColumnAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/SplitAllRegionOfTableAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/MergeRandomAdjacentRegionsOfTableAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/MoveRegionsOfTableAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/Action.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ForceBalancerAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/BatchRestartRsAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/MoveRandomRegionOfTableAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/SnapshotTableAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/TruncateTableAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RemoveColumnAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartActionBaseAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartRandomDataNodeAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/FlushRandomRegionOfTableAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/CompactTableAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/CompactRandomRegionOfTableAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/FlushTableAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartRsHoldingTableAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartActiveMasterAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/UnbalanceKillAndRebalanceAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeVersionsAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeCompressionAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/DumpClusterStatusAction.java
> Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
> --
>
> Key: HBASE-18439
> URL: https://issues.apache.org/jira/browse/HBASE-18439
> Project: HBase
> Issue Type: Bug
> Components: integration tests
>Reporter: Mike Drob
>Assignee: Rabi Kumar K C
>Priority: Minor
> Labels: beginner
> Fix For: 3.0.0, 2.3.0, 1.6.0, 1.4.12, 1.3.7, 2.1.8, 2.2.3
>
>
> A bunch of the actions all use the same logger inherited from the super
> class. We should have them declare distinct loggers, either each one in class
> or perhaps we can do something dynamically like
> {{LogFactory.getLogger(MethodHandles.lookup().lookupClass()}} and drop the
> static modifier on the log field.
> I'm not sure that exact incantation would actually work, but the
> MethodHandles approach in general is how logger resolution happens in Solr
> and it actually works out pretty well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (HBASE-18439) Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
[
https://issues.apache.org/jira/browse/HBASE-18439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel resolved HBASE-18439.
---
Fix Version/s: 2.2.3
2.1.8
1.3.7
1.4.12
1.6.0
2.3.0
3.0.0
Hadoop Flags: Reviewed
Resolution: Fixed
> Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
> --
>
> Key: HBASE-18439
> URL: https://issues.apache.org/jira/browse/HBASE-18439
> Project: HBase
> Issue Type: Bug
> Components: integration tests
>Reporter: Mike Drob
>Assignee: Rabi Kumar K C
>Priority: Minor
> Labels: beginner
> Fix For: 3.0.0, 2.3.0, 1.6.0, 1.4.12, 1.3.7, 2.1.8, 2.2.3
>
>
> A bunch of the actions all use the same logger inherited from the super
> class. We should have them declare distinct loggers, either each one in class
> or perhaps we can do something dynamically like
> {{LogFactory.getLogger(MethodHandles.lookup().lookupClass()}} and drop the
> static modifier on the log field.
> I'm not sure that exact incantation would actually work, but the
> MethodHandles approach in general is how logger resolution happens in Solr
> and it actually works out pretty well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (HBASE-23230) Enforce member visibility in HRegionServer
[
https://issues.apache.org/jira/browse/HBASE-23230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk resolved HBASE-23230.
--
Resolution: Fixed
Merged to master, branch-2. Thanks for the reviews [~stack], [~binlijin].
> Enforce member visibility in HRegionServer
> --
>
> Key: HBASE-23230
> URL: https://issues.apache.org/jira/browse/HBASE-23230
> Project: HBase
> Issue Type: Task
> Components: regionserver
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> {{HRegionServer}} leaks member variables quite a lot. Lock down our interface
> -- member variables should be {{private}} (unless intentionally {{protected}}
> for subclasses) and use getters with proper accessibility constraints.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-23230) Enforce member visibility in HRegionServer
[
https://issues.apache.org/jira/browse/HBASE-23230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-23230:
-
Fix Version/s: 2.3.0
> Enforce member visibility in HRegionServer
> --
>
> Key: HBASE-23230
> URL: https://issues.apache.org/jira/browse/HBASE-23230
> Project: HBase
> Issue Type: Task
> Components: regionserver
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> {{HRegionServer}} leaks member variables quite a lot. Lock down our interface
> -- member variables should be {{private}} (unless intentionally {{protected}}
> for subclasses) and use getters with proper accessibility constraints.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #796: HBASE-23251 - Add Column Family and Table Names to HFileContext and u…
Apache-HBase commented on issue #796: HBASE-23251 - Add Column Family and Table Names to HFileContext and u… URL: https://github.com/apache/hbase/pull/796#issuecomment-552009890 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 4 new or modified test files. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 33s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 43s | master passed | | +1 :green_heart: | compile | 1m 43s | master passed | | +1 :green_heart: | checkstyle | 2m 16s | master passed | | +1 :green_heart: | shadedjars | 4m 58s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 15s | master passed | | +0 :ok: | spotbugs | 4m 25s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 5m 59s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 31s | the patch passed | | +1 :green_heart: | compile | 1m 43s | the patch passed | | +1 :green_heart: | javac | 1m 43s | the patch passed | | +1 :green_heart: | checkstyle | 2m 15s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 4m 57s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 17m 9s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 1m 11s | the patch passed | | +1 :green_heart: | findbugs | 6m 48s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 54s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 160m 40s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 17m 27s | hbase-mapreduce in the patch passed. | | +1 :green_heart: | asflicense | 1m 19s | The patch does not generate ASF License warnings. | | | | 252m 24s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-796/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/796 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 63d329a31420 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-796/out/precommit/personality/provided.sh | | git revision | master / 08aae42156 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-796/5/testReport/ | | Max. process+thread count | 5324 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server hbase-mapreduce U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-796/5/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk merged pull request #806: HBASE-23230 Enforce member visibility in HRegionServer
ndimiduk merged pull request #806: HBASE-23230 Enforce member visibility in HRegionServer URL: https://github.com/apache/hbase/pull/806 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] busbey commented on issue #251: HBASE-22114 Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1
busbey commented on issue #251: HBASE-22114 Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1 URL: https://github.com/apache/hbase/pull/251#issuecomment-552002566 I see some edge cases caused by our use of multijdk that I hadn't considered. let me dig. this looks like an issue with the patch: > -1 ❌ | hbaseanti | 0m 0s | The patch appears use Hadoop classification instead of HBase. I think I fixed it previously but had the change reverted during a rebase. Presuming it doesn't get handled in the mean time, I'll fix it locally before merging. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #809: HBASE-23261 : Processing ZK BadVersionException during node transition
Apache-HBase commented on issue #809: HBASE-23261 : Processing ZK BadVersionException during node transition URL: https://github.com/apache/hbase/pull/809#issuecomment-551998876 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 16s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-1.3 Compile Tests _ | | +0 :ok: | mvndep | 1m 24s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 6m 29s | branch-1.3 passed | | +1 :green_heart: | compile | 0m 56s | branch-1.3 passed with JDK v1.8.0_232 | | +1 :green_heart: | compile | 1m 5s | branch-1.3 passed with JDK v1.7.0_242 | | +1 :green_heart: | checkstyle | 2m 20s | branch-1.3 passed | | +1 :green_heart: | shadedjars | 2m 51s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 51s | branch-1.3 passed with JDK v1.8.0_232 | | +1 :green_heart: | javadoc | 1m 4s | branch-1.3 passed with JDK v1.7.0_242 | | +0 :ok: | spotbugs | 2m 44s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 4m 9s | branch-1.3 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 1m 59s | the patch passed | | +1 :green_heart: | compile | 0m 55s | the patch passed with JDK v1.8.0_232 | | +1 :green_heart: | javac | 0m 55s | the patch passed | | +1 :green_heart: | compile | 1m 6s | the patch passed with JDK v1.7.0_242 | | +1 :green_heart: | javac | 1m 6s | the patch passed | | +1 :green_heart: | checkstyle | 2m 19s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 2m 48s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 10m 15s | Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7. | | +1 :green_heart: | javadoc | 0m 47s | the patch passed with JDK v1.8.0_232 | | +1 :green_heart: | javadoc | 1m 7s | the patch passed with JDK v1.7.0_242 | | +1 :green_heart: | findbugs | 4m 31s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 5s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 124m 23s | hbase-server in the patch passed. | | +1 :green_heart: | asflicense | 0m 40s | The patch does not generate ASF License warnings. | | | | 177m 36s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-809/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/809 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 2a6edac2248e 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-809/out/precommit/personality/provided.sh | | git revision | branch-1.3 / c5f6d04 | | Default Java | 1.7.0_242 | | Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-809/1/testReport/ | | Max. process+thread count | 3603 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-809/1/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure
[GitHub] [hbase] Apache-HBase commented on issue #251: HBASE-22114 Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1
Apache-HBase commented on issue #251: HBASE-22114 Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1 URL: https://github.com/apache/hbase/pull/251#issuecomment-551998196 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 21s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | -1 :x: | hbaseanti | 0m 0s | The patch appears use Hadoop classification instead of HBase. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | ||| _ branch-1 Compile Tests _ | | +0 :ok: | mvndep | 1m 46s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 7m 16s | branch-1 passed | | +1 :green_heart: | compile | 1m 45s | branch-1 passed with JDK v1.8.0_232 | | +1 :green_heart: | compile | 1m 50s | branch-1 passed with JDK v1.7.0_242 | | +1 :green_heart: | checkstyle | 7m 41s | branch-1 passed | | +0 :ok: | refguide | 3m 25s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | shadedjars | 2m 53s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 22s | branch-1 passed with JDK v1.8.0_232 | | +1 :green_heart: | javadoc | 5m 32s | branch-1 passed with JDK v1.7.0_242 | | +0 :ok: | spotbugs | 2m 33s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +0 :ok: | findbugs | 0m 19s | branch/hbase-resource-bundle no findbugs output file (findbugsXml.xml) | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 1s | the patch passed | | +1 :green_heart: | compile | 1m 46s | the patch passed with JDK v1.8.0_232 | | +1 :green_heart: | javac | 1m 46s | the patch passed | | +1 :green_heart: | compile | 1m 50s | the patch passed with JDK v1.7.0_242 | | +1 :green_heart: | javac | 1m 50s | the patch passed | | +1 :green_heart: | checkstyle | 5m 2s | root: The patch generated 0 new + 87 unchanged - 11 fixed = 87 total (was 98) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | -1 :x: | xml | 0m 1s | The patch has 5 ill-formed XML file(s). | | +0 :ok: | refguide | 3m 2s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | -1 :x: | shadedjars | 0m 15s | patch has 7 errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 5m 16s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | -1 :x: | javadoc | 1m 53s | root in the patch failed with JDK v1.8.0_232. | | +1 :green_heart: | javadoc | 3m 46s | the patch passed with JDK v1.7.0_242 | | +0 :ok: | findbugs | 0m 13s | hbase-resource-bundle has no data from findbugs | | -1 :x: | findbugs | 0m 12s | hbase-tinylfu-blockcache in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 222m 24s | root in the patch failed. | | -1 :x: | asflicense | 0m 37s | The patch generated 4 ASF License warnings. | | | | 320m 40s | | | Reason | Tests | |---:|:--| | XML | Parsing Error(s): | | | hbase-common/src/main/resources/hbase-default.xml | | | hbase-it/pom.xml | | | hbase-resource-bundle/src/main/resources/supplemental-models.xml | | | hbase-tinylfu-blockcache/pom.xml | | | pom.xml | | Failed junit tests | hadoop.hbase.master.normalizer.TestSimpleRegionNormalizerOnCluster | | | hadoop.hbase.client.TestAdmin1 | | | hadoop.hbase.client.TestAdmin2 | | | hadoop.hbase.master.TestMasterBalanceThrottling | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-251/31/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/251 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml | | uname | Linux eaea4e21b338 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-251/out/precommit/personality/provided.sh | | git revision | branch-1 / 72d622b | | Default Jav
[jira] [Commented] (HBASE-23236) Upgrade to yetus 0.11.1
[
https://issues.apache.org/jira/browse/HBASE-23236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970590#comment-16970590
]
Hudson commented on HBASE-23236:
Results for branch branch-1.4
[build #1081 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/1081/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/1081//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/1081//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/1081//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Upgrade to yetus 0.11.1
> ---
>
> Key: HBASE-23236
> URL: https://issues.apache.org/jira/browse/HBASE-23236
> Project: HBase
> Issue Type: Task
> Components: build
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 1.4.12, 1.3.7, 2.1.8, 1.5.1, 2.2.3
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23228) Allow for jdk8 specific modules on branch-1 in precommit/nightly testing
[
https://issues.apache.org/jira/browse/HBASE-23228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970591#comment-16970591
]
Hudson commented on HBASE-23228:
Results for branch branch-1.4
[build #1081 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/1081/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/1081//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/1081//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/1081//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Allow for jdk8 specific modules on branch-1 in precommit/nightly testing
>
>
> Key: HBASE-23228
> URL: https://issues.apache.org/jira/browse/HBASE-23228
> Project: HBase
> Issue Type: Improvement
> Components: build, test
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Fix For: 3.0.0, 2.3.0, 1.6.0, 1.4.12, 2.1.8, 2.2.3
>
>
> At least 1 feature backport is waiting on proper handling of jdk8 activated
> modules for our yetus personality (HBASE-22114 tinylfu).
> Implement the general handling here so that we don't have to worry about
> pushes to the PR branch overwriting it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23259) Ability to run mini cluster using pre-determined available random ports
[
https://issues.apache.org/jira/browse/HBASE-23259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970589#comment-16970589
]
HBase QA commented on HBASE-23259:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
33s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
1s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 4 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
35s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
39s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
58s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 3m
59s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
46s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
16s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
25s{color} | {color:green} The patch passed checkstyle in hbase-common {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
25s{color} | {color:green} hbase-server: The patch generated 0 new + 255
unchanged - 5 fixed = 255 total (was 260) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
31s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
15m 31s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
11s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
5s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}161m
58s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
2s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}227m 12s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.4 Server=19.03.4 base:
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-807/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/807 |
|
[GitHub] [hbase] Apache-HBase commented on issue #807: HBASE-23259: Ability to start minicluster with pre-determined master ports
Apache-HBase commented on issue #807: HBASE-23259: Ability to start minicluster with pre-determined master ports URL: https://github.com/apache/hbase/pull/807#issuecomment-551995893 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 4 new or modified test files. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 35s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 11s | master passed | | +1 :green_heart: | compile | 1m 20s | master passed | | +1 :green_heart: | checkstyle | 1m 50s | master passed | | +1 :green_heart: | shadedjars | 4m 39s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 58s | master passed | | +0 :ok: | spotbugs | 3m 59s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 4m 46s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 2s | the patch passed | | +1 :green_heart: | compile | 1m 19s | the patch passed | | +1 :green_heart: | javac | 1m 19s | the patch passed | | +1 :green_heart: | checkstyle | 0m 25s | The patch passed checkstyle in hbase-common | | +1 :green_heart: | checkstyle | 1m 25s | hbase-server: The patch generated 0 new + 255 unchanged - 5 fixed = 255 total (was 260) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 4m 31s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 15m 31s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 0m 58s | the patch passed | | +1 :green_heart: | findbugs | 5m 11s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 3m 5s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 161m 58s | hbase-server in the patch passed. | | +1 :green_heart: | asflicense | 1m 2s | The patch does not generate ASF License warnings. | | | | 227m 12s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-807/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/807 | | JIRA Issue | HBASE-23259 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 626d57594a5d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-807/out/precommit/personality/provided.sh | | git revision | master / d5dcc090c1 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-807/2/testReport/ | | Max. process+thread count | 4417 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-807/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #809: HBASE-23261 : Processing ZK BadVersionException during node transition
bharathv commented on a change in pull request #809: HBASE-23261 : Processing
ZK BadVersionException during node transition
URL: https://github.com/apache/hbase/pull/809#discussion_r344334810
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZKSplitTransactionCoordination.java
##
@@ -163,6 +166,10 @@ public void waitForSplitTransaction(final
RegionServerServices services, Region
}
Thread.sleep(100);
spins++;
+if (spins > SPLIT_WAIT_TIMEOUT) {
Review comment:
I'm trying to wrap my head around the state machine here. So this is more of
a question, if we throw here and assuming that the master still transitioned
the region racily to "SPLITTING", we will still end up rolling back the
transaction right? That seems to be the case based on the logic in
"doSplitting()", but just wanted to double check.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #809: HBASE-23261 : Processing ZK BadVersionException during node transition
bharathv commented on a change in pull request #809: HBASE-23261 : Processing
ZK BadVersionException during node transition
URL: https://github.com/apache/hbase/pull/809#discussion_r344329475
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java
##
@@ -868,7 +868,15 @@ public static int transitionNode(ZooKeeperWatcher zkw,
HRegionInfo region,
try {
rt = RegionTransition.createRegionTransition(
endState, region.getRegionName(), serverName, payload);
- if(!ZKUtil.setData(zkw, node, rt.toByteArray(), stat.getVersion())) {
+ boolean isDataSet;
+ try {
+isDataSet = ZKUtil.setData(zkw, node, rt.toByteArray(),
stat.getVersion());
+ } catch (KeeperException.BadVersionException e) {
Review comment:
Looking at all the callers of this, it appears to me that
BadVersionException needs to be handled in setData(). Currently every call to
this has this pattern,
try {
setData()
} catch (BadVersionException e) {
}
Instead handle it in setData() and refactor the callers to read the return
val? (on a related note, the javadoc for setData() seems incorrect. (===> If
their is a version mismatch, method returns null).
I don't have much context here but it seems reasonable to me that setData()
should gracefully handle version mismatches.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #809: HBASE-23261 : Processing ZK BadVersionException during node transition
bharathv commented on a change in pull request #809: HBASE-23261 : Processing
ZK BadVersionException during node transition
URL: https://github.com/apache/hbase/pull/809#discussion_r344324610
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java
##
@@ -868,7 +868,15 @@ public static int transitionNode(ZooKeeperWatcher zkw,
HRegionInfo region,
try {
rt = RegionTransition.createRegionTransition(
endState, region.getRegionName(), serverName, payload);
- if(!ZKUtil.setData(zkw, node, rt.toByteArray(), stat.getVersion())) {
+ boolean isDataSet;
+ try {
+isDataSet = ZKUtil.setData(zkw, node, rt.toByteArray(),
stat.getVersion());
+ } catch (KeeperException.BadVersionException e) {
+isDataSet = false;
+LOG.info("Received BadVersionException from ZK for " + encoded
Review comment:
I see ok. Looks like branch-1.3 also pulls in slf4j dependency and quite a
few places use it. For ex:
https://github.com/apache/hbase/blob/branch-1.3/hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java#L428
but I see your point that there is no standard usage pattern there. Anyway
this comment was not meant to be a blocker for merging. Feel free to fix it if
you have free cycles.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #809: HBASE-23261 : Processing ZK BadVersionException during node transition
bharathv commented on a change in pull request #809: HBASE-23261 : Processing ZK BadVersionException during node transition URL: https://github.com/apache/hbase/pull/809#discussion_r344336477 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZKSplitTransactionCoordination.java ## @@ -40,6 +40,9 @@ private CoordinatedStateManager coordinationManager; private final ZooKeeperWatcher watcher; + // max wait for split transaction - 100 times in a loop with 100 ms of thread sleep each time + private static final int SPLIT_WAIT_TIMEOUT = 100; Review comment: 10s seems rather small for a busy cluster, no? Concern is that it might result in unnecessary abort splits and rollbacks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #807: HBASE-23259: Ability to start minicluster with pre-determined master ports
virajjasani commented on a change in pull request #807: HBASE-23259: Ability to
start minicluster with pre-determined master ports
URL: https://github.com/apache/hbase/pull/807#discussion_r344325139
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
##
@@ -183,6 +178,47 @@ public LocalHBaseCluster(final Configuration conf, final
int noMasters,
}
}
+ /**
+ * Create new LocalHBaseCluster using pre-defined master rpc ports. Every
other port is picked
+ * randomly. This also populates the master addresses in the base and region
server configs.
+ * @param conf Base configuration to use for the cluster.
+ * @param noMasters Number of masters.
+ * @param noRegionServers Number of region servers.
+ * @param masterClass Impl of master class
+ * @param regionServerClass Impl of RS class
+ * @param masterPorts Array of ports, 2 per master (RPC/INFO) to use.
+ */
+ public LocalHBaseCluster(final Configuration conf, final int noMasters,
+ final int noRegionServers, final Class masterClass,
+ final Class regionServerClass, final
List masterPorts)
+ throws IOException {
+this.conf = conf;
+Preconditions.checkArgument(masterPorts.size() == noMasters);
+
Preconditions.checkArgument(conf.getBoolean(LocalHBaseCluster.ASSIGN_RANDOM_PORTS,
false));
+this.masterClass = (Class)
+conf.getClass(HConstants.MASTER_IMPL, masterClass);
+this.regionServerClass =
+(Class)conf.getClass(HConstants.REGION_SERVER_IMPL,
+regionServerClass);
+// Every port except the master ports are random.
+conf.set(HConstants.MASTER_INFO_PORT, "0");
+conf.set(HConstants.REGIONSERVER_PORT, "0");
+conf.set(HConstants.REGIONSERVER_INFO_PORT, "0");
+List masterHostPorts = new ArrayList<>();
+for (int i = 0, j = 0; i < noMasters; i++) {
+ Configuration c = new Configuration(conf);
+ conf.setInt(HConstants.MASTER_PORT, masterPorts.get(j++));
+ HMaster master = addMaster(c, i).getMaster();
+ masterHostPorts.add(
+ master.getServerName().getHostname() + ":" +
master.getServerName().getPort());
+}
+// Populate the master addresses in the base configuration.
+this.conf.set(HConstants.MASTER_ADDRS_KEY,
Joiner.on(",").join(masterHostPorts));
Review comment:
String.join(",", masterHostPorts) can be used here
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #807: HBASE-23259: Ability to start minicluster with pre-determined master ports
virajjasani commented on a change in pull request #807: HBASE-23259: Ability to
start minicluster with pre-determined master ports
URL: https://github.com/apache/hbase/pull/807#discussion_r344325269
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/TestClusterWithFixedMasterPorts.java
##
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase;
+
+import static org.apache.hadoop.hbase.HBaseTestingUtility.randomFreePorts;
+
+import java.net.BindException;
+import java.util.ArrayList;
+import java.util.List;
+import org.apache.hadoop.hbase.testclassification.SmallTests;
+import org.apache.hadoop.hbase.util.JVMClusterUtil;
+import org.junit.AfterClass;
+import org.junit.Assert;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.apache.hbase.thirdparty.com.google.common.base.Joiner;
+
+@Category(SmallTests.class)
+public class TestClusterWithFixedMasterPorts {
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+ HBaseClassTestRule.forClass(TestClusterWithFixedMasterPorts.class);
+
+ private static final int MAX_INIT_RETRIES = 10;
+
+ private static final HBaseTestingUtility TEST_UTIL = new
HBaseTestingUtility();
+
+ @AfterClass
+ public static void cleanUp() throws Exception {
+TEST_UTIL.shutdownMiniCluster();
+ }
+
+ /**
+ * Test runs a mini cluster with pre-determined master ports and then
verifies that the
+ * configuration is reflected in the cluster conf accordingly.
+ */
+ @Test
+ public void testValidateMasterAddrConfig() throws Exception {
+int retries = 0;
+boolean doRetry = false;
+StartMiniClusterOption option = StartMiniClusterOption.builder()
+.numRegionServers(1).numMasters(3)
+.masterPorts(randomFreePorts(3)).build();
+do {
+ try {
+TEST_UTIL.startMiniCluster(option);
+ } catch (BindException e) {
+// Theoretically random ports can still cause port conflicts because
they could be picked up
+// by another process/thread before we bind to them.
+doRetry = true;
+ }
+} while (doRetry && retries++ < MAX_INIT_RETRIES);
+List actualMasterAddrs = new ArrayList<>();
+for (JVMClusterUtil.MasterThread master:
TEST_UTIL.getMiniHBaseCluster().getMasterThreads()) {
+ ServerName sname = master.getMaster().getServerName();
+ actualMasterAddrs.add(sname.getHostname() + ":" + sname.getPort());
+}
+Assert.assertEquals(Joiner.on(",").join(actualMasterAddrs),
Review comment:
same here: String.join() can be used
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #809: HBASE-23261 : Processing ZK BadVersionException during node transition
virajjasani commented on a change in pull request #809: HBASE-23261 :
Processing ZK BadVersionException during node transition
URL: https://github.com/apache/hbase/pull/809#discussion_r344316779
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java
##
@@ -868,7 +868,15 @@ public static int transitionNode(ZooKeeperWatcher zkw,
HRegionInfo region,
try {
rt = RegionTransition.createRegionTransition(
endState, region.getRegionName(), serverName, payload);
- if(!ZKUtil.setData(zkw, node, rt.toByteArray(), stat.getVersion())) {
+ boolean isDataSet;
+ try {
+isDataSet = ZKUtil.setData(zkw, node, rt.toByteArray(),
stat.getVersion());
+ } catch (KeeperException.BadVersionException e) {
+isDataSet = false;
+LOG.info("Received BadVersionException from ZK for " + encoded
Review comment:
That is true but most of the cases of all branch-1s use
`org.apache.commons.logging.Log` of `commons-logging-1.2`
whereas branch-2 + all use `org.slf4j.Logger` and for them, it is
recommended to use parameterized logging
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #809: HBASE-23261 : Processing ZK BadVersionException during node transition
virajjasani commented on a change in pull request #809: HBASE-23261 :
Processing ZK BadVersionException during node transition
URL: https://github.com/apache/hbase/pull/809#discussion_r344316779
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java
##
@@ -868,7 +868,15 @@ public static int transitionNode(ZooKeeperWatcher zkw,
HRegionInfo region,
try {
rt = RegionTransition.createRegionTransition(
endState, region.getRegionName(), serverName, payload);
- if(!ZKUtil.setData(zkw, node, rt.toByteArray(), stat.getVersion())) {
+ boolean isDataSet;
+ try {
+isDataSet = ZKUtil.setData(zkw, node, rt.toByteArray(),
stat.getVersion());
+ } catch (KeeperException.BadVersionException e) {
+isDataSet = false;
+LOG.info("Received BadVersionException from ZK for " + encoded
Review comment:
That is true but for most of the cases of all branch-1s use
`org.apache.commons.logging.Log` of `commons-logging-1.2`
whereas branch-2 + all use `org.slf4j.Logger` and for them, it is
recommended to use parameterized logging
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #809: HBASE-23261 : Processing ZK BadVersionException during node transition
virajjasani commented on a change in pull request #809: HBASE-23261 :
Processing ZK BadVersionException during node transition
URL: https://github.com/apache/hbase/pull/809#discussion_r344316779
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java
##
@@ -868,7 +868,15 @@ public static int transitionNode(ZooKeeperWatcher zkw,
HRegionInfo region,
try {
rt = RegionTransition.createRegionTransition(
endState, region.getRegionName(), serverName, payload);
- if(!ZKUtil.setData(zkw, node, rt.toByteArray(), stat.getVersion())) {
+ boolean isDataSet;
+ try {
+isDataSet = ZKUtil.setData(zkw, node, rt.toByteArray(),
stat.getVersion());
+ } catch (KeeperException.BadVersionException e) {
+isDataSet = false;
+LOG.info("Received BadVersionException from ZK for " + encoded
Review comment:
That is true but for most of the cases of all branch-1s use
`org.apache.commons.logging.Log` of `commons-logging-1.2`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #809: HBASE-23261 : Processing ZK BadVersionException during node transition
virajjasani commented on a change in pull request #809: HBASE-23261 :
Processing ZK BadVersionException during node transition
URL: https://github.com/apache/hbase/pull/809#discussion_r344316779
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java
##
@@ -868,7 +868,15 @@ public static int transitionNode(ZooKeeperWatcher zkw,
HRegionInfo region,
try {
rt = RegionTransition.createRegionTransition(
endState, region.getRegionName(), serverName, payload);
- if(!ZKUtil.setData(zkw, node, rt.toByteArray(), stat.getVersion())) {
+ boolean isDataSet;
+ try {
+isDataSet = ZKUtil.setData(zkw, node, rt.toByteArray(),
stat.getVersion());
+ } catch (KeeperException.BadVersionException e) {
+isDataSet = false;
+LOG.info("Received BadVersionException from ZK for " + encoded
Review comment:
That is true but for most of the cases of all branch-1s use
`org.apache.commons.logging.Log`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #809: HBASE-23261 : Processing ZK BadVersionException during node transition
bharathv commented on a change in pull request #809: HBASE-23261 : Processing
ZK BadVersionException during node transition
URL: https://github.com/apache/hbase/pull/809#discussion_r344314816
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java
##
@@ -868,7 +868,15 @@ public static int transitionNode(ZooKeeperWatcher zkw,
HRegionInfo region,
try {
rt = RegionTransition.createRegionTransition(
endState, region.getRegionName(), serverName, payload);
- if(!ZKUtil.setData(zkw, node, rt.toByteArray(), stat.getVersion())) {
+ boolean isDataSet;
+ try {
+isDataSet = ZKUtil.setData(zkw, node, rt.toByteArray(),
stat.getVersion());
+ } catch (KeeperException.BadVersionException e) {
+isDataSet = false;
+LOG.info("Received BadVersionException from ZK for " + encoded
Review comment:
nit: Always better to use parameterized logging for performance [1]. Here
info is the default, so probably doesn't matter as much.
[1] https://logging.apache.org/log4j/2.x/performance.html
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #809: HBASE-23261 : Processing ZK BadVersionException during node transition
bharathv commented on a change in pull request #809: HBASE-23261 : Processing
ZK BadVersionException during node transition
URL: https://github.com/apache/hbase/pull/809#discussion_r344314915
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZKSplitTransactionCoordination.java
##
@@ -163,6 +166,10 @@ public void waitForSplitTransaction(final
RegionServerServices services, Region
}
Thread.sleep(100);
spins++;
+if (spins > SPLIT_WAIT_TIMEOUT) {
+ throw new IOException("Waiting time for Split Transaction exceeded
for region: "
Review comment:
same.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani opened a new pull request #809: HBASE-23261 : Processing ZK BadVersionException during node transition
virajjasani opened a new pull request #809: HBASE-23261 : Processing ZK BadVersionException during node transition URL: https://github.com/apache/hbase/pull/809 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] gjacoby126 commented on a change in pull request #796: HBASE-23251 - Add Column Family and Table Names to HFileContext and u…
gjacoby126 commented on a change in pull request #796: HBASE-23251 - Add Column
Family and Table Names to HFileContext and u…
URL: https://github.com/apache/hbase/pull/796#discussion_r344297732
##
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileContext.java
##
@@ -233,6 +255,14 @@ public String toString() {
sb.append(", name=");
sb.append(hfileName);
}
+if (tableName != null) {
+ sb.append(", tableName=");
+ sb.append(Bytes.toString(tableName));
Review comment:
Done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] gjacoby126 commented on a change in pull request #796: HBASE-23251 - Add Column Family and Table Names to HFileContext and u…
gjacoby126 commented on a change in pull request #796: HBASE-23251 - Add Column
Family and Table Names to HFileContext and u…
URL: https://github.com/apache/hbase/pull/796#discussion_r344297785
##
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileContext.java
##
@@ -233,6 +255,14 @@ public String toString() {
sb.append(", name=");
sb.append(hfileName);
}
+if (tableName != null) {
+ sb.append(", tableName=");
+ sb.append(Bytes.toString(tableName));
+}
+if (columnFamily != null) {
+ sb.append(", columnFamily=");
+ sb.append(Bytes.toString(columnFamily));
Review comment:
Done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] gjacoby126 commented on a change in pull request #796: HBASE-23251 - Add Column Family and Table Names to HFileContext and u…
gjacoby126 commented on a change in pull request #796: HBASE-23251 - Add Column Family and Table Names to HFileContext and u… URL: https://github.com/apache/hbase/pull/796#discussion_r344297235 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileContext.java ## @@ -63,6 +63,8 @@ private Encryption.Context cryptoContext = Encryption.Context.NONE; private long fileCreateTime; private String hfileName; + private byte[] columnFamily; + private byte[] tableName; Review comment: Correct, byte[] was what was already there. I could have constructed a TableName and passed that through, but it seemed like an unnecessary allocation. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] HorizonNet merged pull request #794: HBASE-18439 Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
HorizonNet merged pull request #794: HBASE-18439 Subclasses of o.a.h.h.chaos.actions.Action all use the same logger URL: https://github.com/apache/hbase/pull/794 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] gjacoby126 commented on a change in pull request #796: HBASE-23251 - Add Column Family and Table Names to HFileContext and u…
gjacoby126 commented on a change in pull request #796: HBASE-23251 - Add Column
Family and Table Names to HFileContext and u…
URL: https://github.com/apache/hbase/pull/796#discussion_r344295314
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
##
@@ -1267,6 +1267,8 @@ HFileBlock getBlockForCaching(CacheConfig cacheConf) {
.withCompressTags(fileContext.isCompressTags())
.withIncludesMvcc(fileContext.isIncludesMvcc())
.withIncludesTags(fileContext.isIncludesTags())
+
.withColumnFamily(fileContext.getColumnFamily())
+.withTableName(fileContext.getTableName())
Review comment:
I did so in all the paths I could find where the information was readily
available (primarily the main HStore flush path, and the MapReduce output
format). It wasn't available in the read path, at least without larger changes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #808: HBASE-20395 Displaying thrift server type on the thrift page
bharathv commented on a change in pull request #808: HBASE-20395 Displaying
thrift server type on the thrift page
URL: https://github.com/apache/hbase/pull/808#discussion_r344281749
##
File path:
hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/HBaseThriftTestingUtility.java
##
@@ -0,0 +1,80 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.thrift;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseTestingUtility;
+import org.apache.hadoop.util.ToolRunner;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class HBaseThriftTestingUtility {
Review comment:
I think there is a lot of common code between HBaseThriftTestingUtility.java
and HBaseThrift2TestingUtility.java . You can probably merge them and take the
server type as input and start the corresponding version.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #808: HBASE-20395 Displaying thrift server type on the thrift page
bharathv commented on a change in pull request #808: HBASE-20395 Displaying thrift server type on the thrift page URL: https://github.com/apache/hbase/pull/808#discussion_r344268598 ## File path: hbase-examples/src/main/python/thrift1/DemoClient.py ## @@ -66,6 +66,11 @@ def demo_client(host, port, is_framed_transport): # Connect! transport.open() + # Check Thrift Server Type + serverType = client.getThriftServerType() + if serverType != 1: Review comment: Use the version from the thrift file instead of '1'? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #808: HBASE-20395 Displaying thrift server type on the thrift page
bharathv commented on a change in pull request #808: HBASE-20395 Displaying thrift server type on the thrift page URL: https://github.com/apache/hbase/pull/808#discussion_r344269837 ## File path: hbase-examples/src/main/python/thrift1/gen-py/hbase/Hbase-remote ## @@ -1,6 +1,6 @@ #!/usr/bin/env python # -# Autogenerated by Thrift Compiler (0.9.0) +# Autogenerated by Thrift Compiler (0.12.0) Review comment: Curious why check-in auto-generated code. It is going to be overwritten anyway. Just a general question, not related to your patch, I see others doing it too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #808: HBASE-20395 Displaying thrift server type on the thrift page
bharathv commented on a change in pull request #808: HBASE-20395 Displaying
thrift server type on the thrift page
URL: https://github.com/apache/hbase/pull/808#discussion_r344269190
##
File path: hbase-examples/src/main/python/thrift1/DemoClient.py
##
@@ -66,6 +66,11 @@ def demo_client(host, port, is_framed_transport):
# Connect!
transport.open()
+ # Check Thrift Server Type
+ serverType = client.getThriftServerType()
+ if serverType != 1:
+raise Exception("Mismatch between client and server, server type is %s"
%serverType)
Review comment:
nit: space after %
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #808: HBASE-20395 Displaying thrift server type on the thrift page
bharathv commented on a change in pull request #808: HBASE-20395 Displaying
thrift server type on the thrift page
URL: https://github.com/apache/hbase/pull/808#discussion_r344272299
##
File path:
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java
##
@@ -61,11 +61,11 @@ public void setSource(MetricsThriftServerSource source) {
public static final String SLOW_RESPONSE_NANO_SEC =
"hbase.thrift.slow.response.nano.second";
public static final long DEFAULT_SLOW_RESPONSE_NANO_SEC = 10 * 1000 * 1000;
-
+ public final String thriftServerType;
public ThriftMetrics(Configuration conf, ThriftServerType t) {
Review comment:
Get rid of the num ThriftServerType here and use the one from HBase.thrift?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #808: HBASE-20395 Displaying thrift server type on the thrift page
bharathv commented on a change in pull request #808: HBASE-20395 Displaying
thrift server type on the thrift page
URL: https://github.com/apache/hbase/pull/808#discussion_r344282939
##
File path:
hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
##
@@ -871,4 +878,32 @@ private void closeScanner(
handler.scannerGet(scannerId);
handler.scannerClose(scannerId);
}
+
+ @Test
+ public void testGetThriftServerType() throws Exception {
+ThriftHBaseServiceHandler handler =
+new ThriftHBaseServiceHandler(UTIL.getConfiguration(),
+UserProvider.instantiate(UTIL.getConfiguration()));
+assertEquals(TThriftServerType.ONE, handler.getThriftServerType());
+ }
+
+ @Test
+ public void testGetThriftServerOneType() throws Exception {
+// start a thrift2 server
+HBaseThrift2TestingUtility THRIFT2_TEST_UTIL =
+new HBaseThrift2TestingUtility();
+
+LOG.info("Starting HBase Thrift Server Two");
+THRIFT2_TEST_UTIL.startThriftServer(UTIL.getConfiguration());
+try (TTransport transport = new
TSocket(InetAddress.getLocalHost().getHostName(),
+THRIFT2_TEST_UTIL.getServerPort())){
+ TProtocol protocol = new TBinaryProtocol(transport);
+ // This is our thrift client.
+ Hbase.Client client = new Hbase.Client(protocol);
+ // open the transport
+ transport.open();
+ assertEquals(TThriftServerType.TWO.name(),
client.getThriftServerType().name());
+}
+THRIFT2_TEST_UTIL.stopThriftServer();
Review comment:
wrap this in finally block? Otherwise its a thread leak if an exception is
thrown in the try block above.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #808: HBASE-20395 Displaying thrift server type on the thrift page
bharathv commented on a change in pull request #808: HBASE-20395 Displaying
thrift server type on the thrift page
URL: https://github.com/apache/hbase/pull/808#discussion_r344277816
##
File path:
hbase-thrift/src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift
##
@@ -192,6 +192,14 @@ exception AlreadyExists {
1:string message
}
+/**
+ * Specify type of thrift server: thrift and thrift2
+ */
+enum TThriftServerType {
Review comment:
rather than defining the same enum twice in both the thrift files, is it
better to have a const defined?
const i16 THRIFT_SERVER_TYPE = 1; // in thrift1
const i16 THRIFT_SERVER_TYPE =2 // in thrift2
Each thrift server impl can use it's corresponding type directly. Thoughts?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #808: HBASE-20395 Displaying thrift server type on the thrift page
bharathv commented on a change in pull request #808: HBASE-20395 Displaying
thrift server type on the thrift page
URL: https://github.com/apache/hbase/pull/808#discussion_r344271230
##
File path:
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServer.java
##
@@ -259,6 +259,7 @@ protected void startInfoServer() throws IOException {
.get(THRIFT_INFO_SERVER_BINDING_ADDRESS,
THRIFT_INFO_SERVER_BINDING_ADDRESS_DEFAULT);
infoServer = new InfoServer("thrift", a, port, false, conf);
infoServer.setAttribute("hbase.conf", conf);
+ infoServer.setAttribute("hbase.thrift.type",
metrics.getThriftServerType());
Review comment:
nit: hbase.thrift.server.type?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #808: HBASE-20395 Displaying thrift server type on the thrift page
bharathv commented on a change in pull request #808: HBASE-20395 Displaying
thrift server type on the thrift page
URL: https://github.com/apache/hbase/pull/808#discussion_r344282323
##
File path:
hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/HBaseThriftTestingUtility.java
##
@@ -0,0 +1,80 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.thrift;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseTestingUtility;
+import org.apache.hadoop.util.ToolRunner;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class HBaseThriftTestingUtility {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(HBaseThriftTestingUtility.class);
+ private Thread thriftServerOneThread;
+ private volatile Exception thriftServerOneException;
+ private ThriftServer thriftServer;
+ private int testServerPort;
+
+ public int getServerPort() {
+return testServerPort;
+ }
+
+ public void startThriftServer(Configuration conf) throws Exception {
+List args = new ArrayList<>();
+testServerPort = HBaseTestingUtility.randomFreePort();
+args.add("-" + Constants.PORT_OPTION);
+args.add(String.valueOf(testServerPort));
+thriftServer = new ThriftServer(conf);
+LOG.info("Starting Thrift Server One on port: " + testServerPort);
+
+thriftServerOneException = null;
+thriftServerOneThread = new Thread(() -> {
+ try {
+thriftServer.run(args.toArray(new String[args.size()]));
+ } catch (Exception e) {
+thriftServerOneException = e;
+ }
+});
+thriftServerOneThread.setName(ThriftServer.class.getSimpleName() + "-one");
+thriftServerOneThread.start();
+
+if (thriftServerOneException != null) {
+ LOG.error("HBase Thrift server threw an exception ",
thriftServerOneException);
+ throw new Exception(thriftServerOneException);
+}
+
+// wait up to 10s for the server to start
+for (int i = 0; i < 100
Review comment:
What if the server is not up in 10s? Looks like the loop breaks. Should we
handle it?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Updated] (HBASE-23261) Region stuck in transition while splitting
[
https://issues.apache.org/jira/browse/HBASE-23261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viraj Jasani updated HBASE-23261:
-
Attachment: HBASE-23261.branch-1.3.000.patch
> Region stuck in transition while splitting
> --
>
> Key: HBASE-23261
> URL: https://issues.apache.org/jira/browse/HBASE-23261
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.5
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 1.6.0, 1.4.12, 1.3.7, 1.5.1
>
> Attachments: HBASE-23261.branch-1.3.000.patch,
> HBASE-23261.branch-1.3.000.patch
>
>
> While splitting, some region gets stuck in transition. After RegionServer
> initiates split, ZK has the region marked in RIT ZNode. However, RegionServer
> encounters KeeperException.BadVersion for
> /hbase/region-in-transition/\{region-name} while transitioning node to
> RS_ZK_REQUEST_REGION_SPLIT and hence, it runs rollback/cleanup of failed
> split of the region. Even after successful rollback, region stays in
> transition sometimes.
>
>
> {code:java}
> 2019-11-05 04:07:17,711 INFO [splits-1572926837064] regionserver.SplitRequest
> - Successful rollback of failed split of
> TABLE1,1572894157455.257ff8985e7a169af0514208b3b0b430.
> {code}
> {code:java}
> 2019-11-05 04:07:17,688 INFO [splits-1572926837064] regionserver.SplitRequest
> - Running rollback/cleanup of failed split of
> TABLE1,1572894157455.257ff8985e7a169af0514208b3b0b430.; Failed getting
> SPLITTING znode on TABLE1,1572894157455.257ff8985e7a169af0514208b3b0b430.
> java.io.IOException: Failed getting SPLITTING znode on
> TABLE1,1572894157455.257ff8985e7a169af0514208b3b0b430. at
> org.apache.hadoop.hbase.coordination.ZKSplitTransactionCoordination.waitForSplitTransaction(ZKSplitTransactionCoordination.java:203)
> at
> org.apache.hadoop.hbase.regionserver.SplitTransactionImpl.stepsBeforePONR(SplitTransactionImpl.java:383)
> at
> org.apache.hadoop.hbase.regionserver.SplitTransactionImpl.createDaughters(SplitTransactionImpl.java:278)
> at
> org.apache.hadoop.hbase.regionserver.SplitTransactionImpl.execute(SplitTransactionImpl.java:561)
> at
> org.apache.hadoop.hbase.regionserver.SplitRequest.doSplitting(SplitRequest.java:82)
> at
> org.apache.hadoop.hbase.regionserver.SplitRequest.run(SplitRequest.java:153)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748) Caused by: java.io.IOException:
> Failed transition of splitting node
> TABLE1,1572894157455.257ff8985e7a169af0514208b3b0b430. at
> org.apache.hadoop.hbase.coordination.ZKSplitTransactionCoordination.transitionSplittingNode(ZKSplitTransactionCoordination.java:132)
> at
> org.apache.hadoop.hbase.coordination.ZKSplitTransactionCoordination.waitForSplitTransaction(ZKSplitTransactionCoordination.java:161)
> ... 8 more Caused by:
> org.apache.zookeeper.KeeperException$BadVersionException: KeeperErrorCode =
> BadVersion for /hbase/region-in-transition/257ff8985e7a169af0514208b3b0b430
> at org.apache.zookeeper.KeeperException.create(KeeperException.java:115) at
> org.apache.zookeeper.KeeperException.create(KeeperException.java:51) at
> org.apache.zookeeper.ZooKeeper.setData(ZooKeeper.java:1336) at
> org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.setData(RecoverableZooKeeper.java:442)
> at org.apache.hadoop.hbase.zookeeper.ZKUtil.setData(ZKUtil.java:818) at
> org.apache.hadoop.hbase.zookeeper.ZKAssign.transitionNode(ZKAssign.java:871)
> at
> org.apache.hadoop.hbase.coordination.ZKSplitTransactionCoordination.transitionSplittingNode(ZKSplitTransactionCoordination.java:128)
> ... 9 more
> {code}
> {code:java}
> 2019-11-05 04:07:17,688 INFO [.Worker-pool3-t26826] master.RegionStates -
> Transition {257ff8985e7a169af0514208b3b0b430 state=OPEN, ts=1572923178845,
> server=rsserver.net,60020,1572890688075} to {257ff8985e7a169af0514208b3b0b430
> state=SPLITTING, ts=1572926837688, server=rsserver.net,60020,1572890688075}
> {code}
> {code:java}
> 2019-11-05 04:07:17,680 INFO [myid:5] [ead(sid:5 cport:-1):]
> server.PrepRequestProcessor - Got user-level KeeperException when processing
> sessionid:0x36dd5dc94536a3e type:setData cxid:0x8f8a zxid:0x304fd98ef
> txntype:-1 reqpath:n/a Error
> Path:/hbase/region-in-transition/257ff8985e7a169af0514208b3b0b430
> Error:KeeperErrorCode = BadVersion for
> /hbase/region-in-transition/257ff8985e7a169af0514208b3b0b430
> {code}
> {code:java}
> 2019-11-05 04:07:17,668 DEBUG [.Worker-pool3-t26826] master.AssignmentManager
> - Handling RS_ZK_REQUEST_REGION_SPLIT,
> server=rsserver.net,60020,1572890688075,
> region=257ff8985e7a169af0514208b3b0b430,
> current_state={257ff8985e7a169
[GitHub] [hbase] Apache-HBase commented on issue #794: HBASE-18439 Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
Apache-HBase commented on issue #794: HBASE-18439 Subclasses of o.a.h.h.chaos.actions.Action all use the same logger URL: https://github.com/apache/hbase/pull/794#issuecomment-551905393 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 35s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 35 new or modified test files. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 34s | master passed | | +1 :green_heart: | compile | 0m 35s | master passed | | +1 :green_heart: | checkstyle | 0m 20s | master passed | | +1 :green_heart: | shadedjars | 5m 9s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 14s | master passed | | +0 :ok: | spotbugs | 5m 25s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 0m 0s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 33s | the patch passed | | +1 :green_heart: | compile | 0m 30s | the patch passed | | +1 :green_heart: | javac | 0m 30s | the patch passed | | +1 :green_heart: | checkstyle | 0m 16s | hbase-it: The patch generated 0 new + 4 unchanged - 29 fixed = 4 total (was 33) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 5m 11s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 18m 45s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 0m 14s | the patch passed | | +1 :green_heart: | findbugs | 0m 0s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 3s | hbase-it in the patch passed. | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 53m 32s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-794/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/794 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 241d42bbc2b1 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-794/out/precommit/personality/provided.sh | | git revision | master / 2c1d500828 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-794/3/testReport/ | | Max. process+thread count | 396 (vs. ulimit of 1) | | modules | C: hbase-it U: hbase-it | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-794/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (HBASE-15611) add examples to shell docs
[
https://issues.apache.org/jira/browse/HBASE-15611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970384#comment-16970384
]
Sean Busbey edited comment on HBASE-15611 at 11/8/19 4:47 PM:
--
Eventually I'll put this into the MOB section for troubleshooting.
"scan for mob references rather than for the values themselves"
{code}
hbase(main):074:0> scan 'example_table', {LIMIT => 1, CACHE_BLOCKS => false,
ATTRIBUTES => { 'hbase.mob.scan.raw' => '1', 'hbase.mob.scan.ref.only' => '1' }
}
{code}
"count the number of rows with mob references and the number of mob reference
cells"
{code}
hbase(main):031:0> row_count = 0
=> 0
hbase(main):032:0> cell_count = 0
=> 0
hbase(main):033:0> table = get_table('clone_table')
0 row(s) in 0. seconds
=> Hbase::Table - clone_table
hbase(main):034:0> rows = table._get_scanner({CACHE_BLOCKS => false, ATTRIBUTES
=> { 'hbase.mob.scan.raw' => '1', 'hbase.mob.scan.ref.only' => '1' } }).iterator
=> #<#:0x7da887f>
hbase(main):035:0> rows.each do | row | row_count+=1; row.list.each do | cell |
cell_count+=1; end end
hbase(main):036:0> p row_count
1
hbase(main):037:0> p cell_count
52360
{code}
Very important warning: if you use this without at least one column with MOB
enabled, you will get a full table scan with no filtering.
was (Author: busbey):
Eventually I'll put this into the MOB section for troubleshooting.
"scan for mob references rather than for the values themselves"
{code}
hbase(main):074:0> scan 'example_table', {LIMIT => 1, CACHE_BLOCKS => false,
ATTRIBUTES => { 'hbase.mob.scan.raw' => '1', 'hbase.mob.scan.ref.only' => '1' }
}
{code}
"count the number of rows with mob references and the number of mob reference
cells"
{code}
hbase(main):031:0> row_count = 0
=> 0
hbase(main):032:0> cell_count = 0
=> 0
hbase(main):033:0> table = get_table('clone_table')
0 row(s) in 0. seconds
=> Hbase::Table - clone_table
hbase(main):034:0> rows = table._get_scanner({CACHE_BLOCKS => false, ATTRIBUTES
=> { 'hbase.mob.scan.raw' => '1', 'hbase.mob.scan.ref.only' => '1' } }).iterator
=> #<#:0x7da887f>
hbase(main):035:0> rows.each do | row | row_count+=1; row.list.each do | cell |
cell_count+=1; end end
hbase(main):036:0> p row_count
1
hbase(main):037:0> p cell_count
52360
{code}
> add examples to shell docs
> ---
>
> Key: HBASE-15611
> URL: https://issues.apache.org/jira/browse/HBASE-15611
> Project: HBase
> Issue Type: Improvement
> Components: documentation, shell
>Reporter: Sean Busbey
>Priority: Major
> Labels: beginner
>
> It would be nice if our shell documentation included some additional examples
> of operational tasks one can perform.
> things to include to come in comments. when we have a patch to submit we can
> update the jira summary to better reflect what scope we end up with.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-15611) add examples to shell docs
[
https://issues.apache.org/jira/browse/HBASE-15611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970384#comment-16970384
]
Sean Busbey commented on HBASE-15611:
-
Eventually I'll put this into the MOB section for troubleshooting.
"scan for mob references rather than for the values themselves"
{code}
hbase(main):074:0> scan 'example_table', {LIMIT => 1, CACHE_BLOCKS => false,
ATTRIBUTES => { 'hbase.mob.scan.raw' => '1', 'hbase.mob.scan.ref.only' => '1' }
}
{code}
"count the number of rows with mob references and the number of mob reference
cells"
{code}
hbase(main):031:0> row_count = 0
=> 0
hbase(main):032:0> cell_count = 0
=> 0
hbase(main):033:0> table = get_table('clone_table')
0 row(s) in 0. seconds
=> Hbase::Table - clone_table
hbase(main):034:0> rows = table._get_scanner({CACHE_BLOCKS => false, ATTRIBUTES
=> { 'hbase.mob.scan.raw' => '1', 'hbase.mob.scan.ref.only' => '1' } }).iterator
=> #<#:0x7da887f>
hbase(main):035:0> rows.each do | row | row_count+=1; row.list.each do | cell |
cell_count+=1; end end
hbase(main):036:0> p row_count
1
hbase(main):037:0> p cell_count
52360
{code}
> add examples to shell docs
> ---
>
> Key: HBASE-15611
> URL: https://issues.apache.org/jira/browse/HBASE-15611
> Project: HBase
> Issue Type: Improvement
> Components: documentation, shell
>Reporter: Sean Busbey
>Priority: Major
> Labels: beginner
>
> It would be nice if our shell documentation included some additional examples
> of operational tasks one can perform.
> things to include to come in comments. when we have a patch to submit we can
> update the jira summary to better reflect what scope we end up with.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] busbey commented on issue #251: HBASE-22114 Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1
busbey commented on issue #251: HBASE-22114 Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1 URL: https://github.com/apache/hbase/pull/251#issuecomment-551894717 I started a rebuild for QA bot now that HBASE-23228 has merged to all branches. It passed when I ran it locally, though that skips unit tests (and all of the tinylfu module) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-23228) Allow for jdk8 specific modules on branch-1 in precommit/nightly testing
[ https://issues.apache.org/jira/browse/HBASE-23228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey resolved HBASE-23228. - Fix Version/s: 2.2.3 2.1.8 1.4.12 1.6.0 2.3.0 3.0.0 Resolution: Fixed > Allow for jdk8 specific modules on branch-1 in precommit/nightly testing > > > Key: HBASE-23228 > URL: https://issues.apache.org/jira/browse/HBASE-23228 > Project: HBase > Issue Type: Improvement > Components: build, test >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Critical > Fix For: 3.0.0, 2.3.0, 1.6.0, 1.4.12, 2.1.8, 2.2.3 > > > At least 1 feature backport is waiting on proper handling of jdk8 activated > modules for our yetus personality (HBASE-22114 tinylfu). > Implement the general handling here so that we don't have to worry about > pushes to the PR branch overwriting it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] busbey commented on issue #804: HBASE-23228 Allow for jdk8 specific modules on branch-1 in precommit/nightly testing
busbey commented on issue #804: HBASE-23228 Allow for jdk8 specific modules on branch-1 in precommit/nightly testing URL: https://github.com/apache/hbase/pull/804#issuecomment-551889036 thanks for the review! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] busbey merged pull request #804: HBASE-23228 Allow for jdk8 specific modules on branch-1 in precommit/nightly testing
busbey merged pull request #804: HBASE-23228 Allow for jdk8 specific modules on branch-1 in precommit/nightly testing URL: https://github.com/apache/hbase/pull/804 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] cbaenziger commented on a change in pull request #785: HBASE-23239 Reporting on status of backing MOB files from client-facing cells
cbaenziger commented on a change in pull request #785: HBASE-23239 Reporting on status of backing MOB files from client-facing cells URL: https://github.com/apache/hbase/pull/785#discussion_r343376392 ## File path: hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mob/mapreduce/MobRefReporter.java ## @@ -0,0 +1,485 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.mob.mapreduce; + +import java.io.IOException; +import java.util.Arrays; +import java.util.Set; +import java.util.HashSet; +import java.util.UUID; +import java.util.Base64; + +import com.google.protobuf.ServiceException; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.conf.Configured; +import org.apache.hadoop.fs.FileStatus; +import org.apache.hadoop.fs.FileSystem; +import org.apache.hadoop.fs.Path; +import org.apache.hadoop.hbase.Cell; +import org.apache.hadoop.hbase.HBaseConfiguration; +import org.apache.hadoop.hbase.HConstants; +import org.apache.hadoop.hbase.TableName; +import org.apache.hadoop.hbase.client.Admin; +import org.apache.hadoop.hbase.client.ColumnFamilyDescriptor; +import org.apache.hadoop.hbase.client.Connection; +import org.apache.hadoop.hbase.client.ConnectionFactory; +import org.apache.hadoop.hbase.client.Result; +import org.apache.hadoop.hbase.client.Scan; +import org.apache.hadoop.hbase.client.TableDescriptor; +import org.apache.hadoop.hbase.io.HFileLink; +import org.apache.hadoop.hbase.io.ImmutableBytesWritable; +import org.apache.hadoop.hbase.mapreduce.TableInputFormat; +import org.apache.hadoop.hbase.mapreduce.TableMapper; +import org.apache.hadoop.hbase.mapreduce.TableMapReduceUtil; +import org.apache.hadoop.hbase.mob.MobConstants; +import org.apache.hadoop.hbase.mob.MobUtils; +import org.apache.hadoop.hbase.util.Bytes; +import org.apache.hadoop.hbase.util.EnvironmentEdgeManager; +import org.apache.hadoop.hbase.util.FSUtils; +import org.apache.hadoop.hbase.util.HFileArchiveUtil; +import org.apache.hadoop.hbase.util.Pair; +import org.apache.hadoop.io.Text; +import org.apache.hadoop.mapreduce.Job; +import org.apache.hadoop.mapreduce.Reducer; +import org.apache.hadoop.mapreduce.lib.output.TextOutputFormat; +import org.apache.hadoop.security.UserGroupInformation; +import org.apache.hadoop.util.Tool; +import org.apache.hadoop.util.ToolRunner; +import org.apache.yetus.audience.InterfaceAudience; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +/** + * Scans a given table + CF for all mob reference cells to get the list of backing mob files. + * For each referenced file we attempt to verify that said file is on the FileSystem in a place + * that the MOB system will look when attempting to resolve the actual value. + * + * The job includes counters that can help provide a rough sketch of the mob data. + * + * + * Map-Reduce Framework + * Map input records=1 + * ... + * Reduce output records=99 + * ... + * CELLS_PER_ROW_DIGITS + * 1=1 + * MOB + * NUM_CELLS=52364 + * PROBLEM + * IMPACTED_ROWS=338 + * MOB_FILES=2 + * PROBLEM_ROWS_PER_FILE_DIGITS + * 3=2 + * SIZE_PER_CELL_DIGITS + * 5=627 + * 6=51392 + * 7=345 + * SIZE_PER_ROW_DIGITS + * 6=6838 + * 7=3162 + * + * + * * Map-Reduce Framework:Map input records - the number of rows with mob references + * * Map-Reduce Framework:Reduce output records - the number of unique hfiles referenced + * * MOB:NUM_CELLS - the total number of mob reference cells + * * PROBLEM:IMPACTED_ROWS - the number of rows that reference hfiles with an issue + * * PROBLEM:MOB_FILES - the number of unique hfiles that have an issue + * * CELLS_PER_ROW_DIGITS: - this counter group gives a histogram of the order of magnitude of the + * number of cells in a given row by grouping by the number of digits used in each count. + * This allows us to see more about the distribution of cells than what we can determine + * with just the cell count and the row count. In this particular example we can see that + * all of our rows have somewhere between 1 - 9 cells. + * * PROBLEM_ROWS_PER_FILE_DIGIT
[jira] [Comment Edited] (HBASE-22978) Online slow response log
[
https://issues.apache.org/jira/browse/HBASE-22978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16956178#comment-16956178
]
Viraj Jasani edited comment on HBASE-22978 at 11/8/19 3:46 PM:
---
With the attached patch, tried to cover ringbuffer, shell scripts to get and
clear buffers including filters.
If it is fine, will create subtask for optionally dumping logs to HDFS.
Some screenshots of sample outputs:
[^Screen Shot 2019-10-19 at 2.31.59 AM.png]
[^Screen Shot 2019-10-19 at 2.32.54 AM.png]
[^Screen Shot 2019-10-19 at 2.34.11 AM.png]
[^Screen Shot 2019-10-19 at 2.36.14 AM.png]
was (Author: vjasani):
With the attached patch, tried to cover ringbuffer, shell scripts to get and
clear buffers including filters(except USER filter).
If it is fine, will create subtask for optionally dumping logs to HDFS. Also,
just realized, I need to apply USER filter with get_slow_responses(). Will
update the patch with USER filter.
Some screenshots of sample outputs:
[^Screen Shot 2019-10-19 at 2.31.59 AM.png]
[^Screen Shot 2019-10-19 at 2.32.54 AM.png]
[^Screen Shot 2019-10-19 at 2.34.11 AM.png]
[^Screen Shot 2019-10-19 at 2.36.14 AM.png]
> Online slow response log
>
>
> Key: HBASE-22978
> URL: https://issues.apache.org/jira/browse/HBASE-22978
> Project: HBase
> Issue Type: New Feature
> Components: Admin, Operability, regionserver, shell
>Affects Versions: 3.0.0, 2.3.0, 1.5.1
>Reporter: Andrew Kyle Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.6.0
>
> Attachments: Screen Shot 2019-10-19 at 2.31.59 AM.png, Screen Shot
> 2019-10-19 at 2.32.54 AM.png, Screen Shot 2019-10-19 at 2.34.11 AM.png,
> Screen Shot 2019-10-19 at 2.36.14 AM.png
>
>
> Today when an individual RPC exceeds a configurable time bound we log a
> complaint by way of the logging subsystem. These log lines look like:
> {noformat}
> 2019-08-30 22:10:36,195 WARN [,queue=15,port=60020] ipc.RpcServer -
> (responseTooSlow):
> {"call":"Scan(org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ScanRequest)",
> "starttimems":1567203007549,
> "responsesize":6819737,
> "method":"Scan",
> "param":"region { type: REGION_NAME value:
> \"tsdb,\\000\\000\\215\\f)o\\024\\302\\220\\000\\000\\000\\000\\000\\001\\000\\000\\000\\000\\000\\006\\000\\000\\000\\000\\000\\005\\000\\000",
> "processingtimems":28646,
> "client":"10.253.196.215:41116",
> "queuetimems":22453,
> "class":"HRegionServer"}
> {noformat}
> Unfortunately we often truncate the request parameters, like in the above
> example. We do this because the human readable representation is verbose, the
> rate of too slow warnings may be high, and the combination of these things
> can overwhelm the log capture system. The truncation is unfortunate because
> it eliminates much of the utility of the warnings. For example, the region
> name, the start and end keys, and the filter hierarchy are all important
> clues for debugging performance problems caused by moderate to low
> selectivity queries or queries made at a high rate.
> We can maintain an in-memory ring buffer of requests that were judged to be
> too slow in addition to the responseTooSlow logging. The in-memory
> representation can be complete and compressed. A new admin API and shell
> command can provide access to the ring buffer for online performance
> debugging. A modest sizing of the ring buffer will prevent excessive memory
> utilization for a minor performance debugging feature by limiting the total
> number of retained records. There is some chance a high rate of requests will
> cause information on other interesting requests to be overwritten before it
> can be read. This is the nature of a ring buffer and an acceptable trade off.
> The write request types do not require us to retain all information submitted
> in the request. We don't need to retain all key-values in the mutation, which
> may be too large to comfortably retain. We only need a unique set of row
> keys, or even a min/max range, and total counts.
> The consumers of this information will be debugging tools. We can afford to
> apply fast compression to ring buffer entries (if codec support is
> available), something like snappy or zstandard, and decompress on the fly
> when servicing the retrieval API request. This will minimize the impact of
> retaining more information about slow requests than we do today.
> This proposal is for retention of request information only, the same
> information provided by responseTooSlow warnings. Total size of response
> serialization, possibly also total cell or row counts, should be sufficient
> to characterize the response.
> Optionally persist new entries added to the ring buffer into one or more
> files in H
[GitHub] [hbase] Apache-HBase commented on issue #757: HBASE-23196 The IndexChunkPool’s percentage is hard code to 0.1
Apache-HBase commented on issue #757: HBASE-23196 The IndexChunkPool’s percentage is hard code to 0.1 URL: https://github.com/apache/hbase/pull/757#issuecomment-551876146 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 29s | master passed | | +1 :green_heart: | compile | 0m 55s | master passed | | +1 :green_heart: | checkstyle | 1m 21s | master passed | | +1 :green_heart: | shadedjars | 4m 39s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | master passed | | +0 :ok: | spotbugs | 4m 6s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 4m 3s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 4s | the patch passed | | +1 :green_heart: | compile | 0m 55s | the patch passed | | +1 :green_heart: | javac | 0m 55s | the patch passed | | +1 :green_heart: | checkstyle | 1m 18s | hbase-server: The patch generated 0 new + 47 unchanged - 2 fixed = 47 total (was 49) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 4m 38s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 15m 44s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 0m 34s | the patch passed | | +1 :green_heart: | findbugs | 4m 14s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 331m 32s | hbase-server in the patch failed. | | +1 :green_heart: | asflicense | 0m 37s | The patch does not generate ASF License warnings. | | | | 389m 17s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestFromClientSide3 | | | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas | | | hadoop.hbase.master.TestAssignmentManagerMetrics | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.client.TestFromClientSideWithCoprocessor | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-757/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/757 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 4db8ae2a74e0 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-757/out/precommit/personality/provided.sh | | git revision | master / 34661050c8 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-757/3/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-757/3/testReport/ | | Max. process+thread count | 4928 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-757/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23272) Fix link in Developer guide to "code review checklist"
[
https://issues.apache.org/jira/browse/HBASE-23272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970322#comment-16970322
]
Hudson commented on HBASE-23272:
Results for branch master
[build #1530 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1530/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1530//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1530//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1530//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Fix link in Developer guide to "code review checklist"
> --
>
> Key: HBASE-23272
> URL: https://issues.apache.org/jira/browse/HBASE-23272
> Project: HBase
> Issue Type: Task
> Components: documentation
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Minor
> Fix For: 3.0.0
>
>
> The destination of the link "code review checklist" in
> https://hbase.apache.org/book.html#_reject has been moved.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23257) Track ClusterID in stand by masters
[
https://issues.apache.org/jira/browse/HBASE-23257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970326#comment-16970326
]
Hudson commented on HBASE-23257:
Results for branch master
[build #1530 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1530/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1530//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1530//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1530//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Track ClusterID in stand by masters
> ---
>
> Key: HBASE-23257
> URL: https://issues.apache.org/jira/browse/HBASE-23257
> Project: HBase
> Issue Type: Sub-task
> Components: master
>Affects Versions: 3.0.0
>Reporter: Bharath Vissapragada
>Assignee: Bharath Vissapragada
>Priority: Major
> Fix For: 3.0.0
>
>
> Currently, only active master tracks the cluster ID. As a part of removing
> client dependency on ZK (HBASE-18095), it was noted that having stand by
> masters serve ClusterID will help load balance the client requests instead of
> hot-spotting the active master.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22480) Get block from BlockCache once and return this block to BlockCache twice make ref count error.
[
https://issues.apache.org/jira/browse/HBASE-22480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970323#comment-16970323
]
Hudson commented on HBASE-22480:
Results for branch master
[build #1530 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1530/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1530//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1530//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1530//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Get block from BlockCache once and return this block to BlockCache twice make
> ref count error.
> --
>
> Key: HBASE-22480
> URL: https://issues.apache.org/jira/browse/HBASE-22480
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 2.2.2
>Reporter: Lijin Bin
>Assignee: Lijin Bin
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.3
>
> Attachments: HBASE-22480-branch-2.2-v1.patch,
> HBASE-22480-branch-2.2-v1.patch, HBASE-22480-branch-2.2-v1.patch,
> HBASE-22480-branch-2.2-v2.patch, HBASE-22480-master-v1.patch,
> HBASE-22480-master-v2.patch, HBASE-22480-master-v3.patch,
> HBASE-22480-master-v4.patch, HBASE-22480-master-v5.patch,
> HBASE-22480-master-v6.patch, HBASE-22480-master-v6.patch,
> HBASE-22480-master-v6.patch, HBASE-22480-master-v7.patch,
> HBASE-22480-master-v7.patch
>
>
> After debugging HBASE-22433, i find the problem it is that we get a block
> from BucketCache once and return this block to BucketCache twice and make the
> ref count error, sometimes the refCount can be negative.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23262) Cannot load Master UI
[
https://issues.apache.org/jira/browse/HBASE-23262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970324#comment-16970324
]
Hudson commented on HBASE-23262:
Results for branch master
[build #1530 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1530/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1530//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1530//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1530//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Cannot load Master UI
> -
>
> Key: HBASE-23262
> URL: https://issues.apache.org/jira/browse/HBASE-23262
> Project: HBase
> Issue Type: Bug
> Components: master, UI
>Affects Versions: 3.0.0
>Reporter: Karthik Palanisamy
>Assignee: Karthik Palanisamy
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.8, 2.2.3
>
>
> If no online regionservers then master UI can't be opened. This issue occurs
> when using RSGroupAdminEndpoint coprocessor(RSGrouping). The master home
> page tries to load rsgroup info from "hbase:rsgroup" table but currently no
> regionservers up and running.
>
> [http://172.26.70.200:16010|http://172.26.70.200:16010/]
> {code:java}
> HTTP ERROR 500
> Problem accessing /master-status.
> Reason:
> Server Error
> Caused by:
> java.io.UncheckedIOException:
> org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after
> attempts=2, exceptions:
> ...
> Tue Nov
> 05 23:58:51 UTC 2019, , org.apache.hadoop.hbase.exceptions.TimeoutIOException:
> Timeout(9450ms) waiting for region location for hbase:rsgroup, row='',
> replicaId=0
> at
> org.apache.hadoop.hbase.client.ResultScanner$1.hasNext(ResultScanner.java:55)
> at
> org.apache.hadoop.hbase.RSGroupTableAccessor.getAllRSGroupInfo(RSGroupTableAccessor.java:59)
> at
> org.apache.hadoop.hbase.tmpl.master.RSGroupListTmplImpl.renderNoFlush(RSGroupListTmplImpl.java:58)
> at
> org.apache.hadoop.hbase.tmpl.master.RSGroupListTmpl.renderNoFlush(RSGroupListTmpl.java:150)
> at
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmplImpl.renderNoFlush(MasterStatusTmplImpl.java:346)
> at
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmpl.renderNoFlush(MasterStatusTmpl.java:397)
> at
> org.apache.hadoop.hbase.tmpl.master.MasterStatusTmpl.render(MasterStatusTmpl.java:388)
> at
> org.apache.hadoop.hbase.master.MasterStatusServlet.doGet(MasterStatusServlet.java:79)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23230) Enforce member visibility in HRegionServer
[
https://issues.apache.org/jira/browse/HBASE-23230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970321#comment-16970321
]
Hudson commented on HBASE-23230:
Results for branch master
[build #1530 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1530/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1530//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1530//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1530//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Enforce member visibility in HRegionServer
> --
>
> Key: HBASE-23230
> URL: https://issues.apache.org/jira/browse/HBASE-23230
> Project: HBase
> Issue Type: Task
> Components: regionserver
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0
>
>
> {{HRegionServer}} leaks member variables quite a lot. Lock down our interface
> -- member variables should be {{private}} (unless intentionally {{protected}}
> for subclasses) and use getters with proper accessibility constraints.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22888) Share some stuffs with the initial reader when new stream reader created
[
https://issues.apache.org/jira/browse/HBASE-22888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970328#comment-16970328
]
Hudson commented on HBASE-22888:
Results for branch master
[build #1530 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1530/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1530//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1530//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1530//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Share some stuffs with the initial reader when new stream reader created
>
>
> Key: HBASE-22888
> URL: https://issues.apache.org/jira/browse/HBASE-22888
> Project: HBase
> Issue Type: Improvement
> Components: HFile, regionserver
>Affects Versions: 2.0.0
>Reporter: chenxu
>Assignee: chenxu
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> When switching pread to stream read, new HFileReaderImpl will be create, but
> the two different readers do not share informations with each other. maybe we
> can divide HFileReaderImpl into two different class, such as HFilePreadReader
> and HFileStreamReader. When constructing HFileStreamReader, it will copy some
> stuffs (fileInfo, index, etc) from an already existing Reader, and no need to
> do prefetch operations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23236) Upgrade to yetus 0.11.1
[
https://issues.apache.org/jira/browse/HBASE-23236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970327#comment-16970327
]
Hudson commented on HBASE-23236:
Results for branch master
[build #1530 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1530/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1530//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1530//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1530//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Upgrade to yetus 0.11.1
> ---
>
> Key: HBASE-23236
> URL: https://issues.apache.org/jira/browse/HBASE-23236
> Project: HBase
> Issue Type: Task
> Components: build
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 1.4.12, 1.3.7, 2.1.8, 1.5.1, 2.2.3
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23263) NPE in Quotas.jsp
[
https://issues.apache.org/jira/browse/HBASE-23263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970325#comment-16970325
]
Hudson commented on HBASE-23263:
Results for branch master
[build #1530 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1530/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1530//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1530//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1530//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> NPE in Quotas.jsp
> -
>
> Key: HBASE-23263
> URL: https://issues.apache.org/jira/browse/HBASE-23263
> Project: HBase
> Issue Type: Bug
> Components: UI
>Affects Versions: 3.0.0
>Reporter: Karthik Palanisamy
>Assignee: Karthik Palanisamy
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.3
>
>
> QuotaManager will be started after master initialization. If no online
> regionservers then master will not be initialized and will throw NPE over
> accessing Quota page.
>
> [http://172.26.70.200:16010/quotas.jsp]
> {code:java}
> HTTP ERROR 500
> Problem accessing /quotas.jsp.
> Reason:
> Server Error
> Caused by:java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.generated.master.quotas_jsp._jspService(quotas_jsp.java:58)
> at
> org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:111)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
> at
> org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:840)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1780)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #656: HBASE-23063 Add an option to enable multiget in parallel
Apache-HBase commented on issue #656: HBASE-23063 Add an option to enable multiget in parallel URL: https://github.com/apache/hbase/pull/656#issuecomment-551862229 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 34s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 17s | master passed | | +1 :green_heart: | compile | 3m 2s | master passed | | +1 :green_heart: | checkstyle | 2m 31s | master passed | | +0 :ok: | refguide | 5m 35s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | shadedjars | 4m 33s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 45s | master passed | | +0 :ok: | spotbugs | 3m 39s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 18m 10s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 58s | the patch passed | | +1 :green_heart: | compile | 3m 5s | the patch passed | | +1 :green_heart: | javac | 3m 5s | the patch passed | | +1 :green_heart: | checkstyle | 2m 28s | root: The patch generated 0 new + 159 unchanged - 6 fixed = 159 total (was 165) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +0 :ok: | refguide | 5m 27s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | shadedjars | 4m 38s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 15m 46s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 3m 44s | the patch passed | | +1 :green_heart: | findbugs | 18m 50s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 180m 54s | root in the patch failed. | | +1 :green_heart: | asflicense | 1m 44s | The patch does not generate ASF License warnings. | | | | 292m 58s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-656/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/656 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml | | uname | Linux 1cbf9b47c5bb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-656/out/precommit/personality/provided.sh | | git revision | master / 34661050c8 | | Default Java | 1.8.0_181 | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-656/5/artifact/out/branch-site/book.html | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-656/5/artifact/out/patch-site/book.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-656/5/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-656/5/testReport/ | | Max. process+thread count | 4980 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-656/5/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apach
[GitHub] [hbase] Apache-HBase commented on issue #754: HBASE-22978 : Online slow response log
Apache-HBase commented on issue #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#issuecomment-551851927 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 4 new or modified test files. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 35s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 14s | master passed | | +1 :green_heart: | compile | 3m 3s | master passed | | +1 :green_heart: | checkstyle | 2m 45s | master passed | | +0 :ok: | refguide | 5m 28s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | shadedjars | 4m 33s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 4m 59s | master passed | | +0 :ok: | spotbugs | 1m 20s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 22m 48s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 0s | the patch passed | | +1 :green_heart: | compile | 3m 2s | the patch passed | | +1 :green_heart: | cc | 3m 2s | the patch passed | | +1 :green_heart: | javac | 3m 2s | the patch passed | | +1 :green_heart: | checkstyle | 2m 38s | root: The patch generated 0 new + 464 unchanged - 1 fixed = 464 total (was 465) | | -1 :x: | rubocop | 0m 17s | The patch generated 19 new + 490 unchanged - 0 fixed = 509 total (was 490) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +0 :ok: | refguide | 5m 22s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | shadedjars | 4m 33s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 15m 40s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | hbaseprotoc | 8m 23s | the patch passed | | +1 :green_heart: | javadoc | 5m 13s | the patch passed | | +1 :green_heart: | findbugs | 24m 17s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 249m 28s | root in the patch passed. | | +1 :green_heart: | asflicense | 4m 47s | The patch does not generate ASF License warnings. | | | | 386m 56s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/754 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool rubocop | | uname | Linux 3e5c2ad61456 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-754/out/precommit/personality/provided.sh | | git revision | master / 34661050c8 | | Default Java | 1.8.0_181 | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/4/artifact/out/branch-site/book.html | | rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/4/artifact/out/diff-patch-rubocop.txt | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/4/artifact/out/patch-site/book.html | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/4/testReport/ | | Max. process+thread count | 5441 (vs. ulimit of 1) | | modules | C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift hbase-shell . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/4/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.76.0 | | P
[GitHub] [hbase] Apache-HBase commented on issue #808: HBASE-20395 Displaying thrift server type on the thrift page
Apache-HBase commented on issue #808: HBASE-20395 Displaying thrift server type on the thrift page URL: https://github.com/apache/hbase/pull/808#issuecomment-551845358 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 2s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 4 new or modified test files. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 35s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 12s | master passed | | +1 :green_heart: | compile | 0m 58s | master passed | | +1 :green_heart: | checkstyle | 0m 57s | master passed | | -1 :x: | pylint | 0m 1s | Error running pylint. Please check pylint stderr files. | | +1 :green_heart: | shadedjars | 4m 37s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 52s | master passed | | +0 :ok: | spotbugs | 1m 30s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 2m 8s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 0s | the patch passed | | +1 :green_heart: | compile | 0m 59s | the patch passed | | +1 :green_heart: | javac | 0m 59s | the patch passed | | -1 :x: | checkstyle | 0m 40s | hbase-thrift: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) | | -1 :x: | pylint | 0m 3s | Error running pylint. Please check pylint stderr files. | | +1 :green_heart: | pylint | 0m 3s | There were no new pylint issues. | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 4m 37s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 15m 33s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 0m 51s | the patch passed | | +1 :green_heart: | findbugs | 2m 21s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 3m 56s | hbase-thrift in the patch passed. | | +1 :green_heart: | unit | 1m 36s | hbase-examples in the patch passed. | | +1 :green_heart: | asflicense | 0m 26s | The patch does not generate ASF License warnings. | | | | 60m 3s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-808/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/808 | | Optional Tests | dupname asflicense javac javadoc unit pylint shellcheck shelldocs spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 86574e165be0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-808/out/precommit/personality/provided.sh | | git revision | master / 2c1d500828 | | Default Java | 1.8.0_181 | | pylint | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-808/1/artifact/out/branch-pylint-stderr.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-808/1/artifact/out/diff-checkstyle-hbase-thrift.txt | | pylint | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-808/1/artifact/out/patch-pylint-stderr.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-808/1/testReport/ | | Max. process+thread count | 2520 (vs. ulimit of 1) | | modules | C: hbase-thrift hbase-examples U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-808/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.7.0 findbugs=3.1.11 pylint=1.6.5 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Serv
[jira] [Commented] (HBASE-22978) Online slow response log
[
https://issues.apache.org/jira/browse/HBASE-22978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970182#comment-16970182
]
Viraj Jasani commented on HBASE-22978:
--
Please review the pull request
> Online slow response log
>
>
> Key: HBASE-22978
> URL: https://issues.apache.org/jira/browse/HBASE-22978
> Project: HBase
> Issue Type: New Feature
> Components: Admin, Operability, regionserver, shell
>Affects Versions: 3.0.0, 2.3.0, 1.5.1
>Reporter: Andrew Kyle Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.6.0
>
> Attachments: Screen Shot 2019-10-19 at 2.31.59 AM.png, Screen Shot
> 2019-10-19 at 2.32.54 AM.png, Screen Shot 2019-10-19 at 2.34.11 AM.png,
> Screen Shot 2019-10-19 at 2.36.14 AM.png
>
>
> Today when an individual RPC exceeds a configurable time bound we log a
> complaint by way of the logging subsystem. These log lines look like:
> {noformat}
> 2019-08-30 22:10:36,195 WARN [,queue=15,port=60020] ipc.RpcServer -
> (responseTooSlow):
> {"call":"Scan(org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ScanRequest)",
> "starttimems":1567203007549,
> "responsesize":6819737,
> "method":"Scan",
> "param":"region { type: REGION_NAME value:
> \"tsdb,\\000\\000\\215\\f)o\\024\\302\\220\\000\\000\\000\\000\\000\\001\\000\\000\\000\\000\\000\\006\\000\\000\\000\\000\\000\\005\\000\\000",
> "processingtimems":28646,
> "client":"10.253.196.215:41116",
> "queuetimems":22453,
> "class":"HRegionServer"}
> {noformat}
> Unfortunately we often truncate the request parameters, like in the above
> example. We do this because the human readable representation is verbose, the
> rate of too slow warnings may be high, and the combination of these things
> can overwhelm the log capture system. The truncation is unfortunate because
> it eliminates much of the utility of the warnings. For example, the region
> name, the start and end keys, and the filter hierarchy are all important
> clues for debugging performance problems caused by moderate to low
> selectivity queries or queries made at a high rate.
> We can maintain an in-memory ring buffer of requests that were judged to be
> too slow in addition to the responseTooSlow logging. The in-memory
> representation can be complete and compressed. A new admin API and shell
> command can provide access to the ring buffer for online performance
> debugging. A modest sizing of the ring buffer will prevent excessive memory
> utilization for a minor performance debugging feature by limiting the total
> number of retained records. There is some chance a high rate of requests will
> cause information on other interesting requests to be overwritten before it
> can be read. This is the nature of a ring buffer and an acceptable trade off.
> The write request types do not require us to retain all information submitted
> in the request. We don't need to retain all key-values in the mutation, which
> may be too large to comfortably retain. We only need a unique set of row
> keys, or even a min/max range, and total counts.
> The consumers of this information will be debugging tools. We can afford to
> apply fast compression to ring buffer entries (if codec support is
> available), something like snappy or zstandard, and decompress on the fly
> when servicing the retrieval API request. This will minimize the impact of
> retaining more information about slow requests than we do today.
> This proposal is for retention of request information only, the same
> information provided by responseTooSlow warnings. Total size of response
> serialization, possibly also total cell or row counts, should be sufficient
> to characterize the response.
> Optionally persist new entries added to the ring buffer into one or more
> files in HDFS in a write-behind manner. If the HDFS writer blocks or falls
> behind and we are unable to persist an entry before it is overwritten, that
> is fine. Response too slow logging is best effort. If we can detect this make
> a note of it in the log file. Provide a tool for parsing, dumping, filtering,
> and pretty printing the slow logs written to HDFS. The tool and the shell can
> share and reuse some utility classes and methods for accomplishing that.
> —
> New shell commands:
> {{get_slow_responses [ ... , ] [ , \{
> } ]}}
> Retrieve, decode, and pretty print the contents of the too slow response ring
> buffer maintained by the given list of servers; or all servers in the cluster
> if no list is provided. Optionally provide a map of parameters for filtering
> as additional argument. The TABLE filter, which expects a string containing a
> table name, will include only entries pertaining to that table. The REGION
> filter, which expects a string containing an e
[jira] [Updated] (HBASE-23261) Region stuck in transition while splitting
[
https://issues.apache.org/jira/browse/HBASE-23261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viraj Jasani updated HBASE-23261:
-
Description:
While splitting, some region gets stuck in transition. After RegionServer
initiates split, ZK has the region marked in RIT ZNode. However, RegionServer
encounters KeeperException.BadVersion for
/hbase/region-in-transition/\{region-name} while transitioning node to
RS_ZK_REQUEST_REGION_SPLIT and hence, it runs rollback/cleanup of failed split
of the region. Even after successful rollback, region stays in transition
sometimes.
{code:java}
2019-11-05 04:07:17,711 INFO [splits-1572926837064] regionserver.SplitRequest -
Successful rollback of failed split of
TABLE1,1572894157455.257ff8985e7a169af0514208b3b0b430.
{code}
{code:java}
2019-11-05 04:07:17,688 INFO [splits-1572926837064] regionserver.SplitRequest -
Running rollback/cleanup of failed split of
TABLE1,1572894157455.257ff8985e7a169af0514208b3b0b430.; Failed getting
SPLITTING znode on TABLE1,1572894157455.257ff8985e7a169af0514208b3b0b430.
java.io.IOException: Failed getting SPLITTING znode on
TABLE1,1572894157455.257ff8985e7a169af0514208b3b0b430. at
org.apache.hadoop.hbase.coordination.ZKSplitTransactionCoordination.waitForSplitTransaction(ZKSplitTransactionCoordination.java:203)
at
org.apache.hadoop.hbase.regionserver.SplitTransactionImpl.stepsBeforePONR(SplitTransactionImpl.java:383)
at
org.apache.hadoop.hbase.regionserver.SplitTransactionImpl.createDaughters(SplitTransactionImpl.java:278)
at
org.apache.hadoop.hbase.regionserver.SplitTransactionImpl.execute(SplitTransactionImpl.java:561)
at
org.apache.hadoop.hbase.regionserver.SplitRequest.doSplitting(SplitRequest.java:82)
at
org.apache.hadoop.hbase.regionserver.SplitRequest.run(SplitRequest.java:153) at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748) Caused by: java.io.IOException: Failed
transition of splitting node
TABLE1,1572894157455.257ff8985e7a169af0514208b3b0b430. at
org.apache.hadoop.hbase.coordination.ZKSplitTransactionCoordination.transitionSplittingNode(ZKSplitTransactionCoordination.java:132)
at
org.apache.hadoop.hbase.coordination.ZKSplitTransactionCoordination.waitForSplitTransaction(ZKSplitTransactionCoordination.java:161)
... 8 more Caused by:
org.apache.zookeeper.KeeperException$BadVersionException: KeeperErrorCode =
BadVersion for /hbase/region-in-transition/257ff8985e7a169af0514208b3b0b430 at
org.apache.zookeeper.KeeperException.create(KeeperException.java:115) at
org.apache.zookeeper.KeeperException.create(KeeperException.java:51) at
org.apache.zookeeper.ZooKeeper.setData(ZooKeeper.java:1336) at
org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.setData(RecoverableZooKeeper.java:442)
at org.apache.hadoop.hbase.zookeeper.ZKUtil.setData(ZKUtil.java:818) at
org.apache.hadoop.hbase.zookeeper.ZKAssign.transitionNode(ZKAssign.java:871) at
org.apache.hadoop.hbase.coordination.ZKSplitTransactionCoordination.transitionSplittingNode(ZKSplitTransactionCoordination.java:128)
... 9 more
{code}
{code:java}
2019-11-05 04:07:17,688 INFO [.Worker-pool3-t26826] master.RegionStates -
Transition {257ff8985e7a169af0514208b3b0b430 state=OPEN, ts=1572923178845,
server=rsserver.net,60020,1572890688075} to {257ff8985e7a169af0514208b3b0b430
state=SPLITTING, ts=1572926837688, server=rsserver.net,60020,1572890688075}
{code}
{code:java}
2019-11-05 04:07:17,680 INFO [myid:5] [ead(sid:5 cport:-1):]
server.PrepRequestProcessor - Got user-level KeeperException when processing
sessionid:0x36dd5dc94536a3e type:setData cxid:0x8f8a zxid:0x304fd98ef
txntype:-1 reqpath:n/a Error
Path:/hbase/region-in-transition/257ff8985e7a169af0514208b3b0b430
Error:KeeperErrorCode = BadVersion for
/hbase/region-in-transition/257ff8985e7a169af0514208b3b0b430
{code}
{code:java}
2019-11-05 04:07:17,668 DEBUG [.Worker-pool3-t26826] master.AssignmentManager -
Handling RS_ZK_REQUEST_REGION_SPLIT, server=rsserver.net,60020,1572890688075,
region=257ff8985e7a169af0514208b3b0b430,
current_state={257ff8985e7a169af0514208b3b0b430 state=OPEN, ts=1572923178845,
server=rsserver.net,60020,1572890688075}
{code}
{code:java}
2019-11-05 04:07:17,661 DEBUG [splits-1572926837064]
coordination.ZKSplitTransactionCoordination - Still waiting for master to
process the pending_split for 257ff8985e7a169af0514208b3b0b430
{code}
was:
While splitting, some region gets stuck in transition. After RegionServer
initiates split, ZK has the region marked in RIT ZNode. However, HMaster has
KeeperException with BadVersion for /hbase/region-in-transition/\{region-name}
and hence, it runs rollback/cleanup of failed split of the region. Even after
successful rollback, region is in transition.
{code:java}
2019-11-05 04:07:17,711
[jira] [Updated] (HBASE-23261) Region stuck in transition while splitting
[
https://issues.apache.org/jira/browse/HBASE-23261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viraj Jasani updated HBASE-23261:
-
Attachment: HBASE-23261.branch-1.3.000.patch
Fix Version/s: 1.5.1
1.3.7
1.4.12
1.6.0
Status: Patch Available (was: In Progress)
> Region stuck in transition while splitting
> --
>
> Key: HBASE-23261
> URL: https://issues.apache.org/jira/browse/HBASE-23261
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.5
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 1.6.0, 1.4.12, 1.3.7, 1.5.1
>
> Attachments: HBASE-23261.branch-1.3.000.patch
>
>
> While splitting, some region gets stuck in transition. After RegionServer
> initiates split, ZK has the region marked in RIT ZNode. However, HMaster has
> KeeperException with BadVersion for
> /hbase/region-in-transition/\{region-name} and hence, it runs
> rollback/cleanup of failed split of the region. Even after successful
> rollback, region is in transition.
>
>
> {code:java}
> 2019-11-05 04:07:17,711 INFO [splits-1572926837064] regionserver.SplitRequest
> - Successful rollback of failed split of
> TABLE1,1572894157455.257ff8985e7a169af0514208b3b0b430.
> {code}
> {code:java}
> 2019-11-05 04:07:17,688 INFO [splits-1572926837064] regionserver.SplitRequest
> - Running rollback/cleanup of failed split of
> TABLE1,1572894157455.257ff8985e7a169af0514208b3b0b430.; Failed getting
> SPLITTING znode on TABLE1,1572894157455.257ff8985e7a169af0514208b3b0b430.
> java.io.IOException: Failed getting SPLITTING znode on
> TABLE1,1572894157455.257ff8985e7a169af0514208b3b0b430. at
> org.apache.hadoop.hbase.coordination.ZKSplitTransactionCoordination.waitForSplitTransaction(ZKSplitTransactionCoordination.java:203)
> at
> org.apache.hadoop.hbase.regionserver.SplitTransactionImpl.stepsBeforePONR(SplitTransactionImpl.java:383)
> at
> org.apache.hadoop.hbase.regionserver.SplitTransactionImpl.createDaughters(SplitTransactionImpl.java:278)
> at
> org.apache.hadoop.hbase.regionserver.SplitTransactionImpl.execute(SplitTransactionImpl.java:561)
> at
> org.apache.hadoop.hbase.regionserver.SplitRequest.doSplitting(SplitRequest.java:82)
> at
> org.apache.hadoop.hbase.regionserver.SplitRequest.run(SplitRequest.java:153)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748) Caused by: java.io.IOException:
> Failed transition of splitting node
> TABLE1,1572894157455.257ff8985e7a169af0514208b3b0b430. at
> org.apache.hadoop.hbase.coordination.ZKSplitTransactionCoordination.transitionSplittingNode(ZKSplitTransactionCoordination.java:132)
> at
> org.apache.hadoop.hbase.coordination.ZKSplitTransactionCoordination.waitForSplitTransaction(ZKSplitTransactionCoordination.java:161)
> ... 8 more Caused by:
> org.apache.zookeeper.KeeperException$BadVersionException: KeeperErrorCode =
> BadVersion for /hbase/region-in-transition/257ff8985e7a169af0514208b3b0b430
> at org.apache.zookeeper.KeeperException.create(KeeperException.java:115) at
> org.apache.zookeeper.KeeperException.create(KeeperException.java:51) at
> org.apache.zookeeper.ZooKeeper.setData(ZooKeeper.java:1336) at
> org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.setData(RecoverableZooKeeper.java:442)
> at org.apache.hadoop.hbase.zookeeper.ZKUtil.setData(ZKUtil.java:818) at
> org.apache.hadoop.hbase.zookeeper.ZKAssign.transitionNode(ZKAssign.java:871)
> at
> org.apache.hadoop.hbase.coordination.ZKSplitTransactionCoordination.transitionSplittingNode(ZKSplitTransactionCoordination.java:128)
> ... 9 more
> {code}
> {code:java}
> 2019-11-05 04:07:17,688 INFO [.Worker-pool3-t26826] master.RegionStates -
> Transition {257ff8985e7a169af0514208b3b0b430 state=OPEN, ts=1572923178845,
> server=rsserver.net,60020,1572890688075} to {257ff8985e7a169af0514208b3b0b430
> state=SPLITTING, ts=1572926837688, server=rsserver.net,60020,1572890688075}
> {code}
> {code:java}
> 2019-11-05 04:07:17,680 INFO [myid:5] [ead(sid:5 cport:-1):]
> server.PrepRequestProcessor - Got user-level KeeperException when processing
> sessionid:0x36dd5dc94536a3e type:setData cxid:0x8f8a zxid:0x304fd98ef
> txntype:-1 reqpath:n/a Error
> Path:/hbase/region-in-transition/257ff8985e7a169af0514208b3b0b430
> Error:KeeperErrorCode = BadVersion for
> /hbase/region-in-transition/257ff8985e7a169af0514208b3b0b430
> {code}
> {code:java}
> 2019-11-05 04:07:17,668 DEBUG [.Worker-pool3-t26826] master.AssignmentManager
> - Handling RS_ZK_REQUEST_REGION_SPLIT,
> server=rsserver.net,60020,1572890688075,
> region=257ff8985e7a169af051420
[jira] [Work started] (HBASE-23261) Region stuck in transition while splitting
[
https://issues.apache.org/jira/browse/HBASE-23261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-23261 started by Viraj Jasani.
> Region stuck in transition while splitting
> --
>
> Key: HBASE-23261
> URL: https://issues.apache.org/jira/browse/HBASE-23261
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.5
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Major
>
> While splitting, some region gets stuck in transition. After RegionServer
> initiates split, ZK has the region marked in RIT ZNode. However, HMaster has
> KeeperException with BadVersion for
> /hbase/region-in-transition/\{region-name} and hence, it runs
> rollback/cleanup of failed split of the region. Even after successful
> rollback, region is in transition.
>
>
> {code:java}
> 2019-11-05 04:07:17,711 INFO [splits-1572926837064] regionserver.SplitRequest
> - Successful rollback of failed split of
> TABLE1,1572894157455.257ff8985e7a169af0514208b3b0b430.
> {code}
> {code:java}
> 2019-11-05 04:07:17,688 INFO [splits-1572926837064] regionserver.SplitRequest
> - Running rollback/cleanup of failed split of
> TABLE1,1572894157455.257ff8985e7a169af0514208b3b0b430.; Failed getting
> SPLITTING znode on TABLE1,1572894157455.257ff8985e7a169af0514208b3b0b430.
> java.io.IOException: Failed getting SPLITTING znode on
> TABLE1,1572894157455.257ff8985e7a169af0514208b3b0b430. at
> org.apache.hadoop.hbase.coordination.ZKSplitTransactionCoordination.waitForSplitTransaction(ZKSplitTransactionCoordination.java:203)
> at
> org.apache.hadoop.hbase.regionserver.SplitTransactionImpl.stepsBeforePONR(SplitTransactionImpl.java:383)
> at
> org.apache.hadoop.hbase.regionserver.SplitTransactionImpl.createDaughters(SplitTransactionImpl.java:278)
> at
> org.apache.hadoop.hbase.regionserver.SplitTransactionImpl.execute(SplitTransactionImpl.java:561)
> at
> org.apache.hadoop.hbase.regionserver.SplitRequest.doSplitting(SplitRequest.java:82)
> at
> org.apache.hadoop.hbase.regionserver.SplitRequest.run(SplitRequest.java:153)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748) Caused by: java.io.IOException:
> Failed transition of splitting node
> TABLE1,1572894157455.257ff8985e7a169af0514208b3b0b430. at
> org.apache.hadoop.hbase.coordination.ZKSplitTransactionCoordination.transitionSplittingNode(ZKSplitTransactionCoordination.java:132)
> at
> org.apache.hadoop.hbase.coordination.ZKSplitTransactionCoordination.waitForSplitTransaction(ZKSplitTransactionCoordination.java:161)
> ... 8 more Caused by:
> org.apache.zookeeper.KeeperException$BadVersionException: KeeperErrorCode =
> BadVersion for /hbase/region-in-transition/257ff8985e7a169af0514208b3b0b430
> at org.apache.zookeeper.KeeperException.create(KeeperException.java:115) at
> org.apache.zookeeper.KeeperException.create(KeeperException.java:51) at
> org.apache.zookeeper.ZooKeeper.setData(ZooKeeper.java:1336) at
> org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.setData(RecoverableZooKeeper.java:442)
> at org.apache.hadoop.hbase.zookeeper.ZKUtil.setData(ZKUtil.java:818) at
> org.apache.hadoop.hbase.zookeeper.ZKAssign.transitionNode(ZKAssign.java:871)
> at
> org.apache.hadoop.hbase.coordination.ZKSplitTransactionCoordination.transitionSplittingNode(ZKSplitTransactionCoordination.java:128)
> ... 9 more
> {code}
> {code:java}
> 2019-11-05 04:07:17,688 INFO [.Worker-pool3-t26826] master.RegionStates -
> Transition {257ff8985e7a169af0514208b3b0b430 state=OPEN, ts=1572923178845,
> server=rsserver.net,60020,1572890688075} to {257ff8985e7a169af0514208b3b0b430
> state=SPLITTING, ts=1572926837688, server=rsserver.net,60020,1572890688075}
> {code}
> {code:java}
> 2019-11-05 04:07:17,680 INFO [myid:5] [ead(sid:5 cport:-1):]
> server.PrepRequestProcessor - Got user-level KeeperException when processing
> sessionid:0x36dd5dc94536a3e type:setData cxid:0x8f8a zxid:0x304fd98ef
> txntype:-1 reqpath:n/a Error
> Path:/hbase/region-in-transition/257ff8985e7a169af0514208b3b0b430
> Error:KeeperErrorCode = BadVersion for
> /hbase/region-in-transition/257ff8985e7a169af0514208b3b0b430
> {code}
> {code:java}
> 2019-11-05 04:07:17,668 DEBUG [.Worker-pool3-t26826] master.AssignmentManager
> - Handling RS_ZK_REQUEST_REGION_SPLIT,
> server=rsserver.net,60020,1572890688075,
> region=257ff8985e7a169af0514208b3b0b430,
> current_state={257ff8985e7a169af0514208b3b0b430 state=OPEN, ts=1572923178845,
> server=rsserver.net,60020,1572890688075}
> {code}
> {code:java}
> 2019-11-05 04:07:17,661 DEBUG [splits-1572926837064]
> coordination.ZKSplitTransactionCoordination - Still waiting for master to
> proc
[jira] [Commented] (HBASE-20395) Displaying thrift server type on the thrift page
[ https://issues.apache.org/jira/browse/HBASE-20395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970160#comment-16970160 ] Guangxu Cheng commented on HBASE-20395: --- Create a new PR: [https://github.com/apache/hbase/pull/808] > Displaying thrift server type on the thrift page > > > Key: HBASE-20395 > URL: https://issues.apache.org/jira/browse/HBASE-20395 > Project: HBase > Issue Type: Improvement > Components: Thrift >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng >Priority: Major > Attachments: HBASE-20395.master.001.patch, > HBASE-20395.master.002.patch, HBASE-20395.master.003.patch, > HBASE-20395.master.004.patch, HBASE-20395.master.005.patch, > HBASE-20395.master.005.patch, result.png > > > HBase supports two types of thrift server: thrift and thrift2. > But after start the thrift server successfully, we can not get the thrift > server type conveniently. > So, displaying thrift server type on the thrift page may provide some > convenience for the users. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] guangxuCheng opened a new pull request #808: HBASE-20395 Displaying thrift server type on the thrift page
guangxuCheng opened a new pull request #808: HBASE-20395 Displaying thrift server type on the thrift page URL: https://github.com/apache/hbase/pull/808 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #581: HBASE-22888 Share some stuffs with the initial reader when new stream reader created
Apache-HBase commented on issue #581: HBASE-22888 Share some stuffs with the initial reader when new stream reader created URL: https://github.com/apache/hbase/pull/581#issuecomment-551657160 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 1m 8s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 1s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 27 new or modified test files. | ||| _ master Compile Tests _ | | :blue_heart: | mvndep | 0m 36s | Maven dependency ordering for branch | | :green_heart: | mvninstall | 5m 10s | master passed | | :green_heart: | compile | 1m 50s | master passed | | :green_heart: | checkstyle | 2m 15s | master passed | | :green_heart: | shadedjars | 4m 40s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 1m 15s | master passed | | :blue_heart: | spotbugs | 3m 58s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 5m 27s | master passed | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 16s | Maven dependency ordering for patch | | :green_heart: | mvninstall | 4m 56s | the patch passed | | :green_heart: | compile | 1m 48s | the patch passed | | :green_heart: | javac | 1m 48s | the patch passed | | :green_heart: | checkstyle | 1m 33s | hbase-server: The patch generated 0 new + 610 unchanged - 45 fixed = 610 total (was 655) | | :green_heart: | checkstyle | 0m 23s | The patch passed checkstyle in hbase-mapreduce | | :green_heart: | checkstyle | 0m 15s | The patch passed checkstyle in hbase-backup | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | shadedjars | 4m 37s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 15m 42s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | javadoc | 1m 14s | the patch passed | | :green_heart: | findbugs | 5m 51s | the patch passed | ||| _ Other Tests _ | | :broken_heart: | unit | 286m 56s | hbase-server in the patch failed. | | :broken_heart: | unit | 25m 24s | hbase-mapreduce in the patch failed. | | :green_heart: | unit | 17m 56s | hbase-backup in the patch passed. | | :green_heart: | asflicense | 2m 4s | The patch does not generate ASF License warnings. | | | | 398m 26s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.client.TestFromClientSideWithCoprocessor | | | hadoop.hbase.snapshot.TestExportSnapshot | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-581/17/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/581 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 3e9f3eaf4ef7 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-581/out/precommit/personality/provided.sh | | git revision | master / c2e01f2398 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-581/17/artifact/out/patch-unit-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-581/17/artifact/out/patch-unit-hbase-mapreduce.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-581/17/testReport/ | | Max. process+thread count | 5379 (vs. ulimit of 1) | | modules | C: hbase-server hbase-mapreduce hbase-backup U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-581/17/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the
[jira] [Commented] (HBASE-23236) Upgrade to yetus 0.11.1
[
https://issues.apache.org/jira/browse/HBASE-23236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970079#comment-16970079
]
Hudson commented on HBASE-23236:
Results for branch branch-1
[build #1131 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1131/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1131//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1131//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1131//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Upgrade to yetus 0.11.1
> ---
>
> Key: HBASE-23236
> URL: https://issues.apache.org/jira/browse/HBASE-23236
> Project: HBase
> Issue Type: Task
> Components: build
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 1.4.12, 1.3.7, 2.1.8, 1.5.1, 2.2.3
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
