[GitHub] [hbase] xuqinya1 commented on issue #819: HBASE-23285 Sometimes walArchiveDir does not exist when separate the old WALs into different regionserver directories
xuqinya1 commented on issue #819: HBASE-23285 Sometimes walArchiveDir does not exist when separate the old WALs into different regionserver directories URL: https://github.com/apache/hbase/pull/819#issuecomment-556963383 > Do you mean, somewhere else, the RS specific wal dir gets deleted? Thanks for the review. @wchevreuil yes, CleanerChore.traverseAndDelete attempts to clean up a directory(its subdirectories, and files) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #740: HBASE-23197 'IllegalArgumentException: Wrong FS' on edits replay when…
Apache-HBase commented on issue #740: HBASE-23197 'IllegalArgumentException: Wrong FS' on edits replay when… URL: https://github.com/apache/hbase/pull/740#issuecomment-556954909 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 19s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 8m 22s | master passed | | +1 :green_heart: | compile | 1m 19s | master passed | | +1 :green_heart: | checkstyle | 1m 48s | master passed | | +1 :green_heart: | shadedjars | 6m 17s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 50s | master passed | | +0 :ok: | spotbugs | 5m 29s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 5m 26s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 7m 55s | the patch passed | | +1 :green_heart: | compile | 1m 11s | the patch passed | | +1 :green_heart: | javac | 1m 11s | the patch passed | | -1 :x: | checkstyle | 1m 46s | hbase-server: The patch generated 1 new + 290 unchanged - 0 fixed = 291 total (was 290) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 6m 2s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 22m 44s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 0m 55s | the patch passed | | +1 :green_heart: | findbugs | 5m 48s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 276m 27s | hbase-server in the patch failed. | | +1 :green_heart: | asflicense | 0m 28s | The patch does not generate ASF License warnings. | | | | 358m 27s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas | | | hadoop.hbase.client.TestFromClientSideWithCoprocessor | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-740/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/740 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux fae8c9d30607 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-740/out/precommit/personality/provided.sh | | git revision | master / 834ccb4bf6 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-740/5/artifact/out/diff-checkstyle-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-740/5/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-740/5/testReport/ | | Max. process+thread count | 4919 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-740/5/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1
[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979018#comment-16979018 ] Viraj Jasani edited comment on HBASE-23279 at 11/21/19 6:40 AM: The only change require in attached patch 002 is changing DataBlockEncoding: public static final DataBlockEncoding DEFAULT_DATA_BLOCK_ENCODING = DataBlockEncoding.ROW_INDEX_V1; With the patch applied, if I change above value to DataBlockEncoding.NONE, the test case passes, for DIFF, FAST_DIFF, it fails as per above comment was (Author: vjasani): The only change require in attached patch 003 is changing DataBlockEncoding: public static final DataBlockEncoding DEFAULT_DATA_BLOCK_ENCODING = DataBlockEncoding.ROW_INDEX_V1; With the patch applied, if I change above value to DataBlockEncoding.NONE, the test case passes, for DIFF, FAST_DIFF, it fails as per above comment > Switch default block encoding to ROW_INDEX_V1 > - > > Key: HBASE-23279 > URL: https://issues.apache.org/jira/browse/HBASE-23279 > Project: HBase > Issue Type: Wish >Affects Versions: 3.0.0, 2.3.0 >Reporter: Lars Hofhansl >Assignee: Viraj Jasani >Priority: Minor > Fix For: 3.0.0, 2.3.0 > > Attachments: HBASE-23279.master.000.patch, > HBASE-23279.master.001.patch, HBASE-23279.master.002.patch > > > Currently we set both block encoding and compression to NONE. > ROW_INDEX_V1 has many advantages and (almost) no disadvantages (the hfiles > are slightly larger about 3% or so). I think that would a better default than > NONE. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1
[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979018#comment-16979018 ] Viraj Jasani commented on HBASE-23279: -- The only change require in attached patch 003 is changing DataBlockEncoding: public static final DataBlockEncoding DEFAULT_DATA_BLOCK_ENCODING = DataBlockEncoding.ROW_INDEX_V1; With the patch applied, if I change above value to DataBlockEncoding.NONE, the test case passes, for DIFF, FAST_DIFF, it fails as per above comment > Switch default block encoding to ROW_INDEX_V1 > - > > Key: HBASE-23279 > URL: https://issues.apache.org/jira/browse/HBASE-23279 > Project: HBase > Issue Type: Wish >Affects Versions: 3.0.0, 2.3.0 >Reporter: Lars Hofhansl >Assignee: Viraj Jasani >Priority: Minor > Fix For: 3.0.0, 2.3.0 > > Attachments: HBASE-23279.master.000.patch, > HBASE-23279.master.001.patch, HBASE-23279.master.002.patch > > > Currently we set both block encoding and compression to NONE. > ROW_INDEX_V1 has many advantages and (almost) no disadvantages (the hfiles > are slightly larger about 3% or so). I think that would a better default than > NONE. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1
[
https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979017#comment-16979017
]
Viraj Jasani commented on HBASE-23279:
--
{quote}You can try enabling other encoding instead of NONE and see even if it
fails
{quote}
Tried with DIFF and FAST_DIFF, at least the error of "lexically larger than
previous" is not coming but extracting row from meta row is failing here:
{code:java}
assertTrue(Bytes.compareTo(Bytes.toBytes((short)answer),
extractRowFromMetaRow(r.getRow())) == 0);
{code}
{code:java}
java.lang.AssertionErrorjava.lang.AssertionError at
org.apache.hadoop.hbase.regionserver.TestGetClosestAtOrBefore.findRow(TestGetClosestAtOrBefore.java:184)
at
org.apache.hadoop.hbase.regionserver.TestGetClosestAtOrBefore.testUsingMetaAndBinary(TestGetClosestAtOrBefore.java:128)
{code}
> Switch default block encoding to ROW_INDEX_V1
> -
>
> Key: HBASE-23279
> URL: https://issues.apache.org/jira/browse/HBASE-23279
> Project: HBase
> Issue Type: Wish
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Lars Hofhansl
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 2.3.0
>
> Attachments: HBASE-23279.master.000.patch,
> HBASE-23279.master.001.patch, HBASE-23279.master.002.patch
>
>
> Currently we set both block encoding and compression to NONE.
> ROW_INDEX_V1 has many advantages and (almost) no disadvantages (the hfiles
> are slightly larger about 3% or so). I think that would a better default than
> NONE.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1
[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979011#comment-16979011 ] Anoop Sam John commented on HBASE-23279: Ya still good to experiment to know the extra size need because of encoder. For same data if NONE have say 100 blocks, how many more blocks we will end up having when it is ROW_INDEX_V1 . Good to know that math. > Switch default block encoding to ROW_INDEX_V1 > - > > Key: HBASE-23279 > URL: https://issues.apache.org/jira/browse/HBASE-23279 > Project: HBase > Issue Type: Wish >Affects Versions: 3.0.0, 2.3.0 >Reporter: Lars Hofhansl >Assignee: Viraj Jasani >Priority: Minor > Fix For: 3.0.0, 2.3.0 > > Attachments: HBASE-23279.master.000.patch, > HBASE-23279.master.001.patch, HBASE-23279.master.002.patch > > > Currently we set both block encoding and compression to NONE. > ROW_INDEX_V1 has many advantages and (almost) no disadvantages (the hfiles > are slightly larger about 3% or so). I think that would a better default than > NONE. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1
[
https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979009#comment-16979009
]
Anoop Sam John commented on HBASE-23279:
bq.ROW_INDEX_V1 indeed seems to be taking more space for BucketCache.
The concern above was that whether the HFile blocks with ROW_INDEX_V1 encoding
will take more size than the NONE. But the block building logic is
considering the encoded size also now.
{code}
if (blockWriter.encodedBlockSizeWritten() >= encodedBlockSizeLimit
|| blockWriter.blockSizeWritten() >= hFileContext.getBlocksize()) {
finishBlock();
writeInlineBlocks(false);
newBlock();
}
{code}
So if the block size is 64 KB either the encoded size or the encoded size
reaches this limit, we finish and move to next block. So on Bucket Cache
bucket sizes this wont be a concern.And by default the encodedBlockSizeLimit =
hFileContext.getBlocksize() only.
> Switch default block encoding to ROW_INDEX_V1
> -
>
> Key: HBASE-23279
> URL: https://issues.apache.org/jira/browse/HBASE-23279
> Project: HBase
> Issue Type: Wish
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Lars Hofhansl
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 2.3.0
>
> Attachments: HBASE-23279.master.000.patch,
> HBASE-23279.master.001.patch, HBASE-23279.master.002.patch
>
>
> Currently we set both block encoding and compression to NONE.
> ROW_INDEX_V1 has many advantages and (almost) no disadvantages (the hfiles
> are slightly larger about 3% or so). I think that would a better default than
> NONE.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1
[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979010#comment-16979010 ] ramkrishna.s.vasudevan commented on HBASE-23279: [~vjasani] You can try enabling other encoding instead of NONE and see even if it fails bq.Do we support get closest at or before in hbase2? Its deprecated, no? Seems it is deprecated as I remember. But it is still better to verify if the encoding is messing anything. I hope no. > Switch default block encoding to ROW_INDEX_V1 > - > > Key: HBASE-23279 > URL: https://issues.apache.org/jira/browse/HBASE-23279 > Project: HBase > Issue Type: Wish >Affects Versions: 3.0.0, 2.3.0 >Reporter: Lars Hofhansl >Assignee: Viraj Jasani >Priority: Minor > Fix For: 3.0.0, 2.3.0 > > Attachments: HBASE-23279.master.000.patch, > HBASE-23279.master.001.patch, HBASE-23279.master.002.patch > > > Currently we set both block encoding and compression to NONE. > ROW_INDEX_V1 has many advantages and (almost) no disadvantages (the hfiles > are slightly larger about 3% or so). I think that would a better default than > NONE. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1
[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979003#comment-16979003 ] Michael Stack commented on HBASE-23279: --- Do we support get closest at or before in hbase2? Its deprecated, no? We are for sure putting in place the correct comparator, the meta comparator (it does weird stuff comparing sub-pieces of the row delineated by ',' ). Otherwise, it could be an actual problem in how encoding is messing up read. Good on you [~vjasani] > Switch default block encoding to ROW_INDEX_V1 > - > > Key: HBASE-23279 > URL: https://issues.apache.org/jira/browse/HBASE-23279 > Project: HBase > Issue Type: Wish >Affects Versions: 3.0.0, 2.3.0 >Reporter: Lars Hofhansl >Assignee: Viraj Jasani >Priority: Minor > Fix For: 3.0.0, 2.3.0 > > Attachments: HBASE-23279.master.000.patch, > HBASE-23279.master.001.patch, HBASE-23279.master.002.patch > > > Currently we set both block encoding and compression to NONE. > ROW_INDEX_V1 has many advantages and (almost) no disadvantages (the hfiles > are slightly larger about 3% or so). I think that would a better default than > NONE. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1
[
https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978999#comment-16978999
]
Viraj Jasani commented on HBASE-23279:
--
Facing some issue with one UT: TestGetClosestAtOrBefore.testUsingMetaAndBinary()
Here, we are writing rows for 3 tables: A, B, C. For each tables, we start
writing rowkeys in some ranges in meta. e.g. first range is ('', key1) and
second is (key2,key3) and so on. While flushing meta, the error is "key not
lexically larger than previous" for second row. Without this patch(with NONE
encoding), this test passes but with default encoding as ROW_INDEX_V1, not sure
what is going wrong while comparing second row with first one.
Sample error: Current Cell is 2nd region of Table A and Last Cell is 1st region
of Table A:
{code:java}
java.io.IOException: Added a key not lexically larger than previous. Current
cell =
A,\x00\x02,1574315191138.fce5ac5d556ff2c00d7c03a47ddd1270./info:regioninfo/1574315191138/Put/vlen=41/seqid=3/PBUF\x08\xE2\xD6\xFD\xE3\xE8-\x12\x0C\x0A\x07default\x12\x01A\x1A\x02\x00\x02"\x04\x00\x00\x00\x04(\x000\x008\x00,
lastCell =
A,,1574315191089.3745f86220ac4361440a77263915ca1a./info:regioninfo/1574315191089/Put/vlen=39/seqid=2/PBUF\x08\xB1\xD6\xFD\xE3\xE8-\x12\x0C\x0A\x07default\x12\x01A\x1A\x00"\x04\x00\x00\x00\x02(\x000\x008\x00{code}
> Switch default block encoding to ROW_INDEX_V1
> -
>
> Key: HBASE-23279
> URL: https://issues.apache.org/jira/browse/HBASE-23279
> Project: HBase
> Issue Type: Wish
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Lars Hofhansl
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 2.3.0
>
> Attachments: HBASE-23279.master.000.patch,
> HBASE-23279.master.001.patch, HBASE-23279.master.002.patch
>
>
> Currently we set both block encoding and compression to NONE.
> ROW_INDEX_V1 has many advantages and (almost) no disadvantages (the hfiles
> are slightly larger about 3% or so). I think that would a better default than
> NONE.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] saintstack opened a new pull request #859: HBASE-23307 Add running of ReplicationBarrierCleaner to hbck2 fixMeta…
saintstack opened a new pull request #859: HBASE-23307 Add running of ReplicationBarrierCleaner to hbck2 fixMeta… URL: https://github.com/apache/hbase/pull/859 … invocation This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack closed pull request #854: HBASE-23307 Add running of ReplicationBarrierCleaner to hbck2 fixMeta…
saintstack closed pull request #854: HBASE-23307 Add running of ReplicationBarrierCleaner to hbck2 fixMeta… URL: https://github.com/apache/hbase/pull/854 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22607) TestExportSnapshotNoCluster::testSnapshotWithRefsExportFileSystemState() fails intermittently
[
https://issues.apache.org/jira/browse/HBASE-22607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978991#comment-16978991
]
Hudson commented on HBASE-22607:
Results for branch branch-2.1
[build #1716 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1716/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1716//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1716//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1716//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> TestExportSnapshotNoCluster::testSnapshotWithRefsExportFileSystemState()
> fails intermittently
> -
>
> Key: HBASE-22607
> URL: https://issues.apache.org/jira/browse/HBASE-22607
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0, 2.2.0, 2.0.6
>Reporter: Mingliang Liu
>Assignee: Mingliang Liu
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.3, 2.1.9
>
> Attachments: HBASE-22607.000.patch, HBASE-22607.001.patch,
> HBASE-22607.002.patch
>
>
> In previous runs, test
> {{TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState}}
> fails intermittently with {{java.net.ConnectException: Connection refused}}
> exception, see build
> [510|https://builds.apache.org/job/PreCommit-HBASE-Build/510/testReport/org.apache.hadoop.hbase.snapshot/TestExportSnapshotNoCluster/testSnapshotWithRefsExportFileSystemState/],
>
> [545|https://builds.apache.org/job/PreCommit-HBASE-Build/545/testReport/org.apache.hadoop.hbase.snapshot/TestExportSnapshotNoCluster/testSnapshotWithRefsExportFileSystemState/],
> and
> [556|https://builds.apache.org/job/PreCommit-HBASE-Build/556/testReport/org.apache.hadoop.hbase.snapshot/TestExportSnapshotNoCluster/testSnapshotWithRefsExportFileSystemState/].
> So one sample exception is like:
> {quote}
> at
> org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invoke(RetryInvocationHandler.java:155)
> at
> org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeOnce(RetryInvocationHandler.java:95)
> at
> org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:346)
> at com.sun.proxy.$Proxy20.getListing(Unknown Source)
> at org.apache.hadoop.hdfs.DFSClient.listPaths(DFSClient.java:1630)
> at org.apache.hadoop.hdfs.DFSClient.listPaths(DFSClient.java:1614)
> at
> org.apache.hadoop.hdfs.DistributedFileSystem.listStatusInternal(DistributedFileSystem.java:900)
> at
> org.apache.hadoop.hdfs.DistributedFileSystem.access$600(DistributedFileSystem.java:114)
> at
> org.apache.hadoop.hdfs.DistributedFileSystem$22.doCall(DistributedFileSystem.java:964)
> at
> org.apache.hadoop.hdfs.DistributedFileSystem$22.doCall(DistributedFileSystem.java:961)
> at
> org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81)
> at
> org.apache.hadoop.hdfs.DistributedFileSystem.listStatus(DistributedFileSystem.java:961)
> at org.apache.hadoop.fs.FileSystem.listStatus(FileSystem.java:1537)
> at org.apache.hadoop.fs.FileSystem.listStatus(FileSystem.java:1580)
> at
> org.apache.hadoop.hbase.util.CommonFSUtils.listStatus(CommonFSUtils.java:693)
> at
> org.apache.hadoop.hbase.util.FSTableDescriptors.getCurrentTableInfoStatus(FSTableDescriptors.java:448)
> at
> org.apache.hadoop.hbase.util.FSTableDescriptors.getTableInfoPath(FSTableDescriptors.java:429)
> at
> org.apache.hadoop.hbase.util.FSTableDescriptors.getTableInfoPath(FSTableDescriptors.java:410)
> at
> org.apache.hadoop.hbase.util.FSTableDescriptors.createTableDescriptorForTableDirectory(FSTableDescriptors.java:763)
> at
> org.apache.hadoop.hbase.snapshot.SnapshotTestingUtils$SnapshotMock.createTable(SnapshotTestingUtils.java:675)
> at
> org.apache.hadoop.hbase.snapshot.SnapshotTestingUtils$SnapshotMock.createSnapshot(SnapshotTestingUtils.java:653)
> at
> org.apache.hadoop.hbase.snapshot.SnapshotTestingUtils$SnapshotMock.createSnapshot(SnapshotTestingUtils.java:647)
> at
>
[jira] [Updated] (HBASE-23322) [hbck2] Simplification on HBCKSCP scheduling
[ https://issues.apache.org/jira/browse/HBASE-23322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-23322: -- Fix Version/s: 2.2.3 2.3.0 3.0.0 Hadoop Flags: Reviewed Release Note: An hbck2 scheduleRecoveries will run a subclass of ServerCrashProcedure which asks Master what Regions were on the dead Server but it will also do a hbase:meta table scan to see if any vestiges of the old Server remain (for the case where an SCP failed mid-point leaving references in place or where Master and hbase:meta deviated in accounting). Resolution: Fixed Status: Resolved (was: Patch Available) Merged manually to branch-2.2+. Thanks for review [~binlijin] > [hbck2] Simplification on HBCKSCP scheduling > > > Key: HBASE-23322 > URL: https://issues.apache.org/jira/browse/HBASE-23322 > Project: HBase > Issue Type: Sub-task > Components: hbck2 >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Minor > Fix For: 3.0.0, 2.3.0, 2.2.3 > > Attachments: > 0001-HBASE-23322-hbck2-Simplification-on-HBCKSCP-scheduli.patch > > > I can make the scheduling of HBCKSCP simpler. I can also fix a bug in parent > issue that I notice after exercising it a bunch on a cluster. > The bug is that 'Unknown Servers' seem to be retained in the Map of reporting > servers. They are usually cleared just before an SCP is scheduled but > scheduling HBCKSCP doesn't go the usual route. > The patch here forces HBCKSCP via the usual SCP route only at the scheduling > time, context dictates whether SCP or the scouring HBCKSCP. > Let me put up a patch and will test in meantime. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] saintstack closed pull request #855: HBASE-23322 [hbck2] Simplification on HBCKSCP scheduling
saintstack closed pull request #855: HBASE-23322 [hbck2] Simplification on HBCKSCP scheduling URL: https://github.com/apache/hbase/pull/855 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack commented on issue #855: HBASE-23322 [hbck2] Simplification on HBCKSCP scheduling
saintstack commented on issue #855: HBASE-23322 [hbck2] Simplification on HBCKSCP scheduling URL: https://github.com/apache/hbase/pull/855#issuecomment-556926362 Pushed manually after fixing the checkstyle complaint. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #785: HBASE-23239 Reporting on status of backing MOB files from client-facing cells
Apache-HBase commented on issue #785: HBASE-23239 Reporting on status of backing MOB files from client-facing cells URL: https://github.com/apache/hbase/pull/785#issuecomment-556916619 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 34s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 48s | master passed | | +1 :green_heart: | compile | 1m 25s | master passed | | +1 :green_heart: | checkstyle | 1m 46s | master passed | | +1 :green_heart: | shadedjars | 5m 6s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 52s | master passed | | +0 :ok: | spotbugs | 4m 31s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 5m 20s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 32s | the patch passed | | +1 :green_heart: | compile | 1m 25s | the patch passed | | +1 :green_heart: | javac | 1m 25s | the patch passed | | -1 :x: | checkstyle | 0m 19s | hbase-mapreduce: The patch generated 2 new + 1 unchanged - 0 fixed = 3 total (was 1) | | -1 :x: | whitespace | 0m 0s | The patch 2 line(s) with tabs. | | +1 :green_heart: | shadedjars | 5m 3s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 17m 26s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 0m 57s | the patch passed | | +1 :green_heart: | findbugs | 6m 26s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 241m 41s | hbase-server in the patch passed. | | -1 :x: | unit | 27m 25s | hbase-mapreduce in the patch failed. | | +1 :green_heart: | asflicense | 1m 13s | The patch does not generate ASF License warnings. | | | | 338m 25s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.snapshot.TestExportSnapshot | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-785/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/785 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 84f75a1b8661 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-785/out/precommit/personality/provided.sh | | git revision | master / 834ccb4bf6 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-785/3/artifact/out/diff-checkstyle-hbase-mapreduce.txt | | whitespace | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-785/3/artifact/out/whitespace-tabs.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-785/3/artifact/out/patch-unit-hbase-mapreduce.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-785/3/testReport/ | | Max. process+thread count | 5357 (vs. ulimit of 1) | | modules | C: hbase-server hbase-mapreduce U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-785/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23055) Alter hbase:meta
[ https://issues.apache.org/jira/browse/HBASE-23055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978965#comment-16978965 ] Michael Stack commented on HBASE-23055: --- Ran a loading comparing current against a meta that had DATA_BLOCK_ENCODING => 'ROW_INDEX_V1' enabled and the latter can do maybe more throughput -- maybe 30-50% more throughput on meta table. > Alter hbase:meta > > > Key: HBASE-23055 > URL: https://issues.apache.org/jira/browse/HBASE-23055 > Project: HBase > Issue Type: Task >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Fix For: 3.0.0 > > > hbase:meta is currently hardcoded. Its schema cannot be change. > This issue is about allowing edits to hbase:meta schema. It will allow our > being able to set encodings such as the block-with-indexes which will help > quell CPU usage on host carrying hbase:meta. A dynamic hbase:meta is first > step on road to being able to split meta. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-22607) TestExportSnapshotNoCluster::testSnapshotWithRefsExportFileSystemState() fails intermittently
[
https://issues.apache.org/jira/browse/HBASE-22607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978927#comment-16978927
]
Hudson commented on HBASE-22607:
Results for branch branch-2
[build #2360 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2360/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2360//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2360//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2360//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> TestExportSnapshotNoCluster::testSnapshotWithRefsExportFileSystemState()
> fails intermittently
> -
>
> Key: HBASE-22607
> URL: https://issues.apache.org/jira/browse/HBASE-22607
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0, 2.2.0, 2.0.6
>Reporter: Mingliang Liu
>Assignee: Mingliang Liu
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.3, 2.1.9
>
> Attachments: HBASE-22607.000.patch, HBASE-22607.001.patch,
> HBASE-22607.002.patch
>
>
> In previous runs, test
> {{TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState}}
> fails intermittently with {{java.net.ConnectException: Connection refused}}
> exception, see build
> [510|https://builds.apache.org/job/PreCommit-HBASE-Build/510/testReport/org.apache.hadoop.hbase.snapshot/TestExportSnapshotNoCluster/testSnapshotWithRefsExportFileSystemState/],
>
> [545|https://builds.apache.org/job/PreCommit-HBASE-Build/545/testReport/org.apache.hadoop.hbase.snapshot/TestExportSnapshotNoCluster/testSnapshotWithRefsExportFileSystemState/],
> and
> [556|https://builds.apache.org/job/PreCommit-HBASE-Build/556/testReport/org.apache.hadoop.hbase.snapshot/TestExportSnapshotNoCluster/testSnapshotWithRefsExportFileSystemState/].
> So one sample exception is like:
> {quote}
> at
> org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invoke(RetryInvocationHandler.java:155)
> at
> org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeOnce(RetryInvocationHandler.java:95)
> at
> org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:346)
> at com.sun.proxy.$Proxy20.getListing(Unknown Source)
> at org.apache.hadoop.hdfs.DFSClient.listPaths(DFSClient.java:1630)
> at org.apache.hadoop.hdfs.DFSClient.listPaths(DFSClient.java:1614)
> at
> org.apache.hadoop.hdfs.DistributedFileSystem.listStatusInternal(DistributedFileSystem.java:900)
> at
> org.apache.hadoop.hdfs.DistributedFileSystem.access$600(DistributedFileSystem.java:114)
> at
> org.apache.hadoop.hdfs.DistributedFileSystem$22.doCall(DistributedFileSystem.java:964)
> at
> org.apache.hadoop.hdfs.DistributedFileSystem$22.doCall(DistributedFileSystem.java:961)
> at
> org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81)
> at
> org.apache.hadoop.hdfs.DistributedFileSystem.listStatus(DistributedFileSystem.java:961)
> at org.apache.hadoop.fs.FileSystem.listStatus(FileSystem.java:1537)
> at org.apache.hadoop.fs.FileSystem.listStatus(FileSystem.java:1580)
> at
> org.apache.hadoop.hbase.util.CommonFSUtils.listStatus(CommonFSUtils.java:693)
> at
> org.apache.hadoop.hbase.util.FSTableDescriptors.getCurrentTableInfoStatus(FSTableDescriptors.java:448)
> at
> org.apache.hadoop.hbase.util.FSTableDescriptors.getTableInfoPath(FSTableDescriptors.java:429)
> at
> org.apache.hadoop.hbase.util.FSTableDescriptors.getTableInfoPath(FSTableDescriptors.java:410)
> at
> org.apache.hadoop.hbase.util.FSTableDescriptors.createTableDescriptorForTableDirectory(FSTableDescriptors.java:763)
> at
> org.apache.hadoop.hbase.snapshot.SnapshotTestingUtils$SnapshotMock.createTable(SnapshotTestingUtils.java:675)
> at
> org.apache.hadoop.hbase.snapshot.SnapshotTestingUtils$SnapshotMock.createSnapshot(SnapshotTestingUtils.java:653)
> at
> org.apache.hadoop.hbase.snapshot.SnapshotTestingUtils$SnapshotMock.createSnapshot(SnapshotTestingUtils.java:647)
> at
> org.apache.hadoop.hbase.snapshot.SnapshotTestingUtils$SnapshotMock.createSnapshotV2(SnapshotTestingUtils.java:637)
[jira] [Commented] (HBASE-23321) [hbck2] fixHoles of fixMeta doesn't update in-memory state
[
https://issues.apache.org/jira/browse/HBASE-23321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978928#comment-16978928
]
Hudson commented on HBASE-23321:
Results for branch branch-2
[build #2360 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2360/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2360//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2360//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2360//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [hbck2] fixHoles of fixMeta doesn't update in-memory state
> --
>
> Key: HBASE-23321
> URL: https://issues.apache.org/jira/browse/HBASE-23321
> Project: HBase
> Issue Type: Improvement
> Components: hbck2
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.2.3
>
>
> If hbase:meta has holes, you can run fixMeta from hbck2. This will close the
> holes but you have to restart the Master for it to notice the new region
> additions. Also, we were plugging holes by adding regions but no state for
> the region which makes it awkward to subsequently assign. Fix.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #858: HBASE-23259: Populate master address end points in cluster/rs configs…
Apache-HBase commented on issue #858: HBASE-23259: Populate master address end points in cluster/rs configs… URL: https://github.com/apache/hbase/pull/858#issuecomment-556880241 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 31s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ branch-1 Compile Tests _ | | +0 :ok: | mvndep | 1m 27s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 8m 0s | branch-1 passed | | +1 :green_heart: | compile | 0m 58s | branch-1 passed with JDK v1.8.0_232 | | +1 :green_heart: | compile | 1m 8s | branch-1 passed with JDK v1.7.0_242 | | +1 :green_heart: | checkstyle | 2m 1s | branch-1 passed | | +1 :green_heart: | shadedjars | 2m 52s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 51s | branch-1 passed with JDK v1.8.0_232 | | +1 :green_heart: | javadoc | 1m 3s | branch-1 passed with JDK v1.7.0_242 | | +0 :ok: | spotbugs | 2m 42s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 3m 47s | branch-1 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 1m 59s | the patch passed | | +1 :green_heart: | compile | 0m 58s | the patch passed with JDK v1.8.0_232 | | +1 :green_heart: | javac | 0m 58s | the patch passed | | +1 :green_heart: | compile | 1m 6s | the patch passed with JDK v1.7.0_242 | | +1 :green_heart: | javac | 1m 6s | the patch passed | | -1 :x: | checkstyle | 1m 33s | hbase-server: The patch generated 1 new + 29 unchanged - 1 fixed = 30 total (was 30) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 2m 46s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 5m 11s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | +1 :green_heart: | javadoc | 0m 49s | the patch passed with JDK v1.8.0_232 | | +1 :green_heart: | javadoc | 1m 3s | the patch passed with JDK v1.7.0_242 | | +1 :green_heart: | findbugs | 4m 3s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 36s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 151m 5s | hbase-server in the patch passed. | | +1 :green_heart: | asflicense | 0m 57s | The patch does not generate ASF License warnings. | | | | 202m 37s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-858/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/858 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 09c87676b898 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-858/out/precommit/personality/provided.sh | | git revision | branch-1 / eee337f | | Default Java | 1.7.0_242 | | Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-858/2/artifact/out/diff-checkstyle-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-858/2/testReport/ | | Max. process+thread count | 4465 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-858/2/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this
[jira] [Commented] (HBASE-22607) TestExportSnapshotNoCluster::testSnapshotWithRefsExportFileSystemState() fails intermittently
[
https://issues.apache.org/jira/browse/HBASE-22607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978882#comment-16978882
]
Hudson commented on HBASE-22607:
Results for branch branch-2.2
[build #699 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/699/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/699//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/699//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/699//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> TestExportSnapshotNoCluster::testSnapshotWithRefsExportFileSystemState()
> fails intermittently
> -
>
> Key: HBASE-22607
> URL: https://issues.apache.org/jira/browse/HBASE-22607
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0, 2.2.0, 2.0.6
>Reporter: Mingliang Liu
>Assignee: Mingliang Liu
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.3, 2.1.9
>
> Attachments: HBASE-22607.000.patch, HBASE-22607.001.patch,
> HBASE-22607.002.patch
>
>
> In previous runs, test
> {{TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState}}
> fails intermittently with {{java.net.ConnectException: Connection refused}}
> exception, see build
> [510|https://builds.apache.org/job/PreCommit-HBASE-Build/510/testReport/org.apache.hadoop.hbase.snapshot/TestExportSnapshotNoCluster/testSnapshotWithRefsExportFileSystemState/],
>
> [545|https://builds.apache.org/job/PreCommit-HBASE-Build/545/testReport/org.apache.hadoop.hbase.snapshot/TestExportSnapshotNoCluster/testSnapshotWithRefsExportFileSystemState/],
> and
> [556|https://builds.apache.org/job/PreCommit-HBASE-Build/556/testReport/org.apache.hadoop.hbase.snapshot/TestExportSnapshotNoCluster/testSnapshotWithRefsExportFileSystemState/].
> So one sample exception is like:
> {quote}
> at
> org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invoke(RetryInvocationHandler.java:155)
> at
> org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeOnce(RetryInvocationHandler.java:95)
> at
> org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:346)
> at com.sun.proxy.$Proxy20.getListing(Unknown Source)
> at org.apache.hadoop.hdfs.DFSClient.listPaths(DFSClient.java:1630)
> at org.apache.hadoop.hdfs.DFSClient.listPaths(DFSClient.java:1614)
> at
> org.apache.hadoop.hdfs.DistributedFileSystem.listStatusInternal(DistributedFileSystem.java:900)
> at
> org.apache.hadoop.hdfs.DistributedFileSystem.access$600(DistributedFileSystem.java:114)
> at
> org.apache.hadoop.hdfs.DistributedFileSystem$22.doCall(DistributedFileSystem.java:964)
> at
> org.apache.hadoop.hdfs.DistributedFileSystem$22.doCall(DistributedFileSystem.java:961)
> at
> org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81)
> at
> org.apache.hadoop.hdfs.DistributedFileSystem.listStatus(DistributedFileSystem.java:961)
> at org.apache.hadoop.fs.FileSystem.listStatus(FileSystem.java:1537)
> at org.apache.hadoop.fs.FileSystem.listStatus(FileSystem.java:1580)
> at
> org.apache.hadoop.hbase.util.CommonFSUtils.listStatus(CommonFSUtils.java:693)
> at
> org.apache.hadoop.hbase.util.FSTableDescriptors.getCurrentTableInfoStatus(FSTableDescriptors.java:448)
> at
> org.apache.hadoop.hbase.util.FSTableDescriptors.getTableInfoPath(FSTableDescriptors.java:429)
> at
> org.apache.hadoop.hbase.util.FSTableDescriptors.getTableInfoPath(FSTableDescriptors.java:410)
> at
> org.apache.hadoop.hbase.util.FSTableDescriptors.createTableDescriptorForTableDirectory(FSTableDescriptors.java:763)
> at
> org.apache.hadoop.hbase.snapshot.SnapshotTestingUtils$SnapshotMock.createTable(SnapshotTestingUtils.java:675)
> at
> org.apache.hadoop.hbase.snapshot.SnapshotTestingUtils$SnapshotMock.createSnapshot(SnapshotTestingUtils.java:653)
> at
> org.apache.hadoop.hbase.snapshot.SnapshotTestingUtils$SnapshotMock.createSnapshot(SnapshotTestingUtils.java:647)
> at
>
[jira] [Commented] (HBASE-23321) [hbck2] fixHoles of fixMeta doesn't update in-memory state
[
https://issues.apache.org/jira/browse/HBASE-23321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978883#comment-16978883
]
Hudson commented on HBASE-23321:
Results for branch branch-2.2
[build #699 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/699/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/699//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/699//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/699//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [hbck2] fixHoles of fixMeta doesn't update in-memory state
> --
>
> Key: HBASE-23321
> URL: https://issues.apache.org/jira/browse/HBASE-23321
> Project: HBase
> Issue Type: Improvement
> Components: hbck2
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.2.3
>
>
> If hbase:meta has holes, you can run fixMeta from hbck2. This will close the
> holes but you have to restart the Master for it to notice the new region
> additions. Also, we were plugging holes by adding regions but no state for
> the region which makes it awkward to subsequently assign. Fix.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #740: HBASE-23197 'IllegalArgumentException: Wrong FS' on edits replay when…
Apache-HBase commented on issue #740: HBASE-23197 'IllegalArgumentException: Wrong FS' on edits replay when… URL: https://github.com/apache/hbase/pull/740#issuecomment-556763054 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 57s | master passed | | +1 :green_heart: | compile | 0m 58s | master passed | | +1 :green_heart: | checkstyle | 1m 35s | master passed | | +1 :green_heart: | shadedjars | 4m 59s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | master passed | | +0 :ok: | spotbugs | 4m 28s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 4m 26s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 29s | the patch passed | | +1 :green_heart: | compile | 0m 59s | the patch passed | | +1 :green_heart: | javac | 0m 59s | the patch passed | | -1 :x: | checkstyle | 1m 34s | hbase-server: The patch generated 8 new + 290 unchanged - 0 fixed = 298 total (was 290) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 4m 59s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 17m 11s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 0m 35s | the patch passed | | +1 :green_heart: | findbugs | 4m 45s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 253m 46s | hbase-server in the patch failed. | | +1 :green_heart: | asflicense | 0m 40s | The patch does not generate ASF License warnings. | | | | 316m 28s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.TestAssignmentManagerMetrics | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-740/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/740 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 503ad7905df5 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-740/out/precommit/personality/provided.sh | | git revision | master / 834ccb4bf6 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-740/4/artifact/out/diff-checkstyle-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-740/4/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-740/4/testReport/ | | Max. process+thread count | 5110 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-740/4/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23189) Finalize I/O optimized MOB compaction
[ https://issues.apache.org/jira/browse/HBASE-23189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978874#comment-16978874 ] Vladimir Rodionov commented on HBASE-23189: --- Pushed first implementation to parent's PR branch. > Finalize I/O optimized MOB compaction > - > > Key: HBASE-23189 > URL: https://issues.apache.org/jira/browse/HBASE-23189 > Project: HBase > Issue Type: Sub-task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Major > > +corresponding test cases > The current code for I/O optimized compaction has not been tested and > verified yet. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23189) Finalize I/O optimized MOB compaction
[ https://issues.apache.org/jira/browse/HBASE-23189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Rodionov updated HBASE-23189: -- Description: +corresponding test cases The current code for I/O optimized compaction has not been tested and verified yet. was: +corresponding test cases The current code for generational compaction has not been tested and verified yet. > Finalize I/O optimized MOB compaction > - > > Key: HBASE-23189 > URL: https://issues.apache.org/jira/browse/HBASE-23189 > Project: HBase > Issue Type: Sub-task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Major > > +corresponding test cases > The current code for I/O optimized compaction has not been tested and > verified yet. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23189) Finalize I/O optimized MOB compaction
[ https://issues.apache.org/jira/browse/HBASE-23189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Rodionov updated HBASE-23189: -- Summary: Finalize I/O optimized MOB compaction (was: Finalize generational compaction) > Finalize I/O optimized MOB compaction > - > > Key: HBASE-23189 > URL: https://issues.apache.org/jira/browse/HBASE-23189 > Project: HBase > Issue Type: Sub-task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Major > > +corresponding test cases > The current code for generational compaction has not been tested and verified > yet. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-21776) Duplicate "Set storagePolicy" debug logging
[ https://issues.apache.org/jira/browse/HBASE-21776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Pal updated HBASE-21776: Attachment: (was: HBASE-21776-branch-1.patch) > Duplicate "Set storagePolicy" debug logging > --- > > Key: HBASE-21776 > URL: https://issues.apache.org/jira/browse/HBASE-21776 > Project: HBase > Issue Type: Bug > Components: Compaction >Affects Versions: 1.5.0 >Reporter: Andrew Kyle Purtell >Assignee: Sandeep Pal >Priority: Trivial > Labels: branch-1 > Fix For: 1.6.0 > > Attachments: HBASE-21776-branch-1.001.patch > > > An example: > 2019-01-25 02:57:15,831 DEBUG > [regionserver/ip-172-31-13-83.us-west-2.compute.internal/172.31.13.83:8120-longCompactions-1548384634805] > util.CommonFSUtils: Set storagePolicy=HOT for > path=hdfs://ip-172-31-5-95.us-west-2.compute.internal:8020/hbase/data/default/IntegrationTestBigLinkedList/16899cdfdb4ab217208f4108ad0c4803/.tmp/meta > 2019-01-25 02:57:15,831 DEBUG > [regionserver/ip-172-31-13-83.us-west-2.compute.internal/172.31.13.83:8120-longCompactions-1548384634805] > util.CommonFSUtils: Set storagePolicy=HOT for > path=hdfs://ip-172-31-5-95.us-west-2.compute.internal:8020/hbase/data/default/IntegrationTestBigLinkedList/16899cdfdb4ab217208f4108ad0c4803/.tmp/meta > Seen most often during compactions. Ideally we only log once per directory > per flush or compaction. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-21776) Duplicate "Set storagePolicy" debug logging
[ https://issues.apache.org/jira/browse/HBASE-21776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Pal updated HBASE-21776: Attachment: HBASE-21776-branch-1.001.patch > Duplicate "Set storagePolicy" debug logging > --- > > Key: HBASE-21776 > URL: https://issues.apache.org/jira/browse/HBASE-21776 > Project: HBase > Issue Type: Bug > Components: Compaction >Affects Versions: 1.5.0 >Reporter: Andrew Kyle Purtell >Assignee: Sandeep Pal >Priority: Trivial > Labels: branch-1 > Fix For: 1.6.0 > > Attachments: HBASE-21776-branch-1.001.patch > > > An example: > 2019-01-25 02:57:15,831 DEBUG > [regionserver/ip-172-31-13-83.us-west-2.compute.internal/172.31.13.83:8120-longCompactions-1548384634805] > util.CommonFSUtils: Set storagePolicy=HOT for > path=hdfs://ip-172-31-5-95.us-west-2.compute.internal:8020/hbase/data/default/IntegrationTestBigLinkedList/16899cdfdb4ab217208f4108ad0c4803/.tmp/meta > 2019-01-25 02:57:15,831 DEBUG > [regionserver/ip-172-31-13-83.us-west-2.compute.internal/172.31.13.83:8120-longCompactions-1548384634805] > util.CommonFSUtils: Set storagePolicy=HOT for > path=hdfs://ip-172-31-5-95.us-west-2.compute.internal:8020/hbase/data/default/IntegrationTestBigLinkedList/16899cdfdb4ab217208f4108ad0c4803/.tmp/meta > Seen most often during compactions. Ideally we only log once per directory > per flush or compaction. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-21776) Duplicate "Set storagePolicy" debug logging
[ https://issues.apache.org/jira/browse/HBASE-21776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Pal updated HBASE-21776: Attachment: (was: HBASE-21776-branch-1.patch) > Duplicate "Set storagePolicy" debug logging > --- > > Key: HBASE-21776 > URL: https://issues.apache.org/jira/browse/HBASE-21776 > Project: HBase > Issue Type: Bug > Components: Compaction >Affects Versions: 1.5.0 >Reporter: Andrew Kyle Purtell >Assignee: Sandeep Pal >Priority: Trivial > Labels: branch-1 > Fix For: 1.6.0 > > Attachments: HBASE-21776-branch-1.patch > > > An example: > 2019-01-25 02:57:15,831 DEBUG > [regionserver/ip-172-31-13-83.us-west-2.compute.internal/172.31.13.83:8120-longCompactions-1548384634805] > util.CommonFSUtils: Set storagePolicy=HOT for > path=hdfs://ip-172-31-5-95.us-west-2.compute.internal:8020/hbase/data/default/IntegrationTestBigLinkedList/16899cdfdb4ab217208f4108ad0c4803/.tmp/meta > 2019-01-25 02:57:15,831 DEBUG > [regionserver/ip-172-31-13-83.us-west-2.compute.internal/172.31.13.83:8120-longCompactions-1548384634805] > util.CommonFSUtils: Set storagePolicy=HOT for > path=hdfs://ip-172-31-5-95.us-west-2.compute.internal:8020/hbase/data/default/IntegrationTestBigLinkedList/16899cdfdb4ab217208f4108ad0c4803/.tmp/meta > Seen most often during compactions. Ideally we only log once per directory > per flush or compaction. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-21776) Duplicate "Set storagePolicy" debug logging
[ https://issues.apache.org/jira/browse/HBASE-21776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Pal updated HBASE-21776: Attachment: HBASE-21776-branch-1.patch > Duplicate "Set storagePolicy" debug logging > --- > > Key: HBASE-21776 > URL: https://issues.apache.org/jira/browse/HBASE-21776 > Project: HBase > Issue Type: Bug > Components: Compaction >Affects Versions: 1.5.0 >Reporter: Andrew Kyle Purtell >Assignee: Sandeep Pal >Priority: Trivial > Labels: branch-1 > Fix For: 1.6.0 > > Attachments: HBASE-21776-branch-1.patch > > > An example: > 2019-01-25 02:57:15,831 DEBUG > [regionserver/ip-172-31-13-83.us-west-2.compute.internal/172.31.13.83:8120-longCompactions-1548384634805] > util.CommonFSUtils: Set storagePolicy=HOT for > path=hdfs://ip-172-31-5-95.us-west-2.compute.internal:8020/hbase/data/default/IntegrationTestBigLinkedList/16899cdfdb4ab217208f4108ad0c4803/.tmp/meta > 2019-01-25 02:57:15,831 DEBUG > [regionserver/ip-172-31-13-83.us-west-2.compute.internal/172.31.13.83:8120-longCompactions-1548384634805] > util.CommonFSUtils: Set storagePolicy=HOT for > path=hdfs://ip-172-31-5-95.us-west-2.compute.internal:8020/hbase/data/default/IntegrationTestBigLinkedList/16899cdfdb4ab217208f4108ad0c4803/.tmp/meta > Seen most often during compactions. Ideally we only log once per directory > per flush or compaction. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] joshelser commented on a change in pull request #740: HBASE-23197 'IllegalArgumentException: Wrong FS' on edits replay when…
joshelser commented on a change in pull request #740: HBASE-23197
'IllegalArgumentException: Wrong FS' on edits replay when…
URL: https://github.com/apache/hbase/pull/740#discussion_r348822168
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/backup/HFileArchiver.java
##
@@ -295,8 +297,49 @@ public static void archiveFamilyByFamilyDir(FileSystem
fs, Configuration conf,
*/
public static void archiveStoreFiles(Configuration conf, FileSystem fs,
RegionInfo regionInfo,
Path tableDir, byte[] family, Collection compactedFiles)
- throws IOException, FailedArchiveException {
+ throws IOException {
+Path storeArchiveDir = HFileArchiveUtil.getStoreArchivePath(conf,
regionInfo, tableDir, family);
+archive(fs, regionInfo, family, compactedFiles, storeArchiveDir);
+ }
+
+ /**
+ * Archive recovered edits using existing logic for archiving store files.
This is currently only
+ * relevant when hbase.region.archive.recovered.edits is true, as
recovered edits shouldn't
+ * be kept after replay. In theory, we could use very same method available
for archiving
+ * store files, but supporting WAL dir and store files on different
FileSystems added the need for
+ * extra validation of the passed FileSystem instance and the path where the
archiving edits
+ * should be placed.
+ * @param conf {@link Configuration} to determine the archive directory.
+ * @param fs the filesystem used for storing WAL files.
+ * @param regionInfo {@link RegionInfo} a pseudo region representation for
the archiving logic.
+ * @param family a pseudo familiy representation for the archiving logic.
+ * @param replayedEdits the recovered edits to be archived.
+ * @throws IOException if files can't be achived due to some internal error.
+ */
+ public static void archiveRecoveredEdits(Configuration conf, FileSystem fs,
RegionInfo regionInfo,
+byte[] family, Collection replayedEdits)
+throws IOException {
+String workingDir = conf.get(CommonFSUtils.HBASE_WAL_DIR);
Review comment:
Could consolidate to `conf.get(CommonFSUtils.HBASE_WAL_DIR,
conf.get(HConstants.HBASE_DIR))`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-21776) Duplicate "Set storagePolicy" debug logging
[
https://issues.apache.org/jira/browse/HBASE-21776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978821#comment-16978821
]
HBase QA commented on HBASE-21776:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 10m
32s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m
27s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
39s{color} | {color:green} branch-1 passed with JDK v1.8.0_232 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
46s{color} | {color:green} branch-1 passed with JDK v1.7.0_242 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
34s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
52s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
37s{color} | {color:green} branch-1 passed with JDK v1.8.0_232 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
40s{color} | {color:green} branch-1 passed with JDK v1.7.0_242 {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 2m
50s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
47s{color} | {color:green} branch-1 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
40s{color} | {color:green} the patch passed with JDK v1.8.0_232 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
44s{color} | {color:green} the patch passed with JDK v1.7.0_242 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
31s{color} | {color:red} hbase-server: The patch generated 1 new + 47 unchanged
- 0 fixed = 48 total (was 47) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
50s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
5m 5s{color} | {color:green} Patch does not cause any errors with Hadoop 2.8.5
2.9.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} the patch passed with JDK v1.8.0_232 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
41s{color} | {color:green} the patch passed with JDK v1.7.0_242 {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
50s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}124m 19s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
35s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color}
[GitHub] [hbase] Apache-HBase commented on issue #856: HBASE-21776: Duplicate "Set storagePolicy" debug logging
Apache-HBase commented on issue #856: HBASE-21776: Duplicate "Set storagePolicy" debug logging URL: https://github.com/apache/hbase/pull/856#issuecomment-556551543 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 10m 32s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-1 Compile Tests _ | | +1 :green_heart: | mvninstall | 9m 27s | branch-1 passed | | +1 :green_heart: | compile | 0m 39s | branch-1 passed with JDK v1.8.0_232 | | +1 :green_heart: | compile | 0m 46s | branch-1 passed with JDK v1.7.0_242 | | +1 :green_heart: | checkstyle | 1m 34s | branch-1 passed | | +1 :green_heart: | shadedjars | 2m 52s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | branch-1 passed with JDK v1.8.0_232 | | +1 :green_heart: | javadoc | 0m 40s | branch-1 passed with JDK v1.7.0_242 | | +0 :ok: | spotbugs | 2m 50s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 2m 47s | branch-1 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 1m 59s | the patch passed | | +1 :green_heart: | compile | 0m 40s | the patch passed with JDK v1.8.0_232 | | +1 :green_heart: | javac | 0m 40s | the patch passed | | +1 :green_heart: | compile | 0m 44s | the patch passed with JDK v1.7.0_242 | | +1 :green_heart: | javac | 0m 44s | the patch passed | | -1 :x: | checkstyle | 1m 31s | hbase-server: The patch generated 1 new + 47 unchanged - 0 fixed = 48 total (was 47) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 2m 50s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 5m 5s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | +1 :green_heart: | javadoc | 0m 31s | the patch passed with JDK v1.8.0_232 | | +1 :green_heart: | javadoc | 0m 41s | the patch passed with JDK v1.7.0_242 | | +1 :green_heart: | findbugs | 2m 50s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 124m 19s | hbase-server in the patch failed. | | +1 :green_heart: | asflicense | 0m 35s | The patch does not generate ASF License warnings. | | | | 175m 12s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint | | | hadoop.hbase.TestClusterPortAssignment | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-856/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/856 | | JIRA Issue | HBASE-21776 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux f7ef11ab5fc0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-856/out/precommit/personality/provided.sh | | git revision | branch-1 / eee337f | | Default Java | 1.7.0_242 | | Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-856/2/artifact/out/diff-checkstyle-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-856/2/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-856/2/testReport/ | | Max. process+thread count | 4109 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-856/2/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated.
[GitHub] [hbase] bharathv commented on issue #858: HBASE-23259: Populate master address end points in cluster/rs configs…
bharathv commented on issue #858: HBASE-23259: Populate master address end points in cluster/rs configs… URL: https://github.com/apache/hbase/pull/858#issuecomment-556533101 Ah String.join() not in jdk7. Will force push shortly. Sorry for the noise. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-23287) WALs not aged off of HDFS because LogCleaner is not added to choreService
[
https://issues.apache.org/jira/browse/HBASE-23287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-23287:
Affects Version/s: 1.5.0
> WALs not aged off of HDFS because LogCleaner is not added to choreService
> -
>
> Key: HBASE-23287
> URL: https://issues.apache.org/jira/browse/HBASE-23287
> Project: HBase
> Issue Type: Bug
> Components: wal
>Affects Versions: 1.5.0, 1.6.0, 1.4.11
>Reporter: Baiqiang Zhao
>Assignee: Baiqiang Zhao
>Priority: Blocker
> Fix For: 1.6.0, 1.4.12
>
> Attachments: HBASE-23287.branch-1.0001.patch
>
>
> We found /hbase/oldWALs keeps growing, and we never use replication feature.
> Then we found OldWALsCleaner thread is always in WAITTING state :
> {code:java}
> Thread 176 (OldWALsCleaner-1): State: WAITING Blocked count: 0 Waited count:
> 1 Waiting on
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject@2ef05d36
> Stack: sun.misc.Unsafe.park(Native Method)
> java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039)
> java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442)
> org.apache.hadoop.hbase.master.cleaner.LogCleaner.deleteFile(LogCleaner.java:185)
>
> org.apache.hadoop.hbase.master.cleaner.LogCleaner.access$000(LogCleaner.java:48)
> org.apache.hadoop.hbase.master.cleaner.LogCleaner$1.run(LogCleaner.java:161)
> java.lang.Thread.run(Thread.java:745)
> {code}
> Finally, we found that LogCleaner is not added to choreService, so LogCleaner
> doesn't run periodically.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-23287) WALs not aged off of HDFS because LogCleaner is not added to choreService
[
https://issues.apache.org/jira/browse/HBASE-23287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-23287:
Summary: WALs not aged off of HDFS because LogCleaner is not added to
choreService (was: LogCleaner is not added to choreService)
> WALs not aged off of HDFS because LogCleaner is not added to choreService
> -
>
> Key: HBASE-23287
> URL: https://issues.apache.org/jira/browse/HBASE-23287
> Project: HBase
> Issue Type: Bug
> Components: wal
>Affects Versions: 1.6.0, 1.4.11
>Reporter: Baiqiang Zhao
>Assignee: Baiqiang Zhao
>Priority: Blocker
> Fix For: 1.6.0, 1.4.12
>
> Attachments: HBASE-23287.branch-1.0001.patch
>
>
> We found /hbase/oldWALs keeps growing, and we never use replication feature.
> Then we found OldWALsCleaner thread is always in WAITTING state :
> {code:java}
> Thread 176 (OldWALsCleaner-1): State: WAITING Blocked count: 0 Waited count:
> 1 Waiting on
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject@2ef05d36
> Stack: sun.misc.Unsafe.park(Native Method)
> java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039)
> java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442)
> org.apache.hadoop.hbase.master.cleaner.LogCleaner.deleteFile(LogCleaner.java:185)
>
> org.apache.hadoop.hbase.master.cleaner.LogCleaner.access$000(LogCleaner.java:48)
> org.apache.hadoop.hbase.master.cleaner.LogCleaner$1.run(LogCleaner.java:161)
> java.lang.Thread.run(Thread.java:745)
> {code}
> Finally, we found that LogCleaner is not added to choreService, so LogCleaner
> doesn't run periodically.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-23227) Upgrade jackson-databind to 2.9.10.1 to avoid recent CVEs
[ https://issues.apache.org/jira/browse/HBASE-23227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-23227: Summary: Upgrade jackson-databind to 2.9.10.1 to avoid recent CVEs (was: Upgrade jackson-databind to 2.9.10.1) > Upgrade jackson-databind to 2.9.10.1 to avoid recent CVEs > - > > Key: HBASE-23227 > URL: https://issues.apache.org/jira/browse/HBASE-23227 > Project: HBase > Issue Type: Task > Components: dependencies, REST, security >Reporter: Wei-Chiu Chuang >Assignee: Wei-Chiu Chuang >Priority: Blocker > Fix For: 3.0.0, 2.3.0, 1.6.0, 1.4.12, 2.1.8, 2.2.3 > > > Several net new CVEs were raised against jackson-databind 2.9.10. > CVE-2019-16942 > CVE-2019-16943 > 2.9.10.1 is released, which I believe addresses these two CVEs. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23323) Release 1.4.12
[ https://issues.apache.org/jira/browse/HBASE-23323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978811#comment-16978811 ] Sean Busbey commented on HBASE-23323: - git/jira inclusion in 1.4.12 is lined up. > Release 1.4.12 > -- > > Key: HBASE-23323 > URL: https://issues.apache.org/jira/browse/HBASE-23323 > Project: HBase > Issue Type: Improvement > Components: build, community >Affects Versions: 1.4.12 >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Major > Fix For: 1.4.12 > > Attachments: Flaky_report_branch-1.4_build_575.zip > > > it's been about a month and it doesn't seem like we're ready to move the > stable pointer. also we have at least one CVE in branch-1 and the critical > not-cleaning-wals thing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1
[
https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978806#comment-16978806
]
HBase QA commented on HBASE-23279:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
6s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
56s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
10s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 4m
41s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
27s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
27s{color} | {color:green} The patch passed checkstyle in hbase-common {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
33s{color} | {color:green} hbase-client: The patch generated 0 new + 89
unchanged - 2 fixed = 89 total (was 91) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
28s{color} | {color:green} The patch passed checkstyle in hbase-server {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
57s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
17m 3s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
32s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
55s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
42s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}267m 55s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
37s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}343m
[GitHub] [hbase] Apache-HBase commented on issue #855: HBASE-23322 [hbck2] Simplification on HBCKSCP scheduling
Apache-HBase commented on issue #855: HBASE-23322 [hbck2] Simplification on HBCKSCP scheduling URL: https://github.com/apache/hbase/pull/855#issuecomment-556521409 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 22s | branch-2 passed | | +1 :green_heart: | compile | 0m 56s | branch-2 passed | | +1 :green_heart: | checkstyle | 1m 22s | branch-2 passed | | +1 :green_heart: | shadedjars | 4m 8s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | branch-2 passed | | +0 :ok: | spotbugs | 3m 36s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 3m 35s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 48s | the patch passed | | +1 :green_heart: | compile | 0m 56s | the patch passed | | +1 :green_heart: | javac | 0m 56s | the patch passed | | -1 :x: | checkstyle | 1m 19s | hbase-server: The patch generated 2 new + 46 unchanged - 0 fixed = 48 total (was 46) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 4m 10s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 15m 17s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 0m 36s | the patch passed | | +1 :green_heart: | findbugs | 3m 31s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 162m 58s | hbase-server in the patch passed. | | +1 :green_heart: | asflicense | 0m 35s | The patch does not generate ASF License warnings. | | | | 217m 2s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-855/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/855 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 8bf95434916f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-855/out/precommit/personality/provided.sh | | git revision | branch-2 / 7e088daf39 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-855/2/artifact/out/diff-checkstyle-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-855/2/testReport/ | | Max. process+thread count | 4753 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-855/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23323) Release 1.4.12
[
https://issues.apache.org/jira/browse/HBASE-23323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978797#comment-16978797
]
Sean Busbey commented on HBASE-23323:
-
current flaky report for the branch attached. Only problem test looks to be
{{TestSnapshotFromMaster#testAsyncSnapshotWillNotBlockSnapshotHFileCleaner}},
and in branch-1.4 that test assumes taking a snapshot will take less than 11
seconds. looks like we're just taking longer sometimes.
> Release 1.4.12
> --
>
> Key: HBASE-23323
> URL: https://issues.apache.org/jira/browse/HBASE-23323
> Project: HBase
> Issue Type: Improvement
> Components: build, community
>Affects Versions: 1.4.12
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
> Fix For: 1.4.12
>
> Attachments: Flaky_report_branch-1.4_build_575.zip
>
>
> it's been about a month and it doesn't seem like we're ready to move the
> stable pointer. also we have at least one CVE in branch-1 and the critical
> not-cleaning-wals thing.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] busbey commented on issue #785: HBASE-23239 Reporting on status of backing MOB files from client-facing cells
busbey commented on issue #785: HBASE-23239 Reporting on status of backing MOB files from client-facing cells URL: https://github.com/apache/hbase/pull/785#issuecomment-556510248 that push was just rebasing to current master This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-23323) Release 1.4.12
[ https://issues.apache.org/jira/browse/HBASE-23323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-23323: Attachment: Flaky_report_branch-1.4_build_575.zip > Release 1.4.12 > -- > > Key: HBASE-23323 > URL: https://issues.apache.org/jira/browse/HBASE-23323 > Project: HBase > Issue Type: Improvement > Components: build, community >Affects Versions: 1.4.12 >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Major > Fix For: 1.4.12 > > Attachments: Flaky_report_branch-1.4_build_575.zip > > > it's been about a month and it doesn't seem like we're ready to move the > stable pointer. also we have at least one CVE in branch-1 and the critical > not-cleaning-wals thing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23259) Ability to run mini cluster using pre-determined available random ports
[
https://issues.apache.org/jira/browse/HBASE-23259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978789#comment-16978789
]
HBase QA commented on HBASE-23259:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
38s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
18s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
22s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
57s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
46s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
3s{color} | {color:green} branch-2 passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 4m
1s{color} | {color:blue} Used deprecated FindBugs config; considering switching
to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
56s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
28s{color} | {color:green} The patch passed checkstyle in hbase-common {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
21s{color} | {color:green} hbase-server: The patch generated 0 new + 35
unchanged - 1 fixed = 35 total (was 36) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
25s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
15m 28s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
20s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
0s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}167m 35s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
4s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}232m 11s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.5 Server=19.03.5 base:
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-857/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/857 |
| JIRA Issue |
[GitHub] [hbase] Apache-HBase commented on issue #857: HBASE-23259: Populate master address end points in cluster/rs configs
Apache-HBase commented on issue #857: HBASE-23259: Populate master address end points in cluster/rs configs URL: https://github.com/apache/hbase/pull/857#issuecomment-556490230 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 18s | branch-2 passed | | +1 :green_heart: | compile | 1m 22s | branch-2 passed | | +1 :green_heart: | checkstyle | 1m 57s | branch-2 passed | | +1 :green_heart: | shadedjars | 4m 46s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 3s | branch-2 passed | | +0 :ok: | spotbugs | 4m 1s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 4m 56s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 19s | the patch passed | | +1 :green_heart: | compile | 1m 17s | the patch passed | | +1 :green_heart: | javac | 1m 17s | the patch passed | | +1 :green_heart: | checkstyle | 0m 28s | The patch passed checkstyle in hbase-common | | +1 :green_heart: | checkstyle | 1m 21s | hbase-server: The patch generated 0 new + 35 unchanged - 1 fixed = 35 total (was 36) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 4m 25s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 15m 28s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 0m 56s | the patch passed | | +1 :green_heart: | findbugs | 4m 20s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 3m 0s | hbase-common in the patch passed. | | -1 :x: | unit | 167m 35s | hbase-server in the patch failed. | | +1 :green_heart: | asflicense | 1m 4s | The patch does not generate ASF License warnings. | | | | 232m 11s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-857/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/857 | | JIRA Issue | HBASE-23259 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 26b99378b9ea 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-857/out/precommit/personality/provided.sh | | git revision | branch-2 / 7e088daf39 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-857/1/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-857/1/testReport/ | | Max. process+thread count | 4696 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-857/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #858: HBASE-23259: Populate master address end points in cluster/rs configs…
Apache-HBase commented on issue #858: HBASE-23259: Populate master address end points in cluster/rs configs… URL: https://github.com/apache/hbase/pull/858#issuecomment-556473227 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 29m 9s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ branch-1 Compile Tests _ | | +0 :ok: | mvndep | 1m 25s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 8m 8s | branch-1 passed | | +1 :green_heart: | compile | 1m 9s | branch-1 passed with JDK v1.8.0_232 | | +1 :green_heart: | compile | 1m 21s | branch-1 passed with JDK v1.7.0_242 | | +1 :green_heart: | checkstyle | 2m 22s | branch-1 passed | | +1 :green_heart: | shadedjars | 3m 54s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 4s | branch-1 passed with JDK v1.8.0_232 | | +1 :green_heart: | javadoc | 1m 13s | branch-1 passed with JDK v1.7.0_242 | | +0 :ok: | spotbugs | 3m 2s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 4m 16s | branch-1 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 1m 18s | root in the patch failed. | | +1 :green_heart: | compile | 1m 3s | the patch passed with JDK v1.8.0_232 | | +1 :green_heart: | javac | 1m 3s | the patch passed | | -1 :x: | compile | 0m 40s | hbase-server in the patch failed with JDK v1.7.0_242. | | -1 :x: | javac | 0m 40s | hbase-server in the patch failed with JDK v1.7.0_242. | | +1 :green_heart: | checkstyle | 0m 31s | The patch passed checkstyle in hbase-common | | +1 :green_heart: | checkstyle | 1m 48s | hbase-server: The patch generated 0 new + 29 unchanged - 1 fixed = 29 total (was 30) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | -1 :x: | shadedjars | 2m 11s | patch has 16 errors when building our shaded downstream artifacts. | | -1 :x: | hadoopcheck | 1m 20s | The patch causes 16 errors with Hadoop v2.8.5. | | -1 :x: | hadoopcheck | 3m 40s | The patch causes 16 errors with Hadoop v2.9.2. | | +1 :green_heart: | javadoc | 0m 52s | the patch passed with JDK v1.8.0_232 | | +1 :green_heart: | javadoc | 1m 16s | the patch passed with JDK v1.7.0_242 | | -1 :x: | findbugs | 0m 35s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 53s | hbase-common in the patch passed. | | -1 :x: | unit | 0m 40s | hbase-server in the patch failed. | | +1 :green_heart: | asflicense | 0m 25s | The patch does not generate ASF License warnings. | | | | 76m 16s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-858/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/858 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux b4ae25803112 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-858/out/precommit/personality/provided.sh | | git revision | branch-1 / eee337f | | Default Java | 1.7.0_242 | | Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-858/1/artifact/out/patch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-858/1/artifact/out/patch-compile-hbase-server-jdk1.7.0_242.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-858/1/artifact/out/patch-compile-hbase-server-jdk1.7.0_242.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-858/1/artifact/out/patch-shadedjars.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-858/1/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck |
[jira] [Commented] (HBASE-23281) Track meta region changes on masters
[
https://issues.apache.org/jira/browse/HBASE-23281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978778#comment-16978778
]
HBase QA commented on HBASE-23281:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
33s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
1s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
13s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 4m
27s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
5s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
0s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
17m 28s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
46s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
51s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
50s{color} | {color:green} hbase-zookeeper in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}261m 31s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}337m 3s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.5 Server=19.03.5 base:
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-830/6/artifact/out/Dockerfile
|
| GITHUB PR |
[GitHub] [hbase] Apache-HBase commented on issue #830: HBASE-23281: Track meta region locations in masters
Apache-HBase commented on issue #830: HBASE-23281: Track meta region locations in masters URL: https://github.com/apache/hbase/pull/830#issuecomment-556469015 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 11s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 33s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 50s | master passed | | +1 :green_heart: | compile | 1m 42s | master passed | | +1 :green_heart: | checkstyle | 2m 19s | master passed | | +1 :green_heart: | shadedjars | 5m 1s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 13s | master passed | | +0 :ok: | spotbugs | 4m 27s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 6m 5s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 31s | the patch passed | | +1 :green_heart: | compile | 1m 42s | the patch passed | | +1 :green_heart: | javac | 1m 42s | the patch passed | | +1 :green_heart: | checkstyle | 2m 17s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 5m 0s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 17m 28s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 1m 11s | the patch passed | | +1 :green_heart: | findbugs | 6m 46s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 51s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 0m 50s | hbase-zookeeper in the patch passed. | | -1 :x: | unit | 261m 31s | hbase-server in the patch failed. | | +1 :green_heart: | asflicense | 1m 13s | The patch does not generate ASF License warnings. | | | | 337m 3s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-830/6/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/830 | | JIRA Issue | HBASE-23281 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux c6f29395f788 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-830/out/precommit/personality/provided.sh | | git revision | master / 33bedf8d4d | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-830/6/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-830/6/testReport/ | | Max. process+thread count | 4662 (vs. ulimit of 1) | | modules | C: hbase-client hbase-zookeeper hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-830/6/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] bharathv opened a new pull request #858: HBASE-23259: Populate master address end points in cluster/rs configs…
bharathv opened a new pull request #858: HBASE-23259: Populate master address
end points in cluster/rs configs…
URL: https://github.com/apache/hbase/pull/858
… (#807)
All the clients need to know the master RPC end points while using master
based registry for creating cluster connections. This patch amends the
test cluster utility to populate these configs in the base configuration
object used to spin up the cluster.
The config key added here ("hbase.master.addrs") is used in the subsequent
patches for HBASE-18095.
Signed-off-by: Nick Dimiduk
(cherry picked from commit 834ccb4bf6c22fc2a8aab172490fba75c7a40f1c)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Updated] (HBASE-21776) Duplicate "Set storagePolicy" debug logging
[ https://issues.apache.org/jira/browse/HBASE-21776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Pal updated HBASE-21776: Attachment: HBASE-21776-branch-1.patch Status: Patch Available (was: Open) > Duplicate "Set storagePolicy" debug logging > --- > > Key: HBASE-21776 > URL: https://issues.apache.org/jira/browse/HBASE-21776 > Project: HBase > Issue Type: Bug > Components: Compaction >Affects Versions: 1.5.0 >Reporter: Andrew Kyle Purtell >Assignee: Sandeep Pal >Priority: Trivial > Labels: branch-1 > Fix For: 1.6.0 > > Attachments: HBASE-21776-branch-1.patch > > > An example: > 2019-01-25 02:57:15,831 DEBUG > [regionserver/ip-172-31-13-83.us-west-2.compute.internal/172.31.13.83:8120-longCompactions-1548384634805] > util.CommonFSUtils: Set storagePolicy=HOT for > path=hdfs://ip-172-31-5-95.us-west-2.compute.internal:8020/hbase/data/default/IntegrationTestBigLinkedList/16899cdfdb4ab217208f4108ad0c4803/.tmp/meta > 2019-01-25 02:57:15,831 DEBUG > [regionserver/ip-172-31-13-83.us-west-2.compute.internal/172.31.13.83:8120-longCompactions-1548384634805] > util.CommonFSUtils: Set storagePolicy=HOT for > path=hdfs://ip-172-31-5-95.us-west-2.compute.internal:8020/hbase/data/default/IntegrationTestBigLinkedList/16899cdfdb4ab217208f4108ad0c4803/.tmp/meta > Seen most often during compactions. Ideally we only log once per directory > per flush or compaction. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] bharathv commented on issue #858: HBASE-23259: Populate master address end points in cluster/rs configs…
bharathv commented on issue #858: HBASE-23259: Populate master address end points in cluster/rs configs… URL: https://github.com/apache/hbase/pull/858#issuecomment-556386293 @apurtell @ndimiduk FYI, for branch-1. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-21776) Duplicate "Set storagePolicy" debug logging
[ https://issues.apache.org/jira/browse/HBASE-21776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Pal updated HBASE-21776: Attachment: (was: HBASE-21776.branch1.patch) > Duplicate "Set storagePolicy" debug logging > --- > > Key: HBASE-21776 > URL: https://issues.apache.org/jira/browse/HBASE-21776 > Project: HBase > Issue Type: Bug > Components: Compaction >Affects Versions: 1.5.0 >Reporter: Andrew Kyle Purtell >Assignee: Sandeep Pal >Priority: Trivial > Labels: branch-1 > Fix For: 1.6.0 > > > An example: > 2019-01-25 02:57:15,831 DEBUG > [regionserver/ip-172-31-13-83.us-west-2.compute.internal/172.31.13.83:8120-longCompactions-1548384634805] > util.CommonFSUtils: Set storagePolicy=HOT for > path=hdfs://ip-172-31-5-95.us-west-2.compute.internal:8020/hbase/data/default/IntegrationTestBigLinkedList/16899cdfdb4ab217208f4108ad0c4803/.tmp/meta > 2019-01-25 02:57:15,831 DEBUG > [regionserver/ip-172-31-13-83.us-west-2.compute.internal/172.31.13.83:8120-longCompactions-1548384634805] > util.CommonFSUtils: Set storagePolicy=HOT for > path=hdfs://ip-172-31-5-95.us-west-2.compute.internal:8020/hbase/data/default/IntegrationTestBigLinkedList/16899cdfdb4ab217208f4108ad0c4803/.tmp/meta > Seen most often during compactions. Ideally we only log once per directory > per flush or compaction. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-21776) Duplicate "Set storagePolicy" debug logging
[ https://issues.apache.org/jira/browse/HBASE-21776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Pal updated HBASE-21776: Status: Open (was: Patch Available) > Duplicate "Set storagePolicy" debug logging > --- > > Key: HBASE-21776 > URL: https://issues.apache.org/jira/browse/HBASE-21776 > Project: HBase > Issue Type: Bug > Components: Compaction >Affects Versions: 1.5.0 >Reporter: Andrew Kyle Purtell >Assignee: Sandeep Pal >Priority: Trivial > Labels: branch-1 > Fix For: 1.6.0 > > > An example: > 2019-01-25 02:57:15,831 DEBUG > [regionserver/ip-172-31-13-83.us-west-2.compute.internal/172.31.13.83:8120-longCompactions-1548384634805] > util.CommonFSUtils: Set storagePolicy=HOT for > path=hdfs://ip-172-31-5-95.us-west-2.compute.internal:8020/hbase/data/default/IntegrationTestBigLinkedList/16899cdfdb4ab217208f4108ad0c4803/.tmp/meta > 2019-01-25 02:57:15,831 DEBUG > [regionserver/ip-172-31-13-83.us-west-2.compute.internal/172.31.13.83:8120-longCompactions-1548384634805] > util.CommonFSUtils: Set storagePolicy=HOT for > path=hdfs://ip-172-31-5-95.us-west-2.compute.internal:8020/hbase/data/default/IntegrationTestBigLinkedList/16899cdfdb4ab217208f4108ad0c4803/.tmp/meta > Seen most often during compactions. Ideally we only log once per directory > per flush or compaction. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-22902) At regionserver start there's a request to roll the WAL
[
https://issues.apache.org/jira/browse/HBASE-22902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sandeep Pal updated HBASE-22902:
Attachment: (was: HBASE-22902_branch-1_v1.patch)
> At regionserver start there's a request to roll the WAL
> ---
>
> Key: HBASE-22902
> URL: https://issues.apache.org/jira/browse/HBASE-22902
> Project: HBase
> Issue Type: Bug
> Components: wal
>Affects Versions: 3.0.0, 1.5.0, 2.3.0
>Reporter: David Manning
>Assignee: Sandeep Pal
>Priority: Minor
> Fix For: 1.5.0
>
>
> See HBASE-22301 for logic that requests to roll the WAL if regionserver
> encounters a slow write pipeline. In the logs, during regionserver start, I
> see that the WAL is requested to roll once. It's strange that we roll the WAL
> because it wasn't a slow sync. It appears when this code executes, we haven't
> initialized the {{rollOnSyncNs}} variable to use for determining whether it's
> a slow sync. Current pipeline also shows empty in the logs.
> Disclaimer: I'm experiencing this after backporting this to 1.3.x and
> building it there - I haven't attempted in 1.5.x, though I'd expect similar
> results.
> Regionserver logs follow (notice *threshold=0 ms, current pipeline: []*):
> {noformat}
> Tue Aug 20 23:29:50 GMT 2019 Starting regionserver
> ...
> 2019-08-20 23:29:57,824 INFO wal.FSHLog - WAL configuration: blocksize=256
> MB, rollsize=243.20 MB, prefix=[truncated]%2C1566343792434, suffix=,
> logDir=hdfs://[truncated]/hbase/WALs/[truncated],1566343792434,
> archiveDir=hdfs://[truncated]/hbase/oldWALs
> 2019-08-20 23:29:58,104 INFO wal.FSHLog - Slow sync cost: 186 ms, current
> pipeline: []
> 2019-08-20 23:29:58,104 WARN wal.FSHLog - Requesting log roll because we
> exceeded slow sync threshold; time=186 ms, threshold=0 ms, current pipeline:
> []
> 2019-08-20 23:29:58,107 DEBUG regionserver.ReplicationSourceManager - Start
> tracking logs for wal group [truncated]%2C1566343792434 for peer 1
> 2019-08-20 23:29:58,107 INFO wal.FSHLog - New WAL
> /hbase/WALs/[truncated],1566343792434/[truncated]%2C1566343792434.1566343797824
> 2019-08-20 23:29:58,109 DEBUG regionserver.ReplicationSource - Starting up
> worker for wal group [truncated]%2C1566343792434{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-21776) Duplicate "Set storagePolicy" debug logging
[
https://issues.apache.org/jira/browse/HBASE-21776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978725#comment-16978725
]
HBase QA commented on HBASE-21776:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 7s{color}
| {color:red} HBASE-21776 does not apply to master. Rebase required? Wrong
Branch? See
https://yetus.apache.org/documentation/in-progress/precommit-patchnames for
help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-21776 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12986362/HBASE-21776.branch1.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/1036/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
> Duplicate "Set storagePolicy" debug logging
> ---
>
> Key: HBASE-21776
> URL: https://issues.apache.org/jira/browse/HBASE-21776
> Project: HBase
> Issue Type: Bug
> Components: Compaction
>Affects Versions: 1.5.0
>Reporter: Andrew Kyle Purtell
>Assignee: Sandeep Pal
>Priority: Trivial
> Labels: branch-1
> Fix For: 1.6.0
>
> Attachments: HBASE-21776.branch1.patch
>
>
> An example:
> 2019-01-25 02:57:15,831 DEBUG
> [regionserver/ip-172-31-13-83.us-west-2.compute.internal/172.31.13.83:8120-longCompactions-1548384634805]
> util.CommonFSUtils: Set storagePolicy=HOT for
> path=hdfs://ip-172-31-5-95.us-west-2.compute.internal:8020/hbase/data/default/IntegrationTestBigLinkedList/16899cdfdb4ab217208f4108ad0c4803/.tmp/meta
> 2019-01-25 02:57:15,831 DEBUG
> [regionserver/ip-172-31-13-83.us-west-2.compute.internal/172.31.13.83:8120-longCompactions-1548384634805]
> util.CommonFSUtils: Set storagePolicy=HOT for
> path=hdfs://ip-172-31-5-95.us-west-2.compute.internal:8020/hbase/data/default/IntegrationTestBigLinkedList/16899cdfdb4ab217208f4108ad0c4803/.tmp/meta
> Seen most often during compactions. Ideally we only log once per directory
> per flush or compaction.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-21776) Duplicate "Set storagePolicy" debug logging
[ https://issues.apache.org/jira/browse/HBASE-21776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Pal updated HBASE-21776: Attachment: HBASE-21776.branch1.patch Status: Patch Available (was: In Progress) > Duplicate "Set storagePolicy" debug logging > --- > > Key: HBASE-21776 > URL: https://issues.apache.org/jira/browse/HBASE-21776 > Project: HBase > Issue Type: Bug > Components: Compaction >Affects Versions: 1.5.0 >Reporter: Andrew Kyle Purtell >Assignee: Sandeep Pal >Priority: Trivial > Labels: branch-1 > Fix For: 1.6.0 > > Attachments: HBASE-21776.branch1.patch > > > An example: > 2019-01-25 02:57:15,831 DEBUG > [regionserver/ip-172-31-13-83.us-west-2.compute.internal/172.31.13.83:8120-longCompactions-1548384634805] > util.CommonFSUtils: Set storagePolicy=HOT for > path=hdfs://ip-172-31-5-95.us-west-2.compute.internal:8020/hbase/data/default/IntegrationTestBigLinkedList/16899cdfdb4ab217208f4108ad0c4803/.tmp/meta > 2019-01-25 02:57:15,831 DEBUG > [regionserver/ip-172-31-13-83.us-west-2.compute.internal/172.31.13.83:8120-longCompactions-1548384634805] > util.CommonFSUtils: Set storagePolicy=HOT for > path=hdfs://ip-172-31-5-95.us-west-2.compute.internal:8020/hbase/data/default/IntegrationTestBigLinkedList/16899cdfdb4ab217208f4108ad0c4803/.tmp/meta > Seen most often during compactions. Ideally we only log once per directory > per flush or compaction. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] wchevreuil commented on issue #740: HBASE-23197 'IllegalArgumentException: Wrong FS' on edits replay when…
wchevreuil commented on issue #740: HBASE-23197 'IllegalArgumentException: Wrong FS' on edits replay when… URL: https://github.com/apache/hbase/pull/740#issuecomment-556325289 Following internal chat with @joshelser , we agreed to split the archiving between two methods, in order to avoid potential misuse. Latest commit moved recovered edits specific archiving logic to a separate method. Some refactoring on tests and caller classes also needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-23275) Track active master server name in ActiveMasterManager
[ https://issues.apache.org/jira/browse/HBASE-23275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-23275: - Resolution: Fixed Status: Resolved (was: Patch Available) > Track active master server name in ActiveMasterManager > -- > > Key: HBASE-23275 > URL: https://issues.apache.org/jira/browse/HBASE-23275 > Project: HBase > Issue Type: Sub-task > Components: master >Affects Versions: 3.0.0 >Reporter: Bharath Vissapragada >Assignee: Bharath Vissapragada >Priority: Major > Fix For: HBASE-18095 > > > We already track whether the cluster has an active master, it is just another > RPC to the zookeeper to fetch the active master's hostname. Tracking it helps > load balance client requests to fetch the active master information. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23275) Track active master server name in ActiveMasterManager
[ https://issues.apache.org/jira/browse/HBASE-23275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-23275: - Fix Version/s: HBASE-18095 > Track active master server name in ActiveMasterManager > -- > > Key: HBASE-23275 > URL: https://issues.apache.org/jira/browse/HBASE-23275 > Project: HBase > Issue Type: Sub-task > Components: master >Affects Versions: 3.0.0 >Reporter: Bharath Vissapragada >Assignee: Bharath Vissapragada >Priority: Major > Fix For: HBASE-18095 > > > We already track whether the cluster has an active master, it is just another > RPC to the zookeeper to fetch the active master's hostname. Tracking it helps > load balance client requests to fetch the active master information. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] ndimiduk merged pull request #812: HBASE-23275: Track active master's address in ActiveMasterManager
ndimiduk merged pull request #812: HBASE-23275: Track active master's address in ActiveMasterManager URL: https://github.com/apache/hbase/pull/812 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-23324) Deprecate clients that connect to Zookeeper
Nick Dimiduk created HBASE-23324: Summary: Deprecate clients that connect to Zookeeper Key: HBASE-23324 URL: https://issues.apache.org/jira/browse/HBASE-23324 Project: HBase Issue Type: Sub-task Reporter: Nick Dimiduk Sort out on what schedule we'll deprecated and then delete the old client-to-zookeeper path. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-18095) Provide an option for clients to find the server hosting META that does not involve the ZooKeeper client
[ https://issues.apache.org/jira/browse/HBASE-18095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978694#comment-16978694 ] Nick Dimiduk commented on HBASE-18095: -- re: backports, sure, that makes sense. This means we'll need more complexity in our client to decide the right connection mechanism, presumably based on available configuration. It would also be nice to sort out a deprecation schedule for the old path. Let me start a feature branch where we can start to land the patches that are ready. > Provide an option for clients to find the server hosting META that does not > involve the ZooKeeper client > > > Key: HBASE-18095 > URL: https://issues.apache.org/jira/browse/HBASE-18095 > Project: HBase > Issue Type: New Feature > Components: Client >Reporter: Andrew Kyle Purtell >Assignee: Bharath Vissapragada >Priority: Major > Attachments: HBASE-18095.master-v1.patch, HBASE-18095.master-v2.patch > > > Clients are required to connect to ZooKeeper to find the location of the > regionserver hosting the meta table region. Site configuration provides the > client a list of ZK quorum peers and the client uses an embedded ZK client to > query meta location. Timeouts and retry behavior of this embedded ZK client > are managed orthogonally to HBase layer settings and in some cases the ZK > cannot manage what in theory the HBase client can, i.e. fail fast upon outage > or network partition. > We should consider new configuration settings that provide a list of > well-known master and backup master locations, and with this information the > client can contact any of the master processes directly. Any master in either > active or passive state will track meta location and respond to requests for > it with its cached last known location. If this location is stale, the client > can ask again with a flag set that requests the master refresh its location > cache and return the up-to-date location. Every client interaction with the > cluster thus uses only HBase RPC as transport, with appropriate settings > applied to the connection. The configuration toggle that enables this > alternative meta location lookup should be false by default. > This removes the requirement that HBase clients embed the ZK client and > contact the ZK service directly at the beginning of the connection lifecycle. > This has several benefits. ZK service need not be exposed to clients, and > their potential abuse, yet no benefit ZK provides the HBase server cluster is > compromised. Normalizing HBase client and ZK client timeout settings and > retry behavior - in some cases, impossible, i.e. for fail-fast - is no longer > necessary. > And, from [~ghelmling]: There is an additional complication here for > token-based authentication. When a delegation token is used for SASL > authentication, the client uses the cluster ID obtained from Zookeeper to > select the token identifier to use. So there would also need to be some > Zookeeper-less, unauthenticated way to obtain the cluster ID as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23259) Ability to run mini cluster using pre-determined available random ports
[
https://issues.apache.org/jira/browse/HBASE-23259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-23259:
-
Fix Version/s: 3.0.0
> Ability to run mini cluster using pre-determined available random ports
> ---
>
> Key: HBASE-23259
> URL: https://issues.apache.org/jira/browse/HBASE-23259
> Project: HBase
> Issue Type: Test
> Components: test
>Affects Versions: 3.0.0, 1.4.12, 2.2.3
>Reporter: Bharath Vissapragada
>Assignee: Bharath Vissapragada
>Priority: Major
> Fix For: 3.0.0
>
>
> As noted in the code reviews for HBASE-18095, we need the ability to run the
> mini-cluster using a pre-determined set of random (and available) port
> numbers. When I say pre-determined, I mean the test knows these ports even
> before starting the mini cluster.
> In short, the workflow is something like,
> {noformat}
> List ports = getRandomAvailablePorts();
> startMiniCluster(conf, ports);
> {noformat}
> The reason we need this is that certain configs introduced in HBASE-18095
> depend on the ports on which the master is expected to serve the RPCs. While
> that is known for regular deployments (like 16000 for master etc), it is
> totally random in the mini cluster tests. So we need to know them before hand
> for templating out the configs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] bharathv commented on issue #807: HBASE-23259: Ability to start minicluster with pre-determined master ports
bharathv commented on issue #807: HBASE-23259: Ability to start minicluster with pre-determined master ports URL: https://github.com/apache/hbase/pull/807#issuecomment-556212969 ya, I can do that. Thanks for taking care of branch-2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #807: HBASE-23259: Ability to start minicluster with pre-determined master ports
ndimiduk commented on issue #807: HBASE-23259: Ability to start minicluster with pre-determined master ports URL: https://github.com/apache/hbase/pull/807#issuecomment-556211585 Patch applies cleanly to `branch-2`, so I'll merge that after a reasonable response from the buildbot on #857. Patch has conflicts on `branch-1`. Mind resolving conflicts and posting a new PR, @bharathv? By way of process, in case you've not done a back port yet: 1. fetch latest `master` and `branch-1` from upstream 1. checkout a local copy of `branch-1` 1. `git cherry-pick` the patch from `master` 1. resolve conflicts 1. push new PR as usual This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk opened a new pull request #857: HBASE-23259: Populate master address end points in cluster/rs configs
ndimiduk opened a new pull request #857: HBASE-23259: Populate master address
end points in cluster/rs configs
URL: https://github.com/apache/hbase/pull/857
All the clients need to know the master RPC end points while using master
based registry for creating cluster connections. This patch amends the
test cluster utility to populate these configs in the base configuration
object used to spin up the cluster.
The config key added here ("hbase.master.addrs") is used in the subsequent
patches for HBASE-18095.
Signed-off-by: Nick Dimiduk
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk merged pull request #807: HBASE-23259: Ability to start minicluster with pre-determined master ports
ndimiduk merged pull request #807: HBASE-23259: Ability to start minicluster with pre-determined master ports URL: https://github.com/apache/hbase/pull/807 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-23143) Region Server Crash due to 2 cells out of order ( between 2 DELETEs)
[
https://issues.apache.org/jira/browse/HBASE-23143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-23143:
Fix Version/s: (was: 1.3.7)
(was: 1.4.12)
> Region Server Crash due to 2 cells out of order ( between 2 DELETEs)
>
>
> Key: HBASE-23143
> URL: https://issues.apache.org/jira/browse/HBASE-23143
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.2
>Reporter: Xu Cang
>Priority: Major
> Fix For: 1.6.1
>
>
> Region Server Crash due to 2 cells out of order ( between 2 DELETEs)
>
> Caused by: java.io.IOException: Added a key not lexically larger than
> previous.
> Current cell =
> 00D7F00xxQ10D52v8UY6yV0057F00bPaGT\x00057F00bPaG/0:TABLE1_ID/*1570095189597*/DeleteColumn/vlen=0/seqid=*2128373*,
>
> lastCell =
> 00D7F00xxQ10D52v8UY6yV0057F00bPaGT\x00057F00bPaG/0:TABLE1_ID/*1570095165147*/DeleteColumn/vlen=0/seqid=*2128378*
>
>
> I am aware of this JIRA: https://issues.apache.org/jira/browse/HBASE-22862
> Though it's slightly different, HBASE-22862 issue was caused One Delete and
> One Put.
> This issue I am reporting is caused by 2 Deletes
>
> Has anyone seen this issue?
>
> After I read the code and debugged the test cases.
> In AbstractHFileWriter.java
> {code:java}
> int keyComp = comparator.compareOnlyKeyPortion(lastCell, cell);{code}
> This call will always ignore SequenceId. And time stamps are in the correct
> order (above case)
> And since these 2 cells have same KEY. The comparison result should be 0.
> *only possible issue I can think of is, in this code piece: in
> CellComparator.java:*
> {code:java}
> Bytes.compareTo(left.getRowArray(), left.getRowOffset(), left.getRowLength(),
> right.getRowArray(), right.getRowOffset(), right.getRowLength());{code}
> The getRowLength() returns a wrong value.
> Or the offset is messed up. (?)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23323) Release 1.4.12
[ https://issues.apache.org/jira/browse/HBASE-23323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978631#comment-16978631 ] Sean Busbey commented on HBASE-23323: - created 1.4.13 in jira. cleaned out things listed in TODO for 1.4.12. > Release 1.4.12 > -- > > Key: HBASE-23323 > URL: https://issues.apache.org/jira/browse/HBASE-23323 > Project: HBase > Issue Type: Improvement > Components: build, community >Affects Versions: 1.4.12 >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Major > Fix For: 1.4.12 > > > it's been about a month and it doesn't seem like we're ready to move the > stable pointer. also we have at least one CVE in branch-1 and the critical > not-cleaning-wals thing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-21903) Backport major compaction tool HBASE-19528 from to 1.4 and 1.3
[ https://issues.apache.org/jira/browse/HBASE-21903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-21903: Fix Version/s: (was: 1.4.12) 1.4.13 > Backport major compaction tool HBASE-19528 from to 1.4 and 1.3 > -- > > Key: HBASE-21903 > URL: https://issues.apache.org/jira/browse/HBASE-21903 > Project: HBase > Issue Type: Task > Components: Client, Compaction, tooling >Affects Versions: 1.3.3, 1.4.9 >Reporter: Thiruvel Thirumoolan >Assignee: Thiruvel Thirumoolan >Priority: Major > Fix For: 1.3.7, 1.4.13 > > Attachments: HBASE-21903-branch-1.3-addendum.patch > > > Our internal deployments are based on branch-1.3. We will be using the major > compaction tool HBASE-19528 from [~churromorales] and the enhancements on top > of it HBASE-21883 on our 1.3 clusters. I would like to backport HBASE-19528 > to 1.3 and hence 1.4 as well. Since its a standalone tool without any other > dependency or code changes, I believe that should be ok. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-20993) [Auth] IPC client fallback to simple auth allowed doesn't work
[
https://issues.apache.org/jira/browse/HBASE-20993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-20993:
Fix Version/s: (was: 1.3.7)
(was: 1.4.12)
> [Auth] IPC client fallback to simple auth allowed doesn't work
> --
>
> Key: HBASE-20993
> URL: https://issues.apache.org/jira/browse/HBASE-20993
> Project: HBase
> Issue Type: Bug
> Components: Client, IPC/RPC, security
>Affects Versions: 1.2.6, 1.3.2, 1.2.7, 1.4.7
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Critical
> Fix For: 1.6.1
>
> Attachments: HBASE-20993.001.patch,
> HBASE-20993.003.branch-1.flowchart.png, HBASE-20993.branch-1.002.patch,
> HBASE-20993.branch-1.003.patch, HBASE-20993.branch-1.004.patch,
> HBASE-20993.branch-1.005.patch, HBASE-20993.branch-1.006.patch,
> HBASE-20993.branch-1.007.patch, HBASE-20993.branch-1.008.patch,
> HBASE-20993.branch-1.009.patch, HBASE-20993.branch-1.009.patch,
> HBASE-20993.branch-1.010.patch, HBASE-20993.branch-1.011.patch,
> HBASE-20993.branch-1.012.patch, HBASE-20993.branch-1.013.patch,
> HBASE-20993.branch-1.2.001.patch, HBASE-20993.branch-1.wip.002.patch,
> HBASE-20993.branch-1.wip.patch, yetus-local-testpatch-output-009.txt
>
>
> It is easily reproducible.
> client's hbase-site.xml: hadoop.security.authentication:kerberos,
> hbase.security.authentication:kerberos,
> hbase.ipc.client.fallback-to-simple-auth-allowed:true, keytab and principal
> are right set
> A simple auth hbase cluster, a kerberized hbase client application.
> application trying to r/w/c/d table will have following exception:
> {code}
> javax.security.sasl.SaslException: GSS initiate failed [Caused by
> GSSException: No valid credentials provided (Mechanism level: Failed to find
> any Kerberos tgt)]
> at
> com.sun.security.sasl.gsskerb.GssKrb5Client.evaluateChallenge(GssKrb5Client.java:211)
> at
> org.apache.hadoop.hbase.security.HBaseSaslRpcClient.saslConnect(HBaseSaslRpcClient.java:179)
> at
> org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.setupSaslConnection(RpcClientImpl.java:617)
> at
> org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.access$700(RpcClientImpl.java:162)
> at
> org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection$2.run(RpcClientImpl.java:743)
> at
> org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection$2.run(RpcClientImpl.java:740)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:422)
> at
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1628)
> at
> org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.setupIOstreams(RpcClientImpl.java:740)
> at
> org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.writeRequest(RpcClientImpl.java:906)
> at
> org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.tracedWriteRequest(RpcClientImpl.java:873)
> at
> org.apache.hadoop.hbase.ipc.RpcClientImpl.call(RpcClientImpl.java:1241)
> at
> org.apache.hadoop.hbase.ipc.AbstractRpcClient.callBlockingMethod(AbstractRpcClient.java:227)
> at
> org.apache.hadoop.hbase.ipc.AbstractRpcClient$BlockingRpcChannelImplementation.callBlockingMethod(AbstractRpcClient.java:336)
> at
> org.apache.hadoop.hbase.protobuf.generated.MasterProtos$MasterService$BlockingStub.isMasterRunning(MasterProtos.java:58383)
> at
> org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation$MasterServiceStubMaker.isMasterRunning(ConnectionManager.java:1592)
> at
> org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation$StubMaker.makeStubNoRetries(ConnectionManager.java:1530)
> at
> org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation$StubMaker.makeStub(ConnectionManager.java:1552)
> at
> org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation$MasterServiceStubMaker.makeStub(ConnectionManager.java:1581)
> at
> org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.getKeepAliveMasterService(ConnectionManager.java:1738)
> at
> org.apache.hadoop.hbase.client.MasterCallable.prepare(MasterCallable.java:38)
> at
> org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithRetries(RpcRetryingCaller.java:134)
> at
> org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:4297)
> at
> org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:4289)
> at
> org.apache.hadoop.hbase.client.HBaseAdmin.createTableAsyncV2(HBaseAdmin.java:753)
> at
> org.apache.hadoop.hbase.client.HBaseAdmin.createTable(HBaseAdmin.java:674)
> at
>
[GitHub] [hbase] sandeepvinayak commented on issue #837: HBASE-23309: Adding the flexibility to ChainWalEntryFilter to filter the whole entry if all cells get filtered
sandeepvinayak commented on issue #837: HBASE-23309: Adding the flexibility to ChainWalEntryFilter to filter the whole entry if all cells get filtered URL: https://github.com/apache/hbase/pull/837#issuecomment-556172214 @wchevreuil Again, my concern is do we want the custom WAL filers to re-write the whole logic what chain wal filer already does? This would mean, if custom WAL filter want to filter an entry if all cells get filtered in cell, it has to filter cells in WALEntryFilter's filter itself and CellFilterEntry's filterCell is not usable in this case. Let me know what you think. I have also explained the full scenario in the above comments. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work started] (HBASE-23323) Release 1.4.12
[ https://issues.apache.org/jira/browse/HBASE-23323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-23323 started by Sean Busbey. --- > Release 1.4.12 > -- > > Key: HBASE-23323 > URL: https://issues.apache.org/jira/browse/HBASE-23323 > Project: HBase > Issue Type: Improvement > Components: build, community >Affects Versions: 1.4.12 >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Major > Fix For: 1.4.12 > > > it's been about a month and it doesn't seem like we're ready to move the > stable pointer. also we have at least one CVE in branch-1 and the critical > not-cleaning-wals thing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-23323) Release 1.4.12
Sean Busbey created HBASE-23323: --- Summary: Release 1.4.12 Key: HBASE-23323 URL: https://issues.apache.org/jira/browse/HBASE-23323 Project: HBase Issue Type: Improvement Components: build, community Affects Versions: 1.4.12 Reporter: Sean Busbey Assignee: Sean Busbey Fix For: 1.4.12 it's been about a month and it doesn't seem like we're ready to move the stable pointer. also we have at least one CVE in branch-1 and the critical not-cleaning-wals thing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] busbey commented on a change in pull request #846: HBASE-23234 Provide .editorconfig based on checkstyle configuration
busbey commented on a change in pull request #846: HBASE-23234 Provide .editorconfig based on checkstyle configuration URL: https://github.com/apache/hbase/pull/846#discussion_r348655585 ## File path: .editorconfig ## @@ -0,0 +1,693 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +[*] +charset = utf-8 +end_of_line = lf +indent_size = 2 +indent_style = space +insert_final_newline = true +max_line_length = 100 +tab_width = 2 +ij_continuation_indent_size = 2 +ij_formatter_off_tag = @formatter:off +ij_formatter_on_tag = @formatter:on +ij_formatter_tags_enabled = false +ij_smart_tabs = false +ij_wrap_on_typing = false + +[*.css] +ij_css_align_closing_brace_with_properties = false +ij_css_blank_lines_around_nested_selector = 1 +ij_css_blank_lines_between_blocks = 1 +ij_css_brace_placement = 0 +ij_css_hex_color_long_format = false +ij_css_hex_color_lower_case = false +ij_css_hex_color_short_format = false +ij_css_hex_color_upper_case = false +ij_css_keep_blank_lines_in_code = 2 +ij_css_keep_indents_on_empty_lines = false +ij_css_keep_single_line_blocks = false +ij_css_properties_order = font,font-family,font-size,font-weight,font-style,font-variant,font-size-adjust,font-stretch,line-height,position,z-index,top,right,bottom,left,display,visibility,float,clear,overflow,overflow-x,overflow-y,clip,zoom,align-content,align-items,align-self,flex,flex-flow,flex-basis,flex-direction,flex-grow,flex-shrink,flex-wrap,justify-content,order,box-sizing,width,min-width,max-width,height,min-height,max-height,margin,margin-top,margin-right,margin-bottom,margin-left,padding,padding-top,padding-right,padding-bottom,padding-left,table-layout,empty-cells,caption-side,border-spacing,border-collapse,list-style,list-style-position,list-style-type,list-style-image,content,quotes,counter-reset,counter-increment,resize,cursor,user-select,nav-index,nav-up,nav-right,nav-down,nav-left,transition,transition-delay,transition-timing-function,transition-duration,transition-property,transform,transform-origin,animation,animation-name,animation-duration,animation-play-state,animation-timing-function,animation-delay,animation-iteration-count,animation-direction,text-align,text-align-last,vertical-align,white-space,text-decoration,text-emphasis,text-emphasis-color,text-emphasis-style,text-emphasis-position,text-indent,text-justify,letter-spacing,word-spacing,text-outline,text-transform,text-wrap,text-overflow,text-overflow-ellipsis,text-overflow-mode,word-wrap,word-break,tab-size,hyphens,pointer-events,opacity,color,border,border-width,border-style,border-color,border-top,border-top-width,border-top-style,border-top-color,border-right,border-right-width,border-right-style,border-right-color,border-bottom,border-bottom-width,border-bottom-style,border-bottom-color,border-left,border-left-width,border-left-style,border-left-color,border-radius,border-top-left-radius,border-top-right-radius,border-bottom-right-radius,border-bottom-left-radius,border-image,border-image-source,border-image-slice,border-image-width,border-image-outset,border-image-repeat,outline,outline-width,outline-style,outline-color,outline-offset,background,background-color,background-image,background-repeat,background-attachment,background-position,background-position-x,background-position-y,background-clip,background-origin,background-size,box-decoration-break,box-shadow,text-shadow +ij_css_space_after_colon = true +ij_css_space_before_opening_brace = true +ij_css_value_alignment = 0 + +[*.java] +ij_java_align_consecutive_assignments = false +ij_java_align_consecutive_variable_declarations = false +ij_java_align_group_field_declarations = false +ij_java_align_multiline_annotation_parameters = false +ij_java_align_multiline_array_initializer_expression = false +ij_java_align_multiline_assignment = false +ij_java_align_multiline_binary_operation = false +ij_java_align_multiline_chained_methods = false +ij_java_align_multiline_extends_list = false +ij_java_align_multiline_for = true +ij_java_align_multiline_method_parentheses = false +ij_java_align_multiline_parameters = false +ij_java_align_multiline_parameters_in_calls = false +ij_java_align_multiline_parenthesized_expression = false
[GitHub] [hbase] busbey commented on a change in pull request #846: HBASE-23234 Provide .editorconfig based on checkstyle configuration
busbey commented on a change in pull request #846: HBASE-23234 Provide .editorconfig based on checkstyle configuration URL: https://github.com/apache/hbase/pull/846#discussion_r348654622 ## File path: .editorconfig ## @@ -0,0 +1,693 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +[*] +charset = utf-8 +end_of_line = lf +indent_size = 2 +indent_style = space +insert_final_newline = true +max_line_length = 100 +tab_width = 2 +ij_continuation_indent_size = 2 +ij_formatter_off_tag = @formatter:off +ij_formatter_on_tag = @formatter:on +ij_formatter_tags_enabled = false +ij_smart_tabs = false +ij_wrap_on_typing = false + +[*.css] +ij_css_align_closing_brace_with_properties = false +ij_css_blank_lines_around_nested_selector = 1 +ij_css_blank_lines_between_blocks = 1 +ij_css_brace_placement = 0 +ij_css_hex_color_long_format = false +ij_css_hex_color_lower_case = false +ij_css_hex_color_short_format = false +ij_css_hex_color_upper_case = false +ij_css_keep_blank_lines_in_code = 2 +ij_css_keep_indents_on_empty_lines = false +ij_css_keep_single_line_blocks = false +ij_css_properties_order = font,font-family,font-size,font-weight,font-style,font-variant,font-size-adjust,font-stretch,line-height,position,z-index,top,right,bottom,left,display,visibility,float,clear,overflow,overflow-x,overflow-y,clip,zoom,align-content,align-items,align-self,flex,flex-flow,flex-basis,flex-direction,flex-grow,flex-shrink,flex-wrap,justify-content,order,box-sizing,width,min-width,max-width,height,min-height,max-height,margin,margin-top,margin-right,margin-bottom,margin-left,padding,padding-top,padding-right,padding-bottom,padding-left,table-layout,empty-cells,caption-side,border-spacing,border-collapse,list-style,list-style-position,list-style-type,list-style-image,content,quotes,counter-reset,counter-increment,resize,cursor,user-select,nav-index,nav-up,nav-right,nav-down,nav-left,transition,transition-delay,transition-timing-function,transition-duration,transition-property,transform,transform-origin,animation,animation-name,animation-duration,animation-play-state,animation-timing-function,animation-delay,animation-iteration-count,animation-direction,text-align,text-align-last,vertical-align,white-space,text-decoration,text-emphasis,text-emphasis-color,text-emphasis-style,text-emphasis-position,text-indent,text-justify,letter-spacing,word-spacing,text-outline,text-transform,text-wrap,text-overflow,text-overflow-ellipsis,text-overflow-mode,word-wrap,word-break,tab-size,hyphens,pointer-events,opacity,color,border,border-width,border-style,border-color,border-top,border-top-width,border-top-style,border-top-color,border-right,border-right-width,border-right-style,border-right-color,border-bottom,border-bottom-width,border-bottom-style,border-bottom-color,border-left,border-left-width,border-left-style,border-left-color,border-radius,border-top-left-radius,border-top-right-radius,border-bottom-right-radius,border-bottom-left-radius,border-image,border-image-source,border-image-slice,border-image-width,border-image-outset,border-image-repeat,outline,outline-width,outline-style,outline-color,outline-offset,background,background-color,background-image,background-repeat,background-attachment,background-position,background-position-x,background-position-y,background-clip,background-origin,background-size,box-decoration-break,box-shadow,text-shadow +ij_css_space_after_colon = true +ij_css_space_before_opening_brace = true +ij_css_value_alignment = 0 + +[*.java] +ij_java_align_consecutive_assignments = false +ij_java_align_consecutive_variable_declarations = false +ij_java_align_group_field_declarations = false +ij_java_align_multiline_annotation_parameters = false +ij_java_align_multiline_array_initializer_expression = false +ij_java_align_multiline_assignment = false +ij_java_align_multiline_binary_operation = false +ij_java_align_multiline_chained_methods = false +ij_java_align_multiline_extends_list = false +ij_java_align_multiline_for = true +ij_java_align_multiline_method_parentheses = false +ij_java_align_multiline_parameters = false +ij_java_align_multiline_parameters_in_calls = false +ij_java_align_multiline_parenthesized_expression = false
[jira] [Updated] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1
[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-23279: - Attachment: HBASE-23279.master.002.patch > Switch default block encoding to ROW_INDEX_V1 > - > > Key: HBASE-23279 > URL: https://issues.apache.org/jira/browse/HBASE-23279 > Project: HBase > Issue Type: Wish >Affects Versions: 3.0.0, 2.3.0 >Reporter: Lars Hofhansl >Assignee: Viraj Jasani >Priority: Minor > Fix For: 3.0.0, 2.3.0 > > Attachments: HBASE-23279.master.000.patch, > HBASE-23279.master.001.patch, HBASE-23279.master.002.patch > > > Currently we set both block encoding and compression to NONE. > ROW_INDEX_V1 has many advantages and (almost) no disadvantages (the hfiles > are slightly larger about 3% or so). I think that would a better default than > NONE. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-23321) [hbck2] fixHoles of fixMeta doesn't update in-memory state
[ https://issues.apache.org/jira/browse/HBASE-23321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-23321. --- Fix Version/s: 2.2.3 2.3.0 3.0.0 Release Note: If holes in hbase:meta, hbck2 fixMeta now will update Master in-memory state so you do not need to restart master just so you can assign the new hole-bridging regions. Resolution: Fixed Merged to branch-2.2+ > [hbck2] fixHoles of fixMeta doesn't update in-memory state > -- > > Key: HBASE-23321 > URL: https://issues.apache.org/jira/browse/HBASE-23321 > Project: HBase > Issue Type: Improvement > Components: hbck2 >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Minor > Fix For: 3.0.0, 2.3.0, 2.2.3 > > > If hbase:meta has holes, you can run fixMeta from hbck2. This will close the > holes but you have to restart the Master for it to notice the new region > additions. Also, we were plugging holes by adding regions but no state for > the region which makes it awkward to subsequently assign. Fix. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] saintstack closed pull request #851: Hbase 23321
saintstack closed pull request #851: Hbase 23321 URL: https://github.com/apache/hbase/pull/851 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack commented on issue #851: Hbase 23321
saintstack commented on issue #851: Hbase 23321 URL: https://github.com/apache/hbase/pull/851#issuecomment-556113374 Merged manually. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack commented on issue #855: HBASE-23322 [hbck2] Simplification on HBCKSCP scheduling
saintstack commented on issue #855: HBASE-23322 [hbck2] Simplification on HBCKSCP scheduling URL: https://github.com/apache/hbase/pull/855#issuecomment-556101536 Thanks @binlijin . I'm testing on cluster. Found condition where there may be a reference still in Master to a Server though it failed its SCP. In this case, we want to force through out SCP. The code currently bypasses thinking it is mid-processing. Will add a piece so can ride over this state and get the SCP scheduled regardless. Thanks for review. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22607) TestExportSnapshotNoCluster::testSnapshotWithRefsExportFileSystemState() fails intermittently
[
https://issues.apache.org/jira/browse/HBASE-22607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack updated HBASE-22607:
--
Fix Version/s: 2.1.9
2.2.3
2.3.0
3.0.0
Hadoop Flags: Reviewed
Resolution: Fixed
Status: Resolved (was: Patch Available)
Lets try it as you suggest [~liuml07]. Pushed to branch-2.1+. Thanks for the
patch (test fixes especially appreciated).
> TestExportSnapshotNoCluster::testSnapshotWithRefsExportFileSystemState()
> fails intermittently
> -
>
> Key: HBASE-22607
> URL: https://issues.apache.org/jira/browse/HBASE-22607
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0, 2.2.0, 2.0.6
>Reporter: Mingliang Liu
>Assignee: Mingliang Liu
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.3, 2.1.9
>
> Attachments: HBASE-22607.000.patch, HBASE-22607.001.patch,
> HBASE-22607.002.patch
>
>
> In previous runs, test
> {{TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState}}
> fails intermittently with {{java.net.ConnectException: Connection refused}}
> exception, see build
> [510|https://builds.apache.org/job/PreCommit-HBASE-Build/510/testReport/org.apache.hadoop.hbase.snapshot/TestExportSnapshotNoCluster/testSnapshotWithRefsExportFileSystemState/],
>
> [545|https://builds.apache.org/job/PreCommit-HBASE-Build/545/testReport/org.apache.hadoop.hbase.snapshot/TestExportSnapshotNoCluster/testSnapshotWithRefsExportFileSystemState/],
> and
> [556|https://builds.apache.org/job/PreCommit-HBASE-Build/556/testReport/org.apache.hadoop.hbase.snapshot/TestExportSnapshotNoCluster/testSnapshotWithRefsExportFileSystemState/].
> So one sample exception is like:
> {quote}
> at
> org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invoke(RetryInvocationHandler.java:155)
> at
> org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeOnce(RetryInvocationHandler.java:95)
> at
> org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:346)
> at com.sun.proxy.$Proxy20.getListing(Unknown Source)
> at org.apache.hadoop.hdfs.DFSClient.listPaths(DFSClient.java:1630)
> at org.apache.hadoop.hdfs.DFSClient.listPaths(DFSClient.java:1614)
> at
> org.apache.hadoop.hdfs.DistributedFileSystem.listStatusInternal(DistributedFileSystem.java:900)
> at
> org.apache.hadoop.hdfs.DistributedFileSystem.access$600(DistributedFileSystem.java:114)
> at
> org.apache.hadoop.hdfs.DistributedFileSystem$22.doCall(DistributedFileSystem.java:964)
> at
> org.apache.hadoop.hdfs.DistributedFileSystem$22.doCall(DistributedFileSystem.java:961)
> at
> org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81)
> at
> org.apache.hadoop.hdfs.DistributedFileSystem.listStatus(DistributedFileSystem.java:961)
> at org.apache.hadoop.fs.FileSystem.listStatus(FileSystem.java:1537)
> at org.apache.hadoop.fs.FileSystem.listStatus(FileSystem.java:1580)
> at
> org.apache.hadoop.hbase.util.CommonFSUtils.listStatus(CommonFSUtils.java:693)
> at
> org.apache.hadoop.hbase.util.FSTableDescriptors.getCurrentTableInfoStatus(FSTableDescriptors.java:448)
> at
> org.apache.hadoop.hbase.util.FSTableDescriptors.getTableInfoPath(FSTableDescriptors.java:429)
> at
> org.apache.hadoop.hbase.util.FSTableDescriptors.getTableInfoPath(FSTableDescriptors.java:410)
> at
> org.apache.hadoop.hbase.util.FSTableDescriptors.createTableDescriptorForTableDirectory(FSTableDescriptors.java:763)
> at
> org.apache.hadoop.hbase.snapshot.SnapshotTestingUtils$SnapshotMock.createTable(SnapshotTestingUtils.java:675)
> at
> org.apache.hadoop.hbase.snapshot.SnapshotTestingUtils$SnapshotMock.createSnapshot(SnapshotTestingUtils.java:653)
> at
> org.apache.hadoop.hbase.snapshot.SnapshotTestingUtils$SnapshotMock.createSnapshot(SnapshotTestingUtils.java:647)
> at
> org.apache.hadoop.hbase.snapshot.SnapshotTestingUtils$SnapshotMock.createSnapshotV2(SnapshotTestingUtils.java:637)
> at
> org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState(TestExportSnapshotNoCluster.java:80)
> {quote}
> This seems that, somehow the rootdir filesystem is not LocalFileSystem, but
> on HDFS. I have not dig deeper why this happens since it's failing
> intermittently and I can not reproduce it locally. Since this is testing
> export snapshot tool without cluster, we can enforce it using
> LocalFileSystem; no breaking change.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] sandeepvinayak commented on issue #856: HBASE-21776: Duplicate "Set storagePolicy" debug logging
sandeepvinayak commented on issue #856: HBASE-21776: Duplicate "Set storagePolicy" debug logging URL: https://github.com/apache/hbase/pull/856#issuecomment-556083055 @apurtell FYI This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23313) [hbck2] setRegionState should update Master in-memory state too
[
https://issues.apache.org/jira/browse/HBASE-23313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978529#comment-16978529
]
Michael Stack commented on HBASE-23313:
---
Here is a related complaint:
{code}
2019-11-09 02:36:34,956 WARN
org.apache.hadoop.hbase.master.assignment.AssignmentManager: No region state
node for t1,dd2f19a0,1572669183985.258f5eaf51d7da9ad4c7d628bb58f9c5., it should
already be on node.example.com,16020,1573248840154
{code}
> [hbck2] setRegionState should update Master in-memory state too
> ---
>
> Key: HBASE-23313
> URL: https://issues.apache.org/jira/browse/HBASE-23313
> Project: HBase
> Issue Type: Bug
> Components: hbck2
>Reporter: Michael Stack
>Assignee: Wellington Chevreuil
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> setRegionState changes the hbase:meta table info:state column. It does not
> alter the Master's in-memory state. This means you have to kill Master and
> have another assume Active Master role of a state-change to be noticed.
> Better if the setRegionState just went via Master and updated Master and
> hbase:meta.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (HBASE-23313) [hbck2] setRegionState should update Master in-memory state too
[ https://issues.apache.org/jira/browse/HBASE-23313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack reassigned HBASE-23313: - Assignee: Wellington Chevreuil > [hbck2] setRegionState should update Master in-memory state too > --- > > Key: HBASE-23313 > URL: https://issues.apache.org/jira/browse/HBASE-23313 > Project: HBase > Issue Type: Bug > Components: hbck2 >Reporter: Michael Stack >Assignee: Wellington Chevreuil >Priority: Major > Fix For: 3.0.0, 2.3.0 > > > setRegionState changes the hbase:meta table info:state column. It does not > alter the Master's in-memory state. This means you have to kill Master and > have another assume Active Master role of a state-change to be noticed. > Better if the setRegionState just went via Master and updated Master and > hbase:meta. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23313) [hbck2] setRegionState should update Master in-memory state too
[ https://issues.apache.org/jira/browse/HBASE-23313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978527#comment-16978527 ] Michael Stack commented on HBASE-23313: --- Hmm.. I'd thought I'd a bit of a patch but seem to have lost it. Be my guest [~wchevreuil] (and [~liuml07]). I think this has to be a 2.3.0 issue since needs a new RPC in HBCK Service. > [hbck2] setRegionState should update Master in-memory state too > --- > > Key: HBASE-23313 > URL: https://issues.apache.org/jira/browse/HBASE-23313 > Project: HBase > Issue Type: Bug > Components: hbck2 >Reporter: Michael Stack >Priority: Major > Fix For: 3.0.0, 2.3.0 > > > setRegionState changes the hbase:meta table info:state column. It does not > alter the Master's in-memory state. This means you have to kill Master and > have another assume Active Master role of a state-change to be noticed. > Better if the setRegionState just went via Master and updated Master and > hbase:meta. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (HBASE-22048) Incorrect email links on website
[ https://issues.apache.org/jira/browse/HBASE-22048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978513#comment-16978513 ] Beata Sudi edited comment on HBASE-22048 at 11/20/19 3:27 PM: -- Hi, I've looked into this issue and it seems like that the current version (last published: 2019-11-19) opens the [team-list.html | [https://hbase.apache.org/team-list.html|https://hbase.apache.org/team.html]], where everything looks good regarding the email addresses. HBASE-22768 solved this problem, [team.html |[ https://hbase.apache.org/team.html|https://hbase.apache.org/team.html]] is a leftover file from a previous version of the site. This ticket can be closed. was (Author: bea0113): Hi, I've looked into this issue and it seems like that the current version (last published: 2019-11-19) opens the [team-list.html|[https://hbase.apache.org/team-list.html|https://hbase.apache.org/team.html]], where everything looks good regarding the email addresses. HBASE-22768 solved this problem, [team.html|[https://hbase.apache.org/team.html]] is a leftover file from a previous version of the site. This ticket can be closed. > Incorrect email links on website > > > Key: HBASE-22048 > URL: https://issues.apache.org/jira/browse/HBASE-22048 > Project: HBase > Issue Type: Bug > Components: website >Reporter: Peter Somogyi >Assignee: Rishabh Jain >Priority: Minor > Labels: beginner > > Project members email addresses has incorrect link. > [https://hbase.apache.org/team.html] > Instead of [apach...@apache.org|mailto:apach...@apache.org] it points to > [https://hbase.apache.org/apach...@apache.org] > This change might be related to ASF parent pom upgrade which changed the > maven-project-info-reports-plugin version. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-22048) Incorrect email links on website
[ https://issues.apache.org/jira/browse/HBASE-22048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978513#comment-16978513 ] Beata Sudi commented on HBASE-22048: Hi, I've looked into this issue and it seems like that the current version (last published: 2019-11-19) opens the [team-list.html|[https://hbase.apache.org/team-list.html|https://hbase.apache.org/team.html]], where everything looks good regarding the email addresses. HBASE-22768 solved this problem, [team.html|[https://hbase.apache.org/team.html]] is a leftover file from a previous version of the site. This ticket can be closed. > Incorrect email links on website > > > Key: HBASE-22048 > URL: https://issues.apache.org/jira/browse/HBASE-22048 > Project: HBase > Issue Type: Bug > Components: website >Reporter: Peter Somogyi >Assignee: Rishabh Jain >Priority: Minor > Labels: beginner > > Project members email addresses has incorrect link. > [https://hbase.apache.org/team.html] > Instead of [apach...@apache.org|mailto:apach...@apache.org] it points to > [https://hbase.apache.org/apach...@apache.org] > This change might be related to ASF parent pom upgrade which changed the > maven-project-info-reports-plugin version. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23308) Review of NullPointerExceptions
[
https://issues.apache.org/jira/browse/HBASE-23308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978498#comment-16978498
]
Hudson commented on HBASE-23308:
Results for branch master
[build #1542 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1542/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1542//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1542//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1542//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Review of NullPointerExceptions
> ---
>
> Key: HBASE-23308
> URL: https://issues.apache.org/jira/browse/HBASE-23308
> Project: HBase
> Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Fix For: 3.0.0, 2.3.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23315) Miscellaneous HBCK Report page cleanup
[
https://issues.apache.org/jira/browse/HBASE-23315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978497#comment-16978497
]
Hudson commented on HBASE-23315:
Results for branch master
[build #1542 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1542/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1542//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1542//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1542//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Miscellaneous HBCK Report page cleanup
> --
>
> Key: HBASE-23315
> URL: https://issues.apache.org/jira/browse/HBASE-23315
> Project: HBase
> Issue Type: Improvement
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.2.3
>
>
> A bunch of touch up on the hbck report page:
> * Add a bit of javadoc around SerialReplicationChecker.
> * Miniscule edit to the profiler jsp page and then a bit of doc on how to
> make it work that might help.
> * Add some detail if NPE getting BitSetNode to help w/ debug.
> * Change HbckChore to log region names instead of encoded names; helps doing
> diagnostics; can take region name and query in shell to find out all about
> the region according to hbase:meta.
> * Add some fix-it help inline in the HBCK Report page -- how to fix.
> * Add counts in procedures page so can see if making progress; move listing
> of WALs to end of the page.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] guangxuCheng commented on a change in pull request #831: HBASE-23297 [RSGROUP] build RegionPlan per group not per table
guangxuCheng commented on a change in pull request #831: HBASE-23297 [RSGROUP]
build RegionPlan per group not per table
URL: https://github.com/apache/hbase/pull/831#discussion_r348477257
##
File path:
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.java
##
@@ -607,6 +613,22 @@ public void removeServers(Set servers) throws
IOException {
return result;
}
+ private Map> getAssignmentsByGroup(String
groupName)
Review comment:
Yes, we can balance other groups, but if there are many mis-placed regions,
we may need to balance many groups, which I think is unreasonable.
In addition, before the modification, all mis-placed regions of the group
can be moved to the correct group by balancing the group.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bsglz commented on issue #764: HBASE-23223 Support the offsetLock of bucketCache to use strong ref
bsglz commented on issue #764: HBASE-23223 Support the offsetLock of bucketCache to use strong ref URL: https://github.com/apache/hbase/pull/764#issuecomment-555994385 Thanks, who can help to merge it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] guangxuCheng commented on a change in pull request #825: HBASE-23293 [REPLICATION] make ship edits timeout configurable
guangxuCheng commented on a change in pull request #825: HBASE-23293 [REPLICATION] make ship edits timeout configurable URL: https://github.com/apache/hbase/pull/825#discussion_r348464227 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java ## @@ -950,6 +950,10 @@ public static final int REPLICATION_SOURCE_TOTAL_BUFFER_DFAULT = 256 * 1024 * 1024; + /** Configuration key for ReplicationSource shipeEdits timeout */ + public static final String REPLICATION_SOURCE_SHIPEDITS_TIMEOUT = + "replication.source.shipedits.timeout"; Review comment: Usually the configuration key is started with "hbase." This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23281) Track meta region changes on masters
[
https://issues.apache.org/jira/browse/HBASE-23281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978355#comment-16978355
]
HBase QA commented on HBASE-23281:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
45s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
23s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
35s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 4m
43s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
31s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
43s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
31s{color} | {color:red} hbase-server: The patch generated 1 new + 111
unchanged - 0 fixed = 112 total (was 111) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
2s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
17m 25s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
35s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
50s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
50s{color} | {color:green} hbase-zookeeper in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}263m 37s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}346m 3s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated |
| | hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController |
| | hadoop.hbase.master.TestMasterShutdown |
\\
\\
|| Subsystem || Report/Notes ||
|
[GitHub] [hbase] ravowlga123 commented on issue #849: HBASE-23320 Upgrade surefire plugin to 3.0.0-M4
ravowlga123 commented on issue #849: HBASE-23320 Upgrade surefire plugin to 3.0.0-M4 URL: https://github.com/apache/hbase/pull/849#issuecomment-555976509 @HorizonNet I will re-run the test suite locally to see if tests are failing due to the version upgrade of surefire. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #830: HBASE-23281: Track meta region locations in masters
Apache-HBase commented on issue #830: HBASE-23281: Track meta region locations in masters URL: https://github.com/apache/hbase/pull/830#issuecomment-555976416 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 17s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 45s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 8m 26s | master passed | | +1 :green_heart: | compile | 2m 12s | master passed | | +1 :green_heart: | checkstyle | 2m 46s | master passed | | +1 :green_heart: | shadedjars | 6m 23s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 35s | master passed | | +0 :ok: | spotbugs | 4m 43s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 6m 31s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 33s | the patch passed | | +1 :green_heart: | compile | 1m 43s | the patch passed | | +1 :green_heart: | javac | 1m 43s | the patch passed | | -1 :x: | checkstyle | 1m 31s | hbase-server: The patch generated 1 new + 111 unchanged - 0 fixed = 112 total (was 111) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 5m 2s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 17m 25s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 1m 10s | the patch passed | | +1 :green_heart: | findbugs | 6m 35s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 50s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 0m 50s | hbase-zookeeper in the patch passed. | | -1 :x: | unit | 263m 37s | hbase-server in the patch failed. | | +1 :green_heart: | asflicense | 1m 18s | The patch does not generate ASF License warnings. | | | | 346m 3s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated | | | hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController | | | hadoop.hbase.master.TestMasterShutdown | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-830/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/830 | | JIRA Issue | HBASE-23281 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 73eebb990ac2 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-830/out/precommit/personality/provided.sh | | git revision | master / 33bedf8d4d | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-830/5/artifact/out/diff-checkstyle-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-830/5/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-830/5/testReport/ | | Max. process+thread count | 4896 (vs. ulimit of 1) | | modules | C: hbase-client hbase-zookeeper hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-830/5/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git
[jira] [Commented] (HBASE-23278) Add a table-level compaction progress display on the UI
[
https://issues.apache.org/jira/browse/HBASE-23278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978347#comment-16978347
]
Hudson commented on HBASE-23278:
Results for branch branch-1
[build #1143 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1143/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1143//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1143//JDK7_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1143//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Add a table-level compaction progress display on the UI
>
>
> Key: HBASE-23278
> URL: https://issues.apache.org/jira/browse/HBASE-23278
> Project: HBase
> Issue Type: Improvement
> Components: UI
>Affects Versions: 1.6.0, master
>Reporter: Baiqiang Zhao
>Assignee: Baiqiang Zhao
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.6.0, 2.2.3
>
> Attachments: HBase-23278-v2.png, HBase-23278.png,
> image-2019-11-11-20-35-56-103.png, image-2019-11-11-20-37-53-367.png,
> image-2019-11-11-20-44-04-050.png
>
>
> We have regionserver-level compaction progress in UI. However, we often
> compact a table, why there is no table-level compaction progress？Use multiple
> tabs to show compaction progress.
> !HBase-23278-v2.png!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] JeongDaeKim commented on a change in pull request #749: HBASE-23205 Correctly update the position of WALs currently being replicated
JeongDaeKim commented on a change in pull request #749: HBASE-23205 Correctly
update the position of WALs currently being replicated
URL: https://github.com/apache/hbase/pull/749#discussion_r348419504
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReaderThread.java
##
@@ -135,59 +127,46 @@ public void run() {
try (WALEntryStream entryStream =
new WALEntryStream(logQueue, fs, conf, currentPosition, metrics)) {
while (isReaderRunning()) { // loop here to keep reusing stream while
we can
- if (!checkQuota()) {
+ if (manager.isBufferQuotaReached()) {
+Threads.sleep(sleepForRetries);
continue;
}
- WALEntryBatch batch = null;
- while (entryStream.hasNext()) {
-if (batch == null) {
- batch = new WALEntryBatch(replicationBatchCountCapacity,
entryStream.getCurrentPath());
-}
+ WALEntryBatch batch =
+ new WALEntryBatch(replicationBatchCountCapacity,
replicationBatchSizeCapacity);
+ boolean hasNext;
+ while ((hasNext = entryStream.hasNext()) == true) {
Entry entry = entryStream.next();
entry = filterEntry(entry);
if (entry != null) {
WALEdit edit = entry.getEdit();
if (edit != null && !edit.isEmpty()) {
-long entrySize = getEntrySizeIncludeBulkLoad(entry);
-long entrySizeExlucdeBulkLoad =
getEntrySizeExcludeBulkLoad(entry);
-batch.addEntry(entry);
-replicationSourceManager.setPendingShipment(true);
-updateBatchStats(batch, entry, entryStream.getPosition(),
entrySize);
-boolean totalBufferTooLarge =
acquireBufferQuota(entrySizeExlucdeBulkLoad);
+long entrySizeExcludeBulkLoad = batch.addEntry(entry);
+boolean totalBufferTooLarge =
manager.acquireBufferQuota(entrySizeExcludeBulkLoad);
// Stop if too many entries or too big
-if (totalBufferTooLarge || batch.getHeapSize() >=
replicationBatchSizeCapacity
-|| batch.getNbEntries() >= replicationBatchCountCapacity) {
+if (totalBufferTooLarge || batch.isLimitReached()) {
break;
}
}
-} else {
Review comment:
> What if the whole WAL section read got no entries for replication? In this
case, batch would be empty, so
_ReplicationSourceManager.logPositionAndCleanOldLogs_ does not ever get called
(at least, I guess, until the log is rolled).
Yes, In that case, the position will be updated when log rolled. That is my
intention. https://github.com/apache/hbase/pull/749#discussion_r341050152
> I think the answer to my question above is in the resetStream() that gets
called at the end of the second while loop, which will update lastReadPosition
variable that is now used for reading here.
Oh? Then, I think i didn't understand what your question is. 藍
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] JeongDaeKim commented on a change in pull request #749: HBASE-23205 Correctly update the position of WALs currently being replicated
JeongDaeKim commented on a change in pull request #749: HBASE-23205 Correctly
update the position of WALs currently being replicated
URL: https://github.com/apache/hbase/pull/749#discussion_r348419891
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestWALEntryStream.java
##
@@ -378,37 +380,35 @@ public void testReplicationSourceWALReaderThread()
throws Exception {
}
@Test
- public void testReplicationSourceUpdatesLogPositionOnFilteredEntries()
throws Exception {
+ public void testReplicationSourceWALReaderThreadRecoveredQueue() throws
Exception {
Review comment:
I changed the method name to `getRecoveredQueueInfo()`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
