Re: [PR] HBASE-28468: Integration of time-based priority caching in eviction logic. [hbase]
jhungund commented on PR #5826: URL: https://github.com/apache/hbase/pull/5826#issuecomment-2065780777 Closing this PR in favour of https://github.com/apache/hbase/pull/5829 as the solution for [HBASE-28468](https://issues.apache.org/jira/browse/HBASE-28468)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-28298) HFilePrettyPrinter thrown NoSuchMethodError about MetricRegistry
[
https://issues.apache.org/jira/browse/HBASE-28298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838860#comment-17838860
]
Hudson commented on HBASE-28298:
Results for branch branch-2
[build #1035 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1035/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1035/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1035/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1035/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1035/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> HFilePrettyPrinter thrown NoSuchMethodError about MetricRegistry
>
>
> Key: HBASE-28298
> URL: https://issues.apache.org/jira/browse/HBASE-28298
> Project: HBase
> Issue Type: Bug
> Components: HFile, UI
>Affects Versions: 2.5.6
>Reporter: Moran
>Assignee: Moran
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.6.0, 2.4.18, 2.5.9
>
>
> {{When I view the contents of the HFile through storeFile.jsp or hbase hfile
> -p -v , it will throw an exception similar to the following:}}
>
> {{HTTP ERROR 500 java.lang.NoSuchMethodError: 'com.codahale.metrics.Histogram
> com.codahale.metrics.MetricRegistry.histogram(java.lang.String,
> com.codahale.metrics.MetricRegistry$MetricSupplier)'}}
> ||URI:|/storeFile.jsp|
> ||STATUS:|500|
> ||MESSAGE:|java.lang.NoSuchMethodError: 'com.codahale.metrics.Histogram
> com.codahale.metrics.MetricRegistry.histogram(java.lang.String,
> com.codahale.metrics.MetricRegistry$MetricSupplier)'|
> ||SERVLET:|org.apache.hadoop.hbase.generated.regionserver.storeFile_jsp|
> ||CAUSED BY:|java.lang.NoSuchMethodError: 'com.codahale.metrics.Histogram
> com.codahale.metrics.MetricRegistry.histogram(java.lang.String,
> com.codahale.metrics.MetricRegistry$MetricSupplier)'|
> I found that there were conflicting files in the lib folder, specifically
> metrics-core-3.0.1.jar and metrics-core-3.2.6.jar. After deleting
> metrics-core-3.0.1.jar, the functionality returned to normal.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-28470) Fix Typo in Java Method Comment
[
https://issues.apache.org/jira/browse/HBASE-28470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838861#comment-17838861
]
Hudson commented on HBASE-28470:
Results for branch branch-2
[build #1035 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1035/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1035/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1035/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1035/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1035/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Fix Typo in Java Method Comment
> ---
>
> Key: HBASE-28470
> URL: https://issues.apache.org/jira/browse/HBASE-28470
> Project: HBase
> Issue Type: Improvement
> Components: Admin
>Affects Versions: 4.0.0-alpha-1
>Reporter: Hyunduk Choi
>Assignee: Hyunduk Choi
>Priority: Trivial
> Labels: pull-request-available
> Fix For: 2.6.0, 2.4.18, 3.0.0-beta-2, 2.5.9
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> https://github.com/apache/hbase/blob/9adca10e9c106df5119cc067fd610fb19cd1d5ec/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java#L795
>
> The java method comment contains a typo.
> The comment incorrectly states "Region name to assign" instead of "Region
> name to unassign".
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] HBASE-28468: Integration of time-based priority caching in eviction logic. [hbase]
jhungund commented on PR #5826: URL: https://github.com/apache/hbase/pull/5826#issuecomment-2065780262 > Can we close this PR and favour the #5829 as the solution for [HBASE-28468](https://issues.apache.org/jira/browse/HBASE-28468)? ack! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28468: Integration of time-based priority caching in eviction logic. [hbase]
jhungund closed pull request #5826: HBASE-28468: Integration of time-based priority caching in eviction logic. URL: https://github.com/apache/hbase/pull/5826 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-28298) HFilePrettyPrinter thrown NoSuchMethodError about MetricRegistry
[
https://issues.apache.org/jira/browse/HBASE-28298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838857#comment-17838857
]
Hudson commented on HBASE-28298:
Results for branch branch-2.6
[build #98 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/98/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/98/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/98/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/98/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/98/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> HFilePrettyPrinter thrown NoSuchMethodError about MetricRegistry
>
>
> Key: HBASE-28298
> URL: https://issues.apache.org/jira/browse/HBASE-28298
> Project: HBase
> Issue Type: Bug
> Components: HFile, UI
>Affects Versions: 2.5.6
>Reporter: Moran
>Assignee: Moran
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.6.0, 2.4.18, 2.5.9
>
>
> {{When I view the contents of the HFile through storeFile.jsp or hbase hfile
> -p -v , it will throw an exception similar to the following:}}
>
> {{HTTP ERROR 500 java.lang.NoSuchMethodError: 'com.codahale.metrics.Histogram
> com.codahale.metrics.MetricRegistry.histogram(java.lang.String,
> com.codahale.metrics.MetricRegistry$MetricSupplier)'}}
> ||URI:|/storeFile.jsp|
> ||STATUS:|500|
> ||MESSAGE:|java.lang.NoSuchMethodError: 'com.codahale.metrics.Histogram
> com.codahale.metrics.MetricRegistry.histogram(java.lang.String,
> com.codahale.metrics.MetricRegistry$MetricSupplier)'|
> ||SERVLET:|org.apache.hadoop.hbase.generated.regionserver.storeFile_jsp|
> ||CAUSED BY:|java.lang.NoSuchMethodError: 'com.codahale.metrics.Histogram
> com.codahale.metrics.MetricRegistry.histogram(java.lang.String,
> com.codahale.metrics.MetricRegistry$MetricSupplier)'|
> I found that there were conflicting files in the lib folder, specifically
> metrics-core-3.0.1.jar and metrics-core-3.2.6.jar. After deleting
> metrics-core-3.0.1.jar, the functionality returned to normal.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-28470) Fix Typo in Java Method Comment
[
https://issues.apache.org/jira/browse/HBASE-28470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838858#comment-17838858
]
Hudson commented on HBASE-28470:
Results for branch branch-2.6
[build #98 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/98/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/98/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/98/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/98/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/98/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Fix Typo in Java Method Comment
> ---
>
> Key: HBASE-28470
> URL: https://issues.apache.org/jira/browse/HBASE-28470
> Project: HBase
> Issue Type: Improvement
> Components: Admin
>Affects Versions: 4.0.0-alpha-1
>Reporter: Hyunduk Choi
>Assignee: Hyunduk Choi
>Priority: Trivial
> Labels: pull-request-available
> Fix For: 2.6.0, 2.4.18, 3.0.0-beta-2, 2.5.9
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> https://github.com/apache/hbase/blob/9adca10e9c106df5119cc067fd610fb19cd1d5ec/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java#L795
>
> The java method comment contains a typo.
> The comment incorrectly states "Region name to assign" instead of "Region
> name to unassign".
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] HBASE-26974 Introduce a LogRollProcedure [hbase]
frostruan commented on PR #5408: URL: https://github.com/apache/hbase/pull/5408#issuecomment-2065709792 > Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.1.0:test (secondPartTestsExecution) on project hbase-server: There was a timeout in the fork -> [Help 1] The failed UT looks not related. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28428 : ConnectionRegistry APIs should have timeout [hbase]
Apache-HBase commented on PR #5837: URL: https://github.com/apache/hbase/pull/5837#issuecomment-2065661292 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 43s | master passed | | +1 :green_heart: | compile | 1m 18s | master passed | | +1 :green_heart: | shadedjars | 6m 48s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 56s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 5s | the patch passed | | +1 :green_heart: | compile | 1m 24s | the patch passed | | +1 :green_heart: | javac | 1m 24s | the patch passed | | +1 :green_heart: | shadedjars | 6m 17s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 1s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 3s | hbase-common in the patch passed. | | -1 :x: | unit | 1m 7s | hbase-client in the patch failed. | | -1 :x: | unit | 258m 26s | hbase-server in the patch failed. | | | | 291m 2s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5837/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5837 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 28ee601525b9 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / a34b4bc517 | | Default Java | Temurin-1.8.0_352-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5837/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-client.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5837/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5837/1/testReport/ | | Max. process+thread count | 5459 (vs. ulimit of 3) | | modules | C: hbase-common hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5837/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-28470) Fix Typo in Java Method Comment
[
https://issues.apache.org/jira/browse/HBASE-28470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838842#comment-17838842
]
Hudson commented on HBASE-28470:
Results for branch branch-2.4
[build #722 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/722/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/722/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/722/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/722/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/722/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Fix Typo in Java Method Comment
> ---
>
> Key: HBASE-28470
> URL: https://issues.apache.org/jira/browse/HBASE-28470
> Project: HBase
> Issue Type: Improvement
> Components: Admin
>Affects Versions: 4.0.0-alpha-1
>Reporter: Hyunduk Choi
>Assignee: Hyunduk Choi
>Priority: Trivial
> Labels: pull-request-available
> Fix For: 2.6.0, 2.4.18, 3.0.0-beta-2, 2.5.9
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> https://github.com/apache/hbase/blob/9adca10e9c106df5119cc067fd610fb19cd1d5ec/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java#L795
>
> The java method comment contains a typo.
> The comment incorrectly states "Region name to assign" instead of "Region
> name to unassign".
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-28298) HFilePrettyPrinter thrown NoSuchMethodError about MetricRegistry
[
https://issues.apache.org/jira/browse/HBASE-28298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838841#comment-17838841
]
Hudson commented on HBASE-28298:
Results for branch branch-2.4
[build #722 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/722/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/722/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/722/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/722/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/722/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> HFilePrettyPrinter thrown NoSuchMethodError about MetricRegistry
>
>
> Key: HBASE-28298
> URL: https://issues.apache.org/jira/browse/HBASE-28298
> Project: HBase
> Issue Type: Bug
> Components: HFile, UI
>Affects Versions: 2.5.6
>Reporter: Moran
>Assignee: Moran
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.6.0, 2.4.18, 2.5.9
>
>
> {{When I view the contents of the HFile through storeFile.jsp or hbase hfile
> -p -v , it will throw an exception similar to the following:}}
>
> {{HTTP ERROR 500 java.lang.NoSuchMethodError: 'com.codahale.metrics.Histogram
> com.codahale.metrics.MetricRegistry.histogram(java.lang.String,
> com.codahale.metrics.MetricRegistry$MetricSupplier)'}}
> ||URI:|/storeFile.jsp|
> ||STATUS:|500|
> ||MESSAGE:|java.lang.NoSuchMethodError: 'com.codahale.metrics.Histogram
> com.codahale.metrics.MetricRegistry.histogram(java.lang.String,
> com.codahale.metrics.MetricRegistry$MetricSupplier)'|
> ||SERVLET:|org.apache.hadoop.hbase.generated.regionserver.storeFile_jsp|
> ||CAUSED BY:|java.lang.NoSuchMethodError: 'com.codahale.metrics.Histogram
> com.codahale.metrics.MetricRegistry.histogram(java.lang.String,
> com.codahale.metrics.MetricRegistry$MetricSupplier)'|
> I found that there were conflicting files in the lib folder, specifically
> metrics-core-3.0.1.jar and metrics-core-3.2.6.jar. After deleting
> metrics-core-3.0.1.jar, the functionality returned to normal.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] HBASE-28428 : ConnectionRegistry APIs should have timeout [hbase]
Apache-HBase commented on PR #5837: URL: https://github.com/apache/hbase/pull/5837#issuecomment-2065641841 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 58s | master passed | | +1 :green_heart: | compile | 1m 37s | master passed | | +1 :green_heart: | shadedjars | 5m 12s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 4s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 50s | the patch passed | | +1 :green_heart: | compile | 1m 39s | the patch passed | | +1 :green_heart: | javac | 1m 39s | the patch passed | | +1 :green_heart: | shadedjars | 5m 13s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 3s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 37s | hbase-common in the patch passed. | | -1 :x: | unit | 1m 10s | hbase-client in the patch failed. | | -1 :x: | unit | 234m 40s | hbase-server in the patch failed. | | | | 266m 36s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5837/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5837 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux ea84a235b95e 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / a34b4bc517 | | Default Java | Eclipse Adoptium-17.0.10+7 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5837/1/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-client.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5837/1/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5837/1/testReport/ | | Max. process+thread count | 4787 (vs. ulimit of 3) | | modules | C: hbase-common hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5837/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28428 : ConnectionRegistry APIs should have timeout [hbase]
Apache-HBase commented on PR #5837: URL: https://github.com/apache/hbase/pull/5837#issuecomment-2065637516 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 13s | master passed | | +1 :green_heart: | compile | 1m 21s | master passed | | +1 :green_heart: | shadedjars | 5m 53s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 54s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 59s | the patch passed | | +1 :green_heart: | compile | 1m 23s | the patch passed | | +1 :green_heart: | javac | 1m 23s | the patch passed | | +1 :green_heart: | shadedjars | 5m 54s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 54s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 45s | hbase-common in the patch passed. | | -1 :x: | unit | 1m 7s | hbase-client in the patch failed. | | -1 :x: | unit | 231m 15s | hbase-server in the patch failed. | | | | 263m 37s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5837/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5837 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 3402ddd9c745 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / a34b4bc517 | | Default Java | Eclipse Adoptium-11.0.17+8 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5837/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-client.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5837/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5837/1/testReport/ | | Max. process+thread count | 5330 (vs. ulimit of 3) | | modules | C: hbase-common hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5837/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-28534) Authentication failure when running hbase-spark in local mode
[
https://issues.apache.org/jira/browse/HBASE-28534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838833#comment-17838833
]
Junegunn Choi commented on HBASE-28534:
---
[~nikitapande]
Thanks for the comment. Can you be a little more specific? Do you mean that you
(still) get the local mode error even with the patch?
Here's my test result. I tested with pyspark instead of spark-shell but I don't
think it makes any difference.
{code}
# Redacted
SPARK_SUBMIT_OPTS="-Djava.security.krb5.conf=**" HADOOP_CONF_DIR="**" \
pyspark --principal "**@**" --keytab "**.keytab" \
--packages
org.apache.hbase:hbase-common:2.4.16,org.apache.hbase:hbase-server:2.4.16,org.apache.hbase:hbase-shaded-mapreduce:2.4.16
\
--jars
jars/hbase-spark-1.1.0-SNAPSHOT.jar,jars/hbase-spark-protocol-shaded-1.1.0-SNAPSHOT.jar
{code}
h3. Before patch (with {{applyCreds}})
* Without kinit or keytab: Doesn't work (x)
** {code}No matching SASL authentication provider and supporting token found
from providers for user: ** (auth:SIMPLE){code}
* With keytab: Doesn't work (x)
** {code}No matching SASL authentication provider and supporting token found
from providers for user: **@** (auth:PROXY){code}
* After kinit: Doesn't work (x)
** {code}No matching SASL authentication provider and supporting token found
from providers for user: **@** (auth:PROXY){code}
h3. After patch (without {{applyCreds}})
* Without kinit or keytab: Doesn't work (x)
** {code}No matching SASL authentication provider and supporting token found
from providers for user: ** (auth:SIMPLE){code}
* With keytab: Works (/)
* After kinit: Works (/)
> Authentication failure when running hbase-spark in local mode
> -
>
> Key: HBASE-28534
> URL: https://issues.apache.org/jira/browse/HBASE-28534
> Project: HBase
> Issue Type: Bug
> Components: spark
>Affects Versions: connector-1.0.0
>Reporter: Junegunn Choi
>Assignee: Junegunn Choi
>Priority: Major
>
> h2. Problem
> When running Spark in local mode, hbase-spark fails to authenticate to a
> Kerberos secured HBase cluster. The error message is:
> {quote}No matching SASL authentication provider and supporting token found
> from providers for user: x...@xxx.xxx (auth:PROXY)
> {quote}
> That is because {{applyCreds}} changes the authentication method of the
> current user to {{{}PROXY{}}}, when it should still be {{KERBEROS}} for local
> mode to run correctly.
> h2. Suggested solution
> To fix this, I propose removing {{{}applyCreds{}}}. The function is no longer
> needed and should be removed:
> 1. Because we should not change the authentication mode of the current user
> in local mode
> 2. And because the purpose of the function is no longer valid. It is not
> doing anything meaningful since the broadcasting of the user credentials was
> removed in this commit:
> [https://github.com/apache/hbase-connectors/commit/75e41365207408f5b47d5925469a49fd60078b5e]
> A pull request is on the way.
> h2. Testing
> The fix was manually tested against Kerberos secured HBase 2.4.17 + Hadoop
> 3.3.5 cluster using Spark 3.5.1, both in local mode and with Yarn master,
> running the following Python code.
> {code:java}
> df = (spark.read.format("org.apache.hadoop.hbase.spark")
> .option("hbase.columns.mapping", "key STRING :key, state
> STRING info:state")
> .option("hbase.table", "hbase:meta").load())
> df.first()
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] HBASE-28428 : ConnectionRegistry APIs should have timeout [hbase]
Apache-HBase commented on PR #5837: URL: https://github.com/apache/hbase/pull/5837#issuecomment-2065441599 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 57s | master passed | | +1 :green_heart: | compile | 3m 44s | master passed | | +1 :green_heart: | checkstyle | 1m 10s | master passed | | +1 :green_heart: | spotless | 0m 45s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 47s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 49s | the patch passed | | +1 :green_heart: | compile | 3m 41s | the patch passed | | +1 :green_heart: | javac | 3m 41s | the patch passed | | -0 :warning: | checkstyle | 0m 17s | hbase-client: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) | | -0 :warning: | checkstyle | 0m 36s | hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 4m 50s | Patch does not cause any errors with Hadoop 3.3.6. | | -1 :x: | spotless | 0m 20s | patch has 59 errors when running spotless:check, run spotless:apply to fix. | | +1 :green_heart: | spotbugs | 3m 11s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 32s | The patch does not generate ASF License warnings. | | | | 35m 23s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5837/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5837 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 28af1b003969 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / a34b4bc517 | | Default Java | Eclipse Adoptium-11.0.17+8 | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5837/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5837/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | spotless | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5837/1/artifact/yetus-general-check/output/patch-spotless.txt | | Max. process+thread count | 81 (vs. ulimit of 3) | | modules | C: hbase-common hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5837/1/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-28428) ConnectionRegistry APIs should have timeout
[
https://issues.apache.org/jira/browse/HBASE-28428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HBASE-28428:
---
Labels: pull-request-available (was: )
> ConnectionRegistry APIs should have timeout
> ---
>
> Key: HBASE-28428
> URL: https://issues.apache.org/jira/browse/HBASE-28428
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 2.4.17, 3.0.0-beta-1, 2.5.8
>Reporter: Viraj Jasani
>Assignee: Divneet Kaur
>Priority: Major
> Labels: pull-request-available
>
> Came across a couple of instances where active master failover happens around
> the same time as Zookeeper leader failover, leading to stuck HBase client if
> one of the threads is blocked on one of the ConnectionRegistry rpc calls.
> ConnectionRegistry APIs are wrapped with CompletableFuture. However, their
> usages do not have any timeouts, which can potentially lead to the entire
> client in stuck state indefinitely as we take some global locks. For
> instance, _getKeepAliveMasterService()_ takes
> {_}masterLock{_}, hence if getting active master from _masterAddressZNode_
> gets stuck, we can block any admin operation that needs
> {_}getKeepAliveMasterService(){_}.
>
> Sample stacktrace that blocked all client operations that required table
> descriptor from Admin:
> {code:java}
> jdk.internal.misc.Unsafe.park
> java.util.concurrent.locks.LockSupport.park
> java.util.concurrent.CompletableFuture$Signaller.block
> java.util.concurrent.ForkJoinPool.managedBlock
> java.util.concurrent.CompletableFuture.waitingGet
> java.util.concurrent.CompletableFuture.get
> org.apache.hadoop.hbase.client.ConnectionImplementation.get
> org.apache.hadoop.hbase.client.ConnectionImplementation.access$?
> org.apache.hadoop.hbase.client.ConnectionImplementation$MasterServiceStubMaker.makeStubNoRetries
> org.apache.hadoop.hbase.client.ConnectionImplementation$MasterServiceStubMaker.makeStub
> org.apache.hadoop.hbase.client.ConnectionImplementation.getKeepAliveMasterService
> org.apache.hadoop.hbase.client.ConnectionImplementation.getMaster
> org.apache.hadoop.hbase.client.MasterCallable.prepare
> org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries
> org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable
> org.apache.hadoop.hbase.client.HBaseAdmin.getTableDescriptor
> org.apache.hadoop.hbase.client.HTable.getDescriptororg.apache.phoenix.query.ConnectionQueryServicesImpl.getTableDescriptor
> org.apache.phoenix.query.DelegateConnectionQueryServices.getTableDescriptor
> org.apache.phoenix.util.IndexUtil.isGlobalIndexCheckerEnabled
> org.apache.phoenix.execute.MutationState.filterIndexCheckerMutations
> org.apache.phoenix.execute.MutationState.sendBatch
> org.apache.phoenix.execute.MutationState.send
> org.apache.phoenix.execute.MutationState.send
> org.apache.phoenix.execute.MutationState.commit
> org.apache.phoenix.jdbc.PhoenixConnection$?.call
> org.apache.phoenix.jdbc.PhoenixConnection$?.call
> org.apache.phoenix.call.CallRunner.run
> org.apache.phoenix.jdbc.PhoenixConnection.commit {code}
> Another similar incident is captured on PHOENIX-7233. In this case,
> retrieving clusterId from ZNode got stuck and that blocked client from being
> able to create any more HBase Connection. Stacktrace for referece:
> {code:java}
> jdk.internal.misc.Unsafe.park
> java.util.concurrent.locks.LockSupport.park
> java.util.concurrent.CompletableFuture$Signaller.block
> java.util.concurrent.ForkJoinPool.managedBlock
> java.util.concurrent.CompletableFuture.waitingGet
> java.util.concurrent.CompletableFuture.get
> org.apache.hadoop.hbase.client.ConnectionImplementation.retrieveClusterId
> org.apache.hadoop.hbase.client.ConnectionImplementation.
> jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance?
> jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance
> jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance
> java.lang.reflect.Constructor.newInstance
> org.apache.hadoop.hbase.client.ConnectionFactory.lambda$createConnection$?
> org.apache.hadoop.hbase.client.ConnectionFactory$$Lambda$?.run
> java.security.AccessController.doPrivileged
> javax.security.auth.Subject.doAs
> org.apache.hadoop.security.UserGroupInformation.doAs
> org.apache.hadoop.hbase.security.User$SecureHadoopUser.runAs
> org.apache.hadoop.hbase.client.ConnectionFactory.createConnection
> org.apache.hadoop.hbase.client.ConnectionFactory.createConnectionorg.apache.phoenix.query.ConnectionQueryServicesImpl.openConnection
> org.apache.phoenix.query.ConnectionQueryServicesImpl.access$?
> org.apache.phoenix.query.ConnectionQueryServicesImpl$?.call
> org.apache.phoenix.query.ConnectionQueryServicesImpl$?.call
> org.apache.phoenix.util.PhoenixContextExecutor.call
> org.apache.phoenix.query.ConnectionQueryServicesImpl.init
Re: [PR] HBASE-26974 Introduce a LogRollProcedure [hbase]
Apache-HBase commented on PR #5408: URL: https://github.com/apache/hbase/pull/5408#issuecomment-2065214976 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 20s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 10s | master passed | | +1 :green_heart: | compile | 2m 49s | master passed | | +1 :green_heart: | shadedjars | 8m 29s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 18s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 47s | the patch passed | | +1 :green_heart: | compile | 2m 47s | the patch passed | | +1 :green_heart: | javac | 2m 47s | the patch passed | | +1 :green_heart: | shadedjars | 8m 32s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 31s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 12s | hbase-protocol-shaded in the patch passed. | | -1 :x: | unit | 319m 50s | hbase-server in the patch failed. | | +1 :green_heart: | unit | 11m 30s | hbase-backup in the patch passed. | | | | 372m 53s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5408 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux d70cafd57dd3 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / a34b4bc517 | | Default Java | Eclipse Adoptium-11.0.17+8 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/3/testReport/ | | Max. process+thread count | 4858 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-server hbase-backup U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/3/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-28500) Rest Java client library assumes stateless servers
[
https://issues.apache.org/jira/browse/HBASE-28500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838780#comment-17838780
]
Hudson commented on HBASE-28500:
Results for branch branch-3
[build #187 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/187/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/187/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/187/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/187/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Rest Java client library assumes stateless servers
> --
>
> Key: HBASE-28500
> URL: https://issues.apache.org/jira/browse/HBASE-28500
> Project: HBase
> Issue Type: Bug
> Components: REST
>Reporter: Istvan Toth
>Assignee: Istvan Toth
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.6.0, 2.4.18, 4.0.0-alpha-1, 2.7.0, 3.0.0-beta-2, 2.5.9
>
>
> The Rest Java client library accepts a list of rest servers, and does random
> load balancing between them for each request.
> This does not work for scans, which do have state on the rest server instance.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] HBASE-26974 Introduce a LogRollProcedure [hbase]
Apache-HBase commented on PR #5408: URL: https://github.com/apache/hbase/pull/5408#issuecomment-2065029801 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 59s | master passed | | +1 :green_heart: | compile | 1m 49s | master passed | | +1 :green_heart: | shadedjars | 5m 55s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 47s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 39s | the patch passed | | +1 :green_heart: | compile | 1m 36s | the patch passed | | +1 :green_heart: | javac | 1m 36s | the patch passed | | +1 :green_heart: | shadedjars | 5m 48s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 49s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 33s | hbase-protocol-shaded in the patch passed. | | -1 :x: | unit | 278m 41s | hbase-server in the patch failed. | | +1 :green_heart: | unit | 13m 9s | hbase-backup in the patch passed. | | | | 320m 33s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5408 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 23afa7d56869 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / a34b4bc517 | | Default Java | Temurin-1.8.0_352-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/3/testReport/ | | Max. process+thread count | 5803 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-server hbase-backup U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/3/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-28500) Rest Java client library assumes stateless servers
[
https://issues.apache.org/jira/browse/HBASE-28500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838775#comment-17838775
]
Hudson commented on HBASE-28500:
Results for branch master
[build #1054 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1054/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1054/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1054/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1054/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Rest Java client library assumes stateless servers
> --
>
> Key: HBASE-28500
> URL: https://issues.apache.org/jira/browse/HBASE-28500
> Project: HBase
> Issue Type: Bug
> Components: REST
>Reporter: Istvan Toth
>Assignee: Istvan Toth
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.6.0, 2.4.18, 4.0.0-alpha-1, 2.7.0, 3.0.0-beta-2, 2.5.9
>
>
> The Rest Java client library accepts a list of rest servers, and does random
> load balancing between them for each request.
> This does not work for scans, which do have state on the rest server instance.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] HBASE-28468: Integrate the data-tiering logic into cache evictions. [hbase]
Apache-HBase commented on PR #5829: URL: https://github.com/apache/hbase/pull/5829#issuecomment-2064931623 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 15s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-28463 Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 22s | HBASE-28463 passed | | +1 :green_heart: | compile | 0m 52s | HBASE-28463 passed | | +1 :green_heart: | shadedjars | 6m 18s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 31s | HBASE-28463 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 20s | the patch passed | | +1 :green_heart: | compile | 0m 55s | the patch passed | | +1 :green_heart: | javac | 0m 55s | the patch passed | | +1 :green_heart: | shadedjars | 5m 41s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 27s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 341m 47s | hbase-server in the patch failed. | | | | 369m 6s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5829/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5829 | | JIRA Issue | HBASE-28468 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux c3c83ad34e25 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-28463 / b7bb8b9d27 | | Default Java | Eclipse Adoptium-11.0.17+8 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5829/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5829/4/testReport/ | | Max. process+thread count | 4771 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5829/4/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-26974 Introduce a LogRollProcedure [hbase]
Apache-HBase commented on PR #5408: URL: https://github.com/apache/hbase/pull/5408#issuecomment-2064904249 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 54s | master passed | | +1 :green_heart: | compile | 1m 51s | master passed | | +1 :green_heart: | shadedjars | 5m 12s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 53s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 49s | the patch passed | | +1 :green_heart: | compile | 1m 51s | the patch passed | | +1 :green_heart: | javac | 1m 51s | the patch passed | | +1 :green_heart: | shadedjars | 5m 14s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 52s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 36s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 212m 1s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 10m 57s | hbase-backup in the patch passed. | | | | 250m 40s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5408 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux b74dfd0c6628 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / a34b4bc517 | | Default Java | Eclipse Adoptium-17.0.10+7 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/3/testReport/ | | Max. process+thread count | 5448 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-server hbase-backup U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/3/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]
gvprathyusha6 commented on PR #5834: URL: https://github.com/apache/hbase/pull/5834#issuecomment-2064857989 > Checked the POC, overall good. > > It is a pain that we need to touch the MOB related code. > > Anyway, I think first we could first do some refactorings, to move the reference file related logic to StoreFileTracker, without changing any real logic. And then, another refactoring to move HFileLink, and back reference files related logic to StoreFileTracker. And finally, we start to change the implementation of StoreFileTracker, to implement the special logic for FileBasedStoreFileTracker, and also consider how to migrate between different store file tracker implementions. > > WDYT? > > Thanks. > Checked the POC, overall good. > > It is a pain that we need to touch the MOB related code. > > Anyway, I think first we could first do some refactorings, to move the reference file related logic to StoreFileTracker, without changing any real logic. And then, another refactoring to move HFileLink, and back reference files related logic to StoreFileTracker. And finally, we start to change the implementation of StoreFileTracker, to implement the special logic for FileBasedStoreFileTracker, and also consider how to migrate between different store file tracker implementions. > > WDYT? > > Thanks. Totally agree, we can target them 1 pr at a time. - to move the reference file related logic to StoreFileTracker - then, another refactoring to move HFileLink, and back reference files - then we start to change the implementation of StoreFileTracker, to implement the special logic for FileBasedStoreFileTracker to create virtual links - and commit all the ref files as part of split in 1 go Thanks a lot for the review :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28511 Update hbase-thirdparty to 4.1.7 [hbase]
Apache-HBase commented on PR #5818: URL: https://github.com/apache/hbase/pull/5818#issuecomment-2064834288 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 13s | master passed | | +1 :green_heart: | compile | 2m 7s | master passed | | +1 :green_heart: | shadedjars | 6m 16s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 58s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 43s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 45s | the patch passed | | +1 :green_heart: | compile | 1m 47s | the patch passed | | +1 :green_heart: | javac | 1m 47s | the patch passed | | +1 :green_heart: | shadedjars | 6m 16s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 51s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 421m 0s | root in the patch failed. | | | | 456m 36s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5818/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5818 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 921e8462ee0a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / a34b4bc517 | | Default Java | Temurin-1.8.0_352-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5818/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5818/3/testReport/ | | Max. process+thread count | 5038 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-examples . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5818/3/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28468: Integrate the data-tiering logic into cache evictions. [hbase]
Apache-HBase commented on PR #5829: URL: https://github.com/apache/hbase/pull/5829#issuecomment-2064832622 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-28463 Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 23s | HBASE-28463 passed | | +1 :green_heart: | compile | 0m 51s | HBASE-28463 passed | | +1 :green_heart: | shadedjars | 6m 34s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 33s | HBASE-28463 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 16s | the patch passed | | +1 :green_heart: | compile | 0m 53s | the patch passed | | +1 :green_heart: | javac | 0m 53s | the patch passed | | +1 :green_heart: | shadedjars | 5m 55s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 26s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 310m 37s | hbase-server in the patch failed. | | | | 339m 3s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5829/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5829 | | JIRA Issue | HBASE-28468 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 83a9678c4ce5 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-28463 / b7bb8b9d27 | | Default Java | Temurin-1.8.0_352-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5829/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5829/4/testReport/ | | Max. process+thread count | 4948 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5829/4/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-28500) Rest Java client library assumes stateless servers
[
https://issues.apache.org/jira/browse/HBASE-28500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838758#comment-17838758
]
Hudson commented on HBASE-28500:
Results for branch branch-2.5
[build #513 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/513/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/513/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/513/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/513/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/513/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Rest Java client library assumes stateless servers
> --
>
> Key: HBASE-28500
> URL: https://issues.apache.org/jira/browse/HBASE-28500
> Project: HBase
> Issue Type: Bug
> Components: REST
>Reporter: Istvan Toth
>Assignee: Istvan Toth
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.6.0, 2.4.18, 4.0.0-alpha-1, 2.7.0, 3.0.0-beta-2, 2.5.9
>
>
> The Rest Java client library accepts a list of rest servers, and does random
> load balancing between them for each request.
> This does not work for scans, which do have state on the rest server instance.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] HBASE-28511 Update hbase-thirdparty to 4.1.7 [hbase]
Apache-HBase commented on PR #5818: URL: https://github.com/apache/hbase/pull/5818#issuecomment-2064676325 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 32s | master passed | | +1 :green_heart: | compile | 3m 3s | master passed | | +1 :green_heart: | shadedjars | 6m 15s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 27s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 34s | the patch passed | | +1 :green_heart: | compile | 2m 33s | the patch passed | | +1 :green_heart: | javac | 2m 33s | the patch passed | | +1 :green_heart: | shadedjars | 6m 8s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 29s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 356m 56s | root in the patch passed. | | | | 397m 27s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5818/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5818 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 79e8bc4031c5 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / a34b4bc517 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5818/3/testReport/ | | Max. process+thread count | 8337 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-examples . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5818/3/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-28533) Region split failure due to region quota limit leaves Hmaster's in memory state for the region in SPLITTING after procedure rollback
[
https://issues.apache.org/jira/browse/HBASE-28533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838738#comment-17838738
]
Daniel Roudnitsky commented on HBASE-28533:
---
[~wchevreuil] I believe that this does affect newer releases, will reproduce on
the latest to confirm. I do plan on working on a fix, thanks.
> Region split failure due to region quota limit leaves Hmaster's in memory
> state for the region in SPLITTING after procedure rollback
>
>
> Key: HBASE-28533
> URL: https://issues.apache.org/jira/browse/HBASE-28533
> Project: HBase
> Issue Type: Bug
> Components: Region Assignment
>Affects Versions: 2.5.8
> Environment: HBase Version 2.5.8,
> r37444de6531b1bdabf2e445c83d0268ab1a6f919, Thu Feb 29 15:37:32 PST 2024
>Reporter: Daniel Roudnitsky
>Priority: Major
>
> When a SplitTableRegionProcedure is run for a region whose namespace is at
> its maximum region quota limit, the split procedure will fail and rollback,
> and Hmaster's in memory RegionStateNode for the region is left in a SPLITTING
> state. Hmaster will then refuse to start any subsequent merge/split/move
> procedures for that region because it believes the region is not OPEN, until
> it is restarted and the in memory record of region states is reset.
> In the first step of the split procedure SPLIT_TABLE_REGION_PREPARE the
> parent region's RegionStateNode state is set to SPLITTING, and the transition
> is not written to the meta table. In the next step
> SPLIT_TABLE_REGION_PRE_OPERATION the region quota check is done,
> QuotaExceededException is thrown and the procedure ends in ROLLEDBACK state
> without reverting the RegionStateNode back to OPEN state. Hmaster is left
> believing the region is in a SPLITTING state according to its in memory
> RegionStates, while the region is still online on the assigned region server
> and according to meta.
> To reproduce in HBase shell:
> {code:java}
> > create_namespace 'test_ns', {'hbase.namespace.quota.maxregions'=> 2}
> > create 'test_ns:test_table', 'f1', {NUMREGIONS => 2, SPLITALGO =>
> > 'UniformSplit'}
> > region_a =
> > region_b =
> > split region_a, 'x'
> # HMaster will report:
> pid=405, state=ROLLEDBACK,
> exception=org.apache.hadoop.hbase.quotas.QuotaExceededException via
> master-split-regions:org.apache.hadoop.hbase.quotas.QuotaExceededException:
> Region split not possible for : as quota limits are exceeded ;
> SplitTableRegionProcedure table=test_ns:test_table, parent=...
> > merge_region region_a, region_b
> ERROR: org.apache.hadoop.hbase.exceptions.MergeRegionException:
> org.apache.hadoop.hbase.client.DoNotRetryRegionException: is not
> OPEN; state=SPLITTING
> > stop_master # trigger hmaster failover
> > merge_region region_a, region_b # merge now succeeds {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]
gvprathyusha6 commented on code in PR #5834:
URL: https://github.com/apache/hbase/pull/5834#discussion_r1571045154
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java:
##
@@ -822,22 +825,25 @@ private class StoreFileSplitter implements
Callable> {
private final HRegionFileSystem regionFs;
private final byte[] family;
private final HStoreFile sf;
+private final StoreFileTracker tracker;
/**
* Constructor that takes what it needs to split
* @param regionFs the file system
* @param family Family that contains the store file
* @param sf which file
*/
-public StoreFileSplitter(HRegionFileSystem regionFs, byte[] family,
HStoreFile sf) {
+public StoreFileSplitter(HRegionFileSystem regionFs, StoreFileTracker
tracker, byte[] family,
+ HStoreFile sf) {
this.regionFs = regionFs;
this.sf = sf;
this.family = family;
+ this.tracker = tracker;
}
@Override
public Pair call() throws IOException {
- return splitStoreFile(regionFs, family, sf);
+ return splitStoreFile(regionFs, tracker, family, sf);
Review Comment:
Yes if we can add this api as well in SFT, it will be easier to choose if
where we want multi threading, but both impls might still need multi threading
while initiating reader for all the parent store files while reading metadata
for first/lastkeys.
But yes, we can get to it in detail as part of our last phase of
[implementation](https://docs.google.com/document/d/18aHEv7w0RExV6nJbJaVnTR6NIqbiWHIVUvU7v9rvXAk/edit#heading=h.4tx7yijt3qa1)
may be, where we want to commit all the ref/links in 1 go
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] HBASE-28511 Update hbase-thirdparty to 4.1.7 [hbase]
Apache-HBase commented on PR #5818: URL: https://github.com/apache/hbase/pull/5818#issuecomment-2064356458 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 39s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 6s | master passed | | +1 :green_heart: | compile | 1m 56s | master passed | | +1 :green_heart: | shadedjars | 5m 27s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 50s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 47s | the patch passed | | +1 :green_heart: | compile | 1m 55s | the patch passed | | +1 :green_heart: | javac | 1m 55s | the patch passed | | +1 :green_heart: | shadedjars | 5m 24s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 47s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 263m 30s | root in the patch passed. | | | | 297m 55s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5818/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5818 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 4227a9e8122e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / a34b4bc517 | | Default Java | Eclipse Adoptium-17.0.10+7 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5818/3/testReport/ | | Max. process+thread count | 8796 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-examples . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5818/3/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28536 Fix `Disable Stripe Compaction` run error in document [hbase]
Apache-HBase commented on PR #5836: URL: https://github.com/apache/hbase/pull/5836#issuecomment-2064342662 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 12s | master passed | | +0 :ok: | refguide | 3m 14s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | spotless | 0m 52s | branch has no errors when running spotless:check. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 37s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +0 :ok: | refguide | 2m 33s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | spotless | 0m 54s | patch has no errors when running spotless:check. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 17m 36s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5836/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5836 | | Optional Tests | dupname asflicense refguide spotless | | uname | Linux a279f1380b79 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / a34b4bc517 | | refguide | https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5836/1/yetus-general-check/output/branch-site/book.html | | refguide | https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5836/1/yetus-general-check/output/patch-site/book.html | | Max. process+thread count | 78 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5836/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]
gvprathyusha6 commented on code in PR #5834: URL: https://github.com/apache/hbase/pull/5834#discussion_r1571011511 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java: ## @@ -666,8 +666,9 @@ private Pair, List> splitStoreFiles(final MasterProcedureEnv en // table dir. In case of failure, the proc would go through this again, already existing // region dirs and split files would just be ignored, new split files should get created. int nbFiles = 0; -final Map> files = - new HashMap>(htd.getColumnFamilyCount()); +final Map, StoreFileTracker>> files = Review Comment: No we have a StoreFileTracker per column family, we refactored current struct which contains [columnFamilyName] ---> [ Collection(StoreFileInfo) ] to [columnFamilyName] ---> [ Collection(StoreFileInfo) + sft ] ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java: ## @@ -666,8 +666,9 @@ private Pair, List> splitStoreFiles(final MasterProcedureEnv en // table dir. In case of failure, the proc would go through this again, already existing // region dirs and split files would just be ignored, new split files should get created. int nbFiles = 0; -final Map> files = - new HashMap>(htd.getColumnFamilyCount()); +final Map, StoreFileTracker>> files = Review Comment: No we have a StoreFileTracker per column family here, we refactored current struct which contains [columnFamilyName] ---> [ Collection(StoreFileInfo) ] to [columnFamilyName] ---> [ Collection(StoreFileInfo) + sft ] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]
gvprathyusha6 commented on code in PR #5834:
URL: https://github.com/apache/hbase/pull/5834#discussion_r1571005337
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileTrackerBase.java:
##
@@ -189,6 +202,107 @@ public final StoreFileWriter
createWriter(CreateStoreFileWriterParams params) th
return builder.build();
}
+ @Override
+ public String createHFileLink(CreateHFileLinkParams params) throws
IOException {
+String name = HFileLink.createHFileLinkName(params.getLinkedTable(),
params.getLinkedRegion(),
+ params.getHfileName());
+String refName =
+ HFileLink.createBackReferenceName(params.getDstTableName(),
params.getDstRegionName());
+
+// Make sure the destination directory exists
+params.getFs().mkdirs(params.getDstFamilyPath());
+
+// Make sure the FileLink reference directory exists
+Path archiveStoreDir = HFileArchiveUtil.getStoreArchivePath(conf,
params.getLinkedTable(),
+ params.getLinkedRegion(), params.getFamilyName());
+Path backRefPath = null;
+if (params.isCreateBackRef()) {
+ Path backRefssDir = HFileLink.getBackReferencesDir(archiveStoreDir,
params.getHfileName());
+ params.getFs().mkdirs(backRefssDir);
+
+ // Create the reference for the link
+ backRefPath = new Path(backRefssDir, refName);
+ params.getFs().createNewFile(backRefPath);
+}
+try {
+ // Create the link
+ if (params.getFs().createNewFile(new Path(params.getDstFamilyPath(),
name))) {
+return name;
+ }
+} catch (IOException e) {
+ LOG.error("couldn't create the link=" + name + " for " +
params.getDstFamilyPath(), e);
+ // Revert the reference if the link creation failed
+ if (params.isCreateBackRef()) {
+params.getFs().delete(backRefPath, false);
+ }
+ throw e;
+}
+throw new IOException(
+ "File link=" + name + " already exists under " +
params.getDstFamilyPath() + " folder.");
+ }
+
+ @Override
+ public Reference createReference(Reference reference, Path path) throws
IOException {
Review Comment:
Yes thats correct, we will move it respective impl classes once we have the
implementation of virtual links ready in FSFT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]
gvprathyusha6 commented on code in PR #5834:
URL: https://github.com/apache/hbase/pull/5834#discussion_r1571002658
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/DefaultStoreFileTracker.java:
##
@@ -55,12 +65,49 @@ protected void
doAddCompactionResults(Collection compactedFiles,
@Override
protected List doLoadStoreFiles(boolean readOnly) throws
IOException {
-List files =
-
ctx.getRegionFileSystem().getStoreFiles(ctx.getFamily().getNameAsString());
+List files =
getStoreFiles(ctx.getFamily().getNameAsString(), true);
return files != null ? files : Collections.emptyList();
}
@Override
protected void doSetStoreFiles(Collection files) throws
IOException {
}
+
+ /**
+ * Returns the store files available for the family. This methods performs
the filtering based on
+ * the valid store files.
+ * @param familyName Column Family Name
+ * @return a set of {@link StoreFileInfo} for the specified family.
+ */
+ public List getStoreFiles(final String familyName, final
boolean validate)
Review Comment:
This is only helper method used as part of SFT#load() impl of
DefaultStoreFileTracker, this was moved from
[HRegionFileSystem](https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java#L274)
to here. This is not a new API we are adding
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] HBASE-28536 Fix `Disable Stripe Compaction` run error in document [hbase]
Apache-HBase commented on PR #5836: URL: https://github.com/apache/hbase/pull/5836#issuecomment-2064304346 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 1m 35s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5836/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5836 | | Optional Tests | | | uname | Linux 6aa1d61cd290 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / a34b4bc517 | | Max. process+thread count | 36 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5836/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28536 Fix `Disable Stripe Compaction` run error in document [hbase]
Apache-HBase commented on PR #5836: URL: https://github.com/apache/hbase/pull/5836#issuecomment-2064300151 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 1m 39s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5836/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5836 | | Optional Tests | | | uname | Linux dda16c9d9272 5.4.0-176-generic #196-Ubuntu SMP Fri Mar 22 16:46:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / a34b4bc517 | | Max. process+thread count | 40 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5836/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28536 Fix `Disable Stripe Compaction` run error in document [hbase]
Apache-HBase commented on PR #5836: URL: https://github.com/apache/hbase/pull/5836#issuecomment-2064293901 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 1m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5836/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5836 | | Optional Tests | | | uname | Linux 2f8ff2d00f0c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / a34b4bc517 | | Max. process+thread count | 29 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5836/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]
gvprathyusha6 commented on code in PR #5834:
URL: https://github.com/apache/hbase/pull/5834#discussion_r1570996949
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java:
##
@@ -119,12 +120,13 @@ public class StoreFileInfo implements Configurable {
* @param primaryReplica true if this is a store file for primary replica,
otherwise false.
*/
public StoreFileInfo(final Configuration conf, final FileSystem fs, final
Path initialPath,
-final boolean primaryReplica) throws IOException {
-this(conf, fs, null, initialPath, primaryReplica);
+final boolean primaryReplica, final StoreFileTracker sft) throws
IOException {
Review Comment:
you mean, we move the creation of StoreFileInfo itself to SFT, like
SFT.getStoreFileInfo(path, primaryReplica) something like that right? yes this
does look better to me.
Couple of trivial constructors like
[these](https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java#L214)
we can have in StoreFileInfo and rest we can move to SFT interface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] HBASE-28468: Integration of time-based priority caching in eviction logic. [hbase]
wchevreuil commented on PR #5826: URL: https://github.com/apache/hbase/pull/5826#issuecomment-2064167432 Can we close this PR and favour the #5829 as the solution for HBASE-28468? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28521 Use standard ConnectionRegistry and Client API to get reg… [hbase]
Apache-HBase commented on PR #5825: URL: https://github.com/apache/hbase/pull/5825#issuecomment-2064165705 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 55s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 26s | master passed | | +1 :green_heart: | compile | 1m 28s | master passed | | +1 :green_heart: | shadedjars | 8m 48s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 50s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 24s | the patch passed | | +1 :green_heart: | compile | 1m 24s | the patch passed | | +1 :green_heart: | javac | 1m 24s | the patch passed | | +1 :green_heart: | shadedjars | 8m 8s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 47s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 253m 19s | hbase-server in the patch passed. | | | | 289m 31s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5825 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 06073127fe67 5.4.0-176-generic #196-Ubuntu SMP Fri Mar 22 16:46:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Eclipse Adoptium-17.0.10+7 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/4/testReport/ | | Max. process+thread count | 4824 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/4/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28468: Integrate the data-tiering logic into cache evictions. [hbase]
wchevreuil commented on code in PR #5829:
URL: https://github.com/apache/hbase/pull/5829#discussion_r1570904381
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DataTieringManager.java:
##
@@ -219,4 +225,43 @@ private long getDataTieringHotDataAge(Configuration conf) {
return Long.parseLong(
conf.get(DATATIERING_HOT_DATA_AGE_KEY,
String.valueOf(DEFAULT_DATATIERING_HOT_DATA_AGE)));
}
+
+ /*
+ * This API takes the names of files as input and returns a subset of these
file names
+ * that are cold.
+ * @parameter inputFileNames: Input list of file names
+ * @return List of names of files that are cold as per data-tiering logic.
+ */
+ public Map getColdFilesList() {
+Map coldFiles = new HashMap<>();
+for (HRegion r : this.onlineRegions.values()) {
+ for (HStore hStore : r.getStores()) {
+Configuration conf = hStore.getReadOnlyConfiguration();
+if (getDataTieringType(conf) != DataTieringType.TIME_RANGE) {
+ // Data-Tiering not enabled for the store. Just skip it.
+ continue;
+}
+Long hotDataAge = getDataTieringHotDataAge(conf);
+
+for (HStoreFile hStoreFile : hStore.getStorefiles()) {
+ String hFileName =
+
hStoreFile.getFileInfo().getHFileInfo().getHFileContext().getHFileName();
+OptionalLong maxTimestamp = hStoreFile.getMaximumTimestamp();
+if (!maxTimestamp.isPresent()) {
+ // We could throw from here, But we are already in the critical
code-path
+ // of freeing space. Hence, we can ignore that file for now
+ // Or do we want to include it?
Review Comment:
That's fine for me. Can we add a debug/trace log?
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##
@@ -972,6 +976,13 @@ void freeSpace(final String why) {
long bytesToFreeWithExtra =
(long) Math.floor(bytesToFreeWithoutExtra * (1 + extraFreeFactor));
+ // Check the list of files to determine the cold files which can be
readily evicted.
+ Map coldFiles =
+DataTieringManager.getInstance().getColdFilesList();
+ //Can we evict the blocks inline during backingMap traversal?
+ // If not, we accumulate the keys and evict them later.
+ // List coldBlocks = new ArrayList<>();
+
Review Comment:
nit: please remove commented code.
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##
@@ -980,9 +991,18 @@ void freeSpace(final String why) {
BucketEntryGroup bucketMemory =
new BucketEntryGroup(bytesToFreeWithExtra, blockSize,
getPartitionSize(memoryFactor));
+ long bytesFreed = 0;
+
// Scan entire map putting bucket entry into appropriate bucket entry
// group
for (Map.Entry bucketEntryWithKey :
backingMap.entrySet()) {
+
+if (coldFiles.containsKey(bucketEntryWithKey.getKey().getHfileName()))
{
+ //coldBlocks.add(bucketEntryWithKey.getKey());
Review Comment:
nit: remove commented code.
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##
@@ -980,9 +991,18 @@ void freeSpace(final String why) {
BucketEntryGroup bucketMemory =
new BucketEntryGroup(bytesToFreeWithExtra, blockSize,
getPartitionSize(memoryFactor));
+ long bytesFreed = 0;
+
// Scan entire map putting bucket entry into appropriate bucket entry
// group
for (Map.Entry bucketEntryWithKey :
backingMap.entrySet()) {
+
+if (coldFiles.containsKey(bucketEntryWithKey.getKey().getHfileName()))
{
+ //coldBlocks.add(bucketEntryWithKey.getKey());
+ bytesFreed += bucketEntryWithKey.getValue().getLength();
Review Comment:
We should only account for this once the eviction was indeed successfull.
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##
@@ -935,6 +937,7 @@ void freeSpace(final String why) {
}
try {
freeInProgress = true;
+
Review Comment:
nit: please avoid unnecessary new lines.
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##
@@ -980,9 +991,18 @@ void freeSpace(final String why) {
BucketEntryGroup bucketMemory =
new BucketEntryGroup(bytesToFreeWithExtra, blockSize,
getPartitionSize(memoryFactor));
+ long bytesFreed = 0;
+
// Scan entire map putting bucket entry into appropriate bucket entry
// group
for (Map.Entry bucketEntryWithKey :
backingMap.entrySet()) {
+
+if (coldFiles.containsKey(bucketEntryWithKey.getKey().getHfileName()))
{
+ //coldBlocks.add(bucketEntryWithKey.getKey());
+ bytesFreed += bucketEntryWithKey.getValue().getLength();
+ evictBlock(bucketEntryWithKey.getKey());
Review Comment:
Re: [PR] HBASE-28521 Use standard ConnectionRegistry and Client API to get reg… [hbase]
Apache-HBase commented on PR #5825: URL: https://github.com/apache/hbase/pull/5825#issuecomment-2064152215 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 1s | master passed | | +1 :green_heart: | compile | 1m 0s | master passed | | +1 :green_heart: | shadedjars | 6m 47s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 33s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 37s | the patch passed | | +1 :green_heart: | compile | 0m 59s | the patch passed | | +1 :green_heart: | javac | 0m 59s | the patch passed | | +1 :green_heart: | shadedjars | 6m 39s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 27s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 256m 51s | hbase-server in the patch passed. | | | | 286m 0s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5825 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 30dac394593f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/4/testReport/ | | Max. process+thread count | 4501 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/4/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-26974 Introduce a LogRollProcedure [hbase]
Apache-HBase commented on PR #5408: URL: https://github.com/apache/hbase/pull/5408#issuecomment-2064110471 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 48s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | prototool | 0m 1s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 16s | master passed | | +1 :green_heart: | compile | 6m 11s | master passed | | +1 :green_heart: | checkstyle | 1m 21s | master passed | | +1 :green_heart: | spotless | 1m 11s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 6m 55s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 36s | the patch passed | | +1 :green_heart: | compile | 5m 46s | the patch passed | | +1 :green_heart: | cc | 5m 46s | the patch passed | | +1 :green_heart: | javac | 5m 46s | the patch passed | | +1 :green_heart: | checkstyle | 1m 21s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 7m 44s | Patch does not cause any errors with Hadoop 3.3.6. | | +1 :green_heart: | hbaseprotoc | 2m 29s | the patch passed | | +1 :green_heart: | spotless | 1m 14s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 7m 58s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 38s | The patch does not generate ASF License warnings. | | | | 63m 58s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5408 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool | | uname | Linux bbfe54809345 5.4.0-176-generic #196-Ubuntu SMP Fri Mar 22 16:46:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / a34b4bc517 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 81 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-server hbase-backup U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5408/3/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28466 Integration of time-based priority logic of bucket cache in prefetch functionality of HBase [hbase]
vinayakphegde commented on code in PR #5808:
URL: https://github.com/apache/hbase/pull/5808#discussion_r1570896489
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePreadReader.java:
##
@@ -37,10 +37,15 @@ public class HFilePreadReader extends HFileReaderImpl {
public HFilePreadReader(ReaderContext context, HFileInfo fileInfo,
CacheConfig cacheConf,
Configuration conf) throws IOException {
super(context, fileInfo, cacheConf, conf);
+
final MutableBoolean shouldCache = new MutableBoolean(true);
+// Initialize HFileInfo object with metadata for caching decisions
+HFileInfo hFileInfoForCaching = new HFileInfo(context, conf);
+hFileInfoForCaching.initMetaAndIndex(this);
Review Comment:
> maybe we could modify initMetaAndIndex to do its stuff just if the file
info hasn't been initialized yet
Hmmm, I'm not sure how we can do that. Maybe use a boolean field in the
HFileInfo to track whether initMetaAndIndex is done or not? Because
initMetaAndIndex does a couple of things, and it's hard to say whether that is
initialized or not. Can you think of any way we can achieve that?
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePreadReader.java:
##
@@ -37,10 +37,15 @@ public class HFilePreadReader extends HFileReaderImpl {
public HFilePreadReader(ReaderContext context, HFileInfo fileInfo,
CacheConfig cacheConf,
Configuration conf) throws IOException {
super(context, fileInfo, cacheConf, conf);
+
final MutableBoolean shouldCache = new MutableBoolean(true);
+// Initialize HFileInfo object with metadata for caching decisions
+HFileInfo hFileInfoForCaching = new HFileInfo(context, conf);
+hFileInfoForCaching.initMetaAndIndex(this);
Review Comment:
> maybe we could modify initMetaAndIndex to do its stuff just if the file
info hasn't been initialized yet.
Hmmm, I'm not sure how we can do that. Maybe use a boolean field in the
HFileInfo to track whether initMetaAndIndex is done or not? Because
initMetaAndIndex does a couple of things, and it's hard to say whether that is
initialized or not. Can you think of any way we can achieve that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] HBASE-28521 Use standard ConnectionRegistry and Client API to get reg… [hbase]
Apache-HBase commented on PR #5825: URL: https://github.com/apache/hbase/pull/5825#issuecomment-2064016817 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 32s | master passed | | +1 :green_heart: | compile | 0m 43s | master passed | | +1 :green_heart: | shadedjars | 5m 8s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 29s | the patch passed | | +1 :green_heart: | compile | 0m 42s | the patch passed | | +1 :green_heart: | javac | 0m 42s | the patch passed | | +1 :green_heart: | shadedjars | 5m 6s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 228m 4s | hbase-server in the patch passed. | | | | 250m 27s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5825 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux d44775469df0 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/4/testReport/ | | Max. process+thread count | 5641 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/4/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (HBASE-28534) Authentication failure when running hbase-spark in local mode
[
https://issues.apache.org/jira/browse/HBASE-28534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838673#comment-17838673
]
Nikita Pande edited comment on HBASE-28534 at 4/18/24 2:28 PM:
---
I had kinit done with a user. Then had run spark-shell command and got error
{code:java}
No matching SASL authentication provider and supporting token found from
providers for user:
(auth:KERBEROS) {code}
NOTE: I didnt get auth:PROXY but it did fail
{code:java}
Failed on local exception: java.io.IOException:
org.apache.hadoop.security.AccessControlException: Client cannot authenticate
via:[TOKEN, KERBEROS]{code}
When I do not pass "--master local[*]", it picked yarn mode and it passes
successfully.
was (Author: JIRAUSER298527):
I had kinit done with a user. Then had run spark-shell command and got error
```
No matching SASL authentication provider and supporting token found from
providers for user:
(auth:KERBEROS)
```
NOTE: I didnt get auth:PROXY but it did fail
```
Failed on local exception: java.io.IOException:
org.apache.hadoop.security.AccessControlException: Client cannot authenticate
via:[TOKEN, KERBEROS]
```
When I do not pass "--master local[*]", it picked yarn mode and it passes
successfully.
> Authentication failure when running hbase-spark in local mode
> -
>
> Key: HBASE-28534
> URL: https://issues.apache.org/jira/browse/HBASE-28534
> Project: HBase
> Issue Type: Bug
> Components: spark
>Affects Versions: connector-1.0.0
>Reporter: Junegunn Choi
>Assignee: Junegunn Choi
>Priority: Major
>
> h2. Problem
> When running Spark in local mode, hbase-spark fails to authenticate to a
> Kerberos secured HBase cluster. The error message is:
> {quote}No matching SASL authentication provider and supporting token found
> from providers for user: x...@xxx.xxx (auth:PROXY)
> {quote}
> That is because {{applyCreds}} changes the authentication method of the
> current user to {{{}PROXY{}}}, when it should still be {{KERBEROS}} for local
> mode to run correctly.
> h2. Suggested solution
> To fix this, I propose removing {{{}applyCreds{}}}. The function is no longer
> needed and should be removed:
> 1. Because we should not change the authentication mode of the current user
> in local mode
> 2. And because the purpose of the function is no longer valid. It is not
> doing anything meaningful since the broadcasting of the user credentials was
> removed in this commit:
> [https://github.com/apache/hbase-connectors/commit/75e41365207408f5b47d5925469a49fd60078b5e]
> A pull request is on the way.
> h2. Testing
> The fix was manually tested against Kerberos secured HBase 2.4.17 + Hadoop
> 3.3.5 cluster using Spark 3.5.1, both in local mode and with Yarn master,
> running the following Python code.
> {code:java}
> df = (spark.read.format("org.apache.hadoop.hbase.spark")
> .option("hbase.columns.mapping", "key STRING :key, state
> STRING info:state")
> .option("hbase.table", "hbase:meta").load())
> df.first()
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (HBASE-28534) Authentication failure when running hbase-spark in local mode
[
https://issues.apache.org/jira/browse/HBASE-28534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838673#comment-17838673
]
Nikita Pande edited comment on HBASE-28534 at 4/18/24 2:27 PM:
---
I had kinit done with a user. Then had run spark-shell command and got error
```
No matching SASL authentication provider and supporting token found from
providers for user:
(auth:KERBEROS)
```
NOTE: I didnt get auth:PROXY but it did fail
```
Failed on local exception: java.io.IOException:
org.apache.hadoop.security.AccessControlException: Client cannot authenticate
via:[TOKEN, KERBEROS]
```
When I do not pass "--master local[*]", it picked yarn mode and it passes
successfully.
was (Author: JIRAUSER298527):
I had kinit done with a user. Then had run spark-shell command and got error
`
No matching SASL authentication provider and supporting token found from
providers for user:
(auth:KERBEROS)
NOTE: I didnt get auth:PROXY but it did fail
,,.
Failed on local exception: java.io.IOException:
org.apache.hadoop.security.AccessControlException: Client cannot authenticate
via:[TOKEN, KERBEROS]
`
When I do not pass "--master local[*]", it picked yarn mode and it passes
successfully.
> Authentication failure when running hbase-spark in local mode
> -
>
> Key: HBASE-28534
> URL: https://issues.apache.org/jira/browse/HBASE-28534
> Project: HBase
> Issue Type: Bug
> Components: spark
>Affects Versions: connector-1.0.0
>Reporter: Junegunn Choi
>Assignee: Junegunn Choi
>Priority: Major
>
> h2. Problem
> When running Spark in local mode, hbase-spark fails to authenticate to a
> Kerberos secured HBase cluster. The error message is:
> {quote}No matching SASL authentication provider and supporting token found
> from providers for user: x...@xxx.xxx (auth:PROXY)
> {quote}
> That is because {{applyCreds}} changes the authentication method of the
> current user to {{{}PROXY{}}}, when it should still be {{KERBEROS}} for local
> mode to run correctly.
> h2. Suggested solution
> To fix this, I propose removing {{{}applyCreds{}}}. The function is no longer
> needed and should be removed:
> 1. Because we should not change the authentication mode of the current user
> in local mode
> 2. And because the purpose of the function is no longer valid. It is not
> doing anything meaningful since the broadcasting of the user credentials was
> removed in this commit:
> [https://github.com/apache/hbase-connectors/commit/75e41365207408f5b47d5925469a49fd60078b5e]
> A pull request is on the way.
> h2. Testing
> The fix was manually tested against Kerberos secured HBase 2.4.17 + Hadoop
> 3.3.5 cluster using Spark 3.5.1, both in local mode and with Yarn master,
> running the following Python code.
> {code:java}
> df = (spark.read.format("org.apache.hadoop.hbase.spark")
> .option("hbase.columns.mapping", "key STRING :key, state
> STRING info:state")
> .option("hbase.table", "hbase:meta").load())
> df.first()
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-28534) Authentication failure when running hbase-spark in local mode
[
https://issues.apache.org/jira/browse/HBASE-28534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838673#comment-17838673
]
Nikita Pande commented on HBASE-28534:
--
I had kinit done with a user. Then had run spark-shell command and got error
`
No matching SASL authentication provider and supporting token found from
providers for user:
(auth:KERBEROS)
NOTE: I didnt get auth:PROXY but it did fail
,,.
Failed on local exception: java.io.IOException:
org.apache.hadoop.security.AccessControlException: Client cannot authenticate
via:[TOKEN, KERBEROS]
`
When I do not pass "--master local[*]", it picked yarn mode and it passes
successfully.
> Authentication failure when running hbase-spark in local mode
> -
>
> Key: HBASE-28534
> URL: https://issues.apache.org/jira/browse/HBASE-28534
> Project: HBase
> Issue Type: Bug
> Components: spark
>Affects Versions: connector-1.0.0
>Reporter: Junegunn Choi
>Assignee: Junegunn Choi
>Priority: Major
>
> h2. Problem
> When running Spark in local mode, hbase-spark fails to authenticate to a
> Kerberos secured HBase cluster. The error message is:
> {quote}No matching SASL authentication provider and supporting token found
> from providers for user: x...@xxx.xxx (auth:PROXY)
> {quote}
> That is because {{applyCreds}} changes the authentication method of the
> current user to {{{}PROXY{}}}, when it should still be {{KERBEROS}} for local
> mode to run correctly.
> h2. Suggested solution
> To fix this, I propose removing {{{}applyCreds{}}}. The function is no longer
> needed and should be removed:
> 1. Because we should not change the authentication mode of the current user
> in local mode
> 2. And because the purpose of the function is no longer valid. It is not
> doing anything meaningful since the broadcasting of the user credentials was
> removed in this commit:
> [https://github.com/apache/hbase-connectors/commit/75e41365207408f5b47d5925469a49fd60078b5e]
> A pull request is on the way.
> h2. Testing
> The fix was manually tested against Kerberos secured HBase 2.4.17 + Hadoop
> 3.3.5 cluster using Spark 3.5.1, both in local mode and with Yarn master,
> running the following Python code.
> {code:java}
> df = (spark.read.format("org.apache.hadoop.hbase.spark")
> .option("hbase.columns.mapping", "key STRING :key, state
> STRING info:state")
> .option("hbase.table", "hbase:meta").load())
> df.first()
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (HBASE-28344) Flush/Compaction journal logs are missing from 2.x
[
https://issues.apache.org/jira/browse/HBASE-28344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Prathyusha updated HBASE-28344:
---
Summary: Flush/Compaction journal logs are missing from 2.x (was: Flush
journal logs are missing from 2.x )
> Flush/Compaction journal logs are missing from 2.x
> ---
>
> Key: HBASE-28344
> URL: https://issues.apache.org/jira/browse/HBASE-28344
> Project: HBase
> Issue Type: Improvement
>Reporter: Prathyusha
>Assignee: Prathyusha
>Priority: Minor
>
> After refactoring of TaskMonitor from branch-1
> [ public synchronized MonitoredTask createStatus(String
> description)|https://github.com/apache/hbase/blob/branch-2/hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/TaskMonitor.java#L87]
> to branch-2/master
> public MonitoredTask createStatus(String description){ [return
> createStatus(description,
> false);|https://github.com/apache/hbase/blob/branch-2/hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/TaskMonitor.java#L87]
>
> Flush journal logs are missing.
> While flush, currently we do no set ignore monitor flag as true here
> [MonitoredTask status = TaskMonitor.get().createStatus("Flushing " +
> this);|https://github.com/apache/hbase/blob/branch-2/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java#L2459]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (HBASE-28536) Fix `Disable Stripe Compaction` run error in document
[
https://issues.apache.org/jira/browse/HBASE-28536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Moran reassigned HBASE-28536:
-
Assignee: Moran
> Fix `Disable Stripe Compaction` run error in document
> --
>
> Key: HBASE-28536
> URL: https://issues.apache.org/jira/browse/HBASE-28536
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 2.5.6
>Reporter: Moran
>Assignee: Moran
>Priority: Trivial
> Labels: pull-request-available
>
> *Disable Stripe Compaction* in document is
> {code:java}
> alter 'orders_table', CONFIGURATION =>
> {'hbase.hstore.engine.class' =>
> 'rg.apache.hadoop.hbase.regionserver.DefaultStoreEngine'}{code}
> This should be 'org.apache.hadoop.hbase.regionserver.DefaultStoreEngine'
> This will cause all regions to be in the openning state.Finally, I went
> through the disable table and corrected it before enable it.
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (HBASE-28536) Fix `Disable Stripe Compaction` run error in document
[
https://issues.apache.org/jira/browse/HBASE-28536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HBASE-28536:
---
Labels: pull-request-available (was: )
> Fix `Disable Stripe Compaction` run error in document
> --
>
> Key: HBASE-28536
> URL: https://issues.apache.org/jira/browse/HBASE-28536
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 2.5.6
>Reporter: Moran
>Priority: Trivial
> Labels: pull-request-available
>
> *Disable Stripe Compaction* in document is
> {code:java}
> alter 'orders_table', CONFIGURATION =>
> {'hbase.hstore.engine.class' =>
> 'rg.apache.hadoop.hbase.regionserver.DefaultStoreEngine'}{code}
> This should be 'org.apache.hadoop.hbase.regionserver.DefaultStoreEngine'
> This will cause all regions to be in the openning state.Finally, I went
> through the disable table and corrected it before enable it.
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] HBASE-28536 Fix `Disable Stripe Compaction` run error in document [hbase]
zhaomoran opened a new pull request, #5836:
URL: https://github.com/apache/hbase/pull/5836
Disable Stripe Compaction in document is
```
alter 'orders_table', CONFIGURATION =>
{'hbase.hstore.engine.class' =>
'rg.apache.hadoop.hbase.regionserver.DefaultStoreEngine'}
```
This should be 'org.apache.hadoop.hbase.regionserver.DefaultStoreEngine'
This will cause all regions to be in the openning state.Finally, I went
through the disable table and corrected it before enable it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (HBASE-28536) Fix `Disable Stripe Compaction` run error in document
[
https://issues.apache.org/jira/browse/HBASE-28536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Moran updated HBASE-28536:
--
Description:
*Disable Stripe Compaction* in document is
{code:java}
alter 'orders_table', CONFIGURATION =>
{'hbase.hstore.engine.class' =>
'rg.apache.hadoop.hbase.regionserver.DefaultStoreEngine'}{code}
This should be 'org.apache.hadoop.hbase.regionserver.DefaultStoreEngine'
This will cause all regions to be in the openning state.Finally, I went through
the disable table and corrected it before enable it.
was:
*Disable Stripe Compaction* in document is
{code:java}
alter 'orders_table', CONFIGURATION =>
{'hbase.hstore.engine.class' =>
'rg.apache.hadoop.hbase.regionserver.DefaultStoreEngine'}{code}
This should be 'org.apache.hadoop.hbase.regionserver.DefaultStoreEngine'
> Fix `Disable Stripe Compaction` run error in document
> --
>
> Key: HBASE-28536
> URL: https://issues.apache.org/jira/browse/HBASE-28536
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 2.5.6
>Reporter: Moran
>Priority: Trivial
>
> *Disable Stripe Compaction* in document is
> {code:java}
> alter 'orders_table', CONFIGURATION =>
> {'hbase.hstore.engine.class' =>
> 'rg.apache.hadoop.hbase.regionserver.DefaultStoreEngine'}{code}
> This should be 'org.apache.hadoop.hbase.regionserver.DefaultStoreEngine'
> This will cause all regions to be in the openning state.Finally, I went
> through the disable table and corrected it before enable it.
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (HBASE-28536) Fix `Disable Stripe Compaction` run error in document
Moran created HBASE-28536:
-
Summary: Fix `Disable Stripe Compaction` run error in document
Key: HBASE-28536
URL: https://issues.apache.org/jira/browse/HBASE-28536
Project: HBase
Issue Type: Bug
Components: documentation
Affects Versions: 2.5.6
Reporter: Moran
*Disable Stripe Compaction* in document is
{code:java}
alter 'orders_table', CONFIGURATION =>
{'hbase.hstore.engine.class' =>
'rg.apache.hadoop.hbase.regionserver.DefaultStoreEngine'}{code}
This should be 'org.apache.hadoop.hbase.regionserver.DefaultStoreEngine'
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] HBASE-26974 Introduce a LogRollProcedure [hbase]
frostruan commented on PR #5408: URL: https://github.com/apache/hbase/pull/5408#issuecomment-2063901626 A new commit has been added. Let's wait for the UT result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28468: Integrate the data-tiering logic into cache evictions. [hbase]
Apache-HBase commented on PR #5829: URL: https://github.com/apache/hbase/pull/5829#issuecomment-2063859032 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ HBASE-28463 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 43s | HBASE-28463 passed | | +1 :green_heart: | compile | 4m 48s | HBASE-28463 passed | | +1 :green_heart: | checkstyle | 0m 59s | HBASE-28463 passed | | +1 :green_heart: | spotless | 1m 23s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 46s | HBASE-28463 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 56s | the patch passed | | +1 :green_heart: | compile | 3m 35s | the patch passed | | +1 :green_heart: | javac | 3m 35s | the patch passed | | -0 :warning: | checkstyle | 0m 57s | hbase-server: The patch generated 19 new + 14 unchanged - 0 fixed = 33 total (was 14) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 5m 58s | Patch does not cause any errors with Hadoop 3.3.6. | | -1 :x: | spotless | 0m 53s | patch has 66 errors when running spotless:check, run spotless:apply to fix. | | +1 :green_heart: | spotbugs | 2m 37s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 43m 10s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5829/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5829 | | JIRA Issue | HBASE-28468 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 6ad7ab8b4f22 5.4.0-176-generic #196-Ubuntu SMP Fri Mar 22 16:46:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-28463 / b7bb8b9d27 | | Default Java | Eclipse Adoptium-11.0.17+8 | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5829/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | spotless | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5829/4/artifact/yetus-general-check/output/patch-spotless.txt | | Max. process+thread count | 82 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5829/4/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-28535) Implement a region server level configuration to enable/disable data-tiering
[ https://issues.apache.org/jira/browse/HBASE-28535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Janardhan Hungund updated HBASE-28535: -- Summary: Implement a region server level configuration to enable/disable data-tiering (was: Implement a region server level configuration to disable data-tiering) > Implement a region server level configuration to enable/disable data-tiering > > > Key: HBASE-28535 > URL: https://issues.apache.org/jira/browse/HBASE-28535 > Project: HBase > Issue Type: Task > Components: BucketCache >Reporter: Janardhan Hungund >Priority: Major > > Provide the user with the ability to enable and disable the data tiering > feature. The time-based data tiering is applicable to a specific set of use > cases which write date based records and access to recently written data. > The feature, in general, should be avoided for use cases which are not > dependent on the date-based reads and writes as the code flows which enable > data temperature checks can induce performance regressions. > This Jira is added to track the functionality to optionally enable > region-server wide configuration to disable or enable the feature. > Thanks, > Janardhan -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-28535) Implement a region server level configuration to disable data-tiering
Janardhan Hungund created HBASE-28535: - Summary: Implement a region server level configuration to disable data-tiering Key: HBASE-28535 URL: https://issues.apache.org/jira/browse/HBASE-28535 Project: HBase Issue Type: Task Components: BucketCache Reporter: Janardhan Hungund Provide the user with the ability to enable and disable the data tiering feature. The time-based data tiering is applicable to a specific set of use cases which write date based records and access to recently written data. The feature, in general, should be avoided for use cases which are not dependent on the date-based reads and writes as the code flows which enable data temperature checks can induce performance regressions. This Jira is added to track the functionality to optionally enable region-server wide configuration to disable or enable the feature. Thanks, Janardhan -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28529 Use ZKClientConfig instead of system properties when sett… [hbase]
Apache-HBase commented on PR #5835: URL: https://github.com/apache/hbase/pull/5835#issuecomment-2063749090 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 33s | master passed | | +1 :green_heart: | compile | 1m 43s | master passed | | +1 :green_heart: | shadedjars | 5m 10s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 5s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 26s | the patch passed | | +1 :green_heart: | compile | 1m 47s | the patch passed | | +1 :green_heart: | javac | 1m 47s | the patch passed | | +1 :green_heart: | shadedjars | 5m 6s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 6s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 382m 32s | root in the patch failed. | | | | 411m 53s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5835/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5835 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 025a33f9baf2 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Temurin-1.8.0_352-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5835/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5835/2/testReport/ | | Max. process+thread count | 5149 (vs. ulimit of 3) | | modules | C: hbase-common hbase-client hbase-zookeeper . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5835/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28511 Update hbase-thirdparty to 4.1.7 [hbase]
Apache-HBase commented on PR #5818: URL: https://github.com/apache/hbase/pull/5818#issuecomment-2063718983 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 20s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 43s | master passed | | +1 :green_heart: | compile | 7m 16s | master passed | | +1 :green_heart: | checkstyle | 1m 26s | master passed | | +1 :green_heart: | spotless | 1m 8s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 19m 50s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 38s | the patch passed | | +1 :green_heart: | compile | 7m 4s | the patch passed | | -0 :warning: | javac | 7m 4s | root generated 1 new + 924 unchanged - 1 fixed = 925 total (was 925) | | +1 :green_heart: | checkstyle | 1m 17s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 4s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 7m 4s | Patch does not cause any errors with Hadoop 3.3.6. | | +1 :green_heart: | spotless | 1m 6s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 18m 30s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 55s | The patch does not generate ASF License warnings. | | | | 86m 0s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5818/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5818 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile xml | | uname | Linux 47a242c87534 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / a34b4bc517 | | Default Java | Eclipse Adoptium-11.0.17+8 | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5818/3/artifact/yetus-general-check/output/diff-compile-javac-root.txt | | Max. process+thread count | 177 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-examples . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5818/3/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28529 Use ZKClientConfig instead of system properties when sett… [hbase]
Apache-HBase commented on PR #5835: URL: https://github.com/apache/hbase/pull/5835#issuecomment-2063641735 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 49s | master passed | | +1 :green_heart: | compile | 2m 2s | master passed | | +1 :green_heart: | shadedjars | 5m 13s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 46s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 51s | the patch passed | | +1 :green_heart: | compile | 2m 2s | the patch passed | | +1 :green_heart: | javac | 2m 2s | the patch passed | | +1 :green_heart: | shadedjars | 5m 9s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 46s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 317m 56s | root in the patch failed. | | | | 352m 21s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5835/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5835 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 3321eb0214ca 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Eclipse Adoptium-17.0.10+7 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5835/2/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5835/2/testReport/ | | Max. process+thread count | 7895 (vs. ulimit of 3) | | modules | C: hbase-common hbase-client hbase-zookeeper . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5835/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28529 Use ZKClientConfig instead of system properties when sett… [hbase]
Apache-HBase commented on PR #5835: URL: https://github.com/apache/hbase/pull/5835#issuecomment-2063599277 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 2s | master passed | | +1 :green_heart: | compile | 2m 3s | master passed | | +1 :green_heart: | shadedjars | 5m 17s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 43s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 46s | the patch passed | | +1 :green_heart: | compile | 2m 4s | the patch passed | | +1 :green_heart: | javac | 2m 4s | the patch passed | | +1 :green_heart: | shadedjars | 5m 13s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 40s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 292m 55s | root in the patch failed. | | | | 326m 15s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5835/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5835 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux f9a7ddcb5311 5.4.0-176-generic #196-Ubuntu SMP Fri Mar 22 16:46:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Eclipse Adoptium-11.0.17+8 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5835/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5835/2/testReport/ | | Max. process+thread count | 5480 (vs. ulimit of 3) | | modules | C: hbase-common hbase-client hbase-zookeeper . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5835/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28521 Use standard ConnectionRegistry and Client API to get reg… [hbase]
Apache-HBase commented on PR #5825: URL: https://github.com/apache/hbase/pull/5825#issuecomment-2063585361 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 30s | master passed | | +1 :green_heart: | compile | 3m 5s | master passed | | +1 :green_heart: | checkstyle | 0m 43s | master passed | | +1 :green_heart: | spotless | 0m 54s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 50s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 14s | the patch passed | | +1 :green_heart: | compile | 2m 59s | the patch passed | | +1 :green_heart: | javac | 2m 59s | the patch passed | | +1 :green_heart: | checkstyle | 0m 38s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 5m 38s | Patch does not cause any errors with Hadoop 3.3.6. | | +1 :green_heart: | spotless | 0m 48s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 57s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. | | | | 33m 20s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5825 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 91f1211de048 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 80 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/4/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-28470) Fix Typo in Java Method Comment
[ https://issues.apache.org/jira/browse/HBASE-28470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-28470: -- Fix Version/s: 2.6.0 2.4.18 3.0.0-beta-2 2.5.9 (was: 4.0.0-alpha-1) Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was: Patch Available) Pushed to all active branches. THanks [~voztaka] fo contributing! > Fix Typo in Java Method Comment > --- > > Key: HBASE-28470 > URL: https://issues.apache.org/jira/browse/HBASE-28470 > Project: HBase > Issue Type: Improvement > Components: Admin >Affects Versions: 4.0.0-alpha-1 >Reporter: Hyunduk Choi >Assignee: Hyunduk Choi >Priority: Trivial > Labels: pull-request-available > Fix For: 2.6.0, 2.4.18, 3.0.0-beta-2, 2.5.9 > > Original Estimate: 1h > Remaining Estimate: 1h > > https://github.com/apache/hbase/blob/9adca10e9c106df5119cc067fd610fb19cd1d5ec/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java#L795 > > The java method comment contains a typo. > The comment incorrectly states "Region name to assign" instead of "Region > name to unassign". > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28470 Fix typo in Java method comment [hbase]
Apache9 merged PR #5786: URL: https://github.com/apache/hbase/pull/5786 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (HBASE-28298) HFilePrettyPrinter thrown NoSuchMethodError about MetricRegistry
[
https://issues.apache.org/jira/browse/HBASE-28298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang reassigned HBASE-28298:
-
Assignee: Moran
> HFilePrettyPrinter thrown NoSuchMethodError about MetricRegistry
>
>
> Key: HBASE-28298
> URL: https://issues.apache.org/jira/browse/HBASE-28298
> Project: HBase
> Issue Type: Bug
> Components: HFile, UI
>Affects Versions: 2.5.6
>Reporter: Moran
>Assignee: Moran
>Priority: Major
> Labels: pull-request-available
>
> {{When I view the contents of the HFile through storeFile.jsp or hbase hfile
> -p -v , it will throw an exception similar to the following:}}
>
> {{HTTP ERROR 500 java.lang.NoSuchMethodError: 'com.codahale.metrics.Histogram
> com.codahale.metrics.MetricRegistry.histogram(java.lang.String,
> com.codahale.metrics.MetricRegistry$MetricSupplier)'}}
> ||URI:|/storeFile.jsp|
> ||STATUS:|500|
> ||MESSAGE:|java.lang.NoSuchMethodError: 'com.codahale.metrics.Histogram
> com.codahale.metrics.MetricRegistry.histogram(java.lang.String,
> com.codahale.metrics.MetricRegistry$MetricSupplier)'|
> ||SERVLET:|org.apache.hadoop.hbase.generated.regionserver.storeFile_jsp|
> ||CAUSED BY:|java.lang.NoSuchMethodError: 'com.codahale.metrics.Histogram
> com.codahale.metrics.MetricRegistry.histogram(java.lang.String,
> com.codahale.metrics.MetricRegistry$MetricSupplier)'|
> I found that there were conflicting files in the lib folder, specifically
> metrics-core-3.0.1.jar and metrics-core-3.2.6.jar. After deleting
> metrics-core-3.0.1.jar, the functionality returned to normal.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (HBASE-28298) HFilePrettyPrinter thrown NoSuchMethodError about MetricRegistry
[
https://issues.apache.org/jira/browse/HBASE-28298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang resolved HBASE-28298.
---
Fix Version/s: 2.6.0
2.4.18
2.5.9
Hadoop Flags: Reviewed
Resolution: Fixed
Pushed to all branch-2.x branches.
Thanks [~mrzhao] for contributing!
> HFilePrettyPrinter thrown NoSuchMethodError about MetricRegistry
>
>
> Key: HBASE-28298
> URL: https://issues.apache.org/jira/browse/HBASE-28298
> Project: HBase
> Issue Type: Bug
> Components: HFile, UI
>Affects Versions: 2.5.6
>Reporter: Moran
>Assignee: Moran
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.6.0, 2.4.18, 2.5.9
>
>
> {{When I view the contents of the HFile through storeFile.jsp or hbase hfile
> -p -v , it will throw an exception similar to the following:}}
>
> {{HTTP ERROR 500 java.lang.NoSuchMethodError: 'com.codahale.metrics.Histogram
> com.codahale.metrics.MetricRegistry.histogram(java.lang.String,
> com.codahale.metrics.MetricRegistry$MetricSupplier)'}}
> ||URI:|/storeFile.jsp|
> ||STATUS:|500|
> ||MESSAGE:|java.lang.NoSuchMethodError: 'com.codahale.metrics.Histogram
> com.codahale.metrics.MetricRegistry.histogram(java.lang.String,
> com.codahale.metrics.MetricRegistry$MetricSupplier)'|
> ||SERVLET:|org.apache.hadoop.hbase.generated.regionserver.storeFile_jsp|
> ||CAUSED BY:|java.lang.NoSuchMethodError: 'com.codahale.metrics.Histogram
> com.codahale.metrics.MetricRegistry.histogram(java.lang.String,
> com.codahale.metrics.MetricRegistry$MetricSupplier)'|
> I found that there were conflicting files in the lib folder, specifically
> metrics-core-3.0.1.jar and metrics-core-3.2.6.jar. After deleting
> metrics-core-3.0.1.jar, the functionality returned to normal.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] HBASE-28298 Fix HFilePrettyPrinter thrown NoSuchMethodError about Met… [hbase]
Apache9 merged PR #5783: URL: https://github.com/apache/hbase/pull/5783 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28527: Adjust BlockCacheKey to use the file path instead of file name. [hbase]
wchevreuil commented on code in PR #5832:
URL: https://github.com/apache/hbase/pull/5832#discussion_r1570397180
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##
@@ -682,7 +683,7 @@ public void fileCacheCompleted(Path filePath, long size) {
}
private void updateRegionCachedSize(Path filePath, long cachedSize) {
-if (filePath != null) {
+if (filePath != null && filePath.getParent() != null &&
filePath.getParent().getParent() != null) {
Review Comment:
Is this really possible?
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheKey.java:
##
@@ -39,24 +39,16 @@ public class BlockCacheKey implements HeapSize,
java.io.Serializable {
* @param hfileName The name of the HFile this block belongs to.
* @param offsetOffset of the block into the file
*/
- public BlockCacheKey(String hfileName, long offset) {
-this(hfileName, offset, true, BlockType.DATA);
- }
-
- public BlockCacheKey(String hfileName, long offset, boolean isPrimaryReplica,
-BlockType blockType) {
-this.isPrimaryReplicaBlock = isPrimaryReplica;
-this.hfileName = hfileName;
-this.offset = offset;
-this.blockType = blockType;
+ public BlockCacheKey(Path hfilePath, long offset) {
+this(hfilePath, offset, true, BlockType.DATA);
}
public BlockCacheKey(Path hfilePath, long offset, boolean isPrimaryReplica,
BlockType blockType) {
-this.filePath = hfilePath;
this.isPrimaryReplicaBlock = isPrimaryReplica;
Review Comment:
nit: unneeded change.
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketProtoUtils.java:
##
@@ -130,10 +136,30 @@ static Pair, NavigableSet result = new
ConcurrentHashMap<>();
NavigableSet resultSet = new
ConcurrentSkipListSet<>(Comparator
.comparing(BlockCacheKey::getHfileName).thenComparingLong(BlockCacheKey::getOffset));
+
+Map allFilePaths = null;
+DataTieringManager dataTieringManager;
+try {
+ dataTieringManager = DataTieringManager.getInstance();
+ allFilePaths = dataTieringManager.getAllFilesList();
+} catch (IllegalStateException e) {
+ // Data-Tiering manager has not been set up.
+ // Ignore the error and proceed with the normal flow.
+ LOG.warn("Error while getting DataTieringManager instance: {}",
e.getMessage());
+}
+
for (BucketCacheProtos.BackingMapEntry entry : backingMap.getEntryList()) {
BucketCacheProtos.BlockCacheKey protoKey = entry.getKey();
- BlockCacheKey key = new BlockCacheKey(protoKey.getHfilename(),
protoKey.getOffset(),
-protoKey.getPrimaryReplicaBlock(), fromPb(protoKey.getBlockType()));
+
+ BlockCacheKey key = null;
+ if (allFilePaths != null) {
+key = new BlockCacheKey(allFilePaths.get(protoKey.getHfilename()),
protoKey.getOffset(),
Review Comment:
` allFilePaths.get(protoKey.getHfilename())` may yield a null value, if we
are recovering from a crash where we didn't have a chance to save the
persistent index after a given file may have been removed.
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketProtoUtils.java:
##
@@ -130,10 +136,30 @@ static Pair, NavigableSet result = new
ConcurrentHashMap<>();
NavigableSet resultSet = new
ConcurrentSkipListSet<>(Comparator
.comparing(BlockCacheKey::getHfileName).thenComparingLong(BlockCacheKey::getOffset));
+
+Map allFilePaths = null;
+DataTieringManager dataTieringManager;
+try {
+ dataTieringManager = DataTieringManager.getInstance();
+ allFilePaths = dataTieringManager.getAllFilesList();
+} catch (IllegalStateException e) {
+ // Data-Tiering manager has not been set up.
+ // Ignore the error and proceed with the normal flow.
+ LOG.warn("Error while getting DataTieringManager instance: {}",
e.getMessage());
Review Comment:
Is this going to be thrown whenever data tiering type isn't set to
TIME_RANGE?
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheKey.java:
##
@@ -39,24 +39,16 @@ public class BlockCacheKey implements HeapSize,
java.io.Serializable {
* @param hfileName The name of the HFile this block belongs to.
* @param offsetOffset of the block into the file
*/
- public BlockCacheKey(String hfileName, long offset) {
-this(hfileName, offset, true, BlockType.DATA);
- }
-
- public BlockCacheKey(String hfileName, long offset, boolean isPrimaryReplica,
-BlockType blockType) {
-this.isPrimaryReplicaBlock = isPrimaryReplica;
-this.hfileName = hfileName;
-this.offset = offset;
-this.blockType = blockType;
+ public BlockCacheKey(Path hfilePath, long offset) {
+this(hfilePath, offset, true, BlockType.DATA);
}
Review Comment:
Can we just leave these and avoid having to touch every single existing
test? As having a complete path is
Re: [PR] HBASE-28527: Adjust BlockCacheKey to use the file path instead of file name. [hbase]
jhungund commented on PR #5832: URL: https://github.com/apache/hbase/pull/5832#issuecomment-2063509932 > > The time-based priority eviction policy relies on the presence of path in > > the BlockCacheKey to fetch the required metadata to check data hotness and > > decide whether or not to retain the block in the bucket cache. > > Can you explain why do you need that? This is not a simple/small change. Our design originally relied on the presence of path in the BlockCacheKey so that we parse the path to get to the regionID and column family to reach to the file and access its metadata. (The framework that @vinayakphegde has implemented). The purpose of using the path is slightly avoid the overhead of traversing through the regions and column families and their files, if we rely on the filenames to fetch the corresponding metadata. However, what we found is that path may or may not be always populated by the callers who instantiate BlockCacheKey. Hence, this change enforces the users and also unit tests to always instantiate/create BlockCacheKey using the paths. Hence, this change turned out to be a big change. An alternative to this is another approach that relies only on the file name which is always present in the BlockCacheKey. With this approach, we do not make any changes in the callers of BlockcacheKey or the unit tests. During cacheEvictions (freeSpace), we will require one traversal through all the files. I had tried to implement this approach in another change: https://github.com/apache/hbase/pull/5829 Please take a look and let me know your idea about the same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28527: Adjust BlockCacheKey to use the file path instead of file name. [hbase]
wchevreuil commented on PR #5832: URL: https://github.com/apache/hbase/pull/5832#issuecomment-2063474162 >The time-based priority eviction policy relies on the presence of path in the BlockCacheKey to fetch the required metadata to check data hotness and decide whether or not to retain the block in the bucket cache. Can you explain why do you need that? This is not a simple/small change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-28527) Adjust BlockCacheKey to use the file path instead of file name.
[
https://issues.apache.org/jira/browse/HBASE-28527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838573#comment-17838573
]
Wellington Chevreuil commented on HBASE-28527:
--
{quote}
The time-based priority eviction policy relies on the presence of path in the
BlockCacheKey to fetch the required metadata to check data hotness and decide
whether or not to retain the block in the bucket cache.
{quote}
Please explain why that's needed.
> Adjust BlockCacheKey to use the file path instead of file name.
> ---
>
> Key: HBASE-28527
> URL: https://issues.apache.org/jira/browse/HBASE-28527
> Project: HBase
> Issue Type: Task
> Components: BucketCache
>Reporter: Janardhan Hungund
>Assignee: Janardhan Hungund
>Priority: Major
> Labels: pull-request-available
>
> The time-based priority eviction policy relies on the presence of path in the
> BlockCacheKey to fetch the required metadata to check data hotness and decide
> whether or not to retain the block in the bucket cache.
> Hence, the constructor of BlockCacheKey is adjusted to take the file path as
> the input parameter. The code paths that create the blockCacheKey and also
> the unit tests need to be adjusted to pass the path instead of file name.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] HBASE-28521 Use standard ConnectionRegistry and Client API to get reg… [hbase]
Apache-HBase commented on PR #5825: URL: https://github.com/apache/hbase/pull/5825#issuecomment-2063440306 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 56s | master passed | | +1 :green_heart: | compile | 1m 10s | master passed | | +1 :green_heart: | shadedjars | 7m 0s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 32s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 35s | the patch passed | | +1 :green_heart: | compile | 1m 10s | the patch passed | | +1 :green_heart: | javac | 1m 10s | the patch passed | | +1 :green_heart: | shadedjars | 6m 37s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 29s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 15m 43s | hbase-server in the patch failed. | | | | 42m 34s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5825 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 5ac35581548e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Eclipse Adoptium-11.0.17+8 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/3/testReport/ | | Max. process+thread count | 1828 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/3/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28521 Use standard ConnectionRegistry and Client API to get reg… [hbase]
Apache-HBase commented on PR #5825: URL: https://github.com/apache/hbase/pull/5825#issuecomment-2063439848 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 52s | master passed | | +1 :green_heart: | compile | 0m 55s | master passed | | +1 :green_heart: | shadedjars | 5m 13s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 29s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 52s | the patch passed | | +1 :green_heart: | compile | 0m 55s | the patch passed | | +1 :green_heart: | javac | 0m 55s | the patch passed | | +1 :green_heart: | shadedjars | 5m 10s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 28s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 12m 52s | hbase-server in the patch failed. | | | | 33m 45s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5825 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux c06ea7bdd81f 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Eclipse Adoptium-17.0.10+7 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/3/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/3/testReport/ | | Max. process+thread count | 1670 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/3/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28466 Integration of time-based priority logic of bucket cache in prefetch functionality of HBase [hbase]
wchevreuil commented on code in PR #5808:
URL: https://github.com/apache/hbase/pull/5808#discussion_r1570350364
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePreadReader.java:
##
@@ -37,10 +37,15 @@ public class HFilePreadReader extends HFileReaderImpl {
public HFilePreadReader(ReaderContext context, HFileInfo fileInfo,
CacheConfig cacheConf,
Configuration conf) throws IOException {
super(context, fileInfo, cacheConf, conf);
+
final MutableBoolean shouldCache = new MutableBoolean(true);
+// Initialize HFileInfo object with metadata for caching decisions
+HFileInfo hFileInfoForCaching = new HFileInfo(context, conf);
+hFileInfoForCaching.initMetaAndIndex(this);
Review Comment:
AFAICT, we would just be calling it again in HStoreFile.open, right after we
return from reader creation. I don't like duplicate object or code run
unnecessarily, so maybe we could modify initMetaAndIndex to do its stuff just
if the file info hasn't been initialized yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] HBASE-28521 Use standard ConnectionRegistry and Client API to get reg… [hbase]
Apache-HBase commented on PR #5825: URL: https://github.com/apache/hbase/pull/5825#issuecomment-2063406221 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 31s | master passed | | +1 :green_heart: | compile | 0m 51s | master passed | | +1 :green_heart: | shadedjars | 6m 37s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 34s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 17s | the patch passed | | +1 :green_heart: | compile | 0m 52s | the patch passed | | +1 :green_heart: | javac | 0m 52s | the patch passed | | +1 :green_heart: | shadedjars | 6m 22s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 28s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 14m 24s | hbase-server in the patch failed. | | | | 39m 14s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5825 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 670924cd68e5 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Temurin-1.8.0_352-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/3/testReport/ | | Max. process+thread count | 1840 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/3/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28521 Use standard ConnectionRegistry and Client API to get reg… [hbase]
Apache-HBase commented on PR #5825: URL: https://github.com/apache/hbase/pull/5825#issuecomment-2063389532 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 13s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 7s | master passed | | +1 :green_heart: | compile | 2m 43s | master passed | | +1 :green_heart: | checkstyle | 0m 36s | master passed | | +1 :green_heart: | spotless | 0m 43s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 30s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 49s | the patch passed | | +1 :green_heart: | compile | 2m 31s | the patch passed | | +1 :green_heart: | javac | 2m 31s | the patch passed | | +1 :green_heart: | checkstyle | 0m 33s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 5m 8s | Patch does not cause any errors with Hadoop 3.3.6. | | +1 :green_heart: | spotless | 0m 41s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 10s | The patch does not generate ASF License warnings. | | | | 30m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5825 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux dbbcdb96bbab 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 83 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/3/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-28533) Region split failure due to region quota limit leaves Hmaster's in memory state for the region in SPLITTING after procedure rollback
[
https://issues.apache.org/jira/browse/HBASE-28533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838531#comment-17838531
]
Wellington Chevreuil commented on HBASE-28533:
--
Thanks for reporting this and the detailed troubleshooting explanation. Can you
confirm this also affects the newer releases as well? Also, please let me know
if you plan to work on a fix to this, then we can get the jira assigned to you,
[~droudy].
> Region split failure due to region quota limit leaves Hmaster's in memory
> state for the region in SPLITTING after procedure rollback
>
>
> Key: HBASE-28533
> URL: https://issues.apache.org/jira/browse/HBASE-28533
> Project: HBase
> Issue Type: Bug
> Components: Region Assignment
>Affects Versions: 2.5.8
> Environment: HBase Version 2.5.8,
> r37444de6531b1bdabf2e445c83d0268ab1a6f919, Thu Feb 29 15:37:32 PST 2024
>Reporter: Daniel Roudnitsky
>Priority: Major
>
> When a SplitTableRegionProcedure is run for a region whose namespace is at
> its maximum region quota limit, the split procedure will fail and rollback,
> and Hmaster's in memory RegionStateNode for the region is left in a SPLITTING
> state. Hmaster will then refuse to start any subsequent merge/split/move
> procedures for that region because it believes the region is not OPEN, until
> it is restarted and the in memory record of region states is reset.
> In the first step of the split procedure SPLIT_TABLE_REGION_PREPARE the
> parent region's RegionStateNode state is set to SPLITTING, and the transition
> is not written to the meta table. In the next step
> SPLIT_TABLE_REGION_PRE_OPERATION the region quota check is done,
> QuotaExceededException is thrown and the procedure ends in ROLLEDBACK state
> without reverting the RegionStateNode back to OPEN state. Hmaster is left
> believing the region is in a SPLITTING state according to its in memory
> RegionStates, while the region is still online on the assigned region server
> and according to meta.
> To reproduce in HBase shell:
> {code:java}
> > create_namespace 'test_ns', {'hbase.namespace.quota.maxregions'=> 2}
> > create 'test_ns:test_table', 'f1', {NUMREGIONS => 2, SPLITALGO =>
> > 'UniformSplit'}
> > region_a =
> > region_b =
> > split region_a, 'x'
> # HMaster will report:
> pid=405, state=ROLLEDBACK,
> exception=org.apache.hadoop.hbase.quotas.QuotaExceededException via
> master-split-regions:org.apache.hadoop.hbase.quotas.QuotaExceededException:
> Region split not possible for : as quota limits are exceeded ;
> SplitTableRegionProcedure table=test_ns:test_table, parent=...
> > merge_region region_a, region_b
> ERROR: org.apache.hadoop.hbase.exceptions.MergeRegionException:
> org.apache.hadoop.hbase.client.DoNotRetryRegionException: is not
> OPEN; state=SPLITTING
> > stop_master # trigger hmaster failover
> > merge_region region_a, region_b # merge now succeeds {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-28500) Rest Java client library assumes stateless servers
[
https://issues.apache.org/jira/browse/HBASE-28500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838484#comment-17838484
]
Hudson commented on HBASE-28500:
Results for branch branch-2
[build #1033 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1033/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1033/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1033/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1033/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1033/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Rest Java client library assumes stateless servers
> --
>
> Key: HBASE-28500
> URL: https://issues.apache.org/jira/browse/HBASE-28500
> Project: HBase
> Issue Type: Bug
> Components: REST
>Reporter: Istvan Toth
>Assignee: Istvan Toth
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.6.0, 2.4.18, 4.0.0-alpha-1, 2.7.0, 3.0.0-beta-2, 2.5.9
>
>
> The Rest Java client library accepts a list of rest servers, and does random
> load balancing between them for each request.
> This does not work for scans, which do have state on the rest server instance.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] HBASE-28529 Use ZKClientConfig instead of system properties when sett… [hbase]
Apache-HBase commented on PR #5835: URL: https://github.com/apache/hbase/pull/5835#issuecomment-2063095404 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 15s | master passed | | +1 :green_heart: | compile | 5m 15s | master passed | | +1 :green_heart: | checkstyle | 1m 12s | master passed | | +1 :green_heart: | spotless | 0m 47s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 8m 53s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 59s | the patch passed | | +1 :green_heart: | compile | 5m 6s | the patch passed | | +1 :green_heart: | javac | 5m 7s | root generated 0 new + 924 unchanged - 1 fixed = 924 total (was 925) | | +1 :green_heart: | checkstyle | 1m 8s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 5m 39s | Patch does not cause any errors with Hadoop 3.3.6. | | +1 :green_heart: | spotless | 0m 44s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 9m 27s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 35s | The patch does not generate ASF License warnings. | | | | 53m 53s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5835/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5835 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile xml | | uname | Linux 5d37a43133cd 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 176 (vs. ulimit of 3) | | modules | C: hbase-common hbase-client hbase-zookeeper . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5835/2/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
