[jira] [Commented] (HBASE-9116) Add a view/edit tool for favored node mappings for regions
[ https://issues.apache.org/jira/browse/HBASE-9116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13750997#comment-13750997 ] Devaraj Das commented on HBASE-9116: bq. Why not just call initialize() at the end of the constructor body? The reason being I wanted to keep the construction of the object cheap. The initialization does some IO since it scans the meta, and I wanted to keep this out of the basic constructor... bq. Is it worth RegionPlacementMaintainer extending AbstractHBaseTool? IMHO this is not going to add that much value. Do you mind if I look at this in a follow up. bq. Is this necessary – can you instead separate out case 2 as a second test? -@Test(timeout = 18) +@Test(timeout = 180) Fixed the timeout (that was a good catch). The reason the test is clubbed into one is that the test tries out the various favorednode utilities with a single table that it creates in the beginning. Add a view/edit tool for favored node mappings for regions -- Key: HBASE-9116 URL: https://issues.apache.org/jira/browse/HBASE-9116 Project: HBase Issue Type: Improvement Components: Region Assignment Affects Versions: 0.95.0 Reporter: Devaraj Das Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 9116-1.txt, 9116-2.txt, 9116-2.txt, 9116-2.txt, 9116-3.txt, 9116-4.txt, 9116-5.txt Add a tool that one can run offline to view the favored node mappings for regions, and also fix the mappings if needed. Such a tool exists in the 0.89-fb branch. Will port it over to trunk/0.95. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9116) Add a view/edit tool for favored node mappings for regions
[
https://issues.apache.org/jira/browse/HBASE-9116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13751052#comment-13751052
]
Hadoop QA commented on HBASE-9116:
--
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12600102/9116-6.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/6921//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6921//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6921//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6921//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6921//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6921//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6921//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6921//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6921//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/6921//console
This message is automatically generated.
Add a view/edit tool for favored node mappings for regions
--
Key: HBASE-9116
URL: https://issues.apache.org/jira/browse/HBASE-9116
Project: HBase
Issue Type: Improvement
Components: Region Assignment
Affects Versions: 0.95.0
Reporter: Devaraj Das
Assignee: Devaraj Das
Fix For: 0.96.0
Attachments: 9116-1.txt, 9116-2.txt, 9116-2.txt, 9116-2.txt,
9116-3.txt, 9116-4.txt, 9116-5.txt, 9116-6.txt
Add a tool that one can run offline to view the favored node mappings for
regions, and also fix the mappings if needed. Such a tool exists in the
0.89-fb branch. Will port it over to trunk/0.95.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9116) Add a view/edit tool for favored node mappings for regions
[
https://issues.apache.org/jira/browse/HBASE-9116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13751434#comment-13751434
]
Nick Dimiduk commented on HBASE-9116:
-
Overall +1. Everything below are just nits.
---
bq. IMHO this is not going to add that much value. Do you mind if I look at
this in a follow up.
No problem. I don't thing AbstractHBaseTool is used very often within the
codebase anyway.
bq. Fixed the timeout (that was a good catch). The reason the test is clubbed
into one is that the test tries out the various favorednode utilities with a
single table that it creates in the beginning.
I prefer independent tests to run in isolation of each other when at all
possible. Not a show-stopper for the patch -- I regard tweaking test timeouts
as a kind of code smell.
{noformat}
+ Match
+!--
+ The logic explicitly checks equality of two floating point numbers.
Ignore the warning
+!--
+Class name=org.apache.hadoop.hbase.master.AssignmentVerificationReport/
+Bug pattern=FE_FLOATING_POINT_EQUALITY/
+ /Match
{noformat}
AssignmentVerificationReport has separate logic blocks for floating point if (A
B) else if (A == B) -- I wonder if this will be a future source of bugs.
Add a view/edit tool for favored node mappings for regions
--
Key: HBASE-9116
URL: https://issues.apache.org/jira/browse/HBASE-9116
Project: HBase
Issue Type: Improvement
Components: Region Assignment
Affects Versions: 0.95.0
Reporter: Devaraj Das
Assignee: Devaraj Das
Fix For: 0.96.0
Attachments: 9116-1.txt, 9116-2.txt, 9116-2.txt, 9116-2.txt,
9116-3.txt, 9116-4.txt, 9116-5.txt, 9116-6.txt
Add a tool that one can run offline to view the favored node mappings for
regions, and also fix the mappings if needed. Such a tool exists in the
0.89-fb branch. Will port it over to trunk/0.95.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9116) Add a view/edit tool for favored node mappings for regions
[
https://issues.apache.org/jira/browse/HBASE-9116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13751512#comment-13751512
]
Jimmy Xiang commented on HBASE-9116:
You already defined UpdateFavoredNodesRequest, why not use it? These two calls
may divert later on. It is better to use different message so that it will be
easier to maintain compatibility.
Why does this one take a RegionOpenInfo? At least, it doesn't need the zk node
version right?
{noformat}
+message UpdateFavoredNodesRequest {
+ repeated OpenRegionRequest.RegionOpenInfo updateRegionInfo = 1;
+}
{noformat}
Add a view/edit tool for favored node mappings for regions
--
Key: HBASE-9116
URL: https://issues.apache.org/jira/browse/HBASE-9116
Project: HBase
Issue Type: Improvement
Components: Region Assignment
Affects Versions: 0.95.0
Reporter: Devaraj Das
Assignee: Devaraj Das
Fix For: 0.96.0
Attachments: 9116-1.txt, 9116-2.txt, 9116-2.txt, 9116-2.txt,
9116-3.txt, 9116-4.txt, 9116-5.txt, 9116-6.txt
Add a tool that one can run offline to view the favored node mappings for
regions, and also fix the mappings if needed. Such a tool exists in the
0.89-fb branch. Will port it over to trunk/0.95.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9116) Add a view/edit tool for favored node mappings for regions
[ https://issues.apache.org/jira/browse/HBASE-9116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13751515#comment-13751515 ] Devaraj Das commented on HBASE-9116: Thanks, Nick. bq. I regard tweaking test timeouts as a kind of code smell. I had increased the timeout so I could debug various things from within eclipse without the test timing out on me. The timeout annotation in the new patch is 3 minutes (which is what it was set to earlier) but I could actually remove that timeout annotation altogether on commit. The test runs in less than 2 minutes consistently.. bq. AssignmentVerificationReport has separate logic blocks for floating point if (A B) else if (A == B) – I wonder if this will be a future source of bugs. I inspected that part some. The logic for reporting the max/min dispersion is built around the check for equality. This is used only for reporting purposes and we can tune this later if needed. Add a view/edit tool for favored node mappings for regions -- Key: HBASE-9116 URL: https://issues.apache.org/jira/browse/HBASE-9116 Project: HBase Issue Type: Improvement Components: Region Assignment Affects Versions: 0.95.0 Reporter: Devaraj Das Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 9116-1.txt, 9116-2.txt, 9116-2.txt, 9116-2.txt, 9116-3.txt, 9116-4.txt, 9116-5.txt, 9116-6.txt Add a tool that one can run offline to view the favored node mappings for regions, and also fix the mappings if needed. Such a tool exists in the 0.89-fb branch. Will port it over to trunk/0.95. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9116) Add a view/edit tool for favored node mappings for regions
[ https://issues.apache.org/jira/browse/HBASE-9116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13751539#comment-13751539 ] Devaraj Das commented on HBASE-9116: bq. You already defined UpdateFavoredNodesRequest, why not use it? Hmm. I had defined it and not used it... I will do the needful for using UpdateFavoredNodesRequest in my next patch... Add a view/edit tool for favored node mappings for regions -- Key: HBASE-9116 URL: https://issues.apache.org/jira/browse/HBASE-9116 Project: HBase Issue Type: Improvement Components: Region Assignment Affects Versions: 0.95.0 Reporter: Devaraj Das Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 9116-1.txt, 9116-2.txt, 9116-2.txt, 9116-2.txt, 9116-3.txt, 9116-4.txt, 9116-5.txt, 9116-6.txt Add a tool that one can run offline to view the favored node mappings for regions, and also fix the mappings if needed. Such a tool exists in the 0.89-fb branch. Will port it over to trunk/0.95. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9116) Add a view/edit tool for favored node mappings for regions
[ https://issues.apache.org/jira/browse/HBASE-9116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13751698#comment-13751698 ] Jimmy Xiang commented on HBASE-9116: +1. Looks good to me. Add a view/edit tool for favored node mappings for regions -- Key: HBASE-9116 URL: https://issues.apache.org/jira/browse/HBASE-9116 Project: HBase Issue Type: Improvement Components: Region Assignment Affects Versions: 0.95.0 Reporter: Devaraj Das Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 9116-1.txt, 9116-2.txt, 9116-2.txt, 9116-2.txt, 9116-3.txt, 9116-4.txt, 9116-5.txt, 9116-6.txt, 9116-7.txt Add a tool that one can run offline to view the favored node mappings for regions, and also fix the mappings if needed. Such a tool exists in the 0.89-fb branch. Will port it over to trunk/0.95. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9116) Add a view/edit tool for favored node mappings for regions
[
https://issues.apache.org/jira/browse/HBASE-9116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13751758#comment-13751758
]
Hadoop QA commented on HBASE-9116:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12600232/9116-7.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/6938//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6938//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6938//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6938//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6938//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6938//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6938//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6938//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6938//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/6938//console
This message is automatically generated.
Add a view/edit tool for favored node mappings for regions
--
Key: HBASE-9116
URL: https://issues.apache.org/jira/browse/HBASE-9116
Project: HBase
Issue Type: Improvement
Components: Region Assignment
Affects Versions: 0.95.0
Reporter: Devaraj Das
Assignee: Devaraj Das
Fix For: 0.96.0
Attachments: 9116-1.txt, 9116-2.txt, 9116-2.txt, 9116-2.txt,
9116-3.txt, 9116-4.txt, 9116-5.txt, 9116-6.txt, 9116-7.txt
Add a tool that one can run offline to view the favored node mappings for
regions, and also fix the mappings if needed. Such a tool exists in the
0.89-fb branch. Will port it over to trunk/0.95.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9116) Add a view/edit tool for favored node mappings for regions
[ https://issues.apache.org/jira/browse/HBASE-9116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13751992#comment-13751992 ] Hudson commented on HBASE-9116: --- FAILURE: Integrated in hbase-0.95 #499 (See [https://builds.apache.org/job/hbase-0.95/499/]) HBASE-9116. Continuation of the commit. Doing 'svn delete' of a file missed earlier. (ddas: rev 1518022) * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/FavoredNodes.java HBASE-9116. Adds a view/edit tool for favored nodes mapping. Also implements the FavoredNodeLoadBalancer.balanceCluster method. (ddas: rev 1518019) * /hbase/branches/0.95/dev-support/findbugs-exclude.xml * /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java * /hbase/branches/0.95/hbase-common/src/main/resources/hbase-default.xml * /hbase/branches/0.95/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java * /hbase/branches/0.95/hbase-protocol/src/main/protobuf/Admin.proto * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentVerificationReport.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionPlacementMaintainer.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/SnapshotOfRegionAssignmentFromMeta.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/FavoredNodeAssignmentHelper.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/FavoredNodeLoadBalancer.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/FavoredNodesPlan.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSRegionScanner.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/util/MunkresAssignment.java * /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java * /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionPlacement.java Add a view/edit tool for favored node mappings for regions -- Key: HBASE-9116 URL: https://issues.apache.org/jira/browse/HBASE-9116 Project: HBase Issue Type: Improvement Components: Region Assignment Affects Versions: 0.95.0 Reporter: Devaraj Das Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 9116-0.95.txt, 9116-1.txt, 9116-2.txt, 9116-2.txt, 9116-2.txt, 9116-3.txt, 9116-4.txt, 9116-5.txt, 9116-6.txt, 9116-7.txt, 9116-trunk.txt Add a tool that one can run offline to view the favored node mappings for regions, and also fix the mappings if needed. Such a tool exists in the 0.89-fb branch. Will port it over to trunk/0.95. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9116) Add a view/edit tool for favored node mappings for regions
[ https://issues.apache.org/jira/browse/HBASE-9116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13752012#comment-13752012 ] Hudson commented on HBASE-9116: --- SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #699 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/699/]) HBASE-9116. Continuation of the commit. Doing 'svn delete' of a file missed earlier. (ddas: rev 1518021) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/FavoredNodes.java HBASE-9116. Adds a view/edit tool for favored nodes mapping. Also implements the FavoredNodeLoadBalancer.balanceCluster method. (ddas: rev 1518016) * /hbase/trunk/dev-support/findbugs-exclude.xml * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java * /hbase/trunk/hbase-common/src/main/resources/hbase-default.xml * /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java * /hbase/trunk/hbase-protocol/src/main/protobuf/Admin.proto * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentVerificationReport.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionPlacementMaintainer.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/SnapshotOfRegionAssignmentFromMeta.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/FavoredNodeAssignmentHelper.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/FavoredNodeLoadBalancer.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/FavoredNodesPlan.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSRegionScanner.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/MunkresAssignment.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionPlacement.java Add a view/edit tool for favored node mappings for regions -- Key: HBASE-9116 URL: https://issues.apache.org/jira/browse/HBASE-9116 Project: HBase Issue Type: Improvement Components: Region Assignment Affects Versions: 0.95.0 Reporter: Devaraj Das Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 9116-0.95.txt, 9116-1.txt, 9116-2.txt, 9116-2.txt, 9116-2.txt, 9116-3.txt, 9116-4.txt, 9116-5.txt, 9116-6.txt, 9116-7.txt, 9116-trunk.txt Add a tool that one can run offline to view the favored node mappings for regions, and also fix the mappings if needed. Such a tool exists in the 0.89-fb branch. Will port it over to trunk/0.95. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9116) Add a view/edit tool for favored node mappings for regions
[ https://issues.apache.org/jira/browse/HBASE-9116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13752020#comment-13752020 ] Hudson commented on HBASE-9116: --- FAILURE: Integrated in hbase-0.95-on-hadoop2 #275 (See [https://builds.apache.org/job/hbase-0.95-on-hadoop2/275/]) HBASE-9116. Continuation of the commit. Doing 'svn delete' of a file missed earlier. (ddas: rev 1518022) * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/FavoredNodes.java HBASE-9116. Adds a view/edit tool for favored nodes mapping. Also implements the FavoredNodeLoadBalancer.balanceCluster method. (ddas: rev 1518019) * /hbase/branches/0.95/dev-support/findbugs-exclude.xml * /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java * /hbase/branches/0.95/hbase-common/src/main/resources/hbase-default.xml * /hbase/branches/0.95/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java * /hbase/branches/0.95/hbase-protocol/src/main/protobuf/Admin.proto * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentVerificationReport.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionPlacementMaintainer.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/SnapshotOfRegionAssignmentFromMeta.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/FavoredNodeAssignmentHelper.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/FavoredNodeLoadBalancer.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/FavoredNodesPlan.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSRegionScanner.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/util/MunkresAssignment.java * /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java * /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionPlacement.java Add a view/edit tool for favored node mappings for regions -- Key: HBASE-9116 URL: https://issues.apache.org/jira/browse/HBASE-9116 Project: HBase Issue Type: Improvement Components: Region Assignment Affects Versions: 0.95.0 Reporter: Devaraj Das Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 9116-0.95.txt, 9116-1.txt, 9116-2.txt, 9116-2.txt, 9116-2.txt, 9116-3.txt, 9116-4.txt, 9116-5.txt, 9116-6.txt, 9116-7.txt, 9116-trunk.txt Add a tool that one can run offline to view the favored node mappings for regions, and also fix the mappings if needed. Such a tool exists in the 0.89-fb branch. Will port it over to trunk/0.95. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9116) Add a view/edit tool for favored node mappings for regions
[ https://issues.apache.org/jira/browse/HBASE-9116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13752029#comment-13752029 ] Hudson commented on HBASE-9116: --- FAILURE: Integrated in HBase-TRUNK #4440 (See [https://builds.apache.org/job/HBase-TRUNK/4440/]) HBASE-9116. Continuation of the commit. Doing 'svn delete' of a file missed earlier. (ddas: rev 1518021) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/FavoredNodes.java HBASE-9116. Adds a view/edit tool for favored nodes mapping. Also implements the FavoredNodeLoadBalancer.balanceCluster method. (ddas: rev 1518016) * /hbase/trunk/dev-support/findbugs-exclude.xml * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java * /hbase/trunk/hbase-common/src/main/resources/hbase-default.xml * /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java * /hbase/trunk/hbase-protocol/src/main/protobuf/Admin.proto * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentVerificationReport.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionPlacementMaintainer.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/SnapshotOfRegionAssignmentFromMeta.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/FavoredNodeAssignmentHelper.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/FavoredNodeLoadBalancer.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/FavoredNodesPlan.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSRegionScanner.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/MunkresAssignment.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionPlacement.java Add a view/edit tool for favored node mappings for regions -- Key: HBASE-9116 URL: https://issues.apache.org/jira/browse/HBASE-9116 Project: HBase Issue Type: Improvement Components: Region Assignment Affects Versions: 0.95.0 Reporter: Devaraj Das Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 9116-0.95.txt, 9116-1.txt, 9116-2.txt, 9116-2.txt, 9116-2.txt, 9116-3.txt, 9116-4.txt, 9116-5.txt, 9116-6.txt, 9116-7.txt, 9116-trunk.txt Add a tool that one can run offline to view the favored node mappings for regions, and also fix the mappings if needed. Such a tool exists in the 0.89-fb branch. Will port it over to trunk/0.95. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9116) Add a view/edit tool for favored node mappings for regions
[ https://issues.apache.org/jira/browse/HBASE-9116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13750339#comment-13750339 ] Ted Yu commented on HBASE-9116: --- lgtm Add a view/edit tool for favored node mappings for regions -- Key: HBASE-9116 URL: https://issues.apache.org/jira/browse/HBASE-9116 Project: HBase Issue Type: Improvement Components: Region Assignment Affects Versions: 0.95.0 Reporter: Devaraj Das Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 9116-1.txt, 9116-2.txt, 9116-2.txt, 9116-2.txt, 9116-3.txt, 9116-4.txt Add a tool that one can run offline to view the favored node mappings for regions, and also fix the mappings if needed. Such a tool exists in the 0.89-fb branch. Will port it over to trunk/0.95. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9116) Add a view/edit tool for favored node mappings for regions
[
https://issues.apache.org/jira/browse/HBASE-9116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13750343#comment-13750343
]
Jimmy Xiang commented on HBASE-9116:
Why updateFavoredNodes takes an OpenRegionRequest?
{noformat}
+ public UpdateFavoredNodesResponse updateFavoredNodes(RpcController
controller,
+ OpenRegionRequest request) throws ServiceException {
{noformat}
Add a view/edit tool for favored node mappings for regions
--
Key: HBASE-9116
URL: https://issues.apache.org/jira/browse/HBASE-9116
Project: HBase
Issue Type: Improvement
Components: Region Assignment
Affects Versions: 0.95.0
Reporter: Devaraj Das
Assignee: Devaraj Das
Fix For: 0.96.0
Attachments: 9116-1.txt, 9116-2.txt, 9116-2.txt, 9116-2.txt,
9116-3.txt, 9116-4.txt
Add a tool that one can run offline to view the favored node mappings for
regions, and also fix the mappings if needed. Such a tool exists in the
0.89-fb branch. Will port it over to trunk/0.95.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9116) Add a view/edit tool for favored node mappings for regions
[ https://issues.apache.org/jira/browse/HBASE-9116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13750353#comment-13750353 ] Jimmy Xiang commented on HBASE-9116: Is the hbase-site.xml change intentional? Add a view/edit tool for favored node mappings for regions -- Key: HBASE-9116 URL: https://issues.apache.org/jira/browse/HBASE-9116 Project: HBase Issue Type: Improvement Components: Region Assignment Affects Versions: 0.95.0 Reporter: Devaraj Das Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 9116-1.txt, 9116-2.txt, 9116-2.txt, 9116-2.txt, 9116-3.txt, 9116-4.txt Add a tool that one can run offline to view the favored node mappings for regions, and also fix the mappings if needed. Such a tool exists in the 0.89-fb branch. Will port it over to trunk/0.95. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9116) Add a view/edit tool for favored node mappings for regions
[
https://issues.apache.org/jira/browse/HBASE-9116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13750392#comment-13750392
]
Jimmy Xiang commented on HBASE-9116:
Can we create a similar putsToMetaTable method which takes a conf in
MetaEditor? We need to handle exceptions and close the table at the end.
{noformat}
-MetaEditor.putsToMetaTable(catalogTracker, puts);
+// Write the region assignments to the meta table.
+HTable metaTable = new HTable(conf, TableName.META_TABLE_NAME);
+metaTable.put(puts);
{noformat}
Add a view/edit tool for favored node mappings for regions
--
Key: HBASE-9116
URL: https://issues.apache.org/jira/browse/HBASE-9116
Project: HBase
Issue Type: Improvement
Components: Region Assignment
Affects Versions: 0.95.0
Reporter: Devaraj Das
Assignee: Devaraj Das
Fix For: 0.96.0
Attachments: 9116-1.txt, 9116-2.txt, 9116-2.txt, 9116-2.txt,
9116-3.txt, 9116-4.txt
Add a tool that one can run offline to view the favored node mappings for
regions, and also fix the mappings if needed. Such a tool exists in the
0.89-fb branch. Will port it over to trunk/0.95.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9116) Add a view/edit tool for favored node mappings for regions
[
https://issues.apache.org/jira/browse/HBASE-9116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13750414#comment-13750414
]
Jimmy Xiang commented on HBASE-9116:
I see several places warning is logged like this:
{noformat}
+LOG.warn(Cannot place the favored nodes for region
++ regionInfo.getRegionNameAsString() + because + e);
{noformat}
Perhaps, it is better to log the stack trace as well:
{noformat}
+LOG.warn(Cannot place the favored nodes for region
++ regionInfo.getRegionNameAsString() + because + e, e);
{noformat}
Some function may not throw exception declared, for example,
FavoredNodeAssignmentHelper#placeSecondaryAndTertiaryWithRestrictions doesn't
throw IOException.
Good stuff. Is this still WIP? How can we use this? Edit the meta table from
hbase shell?
Add a view/edit tool for favored node mappings for regions
--
Key: HBASE-9116
URL: https://issues.apache.org/jira/browse/HBASE-9116
Project: HBase
Issue Type: Improvement
Components: Region Assignment
Affects Versions: 0.95.0
Reporter: Devaraj Das
Assignee: Devaraj Das
Fix For: 0.96.0
Attachments: 9116-1.txt, 9116-2.txt, 9116-2.txt, 9116-2.txt,
9116-3.txt, 9116-4.txt
Add a tool that one can run offline to view the favored node mappings for
regions, and also fix the mappings if needed. Such a tool exists in the
0.89-fb branch. Will port it over to trunk/0.95.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9116) Add a view/edit tool for favored node mappings for regions
[
https://issues.apache.org/jira/browse/HBASE-9116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13750916#comment-13750916
]
Nick Dimiduk commented on HBASE-9116:
-
Is there a reason for SnapshotOfRegionAssignmentFromMeta to separate
construction from initialization? Why not just call initialize() at the end of
the constructor body?
Is it worth RegionPlacementMaintainer extending AbstractHBaseTool?
Is this necessary -- can you instead separate out case 2 as a second test?
{noformat}
- @Test(timeout = 18)
+ @Test(timeout = 180)
public void testRegionPlacement() throws Exception {
{noformat}
FYI, it looks like this patch has some noise in it:
{noformat}
$ git apply 9116-5.txt
9116-5.txt:31: trailing whitespace.
java.util.Listorg.apache.hadoop.hbase.protobuf.generated.AdminProtos.OpenRegionRequest.RegionOpenInfo
9116-5.txt:44: trailing whitespace.
java.util.List? extends
org.apache.hadoop.hbase.protobuf.generated.AdminProtos.OpenRegionRequest.RegionOpenInfoOrBuilder
9116-5.txt:165: trailing whitespace.
public java.util.List? extends
org.apache.hadoop.hbase.protobuf.generated.AdminProtos.OpenRegionRequest.RegionOpenInfoOrBuilder
9116-5.txt:453: trailing whitespace.
updateRegionInfoBuilder_ =
9116-5.txt:468: trailing whitespace.
warning: squelched 15 whitespace errors
warning: 20 lines add whitespace errors.
{noformat}
Add a view/edit tool for favored node mappings for regions
--
Key: HBASE-9116
URL: https://issues.apache.org/jira/browse/HBASE-9116
Project: HBase
Issue Type: Improvement
Components: Region Assignment
Affects Versions: 0.95.0
Reporter: Devaraj Das
Assignee: Devaraj Das
Fix For: 0.96.0
Attachments: 9116-1.txt, 9116-2.txt, 9116-2.txt, 9116-2.txt,
9116-3.txt, 9116-4.txt, 9116-5.txt
Add a tool that one can run offline to view the favored node mappings for
regions, and also fix the mappings if needed. Such a tool exists in the
0.89-fb branch. Will port it over to trunk/0.95.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9116) Add a view/edit tool for favored node mappings for regions
[
https://issues.apache.org/jira/browse/HBASE-9116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13750922#comment-13750922
]
Hadoop QA commented on HBASE-9116:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12600075/9116-5.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 4 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/6914//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6914//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6914//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6914//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6914//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6914//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6914//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6914//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6914//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/6914//console
This message is automatically generated.
Add a view/edit tool for favored node mappings for regions
--
Key: HBASE-9116
URL: https://issues.apache.org/jira/browse/HBASE-9116
Project: HBase
Issue Type: Improvement
Components: Region Assignment
Affects Versions: 0.95.0
Reporter: Devaraj Das
Assignee: Devaraj Das
Fix For: 0.96.0
Attachments: 9116-1.txt, 9116-2.txt, 9116-2.txt, 9116-2.txt,
9116-3.txt, 9116-4.txt, 9116-5.txt
Add a tool that one can run offline to view the favored node mappings for
regions, and also fix the mappings if needed. Such a tool exists in the
0.89-fb branch. Will port it over to trunk/0.95.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9116) Add a view/edit tool for favored node mappings for regions
[
https://issues.apache.org/jira/browse/HBASE-9116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13749600#comment-13749600
]
Hadoop QA commented on HBASE-9116:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12599715/9116-3.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 4 new
Findbugs (version 1.3.9) warnings.
{color:red}-1 release audit{color}. The applied patch generated 2 release
audit warnings (more than the trunk's current 0 warnings).
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/6871//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6871//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6871//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6871//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6871//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6871//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6871//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6871//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6871//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6871//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/6871//console
This message is automatically generated.
Add a view/edit tool for favored node mappings for regions
--
Key: HBASE-9116
URL: https://issues.apache.org/jira/browse/HBASE-9116
Project: HBase
Issue Type: Improvement
Components: Region Assignment
Affects Versions: 0.95.0
Reporter: Devaraj Das
Assignee: Devaraj Das
Fix For: 0.96.0
Attachments: 9116-1.txt, 9116-2.txt, 9116-2.txt, 9116-2.txt,
9116-3.txt
Add a tool that one can run offline to view the favored node mappings for
regions, and also fix the mappings if needed. Such a tool exists in the
0.89-fb branch. Will port it over to trunk/0.95.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9116) Add a view/edit tool for favored node mappings for regions
[ https://issues.apache.org/jira/browse/HBASE-9116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13749336#comment-13749336 ] Nicolas Liochon commented on HBASE-9116: I haven't run the tool, just read the code. Seems ok, some nits: bq. long startTime = System.currentTimeMillis(); Please use EnvironmentEdge bq. * Copyright 2011 The Apache Software Foundation No date anymore on licenses bq.// TODO Auto-generated method stub Should be removed if we're fine with the standard generation Add a view/edit tool for favored node mappings for regions -- Key: HBASE-9116 URL: https://issues.apache.org/jira/browse/HBASE-9116 Project: HBase Issue Type: Improvement Components: Region Assignment Affects Versions: 0.95.0 Reporter: Devaraj Das Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 9116-1.txt, 9116-2.txt, 9116-2.txt, 9116-2.txt, 9116-3.txt Add a tool that one can run offline to view the favored node mappings for regions, and also fix the mappings if needed. Such a tool exists in the 0.89-fb branch. Will port it over to trunk/0.95. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9116) Add a view/edit tool for favored node mappings for regions
[
https://issues.apache.org/jira/browse/HBASE-9116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13748679#comment-13748679
]
Hadoop QA commented on HBASE-9116:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12599628/9116-2.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 3
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 11 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildBase
org.apache.hadoop.hbase.master.TestAssignmentManager
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.hadoop.hbase.master.TestMasterNoCluster.testNotPullingDeadRegionServerFromZK(TestMasterNoCluster.java:411)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/6858//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6858//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6858//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6858//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6858//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6858//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6858//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6858//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6858//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/6858//console
This message is automatically generated.
Add a view/edit tool for favored node mappings for regions
--
Key: HBASE-9116
URL: https://issues.apache.org/jira/browse/HBASE-9116
Project: HBase
Issue Type: Improvement
Components: Region Assignment
Affects Versions: 0.95.0
Reporter: Devaraj Das
Assignee: Devaraj Das
Fix For: 0.96.0
Attachments: 9116-1.txt, 9116-2.txt, 9116-2.txt, 9116-2.txt
Add a tool that one can run offline to view the favored node mappings for
regions, and also fix the mappings if needed. Such a tool exists in the
0.89-fb branch. Will port it over to trunk/0.95.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9116) Add a view/edit tool for favored node mappings for regions
[
https://issues.apache.org/jira/browse/HBASE-9116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13749131#comment-13749131
]
Ted Yu commented on HBASE-9116:
---
{code}
+for (ServerName sn: serverMgr.getOnlineServersList()) {
+ serverNameToServerNameWithoutCode.put(sn,
+ new ServerName(sn.getHostname(), sn.getPort(),
ServerName.NON_STARTCODE));
+ serverNameWithoutCodeToServerName.put(
+ new ServerName(sn.getHostname(), sn.getPort(),
ServerName.NON_STARTCODE), sn);
+}
{code}
ServerName for (sn.getHostname(), sn.getPort(), ServerName.NON_STARTCODE) can
be created first, avoiding an extra instantiation.
{code}
+ListServerName favoredNodes =
globalFavoredNodesAssignmentPlan.getFavoredNodes(region);
+if (favoredNodes.get(0).equals(currentServerWithoutStartCode)) {
{code}
Is it possible that favoredNodes is null ?
Add a view/edit tool for favored node mappings for regions
--
Key: HBASE-9116
URL: https://issues.apache.org/jira/browse/HBASE-9116
Project: HBase
Issue Type: Improvement
Components: Region Assignment
Affects Versions: 0.95.0
Reporter: Devaraj Das
Assignee: Devaraj Das
Fix For: 0.96.0
Attachments: 9116-1.txt, 9116-2.txt, 9116-2.txt, 9116-2.txt,
9116-3.txt
Add a tool that one can run offline to view the favored node mappings for
regions, and also fix the mappings if needed. Such a tool exists in the
0.89-fb branch. Will port it over to trunk/0.95.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9116) Add a view/edit tool for favored node mappings for regions
[
https://issues.apache.org/jira/browse/HBASE-9116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13744350#comment-13744350
]
Nick Dimiduk commented on HBASE-9116:
-
This looks like it needs rebased onto trunk.
The posted patch includes generated code ({{AdminProtos.java}}), please remove.
Please add javadoc for the new classes and new public methods on existing
classes.
{{FavoredNodeAssignmentHelper#placeSecondaryAndTertiaryWithRestrictions}}
introduces a {{while(true)}} block containing non-trivial branching logic. Can
this be refactored with simpler and/or clearer break conditions?
{{FSUtils}} introduces new configuration
{{hbase.client.localityCheck.threadPoolSize}}. Can this be added to
{{HConstants}} and/or documented in {{hbase-defaults.xml}}?
Add a view/edit tool for favored node mappings for regions
--
Key: HBASE-9116
URL: https://issues.apache.org/jira/browse/HBASE-9116
Project: HBase
Issue Type: Improvement
Components: Region Assignment
Affects Versions: 0.95.0
Reporter: Devaraj Das
Assignee: Devaraj Das
Attachments: 9116-1.txt
Add a tool that one can run offline to view the favored node mappings for
regions, and also fix the mappings if needed. Such a tool exists in the
0.89-fb branch. Will port it over to trunk/0.95.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9116) Add a view/edit tool for favored node mappings for regions
[
https://issues.apache.org/jira/browse/HBASE-9116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13730882#comment-13730882
]
Ted Yu commented on HBASE-9116:
---
Useful tool :-)
{code}
+ListFloat dispersion = report.getDispersionInformation();
+if (simplePrint) {
+ DecimalFormat df = new java.text.DecimalFormat(#.##);
+ System.out.println(\tAvg dispersion score:
+ + df.format(dispersion.get(0)) + hosts;\tMax dispersion score:
{code}
It would be easier to maintain the code if index to dispersions has
corresponding enum.
For FSRegionScanner :
{code}
+ * Maps region encoded names to maps of hostnames to fractional locality of
+ * that region on that host.
+ */
+ private MapString, MapString, Float regionDegreeLocalityMapping;
{code}
Should ServerName be used as key for the inner Map above ?
{code}
+// not part of a table?
+if (parent.getName().startsWith(.)
+ !parent.getName().equals(.META.)) {
{code}
The above would need adjustment once namespace patch goes in.
RegionPlacementMaintainer.java needs license
{code}
+ * @param newPlanMap - new AssignmentPlan
+ * @return how many primaries will move per table
+ */
+ public MapString, Integer getRegionsMovement(FavoredNodes newPlan)
{code}
Parameter and its javadoc don't seem to match.
Add a view/edit tool for favored node mappings for regions
--
Key: HBASE-9116
URL: https://issues.apache.org/jira/browse/HBASE-9116
Project: HBase
Issue Type: Improvement
Components: Region Assignment
Affects Versions: 0.95.0
Reporter: Devaraj Das
Assignee: Devaraj Das
Attachments: 9116-1.txt
Add a tool that one can run offline to view the favored node mappings for
regions, and also fix the mappings if needed. Such a tool exists in the
0.89-fb branch. Will port it over to trunk/0.95.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
